From patchwork Wed May 13 02:09:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 11544523 X-Patchwork-Delegate: marcel@holtmann.org Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E00A490 for ; Wed, 13 May 2020 02:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6CF1206CC for ; Wed, 13 May 2020 02:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gK3dvzuS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbgEMCJv (ORCPT ); Tue, 12 May 2020 22:09:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728515AbgEMCJo (ORCPT ); Tue, 12 May 2020 22:09:44 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1F8C061A0C for ; Tue, 12 May 2020 19:09:42 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id f15so6208791plr.3 for ; Tue, 12 May 2020 19:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zcD9lBfIOsrbGLPLwHavFpU04q9rS7x1jNQUtnqQyIk=; b=gK3dvzuSyDVkWgPlzx40qbLhAs0owj9fIDJoyReMIZDN7XH+poriF7uHhlAQ+w+Fef DfYQXms3qL1YXiyZFcegyl/miVUznOD7rrVn1aG88QwK6QTyvVR2rQ9JGnEXNfUDGcCG FsW+Xj94YC0MRj70Y4eNIEyKrmXxmy0uYMqWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zcD9lBfIOsrbGLPLwHavFpU04q9rS7x1jNQUtnqQyIk=; b=OWMw6mTNO2fGkZSRxeaNVXlJKLZHY1HKeXwJQcz9SO8tnxtFFixECty2g2+xIxYQ7q 5BkE1Ve/btw9DFukN6WTuGbhKaHMztFJYvXbcQb+pLBLc/8BJ2fKszqqAYS/Li9Ia9Wj V4Bm9ShWbSO8mItwvJ0P676QgCyexldn2n9io4LRdBsSz2J/hgpUOZs7Xr+dZUS+N8Bg fSb6dHmIxaPOPk21Ca4qVaV+nYQsTQIJQ9gcSvu20nEKjG433wGyHE1r+VBlwvaEOSMs dqC5xp6T9tlWJiAaoRzYyiNDdxAyXfGpPzCib5WTuVOzTrXIrVw/6bnzwSs8oIADkXKO rQPg== X-Gm-Message-State: AGi0PuZlNJLQCYCO2pzDYLUdUF1SSpi2kA5cIji3D8mUmElXd9ggy2xa Rmg29be3FXjxwaRBQ5Dc0yIdNA== X-Google-Smtp-Source: APiQypKUVISxkbjbdV4dsOfusvVUfRQZvsmwFin9ROrdrs/K1iU7S4CxumWbbsgAW44gvZn353OnYg== X-Received: by 2002:a17:90b:2388:: with SMTP id mr8mr30064911pjb.97.1589335782204; Tue, 12 May 2020 19:09:42 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id x7sm13456749pfj.122.2020.05.12.19.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 19:09:41 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org Cc: chromeos-bluetooth-upstreaming@chromium.org, Abhishek Pandit-Subedi , "David S. Miller" , Johan Hedberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: [PATCH 1/2] Bluetooth: Fix incorrect type for window and interval Date: Tue, 12 May 2020 19:09:32 -0700 Message-Id: <20200512190924.1.Ibdf1535b0d4c63aaf337161a333b419d6d32c364@changeid> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog In-Reply-To: <20200513020933.102443-1-abhishekpandit@chromium.org> References: <20200513020933.102443-1-abhishekpandit@chromium.org> MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The types for window and interval should be uint16, not uint8. Signed-off-by: Abhishek Pandit-Subedi --- net/bluetooth/hci_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index 3f470f0e432c7..f6870e98faab2 100644 --- a/net/bluetooth/hci_request.c +++ b/net/bluetooth/hci_request.c @@ -890,7 +890,7 @@ void hci_req_add_le_passive_scan(struct hci_request *req) struct hci_dev *hdev = req->hdev; u8 own_addr_type; u8 filter_policy; - u8 window, interval; + u16 window, interval; if (hdev->scanning_paused) { bt_dev_dbg(hdev, "Scanning is paused for suspend"); From patchwork Wed May 13 02:09:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 11544521 X-Patchwork-Delegate: marcel@holtmann.org Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C889C14B4 for ; Wed, 13 May 2020 02:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7FFF20714 for ; Wed, 13 May 2020 02:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y1F/Owmk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728881AbgEMCJp (ORCPT ); Tue, 12 May 2020 22:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728504AbgEMCJn (ORCPT ); Tue, 12 May 2020 22:09:43 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A94F3C05BD09 for ; Tue, 12 May 2020 19:09:43 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id mq3so10430843pjb.1 for ; Tue, 12 May 2020 19:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8MeJ34SnvYHzMHHvMnJ7xniPWpeltfCL/1NFcCqodmE=; b=Y1F/OwmkgG6a/vJSNdeI/glSNcKRNQhR1ng7pGL2w59MihUJLZYgexQEWUZuyMbmHS mFk8UbtWEBPqVMJsNeKFvBtlZ/TxIOMHq68Y2wuKPqG6/AG78hEtZkXw8k/fGwC2k9XT EvxSQTcfn3/wAg4QKCrM77pL1R02TQfdm0DJE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8MeJ34SnvYHzMHHvMnJ7xniPWpeltfCL/1NFcCqodmE=; b=uf7mqr8E/YCw9rZFtAjKt7VLkr+4gnAGLxek2gusprF/4PyZH0x9/lQKVlfrWIGKC9 C2istqsxFZC9C6JxQvLIoJF/keGP6tI+C7AI8c964qVWiI4vvsQApPE4warI/Q8jckKU iWk5ldbw/PuKppt4G3bGjouP2Mfips2nVsiYZhz2bzl0mPaZm8WyDd27IjBCYcmM95J3 lhbyRqrmX2jqGJhPwSFb0d4eb6io8wmoQvO1gA5oEQD8xDigjXCF6fMToQerJbEDUXUe t2cB+qxVKnHG9Puq8SlACapBen8U1fqT6VnVh01rbR+CRtz4XfbcrMckWyxvb2C2J2Gv lyhA== X-Gm-Message-State: AGi0PuYRcLcDIujQ1mWck3TaD3Aj1hokv0e0XA/gDAZslPHs65WdsBs/ A6gBxAGeLre5YIWKAs3CgummXQ== X-Google-Smtp-Source: APiQypL5VhmJml8Eed/W5CjePHC1qJ4xGeTRfq/uu6YZm5Sp5R8CkjoREdA/z3nYr6+ZeuAsu5y9zg== X-Received: by 2002:a17:90a:8b82:: with SMTP id z2mr32211504pjn.124.1589335783268; Tue, 12 May 2020 19:09:43 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id x7sm13456749pfj.122.2020.05.12.19.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 19:09:42 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org Cc: chromeos-bluetooth-upstreaming@chromium.org, Abhishek Pandit-Subedi , "David S. Miller" , Johan Hedberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: [PATCH 2/2] Bluetooth: Modify LE window and interval for suspend Date: Tue, 12 May 2020 19:09:33 -0700 Message-Id: <20200512190924.2.Ibdf1535b0d4c63aaf337161a333b419d6d32c364@changeid> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog In-Reply-To: <20200513020933.102443-1-abhishekpandit@chromium.org> References: <20200513020933.102443-1-abhishekpandit@chromium.org> MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org When a device is suspended, it doesn't need to be as responsive to connection events. Increase the interval to 640ms (creating a duty cycle of roughly 1.75%) so that passive scanning uses much less power (vs previous duty cycle of 18.75%). The new window + interval combination has been tested to work with HID devices (which are currently the only devices capable of wake up). Signed-off-by: Abhishek Pandit-Subedi --- net/bluetooth/hci_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c index f6870e98faab2..6b45e31432a77 100644 --- a/net/bluetooth/hci_request.c +++ b/net/bluetooth/hci_request.c @@ -35,7 +35,7 @@ #define HCI_REQ_CANCELED 2 #define LE_SUSPEND_SCAN_WINDOW 0x0012 -#define LE_SUSPEND_SCAN_INTERVAL 0x0060 +#define LE_SUSPEND_SCAN_INTERVAL 0x0400 void hci_req_init(struct hci_request *req, struct hci_dev *hdev) {