From patchwork Thu May 14 13:46:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A7D57697 for ; Thu, 14 May 2020 13:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9020A20728 for ; Thu, 14 May 2020 13:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="j6V+P8QI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgENNqm (ORCPT ); Thu, 14 May 2020 09:46:42 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:45723 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgENNqm (ORCPT ); Thu, 14 May 2020 09:46:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464001; x=1621000001; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=1jwyHDWkbaZ/9+NziawkrE9gv0H8DLkHj8Ik3+mzyi8=; b=j6V+P8QIkiF0auuhB62hjac9hrCgBN6r/Bmkv5oq1AKezZDAkziYM7WE vlCVF5DOxZmWcGCNfn8epjKU3pJ7098ExxfyUqwgHqKa7GYiF9unZn91r LjYFmq54nUoEXIJXKEISBoimPEjgBtThM+LlGWH65nO8miyZPNHb6rfhs dHZBNY5HpE37VyHOBUs6ursrvQwSIh9M0Akl8DkT3Yk9ZQs12kzaIv4vu MPOD7LyfE1U6lXhPt/KZJerncKHClvvn/9YkAvQq1IQOag77TGRgmsOtk SfASw0pfCCLEopTjY+DqHoyDDam9VEYYoA58cNZy0aicfMcEx3E5N6OTn A==; IronPort-SDR: Vt/k3C5z/docO0TtoLqY99ZChMT0wjrDGGw7QGW/T5eJS7YnNO1nfak14wJuqtE4La2ptabWZv mACtfDgqAuOHsYhbdY0SzRorJHXpoF1l11UXxAI2XJgUR2NKztx7PBSyiCqzOszfLVIuth35D6 ECC+g+KAOuRCniEVq4qRMYuhEysHYuDAXMxQ6zOBEPuVyN3xKh+w/LeDkZN4h96cOEQ+CUJFvG 2F8Z8ANrlG+V/zexv3LKio6fdiN0oPLab81gCSDrtfVOoTk2fyf/h4BvQRXdSJsAt3mNWLUln5 2hM= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75267234" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:34 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:34 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:36 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 1/7] staging: most: usb: use dev_*() functions to print messages Date: Thu, 14 May 2020 15:46:23 +0200 Message-ID: <1589463989-30029-2-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index a4bf362..85d4fa0 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -5,7 +5,6 @@ * Copyright (C) 2013-2015 Microchip Technology Germany II GmbH & Co. KG */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include #include #include @@ -186,13 +185,14 @@ static inline int start_sync_ep(struct usb_device *usb_dev, u16 ep) * get_stream_frame_size - calculate frame size of current configuration * @cfg: channel configuration */ -static unsigned int get_stream_frame_size(struct most_channel_config *cfg) +static unsigned int get_stream_frame_size(struct most_channel_config *cfg, + struct device *dev) { unsigned int frame_size = 0; unsigned int sub_size = cfg->subbuffer_size; if (!sub_size) { - pr_warn("Misconfig: Subbuffer size zero.\n"); + dev_warn(dev, "Misconfig: Subbuffer size zero.\n"); return frame_size; } switch (cfg->data_type) { @@ -201,7 +201,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg) break; case MOST_CH_SYNC: if (cfg->packets_per_xact == 0) { - pr_warn("Misconfig: Packets per XACT zero\n"); + dev_warn(dev, "Misconfig: Packets per XACT zero\n"); frame_size = 0; } else if (cfg->packets_per_xact == 0xFF) { frame_size = (USB_MTU / sub_size) * sub_size; @@ -210,7 +210,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg) } break; default: - pr_warn("Query frame size of non-streaming channel\n"); + dev_warn(dev, "Query frame size of non-streaming channel\n"); break; } return frame_size; @@ -270,7 +270,7 @@ static int hdm_poison_channel(struct most_interface *iface, int channel) static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf); + unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); unsigned int j, num_frames; if (!frame_size) @@ -304,7 +304,7 @@ static int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *const conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf); + unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); unsigned int j, num_frames; if (!frame_size) @@ -697,7 +697,7 @@ static int hdm_configure_channel(struct most_interface *iface, int channel, mdev->padding_active[channel] = true; - frame_size = get_stream_frame_size(conf); + frame_size = get_stream_frame_size(conf, &mdev->dev); if (frame_size == 0 || frame_size > USB_MTU) { dev_warn(dev, "Misconfig: frame size wrong\n"); return -EINVAL; From patchwork Thu May 14 13:46:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548745 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 228F8697 for ; Thu, 14 May 2020 13:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A03B20728 for ; Thu, 14 May 2020 13:46:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="BmaWqTb8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbgENNqj (ORCPT ); Thu, 14 May 2020 09:46:39 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:62113 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgENNqj (ORCPT ); Thu, 14 May 2020 09:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464000; x=1621000000; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=tJKksn5Xr0ro+6lb57CFH3u/OX0PnYqchb5vz4CQkJk=; b=BmaWqTb8Y8JSuO9oBXN0urbet2V5dD+uLqoZp0TceJcBXp9Jp2ZbutIv j7SguzHNv85h/WbFAu7bm2gR+tC+f6Opr0AL3Cq/e1XuAAuVS/N9zVg7Q MKjfOlMdo0WOvrePCjoMXLciG9uC6kyuwegJXuy8Fn7nw9uFsoeXjBGBI GXU26UmftYImnUHBpE5fZ4MK0ErsJmVlBDUt8CcH0w+aoLEM76NlMLcVB AShsYzPAyng/uBIUCpcx9EWA98XghoXDwrgAUQ0GvXVTR78fZyNkRdCPz xpZJxVhv9q8ThuwUFoZB/fOFCHB+03d9cTYnrhWqWfp6vyzsJlVVk2eTY g==; IronPort-SDR: GDUH6Rx/XizZ0dK4SiFg4KnrMLmRndorBGOggcEE+nCKKWfHLD7Hos8C7bH4Bki27SKqpvmtVP 6ymeUviP/uAkLakSvTmZNt2ncF2mVl6ZumZql0TSrVxdFibfOdCMFKIn2P/IZIZ/SAaXnXdKYK SasrTGYd7xBBznsbxdAmfik9fBGx/rn/5unzxykrvFNtPb9DaE6XQg3tfj7hE1E/u340DJsoHO IXDil8ckq6xJyAC/ASNJBt588j1QwfJJPo11vdvlj0/aszbImT/D5QXJLFx3jhuUVZWC1kQAHm MW8= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75894428" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:37 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:35 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:37 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 2/7] staging: most: usb: remove reference to USB error codes Date: Thu, 14 May 2020 15:46:24 +0200 Message-ID: <1589463989-30029-3-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 85d4fa0..76963c0 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -477,8 +477,6 @@ static void hdm_write_completion(struct urb *urb) * controller use to indicate a transfer has failed because of device * disconnect. In the interval before the hub driver starts disconnect * processing, devices may receive such fault reports for every request. - * - * See */ static void hdm_read_completion(struct urb *urb) { From patchwork Thu May 14 13:46:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548757 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6121F697 for ; Thu, 14 May 2020 13:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48DD120728 for ; Thu, 14 May 2020 13:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Ytz7z4Vk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbgENNqo (ORCPT ); Thu, 14 May 2020 09:46:44 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:45723 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgENNqn (ORCPT ); Thu, 14 May 2020 09:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464002; x=1621000002; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Rthw9RgyxsSo7CXVnKL+/+TueNiZ78Tg2Sf6xtbmegU=; b=Ytz7z4VkIVNs3o0RSh/LFL71pR+8DQdGsNSUu6ofYG769I5juv4Hn4+J KQdq9uUzSE1d6sL1EuEQVqpIFKUEwMt7GAG8/7GavdpAEuicwqx7CIuLW 9k/qYse74mwO9cx0iL+q0l7ex+FEff10bKM5/T/4Ayi7nIxiVnVF/WIEG zq4U5H90WO+hya+J5yXEaG7V8zPDOHwSKWHSFeAiNvRa9TZUu0wagtD7V LperWjmtdCnRNhFZaDY2XLnJulnTQotgl61Mzcv+u4FiIbUMUX5nfNS4s oZVU2idiYlgrJnpBv+EleDJO2V0eaGB2rNH03e05bC+R2GjDoShQGeHSL Q==; IronPort-SDR: +yJJfPnFu9ZnE4o82sZ4w8RwvUaRAucwpRm96DIxswOCzDNA21w/AHF3nI1il7PeY3tnNO0rFr Z7PRhrsEQ4XgwbG1IxRYVtttsCdrJWq4KeWDjvp4sxTy4tEfOhU4Nkj3OI8ZalcqW2BqoOHTc7 JqZ2sDlNYr9ZVCMZTF+Ns/FHrpDPhia7D/x7cv3+Y+I5/nmbdANGPc6deP/ueSIgueaGZjhNOk LoNBBNNDDK5VaxNN6YJfJs75V7ka+KNQx4SnLiAqQ8/wsWx3ZfRa8RfgFBRZCVimTZEKXppV89 lt8= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75267238" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:37 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:36 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:39 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 3/7] staging: most: usb: check number of reported endpoints Date: Thu, 14 May 2020 15:46:25 +0200 Message-ID: <1589463989-30029-4-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 76963c0..25e114d 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -1045,13 +1045,17 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) unsigned int num_endpoints; struct most_channel_capability *tmp_cap; struct usb_endpoint_descriptor *ep_desc; - int ret = 0; + int ret; if (!mdev) - goto err_out_of_memory; + return -ENOMEM; usb_set_intfdata(interface, mdev); num_endpoints = usb_iface_desc->desc.bNumEndpoints; + if (num_endpoints > MAX_NUM_ENDPOINTS) { + kfree(mdev); + return -EINVAL; + } mutex_init(&mdev->io_mutex); INIT_WORK(&mdev->poll_work_obj, wq_netinfo); timer_setup(&mdev->link_stat_timer, link_stat_timer_handler, 0); @@ -1180,11 +1184,6 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) kfree(mdev->conf); err_free_mdev: put_device(&mdev->dev); -err_out_of_memory: - if (ret == 0 || ret == -ENOMEM) { - ret = -ENOMEM; - dev_err(dev, "out of memory\n"); - } return ret; } From patchwork Thu May 14 13:46:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548747 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 77E55138A for ; Thu, 14 May 2020 13:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 550BE20728 for ; Thu, 14 May 2020 13:46:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="dpVuYCI9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbgENNqk (ORCPT ); Thu, 14 May 2020 09:46:40 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:62113 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgENNqj (ORCPT ); Thu, 14 May 2020 09:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464000; x=1621000000; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=q62AaMvRlnJWHFhcdKw6BSnQ1+0vKJEbrDyzf0ZKEbo=; b=dpVuYCI9ObPruUUE8I/1t/DJzGnzITTfDiY9Ykn0LXE3jcr4jS9d7xtP 0ZajLaf/3E8xgMFckRWkcL/DFxh1A6n5kcjPNCTGc0yaCF+KjohfUjEyY THeTUR86Bc/m2dafgpeGzs9D5opJmQ08j3PF0nMnl/uR8sJO+/SkaYqgV bxSeCq2H53EeGnG0u+B1/uFHlApZve66zezje4trgaOsHwMGd/6gwVIH+ 4P9ylDIFc7pYIP8Obpj5MOaoU9lc9+SfE5Oq+FgZcNQPbJ4yEe1B+uUFe BMZW52v9R3MEC+QKAVwXG8PGPoxdETfDRwKTQWZhn1eHDucL6O9m8vY6W g==; IronPort-SDR: QT6xHZ9BqKXJ2PUNCtCgHwvy7pOtuQTx074zY1NHlqE5YyMnZf0noO+zNWS8PVhHsvpZd9J9QQ WulfXVwhJ7IkQL0VIGo+U1iFKQVKC7B3f8jwnpduc8/jmXwva6Xx9eVjhmed9Jq9mNeyQ7M8Yz Q6IupYP51Q3uAkjXbvO7oIbm8+Xht6s16ZTipc7lSRWhwoAb3RJyZIjws571EeoQdaDhYLwMhX dLS67wuk6cdETux4QZMBWbOGvPlJ85M5hfyv/xaz9sJu72LANtCJRk8TdgNGMUHWFhmOxJiQwa woE= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75894437" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:40 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:38 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:40 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 4/7] staging: most: usb: use dev_dbg function Date: Thu, 14 May 2020 15:46:26 +0200 Message-ID: <1589463989-30029-5-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 25e114d..882f59e 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -1130,13 +1130,13 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) init_usb_anchor(&mdev->busy_urbs[i]); spin_lock_init(&mdev->channel_lock[i]); } - dev_notice(dev, "claimed gadget: Vendor=%4.4x ProdID=%4.4x Bus=%02x Device=%02x\n", + dev_dbg(dev, "claimed gadget: Vendor=%4.4x ProdID=%4.4x Bus=%02x Device=%02x\n", le16_to_cpu(usb_dev->descriptor.idVendor), le16_to_cpu(usb_dev->descriptor.idProduct), usb_dev->bus->busnum, usb_dev->devnum); - dev_notice(dev, "device path: /sys/bus/usb/devices/%d-%s:%d.%d\n", + dev_dbg(dev, "device path: /sys/bus/usb/devices/%d-%s:%d.%d\n", usb_dev->bus->busnum, usb_dev->devpath, usb_dev->config->desc.bConfigurationValue, From patchwork Thu May 14 13:46:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548751 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF5A8138A for ; Thu, 14 May 2020 13:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C0CE20728 for ; Thu, 14 May 2020 13:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="mjGPZElZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbgENNqn (ORCPT ); Thu, 14 May 2020 09:46:43 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:62125 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgENNql (ORCPT ); Thu, 14 May 2020 09:46:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464002; x=1621000002; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=NAWNHUGkWVqHw4OIUXqxJ6p/XpmnlbIkD3/DmN+xwEo=; b=mjGPZElZ0P/lipEk7IoqMBqYoxW5Sqrdk3kFd1FHnxOU/S8EzeA5a8hj /j3SaAKvLgOJIgIqj8uhuD6OrsDYUqC9LCMWzW87XBgIyCxQf6mFl6aA6 1K180EkyhdTTlFssyeJh+WxIxl8q4CKCr6FjBFFVd8p12CGUlgWDHzQAb ZfA1lHcdja2OMliAxdm3eXXR8E/G2r8hjHmJr0TduAiFjMU/8kHHmqEUl yY89OcQb4n8ZO24UJrGO4879jutBQCkTWSI+UlFEWgltjuyKGlyovz2Ok F3wbNBm7LF8B8yZLnxnxgTpk01ilPzJbZ/QtsodXiXKgQAj+h0/9Svo2a w==; IronPort-SDR: EqNu7ea7kDXbyk5j5o1+az4/iDy/TFMy05hMc11XCCLyhb0pllfMDptckjwWFzMjoj3/ry8IeT R9a+K3ccXQ72D+kEAJn6Ooo2GSV+WCC/YyIiuAJI8Y8XJ4ISswmP+c+xl12iL9VEPf9zkkNXqw QQcIsADDChHsgm0u9FX0OdFd15aLIvYiW5H9Fkmv29NyS0S8uvyRQ81/3o2RfslUYksk9PPTHX gvlZxGFjB9KlfFk7hDCJvVT8Dr4o0hu9kLthfjN+bUd+7mELMGe2hsnR+6vDZMomkZcuyjWY6x ruA= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75894442" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:42 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:42 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:41 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 5/7] staging: most: fix typo in Kconfig Date: Thu, 14 May 2020 15:46:27 +0200 Message-ID: <1589463989-30029-6-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- drivers/staging/most/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/usb/Kconfig b/drivers/staging/most/usb/Kconfig index a86f1f6..75dc25c 100644 --- a/drivers/staging/most/usb/Kconfig +++ b/drivers/staging/most/usb/Kconfig @@ -7,7 +7,7 @@ config MOST_USB tristate "USB" depends on USB && NET help - Say Y here if you want to connect via USB to network tranceiver. + Say Y here if you want to connect via USB to network transceiver. This device driver depends on the networking AIM. To compile this driver as a module, choose M here: the From patchwork Thu May 14 13:46:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548755 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A837E697 for ; Thu, 14 May 2020 13:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86FAB20734 for ; Thu, 14 May 2020 13:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="WjHdCtmI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgENNqo (ORCPT ); Thu, 14 May 2020 09:46:44 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:45731 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbgENNqn (ORCPT ); Thu, 14 May 2020 09:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464003; x=1621000003; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=cPkJ3klY44IvPSuqB9e4DTMxpg8N94GY9+FBzes9a9s=; b=WjHdCtmI96yxrFvclqwOVC2Nhpi+b/NKgx4ZuW5f+nYx/esPu79AVe21 EA+rEB34ALjhZHd1tLQh/jxPx41tQEy5fVOGKhcYP6oIa4qx+LO5X+HRR nEKGuBugwKqCDC+VPYp36X35WDuPwkgzM986qy0lRyYOVO1AMCjDma/Yc 1kZBY6A3O62cD25yk6Yk/GUWmI7vT0JEZN3ymU/NbqOEItIN9bd/8hEg4 tqfhOkmT0hK2dV5vZmBr6Zsn+JmBkhQ1kV3eMDQehGI7LNBpIJ10saaNw t4f0H5SNDvncsa5q2Hr935l7h3EA8JmUnC2ZzOx5B26Pi/1MCzwsjcHzL g==; IronPort-SDR: rIzHc0U7/tkuyZY2pSjQ0eIZA0lqlbb36BUDikt5xnzjohAVFzMxhcVkvmGFAn4hlTeYbCdqoR 1OfFTP+eqT9V44Ynt8hUANCIiB7nGZCimuskGBe3TSjYgowbCevBN/CvgOxntlBBVxnqqf13SS D8wkSRhas8jkLESwPoALtXrjQ8VRjHiLoR3VWZlzK3qqy3tX/jbaucoiEYTgdYb9ZMqJLDDn6n xIs+39SZX5ewtP9RCNXpw3XxyVJlH2tmezPadCdCRh8qgmGPoNLDPYNSoNlVby4e7KreHM2AbF GrQ= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75267250" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:41 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:40 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:42 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS Date: Thu, 14 May 2020 15:46:28 +0200 Message-ID: <1589463989-30029-7-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- drivers/staging/most/usb/usb.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 882f59e..a26e9b1 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -1000,14 +1000,7 @@ static struct attribute *dci_attrs[] = { NULL, }; -static struct attribute_group dci_attr_group = { - .attrs = dci_attrs, -}; - -static const struct attribute_group *dci_attr_groups[] = { - &dci_attr_group, - NULL, -}; +ATTRIBUTE_GROUPS(dci); static void release_dci(struct device *dev) { @@ -1160,7 +1153,7 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) mdev->dci->dev.init_name = "dci"; mdev->dci->dev.parent = get_device(mdev->iface.dev); - mdev->dci->dev.groups = dci_attr_groups; + mdev->dci->dev.groups = dci_groups; mdev->dci->dev.release = release_dci; if (device_register(&mdev->dci->dev)) { mutex_unlock(&mdev->io_mutex); From patchwork Thu May 14 13:46:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11548753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 445C6139A for ; Thu, 14 May 2020 13:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A75F20728 for ; Thu, 14 May 2020 13:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="bmGxPtz7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbgENNqo (ORCPT ); Thu, 14 May 2020 09:46:44 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:62125 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726813AbgENNqm (ORCPT ); Thu, 14 May 2020 09:46:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589464004; x=1621000004; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=J8CPJ56ra0XsYdXSteHEa5HFZLx4UbqbE8qlTvd5eP0=; b=bmGxPtz7YBJVNGguGjilDTeesONpbshV555gG6Mc63dsg32QEuaMKiZH PG6HttKD4hS2CIngWvFHCjtPj2wVvtOzW95RktWbAfLEWaVHk3v827BtO tNvAqqxIYO2WK8EGpR8NxZRxxIwcakdTclE5ewe1b2PcpZYTdRE8p93iO taRP1+URnpnVmU8YEDYfE3BTlvZwnJGY4c7fKfTY20KKm845SSj9Gx0yX JnU5zsoh/tZs7LBTw3lHao/yNds+ubRW10g+lqx3K4MMQOf+/YgbLTjcg ST4aRmoto6EWq4CQoDxWps2OZkjRDzRlIL3bP0dOq6tacfB2UnKxjNyGg Q==; IronPort-SDR: UwP4hOSm3q1il5LLLV7UPepQEBkq55Ir8jVmZ4D1Vml4bdPcSEQ8CenqpAM7+oeS+pegMkjHpa W0vGynlL7evxjNKJCh0nYkLWpySDrmimUhDI3c51YeOW6AgyP0P7jojubveb3Nfx6faEBGfTjt tlgnjxTG6HoyjbPFzmLQuPJbiXwGn5N089VzLsbBfTd4M1DpNeUICfanUxJfmOkg1lg0vJCq9Q FXOe6/Y96wunFmB+KqeIlipwI4sIHb4T2fM0FDfWjNBs1Ali9a2+lw/qxNOUaFUv9dIIw8o4Nf zDs= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75894447" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 06:46:43 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 06:46:45 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 06:46:44 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver Date: Thu, 14 May 2020 15:46:29 +0200 Message-ID: <1589463989-30029-8-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> References: <1589463989-30029-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- Documentation/ABI/testing/sysfs-bus-most | 104 ++++++++++++++++--------------- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b/Documentation/ABI/testing/sysfs-bus-most index 6b1d06e..ec0a603 100644 --- a/Documentation/ABI/testing/sysfs-bus-most +++ b/Documentation/ABI/testing/sysfs-bus-most @@ -1,14 +1,14 @@ -What: /sys/bus/most/devices/.../description +What: /sys/bus/most/devices//description Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Provides information about the interface type and the physical - location of the device. Hardware attached via USB, for instance, + Provides information about the physical location of the + device. Hardware attached via USB, for instance, might return <1-1.1:1.0> Users: -What: /sys/bus/most/devices/.../interface +What: /sys/bus/most/devices//interface Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm @@ -16,7 +16,7 @@ Description: Indicates the type of peripheral interface the device uses. Users: -What: /sys/bus/most/devices/.../dci +What: /sys/bus/most/devices//dci Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -26,7 +26,7 @@ Description: write the controller's DCI registers. Users: -What: /sys/bus/most/devices/.../dci/arb_address +What: /sys/bus/most/devices//dci/arb_address Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -35,7 +35,7 @@ Description: application wants to read from or write to. Users: -What: /sys/bus/most/devices/.../dci/arb_value +What: /sys/bus/most/devices//dci/arb_value Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -44,7 +44,7 @@ Description: is stored in arb_address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_hi +What: /sys/bus/most/devices//dci/mep_eui48_hi Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -52,7 +52,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_lo +What: /sys/bus/most/devices//dci/mep_eui48_lo Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -60,7 +60,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_mi +What: /sys/bus/most/devices//dci/mep_eui48_mi Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -68,7 +68,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_filter +What: /sys/bus/most/devices//dci/mep_filter Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -76,7 +76,7 @@ Description: This is used to check and configure the MEP filter address. Users: -What: /sys/bus/most/devices/.../dci/mep_hash0 +What: /sys/bus/most/devices//dci/mep_hash0 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -84,7 +84,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash1 +What: /sys/bus/most/devices//dci/mep_hash1 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -92,7 +92,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash2 +What: /sys/bus/most/devices//dci/mep_hash2 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -100,7 +100,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash3 +What: /sys/bus/most/devices//dci/mep_hash3 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -108,7 +108,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/ni_state +What: /sys/bus/most/devices//dci/ni_state Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -116,7 +116,7 @@ Description: Indicates the current network interface state. Users: -What: /sys/bus/most/devices/.../dci/node_address +What: /sys/bus/most/devices//dci/node_address Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -124,7 +124,7 @@ Description: Indicates the current node address. Users: -What: /sys/bus/most/devices/.../dci/node_position +What: /sys/bus/most/devices//dci/node_position Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -132,7 +132,7 @@ Description: Indicates the current node position. Users: -What: /sys/bus/most/devices/.../dci/packet_bandwidth +What: /sys/bus/most/devices//dci/packet_bandwidth Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -140,7 +140,7 @@ Description: Indicates the configured packet bandwidth. Users: -What: /sys/bus/most/devices/.../dci/sync_ep +What: /sys/bus/most/devices//dci/sync_ep Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -149,7 +149,7 @@ Description: endpoint. Users: -What: /sys/bus/most/devices/...// +What: /sys/bus/most/devices/// Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm @@ -160,91 +160,92 @@ Description: configure it. Users: -What: /sys/bus/most/devices/...//available_datatypes +What: /sys/bus/most/devices///available_datatypes Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the data types the current channel can transport. + Indicates the data types the channel can transport. Users: -What: /sys/bus/most/devices/...//available_directions +What: /sys/bus/most/devices///available_directions Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the directions the current channel is capable of. + Indicates the directions the channel is capable of. Users: -What: /sys/bus/most/devices/...//number_of_packet_buffers +What: /sys/bus/most/devices///number_of_packet_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the number of packet buffers the current channel can + Indicates the number of packet buffers the channel can handle. Users: -What: /sys/bus/most/devices/...//number_of_stream_buffers +What: /sys/bus/most/devices///number_of_stream_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the number of streaming buffers the current channel can + Indicates the number of streaming buffers the channel can handle. Users: -What: /sys/bus/most/devices/...//size_of_packet_buffer +What: /sys/bus/most/devices///size_of_packet_buffer Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the size of a packet buffer the current channel can + Indicates the size of a packet buffer the channel can handle. Users: -What: /sys/bus/most/devices/...//size_of_stream_buffer +What: /sys/bus/most/devices///size_of_stream_buffer Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the size of a streaming buffer the current channel can + Indicates the size of a streaming buffer the channel can handle. Users: -What: /sys/bus/most/devices/...//set_number_of_buffers +What: /sys/bus/most/devices///set_number_of_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the number of buffers of the current channel. + This is to read back the configured number of buffers of + the channel. Users: -What: /sys/bus/most/devices/...//set_buffer_size +What: /sys/bus/most/devices///set_buffer_size Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the size of a buffer of the current channel. + This is to read back the configured buffer size of the channel. Users: -What: /sys/bus/most/devices/...//set_direction +What: /sys/bus/most/devices///set_direction Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the direction of the current channel. + This is to read back the configured direction of the channel. The following strings will be accepted: - 'dir_tx', - 'dir_rx' + 'tx', + 'rx' Users: -What: /sys/bus/most/devices/...//set_datatype +What: /sys/bus/most/devices///set_datatype Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the data type of the current channel. + This is to read back the configured data type of the channel. The following strings will be accepted: 'control', 'async', @@ -252,30 +253,31 @@ Description: 'isoc_avp' Users: -What: /sys/bus/most/devices/...//set_subbuffer_size +What: /sys/bus/most/devices///set_subbuffer_size Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the subbuffer size of the current channel. + This is to read back the configured subbuffer size of + the channel. Users: -What: /sys/bus/most/devices/...//set_packets_per_xact +What: /sys/bus/most/devices///set_packets_per_xact Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the number of packets per transaction of - the current channel. This is only needed network interface - controller is attached via USB. + This is to read back the configured number of packets per + transaction of the channel. This is only applicable when + connected via USB. Users: -What: /sys/bus/most/devices/...//channel_starving +What: /sys/bus/most/devices///channel_starving Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates whether current channel ran out of buffers. + Indicates whether channel ran out of buffers. Users: What: /sys/bus/most/drivers/most_core/components