From patchwork Thu May 14 15:18:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549089 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F36C9697 for ; Thu, 14 May 2020 15:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC4F620728 for ; Thu, 14 May 2020 15:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Xn4d7Vox" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbgENPS6 (ORCPT ); Thu, 14 May 2020 11:18:58 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:8015 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726056AbgENPS6 (ORCPT ); Thu, 14 May 2020 11:18:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469538; x=1621005538; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=H7feGbo36stL28p0Wvk1RKIPuKIoLQhAKgTHMY+gbGU=; b=Xn4d7Voxj5VbCADe0Dczb4JMZzNik8G1ZNDuXZ+Dzjz7pgv5VxXD3j/M PQOvpXNt6OKctTkiAu4Pby/HVFyS0o+CpMUOF8wHKyQe2STKL7mdblPh+ wtVhcnA109GFKcHoR0Ak9985zlvu6LGroX/BT4Sk2dmr6QJpSA3JxEWsS yAf0RsWZXld1R4qd5LPyYMsnR+QE6tOXoC/tQQJ8ByEbh+zfnrTDqxjh3 LGs79fVBfPXD5eyRDq4HLYfBb5sjvjWL9iOfo5k5XrC6JuYs1CmhzqPnY TAIagMDA3KKI6EXrQRVdSDLpPjIqjUa0PIN3JmpEpy2Jf5YrfvXeBgQSr w==; IronPort-SDR: OA09F0RxRqiBLiuVIO5IPxawb/GTjSgNfCE0+EZ163tv6eOcnQYV3DnxtSKznFGHMcnl/qDgyV baLOFVXF3uh4/9+Bd6NoLcbpe4ZyryeoUh6d+dKW4GADOduCav9WZbCUYMGk0efUc9yOhhKIQE UxftRdFOyYhU06/UVZ2gV10khWj8snSVUkmisiV/Hke+WITXnN8kRhjSJd8EyiNHfhASGFZfiP FjagLOO6LYuxKHQ78PLqPngsnTp3nAnSwbgfVNLNud2/pJzt2kRRJLFE7rlRz0VXphN8E3aCfN iUA= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75909798" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:18:58 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:00 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:18:59 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 1/7] staging: most: usb: use dev_*() functions to print messages Date: Thu, 14 May 2020 17:18:46 +0200 Message-ID: <1589469532-21488-2-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch removes the pr_*() functions and uses dev_*() instead. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index a4bf362..85d4fa0 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -5,7 +5,6 @@ * Copyright (C) 2013-2015 Microchip Technology Germany II GmbH & Co. KG */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include #include #include @@ -186,13 +185,14 @@ static inline int start_sync_ep(struct usb_device *usb_dev, u16 ep) * get_stream_frame_size - calculate frame size of current configuration * @cfg: channel configuration */ -static unsigned int get_stream_frame_size(struct most_channel_config *cfg) +static unsigned int get_stream_frame_size(struct most_channel_config *cfg, + struct device *dev) { unsigned int frame_size = 0; unsigned int sub_size = cfg->subbuffer_size; if (!sub_size) { - pr_warn("Misconfig: Subbuffer size zero.\n"); + dev_warn(dev, "Misconfig: Subbuffer size zero.\n"); return frame_size; } switch (cfg->data_type) { @@ -201,7 +201,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg) break; case MOST_CH_SYNC: if (cfg->packets_per_xact == 0) { - pr_warn("Misconfig: Packets per XACT zero\n"); + dev_warn(dev, "Misconfig: Packets per XACT zero\n"); frame_size = 0; } else if (cfg->packets_per_xact == 0xFF) { frame_size = (USB_MTU / sub_size) * sub_size; @@ -210,7 +210,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg) } break; default: - pr_warn("Query frame size of non-streaming channel\n"); + dev_warn(dev, "Query frame size of non-streaming channel\n"); break; } return frame_size; @@ -270,7 +270,7 @@ static int hdm_poison_channel(struct most_interface *iface, int channel) static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf); + unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); unsigned int j, num_frames; if (!frame_size) @@ -304,7 +304,7 @@ static int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *const conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf); + unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); unsigned int j, num_frames; if (!frame_size) @@ -697,7 +697,7 @@ static int hdm_configure_channel(struct most_interface *iface, int channel, mdev->padding_active[channel] = true; - frame_size = get_stream_frame_size(conf); + frame_size = get_stream_frame_size(conf, &mdev->dev); if (frame_size == 0 || frame_size > USB_MTU) { dev_warn(dev, "Misconfig: frame size wrong\n"); return -EINVAL; From patchwork Thu May 14 15:18:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549091 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA1D514B7 for ; Thu, 14 May 2020 15:19:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1E5B20728 for ; Thu, 14 May 2020 15:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="F+FfxlTp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726191AbgENPTA (ORCPT ); Thu, 14 May 2020 11:19:00 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:8015 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726056AbgENPS7 (ORCPT ); Thu, 14 May 2020 11:18:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469539; x=1621005539; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=bSkxPO4YAeYhoA86BhD7AljvgDtewB0pwQgHTAau/j4=; b=F+FfxlTpPbFccc7Ch0rkldLyfNMy0QlWEoiCemG2/dVSeMJKhk57h7P0 SDZwK3if7wWHvdQChMdoqm/LDjJWSj8uAc5SviPkmHabuBYvsQ6DBmg6w v428oWzfdsnCoCiVsmy2S+/BdpWB4vUweiRvuDv2z75nMPInPxSEIYkKC VYpFvTzxZxS7ZFBhk2+Hf65MXJFisV363SaOTVNM1cTZ3srpTrZyry6Z9 YcbvZrChT76o7vawnPVpmsXrXZtdsSu0Pd2Vp9ADbVYkpQP5at9m9wbMF zzrDWpswEJvKAf2NzzlvpntJVdRAfLhoLT5+3rgLE1h8VCxkBXz1UGQaT A==; IronPort-SDR: YwZEYQ980Xrod7RQkQsiZFC7W0OSXRtClbRLXBwGuC1E8koaWVMhAyFZ9f1nZiY6lA1EUzjK6q I/QJ+7jrNrViRx46YXb1iItblsQNSIpI6ddsQSoCBSaBCLMbmQ5R1JoCNqNCPEmH/Tv2kUBzXA ZM8ZDVZBSM8R7pRKikkl7OOOuHGM3hIrNzjhAVIsgxOPtM2liU3ikF3OZtCLhcINzzEJosOyUY 0OOO4p6VDGephHV7WfV5fY0K4ePwbsyZmqNPKpTenM5YOBmh8ueHk1sgqJ0gvTnPRUvyUwmunh 7n4= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75909803" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:18:59 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:01 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:00 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 2/7] staging: most: usb: remove reference to USB error codes Date: Thu, 14 May 2020 17:18:47 +0200 Message-ID: <1589469532-21488-3-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch removes the reference to the driver API file for USB error codes. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: removed copied USB error code section drivers/staging/most/usb/usb.c | 97 ------------------------------------------ 1 file changed, 97 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 85d4fa0..dbb6003 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -382,103 +382,6 @@ static void hdm_write_completion(struct urb *urb) * padding bytes -if necessary- and calls the completion function. * * Context: interrupt! - * - * ************************************************************************** - * Error codes returned by in urb->status - * or in iso_frame_desc[n].status (for ISO) - * ************************************************************************* - * - * USB device drivers may only test urb status values in completion handlers. - * This is because otherwise there would be a race between HCDs updating - * these values on one CPU, and device drivers testing them on another CPU. - * - * A transfer's actual_length may be positive even when an error has been - * reported. That's because transfers often involve several packets, so that - * one or more packets could finish before an error stops further endpoint I/O. - * - * For isochronous URBs, the urb status value is non-zero only if the URB is - * unlinked, the device is removed, the host controller is disabled or the total - * transferred length is less than the requested length and the URB_SHORT_NOT_OK - * flag is set. Completion handlers for isochronous URBs should only see - * urb->status set to zero, -ENOENT, -ECONNRESET, -ESHUTDOWN, or -EREMOTEIO. - * Individual frame descriptor status fields may report more status codes. - * - * - * 0 Transfer completed successfully - * - * -ENOENT URB was synchronously unlinked by usb_unlink_urb - * - * -EINPROGRESS URB still pending, no results yet - * (That is, if drivers see this it's a bug.) - * - * -EPROTO (*, **) a) bitstuff error - * b) no response packet received within the - * prescribed bus turn-around time - * c) unknown USB error - * - * -EILSEQ (*, **) a) CRC mismatch - * b) no response packet received within the - * prescribed bus turn-around time - * c) unknown USB error - * - * Note that often the controller hardware does not - * distinguish among cases a), b), and c), so a - * driver cannot tell whether there was a protocol - * error, a failure to respond (often caused by - * device disconnect), or some other fault. - * - * -ETIME (**) No response packet received within the prescribed - * bus turn-around time. This error may instead be - * reported as -EPROTO or -EILSEQ. - * - * -ETIMEDOUT Synchronous USB message functions use this code - * to indicate timeout expired before the transfer - * completed, and no other error was reported by HC. - * - * -EPIPE (**) Endpoint stalled. For non-control endpoints, - * reset this status with usb_clear_halt(). - * - * -ECOMM During an IN transfer, the host controller - * received data from an endpoint faster than it - * could be written to system memory - * - * -ENOSR During an OUT transfer, the host controller - * could not retrieve data from system memory fast - * enough to keep up with the USB data rate - * - * -EOVERFLOW (*) The amount of data returned by the endpoint was - * greater than either the max packet size of the - * endpoint or the remaining buffer size. "Babble". - * - * -EREMOTEIO The data read from the endpoint did not fill the - * specified buffer, and URB_SHORT_NOT_OK was set in - * urb->transfer_flags. - * - * -ENODEV Device was removed. Often preceded by a burst of - * other errors, since the hub driver doesn't detect - * device removal events immediately. - * - * -EXDEV ISO transfer only partially completed - * (only set in iso_frame_desc[n].status, not urb->status) - * - * -EINVAL ISO madness, if this happens: Log off and go home - * - * -ECONNRESET URB was asynchronously unlinked by usb_unlink_urb - * - * -ESHUTDOWN The device or host controller has been disabled due - * to some problem that could not be worked around, - * such as a physical disconnect. - * - * - * (*) Error codes like -EPROTO, -EILSEQ and -EOVERFLOW normally indicate - * hardware problems such as bad devices (including firmware) or cables. - * - * (**) This is also one of several codes that different kinds of host - * controller use to indicate a transfer has failed because of device - * disconnect. In the interval before the hub driver starts disconnect - * processing, devices may receive such fault reports for every request. - * - * See */ static void hdm_read_completion(struct urb *urb) { From patchwork Thu May 14 15:18:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549093 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6227114C0 for ; Thu, 14 May 2020 15:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AFC620728 for ; Thu, 14 May 2020 15:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Z9X6HDKu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727798AbgENPTA (ORCPT ); Thu, 14 May 2020 11:19:00 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:3694 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgENPTA (ORCPT ); Thu, 14 May 2020 11:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469539; x=1621005539; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Rn1pc1QTMgKmish9JgDfo6jrHeq3EAb4tQb+UmggaHs=; b=Z9X6HDKubv5HjUr4pSWKCrVbrVAhmfhKWnuS3ftc8GdfGxG/VCnf+FBb /wqtPNf62Kixm+B5YJtGk0FhGpJoBxvblcHtySh1E+Qr3NHdYpul7Mgjb LVYmJfZu2AbLkvvDmhB4xwzGeTGJ4bbI8fEWDfV4lvhDgwhmw6ahljy4H pjPyIHFaIxPZkpg9Gvt01eMjJL/bvMER6HdKjXntwLuv1CZpiaxASYYwe reqBHaRr9tr7e5eaG36Jh6Ny24UqJAMrf0yKbDM7PIZB5OS00flHvCnLw q6iXrUUZOPG6BqZ36yfAzangR1ygHFJ/jf0iS/CWjk2q9yuwzxSJVjcDH Q==; IronPort-SDR: AF2hbRuxcvisuVT0xf6kLCxQMTs4C5LGJttxc1RUaYUYz0H1dKA2tliybFI3sbnUrNdN+kVUPG EubRSAAQGUUKx70Ty6EZGvMqm5NIJQl/WVgF0wYnSqopo3dx1SYYk45mnb8fmagVYssu8HwhSU QsJI98vJazbkwF5s49ZpFxOO/rIOvgmLQyyBddQz+9DrW7Q3zODtzbrlxxe9+XkojdEozDxh+F jbfMbZA829uWbL4awKIngx7CkEztt6I+gdfO+j8njDiPgXKPuC13QZHRDFvrRmObFyRoe79OwN eJM= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="76658375" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:18:59 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:18:59 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:01 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 3/7] staging: most: usb: check number of reported endpoints Date: Thu, 14 May 2020 17:18:48 +0200 Message-ID: <1589469532-21488-4-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch checks the number of endpoints reported by the USB interface descriptor and throws an error if the number exceeds MAX_NUM_ENDPOINTS. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman Reported-by: kbuild test robot --- v2: drivers/staging/most/usb/usb.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index dbb6003..d5c73cb 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -950,13 +950,17 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) unsigned int num_endpoints; struct most_channel_capability *tmp_cap; struct usb_endpoint_descriptor *ep_desc; - int ret = 0; + int ret; if (!mdev) - goto err_out_of_memory; + return -ENOMEM; usb_set_intfdata(interface, mdev); num_endpoints = usb_iface_desc->desc.bNumEndpoints; + if (num_endpoints > MAX_NUM_ENDPOINTS) { + kfree(mdev); + return -EINVAL; + } mutex_init(&mdev->io_mutex); INIT_WORK(&mdev->poll_work_obj, wq_netinfo); timer_setup(&mdev->link_stat_timer, link_stat_timer_handler, 0); @@ -1085,11 +1089,6 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) kfree(mdev->conf); err_free_mdev: put_device(&mdev->dev); -err_out_of_memory: - if (ret == 0 || ret == -ENOMEM) { - ret = -ENOMEM; - dev_err(dev, "out of memory\n"); - } return ret; } From patchwork Thu May 14 15:18:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8BA61697 for ; Thu, 14 May 2020 15:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7476A206A5 for ; Thu, 14 May 2020 15:19:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="voC5IqYD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727802AbgENPTB (ORCPT ); Thu, 14 May 2020 11:19:01 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:8015 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgENPTB (ORCPT ); Thu, 14 May 2020 11:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469541; x=1621005541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=lUbXm9Hi2Ra7UqsdrP7ZRyeuZc3zmXm9sYSDoqr6Ukc=; b=voC5IqYDOpLrnqqq0m9+AZZRYhBGI8+lyokVKdH6zZi23xX60DCyai9a SDj6khASMB27J/KEtzxUAdgfm71V8fId9qtGQbIA7KzDz6T0C8MHUYyHs LeqV7ZbvzgEHwaj/v+uJnODFB2uYs8aCSOtzMd8N365OR52bEAVm4keS+ hbHtXntglOjpMUwPI+bb950Ygq5/xWgkpMc1Yf6+iH0oX2vi7mvY9llzW 8QxA14k+Z0JV14o5j66QUXqb0KnV4eCfsfgqvVxRPBp5YlKo3p+eDJ27+ UMdXl44WP1NraZAtYHZz7AZC8Vvi5EE9/u4Cj7TT1Kd4WHMj+tzfZ41EY g==; IronPort-SDR: Hw4LbRd5KLKkWog3YwbbBYlD377fNUU+nzVAwrJ72mssypSUvZXSO0h2z1INf9pEqLZgRygLQm UeranlswXdRu2HB6XPDMlF/lpjKfh96uxVa3NdP7GTRPYJP82HvDTavOr6mDG2CYw4GY0rc1iL xMoO3ExTwDan0ZZ4J/eD1yOZP/vjO48NdWFbvoEovBzPgu4KfjK9nHgHEcIXERRgZ0Lz+0JfJW ff4AZzAxK030pxJa2LpAuwJkXgPESYNPEkqq6OGJePpBxpKaQETTP3YGfBTFPb+LaOFAiB7B+4 HnM= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="75909810" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:19:01 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:03 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:02 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 4/7] staging: most: usb: use dev_dbg function Date: Thu, 14 May 2020 17:18:49 +0200 Message-ID: <1589469532-21488-5-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch replaces the functions dev_notice with dev_dbg to silence the driver during normal operation. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index d5c73cb..c3a7e71 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -1035,17 +1035,17 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) init_usb_anchor(&mdev->busy_urbs[i]); spin_lock_init(&mdev->channel_lock[i]); } - dev_notice(dev, "claimed gadget: Vendor=%4.4x ProdID=%4.4x Bus=%02x Device=%02x\n", - le16_to_cpu(usb_dev->descriptor.idVendor), - le16_to_cpu(usb_dev->descriptor.idProduct), - usb_dev->bus->busnum, - usb_dev->devnum); - - dev_notice(dev, "device path: /sys/bus/usb/devices/%d-%s:%d.%d\n", - usb_dev->bus->busnum, - usb_dev->devpath, - usb_dev->config->desc.bConfigurationValue, - usb_iface_desc->desc.bInterfaceNumber); + dev_dbg(dev, "claimed gadget: Vendor=%4.4x ProdID=%4.4x Bus=%02x Device=%02x\n", + le16_to_cpu(usb_dev->descriptor.idVendor), + le16_to_cpu(usb_dev->descriptor.idProduct), + usb_dev->bus->busnum, + usb_dev->devnum); + + dev_dbg(dev, "device path: /sys/bus/usb/devices/%d-%s:%d.%d\n", + usb_dev->bus->busnum, + usb_dev->devpath, + usb_dev->config->desc.bConfigurationValue, + usb_iface_desc->desc.bInterfaceNumber); ret = most_register_interface(&mdev->iface); if (ret) From patchwork Thu May 14 15:18:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549097 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 334D4697 for ; Thu, 14 May 2020 15:19:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1258C20748 for ; Thu, 14 May 2020 15:19:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="h6v2Z/Fj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727836AbgENPTD (ORCPT ); Thu, 14 May 2020 11:19:03 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:3694 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgENPTC (ORCPT ); Thu, 14 May 2020 11:19:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469542; x=1621005542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=/UWZL9NYOlen4KPZDTsNBZyFf3AQGXvl6hp1Di1o6k4=; b=h6v2Z/Fjb02urvLA16smsIXvprfD4XlOVtyPpt6o22YC3M3RhkiWHYKP /8BdakIg6uyyiL+2BAv6UmTc/f9jHOng6z8skgGTjffR4kUqgR4paY96W 4RSfxUL5DBVOJNdZQtmUtuMR9qpIUfl92w1ehx254oFyMm7hAZJgYrcaS qgXculiCRbj+5BhCN2o6A+B6+CLWGgCkZEujo9MoCMoe5iQWXppDolUBA 0jWXOM/5EbE+o/hNAID16dxaYhIoJDUwhjn5LNcXWtCGToSOP+DSKdc54 q/9xnivSG7R+YBqA2PxpZszhEYOVA590ZoR+JBpTo4pKKgtRhv2jW/yyH w==; IronPort-SDR: tnlGKB5IBYztJTaNWgmN7PR9xbHlq7tCM4FXfUU30Cm9eevqlGiRDtgh7sGjdKWzChGV3yoe8J 7qU5tkJJsGybwt1TrpUdhuAwoTV9/F6Y++38cp3D2mxndUZl3X/nTR0kmYsgYqF591YGVzNTGj BEC/DKZljD9+MyEYtENYq3/jUMFQPULXv56qi51oGgYNUmjiHk3pyEdyE+yaMgcxACDNI0jumr 4kp7hDCDpteEfXYlo54EIhvAfVMXNf8F0ldkcaBsUWiq6+YDbQIFGFH0MBBRDawya4z4T5Z2uL uy0= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="76658384" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:19:01 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:01 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:04 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 5/7] staging: most: fix typo in Kconfig Date: Thu, 14 May 2020 17:18:50 +0200 Message-ID: <1589469532-21488-6-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch corrects the typo in the Kconfig file where it says tranceiver instead of transceiver. Signed-off-by: Christian Gromm Reported-by: Randy Dunlap --- v2: drivers/staging/most/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/usb/Kconfig b/drivers/staging/most/usb/Kconfig index a86f1f6..75dc25c 100644 --- a/drivers/staging/most/usb/Kconfig +++ b/drivers/staging/most/usb/Kconfig @@ -7,7 +7,7 @@ config MOST_USB tristate "USB" depends on USB && NET help - Say Y here if you want to connect via USB to network tranceiver. + Say Y here if you want to connect via USB to network transceiver. This device driver depends on the networking AIM. To compile this driver as a module, choose M here: the From patchwork Thu May 14 15:18:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549099 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2819D14B7 for ; Thu, 14 May 2020 15:19:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06B5C206A5 for ; Thu, 14 May 2020 15:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="OqznM+Ag" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgENPTE (ORCPT ); Thu, 14 May 2020 11:19:04 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:3694 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgENPTD (ORCPT ); Thu, 14 May 2020 11:19:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469543; x=1621005543; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=W6BQ6mxoNRUm2J3Dfm7jT8zQ6cFnZYAQRLmbegyRkTA=; b=OqznM+AgK4fF1giE9atpda2sAR7PfEf/0nxzhzTrmZ9KxrdEC1Z1nAZT hKykZGCZGeLoEZyA796hcZbbGWkLiAQcjAPnZ0MNNfF3oLKJW7jg/wtmt qNfW37hjHTJfdbEXzipWXp4/WvyCeeHQdTcljvh+BTqJnC++8YcN89Kh4 OAVIj0jY5xEU9B+T3Cm1fz28N7DHuJBSw+jceA8ho9naa8/UYBydCwpjN in6YyqfAzFLKdrGrwmT53Fsva/4HkhDlu8bZzy+v4iO96BC4xOfyVYhh5 k2rZMTx6yOtRApExn8KtxuSAyq2dsO8N+f1VFkY+kxtgsEtxFnrCRyV97 A==; IronPort-SDR: Fk+0sB9yuk1N8IuygQd/bDxSuq/YoMwFPFC5/6BCZ6GIzBhDg4poK9xuchJ8WZ+Nu7CYf1CIfm wNymDxOlRnhOeY6JlKPPriIT6dEnpO5H3gMyfranDLp33GTmgDK0y9R3qwDbLs/sbAmsF7/hKG oNad/vNmaOvaE0luPASTibB6vBZLJP/Ojyis3ZCO6dRSgz6clBJOFkfwAj3XK5CTA7x4S7Ctiu 4FN0A17IvspISZunQWDbStjT6qmmsp98urYcCHxpe5n1SynMNhnzGh670wpoMlQkMIG3z8WRS4 mTk= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="76658391" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:19:03 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:02 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:05 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS Date: Thu, 14 May 2020 17:18:51 +0200 Message-ID: <1589469532-21488-7-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups instead of defining them manually. Signed-off-by: Christian Gromm Reported-by: Greg Kroah-Hartman --- v2: drivers/staging/most/usb/usb.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index c3a7e71..43f535f 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -905,14 +905,7 @@ static struct attribute *dci_attrs[] = { NULL, }; -static struct attribute_group dci_attr_group = { - .attrs = dci_attrs, -}; - -static const struct attribute_group *dci_attr_groups[] = { - &dci_attr_group, - NULL, -}; +ATTRIBUTE_GROUPS(dci); static void release_dci(struct device *dev) { @@ -1065,7 +1058,7 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) mdev->dci->dev.init_name = "dci"; mdev->dci->dev.parent = get_device(mdev->iface.dev); - mdev->dci->dev.groups = dci_attr_groups; + mdev->dci->dev.groups = dci_groups; mdev->dci->dev.release = release_dci; if (device_register(&mdev->dci->dev)) { mutex_unlock(&mdev->io_mutex); From patchwork Thu May 14 15:18:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11549101 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2558214B7 for ; Thu, 14 May 2020 15:19:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED9EB20728 for ; Thu, 14 May 2020 15:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="SHH6gUmh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgENPTF (ORCPT ); Thu, 14 May 2020 11:19:05 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:3694 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgENPTE (ORCPT ); Thu, 14 May 2020 11:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1589469544; x=1621005544; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=7sr8R+a8FhyrV5tLGE/O2dQuzK7UJ6QXJnSbaWaRDsg=; b=SHH6gUmhoImZls/obSLpSow6a8lOBkhKmdcOSeYlbUS/FngYvvXF1nsF Xj6ktj79DSyGgslOAEYPz+ha/APZZ9gtCsHL4N8860/32/N0uyoZsYo6x x9Dg8by3m8fnqBSVEx5cYKgD2mgfVPE5MButePOD4TTV8asioLosJAGg5 NtZJTlao3F185ROww7Sh9aSdp8FHi3+5FEAEIIwRae9UwHv6lXds+o7cX k85p1zEU8EYWgGR+OshsVaxD2Gm6V1S/uX/Dd89av6d5l4HMZ3lYLo2pk oWJ9mmaQyVfc85JJTMcEoFOJzW43Hc83VHSVDT4Ua4CK6oFEHT76Ef/au w==; IronPort-SDR: KYQDBIzhp2qmwhM8okMn3pwashUNjhNt/nTYIiWUsJOqmPypr25vApWnIF24Y2sMxbe8z9bmYl ZL+ghFM9IaT1NWLsPraP76VgwWtkpQ0kuvbH2cBGfu4gbJuujX0mNzJkRgQBoCTVt2rs9aPPl1 zU9c7FTDqXnYyMSnGYcOo1K71Y1Wzx3GSt1hGsMpuentkQI8rvRzcvRtVbvWUJ+vfuPvIa3l8r 8wvydZcxo0zPeqJ71cbWgOzchpam/PWYJHURQ/iwY0QWDFP9y5uG089CiPpKWblR1dwZ3bfNv/ /D4= X-IronPort-AV: E=Sophos;i="5.73,391,1583218800"; d="scan'208";a="76658398" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 May 2020 08:19:04 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 May 2020 08:19:04 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Thu, 14 May 2020 08:19:06 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH v2 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver Date: Thu, 14 May 2020 17:18:52 +0200 Message-ID: <1589469532-21488-8-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> References: <1589469532-21488-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch fixes the ABI description file sysfs-bus-most. Signed-off-by: Christian Gromm --- v2: Documentation/ABI/testing/sysfs-bus-most | 104 ++++++++++++++++--------------- 1 file changed, 53 insertions(+), 51 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-most b/Documentation/ABI/testing/sysfs-bus-most index 6b1d06e..ec0a603 100644 --- a/Documentation/ABI/testing/sysfs-bus-most +++ b/Documentation/ABI/testing/sysfs-bus-most @@ -1,14 +1,14 @@ -What: /sys/bus/most/devices/.../description +What: /sys/bus/most/devices//description Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Provides information about the interface type and the physical - location of the device. Hardware attached via USB, for instance, + Provides information about the physical location of the + device. Hardware attached via USB, for instance, might return <1-1.1:1.0> Users: -What: /sys/bus/most/devices/.../interface +What: /sys/bus/most/devices//interface Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm @@ -16,7 +16,7 @@ Description: Indicates the type of peripheral interface the device uses. Users: -What: /sys/bus/most/devices/.../dci +What: /sys/bus/most/devices//dci Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -26,7 +26,7 @@ Description: write the controller's DCI registers. Users: -What: /sys/bus/most/devices/.../dci/arb_address +What: /sys/bus/most/devices//dci/arb_address Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -35,7 +35,7 @@ Description: application wants to read from or write to. Users: -What: /sys/bus/most/devices/.../dci/arb_value +What: /sys/bus/most/devices//dci/arb_value Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -44,7 +44,7 @@ Description: is stored in arb_address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_hi +What: /sys/bus/most/devices//dci/mep_eui48_hi Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -52,7 +52,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_lo +What: /sys/bus/most/devices//dci/mep_eui48_lo Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -60,7 +60,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_eui48_mi +What: /sys/bus/most/devices//dci/mep_eui48_mi Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -68,7 +68,7 @@ Description: This is used to check and configure the MAC address. Users: -What: /sys/bus/most/devices/.../dci/mep_filter +What: /sys/bus/most/devices//dci/mep_filter Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -76,7 +76,7 @@ Description: This is used to check and configure the MEP filter address. Users: -What: /sys/bus/most/devices/.../dci/mep_hash0 +What: /sys/bus/most/devices//dci/mep_hash0 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -84,7 +84,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash1 +What: /sys/bus/most/devices//dci/mep_hash1 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -92,7 +92,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash2 +What: /sys/bus/most/devices//dci/mep_hash2 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -100,7 +100,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/mep_hash3 +What: /sys/bus/most/devices//dci/mep_hash3 Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -108,7 +108,7 @@ Description: This is used to check and configure the MEP hash table. Users: -What: /sys/bus/most/devices/.../dci/ni_state +What: /sys/bus/most/devices//dci/ni_state Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -116,7 +116,7 @@ Description: Indicates the current network interface state. Users: -What: /sys/bus/most/devices/.../dci/node_address +What: /sys/bus/most/devices//dci/node_address Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -124,7 +124,7 @@ Description: Indicates the current node address. Users: -What: /sys/bus/most/devices/.../dci/node_position +What: /sys/bus/most/devices//dci/node_position Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -132,7 +132,7 @@ Description: Indicates the current node position. Users: -What: /sys/bus/most/devices/.../dci/packet_bandwidth +What: /sys/bus/most/devices//dci/packet_bandwidth Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -140,7 +140,7 @@ Description: Indicates the configured packet bandwidth. Users: -What: /sys/bus/most/devices/.../dci/sync_ep +What: /sys/bus/most/devices//dci/sync_ep Date: June 2016 KernelVersion: 4.15 Contact: Christian Gromm @@ -149,7 +149,7 @@ Description: endpoint. Users: -What: /sys/bus/most/devices/...// +What: /sys/bus/most/devices/// Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm @@ -160,91 +160,92 @@ Description: configure it. Users: -What: /sys/bus/most/devices/...//available_datatypes +What: /sys/bus/most/devices///available_datatypes Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the data types the current channel can transport. + Indicates the data types the channel can transport. Users: -What: /sys/bus/most/devices/...//available_directions +What: /sys/bus/most/devices///available_directions Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the directions the current channel is capable of. + Indicates the directions the channel is capable of. Users: -What: /sys/bus/most/devices/...//number_of_packet_buffers +What: /sys/bus/most/devices///number_of_packet_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the number of packet buffers the current channel can + Indicates the number of packet buffers the channel can handle. Users: -What: /sys/bus/most/devices/...//number_of_stream_buffers +What: /sys/bus/most/devices///number_of_stream_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the number of streaming buffers the current channel can + Indicates the number of streaming buffers the channel can handle. Users: -What: /sys/bus/most/devices/...//size_of_packet_buffer +What: /sys/bus/most/devices///size_of_packet_buffer Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the size of a packet buffer the current channel can + Indicates the size of a packet buffer the channel can handle. Users: -What: /sys/bus/most/devices/...//size_of_stream_buffer +What: /sys/bus/most/devices///size_of_stream_buffer Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates the size of a streaming buffer the current channel can + Indicates the size of a streaming buffer the channel can handle. Users: -What: /sys/bus/most/devices/...//set_number_of_buffers +What: /sys/bus/most/devices///set_number_of_buffers Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the number of buffers of the current channel. + This is to read back the configured number of buffers of + the channel. Users: -What: /sys/bus/most/devices/...//set_buffer_size +What: /sys/bus/most/devices///set_buffer_size Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the size of a buffer of the current channel. + This is to read back the configured buffer size of the channel. Users: -What: /sys/bus/most/devices/...//set_direction +What: /sys/bus/most/devices///set_direction Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the direction of the current channel. + This is to read back the configured direction of the channel. The following strings will be accepted: - 'dir_tx', - 'dir_rx' + 'tx', + 'rx' Users: -What: /sys/bus/most/devices/...//set_datatype +What: /sys/bus/most/devices///set_datatype Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the data type of the current channel. + This is to read back the configured data type of the channel. The following strings will be accepted: 'control', 'async', @@ -252,30 +253,31 @@ Description: 'isoc_avp' Users: -What: /sys/bus/most/devices/...//set_subbuffer_size +What: /sys/bus/most/devices///set_subbuffer_size Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the subbuffer size of the current channel. + This is to read back the configured subbuffer size of + the channel. Users: -What: /sys/bus/most/devices/...//set_packets_per_xact +What: /sys/bus/most/devices///set_packets_per_xact Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - This is to configure the number of packets per transaction of - the current channel. This is only needed network interface - controller is attached via USB. + This is to read back the configured number of packets per + transaction of the channel. This is only applicable when + connected via USB. Users: -What: /sys/bus/most/devices/...//channel_starving +What: /sys/bus/most/devices///channel_starving Date: March 2017 KernelVersion: 4.15 Contact: Christian Gromm Description: - Indicates whether current channel ran out of buffers. + Indicates whether channel ran out of buffers. Users: What: /sys/bus/most/drivers/most_core/components