From patchwork Thu May 14 16:10:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549235 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C14A60D for ; Thu, 14 May 2020 16:12:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A2A62065D for ; Thu, 14 May 2020 16:12:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E/ANDeyM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQGQsvBo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A2A62065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=D89TRY47Zj7/ov9zm3oKKFWpuMamksChXbYcSrnyakI=; b=E/ANDeyMzct6/bxPpA4cU8ZtWR P5mgUDfesCbGJ1u47sfMaO9JuSOw1kV2oqlciZ+ma+c1h2/0/91Sde7mi3yLfglUSj2E4Bm57iv4c 9Xx9F9/GH+JFWjaO1ao+Z7Y4u/z0orzn1M8D1Fy7hYYG05L7TdUsbLuBvriFXYzamrjCfKyopU7lF +VoAqMGn+dp+BcGlKDnNEViBQ5t9538piWdcDLhJnKyJxoF3PJazaLPT1Y7r0zuVVGtg6iq1kerMG DzYFeddoMYfXvXWgqwspsjNEA2DEazEfltnAZC3EL9ZGfeYUSL+lyGYEOSxpECgHDOCrI6fGd/sLC oWwXjF9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGTI-0004aB-BW; Thu, 14 May 2020 16:12:32 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSY-00040r-GP; Thu, 14 May 2020 16:11:48 +0000 Received: by mail-pf1-x442.google.com with SMTP id x77so1517666pfc.0; Thu, 14 May 2020 09:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=APuaLgIC8QwM4HVjAlkT/Q/E4FOhXs/Y+oj3WvF1K8Q=; b=mQGQsvBohAwHSmGMdJkoWBlfGJiVrUzdEnS9Jk2tgFVbIkdKIy+JDBVgw+T2lNnvII IgRSmEQSUBMOCxXCS68zA+oJ4uLTPQQ0/CaUYwE8HysRc3ve6u8Nk44TKzkDAyr1+GvV EHQrvk0VemZzCmfaa5NazBkf4K3LKMCZfDkVvUD4bUNZEMZKPFgZCIYQIZN/Cq4bojta JfRVbsZaTJMpoJFqNZiPnkXUkA/vWYSZDKPTDv3RtNAghICy5Vhww1ENPs6OWbZ/vEpb za5XiT9Mwim7TtWgysVWYnvNgBA3wzHIW0ma0JjpXj4Aq4RqE4NaTAtdGtlTeoEsWUN7 aQBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=APuaLgIC8QwM4HVjAlkT/Q/E4FOhXs/Y+oj3WvF1K8Q=; b=HhDI2XAghkO95FoxhGHQ2nYsg7AjuJrYlWMM2UuyL1kKq0opcUbHodqpEP29ceIZbZ k5oUPpckJysVsbB0yZDaVjBkSmcLXanC+v/ZlY8yacjSIl+tnwlEr4+XUy2gcqvuAtYY h84xYTJgq9hqJVjd3d9tm56OVoCdma3iXG4yn+n++cvj2w8eZk2bdBkyEQiB5uo1cm9b wfxmxOaeFEGeb2E4CIf3FvtqErDgXHPa8fC6yjRICbNOS3E+hBaHaZtTirgzeYGHy1we WGKjH3Qp7z4cqOBrzckE2YPC6w+dM5YElqPiIKkiIYgabixa12b62NhURtdaOYh+Xddl 6z4A== X-Gm-Message-State: AOAM531MHBwqU6nYzju3ja+MYxbXsFfmg82BdGKxebJpZHUoJK4216p4 1eFqLzmv8L4Ud6wkKUJzJLI1Tgemq9P/5w== X-Google-Smtp-Source: ABdhPJwS6b90IBbLq7Bu8zFNMTmjukuliSI6GNd3G/1q7ScpIxaYaWmA/P2MaqU5yssWGQiS8XUVgg== X-Received: by 2002:aa7:8c47:: with SMTP id e7mr4890183pfd.98.1589472705523; Thu, 14 May 2020 09:11:45 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.11.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:11:44 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, vkoul@kernel.org, afaerber@suse.de, manivannan.sadhasivam@linaro.org Subject: [PATCH v1 1/9] dmaengine: Actions: get rid of bit fields from dma descriptor Date: Thu, 14 May 2020 21:40:49 +0530 Message-Id: <1589472657-3930-2-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091146_547870_ED43D493 X-CRM114-Status: GOOD ( 17.12 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org At the moment, Driver uses bit fields to describe registers of the DMA descriptor structure that makes it less portable and maintainable, and Andre suugested(and even sketched important bits for it) to make use of array to describe this DMA descriptors instead. It gives the flexibility while extending support for other platform such as Actions S700. This commit removes the "owl_dma_lli_hw" (that includes bit-fields) and uses array to describe DMA descriptor. Suggested-by: Andre Przywara Signed-off-by: Amit Singh Tomar --- Changes since RFC: * No change from RFC. --- drivers/dma/owl-dma.c | 77 ++++++++++++++++++++++----------------------------- 1 file changed, 33 insertions(+), 44 deletions(-) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index c683051257fd..b0d80a2fa383 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -120,30 +120,18 @@ #define BIT_FIELD(val, width, shift, newshift) \ ((((val) >> (shift)) & ((BIT(width)) - 1)) << (newshift)) -/** - * struct owl_dma_lli_hw - Hardware link list for dma transfer - * @next_lli: physical address of the next link list - * @saddr: source physical address - * @daddr: destination physical address - * @flen: frame length - * @fcnt: frame count - * @src_stride: source stride - * @dst_stride: destination stride - * @ctrla: dma_mode and linklist ctrl config - * @ctrlb: interrupt config - * @const_num: data for constant fill - */ -struct owl_dma_lli_hw { - u32 next_lli; - u32 saddr; - u32 daddr; - u32 flen:20; - u32 fcnt:12; - u32 src_stride; - u32 dst_stride; - u32 ctrla; - u32 ctrlb; - u32 const_num; +/* Describe DMA descriptor, hardware link list for dma transfer */ +enum owl_dmadesc_offsets { + OWL_DMADESC_NEXT_LLI = 0, + OWL_DMADESC_SADDR, + OWL_DMADESC_DADDR, + OWL_DMADESC_FLEN, + OWL_DMADESC_SRC_STRIDE, + OWL_DMADESC_DST_STRIDE, + OWL_DMADESC_CTRLA, + OWL_DMADESC_CTRLB, + OWL_DMADESC_CONST_NUM, + OWL_DMADESC_SIZE }; /** @@ -153,7 +141,7 @@ struct owl_dma_lli_hw { * @node: node for txd's lli_list */ struct owl_dma_lli { - struct owl_dma_lli_hw hw; + u32 hw[OWL_DMADESC_SIZE]; dma_addr_t phys; struct list_head node; }; @@ -351,8 +339,9 @@ static struct owl_dma_lli *owl_dma_add_lli(struct owl_dma_txd *txd, list_add_tail(&next->node, &txd->lli_list); if (prev) { - prev->hw.next_lli = next->phys; - prev->hw.ctrla |= llc_hw_ctrla(OWL_DMA_MODE_LME, 0); + prev->hw[OWL_DMADESC_NEXT_LLI] = next->phys; + prev->hw[OWL_DMADESC_CTRLA] |= + llc_hw_ctrla(OWL_DMA_MODE_LME, 0); } return next; @@ -365,8 +354,7 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, struct dma_slave_config *sconfig, bool is_cyclic) { - struct owl_dma_lli_hw *hw = &lli->hw; - u32 mode; + u32 mode, ctrlb; mode = OWL_DMA_MODE_PW(0); @@ -407,22 +395,22 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, return -EINVAL; } - hw->next_lli = 0; /* One link list by default */ - hw->saddr = src; - hw->daddr = dst; - - hw->fcnt = 1; /* Frame count fixed as 1 */ - hw->flen = len; /* Max frame length is 1MB */ - hw->src_stride = 0; - hw->dst_stride = 0; - hw->ctrla = llc_hw_ctrla(mode, - OWL_DMA_LLC_SAV_LOAD_NEXT | - OWL_DMA_LLC_DAV_LOAD_NEXT); + lli->hw[OWL_DMADESC_CTRLA] = llc_hw_ctrla(mode, + OWL_DMA_LLC_SAV_LOAD_NEXT | + OWL_DMA_LLC_DAV_LOAD_NEXT); if (is_cyclic) - hw->ctrlb = llc_hw_ctrlb(OWL_DMA_INTCTL_BLOCK); + ctrlb = llc_hw_ctrlb(OWL_DMA_INTCTL_BLOCK); else - hw->ctrlb = llc_hw_ctrlb(OWL_DMA_INTCTL_SUPER_BLOCK); + ctrlb = llc_hw_ctrlb(OWL_DMA_INTCTL_SUPER_BLOCK); + + lli->hw[OWL_DMADESC_NEXT_LLI] = 0; + lli->hw[OWL_DMADESC_SADDR] = src; + lli->hw[OWL_DMADESC_DADDR] = dst; + lli->hw[OWL_DMADESC_SRC_STRIDE] = 0; + lli->hw[OWL_DMADESC_DST_STRIDE] = 0; + lli->hw[OWL_DMADESC_FLEN] = len | 1 << 20; + lli->hw[OWL_DMADESC_CTRLB] = ctrlb; return 0; } @@ -754,7 +742,8 @@ static u32 owl_dma_getbytes_chan(struct owl_dma_vchan *vchan) /* Start from the next active node */ if (lli->phys == next_lli_phy) { list_for_each_entry(lli, &txd->lli_list, node) - bytes += lli->hw.flen; + bytes += lli->hw[OWL_DMADESC_FLEN] & + GENMASK(19, 0); break; } } @@ -785,7 +774,7 @@ static enum dma_status owl_dma_tx_status(struct dma_chan *chan, if (vd) { txd = to_owl_txd(&vd->tx); list_for_each_entry(lli, &txd->lli_list, node) - bytes += lli->hw.flen; + bytes += lli->hw[OWL_DMADESC_FLEN] & GENMASK(19, 0); } else { bytes = owl_dma_getbytes_chan(vchan); } From patchwork Thu May 14 16:10:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549237 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD60D618 for ; Thu, 14 May 2020 16:12:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86B552065D for ; Thu, 14 May 2020 16:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hHCj4Gy4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XB674fNp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86B552065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/DDIGyVTcWRGJEiEb2Swc1NB5WVVhrk7RhkOdUXDnEo=; b=hHCj4Gy4spNBjRmRFkGkXfz5M2 QWAgJp1S9DjXtE5ntzT1bvcSAToj00g6PNKrAKFBMeNhjQrxsbdQVx9Q1pjaGE1Dk1J40Mc9FdbRm 6A/foXw7HYQeIp2r/6i4mcGx4+K2H5RW/4X9l270/xsV9w19oqLkNhITk2XkH0u7FWTw2IqHVNj7w HG0wglET6lm9Rz7KHN5zLEqLpUcFUDI16mW4z4oFXfaX1yehlIrOqZfP5t9MNAb+Zkj5BC/wY7KT6 ZDmP7GzOk63Iun6tATpeICcTnp8GFOM11qr/NLjGKCHpULTqDnqAWoV9YCQORFR6gd4zpidMhHrbz lD/o6LYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGTZ-0004nl-Ry; Thu, 14 May 2020 16:12:49 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSd-00045d-Ll; Thu, 14 May 2020 16:11:53 +0000 Received: by mail-pj1-x1042.google.com with SMTP id z15so3096915pjb.0; Thu, 14 May 2020 09:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9fV5j8sOG/Soznuq8VAGR0RqzJqSwDfkCf7U4jRW15Y=; b=XB674fNpCkVfFAvljox/XXiF9FYuhispHDqy/LvVa52BMMWsPlD45UsFBzAmOdZGrn 2yUhRF45w2aaOT4toKMzgIlJ2dtDwppawPXCN8vycusNotzPApLVeEfEzMVPWsxy0woQ nCr6KNuIcP8UB8keZwX+20DVVNHpA3+iYVxKdzKALg4EFmiwF3UkZ7A0YtYhNF2+aG/k Dvr8z8kLOOJIoacxDRe6wQ0vtyj8MW+7xEh5Kv/bSUJXXLYOiyOPoxmSKUKPlAJMliaL yPSKA5z1/z99nRWIGHqtzdbAj+B/amxRAGaGL9qVsapMeaExU/TlPObrAX+rHQybqy+m H2gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9fV5j8sOG/Soznuq8VAGR0RqzJqSwDfkCf7U4jRW15Y=; b=Xb3quI4Q8+W8JT6Ih6KJTpaEiu1zmw0yBrJXZBd8oc+YqrnzrtO55eVic4Tyfpp3wl LFgtK+a+mqrS8nuq1iwzCqDBzlz383bXCQx72jzI0GucosxYNxSJjmHmlnlZZtqG//1p Mq3p5CSlaffDcV87QRqwGykcQOIEDkpaCDJE1ff1RFctxY/yI5C+s2l6C6lmioJXNauN uNAvtUe1f2u1kb/NF5dY/MKQoVAvet8zG2tK3hyhCN548zXRXmHknzwHGnS38yEITvlv XyDOErnhS/txNCPAs581B4XHKRrgzHF13xanaO9fe1dqOux6yVlFey7yC+qDEEeaH0op LKjg== X-Gm-Message-State: AOAM532+rX2fH2ig6XXNWmnFaNRwxDLr2ltR8Sos3jKXKHUi9Gp4SpUP WV/rca2e7zKTaos5uEt8RrM= X-Google-Smtp-Source: ABdhPJyM3l1jZefp/L/7D+K4oY6HdUnNSnRtNv3vvopsPp2rumOF7OQ8zPFUx7Q8RL78swJROPK1qQ== X-Received: by 2002:a17:902:8c89:: with SMTP id t9mr4673253plo.131.1589472709957; Thu, 14 May 2020 09:11:49 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.11.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:11:49 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, vkoul@kernel.org, afaerber@suse.de, manivannan.sadhasivam@linaro.org Subject: [PATCH v1 2/9] dmaengine: Actions: Add support for S700 DMA engine Date: Thu, 14 May 2020 21:40:50 +0530 Message-Id: <1589472657-3930-3-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091151_720118_DC504BCF X-CRM114-Status: GOOD ( 17.69 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1042 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DMA controller present on S700 SoC is compatible with the one on S900 (as most of registers are same), but it has different DMA descriptor structure where registers "fcnt" and "ctrlb" uses different encoding. For instance, on S900 "fcnt" starts at offset 0x0c and uses upper 12 bits whereas on S700, it starts at offset 0x1c and uses lower 12 bits. This commit adds support for DMA controller present on S700. Signed-off-by: Amit Singh Tomar --- Changes since RFC: * Added accessor function to get the frame lenght. * Removed the SoC specific check in IRQ routine. --- drivers/dma/owl-dma.c | 50 +++++++++++++++++++++++++++++++++++++------------- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c index b0d80a2fa383..afa6c6f43d26 100644 --- a/drivers/dma/owl-dma.c +++ b/drivers/dma/owl-dma.c @@ -134,6 +134,11 @@ enum owl_dmadesc_offsets { OWL_DMADESC_SIZE }; +enum owl_dma_id { + S900_DMA, + S700_DMA, +}; + /** * struct owl_dma_lli - Link list for dma transfer * @hw: hardware link list @@ -200,6 +205,7 @@ struct owl_dma_vchan { * @pchans: array of data for the physical channels * @nr_vchans: the number of physical channels * @vchans: array of data for the physical channels + * @devid: device id based on OWL SoC */ struct owl_dma { struct dma_device dma; @@ -214,6 +220,7 @@ struct owl_dma { unsigned int nr_vchans; struct owl_dma_vchan *vchans; + enum owl_dma_id devid; }; static void pchan_update(struct owl_dma_pchan *pchan, u32 reg, @@ -308,6 +315,11 @@ static inline u32 llc_hw_ctrlb(u32 int_ctl) return ctl; } +static inline u32 llc_hw_flen(struct owl_dma_lli *lli) +{ + return lli->hw[OWL_DMADESC_FLEN] & GENMASK(19, 0); +} + static void owl_dma_free_lli(struct owl_dma *od, struct owl_dma_lli *lli) { @@ -354,6 +366,7 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, struct dma_slave_config *sconfig, bool is_cyclic) { + struct owl_dma *od = to_owl_dma(vchan->vc.chan.device); u32 mode, ctrlb; mode = OWL_DMA_MODE_PW(0); @@ -409,8 +422,14 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan *vchan, lli->hw[OWL_DMADESC_DADDR] = dst; lli->hw[OWL_DMADESC_SRC_STRIDE] = 0; lli->hw[OWL_DMADESC_DST_STRIDE] = 0; - lli->hw[OWL_DMADESC_FLEN] = len | 1 << 20; - lli->hw[OWL_DMADESC_CTRLB] = ctrlb; + + if (od->devid == S700_DMA) { + lli->hw[OWL_DMADESC_FLEN] = len; + lli->hw[OWL_DMADESC_CTRLB] = 1 | ctrlb; + } else { + lli->hw[OWL_DMADESC_FLEN] = len | 1 << 20; + lli->hw[OWL_DMADESC_CTRLB] = ctrlb; + } return 0; } @@ -572,7 +591,7 @@ static irqreturn_t owl_dma_interrupt(int irq, void *dev_id) global_irq_pending = dma_readl(od, OWL_DMA_IRQ_PD0); - if (chan_irq_pending && !(global_irq_pending & BIT(i))) { + if (chan_irq_pending && !(global_irq_pending & BIT(i))) { dev_dbg(od->dma.dev, "global and channel IRQ pending match err\n"); @@ -741,9 +760,9 @@ static u32 owl_dma_getbytes_chan(struct owl_dma_vchan *vchan) list_for_each_entry(lli, &txd->lli_list, node) { /* Start from the next active node */ if (lli->phys == next_lli_phy) { - list_for_each_entry(lli, &txd->lli_list, node) - bytes += lli->hw[OWL_DMADESC_FLEN] & - GENMASK(19, 0); + list_for_each_entry(lli, &txd->lli_list, + node) + bytes += llc_hw_flen(lli); break; } } @@ -774,7 +793,7 @@ static enum dma_status owl_dma_tx_status(struct dma_chan *chan, if (vd) { txd = to_owl_txd(&vd->tx); list_for_each_entry(lli, &txd->lli_list, node) - bytes += lli->hw[OWL_DMADESC_FLEN] & GENMASK(19, 0); + bytes += llc_hw_flen(lli); } else { bytes = owl_dma_getbytes_chan(vchan); } @@ -1031,11 +1050,20 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec, return chan; } +static const struct of_device_id owl_dma_match[] = { + { .compatible = "actions,s900-dma", .data = (void *)S900_DMA,}, + { .compatible = "actions,s700-dma", .data = (void *)S700_DMA,}, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, owl_dma_match); + static int owl_dma_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; struct owl_dma *od; int ret, i, nr_channels, nr_requests; + const struct of_device_id *of_id = + of_match_device(owl_dma_match, &pdev->dev); od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL); if (!od) @@ -1060,6 +1088,8 @@ static int owl_dma_probe(struct platform_device *pdev) dev_info(&pdev->dev, "dma-channels %d, dma-requests %d\n", nr_channels, nr_requests); + od->devid = (enum owl_dma_id)of_id->data; + od->nr_pchans = nr_channels; od->nr_vchans = nr_requests; @@ -1192,12 +1222,6 @@ static int owl_dma_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id owl_dma_match[] = { - { .compatible = "actions,s900-dma", }, - { /* sentinel */ } -}; -MODULE_DEVICE_TABLE(of, owl_dma_match); - static struct platform_driver owl_dma_driver = { .probe = owl_dma_probe, .remove = owl_dma_remove, From patchwork Thu May 14 16:10:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 30DFC60D for ; Thu, 14 May 2020 16:13:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2AAF2065D for ; Thu, 14 May 2020 16:13:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UknXmxjv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H1ctdj6x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2AAF2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Fl8kachJ4g4aaUa7Sya1P+JqTi0YUzM1QRybcMXLT8A=; b=UknXmxjv3O91dPq/R0yCjwH/Sr Icoe0BBbFdPEIDyuJgMjczJH0cYT/cEu0ROoU7X2hYSeSudOqQyVbt5h/F5d9KIFh3cw/DOZL2IEL fPy7Q81wV8PBIGonQMRAcALRtE7qZl/oPvXOkIkImgi89qxC4tZkGHoOgp8L7zc/iDZ1OiwhN80EE TLFnZyDbQlRANHPjkZBYTbvi+H/6tbWRvYooFoxCeX6cCfXg8ncrbYsfrc7j0UkFMbYi0tNMHqgmw yadTERrkq6nPTQbzQ/EIdEt5j8bXHrFZZpZwQcp8WcCW1g5PVCZ0jeJTmb2MeQTbUPsS3loZ7kxBj T9RA7JCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGTl-00050W-Ox; Thu, 14 May 2020 16:13:01 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSh-0004A7-D3; Thu, 14 May 2020 16:11:56 +0000 Received: by mail-pj1-x1041.google.com with SMTP id ms17so12650793pjb.0; Thu, 14 May 2020 09:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5xFCp8lZ8d3/LVRg1uj5rGVixKp+9QOEo4qBkaPPqRQ=; b=H1ctdj6xjeSjG2aV+fBkoXX35PD+cWMRd8QYRNRzxan+pZScVvZ2yvNPuhW2JimRat gtuAElvAUvYbNWnkFxiunSQ2jd9wMrkUC/r4KgSDUAUtS2QVpXOuFn7XT7WYY67Krgzw DsR9GgwQm11fER+ocWf8ayOO+eSmTRw6p/dVUMeTgJog+tEoM4b27CtsUXkCwyp+HDE1 wumUpNFjt0LwEFDqCUM59G7+w0yExmoqLAAVthonjrQ9EqfmuGINuW5kDOJzU7Bpdt9P 3k3nPVuYX3TogxNLSCbpu/C9MHcxdaOSjxQXuJQ4hExLt5UiHS0yFztic8OXLM3KsVZQ a60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5xFCp8lZ8d3/LVRg1uj5rGVixKp+9QOEo4qBkaPPqRQ=; b=FbfmPGruK5WDR3hu9CCNpyrRkG+C/Shi0zJgmusH13fRAv10sNLfjyhOb/f8iv0HvJ 8PUJeqwlH/5ZglfQGHvTJzN6t/Slev7+JUWznZTFb+/U0ZXbKZE07gLaxdaj+0OtaEPl hCoVybrpSAZNc2rnF3q9LdjF9/Am6scIEDamMR8oMbfmxqQ2pqdIw6AbnmBKIQPkfkLc FGrotlVzCdVuk5pnul2vN/iKwOupZeC2+kNxTViGId5yosvUUZyZVhXmtmJ0mKvobB/k tMAOUxRVdQHCU6fOc/VCQLjcPHWkECM42KBBm3g0KOAi0oToB33ieZrF6zS5tugIZNe2 Zeow== X-Gm-Message-State: AOAM533VclW5AncGzhvdzdtlhRJWgwWd9fYvxynJXpREtw28/EO5D1Bo 0TLkXxUcwaUeGxoXuV6RRIc= X-Google-Smtp-Source: ABdhPJxrNnN/vOxz7Eqo+/5EE7A+H1/lzOpU7gIl78xVsMMAcKcrRgCSLl0S6hV/ldxU2jQSQ/n8LA== X-Received: by 2002:a17:902:ba86:: with SMTP id k6mr4803965pls.212.1589472714578; Thu, 14 May 2020 09:11:54 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.11.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:11:53 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, sboyd@kernel.org Subject: [PATCH v1 3/9] clk: actions: Add MMC clock-register reset bits Date: Thu, 14 May 2020 21:40:51 +0530 Message-Id: <1589472657-3930-4-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091155_469832_41A708A6 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commit adds reset bits needed for MMC clock registers present on Actions S700 SoC. Signed-off-by: Amit Singh Tomar --- Changes from RFC: * No change. --- drivers/clk/actions/owl-s700.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/actions/owl-s700.c b/drivers/clk/actions/owl-s700.c index a2f34d13fb54..cd60eca7727d 100644 --- a/drivers/clk/actions/owl-s700.c +++ b/drivers/clk/actions/owl-s700.c @@ -577,6 +577,9 @@ static const struct owl_reset_map s700_resets[] = { [RESET_DSI] = { CMU_DEVRST0, BIT(2) }, [RESET_CSI] = { CMU_DEVRST0, BIT(13) }, [RESET_SI] = { CMU_DEVRST0, BIT(14) }, + [RESET_SD0] = { CMU_DEVRST0, BIT(22) }, + [RESET_SD1] = { CMU_DEVRST0, BIT(23) }, + [RESET_SD2] = { CMU_DEVRST0, BIT(24) }, [RESET_I2C0] = { CMU_DEVRST1, BIT(0) }, [RESET_I2C1] = { CMU_DEVRST1, BIT(1) }, [RESET_I2C2] = { CMU_DEVRST1, BIT(2) }, From patchwork Thu May 14 16:10:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74130618 for ; Thu, 14 May 2020 16:13:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20BD82065D for ; Thu, 14 May 2020 16:13:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E5lSZHwP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M6gmBW2w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20BD82065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uwkoC6GeA8FPmj/NXDzTTIM9V8s2suY3dYEeeXeI4SY=; b=E5lSZHwPMjYkhsfa7ppzKwAvVt ucGSdB1hBXIRGP5pzY7rvQtCxxPv6DT2yGab1G3VEgNeL6SG7XCefhLcenZJfcgw/EzRQlX8o3JpX XZ2E8/0uOBbeUc1NNvOxAgLv4JHlkYEEWTpOBb2Epa8GBMtze5mD12JwGXDSf0aCAO/ra49kznJMY T6Y0G66VvQVdWU3+W2TsQczrW28KR90w3nM92AOr8EyLo9FyT2G15ifym/ANkmjTO9s2NHXp5o1Ip hjHbrsr+d+9QrF39evgRyBPi09rkwDhRj+tKvmREiWwLtP0CgB854qk38VYXUEr0f5VRXu7VjHnqd 2KI8ig6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGTw-0005Dp-Rx; Thu, 14 May 2020 16:13:12 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSm-0004E9-61; Thu, 14 May 2020 16:12:01 +0000 Received: by mail-pg1-x544.google.com with SMTP id f6so1444762pgm.1; Thu, 14 May 2020 09:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kERbVPKOH+FX4g8aG+gjJYUwyTHcVS7ylYTdMC7w4rU=; b=M6gmBW2wkreDT1FjE3XduSEnQnlx1OmUN/sGm+c1dA/9z8Lf+QwnE+4mSUZQxq3Yqu M+JaZF5Iuuwjecknhi+K9sE/vriSN4mlm9OwWCv2XKKJCA1r0Y1TW0CEjmAZ3XrnKeu1 6dlncoMK7eu2uW+ysxkfQK101dKE0lU0xBsST/dXRin/2gdLg5OQKZ6nQltS4hfH/7F1 40eds0q0Ae92dk8jUUsigc+rLMM26S2w3p3JAieBkUe9F1kZFZjFs/+Wv/R30hIWvBQz dSYWgFo7wkCPwULy0CDpZ+UwLEXqPIMC6ucOabOIVLSIk1rCiq+/QRzlJpmvZGrIyObB WivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kERbVPKOH+FX4g8aG+gjJYUwyTHcVS7ylYTdMC7w4rU=; b=uXIE5TmdHqaV40OHf8lYxM7N3wQe4EKCy48PkzQnA+7P8TW3R201X71tzOd+OMmXdD HSCpXY1e5VO0tAJBrl6ZOiLMgy6Tb3lhyU/5IgM3bhHpeB4rPf7w8xDjxSFlKBeOzOlo mQhAJspmoCXdUPLFqL+OpnAE9eQRQDiQzj73LLKXuSlo0R9aLT2Sdr5FpKoVvLDfePGt 0IAzp6grgt5vSE2nis0quKY2mbKNM92rrrVhKfZFpcAySVBVyRvoSh8H46wZ2MGAHZk2 UQoytyoJkgJmSuWETj2S8HKgkvUgpg4w4orM+nJ9PxjAaOnzUMXO+PhatrDdml57q8Rj SGeg== X-Gm-Message-State: AOAM533bK2C/wG0IdcIBSw5wu1wHFiMd22y0a4TMzjy7vQQnTbKXCEzO 4oZvvzdsIXItjd53t25VDNk= X-Google-Smtp-Source: ABdhPJx221SdCqxog59nayKDC2HJHmIZOnrjna5bc90Ic4mLEglczKwHZp+qojX8hzWdHl57pCXkSA== X-Received: by 2002:a63:f90a:: with SMTP id h10mr4621315pgi.57.1589472718688; Thu, 14 May 2020 09:11:58 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.11.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:11:58 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 4/9] arm64: dts: actions: do not merge disable sps node from S700 Date: Thu, 14 May 2020 21:40:52 +0530 Message-Id: <1589472657-3930-5-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091200_244884_76EB1DE1 X-CRM114-Status: GOOD ( 10.70 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org After commit 7cdf8446ed1d ("arm64: dts: actions: Add pinctrl node for Actions Semi S700") following error has been observed while booting Linux on Cubieboard7-lite(based on S700 SoC). [ 0.257415] pinctrl-s700 e01b0000.pinctrl: can't request region for resource [mem 0xe01b0000-0xe01b0fff] [ 0.266902] pinctrl-s700: probe of e01b0000.pinctrl failed with error -16 This is due to the fact that memory range for "sps" power domain controller clashes with pinctrl. This commit disable "sps" to avoid this conflict and let us test DMA and MMC related changes. Signed-off-by: Amit Singh Tomar --- Changes since RFC: * kept as do not merge. --- arch/arm64/boot/dts/actions/s700.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi index 2006ad5424fa..0397c5dd3dec 100644 --- a/arch/arm64/boot/dts/actions/s700.dtsi +++ b/arch/arm64/boot/dts/actions/s700.dtsi @@ -220,6 +220,7 @@ compatible = "actions,s700-sps"; reg = <0x0 0xe01b0100 0x0 0x100>; #power-domain-cells = <1>; + status = "disabled"; }; timer: timer@e024c000 { From patchwork Thu May 14 16:10:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549243 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70DEF60D for ; Thu, 14 May 2020 16:13:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 084EF2065D for ; Thu, 14 May 2020 16:13:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W03XemkW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Itw4gj29" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 084EF2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1YboelflE1csrHHD5B817rtl4YedwwemduzU2AbvU2c=; b=W03XemkWLXLZEGZrRvsiPEJ+cu NMdIg+VK9edVLX2m8sUG7dguZVMSwvCtEcYyHPEX1zDpmYen0zxosx4M6opvLmfBGMbuYYyuE42Wi 5ote7rVcADl4iWmFZmtsXAzUWh6K6j61JVrkTNlOgTb2T3JKzkgh5WRHs4WdAXhbnl4K0nlcYA7tr eB4aoY5rAzFVsajt/uj43pnVeUbIYb3UYssNtVpQXSpvyPMMUYsWTt31tP9Uio/VdfTBI70iSRwzk FXeaqNCcIw1OqmAH6hDW8Ll7fOQNjpVhi9Y4oR8J+iK/FzxX0nKw/oKuc70CymSyFuznz9uw9mh0S 7bRIGTnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGUE-0005Tv-7N; Thu, 14 May 2020 16:13:30 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSr-0004HZ-1K; Thu, 14 May 2020 16:12:10 +0000 Received: by mail-pl1-x644.google.com with SMTP id k22so60206pls.10; Thu, 14 May 2020 09:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ES8afuL7PSuY7X1eTte9GLtkb9S07PMJ4/U2q/1l3LQ=; b=Itw4gj29hGMizedRPJwNNjoNbwd9nz3Tfc+zIJDtulSOotvysbj+DkrpCoW9KbzC+P rHjF3TgJP6owOXEDDCwJ6OZoacQsRZt3Khtj6mIDI0KpViSoPydhUk7d4UhOif/4EGMo 9MyX9bG5AuZfnXjBH4sp0DUQuYBjLTLVSiLZLrfgmGAz0qGLiBD7vF7/Hl28TILx42CZ cHI0XF0iRG8NcTzddzXLOFfaTpJkdBeFyuJqyUUk0LhjXrrUc1fD0t6k0RWfzIFB2OnX dAp9SN+Fg2ByOcdTrwrhFmtz/3OMqzFfIeNsaYuJ4kZTzgcytBA6H2jBdpWBVkkJ1Z30 Z1Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ES8afuL7PSuY7X1eTte9GLtkb9S07PMJ4/U2q/1l3LQ=; b=qDeIpi6wuX3pUedyY2NR4FnSh7038d3WSpj8zPLZQkR0sTiPLQpJAfHdkUPkwztAJe jDwZ8mkCFHGqLVb7PwL8Ms/F7DR7a/bzO88wRxCZwwF/GQWJAbMKUBD7gb6gnvUvLQqc y/dfR8jViTw/x4ghQeFoHXov6j1oQ7vUZRCuScqMl36iIc12JjUmUraXPbijyonfOccq UprtSvthMgPk3suyC8gfp8n55SEUrd88f938EeWZAgsqHVSOCl5MYvixynYWfzDshsBG F5kybWa7rAhrmxtkkcBCv5MwO5qcoAfX0ggbdAvAtjAqbc4JQ83Cpx9gtStzvJtVmuhl kc1Q== X-Gm-Message-State: AOAM530epr9mARLgozydGJK3V96IuBCW2m5j5inYw3aXMoSbb/Tva8HY 4tGFQJim2f0SyuNzJUyKDH4= X-Google-Smtp-Source: ABdhPJyObmtYnStJLaJtJzAGemjZQ1QgrOmeN7N6Q26fz2KGs69RXBqWup98xXOKuxVxlEJx/NGYrQ== X-Received: by 2002:a17:902:b114:: with SMTP id q20mr4363148plr.120.1589472722763; Thu, 14 May 2020 09:12:02 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.11.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:12:02 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 5/9] dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml Date: Thu, 14 May 2020 21:40:53 +0530 Message-Id: <1589472657-3930-6-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091205_365118_EE56EE7D X-CRM114-Status: GOOD ( 14.44 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:644 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Converts the device tree bindings for the Actions Semi Owl SoCs DMA Controller over to YAML schemas. It also adds new compatible string "actions,s700-dma" to match the driver. Signed-off-by: Amit Singh Tomar --- New patch, was not there in RFC. --- Documentation/devicetree/bindings/dma/owl-dma.txt | 47 ------------ Documentation/devicetree/bindings/dma/owl-dma.yaml | 84 ++++++++++++++++++++++ 2 files changed, 84 insertions(+), 47 deletions(-) delete mode 100644 Documentation/devicetree/bindings/dma/owl-dma.txt create mode 100644 Documentation/devicetree/bindings/dma/owl-dma.yaml diff --git a/Documentation/devicetree/bindings/dma/owl-dma.txt b/Documentation/devicetree/bindings/dma/owl-dma.txt deleted file mode 100644 index 03e9bb12b75f..000000000000 --- a/Documentation/devicetree/bindings/dma/owl-dma.txt +++ /dev/null @@ -1,47 +0,0 @@ -* Actions Semi Owl SoCs DMA controller - -This binding follows the generic DMA bindings defined in dma.txt. - -Required properties: -- compatible: Should be "actions,s900-dma". -- reg: Should contain DMA registers location and length. -- interrupts: Should contain 4 interrupts shared by all channel. -- #dma-cells: Must be <1>. Used to represent the number of integer - cells in the dmas property of client device. -- dma-channels: Physical channels supported. -- dma-requests: Number of DMA request signals supported by the controller. - Refer to Documentation/devicetree/bindings/dma/dma.txt -- clocks: Phandle and Specifier of the clock feeding the DMA controller. - -Example: - -Controller: - dma: dma-controller@e0260000 { - compatible = "actions,s900-dma"; - reg = <0x0 0xe0260000 0x0 0x1000>; - interrupts = , - , - , - ; - #dma-cells = <1>; - dma-channels = <12>; - dma-requests = <46>; - clocks = <&clock CLK_DMAC>; - }; - -Client: - -DMA clients connected to the Actions Semi Owl SoCs DMA controller must -use the format described in the dma.txt file, using a two-cell specifier -for each channel. - -The two cells in order are: -1. A phandle pointing to the DMA controller. -2. The channel id. - -uart5: serial@e012a000 { - ... - dma-names = "tx", "rx"; - dmas = <&dma 26>, <&dma 27>; - ... -}; diff --git a/Documentation/devicetree/bindings/dma/owl-dma.yaml b/Documentation/devicetree/bindings/dma/owl-dma.yaml new file mode 100644 index 000000000000..12e68c0ece67 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/owl-dma.yaml @@ -0,0 +1,84 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/owl-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Actions Semi Owl SoCs DMA controller + +description: | + The OWL DMA is a general-purpose direct memory access controller capable of + supporting 10 and 12 independent DMA channels for S700 and S900 SoCs + respectively. + DMA clients connected to the Actions Semi Owl SoCs DMA controller must + use the format described in the owl-dma.yaml file, using a two-cell specifier + for each channel. + + The two cells in order are: + 1. A phandle pointing to the DMA controller. + 2. The channel id. + + uart5: serial@e012a000 { + ... + dma-names = "tx", "rx"; + dmas = <&dma 26>, <&dma 27>; + ... + }; + +maintainers: + - Manivannan Sadhasivam + +allOf: + - $ref: "dma-controller.yaml#" + +properties: + compatible: + enum: + - actions,s900-dma + - actions,s700-dma + + reg: + maxItems: 1 + + interrupts: + maxItems: 4 + + "#dma-cells": + const: 1 + + dma-channels: + maxItems: 1 + + dma-requests: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - "#dma-cells" + - dma-channels + - dma-requests + - clocks + +examples: + - | + #include + #include + dma: dma-controller@e0260000 { + compatible = "actions,s900-dma"; + reg = <0x0 0xe0260000 0x0 0x1000>; + interrupts = , + , + , + ; + #dma-cells = <1>; + dma-channels = <12>; + dma-requests = <46>; + clocks = <&clock CLK_DMAC>; + }; + +... From patchwork Thu May 14 16:10:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98CAA60D for ; Thu, 14 May 2020 16:13:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 753E6206D8 for ; Thu, 14 May 2020 16:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jdGeu57l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xj8DKYSk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 753E6206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=qU6j2hfZZ0zSSMdWXnuOV5wsabcCEyY6iZumARI95xg=; b=jdGeu57lGeb2j51hUyzSSCkG4X aJTKxUHIdScQ5lyBm93BJhfQmGwags9UBgTo2g2O4gXCsuXVl7DKdm/7CJiJIoqw/7+3BUgaXWY0L 8GU4Z2CMq8TVQs69Two8fy4U5Me3la21qQejSjzuoD38ZvyQjsyDScUs48m1Ey2AKeiSoDcLhafJR 5ZrpURHmyWON5NtXHqo1scIEZOKwevwlCLVGNWRvXgh2byJ/gjNBE4lEDbgEwg0IoccfajTbDGLPO GOfQxm1+I6qWj9oo9dm6S5jiqxbRmMQ/zbOEhp8i/8odPpPmkE4tHzKjYnJFQ14FrRatymnamoxh1 xUcOzbFg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGUX-0005ht-Jo; Thu, 14 May 2020 16:13:49 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGSw-0004LR-OD; Thu, 14 May 2020 16:12:13 +0000 Received: by mail-pj1-x1041.google.com with SMTP id ms17so12651068pjb.0; Thu, 14 May 2020 09:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=siPOjsK0bfqvt9Fq4RN1wntvrens1V+rnit/PWCaq7M=; b=Xj8DKYSkjrwtQmsyJE7FFNnNlGzq2qWf5nU68d9GmIRpZQfcwn1lr0XVp3iTV30FCH W1jGWlgy6grJu8TOe66KCARtJ898Okr7jwvrQdKHnaajzs7NSz7VLa0WJMnd98B4fsTd /OLtLSpeMPe0liz1YkhKCMWcjy2sMh4swGnAv7LJwkPHsdHqnxIyunAAoSQrvbCY6IoA Am4Am0t3nD2LujW1cduYmmaQdFso6H03snd5gvCRx3MX9LYtC1ZA/z6kdT3ArRG+XitF 4xNmbxMWiQwtHdnlVBrXd4fR3EvKKutrqfcjlxhs8jN5p1GDxGXsbvOXP+7QpR+Se5eH p15A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=siPOjsK0bfqvt9Fq4RN1wntvrens1V+rnit/PWCaq7M=; b=lHrwM6ivxSFSy86rrZW+o8IEMCDPNKKdWrbttm2mJD1beYgLYX+HaQTeGlnhCNSt3E pgw3jCfq/vcJVicUU6LDIlpE65c9sTeLlWJTUBPlV9E4JqNQZJ7aqGonZgQoQxqxkCpu nsDGlcC2Mlp/R/1nWt+iYxXNzAO/UHV58B8jdjeHopK8Q2EWu6yKyjW24Ggv2jP812Ov lLy9I+IZMigzgLm/GAGvUXjVMUOrnPFdtsv9SPecBhv9unN6nUc7pap/TcFYz9/rrXSx MaGl8qRmpj+wjCs8O+zSAkb76lY5NBFNoakWYLkAXL18kPUd2ZCS+w5EVu/DBQiPKBiQ umLg== X-Gm-Message-State: AOAM5335UV3jaJSi+IH3AKdiR6bM0McV2lMO7ljOoPjp21vQoL1wyt8l cZsJolkMDWxc223ikEtqSbg= X-Google-Smtp-Source: ABdhPJzNVlwxe6QApmCD4rhZbpgHBetfVc7QbOiFm7CsmOexk92m/E9V9LIFoIO7epDQBmpG66EUEw== X-Received: by 2002:a17:902:70c3:: with SMTP id l3mr4910447plt.147.1589472729540; Thu, 14 May 2020 09:12:09 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.12.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:12:08 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 6/9] arm64: dts: actions: Add DMA Controller for S700 Date: Thu, 14 May 2020 21:40:54 +0530 Message-Id: <1589472657-3930-7-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091210_996151_1ECF11AC X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commit adds DAM controller present on Actions S700, it differs from S900 in terms of number of dma channels and requests. Signed-off-by: Amit Singh Tomar --- Changes since RFC: * No Change. --- arch/arm64/boot/dts/actions/s700.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi index 0397c5dd3dec..56f2f84812cb 100644 --- a/arch/arm64/boot/dts/actions/s700.dtsi +++ b/arch/arm64/boot/dts/actions/s700.dtsi @@ -245,5 +245,18 @@ , ; }; + + dma: dma-controller@e0230000 { + compatible = "actions,s700-dma"; + reg = <0x0 0xe0230000 0x0 0x1000>; + interrupts = , + , + , + ; + #dma-cells = <1>; + dma-channels = <10>; + dma-requests = <44>; + clocks = <&cmu CLK_DMAC>; + }; }; }; From patchwork Thu May 14 16:10:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549247 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B53DD618 for ; Thu, 14 May 2020 16:14:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C7AA2065D for ; Thu, 14 May 2020 16:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="szFH5DPM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bCpA9Den" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C7AA2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W5g9lJZWpJ/xGDeKhnSuFidNwCwIXOHDKlYz2IHl8E4=; b=szFH5DPMsH1bR9JX8y37V6TsZd A0Ij/TtSFcU3T986meNeopduKecw4xw83DrHAwYMqHBa7d8w7k8pOrVJX6ftKAxZIee01UMfvWRsT I+WT5wLnOgbLQsIsF3bdZ1CLXgA70rtTe5WLuz+HfY1wcwIw+brOqNDO3Ob4Rd7Mb+WgLWBMbBgaD uI5umsxRNfsitcP+/eC+zINdkJ7QNKBZD7cxlJGhlMmGHAviLOrGsJyfeeD008dEwM9e9BCZWXd/z GYdYP/Z4ntjHuj4jiW7uNSkQO8WCw7AM7/6VutVGG2dUWItnVf01NY/XNrR412YZJ0Uw5zOX928Gk yequknYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGUn-00061d-Qx; Thu, 14 May 2020 16:14:05 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGT0-0004OR-UD; Thu, 14 May 2020 16:12:16 +0000 Received: by mail-pj1-x1030.google.com with SMTP id a5so12734115pjh.2; Thu, 14 May 2020 09:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nf2fUh4L0xvb2gBsE6dqAlNe1Fn7n9Y6ufB37FLzpcs=; b=bCpA9Den6BRXP6DtJeKNE+xIPbA7NjvVBhI1cxHv25mwT6y/E4hqujy+oLv6uoFaxr dQeApqnC6ZTze3DEiCXMH2krcO0pOE9zZf6gsc174k8WX/O+bxvf0fDjVHqWVBRywKYJ wIo7JQGecv2bop3W91Gr/viQRaUE96Cthcgl8t/0XlCH/ghYTq4n9g3LmabrtVO3bFnD IyGH4yLOk1Phu597psLCI0blmYRhltWZlkoEOlV8OAvvQAntHrkYF7ccOCdAfSSI0vCh V8KLJ5f399PNQdesRpJF8RhqgZS2tOBcfxEk/Rk1RdjroP4bPotYbOOhjAVGjQc49Hd4 E4CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nf2fUh4L0xvb2gBsE6dqAlNe1Fn7n9Y6ufB37FLzpcs=; b=c9tUrN2IfIvCd6NYOzAz4iWZMi8LsGDNi9bzHpQ7cAKCbFqjRvlA05Ta8/c2RYw3nC /Gx00MONI54+keX4VTF0LWTBCxL7UGWGkoXav+TiBDEELtsG/UWWyLoiWVip0RGfnTYk lyOTP0K99PW3oKF/rhHPe1UhqDJ30/hbOwtdTjyJeKEZWgmc1R+Eh/zYG32ZTnqcLyRH r/tA5r2FLsxcQqBcDvNwSMMsJ+1usUhwkWVssPYDrS5f5U9/qLtg+Ome9DVWnLnkfBMC iDcQiZxCaI9F5Z1p+FKe6YBKiH//lPtrzOpyzQam2ddGC+wfYvleDP55im/2Qm3KBuM4 XoGA== X-Gm-Message-State: AGi0PuaNlyAsgNj+aZfGwQsblrtWi3jxLTJ06hBMiW2VcTjIYVYmzDWv DfMAQNsqm91lxV8teMu3J8k= X-Google-Smtp-Source: APiQypIbw0aDPscUlDaeGJmUDx8BKosvpgvswBPyfcGiXK06S3xVDQfhzXazzdb43RYmuGX1crGV2A== X-Received: by 2002:a17:90a:6403:: with SMTP id g3mr36897703pjj.99.1589472733793; Thu, 14 May 2020 09:12:13 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.12.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:12:13 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 7/9] dt-bindings: reset: s700: Add binding constants for mmc Date: Thu, 14 May 2020 21:40:55 +0530 Message-Id: <1589472657-3930-8-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091215_008767_50540D12 X-CRM114-Status: UNSURE ( 9.28 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1030 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commit adds device tree binding reset constants for mmc controller present on Actions S700 Soc. Acked-by: Rob Herring Signed-off-by: Amit Singh Tomar --- Changes since RFC: * added Rob's acked-by tag --- include/dt-bindings/reset/actions,s700-reset.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/reset/actions,s700-reset.h b/include/dt-bindings/reset/actions,s700-reset.h index 5e3b16b8ef53..a3118de6d7aa 100644 --- a/include/dt-bindings/reset/actions,s700-reset.h +++ b/include/dt-bindings/reset/actions,s700-reset.h @@ -30,5 +30,8 @@ #define RESET_UART4 20 #define RESET_UART5 21 #define RESET_UART6 22 +#define RESET_SD0 23 +#define RESET_SD1 24 +#define RESET_SD2 25 #endif /* __DT_BINDINGS_ACTIONS_S700_RESET_H */ From patchwork Thu May 14 16:10:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549249 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9779618 for ; Thu, 14 May 2020 16:14:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8734D20675 for ; Thu, 14 May 2020 16:14:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Kgf02cjK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qUslQwh7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8734D20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=E+6TkjpHCgUtv2GvAn8+v031KuZXnvEX/4UjM4Ji+p4=; b=Kgf02cjKyi6L5Kp2NtSd4TxXfn N1Lljy8x4vF7NpA4+CIhQBrlZ92sOmflMN0JJmMyVLVfdNg90FRyYcW4Kb8tce/jWXWkutiEUWKV9 16J8CKt+A9UrZMXTLCsVxLKvseU1+I9+g2oEYb884rAeBj624wSYnrru2vZJZ0RzTuHbtFtgPWFhC C0JXGiYYel+4Jvs8bdh9JFgj4Xf9urMbubtXbirBMsFdZAzj7wJyiYU5WEAbPM0ibWs9bj4pyBr5x Z5PKHrWVb2YZGGzdLgWP22/AMo9GmbGhhwWpo4e/JBGyJqVhqs91TScjvA8OYn3c6eKZrcX7Zkfb6 KmtBWkGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGV1-0006GB-5r; Thu, 14 May 2020 16:14:19 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGT5-0004RK-15; Thu, 14 May 2020 16:12:20 +0000 Received: by mail-pf1-x42c.google.com with SMTP id y25so1509338pfn.5; Thu, 14 May 2020 09:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iq25LTwXEFRJhD+OnRlNqkQp31RrUmA9ayd2n+EnuO8=; b=qUslQwh7wi9KUoRz7+NTfcmNh906uA25RhWONLuwHJAZ6z5Ys7ozADgdnSOU6AO/3E gtNC7/Ar2klwZ9dBwl+ELEExCd5AALzJmWUEE0mN41K82zda8dTR0hDrqyZfA8YxTNYD eLbqGvMPsAPQRxrAIMeZldL//XkY8Av8iOGxJ3LqggEQeya7aKuB6MUo0jWGCA/4wiqf AbajBqD00r6MnwnwmgySx2B9xHRTiC7eKrHSJuxZEI8KCzVOZG6dG14ecle6006KzfPF c0qgoQth0k0GhXcEN+YJ3+SzGnwo9WgjDXqNdS8II6kh2pmCQ4lw8HtdHOdXZT/tpWq6 S3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iq25LTwXEFRJhD+OnRlNqkQp31RrUmA9ayd2n+EnuO8=; b=NY0BJDMtkJ4xckfp/CthyUzloUWg7nSFKnRw7jlvOS77kJIRbRyrfvn8ph+rPrfmVv k8l7LIQ8jZQNrIqos0DWP4T+TUgehiZufxE5yZQeHPVA/2SY+IfFC9THEJ6BM9aAqi1l VzzyYk9XmP+anqFGMxDzEbeNrHYFbeY3rDwA+RPvmJsKGWQR6EL6jt7E/vWrBCwcJ3c5 9xTbSCJ3iw7V79gsTDWFmTCMRxSrGG6J5iwi08YuW//Ncls0dKrTSag9rmUZfevUBG95 QpPfTd9ScZ4juQlJAkbxJccpppF0G4yakTXbQvYpSXDb5CAxxcLdClGRNaRm6W0GHULR TiTg== X-Gm-Message-State: AOAM5337WYGmT+N4+4QntsUAqhYD4Mf74+KXzkMQUQ//tW5bWUdrndIR xf1uar7KunafbmrWHFAyQR4qeNOj6kz45g== X-Google-Smtp-Source: ABdhPJx17oMOQ9Kw6oKeoUheSZIcyfjXCLb5ZrrPy7cBcxJKbx1NeZ2JhL85jxt8Ywumr+U2/lMQ5g== X-Received: by 2002:a63:1103:: with SMTP id g3mr4684320pgl.206.1589472737839; Thu, 14 May 2020 09:12:17 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.12.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:12:17 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700 Date: Thu, 14 May 2020 21:40:56 +0530 Message-Id: <1589472657-3930-9-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091219_095684_2E6E67F1 X-CRM114-Status: GOOD ( 11.02 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:42c listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commits adds support for MMC controllers present on Actions S700 SoC, there are 3 MMC controllers in this SoC which can be used for accessing SD/EMMC/SDIO cards. Signed-off-by: Amit Singh Tomar --- Changes since RFC: * No change. --- arch/arm64/boot/dts/actions/s700.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi index 56f2f84812cb..3f1fc3e48415 100644 --- a/arch/arm64/boot/dts/actions/s700.dtsi +++ b/arch/arm64/boot/dts/actions/s700.dtsi @@ -258,5 +258,38 @@ dma-requests = <44>; clocks = <&cmu CLK_DMAC>; }; + + mmc0: mmc@e0210000 { + compatible = "actions,owl-mmc"; + reg = <0x0 0xe0210000 0x0 0x4000>; + interrupts = ; + clocks = <&cmu CLK_SD0>; + resets = <&cmu RESET_SD0>; + dmas = <&dma 2>; + dma-names = "mmc"; + status = "disabled"; + }; + + mmc1: mmc@e0214000 { + compatible = "actions,owl-mmc"; + reg = <0x0 0xe0214000 0x0 0x4000>; + interrupts = ; + clocks = <&cmu CLK_SD1>; + resets = <&cmu RESET_SD1>; + dmas = <&dma 3>; + dma-names = "mmc"; + status = "disabled"; + }; + + mmc2: mmc@e0218000 { + compatible = "actions,owl-mmc"; + reg = <0x0 0xe0218000 0x0 0x4000>; + interrupts = ; + clocks = <&cmu CLK_SD2>; + resets = <&cmu RESET_SD2>; + dmas = <&dma 4>; + dma-names = "mmc"; + status = "disabled"; + }; }; }; From patchwork Thu May 14 16:10:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Tomer X-Patchwork-Id: 11549251 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7675C618 for ; Thu, 14 May 2020 16:14:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44DAA20675 for ; Thu, 14 May 2020 16:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G4V48Cez"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BwU30ot7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44DAA20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=krYyuN0Sasr3/dq9ASKcU29azQjP7ymDrN7eb7/4QNg=; b=G4V48CezWF0pDnK/7qMjx9l+KA 1ED0oSdL71CN/m0Yb9btuCySBySWJMeqeD+/42Nspbjq4JXiCT+hE71gCbVistJ3z5u4Qj0jDSND4 XLd7ULQvoxy2gAUElK1pKEknvuoegcMT4oQ0e3URJoBqVPXqyscaHwvi/It+0/ovL/t6vcxQINtPh nPLNTj7zAzBRSmLCVbSyaUVCHNTNq4igY+OOpsJFBgiW9DVBps2oZmTqfa2j8pw+DzqnvQ6brCPy0 dSGraxGG1sr8lObi2GTmAwtr6bmMklBJxupMSm+i1E2CCTbw4r3Mb4Jy0I1csQQQQshbjfzwzCOlW FFisbJsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGVM-0006YA-3J; Thu, 14 May 2020 16:14:40 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZGT9-0004UM-R6; Thu, 14 May 2020 16:12:25 +0000 Received: by mail-pg1-x543.google.com with SMTP id a4so1444381pgc.0; Thu, 14 May 2020 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mOIbZMU3Oqa+Dg2aziM3n4kF2vGK6hWpxfNawd5Nsu0=; b=BwU30ot7YCQG9NZPoBFw4wKb+41wNIIOch4RB+wtj0tn4DTl/fOHuHh/60hJQBGnwh pYvBvBpfp9CScrFFNS4nr9QQ+RiYl6v4GCrWTaqe+zkzbzKnzPHFDSa1h/VIp95+9hGE G6w4trABgsGm2jMi/kCwhN8pjLhek70rDKAqu8N21Lv6JMDNy+gQz4AcFh+C4Hnkog5e UvCBbKH60pkTnoODo9daDuW/jCuibXAfKFGejIHlZVxXHCX4Q5gHfNrLmkZyGzRstoyr k5XTttf2vuLYR4Ylqa3TVMIKsag/tpzLHXd2yWXZJzNJVAaR54xpflyUNXEMg4uSa6FI huwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mOIbZMU3Oqa+Dg2aziM3n4kF2vGK6hWpxfNawd5Nsu0=; b=JmfLnxZIHr8+lZ+Xl5noSCe1xpMgNnJhz5EYksPRrpDMfgPn9z7biPNjXk75rkwF0r 5xRiuFdUUfjEyAsroeDQHvPlzPecRt7NNsmpiP8NI726CACQQ0aPlr8HZXvqrZVxa06M PnNbQJ4ouVp8NeyFJfg01xc43qX8cZD2avEdqGAwx6+SGvna7Hh4pPKHmn3hWGMTYuO8 fRj+butDmxMvHSLKgwZjmZW6hmL8VaVlCURjhqhkb4Vun+xv0DH7vwP+RPpXtDQ+8/yG VkLIf7r1gWe6TRv3IAvaK8G2vLEoieUOOOOlnQ82VDo8PSaTom5ugf05YXiH2U7XtwPh 15Ng== X-Gm-Message-State: AOAM531g3aQxZn491Sw/BZOkUZmfMoxawPNnanwqtAVkwMqVZZcFJJJH DfNxz9JUOPnxRjhOhJJuYOQ= X-Google-Smtp-Source: ABdhPJwvdtggt2b8J6sAudZPYpXwOhIVEjURNrj352xFZESrZQdWvUad1EMYYTo0GKeiMTDOjwEkxw== X-Received: by 2002:a62:5f81:: with SMTP id t123mr5424784pfb.79.1589472741838; Thu, 14 May 2020 09:12:21 -0700 (PDT) Received: from localhost.localdomain ([106.215.24.137]) by smtp.gmail.com with ESMTPSA id t5sm2331755pgp.80.2020.05.14.09.12.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2020 09:12:21 -0700 (PDT) From: Amit Singh Tomar To: andre.przywara@arm.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, robh+dt@kernel.org Subject: [PATCH v1 9/9] arm64: dts: actions: Add uSD support for Cubieboard7 Date: Thu, 14 May 2020 21:40:57 +0530 Message-Id: <1589472657-3930-10-git-send-email-amittomer25@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_091223_904157_3F035912 X-CRM114-Status: GOOD ( 12.61 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [amittomer25[at]gmail.com] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [amittomer25[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, cristian.ciocaltea@gmail.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This commit adds uSD support for Cubieboard7 board based on Actions Semi S700 SoC. SD0 is connected to uSD slot. Since there is no PMIC support added yet, fixed regulator has been used as a regulator node. Signed-off-by: Amit Singh Tomar --- Changes since RFC: * No change. --- arch/arm64/boot/dts/actions/s700-cubieboard7.dts | 41 ++++++++++++++++++++++++ arch/arm64/boot/dts/actions/s700.dtsi | 1 + 2 files changed, 42 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts index 63e375cd9eb4..ec117eb12f3a 100644 --- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts +++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts @@ -13,6 +13,7 @@ aliases { serial3 = &uart3; + mmc0 = &mmc0; }; chosen { @@ -28,6 +29,23 @@ device_type = "memory"; reg = <0x1 0xe0000000 0x0 0x0>; }; + + /* Fixed regulator used in the absence of PMIC */ + vcc_3v1: vcc-3v1 { + compatible = "regulator-fixed"; + regulator-name = "fixed-3.1V"; + regulator-min-microvolt = <3100000>; + regulator-max-microvolt = <3100000>; + }; + + /* Fixed regulator used in the absence of PMIC */ + sd_vcc: sd-vcc { + compatible = "regulator-fixed"; + regulator-name = "fixed-3.1V"; + regulator-min-microvolt = <3100000>; + regulator-max-microvolt = <3100000>; + regulator-always-on; + }; }; &i2c0 { @@ -81,6 +99,14 @@ bias-pull-up; }; }; + + mmc0_default: mmc0_default { + pinmux { + groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp", + "sd0_cmd_mfp", "sd0_clk_mfp"; + function = "sd0"; + }; + }; }; &timer { @@ -90,3 +116,18 @@ &uart3 { status = "okay"; }; + +/* uSD */ +&mmc0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&mmc0_default>; + cd-gpios = <&pinctrl 120 GPIO_ACTIVE_LOW>; + no-sdio; + no-mmc; + no-1-8-v; + bus-width = <4>; + vmmc-supply = <&sd_vcc>; + vqmmc-supply = <&sd_vcc>; +}; + diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi index 3f1fc3e48415..8a541dd48f61 100644 --- a/arch/arm64/boot/dts/actions/s700.dtsi +++ b/arch/arm64/boot/dts/actions/s700.dtsi @@ -4,6 +4,7 @@ */ #include +#include #include #include