From patchwork Mon May 18 11:41:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11555335 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C9F060D for ; Mon, 18 May 2020 11:41:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CC7020756 for ; Mon, 18 May 2020 11:41:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y5bxw+2j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgERLlJ (ORCPT ); Mon, 18 May 2020 07:41:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726362AbgERLlJ (ORCPT ); Mon, 18 May 2020 07:41:09 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13BADC061A0C for ; Mon, 18 May 2020 04:41:09 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id m7so4120031plt.5 for ; Mon, 18 May 2020 04:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VbJhaAvLm/7HhZgtjqIe1iWgPLvm0UT8AWoz9bkvXtQ=; b=Y5bxw+2jHVl/upYZ404mYjQNncJQLYy8IoKs0NolwTK20WNPDR99KSL82UEQr03amL SpwDmuv2b47RjabdVoKCKDcF6Mibor4vPFl9FTl+iNLlCu/0PtV5yPAF4qy3SY23oakK sLH7e/ht6ZSxlF7uLiaVoLb11oiU36w6wzd7D3uwlDq6W/cBZU5OtdR4MiiN7p0b7082 3YfyiKSmR4SvVNwSMuluUJkBlDsGot9yP4ToIsCsxLrxj+61srvSxRcyvKOj5mdiYI8k HTiVjw8V2Jnc/yEVMgV5uCG5poZeGeN4HYYeI2bZPDwute/rlxFmZbKs4S52ruQo33X6 2Dpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VbJhaAvLm/7HhZgtjqIe1iWgPLvm0UT8AWoz9bkvXtQ=; b=buBJK3w2KeKoLRSeHl9dKj1ynH/CPbFo1KXoX2ftaLgo/vMZNtCzrswnresTfhtYRV 4jZrkX7SgnvseGU5q/2I376eXrwLGVOhqZD8FHNj1l9jIUZvKB8u7SnfOjDgClKplL9i FPvU/2S9JPAwcM76fmXN4oHVQ770NbMqXMMltWjbi05jDEL1xxyJQHxn2CfxB0CcS8Wl YR8emz9yxlkIxu9uqfQ92L+y/9nvg/x8gbn/eYbQisUuFocdt1X79dlF/AT4OD/wmU+d JqeAviY1nJOxpTbQ6AV1VDVzGBjPMWqSoiiPI8HNB8uL0xaUrbXlFCPJdcTbEcAuAZA5 FYsQ== X-Gm-Message-State: AOAM530QJEKYUfaPtIwhs7T1pRx+8OIbnMOQ1N2O9v/ih7y+EI2YO1x/ NvHgZFAJB1/opLOZeswKqZHWmw== X-Google-Smtp-Source: ABdhPJwiUAF6xS8J52ol3Q4l7W/WTwov8MV6Dxb9vzOVbeRrhwgPOcI2SoI5Jaipu041OCU7He4xBA== X-Received: by 2002:a17:902:bd95:: with SMTP id q21mr11981142pls.238.1589802068529; Mon, 18 May 2020 04:41:08 -0700 (PDT) Received: from localhost ([122.167.130.103]) by smtp.gmail.com with ESMTPSA id i10sm8650727pfa.166.2020.05.18.04.41.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2020 04:41:07 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Georgi Djakov , Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH] opp: Expose bandwidth information via debugfs Date: Mon, 18 May 2020 17:11:02 +0530 Message-Id: X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af In-Reply-To: <20200512125327.1868-1-georgi.djakov@linaro.org> References: <20200512125327.1868-1-georgi.djakov@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Expose the bandwidth information as well via debugfs. Signed-off-by: Viresh Kumar Signed-off-by: Georgi Djakov --- @Georgi: I am applying this along with your series. drivers/interconnect/core.c | 18 ++++++++++++++++ drivers/opp/debugfs.c | 42 ++++++++++++++++++++++++++++++++++++ include/linux/interconnect.h | 6 ++++++ 3 files changed, 66 insertions(+) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 2d2e49780511..a56349c14985 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -514,6 +514,24 @@ void icc_set_tag(struct icc_path *path, u32 tag) } EXPORT_SYMBOL_GPL(icc_set_tag); +/** + * icc_get_name() - Get name of the icc path + * @path: reference to the path returned by icc_get() + * + * This function is used by an interconnect consumer to get the name of the icc + * path. + * + * Returns a valid pointer on success, or NULL otherwise. + */ +const char *icc_get_name(struct icc_path *path) +{ + if (!path) + return NULL; + + return path->name; +} +EXPORT_SYMBOL_GPL(icc_get_name); + /** * icc_set_bw() - set bandwidth constraints on an interconnect path * @path: reference to the path returned by icc_get() diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 609665e339b6..596c185b5dda 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -32,6 +32,47 @@ void opp_debug_remove_one(struct dev_pm_opp *opp) debugfs_remove_recursive(opp->dentry); } +static ssize_t bw_name_read(struct file *fp, char __user *userbuf, + size_t count, loff_t *ppos) +{ + struct icc_path *path = fp->private_data; + char buf[64]; + int i; + + i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path)); + + return simple_read_from_buffer(userbuf, count, ppos, buf, i); +} + +static const struct file_operations bw_name_fops = { + .open = simple_open, + .read = bw_name_read, + .llseek = default_llseek, +}; + +static void opp_debug_create_bw(struct dev_pm_opp *opp, + struct opp_table *opp_table, + struct dentry *pdentry) +{ + struct dentry *d; + char name[11]; + int i; + + for (i = 0; i < opp_table->path_count; i++) { + snprintf(name, sizeof(name), "icc-path-%.1d", i); + + /* Create per-path directory */ + d = debugfs_create_dir(name, pdentry); + + debugfs_create_file("name", S_IRUGO, d, opp_table->paths[i], + &bw_name_fops); + debugfs_create_u32("peak_bw", S_IRUGO, d, + &opp->bandwidth[i].peak); + debugfs_create_u32("avg_bw", S_IRUGO, d, + &opp->bandwidth[i].avg); + } +} + static void opp_debug_create_supplies(struct dev_pm_opp *opp, struct opp_table *opp_table, struct dentry *pdentry) @@ -94,6 +135,7 @@ void opp_debug_create_one(struct dev_pm_opp *opp, struct opp_table *opp_table) &opp->clock_latency_ns); opp_debug_create_supplies(opp, opp_table, d); + opp_debug_create_bw(opp, opp_table, d); opp->dentry = d; } diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h index 34e97231a6ab..1ad09efd296e 100644 --- a/include/linux/interconnect.h +++ b/include/linux/interconnect.h @@ -32,6 +32,7 @@ struct icc_path *of_icc_get_by_index(struct device *dev, int idx); void icc_put(struct icc_path *path); int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw); void icc_set_tag(struct icc_path *path, u32 tag); +const char *icc_get_name(struct icc_path *path); #else @@ -65,6 +66,11 @@ static inline void icc_set_tag(struct icc_path *path, u32 tag) { } +static inline const char *icc_get_name(struct icc_path *path) +{ + return NULL; +} + #endif /* CONFIG_INTERCONNECT */ #endif /* __LINUX_INTERCONNECT_H */