From patchwork Tue May 19 09:30:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11557317 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BCC0F618 for ; Tue, 19 May 2020 09:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3407205CB for ; Tue, 19 May 2020 09:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589880618; bh=n1SYNx+nqeY3RrskAQmJB/fo2huuZpc8H4cex65aZbg=; h=From:To:Cc:Subject:Date:List-ID:From; b=HZPYYiXUUEjTyrEEPznMaB7T0UMiGSzM5DxDAtWxrmVUey4vdkehTcCfn2rTNgFSP y+LF5NJF2ZlSG+XamXP4TjcgerkGGmqLpKyP6qYTOQyMG2VS0F8fbzlSOHmOjj4H00 SKEI3AWdks0hLvt/FFIjTL7QlnRC1t7mEOE0RSUg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728027AbgESJaP (ORCPT ); Tue, 19 May 2020 05:30:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:37558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726505AbgESJaP (ORCPT ); Tue, 19 May 2020 05:30:15 -0400 Received: from localhost.localdomain (unknown [122.182.207.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C9AA207C4; Tue, 19 May 2020 09:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589880614; bh=n1SYNx+nqeY3RrskAQmJB/fo2huuZpc8H4cex65aZbg=; h=From:To:Cc:Subject:Date:From; b=l4NvE6zQ/ZisItjJ+oZkR/w4eG03j4mXp+qLc8/+x8UiLtJi50ccRssVE1x8C1OnY zF5ZI6pcKx5q7TXGS+3RQhNsKJocf6rxmTWzF8wpsLeI2zIRCI8IhDcEHkm7XwdZrf UGdCyArs72uPHbLI7wfZlWItPpG4u5lHHMjAnlrI= From: Vinod Koul To: Mathias Nyman , Greg Kroah-Hartman Cc: Vinod Koul , Christian Lamparter , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild test robot Subject: [PATCH] usb: xhci: make symbols static Date: Tue, 19 May 2020 15:00:02 +0530 Message-Id: <20200519093002.1152144-1-vkoul@kernel.org> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org When renesas module is not built, we get compiler warning on xhci driver with W=1 CC [M] drivers/usb/host/xhci-rcar.o drivers/usb/host/xhci-pci.h:13:5: warning: no previous prototype for ‘renesas_xhci_check_request_fw’ [-Wmissing-prototypes] int renesas_xhci_check_request_fw(struct pci_dev *dev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/host/xhci-pci.h:19:6: warning: no previous prototype for ‘renesas_xhci_pci_exit’ [-Wmissing-prototypes] void renesas_xhci_pci_exit(struct pci_dev *dev) { }; ^~~~~~~~~~~~~~~~~~~~~ We have defined these symbols when CONFIG_USB_XHCI_PCI_RENESAS is not defined, but missed making then static. Reported-by: kbuild test robot Fixes: 8bd5741e3145 ("usb: renesas-xhci: Add the renesas xhci driver") Signed-off-by: Vinod Koul --- drivers/usb/host/xhci-pci.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h index 4d749556e350..acd7cf0a1706 100644 --- a/drivers/usb/host/xhci-pci.h +++ b/drivers/usb/host/xhci-pci.h @@ -10,13 +10,13 @@ int renesas_xhci_check_request_fw(struct pci_dev *dev, void renesas_xhci_pci_exit(struct pci_dev *dev); #else -int renesas_xhci_check_request_fw(struct pci_dev *dev, - const struct pci_device_id *id) +static int renesas_xhci_check_request_fw(struct pci_dev *dev, + const struct pci_device_id *id) { return 0; } -void renesas_xhci_pci_exit(struct pci_dev *dev) { }; +static void renesas_xhci_pci_exit(struct pci_dev *dev) { }; #endif