From patchwork Tue May 19 11:09:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chi-Hsien Lin X-Patchwork-Id: 11557453 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80E8D912 for ; Tue, 19 May 2020 11:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6321B20708 for ; Tue, 19 May 2020 11:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cypress.com header.i=@cypress.com header.b="NRk4S7/R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728286AbgESLKX (ORCPT ); Tue, 19 May 2020 07:10:23 -0400 Received: from mail-bn8nam12on2129.outbound.protection.outlook.com ([40.107.237.129]:61536 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726157AbgESLKX (ORCPT ); Tue, 19 May 2020 07:10:23 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeqbmDeo8YpBtlDIrQg97P5/pSns8v4RyujlL03oBWv7Enq0QKX3J3obOBoKPA9qRyLV9oofVPZHU+Qd9i4VqhpGH0w48lADygEEChVlnk4ysSgSrvLEvrmqOnaDJ3frbsz4T3IMI24jWsO0/6ycj2+6KCivtGnsuduD5pC/aRxAcAblHqUC/rSCuiDEuXLrqmR7bWLCF8JOLraY6QZvzC+OWpRyjJdW3cowgbU//wprHW53a5T9JOcm0LeC7CF0c8WvFv/wut7ufwJgK7Q1NUdLV+zp4vlHOek1KdbNQXD8XGQ7mAjZpdlb7U1j4V1rcMLrTBXgiE6eVjMFH0jF0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbGO6BtiGo8RXeJy0V305oVt2OBv9ZSO5GQ2MnIfEeo=; b=C5BjITN+B6L+zneRTfRdyvCQcLO33kZMM+I38oAs/QwDVmqTdrmcOrUy/W0G20BxBTDB++b4nuJ+RY8qOIBKzpvgbEDKCM+ZPQLbGHb3B6Xe50tBhkSium5AI482seEL1M9gd2dXqOeVOmA9NN/RNSpTerxGK7hBVsPHeWRHxzo9oDW+Ri25s+MuXpZZe3t1XNiJViP49Pct12HQ7OuXCkaDjWEyIQ7bA9J1vifMvkWEgr0dl7CJ1bKs0NPxqptxOLstj+jgjcEX/bygVNsjO59iXcwXjxko30YRXYLc7qVQHIGycspDg5KF8J0XJzvYjtVQ4+YApWN/AWJqdFUrEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cypress.com; dmarc=pass action=none header.from=cypress.com; dkim=pass header.d=cypress.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cypress.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbGO6BtiGo8RXeJy0V305oVt2OBv9ZSO5GQ2MnIfEeo=; b=NRk4S7/R8Dx5E4wHiWhQhzUb/gLftsN+ZYHOdI/PvJkZ8SxzyAfqX26nohpmbfhclCAYMTvlSGOO8/hYux+HL0MfMJ7hs2BObP+bkUavJYLbQCw38YAiUk0dEWFem7vBABHwGttHJezxx2CVle11LaB2p6179JfCPbrwNkDbjOc= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cypress.com; Received: from DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) by DM6PR06MB6043.namprd06.prod.outlook.com (2603:10b6:5:10b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 11:10:02 +0000 Received: from DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f]) by DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 11:10:02 +0000 From: Chi-Hsien Lin To: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Chi-Hsien Lin Subject: [PATCH 1/4] brcmfmac: fix a sparse incorrect type error in p2p.c Date: Tue, 19 May 2020 06:09:48 -0500 Message-Id: <20200519110951.88998-2-chi-hsien.lin@cypress.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200519110951.88998-1-chi-hsien.lin@cypress.com> References: <20200519110951.88998-1-chi-hsien.lin@cypress.com> X-ClientProxiedBy: BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) To DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from aremote02.aus.cypress.com (12.110.209.245) by BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Tue, 19 May 2020 11:10:01 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [12.110.209.245] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 41ea11f3-6a1a-4b82-9d52-08d7fbe52d3d X-MS-TrafficTypeDiagnostic: DM6PR06MB6043: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:106; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VP2r4o3lj3ugK3Z8OTgid3N3vuliwcGPs+aOhdafRi/uaMKk1+Iav4LYNEvBpshFsKcD+xlXSl0kBlWrD8ffSzRfpoaCMRWAKTF8/8Pw1vBjbvCCVnNgUa3IbZ3+wAOlEPoQSkBZKUq4fmLQdXWxfp5CotKalmSzhRY9l/oAd3m5InmF8DL3l6J+ivpZ4L2UDmxtUMOvpTR7guZYe6YiWzo9YjHlnAsYaULKySSp969Wi+ol0+y5LWjvQOgv7an/sxWYHDaTU2ZVQmRrsOZ9cQD+HvJ18N7NpSm+cYhdqWGi0wBFF98eG40uVlOWeoO8BfEAyUCuAwXtDhgcW9sNdzKb/Ks3Kvj5DbxHlYQVbu0kaW6vzwCUmwvfjcRQiQ7O6fjEYZgBydRSD4FSe5GWYGupiNsDQYlAaI2kxwG4kIoZJoJ5EvG9sw8NMJInmD2G X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR06MB4906.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(39860400002)(366004)(396003)(136003)(346002)(52116002)(66946007)(66556008)(86362001)(36756003)(7696005)(54906003)(66476007)(8936002)(8676002)(6916009)(478600001)(956004)(316002)(2616005)(6486002)(1076003)(5660300002)(6666004)(2906002)(4326008)(186003)(16526019)(107886003)(26005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: RXUnTtIDSZXXEub1NvyBxzK8Ag2X9T/xJ+wQkiWSZk8ZCHLl73oXQTgSjx21b3aOqlM/ceXV5J4UcpcP4Zi5zzqUg/AagZPUZrZmF9sUQLwauEfXuc/rO+AOo1FQOidwNEP/MxF4H3T5wkzTuKZL0XyHL91abZRrOoQlYIwCHNzOGcbr13JbkQu8YBbc0lUOE18bHPcro2f3DLWW2fodCO2WdkR4oop51/vngJD/AZtEpU2AMdwyByvDxo3dSU/EjR40jLPuiWWCKbEOvC7pb8qoO+8LOTwiF8bJHjImZAUNIXXa+69BwDoNu6NWFyE1U1s2swD53h7StcUWe3aqerK/HT2MNHDfKit2v4dwPp96qK8y465eymUjmvRNtrmnudV0ysGn6OX09UyvIbSoaKeNuaRQTpdp4RogvjT4GwOk+MXktzkbvvHt092lJyn3LKgcy13c3R4D7dY2MBSrWSFO3adhqhrn+bpZoBt33WpaHzWcdxjf5hMIsigj0zc/ X-OriginatorOrg: cypress.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41ea11f3-6a1a-4b82-9d52-08d7fbe52d3d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 11:10:02.5387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wR010v45d6M/pWeIT2EBcSU2nA9n/nTwZd64Vhww/eP6MLvM8760lEzSr9AmdnYqlm+xrBMjXEFPfrkF/Zk5rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB6043 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix the below sparse error introduced by commit 9c29da3f4e7e ("brcmfmac: Fix P2P Group Formation failure via Go-neg method"). drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40: error: incorrect type in initializer (different base types) drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40: expected signed int [usertype] requested_dwell drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.c:1741:40: got restricted __le32 [usertype] dwell_time make[3]: *** [drivers/net/wireless/broadcom/brcm80211//brcmfmac/p2p.o] Error 1 Fixes: 9c29da3f4e7ef ("brcmfmac: Fix P2P Group Formation failure via Go-neg method") Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.0 This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message. diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index d2795dc17c46..194c1ac19402 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -1737,8 +1737,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg, uint delta_ms; unsigned long dwell_jiffies = 0; bool dwell_overflow = false; - - s32 requested_dwell = af_params->dwell_time; + s32 requested_dwell = le32_to_cpu(af_params->dwell_time); action_frame = &af_params->action_frame; action_frame_len = le16_to_cpu(action_frame->len); From patchwork Tue May 19 11:09:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chi-Hsien Lin X-Patchwork-Id: 11557455 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 37497912 for ; Tue, 19 May 2020 11:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17CDE20708 for ; Tue, 19 May 2020 11:10:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cypress.com header.i=@cypress.com header.b="GV+OiX0s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgESLK0 (ORCPT ); Tue, 19 May 2020 07:10:26 -0400 Received: from mail-bn8nam12on2135.outbound.protection.outlook.com ([40.107.237.135]:17729 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726157AbgESLKZ (ORCPT ); Tue, 19 May 2020 07:10:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQxRVwsDv6ReGOS9c9ChuoITqxZjVC+13bDvurJtIKOa41C42yFs7nU6c44O3XOKVLMYts8Ks6zKL2UxYky668AjflqK6OxlNjPvW6jCpzICcsJTwpYpungWfXfgXqfmgLVi+iL4Lod1Shdevr9spFPD6m0HsAcV6hSIvUWDY0zPphfgYRn7BaXWTaRF/WMpUmAH3KZnW21Rn1axWSm0salWQZwTUbqwQbfiRuaArBA4KPgW9JP/M5BjGuR43zYUvKnXTY87xshrXpi/47NrMwgIauWj2RMwuMOyhFAcH8995dQ10VxJFx6mYpgBNtxCtE/yam9m2ZTqGCgsML02XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vFl4eDshnBc9/N4YSvMdg/4KOiru8DQ+T8l5ylSAme0=; b=bWo77YM3Tk6KZsw1x7wFe/XHR999S4a0jIHAh9A2xHFvYXAwD8n98gwxQe0ruf44TNqnuKNKwuWBSB5to4OrhwEv1qd2fsrE1ZFHBj3xFjCDmA1JbjGcfUJh6wIvhl2nyNAefQfAjVNAWOCG2iU4XxpcpANlCgamYYMha1SjsgKx3xadFZ0ygNkGDntnjDAJ3pbvQQlkU+Lt44ZmwU2Rv4bn7t3KbWwMPZ6Ke3gZl2dLcJIDpZ5T5IwUpOmP5NzBmUtmg0hQ2pwPA1OSH/Vr8t6AypcpBr8/2ju5fVimIH8ouaJXKp606PpJO/R8ibpsj9UYCv9hZqmOp8IMChKfwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cypress.com; dmarc=pass action=none header.from=cypress.com; dkim=pass header.d=cypress.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cypress.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vFl4eDshnBc9/N4YSvMdg/4KOiru8DQ+T8l5ylSAme0=; b=GV+OiX0sNeZyXoMLbtugCJpV9cCslLpL8SwnzdUiGOpKaJxSkIoq+KUOsXQRiZE/zt4Ewp3Irj4AYGEI69TVPe97hvX+9mIPCCpzg/smK7xY0obBsTl0GuZOgAF6qp1FoMjtluhgYP2iB7FWyqk6DYhNmqw9Vg8ZpO19q27TTTI= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cypress.com; Received: from DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) by DM6PR06MB6043.namprd06.prod.outlook.com (2603:10b6:5:10b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 11:10:18 +0000 Received: from DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f]) by DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 11:10:17 +0000 From: Chi-Hsien Lin To: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Double Lo , Chi-Hsien Lin Subject: [PATCH 2/4] brcmfmac: support virtual interface creation from firmware Date: Tue, 19 May 2020 06:09:49 -0500 Message-Id: <20200519110951.88998-3-chi-hsien.lin@cypress.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200519110951.88998-1-chi-hsien.lin@cypress.com> References: <20200519110951.88998-1-chi-hsien.lin@cypress.com> X-ClientProxiedBy: BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) To DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from aremote02.aus.cypress.com (12.110.209.245) by BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Tue, 19 May 2020 11:10:02 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [12.110.209.245] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0e3b10d4-5e37-4ecf-e669-08d7fbe52e2a X-MS-TrafficTypeDiagnostic: DM6PR06MB6043: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:165; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XlKQTM7NbWIsSbHWhUh8Fz4oaLt/Fu10vRRYvLy5N9vJNpnIYBh9Cq36B/tsmpFyjfnrBsxXXUPfUilNspAa9BPCen5C5eGDxYfoalK9ZBTRgNCfAl+UbzduEJALJKo9aCjujiLOyrovxXqGcaNZB9mtpf79xv6rj3UfWybySaj6GkvHLsESufD93pAYzWHbAvoOGUqSBY+SRDWFwdiFBYB6fshwV8KQHRqn3lBNbXziUnwZOQlEL5HxnL2Jx+okmAZ10+BKTwiovRsf/kb+2F2QQRru/e1P7m31FgT5yid9Amag0wwxfZYjT0Ey6sGqfhUgK8tqtjMYgLUQWrAi0POTG+ZCU1ucE3zlAQF73txMvyKiNfG0YVNt4G07J5/HxK0izyg6bnsgnK0g8kiuss8qoN6COSj/+GDG2N3mQ1V14wTby2oTyXMftRzdptPS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR06MB4906.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(39860400002)(366004)(396003)(136003)(346002)(52116002)(66946007)(66556008)(86362001)(36756003)(7696005)(54906003)(66476007)(8936002)(8676002)(6916009)(478600001)(956004)(316002)(2616005)(6486002)(1076003)(5660300002)(6666004)(2906002)(4326008)(186003)(16526019)(107886003)(26005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: XNuOkqvPQDUjEoxCtXlCNJh/lTqEj+l78QquKZGQgCOhY+k2kUmdWWvyRcmEI1BV5PAo759s+W55by4yp+d+cw0W5ONtlIsoZ5puRMkPfhAisCepSYB+COBF4yrz92MTq2aOC2Hzxu827siH32ik80g3jOXUWr1IqDwP823JN4Ps6elZ51+x/FFG/V0Ir711hKmNSuRWf0pxgJi3xKqwNALSmI70X3nIwPf4scA3p5uCbAfoCh8zZ4IUgpIjA86fpB6ZDUB/dCDw91cWYuMmhYdn1CzqgBZJbgdjJwzYfRNS7cYekvaxpTXT8tFodumYLl2QMIvIrmUbOyQ/w9J0obN7yw+nsxn+Tv3UTLMxElCKpHTV4QRnDQhJrZq35AabxmjoXdC2tZtfK4vMittNHxsdOp6XJg66IJ8hxfaQIJGOzyUXEb9wS0+VaW3zJQf+hfIMiNABxj5W9drPnjStydEYjamS1NdSEblVgv/nsHVhyLyUR3aIb9QrmA3jQF/i X-OriginatorOrg: cypress.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e3b10d4-5e37-4ecf-e669-08d7fbe52e2a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 11:10:04.0898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gh799I7tkkY7kNEdICkKBLp5V4WhP5Bp4tOY5KVFT3jru/ygTXXwJHyoJJOo4tchetyBDfmPdS1q4XplC8hh3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB6043 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Double Lo Allow interface creation via IF_ADD event from firmware. Signed-off-by: Double Lo Signed-off-by: Chi-Hsien Lin --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 46 +++++++++++++++++-- 1 file changed, 43 insertions(+), 3 deletions(-) -- 2.25.0 This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message. diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index a757abd7a599..900376dc0b67 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -230,6 +230,9 @@ struct parsed_vndr_ies { struct parsed_vndr_ie_info ie_info[VNDR_IE_PARSE_LIMIT]; }; +#define WLC_E_IF_ROLE_STA 0 /* Infra STA */ +#define WLC_E_IF_ROLE_AP 1 /* Access Point */ + static u8 nl80211_band_to_fwil(enum nl80211_band band) { switch (band) { @@ -5532,8 +5535,10 @@ void brcmf_cfg80211_free_netdev(struct net_device *ndev) ifp = netdev_priv(ndev); vif = ifp->vif; - if (vif) + if (vif) { brcmf_free_vif(vif); + ifp->vif = NULL; + } } static bool brcmf_is_linkup(struct brcmf_cfg80211_vif *vif, @@ -6090,6 +6095,9 @@ static s32 brcmf_notify_vif_event(struct brcmf_if *ifp, struct brcmf_if_event *ifevent = (struct brcmf_if_event *)data; struct brcmf_cfg80211_vif_event *event = &cfg->vif_event; struct brcmf_cfg80211_vif *vif; + enum nl80211_iftype iftype = NL80211_IFTYPE_UNSPECIFIED; + bool vif_pend = false; + int err; brcmf_dbg(TRACE, "Enter: action %u flags %u ifidx %u bsscfgidx %u\n", ifevent->action, ifevent->flags, ifevent->ifidx, @@ -6102,9 +6110,28 @@ static s32 brcmf_notify_vif_event(struct brcmf_if *ifp, switch (ifevent->action) { case BRCMF_E_IF_ADD: /* waiting process may have timed out */ - if (!cfg->vif_event.vif) { + if (!vif) { + /* handle IF_ADD event from firmware */ spin_unlock(&event->vif_event_lock); - return -EBADF; + vif_pend = true; + if (ifevent->role == WLC_E_IF_ROLE_STA) + iftype = NL80211_IFTYPE_STATION; + else if (ifevent->role == WLC_E_IF_ROLE_AP) + iftype = NL80211_IFTYPE_AP; + else + vif_pend = false; + + if (vif_pend) { + vif = brcmf_alloc_vif(cfg, iftype); + if (IS_ERR(vif)) { + brcmf_err("Role:%d failed to alloc vif\n", + ifevent->role); + return PTR_ERR(vif); + } + } else { + brcmf_err("Invalid Role:%d\n", ifevent->role); + return -EBADF; + } } ifp->vif = vif; @@ -6114,6 +6141,19 @@ static s32 brcmf_notify_vif_event(struct brcmf_if *ifp, ifp->ndev->ieee80211_ptr = &vif->wdev; SET_NETDEV_DEV(ifp->ndev, wiphy_dev(cfg->wiphy)); } + + if (vif_pend) { + err = brcmf_net_attach(ifp, false); + if (err) { + brcmf_err("netdevice register failed with err:%d\n", + err); + brcmf_free_vif(vif); + free_netdev(ifp->ndev); + } + spin_unlock(&event->vif_event_lock); + return err; + } + spin_unlock(&event->vif_event_lock); wake_up(&event->vif_wq); return 0; From patchwork Tue May 19 11:09:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chi-Hsien Lin X-Patchwork-Id: 11557459 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9ADC13B1 for ; Tue, 19 May 2020 11:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A68120708 for ; Tue, 19 May 2020 11:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cypress.com header.i=@cypress.com header.b="Ddiu6Uac" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728632AbgESLKa (ORCPT ); Tue, 19 May 2020 07:10:30 -0400 Received: from mail-bn8nam12on2096.outbound.protection.outlook.com ([40.107.237.96]:16865 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728625AbgESLK3 (ORCPT ); Tue, 19 May 2020 07:10:29 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQTA+nORvbu6yH8IO3KwgTB5Xh0cSylbomNJDTYxfZeRSP+O5Is90M80NgwtLrVA5fujvAXYadj5cONgVUmJPAGKu4J+hQd7pE20zhcxnU0nPTZeiuz57nvVZSd5O6DTCBzLSwLfeyf/6tF800wV2KMiaZBT1HQjKgG8kgY503TOnidK+rSek+lx1eA3/vQGmEyW4nvNEptH9lqLvQ2ydBMpis4gMKeE2e5G1pNeS5RP8gvedP+iFVOxiuIKDWX8vIU1OS3RAJHVtP6bDtRnmNpJ06UvhgP3dmHsSFcZEfAXWl82is36lSFKO57AQTOe1sXqsypnL/izwAurOvtQNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20D4lPd8XG8+TFxRLQPWnsT1/jy9mV551VGUjg2RvMw=; b=oKNJItBWLXhvte5jfWC38sKRlHPjpFCbrCLlWkvjN4cmCwrGwlOe8SiGCON8vpYISIPrhU3Lk364t8ZkxjDVACBgDeKWinSqDRhkXuxQJZUZ7VBwadW3yyDMS1AgHA12LF1CXHv74q4ewnFT12coFAYW3w/0sQ17O0y8eVeehad5lof7A5lehn1SgjRl7VQqINLDNPlSDjxwdic8+I4H516V0tgFI1m8g+92t/E1yKgHt4nSQWBdtsap6bKrdMvoMH+2E0Jcy8qheUkySZU5+Y5bgBDL7UOPw78iWVsBChwZ2DcOcHtrX8M0ro+G7uSQK7Om16I5M6XoZImiqttrVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cypress.com; dmarc=pass action=none header.from=cypress.com; dkim=pass header.d=cypress.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cypress.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20D4lPd8XG8+TFxRLQPWnsT1/jy9mV551VGUjg2RvMw=; b=Ddiu6Uac4BL5Le+syD2KGbfbuV5jYlYNCzPzttw5Q3jfD56svOYCt2GoI8SNRjuYAwSfxT8j7qr+iX9+wBjZaEGWVw9E2C+CIHW8rHCQDf4LMt7WGElCneXP5YG76qYM+BEdD5Ti/wTThSy/aEkyNCGW1Bog6E5oVQm6UHbYHEY= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cypress.com; Received: from DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) by DM6PR06MB6043.namprd06.prod.outlook.com (2603:10b6:5:10b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 11:10:21 +0000 Received: from DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f]) by DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 11:10:21 +0000 From: Chi-Hsien Lin To: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Kurt Lee , Chi-Hsien Lin Subject: [PATCH 3/4] brcmfmac: set net carrier on via test tool for AP mode Date: Tue, 19 May 2020 06:09:50 -0500 Message-Id: <20200519110951.88998-4-chi-hsien.lin@cypress.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200519110951.88998-1-chi-hsien.lin@cypress.com> References: <20200519110951.88998-1-chi-hsien.lin@cypress.com> X-ClientProxiedBy: BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) To DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from aremote02.aus.cypress.com (12.110.209.245) by BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Tue, 19 May 2020 11:10:04 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [12.110.209.245] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d99a9e13-0ba9-4c51-6ba3-08d7fbe52f20 X-MS-TrafficTypeDiagnostic: DM6PR06MB6043: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uGpyZRhzOGnoCmx5Ih9LAcDYqtyFroJTePr8D3uVsUUAvv3w+NGEl6TIqV257XQWyIhNlvUb4Rwc7Mt01CIX9wFmXA03cTGrTpSN5VSQRILXsRPIdKSaCOuLorsM3WLjXFdNBgnUDWUXlZWk7jepvrdTEbu1t1jzRp7+3M+nBOnroLZSch6cedt2RwD0x6P6YkHj7ANZw+fNoo5Hxv9H+Z+H185xUogTJLVpFOXiWiVBuO3dcwS9fNtQUOuIN3eSDhz6F6sDyCvVQrfZRMJJqJI1jAIaWy9hM2hBnZbH9jRRG3jScf7k6XtAGPEnjlxEyYj4nja09FnPTct48FU+g5tkwnw7TgFBpys0jiz2KzL0EpA+8xzJnf8+IBzI829TtxUUab0ac7tTMZMCO+4UIObyh6ef1hOotUzvO+hQuv4w+NpclZYZifbI+v2UFCZz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR06MB4906.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(39860400002)(366004)(396003)(136003)(346002)(52116002)(66946007)(66556008)(86362001)(36756003)(7696005)(54906003)(66476007)(8936002)(8676002)(6916009)(478600001)(956004)(316002)(2616005)(6486002)(1076003)(5660300002)(6666004)(2906002)(4326008)(186003)(16526019)(107886003)(26005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: BhkXbMDDnrLAUE+GSCMkrrHGe2NGdRsYppIKK/s7rOkfHQr2ZnIxL4azfGbUajzpkpy5KZ3OsiynkSF8Ek7ltnhweNH3h/3z5b4v8Zgx33iNp8UZnUX5c8h32735v/S8k5EdnW00mF4XHEf2VBKn5Sep93+NygG7MpM0wcHpGZb/vrhTnOL4Y5MWtXRYhPKANnwma6B42YUpvOSIR1QL9eSdN5/6WPqgzleY8w9cj/789Lnn5CYAEPrwv8FYBfM6O/rWH9wrsW/nIHknSwsB0Ci92gKthjjrUxUrpdPTh/wMp/8p79FOAN7AVz2Wbhckd8Hs87fzwyx7oP6tDA4Z1QaUMG2QbVhsbUUYQfHmW/rhbiTqiauTiiRjfSMZAFP9KUzfmxRAlELfNa98C8+I0tzU6ils/S12wqSevGjjbFbzNRzCyCZUNBobcHl0muF9NCTm6F4Nixt8MpxbVJ9LRun0AQNpFc4QHYLY2gbR9Slq1v3Fj6ZfOERI7McAEHTu X-OriginatorOrg: cypress.com X-MS-Exchange-CrossTenant-Network-Message-Id: d99a9e13-0ba9-4c51-6ba3-08d7fbe52f20 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 11:10:05.6938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7gbSJWlZjWCv+blqweknUP52RA/KU0KLad1rMxcs2NjH9l+1AxYQLQf16wFu4Ip6gQbory5tLYwaxWG6x2kw5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB6043 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Kurt Lee In manufacturing line, test tool may be used to enable SoftAP. Such SoftAP can't pass traffic because netif carrier is off by default. To allow such use case, let brcmfmac parse ioctl cmd, and then set iftype to ap mode and report netif_carrier_on to upper layer. Signed-off-by: Kurt Lee Signed-off-by: Chi-Hsien Lin --- .../net/wireless/broadcom/brcm80211/brcmfmac/vendor.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.25.0 This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message. diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c index d07e7c7355d9..5edf5ac1167a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/vendor.c @@ -64,6 +64,15 @@ static int brcmf_cfg80211_vndr_cmds_dcmd_handler(struct wiphy *wiphy, *(char *)(dcmd_buf + len) = '\0'; } + if (cmdhdr->cmd == BRCMF_C_SET_AP) { + if (*(int *)(dcmd_buf) == 1) { + ifp->vif->wdev.iftype = NL80211_IFTYPE_AP; + brcmf_net_setcarrier(ifp, true); + } else { + ifp->vif->wdev.iftype = NL80211_IFTYPE_STATION; + } + } + if (cmdhdr->set) ret = brcmf_fil_cmd_data_set(ifp, cmdhdr->cmd, dcmd_buf, ret_len); From patchwork Tue May 19 11:09:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chi-Hsien Lin X-Patchwork-Id: 11557457 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DCB4138A for ; Tue, 19 May 2020 11:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F8820708 for ; Tue, 19 May 2020 11:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cypress.com header.i=@cypress.com header.b="OvF6n9Bz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728573AbgESLKa (ORCPT ); Tue, 19 May 2020 07:10:30 -0400 Received: from mail-bn7nam10on2100.outbound.protection.outlook.com ([40.107.92.100]:56385 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726157AbgESLK3 (ORCPT ); Tue, 19 May 2020 07:10:29 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YwuZEMzxa9u36yGhv/C42h0sB4HrQvXQjHu+1QbM5w1nYktfCe0wJmYhgOdhiT7NyWPCMDzuSkPAwL8eGkdJVrfBMsTtPGAxY+t2bKjQf5e+hMC2lBidcwGqddrehubi0iQrSVh1+ayqPnW0455QTPvNhxQh7iFAs0VJh95Z8k7jQ2pWEpW0L343rdmSGBA4zq+kX/MjL0kHyfhR3mdG8fvlslOf3pnbIlMXJ5J19jM+Y5bZSgs9Nc3z5bUpw5PceNhLWtanaCA+KE4/dFDzZDGwIDmUH5XXDmAhv8EmTy30zfOk6Djcw3ATdBBUyC0KG9HhrOghb5RpK4JccUC2Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VICEm403AhP5Knd7Lytlui+ps2b/Q+mICDGcXfHd65s=; b=ihWRVM7aQu8PxkH7Ak4phT99w9Fi4xKsNU33c5KS7DuSq9LCO20/KycBxLN1alawBKq7X86Z7RC9cp0aGR/3//na2mjOeFQ/9iYU8wCY7HKHAp2rjegPgwgbovXZFyYsyFj0FMj59Dw2N34/HVfi0cRgkeBU6y7F/ECG9rOA9ewuhekQ1hDOXwbNubRDf9uXqWSGlOt/D47+Bl3f7BIH/J73j3linYTanqoWMESO0taGERGCkKgJ/JMj+jMzW1Khdh4K6RVaA68OqI0PgYP1h3WTydWWaO8LC6SU73wieB/203OEjrnC/YuT+TVX0m7C4liiBiojdoGt/SZMyakFLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cypress.com; dmarc=pass action=none header.from=cypress.com; dkim=pass header.d=cypress.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cypress.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VICEm403AhP5Knd7Lytlui+ps2b/Q+mICDGcXfHd65s=; b=OvF6n9BzcGgoWtWQ5Ia9QBqny799nBQGtUuNKAP96QaOmAxg2+4ieBL2qO+1V+HOS1UpciA8C+REKp45WfIAGi88UQ4jH6pas1uMWHwjeMT8DIE93y0uZOWtBVozE7f2NAbqHpEHWO9M19mkyaqPhRUY3IJTudHuc78eX1XG0Fs= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cypress.com; Received: from DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) by DM6PR06MB3964.namprd06.prod.outlook.com (2603:10b6:5:86::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Tue, 19 May 2020 11:10:26 +0000 Received: from DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f]) by DM6PR06MB4906.namprd06.prod.outlook.com ([fe80::c0ed:fb1f:a976:5c3f%7]) with mapi id 15.20.3000.034; Tue, 19 May 2020 11:10:26 +0000 From: Chi-Hsien Lin To: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Double Lo , Chi-Hsien Lin Subject: [PATCH 4/4] brcmfmac: increase dcmd maximum buffer size Date: Tue, 19 May 2020 06:09:51 -0500 Message-Id: <20200519110951.88998-5-chi-hsien.lin@cypress.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200519110951.88998-1-chi-hsien.lin@cypress.com> References: <20200519110951.88998-1-chi-hsien.lin@cypress.com> X-ClientProxiedBy: BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) To DM6PR06MB4906.namprd06.prod.outlook.com (2603:10b6:5:56::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from aremote02.aus.cypress.com (12.110.209.245) by BYAPR06CA0029.namprd06.prod.outlook.com (2603:10b6:a03:d4::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Tue, 19 May 2020 11:10:05 +0000 X-Mailer: git-send-email 2.25.0 X-Originating-IP: [12.110.209.245] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 437d01be-e2cd-49fc-e892-08d7fbe53010 X-MS-TrafficTypeDiagnostic: DM6PR06MB3964: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1148; X-Forefront-PRVS: 040866B734 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: neMMvItcLTXCzjDMitD8Hpr+hCVNiTiYtbjrzxtLCwrWZ1X11VLsSJtK5R32ORdTuHpuQoL7TSDBEUXmBmWQQ5GaIeOCduKl98GdbCtZqPK72gdblDorSGEXrvHJCMZC8gWz9TkQu7hw0smdspbB+c0lCpBZXOTh3zQxF1kdiePhEEJSId1ewPsF274OWVAsfdZUHbAVVxBcLTqz48y9DZIwcJro+VmFzVK/8CztFwWv/lriGKz11cy/ZVfCI9oulOKats0koMkCL2WPK0kjsrWh97VnknMseJYM9LTZ5q0otZRgn6rcF13+mU+RlbS+4hOtUOi4p4sts8J9Y1BMxsfp+MkrTQF7kuGhy7AgoUi08cpL1RBTHj8y2JBGApjMYodo6p4+0nGZaJtoDt7KzjFK3+UAHx3bcpvJXtD+fvmS+vSIIk9L2EcP0CNfOpZh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR06MB4906.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(376002)(39860400002)(396003)(346002)(2616005)(316002)(26005)(54906003)(107886003)(86362001)(2906002)(956004)(4326008)(1076003)(6666004)(6486002)(6916009)(16526019)(186003)(5660300002)(8936002)(7696005)(36756003)(52116002)(478600001)(66946007)(8676002)(66476007)(66556008);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: vF1iGIYtGl4vVcTJgiqZQWiQrAwkVTd/eGhRxNidKwBlQ6r0Y7tZqQAV30cNfJrcll16S5i5mN9jwc33diiOIl4hd0uU2ld2m0vuK9TKWkdtQLydnHSn4JZMjNO1U8lFU4E/0BNEQk2fAc/ACE0t1LacwBa9hrgifsTj0ynXx/jXzIdd2bYi7IW24TcIRDnj+p167XLbAwkh+HPPuR3c7KMJnDrqzgv6tyQBznDO1ACEzxj8y0XWXe9LSe/LDViqswP/woJUtgCaKyU8C0pJJj0AWdNaSERyIFU4UL84V5XmIIrXL8OSwPdgi/wcrAgCFHGO7883Q3e23/c9dZFT1DEGCzDuWj6UlQq5jfzBB8Y+VgqNa4Ff6Lfh87mBgUSB8RhTMK5LYCTy9YtB0W9iqhdvJi0SEn5wtcJDAhSS9YDQTU9AOCBwRP6X9URCAosSbIxhAMs9LIfeWoKbsYdgIa21Y7dpjJo6kaZ+AO4FtL0PUtBamHTWIkEUrm3qxNHF X-OriginatorOrg: cypress.com X-MS-Exchange-CrossTenant-Network-Message-Id: 437d01be-e2cd-49fc-e892-08d7fbe53010 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2020 11:10:07.2369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: US5JsQjS+JJyldEY0ILWOtJCQS9wezsrw1OPY15FqxtW98AWjy//WsHuySRaqxP9IjaF7pEdaMosPQBVQrmNpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB3964 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Double Lo Increase dcmd maximum buffer size to match firmware configuration for new chips. Signed-off-by: Double Lo Signed-off-by: Chi-Hsien Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.0 This message and any attachments may contain confidential information from Cypress or its subsidiaries. If it has been received in error, please advise the sender and immediately delete this message. diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c index 2c95a08a5871..705130cf27d5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcdc.c @@ -87,6 +87,8 @@ struct brcmf_proto_bcdc_header { * plus any space that might be needed * for bus alignment padding. */ +#define ROUND_UP_MARGIN 2048 + struct brcmf_bcdc { u16 reqid; u8 bus_header[BUS_HEADER_LEN]; @@ -471,7 +473,7 @@ int brcmf_proto_bcdc_attach(struct brcmf_pub *drvr) drvr->hdrlen += BCDC_HEADER_LEN + BRCMF_PROT_FW_SIGNAL_MAX_TXBYTES; drvr->bus_if->maxctl = BRCMF_DCMD_MAXLEN + - sizeof(struct brcmf_proto_bcdc_dcmd); + sizeof(struct brcmf_proto_bcdc_dcmd) + ROUND_UP_MARGIN; return 0; fail: