From patchwork Wed May 27 09:06:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572351 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EE48790 for ; Wed, 27 May 2020 09:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D761B2084C for ; Wed, 27 May 2020 09:06:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="D9SRndsN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388503AbgE0JGf (ORCPT ); Wed, 27 May 2020 05:06:35 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:1485 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388330AbgE0JGe (ORCPT ); Wed, 27 May 2020 05:06:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570394; x=1622106394; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=UQhCFs5M0TuJKwieIYLpaCSxjEN4IzcEDkm4f4sP1qI=; b=D9SRndsNx9mJcW1XV4p6qGzA6iBUD8T3EVysUJuYM5JizX8guS6IxLFP lM9dwty4rdqv8g7Pr9lZMmCBYzzCP3HnJrwHkXkOAMZsUEzA40gTCb1Po HWgXKxooCQ9i45ccYOVfPe2apmTAbyBkHTd3RodfItxDuXDJfbXnxlvJO Ogy3pgHrw1TmSH7xoQ+UGaigGhNSmfq31o9xpV569e+zZAmoJ4fEP2/Tw isIzlmEOXBV5gkuhIFuFymKOIBkFcgDaNKv25rSlaaXXKrWMQArOVyky1 pu+teI4F2I86tDYEcA3eGC0Uae0QGaqmAdIarR7Oi0ZSzXql+ld91VzkM w==; IronPort-SDR: rykcD1jpoRaddSsGpC1Py2gQs/RJUJQtnj6j9oo2dORH56zZc6MZOSzKdC7WzAD2H7dFy8KXpV chr+jkUFoB1Bw88Dl6dB4j8OatUPiCsGuagR2/yP9kd4T59at9GRnvAb8VYs/4SQAO/5AHDEDv FPuiJQybHtSqJ947TztcuBy3MQkb+Wyp7BmsIdULY8jGRVfuE/Vp4zuGbcm2Z79/ZT5Gi2yFbL ECx/Xdmnv/JEUIsPCSjjHhk3Wmyb70L1sAKsKnsL4XIYxjfBsRQ6NMVDMo9+oXKfly/hFnLkCY Jwc= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="77204586" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:33 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:32 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:31 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 01/10] staging: most: usb: change order of function parameters Date: Wed, 27 May 2020 11:06:18 +0200 Message-ID: <1590570387-27069-2-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch swaps the arguments of function get_stream_frame_size to have the struct device as first parameter. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 56b75e4..0e1264d 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -183,10 +183,11 @@ static inline int start_sync_ep(struct usb_device *usb_dev, u16 ep) /** * get_stream_frame_size - calculate frame size of current configuration + * @dev: device structure * @cfg: channel configuration */ -static unsigned int get_stream_frame_size(struct most_channel_config *cfg, - struct device *dev) +static unsigned int get_stream_frame_size(struct device *dev, + struct most_channel_config *cfg) { unsigned int frame_size = 0; unsigned int sub_size = cfg->subbuffer_size; @@ -270,7 +271,7 @@ static int hdm_poison_channel(struct most_interface *iface, int channel) static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); + unsigned int frame_size = get_stream_frame_size(&mdev->dev, conf); unsigned int j, num_frames; if (!frame_size) @@ -304,7 +305,7 @@ static int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo) { struct most_channel_config *const conf = &mdev->conf[channel]; - unsigned int frame_size = get_stream_frame_size(conf, &mdev->dev); + unsigned int frame_size = get_stream_frame_size(&mdev->dev, conf); unsigned int j, num_frames; if (!frame_size) @@ -600,7 +601,7 @@ static int hdm_configure_channel(struct most_interface *iface, int channel, mdev->padding_active[channel] = true; - frame_size = get_stream_frame_size(conf, &mdev->dev); + frame_size = get_stream_frame_size(&mdev->dev, conf); if (frame_size == 0 || frame_size > USB_MTU) { dev_warn(dev, "Misconfig: frame size wrong\n"); return -EINVAL; From patchwork Wed May 27 09:06:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572353 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 871EB14F6 for ; Wed, 27 May 2020 09:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F89A2084C for ; Wed, 27 May 2020 09:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="E2MwPmnJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388504AbgE0JGf (ORCPT ); Wed, 27 May 2020 05:06:35 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:1488 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388501AbgE0JGf (ORCPT ); Wed, 27 May 2020 05:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570394; x=1622106394; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=4fyavP8fBjWc2V5YbqLvlyLFNgK3DRieJZKIShd5urI=; b=E2MwPmnJt4pllixtL7a2M4bxLKtcYb/z0SU1y99PnVF+gkseRUXO+Pj5 9FOPh6naINQrw6nqFmOEIkuTdBlvcqTYU15bgwmZno+xeeZQwwMb2z8Fz TyWV0BdNT4hSnQB/9XC5q5ctQ+JOZl2c7+RVptubr/AH6YZctwZ++YeHN SJeq466eDUoV/Yg8vgYYhSmPi6uIphNkDTcZfS0FAhp0lVl5bG2H/YHXs NXGIlPlisXhwckPpQccJQhpZV0cMS9/foxHQ0gkfpV6Nn4KFdlx9UHEza j3lHO12GwF7r3wQ1Mb9tQVab1L2VrInpEU+XstHm3V15+5fRCdGUSyW6s w==; IronPort-SDR: cL4GyGm1NPvPFKOUONDjewgN2Rmqt+MhZ3fPmRtrQgUXkqWsplDL3JVVRRx2RUouzuNt6P66/T iHcP7p1k3Za09BN+vBzxRK5PsW1F1gFiM1cxTWqWIq4psfYfYCAhdPx7DCH0fKNiKyKV4yFKsr 8tvUTyP3al2zai9l92XlH0YQf6YcZZ/86PjOGe9wHe/kY0LxlVKE8Uwb9TwI1BTfkpsn8RFC+x LtpniwsYM3ZXRWARFGhTkUTkkTyM4LAKJxPwvDsYiOFvCfD3vuwvosjw/MpenZsuYozB8yNrVk iaw= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="77204588" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:34 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:33 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:32 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 02/10] staging: most: usb: don't use expressions that might fail in a declaration Date: Wed, 27 May 2020 11:06:19 +0200 Message-ID: <1590570387-27069-3-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch moves function calls that can fail out of the declararion block of a function body. This is done to enhance readability. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 0e1264d..fd0d885 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -139,9 +139,10 @@ static void wq_netinfo(struct work_struct *wq_obj); static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf) { int retval; - __le16 *dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL); + __le16 *dma_buf; u8 req_type = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE; + dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL); if (!dma_buf) return -ENOMEM; @@ -846,8 +847,9 @@ static ssize_t value_store(struct device *dev, struct device_attribute *attr, const char *name = attr->attr.name; struct most_dci_obj *dci_obj = to_dci_obj(dev); struct usb_device *usb_dev = dci_obj->usb_device; - int err = kstrtou16(buf, 16, &val); + int err; + err = kstrtou16(buf, 16, &val); if (err) return err; @@ -939,13 +941,14 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id) struct usb_host_interface *usb_iface_desc = interface->cur_altsetting; struct usb_device *usb_dev = interface_to_usbdev(interface); struct device *dev = &usb_dev->dev; - struct most_dev *mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); + struct most_dev *mdev; unsigned int i; unsigned int num_endpoints; struct most_channel_capability *tmp_cap; struct usb_endpoint_descriptor *ep_desc; int ret = -ENOMEM; + mdev = kzalloc(sizeof(*mdev), GFP_KERNEL); if (!mdev) return -ENOMEM; From patchwork Wed May 27 09:06:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572355 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 64E5014F6 for ; Wed, 27 May 2020 09:06:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D6B12084C for ; Wed, 27 May 2020 09:06:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="OL7IDv48" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388501AbgE0JGg (ORCPT ); Wed, 27 May 2020 05:06:36 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:2344 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388374AbgE0JGf (ORCPT ); Wed, 27 May 2020 05:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570395; x=1622106395; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=9tGRvt0IuvI8/C5nNy+dhJmMZwVdWn7eK6/c8LNTvps=; b=OL7IDv48FYQtpaZjVwheX4/1auFrkcJwIJJHoLHYygP15OhyY8Z1ubqL T3e/Ar9ivMMUwQTg8G8379Nm85S46H3ZVr62g4mCQsbm5KKygTEqBGl5H e2Tqs2Lqmy/ZqLstAdYbKCF6CuVdA+TC8P2MAuE7AgGrH+PFvfgNYUEwI 2y5BhK2LZcCS9scIg9rvE2SA+bHGQGyRd0XAvUefRbXHeZCI12pnBML8H C1izFPdUzUWx41E8hHpYIy8tXQivUPpyqpI4Mex9zyIBWC6rIgz4Z3gED BAutYkcbGYbV4WlejQXm49njC31hXJDvN0z8o0T9T11ZSCrcNp5Sla40/ g==; IronPort-SDR: IwA80yyJj6oK3zqahw43qnQiPKDiVRgKN76n9pkyvGpjPKCagXFlzvXq2DuOmLk7jp7da1h5UI 9DU//eRFmrWl5LWGl/9DRzLOKKFy3OxEHVvxscX1nh07/JGTvlL3ZlwFfO2ifIm3PrrN7m6ZXG NJjRZfFv48r3K0lIfHC0B4zueFwgivdAtCsixz+5J2+idna6lT7Vh46ATlrO4BkHjLiPx6Nimf ELMwAHivaX9C3rpWe6CoDr1hqjbeCpUF61C+OuH4JR0/8JLsKyXIqVu/GuzXgQ186YXLhhoyMb iVI= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="74590209" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:35 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:28 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:33 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 03/10] staging: most: usb: change return value of function drci_rd_reg Date: Wed, 27 May 2020 11:06:20 +0200 Message-ID: <1590570387-27069-4-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch makes function drci_rd_reg return 0 in case of success and a negative number else. As no caller is evaluating the number of bytes transferred by function usb_control_msg this information is being omitted. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index fd0d885..64005b6 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -153,7 +153,9 @@ static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf) *buf = le16_to_cpu(*dma_buf); kfree(dma_buf); - return retval; + if (retval < 0) + return retval; + return 0; } /** @@ -686,22 +688,22 @@ static void wq_netinfo(struct work_struct *wq_obj) u16 hi, mi, lo, link; u8 hw_addr[6]; - if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_HI, &hi) < 0) { + if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_HI, &hi)) { dev_err(dev, "Vendor request 'hw_addr_hi' failed\n"); return; } - if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_MI, &mi) < 0) { + if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_MI, &mi)) { dev_err(dev, "Vendor request 'hw_addr_mid' failed\n"); return; } - if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_LO, &lo) < 0) { + if (drci_rd_reg(usb_device, DRCI_REG_HW_ADDR_LO, &lo)) { dev_err(dev, "Vendor request 'hw_addr_low' failed\n"); return; } - if (drci_rd_reg(usb_device, DRCI_REG_NI_STATE, &link) < 0) { + if (drci_rd_reg(usb_device, DRCI_REG_NI_STATE, &link)) { dev_err(dev, "Vendor request 'link status' failed\n"); return; } From patchwork Wed May 27 09:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572357 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 379EE14F6 for ; Wed, 27 May 2020 09:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 158182084C for ; Wed, 27 May 2020 09:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="y2cDPEjC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388506AbgE0JGi (ORCPT ); Wed, 27 May 2020 05:06:38 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:1493 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388374AbgE0JGh (ORCPT ); Wed, 27 May 2020 05:06:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570397; x=1622106397; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=lsUcpKtRbtwIVfqJipCwSMyz8FtKI9qpl8FjLw2PMSo=; b=y2cDPEjCS101OJjnpNFo8cdaF/DYHLpKmtgJwMN36HfpLDwuJT/9acfD X+TWQqCJ24WFMOi6LLf9m/nPL6YoFa1T2SvRDerflwXrio3Gi1NDuYFKb evuSnq5vxN7tsSa/1r7nv7c7Yfl9Ljd2Va+AMTBMn25rmxt88zJmBgI9m J0beW2vYAoUU3leKDKIc/OhXzumao0rUs3CX43xB3RFfFj4jW4qMT9eR+ 2rkPlDZaIZISx5zooTlx0mHYJucax1yIyukSnde+e/hnT7L0vlAYXtqHW Y6QtJMOplrmnwXkfRj88mhmjaND/1no9oYRN6js3aAO94LK1NVYqxlJ1k w==; IronPort-SDR: 1j0tLSS/i3BabXnffbGGi6SM6o6z71ACMDogRbKzxjDqWAtCuy3pq/HXFq6eCjcVpCwJTIF7Y/ 47w32dNCL4EcicfFuV5bQcSenV70Wj0LtwnifnVNxMbA5gbqgtN9X9xUsS9VviP94bZGpR5Z4k GJlLy4E7mAjXxN72YX0NG/K7oVPKD3n91KJdM/vtuT2r+7uw3wmGSaSzuTE2YZvtY70PCFKGTs V6ByKCBsRRI4QZI1oOwwGXjqrMQVdmeE6P1eAUbBa0qLeX0QWmaEiXaVH91yUcOtHm6xa/QKE5 KpI= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="77204595" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:37 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:36 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:35 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 04/10] staging: most: usb: return 0 instead of variable Date: Wed, 27 May 2020 11:06:21 +0200 Message-ID: <1590570387-27069-5-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch returns 0 instead of variable in case of invalid parameter has been passed to function to increase readability. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 64005b6..a605e0f 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -192,12 +192,12 @@ static inline int start_sync_ep(struct usb_device *usb_dev, u16 ep) static unsigned int get_stream_frame_size(struct device *dev, struct most_channel_config *cfg) { - unsigned int frame_size = 0; + unsigned int frame_size; unsigned int sub_size = cfg->subbuffer_size; if (!sub_size) { dev_warn(dev, "Misconfig: Subbuffer size zero.\n"); - return frame_size; + return 0; } switch (cfg->data_type) { case MOST_CH_ISOC: From patchwork Wed May 27 09:06:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572359 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFC6990 for ; Wed, 27 May 2020 09:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C0D320890 for ; Wed, 27 May 2020 09:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="MzsCPVTA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388507AbgE0JGi (ORCPT ); Wed, 27 May 2020 05:06:38 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:2344 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388359AbgE0JGi (ORCPT ); Wed, 27 May 2020 05:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570397; x=1622106397; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=qHSHd1bgmgLlhngnky1syAKjrwWciKU5ySfx008erzA=; b=MzsCPVTAWpUNKbYiHQJSdAUskJdE0hVffvGQsVosOMFF5aVnfmO19vN5 Oo75NahKF+Fh2NMF+r1i40f73DfSFqzq7VrxClLoHsYp41yCN29FHU0fG cSj3u9pSgwtuFm9Q2N3QSh4rFL/ekaAX1BLCpAYbFkVcvrqEuPM4Ek10h yU8YZMSIEZ26K7RUrThizmcKXP18Y/ZmNXE7rmLhxHjyyc1Yni299kgEh SAl3PYsMcgbg8fzt4bhqLS6dUwEg0uehB57yDZF6Yx6HLXOLyiDNrXg8q hjONH9jO5eLMll4VQ7mLl0utTjE8o6Ddkt5URUejyIPasgnaaxWIzwgEA g==; IronPort-SDR: yVXOOwX0QQWb8rRcKDqq81HXC+fOA7If8M2vGB4me/1fCAk2fcKBM7xqdYG9bf/f6l0LCjmLDU IpYYUE73swjsfxUQy6bblSRJNlUm26tMc3Zm7xoSPgnccRmPWk4aCwpGyjWDmEq7gXXWddqiNO HBaerpZLhagYDZNM+q2fsvs4T2DDYUfJcy+26JuqI2KlaNERxvpZClD9tqBBWfACSLbTPKpfcr RURCZDDXoSDUUMNk5teHcBmBEom7nAXb2jm2paXo0YM78qGDhpuxL/AexaDA0ZthNVuLA5NfqF yqk= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="74590217" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:37 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:30 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:36 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 05/10] staging: most: usb: move allocation of URB out of critical section Date: Wed, 27 May 2020 11:06:22 +0200 Message-ID: <1590570387-27069-6-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch puts the call to usb_alloc_urb() before the critical section starts that is protected with the io_mutex lock. This is to make the section as short as possible and to use the regular GFP_KERNEL flag. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index a605e0f..534825f 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -467,18 +467,16 @@ static int hdm_enqueue(struct most_interface *iface, int channel, if (iface->num_channels <= channel || channel < 0) return -ECHRNG; + urb = usb_alloc_urb(NO_ISOCHRONOUS_URB, GFP_KERNEL); + if (!urb) + return -ENOMEM; + conf = &mdev->conf[channel]; mutex_lock(&mdev->io_mutex); if (!mdev->usb_device) { retval = -ENODEV; - goto unlock_io_mutex; - } - - urb = usb_alloc_urb(NO_ISOCHRONOUS_URB, GFP_ATOMIC); - if (!urb) { - retval = -ENOMEM; - goto unlock_io_mutex; + goto err_free_urb; } if ((conf->direction & MOST_CH_TX) && mdev->padding_active[channel] && From patchwork Wed May 27 09:06:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572361 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB5BE14F6 for ; Wed, 27 May 2020 09:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA663208E4 for ; Wed, 27 May 2020 09:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="gd7PE5i0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388510AbgE0JGk (ORCPT ); Wed, 27 May 2020 05:06:40 -0400 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:3417 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388359AbgE0JGj (ORCPT ); Wed, 27 May 2020 05:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570399; x=1622106399; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=ECRnde2nGDyoF30q+Dp+0Em2TFoYB54Q32T69glwsBc=; b=gd7PE5i0BA0HEyWAw2hgSNOpdIpHa5m1sQIiNcFhVGVZPuq3tD111i2K 6Qe7Zc5aDi8kMstLAJ9wcZClJCqRt241hNOZSFhBK05VaIcyrMScGbWtc vGoc3KlOR/3WdoIFuOF5S5ZqfQAxZ7IVBpWAKThcxZDcEzWsD1u1i1U2t oynMpyFi5kPIoxYfwt8FoTh9cvoDOGaQ/1swpkOrQwOS/u4oq0cbNWaae QdZlgEAYFV0gbcfaEljI87FxosGNsqVebQnqigT2Qc5e9ck9KikVQ/ihg bYZS4d0LN3x9Orhl0BUkpY9n6kWHcrWKJ/WhbPVsUGN0l41KxRLglWt31 w==; IronPort-SDR: mtQHI88dzA2lmLkJL8wujurL9HgaWyXvXOPk0ZNSDo1cL9ut6l3hApizLO2FYbf6tgpqYbLbch 6y++L7WeWglQU2L2MO5DpfROhjsaCIicMnuy4beIqBsFWd7aZgTuHwKri7I+2GUDcRyLKG4OeV BVekcrh/iXUlshR/ErP5tS5rGug7bCQVu74KUEPME33z5rWuQrPRzS9sqCMM7cqeNR3eHW9zET vmn7/aXmLLZWg8yPMloEp7BTczhRdQDMZpg3PNV6lGX/7QN5l/hQUPJP2CBWrgniGB9uuQOG+4 lHE= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="77955214" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:39 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:38 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:37 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 06/10] staging: most: usb: don't use error path to exit function on success Date: Wed, 27 May 2020 11:06:23 +0200 Message-ID: <1590570387-27069-7-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch makes it transparent whether the function is exiting with an error or successful. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 534825f..03318de 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -519,13 +519,13 @@ static int hdm_enqueue(struct most_interface *iface, int channel, "URB submit failed with error %d.\n", retval); goto err_unanchor_urb; } - goto unlock_io_mutex; + mutex_unlock(&mdev->io_mutex); + return 0; err_unanchor_urb: usb_unanchor_urb(urb); err_free_urb: usb_free_urb(urb); -unlock_io_mutex: mutex_unlock(&mdev->io_mutex); return retval; } From patchwork Wed May 27 09:06:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572363 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 89CE5166C for ; Wed, 27 May 2020 09:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 720BF208E4 for ; Wed, 27 May 2020 09:06:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="yopHUqx4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388421AbgE0JGl (ORCPT ); Wed, 27 May 2020 05:06:41 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:2344 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388508AbgE0JGk (ORCPT ); Wed, 27 May 2020 05:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570400; x=1622106400; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Ubu5DjfeMwuoDfB7rELb/kow3WmwDtRNqlTYJOZEPRo=; b=yopHUqx45jlkPzQp4aCC/9CM5JITyXoa5/xukd7uTGIUX1X2NHUSltXk XjgkBUczyv3Yx758clSnD27AbN779+A8jxk5R9+KHK8NlpdIcmaiOOPff 5z6Th0tyRnZnB0Ir/P3CPtUqaMcZeVP1E21z1OqPnGx6BNw/FPHzl5vxK Ls+CmMwkrpmPcUtgPbmFQTlY0EsguS3o6SQlsoErEn5A95/ppMQWbxxzs CofKpXwajbn8uNrthtVawpyL8UvDkpiOU8lShdWD1hsbnErs2JXqMgXFq vHg97Ene4/J8ONl9nO5lRpi4l4Kr0TGCh2PzhyuqD1lfAPo2XQWF951w5 g==; IronPort-SDR: 4sKuQhn51/IgvXLOji8+H0LK7IdpJXbTWXQtLD5a4dR6FVsPXy+jcVbgnC2zz4Z0+QPyorwzT/ bs4tSMtDrXYrbvnigLY8fagOIrrjD2QOdXteTWr/zhb7kLXDw8MErCNW1zp39vDUmEq/+0xmVj PMN0EGVZmAIf2z87PuHhYhkw831AAkyD85Q2Ivin32AdcMxfMYFDP1P5FDrTmg8VNc3dFX++Jj 8fnCLYW44zwAteYwTbvORlVeZr7soX0XiTx8YSUNF7HKV6qQ3fcLQ96RyqrruJ9gHMszZACabp fYA= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="74590227" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:40 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:33 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:38 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 07/10] staging: most: usb: replace code to calculate array index Date: Wed, 27 May 2020 11:06:24 +0200 Message-ID: <1590570387-27069-8-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch removes the expression that makes use of a priori knowledge about channel numbers to calculate an array index. The expression 'peer = 1 - channel' utilizes the fact that an USB interface that operates on the asynchronous data of the Network only has two endpoints. Hence, channel being 0 or 1. The replacement is more simple and less confusing when reading the code. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 03318de..468aabf 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -729,6 +729,8 @@ static void wq_clear_halt(struct work_struct *wq_obj) struct most_dev *mdev = clear_work->mdev; unsigned int channel = clear_work->channel; int pipe = clear_work->pipe; + int snd_pipe; + int peer; mutex_lock(&mdev->io_mutex); most_stop_enqueue(&mdev->iface, channel); @@ -746,9 +748,12 @@ static void wq_clear_halt(struct work_struct *wq_obj) */ if (mdev->conf[channel].data_type == MOST_CH_ASYNC && mdev->conf[channel].direction == MOST_CH_RX) { - int peer = 1 - channel; - int snd_pipe = usb_sndbulkpipe(mdev->usb_device, - mdev->ep_address[peer]); + if (channel == 0) + peer = 1; + else + peer = 0; + snd_pipe = usb_sndbulkpipe(mdev->usb_device, + mdev->ep_address[peer]); usb_clear_halt(mdev->usb_device, snd_pipe); } mdev->is_channel_healthy[channel] = true; From patchwork Wed May 27 09:06:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572365 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF81F14F6 for ; Wed, 27 May 2020 09:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE40720890 for ; Wed, 27 May 2020 09:06:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="rB8gazjg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388512AbgE0JGm (ORCPT ); Wed, 27 May 2020 05:06:42 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:2344 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388508AbgE0JGm (ORCPT ); Wed, 27 May 2020 05:06:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570401; x=1622106401; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=DOpb3K0aIjX1Jxk/hBoXZvrpF80ZSQ9sxNZGXH4xfe8=; b=rB8gazjg/TaP51dYd3+GDZfYcQWk5JqykCLWnmm3wmBLR/N11vQCE7kE T6E8gubU4Efa+uvlg2smi1pMnOKhNk90EQtbsGApYX51hU3Mr5l5Rw4GT eC+ayik4WUWszcMy2xRtzdjPH3nYvH0z0zNaIok1zW35+hJHiKGjelpPi zMxyTc24qwx+QrkzwpC0BVZCsrKpvOIxQpgpkYRzFeRoi9x3L/sbHQrso swq2A3CWiCmG4IfCOJ1mLLSW4DlXXsByiejp5yEfCvv2OPDG4jzH5Ze+J 6k3mPGL24Fh4nfj7Yb1vJ2Bpx4Z8P7hV8F88Ui5tRPazxy2DfKCk73a7S g==; IronPort-SDR: 83eZVGeqgznz8y55BfM+32M3oGIH+gDGjXDMTW8VwEiiq6G/0eIQX+rCaVScW70ceN/6YUELn9 eJikdtuRfVYX8kEW4+qP/53LA7tY2oWCJn5bgs691W0qlKfY7GQnQphQUOCFAMVluQ3vRJd3N7 urg+JQJX8R2QMnTpExlqTUPlTpzMmZUmpYAz40NyN52yLDihDIfoHdUzdDFNkIG2VW1BgmFm0K 1HUTftr5C2YWxkN+fE9h8PtPnhyLNF73vr5mHyfZry4qXTrKAEjIZ+5zLnXdgaaNNpg8MagM09 dG0= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="74590234" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:41 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:34 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:40 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 08/10] staging: most: usb: use correct error codes Date: Wed, 27 May 2020 11:06:25 +0200 Message-ID: <1590570387-27069-9-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch uses the -EINVAL return code where -EFAULT is wrongly being used. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 468aabf..3575a40 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -813,7 +813,7 @@ static int get_stat_reg_addr(const struct regs *regs, int size, return 0; } } - return -EFAULT; + return -EINVAL; } #define get_static_reg_addr(regs, name, reg_addr) \ @@ -835,7 +835,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, reg_addr = dci_obj->reg_addr; else if (get_static_reg_addr(ro_regs, name, ®_addr) && get_static_reg_addr(rw_regs, name, ®_addr)) - return -EFAULT; + return -EINVAL; err = drci_rd_reg(dci_obj->usb_device, reg_addr, &val); if (err < 0) @@ -870,7 +870,7 @@ static ssize_t value_store(struct device *dev, struct device_attribute *attr, else if (!get_static_reg_addr(rw_regs, name, ®_addr)) err = drci_wr_reg(usb_dev, reg_addr, val); else - return -EFAULT; + return -EINVAL; if (err < 0) return err; From patchwork Wed May 27 09:06:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572367 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 071BD159A for ; Wed, 27 May 2020 09:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA2452084C for ; Wed, 27 May 2020 09:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="o7dc6UZH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388514AbgE0JGo (ORCPT ); Wed, 27 May 2020 05:06:44 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:2344 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388513AbgE0JGn (ORCPT ); Wed, 27 May 2020 05:06:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570403; x=1622106403; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Veetgosw/XgbnoNh0z9adVvVyUO6uS1tR9xrwVrKhTE=; b=o7dc6UZH9UonIbpXJkvp1cREEXWlkP2AalfFb7zp4yYruCX/mueTO9+4 MltqHkcqQ7dI3SaD2ezqKWyF9MK5xw3ZYX2Ms5/jB2CjY3VPSXSgJhv+9 ljxX6RMtpL6pshooxzJ8qS7LYxFA9EB6UUPFxg5LVJtr9hO0kqZaIVJx7 ygERTNeXUSQ+12wgfDH0CCvRE/Rj2NgysSdxGCFzcJAH4Vx+3ps+Osb4f FjDHos1jqVGAa8uBDAK8mypnZv2TolXjd4pgTeDuicCWxDfpOupK1JBSO xdU7QNqkkmWhnach2Vkj22X1JK2vcTxt8KKKhE6c890oBtIUzR4KIMH7+ Q==; IronPort-SDR: xwkJRzbbz4quINAHcRsOYANRojvjjVysM9bzqiJXm7k8Mi6ifRXlnLeRUuZ1bFzoapAF8PO7Mm Njsu5yy5LqztwK4K5Mj9wPCb+DK0DJ43YRHLOHKSYwgxBNymY2i3+nl4drAijguyTktRySDSXJ bE2gjhVbe2RV3vC2GbpxgYpuO62UXdbWKM3IGC9ztiXkHQ5gQhEYUIkCjew1NAIugr426Jc5lR Nn7intZulFqzI9x/jP18T9bbl+PaBj/dP1TvNE9s3Xa5V02XAg3h7GqJu72IaQUpprpt7IK1cU e7w= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="74590239" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:42 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:35 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:41 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 09/10] staging: most: usb: add missing put_device calls Date: Wed, 27 May 2020 11:06:26 +0200 Message-ID: <1590570387-27069-10-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch adds the missing put_device() function calls to properly free allocated resources and maintain reference counts. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 3575a40..1c4bdb8 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -919,6 +919,7 @@ static void release_dci(struct device *dev) { struct most_dci_obj *dci = to_dci_obj(dev); + put_device(dev->parent); kfree(dci); } @@ -1123,6 +1124,7 @@ static void hdm_disconnect(struct usb_interface *interface) kfree(mdev->cap); kfree(mdev->conf); kfree(mdev->ep_address); + put_device(&mdev->dci->dev); put_device(&mdev->dev); } From patchwork Wed May 27 09:06:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Gromm X-Patchwork-Id: 11572369 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B983F1752 for ; Wed, 27 May 2020 09:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A250720890 for ; Wed, 27 May 2020 09:06:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="fjPcjxOx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388516AbgE0JGp (ORCPT ); Wed, 27 May 2020 05:06:45 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:1514 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388513AbgE0JGo (ORCPT ); Wed, 27 May 2020 05:06:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1590570404; x=1622106404; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=YT1p2jkhQjEOh+Toh8EnfM+hDVS9WGd+MEUj6fk8RGk=; b=fjPcjxOxYx1FUsfWj/Gp1g//FTt6Y1w9F7Xhr5zaN1CnXPzAqkkOYbJx QHmcaskLYWcmJAGO3EZnD2e5fB+fOlSmiQnT5lEFRXhyX7cooeDh77zes c6HlvOdbx6egLaMWetH4aOlVERwKK7tX7CXTgoqIZKojZ7dx1FxRqDYcA HNq3tPtIAzpJIEjtdR18CrVnWjxxa91KXbCnE+CfbYk/UAMLn45frqHTJ kYQum0jrHoR0MW43+CSLOFWtri95u0J4/egvud2r4KSgaPQNEHoapyeLs beQJnlx+11wtp75p72uf7MDiu32kcAm+V9gKWefoQSsbH03Wx2FFnv+3x A==; IronPort-SDR: 1GoF4Q1UpYguWjtUqN+Lvi3TYgQf7dU2/KSUKFlEKneT6u6gclI+2jdMS4N7h4nVSjFdF1Vuje mO5el0pc51INc/7y+5WLGyXkfZtGFOQg3o0RPZKXiKHElRuD+l5OK0fJXf5T+2/6GD2gEGbFB6 4ccrlF0uPzgJOXtCpJNINwY4BihGikXeg73ChEcC6n4DpyDfCCjt+2ZbX56Kr7K27Y1SeMxIQh AiVCQHcaRH/Mug4yiXSN7VZ4VKaQ1qd27VLH66XeiXrrs+dZBeYVpXmiSfjNyDjIj1Lrp+iA+L tg0= X-IronPort-AV: E=Sophos;i="5.73,440,1583218800"; d="scan'208";a="77204630" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 May 2020 02:06:44 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 27 May 2020 02:06:43 -0700 Received: from localhost.localdomain (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Wed, 27 May 2020 02:06:42 -0700 From: Christian Gromm To: CC: , , Christian Gromm Subject: [PATCH 10/10] staging: most: usb: use function sysfs_streq Date: Wed, 27 May 2020 11:06:27 +0200 Message-ID: <1590570387-27069-11-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> References: <1590570387-27069-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch replaces function strcmp() with sysfs_streq() to compare strings provided via sysfs. Signed-off-by: Christian Gromm Reported-by: Dan Carpenter --- drivers/staging/most/usb/usb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c index 1c4bdb8..df5876c 100644 --- a/drivers/staging/most/usb/usb.c +++ b/drivers/staging/most/usb/usb.c @@ -808,7 +808,7 @@ static int get_stat_reg_addr(const struct regs *regs, int size, int i; for (i = 0; i < size; i++) { - if (!strcmp(name, regs[i].name)) { + if (sysfs_streq(name, regs[i].name)) { *reg_addr = regs[i].reg; return 0; } @@ -828,10 +828,10 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, u16 reg_addr; int err; - if (!strcmp(name, "arb_address")) + if (sysfs_streq(name, "arb_address")) return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr); - if (!strcmp(name, "arb_value")) + if (sysfs_streq(name, "arb_value")) reg_addr = dci_obj->reg_addr; else if (get_static_reg_addr(ro_regs, name, ®_addr) && get_static_reg_addr(rw_regs, name, ®_addr)) @@ -858,14 +858,14 @@ static ssize_t value_store(struct device *dev, struct device_attribute *attr, if (err) return err; - if (!strcmp(name, "arb_address")) { + if (sysfs_streq(name, "arb_address")) { dci_obj->reg_addr = val; return count; } - if (!strcmp(name, "arb_value")) + if (sysfs_streq(name, "arb_value")) err = drci_wr_reg(usb_dev, dci_obj->reg_addr, val); - else if (!strcmp(name, "sync_ep")) + else if (sysfs_streq(name, "sync_ep")) err = start_sync_ep(usb_dev, val); else if (!get_static_reg_addr(rw_regs, name, ®_addr)) err = drci_wr_reg(usb_dev, reg_addr, val);