From patchwork Wed May 27 22:13:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11573997 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D7BEF912 for ; Wed, 27 May 2020 22:13:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) id D2490207D8; Wed, 27 May 2020 22:13:40 +0000 (UTC) Delivered-To: soc@kernel.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D5AE2065F; Wed, 27 May 2020 22:13:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D5AE2065F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=arnd@arndb.de Received: from threadripper.lan ([149.172.98.151]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPA (Nemesis) id 1MZTa2-1jXvWm2V4I-00WYLm; Thu, 28 May 2020 00:13:30 +0200 From: Arnd Bergmann List-Id: To: soc@kernel.org, Thierry Reding , Jonathan Hunter , Sowjanya Komatineni Cc: Arnd Bergmann , Thierry Reding , Dmitry Osipenko , Hans Verkuil , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: tegra-video: fix V4L2 dependency Date: Thu, 28 May 2020 00:13:06 +0200 Message-Id: <20200527221327.3339232-1-arnd@arndb.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:OkSCNXrxgq+QBC6VZibXnhg/MVMqw5QZ+B8NVtwOjOHdh8pK7KV oNEVVM4Oeri88gdj7u5OW8bijKaO6HHtbsrhzkmFFZmCUhd2m7Gd2ygmRgvRxVfHB/smmNN 55R6GIMNzhZJYM3/igbihA7ZqXkAXDHxi8VVZpihLDblQ/StiZ+Y5GsvkNU2A8W3qVFeKqQ SaiD+hsn+mHITvEqJXKkw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8tSYDyvKwCo=:LVwvEWqO4zqtVa9oCHOyUR uNwRBjTb9L3mYUmVSjV7rIcFNmq+cDjGRFIlFNf9fwOnPvFfN/qYDMWpeILTUwBDiyoTcd7I6 OtReLlFW8QOdfRy16htFKM/nXzZbMpbAMJFPvcwSreaTx/ZerqczDQHOU6iMPsOf3E3mgblF5 hkfVSufRgbmScDBbPkPJRrdqEFfXab87hi226bAgMn0kAA+nFWszlvJIoUReNd223KDhHgPxS VIuo2Q2cLy6IGrflYwLwvwC+hFtKNSEuO7qGE+n7ZgVw1n919QXDKFkd/oDzRs/apKdPmEkoh gnMGAk/MxlU23oXo08ekP4butF4UORCC7O0P/nTtFohSgb8EEe2Tp4OLC18uYXoj+R6zHpLX8 1/OA+BmFG8Lr7A5mwILNGm0FyyZ7CJr24xTwSlp7YM9gaWcr8DNFgftm9aFNYsuJCL2CLPQok g14eEiZEdb9YaRHtoJ0IhC9PbBrlue8IMbCSdgDAdFx80qg4wQji/lxBXDJii0+suFdWHahhl NRkqnAk7b6W5aKtXfd0CZoOWvegIVTl3WF13HIfkfyMg+io7U6igWGsCMJMXVrAaLXLl6QrDe cUL12Yat+ighNEMELCAiMZ1C7Dkj6x0+QmOu0bAwjry1MGcg1LfwqbS3E+oCK6m3hsWtakD+n rMkIGhi4Gt2of6tqBkzr0tuWqWTesMJqo0RrKXCkr5azyx23Qf3emsGUy90QePxLMPbRXyqvC XQ5tF84oR+SW97FBEQcbkFyWmLw/b6Y9rxvOB6Mohz4lStJqlTPtaiySH3ISw/thz+HCRnlGT 9oJOh0yhDvRSfbkS231duc4zUWmAhFWvkEkPc1FpjEQKFo6cWU= Rather than using a dependency on VIDEO_V4L2, this driver uses "select", which fails when other dependencies are missing: WARNING: unmet direct dependencies detected for VIDEO_V4L2 Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n] Selected by [y]: - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y] (plus an endless stream of link errors for other drivers that depend on VIDEO_V4L2 but are now lacking their dependencies) Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver") Signed-off-by: Arnd Bergmann Acked-by: Sowjanya Komatineni --- drivers/staging/media/tegra-video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig index 3f03b5b39e6c..f6c61ec74386 100644 --- a/drivers/staging/media/tegra-video/Kconfig +++ b/drivers/staging/media/tegra-video/Kconfig @@ -2,7 +2,7 @@ config VIDEO_TEGRA tristate "NVIDIA Tegra VI driver" depends on TEGRA_HOST1X - select VIDEO_V4L2 + depends on VIDEO_V4L2 select MEDIA_CONTROLLER select VIDEOBUF2_DMA_CONTIG help