From patchwork Fri May 29 21:48:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11579661 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7C00990 for ; Fri, 29 May 2020 21:51:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 574DB20707 for ; Fri, 29 May 2020 21:51:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YfwIN1N1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 574DB20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 190486E97B; Fri, 29 May 2020 21:51:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA4496E97B for ; Fri, 29 May 2020 21:51:21 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id x6so5508561wrm.13 for ; Fri, 29 May 2020 14:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SWejylb+djpwIa2N9XUbD+uH2HLcKZnhtSJoefcCpEA=; b=YfwIN1N1HKXAiRpB5zUDK6/WFR3AIY1bQgcw7GwuBUuSnLWc2qbSE2gludDvSxS5nL TZf3giCdm67jZt/G1Zz5Tk6J13kQ2dyyBRgJMIMSfaoLrInjVkcly07iraYqVejGtPjS Y8Ls/IAcoSPxMdVbBS1217Yz7SRsZ9hmDS0pmQgoiAdwOdnxmtVWnP2H/LC4yMoNcses 0bCxNGtZIPEKdN1TbwGqjdEbCP8udTiSD2DpZL4nhZ9O8AB0MhJwc+UEKR9+GF88qa7C LLcKjdb1kzx9Tz97unz4I1hMIcbGNjHGTot6M6DEasI6XABy/EHyvdL60ofhqz3X27j2 F+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SWejylb+djpwIa2N9XUbD+uH2HLcKZnhtSJoefcCpEA=; b=Ybv7PpFYJOFXO41y+rW3x9ZjVNVvw77ieI2bRRGS/qY8nAxyh/TffhdlMWActY/6Ls v3L/9OWUH7FWL4Yh/oDm5jmB2Adk2dO9c04Tt7AcRq7t5Tt8j41DWtpwtKkgLFfR6QY2 xcpMrk2+RMESehCRw1IeCkSh7UOoggOJKiRUFpyAFV9pUch5F07LRbhizwT5SIOcEM98 KT2o02rKnW+aQoXGBX0VNa29vzFwpMUQMp+Y+mTx6rP4PiWt0lJcZLXtipPMKJxYbrzC bWI5rkfPDYi3P0BREpDJNZa3c5bWCkNvvTMNqGL4WQ+zlfrLMR7PTrmqfpJwedVsK/j/ SiGg== X-Gm-Message-State: AOAM530cXE7gq7NE1/s8L7i+BjhR+e+8KpZ1yOH9/ZFCJqpqpRLyLmxZ dcBypGwxXoKps9z3lU6h1p3Q+mOw X-Google-Smtp-Source: ABdhPJw/qxZoUvUVekaSihkNQw+IHXkPjHdGLBmjrBu4ZbUNKC/Njr8V3GrxxuSeh5Mf6um/ZLdnbw== X-Received: by 2002:adf:f582:: with SMTP id f2mr11396456wro.204.1590789080009; Fri, 29 May 2020 14:51:20 -0700 (PDT) Received: from localhost.localdomain (cpc91192-cmbg18-2-0-cust374.5-4.cable.virginm.net. [80.6.113.119]) by smtp.gmail.com with ESMTPSA id 23sm1140660wmo.18.2020.05.29.14.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 14:51:19 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm: vmwgfx: remove drm_driver::master_set() return typ Date: Fri, 29 May 2020 22:48:06 +0100 Message-Id: <20200529214807.3801851-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , VMware Graphics , Roland Scheidegger , emil.l.velikov@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function always returns zero (success). Ideally we'll remove it all together - although that's requires a little more work. For now, we can drop the return type and simplify the drm core code surrounding it. Cc: David Airlie Cc: Daniel Vetter Cc: VMware Graphics Cc: Roland Scheidegger Signed-off-by: Emil Velikov Reviewed-by: Sam Ravnborg --- VMWare team, I'm planning to push this via drm-misc. Review, ack and comments are appreciated. --- drivers/gpu/drm/drm_auth.c | 33 +++++++---------------------- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 8 +++---- include/drm/drm_drv.h | 4 ++-- 3 files changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c index 800ac39f3213..db701a9e9393 100644 --- a/drivers/gpu/drm/drm_auth.c +++ b/drivers/gpu/drm/drm_auth.c @@ -122,27 +122,19 @@ struct drm_master *drm_master_create(struct drm_device *dev) return master; } -static int drm_set_master(struct drm_device *dev, struct drm_file *fpriv, - bool new_master) +static void drm_set_master(struct drm_device *dev, struct drm_file *fpriv, + bool new_master) { - int ret = 0; - dev->master = drm_master_get(fpriv->master); - if (dev->driver->master_set) { - ret = dev->driver->master_set(dev, fpriv, new_master); - if (unlikely(ret != 0)) { - drm_master_put(&dev->master); - } - } + if (dev->driver->master_set) + dev->driver->master_set(dev, fpriv, new_master); - fpriv->was_master = (ret == 0); - return ret; + fpriv->was_master = true; } static int drm_new_set_master(struct drm_device *dev, struct drm_file *fpriv) { struct drm_master *old_master; - int ret; lockdep_assert_held_once(&dev->master_mutex); @@ -157,22 +149,12 @@ static int drm_new_set_master(struct drm_device *dev, struct drm_file *fpriv) fpriv->is_master = 1; fpriv->authenticated = 1; - ret = drm_set_master(dev, fpriv, true); - if (ret) - goto out_err; + drm_set_master(dev, fpriv, true); if (old_master) drm_master_put(&old_master); return 0; - -out_err: - /* drop references and restore old master on failure */ - drm_master_put(&fpriv->master); - fpriv->master = old_master; - fpriv->is_master = 0; - - return ret; } /* @@ -265,7 +247,8 @@ int drm_setmaster_ioctl(struct drm_device *dev, void *data, goto out_unlock; } - ret = drm_set_master(dev, file_priv, false); + ret = 0; + drm_set_master(dev, file_priv, false); out_unlock: mutex_unlock(&dev->master_mutex); return ret; diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index c2247a893ed4..470428387878 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -1129,9 +1129,9 @@ static long vmw_compat_ioctl(struct file *filp, unsigned int cmd, } #endif -static int vmw_master_set(struct drm_device *dev, - struct drm_file *file_priv, - bool from_open) +static void vmw_master_set(struct drm_device *dev, + struct drm_file *file_priv, + bool from_open) { /* * Inform a new master that the layout may have changed while @@ -1139,8 +1139,6 @@ static int vmw_master_set(struct drm_device *dev, */ if (!from_open) drm_sysfs_hotplug_event(dev); - - return 0; } static void vmw_master_drop(struct drm_device *dev, diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index bb924cddc09c..835c38a76ef6 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@ -311,8 +311,8 @@ struct drm_driver { * * Called whenever the minor master is set. Only used by vmwgfx. */ - int (*master_set)(struct drm_device *dev, struct drm_file *file_priv, - bool from_open); + void (*master_set)(struct drm_device *dev, struct drm_file *file_priv, + bool from_open); /** * @master_drop: * From patchwork Fri May 29 21:48:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 11579663 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4485739 for ; Fri, 29 May 2020 21:51:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FFDD20707 for ; Fri, 29 May 2020 21:51:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oEyd4AL6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FFDD20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E77F6E97C; Fri, 29 May 2020 21:51:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BD0C6E97B for ; Fri, 29 May 2020 21:51:22 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id u13so5278951wml.1 for ; Fri, 29 May 2020 14:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=65TKF+831LzNuvirKgQgWrdtRHSJrk79ygPwawVMie4=; b=oEyd4AL60jWocSyUts+CwF7h7ayHfmfvWklUcqZVhhoxm8b8SuCZJVnjCP5uuMStlh fIaW1jREa8WhWYyOQKdiaPK5Z1ElBgD3wHpx44ee2aLb8ZvslFweRDGA/BlOsI03/QfC A2brc18y9amqzzxZv/Mc96WHGuvtPHkPSErlTBfwbAhqe7a3nklHStbjdfBwtYKtJDu5 e5mFjOswf2tYSdnYDD+yZxrfHrhDBCEbwsIZCuqwuzOdX9x2iQ4Qeg4ALRDVl9cz6mWC 6bEXGCySiHAcITnCOp31x2+bpYqcSKOTSI7p0ehe9bvowJDbNioT+XQ7Q2ZoPb74ZeTk PLgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=65TKF+831LzNuvirKgQgWrdtRHSJrk79ygPwawVMie4=; b=BuIRkPNNn8z1ZKR4rhsfNwE7+jukO04B4WsgCaOWyIMRf2pGW9JkQp5YdpYIgdq1zM v96I/QCfS6uM57gwtbO74ePeH8aMtr+5t/jwpOaDmT9MR3rptSH2Mb4HxFjimP7UGLyj NXLcWSU2j9QrLxk9mJPqMhsKLqptLHs4lg0mGl9/hONZ6f3Nu9wco8fxLQZOMfmZWWs+ er0iV7kbzOjYOQEAlNRMTEzpg5lBTW037PIur2ZQAoiZsC/lgN41adnAGUiRH/Ju2Lk1 sPumGzxq5R9pLFI5/s5f8ytcABtTQsKiWKT5OQwFnb2f+EMXMs/5TbPk573J1uUiQ75m PiqQ== X-Gm-Message-State: AOAM5327vht1CXxykPjM4A1jc+28ZvVEHUAQUnQ57e0z/0cWduk06HNC +Slcgm2b2Iy/nOmGAAPewxN6tUk2 X-Google-Smtp-Source: ABdhPJxUK0eJLcz/n08spSqTI+tkDUly+tcktPJEF8NdSYj7qvJXOwK+UD+eD+OvoJTJ3HSkMu1qXw== X-Received: by 2002:a1c:a906:: with SMTP id s6mr10895783wme.171.1590789080907; Fri, 29 May 2020 14:51:20 -0700 (PDT) Received: from localhost.localdomain (cpc91192-cmbg18-2-0-cust374.5-4.cable.virginm.net. [80.6.113.119]) by smtp.gmail.com with ESMTPSA id 23sm1140660wmo.18.2020.05.29.14.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 14:51:20 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/auth: drop unnessesary variable assignments Date: Fri, 29 May 2020 22:48:07 +0100 Message-Id: <20200529214807.3801851-2-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200529214807.3801851-1-emil.l.velikov@gmail.com> References: <20200529214807.3801851-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , emil.l.velikov@gmail.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The variables are already the exact same value or will be overwritten shortly afterwords. In either case there's no functional difference. Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Emil Velikov --- drivers/gpu/drm/drm_auth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c index db701a9e9393..5ae5623f2482 100644 --- a/drivers/gpu/drm/drm_auth.c +++ b/drivers/gpu/drm/drm_auth.c @@ -215,7 +215,7 @@ drm_master_check_perm(struct drm_device *dev, struct drm_file *file_priv) int drm_setmaster_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { - int ret = 0; + int ret; mutex_lock(&dev->master_mutex); @@ -282,7 +282,6 @@ int drm_dropmaster_ioctl(struct drm_device *dev, void *data, if (file_priv->master->lessor != NULL) { DRM_DEBUG_LEASE("Attempt to drop lessee %d as master\n", file_priv->master->lessee_id); - ret = -EINVAL; goto out_unlock; }