From patchwork Fri Jun 5 04:28:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 11588975 X-Patchwork-Delegate: marcel@holtmann.org Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EB8D0138C for ; Fri, 5 Jun 2020 04:28:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0ABB207D5 for ; Fri, 5 Jun 2020 04:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GglctBBj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgFEE27 (ORCPT ); Fri, 5 Jun 2020 00:28:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgFEE26 (ORCPT ); Fri, 5 Jun 2020 00:28:58 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A91FFC08C5C0 for ; Thu, 4 Jun 2020 21:28:58 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id m2so2193640pjv.2 for ; Thu, 04 Jun 2020 21:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iR4VqTS2EXdW82BaNRGhQ3j0kiUhB8MOVYBA8SqjWtM=; b=GglctBBjQUAAk/bc1+7mPFWpkcziV5Aq2oYrhkBd0Q3yOtOzkvGxsJzgyC5XqmNwx3 Y7nZYBsY3ko21cxMFnLpWj4lWmPERhVu5u3atotCjgUkgYpEr6AE3M0DQQbMLBPeN80f EVhK/VGaOjXsdpaDCCUD3qgR2W/NsZu20jcdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iR4VqTS2EXdW82BaNRGhQ3j0kiUhB8MOVYBA8SqjWtM=; b=Lmugsu3W5d5AOsRxzbfB2FjfDnlO6oYq5f7wsl0RUOKBshuMuIsHamzalD1w42RMPQ BOczNI69AhPw+BestmNPi9s4qEpCMsHKvnk4aWZm26OxsXs22aDA/ZSz3ySjJKQWxQsl pPWlrGU4jeiK13fbecIVaMiyqyvDpIKPsc9KDZ3Lj4yYRHfJ/d0XD9ADvYkOpbahlyVE qTGGGmfC+FI4EtWeLgc45jm4IDNZ/pwfnDpIliIPRMdcVLGpXo++cEf0xvbYXWpJZoIt 6Wu8QTXGdfwPqQWePe1S2f1iZAAVy2m8g1FHKlsDt2KBeuexS/y+3xVMjoLxOekmxdKH +0YQ== X-Gm-Message-State: AOAM532Ayia1qZJLDxqH3DVsxoXoBDt1HNsNCx6MTCA2y7aItjhcjuDo Y53L3xEiLrgLny5f+YJ7twRq5Q== X-Google-Smtp-Source: ABdhPJx1VMDcMi0/N7mvHzWvVFSJxRkPEio6Bfmea2ChvhgLtvq0jgqSVywNQc2r0Mrblr3i0vyIjA== X-Received: by 2002:a17:90a:cf17:: with SMTP id h23mr816932pju.139.1591331338098; Thu, 04 Jun 2020 21:28:58 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id z20sm6793906pjn.53.2020.06.04.21.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 21:28:57 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org Cc: len.brown@intel.com, chromeos-bluetooth-upstreaming@chromium.org, linux-pm@vger.kernel.org, rafael@kernel.org, todd.e.brandt@linux.intel.com, rui.zhang@intel.com, Abhishek Pandit-Subedi , "David S. Miller" , Johan Hedberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: [PATCH v2] Bluetooth: Allow suspend even when preparation has failed Date: Thu, 4 Jun 2020 21:28:50 -0700 Message-Id: <20200604212842.v2.1.I0ec31d716619532fc007eac081e827a204ba03de@changeid> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org It is preferable to allow suspend even when Bluetooth has problems preparing for sleep. When Bluetooth fails to finish preparing for suspend, log the error and allow the suspend notifier to continue instead. To also make it clearer why suspend failed, change bt_dev_dbg to bt_dev_err when handling the suspend timeout. Fixes: dd522a7429b07e ("Bluetooth: Handle LE devices during suspend") Reported-by: Len Brown Signed-off-by: Abhishek Pandit-Subedi --- To verify this is properly working, I added an additional change to hci_suspend_wait_event to always return -16. This validates that suspend continues even when an error has occurred during the suspend preparation. Example on Chromebook: [ 55.834524] PM: Syncing filesystems ... done. [ 55.841930] PM: Preparing system for sleep (s2idle) [ 55.940492] Bluetooth: hci_core.c:hci_suspend_notifier() hci0: Suspend notifier action (3) failed: -16 [ 55.940497] Freezing user space processes ... (elapsed 0.001 seconds) done. [ 55.941692] OOM killer disabled. [ 55.941693] Freezing remaining freezable tasks ... (elapsed 0.000 seconds) done. [ 55.942632] PM: Suspending system (s2idle) I ran this through a suspend_stress_test in the following scenarios: * Peer classic device connected: 50+ suspends * No devices connected: 100 suspends * With the above test case returning -EBUSY: 50 suspends I also ran this through our automated testing for suspend and wake on BT from suspend continues to work. Changes in v2: - Added fixes and reported-by tags net/bluetooth/hci_core.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index dbe2d79f233fba..54da48441423e0 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -3289,10 +3289,10 @@ static int hci_suspend_wait_event(struct hci_dev *hdev) WAKE_COND, SUSPEND_NOTIFIER_TIMEOUT); if (ret == 0) { - bt_dev_dbg(hdev, "Timed out waiting for suspend"); + bt_dev_err(hdev, "Timed out waiting for suspend events"); for (i = 0; i < __SUSPEND_NUM_TASKS; ++i) { if (test_bit(i, hdev->suspend_tasks)) - bt_dev_dbg(hdev, "Bit %d is set", i); + bt_dev_err(hdev, "Suspend timeout bit: %d", i); clear_bit(i, hdev->suspend_tasks); } @@ -3360,12 +3360,15 @@ static int hci_suspend_notifier(struct notifier_block *nb, unsigned long action, ret = hci_change_suspend_state(hdev, BT_RUNNING); } - /* If suspend failed, restore it to running */ - if (ret && action == PM_SUSPEND_PREPARE) - hci_change_suspend_state(hdev, BT_RUNNING); - done: - return ret ? notifier_from_errno(-EBUSY) : NOTIFY_STOP; + /* We always allow suspend even if suspend preparation failed and + * attempt to recover in resume. + */ + if (ret) + bt_dev_err(hdev, "Suspend notifier action (%x) failed: %d", + action, ret); + + return NOTIFY_STOP; } /* Alloc HCI device */