From patchwork Mon Jun 8 17:48:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11593763 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7185790 for ; Mon, 8 Jun 2020 17:49:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EF2C20774 for ; Mon, 8 Jun 2020 17:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="W4Z+8xah" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EF2C20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D46A6E1B2; Mon, 8 Jun 2020 17:48:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by gabe.freedesktop.org (Postfix) with ESMTPS id 104C06E198 for ; Mon, 8 Jun 2020 17:48:57 +0000 (UTC) Received: by mail-pj1-x1043.google.com with SMTP id m2so148141pjv.2 for ; Mon, 08 Jun 2020 10:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dYz+Xl/FEuDPplFOt9XJcftofUYzSfEPkgENfM7upRY=; b=W4Z+8xahUegQR5m34xKJyXKb95xGcM4nDB/HcR8qyKD7HD1yTyy8nTggMScCzWXhRR yNF5f0v2m1kwdsvoEs29JXCFlfzARbkRKV2BXVLgFlbq66XhIcfokxUz9LFPg2S+ocH7 m2bSZxdNaIP6rF27XkOKysscJo47pXXpMITQc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dYz+Xl/FEuDPplFOt9XJcftofUYzSfEPkgENfM7upRY=; b=bnn9euOGfZ1stPnCjHkuBxbczL3t30SCUrmrIU8CbKvhgArSREmYh/znB/teNpXQy+ Eoq3El7eAl1qVYNmA5qixwuRRUhXScPwuB9f8Tvh0dQyibdt4tr3bs25eLr4UqVeA6pa YnhkuYyktZI9KnRZ0dBlgi+SEnnKtChi4v3eSBOnVnwui9XZswiNT4vSdPDvNrX4nXqV Nqs3yOtBsRnEf9G9tZx92vLY93nsgjNrr1RzRdhU+PaXS6Ou6tTbjCQWARL6eTWFQQAI fZRcSmk2QtFGej0CtXU12qs4eMeIBezCdFqCgtqGglzE/yRo6dCetAFz1aR8AoCOogsr dVOA== X-Gm-Message-State: AOAM533StS3w3oWP7J1Z2u4fdlYoUVNaNTVGlhe7Ks128+aJq0y+RK1C 1nMZYaFI41xZYG9uRjnzrpNTZQ== X-Google-Smtp-Source: ABdhPJzUQ/95idKfShP8Nh5BuMq/OjblF/QTB/uWi6Bvcc8cxblw6O5yxEJRwy2WRXEJxwvbl9d5jw== X-Received: by 2002:a17:902:c40c:: with SMTP id k12mr22052765plk.105.1591638536526; Mon, 08 Jun 2020 10:48:56 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n7sm162682pjq.22.2020.06.08.10.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:48:55 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO Date: Mon, 8 Jun 2020 10:48:32 -0700 Message-Id: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , kernel test robot , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, Laurent Pinchart , bjorn.andersson@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The kernel test robot noted that if "OF" is defined (which is needed to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get compile failures because some of the members that we access in "struct gpio_chip" are only defined "#if defined(CONFIG_OF_GPIO)". All the GPIO bits in the driver are all nicely separated out. We'll guard them with the same "#if defined" that the header has and add a little stub function if OF_GPIO is not defined. Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") Reported-by: kernel test robot Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Linus Walleij --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 2240e9973178..6fa7e10b31af 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -151,8 +151,10 @@ struct ti_sn_bridge { u8 ln_assign; u8 ln_polrs; +#if defined(CONFIG_OF_GPIO) struct gpio_chip gchip; DECLARE_BITMAP(gchip_output, SN_NUM_GPIOS); +#endif }; static const struct regmap_range ti_sn_bridge_volatile_ranges[] = { @@ -925,6 +927,8 @@ static int ti_sn_bridge_parse_dsi_host(struct ti_sn_bridge *pdata) return 0; } +#if defined(CONFIG_OF_GPIO) + static int tn_sn_bridge_of_xlate(struct gpio_chip *chip, const struct of_phandle_args *gpiospec, u32 *flags) @@ -1092,6 +1096,15 @@ static int ti_sn_setup_gpio_controller(struct ti_sn_bridge *pdata) return ret; } +#else + +static inline int ti_sn_setup_gpio_controller(struct ti_sn_bridge *pdata) +{ + return 0; +} + +#endif + static void ti_sn_bridge_parse_lanes(struct ti_sn_bridge *pdata, struct device_node *np) { From patchwork Mon Jun 8 17:48:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11593765 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09BBC90 for ; Mon, 8 Jun 2020 17:49:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB1F3206D5 for ; Mon, 8 Jun 2020 17:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YjVS/wJM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB1F3206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 786CD6E990; Mon, 8 Jun 2020 17:48:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB7326E198 for ; Mon, 8 Jun 2020 17:48:57 +0000 (UTC) Received: by mail-pj1-x1043.google.com with SMTP id k2so147780pjs.2 for ; Mon, 08 Jun 2020 10:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rDREJdIeqVVNUFKbTRjN9h4pzjh8nAC/rSJIcVHTPvI=; b=YjVS/wJMDLTWoyw/MsK1Tuoq6+gBFrFSlynfEopbBcduF6pOpl8ZIFp6syxK7jadgP SnS5iQoGnbiSlE52dB4TPYH0ijiObajjXDXXytMm4k3DNgb2u247r+rvsDyfsIeeAW2w Qs4FXhdcsKjWCadLsOOJI8zMKrfIQY8x11DfY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rDREJdIeqVVNUFKbTRjN9h4pzjh8nAC/rSJIcVHTPvI=; b=XZLDthDfZSyqOySeU6ouHmPTvMnQZauw/61XM9F/SWBjD4fcNS0ELYtjC3M43QqRuV CLgc7beer3R3hqEsGWaD9UUA4WtmEwHV9l1GLWm9juPgGvTtSJITnpl0an0e3Z2r3JyN gZvKlul0w+irhRlJTCDX8lD+dOzyDkxmdiLPkqmszdu32++DYvbeFaXM1mwg7IwC+84F 7/AxYIthXZnbyZBWxzFoxjyDCI04xJR80/5Xn8Ej2ntjwJF+z6vpqTZE2WTTETYLr+1P MFYfuquFrxwfasAEd9p9MVtJYEI5wCihBuGOjAMFkE2hWE944wQEfBJJqXS3021fxaTa cxXw== X-Gm-Message-State: AOAM5337itRUf8s5DBv9SbQe4LF+QzpiX3cUmQUrGCE/GWuUyAOCfaI1 Gp4W10usaFvwQRNo8L6uvaVcHQ== X-Google-Smtp-Source: ABdhPJzXgMGLzrQbBansRBa6+m6CHlci9mkI2ZDTaVy/m4IurD1PdamJfY6lX9gd88k7K4l+QTJrvA== X-Received: by 2002:a17:90a:1546:: with SMTP id y6mr490880pja.92.1591638537595; Mon, 08 Jun 2020 10:48:57 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n7sm162682pjq.22.2020.06.08.10.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:48:57 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH 2/4] drm/bridge: ti-sn65dsi86: Don't use kernel-doc comment for local array Date: Mon, 8 Jun 2020 10:48:33 -0700 Message-Id: <20200608104832.2.If3807e4ebf7f0440f64c3069edcfac9a70171940@changeid> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog In-Reply-To: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, Laurent Pinchart , bjorn.andersson@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When building we were getting an error: warning: cannot understand function prototype: 'const unsigned int ti_sn_bridge_dp_rate_lut[] = ' Arrays aren't supposed to be marked with "/**" kerneldoc comments. Fix. Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 6fa7e10b31af..fca7c2a0bcf9 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -504,7 +504,7 @@ static unsigned int ti_sn_bridge_get_bpp(struct ti_sn_bridge *pdata) return 24; } -/** +/* * LUT index corresponds to register value and * LUT values corresponds to dp data rate supported * by the bridge in Mbps unit. From patchwork Mon Jun 8 17:48:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11593767 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0134490 for ; Mon, 8 Jun 2020 17:49:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D342A206D5 for ; Mon, 8 Jun 2020 17:49:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="crI+dMdf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D342A206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DE326E991; Mon, 8 Jun 2020 17:49:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2166F6E990 for ; Mon, 8 Jun 2020 17:48:59 +0000 (UTC) Received: by mail-pj1-x1041.google.com with SMTP id a45so171232pje.1 for ; Mon, 08 Jun 2020 10:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o8YyCBCbGrw0DIZ0MXUQK0lVQu61p/lQcR9/ys0P7l8=; b=crI+dMdfSYQau9vc9/yyK65ynELRvAs6mgoiidknTuRcDF9lKldNHf6Un61KThO6LE aBqIOsMppcw3sgF5IxZmYi6Vi+hGCW50d4PqH5aPGGzmglwhzfJxe0d+KFX5WCCsMNDx ofzFeFKmOIFr+i5FdRP+j44Jqmp71NbWE+Hv4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o8YyCBCbGrw0DIZ0MXUQK0lVQu61p/lQcR9/ys0P7l8=; b=CRS4BYCNYtbRGQ9bBJRzoRkANMaga3xeYaQaUtTXvFyjPgG2nJlnTnG95H1xUR9aat M2p4RL+IHGSAz1NpNP9Y2oVvx0vs86ZZQuq26ad0pDgwVk5qrdX/F13DieYbNLWdPv2f nOKGbxdsmiAzH8sx9HwJubJRJQh/WoLAmlI/TtZnahPO5jXAmcRb8yx0wfEzAasV/s12 Y28nQG35h1Nmn/U0+7wDhbqMJGhFgSrKgsT4Ssy5iLfQmhWka1XdzGOJdVqj8czKVGBY IdtRhK7EP6JSscjhCrBPCFTHKMFRjyWJzilH/rAI5gsvzT2S3qt8jjW8J08SRcYCi8GO vI1Q== X-Gm-Message-State: AOAM533hMXa7A5uCy0Z3YIrEITn1s1Tei2/R3RYAN45oW6r2JtRJ6bJq Utw1JSIaNor6P266XdWoTCmTzQ== X-Google-Smtp-Source: ABdhPJxDBcpzVSyypXwZzUR9uGeArOBaGnIrUgjorP9jdXDSPFLOIaEjQmAkCG5ko8oaACbKDzq5+Q== X-Received: by 2002:a17:90b:915:: with SMTP id bo21mr469617pjb.52.1591638538722; Mon, 08 Jun 2020 10:48:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n7sm162682pjq.22.2020.06.08.10.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:48:58 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH 3/4] drm/bridge: ti-sn65dsi86: Fix kernel-doc typo ln_polr => ln_polrs Date: Mon, 8 Jun 2020 10:48:34 -0700 Message-Id: <20200608104832.3.Ib616e311c48cc64b2cef11bd54d4a9cedc874bb1@changeid> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog In-Reply-To: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, Laurent Pinchart , bjorn.andersson@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This fixes a kernel doc warning due to a typo: warning: Function parameter or member 'ln_polrs' not described in 'ti_sn_bridge' Fixes: 5bebaeadb30e ("drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index fca7c2a0bcf9..1080e4f9df96 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -122,7 +122,7 @@ * @supplies: Data for bulk enabling/disabling our regulators. * @dp_lanes: Count of dp_lanes we're using. * @ln_assign: Value to program to the LN_ASSIGN register. - * @ln_polr: Value for the 4-bit LN_POLRS field of SN_ENH_FRAME_REG. + * @ln_polrs: Value for the 4-bit LN_POLRS field of SN_ENH_FRAME_REG. * * @gchip: If we expose our GPIOs, this is used. * @gchip_output: A cache of whether we've set GPIOs to output. This From patchwork Mon Jun 8 17:48:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11593769 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AED37739 for ; Mon, 8 Jun 2020 17:49:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C680206D5 for ; Mon, 8 Jun 2020 17:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZL/xMo+e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C680206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A91E6E993; Mon, 8 Jun 2020 17:49:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5379A6E991 for ; Mon, 8 Jun 2020 17:49:00 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id t7so6951459plr.0 for ; Mon, 08 Jun 2020 10:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YIwI7n7N4VQPufeFuOMvSL/7+RKCUZGC7cYkecAGvXw=; b=ZL/xMo+emwIGJJDYKlUTWBSUaZLy53IDoh4ECTHldAYzsEhYULXTfHE17Ihg5yS9s/ GknxH8a1g7MMdbLIncWs0UnD5Gyu0da/rncun2hoJCW3QuwBCypNjBMBCWjKXEjxQnKY 1Ua9dWh3ALilAaZBwqBXOw+Ql0STZFO8QKaB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YIwI7n7N4VQPufeFuOMvSL/7+RKCUZGC7cYkecAGvXw=; b=dRUlot1nsQ7IohGbJyZLMSfiVL3Phb7srNOTK1i4aQMcqeXsJsv2bLZDgusRkA67Uf JGS2jcBDdaP/kH+EjXWMcwBJYcG1qvseR/ruS//drHVrxhrsFMAV7KdL/Q60afHYO403 HAb6s3nHvd3kw6+GZzOUgyRciZnN43XB7ZF4qKytiGUoHAZBbtjkI+c/g2UdjhIyH7Vl AdqZGidcGbSljMoTyT5CxQ7KcGiQa9H2tCWkba4fWnsnWT1DqhdC08C1NLe+QxshqHgN Y0DvnNB7xZtQ8TnnrXSPsdgMP1SLjZ4XzHh7tG4AG9TJWoi2250sCcxohlJ8r5kD+FEI slXQ== X-Gm-Message-State: AOAM532urg6QLXsQ6hXXAdgY8foCVI+E3LsnMkJVtTAZyaVK9b/WWmbH ITQ+e4h9whG245LpbGw72i/xng== X-Google-Smtp-Source: ABdhPJzg/YUFjJB0n58ZSRa8E0eiVaoklc/4+kOj1C57x3OTuyE0OCpKhKcw+Hm/Y+pNC49YSXIRyw== X-Received: by 2002:a17:90a:9f81:: with SMTP id o1mr431427pjp.139.1591638539924; Mon, 08 Jun 2020 10:48:59 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n7sm162682pjq.22.2020.06.08.10.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:48:59 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Check the regmap return value when setting a GPIO Date: Mon, 8 Jun 2020 10:48:35 -0700 Message-Id: <20200608104832.4.Ia4376fd88cdc6e8f8b43c65548458305f82f1d61@changeid> X-Mailer: git-send-email 2.27.0.278.ge193c7cf3a9-goog In-Reply-To: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, Laurent Pinchart , bjorn.andersson@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The ti_sn_bridge_gpio_set() got the return value of regmap_update_bits() but didn't check it. The function can't return an error value, but we should at least print a warning if it didn't work. This fixes a compiler warning about setting "ret" but not using it. Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") Signed-off-by: Douglas Anderson --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 1080e4f9df96..526add27dc03 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -999,6 +999,9 @@ static void ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset, ret = regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG, BIT(SN_GPIO_OUTPUT_SHIFT + offset), val << (SN_GPIO_OUTPUT_SHIFT + offset)); + if (ret) + dev_warn(pdata->dev, + "Failed to set bridge GPIO %d: %d\n", offset, ret); } static int ti_sn_bridge_gpio_direction_input(struct gpio_chip *chip,