From patchwork Fri Oct 12 06:31:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10637973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D536D13AD for ; Fri, 12 Oct 2018 06:31:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C21EC2B94F for ; Fri, 12 Oct 2018 06:31:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B629E2B960; Fri, 12 Oct 2018 06:31:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0855B2B94F for ; Fri, 12 Oct 2018 06:31:10 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E373A26778D; Fri, 12 Oct 2018 08:31:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D00E6267967; Fri, 12 Oct 2018 08:31:06 +0200 (CEST) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id 1C472267737 for ; Fri, 12 Oct 2018 08:31:03 +0200 (CEST) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 12 Oct 2018 15:31:02 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 8CBA36AD78; Fri, 12 Oct 2018 15:31:02 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.54,371,1534777200"; d="scan'208";a="294946641" Received: from mail-ty1jpn01lp0175.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.175]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 12 Oct 2018 15:31:00 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mzGiN3hmp8KOzYF2LdBX80hp3MVjVCsQhpMwhtaDByQ=; b=U7x6fxyYxEYT9cDgOR3jIc1brGxiuq7wrGJVWyeomIKV+DZke1F7jzRHRXPeNb3TormBKMBgRWocVO/kSzognjgx/5w2zbXSFwVjJp1dA4MWb2QlgIhRQT4AeJ/Cc++Hpv/oQEclrylQTuhe2KS4rbMzgm8grJtm6R+OOE2BoOc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.130) by TYXPR01MB1870.jpnprd01.prod.outlook.com (2603:1096:403:b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Fri, 12 Oct 2018 06:31:00 +0000 Message-ID: <87pnwfbs5b.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown , Jaroslav Kysela In-Reply-To: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> References: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 12 Oct 2018 06:31:00 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TY2PR0101CA0014.apcprd01.prod.exchangelabs.com (2603:1096:404:92::26) To TYXPR01MB1870.jpnprd01.prod.outlook.com (2603:1096:403:b::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 113be53e-e1a1-4d1f-fd8f-08d6300c4695 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:TYXPR01MB1870; X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB1870; 3:yCpbXejesWkMYjAwQTcKsBL8/knCj3e9bMS/wFl1NhDCBMg7Qkzc528oh777EM8rTKtIsc9rXr4yDusH65Q9onbRSNUn1f+lU1PiUYXZZC2Lovq1W+gh/feF7qhgOt8sSDI1jRkxeNklNx9xwt5H7IEOkkU1uSdx/PHhMHVHrY86va6Q4Wx3YmFQEDMEoWEVJ2y/Coa1mB6cdB7hHbrwTosOOPcUfRHQEDZfCz4I3o7UduTwYwKv0jlgp/Nf6Zi+; 25:DDsqezpb0KUmkJgBkF8eagaCTEqn/NU5Dm+tc+13wSNdAd4jL/mObyFf6/MYBgkJUEQ5EcgNP30Ktkr+d9en5O4u3KA6Rvl0i5xsBuEbJxJtFLBg3RnNYvHu7M4FLhdI75739+PLWo6Kcu+c2LDdePar3T+oRrEiL8goSYUkwH0zx51bU00ORFM7EJNmzzOlAFYM3EtA742/8S0Y346tJgbIbufn2mXhrAxKwAYq4KwewdzF2cYAEwqx8LmcaRTEfCElZUzsx1HYePTLpSFDaGvVpNUg9pzVqxK/dZOI7j1aMYuwEXroq8zWms4OQE/GEGj2XMB5wQiNf+WMtSPhLg==; 31:mbhrFrMPiIYeWgZGP1tpKyDaaUA5xW4oP+YlTrFnZNYmvyw05SdSvN1w/ofzPBxfN3rD9LHhZgkq2l+LknzTeqOAHhMUW0r+8YCJ75xMVuSIXPZrfRriU9mC0w6mWeAZkQdJrrWGpXWPDp6W1Qb/0zSaa9s2wyF5xK5JvmoZWnJVVzqzTIm4metI/u/9E/iRzCgcSinNreA5JiaWW2A42ix64G1P8b2rxCULfDIJogA= X-MS-TrafficTypeDiagnostic: TYXPR01MB1870: X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB1870; 20:PGC05/y9csM89udRUqs55jkdnKcrgw6X7QBhWbwdMYOrb6VEY6kXdJ5GOiLYFJ5cNOjdl3aTs7hHSmxP2LXskAKBTII/SwtQ3+238mLOsALROD8b7W6UU0Wt6kgRvLfFw/JcSvGn2znbnuJjW7CP4/d2jtcyefNXaUPS7pdzuN5ufZ/92HQm38R2Lsrp8OrE9y55Lxw45pT1b7CD/uma8JFiX51q5CfCvNBsi1/gk4OBNnAVGcPOonjzNkNbIQFZGRivk/QHaaYUESCqcXXvBM8SImSUeXv1pE4W8ezSMG/3NJGa5+IqZHAli5CHV7odDIFafOA584XCXWyDBduvoQSG/7A+uXuHECb/L2UGVLt3D7GnK7EofiSA0I4e5y2EGsGGi5xhR7cZOLYUzSL5XdL893bSDdzKLlymcMaD11lXIePoDhx7x96P2BLTNC0VLMzjxbh+QJG4AQ6+tZKboDxMlFRK15U0rPlB40BMTlcF6cMOB83UBh5T+f8Zq5pQ; 4:O4x9v9ohzJxNy5crmgawux917GohAPuXPTSRJ1bWvsfrX2qs9Af1gxOUoz8NWLoLs/F/vFlyFrUgkoTdDGGAEm2YlSnQ+vqicRmBaryuOz+6vrNUQJ0E5i89OkoP1w6iO+JtWTcsyQffJOQiKnfAlL+o/wA4zD1hEdG07H5GnVmU1g/Gg5f+SySt6BopaXwYe9xpEtKtUMxdx039hSoG12fHTAqqRThpaBZebJiWl40O3ohnKDQyZTlJFB77ywNQkwawqSB0LV2sY/3w6beGKA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:TYXPR01MB1870; BCL:0; PCL:0; RULEID:; SRVR:TYXPR01MB1870; X-Forefront-PRVS: 0823A5777B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(346002)(39860400002)(366004)(136003)(376002)(189003)(199004)(105586002)(4326008)(305945005)(76176011)(110136005)(8936002)(66066001)(47776003)(478600001)(316002)(16586007)(106356001)(81166006)(52116002)(7696005)(36756003)(81156014)(2906002)(58126008)(69596002)(23726003)(26005)(386003)(7736002)(68736007)(53416004)(8676002)(3846002)(6116002)(476003)(97736004)(50466002)(86362001)(186003)(6486002)(16526019)(486006)(446003)(5660300001)(25786009)(11346002)(956004)(2616005)(53936002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TYXPR01MB1870; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TYXPR01MB1870; 23:VOX9zYmQqhE9Gv3UsGbURdio+8SRZa0F4l+MNyYqd?= K+eHPclHpgZjYB8Y7e//JKFMbTUtj04QQb9/R1Bd0o0cbQNhMCiq0YjQJbko8nODrBObajr9Xre0qvcPSS8XIjaOE/0B9QGdO6UdAbixB+LRCAg7T2D9LDIMBK5ukv7RkIv2NUExASRScJNwxa6E5gyfHS6oC2+vwomyqWUit3fJRn9glkf54+Vh2t2beJhaAaMeXzqk+LjGE2/r/RDtenIZjOJDCp2KlZ8Mca/1apUrFQ/MAP6InnFrLTrZLuDjSQTXctHwDGv4Lg/SEajLogMTo8qvnFAcDHnCSVL3jn+vPLyYAkUD2I71+opAJDUKkKJi/qHGoO/NDrqKKP8D9S4be+l4zom43oF5EgHLKtDGZNp8BncVoRofjIE1J+0kybiSjq4Unzdeb//A+q6pHohnpmzrsNhKhlQesSl6o8G6vm+VrCEwVIMSYtwogpR6ppikTrbTqBJDY1PsxWRsnX7tMAKG9NBAtc4WOFSCf1BUmarlk/txfzHrie9DxpYA72EJpwlwoWQhqOIZCVz16udCx1rznw+MRDAHtQIT+jMORWcapsKCaYe22eUnvcr9GBnYOZDo+k5ucidpEq2+vjbGwDEB8FmgQpkOCv/5lO4XJpXwCLliXE1K++Ch4uRxxajW3vfjRQPmERudr3AFzmx+WZkQJ/D7rtsyCfL143ZsrYoQvl2o3/H43QUCxMThglszGRxj4gItFl7ZtPCsrVwT3hk4szajv9goZZmQ/EZ8hdIr+1cHc29FamsaucLryQalB7tiuP0obFHAHWPGTX1JZhfWlzVFweAyjs13bMrlNCEbNEjgGpNPYU5DCMvMJyltWo+Av0eSFC6p7f/2dOudVyoTi3ZDL/GEImTw8acJDed6DM/6bOlmnZwlwQbpKAwaQHvM+qX1toZK5+iO8kFBaFyVw27pLQXAnAJ/cI+X5FSPStf6gP/2evGQhVrlkorK6mvWILz3uK8H1/QMrYO7Zuoa7vrIO/zHsQLhMcHB4kswkI8KAwZRkoMtpdUCo6yCj330pqVruX0A/Qokr/la/Twl7PWE5LAgCEXEAhyi6lZKC0rdkTMGT4wrrqyy581du+YzYR4cEwSJti9/YfM5O7RUocXPYPt8ZQQ0HbvFn0KPOsUukP+Dbmjjt5W/VE= X-Microsoft-Antispam-Message-Info: +x1eOqNwyDKkbHHR1rgqY/YiQHeUfzRNAbQlWZYLutXJYTpyz/v5cGvY1RySrQW7OlM3CZTMN0AcSz5qRFYjcFPNr2QA4rqsiaC+fOjmcyYxxDsgXZIZ9MtarWqy87qg3S4c4lgH3cMGmCD/YkdCg+L7uMMIHIDybgeqsbg9K4w2fATDpZMHE0QmO9Oif7fHoFlLHIoPXkC3B60P+ZhM9A3Nmq/DoFjj6IKmenU1ACHwSrtQSTspdcA4EwFdhxxNdqBwZGAynGdlbSS7ltAqRIARqxgQhXLaIWrPxTDPYQUlTs8TODhLHHN0r4CNWnKVfBYvDT7eyc69aCie178+thl/v7EN/Ym9Hf6gSdSdchU= X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB1870; 6:G+q6jkoHO9cjuuDUNHoWKZgByAUeHx01gVstbPIlIPjw4hwGMYdCV/+aaECFLX/6sgQ5XjzLqN5xpfohderTanwT2FrXBheaT9e9+PiLteE02akWQg0284r8DTWaL1GfyL6PdXa25oPgirmdqJviUq3OcgkuHtS3R13ORBzD/BKjDD743mnJeuly91WvwXDT1lyW8M7gRE/B2TxjTi1U4p3nf4QADaPNMGNFBeDQv5mztIQ8Cyxz/uAk53qRIMr1/yANsIwqaUQw3d2jHfBCVm4VN7ertXFhgd9syuNujrS61CKDPFGRHD4bpfrH5nCB9DZMPu/Fje2+SXlpbkPKMp1SMSmuOZ5oN+64BkHK6NqfDpm3mcjQPmPX9W1H71Bj/Fa/cglZQ3/XhlMqFgo2ZirkKH1PpLRgIvbQyu7eSx0nf3JGZf3H+UlT6eSruEnUuNMD22KwczB81rMzsZaYPg==; 5:uNiyJbBduqjdUHk/dSlbQQw5Zysqh2H6S5OA5Zmcw47GPdTV7oNBZuojfOKxXGGua5r7Viiwr0GNDzxuLga4V/7WYZZTLPQ5jiS07k2FaG1eIRlAYq87aUpCTId5qhWXiQ04FpaJHE9St4yqCE7rw4aaLJDhbPCNdRI4mK+yjfY=; 7:nKc11nS4b8gcr/q5fj/HN8XLmC9PnQuBeULix+2kOeiTH6I9SEqr6P1cRZxcH427WwiF0M/In5UZATLqCyxKocajjPMfeB67k51darH8tHhE3BZIm+agHHoMv6ZyfX/wjVDplRe+I9YNNvRNBdzK0ciZ9n6l3rlYGvyUv8gZH0UAnoHQb0zOb0GF83LauBT2iR93aSWLuvQ8F3Lfjq1WcTiT5uLR2bdsdGB0oRpcRFDeYMDIQaDM2pl1WkMXH9Kt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TYXPR01MB1870; 20:EKxjgUPXjdk3gL5d3E7lczpVAcHYOQKei1GeB/rdx3lvaFIYvOheB8Sruvv+m19Y21WyVx9AsVb1oKi50F4t2Yd/TKqicKsAr4aW/FKMxJk806AX2nuPkWfLfyabnygPtzLybZBlYN5c1vJAdKjomZriq5Z79oN0t5HCDI4946Q= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2018 06:31:00.0919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 113be53e-e1a1-4d1f-fd8f-08d6300c4695 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYXPR01MB1870 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH 1/3] ASoC: pcm3168a: add HW constraint for non RIGHT_J X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto RIGHT_J only can handle 16bit data bits. Current driver just errored if user requests non RIGHT_J + 16bit combination. But it is not useful for user. This patch adds HW constraint for it, and avoid error on such situation. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/pcm3168a.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 3356c91..233a8df5 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -476,7 +476,43 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream, return 0; } +static int pcm3168a_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct snd_soc_component *component = dai->component; + struct pcm3168a_priv *pcm3168a = snd_soc_component_get_drvdata(component); + bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; + unsigned int fmt; + unsigned int sample_min; + + if (tx) + fmt = pcm3168a->dac_fmt; + else + fmt = pcm3168a->adc_fmt; + + /* + * Available Data Bits + * + * RIGHT_J : 24 / 16 + * LEFT_J : 24 + * I2S : 24 + */ + switch (fmt) { + case PCM3168A_FMT_RIGHT_J: + sample_min = 16; + break; + default: + sample_min = 24; + } + + snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_SAMPLE_BITS, + sample_min, 32); + + return 0; +} static const struct snd_soc_dai_ops pcm3168a_dac_dai_ops = { + .startup = pcm3168a_startup, .set_fmt = pcm3168a_set_dai_fmt_dac, .set_sysclk = pcm3168a_set_dai_sysclk, .hw_params = pcm3168a_hw_params, From patchwork Fri Oct 12 06:31:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10637975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E756913AD for ; Fri, 12 Oct 2018 06:31:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5F222B94F for ; Fri, 12 Oct 2018 06:31:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C73332B960; Fri, 12 Oct 2018 06:31:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E5D02B94F for ; Fri, 12 Oct 2018 06:31:30 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 3748F267976; Fri, 12 Oct 2018 08:31:29 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 87E20267976; Fri, 12 Oct 2018 08:31:26 +0200 (CEST) Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com [210.160.252.174]) by alsa0.perex.cz (Postfix) with ESMTP id E2843267737 for ; Fri, 12 Oct 2018 08:31:23 +0200 (CEST) Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie3.idc.renesas.com with ESMTP; 12 Oct 2018 15:31:20 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 5AAB47FD54; Fri, 12 Oct 2018 15:31:20 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.54,371,1534777200"; d="scan'208";a="294946694" Received: from mail-os2jpn01lp0151.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.151]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 12 Oct 2018 15:31:19 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=siP/l7z2ygYwWs4qkPkM4BVY6X5/PvnzDHhiH30KmZE=; b=jc27604VGs0erH9q81PZNTCqPqEuA/lW/H6G3I8YIm4wHwMAK5msG5ZrvEPVrutMWM/KEqDbFpgZKSWJtSQM2LGRjyjHwJLjKgMbzeQaxGQzrLpudMcpcnZgPelNbn+0e06ZnV+IdculdPEWXqE4mGsbP6+ySh2x3sji0c37DyY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.130) by OSAPR01MB1860.jpnprd01.prod.outlook.com (2603:1096:603:2d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Fri, 12 Oct 2018 06:31:18 +0000 Message-ID: <87o9bzbs4t.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown , Jaroslav Kysela In-Reply-To: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> References: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 12 Oct 2018 06:31:18 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TYAPR04CA0003.apcprd04.prod.outlook.com (2603:1096:404:15::15) To OSAPR01MB1860.jpnprd01.prod.outlook.com (2603:1096:603:2d::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a2d6f47-cc22-4b47-5476-08d6300c517a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:OSAPR01MB1860; X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1860; 3:asgdWICrMdklZHiGJoC9OTzsKer5e+Imr7/w75H0x6Mf+sKGNzplliBV8kURUvNLDudtj68AJX4eD4M2AHILyuc21AMUT2/rfxfVFoku8ujzc27McqPM6HGVhOLHtCK1nzKj6LjHdZsceztEJm1JTNzPXVnJB8PZXsdkHYCdjIjD+TOv9YlymKjUbUaJi6Wj1t3Vv9LcuSjcRDJys31CN/JspONcxGZYCNbMzKyZQeMLKBjAdV058b6bkstuzW+6; 25:qSE5GU2rXvCEEJKbTVRmwvwHt7o2aXjOB0OMD1XSN7T9Zd+EXsLADXW7HxEYjgbEbEYdtv7BTAX/tJTCu9Mp5NNm8OfMo+NL2OMbBMwSIbLhzr3HSNrXtVfB8EtzRtrhLKJKQ7hVswh8YAL42fhOPL9/0LQnVRL5RPBR75kRyMkIHsOtdgYRG0A66c8o4+dqxhgWET86HNHYtLP3kZ8Mpwa212yPn8rxNhfTbeLU5gKNuS9MeXg+qslHzvIG+21DiDvW2YQvnZzk5Sdd9V+guyinmQe1duw5YHCUp6e45V2KxoAR293I9bF4qZtKAlCHTl4gf4nDAs1//okTZZQBZw==; 31:hzeAzb8pQLqNGgMfRuNAB8DHnLF8MO4SJCipgi5EbHGVdFYQPwEiCQ0nWv8nCC1mFDEG25PO9U9r0VDED7+OCTSg0jLvBVjUsiMbAXdADwpaC0Qyl3nxJUU63VsImuYGfHPHgvlK+F1xW0rCxTEqQ9NKTRFmjipuI02n5YCr0xAculZNmKEWXL5ORkB9JyeM1giKEq+WV7D7WNtpmRXhD/+jNq2vpu0qGSt7IZeorA4= X-MS-TrafficTypeDiagnostic: OSAPR01MB1860: X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1860; 20:vWVwZnXxkGYiPNDPvvaZNdunir5ZU+ZwSudUGN+f2nsZaP8ruxk4xqh7yvUPmsM4kiJ9z1a2r/II6Ld+3zDSNoa/PPuE1JV9v3dNTQZsjGOYzbAUMJ8MCXpOj57z37zNfiTfk3rn7Zq4GXux9C8k3FUhodZc1yp/LJDuywG5B0EhdxzVA8Eob8+Yo2+C3NOibz2EYLhS1LzlsiM1d+qGJyNG2/2YbNKEvcSHZhvzs1e6ufc1+Cwn+uKhclv0w+T1FoXPvwUffDePS2LZB5KKtRJduxR/WhjsLcClWaBPD7AzDMQ34iOPzn2xiuxnMwOH6lIh6Gx9ImutpjEsdRyYFU60/6gE5XM5SteGYr16/JSJ3vsaRbkZxXT1Qmq3IlDwkSgtUAS6lYTzOBbFCeFn4twlZ3dXXY/AO+fT8QJSnIiYMbl0R8CsaFocjO9DxEaxsn0QQunLKa4DQmhBeUUBj7XnJzsb7TkbbgeIS8/8JwCokIKDGIUyFU4uysGTFLME; 4:OuDO18FjkfYGHRIwGUgPUbl4cNJMZZfjFxpoeC2YVQwf8Yivzz8E0KdF2paRm7e4yOUeJfX4KB6Mt8jtceQ6Y83IH/bu7DjSW6E6LlRBjWdirXv8UI7vhKgSTVAA5F3hf98vQ6PLzlO96QukqsStSxz/ILIu89xk+MnSTKF9RdhWj/746bMEz9XSBA6r2JlpkLkq2g2oMn9bdyjYpHSssm8QIpQ9vc+AzILxZUrFNCOGhuib7EyqjanvJXpSgWI5RZLcnaMOzgM3dfPIuJ25jg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051); SRVR:OSAPR01MB1860; BCL:0; PCL:0; RULEID:; SRVR:OSAPR01MB1860; X-Forefront-PRVS: 0823A5777B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(376002)(136003)(366004)(346002)(189003)(199004)(47776003)(26005)(81156014)(16526019)(7736002)(25786009)(2616005)(956004)(8676002)(486006)(58126008)(186003)(69596002)(7696005)(53416004)(52116002)(6486002)(8936002)(50466002)(2906002)(305945005)(110136005)(386003)(4326008)(97736004)(81166006)(11346002)(3846002)(86362001)(5660300001)(575784001)(316002)(66066001)(478600001)(446003)(476003)(6116002)(53936002)(105586002)(68736007)(36756003)(16586007)(76176011)(23726003)(106356001)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OSAPR01MB1860; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OSAPR01MB1860; 23:ZDv06u4DUXmaL/lWpA+dxyTqPP4kGCTtyJU65659W?= QTESY6SYt20ik/F+D1ML6M8zf+5UXCdDMw9P5bKLprsI2IX/ouE0hhLzw1BYHtvkINfuK8zdvZHdy1hUbNEFmUBi1PtW8xa51gBS8aoRQw5F4qeqPD2Zd1lLTHnkL6eJ571v29pPAoH0nGqFgGqid8gnZwL8dLdDqC7kLOkPuV6KlFecO/uHRlvyEx19ytUlrki3igZQrC9rcJzA2EFucevqvqffrsjXQIFFaQXSu2KGkQuauQjgFVeyHDy/mPni8orA5j0zco5k+bGy/VJe8aw4UI4a+kaztoMwOxILwB/mmwoRYPVLLg+n6/a47ez2Dzp+A2e4Vef/SGyT7kJCKij5cfe2be//tBgLH42gXKugg8dfu7nOoEb+QUHYOhi9R28wLZtfsAbH89S7vcEtBSSJjhiUSHbhXJ2JnAulr1lDrlV53S+vPWi4rW9xznxSmLceB3QfjatmBIsY8CfNTUbsu/+zQSrsFVTjzauNJrF5KqqaXE7ttbvsnMGNC5weJYpZBwdr1KcR3t6QeHdwgJtf2aPY8sAvEbVz+yD2IH27JWfVbSPpri2bAaEQ+rwn0hL2qqldSSg3AHVc9ePs8AwCk+o1V22tT/9cqu6EDOmx2g/tWe7doBqI/ilONt6nrZiLimRLG6GQAMq4hdtwnLI4SAyicJTZRRwLAjg5zvWBYQ+j5xbnSJkm5oZeLJnlr9I6WwLbGNoJ7YGmQwvpFm8mElCtYaknDx6EEu24qO0VUPFALD44OdzGwnOvpWm7n9QWy/Lz2aMU9BZ3DE2upEmlQ0tZyLrJeCGMXm5GhbsOyTEIv64JaSwFJb++PzTvwnxEXYnqsi+zemLVvZ5DJ2ec4S/aPhPvdH/7rBYLIkQQwcAjTTZGGkn6O9AJ6PRYxRdXxFGArYnrMVTTrpHOFGOhJSv+xg8zDDHznuXYk9iJNEAJbLaHfh7bgeEmxXJ/RYKpDxfae/0pAhDBdxx4rqAIE4VgXakWGDKDIx1MiHTfoeUUbuS9m4xjSNohkx3eIqbQl2sv1Zo5H8Gy3zHgwQQ1La+PUUpSfE6diCLrxUQKh+JRQoShrRyomXLqgqh7O2wZefGDOx7NQ0rsbmQgTUmFZN+5t9KD1V57MoPQAJTVRA2CrulgVEl/cgzd8IuGCiiQTkA2xPY55KtrcmvT3sL X-Microsoft-Antispam-Message-Info: 55JIzNNOzsqqZ6YhK3Sj2VCHPtHcCSyNgV2rbPaKJFqzfS3ihcNeZKoy+HYc5WG2aH3GQSVaCLtXQx3C7jqfW9L+KJH5Wxd80Jh18gS7PC8GFIpwLlKMgbW5UzO9cRidC7Mi0fpBuNOXfWnnZr+gBW/AMkiMr+Ep4CsCYBHQG6LobLqUsTFxK2F/B5Ku2fTmEU55pG1pNYjJMeF8FdpmA8FiwmXC9Ox3/8qY4uMQ1/msPIhwsZHmpg7nFJlzxQb6nBeNUolfwBg32Td2hSp+Prkabq1f03nuasKKeTa15nC/4R+axJyBara8i/Xchc09KPERLroteCWasEr877+Jqw6DoUea47j5TO+HQqg3lo4= X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1860; 6:V0alaNUkqRREEXI5R6esrT0BwPBMsrnrbYDQnCjvc69crrrMhP3YSYXUA3xzSS4QWqDp64AEbnz9Zj3dPZhORahpQJ55FPpwt5Z2VQ59OecgsXt+nOOk5ZsKrwUUsdsPsw6FJ/Gn/u+JFCljEmml5nxzynrZIOtAPUkhHVNaI9ZopoIcla17u0vj+XsThDX7S8y+86eQYxaX7pnSI61KLXIgVfzuZFVLxQzpLqUc00okdOo+Cn4w6oQPqpkvtBo5YWOKv/QP6QPnyXj/668k36WxhxFr8KJi64ElBJToMkcTUxwMVOLz+QXDeRIFVD5QWIvOAtCDN4koYRPA+LOhC+524vk1JRHm1dXqjS2yid6ncETUgGgIsmYhvIEDypQH2oAn21DrpMgnSELKsbQcFOOI6vMVj/b/ShYlMIwaRtlkzoMI184eTdl1ldh1l8TMOrfIIM5xf7EDtYbw4UR5+Q==; 5:sfPkH2IngP+JCxY9VASQ7pmNGJ5QHZ5Yt0wbISpDLzGzaMMMIZ7LuZuHQfTbgl2xP3Zy+nWk/+gCBqUfHWWvjy02ya8SaMJjj78C1ES6iG9DcgzPEVemcta0xWi+YwWSayY134yafA78J3OgQ9ZFU7nUjvlaUg4jF469s0Kcct0=; 7:5NODeVrxsC6PSFi2kF++17p41zqZHzHvwxsyMR5Ww6VqNpQbbPTg+il1sOsFDM0GmLX32Jji8tDz7+s4CNLbp6AFM2o0lBWizi1dTsEneBk1RvfLmFWzICmbMr/e1X7IpnPE+dOSo6erX3xbeKKN4seb6eb+EpK1+tVxoh37TRA79kX1Nd9U+mn2+MVecu1jMvt5te+LrT8nUp69Q9vhjb67hE6Dlkfw//UVN8ZX0bzC389Vd/18BUG1WGsBGLNb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1860; 20:C5ZrFTzuloN8zQtFhik+lVelKfz/ynpabWmUIBIfN2tmnaN0u6A38h6YXgWgEAyFNL9B44ftIdI21JObqwWAjrdahsNJuFPiljrVnWT76KxzQpcSwuZFBaaJsuLQjRxMjhr1i6r5PydfUnNvQvi7mhududi4/JmGwHHlbLZYs3s= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2018 06:31:18.3275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2d6f47-cc22-4b47-5476-08d6300c517a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB1860 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH 2/3] ASoC: pcm3168a: add hw constraint for channel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto LEFT_J / I2S only can use TDM. This patch adds channel constraint for it. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/pcm3168a.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 233a8df5..f0e2b88 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -484,6 +484,7 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; unsigned int fmt; unsigned int sample_min; + unsigned int channel_max; if (tx) fmt = pcm3168a->dac_fmt; @@ -496,19 +497,38 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, * RIGHT_J : 24 / 16 * LEFT_J : 24 * I2S : 24 + * + * TDM available + * + * I2S + * LEFT_J */ switch (fmt) { case PCM3168A_FMT_RIGHT_J: sample_min = 16; + channel_max = 2; + break; + case PCM3168A_FMT_LEFT_J: + sample_min = 24; + channel_max = 8; + break; + case PCM3168A_FMT_I2S: + sample_min = 24; + channel_max = 8; break; default: sample_min = 24; + channel_max = 2; } snd_pcm_hw_constraint_minmax(substream->runtime, SNDRV_PCM_HW_PARAM_SAMPLE_BITS, sample_min, 32); + snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_CHANNELS, + 2, channel_max); + return 0; } static const struct snd_soc_dai_ops pcm3168a_dac_dai_ops = { From patchwork Fri Oct 12 06:31:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10637979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 254AC13AD for ; Fri, 12 Oct 2018 06:31:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 149332B94F for ; Fri, 12 Oct 2018 06:31:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 08DBE2B960; Fri, 12 Oct 2018 06:31:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 544822B94F for ; Fri, 12 Oct 2018 06:31:58 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 19DC1267967; Fri, 12 Oct 2018 08:31:57 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 712C1267981; Fri, 12 Oct 2018 08:31:54 +0200 (CEST) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id B8F32267967 for ; Fri, 12 Oct 2018 08:31:51 +0200 (CEST) Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie2.idc.renesas.com with ESMTP; 12 Oct 2018 15:31:50 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 310DD7FDC3; Fri, 12 Oct 2018 15:31:50 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.54,371,1534777200"; d="scan'208";a="294946740" Received: from mail-os2jpn01lp0146.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.146]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 12 Oct 2018 15:31:49 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kEe4SWW5TkQh6TiWoNzZ0VHpZFRpHriUzcjy5AzPqkQ=; b=Mf+tYqjGofKMXMjiGvQkyAZiYv+aEFThZNIJ5//Ss/HhzfmppZO3jQpyK/E6e0zQOrwlSQsCu2iMXajUA2jr/Qm7AAAZopioa12xQGPPiBy9UG1MzbQPxZkpf9HOzF0FPJP5oFrWk70cPpifeZc/prKovfF73HcbHmjtB50qzdc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.130) by OSAPR01MB1857.jpnprd01.prod.outlook.com (2603:1096:603:2d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Fri, 12 Oct 2018 06:31:49 +0000 Message-ID: <87murjbs45.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown , Jaroslav Kysela In-Reply-To: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> References: <87sh1bbs77.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 12 Oct 2018 06:31:49 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TYAPR04CA0001.apcprd04.prod.outlook.com (2603:1096:404:15::13) To OSAPR01MB1857.jpnprd01.prod.outlook.com (2603:1096:603:2d::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c4f46f1-8747-480d-566c-08d6300c63c3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:OSAPR01MB1857; X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1857; 3:r1h7e4LWPDNvOK00lIngdilKjXfsCKeoVIcflFGCFIeEkHWxKwumGSWDPRtpV9HULC5mhWBOKinsl6+pNE5TGWQFea2fOS50xm28zjH9i3qPEG8jyEEtcN9GoqF6fbkN3q4QFpcN6G/+PtQWjy68/rMiJ+MhLuVNSPG1jlFELFfVZ7kBT3Hr2nWetmtegwMvMc3XMVmdjLdeWqrJ8humvYAOTE67jzdQa0ScDahdbRn0y2YXWM6+agVOPaaYOcS3; 25:XiOm5/HASdlepmlo89f2hVg8CR/Tpp1FRSTDm/EkJyeXUejrSLKdBFeUIe1S8zqEA5lc6uPuZ/lTzbHcdIvrtCW4FgiH1YIAG+SnCQPJJ4MmM2pYYWgVeEhOnac+5hXUO425He5Bdp+XiZC2J35srCoNNRt1mp6z2oAsHoZ34TYuzoZZ3wwFUr94Ft0ZwP+2Z/weK9z9+4gwFfHNY9UP5WLOO7N/kk85bUrEWbvC21L/pjFT/FVdUESgIsRikPmav4bpk5U7r7cSBUvgu9eiwO+K/yR65CPr5FuYnwoX+eIjX//p1EGYY3g6NEW5FsI6VgcvMK3Df0uLCBHcCSoZkg==; 31:NJwsYZ8uYb79MaJLZKuG0bcT929A+XT8SODMilqTpqKrcYOJcDu1LRdKip+G+i+sGA9ki0GvEdDvkZZYh/I1yB1qN6rvAKSkzDraDVkoPemvvuj5rY59ViddzTONosMLLhIOjmumTYEHKcl5vDrD2EC+UXFhzxybZQyqC9qrdy8RzU0IqzvdPCT4zZBekviat2hVlAr8hVC8Vs3k8c9UI5XQOekOZVLUG0SiVVrbBEo= X-MS-TrafficTypeDiagnostic: OSAPR01MB1857: X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1857; 20:4a4ashHlS7MIIqYvPerb6foT3UAf31s/QaiBY1CfasXDvQF3DJKxrtvfzX3lPLXm6W01bwhhbNRyweACQ4ksxb32HYWn71mCw9n5KHBLEgYt2CaGi4e/TuqwdQDHh/3PQRyEeFEvSfwRzFaof3FTJisWpSU7krg+DlZjbew8dzmB6gtAZTvScXy4mlLq2AAUv9w/NmNttfSwsg14X/KfX2MaZfDAAx6/p9hILa5ThMyhG9IB4qgNBqjSm8dLcb8FMhbrpvjlC8gIa2caQg8BRNnHF9Vp/pnB62pfJLTF6d6OIOwiRH9V3fmv9uuAwNo6ZboJRFAgzpLMnx9y9ZFVUtD4n44dTQHPN990RyUwDGmUwRT7TcITC2g6OzRZtn3OnfKfHQi4GyeQ/tUPn8LVuOsCcZq/ZmCd8+7Q47v92V7tbTPKoEXkNckwrscDRNKhjkg36wotqBSNPxUyiAnk9lKP5QEm94ySGNuYuvW93XNXGHuwS4Iy8jZiYPCdD0E0; 4:7YVHELoaEe/t3f36y3XoC0xP4moCjy0qHTO1a2kV24Zx0IYIzmZTu7sNbFIl79zGTLFB0D/58978HsEj6yK5+w4VOs954TjeTlKJuU2X3b61zr6fJMzaLyGx/K1Jn5tOcLTRN0I/iG5TOUK/ryGKMCmOy3R1BWbM/rlQaQZL0MRvaxbuwZulej05JgN68laZ1GFLA+kHMh8XJAldsYs1lETzw+Mu2/T9mG2/iZg//jkYDZCEgsbYaSmlmNASGpKlsG3V+Kav4J549giNeBSMWQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:OSAPR01MB1857; BCL:0; PCL:0; RULEID:; SRVR:OSAPR01MB1857; X-Forefront-PRVS: 0823A5777B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(136003)(39860400002)(396003)(376002)(346002)(189003)(199004)(76176011)(7696005)(52116002)(16586007)(110136005)(956004)(476003)(2616005)(486006)(6486002)(386003)(69596002)(47776003)(5660300001)(53416004)(316002)(50466002)(11346002)(446003)(186003)(26005)(53936002)(97736004)(16526019)(58126008)(305945005)(105586002)(81166006)(106356001)(8936002)(81156014)(2906002)(7736002)(66066001)(478600001)(25786009)(36756003)(3846002)(8676002)(575784001)(6116002)(86362001)(23726003)(68736007)(4326008)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OSAPR01MB1857; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OSAPR01MB1857; 23:875g6qgbtTRdWW5uS6I5PGtcYabpX2YOPNNBvsWMH?= v7ZQWztxJXYRyqcQ84ftVPu+NijScKjb/MO4Dg14v8Wo4nTUgDBpf1SZ9hjheoCMA/W7VqUxPRkd9VHi9Z9Yt5Z+gxN382yEqO9g5FkIPueqysq8PiCVbTaT6G2N7srMEqZjbr3+28U5aBCT+IULZBe3GTJvq3Pkoia2fdhAC9fv/7hGRJ3zy87vJp3tesgNTQMdZBqaKta4fec5M7YYumnDjfbI4L8MpP+nQhrSc6LVcEuuNRdFyXSjIexJuoTe+CYtmVZddtmf35BXU0pWmcb5ez4MeTw3pMyYAgZHjQW0W14Yf5BSVmswkY0WSLn4Fs3fLZYJNuxbwsLul0pcJUdPID3d7h4uu1Xghe6igInxn1zV+90R69W+/DW4wjT5gADZ/A5pffMea+4T/h5RU+DWJd+6jlQDM6ZtHg6+06cnt1c4tL/Nfb0dNCfKK9olNVy5+SzPxjSHjbSZfss0PSBBsgVsraTww6Gnsvc2McZFJYr+m/Zp/r7NWaCnoQ3Sj0vKVqmglpy0MEYNltJRs9ckA+TGhQR77mzuGXAZd7CHWDiTJ/VZFhKUz3/F/ixocNAADRTHnQkmq3JJkSVJhqAngCvGAc5Y4wwbgr85AEZCFoTmDAvtXNFvNupKp1J/Acbr2lGq0csy+1EeguKdhjZ/njpVsS/5oYphWlbUc3k71kb5mhr91DGfdFOC/xeA4rNgrBkci6z3CANrWCHa3GTe+3FFh/pejb/wNT5tOXZGbG2y2i7gFLspgzsxCKbAOnPvJboBy2qnCPsfQG7D4zYEoo7HhetE6zWIlNCB700wFXIJhXUFXHFB/3R765BlPPDqYYp2AzcQTwa4tevOmC5eHZfYKqRF6yQB243h05us2QC39EVF0GS0C69Eq88ibm9uj0rIKAYRPGdckwmhhFsnt46NEAHQqcYUEM/P8NNV5nYdddANV/WrkvPhgFwBFVd/0/2lfVK/B1pMNOywEnUneiM3/jx2xfFhONPFQ4iVQvEnQzEb8zrEh0rNsAt82dZEyn6cg4tNmhZXPzj9I/Qhyedqha6Ei87OVRXkPiRibtf48uOhnHSHtyL3rtgUX+TSv9le1WO4AJZ42m1SNGO26E7NMxW2mmm/H0rX88fx9UNBQJSEORx8jn8xB4k4ehIvRlWMgQrR1PBuu8Budzn X-Microsoft-Antispam-Message-Info: zPVwwooKtO37ktWVu1d+P/KtxwEFHiyqqh5nLza9ixAdPAN9HKcuJ4FkT9F60oHRfkzAfQs3HNiV47SxvnFewuVDfnp05GRMItQtaXx4uUSjhusmuTWG65avTqydrB38fGFDu0trFGC6ZJyBBx6OT2qZxGv8UGlqavC+KGemkEx1TXrM8qb7hD1KOR3o2NLA6zyk2uS/qOrogEFuYrmlnxRqrhSrqBrng+XZyTdoM2Oc4chLI1CFmOqmchq6CpsmqbEori0Wx+EAqXBo5kD0nwmZQ2/GF9mkQPo+UxsMA1cnAJfUFH6TfLBGxjTkN/wszeew/F/+V6UmBQLttYTF8RhwhBtWYKHhbwlGkoa0mKo= X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1857; 6:5grLGELAa5jGVhCqI3WClzIG02eN65g1g+Kp3SP1ZJISelPaLKrpvzAMeF6EoN/sXrV0oAzxPEb4mrQjy083ZhceHUSjZmjx+wtudnC1LYZX9Fn4NLr7PuaRnUixaOmOmDbv29cmPoD7g9pL7Jzvx17F4vo3P0vTntZ71AXBSnQBF1LKb6GPukohtLOkJPt24JlHW1VzhajY6sr9tbnpMWqCPrkT7f63Ym/t7jWnK1Jjvz5ox8EcVthmVjEuCylya3x0dumapfLxqWTQXzXcFQ/FvNn3AQMyWndUb9eBxwWvBXoRjjemZjrkbiimgOlFJK4g/ln6iqvVFbyHdRTlpkOJSK3cVfs0rMtuoFUqsbLaeS4Y8VvM3XMbqqQ1Fjm7B6Knnr6CdwjPe3InnAWeN3umRaHFJuJ/uNxzbOsDb3bEzi//D/GZBJTfJHwEUQLxTsbLGAw93MTdu7hR2vcKkA==; 5:aglzmlE4nUerSC4cQO0dauC8yi9v2SKr29OzoSUP7u+wF3/K+6hczQv7EM/Dpf8mJ7b5CQgMhJin6WN0acecIGYyZKqvcHiT8VFE9yqykFQfOARutX1KlPoiDpfAQHK56/7mCue7ytKfhtC5VAYfVqxWtBivuo5ufl+1tjLMlK8=; 7:JzK8msT6Wo2dkllVuWm5G+QhooeXPbj9DsFnvghat/kLO/rtFsM9fcOaLMYRZ55GrGCOBzek1PXQly4EmdMa9fDnk0kg8TuxE7HqJSRMc72rLhLBk9Oc8MhnQjgud5u+zFewkuujVnwsJ4jP4BJmv/9S03RvmMunX4eBDIIuBwCzO+5SsYLQgcDLLL6SqAQD/45IPX6mTAkSGOoTgncTOyfNucswggdRUIPZKe5QGiSMGdLSGJrf3Y+01qMQ+z9A SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB1857; 20:CHtFnqTth651heqenkI3Bty1XbTSSFbEbh9cF2UkYA1vS6K8mUOPZKYJGxZysNhjPF1S5xvo0C0d6d/6/shhpeSROWp3/1oXYFkRaVhjMCJgJpcgHmQ0/cubV5nDg5rY77kU1eN5naThkkvrlxQIKqy2Zr6zL2bsQW1vX+Nmsow= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2018 06:31:49.0020 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c4f46f1-8747-480d-566c-08d6300c63c3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB1857 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH 3/3] ASoC: pcm3168a: add I2S/Left_J TDM support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto pcm3168a is supporting TDM on I2S/Left_J, but there is no settings for it. This patch add it. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/pcm3168a.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index f0e2b88..63aa025 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -33,6 +33,8 @@ #define PCM3168A_FMT_RIGHT_J_16 0x3 #define PCM3168A_FMT_DSP_A 0x4 #define PCM3168A_FMT_DSP_B 0x5 +#define PCM3168A_FMT_I2S_TDM 0x6 +#define PCM3168A_FMT_LEFT_J_TDM 0x7 #define PCM3168A_FMT_DSP_MASK 0x4 #define PCM3168A_NUM_SUPPLIES 6 @@ -401,9 +403,11 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream, bool tx, master_mode; u32 val, mask, shift, reg; unsigned int rate, fmt, ratio, max_ratio; + unsigned int chan; int i, min_frame_size; rate = params_rate(params); + chan = params_channels(params); ratio = pcm3168a->sysclk / rate; @@ -456,6 +460,21 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } + /* for TDM */ + if (chan > 2) { + switch (fmt) { + case PCM3168A_FMT_I2S: + fmt = PCM3168A_FMT_I2S_TDM; + break; + case PCM3168A_FMT_LEFT_J: + fmt = PCM3168A_FMT_LEFT_J_TDM; + break; + default: + dev_err(component->dev, "TDM is supported under I2S/Left_J only\n"); + return -EINVAL; + } + } + if (master_mode) val = ((i + 1) << shift); else