From patchwork Fri Jun 12 19:30:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11602237 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 576D26A2 for ; Fri, 12 Jun 2020 19:31:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F78A20836 for ; Fri, 12 Jun 2020 19:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WzECtsn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F78A20836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 101A86E193; Fri, 12 Jun 2020 19:31:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C1496E193 for ; Fri, 12 Jun 2020 19:30:59 +0000 (UTC) Received: by mail-pj1-x1043.google.com with SMTP id b7so4489492pju.0 for ; Fri, 12 Jun 2020 12:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGMzjkhMjOHffrm0MUbn2WAGnae39l2+rYHo11+y6eM=; b=WzECtsn5cH0OoinAmzjjiwAaORsCILg5BjcE2ScC3ercyJwv5IqLLyN+nSVp3brQOl KJmIA9SVjkYNpI1ACF38HqARcQKD1PUgmbK1dFdFm1SFZDjT4vfQAVMQoQ9yKTb54ukO l8pJ8POvMkV9L7YxvMLwGk1P/1/eR3yj2X9ko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IGMzjkhMjOHffrm0MUbn2WAGnae39l2+rYHo11+y6eM=; b=nmxFJh+ENDLcFOxa6Hooqys/H9XxUj+4UPLRxMCqMJDsOXzDzVUF4D5y90J2f8SbvP ZiAuORNP7j5PYjd48IjlEMAzsBEy06ZHGQ5ZZoSJ4fdjmJnE/RJ1IzpiV3kdto3N1Tc0 umd84xnEaurctMYtxygqgZ6pJGzlEChmb2bonNvnELcleER25M5S0O9oE7DSN7kPWhU6 TZX72rJkyhLIcey8QshnXu/Qq7/dzonJ/yQQSKfQcmrE5g+KwQjP5HxTI+1G9AFI5E4D cMVBFI8p7r02LlBAXgJoDYxc9Goz/495t1XdgtAm49ZH2dRim89GFocaT4CE2S0SdqTw r3Ww== X-Gm-Message-State: AOAM5308xw97yjzalYXLNrrlPNsR2hylr/xg7e28TWDyRpIcM3jHSLdE juEZD8jcibKAFufuc3c3phkMCg== X-Google-Smtp-Source: ABdhPJxQdLqwY7OobVFFXwfOjXMluaqP9V1tFz7TRtrtpqculJa7afZWCLVRCtERdeCqb/8V9M2KtA== X-Received: by 2002:a17:90a:6483:: with SMTP id h3mr390383pjj.229.1591990258822; Fri, 12 Jun 2020 12:30:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n69sm6966934pjc.25.2020.06.12.12.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:30:58 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO Date: Fri, 12 Jun 2020 12:30:47 -0700 Message-Id: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , kernel test robot , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, Laurent Pinchart , swboyd@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The kernel test robot noted that if "OF" is defined (which is needed to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get compile failures because some of the members that we access in "struct gpio_chip" are only defined "#if defined(CONFIG_OF_GPIO)". All the GPIO bits in the driver are all nicely separated out. We'll guard them with the same "#if defined" that the header has and add a little stub function if OF_GPIO is not defined. Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") Reported-by: kernel test robot Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v2: None drivers/gpu/drm/bridge/ti-sn65dsi86.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 2240e9973178..6fa7e10b31af 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -151,8 +151,10 @@ struct ti_sn_bridge { u8 ln_assign; u8 ln_polrs; +#if defined(CONFIG_OF_GPIO) struct gpio_chip gchip; DECLARE_BITMAP(gchip_output, SN_NUM_GPIOS); +#endif }; static const struct regmap_range ti_sn_bridge_volatile_ranges[] = { @@ -925,6 +927,8 @@ static int ti_sn_bridge_parse_dsi_host(struct ti_sn_bridge *pdata) return 0; } +#if defined(CONFIG_OF_GPIO) + static int tn_sn_bridge_of_xlate(struct gpio_chip *chip, const struct of_phandle_args *gpiospec, u32 *flags) @@ -1092,6 +1096,15 @@ static int ti_sn_setup_gpio_controller(struct ti_sn_bridge *pdata) return ret; } +#else + +static inline int ti_sn_setup_gpio_controller(struct ti_sn_bridge *pdata) +{ + return 0; +} + +#endif + static void ti_sn_bridge_parse_lanes(struct ti_sn_bridge *pdata, struct device_node *np) { From patchwork Fri Jun 12 19:30:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11602239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 929D990 for ; Fri, 12 Jun 2020 19:31:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70BF12063A for ; Fri, 12 Jun 2020 19:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="X6YqLiCq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70BF12063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 577576E1A3; Fri, 12 Jun 2020 19:31:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FEB56E193 for ; Fri, 12 Jun 2020 19:31:00 +0000 (UTC) Received: by mail-pj1-x1042.google.com with SMTP id s88so4261028pjb.5 for ; Fri, 12 Jun 2020 12:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H4xJr5jHCVeAEcRLOFPcb5oZvkfyMNzLWQX/m/ptM6s=; b=X6YqLiCqFgiZc0NhYCB30C7wLDMPbYQ1KFjBFPpBQ0r5OO/xXc4YZgE7MHqjKarp0U N7IeiQ6yhOUF/eWk1pWxJP+Ntzl8V3b4Z0XSxXCfNy9nHAWpTzEmPeCuvx+Eb8c077Cn 0kRaRMRetUI5j6Lk5LSttJVz2vl8Qr+gmey2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H4xJr5jHCVeAEcRLOFPcb5oZvkfyMNzLWQX/m/ptM6s=; b=ZUjpRfZIFfZ77N34NgPY4aHC8WiMCB2LvmBQ4tNA808l5z0zqlTj5UhXEliS5v8SbE sjjgMuZSA4kehZJNrCjDPKwPIUmgfkgijMo0ADAYRtEe6xsqZ2/JOZlDnKNgq5nP0d8S f49AjkaBw5jNurAZIdLrfgzRrpocQijzc8xE/ks3ACzUwx1zV42/30VHy8GfAZ9WYdhc PoVpXvozPtRms6JReyUxcxR5QTd+RPLkr2aMHkvWZi980D7BgagaPZqWk48QqnbxpCyL jLBY+v0yLumv8brWF1Pic1tJjzGBERJEVinvvPvTOzk79bgZE2JTqWm5x9VRgDAowfJf Cxuw== X-Gm-Message-State: AOAM530HopY4yBCALDLFP1PUMjYEOWpdSTI+ha3o+awBnVEziiupGHQ/ nL8uJ5nFbn8D1fFip59XkqDhzw== X-Google-Smtp-Source: ABdhPJxQ5lcbMl7V73ZgbUO6jfK/4rDdndHu4h+o3zCtnTJevCht7YBpu0fJXUZdrdAoteLmZSaYQQ== X-Received: by 2002:a17:90a:de95:: with SMTP id n21mr458867pjv.100.1591990259869; Fri, 12 Jun 2020 12:30:59 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n69sm6966934pjc.25.2020.06.12.12.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:30:59 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH v2 2/4] drm/bridge: ti-sn65dsi86: Don't use kernel-doc comment for local array Date: Fri, 12 Jun 2020 12:30:48 -0700 Message-Id: <20200612123003.v2.2.If3807e4ebf7f0440f64c3069edcfac9a70171940@changeid> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog In-Reply-To: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, Laurent Pinchart , swboyd@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When building we were getting an error: warning: cannot understand function prototype: 'const unsigned int ti_sn_bridge_dp_rate_lut[] = ' Arrays aren't supposed to be marked with "/**" kerneldoc comments. Fix. Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v2: None drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 6fa7e10b31af..fca7c2a0bcf9 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -504,7 +504,7 @@ static unsigned int ti_sn_bridge_get_bpp(struct ti_sn_bridge *pdata) return 24; } -/** +/* * LUT index corresponds to register value and * LUT values corresponds to dp data rate supported * by the bridge in Mbps unit. From patchwork Fri Jun 12 19:30:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11602241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6DFD990 for ; Fri, 12 Jun 2020 19:31:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B6032063A for ; Fri, 12 Jun 2020 19:31:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="G2IlTYMX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B6032063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F18786E1AA; Fri, 12 Jun 2020 19:31:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 888416E1AA for ; Fri, 12 Jun 2020 19:31:01 +0000 (UTC) Received: by mail-pg1-x544.google.com with SMTP id j6so652973pgh.4 for ; Fri, 12 Jun 2020 12:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b/GfnNC8pXVMnpUdumvg6vaJ4jiyTtawkJau7ukqTZo=; b=G2IlTYMXhCkQR4ELMO19WmWfDfP34LAIVdX40D7bNRrYfyXYvFKHC7Cdn77RuP82R4 2ji01psEasSHfT1/aQ/yTtES/Sj6YmBf669RUbjoQtq2VMdbkNQgsRnJr3n07tbZ+BsE 0QYNW/8dm940Jgz8VVbIfmRORs8S/oDxamvWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b/GfnNC8pXVMnpUdumvg6vaJ4jiyTtawkJau7ukqTZo=; b=q9rcqG1CktHALXAewJy7ME6T8RWq8RpcfoTxvBKU3Xgkujje6YnGB48xPxlknxxFUG EQziZuheTBic2+YUO01hslALIU0j5FHMQG5+6Fz+/W7DEt+XQJBw8KbmykvxoM9EL7YK gXr5p3d19GgTkLY8gcLZ+y4//gX5slfy3A+cLKyw8DylkdvlVI1s4epODfWxUQ/+c5qD FDT/uDW7S4On7OGb4hmWLxXNKs23NNeAmZuHdVScNHc2U4sqQTTFQB54Fz3oCAeowU8V xZ0AwyaOa33GMX37ei+snfdGrdz2pC/nOHD7plxo87RhbHrITmsIeKmw8gjFXsde5+xU YF1g== X-Gm-Message-State: AOAM533+HrFgQFPIoPdI+04YcZkHi46wLK22eLTorYSgvlzV9l4N8ZHw hBTHwPFOOXuHjAxhoRHk0pfCHg== X-Google-Smtp-Source: ABdhPJyfydS6pnh63FC5FkWpfhhla7sdsI5aEnFHl7FPTKIrMMSQFO2xsBGnY2nj7D6x9bPXeGIkKQ== X-Received: by 2002:aa7:9052:: with SMTP id n18mr13776479pfo.319.1591990260998; Fri, 12 Jun 2020 12:31:00 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n69sm6966934pjc.25.2020.06.12.12.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:31:00 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Fix kernel-doc typo ln_polr => ln_polrs Date: Fri, 12 Jun 2020 12:30:49 -0700 Message-Id: <20200612123003.v2.3.Ib616e311c48cc64b2cef11bd54d4a9cedc874bb1@changeid> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog In-Reply-To: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, Laurent Pinchart , swboyd@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This fixes a kernel doc warning due to a typo: warning: Function parameter or member 'ln_polrs' not described in 'ti_sn_bridge' Fixes: 5bebaeadb30e ("drm/bridge: ti-sn65dsi86: Implement lane reordering + polarity") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v2: None drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index fca7c2a0bcf9..1080e4f9df96 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -122,7 +122,7 @@ * @supplies: Data for bulk enabling/disabling our regulators. * @dp_lanes: Count of dp_lanes we're using. * @ln_assign: Value to program to the LN_ASSIGN register. - * @ln_polr: Value for the 4-bit LN_POLRS field of SN_ENH_FRAME_REG. + * @ln_polrs: Value for the 4-bit LN_POLRS field of SN_ENH_FRAME_REG. * * @gchip: If we expose our GPIOs, this is used. * @gchip_output: A cache of whether we've set GPIOs to output. This From patchwork Fri Jun 12 19:30:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11602243 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 663D490 for ; Fri, 12 Jun 2020 19:31:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E77206D7 for ; Fri, 12 Jun 2020 19:31:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NXzPbPlf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E77206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84D796E1B3; Fri, 12 Jun 2020 19:31:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C6FE6E1B6 for ; Fri, 12 Jun 2020 19:31:02 +0000 (UTC) Received: by mail-pl1-x644.google.com with SMTP id t7so4149648plr.0 for ; Fri, 12 Jun 2020 12:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/JLcL+eXskupadvzRPr0KYY4jNSs8dr6KFn31X50BKA=; b=NXzPbPlf441w11iFHGJ9W+Y5ontYOUwpkp86hqoqbgJR2zRFsLy6IrP6O+bPWiagdK qiSa5hgegSw3yVsSvyzmUrpNdQUnheUeuSEjk17lEob7A95e3T0oJdW1NpS0aaPSyQzE Qox/wJm24EvNxtf14X0Upc72JOgNWu4E4/u/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/JLcL+eXskupadvzRPr0KYY4jNSs8dr6KFn31X50BKA=; b=rlNTfgP/F/w3Mrm91YJxJswB/tmQu86Svto1iEferyZeD5plSB2rUunSlw+YiSaPYw UkFZT1KWeapW+N6p3HpmuLWrpFRCuU6zqWOaPxQDCZ89bVsBNUZrDqxGRJZYc0irlGyp W4IB5YMsp9UnRWI/BJ9SJ/Qny8W+OZvQklq305i0tySciMKwsAO+PkiqbdO+LYQ5GGWK 3SpApan6ojv7V3Wjne+3jc5v+CQEZPhgypne+6bRhDsVgbxIU4bXplhlW+wAhU7aG8vr rx+1tPdllZ37U8QCG2m2ZXJgqU9imkU4XqMxOXPkXlZGBbjC08c0zLa25VU5ut4E5ZYK tpGw== X-Gm-Message-State: AOAM530ilXWl/GjIeBwqI4UTRHecODK4UqVsaP5lhYnQ3NnCz6JNY+yO PcMfnmyLAU0kmA2kq9wlUuC1vQ== X-Google-Smtp-Source: ABdhPJzOVu00ZU0TwmAIoVI0f6eQMllaYaWPr850VAglM8s0JUILuRPjAG0K84Sfcu8Qs1SEo2VMNA== X-Received: by 2002:a17:902:507:: with SMTP id 7mr12495042plf.115.1591990262080; Fri, 12 Jun 2020 12:31:02 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id n69sm6966934pjc.25.2020.06.12.12.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:31:01 -0700 (PDT) From: Douglas Anderson To: a.hajda@samsung.com, narmstrong@baylibre.com, sam@ravnborg.org Subject: [PATCH v2 4/4] drm/bridge: ti-sn65dsi86: Check the regmap return value when setting a GPIO Date: Fri, 12 Jun 2020 12:30:50 -0700 Message-Id: <20200612123003.v2.4.Ia4376fd88cdc6e8f8b43c65548458305f82f1d61@changeid> X-Mailer: git-send-email 2.27.0.290.gba653c62da-goog In-Reply-To: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> References: <20200612123003.v2.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Douglas Anderson , Jonas Karlman , David Airlie , linux-kernel@vger.kernel.org, spanda@codeaurora.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, Laurent Pinchart , swboyd@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The ti_sn_bridge_gpio_set() got the return value of regmap_update_bits() but didn't check it. The function can't return an error value, but we should at least print a warning if it didn't work. This fixes a compiler warning about setting "ret" but not using it. Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v2: - GPIO %u because it's unsigned. drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 1080e4f9df96..bd3eb0a09732 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -999,6 +999,9 @@ static void ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset, ret = regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG, BIT(SN_GPIO_OUTPUT_SHIFT + offset), val << (SN_GPIO_OUTPUT_SHIFT + offset)); + if (ret) + dev_warn(pdata->dev, + "Failed to set bridge GPIO %u: %d\n", offset, ret); } static int ti_sn_bridge_gpio_direction_input(struct gpio_chip *chip,