From patchwork Mon Oct 15 02:32:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Schmitz X-Patchwork-Id: 10641037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA95F17E3 for ; Mon, 15 Oct 2018 02:32:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEDC0295AF for ; Mon, 15 Oct 2018 02:32:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C26B9295B5; Mon, 15 Oct 2018 02:32:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CF0C295B1 for ; Mon, 15 Oct 2018 02:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbeJOKPo (ORCPT ); Mon, 15 Oct 2018 06:15:44 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44519 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbeJOKPo (ORCPT ); Mon, 15 Oct 2018 06:15:44 -0400 Received: by mail-pl1-f195.google.com with SMTP id p25-v6so8504496pli.11; Sun, 14 Oct 2018 19:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=W9zibn5ZPAe2eR5i6xKHLTY8NrpASUJ4VCryxn+G8tE=; b=MRN5AJNoe+EciY9swvrrooylKYHm23srOeRVu0RSXVptVWBNPuSAoKFNf1die8Q79H FcztFtDoj3vU16CR/q4Xk9f5siRHSmo2HSxeXJHkZkHzAOGau/QR/afVsuqFLHUYNPlD mLowrVantoLPPQFj8wQo2UZ7HFVrzR6U0htHE+MT5S5SfDOlpuHZUHa5ROSr/1heWUBA JGbirxRJqoVS3UspF7iyDLoQzhB471A6DuMQzI1nnwYI9SETW/7+h9MGzTgruuyRGg+O rmVLZCsVxb9yP2ky1+4mXwW7TiVkXSroaxvbqjLNXslu5tsPXd5SAKMsQlEsAFgAJ8Sz 0NeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=W9zibn5ZPAe2eR5i6xKHLTY8NrpASUJ4VCryxn+G8tE=; b=LH90+fVE1mn+dwgg+96EzUbN6+MFgMDvXgWiLwQEPaJNcIMRyehIbZAtJzDlLXcOjQ CVNJvMCQbOFKy4+rIeNNAjVsbIvS7d9ZsBIb9HwudgDHg7Q9Z4d8UeaOhzKl6qYJ62Nw UAz7fZQLW54KFr6Hc6qTUjtWu9wbDukyo5Gi2PJdbzDnebHfzqG44NC1d0k6vGh89dVn tklxdlpIdU7xEq1vc2Bs9ba/n/3rrLtytYa/2XnWRQA4RU/X9wowiT+VGCOcqKwiW/ZE aFvj0Iq0ucLcXupc1g+bQYd5HdVt4cLTJEzCEGXcRP7eDvJN4tsZYQSLy/UuGtfCNXk9 QERA== X-Gm-Message-State: ABuFfohD89C7bxNhOR7+5g94ZTlowtJYo7G+ejgW0VspEo7ydJDDsbtL p40Sl1wzcsrJGBXOA9Wo9WU= X-Google-Smtp-Source: ACcGV61GsdDlPlzO59FU1XuzYNiuzSYOfYxjqKziNslkxiLQiBqOdcbcXC2UKy9ISa6eiJ9s9h8seQ== X-Received: by 2002:a17:902:44:: with SMTP id 62-v6mr15335695pla.181.1539570755072; Sun, 14 Oct 2018 19:32:35 -0700 (PDT) Received: from xplor.waratah.dyndns.org (122-62-216-69-adsl.sparkbb.co.nz. [122.62.216.69]) by smtp.gmail.com with ESMTPSA id i21-v6sm11297161pgj.55.2018.10.14.19.32.33 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 14 Oct 2018 19:32:33 -0700 (PDT) Received: by xplor.waratah.dyndns.org (Postfix, from userid 1000) id 40A93360084; Mon, 15 Oct 2018 15:32:29 +1300 (NZDT) From: Michael Schmitz To: linux-block@vger.kernel.org, axboe@kernel.dk Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, Michael Schmitz Subject: [PATCH v7 1/2] block: fix signed int overflow in Amiga partition support Date: Mon, 15 Oct 2018 15:32:26 +1300 Message-Id: <1539570747-19906-2-git-send-email-schmitzmic@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1539570747-19906-1-git-send-email-schmitzmic@gmail.com> References: <1539570747-19906-1-git-send-email-schmitzmic@gmail.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Amiga partition parser module uses signed int for partition sector address and count, which will overflow for disks larger than 1 TB. Use sector_t as type for sector address and size to allow using disks up to 2 TB without LBD support, and disks larger than 2 TB with LBD. This bug was reported originally in 2012, and the fix was created by the RDB author, Joanne Dow . A patch had been discussed and reviewed on linux-m68k at that time but never officially submitted. This patch differs from Joanne's patch only in its use of sector_t instead of unsigned int. No checking for overflows is done (see patch 2 of this series for that). Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=43511 Reported-by: Martin Steigerwald Message-ID: <201206192146.09327.Martin@lichtvoll.de> Signed-off-by: Michael Schmitz Tested-by: Martin Steigerwald Reviewed-by: Geert Uytterhoeven --- Changes from v3: - split off change of sector address type as quick fix. - cast to sector_t in sector address calculations. - move overflow checking to separate patch for more thorough review. Changes from v4: Andreas Schwab: - correct cast to sector_t in sector address calculations --- block/partitions/amiga.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/partitions/amiga.c b/block/partitions/amiga.c index 5609366..7ea9540 100644 --- a/block/partitions/amiga.c +++ b/block/partitions/amiga.c @@ -32,7 +32,8 @@ int amiga_partition(struct parsed_partitions *state) unsigned char *data; struct RigidDiskBlock *rdb; struct PartitionBlock *pb; - int start_sect, nr_sects, blk, part, res = 0; + sector_t start_sect, nr_sects; + int blk, part, res = 0; int blksize = 1; /* Multiplier for disk block size */ int slot = 1; char b[BDEVNAME_SIZE]; @@ -100,14 +101,14 @@ int amiga_partition(struct parsed_partitions *state) /* Tell Kernel about it */ - nr_sects = (be32_to_cpu(pb->pb_Environment[10]) + 1 - - be32_to_cpu(pb->pb_Environment[9])) * + nr_sects = ((sector_t) be32_to_cpu(pb->pb_Environment[10]) + + 1 - be32_to_cpu(pb->pb_Environment[9])) * be32_to_cpu(pb->pb_Environment[3]) * be32_to_cpu(pb->pb_Environment[5]) * blksize; if (!nr_sects) continue; - start_sect = be32_to_cpu(pb->pb_Environment[9]) * + start_sect = (sector_t) be32_to_cpu(pb->pb_Environment[9]) * be32_to_cpu(pb->pb_Environment[3]) * be32_to_cpu(pb->pb_Environment[5]) * blksize; From patchwork Mon Oct 15 02:32:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Schmitz X-Patchwork-Id: 10641039 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBCED14BD for ; Mon, 15 Oct 2018 02:32:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AEC02295AF for ; Mon, 15 Oct 2018 02:32:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A369F295B1; Mon, 15 Oct 2018 02:32:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D87A8295B7 for ; Mon, 15 Oct 2018 02:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbeJOKPp (ORCPT ); Mon, 15 Oct 2018 06:15:45 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44472 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbeJOKPp (ORCPT ); Mon, 15 Oct 2018 06:15:45 -0400 Received: by mail-pg1-f193.google.com with SMTP id g2-v6so8399468pgu.11; Sun, 14 Oct 2018 19:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GPX19GmA88wQXSA9hlnK6ZZTNeOWTwM5QZpmclJQ2Gs=; b=VOdNmXtM6VhVlj2Mk16mMpN/raMnwMamvOhC/B+3xyT8zqpqW9wGLsaQFQG3bfrZuX TmmIi+TyXD5HfcZmfxFYqVJ03X14UgNptO2mEqFgIpfEOWSBlq4lM//XVbEvtb8RKLCO K/TGA4uVJDsL0PDTlGxdrvUG12eWcoxcz9ZvoZTNpZCOREp0dKzgx3gmywTGUU9FLvgP Kk65NJ2eFHuJIlmma4IA4meBsOdGRFL+Y6rtxwiPN6L8dRb/wIZEUewis64MKaeLLkjM 0nLgX0sOzgXs7GrK1owDRLz2+Vb3wa+0uRviZqLPgX0GcmjtPQw503/84s0ppHWglvaE xfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GPX19GmA88wQXSA9hlnK6ZZTNeOWTwM5QZpmclJQ2Gs=; b=oVpfMqHPO3UVlMjwhE73ibJuULM8OMZr8b90VvoZ4SXEdI2WiDq6ST2sQAIwmb0ZjX GVxNLupmegd28xiLofR9CaT4axR0qLMPbP/qwgfgAB0/X6oO1G3azkUxLEsBK92u8t69 ctTTp9eRxZltAuKaW/3DcsNOWrrMdh9mJ89gJGM6CQfx0B+7HeZFLQkQhvXuIANTIlmL UhvK2YcOSUNv2M/QRY10Oovxd/CiljPJL9tMOeKzZN/KAUpvzUFbrEXC0wgh9xpgMCCx gDPZTEdmgXrgtF+2TjtqMgz1fR56EJ7BCEXo3eYR5qBbjxDQj92i6lQNV0sm/l2VMjbh eeTg== X-Gm-Message-State: ABuFfoh+DqSwStTxmyf+diI40EtTfEMFqFdDWsexYokqheeI/nE+RZ6h elFAgArtt3aUlc4qfQeMYeMLaBp4 X-Google-Smtp-Source: ACcGV60CD6qiKE8IIwp+DdR1SP4JNRGIOAhpj1Kd1LF/ViMQUAD4+OlddQowHJpTDlg3m2xhDZEBPg== X-Received: by 2002:a62:60c1:: with SMTP id u184-v6mr15766706pfb.114.1539570754569; Sun, 14 Oct 2018 19:32:34 -0700 (PDT) Received: from xplor.waratah.dyndns.org (122-62-216-69-adsl.sparkbb.co.nz. [122.62.216.69]) by smtp.gmail.com with ESMTPSA id h6-v6sm11260684pgn.84.2018.10.14.19.32.32 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 14 Oct 2018 19:32:33 -0700 (PDT) Received: by xplor.waratah.dyndns.org (Postfix, from userid 1000) id 28083360079; Mon, 15 Oct 2018 15:32:29 +1300 (NZDT) From: Michael Schmitz To: linux-block@vger.kernel.org, axboe@kernel.dk Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, Michael Schmitz Subject: [PATCH v7 2/2] block: add overflow checks for Amiga partition support Date: Mon, 15 Oct 2018 15:32:27 +1300 Message-Id: <1539570747-19906-3-git-send-email-schmitzmic@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1539570747-19906-1-git-send-email-schmitzmic@gmail.com> References: <1539570747-19906-1-git-send-email-schmitzmic@gmail.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Amiga partition parser module uses signed int for partition sector address and count, which will overflow for disks larger than 1 TB. Use u64 as type for sector address and size to allow using disks up to 2 TB without LBD support, and disks larger than 2 TB with LBD. The RBD format allows to specify disk sizes up to 2^128 bytes (though native OS limitations reduce this somewhat, to max 2^68 bytes), so check for u64 overflow carefully to protect against overflowing sector_t. Bail out if sector addresses overflow 32 bits on kernels without LBD support. This bug was reported originally in 2012, and the fix was created by the RDB author, Joanne Dow . A patch had been discussed and reviewed on linux-m68k at that time but never officially submitted (now resubmitted as separate patch). This patch adds additional error checking and warning messages. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=43511 Reported-by: Martin Steigerwald Message-ID: <201206192146.09327.Martin@lichtvoll.de> Signed-off-by: Michael Schmitz Reviewed-by: Geert Uytterhoeven --- Changes from RFC: - use u64 instead of sector_t, since that may be u32 without LBD support - check multiplication overflows each step - 3 u32 values may exceed u64! - warn against use on AmigaDOS if partition data overflow u32 sector count. - warn if partition CylBlocks larger than what's stored in the RDSK header. - bail out if we were to overflow sector_t (32 or 64 bit). Changes from v1: Kars de Jong: - use defines for magic offsets in DosEnvec struct Geert Uytterhoeven: - use u64 cast for multiplications of u32 numbers - use array3_size for overflow checks - change pr_err to pr_warn - discontinue use of pr_cont - reword log messages - drop redundant nr_sects overflow test - warn against 32 bit overflow for each affected partition - skip partitions that overflow sector_t size instead of aborting scan Changes from v2: - further trim 32 bit overflow test - correct duplicate types.h inclusion introduced in v2 Changes from v3: - split off sector address type fix for independent review - change blksize to unsigned - use check_mul_overflow() instead of array3_size() - rewrite checks to avoid 64 bit divisions in check_mul_overflow() Changes from v5: Geert Uytterhoeven: - correct ineffective u64 cast to avoid 32 bit mult. overflow - fix mult. overflow in partition block address calculation Changes from v6: Geert Uytterhoeven: - don't fail hard on partition block address overflow --- block/partitions/amiga.c | 111 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 89 insertions(+), 22 deletions(-) diff --git a/block/partitions/amiga.c b/block/partitions/amiga.c index 7ea9540..d1b1535 100644 --- a/block/partitions/amiga.c +++ b/block/partitions/amiga.c @@ -11,11 +11,19 @@ #define pr_fmt(fmt) fmt #include +#include +#include #include #include "check.h" #include "amiga.h" +/* magic offsets in partition DosEnvVec */ +#define NR_HD 3 +#define NR_SECT 5 +#define LO_CYL 9 +#define HI_CYL 10 + static __inline__ u32 checksum_block(__be32 *m, int size) { @@ -32,9 +40,12 @@ int amiga_partition(struct parsed_partitions *state) unsigned char *data; struct RigidDiskBlock *rdb; struct PartitionBlock *pb; - sector_t start_sect, nr_sects; - int blk, part, res = 0; - int blksize = 1; /* Multiplier for disk block size */ + u64 start_sect, nr_sects; + sector_t blk, end_sect; + u32 cylblk; /* rdb_CylBlocks = nr_heads*sect_per_track */ + u32 nr_hd, nr_sect, lo_cyl, hi_cyl; + int part, res = 0; + unsigned int blksize = 1; /* Multiplier for disk block size */ int slot = 1; char b[BDEVNAME_SIZE]; @@ -44,8 +55,8 @@ int amiga_partition(struct parsed_partitions *state) data = read_part_sector(state, blk, §); if (!data) { if (warn_no_part) - pr_err("Dev %s: unable to read RDB block %d\n", - bdevname(state->bdev, b), blk); + pr_err("Dev %s: unable to read RDB block %llu\n", + bdevname(state->bdev, b), (u64) blk); res = -1; goto rdb_done; } @@ -61,13 +72,13 @@ int amiga_partition(struct parsed_partitions *state) *(__be32 *)(data+0xdc) = 0; if (checksum_block((__be32 *)data, be32_to_cpu(rdb->rdb_SummedLongs) & 0x7F)==0) { - pr_err("Trashed word at 0xd0 in block %d ignored in checksum calculation\n", - blk); + pr_err("Trashed word at 0xd0 in block %llu ignored in checksum calculation\n", + (u64) blk); break; } - pr_err("Dev %s: RDB in block %d has bad checksum\n", - bdevname(state->bdev, b), blk); + pr_err("Dev %s: RDB in block %llu has bad checksum\n", + bdevname(state->bdev, b), (u64) blk); } /* blksize is blocks per 512 byte standard block */ @@ -83,12 +94,17 @@ int amiga_partition(struct parsed_partitions *state) blk = be32_to_cpu(rdb->rdb_PartitionList); put_dev_sector(sect); for (part = 1; blk>0 && part<=16; part++, put_dev_sector(sect)) { - blk *= blksize; /* Read in terms partition table understands */ + /* Read in terms partition table understands */ + if (check_mul_overflow(blk, (sector_t) blksize, &blk)) { + pr_err("Dev %s: overflow calculating partition block %llu! Skipping partitions %u and beyond\n", + bdevname(state->bdev, b), (u64) blk, part); + break; + } data = read_part_sector(state, blk, §); if (!data) { if (warn_no_part) - pr_err("Dev %s: unable to read partition block %d\n", - bdevname(state->bdev, b), blk); + pr_err("Dev %s: unable to read partition block %llu\n", + bdevname(state->bdev, b), (u64) blk); res = -1; goto rdb_done; } @@ -99,19 +115,70 @@ int amiga_partition(struct parsed_partitions *state) if (checksum_block((__be32 *)pb, be32_to_cpu(pb->pb_SummedLongs) & 0x7F) != 0 ) continue; - /* Tell Kernel about it */ + /* RDB gives us more than enough rope to hang ourselves with, + * many times over (2^128 bytes if all fields max out). + * Some careful checks are in order, so check for potential + * overflows. + * We are multiplying four 32 bit numbers to one sector_t! + */ + + nr_hd = be32_to_cpu(pb->pb_Environment[NR_HD]); + nr_sect = be32_to_cpu(pb->pb_Environment[NR_SECT]); + + /* CylBlocks is total number of blocks per cylinder */ + if (check_mul_overflow(nr_hd, nr_sect, &cylblk)) { + pr_err("Dev %s: heads*sects %u overflows u32, skipping partition!\n", + bdevname(state->bdev, b), cylblk); + continue; + } + + /* check for consistency with RDB defined CylBlocks */ + if (cylblk > be32_to_cpu(rdb->rdb_CylBlocks)) { + pr_warn("Dev %s: cylblk %u > rdb_CylBlocks %u!\n", + bdevname(state->bdev, b), cylblk, + be32_to_cpu(rdb->rdb_CylBlocks)); + } + + /* RDB allows for variable logical block size - + * normalize to 512 byte blocks and check result. + */ + + if (check_mul_overflow(cylblk, blksize, &cylblk)) { + pr_err("Dev %s: partition %u bytes per cyl. overflows u32, skipping partition!\n", + bdevname(state->bdev, b), part); + continue; + } + + /* Calculate partition start and end. Limit of 32 bit on cylblk + * guarantees no overflow occurs if LBD support is enabled. + */ + + lo_cyl = be32_to_cpu(pb->pb_Environment[LO_CYL]); + start_sect = ((u64) lo_cyl * cylblk); + + hi_cyl = be32_to_cpu(pb->pb_Environment[HI_CYL]); + nr_sects = (((u64) hi_cyl - lo_cyl + 1) * cylblk); - nr_sects = ((sector_t) be32_to_cpu(pb->pb_Environment[10]) - + 1 - be32_to_cpu(pb->pb_Environment[9])) * - be32_to_cpu(pb->pb_Environment[3]) * - be32_to_cpu(pb->pb_Environment[5]) * - blksize; if (!nr_sects) continue; - start_sect = (sector_t) be32_to_cpu(pb->pb_Environment[9]) * - be32_to_cpu(pb->pb_Environment[3]) * - be32_to_cpu(pb->pb_Environment[5]) * - blksize; + + /* Warn user if partition end overflows u32 (AmigaDOS limit) */ + + if ((start_sect + nr_sects) > UINT_MAX) { + pr_warn("Dev %s: partition %u (%llu-%llu) needs 64 bit device support!\n", + bdevname(state->bdev, b), part, + start_sect, start_sect + nr_sects); + } + + if (check_add_overflow(start_sect, nr_sects, &end_sect)) { + pr_err("Dev %s: partition %u (%llu-%llu) needs LBD device support, skipping partition!\n", + bdevname(state->bdev, b), part, + start_sect, (u64) end_sect); + continue; + } + + /* Tell Kernel about it */ + put_partition(state,slot++,start_sect,nr_sects); { /* Be even more informative to aid mounting */