From patchwork Wed Jun 24 01:31:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yilun X-Patchwork-Id: 11622193 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8E9FB912 for ; Wed, 24 Jun 2020 01:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80A8F2137B for ; Wed, 24 Jun 2020 01:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388458AbgFXBfh (ORCPT ); Tue, 23 Jun 2020 21:35:37 -0400 Received: from mga04.intel.com ([192.55.52.120]:13602 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388448AbgFXBfg (ORCPT ); Tue, 23 Jun 2020 21:35:36 -0400 IronPort-SDR: 7mj+gMmOjKxmuH1/E5DPvIwYpfPrLj4H6yW1Y3Ay0vlHaodb18ukhlB9P4MwJJyR7ZFao3LfPX ZOOtCV8nnrQA== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="141785220" X-IronPort-AV: E=Sophos;i="5.75,273,1589266800"; d="scan'208";a="141785220" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 18:35:35 -0700 IronPort-SDR: DcsF7zW1/WORb+WpgGTinT6fmS4ArXsY/BAVfiio1IYE+yOc7xg6Tujhf3XBIEegOFxR8xN4m6 b80IUK5lgTLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,273,1589266800"; d="scan'208";a="452459716" Received: from yilunxu-optiplex-7050.sh.intel.com ([10.239.159.141]) by orsmga005.jf.intel.com with ESMTP; 23 Jun 2020 18:35:33 -0700 From: Xu Yilun To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: trix@redhat.com, hao.wu@intel.com, matthew.gerlach@linux.intel.com, russell.h.weight@intel.com, yilun.xu@intel.com Subject: [PATCH 1/2] spi: altera: fix driver matching failure of the device ID "spi_altera" Date: Wed, 24 Jun 2020 09:31:25 +0800 Message-Id: <1592962286-25752-2-git-send-email-yilun.xu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592962286-25752-1-git-send-email-yilun.xu@intel.com> References: <1592962286-25752-1-git-send-email-yilun.xu@intel.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The driver is expected to support device ID "spi_altera" for MMIO accessed devices, device ID "subdev_spi_altera" for indirect accessed devices. But the platform bus will not try driver name match anymore if the platform driver has an id_table. So the "spi_altera" should also be added to id_table. Signed-off-by: Xu Yilun Signed-off-by: Russ Weight --- drivers/spi/spi-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c index d91c093..e272a04 100644 --- a/drivers/spi/spi-altera.c +++ b/drivers/spi/spi-altera.c @@ -352,7 +352,8 @@ MODULE_DEVICE_TABLE(of, altera_spi_match); #endif /* CONFIG_OF */ static const struct platform_device_id altera_spi_ids[] = { - { "subdev_spi_altera", ALTERA_SPI_TYPE_SUBDEV }, + { DRV_NAME, ALTERA_SPI_TYPE_UNKNOWN }, + { "subdev_spi_altera", ALTERA_SPI_TYPE_SUBDEV }, { } }; From patchwork Wed Jun 24 01:31:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Yilun X-Patchwork-Id: 11622191 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF3731731 for ; Wed, 24 Jun 2020 01:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D0372100A for ; Wed, 24 Jun 2020 01:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388502AbgFXBfn (ORCPT ); Tue, 23 Jun 2020 21:35:43 -0400 Received: from mga18.intel.com ([134.134.136.126]:59184 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388448AbgFXBfm (ORCPT ); Tue, 23 Jun 2020 21:35:42 -0400 IronPort-SDR: GzR4V8bjb/CtnH0HJvCxakcF5sztEtpYSPxjbG22ddU1WINR9T5fHRLxkzV1KmBgeYO4XEj/sX GjSyp+pHeFkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="131712149" X-IronPort-AV: E=Sophos;i="5.75,273,1589266800"; d="scan'208";a="131712149" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 18:35:41 -0700 IronPort-SDR: hkR805WW60D4MWqb1W4N7DTGGmvCrTzHKG0lrmxPalIZ2mFlolV784aLk5w76DivwmY2X710dD Un+CT7ewq5Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,273,1589266800"; d="scan'208";a="452459759" Received: from yilunxu-optiplex-7050.sh.intel.com ([10.239.159.141]) by orsmga005.jf.intel.com with ESMTP; 23 Jun 2020 18:35:39 -0700 From: Xu Yilun To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: trix@redhat.com, hao.wu@intel.com, matthew.gerlach@linux.intel.com, russell.h.weight@intel.com, yilun.xu@intel.com Subject: [PATCH 2/2] spi: altera: fix module autoload Date: Wed, 24 Jun 2020 09:31:26 +0800 Message-Id: <1592962286-25752-3-git-send-email-yilun.xu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592962286-25752-1-git-send-email-yilun.xu@intel.com> References: <1592962286-25752-1-git-send-email-yilun.xu@intel.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Add the MODULE_DEVICE_TABLE macro for the platform_device_id table to allow proper creation of modalias strings and fix autoloading module for this driver. Signed-off-by: Xu Yilun Signed-off-by: Russ Weight --- drivers/spi/spi-altera.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c index e272a04..809bfff 100644 --- a/drivers/spi/spi-altera.c +++ b/drivers/spi/spi-altera.c @@ -356,6 +356,7 @@ static const struct platform_device_id altera_spi_ids[] = { { "subdev_spi_altera", ALTERA_SPI_TYPE_SUBDEV }, { } }; +MODULE_DEVICE_TABLE(platform, altera_spi_ids); static struct platform_driver altera_spi_driver = { .probe = altera_spi_probe,