From patchwork Wed Jun 24 14:57:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623443 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 665BA90 for ; Wed, 24 Jun 2020 15:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49B1020781 for ; Wed, 24 Jun 2020 15:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PruqKI5r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404173AbgFXPEq (ORCPT ); Wed, 24 Jun 2020 11:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404337AbgFXPEo (ORCPT ); Wed, 24 Jun 2020 11:04:44 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A18F1C0613ED for ; Wed, 24 Jun 2020 08:04:43 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 17so2865100wmo.1 for ; Wed, 24 Jun 2020 08:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2m2sUpZpH0jbtcmYyVNBHchLvKZgU+7xWa4xsqTn03E=; b=PruqKI5rmzrEACi4Yw4FtuSd9KORHRlamVPBe3qqmkvNpFexwSdnG4SfgHltKStskh mva5w7RUtjo3uJjAaI+cNW5KHVSgyGm6ZovablsXX1U9W9K4v+NyOkE72Byf+dTKKkgE KOiaRHTpCyuRsf5J4jAvNqqmU5btGJgwguhNQ1BnWbgdjRr0p5D4jtr91lroWU6vR32F GCrDJDEiF8/7dfj64lTWImISFa4Np+pVFYTSpf4pdqvc65aSjeHo5ob/hmAWaljIMH3r IggB0GwSnJRl6TjfzWrKX7nxh1UouC0/BKxUinGbWcmXeU2MgDrLsAVtrnjkOC5zhHKr ZfEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2m2sUpZpH0jbtcmYyVNBHchLvKZgU+7xWa4xsqTn03E=; b=mA2BnUPkZo5SEupZ6KuNdD5IQquVOieKZdRPzsxNeEMairDPNXpa7AumfbiYd/SYvG GljfYs6C+pkw5w0bR0hWpuyb/XfoXloW7redFHK2TDO6S9PAX7guvjLILBk0V63bVf4c Zl389Kc/DJV5/1ixgEWKEh9AyYU5QC6qbofuSROF6mL6ag1y5dv9bv10zpZgx+hor433 TfLJCieJ8ERoeim4w73eNzWe/6w1+QZhuqvcT4y9Kg1TdGFFJ6oF4tp1rJRWjfpq0rzA 2ERdf2UC1HDymwKeBS3XXaZaqEOnRxE4stVU5bXJUpL56W0OvO1lgmrfKx8uMzd/mKo6 OsAg== X-Gm-Message-State: AOAM530V5CHhdPMt+K7was8AnwOKe9EzW4kAziJuNBhxJ8o6Htam8qXK cMhlkM2j/wSaA8OIO0nzD+Poig== X-Google-Smtp-Source: ABdhPJxniWUuhOK6ni3DT7xPMV5Jy7/0VJHnvI3QDRXhrWY/QDvZQXT5F80At1ygpltfaC/n543E1A== X-Received: by 2002:a1c:c90a:: with SMTP id f10mr17453319wmb.121.1593011081473; Wed, 24 Jun 2020 08:04:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:40 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: [PATCH 1/8] backlight: lms501kf03: Remove unused const variables Date: Wed, 24 Jun 2020 15:57:14 +0100 Message-Id: <20200624145721.2590327-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org W=1 kernel build reports: drivers/video/backlight/lms501kf03.c:96:28: warning: ‘seq_sleep_in’ defined but not used [-Wunused-const-variable=] 96 | static const unsigned char seq_sleep_in[] = { | ^~~~~~~~~~~~ drivers/video/backlight/lms501kf03.c:92:28: warning: ‘seq_up_dn’ defined but not used [-Wunused-const-variable=] 92 | static const unsigned char seq_up_dn[] = { | ^~~~~~~~~ Either 'seq_sleep_in' nor 'seq_up_dn' have been used since the driver first landed in 2013. Cc: Cc: Bartlomiej Zolnierkiewicz Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/lms501kf03.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/video/backlight/lms501kf03.c b/drivers/video/backlight/lms501kf03.c index 8ae32e3573c1a..c1bd02bb8b2ee 100644 --- a/drivers/video/backlight/lms501kf03.c +++ b/drivers/video/backlight/lms501kf03.c @@ -89,14 +89,6 @@ static const unsigned char seq_rgb_gamma[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; -static const unsigned char seq_up_dn[] = { - 0x36, 0x10, -}; - -static const unsigned char seq_sleep_in[] = { - 0x10, -}; - static const unsigned char seq_sleep_out[] = { 0x11, }; From patchwork Wed Jun 24 14:57:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623415 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7C796912 for ; Wed, 24 Jun 2020 15:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61813206EB for ; Wed, 24 Jun 2020 15:04:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="emOdUiDe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404175AbgFXPEq (ORCPT ); Wed, 24 Jun 2020 11:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404340AbgFXPEo (ORCPT ); Wed, 24 Jun 2020 11:04:44 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2C6C061797 for ; Wed, 24 Jun 2020 08:04:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l17so2656397wmj.0 for ; Wed, 24 Jun 2020 08:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N4d9MV/8IVDi6H6NDx3txaJsaoNizmHMUDUqyGZyRwc=; b=emOdUiDeUe+KFeHCqP/4Vwih/dwJXxtgOfA8pOQGoiPOx4UIAFEj52mjFAk5DhMU86 gT5Wkp7zH2kxwdj2nAgh4si1eNBmRt6zQrHV/KaItnIMe2juaJ0mQG5otPsahO1pCdPJ uNv7FOOfhL9aTrRneY9in0QBdNS0svXag+qoK1jXiCuIROyJEZl6vCMGfgtx9e1iQCaZ fTogXsdUIy5yY0iXLhZIm6MgIN9gDmrnno6dwDdaJSxcXxVh5LP/EdDdXAVtip1VfRmS Qvg6LFloU7LYSBu/IitxhtD60aQwVHctr3SlOUisidawyOoQ3WVkyHKCgnAfwUkNPuA6 Jdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N4d9MV/8IVDi6H6NDx3txaJsaoNizmHMUDUqyGZyRwc=; b=DwYhDJZgPj+j4BIHab+7RmmOJlWd4Gy4hLq8G/4YC7OiEA6aKh7S4lqI05AJpcMgnj 7BkUUyyDUhh/szNaeuMceUbxuI4fZlkVvR29uxWBSz6D9S+rrlgtFvsY8Tc1RNlqnUFM cPD4xAa+DTPXf9/Db+HeQY8OG/opikkoqxDOQbNNmotawCMrdE3Id7refnFLYywTTr7d tGsxmVjt7RP9dui6xT+mchEFL8/MLntsu3xq+09tJo8jJ7eugKmi/oFIfu2c+QDweyhJ 8uFHcVXuWMtRKdycJiDkR8JpBbwhiB+ZUPor/HrVxy1JcA8qdYlpAZFW4SOvO8JkPhpE XqCw== X-Gm-Message-State: AOAM530cQ8KMSjxT1yBWBPto604IsRBg/3eaTx96yIwPwhFjei2Uvj88 +v5Om9J0crnEAONl9bGsM0+8Eg== X-Google-Smtp-Source: ABdhPJygPsccHa5jOlhVGhJlJB4d/4S7eDfjo8Nvz6itCY61Cz7n4glf/TvzYk4QWergu4UvpagYdQ== X-Received: by 2002:a05:600c:204d:: with SMTP id p13mr29834871wmg.88.1593011082536; Wed, 24 Jun 2020 08:04:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:41 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jamey Hicks , Andrew Zabolotny Subject: [PATCH 2/8] backlight: lcd: Add missing kerneldoc entry for 'struct device parent' Date: Wed, 24 Jun 2020 15:57:15 +0100 Message-Id: <20200624145721.2590327-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This has been missing since the conversion to 'struct device' in 2007. Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Jamey Hicks Cc: Andrew Zabolotny Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/lcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index 78b0333586258..db56e465aaff3 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c @@ -179,6 +179,7 @@ ATTRIBUTE_GROUPS(lcd_device); * lcd_device_register - register a new object of lcd_device class. * @name: the name of the new object(must be the same as the name of the * respective framebuffer device). + * @parent: pointer to the parent's struct device . * @devdata: an optional pointer to be stored in the device. The * methods may retrieve it by using lcd_get_data(ld). * @ops: the lcd operations structure. From patchwork Wed Jun 24 14:57:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623445 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3F9390 for ; Wed, 24 Jun 2020 15:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBCD020781 for ; Wed, 24 Jun 2020 15:05:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zPM0JoTe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404247AbgFXPFV (ORCPT ); Wed, 24 Jun 2020 11:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404342AbgFXPEp (ORCPT ); Wed, 24 Jun 2020 11:04:45 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A051C061573 for ; Wed, 24 Jun 2020 08:04:45 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 17so2865198wmo.1 for ; Wed, 24 Jun 2020 08:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZjEPJ8/mm+wq5v36TYnyxcBS/a58z/cHHdKeFkfsfDE=; b=zPM0JoTekc3JwBTNgIwFO0P3svCMqz6zlvJHpDXyqSoLZJPlvT/40LKl7KnfnXmcOt qzD/hMl0Xi1GGBucNTt7iR4B4Xu1v04fUHYnRuvCkawtPjRw8DidaYzoxiJu6TZLLrOr Z5F3E2NaRAqvya3W1eGzceaDjDFLn/S08pifh4nAlO3JVcKUm5EOTsr3xiIuocLLSsTd /xyUNzkGVlysC/Y0PAaGQhWXhrhlJgo3T0Y83UmpYsnTZd6zUE+GCCuRwdATo1kAt5nc NljRyk6f15Lt1rFcApUW2wX5Kdbn9BDptRox73TfhNF0TsdTMSIopA8pPN/+fwS71EaG SURQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZjEPJ8/mm+wq5v36TYnyxcBS/a58z/cHHdKeFkfsfDE=; b=FPdMUo4948SCZfuxJinkiePCyg9Y07jtm6i4M7pYPEcK5QWHbk1naRFqqHOnynu4Tg vpjv88G2aKhKZcM+V9Ce52NdAwroX9D6FsI16EjmoKPz5hfPU3v261ACkMOqG4UGEMVa 8xy+HFfLp4PY+YjjYa9yuY1Q29H4PwT14E1tWw1LO83H+xdX9B1Y0zlZIdO4nouH/NGP 4/KpXRN2h6qm5b1tdY3R4NMIMHrs+xZgGt47llI5o+8SiYrjiUfq9BGZSKENNSBLV4tN 0xAHSwyzgmWzcoPkABp+u9H8mxiDjhJyhC+ZkuhuQFDX9r0lJIiPBPM8RCz2rqK2OS4/ 0XtA== X-Gm-Message-State: AOAM5333rkaKzNavIUUgLFJlDtDQrDxZY/7DD0RyCG1GOpRuVV52SlXR HWrm8TvE+dqbb690fKk5FbjnaA== X-Google-Smtp-Source: ABdhPJyBpq4p7XjDew8RzlYmMmVACRb7x1fhGgY5R/YmeMhjkFjmrwgSZSWjfeVp7THuMLPsMbh1fA== X-Received: by 2002:a7b:c30a:: with SMTP id k10mr25791251wmj.44.1593011084237; Wed, 24 Jun 2020 08:04:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:43 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: [PATCH 3/8] backlight: ili922x: Add missing kerneldoc descriptions for CHECK_FREQ_REG() args Date: Wed, 24 Jun 2020 15:57:16 +0100 Message-Id: <20200624145721.2590327-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 's' not described in 'CHECK_FREQ_REG' drivers/video/backlight/ili922x.c:116: warning: Function parameter or member 'x' not described in 'CHECK_FREQ_REG' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Software Engineering Signed-off-by: Lee Jones --- drivers/video/backlight/ili922x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c index 9c5aa3fbb2842..8cb4b9d3c3bba 100644 --- a/drivers/video/backlight/ili922x.c +++ b/drivers/video/backlight/ili922x.c @@ -107,6 +107,8 @@ * lower frequency when the registers are read/written. * The macro sets the frequency in the spi_transfer structure if * the frequency exceeds the maximum value. + * @s: pointer to controller side proxy for an SPI slave device + * @x: pointer to the read/write buffer pair */ #define CHECK_FREQ_REG(s, x) \ do { \ From patchwork Wed Jun 24 14:57:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623419 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28DEB14E3 for ; Wed, 24 Jun 2020 15:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 104D6206C0 for ; Wed, 24 Jun 2020 15:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XNDfNdRi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404358AbgFXPEt (ORCPT ); Wed, 24 Jun 2020 11:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404348AbgFXPEr (ORCPT ); Wed, 24 Jun 2020 11:04:47 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AC1C061795 for ; Wed, 24 Jun 2020 08:04:46 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g75so2635771wme.5 for ; Wed, 24 Jun 2020 08:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+OscN/rzPmV+Ca3LDqP3+7QfjG8tQ3er8qfNyGN0efc=; b=XNDfNdRiXmh7t9RgId/4XIu21fy4oogY+Nr/WCo6/NyZHQ4Itv6OslAVjjAeFK19iG i0f5xKyDMsV7Y4sxJPI9YCbK1EV5DMyQj7kn5az4goE+ZWa4Hc/EbVOv8PPGwvzyvzbE 4WqWCqGHmNWK5VT5Y/FG+T47fTbw53DNfdHg44MNHKBE2UAvgbjqSEO0jtByy5F7T5G/ ErFuGywjPZ/ZLSOfBNKzhIRi6Zi+cXmpf6gCITOXFnk+trenk9HoqGajs0aLJ5DdlAuo iL8KWarHIl3WczC77gRnj4JI3dHaFMqREtkO9wIJig1PkRUTzCNZ3nVTe0zR5R0gh3Gu h8rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+OscN/rzPmV+Ca3LDqP3+7QfjG8tQ3er8qfNyGN0efc=; b=nOy2zxs4GhvS5eADC0Mp71ldaUEZ+aIosrq0cmqNKRrJmwHn64zDfFm9qUkcE7ldJq MV84VQxIHSMEv6CYEG0adUKR4aw8X4hRzbtJpHdkD+uIatVyb/dm4zCCdTsIrQbxouCm nX9dSBWSypXTLtY5WtZgl9TbD0J4RBGRhIDSc9UfxXG6sKIrHOV9hWR1U8ggTYY+x1p0 L6l8iSbDbj10JCOtEb8oHVc7M2PFKwP5+Fku5qC3vWmJ+WFxZmqj0CBMpTyWu0qnbYCc aIeMw2/lia10q+khY7KLhnIuQBMSpDouyzmg8Skxz/TwqhVIunUTWmmmGCGINOI1d2P2 DjPw== X-Gm-Message-State: AOAM533hMWBB7vu+cX5ZrueyE/TBFqUxiZyL4bdznFUz0D0UIzPyoJnb TPtxWPKUJWIoPXYcHySQLk0hfw== X-Google-Smtp-Source: ABdhPJwVNF8XQROSvPdr0XQdKc3EWPYY8aw/n5FerSWHfY3zltFgb+IFcI7EijR9JNDoP40hEcO9eQ== X-Received: by 2002:a7b:cbc5:: with SMTP id n5mr16795235wmi.95.1593011085576; Wed, 24 Jun 2020 08:04:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:44 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: [PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax Date: Wed, 24 Jun 2020 15:57:17 +0100 Message-Id: <20200624145721.2590327-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/video/backlight/ili922x.c:127: warning: cannot understand function prototype: 'int ili922x_id = 1; ' drivers/video/backlight/ili922x.c:136: warning: cannot understand function prototype: 'struct ili922x ' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Software Engineering Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/ili922x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c index 8cb4b9d3c3bba..cd41433b87aeb 100644 --- a/drivers/video/backlight/ili922x.c +++ b/drivers/video/backlight/ili922x.c @@ -123,7 +123,7 @@ #define set_tx_byte(b) (tx_invert ? ~(b) : b) -/** +/* * ili922x_id - id as set by manufacturer */ static int ili922x_id = 1; @@ -132,7 +132,7 @@ module_param(ili922x_id, int, 0); static int tx_invert; module_param(tx_invert, int, 0); -/** +/* * driver's private structure */ struct ili922x { From patchwork Wed Jun 24 14:57:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623435 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7A9390 for ; Wed, 24 Jun 2020 15:05:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D56D206EB for ; Wed, 24 Jun 2020 15:05:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Erqp8Qyn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404378AbgFXPFA (ORCPT ); Wed, 24 Jun 2020 11:05:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404355AbgFXPEs (ORCPT ); Wed, 24 Jun 2020 11:04:48 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87988C061573 for ; Wed, 24 Jun 2020 08:04:48 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id q5so2619485wru.6 for ; Wed, 24 Jun 2020 08:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tLytrf9J+7CHVP5wu7KcfI+noBAdF1Wf8Twuues69S4=; b=Erqp8QynHDhJNjQVXw0Nml++ayuUC2985duv2TS42VTDHkluSux1WL8NVNlRd8PFfF Tr69ZgM7bf++tb18l5IAjqYmUpu9tlF7PJUiSz8Tr/vUqOcC+v8dsF8Tj4Kt+xMHXB7y fyOCi0BW4U5Gw4ul4uy156ZMt+/VwWbNKspvpwakR+6aCVHht2wBlU4p+IAvEkVI1ZMB 1Z+gXQ77Ie+8ckr7Pl9VYdxjHb12JG1gSlFtHtQBcg1hfU9FICm9DSB1JAhMxSxyUTpN tcuNu/c7Vb6L56SkTxqn1Nf5SV14/ketmit5cqVFZ8i4Y61Uv3chtiOdN+0GUmuUGDIc zUDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tLytrf9J+7CHVP5wu7KcfI+noBAdF1Wf8Twuues69S4=; b=dERUzj9K56cSU6JOXZvUuDlHZfVTO21+Uw14l6Rt2/FY6sqmTMqT+hU+RAIlbKS7rV aXXBIYjwKRQNqwArydVdh7cfmaaYoUN/NbWstm0OkCXmhIfXgHk75g19Kw0Jb3rqA6N0 C8ok8QrO09RoZe31TvtwObamZQ+pSSAbpb5xH3rs89/KstCACOYSPsJUBkvBu7KgFxVK nAAtcHAwVF0qROsPx69YCWNGPjQJmcURVL7wiI9gMaDduroxplUx6J++XYNt7AExlYAD cM/suIbdX9WfQojDz7Fm2AZ800r5nUL+E9cV/htFWOcdVBlEv5HdlWcJukdv1yA3q3s5 zp3g== X-Gm-Message-State: AOAM531HwtA3Yp8HrmCDH7l7eP89qzMWNAEdw4hnvc+1JfwWFPVriLqT JPhyiz8Q7ZuoGHOrMpN06B6tJg== X-Google-Smtp-Source: ABdhPJysPmy/tKH5YJkFzQIv2duUP1ODgbSrj8iubXadOJPQ7Zmf5Z3K1aBiaL4Ibwz73S2H6Wavjg== X-Received: by 2002:a5d:4283:: with SMTP id k3mr25625367wrq.322.1593011087317; Wed, 24 Jun 2020 08:04:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:46 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: [PATCH 5/8] backlight: ili922x: Add missing kerneldoc description for ili922x_reg_dump()'s arg Date: Wed, 24 Jun 2020 15:57:18 +0100 Message-Id: <20200624145721.2590327-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/ili922x.c:298: warning: Function parameter or member 'spi' not described in 'ili922x_reg_dump' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Software Engineering Signed-off-by: Lee Jones --- drivers/video/backlight/ili922x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c index cd41433b87aeb..26193f38234e7 100644 --- a/drivers/video/backlight/ili922x.c +++ b/drivers/video/backlight/ili922x.c @@ -295,6 +295,8 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) #ifdef DEBUG /** * ili922x_reg_dump - dump all registers + * + * @spi: pointer to the controller side proxy for an SPI slave device */ static void ili922x_reg_dump(struct spi_device *spi) { From patchwork Wed Jun 24 14:57:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623423 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C681214E3 for ; Wed, 24 Jun 2020 15:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE866206EB for ; Wed, 24 Jun 2020 15:04:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsBw1uV8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404365AbgFXPEu (ORCPT ); Wed, 24 Jun 2020 11:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404362AbgFXPEt (ORCPT ); Wed, 24 Jun 2020 11:04:49 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC47C061796 for ; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h5so2625894wrc.7 for ; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RVepsW5AvbKSelkDGpeRLJ59PttgtzeSmv2QlhFjJvQ=; b=LsBw1uV8LrG03R4u2wAAHV9lr+txMyw7+BdND15xIDswqXzGkXd922uezxszzxlKxa y6z1rBpFXRbiDLX/DYinCMp07ITmQAaZc4ADuyeddcvqYS9TdDbGAYOWzoL2rDSQWcw9 85nofVUxEK24RYZvCHdW4bsSTMWEs4SAqGBcHF+XCYhgfe54ZZFoXKhSjLS2/c9PD9N3 MjSyj4nMjZzhJNj1+kmNeddik1BNOt9Qx4pJUmMe8atuBq0wU6WIA3OgGX8lEd5hIh7w uQSnwO83jCtGstF7Qtm4upnJkXj8EyJ26Ib+qAdCMXuKvWx55yEiYohCoEgTdLNct4K9 AsXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RVepsW5AvbKSelkDGpeRLJ59PttgtzeSmv2QlhFjJvQ=; b=DJcFAwx1QWibhvIm1J6ftQD2XCwgSQR3X5mkhogNt0p5AdOhQJWJtnLG3sqvCDx1md tgXITm8IjkgHIqis9CHuVJZ0OquTK97+vaUBVJkrJBmipup9X9yu4Vy2Ot8Ioqvdscxi Za08oot3PWc3f8OWUFOD6ctBPkee5HiPv5WyYuOgBzRBZJhN6PIE3bVvJlJyWd7EAqoO 7sfvRcDkudchERibKbGLwlXbQ0nznb6l5qXUis5noRDuD1V0O6N5S4dQj+BHmJH80MTp QGyFdyXgiq0TFiclI3bXc/34YWfJ0XMmY0Pr5IB2ZKJ1Wawqz9n7ZtLzT3C0HMC6goL2 aqog== X-Gm-Message-State: AOAM531L6Df1KwafC8083CD7YJF5Fn5rlyCqM3SRKBxFICee5CEo5dZE HizQ8Sjq4mbtUWz5YsyAgpsAOg== X-Google-Smtp-Source: ABdhPJy5hjoveRZ0F4NTZinjK6e2tP12GsQQtzyhrotgfkM8UdmF7amCXrR0qX7WGB+tS0ZfQBcPvA== X-Received: by 2002:adf:e782:: with SMTP id n2mr31179657wrm.417.1593011088504; Wed, 24 Jun 2020 08:04:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:47 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jamey Hicks , Andrew Zabolotny Subject: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Date: Wed, 24 Jun 2020 15:57:19 +0100 Message-Id: <20200624145721.2590327-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Jamey Hicks Cc: Andrew Zabolotny Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/backlight.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 92d80aa0c0ef1..744ba58488e01 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); * backlight_force_update - tell the backlight subsystem that hardware state * has changed * @bd: the backlight device to update + * @reason: reason for update * * Updates the internal state of the backlight in response to a hardware event, * and generate a uevent to notify userspace @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); * @devdata: an optional pointer to be stored for private driver use. The * methods may retrieve it by using bl_get_data(bd). * @ops: the backlight operations structure. + * @props: pointer to backlight's properties structure. * * Creates and registers new backlight device. Returns either an * ERR_PTR() or a pointer to the newly allocated device. From patchwork Wed Jun 24 14:57:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623437 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF1CF90 for ; Wed, 24 Jun 2020 15:05:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D15EC206EB for ; Wed, 24 Jun 2020 15:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zQRqE+UP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404211AbgFXPFC (ORCPT ); Wed, 24 Jun 2020 11:05:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404381AbgFXPFB (ORCPT ); Wed, 24 Jun 2020 11:05:01 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ACCDC061573 for ; Wed, 24 Jun 2020 08:05:01 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id b6so2604788wrs.11 for ; Wed, 24 Jun 2020 08:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ss7PoxbYLKDr3LBMlu1h9z6F9Bwyl8YcpPLuuDtA3OM=; b=zQRqE+UPlzudn+/cNp26hST9pkqlAF/Roysjl/ZK7hSOKrbhU0+ps/0hPMPZsbtq/y 7wkqhhZfdcOFJBlLfaVIq6w0vtexOBLwbp/pjJGSxtLakMB6+zk27rhGv9J+ON8zZ6kn fzdXdcthiNFm1fkpxraeMNnxwh/t26zQo4S5e/5NFtzLHCzm4EadHFojnWIy7JuQe9cK 6ySZiZs6+kQpTsrLLTyxUW9nVNMXkbf3Ry1jJreYdNgKWyGYrXJxBMXhSJlWyVkmkG+7 0TNrihNQNOQlLEAzLWkhnniT+Ri1c30kv54Kd4HYaALy++kosXWN5+toAf8VcB8ifg3z Us4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ss7PoxbYLKDr3LBMlu1h9z6F9Bwyl8YcpPLuuDtA3OM=; b=rj8RBcbWJnXzQBNsdcLQQnsDT9qY9vhU1jiaUOvWZrkAIIB+PuALzXMChvn3MUNgJi vpdG68cUNGVqoVUn9l1mxDlEataruCJmN5X1o5+YCuIOaEKHmPJOjDAU8DIvQZXYfb+t XiVKFukYpPBrygxKErYjmMKlBP4GjXfpgjsAYHQK/Dw+/WiD2nJW+w3v275e5kOyEoka 2yscb9RbQiuRvHw6j6KSx9J5IDiKEzA8FkMjaNsNRHE4QAWqqAWcGfooF/kN4yEGrAtg aDrYTshSLLaBQ1hXyty3Re47NRhXQdUWycFI5iBXU0y4LjuZo6zIEn/IjF47uzvI8cmg uctA== X-Gm-Message-State: AOAM531PcFIDnOHlOACnRmeQbXlP9qqKpysguRxQy4ZtzWW4XXwl0iAy DC5FvQ4H7OGZWDkZjLvElBnyoA== X-Google-Smtp-Source: ABdhPJyBKk6kJ02PvMM7Uyi6GPyHgQUfHnlBQcJ7n1r9LSHJv+EmY6svcQnxsVdBuisOhIR5XeqR9A== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr32024458wru.324.1593011089754; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:49 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Daniel Jeong , LDD MLP Subject: [PATCH 7/8] backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 Date: Wed, 24 Jun 2020 15:57:20 +0100 Message-Id: <20200624145721.2590327-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org unsigned ints 'sources' and 'bank' cannot be less than LM3630A_SINK_0 (0) and LM3630A_BANK_0 (0) respecitively, so change the logic to only check for thier two possible valid values. Fixes W=1 warnings: drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_led_sources’: drivers/video/backlight/lm3630a_bl.c:394:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 394 | if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1) | ^ drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_bank’: drivers/video/backlight/lm3630a_bl.c:415:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 415 | if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1) | ^ Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Jeong Cc: LDD MLP Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/lm3630a_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index ee320883b7108..e88a2b0e59046 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -391,7 +391,7 @@ static int lm3630a_parse_led_sources(struct fwnode_handle *node, return ret; for (i = 0; i < num_sources; i++) { - if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1) + if (sources[i] != LM3630A_SINK_0 && sources[i] != LM3630A_SINK_1) return -EINVAL; ret |= BIT(sources[i]); @@ -412,7 +412,7 @@ static int lm3630a_parse_bank(struct lm3630a_platform_data *pdata, if (ret) return ret; - if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1) + if (bank != LM3630A_BANK_0 && bank != LM3630A_BANK_1) return -EINVAL; led_sources = lm3630a_parse_led_sources(node, BIT(bank)); From patchwork Wed Jun 24 14:57:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3C2660D for ; Wed, 24 Jun 2020 15:04:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC30A2070A for ; Wed, 24 Jun 2020 15:04:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jMGyaf2Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404372AbgFXPEy (ORCPT ); Wed, 24 Jun 2020 11:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404366AbgFXPEw (ORCPT ); Wed, 24 Jun 2020 11:04:52 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52740C061797 for ; Wed, 24 Jun 2020 08:04:52 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id t194so2850323wmt.4 for ; Wed, 24 Jun 2020 08:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kCGt1BLBXUDbnvT6cymu5MVAxH+kTuMsl5c+6aP/lLY=; b=jMGyaf2YOvnwdGALr7/G0emGXXMlzRVlYnFPWVRjaQMIqVwugRAnJc3hlq5hiW8h5c UlNYM5fXvpEjkCbgvKcR0hRU6Z7v6cS74QrqdBYQQwaf72KYCZRj32ckrnmu0aG5wzCh oQv/67iegU98VlySub1xjGVNx32ddSLk55uKDXkUIrvbzXltQVC60J2oVznaWMR03k3X c88NZ/cwdn2lcyWwoIaMvjTZKlgnZ3OueIPy8vYEViLHA8IFnXW05jOkLP4xaKWjAreX 6dOPEbwj+fmCGzpLHvYH0loVrVQGULW0wojhwots1TLiid7Psoh58sITpdd5KWwWa8ll /faw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kCGt1BLBXUDbnvT6cymu5MVAxH+kTuMsl5c+6aP/lLY=; b=i2GPKuoChssiNH0YBk0Y8x+yMpzcOrphQe0f+XUDdwpwBtGg8i5o2NW9ffrFjLZDYm ADw7ZHP+9Qpcvmc4LEiCa2QD4CNn/+9AwpIp2Asgyg7vqxopFd98p5xvD1tjXcStDFvg aKoqDizzt+tnLuSmU+69BEZOB6Rl6XFqu4i6dcWhbVjXJbLapc72/uUZsJcAMI7AtQ2k zyuQ+/S+U1XkJzMyxqBaSSbrnWhxssev0r22tUx8AAtTD3/wzNMF6zz3XLqX21s74jFk viDgskU0V9eWveBchR7yXSc1/BWFDaJ+n+sz0q7+bv4eLOVBF+7bqBL7YZsE/rcukgVU zxAw== X-Gm-Message-State: AOAM533BTPRPqkuktXn+tx2tXJTromgw6k+aBqWiurhoOdtbP/Cok7a8 L8mb/2R6DeQOGZeNGFo2urIS7A== X-Google-Smtp-Source: ABdhPJwGu9kMwIGOcSohIfYJ+NIxZfevAbg2JhUjdK0aeG9zHaTGKntdmr01NhaUWdU13TxN2I2yTw== X-Received: by 2002:a1c:a5d6:: with SMTP id o205mr20552487wme.125.1593011091041; Wed, 24 Jun 2020 08:04:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:50 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Andy Gross , Bjorn Andersson , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org Subject: [PATCH 8/8] backlight: qcom-wled: Remove unused configs for LED3 and LED4 Date: Wed, 24 Jun 2020 15:57:21 +0100 Message-Id: <20200624145721.2590327-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes W=1 warnings: drivers/video/backlight/qcom-wled.c:1294:34: warning: ‘wled4_string_cfg’ defined but not used [-Wunused-const-variable=] 1294 | static const struct wled_var_cfg wled4_string_cfg = { | ^~~~~~~~~~~~~~~~ drivers/video/backlight/qcom-wled.c:1290:34: warning: ‘wled3_string_cfg’ defined but not used [-Wunused-const-variable=] 1290 | static const struct wled_var_cfg wled3_string_cfg = { | ^~~~~~~~~~~~~~~~ Cc: Cc: Andy Gross Cc: Bjorn Andersson Cc: Bartlomiej Zolnierkiewicz Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson --- drivers/video/backlight/qcom-wled.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 4c8c34b994414..c25c31199952c 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1287,14 +1287,6 @@ static const struct wled_var_cfg wled4_string_i_limit_cfg = { .size = ARRAY_SIZE(wled4_string_i_limit_values), }; -static const struct wled_var_cfg wled3_string_cfg = { - .size = 8, -}; - -static const struct wled_var_cfg wled4_string_cfg = { - .size = 16, -}; - static const struct wled_var_cfg wled5_mod_sel_cfg = { .size = 2, };