From patchwork Wed Jun 24 15:06:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7CD87138C for ; Wed, 24 Jun 2020 15:10:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D85F2076E for ; Wed, 24 Jun 2020 15:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GB5PLdoC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dbjw8KGX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D85F2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iWqjQk8PGnx5MoJUgYRrXYBMDW15t75+d9C3x8/hUko=; b=GB5PLdoCIC8pSdGREaHr52zkN dsG4tWmcEUDSGraTV8QAJtLBuzZDpLxlf6UaVEgAR17WaO6d8R7zorI6t9ZUM8j8PFv6SLRFp1FSn hM5Hnq53q5qEXbTcNJ3Z17CcNszuN0DcWDsArgdyTrJ8Pmz7UiLct8ulNV+c251M3VaMLFONKGJn6 9/wahXHcYOpIFEZoHne4kiXyzjKFTzkbifU6CBniy5BXaFcCYvlFOPpyOz3Y8TZ1HL1kMiocWRnT+ HfMIxQJAbqb/dl3jC4w50QMNdTxWOkPvLxdVCf4zWv69Gle/K/Odf6m3c77iihD/T+JAhAu0kGE0h qXqxeeLDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo70V-0004hn-4C; Wed, 24 Jun 2020 15:08:11 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6za-00048j-2a for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:15 +0000 Received: by mail-wm1-x342.google.com with SMTP id l17so2665673wmj.0 for ; Wed, 24 Jun 2020 08:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3Z/1Sd7KiUmvxa4jor9PLam8Q3K0QVIvvAftZ1YelI=; b=Dbjw8KGXNnJR4/Cv9UY5wql6tvwgAVUE3t+Ql2V7uqKucZ/2lLic1lPgg7arybg/Zv BPvQSpSjk+WFFTm6Ryjn5CCh5S44hDzHQealupKltEpkDgvluJwY4Vyyh1+bDYHsLFvR XxeB3/USF+YNB0BiW+2J7WhBAPKe9YtuzvMBzMUN5NaIjjygKhjsdMOwmU1NEwTHTPVk 0Jo2DMHgKs557saxVmYCP4vImoVwz7KcSk9WdMgBLHj74Kyjb9GIOtjBuAtNQ9VIRtoD V8K7Mx1uw2+Lt9rme1GVEtyg99f/y8opZ4jln0sKsUb/oiikPgu5OzLfhFqUCfbTBiNF 3qIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3Z/1Sd7KiUmvxa4jor9PLam8Q3K0QVIvvAftZ1YelI=; b=q7C0rNvybR7KlgQv0g4CFX459EsHRedt42O6wdu8qJH0+iY1PpHJ3JP/VECA8bN90l zRR5bdumHv7JP1OmnFBWCMkP7NGHxatl14dCSMMIWczuoIo1VAqpOtTUcUPrQicnip6s AuB1sbS7qV2TzcXyXH92gJobSl4mFtQxNnfXLucAzFDV5zIxf/LhNhHgOuE8ggW8JmiA hMJaqkF+oyVwMgaPta1SicL5DQL0OsMLEJSm8PRJZ1+pViCex4ExIXaX2mK4PTrgejCO FX6s59w2XW03a1ctQEFXPaGRBEKQGMxyijgnnqQCcHL5wWEzs6majb3qb1RUiQ6Uc/eU 5cmQ== X-Gm-Message-State: AOAM5324UQMmZsGYptQAjzt+rP8S4VCB04WFzEk0S1/bPhyvp48Wc/a3 jp3PeP/ShERUFne/ZoEkk+wtF4tEwbA= X-Google-Smtp-Source: ABdhPJzVLUwK2s/MOqSCAQcZkXnN+fggMvRKgafQCLwEIMyGzj3cCIhqWF3b0Km0Am8CCXEcMFz0HQ== X-Received: by 2002:a1c:4e1a:: with SMTP id g26mr29750762wmh.148.1593011232892; Wed, 24 Jun 2020 08:07:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/10] mfd: twl4030-irq: Fix incorrect type in assignment warning Date: Wed, 24 Jun 2020 16:06:55 +0100 Message-Id: <20200624150704.2729736-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kai Svahn , Tony Lindgren , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Syed Khasim , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Silences Sparse warning: drivers/mfd/twl4030-irq.c:485:26: warning: incorrect type in assignment (different base types) drivers/mfd/twl4030-irq.c:485:26: expected unsigned int [usertype] word drivers/mfd/twl4030-irq.c:485:26: got restricted __le32 [usertype] Cc: Cc: Tony Lindgren Cc: Kai Svahn Cc: Syed Khasim Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/twl4030-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index 910a304b397ce..d05bc74daba32 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -477,7 +477,7 @@ static void twl4030_sih_bus_sync_unlock(struct irq_data *data) if (agent->imr_change_pending) { union { - u32 word; + __le32 word; u8 bytes[4]; } imr; From patchwork Wed Jun 24 15:06:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 444F7138C for ; Wed, 24 Jun 2020 15:11:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C67320656 for ; Wed, 24 Jun 2020 15:11:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tHiWCFkA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZHnjSn2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C67320656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tJjw8FvHV4hLdlJmwYHAgdIySkqMHUwzzTCQdFHPnJE=; b=tHiWCFkA1MXPAPtXUVKN/iqYJ gvs77zXvAnqx+TvJQul8hwUogZMWdtQBYdToTbV6fWEMwrdIpQML2uzhQIwxAn1rZaTumFNf/RaTf redMStApc+L2S7A2TWdaD545zxi4lnVWuTf9TkT4Bmq2uwaCb8mT1mz0J5vb5OzSmOtsYs4065hLt lRNYgsAomnm8ENCEIWFi2EXU9CG8GHq3DYEsSHfG7AYYP6/FvciaUf5RaI45QVQIeEyXwHt5pvJ1+ G7jBUh49AgXx37M95qHtIFSz4xCLPzR4qobalStCkA4vps2ZPVdjMlRwnj81sPpTkmURoVPqUS/Ga T4CIABKzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo70l-0004ry-AF; Wed, 24 Jun 2020 15:08:27 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zb-00049T-GE for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:16 +0000 Received: by mail-wm1-x342.google.com with SMTP id t194so2858183wmt.4 for ; Wed, 24 Jun 2020 08:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gtJAcvpHkuLRDrUsq1eY3z1bY+z7q8TiiXjibqyd6Ck=; b=ZHnjSn2WorVvPlhnsW05PjkW49hRNPgq84FENEFtuoQWoLFoS5Koxe/dFywbKRMHXL 3TdXrKvSsAttDlfRMZtJGsuGsj/a+hJcx94EmcpOadjkOkkb+KaWqiOYgNy6L6Yx11WO +baxZJlc03ZWuHtQboIEUm9C0m3an2F/wAOR3zMqIO+0e0yZcoFn/dKH/AZytJKBvXIf kasqyP3fjB5JUNwQho/QWyRHJ3YJOyhWE3+Oe40vlAuTWYeoqbw7Ezbto0uUymTcO6fp rAU9JBU5tdSYDQHnIyQdY1pyBRF0zOeb8P/DzpPmVAGVbd1L9Mlm8deCmJcpHyEmu7Vk irqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gtJAcvpHkuLRDrUsq1eY3z1bY+z7q8TiiXjibqyd6Ck=; b=fYK4vleNykL5HtMbrg28esST7mvItvl2ZwyTm0+qYyBuvyy3OpzFZVasRsCtvC3OJw 3i1m5uumx7ugfCYr2b5ZRQQop2jR9lsmUtj3gqb4vOJ+sub2Z2gh5oPqpFw8CdK9DCr0 nhezOm1zczybqve1t7pVXBnl/oOdRZ/lWR2GRaie+/g7tz/vVG/zrsDyc0oFwsqo5WsC DttFZAr1Rurk95l/k4Jg3X2LyMQsgz/AiSV6TGVrvRpeE51YsTFCpvaMldn25+7WrRt5 8Jn6RZK40oofktDcwsOGA9TFxNboAK2bvqpus9WqnDTJjWECWEvlXHeDpRy9tzTFoUMO 9Chw== X-Gm-Message-State: AOAM532OeeVHOuobsIdGRcukBv4DgzPJI9in/HISWSe8D23MRnNaMx9A 1ZS8TPCBzgMY96VP2aQwkfw2KZnon8s= X-Google-Smtp-Source: ABdhPJxagKb1wXFKsg3BjteSAxqyibenBVKBU8QYTY4DNUpO9PPoz2ukw2LgHjBi8SkOZzRYlyySUA== X-Received: by 2002:a1c:e303:: with SMTP id a3mr12187899wmh.26.1593011234076; Wed, 24 Jun 2020 08:07:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/10] mfd: twl4030-irq: Fix cast to restricted __le32 warning Date: Wed, 24 Jun 2020 16:06:56 +0100 Message-Id: <20200624150704.2729736-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kai Svahn , Tony Lindgren , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Syed Khasim , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Silences Sparse warning(s): drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 drivers/mfd/twl4030-irq.c:573:40: warning: cast to restricted __le32 Cc: Cc: Tony Lindgren Cc: Kai Svahn Cc: Syed Khasim Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/twl4030-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index d05bc74daba32..ab417438d1faa 100644 --- a/drivers/mfd/twl4030-irq.c +++ b/drivers/mfd/twl4030-irq.c @@ -561,7 +561,7 @@ static inline int sih_read_isr(const struct sih *sih) int status; union { u8 bytes[4]; - u32 word; + __le32 word; } isr; /* FIXME need retry-on-error ... */ From patchwork Wed Jun 24 15:06:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623495 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E17A138C for ; Wed, 24 Jun 2020 15:11:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36AAE20656 for ; Wed, 24 Jun 2020 15:11:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lm2zXs8U"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UDb/Vse+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36AAE20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X1S17CQTHgbZdzwPfaxhQSbcimeb7hzZ4wIRRop7SKk=; b=lm2zXs8U7ng2FwYFFUriiIfhX mdtO/9mzxRxh70YkNHME3+uY/eNsYHU9BgZyDooTSRjTXFnVZhlH/5R0DmB5aTQOshHHn31NN9C3d wJG/xf0VWKa06BjEFcwzoQWTNxgkFaNi5VH9oxPhwLhQwxuw9oXgnJ6dElHqWoQG7dB1tfhm+tyP4 i+y7geKMftrmzwicRHRQ/HT3VuoSoLNaDcxSTAwNTwKgQbsSWNlxJnWVXwVgpYY+9vEDrvl7+VdTA Jn3DmLqapx9smfBiyA1o+/amwZIncG8WvKIXoIpAKqqAtxdqJNH9rrYTk+3ATArjG1mqXL1SPOe6f fHzLhhq2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo718-000568-A9; Wed, 24 Jun 2020 15:08:50 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zc-0004AA-Aj for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id f18so2862286wml.3 for ; Wed, 24 Jun 2020 08:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s6bqmwyzyHG2RdGTyEeF3lokJJurQOvKiY/PaolAzM0=; b=UDb/Vse+j4PLUklMPE1jOG89dEqQuO2i7OzePR1xZB+Siiw5RD0TNhZ61xg09kUs89 /j6gfY5MnzUfpvNACK/AyPui2vyY89OSGCOHsoIVLaqSqPW9LpLNZAFOlC1J8E0fmIdp an9XJ9DImy6JVYbEUnIPVyxSCmwdNyhEkapxPgOahBtkigo0F522HmM5oAB7yoM0WR1U D32plII+0qv9D9duq0tohxdfVCI6gjoYS/9hQYTQQmTvnHOBVyeSxKVGEiIKxXoGzl5B Ax/pJQOymt1mxWUlguQssE0BX/ehCYDcRuTAyJiWxEyRVtjn0QJTfb+Hq32A+W97Jhov Ch/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s6bqmwyzyHG2RdGTyEeF3lokJJurQOvKiY/PaolAzM0=; b=VvY53QBKDW+ox+fOZSzdNxn+Q/1wfd3rcf7nYqQVKDodYjvco8Rz37Hp3dYRHm4lvk i5zURfK1eFXMSufCMYQfgbIe7TDLQAz8dBZReXh+TrLQ9d4v14umH4TdelDplKp1BQol 3KQwLUYoh3XHAMmWiqDmPnUgntH5mJJRcMzmITuBcOOifSXZ/xCY9Y/KzID71M9gjISZ Q8zYAHKwvpIbDorb4r5U/zNXYPEuzP5Hc/e7WDflLi7Sz+ZrFu9pDc1VNF82lOIApTZs ViTT5YZtUGU84ebDngvIYoYXwzAnEwjwH0BtX+GJHuM6FTl8zrhJ/1k4V1T2fXH94w86 5loA== X-Gm-Message-State: AOAM530/d9cwA4DjhOaNkFSXWr8YYkKeAaKi1Yzv2tKy0RpgwHar+Lah 6LWAn6KHmrvFSHXXVMzK9p2M0Q== X-Google-Smtp-Source: ABdhPJwfNOYCqcizNAWS6wfigwc8Rf4j01V19FGJhjfXQf2U6h6zjrh7PY3vYsNnGql2y9vxSlE+Gg== X-Received: by 2002:a1c:3881:: with SMTP id f123mr29878381wma.178.1593011235038; Wed, 24 Jun 2020 08:07:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/10] mfd: tps6586x: Fix cast to restricted __le32 warning Date: Wed, 24 Jun 2020 16:06:57 +0100 Message-Id: <20200624150704.2729736-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Eric Miao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mike Rapoport Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Silences Sparse warning(s): drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 drivers/mfd/tps6586x.c:323:16: warning: cast to restricted __le32 Cc: Cc: Mike Rapoport Cc: Eric Miao Signed-off-by: Lee Jones --- drivers/mfd/tps6586x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index c8aadd39324e3..c36597797ddd8 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -309,18 +309,19 @@ static const struct irq_domain_ops tps6586x_domain_ops = { static irqreturn_t tps6586x_irq(int irq, void *data) { struct tps6586x *tps6586x = data; - u32 acks; + uint32_t acks; + __le32 val; int ret = 0; ret = tps6586x_reads(tps6586x->dev, TPS6586X_INT_ACK1, - sizeof(acks), (uint8_t *)&acks); + sizeof(acks), (uint8_t *)&val); if (ret < 0) { dev_err(tps6586x->dev, "failed to read interrupt status\n"); return IRQ_NONE; } - acks = le32_to_cpu(acks); + acks = le32_to_cpu(val); while (acks) { int i = __ffs(acks); From patchwork Wed Jun 24 15:06:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623497 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45860913 for ; Wed, 24 Jun 2020 15:11:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C31B320656 for ; Wed, 24 Jun 2020 15:11:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nyxt4/RW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fDNdhuKb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31B320656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I4YOUUheVGL/z4sCF+qt9dvDF6zuHWo//0rhJS6kaGo=; b=Nyxt4/RWrt27NI/QzHBoBL8zD ky4LIO5YAQVuIz91aR3vq2vhTUzCvkMRweJaQgo2HbqGmCwnN8akXZU3UU9cTe7QI4yEWyUWyhaec FQ/WYnPLLYZaYQIhMaFlUuSCKL35zL5ys7U+NQwizTDGwI+47BKAoOI+LxX6llER+gNQfxTOydFEK 2KrGDFuOuc+ORQ+X5AGofWNxuV/+n+IfBrgJ83P/9ZJUOgNYxX8lFLBnz1whqNdfmt/N6A8T/3o0L ey/Pen8x02wEKtM9Ngr86+5A7RI71n/mINh6HgmfgkQ0wDLurcxkpdU/XSBeZfV6mOkRtH1VCsUHB Zwq8fD4rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo71H-0005Ej-E2; Wed, 24 Jun 2020 15:08:59 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zd-0004B9-RN for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:20 +0000 Received: by mail-wr1-x442.google.com with SMTP id k6so2655868wrn.3 for ; Wed, 24 Jun 2020 08:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mWlJbsdlqYw5jcyMhAAPjydUuATe963bkCaEYyUu7rs=; b=fDNdhuKb0j3VVPDO8tDSy54CPULXaYK08sbKQIDy3ep1JOR9nBbVcUbCnIFZr5CSGA 3eEaUEy+1pLOj1z8WJl90MkZZFGGT9kDKYYvy3RI+KX1vuVVu04bxyv83MTjlwzOuWzF 3ZZ83AAafizu+5VZcyLjnzxd75QECfrxUTAwAfV1BnF1c01lu0M5M14g6I5rQJls58v5 STkDxI2Abl7qHAmtVyhd1iATdTFvFTyzTTPld5HJVriQgOMSNPGl/F7gMLR4eKX7QO6Q kTZFbd3qnehapxU5N/pyDV/KutSTw85dKRtaeRBtU3HYGlLQ7Pg8Gg33Pb89SizVNWQa lxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mWlJbsdlqYw5jcyMhAAPjydUuATe963bkCaEYyUu7rs=; b=NeG5xs7uBxGoGDJUGfeC+jMKzV1cPeeuYo5l493NO6Cb4kH3wAhy9dAfR2CTnh7E8u QXiu/G7iywGKbo8YyGmbUUkJS5Y95Sy/nWd/VvR4TcXSandkmHSYmK5pRMSjqDsG9ki9 sLCtlvoAKbrQCV6+03bZ9dYMKUhu4K4afR1Mu9qkOSYyFPZ3dxk6ySD1ASKV3QdNCg8k SlqGMxBN3efblRjpiiMuDM76bXY+ARPodN4tqkDUNQpG2T7jrtEKMK7/abti9Q5oC77e cBg+WTlYIO50o7YkCpigJ5BK1XSTED7mDXzf4vxo1K0w4v6P3Y2PYv1wanorIwfGCDPg 8OOQ== X-Gm-Message-State: AOAM532gnfQJ6P4i1YO0WkaSdTmccZjPYjbUJJl4XBmDwp7r7NTbG7AI 67YUHet9n/DcQyDzYvwPhVRWbw== X-Google-Smtp-Source: ABdhPJy49Vio8rN9TQgC04M3RFdu5P/cZgoeUXhk9TTIv8QmZvoFN4fYe2L0VShsjN01Oh8SpVe4+A== X-Received: by 2002:adf:e4cc:: with SMTP id v12mr3692714wrm.92.1593011236167; Wed, 24 Jun 2020 08:07:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/10] mfd: altera-sysmgr: Fix physical address storing hacks Date: Wed, 24 Jun 2020 16:06:58 +0100 Message-Id: <20200624150704.2729736-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Thor Thayer , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Sparse reports: drivers/mfd/altera-sysmgr.c:150:30: warning: incorrect type in assignment (different address spaces) drivers/mfd/altera-sysmgr.c:150:30: expected unsigned int [usertype] *base drivers/mfd/altera-sysmgr.c:150:30: got void [noderef] * drivers/mfd/altera-sysmgr.c:156:26: warning: incorrect type in argument 3 (different address spaces) drivers/mfd/altera-sysmgr.c:156:26: expected void [noderef] *regs drivers/mfd/altera-sysmgr.c:156:26: got unsigned int [usertype] *base It appears as though the driver data property 'resource_size_t *base' was being used to store 2 different types of addresses (physical and IO-mapped) under a single declared type. Fortunately, no value is recalled from the driver data entry, so it can be easily omitted. Instead we can use the value obtained directly from the platform resource to pass through Regmap into the call-backs to be used for the SMCC call and use a local dedicated __iomem variable for IO-remapping. Cc: Cc: Thor Thayer Signed-off-by: Lee Jones --- drivers/mfd/altera-sysmgr.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index d2a13a547a3ca..83f0765f819b0 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -22,11 +22,9 @@ /** * struct altr_sysmgr - Altera SOCFPGA System Manager * @regmap: the regmap used for System Manager accesses. - * @base : the base address for the System Manager */ struct altr_sysmgr { struct regmap *regmap; - resource_size_t *base; }; static struct platform_driver altr_sysmgr_driver; @@ -127,6 +125,7 @@ static int sysmgr_probe(struct platform_device *pdev) struct regmap_config sysmgr_config = altr_sysmgr_regmap_cfg; struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; + void __iomem *base; sysmgr = devm_kzalloc(dev, sizeof(*sysmgr), GFP_KERNEL); if (!sysmgr) @@ -139,22 +138,19 @@ static int sysmgr_probe(struct platform_device *pdev) sysmgr_config.max_register = resource_size(res) - sysmgr_config.reg_stride; if (of_device_is_compatible(np, "altr,sys-mgr-s10")) { - /* Need physical address for SMCC call */ - sysmgr->base = (resource_size_t *)res->start; sysmgr_config.reg_read = s10_protected_reg_read; sysmgr_config.reg_write = s10_protected_reg_write; - regmap = devm_regmap_init(dev, NULL, sysmgr->base, + /* Need physical address for SMCC call */ + regmap = devm_regmap_init(dev, NULL, (void *)res->start, &sysmgr_config); } else { - sysmgr->base = devm_ioremap(dev, res->start, - resource_size(res)); - if (!sysmgr->base) + base = devm_ioremap(dev, res->start, resource_size(res)); + if (!base) return -ENOMEM; sysmgr_config.max_register = res->end - res->start - 3; - regmap = devm_regmap_init_mmio(dev, sysmgr->base, - &sysmgr_config); + regmap = devm_regmap_init_mmio(dev, base, &sysmgr_config); } if (IS_ERR(regmap)) { From patchwork Wed Jun 24 15:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623499 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2704C913 for ; Wed, 24 Jun 2020 15:12:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3CF02076E for ; Wed, 24 Jun 2020 15:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jhtXvYXC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kDV2gBaw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3CF02076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PkbjMtE8XKfow/drNppwO9NPt84h25M9IMEjfmRmXUQ=; b=jhtXvYXCKaNteec39lPg/dfCO G2UWu+Atlh9sQU2NO5zvN337qKoH10sStE848fEz5VcMwPTPsHY+boun3YaPYNk5u44oS6wTR3LFv w0UiEYHJYyM+H9G4ZHZdBvszhnA2zPwMZpoNhkyBti0+Z/7uPur9IB0KzQSMn68dFKzjqyWDhXjOm 3cToc0OoVSRCoFMqMxMYLVOiyHzLxYT7Hs40ADiZKPJYL82w8eKfiC4QW8mIkLI/EggaV0YfCCqA7 R+2nvnXb7zVNizAgustpmYYxb1dmL1oxlocZdXjk4X2utWZYIvmFVfxYZ35hUYfLZHV14sCQJfsfQ PYaSw7P9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo71p-0005Sv-PG; Wed, 24 Jun 2020 15:09:33 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zh-0004C4-FT for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:22 +0000 Received: by mail-wr1-x444.google.com with SMTP id v3so2660874wrc.1 for ; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C0YMw50ghAnk+HJlng7jm1/7u29zz1+p4P4aWF+LxTM=; b=kDV2gBawSXjgK3E9pSWH7A3EwP21b+YwX9fkeeuRcMt8E5kiFMZWVW0uYtCNOKcJuj IlqNWloTM+FAEb+U0biu0LntpBbm0JAACtz0XyTEmV/gKbjUFfaJRomKsF4zGlZT6I6p LWpzY3Sh6pcWRuViXK7g/WZpDc1qvOlw/ZeK6Ed8mKvL+wr7SabH/mKNbAPxWZApEJFa gnE8MA+E6U/pAaKDfv5CX9jACfdEpHTXEEfxN3ZvrkXac3mtnPw7zaScjyiQv+xl5GaK nJtMTi3C+ufi2umQbtp/YQ4YV/LWR8gsuIQXPdgTB0GBXH/9BabuZmOM7P9L0JNXcm1i 8fDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C0YMw50ghAnk+HJlng7jm1/7u29zz1+p4P4aWF+LxTM=; b=Aq6uVcZg42vtX2N7f3xGHUnEOp8QDkFQL80CozCmo3XHlKnvdiIAieTZRwZit9H9Ij 9nLT5UMEaAbjBqwHHQAFTDFSwbRE/ou+2+pow5WLk2I4sET7gbT0Sgx9TA5Opgb3pJ+X f58n8z/LeCX3Rb1Z5URafF1udCM7uWWQBilSqjzst0By0p+RvqcRQhI5xmdc6z3XTgao T56U+lkQJEKRvtBOCHLScexbMmNU7etAn4IUHveW7blAUH7h10gzqx5CjKksvi3SMBgl IdAz/1cZoI+mm9iEnF7ApLyD1AoS8sma08Yl3vnKl8Q9o0fYHjTRVluLi/ysv+V4norO 3e8Q== X-Gm-Message-State: AOAM531qkaMsNd6jCKRmmkCn/c4UD/xeMi2q27q4/ciOUYImLqvMasqe 5FHK2/c3gS19ampdx0Wv8V5beA== X-Google-Smtp-Source: ABdhPJw7fzjIBqiuXbknQUNCT1qFwoGdpdovl6TpOoVdAxH9PdAL4zXdFmFzQ0XUdcgHG+7Xx0AVNg== X-Received: by 2002:a5d:4611:: with SMTP id t17mr30149480wrq.243.1593011238093; Wed, 24 Jun 2020 08:07:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:17 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning Date: Wed, 24 Jun 2020 16:06:59 +0100 Message-Id: <20200624150704.2729736-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunyan Zhang , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Baolin Wang , Orson Zhai , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Sparse reports: drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol 'sprd_pmic_detect_charger_type' was not declared. Should it be static? ... due to a missing header file. Cc: Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones Reviewed-by: Baolin Wang --- drivers/mfd/sprd-sc27xx-spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index 33336cde47243..c305e941e435c 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include From patchwork Wed Jun 24 15:07:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623501 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4D78138C for ; Wed, 24 Jun 2020 15:12:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A90222076E for ; Wed, 24 Jun 2020 15:12:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="acWZJh3a"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ff5473UI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A90222076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Na5mEsbNZa0OsUKM10B7g8+0OrGdspECEVa/BTJdwrM=; b=acWZJh3azwMLJNsHGByAlvYuH hDNkvlmiPLdtn8LK7cfwWFSeZmqFeJKKK9oPhf0x2YU1+G8ajmIgGkTpfiEG/Js8m/ovW0LnCz5Ir mlzBrLOQp9o2jN13tfQIN1HCcfQzsECDJLD4/3UyVsmwAt5dBXJmw1TFX8sWUi5WOuaIeqYlHQcEh wKIbSBXdNsyP7ETQVi6XK67PEFi89CA/CoUDtdgR8k1KgfvacRekqGrrVXTXcH9GI1lQ0HCotblbA GryStYm10WwnkFfyNUCNJ44Sj5uYnnTQ3mqSatNGK+SZtg2iYV/VF7x2A29zsNvzbTRSJ9H5eKs3D iYxDl8SBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo727-0005gi-VL; Wed, 24 Jun 2020 15:09:52 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zi-0004D6-DU for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:23 +0000 Received: by mail-wr1-x443.google.com with SMTP id h15so2631097wrq.8 for ; Wed, 24 Jun 2020 08:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=Ff5473UIxYPsdW4pi6CB5QPFSge/HWs1GPIn1OasdcMvQPjvlEK+g8lSeufiA1UwKm H6KDcmB3IgwAsPz//203sr/5lItNIy2VU8gLEnAju1bDpqSAA+snoMXXBbUKVTtwRhw+ iYvztLUTfNwIJqWObVgXcpCcC997bPMIODvu8fKaIJsBfDZOWCccn9tKIqHndpm41ykY Mq5NnAMV9jctWKT/2bpdtVs0PMXEScf5SNuIIaSmmhtv+vlqdMu/JvyKU4itIlO1CcGf tVbYtwzeO0StF89eiamELfZGSFWzF039y0cQjpkDunjzUqt5nyJcW9aNz0PxKD3gXnrL vAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=Ik5ScPDXnmi6yIe5su63fzb51bR4aVVqMZ1Jo0Z0fZbHbFZmBJ8RgRx2RGRdmyMlSq gU22qL+fwnAsVptu2senG2lwPCI7iIC9JhjvTrVJjXRs5crjshpe4NPpCBgm7dSG1QZu xX7qarB0U6sPtQyRi5NOlRf2qq6sTBwV1SN54TZ+kFotEm0AVPvQtspMDPwI9eeLj/x4 k3nKukeOa+xCloc+ZnFpUquZAyZ8jBjIazCOOJij4kuKub8wmoh65dVdwiadIX2WmFR7 BYl/dpx4JvFoovlygmKTg/WSKGwpkhXG90Yh7kynOs/Nc48oH7n3+gsE7/W9JUmDaHid W+mg== X-Gm-Message-State: AOAM533cqAWrDF1GcFYzEuo0ja5qTKMjmt4U+zNW02kyrWu6gDkD1P1S Jd4ZlP9lLlebH3gfql3U8znUiQ== X-Google-Smtp-Source: ABdhPJzsQZaqGp6yo+Gvy/E7GwTgHGlfZMJUpo8UcdCxDQEq3FwvOrTnZtBe+XexIjSK/+7zMSJxFA== X-Received: by 2002:a5d:6749:: with SMTP id l9mr31134388wrw.63.1593011239284; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/10] mfd: ab3100-core: Fix incompatible types in comparison expression warning Date: Wed, 24 Jun 2020 16:07:00 +0100 Message-Id: <20200624150704.2729736-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Smatch reports: drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab3100-core.c:501:20: unsigned int * drivers/mfd/ab3100-core.c:501:20: unsigned long * drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long * Since the second min() argument can be less than 0 a signed variable is required for assignment. However, the non-sized type size_t is passed in from the userspace handlers. In order to firstly compare, then assign the smallest value, we firstly need to cast them both to the same as the receiving size_t typed variable. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/mfd/ab3100-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c index 57723f116bb58..ee71ae04b5e63 100644 --- a/drivers/mfd/ab3100-core.c +++ b/drivers/mfd/ab3100-core.c @@ -498,7 +498,7 @@ static ssize_t ab3100_get_set_reg(struct file *file, int i = 0; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((ssize_t)count, (ssize_t)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0; From patchwork Wed Jun 24 15:07:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C469D913 for ; Wed, 24 Jun 2020 15:12:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B59720656 for ; Wed, 24 Jun 2020 15:12:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eivJ6fTm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DPUhRWgB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B59720656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GeFLAF5xajz+DDYML2rHXCHgTjZQIcc+YZ5o8x2HppM=; b=eivJ6fTmepYrKiyvK8PbReoCV AziPoKpNp8jKSwe/1J9MLVOpC8N1ktZrs1BpEXuPHMKaEWDKUeeub8QINKy7VCjHi1LnLta3wY3W5 RGSW2aiwyfz/mrZzmUgp1heGfCZAYVAMW1IELm5ddS25NgkRibyfkAZ/CRZljPZ6rVKXNQpzR3SGM t42KccgGIEdP2IL95tbNG/WzVgrJZQ03PE/ZFeIZyF0MUuQB+T10HAhs18byBsnwIQUjDu3bZdmbu WtotWE7rk0Boysjq9zYcdcPd0G/9np8RQpd/0RXFJW8UxyuRWjeFmAqhNljwoJ+ygtmHguzHgruU3 GOaL/IuiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo72R-0005xW-U9; Wed, 24 Jun 2020 15:10:11 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zj-0004DY-8w for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:25 +0000 Received: by mail-wr1-x444.google.com with SMTP id o11so2620285wrv.9 for ; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZDwUiot6YU8OgX3Hsb4EAg8793UTa9837ZvsB3Ajb68=; b=DPUhRWgBdf4z6Kq3oWU8vrFS/EIgLp6T1Rjiov9INnODXro+UNi8yI8adJRwBb0utU 7Pm3vem2rv8I4QJIpGeXDr5oIFYw7N0HnH07oS/h/x/xgKsH1rkfR+v4BHlP/y+79eyw p6ClIinjeu01EHHr/ntpl6Pu1CqJm9076Dt52/rKxDXw28C8Wg23+Uys/DJw4//G0Lg2 kJJo4eSujafjVkZdQcjpwrnR+NUQRGh5WdZkKoFRB0OTACrZ5/h0jEZisLqxQCBOZ9YB 084H5InBZNTRYzrTu+pYo+r5TQXYYBL7tywwHul7NsS26H2HBonPPvirVNEOc7UAiv21 3n2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZDwUiot6YU8OgX3Hsb4EAg8793UTa9837ZvsB3Ajb68=; b=HDNZJkC00ypCW9rqz8jlV5iUnmJnDOkMpqxMEEsLd1XlFj8NBrACKe/6d/F9PS6rXf ArAeltyufAztUlvFKyOcRNl7/ZWNmYY/WLtWw5KBfS7jV16PBF5r2OwRMDBlU2uC59Nn duoRWTjV4YMR0Mx7uDcvdfH2YkhAldgDSOu5N6RQHqjsA2vBkW9hy9RKMAa1TtPeSRdM EHlUEMoLJS9zeztRYxP1VGX2aG9KBwwbnztM4sNC6QXYkevixDnCCSEinCQNA8lwD/Iw SXMjPrHpPRKL6I+1/E+IW27uCixiRRIofoi0ajR8PZR+30A8uww2m1nhz12C8IkH2c+1 uYag== X-Gm-Message-State: AOAM530yG504nTBFu/6EakwRHfgA0ns9qzjMv/sJscdceBzeY/RcliSD E1yzd3I7jnSQMztKsnMkjPZo3A== X-Google-Smtp-Source: ABdhPJwRg+dd0nV6QlWORkWed0heqJcLSegy+1eW8ToYmwLs3DPPatue04iD98sXOOpgScYdnnXdiw== X-Received: by 2002:adf:a514:: with SMTP id i20mr31153581wrb.112.1593011240649; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/10] mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue Date: Wed, 24 Jun 2020 16:07:01 +0100 Message-Id: <20200624150704.2729736-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Smatch reports: drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long * This is due to mixed types being compared in a min() comparison. Fix this by treating values as signed and casting them to the same type as the receiving variable. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/mfd/ab8500-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 1a9a3414d4fa8..6d1bf7c3ca3b1 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -1801,7 +1801,7 @@ static ssize_t ab8500_hwreg_write(struct file *file, int buf_size, ret; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((int)count, (int)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0; From patchwork Wed Jun 24 15:07:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623505 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98723138C for ; Wed, 24 Jun 2020 15:13:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71A2520656 for ; Wed, 24 Jun 2020 15:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zl+TM/fL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lFmz9hEr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71A2520656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6iIBm6zliOi4CRrhgVhygKiW73pIvuBlpuK/poYmb1k=; b=zl+TM/fL+maLg2FGgMeBX0E+E sgkqxwsCbX5BXualdIjB3ugKKrNLZ41rcVMJulbtqjae/DWmEGxx87kq2K3nBi/9W0chPzVetNEkb eYP6RtGw9EpPW3UMWh8OoNmTbFt5rUAJHMMrQg7BzzN4MJosHDV7vS4GUlStYIAn98Ys77VnI+4GE kQZLveBQF03/g0fWh+RBIIfIwuHvh2r2sic2WuVSVWQOrB/tjq6zHbsfJtjoyfthLcJfC7y8e9bg2 vN+QkrKPXj7cciHgHtMtCBGzYSidnYf44evY+YsGb71Rj8ODZ2Nt6aa+JEiTCb14sJFwaj9hdot+L j6YQLOynQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo72l-00066a-9v; Wed, 24 Jun 2020 15:10:31 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zk-0004Do-7y for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:26 +0000 Received: by mail-wr1-x444.google.com with SMTP id q5so2628414wru.6 for ; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HqgBI5p9cdp/gbRtc5/Vf5SqfkaArMfvY8eaitdy6zc=; b=lFmz9hEr/UQJ+lwMW8roCnq3g4o/1IdbpIbo0yOY9Gr1j8oubjm/YxUQtoUtEG4z0u iDnDFflx74sHdoX4yqDg6oV4pfxet8NvFU2/FHLuALUQr3an4yKs9S+Fs79eIDpc3dcb JtXFXWW12p27qVi6qpB5nk9/t1ogYLmnsm7xyLKp4i3FT22qLqFqH+ICOvXShxjlQnys fqySQyjcMI+FVhbec+8k44RhRNFhvVdmz31l5lW8qOFH+vEQucZDKToab5H7wXcx15lc lpA6UmZdV5LtxK5uhrMDob/Slw1ZsJUiIbWJiEEXLvXoJKmphPdN8AP4XYBMgBlADmQW sBBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HqgBI5p9cdp/gbRtc5/Vf5SqfkaArMfvY8eaitdy6zc=; b=kjkw917xhn0HaGwiWaq8KMjmCnux8ewYk/4NhtVlTpXErPdnCZ6oDYhDwsuvNpwmAd TL/y8VBC+WKKKt4Ax+xsLoUeebTIS+jHBwb5pPAkri4B937PxT2yQf5mMlhSiDef4yPx 3mvol6qY/iGZlYmXVolHfGehpktFL3s2bETQPZFi0ofA5F2tBu3dFTNj/6v/aVKN2D9C P9meujLy6Qh3Y49jjDM6TffrMOHeao3xH3Uc1C+bnfhE7Pnr+H1WfUP81NCxEY4HW+rU ffCTmSpiUsd+UZ7oZA5cOqBWmci2owCco6u0AwjYVl5sMTzJ6JrMy53V4KrP8vrIFvR/ xOYg== X-Gm-Message-State: AOAM533thJNu0uSgSKCWpj1HP8Qq+CmmuibA7LfIhF4Tqw0//Za9w+6W VBpLPR6leW0ANKIemLVKcseeK3D7d1o= X-Google-Smtp-Source: ABdhPJwOvWTMTp+xIS2/s8zG18Vu4DqV2sM9Odv7Zzraz2b8w8qwdPgvlZ7TBTtcClG7K1YLPU2I8A== X-Received: by 2002:a05:6000:10c4:: with SMTP id b4mr18542660wrx.50.1593011241512; Wed, 24 Jun 2020 08:07:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:21 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/10] mfd: tc3589x: Remove invalid use of kerneldoc syntax Date: Wed, 24 Jun 2020 16:07:02 +0100 Message-Id: <20200624150704.2729736-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35890' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35892' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35893' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35894' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35895' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_TC35896' not described in enum 'tc3589x_version' drivers/mfd/tc3589x.c:32: warning: Enum value 'TC3589X_UNKNOWN' not described in enum 'tc3589x_version' Cc: Signed-off-by: Lee Jones --- drivers/mfd/tc3589x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c index 67c9995bb1aa6..7882a37ffc352 100644 --- a/drivers/mfd/tc3589x.c +++ b/drivers/mfd/tc3589x.c @@ -18,7 +18,7 @@ #include #include -/** +/* * enum tc3589x_version - indicates the TC3589x version */ enum tc3589x_version { From patchwork Wed Jun 24 15:07:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623507 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93BDD138C for ; Wed, 24 Jun 2020 15:13:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6828420656 for ; Wed, 24 Jun 2020 15:13:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b6numdfA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B+Hgbe6A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6828420656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oLGhf9GJKnTPzKk7KsCf3+csSFUsDYXHfj10mE39LlA=; b=b6numdfAKLx8BlYil//MBwQ4Q yXeCniWCCMoidSCXe4UYYElRhvOAbTKIrN2yFTdNf8kQqtDAvUxF9OLqcroaXTfBzr0fcyw7N4XgM KNZppqW7IXuID49vDyLw5r+Caym+iWcAvXcpmBSF9KcfeUjGqC+IU70Y5H5tDNH9amkdP2+K2vGTR OayMoYXSRrPNw1N3K18jEFkYUAT/upIyZsN4Gec/fea6m86gnyv4nV5Db/nr8xkaEg9pN9p4AJhbP SDrcx9y9Lf1UtXlYyEF+pyHMRLvfJHqVQU5n3wzEQf2dT4JNxdjeKS657nJ8hWTWqnPYnD8HwqT/8 fdTx1ocPQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo72z-0006KA-FC; Wed, 24 Jun 2020 15:10:47 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zl-0004En-PK for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:27 +0000 Received: by mail-wr1-x444.google.com with SMTP id h5so2634856wrc.7 for ; Wed, 24 Jun 2020 08:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iBe/FTv7QFeWNcu1NrkE8EgReU1liqjk61nWnJ+d1XE=; b=B+Hgbe6AnZtssQEQLO8+i8LkJ9djlesDYCv5WY7N1bZuonlujQTgxUVX+EIDPO9kgQ 5AKudORu/oeiJMDAlTmAdQnVSJtqifT2wniOLK3q1GFfQk93QfIsuzrKKUAJz+R1dzcR suKJvwEPmlDTzNaH7TNLdu1QwMrKr6R6f0HGqXMtOHIuPYgZ/bfkULjSw9PNFIctmDEE P9MNElqmSRzhWWNxy9kXXWmZrxts/dMGERsWqgdpr7/2Q/j5WLhhJJ9Qjt92oI8GBpVN 1o+nBw/CBOEzI7oFe9mzJ7P343F/2Dh04W8EOjuETfcBeVenRb9twG5OwYOW87+Zz/XU XelA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iBe/FTv7QFeWNcu1NrkE8EgReU1liqjk61nWnJ+d1XE=; b=k61KOigNev/MeIN18h4PYe1Woq5Z+0WCoIJJ4EHLmfLOe/c0hqHps99khu6cTpBA6s uEQ6nYjSNfpshXXi/VBgDsr8NfZhPreiisyOhLuRzEytC7qFN/rTvIhbbacgHfIgAxdD TqlGD3fnEy89jgvNgTTnjivVCxemAncYNEylPifL7RVwhDZvPiDO6IpjEtFe1FQzjOBg +XVQdEpArkYxHjxle0g0OYqsHDzLCPsD9QxKrkZkiaCr+aTHHvq0Ew1FU39ccGZaudln uEVnAvLDm9kUNQziIrL3xn2cK4McVK9G6pxYr1NP2AzYJz4Em1GaJcjgu702o++882FC FA5Q== X-Gm-Message-State: AOAM531I18ppWMwKwPkbFn56hvcEeMZ+4mXfYd0gFKdet4Z0XSaBUJWy CYDmxnsz7V4tvyxdswMrrA2k2Q== X-Google-Smtp-Source: ABdhPJwq4TiHFC0om0P4LKPqRz2iWzOotH8E+e4+wuBw1cN25FayJM197IkFVa1gMyGlfOZuFjvacA== X-Received: by 2002:adf:ef89:: with SMTP id d9mr17946513wro.124.1593011242694; Wed, 24 Jun 2020 08:07:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:22 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/10] mfd: wm8400-core: Supply description for wm8400_reset_codec_reg_cache's arg Date: Wed, 24 Jun 2020 16:07:03 +0100 Message-Id: <20200624150704.2729736-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm8400-core.c:113: warning: Function parameter or member 'wm8400' not described in 'wm8400_reset_codec_reg_cache' Cc: Cc: Mark Brown Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones Acked-by: Charles Keepax --- drivers/mfd/wm8400-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c index 3055d6f47afcc..0fe32a05421be 100644 --- a/drivers/mfd/wm8400-core.c +++ b/drivers/mfd/wm8400-core.c @@ -108,6 +108,8 @@ static const struct regmap_config wm8400_regmap_config = { /** * wm8400_reset_codec_reg_cache - Reset cached codec registers to * their default values. + * + * @wm8400: pointer to local driver data structure */ void wm8400_reset_codec_reg_cache(struct wm8400 *wm8400) { From patchwork Wed Jun 24 15:07:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11623509 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 013B3138C for ; Wed, 24 Jun 2020 15:13:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 779C62076E for ; Wed, 24 Jun 2020 15:13:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ztd+LEv1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BtZw33dN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 779C62076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aqVmFAky1d5UCR+flPnxiLcUksy8478MXreHmCcojpg=; b=ztd+LEv1ktaT3U0nt3cufVIZ+ dw7Mb3X/WORNJw2ugwlNo3pOraTaAweOX9C1U2Xkk3KIEMZghQYW4E9MD8hdXuYz7oM2/UeaYuxdu CQrwOjdhJ3h8ryEpJxouYYrZBmhxCowvgJXCvo+YY1nu5dsu6C/BWfUeOW97UC2OcW9B6iOE6yabU iiUAAx2m8I0riwIymx7IFVFx0in0pE4/kHImVRtSK946AaIeFcGxIrPYGMoTd2ckSm0QZVhKtyNLF E0WCjAnXtGcTLBidMdjyrfQdoGJwRp27X+oQxMo3Fyfvf+j/AL55umJye6/P5Vx1HGJyZgMnLeQE9 WtcmnvXyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo73M-0006Xd-Aa; Wed, 24 Jun 2020 15:11:08 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6zn-0004FM-07 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:07:30 +0000 Received: by mail-wr1-x442.google.com with SMTP id v3so2661210wrc.1 for ; Wed, 24 Jun 2020 08:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kSPgE+bGgsMdGhCfRjJWoo3vTL9/vYYp2AF2KnCRX7A=; b=BtZw33dNk6XR2atGnsBkwFUuIxaaSCIFGdnyixfM0UlnYDV3zzT6lb6+aa5UD58UCe tElHor7dZl5GsAKmFmBg3dY+AfhyaoGNRDv2IttT/kiYEg0K6OEVNIX2BjsVMyL6D1Vh pl74LjR7qUunaQwqNmFvpQ8M5npMEODYp/0U4aA7dzfTv0oXX9GuIPNlYKwdGJulKZNC xK911HEq5deWXhRuEJqGaat8+7llFxgHSGLbdqhi18VSQhB6s0rrfYtB0yK78ppQSKlp 1mdd1eqdW9hbgOZwIWTNEFDWEsKFNNT8+oTEHAvTj92jtOvOonh5b99Z7mXBqFc9znrQ 7Bow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kSPgE+bGgsMdGhCfRjJWoo3vTL9/vYYp2AF2KnCRX7A=; b=V+k6KbZnfyO9hHsW1c1B2EAHPaeza599JVkMWVYYw1QeuvAp0J041r7ASQlcSLd4Jz 8wL4p8mtaku2N2iupJ+eTYY4CvR8dk+UjjMz9X9rb8Zgk6JrtA8oY+2e51OlL1tSDrY4 HB9SugGbRjY2tODnJcXvxtO141rv1CO268juIYxE9JkB57lajlIi6l65gbgJmcRkLRuF Ah37VN7cBtiCbXw1cdz3NX01HH0tqip1zaok1mjuJ0US25CfoPtNZ2FECTolaEott286 rzY5PFIn1saiEiKYU07STvpOWCfBlukQsuEb9UwJinZyNx+p0ADqbjGVSlsjUidlX350 Kv3Q== X-Gm-Message-State: AOAM530WopeUXmBglelzW9RZbqdHVCcsmyTPquIRTDM5PNk7Wq5f3MTL 1fkXRp3vtYJKZjLsKyy8My13ww== X-Google-Smtp-Source: ABdhPJxdMcci8lbcX4ZJfwIvm45gJk47ZSdYDBO+zWr066+2R6dxBc4cWi4TqiTyAHdaGplxmjK/Kg== X-Received: by 2002:adf:ff90:: with SMTP id j16mr17817455wrr.364.1593011243632; Wed, 24 Jun 2020 08:07:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/10] mfd: wm831x-core: Supply description wm831x_reg_{un}lock args Date: Wed, 24 Jun 2020 16:07:04 +0100 Message-Id: <20200624150704.2729736-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/mfd/wm831x-core.c:119: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_lock' drivers/mfd/wm831x-core.c:145: warning: Function parameter or member 'wm831x' not described in 'wm831x_reg_unlock' Cc: Cc: Mark Brown Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones Acked-by: Charles Keepax --- drivers/mfd/wm831x-core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c index 02f879b23d9f6..b0344e5353e4f 100644 --- a/drivers/mfd/wm831x-core.c +++ b/drivers/mfd/wm831x-core.c @@ -114,6 +114,8 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg) * The WM831x has a user key preventing writes to particularly * critical registers. This function locks those registers, * allowing writes to them. + * + * @wm831x: pointer to local driver data structure */ void wm831x_reg_lock(struct wm831x *wm831x) { @@ -140,6 +142,8 @@ EXPORT_SYMBOL_GPL(wm831x_reg_lock); * The WM831x has a user key preventing writes to particularly * critical registers. This function locks those registers, * preventing spurious writes. + * + * @wm831x: pointer to local driver data structure */ int wm831x_reg_unlock(struct wm831x *wm831x) {