From patchwork Thu Jun 25 06:46:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624665 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6DF090 for ; Thu, 25 Jun 2020 06:48:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B04F6207FC for ; Thu, 25 Jun 2020 06:48:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RiJlxHhZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L3gPi0V6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B04F6207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jreIHboAKmdUnOcvkHjLqugkrrtSJ8s0+vJYZoQsqNE=; b=RiJlxHhZ+HTc9kwqtJ+ERh04v AXUKDO/fBodrN44047tUt1x+aeKtr8jkq39onCllm2eYHglLxba1ENq6az1nHPkpQu3084v7P2lvn H6/pjCoItwU1YINY/H5eVU9XuNIQH2q3kN54iYPBd664E0tvKfyMuSDSbSS4WsYmgJQGzIkFRNOj6 cSp8M8jf3ZudqD5e5PfYlc2DPkslnjvb7bZwh8pau7exiAgZz7lbypMCBMoqDpJaQot+DCDiYEPWE aHvQak+nbBO3WdFnnUu4UoZMd973dnJbNKE5htQDXLl4HqNPT93OQLn4d1mgdxgRlD50iC6NJDz5m qzgpyIZ8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLea-00005t-LT; Thu, 25 Jun 2020 06:46:32 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeT-0008V2-NG for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:26 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so1612109wrw.1 for ; Wed, 24 Jun 2020 23:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gpZUopdNGKoMuokzA38cWTWHt4qMbyx0+mhPHuM+Znc=; b=L3gPi0V6eWwUbjc0a7NWVYNxvmyjxoCjIHRVwhhbx3/PgBUBX1nYVYjjVo442aXOq1 6X+Rxq4jGsIwLTCBZApP2Rl/SureSgHXIaYxg9LovDj+bhfSXt3hSv90MX1xjfcHLEbP pizWIa2VTBVMWI6eNMnPoO4qath3LnLnEPgrrJ4dAIBvozmxRyuEBNn35Sv9RQVY/0Lg hVqcXYlSA2h6mWAEMsGoEiG/cyjNbXgHy0dMkxXGJQjFqwHHP6PZSwCZU5izFBVnfokC WU1eXhZiZYr6t2/pu9Ce3tAAE6tpfZME71ChHW0a72v/TfEzY4id8vKP2OrKnEGANJQQ 3D8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gpZUopdNGKoMuokzA38cWTWHt4qMbyx0+mhPHuM+Znc=; b=TSdryaqvTWM5lf3u0+S7XkJwOz1nYAAlC/5/H3/YLjIgrEa0tq4QumUByEKJn1XL/4 TQvMnZnatuc1QCkvvGbX6j8BgeagWTaBoXpj0F91O8aL/XHk74PVOOdZAaTq7xnpuAfG +C3hW9Y4JbSjYQzVlOi6GQ9uo6PRjcXYuuL3AbEFXfT2mP0Ukq/UCJKJ50Rafmo3fYMC FIiqPBPJVMZsG+mE2Jm+dHfvpo4hu2hJg5dxJHoxB275cWzKVsLFN2Avfmld6UHtFqp0 EILUdyhUhB2E8vJk9ie2yR6DPHJI1ALzuVXukvQ+PPucgeaTnCdibAphXJVUBlSkmCAH H+cA== X-Gm-Message-State: AOAM5305zVt3Uz4Ps1bO49a3mCasb36GGI5nGDAwmpA8MFfa3I0ZzPDv /EVaxyAfy2BF4wo0PzudYGfdq2B66O4= X-Google-Smtp-Source: ABdhPJzMnG23PTfD5iHcY4F5ksyIND4PVZ3+d2rvuDhBikSUcprsL4BwlP+KBch0OuudWQn4B9nZfA== X-Received: by 2002:a5d:62cd:: with SMTP id o13mr23631593wrv.272.1593067584905; Wed, 24 Jun 2020 23:46:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:24 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices() Date: Thu, 25 Jun 2020 07:46:11 +0100 Message-Id: <20200625064619.2775707-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'dev' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'id' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'cells' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'n_devs' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'mem_base' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'irq_base' not described in 'devm_mfd_add_devices' drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'domain' not described in 'devm_mfd_add_devices' Cc: Signed-off-by: Lee Jones --- drivers/mfd/mfd-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index f5a73af60dd40..720e5c8b1588c 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -318,6 +318,16 @@ static void devm_mfd_dev_release(struct device *dev, void *res) * Returns 0 on success or an appropriate negative error number on failure. * All child-devices of the MFD will automatically be removed when it gets * unbinded. + * + * @dev: Pointer to parent device. + * @id: Can be PLATFORM_DEVID_AUTO to let the Platform API take care + * of device numbering, or will be added to a device's cell_id. + * @cells: Array of (struct mfd_cell)s describing child devices. + * @n_devs: Number of child devices to register. + * @mem_base: Parent register range resource for child devices. + * @irq_base: Base of the range of virtual interrupt numbers allocated for + * this MFD device. Unused if @domain is specified. + * @domain: Interrupt domain to create mappings for hardware interrupts. */ int devm_mfd_add_devices(struct device *dev, int id, const struct mfd_cell *cells, int n_devs, From patchwork Thu Jun 25 06:46:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624667 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0FF514F6 for ; Thu, 25 Jun 2020 06:48:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AABFF20773 for ; Thu, 25 Jun 2020 06:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UV7Rdfuk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y8Xeawii" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AABFF20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZA2iRmmH5DI+KunOj0lIYNsu+n9tB6wpHQ4n8chBCzo=; b=UV7Rdfukwx9gPSMcLuX1neL/A VDno+00HrPBWobaCF1WSBZFWHWT287kkRJ6PKQVjU6CwVCyA9T+LsYg6a1q6wWut4B1BcvOGDsVfd ZeKvg6v3DcGYrPJdlt3TXR4d0VvsDW+74VUvYOicr745aJjnPbIRNKyxx83wAM7tPzroFuJ2T6fl1 byEfcQCKA65KF5jmMf+JOMu1uYA8SMJPES/ALV7i33frg+cfZtzT0A6fkssONCtWxQgVkuXmPkDbD cbbpwQgz6oks9gdrl/BU1AgploE/Z7yDM207ZpqqTnqcbnVfSIItdlIZgx9Eu3uyQ0lASQvaPxvLo vt5/L0zGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLek-00009V-UV; Thu, 25 Jun 2020 06:46:43 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeW-0008Vn-4n for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:28 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so4573217wrw.12 for ; Wed, 24 Jun 2020 23:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1zDIqOBuX/K9nmAOrSn0q1L2wjLhGu0LGpqC1FRybjM=; b=Y8Xeawii/FenN4QcJc/IU0tymI/82VPhOUVQnNDaPq1E1ZUSPPJGiqS/MwnjdXwHqF DvzQqbo+ZusoZvWe7XMRMfOASefHh3I5kfGUIJesheA46gvTr9m5Bqd+xZteU8fuyZhP JSMH36/+uTAtUSckplXY/J74fUfskmrkT+h4Rhi+lPqKjkcu4Wns0XCu97A4qjsByUoy jz6zZaDVI542NxSheQJrNCq2C4ZWaDr3ZAnsBJYX3DPUVqApykF4HUHAiUYbaN/9wj+i v6qGmM7UjH2mb2rrDfpY33gZQo57z3084ZjyupmsBOU9C1cwoWJFWcQi9s8RezQqnSAO XnhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1zDIqOBuX/K9nmAOrSn0q1L2wjLhGu0LGpqC1FRybjM=; b=WX8PBRhWbw9ml9Bt0PvvH7Osus3P+N6HaxIN3j4xSitL+AMI+hmbnUQW2jWy7IzqBS cDqj3Lg1JKOmz0SRJiHmCrXOWrrbvu17mTRJGltQ0Ww5MrUGG/O88D4phx2LjzEu95ov 0HqqT4bKBVwn4HPa50kJuScs3qHtKH6SXizzN5GAVdz32Efm2ELygUjCnITVx7K/InHy JYbsBTRtjVlXTKlm/AdmdsHMYtJl8f0ySPA1RkOJwg2oiml15Zm8nV7g6j44DlzunJgY VdC49uiGBUVFfoUabU5vUKJTUOyHXq4EDmB/ZIrR5HxoJP4yidfUaIkJXJ4NQRvhBQoQ EQdw== X-Gm-Message-State: AOAM5317Yn6bcNDD15VbCsPackYn1Ay8gz5lgNKPcA5W1AHWSKSLzG89 1dCuu4ICzXqGIf/NeiRxECGTSw== X-Google-Smtp-Source: ABdhPJxEEnd+kP3e/yI6hTgHbHGpzO3CUk9z4hOSjDsZ9PiZZ75O0/GISD/HaIfyxC2QMquELbwWWA== X-Received: by 2002:adf:828b:: with SMTP id 11mr37504223wrc.58.1593067586920; Wed, 24 Jun 2020 23:46:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:26 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc Date: Thu, 25 Jun 2020 07:46:12 +0100 Message-Id: <20200625064619.2775707-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Each function parameter should be documented in kerneldoc format. Squashes the following W=1 warnings: drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset' drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter or member 'pdev' not described in 'db8500_prcmu_probe' Cc: Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/mfd/db8500-prcmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 0452b43b04232..9b58b02967638 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -2276,6 +2276,8 @@ bool db8500_prcmu_is_ac_wake_requested(void) * * Saves the reset reason code and then sets the APE_SOFTRST register which * fires interrupt to fw + * + * @reset_code: The reason for system reset */ void db8500_prcmu_system_reset(u16 reset_code) { From patchwork Thu Jun 25 06:46:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624669 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B003E90 for ; Thu, 25 Jun 2020 06:48:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8669B20773 for ; Thu, 25 Jun 2020 06:48:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Idl305Fd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="va0D27Lt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8669B20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k7tRRM2oblBY3v/22fQUEn34fa4LfXXB5E797KusKVA=; b=Idl305FdMu3e7FOsUYn7MqExt rbBZgdrD8vnPAFAD8oYoIHv4nTphFnkETVyTiRYHalcEbePdZ0jOq3tgs9SM1wYZqOcJB2G+t2Prh v2AGgJUdpAwczx2HX1ZIwLHsfnI/lyyPn4RVPakLl3eGpENBAcNeMlYXfKQCv2na91RQZMvUg18iu 2hfQTWvnaa4Uyhg5XcVwwnDxcQojWGmgNFxAzwvCpOMIDuFsdodJtQ0zwT2x6RkndAiKvuKsoBG38 ZmO3BIvk++Hyh7mczSeN4340w/MOR57Z/eCeB9caaLPnZLIbr13zW987JM8H9gaK7Xn7vvD85Ph/q fsGQXwwIg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeq-0000CE-D7; Thu, 25 Jun 2020 06:46:48 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeZ-00005k-VQ for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:32 +0000 Received: by mail-wm1-x343.google.com with SMTP id 17so4744511wmo.1 for ; Wed, 24 Jun 2020 23:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o2mKsGbb/PtyAVg9ggk1Hz11lyz25s2kgotXpuPO+cU=; b=va0D27LtDcF26UdSeyL0kkvFbOHBO1SeIpvY5r8WAMDpK/CuCoK6gWg7iSvitAeRaA ryg7SmradwXnqeEyywbJGFve2MOz/IujZphJ+CKI08KZftt8JvUgjx3ALYfqDAdSExgd HFdT4fk2Ys9jpWVzhGrmy6a9OlzwxMTl/hUthhMkgSFKi1SIOa6GcBG9oyZcebXLBZip m41Z5wANw8Seya5ZA7FXHiz7X8tSKqWX8afSxQcytVP36TcVt6gAXVYiuDMDmDzfss/o IYL49zByXMBr9NcuNAqRE9msPHvNrfyCmu1lgqgRm+/WycTKKMpJ0a+kxAcG5smLTvte pT5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o2mKsGbb/PtyAVg9ggk1Hz11lyz25s2kgotXpuPO+cU=; b=WpUxlstNE615ek1IGBjUTKMPIh8dhykan5qHZaYRrB6cYb895n1ZduJWZQ9TCOEROg LnlwZHHVQjhggvHAVUHN4Oyxuje+0n/iE29xkOT2ZYb1CDjCxQdopJ2MmjKiw4+Z+Gez qcC5C1MX92WCGtw/FK0QAE5Nu8cLcXrK4iyI5UPhddfOYICe/NwsKCc2olZkgx8R52da wGUmgewm5wbIOily1H9U7WJF9PLRmGK/1T8bWA8f1a7cTfSJdut1RdIH+3JZwBOQ7OBp cJPZObXAv6kqFg6QP6I3lKrYqPjaofwefMQK7SYIILhfpfm49EyLo9SyzljkFlTtD8vm Y+5g== X-Gm-Message-State: AOAM530PKbXHngLx4z92Rn5+29aHJgkvC0H4Wdc7CVtDne/D1Gg5vnu6 aakqwJDbyprPH/mvTU17aglKmQ== X-Google-Smtp-Source: ABdhPJyhOlpqerGDG90ewZ1q/iBssKLA4GRwer9f7Kth+G9Ad0uiipRFOOtXx5GsQxexwKswpwtZRw== X-Received: by 2002:a1c:2901:: with SMTP id p1mr1744242wmp.144.1593067590752; Wed, 24 Jun 2020 23:46:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:30 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function Date: Thu, 25 Jun 2020 07:46:13 +0100 Message-Id: <20200625064619.2775707-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Not only is the current header incorrect, the isn't actually a need to document the ubiquitous platform probe call. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/mfd/db8500-prcmu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 9b58b02967638..a9d9c1cdf546b 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -3006,10 +3006,6 @@ static int db8500_prcmu_register_ab8500(struct device *parent) return mfd_add_devices(parent, 0, ab850x_cell, 1, NULL, 0, NULL); } -/** - * prcmu_fw_init - arch init call for the Linux PRCMU fw init logic - * - */ static int db8500_prcmu_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; From patchwork Thu Jun 25 06:46:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624671 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2423514F6 for ; Thu, 25 Jun 2020 06:48:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F14AD20773 for ; Thu, 25 Jun 2020 06:48:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JZPjIaua"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jAVR5eoy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F14AD20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=51pGNkWmiK5RnGT6bBl0h9uuthpyZkxI6gqgTyw8YYQ=; b=JZPjIauaLS3do9H0XcDK8Kk1r HGOG9DzDxhhFRZhbRfsUgJVMAGlxy56yVBaMu3e6dtUtZC1VRvI+RBCnLMoQO7e5lrDfwgy2jT+IX /5glVbpYFDIN10ZotPcjAvfikmzmNTe8OKG3dJN9j6Fgxg2Qvf6u1cfFO2Yz8dVmfCKM2yVMM/ff5 xPHJOR9hz0qiPPfs3dRoABeqK/PjUG/ng5R5IbhANiPOA9G1WFzH6/aBnInd+YBVrgbeLK+bUv80y mTju6krXZDnXI3Xu/5h/dhZqwWbnQj7yGc40KUMyjsuAF3KXlvv+bM405Wy+UK0po96ca3Eydwl7N DhhaBzGdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeu-0000Ex-1f; Thu, 25 Jun 2020 06:46:52 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLea-000060-LY for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:33 +0000 Received: by mail-wm1-x343.google.com with SMTP id j18so4412614wmi.3 for ; Wed, 24 Jun 2020 23:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zFD+XYh0LbdyDPIgjJ6ML5H3hXoar7p4uFfuKLbk0ZA=; b=jAVR5eoyrmVKjLEHNqfjCNWanaCYTE8ppNlexuZG9che0RL0uhWQj0j1YU5wDQgiB2 XxrXcc5uE085/9qsTkTpk2XicffwrBGGolaOz3pSHPcANX/VXJO3NcsEvj/CjpkIDpYq Q3uXB5Y94Cd9PoRDMEZTfc2n3h2txHH6s5g64wtshhSl8eZGhOHM5VvLNYbdwtut8zjf SHmv0HSTQc3SOI81N9Hl/EIU4+S2YDJJin++zw4JooKAF6IG7Tz/GhIVJ2tlE5mHG9XM kU1qAEaskZkY0Jz/u9LZHE9tEDf4/lcq6JOS+Bt0SaLzhLaG1eGh1Rb50sae3rOuvipu FWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zFD+XYh0LbdyDPIgjJ6ML5H3hXoar7p4uFfuKLbk0ZA=; b=hUa4O0DEr2X3BTodW6RNlEQsg3WHKcyLATQiKPhC2fOZ83HH1cZUxS2HBCbBIm5tB0 hpbvG0XR+X1O/6yaHq8r8ERleqgoGhr4OfWEhxzr54TraFdU9DchGGNs5kOJmqk6uJJS oUScVw3qlqNRaXzJUmOHcWeCTZ/GGgvL9+hNs0mRS5lTX9pf+DrQ/fwhDdK0AaAFUdc2 sOEF7dt0RlgqaSanzwvyNjCe32V7411x/Bt5ZqCEpsZPCwByun1R7BCCn9t9GMEOLs8l FzI5z5sF3hhvKCBni5G3qWzSxriD2u1vBb1097RBl3+qkPJUAluX4LfyZ+W/NUXzZmbY 4qCA== X-Gm-Message-State: AOAM532+PN8mnMcgIMlPFvBHZqqS70R9NbCJkpbM+Z8QFSxHX1CW2QFZ YHOiBThSqqGK7g8N/G2S0GS6lg== X-Google-Smtp-Source: ABdhPJwMgZfQzBCeFoiLZTJnp/x4vgmn7WMj1vkUKS/+Lm7IeVtJH2PwgM57kLDLfxA35mh6mWhlMA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr1785713wmg.118.1593067591825; Wed, 24 Jun 2020 23:46:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:31 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/10] mfd: omap-usb-host: Remove invalid use of kerneldoc syntax Date: Thu, 25 Jun 2020 07:46:14 +0100 Message-Id: <20200625064619.2775707-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Keshava Munegowda , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/mfd/omap-usb-host.c:128: warning: cannot understand function prototype: 'const char * const port_modes[] = ' Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/omap-usb-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 1f4f01b02d98c..f56cdf3149dc0 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -120,7 +120,7 @@ static inline u32 usbhs_read(void __iomem *base, u32 reg) /*-------------------------------------------------------------------------*/ -/** +/* * Map 'enum usbhs_omap_port_mode' found in * to the device tree binding portN-mode found in * 'Documentation/devicetree/bindings/mfd/omap-usb-host.txt' From patchwork Thu Jun 25 06:46:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624673 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F31E490 for ; Thu, 25 Jun 2020 06:48:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCBCB207E8 for ; Thu, 25 Jun 2020 06:48:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Al9ZAG8Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pGhwHR37" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCBCB207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a0y+wgaBR1KXirGApJPvPaHabX8ZSnkpdk68JfgcyNo=; b=Al9ZAG8ZsUZysk3LwsKdHzzDo kB2c7K0ibOjQQwZVIqIltDY71b/cU/r0fGZFIB4OgV9na1SpIwTVFY6G6F1iR11AV8Tgtc3xA2cX6 QcdZB/mbPhgYdrdBBODufyHh2CP2FQmMMH9Zl51JsQypYqGEwto8S+4bcxnZzeofLcnK7CsdWq55Q 6k0maSXEITsgaLRkw9i3Y0Q1qvks+LwDNSSAK1yADhNTtsj8pnEU/bf2jXhW+7prhdblsgzpTpidF sIwwuNoDs1RduLMBooa3ddRzPCCl7rvbHnqXJsX7QpJ6Kiu4SiKb/UnE1jXYQY0qwNJpgHgYCcFtW zApSce0jw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLew-0000KA-Ti; Thu, 25 Jun 2020 06:46:54 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLec-00006Z-0j for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:35 +0000 Received: by mail-wr1-x443.google.com with SMTP id a6so4611456wrm.4 for ; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+TE9kOk1Eo+Xge5t3lOhgSjVuYsSynXXEjCl45jZ/BE=; b=pGhwHR37tt09Kl/bFu1zOX6lNU6Dnj8LyCDuRPVubE+Z3M1gSrffbY1VbW9qfSaXiE CNdyWz9lJ0fYj2v5+22h8s0YXCpzND9580Dayad1kycUDReg+D/IhrDU/NO5omUJyCSS xU0riBAU+Vh4SJ/wHhIK/ZIpZTtQ5Onz2zI56sZxmVNSSRIV4b4DZ8c9HqWT7dlLN5sz Y7Aq86j9bH3VV4sB9SdCoQ8+MSmCO8TU6TZDLq8+hT02COCOq7IXFrO0ZftW8FWes2gN zulTt3y1vQ7kc9cNSnHlyPIHjPzBedtVnrUfpSSW0Y0qv6ls8pctACHJYSlHtWv6s8iz bjvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+TE9kOk1Eo+Xge5t3lOhgSjVuYsSynXXEjCl45jZ/BE=; b=lOJxVO9giFqJaI+tdjqXM5ZMshOgqFGCuxfKmf6M00ZZhX7Wncf43k0cii3XdOc3/L vIEWIvMyOjY8J/khpc5d6LV7ETQk+pPtX7EYqHQojMdWs/1yCIN6H2oA9c4sqTXeELG/ MkvbCcK41EEfZ9Wbsq5c7lSppXRhYq8PuPhUnqhPCh0wniLo8L3g8llUNndqcb7Ogxly RFNRYvDDfJY65UVueQWzoawJ+AfQXj1GOoQFc5GNkX0d7s4yAHwAL4uQO124AdXa90Mq 64kGbqCRl/qCJ1gFHOfw2ZEv8/XFQML+pNQdaEGZF9JxcyvjPOfZ7LmGSREH8XXPL7FQ MoMg== X-Gm-Message-State: AOAM5301OwKq0d8KKd0COLfIyfuucVQORPoLJhG+DdM9wSs+ujqQnw7l XdmFrSGK6FdbDY+ypBB64SzG+g== X-Google-Smtp-Source: ABdhPJytxUMgGBVPUzM3IOR72zdB3gVcybqT84W3fTE4JkO2L+7Fo++7itDizMNwfNXl2gA3TPz5/A== X-Received: by 2002:adf:e749:: with SMTP id c9mr37817613wrn.25.1593067592886; Wed, 24 Jun 2020 23:46:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:32 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/10] mfd: omap-usb-host: Provide description for 'pdev' argument to .probe() Date: Thu, 25 Jun 2020 07:46:15 +0100 Message-Id: <20200625064619.2775707-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Keshava Munegowda , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Arg descriptions required. Prevents warnings like: drivers/mfd/omap-usb-host.c:531: warning: Function parameter or member 'pdev' not described in 'usbhs_omap_probe' Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/omap-usb-host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index f56cdf3149dc0..aca5a160c1b24 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -526,6 +526,8 @@ static const struct of_device_id usbhs_child_match_table[] = { * usbhs_omap_probe - initialize TI-based HCDs * * Allocates basic resources for this USB host controller. + * + * @pdev: Pointer to this device's platform device structure */ static int usbhs_omap_probe(struct platform_device *pdev) { From patchwork Thu Jun 25 06:46:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624679 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0FFEE14F6 for ; Thu, 25 Jun 2020 06:48:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D814C20773 for ; Thu, 25 Jun 2020 06:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tBFMTcnq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L97XwVAL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D814C20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SyxUtsp0Y7XNCtM5j+Y3aDip5E3YhE7elvvpFc3BlDA=; b=tBFMTcnqQSTC/4ln1ZQuhwp7t x9DbmGskvIpwMb9lWU2silMyggdKq42L+yI1/mcBG2+Cp2Of7va0V/8DiyXH5CramKBkZ4zMlXeYn UpmoqO+Cl7KVZitom1dPFRvqArWaaunsvh5N6S+hEAjiKNS5vzhs33fzn5ltEqonxhB36EeXmUSKT uP3I8dL5nRiWm4iIHNqKDhmFGh01hV17v0BJA09Q5TPC0eFEziQ+vzzUwSPXksDF9nT/XNH8awTPV GBkEt+Io22F43UmcSs+WjhEtSG/zeXYimm7m86Vunf9Wyoyx11p9QrISXx3VH2upYOSBT487wHPgB P21E0ErDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLez-0000Le-R7; Thu, 25 Jun 2020 06:46:57 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLec-00006q-Qg for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:35 +0000 Received: by mail-wr1-x442.google.com with SMTP id o11so4591106wrv.9 for ; Wed, 24 Jun 2020 23:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PPkLe9A2c/a37hUly+zrhj0g8oPWNS5BWdFQdlxMTw8=; b=L97XwVALwtGB8lb0Ydl/Uxoxe8raykVlOYBYqzU4heUsw5RqxnPa3z8xLxPGWvfAbA plswBX//r6jz0dXg4KLn3wKD4CaHKrhY7iF7sZeT+RbpUrmY42yepOoZx+MVPjI225VO nNLGFSiojX+A97815KN5agb2E/kLbUdBcCIdOvBxdrbFrtff1TdCLeB8peWn7SoyItYh +VcxpYleMeIQH9oOuZf7wTN5wh42l2Ev54zBug8m3GmfyWSt07q2LFyenksyBaHsSM77 EfhCIV6FZbyzHXCZ9HClXrK8R8qZxKM4nHdlXz4ut6uL1CY+62i4UYro1xNOXDO4L9dY IyGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PPkLe9A2c/a37hUly+zrhj0g8oPWNS5BWdFQdlxMTw8=; b=BaNjI+D0xH4GGe/CLCUJmz1dub699k0+nYsvL4C+ha3szfnag6h/2MRpOxcqYI9WYT 5lZXtU44eBfJOAUHHHnWgEeMY423wQk3EyDj+59jLrcN0VRteIUS1Z/aX3MHujjZ863Z CehHF2QwxfCFKCITe+zpk/httqVQFtIOpI6jy+AYh/l4A3ydE1xRKMejjATMpoX7SdLH 6T7TZqy8Dnqg/mlGSDdxgF4jc55dJebESziHYpMAnfV7diklH06taydqGG3jPlHQ+dVd NnCMAUgIvcixKTbGraDByNPiKKWvmWcsILpHs57fHXECzLCMJz04IpsQtUsWmoPVpjKJ FWJg== X-Gm-Message-State: AOAM533ssFPFFWGW9pwCoSV5SkGRUpL0HtCA8UuaDf9J/fRyz50G8BLX DdQHRvqMGU5/qKLgDDBz0OOIuw== X-Google-Smtp-Source: ABdhPJx0uw9TCSRR+V93tjiW3ToHdg6Sqq5aiNebHk420Mimxl1+ayhEO9bw8440/cK3hU1Save1sw== X-Received: by 2002:adf:f54b:: with SMTP id j11mr19439037wrp.206.1593067593835; Wed, 24 Jun 2020 23:46:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:33 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/10] mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe() Date: Thu, 25 Jun 2020 07:46:16 +0100 Message-Id: <20200625064619.2775707-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Keshava Munegowda , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Arg descriptions required. Prevents warnings like: drivers/mfd/omap-usb-tll.c:204: warning: Function parameter or member 'pdev' not described in 'usbtll_omap_probe Cc: Cc: Tony Lindgren Cc: Keshava Munegowda Cc: Roger Quadros Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mfd/omap-usb-tll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 4b7f73c317e87..04a444007cf4e 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -199,6 +199,8 @@ static unsigned ohci_omap3_fslsmode(enum usbhs_omap_port_mode mode) * usbtll_omap_probe - initialize TI-based HCDs * * Allocates basic resources for this USB host controller. + * + * @pdev: Pointer to this device's platform device structure */ static int usbtll_omap_probe(struct platform_device *pdev) { From patchwork Thu Jun 25 06:46:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624677 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1C1490 for ; Thu, 25 Jun 2020 06:48:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53F7E20773 for ; Thu, 25 Jun 2020 06:48:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W7ESBZbQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BoR0BVfF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53F7E20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r2TfmwDBMhzHTzEJmhfWkk+/rWKoS4IedMJ9M2DonLY=; b=W7ESBZbQrK6FFpbiqK9TNLhA+ KrhIr4UEGJi0JBhW0XyIZojO7FedzoR4Ueubv712RP2wKLjy8aLwuONQUQQUDcxsF6CI/M3dbvYgg u/ihRR3H29bSRXlJjkHJChQROZP/wjiiAmcmvq/5skMl/BnY8nrjgIIBcCNzjQHNgq6ljqaOhyJBV ZRa9jMBlW1CTz84vfvTCmSeNtMjDP9fzXRdifV6Cv4n/3DX8TfWN2uaOGTR8JTK8GsfC/nAixO42e nM2x2X0NwwNFD72V63m38C4LXlpd1iHPDyJ+ZeWbk2NHUg7Li/4rLfr2RcwkRJPP2YLievGKaHdBp ISgSRuG8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLf4-0000Pp-P2; Thu, 25 Jun 2020 06:47:02 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLee-00007O-AB for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:37 +0000 Received: by mail-wm1-x342.google.com with SMTP id 22so4424230wmg.1 for ; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZzLtCVZ0xnD69Tq7rrN3k4RXzAsRLvX+l/b23e7w5no=; b=BoR0BVfFhS9za/tBEuj3YkwiY8nNI24M8p9fmhuCM6IiYJIEKM/q4XFtIYaAjPe2Dk +nz7AdEJTpAE6Z+mq1fY/goiHr+ULfYi+dRbajh5fVCoRPVr0Q+zoCiJpLRmGQXpi0nF hp5QBIuI6XCJpSCjUX0V3zfIn+ZbWxvJgbgmtqBW+2vkICODU7hu8BBVpkSerVZbYksH 3F+0fRc9wCbqjlgJjwvTx76agAqHN5CXzt9RhogHKW0HMD0Hsdt+C+QgFL5edj3pUqh/ qEeWE5X1U9a0rI6T84EX3KqVH/ST5X+6bwNw57W9gxqGVfLBP9icFRkYY03DiWqvKjBD zDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZzLtCVZ0xnD69Tq7rrN3k4RXzAsRLvX+l/b23e7w5no=; b=fDrzNEEaF791OQB0qZ2zwYB+SHjGD5PefQKVBffR7REFv59itKTWdZOW5iX6wSqpap tPWhC0xcx5AbYXNAuri2AAklL71jwma7RX4qD2IabgWRxa4sOM9gY3ukbBwSqlNxe/Cz KbxDgJ7RjNzWEsdxA2o/1X0h9Hn6nSL678Q17fl1K2dUG/aAn+XWbr8DPxwKtC9/xYk6 d7UBq9nGmNabV4W4hZPTsomLlxzcD7eLUuYqRaj7aJEv5oI/6+yT4nCxK3ANv/2eMt4f l6d9zR5b7s7upIIEdNg38XhcSlNR/IfbwvFfj0UriWGPPBLWhKjUqrdsQpJyA3ou2Y63 /Pfw== X-Gm-Message-State: AOAM5306mFBkE/XOjlkwsDO3r5MjBevh2qsaLZpljHp9+o63Xg9yuHcQ WzaUU3a9c5+wzLBqBXQzHLZPmg== X-Google-Smtp-Source: ABdhPJwbgPCP3KuminY9vt8AVhB+YH09uHBBW5EhL/706W7PsYH5XWdLmpQqngWOkPmCwNX2J/EVng== X-Received: by 2002:a1c:de07:: with SMTP id v7mr1737470wmg.56.1593067595221; Wed, 24 Jun 2020 23:46:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:34 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1) Date: Thu, 25 Jun 2020 07:46:17 +0100 Message-Id: <20200625064619.2775707-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Alexandre Belloni , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org GENMASK and it's callees conduct checking to ensure the passed parameters are valid. One of those checks is for '< 0'. So if an unsigned value is passed, in an invalid comparison takes place. Judging from the current code, it looks as though 'unsigned int' is the correct type to use, so simply cast these small values with no chance of being false negative to signed int for comparison/error checking purposes. Squashes the following W=1 warnings: In file included from /home/lee/projects/linux/kernel/include/linux/bits.h:23, from /home/lee/projects/linux/kernel/include/linux/bitops.h:5, from /home/lee/projects/linux/kernel/include/linux/kernel.h:12, from /home/lee/projects/linux/kernel/include/linux/mfd/syscon/atmel-smc.h:14, from /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:11: /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c: In function ‘atmel_smc_cs_encode_ncycles’: /home/lee/projects/linux/kernel/include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0))) | ^ /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’ 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:49:25: note: in expansion of macro ‘GENMASK’ 49 | unsigned int lsbmask = GENMASK(msbpos - 1, 0); | ^~~~~~~ /home/lee/projects/linux/kernel/include/linux/bits.h:26:40: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0))) | ^ /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’ 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) | ^ /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’ 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) | ^~~~~~~~~~~~~~~~~~~ Cc: Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Boris Brezillon Signed-off-by: Lee Jones --- drivers/mfd/atmel-smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c index 1fa2ec950e7df..17bbe9d1fa740 100644 --- a/drivers/mfd/atmel-smc.c +++ b/drivers/mfd/atmel-smc.c @@ -46,8 +46,8 @@ static int atmel_smc_cs_encode_ncycles(unsigned int ncycles, unsigned int msbfactor, unsigned int *encodedval) { - unsigned int lsbmask = GENMASK(msbpos - 1, 0); - unsigned int msbmask = GENMASK(msbwidth - 1, 0); + unsigned int lsbmask = GENMASK((int)msbpos - 1, 0); + unsigned int msbmask = GENMASK((int)msbwidth - 1, 0); unsigned int msb, lsb; int ret = 0; From patchwork Thu Jun 25 06:46:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624675 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D5A390 for ; Thu, 25 Jun 2020 06:48:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04B5820773 for ; Thu, 25 Jun 2020 06:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1JjnOFV8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MVXl0wtg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04B5820773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y019kGeRJWloi4stcu28PMjA7+OpiI0EWHPSmS0n2CQ=; b=1JjnOFV8w0GS8P0Fm5Zac2Lsv 4Mk+BjifmU6H7oG8c9e4FRwEmCm9+tdwnfkbwJrrCrxyzXZwU4FLev27h7aQm9ZZMDkSIdfD+5kUw +4XP6aE4Bo7vui4VmImiJKAETemJzlivI2s38KSpfhwWeaDTVgTMBCN0hynSq70OkEj3WYWtMLfSb 8f7HbvOCPiV+dmGjgqgbQD20GyUjuo5FKSPogvwnhMr+o5VS6rfmSddaqLAXK2z5q7yOQ7EE0jx+o vber/WUt0jnoYHpTWQivTrg4Trz1VdiRSbQSa3x1PvplqdcbQboJK2hcHhj9iXHCkaIJQbPQqaGQf iD8bF6z3Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLfB-0000Ud-D0; Thu, 25 Jun 2020 06:47:09 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLef-00007k-1W for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:38 +0000 Received: by mail-wr1-x442.google.com with SMTP id a6so4611580wrm.4 for ; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J2LvBowpzfqfQHnK/gnFZDPalEMEwUf10cp2QuQIuRg=; b=MVXl0wtgTNbcqhYy50uwzSMS91a5du9fhzg4oeB/etwz+t21MCLhi+PSWsJnrEyp3H 37sCoamMGW5zxACUygyfAjblD0iWrElfagnCgzarbJmDFtDaBnfibzhRcELTWRTz6+f7 dAi5vForunxsCLorBb9k5irOYwFYlroFBnbYQ1jQfAosFB6pAR4irkMzKX7m8YjCMfG/ CtRLuLArlmcY/lmBV/bEL17oZ9ZujckJiDZXTLnMsNwn3W3g4RPRBmTy3T6cIdrOxqez DbK7Q3oChBAP1tW0xprzEo4N3hk/VQGb0VfV/LS1HQKjjxRD12nh6V7Q/w8KLxSkDACU DcAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J2LvBowpzfqfQHnK/gnFZDPalEMEwUf10cp2QuQIuRg=; b=AG7E3MYGCUa6jnxbC2kiEl9ThyWqK/R9jXQ2YTIZH9c+nyfRrvWBq7Yyn2HsIXgrBr wgeeSkzbPuOVpi/jZ9Q9LYXlMEz/cvrPzsbPVLxChUkLMWin89FUKXC/kS2D6IsuEpes NBJEV29/zusWnN5GPiNkIlFy/9axJhkuk4Ay+u8SRJWLKHMnAQwyx9EGytf8LYorRLLz 532fPpkIbssnkGdg0sP1gMQhWhC1J59lBqJpOarLqfk2XIbPofLuylaqRs1LptSdhOah lrPd+my/yoWpwGM4PfW+gz5YHO1jR+M+PxN3s5YIFyqjzlfk/M8e+7P85umREW+mMLFV zJbw== X-Gm-Message-State: AOAM5329/m7uyiOaveWWOYFK/93R8auyj+IwbnsteEnmbRtdaR/9UqOn DCOewInzlAqCQ2isiR1eMtuvaQ== X-Google-Smtp-Source: ABdhPJz8KzvsZKFGSyJkJ71Ru54KSb6+CeeKrbaJt/6Ar9O5KO9HCidzIoTFO4ALy3HXGkPV6umT0A== X-Received: by 2002:adf:8091:: with SMTP id 17mr33043279wrl.244.1593067596171; Wed, 24 Jun 2020 23:46:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments Date: Thu, 25 Jun 2020 07:46:18 +0100 Message-Id: <20200625064619.2775707-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Alexandre Belloni , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc valication gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply' drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply' Cc: Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Boris Brezillon Signed-off-by: Lee Jones Reviewed-by: Alexandre Belloni --- drivers/mfd/atmel-smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c index 17bbe9d1fa740..4aac96d213369 100644 --- a/drivers/mfd/atmel-smc.c +++ b/drivers/mfd/atmel-smc.c @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle); * atmel_smc_cs_conf_apply - apply an SMC CS conf * @regmap: the SMC regmap * @cs: the CS id - * @conf the SMC CS conf to apply + * @conf: the SMC CS conf to apply * * Applies an SMC CS configuration. * Only valid on at91sam9/avr32 SoCs. @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply); * @regmap: the HSMC regmap * @cs: the CS id * @layout: the layout of registers - * @conf the SMC CS conf to apply + * @conf: the SMC CS conf to apply * * Applies an SMC CS configuration. * Only valid on post-sama5 SoCs. From patchwork Thu Jun 25 06:46:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11624681 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3B79C90 for ; Thu, 25 Jun 2020 06:49:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1365420773 for ; Thu, 25 Jun 2020 06:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Imv+cWfI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="glb++HtS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1365420773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J5oU6vxdrRaHYjDb32maTI0ZVSJ0kP7pLGJsI79MWdY=; b=Imv+cWfIUQ5sEV5N0lNRtLqzM Ej3y19eGsFkplGP9b3VwMpkt9O8dkZTJezGFoLKGyc6sFDP49quVXvz4aK5pOsH9G3eBQhBcRczzj 6DyfX4PsGEsxkAsAfX98TF2XR6iXjz+ke74pG5rTNj7IxIF+60sfN2TLcoPpLB3pO5UVSdbT2HpAr 4IMseQETrLSvFTJTKzkIlsXlbYjR/RBy4DzTSP/TDf2Aw0qWEwQTZjlgOr1nYJpKfQtmgdIoJebNW 7I/3xQ41ZI3zZVLwR7WPJ60sBlpgOcQl3lnfEDbr7ichr4K4br2ZgIUXHhKCDugmF9Y+qQyPHEWjX OGQ45I+Sg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLfH-0000Z4-JP; Thu, 25 Jun 2020 06:47:15 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joLeg-00008D-3K for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 06:46:38 +0000 Received: by mail-wr1-x441.google.com with SMTP id h5so4603984wrc.7 for ; Wed, 24 Jun 2020 23:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bh7BIJEoFgjXHqYRkwppX22NHiJGTlWMxnnDJ2K7EXk=; b=glb++HtS7oZWTpXDAzu7GckwXl1mrcYHW8RG3vTiRLcrJP0l7bKna80fqlxmkNdFuI WtsEu8LgvypecW54tymX3u8xbDuWXwH15K8LxtUmwAnB5XGefq2pMyX5ndzdlS78CuO6 X8YwtelBuFGRwp5DX/Lg1xCuSkc+Gue1l6Ue7pWro9xfXnmYiRXceFTqupqzt+vGtjDT +jbyK+D9fFbDRc+8XfgTfi+DfbyNx+U0gVeA3dnVYIMm4bPGVm/BWPyspiJbOZd5LODD 3QuaAbe8tuiikxunA1ERhVLZ1r718Dkld9We079Otb5DKfuJKCICePZjxmw2lQLBaD1m DHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bh7BIJEoFgjXHqYRkwppX22NHiJGTlWMxnnDJ2K7EXk=; b=sV6U6Z0QA5a0mIU+WuFe5uKjtr9t1yPD3ZG5Z+TytHL93BnRoXdmyzPKuOF4VwUVrL h+a8FNuwsTFAqHZEU28qqPGW6ySvcSj65qE9JqfYxaaJ/x84ueoxCyUEol0zJNhEeaIb +AE4RwmnL2xe+yxp7ublW2ciDolBO12j405No/zdzUYrlVUVTxi27eiQeMiqTKzkprRy U+h8JfMqENICHZyWlpuUaClbBDqqDUigu9oPwGvJMqJzivbHbcddcUoZ+7DNPLMZdoYq VmxJHgxxjjA/D2UpRVfILUoAhnpHm5NSIIhN3Zz5a7h8QA9jQoFH51W7bRG7WxWkmy2y sx8A== X-Gm-Message-State: AOAM530pxvJHIRWdM0728MxM6u74aCl9jS/7Hsc3Vinu1gs7YUWXaMPF REMF7oOXej5MHF1vyA6rocvLBQ== X-Google-Smtp-Source: ABdhPJz7hX/Z2JM0lOGHssb5FyeBBY2iFs7Z9tsdVrKKfbPW5vOlTRxleyhOq9BreaGxFEv4RwYsQA== X-Received: by 2002:a5d:6802:: with SMTP id w2mr8325231wru.88.1593067597162; Wed, 24 Jun 2020 23:46:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c20sm27235363wrb.65.2020.06.24.23.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 23:46:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args Date: Thu, 25 Jun 2020 07:46:19 +0100 Message-Id: <20200625064619.2775707-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625064619.2775707-1-lee.jones@linaro.org> References: <20200625064619.2775707-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Thor Thayer , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc syntax is used, but not complete. Arg descriptions are required. Fixes the following W=1 build warnings: drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle' drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'property' not described in 'altr_sysmgr_regmap_lookup_by_phandle' Cc: Cc: Thor Thayer Signed-off-by: Lee Jones --- drivers/mfd/altera-sysmgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index 83f0765f819b0..41076d121dd54 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -89,6 +89,9 @@ static struct regmap_config altr_sysmgr_regmap_cfg = { * altr_sysmgr_regmap_lookup_by_phandle * Find the sysmgr previous configured in probe() and return regmap property. * Return: regmap if found or error if not found. + * + * @np: Pointer to device's Device Tree node + * @property: Device Tree property name which references the sysmgr */ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, const char *property)