From patchwork Mon Oct 15 10:55:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 10641543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31416109C for ; Mon, 15 Oct 2018 10:55:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DFA72934C for ; Mon, 15 Oct 2018 10:55:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1264629406; Mon, 15 Oct 2018 10:55:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA8482909B for ; Mon, 15 Oct 2018 10:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=bCJmI8EVTUIGw7XLK+CWR/tvmvfaQyKD78uqhpHSvNU=; b=QmT Pu3BesFoc6iFj3nePAP2AC89Jxblu1ptdGZGBRplYJv6yq1E/+S44FVl7xScs7kjgzV0ZMALi++ol sQ3OHEXWBkU42fkReLrm9TjcsMzhy9+lFBUwnIIZn1FQqicV+/MMRdgm90dzsSqvQOnRVtW9Jr7up yJ3Spa/Onvpq2RcECskc/8rhkQHNJEwKzXf3pFLhGprFjJeEHv6lwfUla6jpEM34lDzgNgDuFcKJS XAU/vqP0YBlCGJxFCktiauVTRDaJvxTpdRxHWryNQn0tQ/5sZhC3eP7yZnGKs4zFSHe76NUBDt+q+ aARcAt5jeQzQYI0C3+e56rlcS6pJe/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC0XJ-0007Wr-W7; Mon, 15 Oct 2018 10:55:46 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC0XF-0007VZ-DN for linux-arm-kernel@lists.infradead.org; Mon, 15 Oct 2018 10:55:43 +0000 Received: from localhost (p54B33719.dip0.t-ipconnect.de [84.179.55.25]) by pokefinder.org (Postfix) with ESMTPSA id 4C5102CF683; Mon, 15 Oct 2018 12:55:27 +0200 (CEST) From: Wolfram Sang To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RESEND] ARM: dma-mapping: update comment about handling dma_ops when detaching from IOMMU Date: Mon, 15 Oct 2018 12:55:17 +0200 Message-Id: <20181015105517.28032-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181015_035541_601033_FD9C4567 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , Russell King , Geert Uytterhoeven MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Update the comment because we don't set the pointer to NULL anymore. Also use the correct pointer name 'dma_ops' instead of 'dma_map_ops'. Fixes: 1874619a7df4 ("ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()") Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman --- arch/arm/mm/dma-mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 66566472c153..e3b04786838f 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -2287,7 +2287,7 @@ EXPORT_SYMBOL_GPL(arm_iommu_attach_device); * @dev: valid struct device pointer * * Detaches the provided device from a previously attached map. - * This voids the dma operations (dma_map_ops pointer) + * This overwrites the dma_ops pointer with appropriate non-IOMMU ops. */ void arm_iommu_detach_device(struct device *dev) {