From patchwork Thu Jun 25 16:36:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625711 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7492492A for ; Thu, 25 Jun 2020 16:38:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B8EE20775 for ; Thu, 25 Jun 2020 16:38:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PZIuohWd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FzK8AnU0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B8EE20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v75ST+5hydHvgBETamDTvVFtpXlWBTYLCFqWw/oWawc=; b=PZIuohWdXk183HqPBqBo+G8Qx bagNGduaj49HTLtaNbIlk5vhwWTR74dVa9IuIFbAK8YQqVAB2pJUOSwequDalqyjLxb3VFqcs7PC7 9SO1nIPCntn8oT3wD0y4zVyoqQ864z5tRl26FIEmtEZ3lwTi0PSCeOgGLkCNTA3tYfLAYBFu9RMjQ IJoTqR+WXqZtqnUvCBh9R65cw6vdDgtlKLJ+MRVan6CUA02dSUNXMpDQhbxr+8NSOXTp/tII72g2U XdDPhOHe42P6P4ZOM08l9Dy2EdhgXL35D9dqiHBb94pTNBPVZlAycROWgtWIf1UxJ9h76yPoGAORe A0AIfCGEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrr-0006Fa-8x; Thu, 25 Jun 2020 16:36:51 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrR-00065z-Po for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:26 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so7093979wmm.0 for ; Thu, 25 Jun 2020 09:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mHyTnFgFhenMvt82ZPvmID/k33g654vFpjxfq56glsw=; b=FzK8AnU0x8SaPN9hkqDc4OZY4o+OqxxYwOVuP5tgHwZy56E0V7VKPPd1SUF+EQ8QVq mVglrjvkMeNBBXl4+XwQaqKiwd+O+7lzdJVEU1GOSsY1J5BrJKz0QX2holhriq6vaYRV HoWTnJf+JS2towXY3YhxVhGHVonJy0o4fxau2JaDJiULGHxaRf+9lftb1jMv/c58RNNz r6mJu4Jpw088ypgdxZuWBZTWC9Ic1GN4zPVZKg9NLkXRi6xhfc6/asVLYjCa/hCQKpnc 9WtyAyhezLrDl8mVmKUOXMBZWTkOdXnwK7bA0IKzfN7TMz1RzhOBSPq36Xn+JwncLwQN IShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mHyTnFgFhenMvt82ZPvmID/k33g654vFpjxfq56glsw=; b=m3Dx5NZ/3pfjGUpqZxDN0UCeYyv855lmeHaq9XsgnSgRQny6uJlzuI48MGzRteIY5D BwHxWYIEnhLUi5wsOLYdHag8c+FssF0GEYehpEs7mtIa8YGd8SKvb35Y9qslFa5/bkmG 8R4hTobKal1FFoEQTvvaklUQLdAtmbAubRVpaIEpuqUSKXDClqK2NYkd+tDAgEWDHwyM oXogPBcI41gmJ1NXV8YVmLDlz80uSqTFFishwfTS8Z3HUouc2lNLuyZ8jZu/JlWJdX8Q nMt1MMu/xQ9eNoR0VjA+zmyb2m2IuJEJhi/2Zf11mLb+wm/hciY8w1A/fWbqWoe1eG+h oNDQ== X-Gm-Message-State: AOAM531aoIitxxZ/GIl1ff6K0cGw1LJYz2crHjbvltOqYjGqfn2+LEXj I1k3/oLTW6oN9pF0Y3JE+xUbYg== X-Google-Smtp-Source: ABdhPJyVaKgIFOh4fci2JoxsGrqpAosiXDp3roJ2/u2guPJCC0MBxFkIz4vGYBqu4hPheEIXpNi6aQ== X-Received: by 2002:a1c:a557:: with SMTP id o84mr4353457wme.42.1593102984711; Thu, 25 Jun 2020 09:36:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:24 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 01/10] regulator: consumer: Supply missing prototypes for 3 core functions Date: Thu, 25 Jun 2020 17:36:05 +0100 Message-Id: <20200625163614.4001403-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org regulator_suspend_enable(), regulator_suspend_disable() and regulator_set_suspend_voltage() are all exported members of the API, but are all missing prototypes. Fixes the following W=1 warning(s): drivers/regulator/core.c:3805:5: warning: no previous prototype for ‘regulator_suspend_enable’ [-Wmissing-prototypes] 3805 | int regulator_suspend_enable(struct regulator_dev *rdev, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/core.c:3812:5: warning: no previous prototype for ‘regulator_suspend_disable’ [-Wmissing-prototypes] 3812 | int regulator_suspend_disable(struct regulator_dev *rdev, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/core.c:3851:5: warning: no previous prototype for ‘regulator_set_suspend_voltage’ [-Wmissing-prototypes] 3851 | int regulator_set_suspend_voltage(struct regulator *regulator, int min_uV, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Lee Jones --- include/linux/regulator/consumer.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h index 6a92fd3105a31..2024944fd2f78 100644 --- a/include/linux/regulator/consumer.h +++ b/include/linux/regulator/consumer.h @@ -32,10 +32,12 @@ #define __LINUX_REGULATOR_CONSUMER_H_ #include +#include struct device; struct notifier_block; struct regmap; +struct regulator_dev; /* * Regulator operating modes. @@ -277,6 +279,14 @@ int regulator_unregister_notifier(struct regulator *regulator, void devm_regulator_unregister_notifier(struct regulator *regulator, struct notifier_block *nb); +/* regulator suspend */ +int regulator_suspend_enable(struct regulator_dev *rdev, + suspend_state_t state); +int regulator_suspend_disable(struct regulator_dev *rdev, + suspend_state_t state); +int regulator_set_suspend_voltage(struct regulator *regulator, int min_uV, + int max_uV, suspend_state_t state); + /* driver data - core doesn't touch */ void *regulator_get_drvdata(struct regulator *regulator); void regulator_set_drvdata(struct regulator *regulator, void *data); From patchwork Thu Jun 25 16:36:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625713 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E23F6912 for ; Thu, 25 Jun 2020 16:39:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9A1B20836 for ; Thu, 25 Jun 2020 16:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SjvWIwpp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U8Vp/tCR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9A1B20836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GmK8zFzPj2weD7+NrvFjM7o6glDhx/bxFTScHiHYIac=; b=SjvWIwppjzOP+9q8bcyCEZimB /owWRHj+7lIBdraccGQx4yO17JRG2d/ACozE7AJjZNehSip+xnQgNz17Kd06FZk7Sgp+DnIanndqW uJgImV7NcaIGA5M3ZUXNkbn7Xz32ktEvD3eKsiUbrn7NZRFNIEoIIM1hpPOh4jsnkDoqLId1iPB5W bEOCS+X9UR6GBccQhhWz6FDf4CqvBakyFngvSNa3a8Ac1CRgRaLOpEtXd2+r4hEBmUzJ/ntx/LlOt cobMgE8+CtoIxzLCvmxgWGgLFwb11TJfGvNLl51n8MMeYOJHwnW9W1Vd9X6w16HJrQUdp5m/dlqT4 ojM275t5A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUs1-0006Ix-8U; Thu, 25 Jun 2020 16:37:01 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrS-00066I-OY for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:27 +0000 Received: by mail-wm1-x344.google.com with SMTP id o8so6202886wmh.4 for ; Thu, 25 Jun 2020 09:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wrbO6xK7EoIeO1VHH2AGpfAcceEYBEVVEFHtZyqDA5M=; b=U8Vp/tCRNrGE22Ur+Ex5s8u+LHfRLDxuxHW3gcrrdE8Jv+nrHRuUKAALGt5OLlttHH DPDgx7URr2b94n8Z26kcbCUEEISXHVx5Jtn6hs1GPjx02z5LrKGoPkAs0lFmL5b/9ZbL PL+/PHQU5LVXGL7q5yP3338Bb4AfDabXM6Tptehd6Udb5DL8b1Rl4HCE8F9dWfOrn71E l+2j7aOUVBV+vI1YZn2CSRM5bLopbMyRjHejF8l8yam53WXpcRvfa47NDTJQp2zlqPyw UTGRzS5ZHi5r0ReifVYTij7pRDXVphYFOpXWHj2KnqGwtxK0+opyS9ly+BVnfv1KXP+N Ilcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wrbO6xK7EoIeO1VHH2AGpfAcceEYBEVVEFHtZyqDA5M=; b=R7KARZMDS1L4qw8qnfipFfkJ4xYQysALmlWSO9a9tlCHvFjXI1jCFDK5J9ZxWY4LqC mGQtKYJ9aH/lCX+FLmf1Jp6NKmc8R+sGfLvlo8UACa1hXg1Xx0CDrOSrjily6TXoMG6v kAPiSkAwAXap+NnaVw5Eb0UkMZpGALHHtK2VkMvSgWZAhyc1FzO+1H6H4TzLV8knaCjy iEPb/Y6YWXAb2myQBePH1jtKkJrS0uL9rFuTgcIXkGcDIwW1YIThMla4TwBYWVBXKKB9 0sYRY2kq69QhBLCBm2mDYWE01Pkjl6HDHNkMYEi4v1vvgGkmvafZ+ku1orBTds7hnsem vpIw== X-Gm-Message-State: AOAM530gMAQ/lG8kQG8pahLtDeTk/soU4uL9GiWQVq91tcLdbeLnzb7e bepmq3gJpKN4erStUclBwnRQDA== X-Google-Smtp-Source: ABdhPJxD4VwwV7Ih+k7y/dG2h+HNygvu6V2v3Ta2fHsyVCBjxkCJcMJuTTKrkF/oSmDZGfw5o2P2Bw== X-Received: by 2002:a1c:c908:: with SMTP id f8mr4307260wmb.150.1593102985745; Thu, 25 Jun 2020 09:36:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:25 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 02/10] regulator: devres: Fix issues with kerneldoc headers Date: Thu, 25 Jun 2020 17:36:06 +0100 Message-Id: <20200625163614.4001403-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Provide descriptions for some missing function args and rename others to match the names used. Fixes the following W=1 warning(s): drivers/regulator/devres.c:187: warning: Function parameter or member 'dev' not described in 'devm_regulator_register' drivers/regulator/devres.c:226: warning: Function parameter or member 'dev' not described in 'devm_regulator_unregister' drivers/regulator/devres.c:226: warning: Function parameter or member 'rdev' not described in 'devm_regulator_unregister' drivers/regulator/devres.c:226: warning: Excess function parameter 'regulator' description in 'devm_regulator_unregister' Signed-off-by: Lee Jones --- drivers/regulator/devres.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/devres.c b/drivers/regulator/devres.c index 3ea1c170f8402..d59009d07a57e 100644 --- a/drivers/regulator/devres.c +++ b/drivers/regulator/devres.c @@ -173,6 +173,7 @@ static void devm_rdev_release(struct device *dev, void *res) /** * devm_regulator_register - Resource managed regulator_register() + * @dev: device for regulator "consumer" * @regulator_desc: regulator to register * @config: runtime configuration for regulator * @@ -216,7 +217,8 @@ static int devm_rdev_match(struct device *dev, void *res, void *data) /** * devm_regulator_unregister - Resource managed regulator_unregister() - * @regulator: regulator to free + * @dev: device for regulator "consumer" + * @rdev: regulator to free * * Unregister a regulator registered with devm_regulator_register(). * Normally this function will not need to be called and the resource From patchwork Thu Jun 25 16:36:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625715 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82B52138C for ; Thu, 25 Jun 2020 16:39:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 581C520775 for ; Thu, 25 Jun 2020 16:39:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dsc4L/+l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I8pv1DA7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 581C520775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qems7yawc+esd2drU4IBMSylAACkHGiDtoDmOCvzwWg=; b=dsc4L/+ldZPcpc/TTAVigDhk4 ZV83Uavig98zCe0aCWYAEbwdsNpnevLnMbAzUiquEhLym0kQJ8c42igCWHZA5NpNSSrPxIhXe0uFX Np1AngQfNUOlzH3TmhgHK1kvSrrAZ+3JIcRK5vOGqioKrVseHwIEhIWcAXYpiBySga+21pEDHhsyM eQ6beHe41k/fQkMWXgvBTpinyLIra1w2wRtYU69nKQ0ntKh4q7c7wR0ADzNSxeKZPGsKtkds/u0b9 DLfstzaj/Tk/LULOzEvT0ntsNpkTMN8SDXuMHCFwRVoKPufd/DUtA9ci3W8ClkP2OVHr/bcYWZavA SrmqmXNOQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUs5-0006LB-4o; Thu, 25 Jun 2020 16:37:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrT-00066p-T2 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:28 +0000 Received: by mail-wm1-x344.google.com with SMTP id q15so6203387wmj.2 for ; Thu, 25 Jun 2020 09:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Oh0M2XxgEicv/4L6G4xS9du1OgGWivqgmfvme6DT5xQ=; b=I8pv1DA7VP8oubQxBsgNdI+KcUYKxD021qWb3WnX0GN9F9PSAMbqBYJ/YqRdkDr+i+ 2I95wk1mNvFrWPiQy1Au8GIenTEuoISlV2qYFDZL9H7fzYS7HvnDaySxgj2jXTS8Jc0l uTyuMCOeYzZIrXokNQlhSODbZahqjKEjR+RP6RgNere7Lz4VGAReCjlp4iGr+bqF2DE3 AwbB0elZeh6pZgayQ1Qzk5spE69Kc3P/Vw40ZMeGKrbrePX71GSNnWQiyjFmjdi/JeCM AUsAYl6iZ7awNTzLQs8yYhRRJmY7p6QLwTn2LcuEfdUh6neOKfuycHUAxzg1mNtji7+N 1iNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oh0M2XxgEicv/4L6G4xS9du1OgGWivqgmfvme6DT5xQ=; b=curDxlAdELXY7uD0D/U0s9i2y9Bq5Y3YhMfVrF08cGFVOyNKaulQGRBBlT1+djsySw OwHwCTJgaGo3kcPr2+CdqBLmhkNrFLo4SB4gRCuifjEK8DHf+B4LPqB1Q9VoLDdTltY4 p5gBma3DrFpLNdA4tRppAEBuz66qcyS7GTLKoMcv1TArKcUPIHBhqutkK0VTjSljjiD5 cQ2+n8L/KsUA/CdUpXSf+BEDIZneh0cWInc/s0v5HapriK6l0bvb7Ju6WOCqQ+1Vk45C 2ncoISJKWOhbAm76XoUhwGi7DbY8Sx6UlLo0e+uKe4LDE2D24prM/pLeK5pL0ETu2oG7 q6jA== X-Gm-Message-State: AOAM532WrO0gW03uGBTVp0evo6+dlrZbP3ipnrJn7ttfJL7n2GkcdRbO lI1mqV4ip0atJE88z2BnJsa6MA== X-Google-Smtp-Source: ABdhPJxSQnTa9XMAO/CZ/o9al09/awtgMaCIbfouAqjZz5Zpg5xQYQP3AY71vBaNPnpoiaKHxVlTTA== X-Received: by 2002:a1c:dd86:: with SMTP id u128mr4269069wmg.123.1593102986847; Thu, 25 Jun 2020 09:36:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:26 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 03/10] regulator: of_regulator: Add missing colon for rdev kerneldoc argument Date: Thu, 25 Jun 2020 17:36:07 +0100 Message-Id: <20200625163614.4001403-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc validation gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: Signed-off-by: Lee Jones --- drivers/regulator/of_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 87637eb6bcbcb..292e68c818ea1 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -532,7 +532,7 @@ static bool of_coupling_find_node(struct device_node *src, /** * of_check_coupling_data - Parse rdev's coupling properties and check data * consistency - * @rdev - pointer to regulator_dev whose data is checked + * @rdev: - pointer to regulator_dev whose data is checked * * Function checks if all the following conditions are met: * - rdev's max_spread is greater than 0 From patchwork Thu Jun 25 16:36:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625717 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 36F50912 for ; Thu, 25 Jun 2020 16:39:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D9D620775 for ; Thu, 25 Jun 2020 16:39:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N0SSPVuG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r5KaDOmo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D9D620775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SuZqDCSEocQwIw8Y9wNYbkF5KtZLs4wbnzfgY1PqvXU=; b=N0SSPVuGgGVI48J3qf34G2cOS 3LtYHjWRW+KuIWwGBKLYvNwXExLvpZUgEdFS9XT1l+Y9/hJKi+iAyBnwi71IN3gXkerKRux4x4gGk 3xXcfVHLi7yf8QNd8zYKqrJibijagX50PudR35Y+hf2TM42cpFTb3TTGW/mjpbn5Sq+IpdgpnlZnm chngypK2pru7/djtKwQTI2CiELjWZGA+k+r3WjBTTsRnOFWRajpGAiwnq3ssoCnMaIhF0n8g70VLR JojcWvfBqt2XbMd56TGSfxLxfjpuvaP/Qeq05a9aO7b7Bp3bbSYC8hs020EIFVfz8vFqLxjQuozbh INmT9ShRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUs8-0006Mf-U1; Thu, 25 Jun 2020 16:37:09 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrU-000677-RO for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:29 +0000 Received: by mail-wr1-x444.google.com with SMTP id o11so6503692wrv.9 for ; Thu, 25 Jun 2020 09:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KndlWInJvGoRF0jx06iGKO8/jC8k1E3YyL6CPU2WcSo=; b=r5KaDOmoHmUoBA//c0h6Z/tJW/Efnytw8+jeKagT/nqoHeq8C7tkhS7rx7VkcrRRvB gwcclc1o0/1iRx/qtLDmRbp9C6WFXPhmErGnQMUnM4ZNkJjAAJ5xW+Y/Ahv7D5IbrErW qqDCfL8XFK+6FMHPqWSAmMTaVxuPOrmaCF1a2JnomKonFUbMNx/43JboGkeTMkZNOCce JSOHxB7P/CeOhFRi0jNWvSFZyhHPHlQPHGzNMLIZObk046kNJ9fKNOpwEuX0NjZdutLX IuvpOxeFl7UoJa6lK2QXF3qC9Y9Bue92b7rPFZFgkxBonDp+G/+dF9pwLxA2NjX8l/PF vWAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KndlWInJvGoRF0jx06iGKO8/jC8k1E3YyL6CPU2WcSo=; b=mUznLw/JT/u3W/KkyUMx3tiVAY3Uyrw0j9shWgOSUaBV5IFctaMe+7Ao1V/SWX3uNH xTPEQTFDnDv2y3KptHztmfY8QxGUcEiZ7KvvCV07aqO3NEhzOBkV2fur4GgvD+BQqyF/ uCs0Ky3WcmUzIbUhlmv8xY2oTnfT5gPtBQbtMiG7akdFP2OpMe+65Tnf5VbQkQ5aUbJr bhzGSFM23It4sW8u2j/qrCwN/MWAC9uU0u1B5mBG0n/Z8qBVGrQhCzUSFV6Rl80YQvod ve7g64VWgikp1QzWmlqxZ3+4PAY9XkoI5eNJ2JJ/bu31la4E1GWl2TEgXCcUDH+pg6Bb gOQg== X-Gm-Message-State: AOAM533FsXpIPvitlFCvLk5iWpFjv0RzKGBNXJCnI9lCmZuGfD/M2qRZ 2PEmNRD53jj4AjmBG/MbSZYDzg== X-Google-Smtp-Source: ABdhPJy3yUyH7m9+jnH6hFEnfrBJRT4MVIZzAefQ4i4842f/fHklh/4aAb7/aJWNEGTQeJcFl9zbnA== X-Received: by 2002:adf:e648:: with SMTP id b8mr38605083wrn.386.1593102987753; Thu, 25 Jun 2020 09:36:27 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:27 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase() Date: Thu, 25 Jun 2020 17:36:08 +0100 Message-Id: <20200625163614.4001403-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There isn't any code present within the current kernel to override this 'weak' function. Besides returning '0', which is never checked anyway, the whole function appears to be superfluous. Consequently fixes W=1 warning: drivers/regulator/dbx500-prcmu.c:113:27: warning: no previous prototype for ‘dbx500_regulator_testcase’ [-Wmissing-prototypes] 113 | int __attribute__((weak)) dbx500_regulator_testcase( | ^~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Lee Jones --- drivers/regulator/dbx500-prcmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c index f604c8db6d0e9..c3ad6aa6b5d37 100644 --- a/drivers/regulator/dbx500-prcmu.c +++ b/drivers/regulator/dbx500-prcmu.c @@ -110,13 +110,6 @@ static int ux500_regulator_status_show(struct seq_file *s, void *p) } DEFINE_SHOW_ATTRIBUTE(ux500_regulator_status); -int __attribute__((weak)) dbx500_regulator_testcase( - struct dbx500_regulator_info *regulator_info, - int num_regulators) -{ - return 0; -} - int ux500_regulator_debug_init(struct platform_device *pdev, struct dbx500_regulator_info *regulator_info, @@ -152,7 +145,6 @@ ux500_regulator_debug_init(struct platform_device *pdev, if (!rdebug.state_after_suspend) goto exit_free; - dbx500_regulator_testcase(regulator_info, num_regulators); return 0; exit_free: From patchwork Thu Jun 25 16:36:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625719 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 405FC912 for ; Thu, 25 Jun 2020 16:39:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1807720775 for ; Thu, 25 Jun 2020 16:39:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WAP8XkGp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BhDdCYXb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1807720775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CwJ1s3gwf5Hpv3P1dRuv9q41IwPF+yGAOmo7JWwwDJA=; b=WAP8XkGp1jSTaTvw6z0Dxg+Gh VKLg33DlGdYgd8p7QWBQXp7AwPJExGu+34Et9rBgPQ6j4eNVAYQdGsLFozgCGv/b3nW68s8OkBzai MeZtetfa344U8fns0zLsUmSptCjbZI47dh/0jrKGdNX7OaF4QPjob5uC0vvZEUGuyAOJxq+k+1Vf9 lyVmTLYP2lDdMSaYn+f0B/vRxbCe1ZzvidulOUs794m6hkO9VbgKSzaC3o/WqGlF/tssjrbkczvC/ wNKvyKRmhfFVwVuFa1XOFTU3sCd4is2zQpgtCJQO5RPPoLYlTxkhkjzlu+3hHd8q/UrFD5NJsIbH5 QLlh62JKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUsJ-0006R2-2B; Thu, 25 Jun 2020 16:37:19 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrV-00067T-Pp for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:31 +0000 Received: by mail-wr1-x442.google.com with SMTP id o11so6503740wrv.9 for ; Thu, 25 Jun 2020 09:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AG5JT6BVc++x++ET4thnNlvU80KPoPW/gm+IcPGlfx4=; b=BhDdCYXbf5Bqe3gq5XkEZV0kknc76p0ua5nw3TxvwQkxOhI94SN5qxknw3zwl5wNEW 3dY47g2rPPn+nFrwNrpOVm9mArj+jAllsr6IQ6L6YNIRNqI0e/4QxmXlxly1hqTF05OU 0roGmZyUaiHYDJOoxFugRIOQ2NLj4ea2+hRgjreQdrEpeHJJLRuDUWBWt/KvhxCLS+mt LuYCoLOJRKiLVmqJ8gAeY5cthidQPeBf86Tv/wn8mfo9GjgoOAAOtTU8TI5IG4BAekLA qpxAXf+nHatgdSrGE80pFgsgV8o1PgjegYusaveC+nr8K/h7FbU2qMDsyiSJ7xKhn3ZF l6xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AG5JT6BVc++x++ET4thnNlvU80KPoPW/gm+IcPGlfx4=; b=AcKD82O/7gwuPzQbTO4JtktI4aQv6oA+clhm+TZLwEMzU75bdG5VfPY90NHKyI/EQK NoqjVdF7G/BwooK3Ent+nsaLc6sx4UAi4L636oZREw80RDlJg4PCQhEGgczNfTbr0INr ea1aUegiYZezmcVJlLV2TkjWmZOI+XeMOq7Vzx2Ezlp0iYZN6+w4mQLe7TpRgSD+9OiW GIFWFEWTimXfzSRlM1aCVlHIBc6P/JbNWUau/Nt76ysJpu8CdGkKQYZtVxImiXGAs46C ZQzDPsjZcbSQwKyH8oTY3LpufIkZEDJKftAliLiDVVBSlhVHz/Z4miOu5Zl0DrHu6T/Y eViw== X-Gm-Message-State: AOAM530PVldG7cmbj1X5u377xmOhbCZEyj7hceA5pAmVekg28/WTeCVB +YmvdthONSElM8t6vfKa9moBXw== X-Google-Smtp-Source: ABdhPJwU7z6hTpdi1x9E0HggAu6Vtz2QvUClP5kZIoGM9g28pYobAy85ukWrA02d7gn5e7lGb05t6w== X-Received: by 2002:adf:f20a:: with SMTP id p10mr29547732wro.41.1593102988733; Thu, 25 Jun 2020 09:36:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:28 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 05/10] regulator: ab8500: Remove unused embedded struct expand_register Date: Thu, 25 Jun 2020 17:36:09 +0100 Message-Id: <20200625163614.4001403-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Used primarily for the AB8540 which lost support in early 2018. It is now deemed safe to remove this legacy data structure. Also fixes W=1 issue: drivers/regulator/ab8500.c:88: warning: Function parameter or member 'expand_register' not described in 'ab8500_regulator_info' Signed-off-by: Lee Jones --- drivers/regulator/ab8500.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 716ca5bb178e7..47b8b6f7b5715 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -59,6 +59,7 @@ struct ab8500_shared_mode { * @voltage_bank: bank to control regulator voltage * @voltage_reg: register to control regulator voltage * @voltage_mask: mask to control regulator voltage + * @expand_register: */ struct ab8500_regulator_info { struct device *dev; @@ -79,12 +80,6 @@ struct ab8500_regulator_info { u8 voltage_bank; u8 voltage_reg; u8 voltage_mask; - struct { - u8 voltage_limit; - u8 voltage_bank; - u8 voltage_reg; - u8 voltage_mask; - } expand_register; }; /* voltage tables for the vauxn/vintcore supplies */ From patchwork Thu Jun 25 16:36:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625731 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1568D912 for ; Thu, 25 Jun 2020 16:39:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E21AB20836 for ; Thu, 25 Jun 2020 16:39:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I2aG+9ey"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZPbYUR/a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E21AB20836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mpGvAwj7NpHrU8GB/b8WOEEx88Ir0hU+8VdNnSHXnAE=; b=I2aG+9eyM3KbRj5RC6oaFNYBn p9fgILFTNuZqB7CWEUCNH5a+1jR3XVjSUM+m4jrkRRVHvCZhJ6UFzVeQF4JtX/2I6QIE+LhG64ind gnMvPl7plMBv5+y/8C5saLnrl3XALso+l9KUga8tKnNO9sENZ7d5RrggwPMzU3QHzHX0Tmc3k+tRI zGm04RYVgKRAC+0SNjT1sP+DLL/7/maSCf7vmBzWkdrzgykpVrzVhX2wxSai8xN0Y3ofWzv4rYmKB I2jnwB2gVRYudmsViEAIPYuifQA8FX+iI7Jo39Yad8xUqqemxq1XB9isG63WlIvCgR30PABwaoGql D0S5hrByQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUsN-0006TJ-JQ; Thu, 25 Jun 2020 16:37:24 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrX-000684-GW for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:33 +0000 Received: by mail-wr1-x444.google.com with SMTP id h15so6504756wrq.8 for ; Thu, 25 Jun 2020 09:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JwnlbyOVm51Eb0pUcF4rl7PINN6mIzB8TF+ZR7WT2tk=; b=ZPbYUR/apHsgXXjmIkyAJtuxDa0o9TtEQ7P5i8ewdtE/m2vtGGZnK2qKwY79uju+2r xbQfnGIOFW5g3VQLd/aQS6AZeezdYbNkx9Oo6nn973GAkLEof6DLi6/oppQbddV84tan X8EBv8Qqf41PpcAA4d0ab7OlFb7cVQQ2ZiNVEvQuS4F/fiA6XynurgG3GJpWKIWT83Z6 P7y9F1GpHSIXyGillKp2n9XqtwQN+9qVXtzB30QNistBhW/aTsJ8B1eAqXVVuDsV0hFy j3hwXpvQ/QirFRfIPLN33LmjPa+Zp8A7J6CvWYM07ufHjs1/xNlgUCNvbcwJH3YJwxlF zZZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JwnlbyOVm51Eb0pUcF4rl7PINN6mIzB8TF+ZR7WT2tk=; b=D7vZi9ARfd04ZaDEJiVUdoildg6+pyunFn7RXBqtimTS70U9liAc0Oe3jgVcFLb6ab wyEk1AH0+aB2IPRFe2lZr+uMDoiY0NLt8gJ+i/6Wlwq2qKMuO52RLPzwaGonN2fLpnS4 lwHUHKjHS+SLguEcx6fzfY3ogKY9CPNtPJoUm8YfcJKzCYF1uRjnIH+ISJBKo4RTC2c2 sX5nj11kBm/Ezqnf4BJAswTsjyvcoU1raPuFJLiyWMB5PVtMUOwFXqTfyy5fm6AI29kK GXgyRMkSFJP7vMX/vvtnbpgVgzEQT1ZWx5VZWRz09NGl3u9uGOhp21tygv49qYDWQ9ng sdJQ== X-Gm-Message-State: AOAM532Slkn4A1bP4HHUg+dli2Ov7+tFvsrhM80mMFpAQZRnH/yOanOl BUn9s381NUfi3Cz9c7pe7zrTmg== X-Google-Smtp-Source: ABdhPJzuGUu4iIUai+NXGCIgKUFHcPNWsPnkkzDdHPsRkCjYNZuSAZnZDpgj3O2ldTTcOrXxLOp1WQ== X-Received: by 2002:adf:8521:: with SMTP id 30mr35819917wrh.238.1593102990051; Thu, 25 Jun 2020 09:36:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:29 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 06/10] regulator: wm8350-regulator: Repair odd formatting in documentation Date: Thu, 25 Jun 2020 17:36:10 +0100 Message-Id: <20200625163614.4001403-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects function arguments to be in the format '@.*:'. If this format is not followed the kerneldoc tooling/parsers/validators get confused. Fixes the following W=1 warning(s): drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'wm8350' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'lednum' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'dcdc' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'isink' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'pdata' not described in 'wm8350_register_led' Signed-off-by: Lee Jones --- drivers/regulator/wm8350-regulator.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c index ae5f0e7fce8bb..2e7bfdf7c87bb 100644 --- a/drivers/regulator/wm8350-regulator.c +++ b/drivers/regulator/wm8350-regulator.c @@ -1216,11 +1216,11 @@ EXPORT_SYMBOL_GPL(wm8350_register_regulator); /** * wm8350_register_led - Register a WM8350 LED output * - * @param wm8350 The WM8350 device to configure. - * @param lednum LED device index to create. - * @param dcdc The DCDC to use for the LED. - * @param isink The ISINK to use for the LED. - * @param pdata Configuration for the LED. + * @wm8350: The WM8350 device to configure. + * @lednum: LED device index to create. + * @dcdc: The DCDC to use for the LED. + * @isink: The ISINK to use for the LED. + * @pdata: Configuration for the LED. * * The WM8350 supports the use of an ISINK together with a DCDC to * provide a power-efficient LED driver. This function registers the From patchwork Thu Jun 25 16:36:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B880E92A for ; Thu, 25 Jun 2020 16:39:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 844B320775 for ; Thu, 25 Jun 2020 16:39:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xc5CGmfN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zIdULsYK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 844B320775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w+u8C62Vshewg47+rW8QWN2l33XUEiiCUuZRhdelB18=; b=xc5CGmfNdWBc6Bj17osujLmkN w3dHkjyG42XyDcX64dpvlohyqCcpv78me8WPdDP/A6k34YgFWaEB27w8PGP396+94zbhOClA6/OI8 pAmduIg3hTQ+HZoeyOzTuVPLh0ww/U/HUmWwU+EiQ7fbHhF5eMA75C4LlG60G+RasEgYpmyZ0wZki z3tlYJBKQzrZ9CjTeRXsTOZ1tagJMcqmVRSzCIZT1vdZuB7eTNJyLvUmMbVf8/wsDaMNuAsVnsdJC napTWTYNWd5MObVxoFd0YvxW7DpmzBcYR6KIC+aFJ0Mbceohd045FFyBBbMmP4GIRXSBJ18SnvxK2 HtsYzdV+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUsW-0006XI-FZ; Thu, 25 Jun 2020 16:37:32 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrY-00068Q-Ca for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:36 +0000 Received: by mail-wr1-x442.google.com with SMTP id z13so6519115wrw.5 for ; Thu, 25 Jun 2020 09:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wFHpX6/JfOmiOR17NB/0ktU3gvi4o0iTMP6vlrr3mrk=; b=zIdULsYKpkHXr1aYsS3j6Xbz6bEtRdY77wQUWfADIEdlrFH814frioWaPTHfsdfU5b dNCw6owykLKBXa6ui/3kaRPIGMM5A8Mi6I1dx2jA6uL3Zzp6qnh9nNGMBc0o9KQfQkXp SOriJULBMs+vPwT0nkuoedTH1my15z7bXbF9bB8Fj6yz/XHU/uS4U+GRUUZdlwFUHhz6 VPmtzXG+UZMR3ux79lxpyIJfFDtKo84VS21PkapYzRu7bbA1dQEY7bwIBx+e6h8AP212 UDW+70PAMEw+yFN1b+FWcbYbzDVmQ0KzpFaq6PanhIxKdczKLkqQgf6RUTCpswiEr6aL 3ifA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wFHpX6/JfOmiOR17NB/0ktU3gvi4o0iTMP6vlrr3mrk=; b=mcQljVhp96LedTmEwyOP2ofCnKx3a3oyg3K7yPVw3qVmsd7kQuTo915a7iwT/H9p7A xS2yFBwqBjwk9b0yZ8OVo7WL7IFFNHZa5l5rGBCnHWFLaisDTV8Vo9j4pToFpTdz+6ib kJPt+qKHJogHO3E8Or+URCD50pcb2XgPcOOAN+2AlJlQf3vqLbVJ7EcNjZq64BUlTXRg zMktuqbLER493sg/Dl/B+/e5UMva+CpeO9Ngj1avyccXmUuX/A2r1wtCgO0SusA2VDMV T2G1k7UBqHIvFfb59gTKy4A4lc1O1jdNjkf0iB7RrALYAjkh8XWm/8WDTiinqfaMw6aS +Urg== X-Gm-Message-State: AOAM532YRuiMaLru8JwalcqpZLy4/SpmWDEcM9jkFlBsfMmGaiI6Ksbt /IQyBk5SmpQMagRs+/BWV6slAQ== X-Google-Smtp-Source: ABdhPJy+4PviXw5CFNHqNwfxVVngNozT+a0WUquCVyiwMtCTrMt2dTadyjRihV9XXUnNG0NGbrRmQg== X-Received: by 2002:adf:f209:: with SMTP id p9mr36231294wro.86.1593102991088; Thu, 25 Jun 2020 09:36:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:30 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore' Date: Thu, 25 Jun 2020 17:36:11 +0100 Message-Id: <20200625163614.4001403-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It's okay to not check the return value that you're not conserned about, however it is not okay to assign a variable and not check or use the result. Fixes W=1 warnings(s): drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] 172 | int error, ignore; | ^~~~~~ drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’: drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] 196 | int error, ignore; | ^~~~~~ Signed-off-by: Lee Jones --- drivers/regulator/cpcap-regulator.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c index f80781d58a282..fbf823b830308 100644 --- a/drivers/regulator/cpcap-regulator.c +++ b/drivers/regulator/cpcap-regulator.c @@ -169,7 +169,7 @@ enum cpcap_regulator_id { static int cpcap_regulator_enable(struct regulator_dev *rdev) { struct cpcap_regulator *regulator = rdev_get_drvdata(rdev); - int error, ignore; + int error; error = regulator_enable_regmap(rdev); if (error) @@ -180,7 +180,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev) regulator->assign_mask, regulator->assign_mask); if (error) - ignore = regulator_disable_regmap(rdev); + regulator_disable_regmap(rdev); } return error; @@ -193,7 +193,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev) static int cpcap_regulator_disable(struct regulator_dev *rdev) { struct cpcap_regulator *regulator = rdev_get_drvdata(rdev); - int error, ignore; + int error; if (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC) { error = regmap_update_bits(rdev->regmap, regulator->assign_reg, @@ -204,9 +204,9 @@ static int cpcap_regulator_disable(struct regulator_dev *rdev) error = regulator_disable_regmap(rdev); if (error && (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC)) { - ignore = regmap_update_bits(rdev->regmap, regulator->assign_reg, - regulator->assign_mask, - regulator->assign_mask); + regmap_update_bits(rdev->regmap, regulator->assign_reg, + regulator->assign_mask, + regulator->assign_mask); } return error; From patchwork Thu Jun 25 16:36:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625743 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 142B5912 for ; Thu, 25 Jun 2020 16:39:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E05F420857 for ; Thu, 25 Jun 2020 16:39:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G8GWSbjx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GSc/LxSA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05F420857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=npHeZTcq8ZUfJru4WYpWWt0Ndb+S5SSsKTOcaphJVhk=; b=G8GWSbjxLfyh1yLwvRhYCeJtJ UL7skl5IkcYkiRxP7aaZi0QrD+WG+ZdmqmVACJiV+8yQ4RcYoeL1zZG8fHxuFAjzNwnaTEgmqyVnE QvkH9k5P9anSEoVdYBrAAMvm3AJ22voQ4S1Q6YPYwX9nej73lqOJ3VH2nVv7Ju/ePPbWzxL92MDW/ 7vs5ETITcfPK7NfYF2yfwTTo4F8Nsfd+z99Zhn3oNCkcS0VskACoGwwsZEIuyY8oJ3KelSIVNKFCA BCrf21MhaHZ8xbpnjkkOzI6fFvdd6ETfGiRlvJd/9b16ptDCGM7H5rmrvvH5dLzOKXhMMaadcfBdJ tbg00ga0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUsk-0006d8-Gc; Thu, 25 Jun 2020 16:37:46 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUra-00068r-3T for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:39 +0000 Received: by mail-wr1-x443.google.com with SMTP id h15so6504876wrq.8 for ; Thu, 25 Jun 2020 09:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TC6ovm1MTdrPXtJ7RPNgE+kqgQ9elvNJFPlbxofiJ9w=; b=GSc/LxSAVa29kXTlsfWMyCLX/Yr2la9yDbQV029tu6huJwXsEThpfpX67gY5snQPRs 9w17UHzz9qEJtm2vVVgSXslhm76xPE8MSFfy3n6T+YXK8Wf7rtUU39Dq8tnZE8JXoi8I ZilOALyMsEAlXNrlilnNNNP3SDexRspuU5i4duvqMaJ2+wfM+9u/eyWF+kj9glvP2Yca iqTVg6u+h4bB8yklv3g3unbra6xnMH1T6TdkVtXtvUs8LIQ7Ey/z0B3pcPSKlIjWwBEo AvNA5dWzG/iviUkBsJd3ERZh81VGimZna9c+DnXZXZIcPXc4fr7dHPNUEEGgk7AjiZwz tVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TC6ovm1MTdrPXtJ7RPNgE+kqgQ9elvNJFPlbxofiJ9w=; b=RvjubByHKI1VuhONu7x+GL+xqpG5xecCbuqefkmd5IE46xP7cgwwsSEDezRuW2WOZT y2SGBL4cMEzMr6RQl5XY+kng/f53DN20LdEqDNodMNJ0pmrBRJ72+YxIMNbmgKZXmxkp 2Wn34O6qIzSPCkbt00Ai1LqadTR9ky0nXW7/YRxeSi+fWw19dXTQllp5tk7I/M/ZTWlh ztJvFPZQt+uCd8G0pTS2UhG/2liO+iQKTyNQTtzGyVhWW53PdoNKCwtOgi2nHc4N8KIe ZytPSs5XvpkEcszxuyHHPqDvDRZMhcaRY9REfE2FbC9nHLNV+XRaQl4pDRi+BCJFGsw6 rSCQ== X-Gm-Message-State: AOAM531Ge/cPiwY2Kta2Fk5j7QZfNLFuw5W4PmGupKuEnWbiEpwsS64k 9MmuD804GEM64gyg39YEZ+UNJQ== X-Google-Smtp-Source: ABdhPJzhEYgPmTR4l1oHQcmaoYP7rMe39jztBc3C01yTdPLg527ej6688QjPkiAxzMTPtlCnn7Oe1A== X-Received: by 2002:a5d:688c:: with SMTP id h12mr26136963wru.212.1593102992114; Thu, 25 Jun 2020 09:36:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:31 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 08/10] regulator: cpcap-regulator: Demote kerneldoc header to standard comment Date: Thu, 25 Jun 2020 17:36:12 +0100 Message-Id: <20200625163614.4001403-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Nothing about this comment identifies it as a kerneldoc header. They're missing all of their struct's property descriptions and the correct 'struct *' header. Fixes the following W=1 warning(s): drivers/regulator/cpcap-regulator.c:99: warning: cannot understand function prototype: 'struct cpcap_regulator ' drivers/regulator/cpcap-regulator.c:337: warning: cannot understand function prototype: 'const struct cpcap_regulator omap4_regulators[] = ' Signed-off-by: Lee Jones --- drivers/regulator/cpcap-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c index fbf823b830308..221e8db358c9e 100644 --- a/drivers/regulator/cpcap-regulator.c +++ b/drivers/regulator/cpcap-regulator.c @@ -89,7 +89,7 @@ */ #define CPCAP_REG_OFF_MODE_SEC BIT(15) -/** +/* * SoC specific configuration for CPCAP regulator. There are at least three * different SoCs each with their own parameters: omap3, omap4 and tegra2. * @@ -325,7 +325,7 @@ static const unsigned int vvib_val_tbl[] = { 1300000, 1800000, 2000000, static const unsigned int vusb_val_tbl[] = { 0, 3300000, }; static const unsigned int vaudio_val_tbl[] = { 0, 2775000, }; -/** +/* * SoC specific configuration for omap4. The data below is comes from Motorola * Linux kernel tree. It's basically the values of cpcap_regltr_data, * cpcap_regulator_mode_values and cpcap_regulator_off_mode_values, see From patchwork Thu Jun 25 16:36:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F50A92A for ; Thu, 25 Jun 2020 16:40:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6529A20775 for ; Thu, 25 Jun 2020 16:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bT+qc02Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Clvr0gA4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6529A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KcEb4cXOSISXp2rG4n09eDIbk+qiWl/1EoRjypI73kE=; b=bT+qc02Yizn+rkfujMHSwoZP/ mpV6YsANqaumeICZLpjsEnlx0zuP6ML7vAB2GUSEbmUZbFCnTEtZWind1QUZQ2ZBAXSUhLV+hvsIM 5Wzf5qQ8L/uxyqM4jnwdBIKyBFqf9hYfL2SKWQM22jxugmb2ZYtfVrVUwZfxLjI8hQo53Mg+phvmb jd0bWuMn5ZD4hA60z+gF3qgQS2zBnpRKllLbRVy/G41orVzpM/FU5KMhZu8Gg1E484LU3+Hhiz4+7 Uur88wZ8ZOGri3MSgW1mbxLhral09VOMsYhkz2VDlE+5+RFgEnBmFVL/ciPHC/2xzvsEjwl3pUGgr e8Tn/TDhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUt3-0006ou-JA; Thu, 25 Jun 2020 16:38:05 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUra-00069H-WF for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:39 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so3525150wrw.1 for ; Thu, 25 Jun 2020 09:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p8b+PVloZKecBIPRr/OI23SwGO/e4hTRF+SmOkygulE=; b=Clvr0gA4nLJBZGW6W/+HM9VWedZywRI9gj5x8nbcChWuKDVxsOPcRqm7opsvillYev VnVcVawCHAs8atU6mQP1AWBBYIqUyZ4pcdT06OcEnaS3BK+Yd043lFERn83GnlFAq+RJ Hwp75B6pHUL1Jm7ON5CEN+o+kne7pIVGhQ7rZlXaRVc0Wmwlfe71YmqKo9tV3gdB+mq4 get8f7O5pMdch0xN3a8XCzwfJcHqdNnuyMGX24kEXxzEb33aLnQFyOlBI/RJBCKMjCPN m/yWapgMU5DHtKSQwOYafBEfjASBncKU/oB1ppJqV37Zf+eSN24EdsC22njJm+696N0y 7BHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p8b+PVloZKecBIPRr/OI23SwGO/e4hTRF+SmOkygulE=; b=bGvAb/GF2xzxG6ClWLMBVnR+do3ZIq7+dPuj5FkE+fDPcHZomkjEfTc+GzvK/FycBm 5ORRMXOofoZEoXl7yJTuiDyEk/Va/Adm8lRyXTLbVT+uzlIl4BH6g1Fs1XwjyN1HSgg2 ALlYUelMcsktYuTkmF3GwnWrF07uTeNmI7GCgKZY7fznmdJSVsszdSPrgG30kdYGYWEf +8AURioj9Ok/gimSI4j44epwY75L+Yk0bBz7OzGnYqjSuApMAxDre5zMUyrC43X5kEOh l5V/NJXBrqMOQUUD2UlGnWVt5Rgc9r9cFOPRjvYF6c4KMkGNyEYiSSBCH63/NI0rtDMX jPcg== X-Gm-Message-State: AOAM530KSLSfRvzJ5FxA1XR9+BodGopl+Y0oWHPapNQGkh8vFVMQMRay 0XdLJuWB5wg3Kh3rK/jpzZmchg== X-Google-Smtp-Source: ABdhPJyr1ofOi7hZPmKskeIrOB05REDu3cC6GxuHEK6qzVDcUnQbMElvkDMUwm1aSNxpOCPQ6f7Jig== X-Received: by 2002:adf:8067:: with SMTP id 94mr35980537wrk.427.1593102993280; Thu, 25 Jun 2020 09:36:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:32 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Date: Thu, 25 Jun 2020 17:36:13 +0100 Message-Id: <20200625163614.4001403-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though 9f75ce666199 ("regulator: da9063: fix suspend") failed to clean-up all of the existing .suspend variable initialisations. This has led to some 'initilized field overwritten' issues now present in W=1 builds. This patch squashes the following build warnings: In file included from drivers/regulator/da9063-regulator.c:17: include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init] 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’) 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ Signed-off-by: Lee Jones --- drivers/regulator/da9063-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index e1d6c8f6d40bb..fe65b5acaf280 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = { }, { DA9063_LDO(DA9063, LDO9, 950, 50, 3600), - .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), }, { DA9063_LDO(DA9063, LDO11, 900, 50, 3600), From patchwork Thu Jun 25 16:36:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625747 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7A18A912 for ; Thu, 25 Jun 2020 16:39:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5176020857 for ; Thu, 25 Jun 2020 16:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="erLMnO0n"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bmX8oMZh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5176020857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YJFV5ekNbWVPtptG9qh1WdjryV/tSL82c1fXe19LrXI=; b=erLMnO0n3I3SFjuLU7yQjKIbf efJXp4hz4NAd/+H0I72ILd3gN0/kxBKtH0rmnMq54B8IufEeL20xjW6xdGkOyBbrk5CSNJCu1dlKX a7Z77R7Ylb0jv85e4r9BAJ8irMKUfwR8lIJ4Xd3uF6Ao61etj5oUN0N7LwJ7IzoqlWbD8TPRvhWA7 NjSpOhFAJdibK5MKqY7dyNcreED/856xLi2pMyf3t3kI1oDgvFc7yPCZojhUDaJFaNntRZVdzo5UB Jog3A/jSZtua3o8vWQF8Oy1OkX3stRPKLjb6manun7j9KqxU3oGHjSVVFCF/ezuQkxDlbvzoM/UmW kTK+mRlAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUsx-0006kb-UK; Thu, 25 Jun 2020 16:38:00 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUrb-00069W-Ei for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:36:39 +0000 Received: by mail-wr1-x441.google.com with SMTP id k6so6527783wrn.3 for ; Thu, 25 Jun 2020 09:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7w/pnlnnQSHCAirkmRSLoxGGcJUAfrsJnqhR6P4aZuM=; b=bmX8oMZhEkT5mR32QGDXGU5JDQxWrWOUHAsLmg7Kq1troHvADX/on1a8CxOZMN63bJ cPt9Syn8oX4fOe/xAg1BmVMI6U9bn+meIzNYXvLdVWTVa0LWsSpnOBpt9k20vkwn1AOE RSkkICZ7JlI16quRqokQEhsLx0U/TnXhM8fRtPm5fNQ/louYdiE5O0q2S0BCs9Uh3Tcr p37e7ITisX2e9fOlKKCRuzEfCqh+AVyl0wWSVNtq5b7Jr2rqnsa5krhIVzowcHCTKdyU ww7yD2K1XABWmbzeyi2VcYHrZt2gfqbNzFGo55H0fxpNM+nXcLOKCMFY8jxyq67YW7b/ BBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7w/pnlnnQSHCAirkmRSLoxGGcJUAfrsJnqhR6P4aZuM=; b=ocV7ynn/DS+eSAajHVpE0LMyidUFLMwqhnHSv9UnDNJVwQZVZ7ooOu0YC+4d+JTE3W FeWAOXfHYZBqqaaLhZraXXpH09bU9kSq9J/TvNdihK2LWcWRo/lsyLNGgBmLjzhgrzy3 YK8EjdGpkuLmLlCgNZDa8axC8sKe5ucAtSdpoMS6hlY6fWgG1EZrhfexIRPmjLrel/ZG mdCaTHxtWNbrVycK1UcFA8UngNB/tJyscfjp5aybNwexDJsx02FNHSyYLPINXpyTuMMA comkGJHQnMvlMBePUvmtpvJTGAAxlUTOuhPkTCRWd+XWlqBFrMtXgBAuJ2qSdb7LpuBQ /MWA== X-Gm-Message-State: AOAM533zOIwjv6lyFG73ubTPvkP1JYJW7WWs/wNP/WQptNk86Fj9z7eT e8e7EcG0s/7e5uft0KNG6UBf2Q== X-Google-Smtp-Source: ABdhPJwkefas7Xjc8zxfcgoc5NtjPc9XHGGk7tV1NQOV6YhohojlxLzCRryaWgBWuGxwQ0OnYotAhQ== X-Received: by 2002:adf:9bc1:: with SMTP id e1mr8307199wrc.253.1593102994153; Thu, 25 Jun 2020 09:36:34 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id a15sm36729089wrh.54.2020.06.25.09.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:36:33 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 10/10] regulator: max14577-regulator: Demote kerneldoc header to standard comment Date: Thu, 25 Jun 2020 17:36:14 +0100 Message-Id: <20200625163614.4001403-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163614.4001403-1-lee.jones@linaro.org> References: <20200625163614.4001403-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Nothing about this comment identifies it as a kerneldoc header. It's missing all of it's function argument descriptions and the correct function header. Fixes the following W=1 warning(s): drivers/regulator/max14577-regulator.c:166: warning: Function parameter or member 'max14577' not described in 'max14577_get_regma drivers/regulator/max14577-regulator.c:166: warning: Function parameter or member 'reg_id' not described in 'max14577_get_regmap' Signed-off-by: Lee Jones --- drivers/regulator/max14577-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c index 07a150c9bbf22..e34face736f48 100644 --- a/drivers/regulator/max14577-regulator.c +++ b/drivers/regulator/max14577-regulator.c @@ -155,7 +155,7 @@ static const struct regulator_desc max77836_supported_regulators[] = { [MAX77836_LDO2] = MAX77836_LDO_REG(2), }; -/** +/* * Registers for regulators of max77836 use different I2C slave addresses so * different regmaps must be used for them. *