From patchwork Thu Jun 25 19:16:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627399 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3DA2B1392 for ; Fri, 26 Jun 2020 12:25:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6C8F207FC for ; Fri, 26 Jun 2020 12:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bgL9htCY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VTFVQpH1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6C8F207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q1Pk8KEf31UgPKr3RykOfRmusFtJ2iFsCKbY5PqGyFQ=; b=bgL9htCYFrNUBNT52OC3BE3jX c5KdDRkuZSlX3M3bNTO1NL5INVP/QQCHA+QtzWdxlaHsCD8D4eUCkrrvChBiZyix9iWZ3YvQP8Wv2 tQGEDcSjmfhQiC4Rh8hk8+o3Gcxv5Qf87vA5LqbYa40259pjPGEPbk9j2SScuDkxAqcI+oVhSUZMz blX5g6Is1l23Jo8YAb9M9Y33/plhsmdD4a/lg64ypWlKGkB1GJrU3sh5M/Mgs69S5c1jYn6eRhPig /QovZ1iy9iwfV1XaXaTINWDnhEAL8vN7cD4wf3uOSQna21ymgwFH+kgLD/gf5tmTjHVadsw4/5/nV 4WpPXaIdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jonNd-0003pv-L7; Fri, 26 Jun 2020 12:22:53 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jon2j-0001vU-5o for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 12:01:18 +0000 Received: by mail-wm1-x344.google.com with SMTP id l2so7647217wmf.0 for ; Fri, 26 Jun 2020 05:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dg6MQg0di+LqjBqONGXXxyBRvWh5krLOCNnRvvUvfe8=; b=VTFVQpH1dFYRfxcEVx1bIlmWtAfGkxcoZS/nr0pP6c8NX8FurH4xumCl5GhdhERzRX X0KxL66ekXPT18Cyga/sr+tr1CYTt42D4hLtbgE7yywKGiesUCemmKbz+hYBN4VYtJGZ 6foOfmsUMOd/k+TR1XAcDur1OD9lKNpjlLA0ho0BMJ9jNKELA52kVOvYCl9NC4jCilog WNN6v9hYwpbq3/rOXyU2k70kRnhyxyodAQLYKiG7muWYTb7nOEGpM7futwBV6jayL3l6 6eaeOJE1Xebfw7lDx3cmAjwkTTz0GPJkpiaJsxzbB+es+cm2P0hiSeOKGxuFiSX2ZgOE k+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dg6MQg0di+LqjBqONGXXxyBRvWh5krLOCNnRvvUvfe8=; b=ExA+aQpurdPFiO1u2HHxSgQyHOra/IJMos28AjeiglnG3PWCDHV2v+4c6Tr9rZstsl eyIbWmS5D5yxYMzoNgGRnYl+INeXNVDV/EaKj9SJBI/tECdLrWZZysJibUmFJ57YUYnl 7+0Gdxh6LZRMwnOliQqRGGIj2bvWNmMiS8GeVe/nLrTSZL30S1XpZmn+epl0dRl9Ynwp mNxW0DeveYm4kj3iqZzHrmy/eVXoC7jVuNfYxV4hXmMT7pLuKVairgH960mA6SBMtpcQ 8SH32A4NklHnKrqlsk64booqL4j8Z1Dmsx3EHcDGvUBudnv++LW40ppuwo4zvUarkVOc kKEA== X-Gm-Message-State: AOAM530DOxxWhrWPgGb2JBiQsG7F9uQ2IcnNesrPAd/pzhnCDWDb10uq 8v62t5xwCNFSbPonAolfhcZsM2i7G3lPcw== X-Google-Smtp-Source: ABdhPJwAKgulgVqfj13NpdmZBph65BTuF2FQs3d33CORBUFhvk4113wi68pqZxuDe+nzewP+3ZAlbw== X-Received: by 2002:a7b:c381:: with SMTP id s1mr5308570wmj.25.1593112634724; Thu, 25 Jun 2020 12:17:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:13 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 01/10] regulator: consumer: Supply missing prototypes for 3 core functions Date: Thu, 25 Jun 2020 20:16:59 +0100 Message-Id: <20200625191708.4014533-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chunyan Zhang Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org regulator_suspend_enable(), regulator_suspend_disable() and regulator_set_suspend_voltage() are all exported members of the API, but are all missing prototypes. Fixes the following W=1 warning(s): drivers/regulator/core.c:3805:5: warning: no previous prototype for ‘regulator_suspend_enable’ [-Wmissing-prototypes] 3805 | int regulator_suspend_enable(struct regulator_dev *rdev, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/core.c:3812:5: warning: no previous prototype for ‘regulator_suspend_disable’ [-Wmissing-prototypes] 3812 | int regulator_suspend_disable(struct regulator_dev *rdev, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/regulator/core.c:3851:5: warning: no previous prototype for ‘regulator_set_suspend_voltage’ [-Wmissing-prototypes] 3851 | int regulator_set_suspend_voltage(struct regulator *regulator, int min_uV, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Chunyan Zhang Signed-off-by: Lee Jones --- include/linux/regulator/consumer.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h index 6a92fd3105a31..2024944fd2f78 100644 --- a/include/linux/regulator/consumer.h +++ b/include/linux/regulator/consumer.h @@ -32,10 +32,12 @@ #define __LINUX_REGULATOR_CONSUMER_H_ #include +#include struct device; struct notifier_block; struct regmap; +struct regulator_dev; /* * Regulator operating modes. @@ -277,6 +279,14 @@ int regulator_unregister_notifier(struct regulator *regulator, void devm_regulator_unregister_notifier(struct regulator *regulator, struct notifier_block *nb); +/* regulator suspend */ +int regulator_suspend_enable(struct regulator_dev *rdev, + suspend_state_t state); +int regulator_suspend_disable(struct regulator_dev *rdev, + suspend_state_t state); +int regulator_set_suspend_voltage(struct regulator *regulator, int min_uV, + int max_uV, suspend_state_t state); + /* driver data - core doesn't touch */ void *regulator_get_drvdata(struct regulator *regulator); void regulator_set_drvdata(struct regulator *regulator, void *data); From patchwork Thu Jun 25 19:17:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627343 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70CB21392 for ; Fri, 26 Jun 2020 12:13:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2976A20775 for ; Fri, 26 Jun 2020 12:13:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gr6NT1XL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BoLnBkwq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2976A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fq8OdAo2DIuoJtw2mHe+22XOsAFVmR0H0Y5D8/aOimE=; b=gr6NT1XLWk6S9stnGF5aR1BSl HhevVYn9QfKILG2x+O5x6ipG0IAyb1SU/vdAVNDR12QLZpR6geOQqy5hOjcOW4YtVBE2CJqjWPAL+ po5mTCi6hzjaGVXO66FydDE6JVglG/Z1ahmkFywtgplJ3wqH6dBgtPsvYPl5SWHnAewyQC7yD0kyA 0VcdoBP2hxqPGkBOmE+88XwVHPJe9hDboaivK2SryOtLA1EBDoZAawMHBAJL5UgPe3r4v616d1ieS mfDwqUtW+mmB5Ybg3VECw+Rgrr8N02SBOPvOMK//5XrgIChx4sC1IYuTEEGIcZYEZ7Eb7OUGMBfN9 pq1DMnV7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jonBv-0006H6-Qm; Fri, 26 Jun 2020 12:10:47 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomgw-00083v-Ij for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 11:38:54 +0000 Received: by mail-wr1-x443.google.com with SMTP id g18so9220997wrm.2 for ; Fri, 26 Jun 2020 04:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o1XJQv3xdST2ri9dQSPRqTi+utLoroqVOFsqThWptWg=; b=BoLnBkwqv59Kv2JXYWfehBShW2dawYLjjfGT83f2LDKPJ9DgeFbYuYiBm6hc1IninT NM9ehe+OWD5qfZiGF1uCZ9zhVMIMIyI5CnwksIQFJZV6Pbw5GBXKCGQVq/sv6WhYD/C0 bQXZOeTzc7Jzg8nOMOU3Rih1rtIpcJL8Z+xtAw0oodBjpYyJOEB40dl73dwhB8AZa5kY lwv5HZCL81ivLPF8dLnO7OgYWsxtDGdFTuN8lvKVuBb0Ts6cv7B2a7sfnpuxG4qqktkD 0+yBMZMag2MBjMaz6Pscwv1+3auLTu8n05bYIQz6+DgEl9C+19kfCrxi3gTSXcsYHul1 KQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o1XJQv3xdST2ri9dQSPRqTi+utLoroqVOFsqThWptWg=; b=U570l6sck9Ax3KdN+NBc03lYYx/SxkRIbnVDRJW9WYVVbUp4sjriHkXzU7UwHfybPa jcjuokZi501ZY7NsIPmDMwOcwgSGGfbYCdb27uKCiZ7bwaBTCfPVgqDNzZDig7dUXFzk fwzQ7RONEUjA46MW8GA7tMQmDbmUFeRj+8sXay8FrEovudalCS69TkVSVyIOgYNqkaYt x86JCLgqR1QtJb+LIBeE1DSot9MON67nUaSLmnOcjrUKHuLCwrC/ssHVt2p72RbbwQz0 iv19ycR1tZNXe9iStebQBvHgWPuGv+XNOWxUduc9KH/alnJY2wWr79apgzrR83zsfU1U TqMw== X-Gm-Message-State: AOAM532xB4XMFNe8tf/8x+uopWwgaP1xkKsfsWfWHxcOj8Ox7BqoZZA+ v5q16FOVUhnZpdKXcxfZTYdh+5PfCJxB1Q== X-Google-Smtp-Source: ABdhPJxtSqoSA4WAktcHqgHNSJc/uRopu59O8Pv32mWtJTYz7hbM01rHb3X/SSRuT+mhPP39eykD8A== X-Received: by 2002:adf:84e2:: with SMTP id 89mr34557885wrg.139.1593112635636; Thu, 25 Jun 2020 12:17:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:15 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 02/10] regulator: devres: Fix issues with kerneldoc headers Date: Thu, 25 Jun 2020 20:17:00 +0100 Message-Id: <20200625191708.4014533-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Provide descriptions for some missing function args and rename others to match the names used. Fixes the following W=1 warning(s): drivers/regulator/devres.c:187: warning: Function parameter or member 'dev' not described in 'devm_regulator_register' drivers/regulator/devres.c:226: warning: Function parameter or member 'dev' not described in 'devm_regulator_unregister' drivers/regulator/devres.c:226: warning: Function parameter or member 'rdev' not described in 'devm_regulator_unregister' drivers/regulator/devres.c:226: warning: Excess function parameter 'regulator' description in 'devm_regulator_unregister' Signed-off-by: Lee Jones --- drivers/regulator/devres.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/devres.c b/drivers/regulator/devres.c index 3ea1c170f8402..3f73ce8590007 100644 --- a/drivers/regulator/devres.c +++ b/drivers/regulator/devres.c @@ -173,6 +173,7 @@ static void devm_rdev_release(struct device *dev, void *res) /** * devm_regulator_register - Resource managed regulator_register() + * @dev: device to supply * @regulator_desc: regulator to register * @config: runtime configuration for regulator * @@ -216,7 +217,8 @@ static int devm_rdev_match(struct device *dev, void *res, void *data) /** * devm_regulator_unregister - Resource managed regulator_unregister() - * @regulator: regulator to free + * @dev: device to supply + * @rdev: regulator to free * * Unregister a regulator registered with devm_regulator_register(). * Normally this function will not need to be called and the resource From patchwork Thu Jun 25 19:17:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627199 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 088566C1 for ; Fri, 26 Jun 2020 11:16:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D467B20C09 for ; Fri, 26 Jun 2020 11:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MwxFn4Dn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J3t8Bw93" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D467B20C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hkc6LIdIWJdIm9IR29WBRnyCVXOAhCyJnxq8uH7INbc=; b=MwxFn4DnhbSETjAIDMHChstBe LFp3gd7nZNU1WnGVnQZgVBK5Fs8hzIpfKowHt9GXVE+M3K3viW+oq45dzXCAJsxrfE7OR9LNERiIh lreawBmZPDuBI/h3tuQ2Yb1WbtvpHV6MQgSWsbX3puMMJLLdpqNeT3Dpg1cZcimTQle06CDh1vX/+ 9SuIarWQ7x73fMLM0gT2PX6Z0fPnjXGr/0ZWq1N4d63InM9DInT5cAWyt0UHmrm8nXwIB0RC7S4TB 4DjHUubAozNkcfFQugXfTPCGqWlWAeKY2MXsB2tVTU3LAkkCBkapvX/GaZGX5Aj4+KfJJ9pNHcRHc UjAHLp/4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomJX-0006LS-HI; Fri, 26 Jun 2020 11:14:35 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomJF-0006E6-FQ for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 11:14:20 +0000 Received: by mail-lj1-x22f.google.com with SMTP id h19so9863330ljg.13 for ; Fri, 26 Jun 2020 04:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4/CDB2l4JpZBpeXJ5F7ZtKgNEooXeOnUoj71PMW6rrU=; b=J3t8Bw937CgTO8lYSG+HhLvnS7lV0gd31rIQ4Lk/CXtSfXHWwrivgfL1x1f0otUOMT cjmuYjZ2VrkY2VEjcXRp/zOcAXeugJ8Nq3E5cD5WBUIAqm4EBEI6TQbGY+fq/aut1Dji hG7uosrCrRrCnDnjXAkcrzMD0IYZA8QTuym0FqwNLFLPYDnL1LXQCn3jqo+6cKL9FCxf iGTX9Nt0p3Zm+5RHOCBvVDFcW4tHJyOuCEj47k0cTWSrYfXP/gLDd0mpjYgboDIA0alY vjrcQr8f3ci5XKMOI9V5Y/lkf8+KSCyWe838LwaW8Ga/1JT7G3i3mjz8GGcwUoiUTV6X +E6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4/CDB2l4JpZBpeXJ5F7ZtKgNEooXeOnUoj71PMW6rrU=; b=hQ2Z/r28E26XcbH1UkY0rCHoEswFKoZzymyl06kQ2vjBPH9U9SImu/s/YcHuF9K0NV NYqt6h4yhFQ0GwiMEt2aeg1RA7sDaTkh1nEf/4Yv5xINk58dVkhwc2YcnC06IJGeuVNz X2oR/+pzSMdM2Ql+Zq2ccHvVgG1ospN9UYr0aNevDihzUwpGQ5Gk1RIHVfojtaUAra6x GzVLe+iYkhl/+xBiGF1JpCaqU7qwg/oA6pw6PWsHsCbRb3Npw0PLJNssfdUrK3CmuH3b iIa/Kov9rbBjMZOPAzngfABkfuQZK/lzJFrJ9CArY3eVM3kVvCYIwGi4C/ql9D2X1vZA tFPg== X-Gm-Message-State: AOAM532jqIqzjCRlwEg8VDUV9JNM2ziH7duKX/fom9wQRFxQXjZQoyRn q+KngatNBTfUTCeBMozEkShlSI8a6STvaA== X-Google-Smtp-Source: ABdhPJyIYQF86tVFqTQfAszSkBtYqZ9soigeoM9NELkd6pzeaRIJNybLyLmMNBTmcL1wQhj+AB+qGg== X-Received: by 2002:a5d:6809:: with SMTP id w9mr40614001wru.182.1593112636948; Thu, 25 Jun 2020 12:17:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:16 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 03/10] regulator: of_regulator: Add missing colon for rdev kerneldoc argument Date: Thu, 25 Jun 2020 20:17:01 +0100 Message-Id: <20200625191708.4014533-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajendra Nayak , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc validation gets confused if syntax isn't "@.*: ". Adding the missing colons squashes the following W=1 warnings: Cc: Rajendra Nayak Signed-off-by: Lee Jones --- drivers/regulator/of_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 87637eb6bcbcb..06c0b15fe4c08 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -532,7 +532,7 @@ static bool of_coupling_find_node(struct device_node *src, /** * of_check_coupling_data - Parse rdev's coupling properties and check data * consistency - * @rdev - pointer to regulator_dev whose data is checked + * @rdev: pointer to regulator_dev whose data is checked * * Function checks if all the following conditions are met: * - rdev's max_spread is greater than 0 From patchwork Thu Jun 25 19:17:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B2FF90 for ; Fri, 26 Jun 2020 11:30:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F5E820724 for ; Fri, 26 Jun 2020 11:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QLDA2lOn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FDSYeKQJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ChFks/XE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F5E820724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bRGc5bwkmz7qGjBnc+MIWNGJyBPea0TrATQspkq3Sw0=; b=QLDA2lOnO5Qjm6dNN/0aJxIzg qH6uhbfZ++6wbRpMLNJfTJh0ioNaLODKBtkjQhRn683VNiXAmKbczpQ1QtwAPfeo4uWuU/d6WG74n FPhSD6BGZ4t64qpo4F8WuPISUkp7s/n25iPEF+zJNHSmJT5FCBoYty9e6/nZMUm6cKoBAFMU8spkD 2VpEjGH/JBMkRWxluhKI5gssf09/WTWh2HFP5FuzqGLE+eX+ES8l+SLODjoVavdvBQvR/zR/Aevc9 /NMRHCRXceVvk+aqZg7TSWUd+7LbX+d+bFf0duyT6AYweSYpax76DiX8ftMcFfU9vZtKMtv591jiM j4PSdXHaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomWZ-00039h-IB; Fri, 26 Jun 2020 11:28:04 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolFk-0001XZ-79 for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:06:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=+r7WAzJKscpz2A7LfanwlEQFW/6BOounTqgY0FCqgHk=; b=FDSYeKQJgwpn8fz0v4SmhcdCH6 Ig66qh85meomH64N3bZrV5SnmAdcPLZ39KEM6Z4GrKeJCbZzIfZm1MbHOmjxbeYjn3Gnq/HsrkYLZ X7E5Yo3UQ66rFs7sGu0sxO6/NqOumUI4iwHxCrrGML7LC/HDjuj2PPUjFXfoObqZLvhLfwA76BI/b x4xJ4VmM7+tzHvHjXmJOHiwFeFLRMJ/b4I/seTag+JLKc/zxt2tTGF8/Uy8KdFWByR64oTYIqwftB ssI714GgeyCRAVAiidFnIam19xO1kbMNj9jGvLbXBKJBXKskFkroWzS3rzXKzR6ebzBKMX9KxtsOq yCN4CsGA==; Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokkZ-0003RL-Dv for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:34:52 +0000 Received: by mail-wm1-x344.google.com with SMTP id o8so8188420wmh.4 for ; Fri, 26 Jun 2020 02:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+r7WAzJKscpz2A7LfanwlEQFW/6BOounTqgY0FCqgHk=; b=ChFks/XEc7bzV0CTcMWfhB7IgCRQxU/ix22NfRn6vDTUiSMVowVLaUl6yu7QMlcVVZ HIpJw4xTHVybS62gdWM1VHFFBSK0dTQm5ovklGSePPlvX4kAkJhIkf4FubT+ZkZ9yhij CTVZrQko7ww3J9imShFnpURQHqUoLNB/YAfvXak+Efsy+I07bcLsAD++oVv9gQA5rUe/ 1Nm5+BIUSvod+52HYDbqpSQKJogjRpztt5k8ZN6oHSxjr2MOUuZLeddwge1f5DpitMgp toasWrca/RulM3TnAxEnjBxB38zyKS1zf5HDbx2hn5aZZWbfKiCM/W50ed83S/NIjsYg 8+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+r7WAzJKscpz2A7LfanwlEQFW/6BOounTqgY0FCqgHk=; b=bKs7YYi++y2j3oa5jRVbcqOMr+anEOCvpmU9+/c8sEss8daC4hfCt9r8fZFpfmE8dI NgIvUschSUjH220hWgvG/WVmufMRrb0mieN79LhlsAI5niqgp+M7ma1Tdw4mElM540rB AKyqCerI+JUi9Wkgg1Jnr2oelavZ6UUM85C/clVhhnsNGll70HEe1E5N0W585ilgQbPq 1XWiXB47bTgpZxNcvAyhX2AESMniUxfBoOR340YbHTEsPLKsjA5Q8Sa3wHypWRmPyVJD AZTc0YJKX7A173NO8uBQR6ZkF36TkGiFDlvL6+R4cCklu3COpCe2nwVJpWTyd4/FIG3a gg7g== X-Gm-Message-State: AOAM531HiaeP+eZq3hvJy17hFIDoS1/OZOpltCZIc+jSXqUax1hlKX8v WmCK9YoEPOyx865i6yuyvHLMzxFkodjyTg== X-Google-Smtp-Source: ABdhPJxocm800/ZlJ2PBjWP1tsP9WN64x1zPnFXiyjxHxw49nomSN71rB9+UScUF2TFK7UoUqEPKzw== X-Received: by 2002:a7b:c348:: with SMTP id l8mr5484694wmj.54.1593112638103; Thu, 25 Jun 2020 12:17:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:17 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase() Date: Thu, 25 Jun 2020 20:17:02 +0100 Message-Id: <20200625191708.4014533-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_103423_808061_81BAD9BF X-CRM114-Status: GOOD ( 11.98 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There isn't any code present within the current kernel to override this 'weak' function. Besides returning '0', which is never checked anyway, the whole function appears to be superfluous. Consequently fixes W=1 warning: drivers/regulator/dbx500-prcmu.c:113:27: warning: no previous prototype for ‘dbx500_regulator_testcase’ [-Wmissing-prototypes] 113 | int __attribute__((weak)) dbx500_regulator_testcase( | ^~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/regulator/dbx500-prcmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c index f604c8db6d0e9..c3ad6aa6b5d37 100644 --- a/drivers/regulator/dbx500-prcmu.c +++ b/drivers/regulator/dbx500-prcmu.c @@ -110,13 +110,6 @@ static int ux500_regulator_status_show(struct seq_file *s, void *p) } DEFINE_SHOW_ATTRIBUTE(ux500_regulator_status); -int __attribute__((weak)) dbx500_regulator_testcase( - struct dbx500_regulator_info *regulator_info, - int num_regulators) -{ - return 0; -} - int ux500_regulator_debug_init(struct platform_device *pdev, struct dbx500_regulator_info *regulator_info, @@ -152,7 +145,6 @@ ux500_regulator_debug_init(struct platform_device *pdev, if (!rdebug.state_after_suspend) goto exit_free; - dbx500_regulator_testcase(regulator_info, num_regulators); return 0; exit_free: From patchwork Thu Jun 25 19:17:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1AE0E60D for ; Fri, 26 Jun 2020 12:30:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E64A8207E8 for ; Fri, 26 Jun 2020 12:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WV4vFYdJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OERUmgpV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tmCpEbSO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E64A8207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1MUfjCvl8peQ1XOzmhyeWFq1Hi8/k9Psl8C238/ebNA=; b=WV4vFYdJYq/EOxycR/F0ov49R Hms0OO4uN5HKBfOTC4Fwgwz3Z7EQQzmibsT1YCLn9IOURHQLtiIMeWo7guPf5YKbBLB0vOqo+LcfP ZRvSgU7Q2lDo5KjSZkFJcZkOvJyeOOJs62zs635O38lIt/xz7aVu0hdzIMBBK1OW1DQbbs2Rpd4PK 4cHSqx/c1oZ7WdcPdv0lmtKGKoiZXky5ARZ5LpNfi8TFasdYIigcWY3ZByMDDQWNg+R6E7LqHoBwb OZjnSfdFtEnzrYqeSvZ9yAN1oXiRRtI9dCdOCim7HwBWujxoOjmV1pa7MLQY6j9HuaHAno8sDHGI2 hSpNPOkrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jonTq-0006qv-Im; Fri, 26 Jun 2020 12:29:18 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomEf-0003tC-Qv for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 11:09:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=j4djQhcgSgTg/9mtm4BHCd5MDCRCq+1jmLB+caUyB0M=; b=OERUmgpVenbML25rP//V+IkC8e hpjl7xKJBO9orLsbrI/gBP5hfZpW0KkfPYUbqMiBQpN1ViB8X29UPize+GbOI1OyrY2I1E1CnXtXA jszAxAbvPlQE9W4e5DHpAkyy1Y3GEkaivTSa0e5ccb9GLr8bpBYk8lxeed1PgHMNCAXvweNZVHgCg 5oeUoH/OygquNpT+SPlB/CHZdzbCdryGMENTLNeABkCcJTkpiAD3Pj0OdlfCUTwhcYKf+Vd4z9p0U GGfwxX4ohzn4RJqYbHsCv390iDmYPkLUy2CKkx2NUzmQ7+6yo+2eWRPeA1kyrZObyRBbXXV+8Rcmg r3ncljDQ==; Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomCE-0005iU-SN for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 11:07:22 +0000 Received: by mail-ej1-x643.google.com with SMTP id p20so8917951ejd.13 for ; Fri, 26 Jun 2020 04:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j4djQhcgSgTg/9mtm4BHCd5MDCRCq+1jmLB+caUyB0M=; b=tmCpEbSO5A63g/ncvKbOwmY8ndQGqysFj9YM7YJH9vcFA1KQbqIHeegdH4VZq2Sfzg 1nO++r+wXM140SabSVtpFxRLswNTuUsjqQtyAN006BO9tYL+i2dFGpOaF+8aGSmddfwN oDVjX1ZE6aX+Alb9sEJo5Br2x47SYFxxIqHxUVWywWMbDeVeEZbU8szbVjRRUqW+Piyo TbvuDf+7UoMFVYcfhqOpPVKDCg2cVqsPjxvEBI+zrgTresjCjMBgoXwiH8pv0s6yok1v qflrl21jKsf3H2N+5P7wTPXGDnUxTh/TDx75VTRMwjzJsmrxr3Hh3+XnITkjaGmBg4v1 RoBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j4djQhcgSgTg/9mtm4BHCd5MDCRCq+1jmLB+caUyB0M=; b=J1Sl8GBQ7XS9wFqglD1EBor1bprtEQz+/vtfcxA6doFONKdR5snXTpus0aUphOLf08 DgtfcIoY+Ouo1oiC1MNS0aWrTp0w5kwHmvObIMqlii+hEXuoTvA4+0JVUxxo/Lz7Ro5G eux1V6d7buS9pSClzOHd0iM5DYMSVmVkw9abvky4e7yKfhyHDke39htS5yyEXiyOn7Nb eeyh8m5X/K1dKam57rWvbV62UsqcnqF4GNULKM6T/t7zYT3iyVgHvpIS/gbvBBD6Jcai iXYPDKO3hZsjoE+R8dmZSVSDw0enkh/U3Dn2xmfbp3FpPb5kANeFFzsFHwdAoLCn5tfg I49A== X-Gm-Message-State: AOAM531gMUl3X4Y2dsZrj+pUA+LZq1Y0Kw24DKYRFSziB1QE3Yo+vd2v 1GWUPSCFvn2KVGb7v81+75WUNfF53uxZZA== X-Google-Smtp-Source: ABdhPJxfrQVQDk1A0hJljlXTR/40r15qonzvIABkQ+QNdsonSUnyTjpbtsbUomDnBDW4ZUxRsTCUBg== X-Received: by 2002:a05:6000:ca:: with SMTP id q10mr19640747wrx.135.1593112639977; Thu, 25 Jun 2020 12:17:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:19 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 05/10] regulator: ab8500: Remove unused embedded struct expand_register Date: Thu, 25 Jun 2020 20:17:03 +0100 Message-Id: <20200625191708.4014533-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_120704_513624_3401BF51 X-CRM114-Status: GOOD ( 13.26 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:643 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Used primarily for the AB8540 which lost support in early 2018. It is now deemed safe to remove this legacy data structure. Also fixes W=1 issue: drivers/regulator/ab8500.c:88: warning: Function parameter or member 'expand_register' not described in 'ab8500_regulator_info' Cc: Linus Walleij Signed-off-by: Lee Jones Reviewed-by: Linus Walleij --- drivers/regulator/ab8500.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index 716ca5bb178e7..47b8b6f7b5715 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c @@ -59,6 +59,7 @@ struct ab8500_shared_mode { * @voltage_bank: bank to control regulator voltage * @voltage_reg: register to control regulator voltage * @voltage_mask: mask to control regulator voltage + * @expand_register: */ struct ab8500_regulator_info { struct device *dev; @@ -79,12 +80,6 @@ struct ab8500_regulator_info { u8 voltage_bank; u8 voltage_reg; u8 voltage_mask; - struct { - u8 voltage_limit; - u8 voltage_bank; - u8 voltage_reg; - u8 voltage_mask; - } expand_register; }; /* voltage tables for the vauxn/vintcore supplies */ From patchwork Thu Jun 25 19:17:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627087 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 351416C1 for ; Fri, 26 Jun 2020 10:32:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DABF2076E for ; Fri, 26 Jun 2020 10:32:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ueHoOPA7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dCAo2lhM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DABF2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OVYQ/hq6BAhrwiPzReQiNYDjKeKBVhCzdBXUNH6OKfo=; b=ueHoOPA7fdRgaD68bLbvseMjH zenyZww6M/7KMdTyiDQHrmizGbbyQ25HaLVpxUSHmiJ7F+3uxaZmWWqwAU32BcWdFPZI1snGKMCe8 vtNshoOx7On13jWpRb/2MiUa5M4jnHECuQ0Bh/LHHtjgeXdPE9ET5n6ckc7za/dmcR0rvWHZvqRTe gEMSgnQnDnKdi1BZxJMjA6w4FQWow+wIIGnY6ubp4bGNN7yXdPwwWi9oLAA1jXUsovVHnhHBQwQhJ Ydv0s2EpZvQBKZlcdPnyKgsL3GkGvS7SZoOehffQvXnnWPvn4VtBFFSM6wvAcC0+wJd7VkP6fYC3U FIdT3WjQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joldM-00056O-LC; Fri, 26 Jun 2020 10:31:00 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jold4-0004yg-Rx for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:30:54 +0000 Received: by mail-lf1-x142.google.com with SMTP id g139so4859367lfd.10 for ; Fri, 26 Jun 2020 03:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dtxyN/1kKIF9/7TTE8iRG6sUFtmO+Fu1upUgVSih01U=; b=dCAo2lhMHJ6NdZfByQXxyz/SilOR/HaQ4pU6fAkuElnZt1kyUUuWW2txb7RP5Sx71d vPyJ+232KysYhAHj/oXvRQFfipE38M//axfZd6N7wNBzZdRFiaw9PpV3gjYTBOGqQdp6 SSsdT9motcSOSYnmISrrkVk0qXEmHXBKgrfMwAVaqtoY9k8PFSuHp8pto4xyc/j7leAY g9vwZCZYX59BKX4NPsZnzEx59VQoikmfepvWXsMfBFzu23yrwxoKS1CtX2yupeJ5l2Ve ejZGLPZr2e0cQAavi37yJcRawSGCUMqTMugvD+tmKqh99xDzcLd7njI7mCs1IcuzRREO TgFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dtxyN/1kKIF9/7TTE8iRG6sUFtmO+Fu1upUgVSih01U=; b=NJ91ykxlsgA+0ePqvILYQJIkSSD7QF13wIjY8T/eJ2jLxKb8nvMaax1eSfPb/9xSXA 5f1CxcChTBQQLSOhn13BjII89kMBJ4lpF4K+QLwPLp9+dSYM8u+XApB9hZAf2aU/lWH9 aWxNCXYBCcpYyW4xQkmKZHaBjzbQHwGKkP22bf5Chd9jDSdzuxcskxR5kiDV3le95QuV XVVsy7MAaNM4twVaSFuvjcx1S4ghcAuw6N+Kh5Yd5eDFYGTdLU48cRJcAqFUEzDkENMP o9akijxxbZaDDe1sLCu749cKwjkh+G1AZ/mftHJvR7DhJ1VZsXFl7Y6LaVxSO8mnkRAm GW4g== X-Gm-Message-State: AOAM532TEadamIN0ncg+IovL+Ow7uknQlbe8QXDDbkL2n9g3K8q/xIVh IekSXtRRu4EmyJPZTpZSCMmCgpsfT5TgZQ== X-Google-Smtp-Source: ABdhPJzCK3QqVbhCKU/8mHFqhgDbsJuNWAuV/wA5EVreGSMHRhwhU/xzif2uG9N7vr5wfQE6elguEw== X-Received: by 2002:a5d:630c:: with SMTP id i12mr17386670wru.158.1593112640968; Thu, 25 Jun 2020 12:17:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:20 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 06/10] regulator: wm8350-regulator: Repair odd formatting in documentation Date: Thu, 25 Jun 2020 20:17:04 +0100 Message-Id: <20200625191708.4014533-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:142 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@opensource.cirrus.com, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects function arguments to be in the format '@.*:'. If this format is not followed the kerneldoc tooling/parsers/validators get confused. Fixes the following W=1 warning(s): drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'wm8350' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'lednum' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'dcdc' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'isink' not described in 'wm8350_register_led' drivers/regulator/wm8350-regulator.c:1234: warning: Function parameter or member 'pdata' not described in 'wm8350_register_led' Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones Acked-by: Charles Keepax --- drivers/regulator/wm8350-regulator.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c index ae5f0e7fce8bb..2e7bfdf7c87bb 100644 --- a/drivers/regulator/wm8350-regulator.c +++ b/drivers/regulator/wm8350-regulator.c @@ -1216,11 +1216,11 @@ EXPORT_SYMBOL_GPL(wm8350_register_regulator); /** * wm8350_register_led - Register a WM8350 LED output * - * @param wm8350 The WM8350 device to configure. - * @param lednum LED device index to create. - * @param dcdc The DCDC to use for the LED. - * @param isink The ISINK to use for the LED. - * @param pdata Configuration for the LED. + * @wm8350: The WM8350 device to configure. + * @lednum: LED device index to create. + * @dcdc: The DCDC to use for the LED. + * @isink: The ISINK to use for the LED. + * @pdata: Configuration for the LED. * * The WM8350 supports the use of an ISINK together with a DCDC to * provide a power-efficient LED driver. This function registers the From patchwork Thu Jun 25 19:17:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627195 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2BCCC6C1 for ; Fri, 26 Jun 2020 11:14:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 040AC2080C for ; Fri, 26 Jun 2020 11:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S2qEJgkZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="i7Nzr0VW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zves/PjM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 040AC2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jj1aFwfirGAu66EKbPgo08FOHGKXveGVl2gy/X3IfF0=; b=S2qEJgkZ0gq29w92wJF5laBX/ yX+Dnxt97h2ch8NwV2tRBWYDnaOT+9nyBnbjoauI631ykMAe8slWy7edcZk5g/N/CMyTVJEI+be3J /ffAzC0DW0KrWPbDb4+XYceHftURL9x/C29vWWfHWuZp9ersz1sWoFe3XlvEIwjHnv4BH8j8Xh9br XYHIAc7s7GBIEdxqa76RhYp1LXnmZ1QDrglGRDWWqyYisKyTpUvnkgGICH2MIHETjvUhw+ZfSHamP Ymp/cuQSDoNhdtedMoxVzwC//Bp+NO/p/lPH7m1/dFSlsJyZCKn6RxF1BzvDbqv4S6en6w6VoSEmP fY+fCUrbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomHS-0005KB-Js; Fri, 26 Jun 2020 11:12:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomFJ-0003r5-Eq for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 11:10:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=VJTFtlmSJJssMoK2NzaWqKKHmjNJh935ngd0RHoSQ4I=; b=i7Nzr0VWRo08OXHWytAnB//Tni JIGhY1P20u+km9kFaDMjD3zrrl2L8+NNC9vQi95fJ05/CM5809KmrOqCpDAsjvsH8UhvWbJWxfdZa IHS2ZMxgpP0vpuahBZJeY03izGEQhhCsy9X5Pno4lUR02JRQaE1PViLlr5L8p8IMsxkgLURPGkv5J Ex/HF04XMtUqz3heGusNJdUSiRro1+KhgDvLJQtF5Eyp/epLLR1ADyQJUyEFQPCmdHzz29UwhChkj v90O0AL7bGZjNHe+xOVrRGpvnBLyjvLMzbVL0h4OMNv/XHaxYc9aTRl6aFcYaXH5NJ9TBBmWSOpJ5 0F7BRvDQ==; Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jom4V-0004oF-Ci for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:59:11 +0000 Received: by mail-lf1-x144.google.com with SMTP id t74so4930301lff.2 for ; Fri, 26 Jun 2020 03:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VJTFtlmSJJssMoK2NzaWqKKHmjNJh935ngd0RHoSQ4I=; b=zves/PjMXG5dsDUU3LkKSqvd8Bb0cLVC4eNdrmRTaXPn3sjcy9wIXCjmp4oOjJ298l YwImrnxAene93jXTIWVWM7v1FnFrZ2XY/VT3blGeG+jT79aoHFGu1p5/clb2w+cMbLX3 b093iveq45CviyVp7oOKIxrnO/t3MVXzq44W/IWi77iSIsZ482hjzQKzReXHdOVjv3XL kD+qjvbQVJPQsSEtil8n/WCGrxnO/6kdotX1ZWjp2HJbChf8oPE4thsI9msSAs/bKVER gz8oecwLYYbbG+Li7kB9lUjOPlCnykyn00TgD9mURb3uGkJm+yPXNknQkKxyS1j6Ijdl u1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VJTFtlmSJJssMoK2NzaWqKKHmjNJh935ngd0RHoSQ4I=; b=dfUbUaKii+G0+nmj4NzFpbo+GaqGHrToQ1OBlfbuuZRnvQjDLyGGDU9BUanBHuf5s+ FwzJ0BhSAGN6i6b58oO7OVxRiORdBTrGrJ9q2b6YC72qCdStQ0ea3gFOcGhgGQanldm7 N0ahwlrUxomvM0q9Obd6LBOwUo6MAUbVo9ZEXeQLiHx+pNd0ib0JmSIvs7VGq0XaGy7M WXLWJ5Rq+MKrMovpHiq2ppNbxgKPMB0CLg+bNGUfJX3ZE5cYqIic/fHGLJVGuIHxse6C tUAia+FRc+L4tm/jt9SuxjRYEH/Q84SQ/5AKJHdeuaqyu3Id5YjKCS+flvIrp9GDvid0 YHPg== X-Gm-Message-State: AOAM531ZNXIN0kfkb9RCsMdc7ETCocu3VZM2g0bJErrRkM2C4Q1LvprL qhJRcWzhgBnZOBvQQFqQuawFpJC0OTvPwg== X-Google-Smtp-Source: ABdhPJymLg8gydmo/J1S/z2FvMDOD/E0XTWBEtx2MX9NS1hIZsEuZGaoD+dfeVXI2wMZrmEbLwn25g== X-Received: by 2002:a5d:46d0:: with SMTP id g16mr41499262wrs.229.1593112642402; Thu, 25 Jun 2020 12:17:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:21 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore' Date: Thu, 25 Jun 2020 20:17:05 +0100 Message-Id: <20200625191708.4014533-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_115906_251720_D0B763F4 X-CRM114-Status: GOOD ( 14.57 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:144 listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It's okay to not check the return value that you're not conserned about, however it is not okay to assign a variable and not check or use the result. Fixes W=1 warnings(s): drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] 172 | int error, ignore; | ^~~~~~ drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’: drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable] 196 | int error, ignore; | ^~~~~~ Cc: Tony Lindgren Signed-off-by: Lee Jones Acked-by: Tony Lindgren --- drivers/regulator/cpcap-regulator.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c index f80781d58a282..fbf823b830308 100644 --- a/drivers/regulator/cpcap-regulator.c +++ b/drivers/regulator/cpcap-regulator.c @@ -169,7 +169,7 @@ enum cpcap_regulator_id { static int cpcap_regulator_enable(struct regulator_dev *rdev) { struct cpcap_regulator *regulator = rdev_get_drvdata(rdev); - int error, ignore; + int error; error = regulator_enable_regmap(rdev); if (error) @@ -180,7 +180,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev) regulator->assign_mask, regulator->assign_mask); if (error) - ignore = regulator_disable_regmap(rdev); + regulator_disable_regmap(rdev); } return error; @@ -193,7 +193,7 @@ static int cpcap_regulator_enable(struct regulator_dev *rdev) static int cpcap_regulator_disable(struct regulator_dev *rdev) { struct cpcap_regulator *regulator = rdev_get_drvdata(rdev); - int error, ignore; + int error; if (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC) { error = regmap_update_bits(rdev->regmap, regulator->assign_reg, @@ -204,9 +204,9 @@ static int cpcap_regulator_disable(struct regulator_dev *rdev) error = regulator_disable_regmap(rdev); if (error && (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC)) { - ignore = regmap_update_bits(rdev->regmap, regulator->assign_reg, - regulator->assign_mask, - regulator->assign_mask); + regmap_update_bits(rdev->regmap, regulator->assign_reg, + regulator->assign_mask, + regulator->assign_mask); } return error; From patchwork Thu Jun 25 19:17:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627101 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D3D76C1 for ; Fri, 26 Jun 2020 10:32:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DD9E20768 for ; Fri, 26 Jun 2020 10:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBidybVR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DJYjoIBY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DD9E20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=voRFthS3wmXFbWSIzc0m9iR/dKoLevd4H78Dsm18HGM=; b=PBidybVRp62fEs2kilASTyvdg 3W04BHZkzeHfj200KNZI/SmYvhu92SxSOzC88fKPkr8tUxUNcvk2aUhC0HAi52XeGxgeqCwDHP2JI mdF+8b+rs3+bncOLTWNzyO7879ZXH51CIdH4Wf1V58nlJmMG2kLnJZ20gC5WX874MxeO2xaWYWIPA ArJVTl6LrUM7bW8GZTb8dfkC4DihoTaySyOdxgp28Z3/r4E960M60HUX61Uc8APrwxfkuIHeiy9tp m9iLKba3/96kdVhKqV9Eh9Kf/QZHBEWnK3uRKccojSDc6cSGYk50QCWFdyJ3XQ35cVQfK3CX1dCZQ eKS0F+hZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolcW-0004gs-B2; Fri, 26 Jun 2020 10:30:08 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolcD-0004ZR-CC for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:30:01 +0000 Received: by mail-wm1-x344.google.com with SMTP id t194so8877603wmt.4 for ; Fri, 26 Jun 2020 03:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=akaAj645pp+5kfB2OMHemKghBJ6xbAKNYnmCPlCSuI4=; b=DJYjoIBYSS2lz1zbBDeTTsMP/zoqEcyAlbRPPhemK424wFYbrYKJ8nOzwJXHGnnrO3 xVgD4p5dW2IluzPSraMewfwy7VLOGiKVCJqXoDhOuj8jMgZ9uFV95vgLagUVoSclZUrP Yv/58ap4pjA2xK83ar6XJtiLkw7ZJj5t269M7AZOksbPNAlUw4aFRPSbVFEz0BLnhyHq ah2wRxrr/EB7e+CW9CzyK0IMcpAr6vOkCNG0NVggAASTusAgwhRbVrUgz2+agpr7FOE9 SfBUXPOM288pdFyoWOh4ihtvLnURlwfrdksVtHOcyl0PxOaxc5rbCSWywe23opzNF5EH axvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=akaAj645pp+5kfB2OMHemKghBJ6xbAKNYnmCPlCSuI4=; b=taJWEzxLxKbsgIngCCztGaJll5qvWX1Xp20TOGIRpg9YhDXXt9M1ODaQ6y+bZP539v EgHzCEOfUY9URGlcFnEMmWmZfSeBdqTQi3TjKtqvgujj2Vpnd2Zw/lizhT5GKTI5xeNJ 5vI+VRPze3suHjkw6T1rKEcfxWd9Yk1KQ9JmpQGGgMmlg99CGhKBZPUaQP9EhFSsmULM ZvQV0gH7Dtbl50g/mPetmSYJSYpl9IS8Qq66o7JbYvNb4qYeV7t4NR+WQZEi1MK2FKGk pxaXFqy0nVYA/SUILbo3U6CxQgzOaqQrmzVMOz/Oo8CRHickT7YOZOhggP3yh6/xs8yS MnJQ== X-Gm-Message-State: AOAM533cbyrv/uf+6LOcvyHyeb8JFYUT8Cjyvr06WFntHpnc50rHa67g reDAIBkwig6TPm+KRJ7eXiXrtaz8Zo6cmw== X-Google-Smtp-Source: ABdhPJxxuE2UVuaT+d/IHqyXzR0hzE7J39cB8NHtnMbnpwgisQf2e9In0WZInXBmGfRGOzs1i6h3QA== X-Received: by 2002:a05:600c:2108:: with SMTP id u8mr5436244wml.189.1593112643364; Thu, 25 Jun 2020 12:17:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:22 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 08/10] regulator: cpcap-regulator: Demote kerneldoc header to standard comment Date: Thu, 25 Jun 2020 20:17:06 +0100 Message-Id: <20200625191708.4014533-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Nothing about this comment identifies it as a kerneldoc header. They're missing all of their struct's property descriptions and the correct 'struct *' header. Fixes the following W=1 warning(s): drivers/regulator/cpcap-regulator.c:99: warning: cannot understand function prototype: 'struct cpcap_regulator ' drivers/regulator/cpcap-regulator.c:337: warning: cannot understand function prototype: 'const struct cpcap_regulator omap4_regulators[] = ' Cc: Tony Lindgren Signed-off-by: Lee Jones --- drivers/regulator/cpcap-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c index fbf823b830308..221e8db358c9e 100644 --- a/drivers/regulator/cpcap-regulator.c +++ b/drivers/regulator/cpcap-regulator.c @@ -89,7 +89,7 @@ */ #define CPCAP_REG_OFF_MODE_SEC BIT(15) -/** +/* * SoC specific configuration for CPCAP regulator. There are at least three * different SoCs each with their own parameters: omap3, omap4 and tegra2. * @@ -325,7 +325,7 @@ static const unsigned int vvib_val_tbl[] = { 1300000, 1800000, 2000000, static const unsigned int vusb_val_tbl[] = { 0, 3300000, }; static const unsigned int vaudio_val_tbl[] = { 0, 2775000, }; -/** +/* * SoC specific configuration for omap4. The data below is comes from Motorola * Linux kernel tree. It's basically the values of cpcap_regltr_data, * cpcap_regulator_mode_values and cpcap_regulator_off_mode_values, see From patchwork Thu Jun 25 19:17:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11626999 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3647E92A for ; Fri, 26 Jun 2020 09:55:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E97AA2053B for ; Fri, 26 Jun 2020 09:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oh9N0tTf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U2NxEfmv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E97AA2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q4niIU/lk28j9EL/joCiRcELI45f8riD+3jwFpWYDxo=; b=oh9N0tTfXLeUoAaRAUSZPuDo6 62v7U7mkQbdpqqsOGAymQd7jwHAcudehLwgwOr2wpYZYd6bJrGgk/9dNoIJWSX/8ee9IcEnK5Pze0 c8vjfPFgqEWdMjTtTmPjf9DCIhICwLnK5ESqPPzuwqj6gopM1ne7Mn5ZODeVUSETH+8MczZqwgl+W klaSfl1m4Pc7bf+830C1YFegyC7LB5gEx9d9LhHFhHkubEusepAvVrxF6W4JIit+6+22An31X1T3f biIFPAMKhowY8Ig+amRyrwQgzTkMybldZb5trN/wJefbaCdbKy/iA9NJRho/8tHGs8Tpd6oAsDAdR PPpKWeqZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jol2k-00040c-0x; Fri, 26 Jun 2020 09:53:10 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jokeK-0000ub-Oo for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:28:26 +0000 Received: by mail-wm1-x344.google.com with SMTP id a6so8470605wmm.0 for ; Fri, 26 Jun 2020 02:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xLynNpCT3aHwFMp9X5o+Fu0+7LET71ajpqSGjxj/VKI=; b=U2NxEfmvuzlHjSdqFrB1DTCE1IiLf6GxQI/mZCkymUUYetLIbpidegjuARBEpicPGQ SNxET/9290AhKWxrDFozhx518+EeIO9ctBFjEGTs0jSKZHie79lqbOw1iiDKLQt9EDFu 2omYoJoG6p1TeXQGaNtlqqfywIKA8zuqPz4U2b+r2sZepAMRdm+UJIo0GXnI51eZHAIu bCHRewtKelLzEBBhvIVEIpHkVOaefYVPAtfUlejG++R38YV1oPzV7lR0oCC1ky1+UojM hFgAO5zK9mFjdlUC5B4YcC9QscMdPkFoxvorPIA9jnvRG9Ig6T8bTpbV5FtaXundYkEL 7uag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xLynNpCT3aHwFMp9X5o+Fu0+7LET71ajpqSGjxj/VKI=; b=QVjafeg6c+cKb6srsECYAcHdKjteXS6d8QBGjR6Rw25JWwAxoWXXQnn+OpG6DNFnRQ gTtNv0opNbF1E/QBbzFqmve73/13+BJd/nT35O+vyk+g7QUInb0G2xCGPRqqLfe5bJ/9 i1p5EcdimJj4HWUMusiTDCe9WkXminVxyabLySokGy3mjF3Eb8LbLaj/BGVHA2tGLmWD PdsK/jYcfudoyCNoV7Zpywq0TOjrvMHe9B8KsAO3KlJsqiZdhB0P0xK8A/O6wdqIg2PQ xNHqi3HqjRf5+v4CyXlwgWT1+mvaThC2ju1cZ6+g3ywssLKUUrRHjlEklENXBfuyQHql f1jg== X-Gm-Message-State: AOAM533gjmHLgIaYtUylSwuFXpfSGHKJFuBMMMSf0AxtZjzWuqjdbB3g pJs1nLjVY/vnEkwaSkmftCl98a+E4nCFbA== X-Google-Smtp-Source: ABdhPJzqCiWgHDKk7Wbw62YYaS6BBq8yV0ZPPzWnBmFbpkw3OTjfzMibwAVS5PPLDhCF7SnZwq49vw== X-Received: by 2002:a1c:96ce:: with SMTP id y197mr5307426wmd.55.1593112644657; Thu, 25 Jun 2020 12:17:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:23 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Date: Thu, 25 Jun 2020 20:17:07 +0100 Message-Id: <20200625191708.4014533-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krystian Garbaciak , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Support Opensource Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though 99f75ce666199 ("regulator: da9063: fix suspend") failed to clean-up all of the existing .suspend variable initialisations. This has led to some 'initilized field overwritten' issues now present in W=1 builds. This patch squashes the following build warnings: In file included from drivers/regulator/da9063-regulator.c:17: include/linux/regmap.h:1124:37: warning: initialized field overwritten [-Woverride-init] 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ include/linux/regmap.h:1124:37: note: (near initialization for ‘da9063_regulator_info[11].suspend’) 1124 | #define REG_FIELD(_reg, _lsb, _msb) { | ^ drivers/regulator/da9063-regulator.c:27:2: note: in expansion of macro ‘REG_FIELD’ 27 | REG_FIELD(_reg, __builtin_ffs((int)_mask) - 1, | ^~~~~~~~~ drivers/regulator/da9063-regulator.c:515:14: note: in expansion of macro ‘BFIELD’ 515 | .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), | ^~~~~~ Cc: Krystian Garbaciak Cc: Support Opensource Signed-off-by: Lee Jones --- drivers/regulator/da9063-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index e1d6c8f6d40bb..fe65b5acaf280 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -512,7 +512,6 @@ static const struct da9063_regulator_info da9063_regulator_info[] = { }, { DA9063_LDO(DA9063, LDO9, 950, 50, 3600), - .suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL), }, { DA9063_LDO(DA9063, LDO11, 900, 50, 3600), From patchwork Thu Jun 25 19:17:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627045 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 920006C1 for ; Fri, 26 Jun 2020 10:10:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A2D4208C7 for ; Fri, 26 Jun 2020 10:10:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WnUgO5/j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ivxIkASn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nCwrZoKD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2D4208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c55Zw6VULtw0Y9cgJ1m6X9reFeUj92N3y4FffICWL0w=; b=WnUgO5/joN2P2hSbNe/4jqH0Q 9T4jb/XkHmVqgKnrgM8F33BkW2loJwul9xwojnxCv62uMTYu6+fu39DPphHBiEDLFlpXzBd7fAtcc jfkenjGReWQRDJraW3rIqXzKFJPcNG6ManrcSRRjze+cNR4ihWjIYWx0zD5hcNVE/TdE3e8MKcIHY c0cpn8eUAVQps6t8eGs2T5ReeydeKgcUJ/dE2x4mz9IVv0LmZmZihauU13dNtY8ci3qO7YM2Z0TIW 5k9r2kfSUTlT5f9/WPoSf4+pmq2OVhnC4qGsGeL9dG41s727PJxypIkMrlJonAy7R/vGBdcQGrkNQ nmzTucJlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolI6-00039M-Da; Fri, 26 Jun 2020 10:09:02 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolHw-0002eU-S0 for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:08:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=6KRQ2iJpwYa3qnjlJG4YmheyTfVRexZvMMMSKG/N/5M=; b=ivxIkASnYBWX7YD8tUw2BLslqT SNE0VBCzPgE+zDHD7HMXpjjtVb99Aq6FxJ2w7u06F9NatKjMxKoLdl2U9dhHJOu2qJBDqSQ7NY4MI 4cirATvVIKgBkLcIUH7RTzqA+wDsUTIYzomrZkPaDJjZF0fqsVoCtzMaF+ELmNXIbqJO57nwXB/nj 0uizpLtcI+XRnR1Z3duiCoCZVj6cBlLgh3hqyXepA8eSd49L3NSiVIuZDKKDNz4XzMWY3mAr5iNle NXV8xJ+s00KKu1T22l3CMwOIf9FBaLfkKXS640OMZOpsHfIZb3BaO7nSkTM55xy1JG9zxcnloJJM2 JCvy3bBw==; Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jok5N-0005CN-Qu for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 08:52:26 +0000 Received: by mail-ej1-x62f.google.com with SMTP id mb16so8608320ejb.4 for ; Fri, 26 Jun 2020 01:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6KRQ2iJpwYa3qnjlJG4YmheyTfVRexZvMMMSKG/N/5M=; b=nCwrZoKDGyU62ArlORuxv6qQBsgl4YVcIUDL6rSD9Y7+e0cL12Hxyq10e0xvkTBGKb n6XrBFSKgWUvEx/76sDRUipmJOxN1Si4WqpO95vs96j8UykMdpHbay9F4C7R4brkwQD7 2dZM09L43FHaxpA7wFsZrQP6QxaPspU2AAXOVG2bYrmKaQanMEz8DNR+cpTRinl5FrfV PTx2xeUi3h2Q2e+gNHA2EomT5FJoBvQesO6RIyJn7EZJPerABh02zlc9dae50ChU8jrK G5Qbck5qK2xe7uVHXh2KuoTHcnJ6ECDx+PYBhHQawUfhNZVSD8eo2tpKT2F64xbBXwvM cZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6KRQ2iJpwYa3qnjlJG4YmheyTfVRexZvMMMSKG/N/5M=; b=qi9ePtw6HhT1EWa+Lc+WfUeuj6AL+PlZDFBj8jchSAvJqQ2lkbn3sGO8mM4vssuLmU 3RmKUs1ldjc7c75/BoEJSzA7vl7/bC8HOUyDUZlODv7Qm1dXzAQGa62zpNj9Go87c45U yhnY4WPe1VdYP7/QYAPA9QmxnR337uy5eUc1jdxXGelSv9iaRJNfCVKjI0bR0h9R7mlH OWuVoIyNK3oaGmWcgKjAFAhNaX8MuuiY6eJclNprpAwikTu//xmbTHMcnxvrmgU9IKes 9tWm4B4voXQSfhzkkCNhzlFgE3DxZKtOFdfup7Us8rrLwHovY0ipbV9u9ekaD2zSOMls 1DRQ== X-Gm-Message-State: AOAM5331uExYiOU7FjqwidnJwd0y0o/xVZj3FvqhPSUNJHfKiV/XnzMn EepWwLk/gpY0BHO3KaVYO288/izgqNWgqw== X-Google-Smtp-Source: ABdhPJz9/MPIxJh8xZy057BUPDVzPUARP1XEN4i7iiDFKzDhVL1EwMddUZEaB9b7O/scLJTFbxgUGw== X-Received: by 2002:adf:e74e:: with SMTP id c14mr26668601wrn.143.1593112645638; Thu, 25 Jun 2020 12:17:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p13sm22693983wrn.0.2020.06.25.12.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 12:17:25 -0700 (PDT) From: Lee Jones To: lgirdwood@gmail.com, broonie@kernel.org Subject: [RESEND 10/10] regulator: max14577-regulator: Demote kerneldoc header to standard comment Date: Thu, 25 Jun 2020 20:17:08 +0100 Message-Id: <20200625191708.4014533-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625191708.4014533-1-lee.jones@linaro.org> References: <20200625191708.4014533-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_095150_944401_C72A2DEB X-CRM114-Status: GOOD ( 15.20 ) X-Spam-Score: -2.1 (--) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:62f listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Chanwoo Choi , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Nothing about this comment identifies it as a kerneldoc header. It's missing all of it's function argument descriptions and the correct function header. Fixes the following W=1 warning(s): drivers/regulator/max14577-regulator.c:166: warning: Function parameter or member 'max14577' not described in 'max14577_get_regma drivers/regulator/max14577-regulator.c:166: warning: Function parameter or member 'reg_id' not described in 'max14577_get_regmap' Cc: Chanwoo Choi Cc: Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz Signed-off-by: Lee Jones --- drivers/regulator/max14577-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c index 07a150c9bbf22..e34face736f48 100644 --- a/drivers/regulator/max14577-regulator.c +++ b/drivers/regulator/max14577-regulator.c @@ -155,7 +155,7 @@ static const struct regulator_desc max77836_supported_regulators[] = { [MAX77836_LDO2] = MAX77836_LDO_REG(2), }; -/** +/* * Registers for regulators of max77836 use different I2C slave addresses so * different regmaps must be used for them. *