From patchwork Fri Jun 26 10:01:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 11627039 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 65D1A912 for ; Fri, 26 Jun 2020 10:09:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3961F206C0 for ; Fri, 26 Jun 2020 10:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kzG52qff"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DbzVcdiV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="ipgG6TEg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3961F206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4gZIAFMozoF271p2p8GPMkxXLAQ2H+mF4d9BMIOWtWQ=; b=kzG52qffqTVzX4ZR6FpFgpcEsm vdMs6r87gi06936iS36AdULhd+3k3QoUmfQSFVg7lTCmvPJYVJpGnqRyxVzLD8OuEykLdssNRizi4 gldTSdxVH0SMqxK1DVmGKPo1ukCYzjrUPG/wn5BslC27fyTl/5++ETeCj6roNXIumlnKpO4PVMjnZ tCl0ZIxtlz4vHxXssqXSLneXyV/ksK1a4fQV0hJyemY/I17ncmrq9BTK+PE2xe0gU4W6EBTVYWJxP orc1gn2Q/81fFC0d4DXU0Bte2C3BHZxoixrjtt/WSSBnLa//oxhQ+Al8MDA8LuI0KmUwf/601gYzS XhxL+ZOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolH2-0002K3-4q; Fri, 26 Jun 2020 10:07:56 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDZ-0000bm-HY for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:Content-Type:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3407dn9k5QQedWzfTAmf5rXvTScGYVbjSfdZVMHdevA=; b=DbzVcdiVzs+ob93Xl+RzCEVeuC qYPwVI+feDAMUvpugRBwe1+j4hsPy33aTAvYixmhVZFk9ygWZGZTQGvpf/fKxSFoDnft265GVrtSu KEPsKDyJQUUYC7YXBHyjInoqgbCYN79U1bIWdha1FPbo4Q6cPHUFwagQAVuTeDFGJDKKT5OvmciY3 Dn02WIO4OX6vdyDhGiTrBHhP6QR7jfHBxxInw+5iyclQy9wwr4FvkW7ku4er+C5Djh3Iu5Erfdg8N ssuEUNaVw5B15BGCYIEJ+sKF5FFwx0g5W0fSoujfv0wY39Og7G3E10aCACR09e3Y7xsTvqWDpgjrB RL5P9THg==; Received: from mailout1.w1.samsung.com ([210.118.77.11]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolAX-0003aZ-Ou for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:01:36 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200626100110euoutp013a9a13445cabf8a99a008c6df9ff7a55~cD7x2PAva0658406584euoutp015 for ; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200626100110euoutp013a9a13445cabf8a99a008c6df9ff7a55~cD7x2PAva0658406584euoutp015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1593165670; bh=3407dn9k5QQedWzfTAmf5rXvTScGYVbjSfdZVMHdevA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ipgG6TEgxzP9cYzYOb0Fndx683NMic+WzY/grLfqk/jPI6vOe+z7GbIhKVmvspETy Klq/d+ujqIVCWw/jC424z2oaLvrImL9CQZW0fre/CJs+0KZPM7hL16/CMCZfA8CwxI krNjesUyHcwoCq8JMxh65RdmmaILqAEIVU62KO4k= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200626100109eucas1p212f8a933788e87aeb64f79be106a9eec~cD7xcRLb81867418674eucas1p20; Fri, 26 Jun 2020 10:01:09 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 0F.DB.06456.567C5FE5; Fri, 26 Jun 2020 11:01:09 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200626100109eucas1p25331652d017cd17d21c0ae60541d1f73~cD7w3_ign0244402444eucas1p2t; Fri, 26 Jun 2020 10:01:09 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200626100109eusmtrp24ba8dd0378ed8a726946b16ba1a4d1d6~cD7w2We7Q1306813068eusmtrp2_; Fri, 26 Jun 2020 10:01:09 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-2f-5ef5c7658a64 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 22.86.06017.567C5FE5; Fri, 26 Jun 2020 11:01:09 +0100 (BST) Received: from AMDC3748.digital.local (unknown [106.120.51.74]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200626100108eusmtip17696631433fc09b000d8dedeaaeada88~cD7wImxm_2131121311eusmtip1_; Fri, 26 Jun 2020 10:01:08 +0000 (GMT) From: Andrzej Hajda To: Greg Kroah-Hartman Subject: [PATCH v6 1/4] driver core: add device probe log helper Date: Fri, 26 Jun 2020 12:01:00 +0200 Message-Id: <20200626100103.18879-2-a.hajda@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200626100103.18879-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0iTURjHOXsvezUXb1PxYJI5EFTIC0qcqMRC4v0SXaAkRWvmy6ycyl7n 7YujctnyWonlhTTNxJWXpdbstpY4wzZMnahoJhliJIZulYKa2zvr2+85z/N//v9zOBQmNhO+ 1KX0LFaRLk2TkO54T/+qZR9rsieFr46Fo8k2C4EWyt8D1HmvnUCVs3Mk2uypwNCofYlE1xrb SWT9vYChDz+sOLpZ0SREuq9jBBrprSWRsfI1QE/7poXIWJqA6myVWAzNjIx9wpil8UIh8/pX Pc7oq6eFTE3RfYLRtd4kmYHyYQHztu6JkJm5ZRIwz5oKmNKuVsAYSu7gzIpuz0lRvPuhFDbt UjarCIu+4J5qL5wkMke9cxstSSrwZZcGuFGQjoJzmnlSA9wpMd0C4LJhHfCFDcCnOi3BFysA Ng5p8G3J82a1a+oxgGpjC/FPYtioxxxTJB0M159NkA72oiNhmbla6BjC6DUcWm+oCUfDk46B i59rBQ7G6UD4cmDJKRDRCK62vyJ5O3+o7TA4l7rRB2DVZInTDdKLQlhXPOzKFAvXzZ0Yz57w u6lLyLMf3NQ/EPBcAGdarmO8uAjA7g69S3AQTlnWttyorXjBsL03zIGQPgJtZTIed8LxReeD YVt4u6cK449FsEgt5ncEwBlzt2ufD3w0ZHelZ+CktsR5WzFdDGDDG1E58K/+b1UPQCvwYZWc XMZyEelsTignlXPKdFnoxQy5Dmx9ssEN0/ILYB9ONgKaAhIPkaHCliQmpNlcntwIIIVJvERH zYNJYlGKNC+fVWScVyjTWM4IdlO4xEcU+XAhUUzLpFnsFZbNZBXbXQHl5qsCp+0BKbs0OzLm lSFxvct+HXvXLzTMkl0dqlT1t3fm5GNTqQOnVLagnyvN3II+5XhkVnlfQpy3RXm4LflPtOJM TafnSIQsd2Z0f0JOgEpRZK1ODIy6rFWXxTf1L37cczd/7Zz2hCy2YHVN3tUnmC2cCBu1WyOD zqYteZisV+X6KAnOpUojQjAFJ/0Lq2KVvGADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xu7qpx7/GGRxay2Nxa905VouXEw4z WmycsZ7VYurDJ2wW/7dNZLa48vU9m0Xz4vVsFle/v2S2OPnmKotF58Ql7BabHl9jtbi8aw6b xaGpexkt1h65y25xqC/aYu6XqcwOAh6Xr11k9nh/o5XdY++3BSweO2fdZfeY3TGT1WPTqk42 jxMTLjF57J+7ht3jfvdxJo/NS+o9+rasYvQ40DuZxePzJrkA3ig9m6L80pJUhYz84hJbpWhD CyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9jK+tt1gLrohWLD4X18D4QLCLkZND QsBEYvuyNsYuRi4OIYGljBIde/exQyTEJXbPf8sMYQtL/LnWxQZR9IlRYuXMzywgCTYBTYm/ m2+ygdgiAsYS/WdnsYMUMQu0sUrMPf8EbJKwgIPE23tzmEBsFgFVid0n3oM18ApYSPxcv4cN YoO8xOoNB8C2cQpYSky/1cvaxcgBtM1ConNJ5ARGvgWMDKsYRVJLi3PTc4uN9IoTc4tL89L1 kvNzNzECI2vbsZ9bdjB2vQs+xCjAwajEw3tg4pc4IdbEsuLK3EOMEhzMSiK8TmdPxwnxpiRW VqUW5ccXleakFh9iNAW6aSKzlGhyPjDq80riDU0NzS0sDc2NzY3NLJTEeTsEDsYICaQnlqRm p6YWpBbB9DFxcEo1MObaTxD9IbqzIa1f8LXOg6rJR8P1+bqSvmYyenRtbir7+d9w+b1vv23f M4ZNa1miK71PNd5t66NeKWEPhpKjM128EmXmHTh5+FvsjP/avolmmfvT9t9apHbjVZixkunG 2KU/vi/2SYg+urI1ivPHG5eOjFjO1q7Zbjfnno7cFqF+b1PDa6niOCWW4oxEQy3mouJEAJrA gH3CAgAA X-CMS-MailID: 20200626100109eucas1p25331652d017cd17d21c0ae60541d1f73 X-Msg-Generator: CA X-RootMTR: 20200626100109eucas1p25331652d017cd17d21c0ae60541d1f73 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200626100109eucas1p25331652d017cd17d21c0ae60541d1f73 References: <20200626100103.18879-1-a.hajda@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_110114_711137_E3A42458 X-CRM114-Status: GOOD ( 19.22 ) X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-7.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [210.118.77.11 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [210.118.77.11 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Jonas Karlman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , andy.shevchenko@gmail.com, Mark Brown , Laurent Pinchart , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org During probe every time driver gets resource it should usually check for error printk some message if it is not -EPROBE_DEFER and return the error. This pattern is simple but requires adding few lines after any resource acquisition code, as a result it is often omitted or implemented only partially. dev_err_probe helps to replace such code sequences with simple call, so code: if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return probe_err(dev, err, ...); Signed-off-by: Andrzej Hajda Reviewed-by: Rafael J. Wysocki Reviewed-by: Grygorii Strashko --- drivers/base/core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ include/linux/device.h | 3 +++ 2 files changed, 45 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 67d39a90b45c..3a827c82933f 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3953,6 +3953,48 @@ define_dev_printk_level(_dev_info, KERN_INFO); #endif +/** + * dev_err_probe - probe error check and log helper + * @dev: the pointer to the struct device + * @err: error value to test + * @fmt: printf-style format string + * @...: arguments as specified in the format string + * + * This helper implements common pattern present in probe functions for error + * checking: print debug or error message depending if the error value is + * -EPROBE_DEFER and propagate error upwards. + * It replaces code sequence: + * if (err != -EPROBE_DEFER) + * dev_err(dev, ...); + * else + * dev_dbg(dev, ...); + * return err; + * with + * return dev_err_probe(dev, err, ...); + * + * Returns @err. + * + */ +int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) +{ + struct va_format vaf; + va_list args; + + va_start(args, fmt); + vaf.fmt = fmt; + vaf.va = &args; + + if (err != -EPROBE_DEFER) + dev_err(dev, "error %d: %pV", err, &vaf); + else + dev_dbg(dev, "error %d: %pV", err, &vaf); + + va_end(args); + + return err; +} +EXPORT_SYMBOL_GPL(dev_err_probe); + static inline bool fwnode_is_primary(struct fwnode_handle *fwnode) { return fwnode && !IS_ERR(fwnode->secondary); diff --git a/include/linux/device.h b/include/linux/device.h index 15460a5ac024..6b2272ae9af8 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -964,6 +964,9 @@ void device_link_remove(void *consumer, struct device *supplier); void device_links_supplier_sync_state_pause(void); void device_links_supplier_sync_state_resume(void); +extern __printf(3, 4) +int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); + /* Create alias, so I can be autoloaded. */ #define MODULE_ALIAS_CHARDEV(major,minor) \ MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor)) From patchwork Fri Jun 26 10:01:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 11627229 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC1091392 for ; Fri, 26 Jun 2020 11:24:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77688206C0 for ; Fri, 26 Jun 2020 11:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fYN8ECsO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DUbhxXWi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="OnXwuQl/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77688206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pLBayL2+CbpKfEFg6rvOvrMnLzcJ95XouWWti4VPbtU=; b=fYN8ECsOOCInhUBN7evvNZiusn ZuAh4JW/yC8RAiga2kclHXCPTChWHi4G9YoHUQyzw4SrFxkMQj7Km6r/pLm49QZYpXixQ8c9RhHis agFeW+w2cxZDM+w3b3AW/SmZjNjbxEVlilXOFtUR4L8UJEgay85i6WNwX2LSL+FrXkQpkbscGpzLY VA1Lb1WBtanhk0jRkEtwlLqMzgfiXq0logtNoHLSeSHB5+KZZziLSQSItaIIzIJN5k/UNc2uN6Poc zLEz5Nqsh2UyRGH75ONJB5tkkJaFxPllUCySSXO8GbXRFXzo7bDlsBi32iS29iBB9FbjHudbKeU75 eYyUuscA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomRN-0000nO-SR; Fri, 26 Jun 2020 11:22:41 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDb-0000YK-D6 for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:Content-Type:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zzYpMezHcCPuAI9WGmae4c4hMI68Rcf9k4HVAnd3Gnw=; b=DUbhxXWi2PAoLoXe3kazR7hj4E Y7dMj2yHzaaf1yutdbREHHslnODxnKCxKwp/hMRZNwdhRHErItIu6EcDLzJINjU4Jg97I6/Pci+HY PYWQ2iMtFyuiZUV6YOwRaJBv4CMZX3or+g6PdVk9Dr2KddZrd8dYWUNjnVOFPhi5z3d2QHGnI65hZ ceYZeCeIn9XTU25z8Wv/Xirsn32ZRf11QBlbEwVFlfA5TOIKncgeME1B5XuLVzYtLDvj4FonVNsCB NH31jLKe3Cl8VsZxSaOxpbp4CpGJdaPGq2MMu+500zfnaSS+DFoEfJxhw0H1h0ICvHsRcrmZXzWv9 NXZ7I61Q==; Received: from mailout2.w1.samsung.com ([210.118.77.12]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolAX-0003aY-Hz for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:01:32 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200626100110euoutp02a6c961508f6ca3eeb3e7a8e8e5838701~cD7yWTE6X2540925409euoutp02G for ; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200626100110euoutp02a6c961508f6ca3eeb3e7a8e8e5838701~cD7yWTE6X2540925409euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1593165670; bh=zzYpMezHcCPuAI9WGmae4c4hMI68Rcf9k4HVAnd3Gnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OnXwuQl/2zZZcghh0En8N22tVuv4q0gKbHR17QkgjhsUL5+z19i7D2wgk9XaaudXt GUEfWEWvEIKdVhc9nX9EkTDTpMNSL2/vT2RPRBVFrYZPj8wkbuNV94UTohdiRzalqw e0N5WSup0uUpl3rewfZBJq9evpLCU449zLLYloU8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200626100110eucas1p234cd1b600e94a718a94bef5fec6310f6~cD7x95GAB1856618566eucas1p25; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id AD.EC.06318.667C5FE5; Fri, 26 Jun 2020 11:01:10 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200626100110eucas1p2c5b91f2c98a5c6e5739f5af3207d192e~cD7xp296r1867018670eucas1p24; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200626100110eusmtrp2c937eca2603216d9e16861f32096763f~cD7xpJucK1306813068eusmtrp2D; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-62-5ef5c766c33b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C3.86.06017.567C5FE5; Fri, 26 Jun 2020 11:01:10 +0100 (BST) Received: from AMDC3748.digital.local (unknown [106.120.51.74]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200626100109eusmtip190f09b3306fb2cc99e90aff84181ad15~cD7w4Nr0M2485024850eusmtip1F; Fri, 26 Jun 2020 10:01:09 +0000 (GMT) From: Andrzej Hajda To: Greg Kroah-Hartman Subject: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property Date: Fri, 26 Jun 2020 12:01:01 +0200 Message-Id: <20200626100103.18879-3-a.hajda@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200626100103.18879-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSfUyMcRz3u+e553muOR7npu+6MGdsMmElPzLDSs8/zB9kWMfRo5q6y10v Slu3RbrSGxJHqxFa5OhtQqpD52WXihpX7bIyotaoY7Xz0uPJ/Pf5fj8v398++zGEwiH1YWJ0 CbxBp41VU15kfevEqxWH7W7NqmwrYOftNikeKniM8N0LVikuej9I4d/1hQR+4x6lcMZVK4W7 fgwR+PlwF4nNheU0rh7oluLX9y9T2FbUiHDVkz4a2/L24ZLxImITy73u7iC40bcnaa7xexnJ NVj6aO5S1kUpV11pprhnBZ0SrqnkFs25cuwSrqY8ncurrURcc+5ZkhurXrBDvtdrQyQfG5PE G1ZuPOAVnd3dQ8b3Lz72JdeJTOjb/GwkY4ANhMr+U2Q28mIUbAWCKxMZEnEYR+Dq6Z0exhBc eNhC/bOc85QjkbiBwNI5+d/ScfsDLagodhn8rHn316FkAyDfYaEFEcFOktB1KlMqEHNZDXQU X51yMwzJLoGGx37CWs5iGHBWIfHaQrh5p5kQsIxdB8XOXKmQA+wIDa6iB3+9wIaA2RIu6ufC Z3stLWJf+N1QKhFxOrgqThCiNwtB3Z0GQiSCobdtkhJyiKlHW++vFCM3w7WBIBHOgrcjcwQx MQXP1BcT4loOWZkKMWMRuBx103necK3dPV0VB2eyhBKEdk4jGBj+igrQQsv/W2UIVSJvPtEY F8UbA3R8sr9RG2dM1EX5H9LHVaOpT/byl919Dz3yHLQhlkHqmfLmwnGNQqpNMqbE2RAwhFop 3+J4qVHII7UpqbxBv9+QGMsbbUjFkGpvecCVoQgFG6VN4I/wfDxv+MdKGJmPCcmG604/cETl fLTPnnA2kYN7XoREDM7LDzNfClK684NCN7Wb14e16qmEArVq67C+NDDoU//OtJalyZHbU2Wu Nv38zWXbYHlaaPNqree6b+nRNRC2S3nZ7/hTPqRtRvjYbs9gTvxB5azwEkWSb4fphEsXnK4c Mp2PMKl2RRsMqrVq0hitXe1HGIzaP6XapvFgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xu7ppx7/GGexoYbS4te4cq8XLCYcZ LTbOWM9qMfXhEzaL/9smMltc+fqezaJ58Xo2i6vfXzJbnHxzlcWic+ISdotNj6+xWlzeNYfN 4tDUvYwWa4/cZbc41BdtMffLVGYHAY/L1y4ye7y/0crusffbAhaPnbPusnvM7pjJ6rFpVSeb x4kJl5g89s9dw+5xv/s4k8fmJfUefVtWMXoc6J3M4vF5k1wAb5SeTVF+aUmqQkZ+cYmtUrSh hZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJeRte12ywFD5QrXvfeYmxg/CTbxcjJ ISFgIjHlzxLGLkYuDiGBpYwS3TubWSES4hK7579lhrCFJf5c62KDKPrEKPG2uwusiE1AU+Lv 5ptsILaIgLFE/9lZ7CBFzAJtrBJzzz9hB0kIC8RIvDvcA7SCg4NFQFVi52EtkDCvgIXE41tr GSEWyEus3nAAbBmngKXE9Fu9rCDlQkA1nUsiJzDyLWBkWMUoklpanJueW2ykV5yYW1yal66X nJ+7iREYWduO/dyyg7HrXfAhRgEORiUe3gMTv8QJsSaWFVfmHmKU4GBWEuF1Ons6Tog3JbGy KrUoP76oNCe1+BCjKdBJE5mlRJPzgVGfVxJvaGpobmFpaG5sbmxmoSTO2yFwMEZIID2xJDU7 NbUgtQimj4mDU6qBMeHQMhOjk2ES0hdvvFN64ZYnM1dN1feqWeyG3UXeImvdlI+4FJov107V fXiLy3jytpqfm/zeGLxOVfgZ9W5Z8IIfize9O23U+ueYknePfeZShlVLf3gt+yHGLf4uxDEx w3H/xJA7nx+tvLTgH2tEkOi1rze3CclFq7ikROZ+LVmQ+jJO58M3eSWW4oxEQy3mouJEABQO xHbCAgAA X-CMS-MailID: 20200626100110eucas1p2c5b91f2c98a5c6e5739f5af3207d192e X-Msg-Generator: CA X-RootMTR: 20200626100110eucas1p2c5b91f2c98a5c6e5739f5af3207d192e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200626100110eucas1p2c5b91f2c98a5c6e5739f5af3207d192e References: <20200626100103.18879-1-a.hajda@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_110114_209984_20BD6298 X-CRM114-Status: GOOD ( 22.59 ) X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-7.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [210.118.77.12 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [210.118.77.12 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Jonas Karlman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , andy.shevchenko@gmail.com, Mark Brown , Laurent Pinchart , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org /sys/kernel/debug/devices_deferred property contains list of deferred devices. This list does not contain reason why the driver deferred probe, the patch improves it. The natural place to set the reason is probe_err function introduced recently, ie. if probe_err will be called with -EPROBE_DEFER instead of printk the message will be attached to deferred device and printed when user read devices_deferred property. Signed-off-by: Andrzej Hajda Reviewed-by: Mark Brown Reviewed-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko Reviewed-by: Rafael J. Wysocki --- drivers/base/base.h | 3 +++ drivers/base/core.c | 8 ++++++-- drivers/base/dd.c | 23 ++++++++++++++++++++++- 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index 95c22c0f9036..6954fccab3d7 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -93,6 +93,7 @@ struct device_private { struct klist_node knode_class; struct list_head deferred_probe; struct device_driver *async_driver; + char *deferred_probe_reason; struct device *device; u8 dead:1; }; @@ -134,6 +135,8 @@ extern void device_release_driver_internal(struct device *dev, extern void driver_detach(struct device_driver *drv); extern int driver_probe_device(struct device_driver *drv, struct device *dev); extern void driver_deferred_probe_del(struct device *dev); +extern void device_set_deferred_probe_reson(const struct device *dev, + struct va_format *vaf); static inline int driver_match_device(struct device_driver *drv, struct device *dev) { diff --git a/drivers/base/core.c b/drivers/base/core.c index 3a827c82933f..fee047f03681 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3963,6 +3963,8 @@ define_dev_printk_level(_dev_info, KERN_INFO); * This helper implements common pattern present in probe functions for error * checking: print debug or error message depending if the error value is * -EPROBE_DEFER and propagate error upwards. + * In case of -EPROBE_DEFER it sets also defer probe reason, which can be + * checked later by reading devices_deferred debugfs attribute. * It replaces code sequence: * if (err != -EPROBE_DEFER) * dev_err(dev, ...); @@ -3984,10 +3986,12 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; - if (err != -EPROBE_DEFER) + if (err != -EPROBE_DEFER) { dev_err(dev, "error %d: %pV", err, &vaf); - else + } else { + device_set_deferred_probe_reson(dev, &vaf); dev_dbg(dev, "error %d: %pV", err, &vaf); + } va_end(args); diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 9a1d940342ac..dd5683b61f74 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "base.h" #include "power/power.h" @@ -136,6 +137,8 @@ void driver_deferred_probe_del(struct device *dev) if (!list_empty(&dev->p->deferred_probe)) { dev_dbg(dev, "Removed from deferred list\n"); list_del_init(&dev->p->deferred_probe); + kfree(dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason = NULL; } mutex_unlock(&deferred_probe_mutex); } @@ -211,6 +214,23 @@ void device_unblock_probing(void) driver_deferred_probe_trigger(); } +/** + * device_set_deferred_probe_reson() - Set defer probe reason message for device + * @dev: the pointer to the struct device + * @vaf: the pointer to va_format structure with message + */ +void device_set_deferred_probe_reson(const struct device *dev, struct va_format *vaf) +{ + const char *drv = dev_driver_string(dev); + + mutex_lock(&deferred_probe_mutex); + + kfree(dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s: %pV", drv, vaf); + + mutex_unlock(&deferred_probe_mutex); +} + /* * deferred_devs_show() - Show the devices in the deferred probe pending list. */ @@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s, void *data) mutex_lock(&deferred_probe_mutex); list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) - seq_printf(s, "%s\n", dev_name(curr->device)); + seq_printf(s, "%s\t%s", dev_name(curr->device), + curr->device->p->deferred_probe_reason ?: "\n"); mutex_unlock(&deferred_probe_mutex); From patchwork Fri Jun 26 10:01:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 11627037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 280B5912 for ; Fri, 26 Jun 2020 10:09:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00077206C0 for ; Fri, 26 Jun 2020 10:09:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oYBMSzZv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cqowPQkz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="hrA8eI/O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00077206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uKFk7NTmzTeKCAky2B9iupyK9uREMhP2IgsY2lkX14Q=; b=oYBMSzZvJ1Zwyfo/tss4MpXrz0 b8GpEF5fygsr6NqVvYwltUykm9Lk4dmRiyyyNLAUS2UM73a2O8RC4ZT2TJ0YOgslnwxrJXEZWOOJq S7rAlWeTV8p76otT9CJkAJlfaysyPm5fQyr7TXQCnPtRY0tpkOp4MWEmbia6E9LIj8redgkg9qGlo PoUNq981MdD6ADmGGbOfXkxdsMb5R30CbFLXNb+/qk7FlsF2HGOgsSrxsPpk9qK35ubdpljAynwbe Ynwiz7cibDmcYDISZC3CtOEymW/SeT0quGbulzayJqa5JolqD6zCaRmPaKw5YSS59U5v02tqE7XeR zhFabSlg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolHC-0002QC-8u; Fri, 26 Jun 2020 10:08:06 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDa-0000aR-6Q for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:Content-Type:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FHCuuaIM6iYHipda4rakjqMi4ghKc6Dm3/I5/j2IFWo=; b=cqowPQkzOi8Aiqdx9mvE8Zsae3 u92bWP3nbHDiygF5ZpDIGrqKjPf/aaRCmxdXsvV24l5EqiTMsf1Wuf4A2LUYfB/KjHAmu2MCngc6s 9wD87Fgzk44hBM+IiIFbRgXgw5BO2DbSbgJWv6a0nX40k2ADRQrkXzoB6ewgTYdixSYFbydLbOYLe uC3R2EjJbiw1z2N9tn+1OKBMzrfJVLSmCobnstEMocHiI1JNPcZWa+qkBtsufrI/VbeGsjRCGiJez SBQJPOfLrYEpOkOg+hkhj6OQsiunkSRbWo2OonggNTDJgXp38f1+FxWtpI20Q9T5Y9zeVIFjxnlno 2MO35IFA==; Received: from mailout1.w1.samsung.com ([210.118.77.11]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolAX-0003aa-Ow for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:01:34 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200626100111euoutp0142249824cdd47325d69bc2d89ca78965~cD7zPDvTo0693406934euoutp01o for ; Fri, 26 Jun 2020 10:01:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200626100111euoutp0142249824cdd47325d69bc2d89ca78965~cD7zPDvTo0693406934euoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1593165671; bh=FHCuuaIM6iYHipda4rakjqMi4ghKc6Dm3/I5/j2IFWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hrA8eI/OFM5nK6TDghuwcmWoCGT/BoU1SJ4hBfWBsHjVjRBWj4RE1ZAfxKmV/NXpN uwj4M3LGoqD2Z3yAf6zb49VIWFBUf30r6F16Ma4ToC58IN7dqvocmW2sbxgsaxr0BF vYquaA3aXNq5P5fLRV3PZqKhivS9yic0Azj7ATjA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200626100111eucas1p2a3fc77556f77587970444e08c7bfbd29~cD7y4vQM40241702417eucas1p2q; Fri, 26 Jun 2020 10:01:11 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 21.EB.06456.767C5FE5; Fri, 26 Jun 2020 11:01:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200626100110eucas1p24327c924dada0c2e86ecf0ab5b5af571~cD7yfZReH0240902409eucas1p2-; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200626100110eusmtrp2e1590d0784faf930f3ae366b4abbe2c5~cD7yeyj9e1303213032eusmtrp2U; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-37-5ef5c7679853 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 55.86.06017.667C5FE5; Fri, 26 Jun 2020 11:01:10 +0100 (BST) Received: from AMDC3748.digital.local (unknown [106.120.51.74]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200626100110eusmtip10e216f4cb07c1f1d10a5fb2c27eddda1~cD7xo50po2131121311eusmtip1A; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) From: Andrzej Hajda To: Greg Kroah-Hartman Subject: [PATCH v6 3/4] drm/bridge/sii8620: fix resource acquisition error handling Date: Fri, 26 Jun 2020 12:01:02 +0200 Message-Id: <20200626100103.18879-4-a.hajda@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200626100103.18879-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSfUyMcRzf757X0rXHyfqNlG5rw0YS28/LvLb2mI0wfyguR49q1ZV7VNio RF2ld72IJtTkQlx1uVrrXK3TUnqXI0fILrVGhVqi6wn/fb6fz/fz+X6/v/1oTNJGLKGDFac5 pUIeKiVtcW3T5IvVgcYJ2druAQkyPWwjkCWjAaDH+eUEynn/kUS/tZkY6p4YJVH8nXIS9fyw YKh5uAdHSZnFFNJ86CVQV80NEhly6gB60NhPIUOaHyocz8G2M2xXbwfGjvZdpti670U4qyvo p9jrqmsEq1EnkeyzjE4RW194n2LNKUYRW1Ecw6ZVqgGrT83G2TGNs4/Y13ZLABcaHMUp3bce sw2qyu8gIobtz7Tfdo4FuXbJwIaGzHo4rTKJkoEtLWFKAXz7+SolFOMAfu1WA6EYA3A6O3VW oecsD5pkAn8XwC91Q+Cf4+d0HGXNJZmV8FfFK9KKHRhPmN5aMBeLMVM47ElMIKzCIuYQfN47 KLJinHGDvTkZcwYxg+BkQyEuLOgCyx7pMSu2YTbCPFMqYQ2CzAgFR9PTCKHJC9am3Zo3LIJD xkpKwE7wt+6mSMAx0Fx6CRPMKgCrHukwQdgM37RNkdbbsNm1y2vcBXoHLMxLFQkn28O+kYVW GpuFWdo8TKDFUJUgEbpdobm1aj7QEZa0T5ACZuFrzSVSeKArALboG8kM4FLwf1gRAGrgyEXy YYEc76Hgotfw8jA+UhG45kR4mAbM/rKWGeO3J2Ci87gBMDSQ2on1meMyCSGP4s+GGQCkMamD eGdri0wiDpCfPccpw/2VkaEcbwBLaVzqKPa8bTkqYQLlp7kQjovglH9VEW2zJBaovUbGq/u7 g+vjQRnbcfD1Uk1Wk+mU/7tdjzldyOH0Yt+6aVnnhZexxjHtgUnX3G0bZmr38CWfJtf15y4L 9a5MyUrea9mdvvxk87uL/kRsiN/DIie3p+b66CMD0FkRFO+qM/lo73ir5EGJi2fiqpPz7jWW ZEYNLji/Yv8m+3197pVSnA+Se6zClLz8D/GU1O5hAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsVy+t/xu7ppx7/GGax7b25xa905VouXEw4z WmycsZ7VYurDJ2wW/7dNZLa48vU9m0Xz4vVsFle/v2S2OPnmKotF58Ql7BabHl9jtbi8aw6b xaGpexkt1h65y25xqC/aYu6XqcwOAh6Xr11k9nh/o5XdY++3BSweO2fdZfeY3TGT1WPTqk42 jxMTLjF57J+7ht3jfvdxJo/NS+o9+rasYvQ40DuZxePzJrkA3ig9m6L80pJUhYz84hJbpWhD CyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9jK0zLrIWvOGruLBIroFxGk8XIweH hICJxNpjcV2MXBxCAksZJXb+XczWxcgJFBeX2D3/LTOELSzx51oXG0TRJ0aJhc2zmUASbAKa En833wRrEBEwlug/O4sdpIhZoI1VYu75J+wgG4QFgiXWnRUFqWERUJW4NnUCWD2vgIXEz8Nz WSAWyEus3nAAbBmngKXE9Fu9rCCtQkA1nUsiJzDyLWBkWMUoklpanJueW2ykV5yYW1yal66X nJ+7iREYVduO/dyyg7HrXfAhRgEORiUe3gMTv8QJsSaWFVfmHmKU4GBWEuF1Ons6Tog3JbGy KrUoP76oNCe1+BCjKdBNE5mlRJPzgRGfVxJvaGpobmFpaG5sbmxmoSTO2yFwMEZIID2xJDU7 NbUgtQimj4mDU6qBcc2rTZ+6/d2uSLewHij6tDV1qtDLXSu5eiI2/esKXVV14kh/ifucVd1L ZLdWeYeyGM9hq95oWmLSF9iTLnd3TtCapPN2l15dnh/BnGnqHP0y4zEbV5xVg6Vw9nylu/YP Cvdcytdpv3u803na0dOq5ZpyG6YkTFxvfPTiqaAZEx9MZTCoXmcSocRSnJFoqMVcVJwIAAI3 g3bAAgAA X-CMS-MailID: 20200626100110eucas1p24327c924dada0c2e86ecf0ab5b5af571 X-Msg-Generator: CA X-RootMTR: 20200626100110eucas1p24327c924dada0c2e86ecf0ab5b5af571 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200626100110eucas1p24327c924dada0c2e86ecf0ab5b5af571 References: <20200626100103.18879-1-a.hajda@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_110114_541555_8CEF9F47 X-CRM114-Status: GOOD ( 14.58 ) X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-7.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [210.118.77.11 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [210.118.77.11 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Jonas Karlman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , andy.shevchenko@gmail.com, Mark Brown , Laurent Pinchart , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org In case of error during resource acquisition driver should print error message only in case it is not deferred probe, using dev_err_probe helper solves the issue. Moreover it records defer probe reason for debugging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/sil-sii8620.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 92acd336aa89..389c1f029774 100644 --- a/drivers/gpu/drm/bridge/sil-sii8620.c +++ b/drivers/gpu/drm/bridge/sil-sii8620.c @@ -2299,10 +2299,9 @@ static int sii8620_probe(struct i2c_client *client, INIT_LIST_HEAD(&ctx->mt_queue); ctx->clk_xtal = devm_clk_get(dev, "xtal"); - if (IS_ERR(ctx->clk_xtal)) { - dev_err(dev, "failed to get xtal clock from DT\n"); - return PTR_ERR(ctx->clk_xtal); - } + if (IS_ERR(ctx->clk_xtal)) + return dev_err_probe(dev, PTR_ERR(ctx->clk_xtal), + "failed to get xtal clock from DT\n"); if (!client->irq) { dev_err(dev, "no irq provided\n"); @@ -2313,16 +2312,14 @@ static int sii8620_probe(struct i2c_client *client, sii8620_irq_thread, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "sii8620", ctx); - if (ret < 0) { - dev_err(dev, "failed to install IRQ handler\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "failed to install IRQ handler\n"); ctx->gpio_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(ctx->gpio_reset)) { - dev_err(dev, "failed to get reset gpio from DT\n"); - return PTR_ERR(ctx->gpio_reset); - } + if (IS_ERR(ctx->gpio_reset)) + return dev_err_probe(dev, PTR_ERR(ctx->gpio_reset), + "failed to get reset gpio from DT\n"); ctx->supplies[0].supply = "cvcc10"; ctx->supplies[1].supply = "iovcc18"; From patchwork Fri Jun 26 10:01:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 11627227 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9174E913 for ; Fri, 26 Jun 2020 11:24:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66407206A1 for ; Fri, 26 Jun 2020 11:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hVopxAPm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FKZru85a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="lpVNe9om" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66407206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8shxZP/xP3pZcsJCPpj7Z8Dwb7GbVCfZkAe+g6+Qxm8=; b=hVopxAPm5RWTHVpSeFxGqfrp02 70vLPQW7W44+gIH0g81T6DV0TIQ0j7voexPFGmn/p5O4XkMuR6BUU8H8p5fEHwBfUmcXuWU5uehuI +rBBMR+3iG5mF2lryEB4giUuMjIWbTEAcuAjFnwCHGrECZJd1ZTATNBdZ8dPwDxurL4ygBLYcW0GK RzDEN6hAsn0bRf/guCsfbNPkhk2s3xG0aciyDI5DTgQxFFZxxcDbcmrAIc4ohBGTyWzuFzGAEUAOn 13KzA7jDC7NSXU9+d7WUbb9d6vzudzr4SN5EYpK777hnKBeNicVtDNNXm1N2FJY946qSi6H6xJkDV zjQ1/h1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomRL-0000ms-4R; Fri, 26 Jun 2020 11:22:39 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDZ-0000hS-HX for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:Content-Type:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fQMNu6sWDptDAr6/vT/QHkEA8xvrKj4wgjHFZNOz7Ao=; b=FKZru85akX4TzYXkqTZx/M1IDp vkjV4XLEutpoPUQLebOi8HDGd3EErWRhkp5WSVnc9J+g+Rn4mpxfh5HtXzGbu9W8TelGgbrCTNtor +8d8qwtmNXuzcN1atmnNudIBTkuXrolAUYaNpU9iXqzhC7zRmpgt7YGk3OiC0ryOXd6y80PZGnr2k qNxxbM6NgYigJByMf5n2XIDNvSlundBsXCLqA4FUSLAGeaU/qwf4eoI34Ab3iE81WQQ2KuDABSpbi WGldCY7xj9cl0+f0k89nOLHoE5IFjLjO5IMs7BCHQ3aMATu6tTS5loBLD3HnOHd3q+fOlZekxa9ii faG4TlnA==; Received: from mailout1.w1.samsung.com ([210.118.77.11]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolAX-0003b3-Ov for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 10:01:38 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200626100112euoutp01d83eaa1eb77cb82792935e1b58ae36a0~cD7z6dS880658406584euoutp01- for ; Fri, 26 Jun 2020 10:01:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200626100112euoutp01d83eaa1eb77cb82792935e1b58ae36a0~cD7z6dS880658406584euoutp01- DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1593165672; bh=fQMNu6sWDptDAr6/vT/QHkEA8xvrKj4wgjHFZNOz7Ao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lpVNe9omwXEPlO6h8p0Gi1Fhy/ZRFWHx+0LogdW4+hAdnNc/vlpXE/VYqdMlHJgYg CT5hH0mxb1cNsJGVNpZaSAffSLjt7Yx0xoXVDYM7TieryTOigyCpStcg+6Oa4v0T3u 3LzT2gvGlC4Odf77k3D8jxtOEeAREXbQ03ZlPtzc= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200626100112eucas1p24ede723f8f1211f52807bcd5beef82ee~cD7zkzPvd1856218562eucas1p2O; Fri, 26 Jun 2020 10:01:12 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id FA.B3.05997.867C5FE5; Fri, 26 Jun 2020 11:01:12 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200626100111eucas1p18e175e6c77af483bd80fb90c171b05db~cD7zP1nsi1585815858eucas1p1T; Fri, 26 Jun 2020 10:01:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200626100111eusmtrp2d0bae6ed7bc417a53d8edd19c0ea7f1c~cD7zOhJL61350013500eusmtrp2F; Fri, 26 Jun 2020 10:01:11 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-d0-5ef5c7685195 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 17.86.06017.767C5FE5; Fri, 26 Jun 2020 11:01:11 +0100 (BST) Received: from AMDC3748.digital.local (unknown [106.120.51.74]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200626100110eusmtip19acd13a6af9c0b1fd47584ae7feb08bf~cD7yenk9Q2495924959eusmtip1O; Fri, 26 Jun 2020 10:01:10 +0000 (GMT) From: Andrzej Hajda To: Greg Kroah-Hartman Subject: [PATCH v6 4/4] drm/bridge: lvds-codec: simplify error handling Date: Fri, 26 Jun 2020 12:01:03 +0200 Message-Id: <20200626100103.18879-5-a.hajda@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200626100103.18879-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0iTURjHOXuvjhZvM/Cg2WUllZBWFp0opLTLi4FlH/rQxXrLlyluSzat lCC7mfM2zbykRqOU2Uxnq0St0DZpiU68pKlkll3ITCrcCkdlm++sb7/zPP/n/3/O4dCY1E74 0wmqZF6t4hQyUow3PJvuWhNvc8aufWym0HBdF4HG860A3Ss1Eajo7XsSzTQUYOiF8yuJLt42 kaj/5ziG2r/040hbUEkh87sBAvU1V5DIUvQEoNq2EQpZ8g6hG44ibBvD9g30YOzXwcsU++SH HmebykYotjzzOsGajVqSfZ7fK2Jbbtyl2NFsm4i9X3mOzXtgBGxrbiHOTpkX75McFG+N4xUJ p3h1aPgxcfzN+jxR0kefM9+N34l0UElnAR8aMhtgqaMB87CUqQaw6kJiFhC72QFgobaYEA5T ADZ2j2BzE1m9Q96GAUCXXo/9G7n2KIfwqEhmNfx9f4j08EImDOrsZZRHhDEuHPZfyZgV+TK7 YelEzawIZ4Lgqztv3E40LWEQPG/bJaQtgTX1rbPJPsxmWDKcO5sMmUkKOrN1Io8eMjug4dFh Qe8LP9seUAIvgjNNN0UCn4Oj1ZcwYTYTwIf1Td7rbIGvulykxwdzL21qDhXK22FuhstrPx8O Ti7wlDE3Xm0owYSyBGZmSAX1Mjhqf+g19INV3U5SYBbWF4x5nycHwPaJDFE+WFL2P0wPgBH4 8SkapZzXrFfxp0M0nFKTopKHnDipNAP3J+v4Y3M0guZfxy2AoYFsnqS1wBErJbhTmlSlBUAa ky2URNg7YqWSOC41jVefPKpOUfAaCwigcZmfJOzW+BEpI+eS+USeT+LVc10R7eOfDojqp46N l3gTEV7LLd0UPq9mc/nbYmNFaKJNy2d/0uG9520rl0dF6qIjnMqpkOaoxZXW1/6BY1tdnHVn jLIuvcWQZgjrGaIj3nw4EFgavPfbpvQ7AVC+Z2b/WeunxhWq6Wj9WJ8soS0yJupwYKfrS0jk dCdTLv+Q1fFy1dj2IIUM18Rz64IxtYb7C5w2LdhgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xu7rpx7/GGeycpGNxa905VouXEw4z WmycsZ7VYurDJ2wW/7dNZLa48vU9m0Xz4vVsFle/v2S2OPnmKotF58Ql7BabHl9jtbi8aw6b xaGpexkt1h65y25xqC/aYu6XqcwOAh6Xr11k9nh/o5XdY++3BSweO2fdZfeY3TGT1WPTqk42 jxMTLjF57J+7ht3jfvdxJo/NS+o9+rasYvQ40DuZxePzJrkA3ig9m6L80pJUhYz84hJbpWhD CyM9Q0sLPSMTSz1DY/NYKyNTJX07m5TUnMyy1CJ9uwS9jPkb+pgKnnFWfFz1kbWBcQlHFyMn h4SAiUTXpZusXYxcHEICSxklGi/sZIdIiEvsnv+WGcIWlvhzrYsNougTo8SMK7sYQRJsApoS fzffZAOxRQSMJfrPzmIHKWIWaGOVmHv+CdgkYQF3iRmvV4MVsQioStxZ+QBoKgcHr4CFRONx N4gF8hKrNxwAW8YpYCkx/VYvK0iJEFBJ55LICYx8CxgZVjGKpJYW56bnFhvpFSfmFpfmpesl 5+duYgRG1rZjP7fsYOx6F3yIUYCDUYmH98DEL3FCrIllxZW5hxglOJiVRHidzp6OE+JNSays Si3Kjy8qzUktPsRoCnTSRGYp0eR8YNTnlcQbmhqaW1gamhubG5tZKInzdggcjBESSE8sSc1O TS1ILYLpY+LglGpg3NjVe7L1+q32KTsdPoqGPlWym/J/9bmzl+VD5K9HfMzUkV6fy+OerlGS /LTkto9R4RGHh1l5P+/tCvN72PvgMHNjdMWClXa/2WclFZ+wDxYUeaP/9Vpv2sLA+p+Su5v9 7V994hI0mTj/8JnYXR9/psT+73/9+cFnLe30vDiufXPFdXzzs0W2KbEUZyQaajEXFScCACoG v53CAgAA X-CMS-MailID: 20200626100111eucas1p18e175e6c77af483bd80fb90c171b05db X-Msg-Generator: CA X-RootMTR: 20200626100111eucas1p18e175e6c77af483bd80fb90c171b05db X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200626100111eucas1p18e175e6c77af483bd80fb90c171b05db References: <20200626100103.18879-1-a.hajda@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_110114_696726_03C4511B X-CRM114-Status: GOOD ( 14.88 ) X-Spam-Score: -7.1 (-------) X-Spam-Report: SpamAssassin version 3.4.4 on casper.infradead.org summary: Content analysis details: (-7.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [210.118.77.11 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [210.118.77.11 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , "Rafael J. Wysocki" , Jonas Karlman , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, "open list:DRM DRIVERS" , Russell King - ARM Linux , Neil Armstrong , Andrzej Hajda , andy.shevchenko@gmail.com, Mark Brown , Laurent Pinchart , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Using dev_err_probe code has following advantages: - shorter code, - recorded defer probe reason for debugging, - uniform error code logging. Signed-off-by: Andrzej Hajda Reviewed-by: Neil Armstrong --- drivers/gpu/drm/bridge/lvds-codec.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c index 24fb1befdfa2..f19d9f7a5db2 100644 --- a/drivers/gpu/drm/bridge/lvds-codec.c +++ b/drivers/gpu/drm/bridge/lvds-codec.c @@ -71,13 +71,9 @@ static int lvds_codec_probe(struct platform_device *pdev) lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev); lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_HIGH); - if (IS_ERR(lvds_codec->powerdown_gpio)) { - int err = PTR_ERR(lvds_codec->powerdown_gpio); - - if (err != -EPROBE_DEFER) - dev_err(dev, "powerdown GPIO failure: %d\n", err); - return err; - } + if (IS_ERR(lvds_codec->powerdown_gpio)) + return dev_err_probe(dev, PTR_ERR(lvds_codec->powerdown_gpio), + "powerdown GPIO failure\n"); /* Locate the panel DT node. */ panel_node = of_graph_get_remote_node(dev->of_node, 1, 0);