From patchwork Fri Jun 26 13:05:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627569 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2EF66913 for ; Fri, 26 Jun 2020 13:07:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D591E2080C for ; Fri, 26 Jun 2020 13:07:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gZyQ6WfB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UWsgLVFR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D591E2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u83Ks2BGxpWKw7ELn+gZZd+2Z+esA/wBGRaU7ST9FzI=; b=gZyQ6WfByKb3Bp8qu2aWwvr0C y5bH+jWVMN6PkASYaSupTwn6Gn1dRDrHuuL1vkWVYRq5FQ9O5fcVYm4tdEHyizMBkSZo9sgjZK8WW jlt53fIHUmpw98bYBz1Kd4IEW184jkGPuZKb0+grTjv8lPj3Pa/X2z9C8gheQu39Qg+cef6zR5G9O kLfPIf3VgEWhl/vkjj4F8yjmxA2MslQzX9XgyNqmcw4AFwe02Ekd1pqyJZ5YHIBcgqKWIWUNeVaXY RlwltVpXKOWD4x0Dw+LfvIfGbl7vXK/TPZLk/Ys6rfNzdG5gHAbzlqeE/KR5/zftQvmKNeWDbkE+M H7GJB9Ufg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo30-0002hI-P0; Fri, 26 Jun 2020 13:05:38 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2s-0002fx-Q1 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:31 +0000 Received: by mail-wm1-x342.google.com with SMTP id l17so8786626wmj.0 for ; Fri, 26 Jun 2020 06:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6du7sHpmroejr9lp9ztEYkWIN/fkcg7/2Uksn80/5h0=; b=UWsgLVFRaDNyhFO1xT+LBUyTFFSmoKYce1w5HR+oyOoZjlI2VIetRXHVv0ch5mYgXC IqCuj/qcmtBNc/qm+riwEb3JXaPnmf3WlzoUZxMse3tMkwOUl2f9F6hAwtFxCgQYlgQu /NBi05hfpZyzwTGRd5e3u6roLKEP5pr0sKjGU60X+9CJKWYbTeI6Y9Q6WHxwrUZTf4M6 PHIZTyaDKpc657YDC4rsn3THlGs6o2cnDeiLFGABbZTmcnQeu+a04Dov95pgGhnvLKor ba62ALADZf3j6AMz9l+Xu/vmcMB4Hui9d9pWDj1pw09ld0N6+M+hEN3RpR55JEF+iFnR B4zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6du7sHpmroejr9lp9ztEYkWIN/fkcg7/2Uksn80/5h0=; b=e1JE61jVdiQYepiV7xF2xc1YtlFIzd879Ys2h+y3NTv6LMZU8fVh5bx5qGT0tXENeG HILtf6fa2q7bUJRKr5r3wvL6rBFQeYvwv9g93/qiXtfp74+NCjHA/GynawyXxcGGVFa6 ZwAQv24SdHJmCMYBppkBCgL7LGHACzwtze/xwx8XKp64rx92F1cMfk3PoG50XvGXrp84 D1cQ5kxDJ4dZ+cAKeFwZBNwxzhH4oqH6uK1nSwtlk2Krgkvw2gtGQFJX6etxV+apDVe2 cvxGleW5qnSC0WHn81m7C0He6Ylg4anrJDeehJL4eQJY6QiDRGObs55Q5wOTnZs7ZlE/ MAuA== X-Gm-Message-State: AOAM530Se5xbHBTm5jRaLdbhlxPwWZZqAxiM4wQ6Gpkk5eThackhpn+S wJQECG4JfMZQLBXsl+5tlExnpQ== X-Google-Smtp-Source: ABdhPJyJ2n62/Y1Rl+W1QOIJetY7OS5+awAyZ6wQTR6lWI70ZzGrBOLFafJyKmyAFcSNekqG1/1E/g== X-Received: by 2002:a05:600c:2254:: with SMTP id a20mr3238838wmm.115.1593176729872; Fri, 26 Jun 2020 06:05:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:29 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 01/10] misc: c2port: core: Ensure source size does not equal destination size in strncpy() Date: Fri, 26 Jun 2020 14:05:16 +0100 Message-Id: <20200626130525.389469-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Eurotech S.p.A" , Rodolfo Giometti , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We need to ensure there's a place for the NULL terminator. Fixes the following W=1 warning(s): In file included from include/linux/bitmap.h:9, from include/linux/nodemask.h:95, from include/linux/mmzone.h:17, from include/linux/gfp.h:6, from include/linux/umh.h:4, from include/linux/kmod.h:9, from include/linux/module.h:16, from drivers/misc/c2port/core.c:9: In function ‘strncpy’, inlined from ‘c2port_device_register’ at drivers/misc/c2port/core.c:926:2: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ Cc: Rodolfo Giometti Cc: "Eurotech S.p.A" Signed-off-by: Lee Jones Acked-by: Rodolfo Giometti --- drivers/misc/c2port/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c index 33bba18022892..80d87e8a0bea9 100644 --- a/drivers/misc/c2port/core.c +++ b/drivers/misc/c2port/core.c @@ -923,7 +923,7 @@ struct c2port_device *c2port_device_register(char *name, } dev_set_drvdata(c2dev->dev, c2dev); - strncpy(c2dev->name, name, C2PORT_NAME_LEN); + strncpy(c2dev->name, name, C2PORT_NAME_LEN - 1); c2dev->ops = ops; mutex_init(&c2dev->mutex); From patchwork Fri Jun 26 13:05:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627575 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B255613B4 for ; Fri, 26 Jun 2020 13:08:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BE6F2080C for ; Fri, 26 Jun 2020 13:08:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1GtFi+Ou"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HlFLionZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BE6F2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D5H+0GDV6+7sdTve2VI0MK/jKMXdkwl7dsid/kKkQ6E=; b=1GtFi+OuD4ej0mw9OFzyJyEkC IYoVU7zZBB2JKT0Iz5xupe/eog9bWPFUkp6uaAB6hA7vz2NHamWkZI+HvwJrRmvmjYZYkAkWXVU5h nd60mZvc6Yd8qLecd8BLWh8+wcv27aBCm3jHYmKypy9X53bEuMe9MtytULVYjv2HAeAJ5iNdtbplN 0KyaOD2NcZkHI2Ij7YF9lfomzEv6LEQ/hlECgcxAv5IuVLbFmoUXfuMMQFLYi4rN2zXfvzZ+K5PC6 cmzDZU8YarGChxuvJkk2lDH2pfmTdfmlLwUmvlUHgF2lhNbSfwGsXGN0It1LFu0QxLSrMPNa9Uhm8 g9P+UNzhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo39-0002jH-0U; Fri, 26 Jun 2020 13:05:47 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2u-0002g8-Bj for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:34 +0000 Received: by mail-wr1-x442.google.com with SMTP id b6so9419675wrs.11 for ; Fri, 26 Jun 2020 06:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=daHyuJlZ21yTucBCriQSJRjQqcObN26/yVHvenxInRk=; b=HlFLionZgSOs6uB5R/XFj+QIIQ5tQl7fhImDsr1EeJhlVxOL9n404r1ANLopHwWtlY zywtHNZ54HiqUqgmPyiXkVySsIX4Hdk5SWXj59y9VIkehX/2bWPlhpcP7bkThFYisB7L aYoLNSR3p1LB8G0Ts1jI1ig5BPgz25+wFct97UzGfn349NuZSZqSwCDKY2W2oZlGBzV0 YmvLsIPf7g1dPN95thFlze08d6GIffTkmWyjaxSaff6/6ReJBYwwFa4XTK8Y5ZeTsUPA dz6N/RJAHapYtB681ADXg6GWRBLyVeyCUflJ7MAVPiXKoqzUEY+U6C8hRybcrFPGTzfF p12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=daHyuJlZ21yTucBCriQSJRjQqcObN26/yVHvenxInRk=; b=Mf1RZ55llEpY7czmL2hxfSyptjs3hU9azZe37sXlzQx5aJkHOrCJ4XF0eVGEuokY9e H4/wnWrzKycEYKueDhFkgr9F8EdO3qrGwotsAxNipjLG+/2shBqIFh9/NX5OfoSgdqo1 GQbTNBY8zgZhjLcA8y9+QbRRANY2F6lMQu3CuoqjTGgG3dO4/1Doi64eNFUsDp0nierg ROTPaUcyMTBSMWEN6QI4bBmHs+PgSP22vPWEJAasQUwEk1CTEAgeeFVO7Yr4k0bBlOQQ 8ddztQMphDcuVZK25FOorTXlzxcigO7CuI6f47zyaaz7/kbKhQ43D7mnjUyKdf1yKxqM slQw== X-Gm-Message-State: AOAM533iLwG46BmJoAnuUK+obyjTXDwnoeOXTGWmkPCyep+wh60ZjPkv x+MhgXyw2O3aKTIYG57CN2DLcw== X-Google-Smtp-Source: ABdhPJzdQdsAOHVLeNWM/Vp1yS4sRgT3xxrd2+IrFxsYUcMKcsL2YoQVIt2KlUvCS/9L2F4AxW13NQ== X-Received: by 2002:adf:e90d:: with SMTP id f13mr3565068wrm.146.1593176731129; Fri, 26 Jun 2020 06:05:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:30 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 02/10] misc: ti-st: st_core: Tidy-up bespoke commentry Date: Fri, 26 Jun 2020 14:05:17 +0100 Message-Id: <20200626130525.389469-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Naveen Jain , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pavan Savoy Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If it's still in use and worth the effort, it sure looks like this driver could do with a good scrub (clean). This patch conserns itself with the non-standard comments located thoughout the file. It also fixes the following W=1 warnings by demoting the kerneldoc function headers to standard comments, since there doesn't appear to be a requirement for the function args to be documented: drivers/misc/ti-st/st_core.c:132: warning: Function parameter or member 'st_gdata' not described in 'st_reg_complete' drivers/misc/ti-st/st_core.c:132: warning: Function parameter or member 'err' not described in 'st_reg_complete' drivers/misc/ti-st/st_core.c:197: warning: Function parameter or member 'st_gdata' not described in 'st_wakeup_ack' drivers/misc/ti-st/st_core.c:197: warning: Function parameter or member 'cmd' not described in 'st_wakeup_ack' drivers/misc/ti-st/st_core.c:226: warning: Function parameter or member 'disc_data' not described in 'st_int_recv' drivers/misc/ti-st/st_core.c:226: warning: Function parameter or member 'data' not described in 'st_int_recv' drivers/misc/ti-st/st_core.c:226: warning: Function parameter or member 'count' not described in 'st_int_recv' drivers/misc/ti-st/st_core.c:387: warning: Function parameter or member 'st_gdata' not described in 'st_int_dequeue' drivers/misc/ti-st/st_core.c:409: warning: Function parameter or member 'st_gdata' not described in 'st_int_enqueue' drivers/misc/ti-st/st_core.c:409: warning: Function parameter or member 'skb' not described in 'st_int_enqueue' Cc: Pavan Savoy Cc: Naveen Jain Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/ti-st/st_core.c | 79 ++++++++++++++++++++++-------------- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 14136d2cc8f93..f4ddd1e670151 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -18,7 +18,8 @@ extern void st_kim_recv(void *, const unsigned char *, long); void st_int_recv(void *, const unsigned char *, long); -/* function pointer pointing to either, +/* + * function pointer pointing to either, * st_kim_recv during registration to receive fw download responses * st_int_recv after registration to receive proto stack responses */ @@ -60,7 +61,8 @@ int st_get_uart_wr_room(struct st_data_s *st_gdata) return tty->ops->write_room(tty); } -/* can be called in from +/* + * can be called in from * -- KIM (during fw download) * -- ST Core (during st_write) * @@ -100,7 +102,8 @@ static void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata) kfree_skb(st_gdata->rx_skb); return; } - /* this cannot fail + /* + * this cannot fail * this shouldn't take long * - should be just skb_queue_tail for the * protocol stack driver @@ -121,9 +124,8 @@ static void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata) return; } -/** - * st_reg_complete - - * to call registration complete callbacks +/* + * st_reg_complete - to call registration complete callbacks * of all protocol stack drivers * This function is being called with spin lock held, protocol drivers are * only expected to complete their waits and do nothing more than that. @@ -156,21 +158,24 @@ static inline int st_check_data_len(struct st_data_s *st_gdata, pr_debug("len %d room %d", len, room); if (!len) { - /* Received packet has only packet header and + /* + * Received packet has only packet header and * has zero length payload. So, ask ST CORE to * forward the packet to protocol driver (BT/FM/GPS) */ st_send_frame(chnl_id, st_gdata); } else if (len > room) { - /* Received packet's payload length is larger. + /* + * Received packet's payload length is larger. * We can't accommodate it in created skb. */ pr_err("Data length is too large len %d room %d", len, room); kfree_skb(st_gdata->rx_skb); } else { - /* Packet header has non-zero payload length and + /* + * Packet header has non-zero payload length and * we have enough space in created skb. Lets read * payload data */ st_gdata->rx_state = ST_W4_DATA; @@ -178,8 +183,7 @@ static inline int st_check_data_len(struct st_data_s *st_gdata, return len; } - /* Change ST state to continue to process next - * packet */ + /* Change ST state to continue to process next packet */ st_gdata->rx_state = ST_W4_PACKET_TYPE; st_gdata->rx_skb = NULL; st_gdata->rx_count = 0; @@ -188,7 +192,7 @@ static inline int st_check_data_len(struct st_data_s *st_gdata, return 0; } -/** +/* * st_wakeup_ack - internal function for action when wake-up ack * received */ @@ -199,7 +203,8 @@ static inline void st_wakeup_ack(struct st_data_s *st_gdata, unsigned long flags = 0; spin_lock_irqsave(&st_gdata->lock, flags); - /* de-Q from waitQ and Q in txQ now that the + /* + * de-Q from waitQ and Q in txQ now that the * chip is awake */ while ((waiting_skb = skb_dequeue(&st_gdata->tx_waitq))) @@ -213,7 +218,7 @@ static inline void st_wakeup_ack(struct st_data_s *st_gdata, st_tx_wakeup(st_gdata); } -/** +/* * st_int_recv - ST's internal receive function. * Decodes received RAW data and forwards to corresponding * client drivers (Bluetooth,FM,GPS..etc). @@ -262,8 +267,10 @@ void st_int_recv(void *disc_data, /* Waiting for complete packet ? */ case ST_W4_DATA: pr_debug("Complete pkt received"); - /* Ask ST CORE to forward - * the packet to protocol driver */ + /* + * Ask ST CORE to forward + * the packet to protocol driver + */ st_send_frame(st_gdata->rx_chnl, st_gdata); st_gdata->rx_state = ST_W4_PACKET_TYPE; @@ -276,7 +283,7 @@ void st_int_recv(void *disc_data, &st_gdata->rx_skb->data [proto->offset_len_in_hdr]; pr_debug("plen pointing to %x\n", *plen); - if (proto->len_size == 1)/* 1 byte len field */ + if (proto->len_size == 1) /* 1 byte len field */ payload_len = *(unsigned char *)plen; else if (proto->len_size == 2) payload_len = @@ -294,18 +301,23 @@ void st_int_recv(void *disc_data, } /* end of if rx_count */ - /* Check first byte of packet and identify module - * owner (BT/FM/GPS) */ + + /* + * Check first byte of packet and identify module + * owner (BT/FM/GPS) + */ switch (*ptr) { case LL_SLEEP_IND: case LL_SLEEP_ACK: case LL_WAKE_UP_IND: pr_debug("PM packet"); - /* this takes appropriate action based on + /* + * this takes appropriate action based on * sleep state received -- */ st_ll_sleep_state(st_gdata, *ptr); - /* if WAKEUP_IND collides copy from waitq to txq + /* + * if WAKEUP_IND collides copy from waitq to txq * and assume chip awake */ spin_unlock_irqrestore(&st_gdata->lock, flags); @@ -331,7 +343,8 @@ void st_int_recv(void *disc_data, default: type = *ptr; - /* Default case means non-HCILL packets, + /* + * Default case means non-HCILL packets, * possibilities are packets for: * (a) valid protocol - Supported Protocols within * the ST_MAX_CHANNELS. @@ -377,7 +390,7 @@ void st_int_recv(void *disc_data, return; } -/** +/* * st_int_dequeue - internal de-Q function. * If the previous data set was not written * completely, return that skb which has the pending data. @@ -396,7 +409,7 @@ static struct sk_buff *st_int_dequeue(struct st_data_s *st_gdata) return skb_dequeue(&st_gdata->txq); } -/** +/* * st_int_enqueue - internal Q-ing function. * Will either Q the skb to txq or the tx_waitq * depending on the ST LL state. @@ -561,7 +574,8 @@ long st_register(struct st_proto_s *new_proto) /* release lock previously held - re-locked below */ spin_unlock_irqrestore(&st_gdata->lock, flags); - /* this may take a while to complete + /* + * this may take a while to complete * since it involves BT fw download */ err = st_kim_start(st_gdata->kim_data); @@ -583,7 +597,8 @@ long st_register(struct st_proto_s *new_proto) clear_bit(ST_REG_IN_PROGRESS, &st_gdata->st_state); st_recv = st_int_recv; - /* this is where all pending registration + /* + * this is where all pending registration * are signalled to be complete by calling callback functions */ if ((st_gdata->protos_registered != ST_EMPTY) && @@ -593,7 +608,8 @@ long st_register(struct st_proto_s *new_proto) } clear_bit(ST_REG_PENDING, &st_gdata->st_state); - /* check for already registered once more, + /* + * check for already registered once more, * since the above check is old */ if (st_gdata->is_registered[new_proto->chnl_id] == true) { @@ -622,7 +638,8 @@ long st_register(struct st_proto_s *new_proto) } EXPORT_SYMBOL_GPL(st_register); -/* to unregister a protocol - +/* + * to unregister a protocol - * to be called from protocol stack driver */ long st_unregister(struct st_proto_s *proto) @@ -742,7 +759,8 @@ static void st_tty_close(struct tty_struct *tty) pr_info("%s ", __func__); - /* TODO: + /* + * TODO: * if a protocol has been registered & line discipline * un-installed for some reason - what should be done ? */ @@ -795,7 +813,8 @@ static void st_tty_receive(struct tty_struct *tty, const unsigned char *data, pr_debug("done %s", __func__); } -/* wake-up function called in from the TTY layer +/* + * wake-up function called in from the TTY layer * inside the internal wakeup function will be called */ static void st_tty_wakeup(struct tty_struct *tty) From patchwork Fri Jun 26 13:05:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627573 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 031C1913 for ; Fri, 26 Jun 2020 13:08:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD51D2080C for ; Fri, 26 Jun 2020 13:08:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k7oxPYpl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lnCjdUGV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD51D2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M9mwl/9DopQD77syZx0nQRu13Agh6jr6C/VHkmkdgBI=; b=k7oxPYplogXfU3LpGSNGTUaHv AMKXxtY536NRsw1LUn5Jryj9LOSZC2z2/fpiJmLo8YrRKaHIm1zbOg1nHbVHC4DrQJ1OASImp/mpX 6UvyTGw65dw7l+0+7F56hN0dQgwGKAnjmgL37j1FoNHr2G0UxUi6mWGkGI2l5/1//dTZrKWxJ5nBE Lf5bUZPAG32U7Xm7onUtg8xamCJoszUTm+AwLWzwYT7ftFTY3jRdZN8qrJLka0DV3Z+EvRP2okGAb /VmbAluqoWr4keDDT327UG77FYL/uxeq/GaFpdpGSKAny5uJ6MvUuq7fv9xeLk1uNQbfvV6nh2cO4 PLutrewAw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3D-0002kn-Rw; Fri, 26 Jun 2020 13:05:51 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2v-0002gP-Rq for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:35 +0000 Received: by mail-wr1-x444.google.com with SMTP id h15so9429004wrq.8 for ; Fri, 26 Jun 2020 06:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2h3Gz11K9lz1GWwD6l+glaQop1qQtS3m0z/WOqzfDhk=; b=lnCjdUGVWFd64dqs1Pxf1ilLYbrTGBJ6/SubvmW15xt/YFyLhtakePLjr0ysjDZJ6+ Njj3gSu/JxXkPOFptelL0qEKUuoyL8RLE5TCr7RJrTM8ayJwJIS6Z0ZLv3QGViB/kQo4 c793ZcLpZEnEEy7QerSJvgMa4N6IYxLOv6670a6u5FR8TR/3nNB+bMe37MjoXrORCZR5 +kQnpkWYNOVBcLbsLVYz6AqJpI7Rmt8Vd+yyDJtfcoTnE/WnEspWMCBQL9FipWxeO582 g36+a9+dT2iRl63/Tf+eR3ANQ7A9y30+4Q7N3e0WxvogO7OZ/oqDH24MMYLZYFz1A3p8 Y+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2h3Gz11K9lz1GWwD6l+glaQop1qQtS3m0z/WOqzfDhk=; b=XZGn3rqemEvtGewY6dUyvCI9TDKSRCU95SkRA5656pRi9pzPI6lvswP9RlNnsFWBkg C/O52QC3v2eyO3uVc0JZgkXLXad2HhhTYlZIHw936s8lQL2rUv5Iiw2yeSQzcZjWoxTT /TzlcA+CCy6CdfPY5ezh5HzeOLhdsRXeEyhuLM6hl4ZElqSiQlR89e7po0LedIWOr+b/ fez2s1rj2TpaS6DFIO3pa9FTon+coVvLr8ol1RL0GFOXb8JjT5GpB4gwnzwywQOsh+9l hA7QMcGmivyG4Lzk0sDsKAJUgoWLGgcFO51UqEteFtRD7kW04McNrBwC8kARUmCAidIk 8c0A== X-Gm-Message-State: AOAM531QSm1gdL7dE+UNCyZTsodIcuJWmT/ICcgg93bNASLO9eY1AiyC qpHgRlnYLNlTCB+IC4j1fUC+zA== X-Google-Smtp-Source: ABdhPJxK+YkmbDwzyiNATXYFOhK+8lW4MBKB9U+eFI0+bnZxV5GzvY/YoYYTr1RXZgYTUlzXxu0XIQ== X-Received: by 2002:adf:b312:: with SMTP id j18mr3472991wrd.195.1593176732336; Fri, 26 Jun 2020 06:05:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:31 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 03/10] misc: ti-st: st_kim: Tidy-up bespoke commentry Date: Fri, 26 Jun 2020 14:05:18 +0100 Message-Id: <20200626130525.389469-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pavan Savoy Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org If it's still in use and worth the effort, it sure looks like this driver could do with a good scrub (clean). This patch conserns itself with the non-standard comments located thoughout the file. It also fixes the following W=1 warnings by demoting the kerneldoc function headers to standard comments, since there doesn't appear to be a requirement for the function args to be documented: /drivers/misc/ti-st/st_kim.c:42: warning: Function parameter or member 'id' not described in 'st_get_plat_device' /drivers/misc/ti-st/st_kim.c:53: warning: Function parameter or member 'kim_gdata' not described in 'validate_firmware_response' /drivers/misc/ti-st/st_kim.c:126: warning: Function parameter or member 'kim_gdata' not described in 'kim_int_recv' /drivers/misc/ti-st/st_kim.c:126: warning: Function parameter or member 'data' not described in 'kim_int_recv' /drivers/misc/ti-st/st_kim.c:126: warning: Function parameter or member 'count' not described in 'kim_int_recv' /drivers/misc/ti-st/st_kim.c:272: warning: Function parameter or member 'kim_gdata' not described in 'download_firmware' /drivers/misc/ti-st/st_kim.c:445: warning: Function parameter or member 'kim_data' not described in 'st_kim_start' /drivers/misc/ti-st/st_kim.c:509: warning: Function parameter or member 'kim_data' not described in 'st_kim_stop' /drivers/misc/ti-st/st_kim.c:661: warning: Function parameter or member 'core_data' not described in 'st_kim_ref' /drivers/misc/ti-st/st_kim.c:661: warning: Function parameter or member 'id' not described in 'st_kim_ref' Cc: Pavan Savoy Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/ti-st/st_kim.c | 71 +++++++++++++++++++++++-------------- 1 file changed, 44 insertions(+), 27 deletions(-) diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index a36ed1ff5967f..f2f6cab97c086 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -30,7 +30,7 @@ static struct platform_device *st_kim_devices[MAX_ST_DEVICES]; /**********************************************************************/ /* internal functions */ -/** +/* * st_get_plat_device - * function which returns the reference to the platform device * requested by id. As of now only 1 such device exists (id=0) @@ -43,7 +43,7 @@ static struct platform_device *st_get_plat_device(int id) return st_kim_devices[id]; } -/** +/* * validate_firmware_response - * function to return whether the firmware response was proper * in case of error don't complete so that waiting for proper @@ -55,7 +55,8 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata) if (!skb) return; - /* these magic numbers are the position in the response buffer which + /* + * these magic numbers are the position in the response buffer which * allows us to distinguish whether the response is for the read * version info. command */ @@ -79,7 +80,8 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata) kfree_skb(skb); } -/* check for data len received inside kim_int_recv +/* + * check for data len received inside kim_int_recv * most often hit the last case to update state to waiting for data */ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) @@ -91,14 +93,16 @@ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) if (!len) { validate_firmware_response(kim_gdata); } else if (len > room) { - /* Received packet's payload length is larger. + /* + * Received packet's payload length is larger. * We can't accommodate it in created skb. */ pr_err("Data length is too large len %d room %d", len, room); kfree_skb(kim_gdata->rx_skb); } else { - /* Packet header has non-zero payload length and + /* + * Packet header has non-zero payload length and * we have enough space in created skb. Lets read * payload data */ kim_gdata->rx_state = ST_W4_DATA; @@ -106,8 +110,10 @@ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) return len; } - /* Change ST LL state to continue to process next - * packet */ + /* + * Change ST LL state to continue to process next + * packet + */ kim_gdata->rx_state = ST_W4_PACKET_TYPE; kim_gdata->rx_skb = NULL; kim_gdata->rx_count = 0; @@ -115,7 +121,7 @@ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) return 0; } -/** +/* * kim_int_recv - receive function called during firmware download * firmware download responses on different UART drivers * have been observed to come in bursts of different @@ -216,7 +222,8 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name) return timeout ? -ERESTARTSYS : -ETIMEDOUT; } reinit_completion(&kim_gdata->kim_rcvd); - /* the positions 12 & 13 in the response buffer provide with the + /* + * the positions 12 & 13 in the response buffer provide with the * chip, major & minor numbers */ @@ -263,7 +270,7 @@ static void skip_change_remote_baud(unsigned char **ptr, long *len) } } -/** +/* * download_firmware - * internal function which parses through the .bts firmware * script file intreprets SEND, DELAY actions only as of now @@ -295,7 +302,8 @@ static long download_firmware(struct kim_data_s *kim_gdata) } ptr = (void *)kim_gdata->fw_entry->data; len = kim_gdata->fw_entry->size; - /* bts_header to remove out magic number and + /* + * bts_header to remove out magic number and * version */ ptr += sizeof(struct bts_header); @@ -313,8 +321,10 @@ static long download_firmware(struct kim_data_s *kim_gdata) if (unlikely (((struct hci_command *)action_ptr)->opcode == 0xFF36)) { - /* ignore remote change - * baud rate HCI VS command */ + /* + * ignore remote change + * baud rate HCI VS command + */ pr_warn("change remote baud" " rate command in firmware"); skip_change_remote_baud(&ptr, &len); @@ -346,7 +356,8 @@ static long download_firmware(struct kim_data_s *kim_gdata) release_firmware(kim_gdata->fw_entry); return -ETIMEDOUT; } - /* reinit completion before sending for the + /* + * reinit completion before sending for the * relevant wait */ reinit_completion(&kim_gdata->kim_rcvd); @@ -418,14 +429,16 @@ void st_kim_recv(void *disc_data, const unsigned char *data, long count) struct st_data_s *st_gdata = (struct st_data_s *)disc_data; struct kim_data_s *kim_gdata = st_gdata->kim_data; - /* proceed to gather all data and distinguish read fw version response + /* + * proceed to gather all data and distinguish read fw version response * from other fw responses when data gathering is complete */ kim_int_recv(kim_gdata, data, count); return; } -/* to signal completion of line discipline installation +/* + * to signal completion of line discipline installation * called from ST Core, upon tty_open */ void st_kim_complete(void *kim_data) @@ -434,7 +447,7 @@ void st_kim_complete(void *kim_data) complete(&kim_gdata->ldisc_installed); } -/** +/* * st_kim_start - called from ST Core upon 1st registration * This involves toggling the chip enable gpio, reading * the firmware version from chip, forming the fw file name @@ -472,8 +485,10 @@ long st_kim_start(void *kim_data) err = wait_for_completion_interruptible_timeout( &kim_gdata->ldisc_installed, msecs_to_jiffies(LDISC_TIME)); if (!err) { - /* ldisc installation timeout, - * flush uart, power cycle BT_EN */ + /* + * ldisc installation timeout, + * flush uart, power cycle BT_EN + */ pr_err("ldisc installation timeout"); err = st_kim_stop(kim_gdata); continue; @@ -482,8 +497,10 @@ long st_kim_start(void *kim_data) pr_info("line discipline installed"); err = download_firmware(kim_gdata); if (err != 0) { - /* ldisc installed but fw download failed, - * flush uart & power cycle BT_EN */ + /* + * ldisc installed but fw download failed, + * flush uart & power cycle BT_EN + */ pr_err("download firmware failed"); err = st_kim_stop(kim_gdata); continue; @@ -495,7 +512,7 @@ long st_kim_start(void *kim_data) return err; } -/** +/* * st_kim_stop - stop communication with chip. * This can be called from ST Core/KIM, on the- * (a) last un-register when chip need not be powered there-after, @@ -650,7 +667,7 @@ static const struct attribute_group uim_attr_grp = { .attrs = uim_attrs, }; -/** +/* * st_kim_ref - reference the core's data * This references the per-ST platform device in the arch/xx/ * board-xx.c file. @@ -729,8 +746,7 @@ static int kim_probe(struct platform_device *pdev) pr_err(" unable to configure gpio %d", kim_gdata->nshutdown); goto err_sysfs_group; } - /* get reference of pdev for request_firmware - */ + /* get reference of pdev for request_firmware */ kim_gdata->kim_pdev = pdev; init_completion(&kim_gdata->kim_rcvd); init_completion(&kim_gdata->ldisc_installed); @@ -772,7 +788,8 @@ static int kim_remove(struct platform_device *pdev) kim_gdata = platform_get_drvdata(pdev); - /* Free the Bluetooth/FM/GPIO + /* + * Free the Bluetooth/FM/GPIO * nShutdown gpio from the system */ gpio_free(pdata->nshutdown_gpio); From patchwork Fri Jun 26 13:05:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627577 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7038713B4 for ; Fri, 26 Jun 2020 13:08:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C3722081A for ; Fri, 26 Jun 2020 13:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BCKVaGZK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hjeADPj+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C3722081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8w6mIVPNfmnXT+qeEsTy5T0Z1xB2b8tinY/SoXSVkXI=; b=BCKVaGZKU+OXkwn2bOQVXrGdG 9+ILB0JreHqklNDjnMA/8zQu7IMXUfm7xuAZnwDvyVeCEFBAd9Havt6A8a6nnjjCfuVpVMb8YSfKJ uCyqykI3eReRIaVr55UJDPALhrTOGZO7EH+fFoKAkydazMHy9snikqnbU38YkKVcK4LEPK2Zo4o+w zuHn+Tez+eZQJVmTt5ojG2u5905MRSzIF+WJKq6/nUi7kJ3ChNMTki5yladSzgMx1inIq7BxbeLu5 hzV8ai/q56ReLA0ik/ulx2pWZzNoOa5lsYksdeAkdvKfLzy1VnvTOsF6BUqc3cWPF4GfPJUVKtzC3 xYXpnsyKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3I-0002m5-Nc; Fri, 26 Jun 2020 13:05:56 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2w-0002gi-TK for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:36 +0000 Received: by mail-wr1-x443.google.com with SMTP id b6so9419817wrs.11 for ; Fri, 26 Jun 2020 06:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GAj330t/cLz/0OA5LR4Jx3FFMEjm0vNa388Rc6BW4E8=; b=hjeADPj+J8vNOwmitxg9Sq/bkOGvPZqy5wI5dY78aKilYPQ34vfHpdzTNNXwUUda7a TeAh0Vy3PKN3+5oOUCy3GnILWKVTXX9wvt8Qq4rF8ic9I5U4XegFPlEsffv2Yi3lcvi8 BdfZNJkUPRKfF5m/DikKLMAd024eQ2QQSLb/Y8B+XcAnnAz7sI6aA9iT7b3kQWFE2aLQ IKEIVVaGH7mRmTnXSqC5d92uZuiVUJrtmwRDZyHMD/fvC4IJDyEFdXf1FGu4vNKPvT+K qBgMz360dqdXTLJNuZzZ+bk/WGh+WGtTly/yXu6npw/+hb+xylgPxq2jL9GqPpBfesdb 285w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GAj330t/cLz/0OA5LR4Jx3FFMEjm0vNa388Rc6BW4E8=; b=cBZbVBQTQ4RVZBp22Fr6Is0TijAveDxsQG3JBF60jPpl7etWt1lHYUEYepapvKJqkP 07CpHtqz3A41o/WIyqRfwAjFU3QzzgxAcF7xdXP2DIJNwTVz+PTLOwq8owLkqef7YvQ3 +g5LpTVy/O90TBwg5UgBvsxxQTwI3wkmOoD2FqrJKSZ0wPUhk6pIaUSMwD9u9pL1R3Md XgjF4gcHHHaoC+dwROfVxQtZmSXJ9CdkanYW2O7HYK+iRuNgSBRLB8rdm3qfMNzMXNCl +eUI1WhTlmqA1nNm8SZ2fKfaqlr/shwhxJUBdqR7fQ3dWpQ5bJ+8iw8DQg8fdmy10233 vVzg== X-Gm-Message-State: AOAM533Of4FLx3qnE/ggVeKT/jL40Gca5TT1CJs9Ewg6x8FTHdsfV7po 7wxOFP9inhh4Qde7UPDWEl//7w== X-Google-Smtp-Source: ABdhPJz0Z/3IvuQkcNWe4kc7SPhrizHq3K94NdYdMbd/faRkSyqVl19ju6hkKCpPo/dFz1MB0suI5A== X-Received: by 2002:adf:9148:: with SMTP id j66mr1872622wrj.311.1593176733769; Fri, 26 Jun 2020 06:05:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:32 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 04/10] misc: lkdtm: bugs: At least try to use popuated variable Date: Fri, 26 Jun 2020 14:05:19 +0100 Message-Id: <20200626130525.389469-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kees Cook Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The result may not be intereresting, but not using a set variable is bad form and causes W=1 kernel builds to complain. Fixes the following W=1 warning(s): drivers/misc/lkdtm/bugs.c: In function ‘lkdtm_STACK_GUARD_PAGE_LEADING’: drivers/misc/lkdtm/bugs.c:331:25: warning: variable ‘byte’ set but not used [-Wunused-but-set-variable] 331 | volatile unsigned char byte; | ^~~~ drivers/misc/lkdtm/bugs.c: In function ‘lkdtm_STACK_GUARD_PAGE_TRAILING’: drivers/misc/lkdtm/bugs.c:345:25: warning: variable ‘byte’ set but not used [-Wunused-but-set-variable] 345 | volatile unsigned char byte; | ^~~~ Cc: Kees Cook Signed-off-by: Lee Jones Acked-by: Kees Cook --- drivers/misc/lkdtm/bugs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c index 736675f0a2464..4f94296fc58ad 100644 --- a/drivers/misc/lkdtm/bugs.c +++ b/drivers/misc/lkdtm/bugs.c @@ -334,7 +334,7 @@ void lkdtm_STACK_GUARD_PAGE_LEADING(void) byte = *ptr; - pr_err("FAIL: accessed page before stack!\n"); + pr_err("FAIL: accessed page before stack! (byte: %x)\n", byte); } /* Test that VMAP_STACK is actually allocating with a trailing guard page */ @@ -348,7 +348,7 @@ void lkdtm_STACK_GUARD_PAGE_TRAILING(void) byte = *ptr; - pr_err("FAIL: accessed page after stack!\n"); + pr_err("FAIL: accessed page after stack! (byte: %x)\n", byte); } void lkdtm_UNSET_SMEP(void) From patchwork Fri Jun 26 13:05:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627579 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02EEE13B4 for ; Fri, 26 Jun 2020 13:08:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF3A42080C for ; Fri, 26 Jun 2020 13:08:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qKA5Euio"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B+LncNES" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF3A42080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F5oWFDJ0Iak/Ecn+MTJFzDutpKxKmUKMOM6KTpara4w=; b=qKA5EuioqGYrJsiGXGfmaNgzm 5gqS4UXoXCbiL/AJria4ebo0W45d7HESxCbYUd6i3Yp3WACB37CLiuJWRlQ2Q0yuwzgLRQzcniCNe HyCUhrfyzuadRoLW/p6SCc54t61+dP581mh/3jSxWRaL6WkJCqiaGABeGHZ1kYPRnc1+g5wQyfaPi q7cBYrMCIM0h+kt9XN2fenNDPjTQIsyh6fLo8TISUAQ84BJK5ndW5sk8vVqg5DCLTWpJCeZjwGIL/ u5HhJROWsvUejWYeeLYn8SJ/hTqpNjpVHfFa8Q2aOGrqlhhatp40TxUO88fEREon9XsSqw6CUaoCi ZAfPivpkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3R-0002ph-GN; Fri, 26 Jun 2020 13:06:05 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2x-0002h1-Vr for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:37 +0000 Received: by mail-wr1-x443.google.com with SMTP id f18so1379159wrs.0 for ; Fri, 26 Jun 2020 06:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eNnA3JIm/nNhrY/m6pTfGCbKyGY/Dou+IuOqoFoMcwU=; b=B+LncNESHZGTDdwm7FjaILQLgKfvB6QamNreWe/XQU8xhaEyEgsb4U4qxv08+ixDQ/ FnFt+RwqGrfUKnvBlql07hsVBCzE8UfjCT3v5eVekh5N4t1Bwgj3t+2SxxxU7SRQMXB0 iTIJMUDsufjuawLt1gCRmBs/5pxHL5XViTLUT+Uo07Yz19ugnCvaoVfcFUnnLjCb4OjZ APmtU1Hf+9fSpX5lG6GEsXO6xskSzVK/ym1JiQDWWG5muto8+vU7oP854PneFglhTygr IQp8m8nacqffpUHGayeWyU3H9dsP1a2WI5Ubcvp56QpipsQYivh3t90zZIS4lEEMDq1c Bd6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eNnA3JIm/nNhrY/m6pTfGCbKyGY/Dou+IuOqoFoMcwU=; b=NCoTW9jJVM9KkrhKolXTTVri192GKTVkwCGGy6J+oecJBf/e7arcJH+V5yUihbnEl6 lSTCb/IAn/JO0Of8qBt8WBUa17n3ITOaVHTAQnOcfJ0rY1KJoq9Qiie0QfOosFq6n5B9 trnPBF3iaN4AlUGZWdBkddHC2VC5jvH+CVtis8VKDIk5sWKOyMUa3y9nO/aQx2RKYvYf hA2nXfe5Z67jkBso9clde7uML3I7lVgbe8l1fgQkmf9Zzmz07PxqpvkFrr1gNbmtF0tC hiQqU1v8Z86lV+AOB/lF/PjcT3/yiHEnDNlGpEwR8DS3jDaE00MjIJHAhasGkqK8lIED MOLg== X-Gm-Message-State: AOAM530q8iiX7DlQsd0wK2B0LffraHRqG3ducb8mLCvukgEGcN97r8WH KjEhuvpiHnR4HMUVn9vEe3f9pex7i8M= X-Google-Smtp-Source: ABdhPJxBW4IPbPO5eoGMHxlvutWDO9MyQLFBGRb78I8VQ4Bim4qrRNtJrdF1lbgIHvXTS+XFhHn/sA== X-Received: by 2002:a5d:408c:: with SMTP id o12mr3677374wrp.412.1593176735173; Fri, 26 Jun 2020 06:05:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:34 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 05/10] misc: lkdtm: Always provide prototype for lkdtm_DOUBLE_FAULT() Date: Fri, 26 Jun 2020 14:05:20 +0100 Message-Id: <20200626130525.389469-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kees Cook Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org lkdtm_DOUBLE_FAULT() already has internal logic to handle !CONFIG_X86_32. Compiling out the prototype actually prevents that logic from being useful. Fixes the following W=1 warning: drivers/misc/lkdtm/bugs.c: At top level: drivers/misc/lkdtm/bugs.c:420:6: warning: no previous prototype for ‘lkdtm_DOUBLE_FAULT’ [-Wmissing-prototypes] 420 | void lkdtm_DOUBLE_FAULT(void) | ^~~~~~~~~~~~~~~~~~ Cc: Kees Cook Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/lkdtm/lkdtm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/lkdtm/lkdtm.h b/drivers/misc/lkdtm/lkdtm.h index 601a2156a0d48..8878538b2c132 100644 --- a/drivers/misc/lkdtm/lkdtm.h +++ b/drivers/misc/lkdtm/lkdtm.h @@ -31,9 +31,7 @@ void lkdtm_CORRUPT_USER_DS(void); void lkdtm_STACK_GUARD_PAGE_LEADING(void); void lkdtm_STACK_GUARD_PAGE_TRAILING(void); void lkdtm_UNSET_SMEP(void); -#ifdef CONFIG_X86_32 void lkdtm_DOUBLE_FAULT(void); -#endif void lkdtm_CORRUPT_PAC(void); /* lkdtm_heap.c */ From patchwork Fri Jun 26 13:05:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627581 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7F51313B4 for ; Fri, 26 Jun 2020 13:08:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50FEF2080C for ; Fri, 26 Jun 2020 13:08:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pqSEf/vl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V7IxkQgf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50FEF2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zl0PT9q+bZoHpMtT7SJnuDmu1meEHt2WEoiz55Zy2UI=; b=pqSEf/vltOqpZ3fXw2cSu0jGY EVPTGfmuqYlt+Vimi+Q7O7/EzQPmEJH56f55w5vmTMhMaEPTWc24VElo5HzUtww89qOiLvf8WygZj qJVjY5J3/vqXYg6aTDN9kV8jwUqTeMEfU4WzKK+HeT7ayzSNvNK902yCErA3KhzHkzZXRnpdRiTnJ hwK/ixa6mKA8yyUlVY2OklZ43doaknjHhc+VXIF7SmVeGR7lPXmraBugc7BA8LRBWsjhyavf/Yq6q VXuL0fbsfDxc3h7a1iMo9+wNnoPeIEpgu4PH+uwaVFMInpvMjsbHaSlzCzWgmeSL8d6aN7mfFK7nm InVFjjsfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3U-0002rc-JG; Fri, 26 Jun 2020 13:06:08 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo2z-0002hJ-Eg for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:39 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so9408290wrw.12 for ; Fri, 26 Jun 2020 06:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z9egOal3uN/e6e9MaOrNvFSxzzJuszdkWNRmQ29ZgoU=; b=V7IxkQgf7wGz0DpEojoH/IUl8uhIPCLkWJcfgONzZXJQVqVWNiIkbffuTbRAzPsnaG 9B1MG1NxVnNlGAQ7Mb2IRUomTjwKPNYs/NNjEMEg5Ell+59PWbiub25e5fGlfIp/zm8d mkSITkB56G89qfu4DsDCxXOi8Q2tgL3PdogZGF0I5DSPiZZV4vA2RJoR60lJKfOViKoQ O7Xt6Wgb2yb9DxMOZMKMif7av87+AOB42O+/wDA2KleCph7PaR4mGo4p0BssrOUq94Ou ONN2LOo2d1+N81ZKjzCA3lxoXNmQe0K9vq4z09zwrnMSFncvknsqjTeShfjj2Rcv99s+ u/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z9egOal3uN/e6e9MaOrNvFSxzzJuszdkWNRmQ29ZgoU=; b=AtRP5hPwmm9/6s1nA8NVOUdz0RYdXSPdlJ2aytYYEn6jxN8fn35g/VsCefT/RU1/sr GyHydLiKFILeED5oKoF7izvHAg6vgjqJyswDMjDQwBCTJ6r26BLKp8WeRfYH0Ir0J+re uhhU//ewNoOn4kQpYgi8rD7eQkbbZM3Geb2fqMdiydj895b5iyLdnnfjXwHX7HpD+Adc XQFORHg0K71jcsXJgvzzG8JRGBOMpZUq6tDxU3PCHIP4+mU8VngJcZCONGrvUBb5BExO 6vyBKYuwO7LXfjwBkzG6Q/VtolWxzDwaIr+TeTT1ftsUkZklTuG57s8km5SokLSK0l8P Dyvw== X-Gm-Message-State: AOAM530/+3z2JM25M2lwkRbinXi4AhtCJs5BfaHoflx1s5WM9Q/0j3Fg Jw3B3gNQrgB/d4A/8ezI7TsXOQ== X-Google-Smtp-Source: ABdhPJwm4pLJby/llKlKk2pTQRstc6jX1VxdYEZilS6bFSSooSi0Sw/2PixW9k4WiLO2WnWEAkMYKw== X-Received: by 2002:a5d:51ce:: with SMTP id n14mr3716291wrv.155.1593176736454; Fri, 26 Jun 2020 06:05:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:35 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 06/10] misc: eeprom: eeprom_93cx6: Repair function arg descriptions Date: Fri, 26 Jun 2020 14:05:21 +0100 Message-Id: <20200626130525.389469-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wolfram Sang , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Copy-paste issue. Looks like the kerneldoc style descriptions for these functions were taken from existing functions with slightly different argument names. Fixes the following W=1 warnings: drivers/misc/eeprom/eeprom_93cx6.c:239: warning: Function parameter or member 'byte' not described in 'eeprom_93cx6_readb' drivers/misc/eeprom/eeprom_93cx6.c:239: warning: Excess function parameter 'word' description in 'eeprom_93cx6_readb' drivers/misc/eeprom/eeprom_93cx6.c:280: warning: Function parameter or member 'bytes' not described in 'eeprom_93cx6_multireadb' drivers/misc/eeprom/eeprom_93cx6.c:280: warning: Excess function parameter 'words' description in 'eeprom_93cx6_multireadb' Cc: Wolfram Sang Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/eeprom/eeprom_93cx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/eeprom/eeprom_93cx6.c b/drivers/misc/eeprom/eeprom_93cx6.c index 36a2eb837371b..9627294fe3e95 100644 --- a/drivers/misc/eeprom/eeprom_93cx6.c +++ b/drivers/misc/eeprom/eeprom_93cx6.c @@ -228,7 +228,7 @@ EXPORT_SYMBOL_GPL(eeprom_93cx6_multiread); /** * eeprom_93cx6_readb - Read a byte from eeprom * @eeprom: Pointer to eeprom structure - * @word: Byte index from where we should start reading + * @byte: Byte index from where we should start reading * @data: target pointer where the information will have to be stored * * This function will read a byte of the eeprom data @@ -270,7 +270,7 @@ EXPORT_SYMBOL_GPL(eeprom_93cx6_readb); * @eeprom: Pointer to eeprom structure * @byte: Index from where we should start reading * @data: target pointer where the information will have to be stored - * @words: Number of bytes that should be read. + * @bytes: Number of bytes that should be read. * * This function will read all requested bytes from the eeprom, * this is done by calling eeprom_93cx6_readb() multiple times. From patchwork Fri Jun 26 13:05:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627583 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E48A913B4 for ; Fri, 26 Jun 2020 13:08:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B946F2080C for ; Fri, 26 Jun 2020 13:08:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KBPS0oMY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rD9Q+/Md" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B946F2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ReQ62f1dA84hsahNjopB2UN/Z+Y8FTRoEBuxqB9UXLw=; b=KBPS0oMY9Wl34PaTMF2qcvv1p QDbh4pn+YKrRBHb5UrxLcPDALZytEH1ZaHaFATojFGLblgDa0UYWTs5EPyRZk5NOhslSeebcN4Azi ZbuUQwV4yEN5jhlar0lJcBElnjdJ0uqBvFkqPDTkm8vZu+qT2/5E1BnUcydyU6ZceCa+iiDTMJZzG cCT1+eq25guaXjoj+TVgGFxcV9mvB9D+G4vIF/j0/743vsWXu/smTx02jSNs1jHYVULAxCNFbhyIo RELgjN7uGHfZz57wgoqZ5+5i4sh2rTpTn5Pksl3VhbM63oA/KLOi3OkNg7UMVuyrAyJjCBI0IqBH1 gTElbfTfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3b-0002ud-Lr; Fri, 26 Jun 2020 13:06:15 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo30-0002hb-GO for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:42 +0000 Received: by mail-wr1-x441.google.com with SMTP id g18so9483776wrm.2 for ; Fri, 26 Jun 2020 06:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DnDd4j0ST145ZKeSSkw7lJ4M0WvMcY2dd1eGT6PhUvQ=; b=rD9Q+/MdYAlK7GwwCud9z4mDJYqfCSBtUUO+yQP8diYsyyOv3LrCBx8gMTRQJmNPqy 8eR9J0ba/xpUahmzaB3rFvWZm+r/9s4zZcLfV9msgEtRMxiv+BiN7AEt1eaBt3husw5h vc/ojDmi7VtWGYsgj+z6R71ru2v8qyzUwKYVv824FY7h79tch/fa19ZIafKJGLK/uhMV FfdeN1CXMUHH0s4W392zQGtLK5rCmUbpYQwkcDSa33s4ZZpa6sGMQlV8CrK6lLgjGWa6 W/S/88/kdyIbRCWOJmvCL/vLCa2ASIzlLwiO6+v3ERLgDPYKFUwnnEMPpVfwSQILNjjg USvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DnDd4j0ST145ZKeSSkw7lJ4M0WvMcY2dd1eGT6PhUvQ=; b=eIq4s9Qy9EGPDFhRVAIy+78cpCaI7Wy/XVpGmWbVG4qlMwyxQsbfybNaquWddiRyFi xqnV9t2W0ycCaQ2jnhahqPYZuFuHLcnDbUvZBjTU0XKTZcvblhwIUQ7tqgt+Vtbi0gLG DK+eJqgBGvNBOWsOQFplDCFCn6dt8EX1dNQzJW2ZT+OkJAultuS/Sfv0tzoRhquA3gLr 9F4n6H2+ncGorabJiu5zlnSwO91qVW8/3Ep/hDQP1QXARR1qJhmbCfSZc0TW+0iMI4j4 t/9dSmWJtYKVqPXstMCD9IhFTtNvRrFqDDuoNbN40Ohqm9o+/Yw+39tpQiMLHiK/ES1s mNNg== X-Gm-Message-State: AOAM531rxUcJcS0k5DifCJVUus/yVtFBPqWnJ+taqsxn7/SKWMwpOMkn 5vpdfLIRdv/BG31/XK7H+zQOag== X-Google-Smtp-Source: ABdhPJxohCKHaCy7HdNTnlvnqVvGHqegU4a3Ml98qFUy57L2Z9oR2VLu0jP0cvvnWHbaMsEe+c3gTg== X-Received: by 2002:a5d:5587:: with SMTP id i7mr2686605wrv.314.1593176737524; Fri, 26 Jun 2020 06:05:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:36 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret' Date: Fri, 26 Jun 2020 14:05:22 +0100 Message-Id: <20200626130525.389469-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Sudeep Dutt , Ashutosh Dixit , Christian Borntraeger , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hasn't been checked since its conception 2 years ago. Squashes W=1 warning: drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’: drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 617 | int ret; | ^~~ Cc: Sudeep Dutt Cc: Ashutosh Dixit Cc: Christian Borntraeger Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/mic/vop/vop_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c index 85942f6717c57..4e63cb1360921 100644 --- a/drivers/misc/mic/vop/vop_main.c +++ b/drivers/misc/mic/vop/vop_main.c @@ -614,7 +614,6 @@ static void _vop_scan_devices(void __iomem *dp, struct vop_device *vpdev, struct mic_device_desc __iomem *d; struct mic_device_ctrl __iomem *dc; struct device *dev; - int ret; for (i = sizeof(struct mic_bootparam); i < MIC_DP_SIZE; i += _vop_total_desc_size(d)) { @@ -644,7 +643,7 @@ static void _vop_scan_devices(void __iomem *dp, struct vop_device *vpdev, &dc->config_change); put_device(dev); _vop_handle_config_change(d, i, vpdev); - ret = _vop_remove_device(d, i, vpdev); + _vop_remove_device(d, i, vpdev); if (remove) { iowrite8(0, &dc->config_change); iowrite8(0, &dc->guest_ack); From patchwork Fri Jun 26 13:05:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627585 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F19A713B4 for ; Fri, 26 Jun 2020 13:08:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C683A2080C for ; Fri, 26 Jun 2020 13:08:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MbmZ9r61"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ve0vODUR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C683A2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3e/4K70zz//JW4uC0VlEnYjj5lcqW0KlP+BJ7UjUSIE=; b=MbmZ9r61n/EDX1qZ96gbWdAwG rN8rk9HmVBDFIioGriJwVaqjomTxKDlxa4gdZtqXnXQbHvIHXAKqN4qdPB/HYHTtGyTf+2mz7rWVq b7TjGww+esxiAVEdHN9LNudF/8fJ/pjKvJ7PPVhnslM6W5/va9qX8bluHDa00RrNijt6mBfUbSXIe Xqt6est+YphDVgk32hnYQz9qAGO49MTY4BvztnPzklhrkmuNDPnBT7ybadIX7h8I1ic1ICdaJtcV6 spZTPG2GchS1pmtt9CfW6UTgEYnFWwTVqu4+GYQXDjPnwRUpF32sWdR1bdSx7C/CzNdG4K74lk4IG 1lya1akWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3k-0002yM-6n; Fri, 26 Jun 2020 13:06:24 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo31-0002hq-QM for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:43 +0000 Received: by mail-wr1-x444.google.com with SMTP id a6so9447605wrm.4 for ; Fri, 26 Jun 2020 06:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wtZgwN1VEe1uHwSxLOV5iMEAtJq6PXuzc/2gq6Shnxw=; b=ve0vODURkQ/NmbAvYy1X78a87W0iIn8AB8y2hOTsOaFy50tuPrl7R+PMgOe9Nt0/v0 d+GQeXOTlguWywGBl1Tvl59tosAfEK6jX7aAgpjoW+ZjvJtBdkacmlmWE4PEgZTfE9Cp +YC1m1VQT9y/kolkuJ/Gzby9rE/xIWfwusc6ScaVSdvqeQl8vtEZp+R3B1HMD6rvzlE+ 4pg68HmeRVY7FY0XZubD01AGP/sBZkqreA3RDmSp9tU2mAOYxXxqIdEiYDyADVcnkeS/ PIZivkIaJOUFb0954GFHDGYM8+U+jC5xgeR8wFEKI/slBUdpa+si3Rk2x/Tq+4u5GR+J vLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wtZgwN1VEe1uHwSxLOV5iMEAtJq6PXuzc/2gq6Shnxw=; b=k0vKbPja+hXhgfrE6LMjWb38cElBXUrehvAllsEyumEr6CCp44D1Yyp4pySp5eDrYY 5eLJUIgvqdHnHltyXhtIRh5CyBF9Jrj3U0myfhUz7DZF5crDTPmgeSIVauZTl1iMdyaR ufinwzMvNtSl0OhkgBEAVyCF7ULVd56JKFsbbo0uTTomLHHsArbcJzX0Lb42zoaOCF2g wXYc+kou9SWAFv9H1waAEDu4/FZ9rGhdV0Uj3xiUtmFfGVLa3E6tOpeBiKtF6qvWVyPZ 5Lmdut+/Hpn6DaMxqD6Qu1ZBdOhf5tOPf034ov9XMRkfHUjoqioVkiFfRkXwxTNrw+n6 +/YQ== X-Gm-Message-State: AOAM530IvdtqQXxsmSThSPSSs3DCKinRy8H1FVznmVEyPoPDDKTieyy3 qyqOaZPFF/lsVKJhyraEDFSZCQ== X-Google-Smtp-Source: ABdhPJxcb8/qodOG2VmiAY0Wvi/Gp9r7A1G8FrbCD4mBZKGbAemQCuno75AvB02aZQKkRKnmvGwq+g== X-Received: by 2002:adf:8b5a:: with SMTP id v26mr3660157wra.165.1593176738701; Fri, 26 Jun 2020 06:05:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:38 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 08/10] misc: cb710: sgbuf2: Add missing documentation for cb710_sg_dwiter_write_next_block()'s 'data' arg Date: Fri, 26 Jun 2020 14:05:23 +0100 Message-Id: <20200626130525.389469-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org An attempt was made to provide a proper kerneldoc header for cb710_sg_dwiter_write_next_block(), but a description for it's 'data' argument was missed. Squashes W=1 kernel build warning: drivers/misc/cb710/sgbuf2.c:131: warning: Function parameter or member 'data' not described in 'cb710_sg_dwiter_write_next_block' Cc: "Michał Mirosław" Signed-off-by: Lee Jones Acked-by: Arnd Bergmann Acked-by: Michał Mirosław --- drivers/misc/cb710/sgbuf2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c index dfd2969e36289..e5a4ed3701eb8 100644 --- a/drivers/misc/cb710/sgbuf2.c +++ b/drivers/misc/cb710/sgbuf2.c @@ -117,6 +117,7 @@ static void sg_dwiter_write_slow(struct sg_mapping_iter *miter, uint32_t data) /** * cb710_sg_dwiter_write_next_block() - write next 32-bit word to sg buffer * @miter: sg mapping iterator used for writing + * @data: data to write to sg buffer * * Description: * Writes 32-bit word starting at byte pointed to by @miter@ From patchwork Fri Jun 26 13:05:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627587 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD1C5913 for ; Fri, 26 Jun 2020 13:08:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E44F2080C for ; Fri, 26 Jun 2020 13:08:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N6Uof0DI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lssD7wLq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E44F2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ug2tl34No0nMhyDeBpiyBLhtSel9Cmq1hD1AGC7FIpw=; b=N6Uof0DIfWq7xAnvcRTWG2dMQ zTFWkUnDohMMuRQjUFf/bx6CZZKXO3plEhHjvrYF5IEThBgxE2pPCqG11fzDWnmFWyIxWF1RlTpV2 9qqdNecStC1FfR6mQboXWwlwetUth786aKEBBZnl4i36pJCxS93OiA3zUdM5wecCEkaWfa//eEDal IOB6Ill0MV1Hk+iTdpA5lh9aPR91ziSqFrm98Km9KRfpPZZIlrLYsnqJ0NA8AfQ9yYb3euhsQGjEr DSOhWcDGxzEZ4bAP76D7eBdq15uy4btvO/GVd+6wmBfNZZl3YMTHcc0+gbJw6tfsZedKyk+U+ShMO KIeQQ+FLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo3y-00036O-2I; Fri, 26 Jun 2020 13:06:38 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo32-0002i9-VN for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:44 +0000 Received: by mail-wr1-x444.google.com with SMTP id h5so9434130wrc.7 for ; Fri, 26 Jun 2020 06:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ANELz34YBsSGQN7d0PesCj0UqV7NJ8u8B5Ne0MQu0g=; b=lssD7wLqAJ0gJ+IzPKc8xCcG8BbMd7WxfU4aZ1PnxbgyuJuJJKMUg2E0Ncry6QBvL3 ldpGHJOw45mbzIlGcVPNAN/4EifoPDi7u3mGWe3FjBIIJzp+ZiLBdQ3KGT89eRn3XDZa LvTdr7vyqiv8LYUrxWAPKfXhMizTs+8VM3nOqmbVaaK1U1DQhlZQPfvreyntL3S5XHuh 3kxtwFKo6y3ZCqypb55xeMvUL5EPM1Iti+A/AURIU8A05l3thR5Jc6nlcTi/iX7MwU+m rfs+UWRblseM4HJb0sQODTWcGMNDBrVGSDKnGsyRc25pTlmFk09o94sn7U9dj2AEpDvb QXzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ANELz34YBsSGQN7d0PesCj0UqV7NJ8u8B5Ne0MQu0g=; b=mKXBy7FpSHhVfixEHT9OcUc3ud4WXrhzXfA3yAgRdeW7azI3AqxCaNiJgrhUeJB0VB Y5HotUalytM/F1IhCu2bVZ9m+gDWZMIFlqrFVs2TOpIq01qgbg7Iu3OEp0Ma07YH4/Pb hq8xxIg1PhlLG/ROLvt07b1ORaQURDJH15RXCmxzBT0IvmpOJT/yAlAtisRj0esNjKpj JmpDFlYMvgFzjGobTMQ4O51kQ1dYd/iHAAotsr/EzkuREghVojQ5d/uKHqSG4xuWgEJW xQ5u7eKOgJ8P0N6uZe6cGuzcqPVi8jfLLx3uogXApcrwpOhf7Jz1GJy7J1eTt73hxAqX Fsug== X-Gm-Message-State: AOAM5323fvKnwphfAebNGh7RCqAYCDTv3WugFLQp6SUlsEqIgB+a7mP2 DBDbduluzvnS/+20lUyebsLlpA== X-Google-Smtp-Source: ABdhPJzGWHVPd8vU4+Qbx/bdjmxkJJaSh3IiL55zDdAssidkE68VRfBSl22gKPmVsY+9Ihcaf3wkdw== X-Received: by 2002:adf:edc6:: with SMTP id v6mr3711643wro.413.1593176739993; Fri, 26 Jun 2020 06:05:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:39 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 09/10] misc: habanalabs: irq: Add missing struct identifier for 'struct hl_eqe_work' Date: Fri, 26 Jun 2020 14:05:24 +0100 Message-Id: <20200626130525.389469-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org In kerneldoc format, data structures have to start with 'struct' else the kerneldoc tooling/parsers/validators get confused. Squashes the following W=1 warning: drivers/misc/habanalabs/irq.c:19: warning: cannot understand function prototype: 'struct hl_eqe_work ' Cc: Oded Gabbay Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/irq.c b/drivers/misc/habanalabs/irq.c index fac65fbd70e81..4e77a73857793 100644 --- a/drivers/misc/habanalabs/irq.c +++ b/drivers/misc/habanalabs/irq.c @@ -10,7 +10,8 @@ #include /** - * This structure is used to schedule work of EQ entry and armcp_reset event + * struct hl_eqe_work - This structure is used to schedule work of EQ + * entry and armcp_reset event * * @eq_work - workqueue object to run when EQ entry is received * @hdev - pointer to device structure From patchwork Fri Jun 26 13:05:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11627589 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 594F5913 for ; Fri, 26 Jun 2020 13:08:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D9752080C for ; Fri, 26 Jun 2020 13:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ljg2ZdxB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IQ7ok0HF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D9752080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y3e1oUbyuMcN0INIaXWp/CIwODbNCrjl42Ol5SvAKIw=; b=Ljg2ZdxBXYmWh/q0dLiT2IZfI yVhanxaBQI9G+87V1AlwplN0kr9eu8g/g7J+K9sOVfZ9pGN5oW6QqQEDe5XJg6tUTrlViwI1mYFfM X0GrgHcoeDyHDUDuK5qbFdZMJm5bDFcGYLbEsXgZJ5TfgzDIxzv3lh5u9CTsmHeVzF0uw1C4l5l8i 7kImcAp7TmMy3uTZyo9gZqm43nQbFfmYPbwxJfPHf4AknArhxx2jyv5GLamzvTSf5TE8yhzkyX00x vg1qhxmDbg0mnTs1TcyyuDTMlOigOAh2L45NqsH8j3tI/SQV80aKkg8XMm1/tsOsPy3L+sfFrZ5Qh L8stblBzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo45-00039Z-Ha; Fri, 26 Jun 2020 13:06:45 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joo34-0002iQ-1l for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 13:05:45 +0000 Received: by mail-wr1-x444.google.com with SMTP id f18so1379500wrs.0 for ; Fri, 26 Jun 2020 06:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wgIF2Tzx4eGBueCHKg86n/uEbujpF9PDzYcT2/3mg20=; b=IQ7ok0HF4tKRxVuvEs17kkX6k+cf/VouH+TSqbBr+XLgYtS7BRaQowsbrDttWVuvPc E7AqbgsIs9MIqUKO4193FmdzsBWz8ZBRtnrfrFwXv9VjBGww9Xq9ha+/iMi7Njv3vtJl ICkZlU0pFyjugJPCj9LXhEoMytPjjDR0Uvwj8IV1ndWViuTfybwqOsxvx1WrTqd7cH06 W1TO2mrjQZ1h2pQ1vGmACWESyt5q4Me02Zj5yjlbJc3n6wF5P2WuR3SkSAlD79Lf+dBA O71OZrslrwEWGs3Nav792wgk1CsCAzUtRJrHod5wrFXh8JN0dvN8M4ZlrlAY5j30+AIp 125A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wgIF2Tzx4eGBueCHKg86n/uEbujpF9PDzYcT2/3mg20=; b=aM2AkEHIL0JkG0/6+9z+5PNLo2O4nddSs6jkk/ec+owR5dE6Ae+Bz9z4mZPs5nkSKF JO+EmHkhOtTTA9mBU429SAXjAeSmwSeHoCGBkc331XtcmDR/BWdpTT97sJRsCVrbiPIF xps1UxZvt7GbpIHUQJ59ssjtUXLGKLFv5q3084JgKiLgqZZyDvzux9nTFz2btY/w3rhj 1bjwmA5SmEzb3wRCv+UNpTsOk2fqPsxfIuTheyBvs27FXgkxtckqITphE7T8T0kx87a7 NMzT5BLuMHVNn8vQVfPxPuWUGU+QjQe6jixBNBMriEKqFX5geXqqcNcZIWcIKahd/y/+ 8XvA== X-Gm-Message-State: AOAM532e+t3rxnrGYbV2G/mnagwtbUCWeZj9sHYpVQj7ODJ8Q/AARzAY vX171AmaPzsGIgkd04uYGLxUmQ== X-Google-Smtp-Source: ABdhPJwgQ+N90JMO76E5nSShh82EMIgdI+DtTpbaW3v6JMh6ZlktTQ/YpvCCbUfSm6baoLg6e4CgEQ== X-Received: by 2002:adf:e884:: with SMTP id d4mr3582523wrm.176.1593176740964; Fri, 26 Jun 2020 06:05:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id u20sm16746904wmc.44.2020.06.26.06.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 06:05:40 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 10/10] misc: pti: Fix documentation for bit-rotted function pti_tty_driver_write() Date: Fri, 26 Jun 2020 14:05:25 +0100 Message-Id: <20200626130525.389469-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200626130525.389469-1-lee.jones@linaro.org> References: <20200626130525.389469-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: J Freyensee , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The API has moved on since the original function header was authored. This changes brings the function's documentation back into line with reality, complete descriptions of the latest arguments to be used. Squashes the following W=1 kernel build warnings: drivers/misc/pti.c:510: warning: Function parameter or member 'tty' not described in 'pti_tty_driver_wr drivers/misc/pti.c:510: warning: Function parameter or member 'buf' not described in 'pti_tty_driver_wr drivers/misc/pti.c:510: warning: Excess function parameter 'filp' description in 'pti_tty_driver_write' drivers/misc/pti.c:510: warning: Excess function parameter 'data' description in 'pti_tty_driver_write' Cc: J Freyensee Signed-off-by: Lee Jones Acked-by: Arnd Bergmann --- drivers/misc/pti.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index b7f510676cd61..07e9da7918ebd 100644 --- a/drivers/misc/pti.c +++ b/drivers/misc/pti.c @@ -496,9 +496,8 @@ static void pti_tty_cleanup(struct tty_struct *tty) * pti_tty_driver_write()- Write trace debugging data through the char * interface to the PTI HW. Part of the misc device implementation. * - * @filp: Contains private data which is used to obtain - * master, channel write ID. - * @data: trace data to be written. + * @tty: tty struct containing pti information. + * @buf: trace data to be written. * @len: # of byte to write. * * Returns: