From patchwork Mon Jun 29 14:04:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630987 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0EA4992A for ; Mon, 29 Jun 2020 14:07:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB31823D98 for ; Mon, 29 Jun 2020 14:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="saj3x6NS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bWI/Qpg8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB31823D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/YjrgdbXfLLt7LKabCZBxYrAzA/wn2GdrehhOzPteXw=; b=saj3x6NSfsxv1S3LMAt3COzha WG45fctr75u86EMRNWgp++HzMK/zYyjHSSlb3j6Ict2PK+2UGnrWOYOuYFatQLaunJZSO/r2/8d+Y 2ozCD1dVmn0Al4/CFDwUbNiSKDqmLl7tTNiRYtr31Wvy2oZPKishqgK/gKpucT4ftpri2/XKig9K2 f5zseUiLgn4iOGmIho2WcwktyXL5Em9l2u1wLYdFkySvsgV+ZlrQf1BpsHDBLSD0YvOxqmrFeUmHb Q4XI/t/awOIP5zPyjxDYqJz4Zw/bUbDrzH4bN3nfXLrAkeKgKV+RsxrPTIHW1qyZLJlZ+yJ4Mfg94 6ENDF9+oA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP3-0004Dz-3N; Mon, 29 Jun 2020 14:04:57 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuOu-0004BN-1P for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:49 +0000 Received: by mail-wr1-x443.google.com with SMTP id h5so16665041wrc.7 for ; Mon, 29 Jun 2020 07:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=awbvdf/o8WJSBn2jZAYd3v4hbJ6rKznLBA9Uh+6bpSY=; b=bWI/Qpg8KHMiyukEPTm6FGM05U/4gMMkQHOHo8Nz82wB1fM52NfEp9sQEYJxW2Admn 36jXiYmOkyXpV+MMfSlpZT8Z9s9TZYZBTkr+WU+AkV6levgYIww9eFqKcfy+b7aov0Ar aSA6O4aQYnrIzAVcN2+hH+w3Fx7vH5ROlRP5Q22Uxuts5CNaQr/iw9JPKy3+nzLruCX5 rCb9EPkFb0B6QKG1l2+sEq1zz5+b6EgH7+TAMVkNi3o6cKbwRjBq67YFLhSGVkXgCcOv 8znzvVP02lrg2wbkpchzZYSHLbUR3k6W/ri5p3Tqp9XejF7alIJ68AbMxV5b4psyB5Oe c7RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=awbvdf/o8WJSBn2jZAYd3v4hbJ6rKznLBA9Uh+6bpSY=; b=RvmArk9GWbVuo4ALOtgiTcQgT3Bel1ib+EUtG2KyOXOougvCv6LvuKi6DslDK3Bcjw AuLousw4I0jUNrouTEB67sj9z55YDV+1JkdwaVibxfhRD90XHejU/mEddQ1PEUX08OkU ze/SpII9e7CVYY8HOgKYru88IFzokWZ1PT/6xHvwa4kb27X2hD/7K/+5g7p/9A075EFb drDwyomPd/W9h8BB6hSZEQfA797Zs2nRz10VTN9j2L6q8OWBpw7esuD6xynRQDTu3lUz Uhmsb+vIaRgn6llTCLiJyk1lZfxGTRHXORAQhZ5q8Asp1F2UtM5l731KYJT3ajAZHuCp 89XQ== X-Gm-Message-State: AOAM530myOibC4QcBlaHTxCX6e2/tz/cFzyhLW3T4aA48mIRRGQ1zY3P /M0nbabACIEF3SN2ZSvADKsrqA== X-Google-Smtp-Source: ABdhPJwlYoQKfNVdDrit+2utE+6X7YuQwjowoDK8uijEIVf5IcJ4q9wfncz9T8GKzXHC/FOuq3rmSw== X-Received: by 2002:a5d:4603:: with SMTP id t3mr18518133wrq.38.1593439487048; Mon, 29 Jun 2020 07:04:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:46 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 01/20] misc: pti: Repair kerneldoc formatting issues Date: Mon, 29 Jun 2020 15:04:23 +0100 Message-Id: <20200629140442.1043957-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: J Freyensee , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org W=1 kernel builds report a lack of descriptions for various function arguments. In reality they are documented, but the formatting was not as expected '@.*:'. Instead, '-'s were used as separators. This change fixes the following warnings: drivers/misc/pti.c:748: warning: Function parameter or member 'port' not described in 'pti_port_activate' drivers/misc/pti.c:748: warning: Function parameter or member 'tty' not described in 'pti_port_activate' drivers/misc/pti.c:765: warning: Function parameter or member 'port' not described in 'pti_port_shutdown' drivers/misc/pti.c:793: warning: Function parameter or member 'pdev' not described in 'pti_pci_probe' drivers/misc/pti.c:793: warning: Function parameter or member 'ent' not described in 'pti_pci_probe' Cc: J Freyensee Signed-off-by: Lee Jones --- drivers/misc/pti.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index 07e9da7918ebd..e19988766aa69 100644 --- a/drivers/misc/pti.c +++ b/drivers/misc/pti.c @@ -733,8 +733,8 @@ static struct console pti_console = { * pti_port_activate()- Used to start/initialize any items upon * first opening of tty_port(). * - * @port- The tty port number of the PTI device. - * @tty- The tty struct associated with this device. + * @port: The tty port number of the PTI device. + * @tty: The tty struct associated with this device. * * Returns: * always returns 0 @@ -754,7 +754,7 @@ static int pti_port_activate(struct tty_port *port, struct tty_struct *tty) * pti_port_shutdown()- Used to stop/shutdown any items upon the * last tty port close. * - * @port- The tty port number of the PTI device. + * @port: The tty port number of the PTI device. * * Notes: The primary purpose of the PTI tty port 0 is to hook * the syslog daemon to it; thus this port will be open for a @@ -780,8 +780,8 @@ static const struct tty_port_operations tty_port_ops = { * pti_pci_probe()- Used to detect pti on the pci bus and set * things up in the driver. * - * @pdev- pci_dev struct values for pti. - * @ent- pci_device_id struct for pti driver. + * @pdev: pci_dev struct values for pti. + * @ent: pci_device_id struct for pti driver. * * Returns: * 0 for success From patchwork Mon Jun 29 14:04:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630981 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2716992A for ; Mon, 29 Jun 2020 14:07:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F274623D99 for ; Mon, 29 Jun 2020 14:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l3O2NPEV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AnISCPiR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F274623D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=svqeniiWjAMxtL3XZRn8j1yX4BKoAd1IQXj+GMFiDnI=; b=l3O2NPEVk1gi+wUauXD+2vSAB jFsKP78uq0TpqzAJwb5cvX+VOFywKZEb5R4KLoHJbQKKKJyuK6yKPEL1UwGwuwZ/aYIYI1TE2Cmdp s3oXXADsyBuCpaBBJxCyb/OdEdYsMZxzRD5CBbzvkKniJS4SJakmjIMfBmTnN4BJSs5JSETfOp5HP Q+xo7SnJWvSIeTqDvEaqCot5l8H1dUFvoqdv+P0/DcQ9GwbchLpcYguEc8L7/FmM5t5AR2/kWz1Jp ZewbiImwCdkxeMyy+eJP8MgI0lLdlag++3ODdXhDqbSHWR13vA0Wyl9IhkHmWbjfmlQdue7neLuiB OObgEURZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPD-0004Gv-24; Mon, 29 Jun 2020 14:05:07 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuOv-0004CE-8T for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:50 +0000 Received: by mail-wm1-x342.google.com with SMTP id j18so15513044wmi.3 for ; Mon, 29 Jun 2020 07:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5YQ/t8dSO0QYHudXebIYH68IYouA3ghRaFXxhzcpiAg=; b=AnISCPiRzH9TAyM1Yh/eas5uDZIiRrIXjaz84GZW0n+uAi8a26gU+tSqm77U3+rVZP NdV4xzJw8f2Ev9nBOarM/NU/yZ8KySVqMtpo3QQ1EKVUhnvFx8JQmbwFYaNaJD7/Zyn3 Fug4WDcUWHR/wmveZO01FVAC27cp7Td1Q2ZhMbVo9fhVF4NQKi7z4zbDrVALYLrK0vpQ DzQ4jCYTUc6B2LXvBglJpu+atdKccTXXJ0T5cB/0Y90m3fGPF0BSXSj22obJPWKVIXtO K7ih9N4L+20HHUOZqdVFp2be+ozko5YAMI4wvpWO/UUYO3n1Z/FyxYD3OqqVbwuvwC5C gEPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5YQ/t8dSO0QYHudXebIYH68IYouA3ghRaFXxhzcpiAg=; b=e/kR4hROONnSAUP2F3bi7rjSwPhFb4jidNAZTvJqbb7FhTiHTwQFBN+uR3oWqafLCC jp6Pi3zv/itKiNHG0agDnXxKtJV+/c+wb7S2/IWoq0eBZynyoFnxygA/DzCu8vCBx6oX xXnC0LtnOtc6oTBEywCwBlExYatCHQ6Owmo3Co7pQ4J5Y8m/7NGJ7SJu2k90XtdirztU UecX1NlXejeb2imIquGL0UvbM1uw0rd3wEPfDLAwkyHdJlWYl+Z6FHCGM+Kam1TOmbNT gIrRGv0cY7nUjjiSfLmBJF26HQh4aZSsVF74nti+0bwnuRW33hfHHOJ8J+zVM9QZGLqn lGAQ== X-Gm-Message-State: AOAM531iQmzg3Ec8wUocmpVJkMPhbA2QVI7zKZKdNc7QmuxJoi7rzJg1 T8QPm9zCuWKt3U5mkG/4Npi5Qw== X-Google-Smtp-Source: ABdhPJzklT/ar5KuBB0weZ4AZeRlCfm6aQdYK/f0/bnGvB3j51na/D665sOuUJB8nwyHym/s0z/zlw== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr16500903wmj.20.1593439488384; Mon, 29 Jun 2020 07:04:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:47 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 02/20] misc: pti: Remove unparsable empty line in function header Date: Mon, 29 Jun 2020 15:04:24 +0100 Message-Id: <20200629140442.1043957-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: J Freyensee , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The kerneldoc tooling/parsers/validators get confused if non- standard formatting is used. The first line after the kerneldoc identifier '/**' must not be blank else the following warnings will be issued: drivers/misc/pti.c:902: warning: Cannot understand * on line 902 - I thought it was a doc line Cc: J Freyensee Signed-off-by: Lee Jones --- drivers/misc/pti.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index e19988766aa69..7236ae527b19e 100644 --- a/drivers/misc/pti.c +++ b/drivers/misc/pti.c @@ -898,7 +898,6 @@ static struct pci_driver pti_pci_driver = { }; /** - * * pti_init()- Overall entry/init call to the pti driver. * It starts the registration process with the kernel. * From patchwork Mon Jun 29 14:04:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630983 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C0E8161F for ; Mon, 29 Jun 2020 14:07:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00E7A23D9B for ; Mon, 29 Jun 2020 14:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j82XLKPg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S/dhmjP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00E7A23D9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QbsiqYKu+rjjnwfaENZrP2GMC5pOk7FEIe9Ah+4udBk=; b=j82XLKPgoNs36w3bcbNicNBlo tftJGo31rqbXh9N2jeKc2cT+8YTRizGHpzUYlh2QGFoT/tDpP2JJyOkOLgxxiJfGrkhaCIS6tvjN6 A5GDCPwC/Ni7DNZA8O3/f6T5DrYhNDJuf0nq2984x7pfsdIC2T+WnpPRjI0UwclIqGYwzMakOxjUv sEKlXBGZm2uHoXVaw9xnA2VTta+UYdKAg0vcbFLSAlOV/SsTLXi8MN/P9JlyXva53tYaD9RYV3O4u iAskderNxCBuS1iT5TC6lQ5J28gmoGEFFS17pG7//7fgxa7Uo0yaYV+ulWChejEEubIqwGEG3hhh3 iSlJjCWfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPO-0004KP-4q; Mon, 29 Jun 2020 14:05:18 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuOw-0004Ce-Qm for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:53 +0000 Received: by mail-wm1-x343.google.com with SMTP id l17so15527213wmj.0 for ; Mon, 29 Jun 2020 07:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KMTCDVkmhrFSTaB8bx1bgREeHsoHTmBvamvepGv04mE=; b=S/dhmjP1Wds8RWIrdtgpp+KtZkHcSrMog/xRtGlSaf3iTckrCpwC/qb3qLOOKEADrl kZpxdApdfTy1KHnz6O6+jI7SbLRhTquBGADwdfSEIVjCa/Us7YMMK+rSrDigt9pKKqI0 arAl5wsHoGHJdXZD9hM3hrNqoas6LfBWPIXFg2LiSBUriBEnR58FC9UGbKCTqPgRmE8/ KJZtCDQD/bWeKePibICKhOVGetOraGmlTNY4Qmo+Wl4yjii80DNIgNBDngEU4Sg2WK3n 8SCG0nA/cmzTOyeEVf+hiyaq0XJoRy4VTVyAFgB3iB0KTHqz43w+6Ea4riu19Pvm1t5q OUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KMTCDVkmhrFSTaB8bx1bgREeHsoHTmBvamvepGv04mE=; b=bZD6HhWDEH10oB5dAJuRW6kUSskHrhgZYKPIHe7jhbU+ErzUOrbgxgwrScQ/zjWPwO npRXQs4YXqdugcTeGhykOSu6Gwg0xtW1iyAYVqvQztQqhLFAB81GnoVMtr0X52kP0w31 WN1qp4TS1t73D64XFx5cTHEWAri7S/j5gsNghaEcosxV9DFUBlptSIBSdjyyMW/7c85b V/+BzFI4dr5kJ7PkqwxAH2u9InieE5/RIw31ggMlJL7B+l5BiPF6Rkyc5aMdQL14R1gv qITW8v2jGqNMbJgpqWDz8THwgbQSViieEw+4IMtTX+Q/MTwT9qhK2WujoQOXpP0vwiLz iZNA== X-Gm-Message-State: AOAM530UO7gp9NYF7u6A2Cdc3yK9SFiPFqVC3gaB6lK9gJXFjgSjcyOJ y2Dig45Dwl+AlQ0aJjr5GfqqNw== X-Google-Smtp-Source: ABdhPJxpFPRPZgqmcu4lCys19buO548MqP7hdlLxqhc4qChHB+Z5s1KZcLBS69vBLvmj0ivfeBVVlA== X-Received: by 2002:a05:600c:2285:: with SMTP id 5mr5381620wmf.78.1593439489644; Mon, 29 Jun 2020 07:04:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:48 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 03/20] misc: habanalabs: firmware_if: Add missing 'fw_name' and 'dst' entries to function header Date: Mon, 29 Jun 2020 15:04:25 +0100 Message-Id: <20200629140442.1043957-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though documentation for these function arguments have been missing since the driver's inception last year. Fixes the following W=1 kernel build warnings: drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'fw_name' not described in 'hl_fw_load_fw_to_device' drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'dst' not described in 'hl_fw_load_fw_to_device' Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/firmware_if.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c index baf790cf4b787..15e0793da6554 100644 --- a/drivers/misc/habanalabs/firmware_if.c +++ b/drivers/misc/habanalabs/firmware_if.c @@ -15,7 +15,10 @@ /** * hl_fw_load_fw_to_device() - Load F/W code to device's memory. + * * @hdev: pointer to hl_device structure. + * @fw_name: the firmware image name + * @dst: IO memory mapped address space to copy firmware to * * Copy fw code from firmware file to device memory. * From patchwork Mon Jun 29 14:04:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630985 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F006D912 for ; Mon, 29 Jun 2020 14:07:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C719923D99 for ; Mon, 29 Jun 2020 14:07:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lgd3yVp9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EBCbSVbx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C719923D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v+d75nRv5S+TQFka4deV6tyuJ3zUZHIpndcUgQhF/wk=; b=lgd3yVp9f4Rp3Kbh/+RVwmq/5 GaQCvwpSyjud8ssWQazVaDv7Qu1kFZ1vywJefueZHTYxSFijgSq3sUjfb6CZLZpyj86xmTiSFfLtE 04Qo14QOUo5obZQ7wm/6zaiGL5oYJbnoR08ItidV/G3tYkOU4yyp2pA2JuotOMCqGqaw7Ov29721l 0o+5Tshny16NHqha4gGfRLNUNJdZUjtIOga9XyN2TGcaDf0/td3sF01Zxxk2Zgslgih3uxpZivxlu VSiGfBzFkCW5jIV/U+6iPDrhjvfAIizt9b9nqIZLyGJIbZF0hKxxwcpu4L1RFjwrKumqiNtxriR1P kmh/b/svA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPS-0004Ly-UX; Mon, 29 Jun 2020 14:05:23 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuOx-0004Cs-QB for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:55 +0000 Received: by mail-wm1-x344.google.com with SMTP id j18so15513185wmi.3 for ; Mon, 29 Jun 2020 07:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=snRavlMzvk6o89999ihW2SJGcP4kgkkLuKbzazJuz7M=; b=EBCbSVbxb5YiApQEcA5o+TIGFgyXHcDAl7i662DfxDYdnp862l0GPoQfWOcNUtjcSe jnezcozxuPVkZo5f4KjMKLccsMOZTvdDTyEbUlK4123+wVNAkXCXWv8ZfYrJxAS3qZ93 8vrs/CdF0z7YODI7HgsfSKNJdxYv1vhR4+IGMmCaoAOzFgJycGJVJ0ZGcNbsup+I/eZE XqHkVB4Rbu4LtbCpo307g++fMpBLSJJGlXhTLve6b5TV0o4HitW+xa8FO/mP/sCAT6Pa 3VnkcXGnjMH8qE1jsEUyE7sTCYERb3R3EtTgvwOpZAcOq6zxn7z3UFHnAkImidK5q/fj I+6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=snRavlMzvk6o89999ihW2SJGcP4kgkkLuKbzazJuz7M=; b=hEc9IVtXzXlGPHP1eHLEKcGMsPZACOPV6hG4q99rUwS73qOgca213cGarZVZkuI7+F nJxJwkcVXW8n7DknOzOfRHBaWGpZ12AXxISbq9A+APs4jtaM0EPVE7bT8VPClfmdHySn 4a9s0Hr0MQVwEpkiMsWD19Ntx8AMI9bt2iQKlhiOWax5ftzAwKgqsr9CxjpGaM73D5yK cUA+jvQa7RzTKez8fMqf1u6prIAOz5Ba0DQARifI0TDVz8C/qQdclHr+JmRYfIhiSM9H O3NN6Ym73HXfiW5xFgnNt+UgJgwq3WputxCXM2Osm/jNcJZUJPrNBHpDn3Uk6QOH1gZh gd9Q== X-Gm-Message-State: AOAM532GDs5MhDgUYHoBn4nt1gMczKoCxjxJwGIN6HoIl4t/Bp5ofs3s 1gbrptcnyMjmXA7iNXbO6UeMDA== X-Google-Smtp-Source: ABdhPJwtIrvDrDIcBEd1RS2NhZDsLvIxIfEKOQpWVF86D0jsOeJclt4mGbamK7+WRgzx6R43bbW3/Q== X-Received: by 2002:a1c:2cd7:: with SMTP id s206mr16182224wms.109.1593439490833; Mon, 29 Jun 2020 07:04:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:50 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 04/20] misc: habanalabs: pci: Fix a variety of kerneldoc issues Date: Mon, 29 Jun 2020 15:04:26 +0100 Message-Id: <20200629140442.1043957-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org hl_pci_bars_map() has a miss-typed argument name in the function description. hl_pci_elbi_write() was missing documented arguments. The headers for functions hl_pci_bars_unmap(), hl_pci_elbi_write() and hl_pci_reset_link_through_bridge() were written in kerneldoc format, but lack the kerneldoc identifier '/**'. Let's promote them so they can gain access to the checker. These changes fix the following W=1 kernel build warnings: drivers/misc/habanalabs/pci.c:27: warning: Function parameter or member 'name' not described in 'hl_pci_bars_map' drivers/misc/habanalabs/pci.c:27: warning: Excess function parameter 'bar_name' description in 'hl_pci_bars_map' drivers/misc/habanalabs/pci.c:147: warning: Function parameter or member 'addr' not described in 'hl_pci_iatu_write' drivers/misc/habanalabs/pci.c:147: warning: Function parameter or member 'data' not described in 'hl_pci_iatu_write' drivers/misc/habanalabs/pci.c:324: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask' Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/pci.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/misc/habanalabs/pci.c b/drivers/misc/habanalabs/pci.c index 9f634ef6f5b37..24073e8eb8df9 100644 --- a/drivers/misc/habanalabs/pci.c +++ b/drivers/misc/habanalabs/pci.c @@ -15,7 +15,7 @@ /** * hl_pci_bars_map() - Map PCI BARs. * @hdev: Pointer to hl_device structure. - * @bar_name: Array of BAR names. + * @name: Array of BAR names. * @is_wc: Array with flag per BAR whether a write-combined mapping is needed. * * Request PCI regions and map them to kernel virtual addresses. @@ -61,7 +61,7 @@ int hl_pci_bars_map(struct hl_device *hdev, const char * const name[3], return rc; } -/* +/** * hl_pci_bars_unmap() - Unmap PCI BARS. * @hdev: Pointer to hl_device structure. * @@ -80,9 +80,11 @@ static void hl_pci_bars_unmap(struct hl_device *hdev) pci_release_regions(pdev); } -/* +/** * hl_pci_elbi_write() - Write through the ELBI interface. * @hdev: Pointer to hl_device structure. + * @addr: Address to write to + * @data: Data to write * * Return: 0 on success, negative value for failure. */ @@ -140,6 +142,8 @@ static int hl_pci_elbi_write(struct hl_device *hdev, u64 addr, u32 data) /** * hl_pci_iatu_write() - iatu write routine. * @hdev: Pointer to hl_device structure. + * @addr: Address to write to + * @data: Data to write * * Return: 0 on success, negative value for failure. */ @@ -161,7 +165,7 @@ int hl_pci_iatu_write(struct hl_device *hdev, u32 addr, u32 data) return 0; } -/* +/** * hl_pci_reset_link_through_bridge() - Reset PCI link. * @hdev: Pointer to hl_device structure. */ From patchwork Mon Jun 29 14:04:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630989 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 357B9912 for ; Mon, 29 Jun 2020 14:07:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A42F23D99 for ; Mon, 29 Jun 2020 14:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CcRXiULl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ous+18uF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A42F23D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=akF0c8XSY03BkCt9/aFd/GINT77t/fmz+PKq/+mjTJw=; b=CcRXiULljmyxDSbYzZjo7YsWr lZ2FNNk52Wkt8aUyZZnRVXl/39yZnq3Or43KHr3zUFtT1xEDUomjunO8xQwfJPiKm5ZIPCfyVZin7 pZapai5JQhCVlAlqv8mTJro9d8gqhviZj0jisibFv2rQOje7a5EF2dMXjixguLWwliukoWXNcwlok TvHr2pkShE9/S1TOE4wzDpKqRuNHJ5gD44OkI1fghC5l7nHy4msPxM9NeScgBxDhA8MCXVwZphnsK 7DuVywfuIrQQs+w5ReMtWw5JorwWFHE2rUwVWeY5425+4E5j0m6Uie/5AkSHxaA43YZ2yUI56hwLU A/QVD7KdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPW-0004NM-SI; Mon, 29 Jun 2020 14:05:26 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuOz-0004DM-Kj for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:55 +0000 Received: by mail-wr1-x444.google.com with SMTP id k6so16693912wrn.3 for ; Mon, 29 Jun 2020 07:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yhVnLd0r7raxgcyoOCULQKwhfsHJk9/wusjVrNWGYS4=; b=ous+18uFIcLaG4cRJ524/Q1ebFSiRNvabxyUHCwVUaiHeJAFRIwyphH3zHRsSz0qS9 I5ONR3KmqwEOEL/VKlk9HPadqUmAq9XaRGcdladgrGuMDJF6qgEu6F8CckoAtv06KGIF 3bjATAYVK/0qKDy3omdQMZlPnvhr7hDQovFKt/7+86+M7yFt0QYblSF+uvHDe+QzsSni 9Ql/GNVVBEfWoOPONrJJJ7plhbru+0WlGgEssah/lUvnHKVpKZgryoy/1D9Mo50mDZ8Y sV3VnKgvzDfnBA9b6XtGg5Y4T4G24dfqY34pKwl9m+podVZRUNE9hbt/WluL86x2hc5l eO6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yhVnLd0r7raxgcyoOCULQKwhfsHJk9/wusjVrNWGYS4=; b=aT00Nq8IFZN84uHsknx4OmvbRNB0Ss2zZ5GJm260KBoc2t9AsB1is/wJ+5tbqXHjS0 JB0fSE7ldMgVUQZ/GBCJzExM6O9+pO9ZbCsF0o+zSSxRihMYZbAJlvUKMoPjW1DgLQWz OqgkzblZPXCepVLEgYEf1LzRWsJNYS4CfQBg5OdZYjngoWyOH0oogc7NfCOF4zw/OoKK ZI3zc53h+VD6JDpeifWuTFHOswXQSOsSYOj5deGRnieSKMrtgBMES/XHY6rYs2wVR3pY aCvDgHp8lCYGZONXFCgr3gfOuOEB9PMhOepQd8NiZ9YRVRFuXoIi33gH1RRfcCvwNmxR GIQA== X-Gm-Message-State: AOAM533IBAYqOxPPAYmmMekazRMeVoYLaNhUrQbIACZFy81dXzRdW2KC KTuF3Vj+dSVaqwati3l3vL4Rsg== X-Google-Smtp-Source: ABdhPJweOwERgUR+r9gh8XzakhlezA7hIvHmDKSA8UboEuprGSmmgnfQoX93xLHK/KaSO4JsEZHXOQ== X-Received: by 2002:a5d:6603:: with SMTP id n3mr17730012wru.142.1593439492519; Mon, 29 Jun 2020 07:04:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:51 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 05/20] misc: habanalabs: irq: Repair kerneldoc formatting issues Date: Mon, 29 Jun 2020 15:04:27 +0100 Message-Id: <20200629140442.1043957-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org W=1 kernel builds report a lack of descriptions for various function arguments. In reality they are documented, but the formatting was not as expected '@.*:'. Instead, '-'s were used as separators. While we're here, the headers for functions various functions were written in kerneldoc format, but lack the kerneldoc identifier '/**'. Let's promote them so they can gain access to the checker. This change fixes the following W=1 warnings: drivers/misc/habanalabs/irq.c:24: warning: Function parameter or member 'eq_work' not described in 'hl_eqe_work' drivers/misc/habanalabs/irq.c:24: warning: Function parameter or member 'hdev' not described in 'hl_eqe_work' drivers/misc/habanalabs/irq.c:24: warning: Function parameter or member 'eq_entry' not described in 'hl_eqe_work' Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/irq.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/misc/habanalabs/irq.c b/drivers/misc/habanalabs/irq.c index 4e77a73857793..6981d67153b11 100644 --- a/drivers/misc/habanalabs/irq.c +++ b/drivers/misc/habanalabs/irq.c @@ -13,9 +13,9 @@ * struct hl_eqe_work - This structure is used to schedule work of EQ * entry and armcp_reset event * - * @eq_work - workqueue object to run when EQ entry is received - * @hdev - pointer to device structure - * @eq_entry - copy of the EQ entry + * @eq_work: workqueue object to run when EQ entry is received + * @hdev: pointer to device structure + * @eq_entry: copy of the EQ entry */ struct hl_eqe_work { struct work_struct eq_work; @@ -23,7 +23,7 @@ struct hl_eqe_work { struct hl_eq_entry eq_entry; }; -/* +/** * hl_cq_inc_ptr - increment ci or pi of cq * * @ptr: the current ci or pi value of the completion queue @@ -39,7 +39,7 @@ inline u32 hl_cq_inc_ptr(u32 ptr) return ptr; } -/* +/** * hl_eq_inc_ptr - increment ci of eq * * @ptr: the current ci value of the event queue @@ -66,7 +66,7 @@ static void irq_handle_eqe(struct work_struct *work) kfree(eqe_work); } -/* +/** * hl_irq_handler_cq - irq handler for completion queue * * @irq: irq number @@ -142,7 +142,7 @@ irqreturn_t hl_irq_handler_cq(int irq, void *arg) return IRQ_HANDLED; } -/* +/** * hl_irq_handler_eq - irq handler for event queue * * @irq: irq number @@ -206,7 +206,7 @@ irqreturn_t hl_irq_handler_eq(int irq, void *arg) return IRQ_HANDLED; } -/* +/** * hl_cq_init - main initialization function for an cq object * * @hdev: pointer to device structure @@ -238,7 +238,7 @@ int hl_cq_init(struct hl_device *hdev, struct hl_cq *q, u32 hw_queue_id) return 0; } -/* +/** * hl_cq_fini - destroy completion queue * * @hdev: pointer to device structure @@ -269,7 +269,7 @@ void hl_cq_reset(struct hl_device *hdev, struct hl_cq *q) memset((void *) (uintptr_t) q->kernel_address, 0, HL_CQ_SIZE_IN_BYTES); } -/* +/** * hl_eq_init - main initialization function for an event queue object * * @hdev: pointer to device structure @@ -297,7 +297,7 @@ int hl_eq_init(struct hl_device *hdev, struct hl_eq *q) return 0; } -/* +/** * hl_eq_fini - destroy event queue * * @hdev: pointer to device structure From patchwork Mon Jun 29 14:04:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630991 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 26EAE912 for ; Mon, 29 Jun 2020 14:07:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E736223D99 for ; Mon, 29 Jun 2020 14:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xl0y+PWq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mExcRW14" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E736223D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O4jBKwGOC1ptHq862j3I1/xHTL5qA0qH53Bc/MUpy8Y=; b=Xl0y+PWqFjWgf48wen1oFnooq YmuwFUm+6UyzGkTYtoX4+wIQKZlqpFRYi35lyQC2ptEQv8tL7UE9/sxtrsf1lVsPaU4wO3t5LTZED SSXDFMw3XGac4xhG1xn+LtASrM7iQiy3LYjVlveSdfh4qurJV8MsxYY5HS4L56lGaAHYLHGPcyMiY Q0o20oMMy5HScZ0smVmN4kIzq7Xh9AbB36RMOM3nXNXfs9eYu8nvNoPzzpQmLYd524piWhKJjrrko Xq/mBgaT6am4YUI8eeiL10RcShWDwutTaRilsw3SjKZ4Zk9xuoXNOvo3F6fs0uHJCxg/rDnNb1NeZ 9Uhg3bzhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPf-0004QB-9p; Mon, 29 Jun 2020 14:05:35 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP0-0004De-Jh for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:56 +0000 Received: by mail-wr1-x441.google.com with SMTP id s10so16639118wrw.12 for ; Mon, 29 Jun 2020 07:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eCTcGJHtSmaPBnZUOms/69xtZG01NEK1s+KL4aDek/0=; b=mExcRW14yTqdrE+npdERL83UBRuofRErdA5/zgO3vl9BxrfDKDkoQbWF20CyrH2IUS 8UGyTrSsNjnnKbfg/JmvpnQmPPE+9II9m4mQ1g3abKPLo/CHKonJEB9B2KyTk40TL7zZ wJelDv5eKmyMI8SV1t20g5eXswq7iBjDP7X11tsetirsv9dUe16SDowmC7QpfiHTMG+x XvDbt0wa3fLD8MJ8wtrAGo1AQyLuSl7AIsI5m7XxErYSsKc6UKyp0O771NkG9DgFhEm6 NN/AlfVVuxiSc3efXqK8IquWgOi6l6dGg0dGxvvifTk7+/navEyuFGkz6eRr2WYZVKZy IMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eCTcGJHtSmaPBnZUOms/69xtZG01NEK1s+KL4aDek/0=; b=ca534GR9VKZz7g6wgD3+1IuVBEMqemrhB0Tk7Tls6E5a1R0UmQtvehCcF66qqL8Zta /kPAVDY89a8HLZiKejQb1b1m+W0YsDaHOwgIRT/TkxJRjLB28rQ7qtyr3ADimiB4EzHe Q+C55fPSsJmb5aPPfE1eTLXIi635LBfHTU8cINIIGb6PeKFz+p6G7N4fFHWA/ogp5DPh pTEp1bw1tOMBnZcCBUhdx50ZNl0RT9vxXx2tkhYzBd+RX7XIZF2eLrsrGe83mHR+Dlvh Zq6bpKn/denf3TxnxbLQhv4fjKW/g5NpZaL47JDD+IgFwyAkfPopH+lcdppo3Vown6O5 ZTDw== X-Gm-Message-State: AOAM5334Fga8ngW1UwTBPm2tatDYg1A1WCeJJWXr57584Fdah8f8trbG YQkylpzjHdUBdRcIywfz9Ue4eA== X-Google-Smtp-Source: ABdhPJygUbnUrJAbW4jXvLREPQuFQ/kwh1F2Ffox4kxTw9ORCJFsMC95XOvyQ46XY78Axn7iLPLN1w== X-Received: by 2002:a5d:6846:: with SMTP id o6mr17264874wrw.370.1593439493674; Mon, 29 Jun 2020 07:04:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:53 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 06/20] misc: habanalabs: goya: Omit pointless check ensuring addr is >=0 Date: Mon, 29 Jun 2020 15:04:28 +0100 Message-Id: <20200629140442.1043957-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Seeing as 'addr' is unsigned, it would be impossible for the assigned value to be anything other than zero or positive. Squashes the following W=1 warnings: drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read32’: drivers/misc/habanalabs/goya/goya.c:3945:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 3945 | } else if ((addr >= DRAM_PHYS_BASE) && | ^~ drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write32’: drivers/misc/habanalabs/goya/goya.c:4002:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 4002 | } else if ((addr >= DRAM_PHYS_BASE) && | ^~ drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_read64’: drivers/misc/habanalabs/goya/goya.c:4047:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 4047 | } else if ((addr >= DRAM_PHYS_BASE) && | ^~ drivers/misc/habanalabs/goya/goya.c: In function ‘goya_debugfs_write64’: drivers/misc/habanalabs/goya/goya.c:4091:19: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 4091 | } else if ((addr >= DRAM_PHYS_BASE) && | ^~ drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask' drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’: drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] 643 | u32 val; | ^~~ Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/goya/goya.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index 0d2952bb58dfb..a4a20e27ed3b4 100644 --- a/drivers/misc/habanalabs/goya/goya.c +++ b/drivers/misc/habanalabs/goya/goya.c @@ -3942,8 +3942,7 @@ static int goya_debugfs_read32(struct hl_device *hdev, u64 addr, u32 *val) *val = readl(hdev->pcie_bar[SRAM_CFG_BAR_ID] + (addr - SRAM_BASE_ADDR)); - } else if ((addr >= DRAM_PHYS_BASE) && - (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size)) { + } else if (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size) { u64 bar_base_addr = DRAM_PHYS_BASE + (addr & ~(prop->dram_pci_bar_size - 0x1ull)); @@ -3999,8 +3998,7 @@ static int goya_debugfs_write32(struct hl_device *hdev, u64 addr, u32 val) writel(val, hdev->pcie_bar[SRAM_CFG_BAR_ID] + (addr - SRAM_BASE_ADDR)); - } else if ((addr >= DRAM_PHYS_BASE) && - (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size)) { + } else if (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size) { u64 bar_base_addr = DRAM_PHYS_BASE + (addr & ~(prop->dram_pci_bar_size - 0x1ull)); @@ -4044,9 +4042,8 @@ static int goya_debugfs_read64(struct hl_device *hdev, u64 addr, u64 *val) *val = readq(hdev->pcie_bar[SRAM_CFG_BAR_ID] + (addr - SRAM_BASE_ADDR)); - } else if ((addr >= DRAM_PHYS_BASE) && - (addr <= - DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u64))) { + } else if (addr <= + DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u64)) { u64 bar_base_addr = DRAM_PHYS_BASE + (addr & ~(prop->dram_pci_bar_size - 0x1ull)); @@ -4088,9 +4085,8 @@ static int goya_debugfs_write64(struct hl_device *hdev, u64 addr, u64 val) writeq(val, hdev->pcie_bar[SRAM_CFG_BAR_ID] + (addr - SRAM_BASE_ADDR)); - } else if ((addr >= DRAM_PHYS_BASE) && - (addr <= - DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u64))) { + } else if (addr <= + DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u64)) { u64 bar_base_addr = DRAM_PHYS_BASE + (addr & ~(prop->dram_pci_bar_size - 0x1ull)); From patchwork Mon Jun 29 14:04:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630993 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B68792A for ; Mon, 29 Jun 2020 14:07:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3D9C23D98 for ; Mon, 29 Jun 2020 14:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AsXc9ixy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PbIxwA8v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3D9C23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gXTa7PNFLsgLgLJu7NC3jVYkYFmLQ5VzA33lZQwD/u0=; b=AsXc9ixyUfYaP8F5I0MdnqcDX 8Fxixb0u1ognUybOFdqa2LRnicIdahxThL7q9At8usATGCbkteMRD3MCRdmUVcGpIuHQn8edrToeN Ovydm+m5ZbCD05IdPq4fhebAQu4lWd+xDOTfgMAub84m/MSHIf34uhUcVz1uJ2Ifxx7Far4nHml3O 5L8Khzjbbpk01vYXnRLKsK0xhZ55Ba2AS5V5MG3fRqcaivKlX2DSgnZFU9r9eqSz68OL8Aw6OJ5nA y+pY3sOywq7SIXjxC+Y1YPhYlt7xsql7TpKbmHopgAkNweHOrTyBKX88j8qDqqF7SOfO0WJCyaCan 455GUpi8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPp-0004TW-01; Mon, 29 Jun 2020 14:05:45 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP1-0004Ds-Gm for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:57 +0000 Received: by mail-wm1-x344.google.com with SMTP id g75so15495928wme.5 for ; Mon, 29 Jun 2020 07:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xnIhP+BLJCkXHxO9I8vb7t4ZYrl34I7GGa9NV7vqaQI=; b=PbIxwA8vy7vWwp3PD1xYvC/boLvJezju8OhuIn1WM5qPXlK2MdHIieYvhn934I/UGA OURRy4f4bR0e0ymv4gSsOjdvPt+GDIeqZW65pRyK3+1U3jg+H4I2SGTL5572ec1SsDNz N+VMvXp2ig6KCBI/kKZM7CZ0OLIimgEUoYBfBhg8GeUjawTAJC3doOiPq6oJOzVJ/12U dMXCjVQc6LifoAl9uBJ8pFrHlHAMFF5aB10GKWdxKort9tIty0y2pSIcGpIivF9NIPmn nOQycVd1S4Orevvtr0YBONdbpszrq0tUfl6hfN8a9UI2cpYPDvBQcA+vULw12+lFAIZP 5OxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xnIhP+BLJCkXHxO9I8vb7t4ZYrl34I7GGa9NV7vqaQI=; b=kntKJPczsVTnt1h/2rrFWzp182AIhPSgLMBwmUAJUl8b7Linbzc1+4yg2k5nZx9S7m 2LB1Hie4RulzyURgr51EkxEGlUIcN6e8oPg3xuSXsBfVwz2d34NCX1j37fmY8qURFeDA psRVAtQPYl/jJRYwZSZzdlo8aVxSXNZ4GEduaC1ipZPDhH/crn5f54vilCYLHXz6h6O7 m8QXBR3+cbZI5fJwrb0hEyv03VbUfg2oX+VeRpS9EUkaNVppcB+D96mgUnhbaARIR047 zjdR06RzpVW14uMrqEU4RBw26qnzXMwoOJ46aUZEz2utupN0ycjbDeFUYS6OhQIwLObY eMXg== X-Gm-Message-State: AOAM533IMIz8XY8F6KZ05U4P4fDt6Mtw3nBd9U6Cic+5KDgaXQaFJzlx VePeUjqhebW++DLWlz1x4oks0g== X-Google-Smtp-Source: ABdhPJzOeMnbeszmHXXVmi9cS1WP+C6v+N9/fl+FfYjF90m7DrLtS9Wxsh//Et3QXAUgw7l8F9buNA== X-Received: by 2002:a1c:e908:: with SMTP id q8mr6088247wmc.59.1593439494664; Mon, 29 Jun 2020 07:04:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:54 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 07/20] misc: habanalabs: pci: Scrub documentation for non-present function argument Date: Mon, 29 Jun 2020 15:04:29 +0100 Message-Id: <20200629140442.1043957-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'dma_mask' is not passed directly into hl_pci_set_dma_mask() as an argument. Instead, it is pulled from struct hl_device *hdev. Fixed the following W=1 warning: drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'dma_mask' description in 'hl_pci_set_dma_mask Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/misc/habanalabs/pci.c b/drivers/misc/habanalabs/pci.c index 24073e8eb8df9..61a8bb07262cf 100644 --- a/drivers/misc/habanalabs/pci.c +++ b/drivers/misc/habanalabs/pci.c @@ -317,7 +317,6 @@ int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address, /** * hl_pci_set_dma_mask() - Set DMA masks for the device. * @hdev: Pointer to hl_device structure. - * @dma_mask: number of bits for the requested dma mask. * * This function sets the DMA masks (regular and consistent) for a specified * value. If it doesn't succeed, it tries to set it to a fall-back value From patchwork Mon Jun 29 14:04:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630995 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDEFF92A for ; Mon, 29 Jun 2020 14:07:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9771A23D98 for ; Mon, 29 Jun 2020 14:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A+FQH0+g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yR7EVA/J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9771A23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GBlGkdP9C2bw2vtoFgizCKZEKbC4pJTdQKaQqVU+qvo=; b=A+FQH0+g0rYsBRrNnRE7NJV8L 1OvfWFAKfp94tW2NzjBw5JOZ1DV3/SQi5QbKLEWWw4LrFHUX9O/yvkVYRhCiKn0i5HdXLqdX7mtII J83wePneC9llIMcAPURdn94aosNG2ZPQ3Ko2F4l7OByYm03zr+8lZxVt6dzoP8hg5XsDOPKEhUDot qDw0P8uSB9ljwjh7he8Nv3jOmH6sEgV8hw5Xm9UBZTGHK1nmCzAemIe95tF8PwXdSKNc3tTWESDpa UNECueSVorVZEpPAt7LODeYAXu82/jMxFgieADu5+Mg4kKy/7FDY7nwRNqeflGWol9eK7/iKj+yx7 MM6+frc+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQ0-0004ZB-Si; Mon, 29 Jun 2020 14:05:56 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP2-0004EC-J4 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:57 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so13686167wrw.1 for ; Mon, 29 Jun 2020 07:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1S50qko1q+z74H3H0J6W5HtpHbtK1gQwgwBXn9Rlvzc=; b=yR7EVA/JfMBOI9U5dnD0dsDVA/IHZqoG8OX+LKynRnDtfmxafybx4Z1ZVUsa0221gw xWauzNcM5+cKRdOuF6YTMKPahxAdgN3yCtQ2Uowy2mLLdVxBF0BHoY3LFCD+i00XyFrc PkkbwMlKAoH7XAYVQW3PZUvDJdSGvHGDQaUTjVJSTqDj48v/pB2GyvTgRn39wWvEtgZ3 UfIywRtxHwUjIlNYJ8MwtNNzp+LIKvWmUnesoPvAkV8vDuM3NaVZPWOM4bAVYxOfrwaQ Y8/dgvQKIAtTIPTBVuNfuPVJlfZn65WKu1hoX4o20Zi8VRS2aouROf1cs84TMYqlaoM2 95Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1S50qko1q+z74H3H0J6W5HtpHbtK1gQwgwBXn9Rlvzc=; b=GDU2l62ZIvsgI/1WxEBFIxD5kd7nxNQ6jMAtqdPlnRCTS1BcoQU4WsXcbhJt3k8T4c TM4crNHLSgmKlG+ZubbAb5hGqZVWyHrP9DozL7lGGP/4+IcOCzPiTfSS+k//W6OSQ4Fc 1MR0mDIBm6MktWB0JE6xHlC1//+RqZ6rqUwZrAoDs/5MAt3ttV3IB3eBtmroWp0icyaR b6k/dID47GgbEJPfczufgs3zelFHtuJVnogr/E3nmbxMyK26M9MKEleA9kGnKL2yRN4E xsyuCL7rm9mFeflVCwgN2jHCHTasRD+77vEiFYZFJ0dA+dhR0nI8EVl60zJwxMyYByh4 NcNA== X-Gm-Message-State: AOAM533C+GVSUgWAO1AKmyt7ecDmRh/nztzNcuIWuzr4hESH5takrrTa sZjMClH+D1NXoTMt7TXNPFlLxg== X-Google-Smtp-Source: ABdhPJw7u+pR3PUUjovhGP29vg+5MVuG3YO6weDsgP3XkESH2uz5kK5iz1fARHNMR2qAFPReAFxLOQ== X-Received: by 2002:adf:e901:: with SMTP id f1mr17201511wrm.80.1593439495667; Mon, 29 Jun 2020 07:04:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:55 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 08/20] misc: habanalabs: goya: goya_coresight: Remove set but unused variable 'val' Date: Mon, 29 Jun 2020 15:04:30 +0100 Message-Id: <20200629140442.1043957-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt to check the return value of RREG32() has been made since the call was introduced a year ago. Fixes W=1 kernel build warning: drivers/misc/habanalabs/goya/goya_coresight.c: In function ‘goya_debug_coresight’: drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] 643 | u32 val; | ^~~ Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/goya/goya_coresight.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/goya/goya_coresight.c b/drivers/misc/habanalabs/goya/goya_coresight.c index 1258724ea5106..aa51fc71f0a1f 100644 --- a/drivers/misc/habanalabs/goya/goya_coresight.c +++ b/drivers/misc/habanalabs/goya/goya_coresight.c @@ -640,7 +640,6 @@ static int goya_config_spmu(struct hl_device *hdev, int goya_debug_coresight(struct hl_device *hdev, void *data) { struct hl_debug_params *params = data; - u32 val; int rc = 0; switch (params->op) { @@ -672,7 +671,7 @@ int goya_debug_coresight(struct hl_device *hdev, void *data) } /* Perform read from the device to flush all configuration */ - val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); + RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG); return rc; } From patchwork Mon Jun 29 14:04:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630997 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB168912 for ; Mon, 29 Jun 2020 14:07:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92C5723D99 for ; Mon, 29 Jun 2020 14:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KDh6vIVg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hUHcgi2v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92C5723D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+aXXOYqc1Uu5xNBUS/Y+iynCStAtkAul6TqS30/sP2M=; b=KDh6vIVgNJShlJk9I0Dxetvga XCCLBymMPUVLvdwnknduwL3LSc5v8amzA6S2tf77XaccztaNnc/dzYNpGZlZEUiMShw67X1t1uErm ONz7T3BKPgG3vOWTk4hI35xvfxMq4wyvlIMCYnHw6JRMFZHlvIYXUV/OcxT2bpxGV2Zhu2xtiZre5 F+A4lfJ4iAHX8EtFVDBbUXIJIqETf7MRz9oWsvnnba+blV0DdPd3X1nEq+hte//rvflPz4CMw5Rwy twKfSq6WFh0KxdNuH8zbCIW8x8UnWe2gqlX73b3yBeK7JIhQWWTVbFOUleDhppyvwUHnVp9Z04P7N /QywL6WJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQ7-0004bJ-9M; Mon, 29 Jun 2020 14:06:03 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP4-0004Ep-MB for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:04:59 +0000 Received: by mail-wm1-x344.google.com with SMTP id l2so14759281wmf.0 for ; Mon, 29 Jun 2020 07:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M622QyXkGImCQOBm9coRWRHenvXfV0A+BN5blU47k6s=; b=hUHcgi2vihm8gXNvlTePM3HpVMkMlur2cTNuCxMxvj+KIjqeq3e8gkHbWaW1YdmXzZ 8jjqtglnruE6j5R+lzaQu9fZdxFcvfr1+fxXFIY/TZgE8cmjdG05PtbWEBK2p6YoFSAc ESoURzHQKCCoMmpFTYSoVA96mFuSvZYrh3fVsl5U7gS4TD8kIGhj6LnJBXyXJlQk2qyl 4DjC7HmsgszTC7Rt8nzICoJYKVCaCicSoLOKR5PhvNuXAp3boRKRdhjoqdVM6UGhnrSH w48rWMBw1XdQtKe0b63eQl+7z9/yHDPxyDtyOsVXu29tQKp0eH7Fjr4NtXu/Z4bdF5Mc 77bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M622QyXkGImCQOBm9coRWRHenvXfV0A+BN5blU47k6s=; b=BobkA0EVjWf7y89QV6not9sTqgjoXjXBU19Jl8av708YE/H0btvrqLTYj8tjLKUlxL mwMYGnU1s2V18odx2Cn4S6vzVqDnzxsMwAyKih9E8tVJS9JLNdGWIeXb8Sc8IxrM4H6p KM5nXZlW2Pz1RsV2icMRNE1wkzJDSO6/i744Eqk0sdUZLpSIU/ruq0EUwflNfeTKvwjD n4l2b+ylE2okJg0xdM1Li2Vxk7j+gAVIyCeY1bRIRh3cn//GtidSIfwo9+ExxuasEAzt AWY+GjiF2Ah2ZusZXONcYZk+mUbNO+z01wQR01vRaP1Gc3Wa+MMetj4LjT33JIUF+gGw aW8Q== X-Gm-Message-State: AOAM531xJKehzzXYZAU/7C895ertThwsi1SkS0B/YBfZW/GMT6Y2ZLM7 i6S+tmT12HDn7o7dItXkj0b6BKc1oc4= X-Google-Smtp-Source: ABdhPJxHpy4/biSgBzjt0OrJ9J5FM6Wm0UnBQzDsoEPjxlScdZKQtk0/AHSsk+eH8Q4Ea8ol50x1Lw== X-Received: by 2002:a1c:cc0d:: with SMTP id h13mr18320824wmb.168.1593439496774; Mon, 29 Jun 2020 07:04:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:56 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 09/20] misc: habanalabs: gaudi: Remove ill placed asterisk from kerneldoc header Date: Mon, 29 Jun 2020 15:04:31 +0100 Message-Id: <20200629140442.1043957-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org W=1 kernel builds report a lack of description of gaudi_set_asic_funcs()'s 'hdev' argument. In reality it is documented, but the formatting was not as expected '@.*:'. Instead, there was a misplaced asterisk which was confusing the kerneldoc validator. Squashes the following W=1 warning: drivers/misc/habanalabs/gaudi/gaudi.c:6746: warning: Function parameter or member 'hdev' not described in 'gaudi_set_asic_funcs' Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index 61f88e9884ce9..bdb9c0080c464 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -6739,7 +6739,7 @@ static const struct hl_asic_funcs gaudi_funcs = { /** * gaudi_set_asic_funcs - set GAUDI function pointers * - * @*hdev: pointer to hl_device structure + * @hdev: pointer to hl_device structure * */ void gaudi_set_asic_funcs(struct hl_device *hdev) From patchwork Mon Jun 29 14:04:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11630999 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8378912 for ; Mon, 29 Jun 2020 14:08:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78E5523D9B for ; Mon, 29 Jun 2020 14:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r/3XU/5E"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UhjCZd7W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78E5523D9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O/P9qeKTXSDyVJPeI/2wDCDaXuGuuJ/0hq5MWFqgji8=; b=r/3XU/5EGH2DOXrudfrnx1m8Y vzfVNA/6ERkbbimDyBG+3F6vDS+KShdJiRQ1LPGsjUUTBI5NRxv5YSle/1BdND0kR+PLOqwhbaEeu BZK1a3Jl1nJ1mMpGmEFcnQif6yRELnQbqyI4Xi7zH9+5QgtA8Rndv7Cy4rkH9lKtyjtv8wgCy6K79 DczEOWmYmV4vTGTzz2Tb87glyi2XSXyu9GPBlYBmSLKW3vX5Oak9FybQZBLQNzgHyUOLCK4kHlzCz dwFkIp9vodfPly1fSwTQIIsoaU+vgDdzDSiv8kyknDniYlZwjOjOMarXLjKP5k0bs07EgHR/wmQ7K 93H3AbzFA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQB-0004ea-52; Mon, 29 Jun 2020 14:06:08 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP4-0004Ex-W5 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:00 +0000 Received: by mail-wm1-x341.google.com with SMTP id l2so14759287wmf.0 for ; Mon, 29 Jun 2020 07:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zFg/20zEaYelN+bfrfecs/17poyLmNxtGMsllJMhgRc=; b=UhjCZd7WNhGjoLDr5PyNeZnltRSCoPXKyAHQgfTsZnaLk96ITbriliBHRl55k0eDJx lc3n3EKymPGCS7unDwOE063XuLFpjB1iQAYFZTgz6tyySvF4yoaosDvst4ifsKgVhmN0 LNPrO6GKlT5E6LwyirkIJorC2j5C4qh6EJoyY465J+R2Xs4hziqKqz1uaTVzlsA+pn3z gcTXxqlLkpSrB2zUsNjQzVNKBajJz1mQaknOq5scO/mQ6+uWRfqEMbL8jlgwOjLK2+sR LzTx5lmYPk/Hf2baptXHP4/mApmazi/TAZpWe3byTGbgwYtrag7D56WH3ZziZygGlE1v oGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zFg/20zEaYelN+bfrfecs/17poyLmNxtGMsllJMhgRc=; b=G3hIKrOgK/Wz+1y2xsiymzJ32xT/gVMlQCBoxxv46d2FY/hhaAYFsCH84UU1kAFsRz xmCHId+yqWHrQFv4lr/Iq63VgaAu+4QZdf3Fh8WKv0UcGz5BB10n/Csx4TPEeIMN2Wk8 HffSqpIQn0dAL7j4mJpQaJgHH8cG0ICQCjn8E30tjxyvJrzU4Am4vjK5/AVrcT1maIHM 0zA7/NWlRAnJGSzwncyMY2sA+B6LuEERFHpi8rhNRmvYi3TUG+HB98ROxKWonB7dzh65 aBFA+V36qZExoWFsXIuhgFr5ki0QiJ5czDVQu0elV9wooGaNFppL6rO/vSFz0f+xTpYU uQEQ== X-Gm-Message-State: AOAM530ylZphVcG5qXyKCfbOCz6XUAcgS6pNgVt3O21lUBkAeN7A5pV/ nwk47Sz8g+aexJuSGWcvBGINsw== X-Google-Smtp-Source: ABdhPJxVASpcY0mI0vJ1KMxWvt8KciiXaLwY9KmwNnvFBmpGV0B9lPz9rGOhshF5HA/le49SFgxcpw== X-Received: by 2002:a1c:2e0e:: with SMTP id u14mr16716253wmu.55.1593439497936; Mon, 29 Jun 2020 07:04:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:57 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg Date: Mon, 29 Jun 2020 15:04:32 +0100 Message-Id: <20200629140442.1043957-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oded Gabbay , Tomer Tayar , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in its function header. Fixes the following W=1 kernel build warning(s): drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block' drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block' Cc: Oded Gabbay Cc: Tomer Tayar Signed-off-by: Lee Jones Reviewed-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c index 6a351e31fa6af..abdd5ed8f2cf6 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = { * gaudi_set_block_as_protected - set the given block as protected * * @hdev: pointer to hl_device structure - * @block: block base address - * + * @base: block base address */ static void gaudi_pb_set_block(struct hl_device *hdev, u64 base) { From patchwork Mon Jun 29 14:04:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631001 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE19992A for ; Mon, 29 Jun 2020 14:08:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8593E23D99 for ; Mon, 29 Jun 2020 14:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qEkRoy1p"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a6lY1hwR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8593E23D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hJG/GrEf5GflKF9q2ls22g8DgyEpifs04AjKtQLIhs0=; b=qEkRoy1pFI15umNuh4H/iphvh 6PweD5aGwE7b+uFb7Ao/V4Q5sOD7ZcT/I5XBnD4M7LL/rnfKo1qf7KDvVVtM7B+IMVBBC7cFtQU5D Vn4rwG1q/amoeBDePlwdKtecYgCBVrEnp+KUMwReW3IdY9xFGZJI8gEJIngj7r6V/4wtCkDLD199f F/0jrxMVH/wq9y5ZutjbKHuQ+UernUtr2gAZWV/63bS06KZDbKazyt3ncJaSmdQI7VX/SGYr/ft/e 23Wg2k+RZpyNe0zJ6hNXBc3+u+/ADaPuQDdSFH8Cg8UW155XcPYbQKnm9O6YiWp5jOaPSHUf472Ev /YXuXr3yw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQG-0004go-7R; Mon, 29 Jun 2020 14:06:12 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP6-0004FU-Hl for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:02 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so16235729wmf.5 for ; Mon, 29 Jun 2020 07:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KG862h2vmccOR30Zy+dEvVE74O1dfXe3tQ9ea9Wl0kU=; b=a6lY1hwRQfrrWwQ+wHSUIGy11GsRdeUlhhyJ0ZzZ4czs3V0mgD5NY7lzixVzuUWzlL akdh+Uv6PTnpAKv4iWUHoYDESL7HfZjPqk9/WM7W3w6T2yrZmrwO9FRiBuIBV0deyNo+ zfStV9k4eSj/vx0x15mO3/VJWdg+hl3nt0cQX3K1bu+ZJurQBip0CMxhGHy0VIb6MP9b oxFY1I/GLar0bZxP0OGjfUvxGvX0VFDkl2k6Qd2SztjENj+Vo76dCcgV5R005s+8cfrh a0jr0UdpYMJ5rWgozkUzZeZLAUBB1FWNf3xP+ebdGw/sy4Es8VLllhYU0opQNaHghjNf y1LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KG862h2vmccOR30Zy+dEvVE74O1dfXe3tQ9ea9Wl0kU=; b=i2IybNspe3OSABFeVV6P0dNabWz+5Evu3tEDcy2l7Jrin9D5wrVHJ7MV+HqJIdy1oT 4Txtmy2fvciKT9ut5uLVQQrx1s/fnk27WTaQrHJyJ4VmXJMLe1pcV7DwWCdOjE6DZwOG S90G2v7wupL33DcFxBf84ym3t5HKJu9FQkhsaMvRFc/SpDi6mQVz1eRUH8e7G+Mk0ijN MGe9QwsnRhs8RCoMTp8WmeJaF6WtmDnGBLTEZ3QH8qJayE6DrpEZe42fjLlKSkt58j2V 9KIi2UvqMQ+FN50cmFjnuZjcnBfEwNEu9H8aaj3nka0kT19ZnUL7wbk5tMzc7TOf6top gp6g== X-Gm-Message-State: AOAM530gRLDKVrvHMkhcDfruJSZNXMPyUFAVkGgmnotOTxa27ttfSNzu baIMG5RUUH3eNi899XWG+PTc6g== X-Google-Smtp-Source: ABdhPJz/fRbJ6fyCO1SuMHt5E5sUIRbeH3s/cAZ07coPEBwFUMgIQRAVseQRxEZ6RHFD+GJq655Rlg== X-Received: by 2002:a05:600c:414f:: with SMTP id h15mr5965306wmm.82.1593439499585; Mon, 29 Jun 2020 07:04:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:58 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 11/20] misc: enclosure: Fix some kerneldoc anomalies Date: Mon, 29 Jun 2020 15:04:33 +0100 Message-Id: <20200629140442.1043957-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Bottomley , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly some missing function argument documentation, then some whch are present, but are incorrectly named. Fixes the following W=1 kernel build warnings: drivers/misc/enclosure.c:115: warning: Function parameter or member 'name' not described in 'enclosure_register' drivers/misc/enclosure.c:115: warning: Function parameter or member 'cb' not described in 'enclosure_register' drivers/misc/enclosure.c:283: warning: Function parameter or member 'number' not described in 'enclosure_component_alloc' drivers/misc/enclosure.c:283: warning: Excess function parameter 'num' description in 'enclosure_component_alloc' drivers/misc/enclosure.c:363: warning: Function parameter or member 'component' not described in 'enclosure_add_device' drivers/misc/enclosure.c:363: warning: Excess function parameter 'num' description in 'enclosure_add_device' drivers/misc/enclosure.c:398: warning: Function parameter or member 'dev' not described in 'enclosure_remove_device' drivers/misc/enclosure.c:398: warning: Excess function parameter 'num' description in 'enclosure_remove_device' Cc: James Bottomley Signed-off-by: Lee Jones --- drivers/misc/enclosure.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index 3c2d405bc79b9..e8eba52750b34 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -103,7 +103,9 @@ EXPORT_SYMBOL_GPL(enclosure_for_each_device); * enclosure_register - register device as an enclosure * * @dev: device containing the enclosure + * @name: chosen device name * @components: number of components in the enclosure + * @cb: platform call-backs * * This sets up the device for being an enclosure. Note that @dev does * not have to be a dedicated enclosure device. It may be some other type @@ -266,7 +268,7 @@ static const struct attribute_group *enclosure_component_groups[]; /** * enclosure_component_alloc - prepare a new enclosure component * @edev: the enclosure to add the component - * @num: the device number + * @number: the device number * @type: the type of component being added * @name: an optional name to appear in sysfs (leave NULL if none) * @@ -347,7 +349,7 @@ EXPORT_SYMBOL_GPL(enclosure_component_register); /** * enclosure_add_device - add a device as being part of an enclosure * @edev: the enclosure device being added to. - * @num: the number of the component + * @component: the number of the component * @dev: the device being added * * Declares a real device to reside in slot (or identifier) @num of an From patchwork Mon Jun 29 14:04:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631003 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 94C4392A for ; Mon, 29 Jun 2020 14:08:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1225E23D98 for ; Mon, 29 Jun 2020 14:08:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Reak8NV9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yqxeccx+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1225E23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i5pbml1MU3248IfDUIoZ7f73qp0NxPXu1jSEeropv68=; b=Reak8NV90VQwnG7IiFTXWGPW9 ur8Fq5+mhUSf6JUFrQDCTMi9pvjVjdse7nKjqyBay6tRoPqR5JsgbBvuNLN8mnxEWlXNn/6s7iPRe zZCdgqDsm0g954Dr8Cob0Ed1Fbbsrzaq17EvQXywDCYvd6SU/399WLXG/B0NYqHJHGas9SmMFGLLp a1pMvAPXyaqnK0Z6LKp6ffrrLFB4XV3M5K5Y2ikOHUD+4S0fP0mD6eXMPgDSNXXOqpJsGLq0+hMtw K0Sux1+ib0c0Ewh6MbjwWgNTb30W/Zev0wSyldZF6JRUIAXq/KdWqdiDzbAfeeIry4xO/fYq6rYaN 9Pv/7DWZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQO-0004l4-8i; Mon, 29 Jun 2020 14:06:20 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP7-0004Fn-J0 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:04 +0000 Received: by mail-wm1-x343.google.com with SMTP id o2so16258951wmh.2 for ; Mon, 29 Jun 2020 07:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MA4D/3EmXU00HIViUNDTK2zztNgG9GHE3QsyfvIeaek=; b=Yqxeccx+BeP2NcoVf8V9CW9Kfpy/B9e8WWtiZSLEHcXHUfBkdQr5EVkUMgJXYsMhRX eauSayO11Dx3fdjMWqVvKs8GhjWRJLil0U37o7wDe0enpWSyrIfJfS8I0zq1UCIH1waR nSq/2T/OlzJugB5pOGYgAC0+y4dfD241WRypgzJ6jV0dSfxi7/PVCjfJJf6sgOjNVlhz uAAUA0LtZmQhBOmnS6splciovURAzeKzs5zQCV19j1xV1Woy2IFAqcrzrujtgS/xZEoE SW69zYx+gng/6cTnFfPiy0h4WZAr2yIQIHpdb5NMI1ipqNxuU3XKJB3ENdl0yGYKwOTt nM2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MA4D/3EmXU00HIViUNDTK2zztNgG9GHE3QsyfvIeaek=; b=UzUk2u52CdVAJTUHLdCA7aLXlaZJIY6B4RK0qTjDTknXfg0Ri9peaKSY3YzGZRcVwp wKfia4ol7levB4v4E5dhRrIP25DS9R47vtqsf6exLOW7qOtWZc3fqR0+6/75OZnwp5Vj NSSyphLPkrHerSG9GaiEtb/Nb0f2zddztjEX+NOtDtKXizbKo02Y7hRjtIVXlkPC11pN kIugNEDYuhotNb5l3uEB2+qn/SXC5tlBeO/ty/g5cOm77J5aKdYG9D6XgyLFTOmKABFA UtuIQjHIP+D0xZ2aO+yI2owcN/1a9ACxN9qPdaF03WJfiovnZK/XlgV3emV/1s0JrD4I KxcQ== X-Gm-Message-State: AOAM531wL9/qEEH5csHmaok5Z0d2blxmQEhqNCRwENzJUb++gIadhy+f +xK3JJ0WIPxqT7N9I5iMtkk3FA== X-Google-Smtp-Source: ABdhPJxDNp7vd10O4kA6m0+v/7iGwoA/DNFCia8vBm/9JG0WJDOmhz/GZXc5w1/8d9K8otS7NjxLwg== X-Received: by 2002:a1c:bdc3:: with SMTP id n186mr1698099wmf.84.1593439500590; Mon, 29 Jun 2020 07:05:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:04:59 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 12/20] misc: lattice-ecp3-config: Remove set but clearly unused variable 'ret' Date: Mon, 29 Jun 2020 15:04:34 +0100 Message-Id: <20200629140442.1043957-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Roese , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It's odd for the return value to be assigned to a variable so many times, but never actually checked, but this has been the case since the driver's inception in 2012. If it hasn't caused any issues by now, it's probably unlikely to. Let's take it out, at least until someone finds a reason to start using it. Fixes the following W=1 kernel build warning: drivers/misc/lattice-ecp3-config.c: In function ‘firmware_load’: drivers/misc/lattice-ecp3-config.c:70:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 70 | int ret; | ^~~ Cc: Stefan Roese Signed-off-by: Lee Jones --- drivers/misc/lattice-ecp3-config.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/misc/lattice-ecp3-config.c b/drivers/misc/lattice-ecp3-config.c index 884485c3f7232..5eaf74447ca1e 100644 --- a/drivers/misc/lattice-ecp3-config.c +++ b/drivers/misc/lattice-ecp3-config.c @@ -67,7 +67,6 @@ static void firmware_load(const struct firmware *fw, void *context) struct spi_device *spi = (struct spi_device *)context; struct fpga_data *data = spi_get_drvdata(spi); u8 *buffer; - int ret; u8 txbuf[8]; u8 rxbuf[8]; int rx_len = 8; @@ -92,7 +91,7 @@ static void firmware_load(const struct firmware *fw, void *context) /* Trying to speak with the FPGA via SPI... */ txbuf[0] = FPGA_CMD_READ_ID; - ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); + spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); jedec_id = get_unaligned_be32(&rxbuf[4]); dev_dbg(&spi->dev, "FPGA JTAG ID=%08x\n", jedec_id); @@ -110,7 +109,7 @@ static void firmware_load(const struct firmware *fw, void *context) dev_info(&spi->dev, "FPGA %s detected\n", ecp3_dev[i].name); txbuf[0] = FPGA_CMD_READ_STATUS; - ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); + spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); status = get_unaligned_be32(&rxbuf[4]); dev_dbg(&spi->dev, "FPGA Status=%08x\n", status); @@ -130,20 +129,20 @@ static void firmware_load(const struct firmware *fw, void *context) memcpy(buffer + 4, fw->data, fw->size); txbuf[0] = FPGA_CMD_REFRESH; - ret = spi_write(spi, txbuf, 4); + spi_write(spi, txbuf, 4); txbuf[0] = FPGA_CMD_WRITE_EN; - ret = spi_write(spi, txbuf, 4); + spi_write(spi, txbuf, 4); txbuf[0] = FPGA_CMD_CLEAR; - ret = spi_write(spi, txbuf, 4); + spi_write(spi, txbuf, 4); /* * Wait for FPGA memory to become cleared */ for (i = 0; i < FPGA_CLEAR_LOOP_COUNT; i++) { txbuf[0] = FPGA_CMD_READ_STATUS; - ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); + spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); status = get_unaligned_be32(&rxbuf[4]); if (status == FPGA_STATUS_CLEARED) break; @@ -160,13 +159,13 @@ static void firmware_load(const struct firmware *fw, void *context) } dev_info(&spi->dev, "Configuring the FPGA...\n"); - ret = spi_write(spi, buffer, fw->size + 8); + spi_write(spi, buffer, fw->size + 8); txbuf[0] = FPGA_CMD_WRITE_DIS; - ret = spi_write(spi, txbuf, 4); + spi_write(spi, txbuf, 4); txbuf[0] = FPGA_CMD_READ_STATUS; - ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); + spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len); status = get_unaligned_be32(&rxbuf[4]); dev_dbg(&spi->dev, "FPGA Status=%08x\n", status); From patchwork Mon Jun 29 14:04:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631005 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D3FD912 for ; Mon, 29 Jun 2020 14:08:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 664BD23D98 for ; Mon, 29 Jun 2020 14:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZBDPCZln"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jOLEqH8u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 664BD23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Js/fzi8wLId2j7Kts08hCZb/su2ahamrxAkDB5e2t80=; b=ZBDPCZlniJ4KP+0LACc+RcsQg o3MIZWCRXUgSc1MlMUJLJORf1OxgtF1p6lX3KfYoGvcZm8g2uxMvtlc3Z9I4Ml9LY3ZOcK5CshNCm 18A80iHDzIwphnAgrqHsoIpwLc77YjZpGOXlf9gLPPt/sWTBS75YTmHFCidX1oCFFGmOisTHOL7zH bacQG3D5u5zQgMtasmu1mbQa8ATBtS4mgX0gQQ5CELM/FCVMf47QsBBFsUhUF1ZChl/gcHEvr7UZ/ 5G96wuBEK89gn5jgrgORDBxVhnvRIoqYgGbnvBiqWkvLT/BT40f31jN3bDCxBTOR8XtxB0acVEwCm ZPXgG3DOg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQW-0004r1-VK; Mon, 29 Jun 2020 14:06:29 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuP9-0004GL-5y for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:06 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so16639621wrw.12 for ; Mon, 29 Jun 2020 07:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mu+wXsRAPVJI2BbUnA6whI4V192flwFfYNz4LkoWH3w=; b=jOLEqH8u8fh6v6UYWj7y6Sg98lssQOe4aTyeSL0IikxGXCqZutLG6GKlQ9BXJNekwO pA0FLrP45RJazv/O776JiqFwBiM9SSicqTdF0HmAHU3jsaAj1VlHgzlj9wY/GzgB17pM ubWy6qfRPbBvZ8J3w1kxyXFv/IeI5waIMPcfmr2zcYZvZlRxT2dwWNaRuE4Puv/HfYYT nIkmrT8A+p9sCGg0k4ohno1ddfnIdqPqRPEFbj0iJclDIK6PzXYisbdjyd+W2gD3vfvk Zsevyfjt6lHQNZDymm97hSlwNKvxpXflu4E4I+3qDDPb+o+TP01B05fqRjFg7PI25dmS Rl1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mu+wXsRAPVJI2BbUnA6whI4V192flwFfYNz4LkoWH3w=; b=DF3Q7WvDGiQoKe945ByvR479xD+iP7rOQJl7wlwYcPHY0BVKF6VVYhv0a9k4e2UjzX IJV3WWFg3l6HzhOo5Agm8Skg6ytUdOjVqHaICY71q6lD8FO58Y4NyjBY69bGUCajSEVW fpNl4aux5lGtI8PR3YcUPFoMHFzF4aDwg/pcQqGuNXWjCxtiAE6M/xu8qU2D5nGXMn4z EmmVr3YfC4d6Mk3JxAVFgT8TmSHLNfitJoZuLmTAHtT8LWsShXkAZRYQOthDbDj0Npn4 SIuFHzBvoL6RHj56o/0eBk+sM3cOAQtrYuUTskQflXHBpIw547iDddtz1M/c+8Izdpkf IGrQ== X-Gm-Message-State: AOAM532HuQTO/JNTekBKRHdqVww7EE05RUYVxItZcejjge7PonKrZIHh eK45A8K5NDel6Q3SDPu6okmrSg== X-Google-Smtp-Source: ABdhPJznnVAOrd15Z7Gc4f8Mk9Y3wkQjwCks7QOJqn2xOTJTvoqY/62dUv1+U/NtBEe3EVYh+Ui3rw== X-Received: by 2002:a5d:4a45:: with SMTP id v5mr17241252wrs.228.1593439501944; Mon, 29 Jun 2020 07:05:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:00 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 13/20] misc: pch_phub: Provide descriptions for 'chip' argument Date: Mon, 29 Jun 2020 15:04:35 +0100 Message-Id: <20200629140442.1043957-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masayuki Ohtak , Tomoya MORINAGA , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org For some reason (probably copy 'n' paste) kerneldoc descriptions were missing for all instances of 'chip'. Providing them squashes the following W=1 kernel build warnings: drivers/misc/pch_phub.c:145: warning: Function parameter or member 'chip' not described in 'pch_phub_read_modify_write_reg' drivers/misc/pch_phub.c:282: warning: Function parameter or member 'chip' not described in 'pch_phub_read_serial_rom' drivers/misc/pch_phub.c:296: warning: Function parameter or member 'chip' not described in 'pch_phub_write_serial_rom' drivers/misc/pch_phub.c:334: warning: Function parameter or member 'chip' not described in 'pch_phub_read_serial_rom_val' drivers/misc/pch_phub.c:350: warning: Function parameter or member 'chip' not described in 'pch_phub_write_serial_rom_val' drivers/misc/pch_phub.c:450: warning: Function parameter or member 'chip' not described in 'pch_phub_read_gbe_mac_addr' drivers/misc/pch_phub.c:462: warning: Function parameter or member 'chip' not described in 'pch_phub_write_gbe_mac_addr' Cc: Masayuki Ohtak Cc: Tomoya MORINAGA Signed-off-by: Lee Jones --- drivers/misc/pch_phub.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 60828af7506a3..95ba82a8625b0 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -135,6 +135,7 @@ static DEFINE_MUTEX(pch_phub_mutex); /** * pch_phub_read_modify_write_reg() - Reading modifying and writing register + * @chip: Pointer to the PHUB register structure * @reg_addr_offset: Register offset address value. * @data: Writing value. * @mask: Mask value. @@ -274,6 +275,7 @@ static void pch_phub_restore_reg_conf(struct pci_dev *pdev) /** * pch_phub_read_serial_rom() - Reading Serial ROM + * @chip: Pointer to the PHUB register structure * @offset_address: Serial ROM offset address to read. * @data: Read buffer for specified Serial ROM value. */ @@ -288,6 +290,7 @@ static void pch_phub_read_serial_rom(struct pch_phub_reg *chip, /** * pch_phub_write_serial_rom() - Writing Serial ROM + * @chip: Pointer to the PHUB register structure * @offset_address: Serial ROM offset address. * @data: Serial ROM value to write. */ @@ -326,6 +329,7 @@ static int pch_phub_write_serial_rom(struct pch_phub_reg *chip, /** * pch_phub_read_serial_rom_val() - Read Serial ROM value + * @chip: Pointer to the PHUB register structure * @offset_address: Serial ROM address offset value. * @data: Serial ROM value to read. */ @@ -342,6 +346,7 @@ static void pch_phub_read_serial_rom_val(struct pch_phub_reg *chip, /** * pch_phub_write_serial_rom_val() - writing Serial ROM value + * @chip: Pointer to the PHUB register structure * @offset_address: Serial ROM address offset value. * @data: Serial ROM value. */ @@ -444,6 +449,7 @@ static int pch_phub_gbe_serial_rom_conf_mp(struct pch_phub_reg *chip) /** * pch_phub_read_gbe_mac_addr() - Read Gigabit Ethernet MAC address * @offset_address: Gigabit Ethernet MAC address offset value. + * @chip: Pointer to the PHUB register structure * @data: Buffer of the Gigabit Ethernet MAC address value. */ static void pch_phub_read_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data) @@ -456,6 +462,7 @@ static void pch_phub_read_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data) /** * pch_phub_write_gbe_mac_addr() - Write MAC address * @offset_address: Gigabit Ethernet MAC address offset value. + * @chip: Pointer to the PHUB register structure * @data: Gigabit Ethernet MAC address value. */ static int pch_phub_write_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data) From patchwork Mon Jun 29 14:04:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631007 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC18A912 for ; Mon, 29 Jun 2020 14:08:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A413523D98 for ; Mon, 29 Jun 2020 14:08:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J94ycSgF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UWLk6Vml" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A413523D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=j+lPDrJPV9dcNHhfVW2gJUCGe7x9OAHXZ1Rf0DAzeq0=; b=J94ycSgFRmOQ4IPJ+GjwR5v8h 7CVxVJAoKLFlgszrer4fTu+z1u+aoIIcv1krL6UMQjA6elpTTUtSr4IahHps0+uN8NwUMLz+QADj5 6lvQIuOdP6zkQYOhz0XiAVHpufYG4FdJRrG1w1GP5vOsncGF6nvDdDJiouXkQ54/N6gyLhUZY/hLV Ezw+W27F1teud1lkmEH068DhwXEo/BPkQ/lkWSaDV7oi4OKE0M6vNvwRiDz2wkO6k7hzima7r1jyJ jOjIjEzkoBmOLxLo996Dpuvy8NfT/CUW7+UY06gxsANRk0mW7YTb3sqkL+R3Y0ra/imYnliNiZ88A 8quxCVMJQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQj-0004yb-H2; Mon, 29 Jun 2020 14:06:41 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPA-0004GZ-19 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:07 +0000 Received: by mail-wr1-x443.google.com with SMTP id s10so16639691wrw.12 for ; Mon, 29 Jun 2020 07:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JmkBl6CgYcKij/6z3M241pPTb33PjPTKpPi0m3JJzZw=; b=UWLk6VmlQbmgGn4fxQ9O9psVUunquWgTklcNwPDy56YobyD39DbRUDQCyVvdxB+o3p LGCnqchxFgFvLy1pT+ih5xMmrLS1HVNnYIK/pluBDZb09cz8AqhLnXfvEjPncFbmC13T p2N7ccpTgWZ7gkTeMI4Y64VGhLlUURWMObv42l0H+kk/Fq5rONWnaJ9Yn8s69opYrbdW pS2nx53E8qC4aQPhLC6IocEWs+ZOu/cxQ8ONVYrZPOfPsW6cwQK7vzt+9GGr+RChqZCj bjo/bWB+8L5H4e+VqyufDUV/kEx7SG2rQphbkfVZTatbY7LItp8tSL3kV7gDzh+dkST0 OIQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JmkBl6CgYcKij/6z3M241pPTb33PjPTKpPi0m3JJzZw=; b=Q3MStIAhvvxTv/+74UuywTzvMmwnPwF7E7cipSlPTpaYqR1gH6emKASbSgcOS1rrG5 x0jzKJ1sSNQND30jb1y+7HsTVAWRIYGPo9MwELmWB+lpcP6fVE4ikzFV4RqdlE+IxV7a X6Hc2YZHgsiCMF8BfytvhBizEa8YwdeVcFNExF7zCmO76bmjR/kDT+fi2YgKrcmGolBs qjjHc7fC7r86J2TwX2bnCTMBpIXbJG984hRbrUKpTrB+UzzLxXgOAgPRPxmfX3WLHYgu nRH5qLTaRnzIWoJE2S8hmm0FA9TbGW/BKnwZijWvFOQ/poaC6e9BZ3x79ED87MZtTlP0 qzTA== X-Gm-Message-State: AOAM532uQRZ8VuQKEeP2IgxkZNybg/WXaF5mQf1djuu308sv9ud9VovS ugOi2X3wl+QojnKSL4A8yof5Yw== X-Google-Smtp-Source: ABdhPJyQRVI9EP39ZGYsTFc+3vc1D9TeBEYaguyI5hOW2INRl8vdxPpsYcnXAsNe5kQjL671fwMBlA== X-Received: by 2002:a5d:684f:: with SMTP id o15mr12582448wrw.148.1593439502968; Mon, 29 Jun 2020 07:05:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:02 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 14/20] misc: pch_phub: Remove superfluous descriptions to non-existent args 'offset_address' Date: Mon, 29 Jun 2020 15:04:36 +0100 Message-Id: <20200629140442.1043957-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masayuki Ohtak , Tomoya MORINAGA , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Probably a copy 'n' paste error, 'offset_address' has never been part of the pch_phub_{read,write}_gbe_mac_addr() functions. Squashes the following W=1 warnings: drivers/misc/pch_phub.c:450: warning: Excess function parameter 'offset_address' description in 'pch_phub_read_gbe_mac_addr' drivers/misc/pch_phub.c:462: warning: Excess function parameter 'offset_address' description in 'pch_phub_write_gbe_mac_addr' Cc: Masayuki Ohtak Cc: Tomoya MORINAGA Signed-off-by: Lee Jones --- drivers/misc/pch_phub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c index 95ba82a8625b0..b27d826132915 100644 --- a/drivers/misc/pch_phub.c +++ b/drivers/misc/pch_phub.c @@ -448,7 +448,6 @@ static int pch_phub_gbe_serial_rom_conf_mp(struct pch_phub_reg *chip) /** * pch_phub_read_gbe_mac_addr() - Read Gigabit Ethernet MAC address - * @offset_address: Gigabit Ethernet MAC address offset value. * @chip: Pointer to the PHUB register structure * @data: Buffer of the Gigabit Ethernet MAC address value. */ @@ -461,7 +460,6 @@ static void pch_phub_read_gbe_mac_addr(struct pch_phub_reg *chip, u8 *data) /** * pch_phub_write_gbe_mac_addr() - Write MAC address - * @offset_address: Gigabit Ethernet MAC address offset value. * @chip: Pointer to the PHUB register structure * @data: Gigabit Ethernet MAC address value. */ From patchwork Mon Jun 29 14:04:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631009 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 473F3912 for ; Mon, 29 Jun 2020 14:08:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 198C923D98 for ; Mon, 29 Jun 2020 14:08:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nFFnn8PB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rDYv3J+t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 198C923D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TVTEexzfqFJLqgjTCxX0zY8rTTntMewyhGOvV6rz60o=; b=nFFnn8PBt0/o8b6jWbm4kDl14 Tk7eZWnZJE3oo9543Hef136NggDOjltfSDeIL8Oh/2iDwQFM96gpW+B+ytaYwtKbkvgMDawZRqHXS EuaZeGsj8iSF4GKhesGW9w1J2HDY3Bz/nbn1mhvuAAVU/WJuoVUu3KA/uSYNOExe3AaSirroiol1f h9Hr2ZPREFMNpN9frWTfX36mlOI2d8nRVgnDJau5A47Ft/gNwhOpanmy+86B6fAaZy6r9y/fLZLaL 1LuE0wj1XnZK+oot/j2u4QwoiwibZMYVOBcmvOLxadlOCOMJCsv4aYspf6DLC0armq3r1UWtxWsEm jmL1UfUmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQq-00053L-N6; Mon, 29 Jun 2020 14:06:48 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPB-0004Gz-Pl for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:08 +0000 Received: by mail-wr1-x444.google.com with SMTP id j4so14225815wrp.10 for ; Mon, 29 Jun 2020 07:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XFhbgCKNRxFbloxjm7n8+8nB92/O/AE2sBwMkN1jQVY=; b=rDYv3J+t/fvTXVYSLvlXorZNbHhUQ/6y/asw1e95tUgjbuzJJ22wOs5jgNEXZ9aCFw 7nENOeDtyDLGMIcPXDx4J6RpgY0J72cV3yU9pJyBzsKwUHo5ax6PbSWYW3A0F0yg5poM yrnzqIS/FqzMaroXxLXo+0M2YedfnRYdVtYyO882ipkmlwYEGNM5n0IX7fASjRbyJRhX qNjGbqr4NAX+OrG9kHVAeWj4xRrT+Piiiq+v8IaiWO+R1O1vthsB8/QlFEKVLAQYZvzM NsKP8ih9Vk3CTfeB4RzJyjQ0jdxLswX27P9M+U41Yd8vx4H2FQERi0c+7/F7l5VcEEpi kJSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XFhbgCKNRxFbloxjm7n8+8nB92/O/AE2sBwMkN1jQVY=; b=EDCLNjXGyXJ4Jt0Ve+nEUbdYzjoQly+PF0i1BwDvFfvr8k+GBQtQUvlqKCTrFDQpy/ w2ZaocAFgDHzIEfYf8GTzCdahVDWlndjEpuyEWDvJNAcT6kuKiup2YvBFWohWEaRs75D pOwe4mc8c3SbZTF03YXHwJUJeJQJP1clfS1cpcO4pD0BR2ibJOc0b6VxjxQgm2X+7Kiw AWz1YQLzYKRdz+BAo4eE44JX/X/VGwvKmawKh/GHEw1Utp29LrbOp1OmBc6Y8l4h3fou SYOVSFVgZjnXsFnPauh6LBG2xXrp815LBSrB4DVP/U/WfkE5Trh3xTWVP8mv91vifTe0 Fp2g== X-Gm-Message-State: AOAM533dLB3Nsl4NscLUvg6ZjaXSaWln+yhmMmD3TZkt6UqYx/RUl/2a eq6WdGe5bdfQHVvAPgkvTgJUXA== X-Google-Smtp-Source: ABdhPJzyDyJpP65nJE9M2B1HioZi4XCaFMuMdtxDSjSoHMRbycyagIcp+yN52R7KVxHSkjFw7Jr9QA== X-Received: by 2002:a5d:4649:: with SMTP id j9mr16461671wrs.270.1593439504476; Mon, 29 Jun 2020 07:05:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:03 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 15/20] misc: enclosure: Update enclosure_remove_device() documentation to match reality Date: Mon, 29 Jun 2020 15:04:37 +0100 Message-Id: <20200629140442.1043957-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Bottomley , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org enclosure_remove_device() hasn't taken an 'int component for over a decade. Instead use kerneldoc to describe the 'struct device' actually passed in. Fixes the following W=1 kernel build warning(s): drivers/misc/enclosure.c:400: warning: Function parameter or member 'dev' not described in 'enclosure_remove_device' drivers/misc/enclosure.c:400: warning: Excess function parameter 'num' description in 'enclosure_remove_device' Cc: James Bottomley Signed-off-by: Lee Jones --- drivers/misc/enclosure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index e8eba52750b34..f950d0155876a 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -391,7 +391,7 @@ EXPORT_SYMBOL_GPL(enclosure_add_device); /** * enclosure_remove_device - remove a device from an enclosure * @edev: the enclosure device - * @num: the number of the component to remove + * @dev: device to remove/put * * Returns zero on success or an error. * From patchwork Mon Jun 29 14:04:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631011 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02EE892A for ; Mon, 29 Jun 2020 14:09:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFC2B23D9B for ; Mon, 29 Jun 2020 14:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iTGZOuOb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UerGcuAl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFC2B23D9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7wUs4r0YSRqb5eaat3R52cN/7Y3ATwdFFDg5TUcJSk8=; b=iTGZOuObKhWVuK+opLs9oeRDY 1snU5Dxx1p+76LOHIoDvlCekfkFTJoqJ8J6FVSR3DO8aAKSSBRuMxlG4t6l8ISYt+CuEbgeLR02Pa qIDaAiNFeyGzlzJz1eNdq3kMxIIeIMQUt13VzTXS1YXwZAb46RKNm9jaMOTIj+6EuxKTI+1u7ZxJX 07fyLmHCVrumjg8AjtLmMScNQ7xZbEqtVD8/BCyhQPtciUGNaN0WPSaqgdJdlmiGcp1fU9NQyFP5W whDVNwQvNMpgV8AAqooA+xSu4Y+qRrWMD5EbUY5V+tLo46Yk6atRt5BAA5ghY+BsqHuVWgFOar2Xq cwdivI8kw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuQx-00057p-Mp; Mon, 29 Jun 2020 14:06:55 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPC-0004HO-QM for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:08 +0000 Received: by mail-wr1-x444.google.com with SMTP id g18so16717165wrm.2 for ; Mon, 29 Jun 2020 07:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t94gU7LdZ9jhuE6Fuy5QcBW6wxTpYHr3wMA3J0Azebg=; b=UerGcuAlj7Z9MLnen9oULz1ZCNnOGBCp6prj5iOmxWAPp79uH10ApRql/esij74qU1 TWwBUWUwXKybD7mLCIFuxnDkchZH4v0l7AhLDtvi1LP5qGhTW5sQI1CWSfJzFZ2r0vbq iNCHT11TSH8gowVpzmfcRa9Ybi5BKsZNrAdCaLmXiEmJdHZQ/WB4GD2FFJw0jldyNHWe 1OOZfR50UhVxtQc3KBBvl3eGL4DEhf4K/Wvr3X/HV9mV+Jt0MY2ytHYcvMJwARnRZ6kJ Ug4lNp8IbJIuT+yzwH5HioKnq78YX5xRE4ZSMXGPflUPfa9qFJlKYMJqu8veJZDVafd/ ORJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t94gU7LdZ9jhuE6Fuy5QcBW6wxTpYHr3wMA3J0Azebg=; b=J2w9X+9JIxykxFLIn13D8O1TQgdl/Gvc5vVefTa5nPb82mtzqz94CtoKmoC2GxyWlu a85wfvOXIZx8xJBmUlO2nb/mlcs/0+WYNTfnlQHeNj5sSlIFbIxqE58qb45X2crbZaCq BY4V3jA/JSPh3V0KpsXX1dZUub787r/qwsCEtHuttRw3S2hF6wEIMPEUmT88vz/g8j2W QdUQtNMgiwDL9wSdiRmZo0h8pFNoYA7ilHCfWQRasJ2J9b8891O4fCxVsr0NnFVxlrwT xLAgIZ2cP+Q955iongt5yczg++IHbPpjL4Kvk0AOReGq3WTazUAK1ZXWTPuTX2uPLm0F sjYw== X-Gm-Message-State: AOAM532c7irGcQa7RIGkF6UCxsffBljtjfLoOjFVugLqovEe7QTnpTQy Q8Bm6FwEQErKG2xI6jS9ENUm9Q== X-Google-Smtp-Source: ABdhPJwmw6HtLwtc/BWKL7jvIFL/StauXcjQlFWHZqdNshQG+W/DhIyNUji82FIRqL0MnKMNZWFvkg== X-Received: by 2002:a5d:6846:: with SMTP id o6mr17265668wrw.370.1593439505791; Mon, 29 Jun 2020 07:05:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:05 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Date: Mon, 29 Jun 2020 15:04:38 +0100 Message-Id: <20200629140442.1043957-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Variable 'rc' hasn't been checked since the driver's inception in 2013. If it hasn't caused any issues since then, it's unlikely to in the future. Let's take it out for now. Fixes the following W=1 kernel build warning(s): drivers/misc/genwqe/card_base.c: In function ‘genwqe_health_check_stop’: /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] 1046 | int rc; | ^~ Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones Signed-off-by: Frank Haverkamp Acked-by: Frank Haverkamp --- drivers/misc/genwqe/card_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index 1dc6c7c5cbce9..bceebf49de2d5 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct genwqe_dev *cd) static int genwqe_health_check_stop(struct genwqe_dev *cd) { - int rc; - if (!genwqe_health_thread_running(cd)) return -EIO; - rc = kthread_stop(cd->health_thread); + kthread_stop(cd->health_thread); cd->health_thread = NULL; return 0; } From patchwork Mon Jun 29 14:04:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631013 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B42ED912 for ; Mon, 29 Jun 2020 14:09:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A7623D99 for ; Mon, 29 Jun 2020 14:09:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j6H6rCU4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CITmqLc3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A7623D99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=00H9Kc+Mqk6nk+Lq6rQR0rtWpmv/Ysbbz5l4zTJ7Xp4=; b=j6H6rCU4dbiPtyF2TvG8LOZYn ZfBhXladejbZ70erbguyYqjrINtOwBCoTSW0zSophkBhs1CwFDMmV2Ut+X8t5CYOAfjbYFlOGiGqi AmBDDFuePExD1xgbQ5i1hhPFSANk8b69635bxxU+yaAsLTcidcWOaJgRg1Ppq1/Osnh2fJly3WyOw 6oZHCT4VS6Tk8GfzSFFERbaLAtJBJZFBcTRFCBpBXUOFXdrEFFBzp/XaOV4hJhj94Uy9FiDm8mwY/ nO1wppTvkAklLktsdW2fpf/mRDgePd2VzKf2DCuOp4N9YtnJRRs5dqiVXUxeW+jvUiaoFi5AfZN0d gnVlCmmPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuRE-0005H5-4I; Mon, 29 Jun 2020 14:07:12 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPE-0004Hh-5G for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:10 +0000 Received: by mail-wr1-x444.google.com with SMTP id h5so16666338wrc.7 for ; Mon, 29 Jun 2020 07:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ObKoaiwUBMsH7RgwRp2nwwP2sLs2C+zRlkZVkrEZxL8=; b=CITmqLc3nbGdsGtKVJszDGHLgzCb7zsuvkz+o0c8ghMxDpU6eESRHcmbaHok/SMQ2R 3BU+t5KbBGhwJFZI+r+/nkGDxLbMDFjegBajaC6W6wItOi04H/OIE/Hth21EIcoxTgPS zEG/Pxz8a4/dNmmparDp0h0BLY0sTcsOeYI4rE6yK7E6G6mLkhST9OS1rTALTq79Fozc 74S2ArYQU1OOHSZ/moJCDIwcmWgFtR5hTcH7/j3iFTt3wuPylApkTXnwcx5VF99WNeKD RJvoNJm9t4E/z0j1kjIWLSVgkJIarplQvWgTVfehAFzcmf0+Zp+yvd8G5B8KZftONrdD 4z5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ObKoaiwUBMsH7RgwRp2nwwP2sLs2C+zRlkZVkrEZxL8=; b=heAjJixfnWBMSE3G7XXjjxTZj8L+I6y5tUSyiDmXHdCozlkOpVd0x0y1yOUUJZHmSw VtzZoxk+F3o2ucgUwWFszoQzO6v63zQVy3BScjbOGRSycBWYfIp/hmlN5wAcfUie/tx+ 1YmqN8eAqTxX77WhcTdDejAXEfNLH74jcBno/hSMFUwiT798fW7HCmf0MRrnu9aovqdI HS+QbeSl1Mpz1eRjoKXLr4DvO/+lplmzprM2r5Ia+o/yBgjazo5FYgQ0CyglnWo1yySr SjDqMEy4Y/oaq1p2dk4Y9GlJn2AtKk6ziTlOtjTf9K6OkTcscNb0Y+OWE3bNG2dIzLoF YGpw== X-Gm-Message-State: AOAM531mZE1Q7Hv4Lh3rn9t/hUldQqmBahbXQA8tFtWo4QfI+7VLsf0s PpYrBBwxjR+w9riN7zlvvw6VQA== X-Google-Smtp-Source: ABdhPJxkqzk0GPRCr9K1MAup+ksNzBdsY/taKwJeGxTcrmTr/Z34GpJMd3SoWqWuUsqXZ3BvIKddTg== X-Received: by 2002:adf:fe0e:: with SMTP id n14mr16825329wrr.325.1593439507115; Mon, 29 Jun 2020 07:05:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:06 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err' Date: Mon, 29 Jun 2020 15:04:39 +0100 Message-Id: <20200629140442.1043957-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'fatal_err' is taken as an argument to a static function which is only invoked once. During this invocation 'fatal_err' is not set. There doesn't appear to be a good reason to keep it around. Also fixes the following W=1 kernel build warning: drivers/misc/genwqe/card_base.c:588: warning: Function parameter or member 'fatal_err' not described in 'genwqe_recover_card' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones --- drivers/misc/genwqe/card_base.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index bceebf49de2d5..809a6f46f6de3 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -569,30 +569,18 @@ static int genwqe_stop(struct genwqe_dev *cd) /** * genwqe_recover_card() - Try to recover the card if it is possible - * - * If fatal_err is set no register access is possible anymore. It is - * likely that genwqe_start fails in that situation. Proper error - * handling is required in this case. + * @cd: GenWQE device information * * genwqe_bus_reset() will cause the pci code to call genwqe_remove() * and later genwqe_probe() for all virtual functions. */ -static int genwqe_recover_card(struct genwqe_dev *cd, int fatal_err) +static int genwqe_recover_card(struct genwqe_dev *cd) { int rc; struct pci_dev *pci_dev = cd->pci_dev; genwqe_stop(cd); - /* - * Make sure chip is not reloaded to maintain FFDC. Write SLU - * Reset Register, CPLDReset field to 0. - */ - if (!fatal_err) { - cd->softreset = 0x70ull; - __genwqe_writeq(cd, IO_SLC_CFGREG_SOFTRESET, cd->softreset); - } - rc = genwqe_bus_reset(cd); if (rc != 0) { dev_err(&pci_dev->dev, @@ -958,7 +946,7 @@ static int genwqe_health_thread(void *data) cd->card_state = GENWQE_CARD_FATAL_ERROR; - rc = genwqe_recover_card(cd, 0); + rc = genwqe_recover_card(cd); if (rc < 0) { /* FIXME Card is unusable and needs unbind! */ goto fatal_error; From patchwork Mon Jun 29 14:04:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1116E92A for ; Mon, 29 Jun 2020 14:10:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCDCE23D98 for ; Mon, 29 Jun 2020 14:10:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xwUok2OS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QDZD1E/9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCDCE23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G7Ab1o5WDS5FPdxPaFD9xAX2BXWJgSxaz94WqDaSzNM=; b=xwUok2OSZof8Ry0GflN+FdqbA fteFAyaNCzyhaioL2AfCzuiMWQ02ceg5vryHRenKMts/3/0rohgy6LAOTliUQlEn+9Kr0pvvCIlgH I2yPFNUKnoCuwDQCcE1RroQMvwc+s5dC4wOcMf4KJNG3cx14PWNEBZehOYOwD+PkkcsZF6sGgtw5v CMtSmN5eHEbEQtAxOufg+hbqE2sOspYYUIDo2qHhvaQQHs/fjl/+hzQgzE6cRRlF74xPgwh5732GV nSqYtnevsnfOCHxYJIfyjNnkyMgphwtTD+W9BNrbE4MN5wjkGOwCfIiBvr0WZwGmApOg1OoPZ2htR rzDnk4KRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuRs-0005hN-QQ; Mon, 29 Jun 2020 14:07:52 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPF-0004I1-DF for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:14 +0000 Received: by mail-wr1-x444.google.com with SMTP id f7so13687055wrw.1 for ; Mon, 29 Jun 2020 07:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LaDrQKEmYDpmhOISw+HFewU1l3tDs3w3ogOpoIA2uN8=; b=QDZD1E/9mwp7cfrgqZrqgaE7lGA3ei+Rg22ZRYVh4tYM3xOIaNa6YJFDsY+D4RevD+ IuuHKr6BYZrAkktht/fH5EhOkmgn0TcBTvOwS+uQZ9OOqteNofjMA3qFe1bL559UJz7o 9tNOkQ6OLJcIRlAp0ZWeYUKjxl/aITEh6LZlI5jxtPmX0fQqGGHCL33GvnFQOJh5ROzC XCTP06lHVpX6iVNZBsyPaTuw2Q3BPpQ7jfa8djKvbxNFfyVexLanjtdIIal32c+uXq9j sBGNaQu+/99e6YWBTZADXxTfDipb5V/hldrKYAWLg9Sn4Mv9dLipmeYmXfm9s5rsKp6h 3itA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LaDrQKEmYDpmhOISw+HFewU1l3tDs3w3ogOpoIA2uN8=; b=EWDMAJVOQWy0mMSO8fmUr+BpEcYWVfGLpDEvZruKJVpgm4uH1OKO0wPdpdXHnQBKfC S+LhOUj5SYD2QtVTVjIRWJ1e9OG0Jt+mEJA8nDfKHJ5nWPbtUZrScygjWQAH+rJq0wJI IHFYn3g+l1aQLayd3McyHR6HncI2sfNo5epVhlpMHI1Fb4EdNRWR9SIUOXUYjJjfBeJa EQVRocoiF3qlRp1k5jUbDi4sg4GcGeWHe/itcD/ZlAT4duFw/GvRcZOmyNGOx5M8+ywj GkAINyD2mKIOxklbKR9/xMGEoSihe5YrnecOoSb690Fww7k3uIHnDu4WxnS+fWCHJfSj lRnw== X-Gm-Message-State: AOAM5333IMP1DPrp9fkHssZFVXOrVEFi702yiDPLfV5Kat46JPg1Mn4/ 11nL/n4CoQ6YVtWHwxY1h7qrsw== X-Google-Smtp-Source: ABdhPJzl12/NkxoNTuG2tDJ4lxfsOxRelqQlweCR8UDDSuqOm/zLruwEJaWtVaWl3vuHMZEHwHqTvg== X-Received: by 2002:a5d:684f:: with SMTP id o15mr12582829wrw.148.1593439508252; Mon, 29 Jun 2020 07:05:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:07 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 18/20] misc: genwqe: card_base: Whole host of kerneldoc fixes Date: Mon, 29 Jun 2020 15:04:40 +0100 Message-Id: <20200629140442.1043957-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From missing documentation for function arguments, to promotion obvious kerneldoc headers and incorrectly named arguments. Fixes the following W=1 warnings: drivers/misc/genwqe/card_base.c:175: warning: Function parameter or member 'cd' not described in 'genwqe_bus_reset' drivers/misc/genwqe/card_base.c:272: warning: Function parameter or member 'cd' not described in 'genwqe_recovery_on_fatal_gfir_required' drivers/misc/genwqe/card_base.c:293: warning: Function parameter or member 'cd' not described in 'genwqe_T_psec' drivers/misc/genwqe/card_base.c:314: warning: Function parameter or member 'cd' not described in 'genwqe_setup_pf_jtimer' drivers/misc/genwqe/card_base.c:334: warning: Function parameter or member 'cd' not described in 'genwqe_setup_vf_jtimer' drivers/misc/genwqe/card_base.c:557: warning: Function parameter or member 'cd' not described in 'genwqe_stop' drivers/misc/genwqe/card_base.c:617: warning: Function parameter or member 'cd' not described in 'genwqe_fir_checking' drivers/misc/genwqe/card_base.c:760: warning: Function parameter or member 'pci_dev' not described in 'genwqe_pci_fundamental_reset' drivers/misc/genwqe/card_base.c:889: warning: Function parameter or member 'data' not described in 'genwqe_health_thread' drivers/misc/genwqe/card_base.c:1046: warning: Function parameter or member 'cd' not described in 'genwqe_pci_setup' drivers/misc/genwqe/card_base.c:1131: warning: Function parameter or member 'cd' not described in 'genwqe_pci_remove' drivers/misc/genwqe/card_base.c:1151: warning: Function parameter or member 'pci_dev' not described in 'genwqe_probe' drivers/misc/genwqe/card_base.c:1151: warning: Function parameter or member 'id' not described in 'genwqe_probe' drivers/misc/genwqe/card_base.c:1151: warning: Excess function parameter 'pdev' description in 'genwqe_probe' drivers/misc/genwqe/card_base.c:1207: warning: Function parameter or member 'pci_dev' not described in 'genwqe_remove' drivers/misc/genwqe/card_base.c:1336: warning: Function parameter or member 'dev' not described in 'genwqe_devnode' drivers/misc/genwqe/card_base.c:1336: warning: Function parameter or member 'mode' not described in 'genwqe_devnode' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones Signed-off-by: Frank Haverkamp --- drivers/misc/genwqe/card_base.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index 809a6f46f6de3..93d2ed91c85b2 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -165,6 +165,7 @@ static void genwqe_dev_free(struct genwqe_dev *cd) /** * genwqe_bus_reset() - Card recovery + * @cd: GenWQE device information * * pci_reset_function() will recover the device and ensure that the * registers are accessible again when it completes with success. If @@ -262,6 +263,7 @@ static void genwqe_tweak_hardware(struct genwqe_dev *cd) /** * genwqe_recovery_on_fatal_gfir_required() - Version depended actions + * @cd: GenWQE device information * * Bitstreams older than 2013-02-17 have a bug where fatal GFIRs must * be ignored. This is e.g. true for the bitstream we gave to the card @@ -280,6 +282,7 @@ int genwqe_flash_readback_fails(struct genwqe_dev *cd) /** * genwqe_T_psec() - Calculate PF/VF timeout register content + * @cd: GenWQE device information * * Note: From a design perspective it turned out to be a bad idea to * use codes here to specifiy the frequency/speed values. An old @@ -303,6 +306,7 @@ static int genwqe_T_psec(struct genwqe_dev *cd) /** * genwqe_setup_pf_jtimer() - Setup PF hardware timeouts for DDCB execution + * @cd: GenWQE device information * * Do this _after_ card_reset() is called. Otherwise the values will * vanish. The settings need to be done when the queues are inactive. @@ -329,6 +333,7 @@ static bool genwqe_setup_pf_jtimer(struct genwqe_dev *cd) /** * genwqe_setup_vf_jtimer() - Setup VF hardware timeouts for DDCB execution + * @cd: GenWQE device information */ static bool genwqe_setup_vf_jtimer(struct genwqe_dev *cd) { @@ -543,6 +548,7 @@ static int genwqe_start(struct genwqe_dev *cd) /** * genwqe_stop() - Stop card operation + * @cd: GenWQE device information * * Recovery notes: * As long as genwqe_thread runs we might access registers during @@ -606,6 +612,7 @@ static int genwqe_health_check_cond(struct genwqe_dev *cd, u64 *gfir) /** * genwqe_fir_checking() - Check the fault isolation registers of the card + * @cd: GenWQE device information * * If this code works ok, can be tried out with help of the genwqe_poke tool: * sudo ./tools/genwqe_poke 0x8 0xfefefefefef @@ -750,6 +757,7 @@ static u64 genwqe_fir_checking(struct genwqe_dev *cd) /** * genwqe_pci_fundamental_reset() - trigger a PCIe fundamental reset on the slot + * @pci_dev: PCI device information struct * * Note: pci_set_pcie_reset_state() is not implemented on all archs, so this * reset method will not work in all cases. @@ -814,8 +822,9 @@ static int genwqe_platform_recovery(struct genwqe_dev *cd) return rc; } -/* +/** * genwqe_reload_bistream() - reload card bitstream + * @cd: GenWQE device information * * Set the appropriate register and call fundamental reset to reaload the card * bitstream. @@ -868,6 +877,7 @@ static int genwqe_reload_bistream(struct genwqe_dev *cd) /** * genwqe_health_thread() - Health checking thread + * @data: GenWQE device information * * This thread is only started for the PF of the card. * @@ -1041,6 +1051,7 @@ static int genwqe_health_check_stop(struct genwqe_dev *cd) /** * genwqe_pci_setup() - Allocate PCIe related resources for our card + * @cd: GenWQE device information */ static int genwqe_pci_setup(struct genwqe_dev *cd) { @@ -1126,6 +1137,7 @@ static int genwqe_pci_setup(struct genwqe_dev *cd) /** * genwqe_pci_remove() - Free PCIe related resources for our card + * @cd: GenWQE device information */ static void genwqe_pci_remove(struct genwqe_dev *cd) { @@ -1140,7 +1152,8 @@ static void genwqe_pci_remove(struct genwqe_dev *cd) /** * genwqe_probe() - Device initialization - * @pdev: PCI device information struct + * @pci_dev: PCI device information struct + * @id: PCI device ID * * Callable for multiple cards. This function is called on bind. * @@ -1200,6 +1213,7 @@ static int genwqe_probe(struct pci_dev *pci_dev, /** * genwqe_remove() - Called when device is removed (hot-plugable) + * @pci_dev: PCI device information struct * * Or when driver is unloaded respecitively when unbind is done. */ @@ -1219,8 +1233,10 @@ static void genwqe_remove(struct pci_dev *pci_dev) genwqe_dev_free(cd); } -/* +/** * genwqe_err_error_detected() - Error detection callback + * @pci_dev: PCI device information struct + * @state: PCI channel state * * This callback is called by the PCI subsystem whenever a PCI bus * error is detected. @@ -1328,6 +1344,8 @@ static struct pci_driver genwqe_driver = { /** * genwqe_devnode() - Set default access mode for genwqe devices. + * @dev: Pointer to device (unused) + * @mode: Carrier to pass-back given mode (permissions) * * Default mode should be rw for everybody. Do not change default * device name. From patchwork Mon Jun 29 14:04:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631015 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C046092A for ; Mon, 29 Jun 2020 14:09:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9794823D98 for ; Mon, 29 Jun 2020 14:09:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cTwJQpMn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zB7LyQxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9794823D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n4y52iFxzH6ekHowhhJt1tG+UjHwNkTGVcJGkIWhObY=; b=cTwJQpMn2q1BmyPHucxtuKhXz Ovag4K2OmqHc3KBXIiDZeyKcgceRLFIEh1KzDGCmtBHuJH+F542FbCGxsI11j7RB074qWGQxJ86/W a4q/R1zh55qFmo4VfEf7v6U6vxC7LRV9SAi8vpIR30QMQ8I/MdF9mf9t5G/2OBK1d35I4gmn++Kxy 5tX9tHBqAXMbgU/jyczk1MAkEqwT6J+UnGMwSutV0Jru/pWJfKNFSM8YSqkZtLZVVnq0Z8RuJ9uE+ UH1Y8BiLxmlaJ+h8rZlMogdLR9nR8QZfrmKmOmwEFV/8ofeK/SfzStOAxCrFB6x9cXusKo42MP/ou Kbupm7Atw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuRT-0005Sz-HO; Mon, 29 Jun 2020 14:07:27 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPG-0004IH-64 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:13 +0000 Received: by mail-wr1-x441.google.com with SMTP id f7so13687127wrw.1 for ; Mon, 29 Jun 2020 07:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vqNBDouTK8PphAMbImg0Rb2dZabHhQnfuFaJhvwhGMc=; b=zB7LyQxQm5VAV564JDk+hIRS+rFVYoTLn+2odNt5cJA2OZCbVqBV6/ojoVy8kbcd6N phRRRw4efeVbgdvzOAHc7Vp8J7CyxV7EwSvlFDHqv39hIagaRpuRPzMgyZIGD+rVyGtm rqPBZ93NHBdfB8QdPg5miFgYKJUz2jPE7zqJfIntxdxqOaTSi+rzbDT5JgVWV1PbexWN L0ucbbcLk9vWrLWAql7k+X8bPBnp5pHFUNpsdNAIbBqIXftZ6RPDIw8GQYVtbMZWFDoc 0R/I6TfjId5f32mbIN48VzhDo6icVIW630KZEgN5er9lBK4VbRbfznr4OoushIRloORH Xxqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vqNBDouTK8PphAMbImg0Rb2dZabHhQnfuFaJhvwhGMc=; b=B7H0eiwUsApneb/jTMkeNYqSItRsFhD/eBBx8+prEi6BSY43z9mquYy+7eGD7229UT tMpfP9cYzR6KLaxXFOFBjWWqD/LVDFptYCgoB0sYaqc4l4AvzFeKLyFd/Zs+uDRJUHMs vFHuhNkvSQVDWtZIrwETaO66wnV1K/iBmzbKhXMumS1Vo2ZvDYe7GFz95ptsmQtJ/eEr LrkfbMiZXd5hDHrB9Y++fZUnHp87TfioaWONoTuPUtJLU8nOxEtP898zvrxFR/gbxj7y hSLjReMTk+QhrzdZMDRl6Tf4H4Y2PXja49Y5jhnw7njRj4q1eHaCh1QNzzh+8neTS+cG Vkgg== X-Gm-Message-State: AOAM533dgq9sLNmOn7BTLxVV4EXMHWuBjK7ACRZkOQuQX2kmo9DgaMVA V85Lr/sL33e/IEvus24GZRcgrA== X-Google-Smtp-Source: ABdhPJxwXHImUgT4Ji8ujROEtLVQiDyh2r8H5CowRBsagghC0NtuoezWsUvt7hSsxqBQ3E7UkwNxYg== X-Received: by 2002:a5d:650e:: with SMTP id x14mr18020746wru.187.1593439509213; Mon, 29 Jun 2020 07:05:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:08 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 19/20] misc: genwqe: card_dev: Whole host of kerneldoc fixes Date: Mon, 29 Jun 2020 15:04:41 +0100 Message-Id: <20200629140442.1043957-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Including; add missing documentation for function arguments, re-ordering of #defines i.e. not placed between kerneldoc headers and the functions they are documenting, demotion of file header/comment from kerneldoc format and removal of documentation for non-existent args. Fixes the following W=1 kernel build warnings: drivers/misc/genwqe/card_dev.c:33: warning: Function parameter or member 'cd' not described in 'genwqe_open_files' drivers/misc/genwqe/card_dev.c:98: warning: Function parameter or member 'virt_addr' not described in 'genwqe_search_pin' drivers/misc/genwqe/card_dev.c:98: warning: Excess function parameter 'dma_addr' description in 'genwqe_search_pin' drivers/misc/genwqe/card_dev.c:154: warning: Function parameter or member 'virt_addr' not described in '__genwqe_search_mapping' drivers/misc/genwqe/card_dev.c:256: warning: Function parameter or member 'cd' not described in 'genwqe_kill_fasync' drivers/misc/genwqe/card_dev.c:256: warning: Function parameter or member 'sig' not described in 'genwqe_kill_fasync' drivers/misc/genwqe/card_dev.c:387: warning: Function parameter or member 'vma' not described in 'genwqe_vma_close' drivers/misc/genwqe/card_dev.c:430: warning: Function parameter or member 'filp' not described in 'genwqe_mmap' drivers/misc/genwqe/card_dev.c:430: warning: Function parameter or member 'vma' not described in 'genwqe_mmap' drivers/misc/genwqe/card_dev.c:495: warning: Excess function parameter 'cd' description in 'FLASH_BLOCK' drivers/misc/genwqe/card_dev.c:495: warning: Excess function parameter 'load' description in 'FLASH_BLOCK' drivers/misc/genwqe/card_dev.c:827: warning: Function parameter or member 'cfile' not described in 'ddcb_cmd_cleanup' drivers/misc/genwqe/card_dev.c:827: warning: Function parameter or member 'req' not described in 'ddcb_cmd_cleanup' drivers/misc/genwqe/card_dev.c:854: warning: Function parameter or member 'cfile' not described in 'ddcb_cmd_fixups' drivers/misc/genwqe/card_dev.c:854: warning: Function parameter or member 'req' not described in 'ddcb_cmd_fixups' drivers/misc/genwqe/card_dev.c:984: warning: Function parameter or member 'cfile' not described in 'genwqe_execute_ddcb' drivers/misc/genwqe/card_dev.c:984: warning: Function parameter or member 'cmd' not described in 'genwqe_execute_ddcb' drivers/misc/genwqe/card_dev.c:1350: warning: Function parameter or member 'cd' not described in 'genwqe_device_remove' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones Signed-off-by: Frank Haverkamp --- drivers/misc/genwqe/card_dev.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/misc/genwqe/card_dev.c b/drivers/misc/genwqe/card_dev.c index 040a0bda31254..55fc5b80e649f 100644 --- a/drivers/misc/genwqe/card_dev.c +++ b/drivers/misc/genwqe/card_dev.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 @@ -87,7 +87,7 @@ static int genwqe_del_pin(struct genwqe_file *cfile, struct dma_mapping *m) * @cfile: Descriptor of opened file * @u_addr: User virtual address * @size: Size of buffer - * @dma_addr: DMA address to be updated + * @virt_addr: Virtual address to be updated * * Return: Pointer to the corresponding mapping NULL if not found */ @@ -144,6 +144,7 @@ static void __genwqe_del_mapping(struct genwqe_file *cfile, * @u_addr: user virtual address * @size: size of buffer * @dma_addr: DMA address to be updated + * @virt_addr: Virtual address to be updated * Return: Pointer to the corresponding mapping NULL if not found */ static struct dma_mapping *__genwqe_search_mapping(struct genwqe_file *cfile, @@ -249,6 +250,8 @@ static void genwqe_remove_pinnings(struct genwqe_file *cfile) /** * genwqe_kill_fasync() - Send signal to all processes with open GenWQE files + * @cd: GenWQE device information + * @sig: Signal to send out * * E.g. genwqe_send_signal(cd, SIGIO); */ @@ -380,6 +383,7 @@ static void genwqe_vma_open(struct vm_area_struct *vma) /** * genwqe_vma_close() - Called each time when vma is unmapped + * @vma: VMA area to close * * Free memory which got allocated by GenWQE mmap(). */ @@ -416,6 +420,8 @@ static const struct vm_operations_struct genwqe_vma_ops = { /** * genwqe_mmap() - Provide contignous buffers to userspace + * @filp: File pointer (unused) + * @vma: VMA area to map * * We use mmap() to allocate contignous buffers used for DMA * transfers. After the buffer is allocated we remap it to user-space @@ -484,16 +490,15 @@ static int genwqe_mmap(struct file *filp, struct vm_area_struct *vma) return rc; } +#define FLASH_BLOCK 0x40000 /* we use 256k blocks */ + /** * do_flash_update() - Excute flash update (write image or CVPD) - * @cd: genwqe device + * @cfile: Descriptor of opened file * @load: details about image load * * Return: 0 if successful */ - -#define FLASH_BLOCK 0x40000 /* we use 256k blocks */ - static int do_flash_update(struct genwqe_file *cfile, struct genwqe_bitstream *load) { @@ -820,6 +825,8 @@ static int genwqe_unpin_mem(struct genwqe_file *cfile, struct genwqe_mem *m) /** * ddcb_cmd_cleanup() - Remove dynamically created fixup entries + * @cfile: Descriptor of opened file + * @req: DDCB work request * * Only if there are any. Pinnings are not removed. */ @@ -844,6 +851,8 @@ static int ddcb_cmd_cleanup(struct genwqe_file *cfile, struct ddcb_requ *req) /** * ddcb_cmd_fixups() - Establish DMA fixups/sglists for user memory references + * @cfile: Descriptor of opened file + * @req: DDCB work request * * Before the DDCB gets executed we need to handle the fixups. We * replace the user-space addresses with DMA addresses or do @@ -974,6 +983,8 @@ static int ddcb_cmd_fixups(struct genwqe_file *cfile, struct ddcb_requ *req) /** * genwqe_execute_ddcb() - Execute DDCB using userspace address fixups + * @cfile: Descriptor of opened file + * @cmd: Command identifier (passed from user) * * The code will build up the translation tables or lookup the * contignous memory allocation table to find the right translations @@ -1339,6 +1350,7 @@ static int genwqe_inform_and_stop_processes(struct genwqe_dev *cd) /** * genwqe_device_remove() - Remove genwqe's char device + * @cd: GenWQE device information * * This function must be called after the client devices are removed * because it will free the major/minor number range for the genwqe From patchwork Mon Jun 29 14:04:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11631021 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 165F0912 for ; Mon, 29 Jun 2020 14:10:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81D3A23D98 for ; Mon, 29 Jun 2020 14:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2SVA4DJS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="faYbDJZZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81D3A23D98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y6gwW6JXW7/x1wCA8JtUdHPJPepI2SaiN625/HEVPJ8=; b=2SVA4DJSczBHlDCq+hkdd1mqh 4W7rGeumS3MyhkyQDLuce5+7UA8ZmGHzZ1rbGuq+9WLZRGetqLjEbj+gpSIRzOoWXYGmf5US0sXea oSxSou/gc4hoAPC3gLZhjYBfRMbXhRirV4Piujav5jfL66ZYCD/R+hYzR4bFRFFW1lRHperPNO9po A3ep4oHVfXw1WbMP/sS8+R76PdjAckzltZ5+/5NTSfXPSzKej/zQPcFcy3drDc46PZsRKH+26oVyT UJB+c3zvzDWL9siy28twYxcNY3EXFdqAt5B9xTVMo35BySPM0sh+Sy+db+y5SOizNs44wzJJfSBNM Ta69w81RQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuSD-0005xs-Dg; Mon, 29 Jun 2020 14:08:13 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuPH-0004If-MR for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 14:05:15 +0000 Received: by mail-wr1-x442.google.com with SMTP id a6so16689119wrm.4 for ; Mon, 29 Jun 2020 07:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L35hXwGJYWdFNYEqvYo8VWLeKGQ8JU/sfeVxKoFGLpc=; b=faYbDJZZ9JpfMImGBJzoscendZhfvHpM47CPMRR4jSzOeOEei37aq3S7hRFnCXYwSV Zb755P0uqqSdADz/4FkfjIBjJP1WuRcNIuw9KeFK9QqNK0Ful+iEYhl0g1O1AAz6tSBR KzpEwa/0OaX2TP6s2bOY7N9Rvko5LmWtAZMhdiPqQe10JwAo80y0n7Jmv+aLL2l6/kC+ WKEO6/EjP2mFqCm1PD6WYrl5AQINA+OHgXc5ScW2P1nehzakjMt2A151p8FZQNOz3+fy 0lW1dznXS2BYhYDzM9/wMTH8jDxTaTx1F+2EScbbimKzD0vRtEliKh+6FfNMGRa88xeY yUMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L35hXwGJYWdFNYEqvYo8VWLeKGQ8JU/sfeVxKoFGLpc=; b=CMZDo4HaDQlKvkS30HFsfsgwKNpxfNoG1ZV8qaqjVm7YWXXqlmctSn+dqVnE3trtBg 2zt7DIcHbrl/31NPDA+CJ6SZDWmqf4wi/kzWyRx6x9l9S8lZhjn2TjFr2bFYhfmyUvM0 EUssv/I6+zqCtMeV/XnG8EW+0mf+BYzSqNiFuiQMlILCcWq9aJ8cQuD61E4402OYbLX9 6AytzANO5eqa8PaGOSu4r8rbtBqKMOFDQa/FZqUvsIIHjGiNsDwPpxHs1Qj/3zMDi+vl nz+sJkylA/M0kx4nEjMADK/th4wZzXQwi4XHqhIkiQwDqAtAH9biIP668DTwNYWx7R+I cHwg== X-Gm-Message-State: AOAM531V4xQd/DYQSAxLJpRAjnKVkWahdtyxQTXMsc4tfLabrt0E8wJK EyWHJ5CVHUFbXpG6qbCTJ360Gw== X-Google-Smtp-Source: ABdhPJxjuhlvdoJM+CJIODgeu/TfKjRtqBLpoYlSycTPURSj2Y1LRCuoFybaejKcg5Z1rr5Wh5o1/A== X-Received: by 2002:a5d:4c82:: with SMTP id z2mr16302472wrs.287.1593439510514; Mon, 29 Jun 2020 07:05:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id p14sm15394928wrj.14.2020.06.29.07.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 07:05:09 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 20/20] misc: genwqe: card_utils: Whole a plethora of documentation issues Date: Mon, 29 Jun 2020 15:04:42 +0100 Message-Id: <20200629140442.1043957-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629140442.1043957-1-lee.jones@linaro.org> References: <20200629140442.1043957-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Including; demoting file header from kerneldoc to standard comment/ header, adding a variety of missing function argument documentation, repairing formatting (kerneldoc does not like blank lines) and the demotion of a kerneldoc header which shows no interest in providing documentation for any of its arguments. Fixes this the following W=1 issues: drivers/misc/genwqe/card_utils.c:37: warning: Incorrect use of kernel-doc format: * __genwqe_writeq() - Write 64-bit register drivers/misc/genwqe/card_utils.c:45: warning: Function parameter or member 'cd' not described in '__genwqe_writeq' drivers/misc/genwqe/card_utils.c:45: warning: Function parameter or member 'byte_offs' not described in '__genwqe_writeq' drivers/misc/genwqe/card_utils.c:45: warning: Function parameter or member 'val' not described in '__genwqe_writeq' drivers/misc/genwqe/card_utils.c:136: warning: Function parameter or member 'cd' not described in 'genwqe_read_app_id' drivers/misc/genwqe/card_utils.c:136: warning: Function parameter or member 'app_name' not described in 'genwqe_read_app_id' drivers/misc/genwqe/card_utils.c:136: warning: Function parameter or member 'len' not described in 'genwqe_read_app_id' drivers/misc/genwqe/card_utils.c:186: warning: bad line: drivers/misc/genwqe/card_utils.c:290: warning: Function parameter or member 'cd' not described in 'genwqe_alloc_sync_sgl' drivers/misc/genwqe/card_utils.c:290: warning: Function parameter or member 'sgl' not described in 'genwqe_alloc_sync_sgl' drivers/misc/genwqe/card_utils.c:290: warning: Function parameter or member 'user_addr' not described in 'genwqe_alloc_sync_sgl' drivers/misc/genwqe/card_utils.c:290: warning: Function parameter or member 'user_size' not described in 'genwqe_alloc_sync_sgl' drivers/misc/genwqe/card_utils.c:290: warning: Function parameter or member 'write' not described in 'genwqe_alloc_sync_sgl' drivers/misc/genwqe/card_utils.c:469: warning: Function parameter or member 'cd' not described in 'genwqe_free_sync_sgl' drivers/misc/genwqe/card_utils.c:469: warning: Function parameter or member 'sgl' not described in 'genwqe_free_sync_sgl' drivers/misc/genwqe/card_utils.c:716: warning: Function parameter or member 'count' not described in 'genwqe_set_interrupt_capability' drivers/misc/genwqe/card_utils.c:747: warning: Function parameter or member 'idx' not described in 'set_reg_idx' drivers/misc/genwqe/card_utils.c:747: warning: Excess function parameter 'index' description in 'set_reg_idx' drivers/misc/genwqe/card_utils.c:823: warning: Function parameter or member 'cd' not described in 'genwqe_ffdc_buff_size' drivers/misc/genwqe/card_utils.c:823: warning: Function parameter or member 'uid' not described in 'genwqe_ffdc_buff_size' drivers/misc/genwqe/card_utils.c:877: warning: Function parameter or member 'cd' not described in 'genwqe_ffdc_buff_read' drivers/misc/genwqe/card_utils.c:877: warning: Function parameter or member 'uid' not described in 'genwqe_ffdc_buff_read' drivers/misc/genwqe/card_utils.c:877: warning: Function parameter or member 'regs' not described in 'genwqe_ffdc_buff_read' drivers/misc/genwqe/card_utils.c:877: warning: Function parameter or member 'max_regs' not described in 'genwqe_ffdc_buff_read' drivers/misc/genwqe/card_utils.c:964: warning: Function parameter or member 'cd' not described in 'genwqe_write_vreg' drivers/misc/genwqe/card_utils.c:964: warning: Function parameter or member 'reg' not described in 'genwqe_write_vreg' drivers/misc/genwqe/card_utils.c:964: warning: Function parameter or member 'val' not described in 'genwqe_write_vreg' drivers/misc/genwqe/card_utils.c:964: warning: Function parameter or member 'func' not described in 'genwqe_write_vreg' drivers/misc/genwqe/card_utils.c:977: warning: Function parameter or member 'cd' not described in 'genwqe_read_vreg' drivers/misc/genwqe/card_utils.c:977: warning: Function parameter or member 'reg' not described in 'genwqe_read_vreg' drivers/misc/genwqe/card_utils.c:977: warning: Function parameter or member 'func' not described in 'genwqe_read_vreg' drivers/misc/genwqe/card_utils.c:995: warning: Function parameter or member 'cd' not described in 'genwqe_base_clock_frequency' drivers/misc/genwqe/card_utils.c:1012: warning: Function parameter or member 'cd' not described in 'genwqe_stop_traps' drivers/misc/genwqe/card_utils.c:1022: warning: Function parameter or member 'cd' not described in 'genwqe_start_traps' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Mon Jun 29 10:30:56 2020 +0100 # # On branch tb-mfd-fix-warnings # Changes to be committed: # modified: drivers/misc/genwqe/card_utils.c # # Untracked files: # qemu-i2c-devs.txt # Signed-off-by: Frank Haverkamp --- drivers/misc/genwqe/card_utils.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c index 77c21caf2acd1..039b923d1d60a 100644 --- a/drivers/misc/genwqe/card_utils.c +++ b/drivers/misc/genwqe/card_utils.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 @@ -129,6 +129,9 @@ u32 __genwqe_readl(struct genwqe_dev *cd, u64 byte_offs) /** * genwqe_read_app_id() - Extract app_id + * @cd: genwqe device descriptor + * @app_name: carrier used to pass-back name + * @len: length of data for name * * app_unitcfg need to be filled with valid data first */ @@ -183,7 +186,7 @@ void genwqe_init_crc32(void) * @init: initial crc (0xffffffff at start) * * polynomial = x^32 * + x^29 + x^18 + x^14 + x^3 + 1 (0x20044009) - + * * Example: 4 bytes 0x01 0x02 0x03 0x04 with init=0xffffffff should * result in a crc32 of 0xf33cb7d3. * @@ -277,7 +280,7 @@ static int genwqe_sgl_size(int num_pages) return roundup(len, PAGE_SIZE); } -/** +/* * genwqe_alloc_sync_sgl() - Allocate memory for sgl and overlapping pages * * Allocates memory for sgl and overlapping pages. Pages which might @@ -460,6 +463,8 @@ int genwqe_setup_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl, /** * genwqe_free_sync_sgl() - Free memory for sgl and overlapping pages + * @cd: genwqe device descriptor + * @sgl: scatter gather list describing user-space memory * * After the DMA transfer has been completed we free the memory for * the sgl and the cached pages. Data is being transferred from cached @@ -710,6 +715,7 @@ int genwqe_read_softreset(struct genwqe_dev *cd) /** * genwqe_set_interrupt_capability() - Configure MSI capability structure * @cd: pointer to the device + * @count: number of vectors to allocate * Return: 0 if no error */ int genwqe_set_interrupt_capability(struct genwqe_dev *cd, int count) @@ -738,7 +744,7 @@ void genwqe_reset_interrupt_capability(struct genwqe_dev *cd) * @i: index to desired entry * @m: maximum possible entries * @addr: addr which is read - * @index: index in debug array + * @idx: index in debug array * @val: read value */ static int set_reg_idx(struct genwqe_dev *cd, struct genwqe_reg *r, @@ -818,6 +824,8 @@ int genwqe_read_ffdc_regs(struct genwqe_dev *cd, struct genwqe_reg *regs, /** * genwqe_ffdc_buff_size() - Calculates the number of dump registers + * @cd: genwqe device descriptor + * @uid: unit ID */ int genwqe_ffdc_buff_size(struct genwqe_dev *cd, int uid) { @@ -871,6 +879,10 @@ int genwqe_ffdc_buff_size(struct genwqe_dev *cd, int uid) /** * genwqe_ffdc_buff_read() - Implements LogoutExtendedErrorRegisters procedure + * @cd: genwqe device descriptor + * @uid: unit ID + * @regs: register information + * @max_regs: number of register entries */ int genwqe_ffdc_buff_read(struct genwqe_dev *cd, int uid, struct genwqe_reg *regs, unsigned int max_regs) @@ -956,6 +968,10 @@ int genwqe_ffdc_buff_read(struct genwqe_dev *cd, int uid, /** * genwqe_write_vreg() - Write register in virtual window + * @cd: genwqe device descriptor + * @reg: register (byte) offset within BAR + * @val: value to write + * @func: PCI virtual function * * Note, these registers are only accessible to the PF through the * VF-window. It is not intended for the VF to access. @@ -969,6 +985,9 @@ int genwqe_write_vreg(struct genwqe_dev *cd, u32 reg, u64 val, int func) /** * genwqe_read_vreg() - Read register in virtual window + * @cd: genwqe device descriptor + * @reg: register (byte) offset within BAR + * @func: PCI virtual function * * Note, these registers are only accessible to the PF through the * VF-window. It is not intended for the VF to access. @@ -981,6 +1000,7 @@ u64 genwqe_read_vreg(struct genwqe_dev *cd, u32 reg, int func) /** * genwqe_base_clock_frequency() - Deteremine base clock frequency of the card + * @cd: genwqe device descriptor * * Note: From a design perspective it turned out to be a bad idea to * use codes here to specifiy the frequency/speed values. An old @@ -1005,6 +1025,7 @@ int genwqe_base_clock_frequency(struct genwqe_dev *cd) /** * genwqe_stop_traps() - Stop traps + * @cd: genwqe device descriptor * * Before reading out the analysis data, we need to stop the traps. */ @@ -1015,6 +1036,7 @@ void genwqe_stop_traps(struct genwqe_dev *cd) /** * genwqe_start_traps() - Start traps + * @cd: genwqe device descriptor * * After having read the data, we can/must enable the traps again. */