From patchwork Tue Jun 30 13:50:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634027 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ACBD1912 for ; Tue, 30 Jun 2020 13:53:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85D61206BE for ; Tue, 30 Jun 2020 13:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PX8pLEG8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HmuUR+42" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D61206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S/6rLrMIpWl6DjbZRMxYbn4q+Ab76Rej3xw2reG9aW0=; b=PX8pLEG8eLbwsBZw4nUqDwNBF yPNPEEj+LySnccvPffa7xPbQ5FIjbeBxpgZv7WuR3p2crU0BRItfzNyb2/tLooZG0vKfwobgYVpAY LN90F9XPC1bhKZFvOoakGeSHrGDKBV6q22HbPnTuzyNSZA298++OrJKvBnd5+Xp5HZLBEuRVivln/ 4LFgReEucp8L/D6WiIi3K35l6JYuEbMS3SBR1+3DhW5wrce/N3jC5+r4yNUhqhL1xv524c6GwZpcp JfihoaGbs1Wd+ODUBhKrAKykUXM1MBXXTUfhaf8Y18lW4qQLVK7bCrMf8BPFf6e46eyXUKAOhR4Kw 2qTo8OZgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfQ-0001Bv-Vq; Tue, 30 Jun 2020 13:51:21 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfK-0001Ap-N2 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:15 +0000 Received: by mail-wr1-x441.google.com with SMTP id f18so12218316wrs.0 for ; Tue, 30 Jun 2020 06:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1tAsKayZdJ/bssiKZaLewML1qJ1Qy+lK1MBLKE8UREg=; b=HmuUR+42Bn4cTBDsI05lTD2ybzQaTZdf85wQG+9YuVjwQPKeeP1tNYCTEcHXqTrEEM T4z+jbv5tiNasZ6KmWnhlPG3QrEUrk/mMnYUOJsCJr6zrIDphWWO6uLDw76IRRzJVXc4 TLUyYMKT9neCKXZ+YO+leUiN+5MszBevEmTVS2AyFbJmk7XkV+VbUU3NKN2vGSdQ+ROA 4Lq+q5YSoYDj7Bda8DG5nn8T2TEXTgAqloWvajJ3guqnQBP5KTjMZi+BBUENM/oLgqox R9HTq7j3jdyvH478RgakzrBZVsYX3BX+2508Ti/I99uQAOYeoJdK4AM8Dlgn5m+Ws9vn omBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1tAsKayZdJ/bssiKZaLewML1qJ1Qy+lK1MBLKE8UREg=; b=uZBlTVvxZGCimJ39d1SJ+AyMIQPL7aYozm7WPOVYDXhScw/A+zWHmRuuf5cQ+vt2J3 QWfRi5b2UYCqzNwLbXMOIiNxifrV0KyRsuw4AGsY3/L6PkB/xOqvkSS1WOgj3b+NOZcq Mbz0jrhr+/U1wN9oTc7P/7P+vZ6CsCkfbMIzst3rgRBElmnsqdjXG/i2mg0xZp9M0GWn DpBZlw8B8WxqJU/RBWaOaR1zX+FTxpMwqg/QyrHoZqR7BH0fbEoXgUFhc9rlKxQl6of4 OmvaEp9Vv2SHl3mY+dPjfXiJmMxUeui8XddIMMHL5ey2l/wDpwwQVGHdlZrmYh7G96KG p8QQ== X-Gm-Message-State: AOAM532eaUGRzC1fKZX30teXWjEDc2grXIbPzNTT7W7527PRMvk50EMX LPL0+EYLMFEvmlJLk2c1v7gkjQ== X-Google-Smtp-Source: ABdhPJxIo7/ko+Ybgyw1T84vSapma04jKlDgzkG2BjzAzen18pjnBD0YX9WF7hVrDcmqSZnly+BvqQ== X-Received: by 2002:adf:db4d:: with SMTP id f13mr21658826wrj.336.1593525073582; Tue, 30 Jun 2020 06:51:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:13 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 01/30] misc: genwqe: card_ddcb: Fix a variety of kerneldoc issues Date: Tue, 30 Jun 2020 14:50:41 +0100 Message-Id: <20200630135110.2236389-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Including; demoting file header from kerneldoc to standard comment/ header, adding a variety of missing function argument documentation, re-ordering of #defines i.e. not placed between kerneldoc headers and the functions they are documenting and re-documenting of changed/ renamed arguments. Fixes the following W=1 kernel build warnings: drivers/misc/genwqe/card_ddcb.c:83: warning: Function parameter or member 'queue' not described in 'queue_empty' drivers/misc/genwqe/card_ddcb.c:262: warning: Excess function parameter 'cd' description in 'RET_DDCB_APPENDED' drivers/misc/genwqe/card_ddcb.c:262: warning: Excess function parameter 'queue' description in 'RET_DDCB_APPENDED' drivers/misc/genwqe/card_ddcb.c:262: warning: Excess function parameter 'ddcb_no' description in 'RET_DDCB_APPENDED' drivers/misc/genwqe/card_ddcb.c:329: warning: Function parameter or member 'req' not described in 'copy_ddcb_results' drivers/misc/genwqe/card_ddcb.c:329: warning: Function parameter or member 'ddcb_no' not described in 'copy_ddcb_results' drivers/misc/genwqe/card_ddcb.c:364: warning: Function parameter or member 'queue' not described in 'genwqe_check_ddcb_queue' drivers/misc/genwqe/card_ddcb.c:565: warning: Function parameter or member 'queue' not described in 'get_next_ddcb' drivers/misc/genwqe/card_ddcb.c:565: warning: Function parameter or member 'num' not described in 'get_next_ddcb' drivers/misc/genwqe/card_ddcb.c:909: warning: Function parameter or member 'cmd' not described in '__genwqe_execute_raw_ddcb' drivers/misc/genwqe/card_ddcb.c:909: warning: Excess function parameter 'req' description in '__genwqe_execute_raw_ddcb' drivers/misc/genwqe/card_ddcb.c:972: warning: Function parameter or member 'cd' not described in 'genwqe_next_ddcb_ready' drivers/misc/genwqe/card_ddcb.c:1002: warning: Function parameter or member 'cd' not described in 'genwqe_ddcbs_in_flight' drivers/misc/genwqe/card_ddcb.c:1181: warning: Function parameter or member 'data' not described in 'genwqe_card_thread' drivers/misc/genwqe/card_ddcb.c:1308: warning: Function parameter or member 'cd' not described in 'queue_wake_up_all' drivers/misc/genwqe/card_ddcb.c:1333: warning: Function parameter or member 'cd' not described in 'genwqe_finish_queue' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones --- drivers/misc/genwqe/card_ddcb.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c index 905106579935a..0db4000dedf20 100644 --- a/drivers/misc/genwqe/card_ddcb.c +++ b/drivers/misc/genwqe/card_ddcb.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 @@ -244,10 +244,13 @@ static int ddcb_requ_finished(struct genwqe_dev *cd, struct ddcb_requ *req) (cd->card_state != GENWQE_CARD_USED); } +#define RET_DDCB_APPENDED 1 +#define RET_DDCB_TAPPED 2 /** * enqueue_ddcb() - Enqueue a DDCB * @cd: pointer to genwqe device descriptor * @queue: queue this operation should be done on + * @pddcb: pointer to ddcb structure * @ddcb_no: pointer to ddcb number being tapped * * Start execution of DDCB by tapping or append to queue via NEXT @@ -259,9 +262,6 @@ static int ddcb_requ_finished(struct genwqe_dev *cd, struct ddcb_requ *req) * Return: 1 if new DDCB is appended to previous * 2 if DDCB queue is tapped via register/simulation */ -#define RET_DDCB_APPENDED 1 -#define RET_DDCB_TAPPED 2 - static int enqueue_ddcb(struct genwqe_dev *cd, struct ddcb_queue *queue, struct ddcb *pddcb, int ddcb_no) { @@ -316,6 +316,8 @@ static int enqueue_ddcb(struct genwqe_dev *cd, struct ddcb_queue *queue, /** * copy_ddcb_results() - Copy output state from real DDCB to request + * @req: pointer to requsted DDCB parameters + * @ddcb_no: pointer to ddcb number being tapped * * Copy DDCB ASV to request struct. There is no endian * conversion made, since data structure in ASV is still @@ -356,6 +358,7 @@ static void copy_ddcb_results(struct ddcb_requ *req, int ddcb_no) /** * genwqe_check_ddcb_queue() - Checks DDCB queue for completed work equests. * @cd: pointer to genwqe device descriptor + * @queue: queue to be checked * * Return: Number of DDCBs which were finished */ @@ -553,6 +556,8 @@ int __genwqe_wait_ddcb(struct genwqe_dev *cd, struct ddcb_requ *req) /** * get_next_ddcb() - Get next available DDCB * @cd: pointer to genwqe device descriptor + * @queue: DDCB queue + * @num: internal DDCB number * * DDCB's content is completely cleared but presets for PRE and * SEQNUM. This function must only be called when ddcb_lock is held. @@ -900,7 +905,7 @@ int __genwqe_enqueue_ddcb(struct genwqe_dev *cd, struct ddcb_requ *req, /** * __genwqe_execute_raw_ddcb() - Setup and execute DDCB * @cd: pointer to genwqe device descriptor - * @req: user provided DDCB request + * @cmd: user provided DDCB command * @f_flags: file mode: blocking, non-blocking */ int __genwqe_execute_raw_ddcb(struct genwqe_dev *cd, @@ -965,6 +970,7 @@ int __genwqe_execute_raw_ddcb(struct genwqe_dev *cd, /** * genwqe_next_ddcb_ready() - Figure out if the next DDCB is already finished + * @cd: pointer to genwqe device descriptor * * We use this as condition for our wait-queue code. */ @@ -993,6 +999,7 @@ static int genwqe_next_ddcb_ready(struct genwqe_dev *cd) /** * genwqe_ddcbs_in_flight() - Check how many DDCBs are in flight + * @cd: pointer to genwqe device descriptor * * Keep track on the number of DDCBs which ware currently in the * queue. This is needed for statistics as well as conditon if we want @@ -1171,6 +1178,7 @@ static irqreturn_t genwqe_vf_isr(int irq, void *dev_id) /** * genwqe_card_thread() - Work thread for the DDCB queue + * @data: pointer to genwqe device descriptor * * The idea is to check if there are DDCBs in processing. If there are * some finished DDCBs, we process them and wakeup the @@ -1299,6 +1307,7 @@ int genwqe_setup_service_layer(struct genwqe_dev *cd) /** * queue_wake_up_all() - Handles fatal error case + * @cd: pointer to genwqe device descriptor * * The PCI device got unusable and we have to stop all pending * requests as fast as we can. The code after this must purge the @@ -1323,6 +1332,7 @@ static int queue_wake_up_all(struct genwqe_dev *cd) /** * genwqe_finish_queue() - Remove any genwqe devices and user-interfaces + * @cd: pointer to genwqe device descriptor * * Relies on the pre-condition that there are no users of the card * device anymore e.g. with open file-descriptors. From patchwork Tue Jun 30 13:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634029 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 90A7B912 for ; Tue, 30 Jun 2020 13:53:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6836620702 for ; Tue, 30 Jun 2020 13:53:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jkQfBYbc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYqNqpj4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6836620702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/oHCN5avlFi6duo0Z5zoYFiI5LvnKmdBF/iH9yIIx5c=; b=jkQfBYbcjXyjxfubpa3tZjWB4 P9xfwjjnm3kfkd2cXd/QKficZKRr3i3ipL/vDDuDNX3FdWJx93mJ/EFWO0RkTG2GNtZs7yikB2eIM aT966ZEwsSlS95vmwWSJHfBmMhukOgmthojZWUp3i0LeyY4FuVYfpBxEmtLSQcQdiguFxocHmkVt2 QPlu3fLVN2r+2vH6o3x+xA4zJNZ5RDk44B8dlf36bXqZOdPawLClNMVdTXv7yXgvJy8dJ0MoL1gd8 HscYXvL8bOs4w6GdSeZjiya+CcxB4frJ1U+4BOgNYlSj00pILt4Pt2IhXG6j4XkGTc9/TdckQecOf 8w2IF4x9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfU-0001Ca-66; Tue, 30 Jun 2020 13:51:24 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfM-0001B6-S4 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so18894576wmj.2 for ; Tue, 30 Jun 2020 06:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0JG9yfk7UsIlwDFN/XvWcoL4qtnzwNOpXg0C3Lo2gcU=; b=wYqNqpj46PQI5CQBcWLOeLqbE5yU0YKgbwQldUAM+2YLSOl0alIcjDAjWxXqItSLVF EjicKVJJSbpZ66Us/9K8NPC+lXTwZGycJQZ6n/WkAgH2KMP2mA0qgo11H8zKcSrJ7ra9 DEolk/J/4SdiODEWHl7mVjseYCplZJ7zPDnNUN0b+L6ZVGNz/NI50ZUYe9c/Lf+9Yknt syutilb7MUGTIeMxwtRle9iILSYmYLB2zUoCALw3NNmn0KcrBKoa5V6LegPNh+IWGY3X 0E/Scjq+fB9Ks/pJeviVQ9EFQ49uwRt0MF172acvJ6l+K3bNG4rMzS2aB0l1cIwn9qlb DBEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0JG9yfk7UsIlwDFN/XvWcoL4qtnzwNOpXg0C3Lo2gcU=; b=n5POH3Or+fUYtL6EQf+3gvz3ulHXEjUU8G4bgzqgufc1z4e12+fib038UMJ9wQ16D0 AwiyUluW2dIgMvHny2mfBB9MPymENvL3p9o8BMjNX5foWTj4UmN8S5PE2/rGd2+4MJIw SKKD2tOZSGqPCIVjClN0Z1UVtp7DUD1SNz3SEqJwbrkR16D5Kbxo1cx7SPLBMrOuHisg 9ygssJlUEtocCwPUE5kZ79fmRAMBLLRCLsSAQKuLiNw5cMry1RVsWjPQkCTY0bacmynI BVKg6dzqyQXScQJjfec9/Z4FgrPEFzvgVaDeF6OPbhbGrQFBtY9F3rnBdTLaP3sa4+hU bkFg== X-Gm-Message-State: AOAM530oB8fXF+26IjLlYpV2twZSjolbVYAcpmAaHTfN9vNfHeoU/sz3 gC/nmKRQI2eBPzbYdXblKuvnKw== X-Google-Smtp-Source: ABdhPJzinaVgXzm1+p8rUkcxU0U4zHaoc0tKkatJO/uvJ76C784lzkLQEsHBmfuew/F+rEeqz/RK9Q== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr22050588wmj.86.1593525075011; Tue, 30 Jun 2020 06:51:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:14 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 02/30] misc: genwqe: card_sysfs: Demote function/file headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:42 +0100 Message-Id: <20200630135110.2236389-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There has been no attempt to provide documentation for these function's arguments, so align with the remainder of the file and just treat them as standards function headers. Fixes the following W=1 kernel build warnings: drivers/misc/genwqe/card_sysfs.c:32: warning: cannot understand function prototype: 'const char * const genwqe_types[] = ' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'dev' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'attr' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'buf' not described in 'curr_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'dev' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'attr' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'buf' not described in 'next_bitstream_show' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'kobj' not described in 'genwqe_is_visible' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'attr' not described in 'genwqe_is_visible' drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'n' not described in 'genwqe_is_visible' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones --- drivers/misc/genwqe/card_sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/genwqe/card_sysfs.c b/drivers/misc/genwqe/card_sysfs.c index 28a3fb1533f70..b2f115602523a 100644 --- a/drivers/misc/genwqe/card_sysfs.c +++ b/drivers/misc/genwqe/card_sysfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 @@ -129,7 +129,7 @@ static ssize_t base_clock_show(struct device *dev, } static DEVICE_ATTR_RO(base_clock); -/** +/* * curr_bitstream_show() - Show the current bitstream id * * There is a bug in some old versions of the CPLD which selects the @@ -156,7 +156,7 @@ static ssize_t curr_bitstream_show(struct device *dev, } static DEVICE_ATTR_RO(curr_bitstream); -/** +/* * next_bitstream_show() - Show the next activated bitstream * * IO_SLC_CFGREG_SOFTRESET: This register can only be accessed by the PF. @@ -260,7 +260,7 @@ static struct attribute *genwqe_normal_attributes[] = { NULL, }; -/** +/* * genwqe_is_visible() - Determine if sysfs attribute should be visible or not * * VFs have restricted mmio capabilities, so not all sysfs entries From patchwork Tue Jun 30 13:50:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634023 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDBA4912 for ; Tue, 30 Jun 2020 13:53:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A764A206EB for ; Tue, 30 Jun 2020 13:53:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v6/uN0JM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C+CpJTIv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A764A206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DgahbVMDOPCrYrpzzUtOuoNRD8jP97TbFoBfMW7hyBk=; b=v6/uN0JMLWGgDvYIQVF1E+KDw vqmJqPDwDoTgUDIWFPmPt8Mfq2tNsteQocTteXXP5zFKnyE0t/cQCvtcU/bQHlfyHW2YgZCAoFl/l 6rqQhcp5t1F67aDqderCkUxeWmQo7nhcCnrzwHPVt9cv1YOMRHAwyoYxBOBNgC6Vth3Cfv9swtlUi c+QAbvfCyyK9pqGnPOv+KCitNNrQmR2ZC7lHzmQ/YzWUBA39mn0QUSutihF8NDQYgvMM/AYyb8vpi XVns9uSGnX0IKMGFZsYm59buetYsGxQvICyxwJsY5DhDOypienq07bcjERWfQsGZ3wSXCUM5g37gj K5Hk4kvpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfc-0001Ed-Su; Tue, 30 Jun 2020 13:51:32 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfO-0001BL-AP for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:19 +0000 Received: by mail-wm1-x341.google.com with SMTP id o8so18897090wmh.4 for ; Tue, 30 Jun 2020 06:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zQGzW5dI+CJY57UuhEAmK6g60SBrVTGRjgbtv0HdhAY=; b=C+CpJTIvfIGIs4cJkn37fTz6yt1tJ8g3S//jhOe0+456JFng7nB0mqqj4PGt32ZJmI tDRat8+PSlcWIaUohMmROjOMTqKh4o69i0aPGeGC9iaPmJ+VBQXjtN520xUgdFw5y1qe aTikfzaH5S4VZhoP5avaXsa5X8kDRaYiVfpd006TPFx/WvM9K2NyEZvO9YzZXLicmosA B8mxu0a+V+xCiDCGHBypcuNJravucfqU5ksMkrk81b2/2HNiMwr3FY3YGfteMIonfHqO 0R6A9YAmgrAiEUZXg/cc9bDUny/djVO3rZ8YazswKVTK8SPSO5nDB7TTJVc32ljzgPUw Wu4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zQGzW5dI+CJY57UuhEAmK6g60SBrVTGRjgbtv0HdhAY=; b=T+qYyW9NJAf+/asDWmSbmtx1m0cgP5yBDr8WGxrvQJnrfZVvn5eNfaUJNYVstj3+bC gbLNcTQJmYGD9JTlVbzpdPyB5JGKCMNdTMz15eRjeRO1ixVvbx2+p8CxOeZQXHMz4922 uJIHIxfLu3LFZzcHhc4vYzavhsCxpfW7GWJAcVPHAGXPNRsi/bVW8D5hls72n8o/JdZR sDe3+cY1WNwOS1NZi7HjyENe+/sv7sd8b8tV62PBwtvuMgDY2Im95pVSQKnQBlJNCvjP QnMq8g8en9e5+kZRxqcZ5ecqGohpAlH7Np551XhmlJUCvQQocACUYZMynn4ExCk9tZnP pcHA== X-Gm-Message-State: AOAM533bcgZNAFGnSy2NvmD5MlhbDygIGVpFBCPPhGdgeJCoDBd2idAs EDOppNeSxJosL/gbPog//rYWSw== X-Google-Smtp-Source: ABdhPJxt1DCJ8adnNm77NquA3B67xrt2gf/9+UcEnIXepE5IwsSQfNR369EHHBetezmvTIajmBYo9A== X-Received: by 2002:a1c:4804:: with SMTP id v4mr21508966wma.139.1593525077188; Tue, 30 Jun 2020 06:51:17 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:16 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 03/30] misc: genwqe: card_debugfs: Demote file header from kerneldoc Date: Tue, 30 Jun 2020 14:50:43 +0100 Message-Id: <20200630135110.2236389-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joerg-Stephan Vogt , Michael Ruettger , Frank Haverkamp , linux-kernel@vger.kernel.org, Michael Jung , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc does not understand file headers. There is therefor no reason for them to use the syntax. Fixes the following W=1 kernel build warnings: drivers/misc/genwqe/card_debugfs.c:30: warning: Function parameter or member 's' not described in 'dbg_uidn_show' drivers/misc/genwqe/card_debugfs.c:30: warning: Function parameter or member 'regs' not described in 'dbg_uidn_show' drivers/misc/genwqe/card_debugfs.c:30: warning: Function parameter or member 'entries' not described in 'dbg_uidn_show' Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones --- drivers/misc/genwqe/card_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/genwqe/card_debugfs.c b/drivers/misc/genwqe/card_debugfs.c index 1b5b82e652687..491fb4482da29 100644 --- a/drivers/misc/genwqe/card_debugfs.c +++ b/drivers/misc/genwqe/card_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * IBM Accelerator Family 'GenWQE' * * (C) Copyright IBM Corp. 2013 From patchwork Tue Jun 30 13:50:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634031 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D8207912 for ; Tue, 30 Jun 2020 13:53:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B14D920774 for ; Tue, 30 Jun 2020 13:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cbhTW+kV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hE2Pt8S5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B14D920774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mmp/zUTdo3xpPNrxiH4v/15eV/nxMGPnwY44c07jL1Q=; b=cbhTW+kVduRx9N0gTzoEDIoQy lEkuSyOJHhVBGe9AzHfP57+7eQrmGc8knlgo1i3v4pQJUXDOtt8v+gy9FFYeyMDP21DZ57A4Kyh5Y CMUADYNrJHwy7JEgcNfHj0Ey5bpYUSgUGiJpSFzgsQGEotJcW4yIC/GtX8z6pmD1BI5aIyOi8Jtkx M/NSz1MMIeE/+zRrV1HQe1mGeFR6Wu9ZZGWMgPCejiu6s+Iux4+JbDiVczmmfq1ij8gkpSQBlmmk+ RxLy3yplT8NtwI0I7N+aubcAE6MuOG1dxYG51JIPdWQiN+mWH0tg3i5HCeRRfokw0B+KHDzoRF3N1 ocdb84CwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGft-0001Kf-Iv; Tue, 30 Jun 2020 13:51:49 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfP-0001Bg-3d for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:20 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so16013096wmm.0 for ; Tue, 30 Jun 2020 06:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pdyAQzGUZDqA1eYmqwW6m9OLrHYQ+P2llVYkgd4FTX8=; b=hE2Pt8S5AwVId23lueZ+yGkCmFFu1fwqVco8jIyW78nKWJrFIXetTc/yR8eI75Qaii DZpmTa2uqeBD3NInvTdZwjioXVxtLMKc8X4u26l6uSI/75D1uyTpO025wnpR0iaZ2Hi2 E9c9ug48gYEzm+iqkA5vWqwYR5ysKX3KR0IBKmuPeJuEgCMBT/ohlaEGU7xdSXeLJuRj ZiL06zeczxfeLENngMMFJ39X2w9Ana3Fjp96qLbPBaK289XrSa0JuRngxygQielOT8CF /n7wqCVtFgLRLEIVy5oF/pNZL9x6K3JMBMI4JN1+z862FsxVi1viaR8mdbr83VZ1HZQf K2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pdyAQzGUZDqA1eYmqwW6m9OLrHYQ+P2llVYkgd4FTX8=; b=QfznKbjaAfwvZZ4lLkaKKF+3kAaIRulEcR4bl30+P6kUf9N6jT3nTgDwZpZaXLQxwg G0s2snIE91QiCXZkbxon/KA7xKfFCW2Nkmmrt2R1Uxj42jaeVxm0Ftpck6nAv8BtmkGJ Z9hw8c3/STBgFaT2T3FQMUhwqRC2VgFZ9wk6kX+CbeM3lbZsPUM/LFGrUd59CFub03jB ra/y/HkZwANnph7o/zKao+Xj4p5z9qZwrgxYCaIxm8hbfUtm+Qq+40M4/MHN51dmbfs2 MeO/pebGYikcMuM4ykKrberlybNZsc9rtJTPAeqn8LJaL8IBoBKkD/Yo9vChugVL5IVC XGaw== X-Gm-Message-State: AOAM533IOQ/Vi5qsqCOEE7IexOdb0ue4Ad9POCo3DNr2sXUoUSvLfR4c G3/wYZVg6trFJOEDo7wayutp2A== X-Google-Smtp-Source: ABdhPJzZkUhnaiYGoKU11zPHejuow+g7olSZe4Bhiz8EWdA1f4D4IouDADVj35YoDpJMGYofe2mbZw== X-Received: by 2002:a1c:de07:: with SMTP id v7mr22001147wmg.56.1593525078259; Tue, 30 Jun 2020 06:51:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:17 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 04/30] misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit() Date: Tue, 30 Jun 2020 14:50:44 +0100 Message-Id: <20200630135110.2236389-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Robin Holt , linux-kernel@vger.kernel.org, Dean Nelson , Lee Jones , Cliff Whickman , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org These functions are not exported and no external prototypes exist Fixes W=1 kernel build warning(s): drivers/misc/sgi-xp/xp_main.c:227:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes] 227 | xp_init(void) | ^~~~~~~ drivers/misc/sgi-xp/xp_main.c:250:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes] 250 | xp_exit(void) | ^~~~~~~ Cc: Cliff Whickman Cc: Robin Holt Cc: Dean Nelson Signed-off-by: Lee Jones Acked-By: Robin Holt --- drivers/misc/sgi-xp/xp_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c index 5fd94d8360707..61b03fcefb134 100644 --- a/drivers/misc/sgi-xp/xp_main.c +++ b/drivers/misc/sgi-xp/xp_main.c @@ -223,7 +223,7 @@ xpc_disconnect(int ch_number) } EXPORT_SYMBOL_GPL(xpc_disconnect); -int __init +static int __init xp_init(void) { enum xp_retval ret; @@ -246,7 +246,7 @@ xp_init(void) module_init(xp_init); -void __exit +static void __exit xp_exit(void) { if (is_uv()) From patchwork Tue Jun 30 13:50:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634033 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF9CF912 for ; Tue, 30 Jun 2020 13:53:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B674820829 for ; Tue, 30 Jun 2020 13:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZeGIsyn2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C3JufE1V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B674820829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3ITKEeb4RC5uJha7/NaMtlEg882d5kf3OsBGncrUDww=; b=ZeGIsyn2NJKlKTF7o4ZVv1Ut2 6j/zrHGpbkSrN28pLHo+I4Y+ebQwmd79h3yhkfxPFTolxDsEvAgZ7BhLIGprC6eEGumMKhMDQ34e0 WuzJ6L/mqtexYs4Rg6p5tf8Uzi0/MNVuWGfHeEiA3mU7NPjLNp9bCw+WYx3g5vTD4Gbbono47nlhT ysWn5g6PTEUEH6bMzrfvdTZi45BiK0mdsozl0g2R4JOFXlgqyzjJINaARz2jh0CBIa2g9tK4C9N/e o1Kf4QBd/gQhdD/QFapCFpRTRlNydwSUhsbn7wA1Mr2j6IJq6MwlMEof2y8qBEWp67hm8v6a1MHaU mzb+LAkFw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfy-0001MK-7K; Tue, 30 Jun 2020 13:51:54 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfQ-0001Bs-FM for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:21 +0000 Received: by mail-wm1-x343.google.com with SMTP id w3so7222786wmi.4 for ; Tue, 30 Jun 2020 06:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zimOoN2kqyjp0StchByfx/9jGDhP6/dApme8q5aFBgg=; b=C3JufE1Vbw703iYTl6sZac2o77v/HxfiLUxfLsvV7rf63VdFwoY8pZRLVXzmFORdiP tnIsWGaURHCqIdQWcy2O/ujeJUPkWtg9KM2i50TVu04acdEVD6YhMrv63V596iYirxpW 8aPANMM6SZqICnuKyCCV1BBYzbEv2gRX4A9nxB384FenhAFSBg7YuXubRgcDV293nK3S JDEHR1xB0VkC3vFYwM1sIuI+Z8VdjtWiR2aqO1+IVoXiNDIEeFDObePM0b3ousVgsu2g aLM05GkJa08x2XJ/KUFghTV+6cdM78kxQUwHXmTO94P/5TAriG4BTtKSi7YRpni66COw uxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zimOoN2kqyjp0StchByfx/9jGDhP6/dApme8q5aFBgg=; b=Oz58vOOXmtUOM88d68/syx/ThOTNjAHdqElN2SJwQCd3h0V2IWoqEPOvbMiJbh6YoB kzAfJIB0MBGHH2MIZM5XD6f8QbwzE277Dck4r3ZHxz7soMmIN8l6z1YMUhVcO/opPTtT P75Uk3P2walKXcr6SWsgbYBI+N/aq1mCeo1+nhQTBKbXZ6CJfFDuk63Xjd4qmMzseH+H 1flShMP90h+2Nh1/4k5ghVsKGQ7O6JCxczdxdo+uWsZRzFmBaObU1kSAjZgrGhIARMUA UsuBiooxSzk5CeYB5KWP/WgkSQJivsrsZcybazvORhhZuKReWpTE0yzOMRcXqmTASsJb FSFA== X-Gm-Message-State: AOAM533TYutCl0twsZ5G0CsIPKZJLYG1e1xmW2qSewFN3pcgw9wGZ+fm 2vxF3fYTBYpf2CwuYgGFvsepn9/1OpY= X-Google-Smtp-Source: ABdhPJztSC+qO8Bs60jiFpwOyAyS3D8NxgvpHTcxkBciCImutF2lsX+GPC6MWhWkOcraBY8wceqZLw== X-Received: by 2002:a1c:e209:: with SMTP id z9mr21891607wmg.153.1593525079340; Tue, 30 Jun 2020 06:51:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:18 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 05/30] misc: ibmasm: event: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:45 +0100 Message-Id: <20200630135110.2236389-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/event.c:44: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_event' drivers/misc/ibmasm/event.c:44: warning: Function parameter or member 'data' not described in 'ibmasm_receive_event' drivers/misc/ibmasm/event.c:44: warning: Function parameter or member 'data_size' not described in 'ibmasm_receive_event' drivers/misc/ibmasm/event.c:78: warning: Function parameter or member 'sp' not described in 'ibmasm_get_next_event' drivers/misc/ibmasm/event.c:78: warning: Function parameter or member 'reader' not described in 'ibmasm_get_next_event' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ibmasm/event.c b/drivers/misc/ibmasm/event.c index 974d63f5a4dda..40ce75f8970c1 100644 --- a/drivers/misc/ibmasm/event.c +++ b/drivers/misc/ibmasm/event.c @@ -31,7 +31,7 @@ static void wake_up_event_readers(struct service_processor *sp) wake_up_interruptible(&reader->wait); } -/** +/* * receive_event * Called by the interrupt handler when a dot command of type sp_event is * received. @@ -68,7 +68,7 @@ static inline int event_available(struct event_buffer *b, struct event_reader *r return (r->next_serial_number < b->next_serial_number); } -/** +/* * get_next_event * Called by event readers (initiated from user space through the file * system). From patchwork Tue Jun 30 13:50:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5034613B6 for ; Tue, 30 Jun 2020 13:53:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 298962074F for ; Tue, 30 Jun 2020 13:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rd9ektQ6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XFCjAT0F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 298962074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z3GVFz2onm1LdUOCxtuPG8rMUcUojGLOtbR/LGJ1FbY=; b=rd9ektQ6ntx/6J6c0/Iz+NSi4 9Q+pCD9SmQrXUBRzKcncRt1hYy0polTeXWvbo4LEcAXTNXXSnIK5krepWrxgKeyM3wZWVh6KRUT2v tatUi+3vEapsdPY3m5ze8pK/JzA59P3EFfeANMxjl9thtJaGEtKX5tD7qlfqNtqBROSLNBENfrz5c yfsZxhSi4+ZhoQ+OdCOupiD6pu5eWEt49aSrZU71VujyiSL2UR50NVo6iQ5Iyr/XcTNfWMxQYd/Xv ffB4ZFnksLCaBDRRhS53iPI2ONsqu1SJV/XZD7RojO37FDAcE9jEl0r9qLiQCdKhulSReojobmpDr dASNwwFWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGg5-0001P1-Hz; Tue, 30 Jun 2020 13:52:01 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfR-0001C8-BX for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:22 +0000 Received: by mail-wr1-x441.google.com with SMTP id o11so20284008wrv.9 for ; Tue, 30 Jun 2020 06:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KJS/keN17J0QH5GuMuvB98PgdVtEKXtUDk7tuwa3qBk=; b=XFCjAT0Fm2Ktek2vUmuOq+8tn3ROAtbgpJk64jEsnz+2NgMKEmCjQVVJiJw26bM0Jp jU+fBCIwnQ6kZyreKOOLT9bP2ruK+Lv/HnpktY370ivsAanhrBUWmAPNLh0s8vnVerwO atcn4KvjOovczEXJuU9OrLI34JUVUq0ZZ3hoAd3yw77gPdqsSoLmX+hUivb8eEwk9oI+ mHsFEavVDJuvmzCMV7qeQ9C8td2nhnr8vG+MVxa7jOsrGmGKWTqoEqyia6KKpCHhpxPs oQbx8xurNvuThuNuImiFXtrfph9OG4buS8F9VlXr3Zianl+H0ZpJKydwEo0E/oKpTULn e5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KJS/keN17J0QH5GuMuvB98PgdVtEKXtUDk7tuwa3qBk=; b=pUB598H/sA5Q1tT5gfLYIKcOQU8Ux9MfkyOqGwYlHDbmJrOzBe9gu/F67asy6EIuXX JaoURkYHyDG63AJFhKMSDFwEoQxhEQaRW7TgnOTq6/ZQ1mlZ2CB/0SFhAaaoc27M2cKe bHPbKBEVba/J8wYydBB0OXGdfRH7UqJizICPozD0k5XvHgOgfyPlo9vY2hQ5I6D9iOkp uB+s/sHPZ2drIQxnrKzDLTUCcVkHHbA6ot4Uv8Gnkam3Nxsq+8yE2NB1n4LtcEhDyzGw FLvl/pkejnXAM3nh7NLKtGXmci/TGOSlff8I2RZ7Zu0p7MYT1FN7pndkUf4aw1JXqrxW 4g7Q== X-Gm-Message-State: AOAM530POr3n28zZkAWr5bHPfSeEh0AhK1LAYO9ocdy2lqTkpayrDXku MeJ5I5lZdt3pXcUuvvkcu+Qadg== X-Google-Smtp-Source: ABdhPJy9deKfqIJP8pIRE38cgy1gIRpXGQWSZKp0s1rjHDZKFWj+i5L71stp9jmlT9v2RxSlGNzVYA== X-Received: by 2002:adf:c44d:: with SMTP id a13mr22553613wrg.205.1593525080501; Tue, 30 Jun 2020 06:51:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:19 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 06/30] misc: ibmasm: command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:46 +0100 Message-Id: <20200630135110.2236389-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/command.c:106: warning: Function parameter or member 'sp' not described in 'ibmasm_exec_command' drivers/misc/ibmasm/command.c:106: warning: Function parameter or member 'cmd' not described in 'ibmasm_exec_command' drivers/misc/ibmasm/command.c:149: warning: Function parameter or member 'cmd' not described in 'ibmasm_wait_for_response' drivers/misc/ibmasm/command.c:149: warning: Function parameter or member 'timeout' not described in 'ibmasm_wait_for_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_command_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'response' not described in 'ibmasm_receive_command_response' drivers/misc/ibmasm/command.c:162: warning: Function parameter or member 'size' not described in 'ibmasm_receive_command_response' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ibmasm/command.c b/drivers/misc/ibmasm/command.c index 2863657fa2683..733dd30fbaccf 100644 --- a/drivers/misc/ibmasm/command.c +++ b/drivers/misc/ibmasm/command.c @@ -94,7 +94,7 @@ static inline void do_exec_command(struct service_processor *sp) } } -/** +/* * exec_command * send a command to a service processor * Commands are executed sequentially. One command (sp->current_command) @@ -140,7 +140,7 @@ static void exec_next_command(struct service_processor *sp) } } -/** +/* * Sleep until a command has failed or a response has been received * and the command status been updated by the interrupt handler. * (see receive_response). @@ -153,7 +153,7 @@ void ibmasm_wait_for_response(struct command *cmd, int timeout) timeout * HZ); } -/** +/* * receive_command_response * called by the interrupt handler when a dot command of type command_response * was received. From patchwork Tue Jun 30 13:50:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634035 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 611C4912 for ; Tue, 30 Jun 2020 13:53:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38FC120780 for ; Tue, 30 Jun 2020 13:53:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w4yrEj9i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JROVTSMx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38FC120780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OUeBjCXCPxhpNLui9wfD3/e7HsJ9w31H0moUSsp2KUE=; b=w4yrEj9ioGsykdtz32Y4OWkdq f4I/Hav92e0T2P9/4U4NLxjO2i+xbW8hBCynVlwVaLWAF53MO59dXL4Fvg04SFZVjWmD7EgY4MHer qXiJt9BNqGZXwqqe+Si1toyTg41piYg9gShltjTtxKHCIocWw6zodZtL0gFKDcaFupSgAIdlwTG3O hBLkw088X9MFF7akKJ45g6dII9/i58sOY4XYzYt2bovC+3gtaIKpbZYjBXmnPw8grEDIQUZXgcwGj QLb/HfsOOtxOXwpCIoDN7W1wMnvR24RVOn/7u7BfqWvYpDpbv7YVvykSq/TteovNRHU8pg+bYfMUD vVaGPIVNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGgB-0001S7-Aa; Tue, 30 Jun 2020 13:52:08 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfS-0001CH-Al for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:24 +0000 Received: by mail-wm1-x341.google.com with SMTP id o2so19686640wmh.2 for ; Tue, 30 Jun 2020 06:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xbSUqKBCxymsC6lBBef3Qyn0QkDTIAKXJyfnYrQoXC8=; b=JROVTSMxcYpya04e8YJ8NvbOL9s6Y8mdWsTPgTWrjU6LHmLpBqI+RWcUkPq3iU12Ce Oh+Byu/dqxO3e7TDVyj21qrQM80IuHA9vi8gT+czeAw1IWM5YBrS1FjDXkUkeNGpb8n7 0inwVFXMPKT5ghvUXxvbM3OAEBSbZHRjzhzoV8JDCRs+tFLRv3Ky7RDB+6PglnHeMFpo 9n4VRksZq8uKFBm3VX8GA8J/ivxO+xegMzjP84WffpO7u/NoT6bFy73L5ljK2jAry31O BOKtaDEWKMnua+idVaSdZsHXOC0ejVXpf2SeDpzPJ5molGB5WIftQn0uGLBaqVmDfG/D fidw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xbSUqKBCxymsC6lBBef3Qyn0QkDTIAKXJyfnYrQoXC8=; b=CCWVfks9nBFtYPFRqLVbNXfeQayJqWbMhW91/d/9ThYJHv+rjCxe9jz/jnXxW3lebf QWX7beOvt2UrnoW49v5aYvmdyP8CEkVAC/8sEZBN3KY9TQDTE3GCJa2IUjuTtvyoJDV6 G+AHvsGC1c7Rw9zqRqak4ICTfQgz1jcu921TACYEKrL4OrtFDEa8VfvW7heZqSU7B8RH JpDqsAyEMibTCMOrDLtRQ0gvGrcwefJP9AxS/SwV/SIbpIBcsy8SVzCxFLjh7M94HJkm b8LxtELUP5EnqFL/EVa2lmbsnoPhevxrPFBh2/PQkFesTpckBQzo/MLB7xDhaEy8mUsR XoYg== X-Gm-Message-State: AOAM533Q6Bfm9O/iiY4OYQ9bJVdgfuZ7axZPX4f6gkI2PlikbyT07rOR +T2sIp+KoMvcs0YTfrcKvIdIVg== X-Google-Smtp-Source: ABdhPJw0jWJJPA9KNfsgcxxlrnj5t8iBR+bMqFMhI7nW9X7rHQGhd1hfd2q0Q1rm2llFxBbChW9waA== X-Received: by 2002:a1c:e285:: with SMTP id z127mr21764312wmg.162.1593525081517; Tue, 30 Jun 2020 06:51:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:20 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 07/30] misc: vmw_vmci_defs: 'struct vmci_handle VMCI_ANON_SRC_HANDLE' cannot be static Date: Tue, 30 Jun 2020 14:50:47 +0100 Message-Id: <20200630135110.2236389-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, George Zhang Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This header file is included into source files which do not make use to 'struct vmci_handle VMCI_ANON_SRC_HANDLE' which results in the following W=1 warnings: In file included from drivers/misc/vmw_vmci/vmci_context.c:8: include/linux/vmw_vmci_defs.h:162:33: warning: ‘VMCI_ANON_SRC_HANDLE’ defined but not used [-Wunused-const-variable=] 162 | static const struct vmci_handle VMCI_ANON_SRC_HANDLE = { | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/misc/vmw_vmci/vmci_datagram.c:8: include/linux/vmw_vmci_defs.h:162:33: warning: ‘VMCI_ANON_SRC_HANDLE’ defined but not used [-Wunused-const-variable=] 162 | static const struct vmci_handle VMCI_ANON_SRC_HANDLE = { | ^~~~~~~~~~~~~~~~~~~~ Cc: George Zhang Signed-off-by: Lee Jones Reported-by: kernel test robot --- include/linux/vmw_vmci_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h index fefb5292403bc..0374dd3cda3df 100644 --- a/include/linux/vmw_vmci_defs.h +++ b/include/linux/vmw_vmci_defs.h @@ -159,7 +159,7 @@ static inline bool vmci_handle_is_invalid(struct vmci_handle h) */ #define VMCI_ANON_SRC_CONTEXT_ID VMCI_INVALID_ID #define VMCI_ANON_SRC_RESOURCE_ID VMCI_INVALID_ID -static const struct vmci_handle VMCI_ANON_SRC_HANDLE = { +const struct vmci_handle VMCI_ANON_SRC_HANDLE = { .context = VMCI_ANON_SRC_CONTEXT_ID, .resource = VMCI_ANON_SRC_RESOURCE_ID }; From patchwork Tue Jun 30 13:50:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634039 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DBE40912 for ; Tue, 30 Jun 2020 13:54:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B493520722 for ; Tue, 30 Jun 2020 13:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LlFxsMZ4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sK/MjBLn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B493520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z1bA59mc9CXQ8IqJamXNbC8oyZnhL7e0XrJpVzu+P3k=; b=LlFxsMZ4plGzYfO7e5vntMCU6 YxJHuDqP4nkGHoY5eNZQYdZdGRkjvZ9ZBgmO0K7z2k66Hr4ds0qN7OWCwDyAMQKKRQlVSitpTPro5 VK842x7WzmPh4Dnk1MWyjDrs70FiIW7gGNYhyLdfI1wuD4PDQIbEKXrIaYnPSyv5g7MAyNCpLCUTC xrD20OrnsvfrBET048kZ64FS6J7VBswcioRrHl1bCEOWgVN4Clz1ro1lAawGlO2KL960jLokUGGfD PImYHhFo9d+L8LLUAXw/rrN744CCZnzowLBU3VNbr2rSLOUfkGLrJ3/XqyB6LT1bZzylkbi7H4RlJ xZgl1ANuA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGgL-0001UZ-73; Tue, 30 Jun 2020 13:52:17 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfT-0001CU-IS for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:26 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so18191072wmf.0 for ; Tue, 30 Jun 2020 06:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0HQs0EX6y4pWd4N+iRFQEBAE/mvgYPFVjycd+tHmjaQ=; b=sK/MjBLnUjG8NYp5Oa/pEOupOcPm/ZEJfX5LnNv64UNaye7QtI6qhMXXu5yhPadFKO slhHIIMGRHslLQUhQw0nGrvcB2csGQrLajPzJws3XAbX+dSqe+64BeuOrd2V4sa1KDlM qwewlAHNNakuxpilJrs56Kd+6HnPc/0FW/QpbIcrX0HsO/Js14vmF7Tl508WyfN4TGfC j+bx/2GEUtQGnpfOLnqKFS45PXFGGEaf4H79E8BMcD6o0gmc+cw89fIaEX2oR/pmOtxm DpCvADMUFGfO24Z8Ib1xpuo/06RZGIX45/BRDt8vBw0P2IXU+DfVDDcX5IqjHPTf/hmg 75FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0HQs0EX6y4pWd4N+iRFQEBAE/mvgYPFVjycd+tHmjaQ=; b=DN3nu+oQHtN1OiW3LW1zRlyBd44KcPkXonj6Xd9cWDaWAGDcrb9Uq0eZ/WOMNoKFT9 bGlPHTxsoEy428ynHuO6jh571W7B36K55ZXYYaqETXurRKj4Sei4/YpEzo3uyYWD+OfR /ZVzKTy9cChJGJJJivqJHOh6mLeWEBhh/qTv/wdyxH/7FGsGz9+jx5PnqaTTNY/yY+j4 30No+M5C+yIPY7MNMjeopyGGEvgRhBlKe9t7oBLW+aab80onU5MtyoXGZ/Ckrrfx4Nng +iV8PhmtfDZBrjEqnndBGxJLN/8YCPqdINERaAXdLu1rfI/xnF2WnwPPsn6z2bCyQzgn 8hIQ== X-Gm-Message-State: AOAM532PKrkO53I3/Dfxg3eMOfCp/IiAkg0lGO+nWfNojgo6MXMOkOVi xGbEH0Lu/j0vqbFZxzYmsXuyjQ== X-Google-Smtp-Source: ABdhPJw0TifXBK9AOZnXWLaDXMh1MZL4Xz0zESP5aT8WW2ZN59Rj/jcbvhPgWlb4zVF2mMhmDW6lag== X-Received: by 2002:a7b:cf10:: with SMTP id l16mr21845849wmg.93.1593525082614; Tue, 30 Jun 2020 06:51:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:22 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 08/30] misc: ibmasm: r_heartbeat: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:48 +0100 Message-Id: <20200630135110.2236389-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/r_heartbeat.c:49: warning: Function parameter or member 'sp' not described in 'ibmasm_start_reverse_heartbeat' drivers/misc/ibmasm/r_heartbeat.c:49: warning: Function parameter or member 'rhb' not described in 'ibmasm_start_reverse_heartbeat' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/r_heartbeat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ibmasm/r_heartbeat.c b/drivers/misc/ibmasm/r_heartbeat.c index 6567df638ea93..21c9b6a6f2c36 100644 --- a/drivers/misc/ibmasm/r_heartbeat.c +++ b/drivers/misc/ibmasm/r_heartbeat.c @@ -39,7 +39,7 @@ void ibmasm_init_reverse_heartbeat(struct service_processor *sp, struct reverse_ rhb->stopped = 0; } -/** +/* * start_reverse_heartbeat * Loop forever, sending a reverse heartbeat dot command to the service * processor, then sleeping. The loop comes to an end if the service From patchwork Tue Jun 30 13:50:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634041 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C6783912 for ; Tue, 30 Jun 2020 13:54:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F12B20722 for ; Tue, 30 Jun 2020 13:54:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SGEschZX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wlZk4sCJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F12B20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HXxjVwzHUHZ0m4gq41h8eg9vcJ/y1yzxPiO2NmpvYJY=; b=SGEschZXPKwIM2IT8rqsqU7kR 5wvL+EzkatwouhoRqAHkKy/JdDiyqKfp2YCWym5OmW6YJY8kuuIcW9f0ABAsFKFSF7DBfGwi+/str uutoYnrIbq7XdKeIx3+1gL5/Dms82fPsJhC8Xf5PuAgGT1XJlFnJRXeOVc+WFsrmNgnFAPU8O+ByU uhidIoQk8BJg0FKH7vN6XpKPiZaApDBS2umHg435yVDvu+sfC5g90j+wbhuhNK2Q4UioBz8opWNUd 0GOqaf4YU6criKsYvIcP222TrGUfe2V5emDUUIlnIo0uOC5ZzhL9TW2TeL2VFbS1KBHWPq4q625LB cXEUPzX+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGgb-0001cJ-ME; Tue, 30 Jun 2020 13:52:33 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfU-0001Cx-Ox for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:27 +0000 Received: by mail-wm1-x343.google.com with SMTP id a6so16013272wmm.0 for ; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lmSBURMhXlbXc5orPK26lnn3GrcbTsJzrTiKQM0CKuw=; b=wlZk4sCJ9LabE6MjBgDWfj+RAHJ7nlNR6gXF7qoifDB9OBorUV/WhRsFDUzsxdGC3k I+QATjMUHS6m99ukRPLizQEXD5V1Nd92XYCHMOAJ9mU+z6xf/ukS72a8n/il6//Ez6Ru DYrtSOwh4GkJBzr7ZcRIxMtyVSJqMuJ+wOZp6UVPd9rYzqnP3GOaSG829kAhJr3ZzxOX UvVnsVNZBiV6xsMa17D2OqtFmf/HMhxQVT/55iPrm7Ik4SZbMq5aTE6oyT8/gUW9F0av hnTOVhppnnQK7ZX27CXpmW5FWHS1RcJtiGxDSUZa64vF8C8mDDfFIcbmOMh7k955X53O hn6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lmSBURMhXlbXc5orPK26lnn3GrcbTsJzrTiKQM0CKuw=; b=sLvMZ32QErk9ou+KbPiiMsHGs9pYx1lb/sxJpeFz23xCeqokXUuxmMi4MMtC1ceiVV s+jHECVRC8xpmxgTSjaAvpl+cqQcKsA8W6t2gwZmHlzkPjrPpyruCCL712KkepF9AHfx SVGqIiJgmXYBPjQy28KZlsi6CJWJx27a976OY7KaUhUumJSVt3+IbiVjecTKF9UoA8Iy 5E+HQTsyaCjP/hjOcqGEyIKoU1HCDVu7R53Sqo87mc9p66WrA3F1OoStnO2qeKP13yud BFUMM5dJOJGcXptkzV2O1CKJIM3dkFqdMs85p3LezPYlo53QsByqu1uHJtD6mU4ETAB6 qNXA== X-Gm-Message-State: AOAM530sGdzp9VujTWwSCYSJtEYKmGwY4fizoGW1ljZmQyWgacfJzb13 m1fxDccpeinY+euY+Yncg+ps8w== X-Google-Smtp-Source: ABdhPJw756eqLhggdvniBrPLPyxPwbKeDc28oktY7T6iJ36sLKgK7neqmV89L3KWmAqnXuhPUzSPOA== X-Received: by 2002:a05:600c:21a:: with SMTP id 26mr17724220wmi.148.1593525083614; Tue, 30 Jun 2020 06:51:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:23 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 09/30] misc: mic: host: mic_x100: Move declaration of mic_x100_intr_init[] into c-file Date: Tue, 30 Jun 2020 14:50:49 +0100 Message-Id: <20200630135110.2236389-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org mic_x100_intr_init[] is only ever used in mic_x100.c, so instead of listing to the compiler complain about unused static arrays simply move it into the c-file for direct consumption. This way it can stay 'static'. Fixes the following W=1 kernel build warning: In file included from drivers/misc/mic/host/mic_main.c:17: drivers/misc/mic/host/mic_x100.h:70:18: warning: ‘mic_x100_intr_init’ defined but not used [-Wunused-const-variable=] 70 | static const u16 mic_x100_intr_init[] = { | ^~~~~~~~~~~~~~~~~~ Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_x100.c | 9 +++++++++ drivers/misc/mic/host/mic_x100.h | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mic/host/mic_x100.c b/drivers/misc/mic/host/mic_x100.c index d18cda9669121..843ce13750158 100644 --- a/drivers/misc/mic/host/mic_x100.c +++ b/drivers/misc/mic/host/mic_x100.c @@ -17,6 +17,15 @@ #include "mic_x100.h" #include "mic_smpt.h" +static const u16 mic_x100_intr_init[] = { + MIC_X100_DOORBELL_IDX_START, + MIC_X100_DMA_IDX_START, + MIC_X100_ERR_IDX_START, + MIC_X100_NUM_DOORBELL, + MIC_X100_NUM_DMA, + MIC_X100_NUM_ERR, +}; + /** * mic_x100_write_spad - write to the scratchpad register * @mdev: pointer to mic_device instance diff --git a/drivers/misc/mic/host/mic_x100.h b/drivers/misc/mic/host/mic_x100.h index 1f727a6f609c7..aebcaed6fa728 100644 --- a/drivers/misc/mic/host/mic_x100.h +++ b/drivers/misc/mic/host/mic_x100.h @@ -67,15 +67,6 @@ #define MIC_X100_FW_SIZE 5 #define MIC_X100_POSTCODE 0x242c -static const u16 mic_x100_intr_init[] = { - MIC_X100_DOORBELL_IDX_START, - MIC_X100_DMA_IDX_START, - MIC_X100_ERR_IDX_START, - MIC_X100_NUM_DOORBELL, - MIC_X100_NUM_DMA, - MIC_X100_NUM_ERR, -}; - /* Host->Card(bootstrap) Interrupt Vector */ #define MIC_X100_BSP_INTERRUPT_VECTOR 229 From patchwork Tue Jun 30 13:50:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634045 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFE47912 for ; Tue, 30 Jun 2020 13:54:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 994B42074F for ; Tue, 30 Jun 2020 13:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EljwqrGh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VkzyBtZb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 994B42074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JOidiDZ+fPHfCIwM0clJF+GUACk8ExqtmENxjri/DuQ=; b=EljwqrGhz7+XXccbxa5Xhi2zl OLDTmetw33yljkuQ0D1wXzssfEm2Uq79vmnoMlpXZCGEuaKc/Pu5tD0jo1rasYHjp8izAO0dIB1Eq 1yImaw/ms/XfjttLi0MqF8NEEgdRkdFvISV365YWiVIMdp4Anve86COXPHYvsGvijMc8ouoNdYKuK n/iEFXUopDqz36wVFkf5eMQI/yRi4WGeZsTZJIZkq1TQZ08/eAAag/D6wiYNODj1OfpwhSA8kquMy MylLU9xhSWzWPGtWXPptjr5cNTrUoeAS02ZfFelKjLW9fMsVX5yA3vXDpPbEI5de7EH7IFAov94R7 r5AjX/AcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGh7-0001sw-Fs; Tue, 30 Jun 2020 13:53:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfV-0001Db-VH for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:29 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so19674437wmf.5 for ; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=VkzyBtZbCjJJvhPGehZwLMGCthflX3/XiLaEsXmprAcJVpo80+gSoG8rwFsE+weyh4 ktuEsHJwHeeliHVIBqZbZHfxKTIhxooQjcRWF/IRKDYzwE0+BxanVd9NYSfhyIWiG53s tCxie/X8WcL0U9Vj/0ZNtTRsbOsvDazA5kboXlz+kHELQbXY/ZUAToaYVXd5H8spQ0Ou rwE4U1QYKcOnU7H3cbJIWJX1fKQ2wKeHi3V0r0eQQ4rkLM4VTLOYwWKNhDeT+4tOUam6 RIuizvWzQw2rQii5W+le77E6a2DZZCX6R8CQv+5LcI3fDCgBy3EW/p2Aahnk/Ui+KABm 1nyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekub7s2tFsF3z7X9QKVOCDCBJvabEEOsb/caCUw91kQ=; b=qQmPcCgOsEYjFrabwfp2NwqfQNPmoLIYGVOLEIX6snuoeErucRCJ9xlv9a/l3SFSK1 CiGqYYqPgGK952+MozcQlwY6TmphKG5u++aSl6d/ST7/NrpePvTvIuK14mjKney1WuHz F5FKkwT8U/PAOCGj6e5xq5REdxpME7QGsNE4eX1TKIy4u5iqty9D5xiuVpY65nAbp1gc fea8Aqrd+S6e0ukv/HLc4FTWYsMhJ7nBV2dQl1t2BuChPZ7S4CdOGcXhTFmnsfL15bOw aa4KycZQcOfsVTy7Nf1iytvMWRhlQgd5i2Et+qbtd30TUFRLmfW3L4z7y5mEbv4QzBHt yrnQ== X-Gm-Message-State: AOAM530k4KQHesnutLdzvBUK5ShZRAlB8W2pmWm60e83EfgM2MAtJKUR PHjfUy8geqFKG4HvZ9TFLWGk2A== X-Google-Smtp-Source: ABdhPJzXnmpgLmFJj/trdGQhzlz4Fmuvb3Xl3DNNCpx4ncsMeB/kuKfjKKh6mqpcjRvSFV0zFJrmIA== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr21474519wmb.21.1593525084780; Tue, 30 Jun 2020 06:51:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:24 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:50 +0100 Message-Id: <20200630135110.2236389-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Max_Asb=C3=B6ck?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'sp' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:18: warning: Function parameter or member 'message_size' not described in 'ibmasm_receive_message' drivers/misc/ibmasm/dot_command.c:55: warning: Function parameter or member 'sp' not described in 'ibmasm_send_driver_vpd' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'sp' not described in 'ibmasm_send_os_state' drivers/misc/ibmasm/dot_command.c:111: warning: Function parameter or member 'os_state' not described in 'ibmasm_send_os_state' Cc: "Max Asböck" Signed-off-by: Lee Jones --- drivers/misc/ibmasm/dot_command.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ibmasm/dot_command.c b/drivers/misc/ibmasm/dot_command.c index 70273a4cb3527..df389bd4c9df7 100644 --- a/drivers/misc/ibmasm/dot_command.c +++ b/drivers/misc/ibmasm/dot_command.c @@ -10,7 +10,7 @@ #include "ibmasm.h" #include "dot_command.h" -/** +/* * Dispatch an incoming message to the specific handler for the message. * Called from interrupt context. */ @@ -48,7 +48,7 @@ void ibmasm_receive_message(struct service_processor *sp, void *message, int mes #define INIT_BUFFER_SIZE 32 -/** +/* * send the 4.3.5.10 dot command (driver VPD) to the service processor */ int ibmasm_send_driver_vpd(struct service_processor *sp) @@ -99,7 +99,7 @@ struct os_state_command { unsigned char data; }; -/** +/* * send the 4.3.6 dot command (os state) to the service processor * During driver init this function is called with os state "up". * This causes the service processor to start sending heartbeats the From patchwork Tue Jun 30 13:50:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634043 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D80113B6 for ; Tue, 30 Jun 2020 13:54:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD01D20722 for ; Tue, 30 Jun 2020 13:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s851MbFi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RmUE4xRR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD01D20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5z6do9MSuaTXCcnicpXAAkYPtvwQ1sOlvTLCjTftM+A=; b=s851MbFi/lMSM6xwqnRnZRfUS s++LikihzKCu8XN4CMEfaL6hE/jqiOrkBETBZBaC5fEc//jjv2FAF8ENmit8JFiM8bFzK9NdBY9xX iZGYoh8J17eRkRnOFxf6LSEPahE+HCAHAMwkBO2nEJ2jSsvi3CjBB2itkadXhnjiqsZOSE59P865f k54W40e67QhxJoPmfsrzZANYaoIskVP8XKsMNA3FwGvlc04GF516YsD1GWpB9yLMybcS1/R2V+hFa H1J43JJEVk/DtWM3v6Yqje+IYyFQFlLraP0DfiAPeBu2Lut0EfkROsv6zsOA1EyLhBr+XrQzoafVk 36eWwQo8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGh2-0001nZ-D8; Tue, 30 Jun 2020 13:53:00 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfX-0001E3-2x for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:29 +0000 Received: by mail-wr1-x442.google.com with SMTP id h5so20266584wrc.7 for ; Tue, 30 Jun 2020 06:51:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RJCjtk9nocbEbC4CT5qyevqfhFFyrky+2iu8F1RJDRM=; b=RmUE4xRRiwVsmYoHLqv4r8cSKHDYrBB658nvefHkaSclGp0eS91gB+SAjnzDGVUbpE kdr/4pBlbcXLjisWngtOtitsAZFIpCmfZaYhQEdP1rkjRpxU1wj1JnQcqawvmOp08ZIe JHNA4T0IV8DLKk3SXIU+0TtuyX/ExSs0VvHDP3FNG/f1VfGCOBoHEpDTTbZesPaUe08R I6jtzOgeQr+LSTwrI4W7JVNOsHCBXa/498wBwMdpZvkemTceOt7S8bL9ELpmUO1oE3Wu 0sm6241qSpfPTCe+1wBtH8+48VHMraGuS2IYB7cLSaF/SXRnX51aU0xsaTZBcfgRIRxI VeWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJCjtk9nocbEbC4CT5qyevqfhFFyrky+2iu8F1RJDRM=; b=OTwCqyH6e47iP2tCiysNu5RTcRmV8Sf3nu4wSV4DE38V8pmam4ytPgz9Rpr30X8HL4 G/Z1sYOtw2QsH9girW7bZgIs7D7YNpCWW9TnTNo59PdomVhoqQ1h6O0JNbkIE4pRbmiA ebFoRngmnzZGbvAuL/rkJEGO+g095pcf8Xd/4iMqCFJ7YumRrSCLJPP8Yakh3w+EkqXk kSelEKXKwF8R9Rb/bcVlmtysqkl+hIZ+3Y+1xDI0HhWAolZRwaD4WRRdeTx4b7ucEQVn rnV5YmlcRaABcPVzLbVqaWrpgazdQTR2S1IcKyVzFoS9hmRRkuDHTNIRa3SoCK/luhou gV4w== X-Gm-Message-State: AOAM533bj27aiZIUbrALS1yFm1fqK9Aly370PqyAEMPh1ZZ6hJQQVK4m zCM8Vu4vPe1WEA9WGMLFd/FZqA== X-Google-Smtp-Source: ABdhPJx2kkPJCP6s7Z7K+iQmwN4Qs9Wxn6yYUEBx+rYFR+LhJUUCrVnVwUsObMJQldJQDD2uO1u9wg== X-Received: by 2002:a5d:60d0:: with SMTP id x16mr22596798wrt.5.1593525085786; Tue, 30 Jun 2020 06:51:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:25 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 11/30] misc: mic: host: mic_intr: Properly document function arguments Date: Tue, 30 Jun 2020 14:50:51 +0100 Message-Id: <20200630135110.2236389-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org mic_interrupt() and mic_setup_msix() have incomplete documentation. Fixes the following W=1 kernel build warnings: drivers/misc/mic/host/mic_intr.c:42: warning: Function parameter or member 'irq' not described in 'mic_interrupt' drivers/misc/mic/host/mic_intr.c:42: warning: Function parameter or member 'dev' not described in 'mic_interrupt' drivers/misc/mic/host/mic_intr.c:188: warning: Function parameter or member 'pdev' not described in 'mic_setup_msix' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_intr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mic/host/mic_intr.c b/drivers/misc/mic/host/mic_intr.c index 433d35dc17216..85b3221b5d407 100644 --- a/drivers/misc/mic/host/mic_intr.c +++ b/drivers/misc/mic/host/mic_intr.c @@ -37,6 +37,8 @@ static irqreturn_t mic_thread_fn(int irq, void *dev) /** * mic_interrupt - Generic interrupt handler for * MSI and INTx based interrupts. + * @irq: interrupt to handle (unused) + * @dev: pointer to the mic_device instance */ static irqreturn_t mic_interrupt(int irq, void *dev) { @@ -180,7 +182,7 @@ static u8 mic_unregister_intr_callback(struct mic_device *mdev, u32 idx) * mic_setup_msix - Initializes MSIx interrupts. * * @mdev: pointer to mic_device instance - * + * @pdev: PCI device structure * * RETURNS: An appropriate -ERRNO error value on error, or zero for success. */ From patchwork Tue Jun 30 13:50:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634047 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB55A912 for ; Tue, 30 Jun 2020 13:54:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 943F920722 for ; Tue, 30 Jun 2020 13:54:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n4Q+61EB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sd4ljwqm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 943F920722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JA88l1APT4eRzasthMksrAxU0JHqGKMEo+rfG7ysL6s=; b=n4Q+61EBIdKxOwslJxP348mS6 YoAVsBofMfXgAoHOg2zNzVSVi++IjQRDEZijdzZlJUTD98Vo8IaX8L3JVeLUCpjYI1Sd0to7F9BnM kk0hHEZxm6FUm0nvfv5iBYr4GW58pjzVFKylimS+NFemzEtaAUptrhG7DyiyN/yoJtt37fypPZbVi YKbnfGisFyJyOkUS2wb6BLyoqi8T4lcKRHg/p5PPCptZVs1WjscCmhrKCcn651YPbLYyp5+LUSUuD 9hltxZmIp2m0I3fEYhVoRnNgV4J/h0tk0XFdt92bWEGuPhyB31d153czRLFZJi9gcDuwyB9oPqe8e AXDLQWFdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhD-0001wj-9P; Tue, 30 Jun 2020 13:53:11 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfY-0001EF-Hj for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:30 +0000 Received: by mail-wr1-x443.google.com with SMTP id h5so20266672wrc.7 for ; Tue, 30 Jun 2020 06:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PcEwXK0xNmm8KLbdljUMIqWDcW1MZg3tkSRXZHPr9pQ=; b=sd4ljwqmp/zYlzEoyZu1xy0nSWXuHKG4YDJ8lnb8YsfDmzJwM0MYDZEmm+1XCWSUer kEcYOjz7nPz45b2R1EaJZoW1wAI9UIwneyJO56ceV1BdxO3seNPw/q3Yf0qJZ2sM+dXF Zr39Osy771y39P14DYzfnfHvyUTVYsS5B13UlvieqiYUEek39OqnSmcL9pS0C1N6PAx5 ycM5xQ2Vp7wOT0V7xpt8oRAWeptXJLiTuEkBkKCsI/CZLRgrEUGZpIaUJNiMAB0pQVev pwLjI03jAZ0xVV8yfggMZ0IQCjTTutEPkZ4T5h2Ry/WRKyV8nLkk5Ua9TTJ81pphvVfo XNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PcEwXK0xNmm8KLbdljUMIqWDcW1MZg3tkSRXZHPr9pQ=; b=KSHkhwZAN+nfLoqGSd7Fk0DewcfCoFhivLBpyowfJBNYxKFUF48gFZi3LV+qSuIWlC +UWfD83QnUmC7T0WrBCCq63DrlS97PC8CM7/PQXy7vFbuIv/KBDRek8DKcQxk3BJeDf3 INmx0BLtiFNZPrtCEs5oS1Gk9/4p98fo9V0b1S48AJ2X/zepSDfNckgNMXJWtNFo6YD4 qogDMEiLdkmCCFIAh+yQaqDnb9/ttPOK7Xvx56whyR3GXooadhTJEcKesUf+WlasfcY0 uLYINU6jojfg6q9CNGUJU5SpjHkWiBN1qiNIRTej0pcDAplYN5MLsEKWy+ix/boKyA4e 7Ksw== X-Gm-Message-State: AOAM530mo4a19jhoAHwR9DzMiu4EbKqkQBTFLamHrL9GcgAVZ57A5j1L aTjUOyt9bZuiqXrfgP/JVl2HNw== X-Google-Smtp-Source: ABdhPJxZLNyr0uQ8NR+OdfFIu/76siTbfZmzTER0rduvkESdd8zMDl2QiaPTsICt2/mN/E+Xl8xGcg== X-Received: by 2002:adf:c382:: with SMTP id p2mr21631803wrf.283.1593525086937; Tue, 30 Jun 2020 06:51:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:26 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 12/30] misc: mic: host: mic_x100: Add missing descriptions to kerneldoc headers Date: Tue, 30 Jun 2020 14:50:52 +0100 Message-Id: <20200630135110.2236389-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 warnings: drivers/misc/mic/host/mic_x100.c:127: warning: Function parameter or member 'doorbell' not described in 'mic_x100_send_sbox_intr' drivers/misc/mic/host/mic_x100.c:148: warning: Function parameter or member 'doorbell' not described in 'mic_x100_send_rdmasr_intr' drivers/misc/mic/host/mic_x100.c:511: warning: Function parameter or member 'dma_addr' not described in 'mic_x100_smpt_set' drivers/misc/mic/host/mic_x100.c:511: warning: Function parameter or member 'index' not described in 'mic_x100_smpt_set' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_x100.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/mic/host/mic_x100.c b/drivers/misc/mic/host/mic_x100.c index 843ce13750158..f5536c1ad6071 100644 --- a/drivers/misc/mic/host/mic_x100.c +++ b/drivers/misc/mic/host/mic_x100.c @@ -121,6 +121,7 @@ static void mic_x100_disable_interrupts(struct mic_device *mdev) /** * mic_x100_send_sbox_intr - Send an MIC_X100_SBOX interrupt to MIC. * @mdev: pointer to mic_device instance + * @doorbell: doorbell number */ static void mic_x100_send_sbox_intr(struct mic_device *mdev, int doorbell) @@ -142,6 +143,7 @@ static void mic_x100_send_sbox_intr(struct mic_device *mdev, /** * mic_x100_send_rdmasr_intr - Send an RDMASR interrupt to MIC. * @mdev: pointer to mic_device instance + * @doorbell: doorbell number */ static void mic_x100_send_rdmasr_intr(struct mic_device *mdev, int doorbell) @@ -503,6 +505,8 @@ static u32 mic_x100_get_postcode(struct mic_device *mdev) /** * mic_x100_smpt_set - Update an SMPT entry with a DMA address. * @mdev: pointer to mic_device instance + * @dma_addr: DMA address to use + * @index: entry to write to * * RETURNS: none. */ From patchwork Tue Jun 30 13:50:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634049 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB6F7912 for ; Tue, 30 Jun 2020 13:55:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DED620722 for ; Tue, 30 Jun 2020 13:55:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="roPz0NLy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l0ql2sn5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DED620722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XD0gN6GC/ihPaF8uoXKd+LSzx8x6uygOO7vn7ejs/aU=; b=roPz0NLyGjd+FqEEdvkXINw+9 1icJogigVUQpdSsrxyEnj/VSvFYd1Goku6xgxt3ce/zmS5uyw4YD5pMC6a57xqChiY0ekUUYWJM0D hEvUAMekx/2cW88of7FCBbpjAS1XiPt25lCQex0vI9HisUZzraj0kNdW+oFko9Kh6jVyuu0MCpvO9 8zocLAxIj5/PQjdkchE5aonblY2OYDE4f5CrPmpbCBMnRrntSAfmfItWcgGyMdMNQWpoc/LVXwzYG 2dvO/aomNNP/H3YqLsfsEm1kPr1aA61rbLAXs47/J72pBZTyf4wHpRs4mS0W2giTKnZDqHQ1o3qAv RQdRrcvmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhI-00022J-Mb; Tue, 30 Jun 2020 13:53:16 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfZ-0001EW-CY for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:30 +0000 Received: by mail-wr1-x441.google.com with SMTP id k6so20291528wrn.3 for ; Tue, 30 Jun 2020 06:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Rr7wa1veduLhh9ZAr39E4g8k4FtFNV6OceNUbS0RKk=; b=l0ql2sn5FiL9hzSkQ+yI7cAzJkka4RsC7ibUvZkRg88BN0zPoJVj2CCmPhRVJEhMTZ ZvqLmbJcCy3t1cMqYZjp5vBNBLBLZAL6f+qmWr/k4xb5m2BwaOqi3jrX9vQ8JIBumN60 Sj/oB1X6FT9XUFRqZGk3DUe003hWauUxsyLPQqaAx+R3E8GWf28kU5e8iOq2QuiUeNu1 N35lUJPUUNmq+fYpMdZsUEhZ1SJUgI8i3+FL3Xit6O96cnfeTh9+/o4CNMxkpSGfcKs6 xexXuKA6fhyFqlmlsLD+5QaIs7CrHlxjcrLfgIQMJrafOsQ5vIAzkkEtDcRDyNXHpyT8 w4cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Rr7wa1veduLhh9ZAr39E4g8k4FtFNV6OceNUbS0RKk=; b=DW+jN3s4hVHSbW7Abu45yakMFKtV+jwpNXvoPRmHI3Lv6Eck72UnDU+ZMvxyYPodWf xG710EWgEQJm85KKOZDtUIKuQN3VvP4+Sqj7tVOEGViT8HpkaK6577/hKkiU2QOYGEbU q+lxC+prvWiVO7UPgOaElGAtolZbioeT8OTn+ncjlQRzhCMvF+5iexyE3plEMnvGQuIq TNA1KYH1D9fI58+fspHEviqfC002ijylEJ85suJlDQkTyRsIOW3BXL1z6OyXb9LAY29d nNdZR02t5BpIGogkfDDznvStqGVKpc+dwHoSGYzM3OiFoD71i9qo5pizYZDsYJI+zg4g O/iA== X-Gm-Message-State: AOAM532u8NDrz61pGjBCQfCfSbRH84sH4Hw9pzwchNd614S3vks05p0R 1VkJmVlCjfJQgLtMuV+eSSVEMQ== X-Google-Smtp-Source: ABdhPJx7RZSCG6MhccQsVv6Y1Q3D48aKEAlqzGQWs/ITBqKeYmpx867Pcfq0L5FYO9K0o9jZk5hI7Q== X-Received: by 2002:a5d:40cb:: with SMTP id b11mr22580348wrq.263.1593525088326; Tue, 30 Jun 2020 06:51:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:27 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 13/30] misc: mic: card: mic_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:53 +0100 Message-Id: <20200630135110.2236389-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the headers back down to simple comments. Fixes the following W=1 warnings: drivers/misc/mic/card/mic_debugfs.c:31: warning: Function parameter or member 's' not described in 'mic_intr_show' drivers/misc/mic/card/mic_debugfs.c:31: warning: Function parameter or member 'unused' not described in 'mic_intr_show' drivers/misc/mic/card/mic_debugfs.c:53: warning: Function parameter or member 'mdrv' not described in 'mic_create_card_debug_dir' drivers/misc/mic/card/mic_debugfs.c:67: warning: Function parameter or member 'mdrv' not described in 'mic_delete_card_debug_dir' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/card/mic_debugfs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c index b58608829b180..4c326e8f4d993 100644 --- a/drivers/misc/mic/card/mic_debugfs.c +++ b/drivers/misc/mic/card/mic_debugfs.c @@ -24,7 +24,7 @@ /* Debugfs parent dir */ static struct dentry *mic_dbg; -/** +/* * mic_intr_show - Send interrupts to host. */ static int mic_intr_show(struct seq_file *s, void *unused) @@ -46,7 +46,7 @@ static int mic_intr_show(struct seq_file *s, void *unused) DEFINE_SHOW_ATTRIBUTE(mic_intr); -/** +/* * mic_create_card_debug_dir - Initialize MIC debugfs entries. */ void __init mic_create_card_debug_dir(struct mic_driver *mdrv) @@ -60,7 +60,7 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv) &mic_intr_fops); } -/** +/* * mic_delete_card_debug_dir - Uninitialize MIC debugfs entries. */ void mic_delete_card_debug_dir(struct mic_driver *mdrv) @@ -68,7 +68,7 @@ void mic_delete_card_debug_dir(struct mic_driver *mdrv) debugfs_remove_recursive(mdrv->dbg_dir); } -/** +/* * mic_init_card_debugfs - Initialize global debugfs entry. */ void __init mic_init_card_debugfs(void) @@ -76,7 +76,7 @@ void __init mic_init_card_debugfs(void) mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL); } -/** +/* * mic_exit_card_debugfs - Uninitialize global debugfs entry */ void mic_exit_card_debugfs(void) From patchwork Tue Jun 30 13:50:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634051 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33DC9912 for ; Tue, 30 Jun 2020 13:55:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D05520722 for ; Tue, 30 Jun 2020 13:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2PlJSPs8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qDMd25o0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D05520722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CGlOV7ed3LLs1MpiSMY4ph4n1PGymUA0hoVNtEHdCVc=; b=2PlJSPs8oen9emXuh1s0lhfy2 IG2hhwNltfHfYZIQR0qpC8WjU/uT9woKcbagqcxoDTvjRPFiAvciIukcVq45rs2i0UJdnKfh94KbW KsOoqozLGHYqDH6pLgjTrxFdavV9UQA8zZubWbMqH+qd1dY60bPNdng/Rrr12vySqlO5B4evgX0Av bXob/cj5g8SUIKhV4DMH6unC/pakCMM6xWawB+2xN+gBWSnRukrtAGBObTQJjU1gcWhPPWOZdGz3f hdfACUjJ5z3qXCb6ASyzButrVZ7y4E2GLIBVNluPbvwBtBFXPPKR4sRobhXb01tKSKyPX4gCyf57R 7D7b6V3Rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGha-0002E8-La; Tue, 30 Jun 2020 13:53:34 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfa-0001Ex-L4 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:32 +0000 Received: by mail-wr1-x444.google.com with SMTP id s10so20236309wrw.12 for ; Tue, 30 Jun 2020 06:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qqN6XxuBV4Jc4c7/xcuhasc+YhoMkS+syDgxfhyrVnI=; b=qDMd25o04PnMrI7s5/XLbUKoJJaCs5QElcqGQC8Ps8VWTX5SlIPD7ntW4ahpr3/mv+ xsRPeqJb51zpw6iUma6WOquB3Z3GX+eD1Drx+fID9HNPEiGiXt9ATD2SiirAeqDpXYTW V+WDzYlfBStA7UnKW8JXWUzQwlxdkaqvONzpzQpz52QlwpfeCF051bjArWwerpLIN2hP vQdq92UzPHPJYLL58KgKipIQdJXZ2Y1Ytz9Cz3nZzY9Rsmg61xI1urRdKyCcipKQ1Zjk DLeNOcZVV9uFyOWckmjAQSaELmCkOH9gUPYhfNqw92wm1SRXgj5Xr74P/FyBj+mPsET+ y8pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qqN6XxuBV4Jc4c7/xcuhasc+YhoMkS+syDgxfhyrVnI=; b=SwyaTcJ+sB9MAoyIfbRY7sXlhc8HyOWyxbMBp8b/dkdZJ6bUjGtzhvIe4QMhklTttC 8UQPw2Ozo1jf+Y1cspgZr/zjBD5dsMMzpVfjExieRLydbhTMeUJx8RZTBN0rvLc33CNc ly7f00Cy3VMEcQeW1620GGf6wbuLdzkPHClG0VX5pHFk6buONzx7pSLtMqaladUDNxM9 Jk7DjmOLpDFTqG9KZg9QPC7J57X8Tp4uaJvJk0/Yb2rCjC7PQ4PVGtz9CzTyiufUBCvy F7nbu2eUatFWY5q0nR2U6fl5ATCzD3qKopvzZkY8ZAP9qgn1DPk0Md2Buv9/Qs2PxWhk 3HGA== X-Gm-Message-State: AOAM533BwEhTljXDrEX7QwyVt/CuKtZeQxWqX16gbLN0E7wC8dxiUPFs oBIAWarpuOveHorrnllJsKIHJmbHYlA= X-Google-Smtp-Source: ABdhPJxBCPH1g9KzdqS9IQ654MY2nJGCfEf2EBKfgxw48PUsFnr727YH5gZI9bH2YoaczlXd24j1uQ== X-Received: by 2002:adf:db4d:: with SMTP id f13mr21659776wrj.336.1593525089539; Tue, 30 Jun 2020 06:51:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:28 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 14/30] misc: mic: host: mic_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:54 +0100 Message-Id: <20200630135110.2236389-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the headers back down to simple comments. Fixes the following W=1 warnings: drivers/misc/mic/host/mic_debugfs.c:108: warning: Function parameter or member 'mdev' not described in 'mic_create_debug_dir' drivers/misc/mic/host/mic_debugfs.c:131: warning: Function parameter or member 'mdev' not described in 'mic_delete_debug_dir' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/host/mic_debugfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c index ab0db7a2ac8c2..ffda740e20d56 100644 --- a/drivers/misc/mic/host/mic_debugfs.c +++ b/drivers/misc/mic/host/mic_debugfs.c @@ -101,7 +101,7 @@ static int mic_msi_irq_info_show(struct seq_file *s, void *pos) DEFINE_SHOW_ATTRIBUTE(mic_msi_irq_info); -/** +/* * mic_create_debug_dir - Initialize MIC debugfs entries. */ void mic_create_debug_dir(struct mic_device *mdev) @@ -124,7 +124,7 @@ void mic_create_debug_dir(struct mic_device *mdev) &mic_msi_irq_info_fops); } -/** +/* * mic_delete_debug_dir - Uninitialize MIC debugfs entries. */ void mic_delete_debug_dir(struct mic_device *mdev) @@ -132,7 +132,7 @@ void mic_delete_debug_dir(struct mic_device *mdev) debugfs_remove_recursive(mdev->dbg_dir); } -/** +/* * mic_init_debugfs - Initialize global debugfs entry. */ void __init mic_init_debugfs(void) @@ -140,7 +140,7 @@ void __init mic_init_debugfs(void) mic_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL); } -/** +/* * mic_exit_debugfs - Uninitialize global debugfs entry */ void mic_exit_debugfs(void) From patchwork Tue Jun 30 13:50:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634053 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15A5213B6 for ; Tue, 30 Jun 2020 13:55:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2E022074F for ; Tue, 30 Jun 2020 13:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qk1TYI86"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UIAErbA5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2E022074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=422MDurhftjOsejIAtR5MYG8HgtdfX0JAAxDhNnRpjk=; b=qk1TYI860ZYJ6G6LFKn8VcQBW 24Ogn+ADe1LNpIehvnAeZI7vYiguFdpKzh5IY+8AwOqS9GrRn6lnOTN5w1gzLg4gnl1M9CQZC4ViR dN1teHj7uHj/v+azp8xY01/X6Lpt7Qb1Gad0L1FI/9sTpMMYyl3q64MoEKqeAZIHNiNNXfmXy3kj1 oMTUvsdvf3ssaGkxaDjRV7aIVXPtKAO9JdozjqxHRADgvNHpcxrLE3d/HtwX/gB860bPzpWwoZXXx +2NsTCY+o3ijxyGbeBgaXiWBVCgF9nVWXPT345cYnVG9MQmLr/g/C7X/LEza2EncOvy23TmdpdnUP xiwmaGviw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhi-0002LG-OC; Tue, 30 Jun 2020 13:53:42 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfb-0001FD-I8 for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:32 +0000 Received: by mail-wm1-x343.google.com with SMTP id 17so19665636wmo.1 for ; Tue, 30 Jun 2020 06:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oA8RTovB0rd6yTwQFM7j/fT5zajZLuFIh0xLtIq5guU=; b=UIAErbA5c+2SMZ+wjP2jjX5s6AjjcaaAxML/0/lVekLqDa7u3dTrURRKA75hCWNmYg wtzMu/ZtLDLINdwqAlf8KtdzHF388IABv3nsxfqPua5jV4xeDRdVaT3Ytmaz1tc5xDWH QYVsNgqDAm6LQp+d0HSkJosNriujwdQmsVrMymBfIGblaaNqvduC27Pdzw/BlxENFEx3 dRyMLxx0bcSZIEwod7ftiX3r1ofa4jbIGZF4VQ9G6crqLedLlnE9F5QWBn5lcS9NG5er EaDWLakcusn3lWrDIIAUDnufmxRM0RuYXPbUNf/jXX0E0aPPxlCquh9cb5dbfktfHXFI 708Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oA8RTovB0rd6yTwQFM7j/fT5zajZLuFIh0xLtIq5guU=; b=KaVo6diYqsO+MMDgc7Qzura6/XPgJ08bdH/GFUzrPPU0QwVq33tEbFuaaSVm+Hzg7T wFSmfQESjETOVBAjMsevh8chFKkwn2k2lEzwgi2AwXmboZMUGTDyCjDQzqWkuNT3hu34 CeCJqZvNEQyOtcNIDme2OtaNXhcZvN5a0SShgilpP13bye9XjaA2+tg46jjBRDMlaULs t/SnHcPN2is6Ohsvjg9VRhCNbo0NmHhSCjj1ojtwRc+1SgWWq+vbu4yPhTEMnZhEPN68 Hflxo0kTfRzeN2B+chXBUZt4lJlqMB//GQgPMNlr7KdUiM+3zvEj4JEpHZX87N+oqTAB OVFQ== X-Gm-Message-State: AOAM533mPPD6p7gc8DJc9+VyXuzPkvc9j4Tef25aki5F+Qh9yhL+dtwy OMI+FadhbFrGredsrUWCkrR8Ow== X-Google-Smtp-Source: ABdhPJwwBQaKJSpY60ja6PdGUXZLEsscFN3/NRLrOYALfhdPnliSxjMd73lWq+QUHPqsPmJ0PYqLMw== X-Received: by 2002:a1c:4343:: with SMTP id q64mr21699175wma.20.1593525090438; Tue, 30 Jun 2020 06:51:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:29 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 15/30] misc: mic: cosm: cosm_main: Document 'force' function argument Date: Tue, 30 Jun 2020 14:50:55 +0100 Message-Id: <20200630135110.2236389-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning: drivers/misc/mic/cosm/cosm_main.c:31: warning: Function parameter or member 'force' not described in 'cosm_hw_reset' Signed-off-by: Lee Jones --- drivers/misc/mic/cosm/cosm_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mic/cosm/cosm_main.c b/drivers/misc/mic/cosm/cosm_main.c index f9133c4f61050..ebb0eac43754a 100644 --- a/drivers/misc/mic/cosm/cosm_main.c +++ b/drivers/misc/mic/cosm/cosm_main.c @@ -26,6 +26,7 @@ static atomic_t g_num_dev; /** * cosm_hw_reset - Issue a HW reset for the MIC device * @cdev: pointer to cosm_device instance + * @force: force a MIC to reset even if it is already reset and ready */ static void cosm_hw_reset(struct cosm_device *cdev, bool force) { From patchwork Tue Jun 30 13:50:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634057 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE9CA912 for ; Tue, 30 Jun 2020 13:55:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8827D20780 for ; Tue, 30 Jun 2020 13:55:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IRGOYV2i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YTFr/Jhv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8827D20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CzssIczj2aWPEA9XPPHGdVV0+TN8TeXcGxZjyExO2YU=; b=IRGOYV2iE5w7TjAZPmp35cUDu bb1I2us7W1n4VZvO0tY0YzxPgsYs3b3wtZlu8dgKGH3tg+0x9g7mlm9GHgT1OJCLl3oSFvlgPfWzk Vuxf6bITXaPHV2zvhwaNed4YIJAoRIQLIjTFG3VzYHu0KYFosPR6iBmHtvldwPMp48N2QFIislGpx Bi5kQiqPqmgGB6cB+hOHRWrYOwSpNihyxU3W/fZrDx7FxpS2Qv1FAj3Ig9UHNakKwlXI0yn1oN9Mv Ga1Bjy2jCqqUSn/PCEUNnwA4ojgpIoV9DzLswo2OlyVI9/tRmQ4IkVFP2ZbbKHvxBo+fYlFGP3D8U FzpFiv0ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGhu-0002TV-J8; Tue, 30 Jun 2020 13:53:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfc-0001FU-Cf for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:34 +0000 Received: by mail-wr1-x444.google.com with SMTP id r12so20215886wrj.13 for ; Tue, 30 Jun 2020 06:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wk9/DzLGRf8KDCzfvt/GOgByrJsxT/fIOxcZPlWq/CY=; b=YTFr/Jhv0IxMRjGJfO5vfcAWzDDEhJZD1S9kEdXHCGlHd/6sUL1vsEErzCACCcBSFZ u9zv/VeGKVgLS7CL/GgMyWr+1k2OoHi3Qi/KMvnIfmHQY11q3i/qb/Ya2PfwKSxM0MvQ 7MET2nVm3HQiCnM1TKCWe4be8nmhxtDblN53F96eJHD4KUFAszWEBwfOFiBDyFH83Rpm BwbKrOCzmPjfD0ZcjdF8HnYbO5GQWMBJVexLMX+zq3SrVUPZPEIXRjFVQW/Djc8XleSB kVaBGlxwFPf+nsWc+In+cyqgu62pjiTY2num8107Z0kEYZ4UGRhZEnG3z4xKrocL0IpZ xhlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wk9/DzLGRf8KDCzfvt/GOgByrJsxT/fIOxcZPlWq/CY=; b=ErQ1qBiejakfW1tOetoVNKYKNHsHcJxQMfo9rOWOAhmjO1DZjAG1KhJY6Ewepo0vvJ 3GnBf5Szc13W1zsvTXdpvqjfVgHjuGjJ+LeEaHlKa1XjHjrwbB1xkOTMhr8X4CPBsO6b MqfnUXHt6C5a954WbDYBasicyg7/sJRLCZMfZ9bpM9FMdEaO5I/tVftvUNvO2E/6JbLz uZFnvSrsyyDYEpxKnp5WUqfoUHVevvxxrQnV0Z+ikALkGx92751c6LJWJGTD4H86SX4L pVolcMGXW71d+coaBylSwX+wv3xrJiRDVfe3MTxJS6cZISpxeSOrDCqfKhUAlNXuU+Wb VaRg== X-Gm-Message-State: AOAM533IzKJj7WaW3wKmhirF2hAhT8dSNEM0FsNO3WIqLVYKmNlWM7hQ ge3nMpYEe6eyDisa5kRPd4jUbsqmvAE= X-Google-Smtp-Source: ABdhPJy+tsRYfnowp6Jy74IXc5vBXoUVMYXIcAJJ6qCYOHFM4FMkD6FU1i2uxa+KqN5jXoQvqqo3FQ== X-Received: by 2002:a05:6000:128c:: with SMTP id f12mr22618875wrx.67.1593525091335; Tue, 30 Jun 2020 06:51:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:30 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 16/30] misc: mic: scif: scif_ports: Fix copy 'n' paste error Date: Tue, 30 Jun 2020 14:50:56 +0100 Message-Id: <20200630135110.2236389-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org __scif_get_port() has never taken 'port' as an argument since its inception back in 2015. Probably document the proper arguments expected 'start' and 'end'. Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'start' not described in '__scif_get_port drivers/misc/mic/scif/scif_ports.c:36: warning: Function parameter or member 'end' not described in '__scif_get_port' drivers/misc/mic/scif/scif_ports.c:36: warning: Excess function parameter 'port' description in '__scif_get_port' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_ports.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/scif/scif_ports.c b/drivers/misc/mic/scif/scif_ports.c index 547a71285069a..4bdb5ef9a1399 100644 --- a/drivers/misc/mic/scif/scif_ports.c +++ b/drivers/misc/mic/scif/scif_ports.c @@ -14,11 +14,11 @@ struct idr scif_ports; -/* +/** * struct scif_port - SCIF port information * - * @ref_cnt - Reference count since there can be multiple endpoints - * created via scif_accept(..) simultaneously using a port. + * @ref_cnt: Reference count since there can be multiple endpoints + * created via scif_accept(..) simultaneously using a port. */ struct scif_port { int ref_cnt; @@ -27,7 +27,8 @@ struct scif_port { /** * __scif_get_port - Reserve a specified port # for SCIF and add it * to the global list. - * @port : port # to be reserved. + * @start: lowest port # to be reserved (inclusive). + * @end: highest port # to be reserved (exclusive). * * @return : Allocated SCIF port #, or -ENOSPC if port unavailable. * On memory allocation failure, returns -ENOMEM. From patchwork Tue Jun 30 13:50:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634059 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 303D1912 for ; Tue, 30 Jun 2020 13:56:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087C120774 for ; Tue, 30 Jun 2020 13:56:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mosSv/dI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BuGM2xep" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087C120774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dS+nQX+JvB0enYXuzLKIQPpHBoc8lPt9iYeCFK+CQIE=; b=mosSv/dIccfZsP1utMY2fVyQ0 4585E+xkuobEgtRO193Wyhk0VDZEzxfdlNR4xCBxgD865wHzUMvqLhNISoEyrEscWwYEE6qN6AoQL YyIazfZH9sAxT3dnjnuLfevewyftJg477KoIABB3P7s/3TdZTb4eTpbuW2S/Updmr1CEYt5249BYD MJRgAU+WK/Jom268oP4HfBLtCH+kI6pvHYI3CZ06b3N9FdK8ZTyA3Fp5MyBTkFa5tc5jtq6tzbVnD 2JFmKkFDWg+45VYk3DjnTEw0tdjjRx+LlZbU9Ldvh/lZ1HR4mb2iUDaCoYEYdgUd69EL8F8M7x0AZ Pc/p6zlCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGi8-0002eN-24; Tue, 30 Jun 2020 13:54:08 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfd-0001Fl-KA for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:35 +0000 Received: by mail-wr1-x441.google.com with SMTP id b6so20246570wrs.11 for ; Tue, 30 Jun 2020 06:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GHtif/VrKAdzD8tANDBuK+rW4l81OqvLbxPsir5m1XU=; b=BuGM2xep6RhwyJLaKYzA1LY0lnzmDeGISBQyDgjvCCdB4uSlbOdhNjGAIySKO9kXcw EH5QjQGaJnt54u7lAG8VzxejktsK+98Wo5238OHW0RywWUP5rBq2uyhK/qSQHmIwsBg2 jrEMTHQ5+VsIcWGiCUsmbojJN34+WqZ9qjPytbo4FwL2egqnP/No/6NFT6lmqv0+yiwS Qpv4gaucJzpQNMNKa/p+tsrpe8i84+0GV1LqzrHqVpfwVDLzCjesyVU7P8PECRQpmdM3 UkLtQ42eRaVhx+y7ydAuqsU/5zQa3TrZiLpMyY3/0iiOwVnw8XocpSuHG5POF1wpRtJ2 rxtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GHtif/VrKAdzD8tANDBuK+rW4l81OqvLbxPsir5m1XU=; b=n3RN7trm5EKjSWnOtamvSMNsMnXkpo83d6Ldlkvh2YdoXwf9lbBN5BJJgTbhB/yOJB cREADq8Btbr8OLTxxf7pLQL2nDGFURhOBYxu33f3iIF26K6lI7qDgv5dh2QzTJhzxDaP uumwIde+Qla07ZRDR8JXsMWNvHpW6Eq9/Qo1SBgUIb5c524R/CNZl7JgjJ1u39eAvv7v R8hRUiM5SIi36QyuI4fHvEZlzX624GK8ikH6JfWvPftgZlbXdgnQtPYy/Xc0c8RT98cB xu3D50RGpr2rjNlagy3v6jS0aboSNvVFzmmlX/rcw1EiOX2F2YtHEB25Iz1mlDjR4Q+9 K/tw== X-Gm-Message-State: AOAM533/NdIz3nzTseXVhq/zm3UjhVjBL4IvVhu9O2bkU2Y7SXWwwUm7 uefc0CSTIq2Lrll/HBMQUg28YQ== X-Google-Smtp-Source: ABdhPJwW+1Hk4BGrbmmXevBy2713hmUjyPmxt1lmCevbhbcXJYipCFBTuWS3WioQoS/mcYj09qQiXw== X-Received: by 2002:a5d:56d0:: with SMTP id m16mr21150324wrw.194.1593525092319; Tue, 30 Jun 2020 06:51:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:31 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 17/30] misc: mic: cosm: cosm_debugfs: Demote function headers from kerneldoc Date: Tue, 30 Jun 2020 14:50:57 +0100 Message-Id: <20200630135110.2236389-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/mic/cosm/cosm_debugfs.c:25: warning: Function parameter or member 's' not described in 'log_buf_show' drivers/misc/mic/cosm/cosm_debugfs.c:25: warning: Function parameter or member 'unused' not described in 'log_buf_show' drivers/misc/mic/cosm/cosm_debugfs.c:78: warning: Function parameter or member 's' not described in 'force_reset_show' drivers/misc/mic/cosm/cosm_debugfs.c:78: warning: Function parameter or member 'pos' not described in 'force_reset_show' Signed-off-by: Lee Jones --- drivers/misc/mic/cosm/cosm_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c index 68a731fd86dee..cb55653cf1f92 100644 --- a/drivers/misc/mic/cosm/cosm_debugfs.c +++ b/drivers/misc/mic/cosm/cosm_debugfs.c @@ -15,7 +15,7 @@ /* Debugfs parent dir */ static struct dentry *cosm_dbg; -/** +/* * log_buf_show - Display MIC kernel log buffer * * log_buf addr/len is read from System.map by user space @@ -68,7 +68,7 @@ static int log_buf_show(struct seq_file *s, void *unused) DEFINE_SHOW_ATTRIBUTE(log_buf); -/** +/* * force_reset_show - Force MIC reset * * Invokes the force_reset COSM bus op instead of the standard reset From patchwork Tue Jun 30 13:50:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634063 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A34613B6 for ; Tue, 30 Jun 2020 13:56:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED55520780 for ; Tue, 30 Jun 2020 13:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jEf8itn3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BjQ5sEe1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED55520780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ErCnsACbyIAhgiYJkxAPy3G/1AWAE11xRCdR2s4lV2Q=; b=jEf8itn3q+HA+HbeE+lcua+vg FTf16hm1qwvkbVahwZQuF+vQOrp6BZMlswHFeb9DjT7hdUG8/B//ZMN0q1M2nG5eiqt3pk4VJKhgV xT5v5sTlqsBKnHybL0DQPY4N6mf411/Nb19fOy1yVdSfiJc6p8Ua/dpD+SfJOb63YIkhD8vppqvTC Bn7tvBqf7afyrd2m02mTXCR3vynKgoQINQNFqYv4bq23TPEVmms5cnH3rgvxn/fVHPVbGYzLrXKvI XJOx6pHChJc8grcFsa2sf/QvJIKu2JWqdcmQ70IHyzovmXg14orq0t5ePDbdHR6vOnAFlRoHF8RMm /H/YiHocA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGiR-0002uL-Fg; Tue, 30 Jun 2020 13:54:27 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfe-0001G7-IZ for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:36 +0000 Received: by mail-wr1-x444.google.com with SMTP id z15so9005508wrl.8 for ; Tue, 30 Jun 2020 06:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g8/OUfoNrwMRghF2Xm56r8amPV/zzR8eJyRX/3dxUYA=; b=BjQ5sEe1VUAWTyNZ9XCItu/X9mKXJ4kknIGy/dde60ssxdqPtrClkggPQn61sQFEbG ZUl/ATV6/LFDcAgqoPPcLSkAboYweOHujXM1A5aKjPVBj7Ey/vvrUbmwspN3CgjiX4XL uwtDzStDFzZSD08soxa7wHv3g/K/Irn5cBopE8MRlfY2fifczF1z9Qaa+QJUV30gBkrs o7NiVh+ah6uS2kdMqKwC+173SkiLajl5xtvRPO0lk/yDTw2bdI3hoMMgdKuMxQSiNNof KyQCmMWv9CY76fq7cqJIEhGstnyIIWy2OTk8+E5hvmDKKg7UnIWox7KMDxkAJ6RZLCRy 4+2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g8/OUfoNrwMRghF2Xm56r8amPV/zzR8eJyRX/3dxUYA=; b=DW1PxrTA5PFXF9jaB6sXeu2LZ9W7cRyD1O7GVzk9E5ENm5DiXEEWXoeyjFyM9UmzLc GEfWxJznYrIpxkIJ8RtLuqKyNEVNB8t4fzZNLlhNlb6LflpfToh4O08uPSZMhjGybjor qX5tb0rr8kqM1FWmczRnNFO6PgXe+MQHJoSDvkMRL4HdgkziH3Tydo0UFB7rQkKRg/6L RFKeyCF/5NQZnZ9NOf2dDWS8erAaI3JUFlcm0Qxb2sUgzuqjlWgfZdZ5WI/2CUONlM/z o/ZeNb9gGslar14mJj9jpl2rD9T6sH5gHOsa/bowNM1lBbe24sZK5w+szI7NCdi/1VZo 1J2g== X-Gm-Message-State: AOAM531+w73K3gORKgnEFvTa+GScfI2K7TLOI/cRnM8osuw/xDm2NaQD 3RIfkzLTvNWBfZE/YgNnC13OgGrM+wY= X-Google-Smtp-Source: ABdhPJyIQqjsDwJKis+cJUwdYmBjCkdXP25GxIOWJOEk9ecH3aDPL+QaOTZCX36CbfPBbD5MpTV9yw== X-Received: by 2002:adf:e948:: with SMTP id m8mr22555359wrn.398.1593525093406; Tue, 30 Jun 2020 06:51:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:32 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 18/30] misc: mic: scif: scif_api: Remove set but unused variable 'read_size' Date: Tue, 30 Jun 2020 14:50:58 +0100 Message-Id: <20200630135110.2236389-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'read_size' appears to have been assigned, but never used since the SCIF messaging and node enumeration APIs were introduced in 2015. Makes sense to simply remove it. Fixes the following W=1 warning: drivers/misc/mic/scif/scif_api.c: In function ‘_scif_recv’: drivers/misc/mic/scif/scif_api.c:1000:6: warning: variable ‘read_size’ set but not used [-Wunused-but-set-variable] 1000 | int read_size; | ^~~~~~~~~ Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_api.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/mic/scif/scif_api.c b/drivers/misc/mic/scif/scif_api.c index 781217c030a63..d7faffdd87e92 100644 --- a/drivers/misc/mic/scif/scif_api.c +++ b/drivers/misc/mic/scif/scif_api.c @@ -997,7 +997,6 @@ static int _scif_send(scif_epd_t epd, void *msg, int len, int flags) static int _scif_recv(scif_epd_t epd, void *msg, int len, int flags) { - int read_size; struct scif_endpt *ep = (struct scif_endpt *)epd; struct scifmsg notif_msg; int curr_recv_len = 0, remaining_len = len, read_count; @@ -1017,8 +1016,7 @@ static int _scif_recv(scif_epd_t epd, void *msg, int len, int flags) * important for the Non Blocking case. */ curr_recv_len = min(remaining_len, read_count); - read_size = scif_rb_get_next(&qp->inbound_q, - msg, curr_recv_len); + scif_rb_get_next(&qp->inbound_q, msg, curr_recv_len); if (ep->state == SCIFEP_CONNECTED) { /* * Update the read pointer only if the endpoint From patchwork Tue Jun 30 13:50:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634061 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 07F6414B7 for ; Tue, 30 Jun 2020 13:56:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D141920774 for ; Tue, 30 Jun 2020 13:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g9ELlurW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ze4B74SN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D141920774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUrWZuxAAeyrMhYvAvFepvE7h1NvkQ+FPDuyn3ltDic=; b=g9ELlurWVHszSUcnj0ewolBmG c5zkm5xSFKGrPEwhuaKAtAH18f8L5CBvmGh6qt1hASUA354CbxQllybakKa/RZcH1WDrGqudGmgHk AHYUoIe8etjVHY3ehNNetym1rrrp6oMp5TwD4oiJahzkSykyzc7ewDMffzuC8eipG5M3H1e2ql6yO LPvQrgMzujl55Vx+ypS+zzPx7/r4ypSErjaE4yZ9zBxSbvjki0IP1XwX2bF1zQJybOYbjedeeDGbb rBlhMrc8mQgPnr07eKlOc74OypHRRuPYjcnMja+2lcwnpsu2qHhk9VnDv+Z8eEuA5dOl2a/JFV+6Z 5KQoZ2GkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGiY-00030z-Tk; Tue, 30 Jun 2020 13:54:34 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGff-0001GK-Km for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:37 +0000 Received: by mail-wm1-x342.google.com with SMTP id w3so7223694wmi.4 for ; Tue, 30 Jun 2020 06:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DZzcRr+il6B7Wb5szs9514Q011nYXDt2b1eWYEXToMg=; b=ze4B74SNFERaaTVJaC+Vyy9gFPkffpaYoHDqnKPXapQkMmFkERaQqn16iIHhsHRn+G yJu7CcRD2h2URZMaPCPR4lxNq6wl9EhGCCPQoqSHF+jo60WsQChbaXzZvumAd4yR4FXN CZ9cix2D3iP96P1e3KDEkwHSBE+39b9H6hxax52ooGJh0ZYOc+OzfcGV7nuplasxTM5S IYiud7p8VTP9R9nV8ujiG6tWdWaRWs911QiZycDK6vvTcZb2/w7GAxUU7ZXRHILGxfTQ HrgIagryeAIhS/lDTaOIwM89w4a1G+c8uWzTWOv2Fpvayb4MasWtClkqd4jQ9qgWy//G sNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DZzcRr+il6B7Wb5szs9514Q011nYXDt2b1eWYEXToMg=; b=lHfJ1DEuPsHVsPdHRmB/irMcE7bFRN87eKh9YxGb84FD/4HPhhD27k54xJQJkdomFj qscVfWJ4o7wgJNuuPYzLFXPcDIaPS2M7T1Vs+a7q6Qp2EGRrpjQgCZgyY0rpTsacQ0E6 vhngVDJg1X5CWW6AVtYnmk3ct57RcFaj+Nka5f6aLvtJY3Cpxcp+CxPaSjvPZ79+TeeB juC1COYUcS0jvWPBzgJA0KCJvWMwQkz7PGNJPwda8dCQUhHTJVH3D/739dBhbKjfaUbW mXDL7BIO7/gCIYaA6d2FML+om5+wvTbZc78vhKUCw11EmNXFxYrqCuLe/MRgl79disyJ Z/uQ== X-Gm-Message-State: AOAM530yXWGVy7ohls5VROwO3oGJ3x6IXjst1eXpw3AQPAJcLp6NzWjM ya4fmpk2S6wAiy7cVo2sW6n/rg== X-Google-Smtp-Source: ABdhPJxyqQHdVZGRJovPYRIq+ziAdoNs4/aOWvvPnANoKN6II3dppM9ZNMFHnOC3zBh8CS1Nwt2Upw== X-Received: by 2002:a1c:e209:: with SMTP id z9mr21892593wmg.153.1593525094264; Tue, 30 Jun 2020 06:51:34 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:33 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 19/30] misc: mic: scif: scif_api: Demote scif_accept() function header Date: Tue, 30 Jun 2020 14:50:59 +0100 Message-Id: <20200630135110.2236389-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The correct format is not used and no attempt has been made to document the function arguments. Makes sense to just demote the header back down to a simple comment. Fixes the following W=1 warnings: drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'epd' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'peer' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'newepd' not described in 'scif_accept' drivers/misc/mic/scif/scif_api.c:739: warning: Function parameter or member 'flags' not described in 'scif_accept' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/scif/scif_api.c b/drivers/misc/mic/scif/scif_api.c index d7faffdd87e92..9cc6b2a6cf229 100644 --- a/drivers/misc/mic/scif/scif_api.c +++ b/drivers/misc/mic/scif/scif_api.c @@ -713,7 +713,7 @@ int scif_connect(scif_epd_t epd, struct scif_port_id *dst) } EXPORT_SYMBOL_GPL(scif_connect); -/** +/* * scif_accept() - Accept a connection request from the remote node * * The function accepts a connection request from the remote node. Successful From patchwork Tue Jun 30 13:51:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634065 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A4EB912 for ; Tue, 30 Jun 2020 13:57:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C72E20780 for ; Tue, 30 Jun 2020 13:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nQUT4smf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NyAGhIIq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C72E20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FmxgZASy1xmssmKQqti3SO7sRdMdC4f6QQC9Fo0lT3k=; b=nQUT4smfz34CRetk2t/1MDpIl v+BgwnTLysWqrY6rAANgZU8BOg47YWkJBwMOxZMJphulYqHp46XFEp42tW/UORvxaHeZRVnhBgDHI wjkadsafoW1XbQZo33nvpPYzNkSSUF4mfk0+Z+fc0HK5E2/EmpcHBVYmTV4CqbuNrPvjh6fGNyQg1 leXiDHcnBjL/lF9Cm28Esr1R0Bas/4JVzaHWH8H7G3SK4kWvCedw7WckBHOjNk5U94U+/QGAQ1sUr q8mN30z7HN0T45JK60/mW71PyR/SOj642WUfD8ATHNpCJw3Rl0w+5r2RbYYtiNOIqAc2vDgdZIRaw jfdQVpbqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGiq-0003Bm-UD; Tue, 30 Jun 2020 13:54:53 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfg-0001Ga-AF for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so16013560wmm.0 for ; Tue, 30 Jun 2020 06:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y0hPzbcINWUoj1nY9cM2w0ma0wuqc7/tUG8vEbWtQrA=; b=NyAGhIIq7tcUSetuycocG2Az7Rg27v0X3CZksZSP3YxgxoL2mqxpSTNv2VQRW+hw24 I2FpCK17236jluMXVrlB/I/SQORS/Oy3FQt/a3J5d/LQg4whDZBdx1uBcFP/IcCd+bY+ 2Oj03YvKxENikAh+NNcGwqNrA5szR+ChUeWCvRZcOf6HADFgwewaWFba+Yi8IcRQQlfZ kWyJ/0Gsl+UgCA02fH0QESE7xvtuIZtaW58qxxurPSnQUIQ9TAqf8KwZ6tqNh+AYLQ0S Dfcr4Ci3M1KGdXcdgBDuKtB7jCXXcE0oUft7kdyQrI62CGQkmT8s9zmi1u9BpeTzcWao kxPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y0hPzbcINWUoj1nY9cM2w0ma0wuqc7/tUG8vEbWtQrA=; b=Qbjk34d7jsuxkYmq1dz9Qwj7mnjrPqT0nrgtdSWodroDsCoNL3Ouj4YUGgNwcvHuAZ Rc4pbLWD1nolR24O3nmgbDO07Fl+9e68OhkpzHHrbdexTOD3V6SufAJuWQXxUXuIVRBD rddWR2I//77m91lNqHQ/YowKIfzJutH2YKkkfeDigWfmVpfumQmr4Twi2QUEXbKT7z17 6I23QH1FLVQL5+wCfD6bH2K1QKVZyDtuzkmo7SOV3N7VFJ5k24oJ2IotNd13uRPuvncy T2227gBLWzfslbfxuXLZ0459iiyh7WND27RHks0dVlPAOYmrQNa2FVtBOvOTlxaDODbE baJA== X-Gm-Message-State: AOAM533te53PR5gcaJ8gXn/+PhZe7yfaHlY8RKPSW1m8QM2mXBKpj3O0 w/qq+rD5RCpJTjHoSb+489bqLA== X-Google-Smtp-Source: ABdhPJxWWWQuwmxxv7qT6mU94toirjTBOKwjxi7sdSOqWkv+QHH/hAXbCM5wLN+DsnyGnN5Bs7fqXw== X-Received: by 2002:a05:600c:c1:: with SMTP id u1mr22176559wmm.48.1593525095077; Tue, 30 Jun 2020 06:51:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:34 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 20/30] misc: mic: scif: scif_epd: Describe missing 'scifdev' argument(s) Date: Tue, 30 Jun 2020 14:51:00 +0100 Message-Id: <20200630135110.2236389-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org For some reason (copy 'n' paste error?) the passed in pointers to 'struct scif_dev scifdev' weren't described throughout the source file. Change that. Fixes the following W=1 kernel build warning(s): drivers/misc/mic/scif/scif_epd.c:120: warning: Function parameter or member 'scifdev' not described in 'scif_cnctreq' drivers/misc/mic/scif/scif_epd.c:166: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt' drivers/misc/mic/scif/scif_epd.c:191: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_ack' drivers/misc/mic/scif/scif_epd.c:213: warning: Function parameter or member 'scifdev' not described in 'scif_cnctgnt_nack' drivers/misc/mic/scif/scif_epd.c:230: warning: Function parameter or member 'scifdev' not described in 'scif_cnctrej' drivers/misc/mic/scif/scif_epd.c:255: warning: Function parameter or member 'scifdev' not described in 'scif_discnct' drivers/misc/mic/scif/scif_epd.c:309: warning: Function parameter or member 'scifdev' not described in 'scif_discnt_ack' drivers/misc/mic/scif/scif_epd.c:325: warning: Function parameter or member 'scifdev' not described in 'scif_clientsend' drivers/misc/mic/scif/scif_epd.c:341: warning: Function parameter or member 'scifdev' not described in 'scif_clientrcvd' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_epd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/misc/mic/scif/scif_epd.c b/drivers/misc/mic/scif/scif_epd.c index 590baca9dc7bf..426687f6696b5 100644 --- a/drivers/misc/mic/scif/scif_epd.c +++ b/drivers/misc/mic/scif/scif_epd.c @@ -104,6 +104,7 @@ void scif_cleanup_zombie_epd(void) /** * scif_cnctreq() - Respond to SCIF_CNCT_REQ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * This message is initiated by the remote node to request a connection @@ -155,6 +156,7 @@ void scif_cnctreq(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt() - Respond to SCIF_CNCT_GNT interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * An accept() on the remote node has occurred and sent this message @@ -181,6 +183,7 @@ void scif_cnctgnt(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt_ack() - Respond to SCIF_CNCT_GNTACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote connection request has finished mapping the local memory. @@ -203,6 +206,7 @@ void scif_cnctgnt_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctgnt_nack() - Respond to SCIF_CNCT_GNTNACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote connection request failed to map the local memory it was sent. @@ -221,6 +225,7 @@ void scif_cnctgnt_nack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_cnctrej() - Respond to SCIF_CNCT_REJ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote end has rejected the connection request. Set the end @@ -240,6 +245,7 @@ void scif_cnctrej(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_discnct() - Respond to SCIF_DISCNCT interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * The remote node has indicated close() has been called on its end @@ -301,6 +307,7 @@ void scif_discnct(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_discnct_ack() - Respond to SCIF_DISCNT_ACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side has indicated it has not more references to local resources @@ -317,6 +324,7 @@ void scif_discnt_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_clientsend() - Respond to SCIF_CLIENT_SEND interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side is confirming send or receive interrupt handling is complete. @@ -333,6 +341,7 @@ void scif_clientsend(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_clientrcvd() - Respond to SCIF_CLIENT_RCVD interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side is confirming send or receive interrupt handling is complete. From patchwork Tue Jun 30 13:51:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634067 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0506E13B6 for ; Tue, 30 Jun 2020 13:57:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 883D820780 for ; Tue, 30 Jun 2020 13:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dFgN47TA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jPfxIEh0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 883D820780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1d3xIlpGD+gHBQ4yjNXYjoMroURXA/EP6cwKnO/+Pe4=; b=dFgN47TAHc+S3S2I/mGS200CT fOrg9b/HWhcZAykumbdd420QmvsWoU0Eakb+wWmVIgF9mdeeWkT6UmOQYUTDbGGnoEqms1TOlgFK4 Jgi/geeduQcq73u1Exq7/EQc0EYomKdtCTR40paE7OutywZdJ+pcuIBhOQBCaSGWCnMqiGdJDDBuB p/w37gyVozXNuyecVwl0EXqRJgKqMZU7dvpv9OtAQbpCI55c4/kGTOh7eGhnS+NHkdM8/EeZYFia8 VRXU5x6Hc7Dako9MY5IAoPBGRb7D0e9193IZeful7JIMTElFQrDmDTrAowPtRhaaX/khYTtWFoM+b HFiZcs0zQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGjF-0003R9-5d; Tue, 30 Jun 2020 13:55:17 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfh-0001Gv-6Q for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:39 +0000 Received: by mail-wm1-x344.google.com with SMTP id o2so19687491wmh.2 for ; Tue, 30 Jun 2020 06:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ihwB2j52q4JKu9sE46KLVBy86wjLuHmVQi4idxjX6zQ=; b=jPfxIEh0bd6mQeJBi3dfCfnz54R8uS9N1AKe094sja57OTdh7rY41T9MU+O33WQwwg T1+5SlqMCsiKM0opraHCUtSIiPqNE7mQGkyE6C2N7TQynygN1R8SWdr/QoAgphFup8BS 2gQPTmG2Xk3e4tHyeeKZzZZjqf26WxbdyZwZzEM8OphbpdBiIIy+r9oIgMnE/IkdisCU JoZZzFbyrXwCVlFvxTAUmVvDxfU6jNg03HGRHSSwlBPKmqv0ZeecC5mNPJMKMhN3BCHx DpmQTj7fMq1LovJnDKyxm6MHE9MpEqkhJ37cOyvIeM7aMDGrKEzNl//uWAEaK6cWX72g SrFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ihwB2j52q4JKu9sE46KLVBy86wjLuHmVQi4idxjX6zQ=; b=Qg/kTibHZ6mIQ02P6W08fLG8V7ZYI5cIgzCKiiW0ussLOr23ss/Ei7URls722BEdK5 CDEYb1j8Z2/s2yipdyB3HtGYpwslKxTm4XJ/Xgmz8LiJa18tw3/rAAnfl6pEn4+koDvr rTxeC1ls2Z+ZfZ9eLyWLw+h+rNDOvy+GFQ5QKMbbERmb0KujgPbPG+xkBOayYGh8klxo y5HLCsPPBg+EC/jcdS9Los8WnDWbv+ndDYny7MA+JHczmXliJCK7DffIkNYiEGsvGepQ 1yQIVmQget1SJQ8ZtQO6Lw630z4HEjSsq26QZd01zqAOw30rkgBf5us99CtjRPxO+T8q zefA== X-Gm-Message-State: AOAM533XUGuME9LeZ5Lr0pCQ/kX6vfhqW0USMl3WtqZefkfED3KWke1n Y0jQfeMbViNW1oemgQUEs5TFBg== X-Google-Smtp-Source: ABdhPJwp/CjHlacUxa2kMksjFUGRqeD5bMMYnbpDQLiy+y+GNkw0gzTcf+QJ4WXu3l9LWEGeTdO0DA== X-Received: by 2002:a1c:a557:: with SMTP id o84mr21910730wme.42.1593525096056; Tue, 30 Jun 2020 06:51:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:35 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 21/30] misc: mic: scif: scif_nodeqp: Fix a bunch of kerneldoc issues Date: Tue, 30 Jun 2020 14:51:01 +0100 Message-Id: <20200630135110.2236389-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Includes; missing function argument documentation, misnamed argument tags, the promotion of obvious kerneldoc header candidates and an ordering issue (functions must follow the kerneldoc which describes them). Fixes the following W=1 kernel build issues: drivers/misc/mic/scif/scif_nodeqp.c:452: warning: Function parameter or member 'scifdev' not described in 'scif_node_connect' drivers/misc/mic/scif/scif_nodeqp.c:730: warning: Function parameter or member 'unused' not described in 'scif_exit' drivers/misc/mic/scif/scif_nodeqp.c:730: warning: Excess function parameter 'msg' description in 'scif_exit' drivers/misc/mic/scif/scif_nodeqp.c:748: warning: Function parameter or member 'unused' not described in 'scif_exit_ack' drivers/misc/mic/scif/scif_nodeqp.c:748: warning: Excess function parameter 'msg' description in 'scif_exit_ack' drivers/misc/mic/scif/scif_nodeqp.c:939: warning: Function parameter or member 'scifdev' not described in 'scif_node_add_nack' drivers/misc/mic/scif/scif_nodeqp.c:988: warning: Function parameter or member 'scifdev' not described in 'scif_get_node_info_resp' drivers/misc/mic/scif/scif_nodeqp.c:1070: warning: cannot understand function prototype: 'int scif_max_msg_id = SCIF_MAX_MSG; ' drivers/misc/mic/scif/scif_nodeqp.c:1129: warning: Function parameter or member 'unused' not described in 'scif_loopb_wq_handler' drivers/misc/mic/scif/scif_nodeqp.c:1129: warning: Excess function parameter 'work' description in 'scif_loopb_wq_handler' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_nodeqp.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/misc/mic/scif/scif_nodeqp.c b/drivers/misc/mic/scif/scif_nodeqp.c index ea084626fe116..e0748be373f19 100644 --- a/drivers/misc/mic/scif/scif_nodeqp.c +++ b/drivers/misc/mic/scif/scif_nodeqp.c @@ -443,6 +443,7 @@ static void scif_deinit_p2p_info(struct scif_dev *scifdev, /** * scif_node_connect: Respond to SCIF_NODE_CONNECT interrupt message + * @scifdev: SCIF device * @dst: Destination node * * Connect the src and dst node by setting up the p2p connection @@ -719,7 +720,7 @@ scif_init(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_exit() - Respond to SCIF_EXIT interrupt message * @scifdev: Remote SCIF device node - * @msg: Interrupt message + * @unused: Interrupt message (unused) * * This function stops the SCIF interface for the node which sent * the SCIF_EXIT message and starts waiting for that node to @@ -740,7 +741,7 @@ scif_exit(struct scif_dev *scifdev, struct scifmsg *unused) /** * scif_exitack() - Respond to SCIF_EXIT_ACK interrupt message * @scifdev: Remote SCIF device node - * @msg: Interrupt message + * @unused: Interrupt message (unused) * */ static __always_inline void @@ -930,6 +931,7 @@ scif_node_add_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_node_add_nack: Respond to SCIF_NODE_ADD_NACK interrupt message + * @scifdev: Remote SCIF device node * @msg: Interrupt message * * SCIF_NODE_ADD failed, so inform the waiting wq. @@ -946,8 +948,9 @@ scif_node_add_nack(struct scif_dev *scifdev, struct scifmsg *msg) } } -/* +/** * scif_node_remove: Handle SCIF_NODE_REMOVE message + * @scifdev: Remote SCIF device node * @msg: Interrupt message * * Handle node removal. @@ -962,8 +965,9 @@ scif_node_remove(struct scif_dev *scifdev, struct scifmsg *msg) scif_handle_remove_node(node); } -/* +/** * scif_node_remove_ack: Handle SCIF_NODE_REMOVE_ACK message + * @scifdev: Remote SCIF device node * @msg: Interrupt message * * The peer has acked a SCIF_NODE_REMOVE message. @@ -979,6 +983,7 @@ scif_node_remove_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_get_node_info: Respond to SCIF_GET_NODE_INFO interrupt message + * @scifdev: Remote SCIF device node * @msg: Interrupt message * * Retrieve node info i.e maxid and total from the mgmt node. @@ -1058,6 +1063,7 @@ static void (*scif_intr_func[SCIF_MAX_MSG + 1]) scif_recv_sig_resp, /* SCIF_SIG_NACK */ }; +static int scif_max_msg_id = SCIF_MAX_MSG; /** * scif_nodeqp_msg_handler() - Common handler for node messages * @scifdev: Remote device to respond to @@ -1067,8 +1073,6 @@ static void (*scif_intr_func[SCIF_MAX_MSG + 1]) * This routine calls the appropriate routine to handle a Node Qp * message receipt */ -static int scif_max_msg_id = SCIF_MAX_MSG; - static void scif_nodeqp_msg_handler(struct scif_dev *scifdev, struct scif_qp *qp, struct scifmsg *msg) @@ -1117,7 +1121,7 @@ void scif_nodeqp_intrhandler(struct scif_dev *scifdev, struct scif_qp *qp) /** * scif_loopb_wq_handler - Loopback Workqueue Handler. - * @work: loop back work + * @unused: loop back work (unused) * * This work queue routine is invoked by the loopback work queue handler. * It grabs the recv lock, dequeues any available messages from the head From patchwork Tue Jun 30 13:51:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634069 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B8E013B6 for ; Tue, 30 Jun 2020 13:58:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFD6C20774 for ; Tue, 30 Jun 2020 13:58:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D7pT9LYJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OihDsauu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFD6C20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fpZsF2Tz3JwktoVIGW/m9I4rsCfnqDZlaso8kGyB6sM=; b=D7pT9LYJ0PU0i0xPhWjwmFYGu qpMQsirQBncVnUosjCkcy0jHBF04KbDxQjgU5ekYPsT/DNZNYsTS+Ia427H2NJTG9X6Xnae3bzQQe Fb9fb4e20+v1mzEqtXAIh+z3db0DbYHns7jv5RVQKbnykjGxno9n67noNPMjxAZFOKQqOkO571hau rTSzHuituY7F0ZXumW4ZCLjggQZ1bznf/Ypn829kKwVNHZgQd2plYHU+JYgcJOaX7NRt9c9zp9zS9 q6jQc9jPYcHLdDY429QwLMXTXXi9QX4u6FC81UGjLvXMZrXEXtAr9nSz+GEfeHQm1Mat93M19P8uf Kx+aJSuog==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGja-0003jS-3d; Tue, 30 Jun 2020 13:55:38 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfi-0001HA-Hs for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:40 +0000 Received: by mail-wm1-x342.google.com with SMTP id 17so19666023wmo.1 for ; Tue, 30 Jun 2020 06:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9c9u4tDA/tuITz0x9b4sRgCY6xDvpdYsLA/gKX2PRak=; b=OihDsauuGos+atBkAQmQ98Sb91kjMWCgnGuEglF6lG3XVluS7gxfiGT0wk9w2Y8SfH D9GTgo0Ir3t2J6nII/WVYTtVb/HJR0tonCmcM9ADBX5FLB+DhZy2VNjFbD0kXBHESIrN RVfBZLfPS04fsIkGMFbQIBroUkgdpoPqfDUgc3IHQtAiPEF0pUTrBLJCCZBiwYIJreGZ vQon9WHCo66yzUZ995FfFpSeRjj7ievLDE4/ojI7H/AqcalrBC6Fa1cPozv+hq/aed96 p/7y3KOknwmQ//WDGuRXWHvn4ONfhCXtjxIQlHAoEjnlQv1qgjyppYVqWapkXjru66dz WtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9c9u4tDA/tuITz0x9b4sRgCY6xDvpdYsLA/gKX2PRak=; b=TbWDBTHhAcKhjbzK4H4CHyAEL5of69z5In8+BDj4SccM/91bvYfn7mRgE2XzMFYitB aICeVr/7MNGPzq3qAXTM/bfLovL/tdPks4AgLP8PBsGe+w4MmsDYp4Fa1FBMkAHvXPM0 3jSANj/UV5Zn8JjeDjc848o01uL/VrSm9lffxWahFRZ5Uxe5LMXvuTYEWcxmhECRXsS1 KT0nhI6JpvUx9OoWRL/OFarE3c1/WzdUGM6t+xdFyjhUTDS7nlvMVZxVa1G3PPf0/w+v FMh2qhPGcVhWB6x7YR4dlMeTygVwK7h6lCI83BYPwJ6FxeoGz7K87g/xLuIJnJwb6UhM Vn1A== X-Gm-Message-State: AOAM531U2E20AGCGEHrJmy6cZNwblgkgBSUQiF6Y4VzCf7wUx4ER6MeX 1zkwcCvaj+OSROC+QHtr04ecdw== X-Google-Smtp-Source: ABdhPJwRlejJQlEt5qpd9gycW4xMxVnkRlVdobgJjdYhmGmJu5MUUVgXNCMeq0EgZH3mSLHi19ymmg== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr21226455wmj.20.1593525097096; Tue, 30 Jun 2020 06:51:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:36 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 22/30] misc: mic: scif: scif_nm: Supply various kerneldoc fix-ups Date: Tue, 30 Jun 2020 14:51:02 +0100 Message-Id: <20200630135110.2236389-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Includes; missing descriptions for function args, the promotion of obvious kerneldoc headers and the mis-formatting of existing argument descriptions. Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_nm.c:19: warning: Function parameter or member 'node' not described in 'scif_invalidate_ep' drivers/misc/mic/scif/scif_nm.c:173: warning: Function parameter or member 'node_id' not described in 'scif_disconnect_node' Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_nm.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/misc/mic/scif/scif_nm.c b/drivers/misc/mic/scif/scif_nm.c index c537df84539a9..c4d9422082b7d 100644 --- a/drivers/misc/mic/scif/scif_nm.c +++ b/drivers/misc/mic/scif/scif_nm.c @@ -14,6 +14,8 @@ /** * scif_invalidate_ep() - Set state for all connected endpoints * to disconnected and wake up all send/recv waitqueues + * + * @node: Node to invalidate */ static void scif_invalidate_ep(int node) { @@ -99,11 +101,10 @@ void scif_send_acks(struct scif_dev *dev) } } -/* - * scif_cleanup_scifdev - * +/** + * scif_cleanup_scifdev - Uninitialize SCIF data structures for remote + * SCIF device. * @dev: Remote SCIF device. - * Uninitialize SCIF data structures for remote SCIF device. */ void scif_cleanup_scifdev(struct scif_dev *dev) { @@ -136,8 +137,8 @@ void scif_cleanup_scifdev(struct scif_dev *dev) scif_cleanup_qp(dev); } -/* - * scif_remove_node: +/** + * scif_remove_node * * @node: Node to remove */ @@ -162,9 +163,9 @@ static int scif_send_rmnode_msg(int node, int remove_node) } /** - * scif_node_disconnect: + * scif_node_disconnect * - * @node_id[in]: source node id. + * @node_id: source node id [in] * @mgmt_initiated: Disconnection initiated from the mgmt node * * Disconnect a node from the scif network. From patchwork Tue Jun 30 13:51:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634071 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A9B413B6 for ; Tue, 30 Jun 2020 13:58:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8531A20774 for ; Tue, 30 Jun 2020 13:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bWeNd/+O"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DBX0I1Xo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8531A20774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HulKgVcdi0v+EbWVKH1Dr+xagcMyVOneEplgL/FZu2k=; b=bWeNd/+O0pY40biD7n+GRClSM RbkeDzCkcwRpLQ1hpKkdUTXGYgSatE8eymZtNn3c7RPE9ws6k0LW/EHaOGecw8Kq6mG3tffViu8yC LiGOMJIgPiUUclBxI44IAas1jS4V4jgdL2KRO0dwCR6/b7N+5iOojSHayKzpeMKpF9z5hlpw2waUY ajWcLhXiIJJ8zPnExkeiN/P8TUcJa97EMH4CqxPdm0LsYPNCVPdJZnUUQX3Kd/MGZAfZ29++fX6XC rldZ/6O0sTtpzqGOazATG4gGu6TzW4+FjNNEDfPjDiEp+RsEPUuWwQX8bPwGxfsc59SIl/znOlalH WHQ1Zu/mQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGjq-0003vp-AQ; Tue, 30 Jun 2020 13:55:54 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfj-0001Hb-Tx for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:41 +0000 Received: by mail-wm1-x343.google.com with SMTP id j18so18900423wmi.3 for ; Tue, 30 Jun 2020 06:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yU99x7wrPL/01EJwaTy/8jjc+2wcUgkGTNBMFf55IvQ=; b=DBX0I1Xoz1RB0rHsREV4F1DBHNvh6YXcIk5gJTQM+hrPpe/ulAYPEBf3SY/1fdFdwQ iTLLW0oG7YnIeQaEnVmgmsJxPq85bgnw02059tpG1WH/kSFOUkX9FEy+MxGDMeN8NuNZ TJcEhQPSsDI3Dm8CYkl12pqFw0v9tlzqY1n/QV0VEBd2omHuCM4utDdThU+PIvkGKd7a ynrV+MLQC0MeV/7OtudGaup3/p3XVgsYmofHRBHLFBgC0T9HvJI+yNsd+Ztk3Hcg/6dQ eMDPtojOGYIvAeDvoMdE/+U/0BjMDImQcGQUOYi/C4KFtRvT9ZhWC5UwQGYgPoBJtmLD 1y3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yU99x7wrPL/01EJwaTy/8jjc+2wcUgkGTNBMFf55IvQ=; b=J0SwZ3i5qE9az/EYX9gMxyUCHDht552acnYs9LyXDAWogScyfDwGVTMdQCaNdRowQw mgAzEvlQI4IZA8vcUXO7sq+RKa7V/Fdw9V6DXFxu0jDbVOS/ZLYj2FKdJ0FDLeSr6H36 BiPUevS3CJ/SKIEi8c+snZUhbxeYXgvSDLEraGy+V17XbasVByqGzBH5FJI1/NmzjCaf BSdESf88tz13YGE+gVtTY8E2ifvCN97U44gM0Sf+8LK0G82zeyr2Ofiw/Snev5WKvn1X YH7zb6njwqgKWNfP1lJ4YZT0C8kM9oUXoWfB1hYmcJAJfxd4eDChU7W7NKoVl8g59Fad vWZg== X-Gm-Message-State: AOAM53216wVQ/UdqV0KuJ9P31weufcL6iYgRKODGgQNGCXgfnIqbzQio ynUZy2Hd0mSwhXTC3nobHOtLng== X-Google-Smtp-Source: ABdhPJxxX6DLAxnAOLXJaTGQjMHo/F+wmeM2ttmW7ZKu2Qki+qguyXmwlzw33EFjUo8ZheSVrZSmCg== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr21826376wmk.77.1593525098319; Tue, 30 Jun 2020 06:51:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:37 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 23/30] misc: mic: scif: scif_dma: Fix a couple of kerneldoc issues Date: Tue, 30 Jun 2020 14:51:03 +0100 Message-Id: <20200630135110.2236389-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly demote scif_rma_destroy_tcw()'s header to a standard comment as no attempt has been made to document any of the function arguments. Secondly, provide missing description for 'prot' for scif_register_temp(). Fixes the following W=1 kernel build warnings: drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'mmn' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'start' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:110: warning: Function parameter or member 'len' not described in '__scif_rma_destroy_tcw' drivers/misc/mic/scif/scif_dma.c:344: warning: Function parameter or member 'prot' not described in 'scif_register_temp' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c index c7c873409184c..401b98e5ad79a 100644 --- a/drivers/misc/mic/scif/scif_dma.c +++ b/drivers/misc/mic/scif/scif_dma.c @@ -99,7 +99,7 @@ int scif_reserve_dma_chan(struct scif_endpt *ep) } #ifdef CONFIG_MMU_NOTIFIER -/** +/* * scif_rma_destroy_tcw: * * This routine destroys temporary cached windows @@ -332,6 +332,7 @@ static bool scif_rma_tc_can_cache(struct scif_endpt *ep, size_t cur_bytes) * @epd: End Point Descriptor. * @addr: virtual address to/from which to copy * @len: length of range to copy + * @prot: read/write protection * @out_offset: computed offset returned by reference. * @out_window: allocated registered window returned by reference. * From patchwork Tue Jun 30 13:51:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634097 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B496B912 for ; Tue, 30 Jun 2020 13:59:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 658062083E for ; Tue, 30 Jun 2020 13:59:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBd3LY0B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LYXvdcqD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 658062083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ed9b7Fxmsw/qrtlQbGaejBmthrBtYDyJ0fl460rCrMY=; b=PBd3LY0BvODETQmYvxbQuTT2g cu/BInYfago+sNtKq+VY6pQnHSsdhVhjAqIlvSyqRnZuBSx0vmBkS9gLgGhxhqefSgJCHprx9OGez /a94rmIlMETGHhgJVvMlIoUa/+tLSe64SlodJIC3n3k0P6hizepZjU1HLDIHme6BWqQsWC+QI06Y2 Z6WIRAtFRRYsA8MQwZluuj2n6wLYUjTfeWRC7JWArv0sigPTgXUpQgIPeRCR4eAMarKonsvZuRbzR dz0hcaSSfQoLzVxiPVaxOI/gL0GrpyknhY7oGqVL9bkS4P6eFjilQbDdTDuzM3sj2MA1LxX9pfIiL 7cWQDauow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGkx-0004VY-6a; Tue, 30 Jun 2020 13:57:04 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfk-0001Ht-IM for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:41 +0000 Received: by mail-wr1-x444.google.com with SMTP id g18so20318325wrm.2 for ; Tue, 30 Jun 2020 06:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WbXNfDHMBERrHFjsyxyOToTajDh8zV3mfokRINKpnhg=; b=LYXvdcqDzA2qwHzkZ1KiY139X2ckq17/1uJ6MncswuJ14+qyU1/l+amCCdwI3ZI8+I mchIzeCBvkv4eAojs/t6eHfgwtVGlgbLhVLiGvmRCZBQb1T9UCg/rDSh7NrQuemXCeja EPC8Gveblq/YRqoMvNdbnOIRANIOeT99Ukar2pZrQu/kcIzpQTO+4/Q2jSW/sjdVzkMp 8Ku7LlikoumI8Cl5D6NtE9RLxUOFH87HIO6YqnrPNQFUa5lZB/S5xU4qBV+S0cWAt26k oRtkQCDoMnnEt3xBs9Y15PQvtkMjqkSoIVRgcjYxfCZujByshyOi+7FbcL/umevJ80Rd XwIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WbXNfDHMBERrHFjsyxyOToTajDh8zV3mfokRINKpnhg=; b=qNBzc1aPZjKT1U23iIfXzd5uVm9Ojui5HZONpwAOI8qhWwTaX+zh3uiO2hL12WB17m D8CdgXkDqFGhL5D/ku5UFez9iDndP1RYEHZGysqCT+bbZZOHynkDRpizk0rCV8Gpevma cfTrREWZwl28K9t0bl8Oxgczoe7m1n+xPC2yezG6kTxIuprZapl7Zkgr5L5PbfqvGIV2 D53Mt7+EPbjM4CQFLJxABhpfBnUpVqgBjneF9oBqKr0iRmR69MbMORlMKI3v6SrXWoJK VDxUoS0/UOWU/E40EP/kBHBTDGhLsCs2bVQ1fphzwbDZd20M2qDpqYzt/E7rAAivlnkf MrHw== X-Gm-Message-State: AOAM532mlQ9pgDZQ7Alup1qr9XCP0VOEDZNPKJRWRNEdhM5S1f7nEMwj QRJ739aWX0Qn6W13xPcPfd4oBA== X-Google-Smtp-Source: ABdhPJys4mwAgYke7AvLq6KmzbX8oSCnKjm8Sx7aH4Z47QBuT+4/XDTnm3Z3UpmhYRqg7Un1vAYsDg== X-Received: by 2002:adf:aad3:: with SMTP id i19mr22175200wrc.359.1593525099374; Tue, 30 Jun 2020 06:51:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:38 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 24/30] misc: mic: scif: scif_fence: Fix a bunch of different documentation issues Date: Tue, 30 Jun 2020 14:51:04 +0100 Message-Id: <20200630135110.2236389-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly add missing descriptions for every use of 'scifdev', then correct incorrect formatting of existing function argument descriptions changing to the expected format of '@.*: ', finally add missing description for function argument 'mark'. Fixes the following W=1 warnings: drivers/misc/mic/scif/scif_fence.c:19: warning: Function parameter or member 'scifdev' not described in 'scif_recv_mark' drivers/misc/mic/scif/scif_fence.c:41: warning: Function parameter or member 'scifdev' not described in 'scif_recv_mark_resp' drivers/misc/mic/scif/scif_fence.c:64: warning: Function parameter or member 'scifdev' not described in 'scif_recv_wait' drivers/misc/mic/scif/scif_fence.c:101: warning: Function parameter or member 'scifdev' not described in 'scif_recv_wait_resp' drivers/misc/mic/scif/scif_fence.c:122: warning: Function parameter or member 'scifdev' not described in 'scif_recv_sig_local' drivers/misc/mic/scif/scif_fence.c:143: warning: Function parameter or member 'scifdev' not described in 'scif_recv_sig_remote' drivers/misc/mic/scif/scif_fence.c:164: warning: Function parameter or member 'scifdev' not described in 'scif_recv_sig_resp' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'epd' not described in 'scif_send_fence_signal' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'roff' not described in 'scif_send_fence_signal' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'rval' not described in 'scif_send_fence_signal' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'loff' not described in 'scif_send_fence_signal' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'lval' not described in 'scif_send_fence_signal' drivers/misc/mic/scif/scif_fence.c:515: warning: Function parameter or member 'flags' not described in 'scif_send_fence_signal' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_fence.c | 34 ++++++++++++++++++------------ 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/misc/mic/scif/scif_fence.c b/drivers/misc/mic/scif/scif_fence.c index 657fd4a206565..4fedf6183951c 100644 --- a/drivers/misc/mic/scif/scif_fence.c +++ b/drivers/misc/mic/scif/scif_fence.c @@ -11,6 +11,7 @@ /** * scif_recv_mark: Handle SCIF_MARK request + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has requested a mark. @@ -33,6 +34,7 @@ void scif_recv_mark(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_mark_resp: Handle SCIF_MARK_(N)ACK messages. + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has responded to a SCIF_MARK message. @@ -56,6 +58,7 @@ void scif_recv_mark_resp(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_wait: Handle SCIF_WAIT request + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has requested waiting on a fence. @@ -93,6 +96,7 @@ void scif_recv_wait(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_wait_resp: Handle SCIF_WAIT_(N)ACK messages. + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has responded to a SCIF_WAIT message. @@ -114,6 +118,7 @@ void scif_recv_wait_resp(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_sig_local: Handle SCIF_SIG_LOCAL request + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has requested a signal on a local offset. @@ -135,6 +140,7 @@ void scif_recv_sig_local(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_sig_remote: Handle SCIF_SIGNAL_REMOTE request + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has requested a signal on a remote offset. @@ -156,6 +162,7 @@ void scif_recv_sig_remote(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_sig_resp: Handle SCIF_SIG_(N)ACK messages. + * @scifdev: SCIF device * @msg: Interrupt message * * The peer has responded to a signal request. @@ -280,12 +287,12 @@ static int _scif_prog_signal(scif_epd_t epd, dma_addr_t dst, u64 val) return err; } -/* +/** * scif_prog_signal: - * @epd - Endpoint Descriptor - * @offset - registered address to write @val to - * @val - Value to be written at @offset - * @type - Type of the window. + * @epd: Endpoint Descriptor + * @offset: registered address to write @val to + * @val: Value to be written at @offset + * @type: Type of the window. * * Arrange to write a value to the registered offset after ensuring that the * offset provided is indeed valid. @@ -501,12 +508,12 @@ static int _scif_send_fence_signal_wait(struct scif_endpt *ep, /** * scif_send_fence_signal: - * @epd - endpoint descriptor - * @loff - local offset - * @lval - local value to write to loffset - * @roff - remote offset - * @rval - remote value to write to roffset - * @flags - flags + * @epd: endpoint descriptor + * @loff: local offset + * @lval: local value to write to loffset + * @roff: remote offset + * @rval: remote value to write to roffset + * @flags: flags * * Sends a remote fence signal request */ @@ -577,10 +584,11 @@ static void scif_fence_mark_cb(void *arg) atomic_dec(&ep->rma_info.fence_refcount); } -/* +/** * _scif_fence_mark: + * @epd: endpoint descriptor + * @mark: DMA mark to set-up * - * @epd - endpoint descriptor * Set up a mark for this endpoint and return the value of the mark. */ int _scif_fence_mark(scif_epd_t epd, int *mark) From patchwork Tue Jun 30 13:51:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634127 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4BD11138C for ; Tue, 30 Jun 2020 14:00:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1A3B206BE for ; Tue, 30 Jun 2020 14:00:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fghH7NHx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d7k/5kR1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1A3B206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WiVFRaN3aJuUafkIxVKuJnMnMzriUqI8dctNBL9JbYA=; b=fghH7NHxvMntm28wi0jNW52QD ruiHPEWfIpfv+CMQ6jmtH2wRmcjUSH5So8xF2oajvImFnDpO2NWfybEF1C/oDoEe4/NtIFNp/ikB5 O4EN5omlPKVi8OnOs6MpreqQ0LTj0hetV9yw9SLnSgKbolTdNM7klZPB6Q3pm2c8RjexYhHJxr/QK X/Xi9ImIhNue/QJMaFLyG3McMnWIC4e/3cotYKMOpqn3S0xkqjytzAwcWoF73tTlV8GJ0mNVso4w1 9irHnU2uEOXr6Ih+YLbs6UEUHff6SGrzf1aJbHpSJP1CGfmqkrn9FRfuC/0FmK2vtz7qnmLL+Kgth BJ13SIFPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGlx-0004uG-Pg; Tue, 30 Jun 2020 13:58:06 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfl-0001IM-IJ for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id 17so19666189wmo.1 for ; Tue, 30 Jun 2020 06:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y1zDXtnu4nYqM822JS90Uin0HwiZbzzdDBFpt66EWWs=; b=d7k/5kR1qiJB9I8wUeO83oekbSzZU46dMeScb0EzHVURvCyrbXk22BSOWM13XyQfXA L3RPHyLinXF2f6JXJeD2Fg1c6YkaXr7SR3yfuhwD2YXqQhVqJ9YX4k8AjZsbGyp4FGQZ BzvEp6WPUEno848z2J9xukGRDZ7BFdONeFmHe0p3+qPu7B9kHH4RBtMrYlGJsbmkWDCV y7jAs2hIF5HP+6I81qf2QOcBLnlVbmEU4BzDpO0o1Hnb67F4ZTc/SIqxJRriKk7MbTfu y8wY4Rz8ziEOXnTvSEN0ADNEg+jEFmj9Hj+jdifuGZusImdpAjBegKAr2hdrfDYj8RzI C5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y1zDXtnu4nYqM822JS90Uin0HwiZbzzdDBFpt66EWWs=; b=ZKFwQvKI8cVtwuPw7Xs0HtneEZkS13SER1MsUOGzQhC8EpUNEr/bEyF+pl4hCDmpIk J/hTn7cHvasHD8tIvNYiQAp5Mg55A0voVjOZFQwFF5XJ4ufW0fGeB2OKjMG0246fGMGT LwHEWvPq1/j5vL+u8/G/VKcJ33Uj9l5mQNnm/NBZzzmuZn3hWOGLVBYf7EvMkpyMhkXX Tbk9xZezgCnyDG5fZvyXlM/EFfU4wHbtFOZ/0t+lny0tOMGl/0wFHnLAWlZmYS97sy4O W1zsxpRSNztwHOyQmHXf81qm5wBF0vJcrlJh7vgFRgfPdTBNeB6YUl2YSl5fc7C7f8DO 3qfA== X-Gm-Message-State: AOAM531kmfXctH6O9TJIwocaOW/D0S4DGJBriN46dvUTU9k093BgJ1tm dQ3pIJI1A8vFhvpT770amU3gbopJ9c4= X-Google-Smtp-Source: ABdhPJzsUzBMER02528kWrOC9qgDSaXSh2ak8iFAlndL0t+7FKAxkUl019ETK2s+ggIgnhv+g5sDVQ== X-Received: by 2002:a1c:98cc:: with SMTP id a195mr21391693wme.89.1593525100565; Tue, 30 Jun 2020 06:51:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:39 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 25/30] misc: mic: scif: scif_rma: Repair a bunch of kerneldoc issues Date: Tue, 30 Jun 2020 14:51:05 +0100 Message-Id: <20200630135110.2236389-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ashutosh Dixit , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Dutt Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Firstly, for some reason documentation of all 'scifdev' arguments are missing, so apply those. Also remove 2 descriptions of 'ep' which appear to document non-existent function arguments. drivers/misc/mic/scif/scif_rma.c:468: warning: Function parameter or member 'scifdev' not described in 'scif_create_remote_window' drivers/misc/mic/scif/scif_rma.c:468: warning: Excess function parameter 'ep' description in 'scif_create_remote_window' drivers/misc/mic/scif/scif_rma.c:510: warning: Excess function parameter 'ep' description in 'scif_destroy_remote_window' drivers/misc/mic/scif/scif_rma.c:1045: warning: Function parameter or member 'scifdev' not described in 'scif_alloc_req' drivers/misc/mic/scif/scif_rma.c:1080: warning: Function parameter or member 'scifdev' not described in 'scif_alloc_gnt_rej' drivers/misc/mic/scif/scif_rma.c:1104: warning: Function parameter or member 'scifdev' not described in 'scif_free_virt' drivers/misc/mic/scif/scif_rma.c:1142: warning: Function parameter or member 'scifdev' not described in 'scif_recv_reg' drivers/misc/mic/scif/scif_rma.c:1178: warning: Function parameter or member 'scifdev' not described in 'scif_recv_unreg' drivers/misc/mic/scif/scif_rma.c:1243: warning: Function parameter or member 'scifdev' not described in 'scif_recv_reg_ack' drivers/misc/mic/scif/scif_rma.c:1262: warning: Function parameter or member 'scifdev' not described in 'scif_recv_reg_nack' drivers/misc/mic/scif/scif_rma.c:1280: warning: Function parameter or member 'scifdev' not described in 'scif_recv_unreg_ack' drivers/misc/mic/scif/scif_rma.c:1299: warning: Function parameter or member 'scifdev' not described in 'scif_recv_unreg_nack' Cc: Sudeep Dutt Cc: Ashutosh Dixit Signed-off-by: Lee Jones --- drivers/misc/mic/scif/scif_rma.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c index 406cd5abfa726..de8f61efaef5c 100644 --- a/drivers/misc/mic/scif/scif_rma.c +++ b/drivers/misc/mic/scif/scif_rma.c @@ -458,7 +458,7 @@ static void scif_destroy_remote_lookup(struct scif_dev *remote_dev, /** * scif_create_remote_window: - * @ep: end point + * @scifdev: SCIF device * @nr_pages: number of pages in window * * Allocate and prepare a remote registration window. @@ -500,7 +500,6 @@ scif_create_remote_window(struct scif_dev *scifdev, int nr_pages) /** * scif_destroy_remote_window: - * @ep: end point * @window: remote registration window * * Deallocate resources for remote window. @@ -1037,6 +1036,7 @@ void scif_free_window_offset(struct scif_endpt *ep, /** * scif_alloc_req: Respond to SCIF_ALLOC_REQ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side is requesting a memory allocation. @@ -1072,6 +1072,7 @@ void scif_alloc_req(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_alloc_gnt_rej: Respond to SCIF_ALLOC_GNT/REJ interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remote side responded to a memory allocation. @@ -1096,6 +1097,7 @@ void scif_alloc_gnt_rej(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_free_virt: Respond to SCIF_FREE_VIRT interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Free up memory kmalloc'd earlier. @@ -1134,6 +1136,7 @@ scif_fixup_aper_base(struct scif_dev *dev, struct scif_window *window) /** * scif_recv_reg: Respond to SCIF_REGISTER interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Update remote window list with a new registered window. @@ -1170,6 +1173,7 @@ void scif_recv_reg(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_unreg: Respond to SCIF_UNREGISTER interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Remove window from remote registration list; @@ -1235,6 +1239,7 @@ void scif_recv_unreg(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_reg_ack: Respond to SCIF_REGISTER_ACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Wake up the window waiting to complete registration. @@ -1253,6 +1258,7 @@ void scif_recv_reg_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_reg_nack: Respond to SCIF_REGISTER_NACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Wake up the window waiting to inform it that registration @@ -1272,6 +1278,7 @@ void scif_recv_reg_nack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_unreg_ack: Respond to SCIF_UNREGISTER_ACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Wake up the window waiting to complete unregistration. @@ -1290,6 +1297,7 @@ void scif_recv_unreg_ack(struct scif_dev *scifdev, struct scifmsg *msg) /** * scif_recv_unreg_nack: Respond to SCIF_UNREGISTER_NACK interrupt message + * @scifdev: SCIF device * @msg: Interrupt message * * Wake up the window waiting to inform it that unregistration From patchwork Tue Jun 30 13:51:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634129 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 450A5138C for ; Tue, 30 Jun 2020 14:01:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEE7B206BE for ; Tue, 30 Jun 2020 14:01:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AnbrF1Ey"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hvqllLl1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEE7B206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9SI9D2wTIeQDoPz8Fimv8K1fOMwi2ZqpfPsVlDXIxSk=; b=AnbrF1EyVFpWT7UzqdFOjVUg3 X1449ReVGN1HBZFfLDmH/yLUoPD2A1Zj2gI7hk3HR9Y4I+NTr36VRTVOxwtsBvdYCu5huXdPhChhZ i/NZ52blp7Kf+ZtedjJrOQ//Y5wjAAvVlhzBPn8Zi7bjRingY5ipuYNZAHQVRZSTCk8Clhtgiksui MEi94vKSvlKpk6V0vaNF5ZRsTgapif7pgMHT1OERIanFK4kBhXoqktNvJcgtre6Z3ovtXRYL7yNQc F4BCkMrOSkBDLLdAL/2FavJGlZALH1NtqP21kC/vJSDlIhHi0Ziwg2TwqaKayPcM9gEPIsUxxW+YT li2Kc8e3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGmj-0005GQ-2G; Tue, 30 Jun 2020 13:58:53 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfm-0001Iq-OL for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:44 +0000 Received: by mail-wm1-x344.google.com with SMTP id l2so18192236wmf.0 for ; Tue, 30 Jun 2020 06:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XHXWFB9CtCq3ogRoTXjYaAYG+vDjtwvgXpZpFIdOYUs=; b=hvqllLl1pn0fatf/QsCkR7Paee5bgvm0WeS+Joju1W2knw4rOIxqtF8Wm+Zd5pvEe8 GoX/KnP89+9iW2Xbpy8h8z0bvLxExRdZ9OKDSLwyiSa5DvtS2vVETgmjXcl1ptlC6fRD P8C0LFP3/W8lQl21D8XVlp4UmiRd8MtWlkpo5AtnqcW1mM4cve/yg2D1ZCVTrLUVpv5v fdR9ocabGIPny5c6K3qt/6oPd+jAMIUuq+KD28kCas/xzpPYjmVn1gFcOsLbI23SrPrw 9bqNhAyEzfRXdIb8wLt19KfIIaJL6xolGLI9R988mc1PX0CKEaFHGilGUcVnc4FSRIza oNig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XHXWFB9CtCq3ogRoTXjYaAYG+vDjtwvgXpZpFIdOYUs=; b=A5cyspHKAjhBRQ14Z4f2/TTS4NcQ9+zWdIZNYyiM54VDspbV1DMnz7DlievwKwJrHW NvvPvSNAITncHm/4bTyL7Mfv8uniaionDfe/mzMVSVtDURVc9nyIAWz6odDIqWms+uS5 BTbaWbyU/OlM/MGnU6EmQkWcQGlML0hs81dfSnf7B5xHYO+WiV+PsZ7d9lz6WlxMjlwy yt4FzurSRgeIJ2K1wyj4L3j+6M4aoIrMn650U4BscjPWnWL7Wmg6YyFPAifRnWUXe0Qn Yz2Tnrp6uhTFoTV6LMeGS23DsZzOUfuqYkmESQpvD4JNYo6puBJUQVaGMkyJVQRUkiE5 R3mg== X-Gm-Message-State: AOAM53081GHRqkw5KUvbX821zVf3RIfo2niNCJVxRBAHnONTRO++g94F hb863b9PVdg5gMc8ZFmUA16SAgfDIFM= X-Google-Smtp-Source: ABdhPJy8971wuT/pclHPRWG3d6DRtSEvF8CePSBrYNq9om1ZWVq5Pob2KizrOYchZ8agKjF2/t3iMQ== X-Received: by 2002:a1c:96ce:: with SMTP id y197mr13876541wmd.86.1593525101687; Tue, 30 Jun 2020 06:51:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:40 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used Date: Tue, 30 Jun 2020 14:51:06 +0100 Message-Id: <20200630135110.2236389-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wolfram Sang , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/misc/eeprom/at24.c:228:36: warning: ‘at24_acpi_ids’ defined but not used [-Wunused-const-variable=] Cc: Wolfram Sang Signed-off-by: Lee Jones --- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 9ff18d4961ceb..2591c21b2b5d8 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = { }; MODULE_DEVICE_TABLE(of, at24_of_match); -static const struct acpi_device_id at24_acpi_ids[] = { +static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = { { "INT3499", (kernel_ulong_t)&at24_data_INT3499 }, { "TPF0001", (kernel_ulong_t)&at24_data_24c1024 }, { /* END OF LIST */ } From patchwork Tue Jun 30 13:51:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634135 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 64913912 for ; Tue, 30 Jun 2020 14:02:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FFDB206BE for ; Tue, 30 Jun 2020 14:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="StA4WO6h"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Tpifyogt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FFDB206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tz+TlWA9soeSTg+e/tA4vEtEItGRzZkhytq/zbOYbmQ=; b=StA4WO6h+OXzIeeiJ9Li8lPqH nwZVPMr5S//OCVvtl0BqDiYHeqM64j4kY3EU/V2o0+svNdRpDMuoU9qNRXg3tCm29f/Ne+cPL+aIz n6sNLlXauAgaVSW9s4nPJNsyRec/3rjkjUfFd5J7VF2Nr/i+eDOIZtR6cBtIqO6SF2yfooElsfE2H z2XIi/7uESUnetEBJ0mpmNk2dtiNzKniv/bU3n5O/RsNr2iAG/1USDeVa7yCM38EYZwGBL0dunm29 rmCGbJqql8zuKnas92oqBSm+KolJaHRQA1uMHSBFBRjj2yl2Qi3nYBcEsgl9DaVkZpEjmQ2HgNZ42 LHt/YlPrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGnw-0005qf-Ua; Tue, 30 Jun 2020 14:00:09 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfn-0001JF-TP for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:47 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so20237258wrw.12 for ; Tue, 30 Jun 2020 06:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7Vgj6mJ007ffR2XpxkUWmsRKmQ1//Tce8MuBu+oPzlU=; b=TpifyogtmSQyoYQkRCsDn943WBZc7wqFAHoz5GIiSpG94b7uokBuZwOSI3krYEDuIZ rFXoISEx06/BbuCR5VaMBQujjIk44C2m3HNDPGCyDaWpb7154AzN435wx/tD0npm9m+v R65mNjskdTU6G0NRxvyTGhXjBReTvGUeBKaqJJnLBm3CTy2N/FTEAd7Of9BLBWysQGWr 1nx6FcwuKJv2b0fwL/qC/HkpqhsYGRH+GBnF81zCDMv+S4YKI3ZGYxBHFQTFMImlMZ4V mSkC43Hxq9EClkoTAWRsHGtsbVNSchBai6am4E8ViMGIjYvNOhAQxw0LTiOZPVJeEirj pMsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7Vgj6mJ007ffR2XpxkUWmsRKmQ1//Tce8MuBu+oPzlU=; b=BX9ayVrBAhkWnUS16nhVA/DPIIrJOl3LDoZ8SjwEzIb2QxCu+n2Vm2bzYtYuo/+HXN 2DlZoMbbMjL59wFQaEqe41U3p6/hfyoDjXhU3H02fdniep952YZw+mrgVNA+ArUmpRnZ 5TzfQYaJ09H5a2lfEzWY9GZ3Sv/NyQUVdHW2iQyqkGxk5+6beXcHIIetoamU+a9XiwT3 gqIaXs7LQmqI4SUbG22q7niBtoKc/5HtDenTM/rMH6Wk6SVG5oDeL0oDHYqjs/vizz1W V2CfoGCS07K/MaB04AKHmKQ4hPPAmW/YKHmVm5WYS6J+/q/25ShZZABi2PDBZNU1MRps hpVg== X-Gm-Message-State: AOAM532gFyDGXqqbNi9zFPA3AHJKkbvvvqeb4jCjF8HUZ2cUPv52z/mN mOWuwwOzNZqmn9MRE3wNkb+Hhg== X-Google-Smtp-Source: ABdhPJx721IVepbgyMmVRJlfPKLFs9l9eVG25Gkt/1drnG8PPf9M+3ev+koLG4DTEaifYuBuIbULTA== X-Received: by 2002:adf:edc6:: with SMTP id v6mr22116585wro.413.1593525102783; Tue, 30 Jun 2020 06:51:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:42 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 27/30] misc: cxl: hcalls: Demote half-assed kerneldoc attempt Date: Tue, 30 Jun 2020 14:51:07 +0100 Message-Id: <20200630135110.2236389-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Donnellan , Lee Jones , linux-kernel@vger.kernel.org, Frederic Barrat , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Function headers will need a lot of work before they reach the standards expected of kerneldoc. Demote them down to basic comments/headers, for now at least. Fixes the following W=1 kernel build warnings: drivers/misc/cxl/hcalls.c:175: warning: Function parameter or member 'unit_address' not described in 'cxl_h_detach_process' drivers/misc/cxl/hcalls.c:175: warning: Function parameter or member 'process_token' not described in 'cxl_h_detach_process' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'unit_address' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'op' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'p1' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'p2' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'p3' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'p4' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:207: warning: Function parameter or member 'out' not described in 'cxl_h_control_function' drivers/misc/cxl/hcalls.c:245: warning: Function parameter or member 'unit_address' not described in 'cxl_h_reset_afu' drivers/misc/cxl/hcalls.c:258: warning: Function parameter or member 'unit_address' not described in 'cxl_h_suspend_process' drivers/misc/cxl/hcalls.c:258: warning: Function parameter or member 'process_token' not described in 'cxl_h_suspend_process' drivers/misc/cxl/hcalls.c:271: warning: Function parameter or member 'unit_address' not described in 'cxl_h_resume_process' drivers/misc/cxl/hcalls.c:271: warning: Function parameter or member 'process_token' not described in 'cxl_h_resume_process' drivers/misc/cxl/hcalls.c:284: warning: Function parameter or member 'unit_address' not described in 'cxl_h_read_error_state' drivers/misc/cxl/hcalls.c:284: warning: Function parameter or member 'state' not described in 'cxl_h_read_error_state' drivers/misc/cxl/hcalls.c:300: warning: Function parameter or member 'unit_address' not described in 'cxl_h_get_afu_err' drivers/misc/cxl/hcalls.c:300: warning: Function parameter or member 'offset' not described in 'cxl_h_get_afu_err' drivers/misc/cxl/hcalls.c:300: warning: Function parameter or member 'buf_address' not described in 'cxl_h_get_afu_err' drivers/misc/cxl/hcalls.c:300: warning: Function parameter or member 'len' not described in 'cxl_h_get_afu_err' drivers/misc/cxl/hcalls.c:320: warning: Function parameter or member 'unit_address' not described in 'cxl_h_get_config' drivers/misc/cxl/hcalls.c:320: warning: Function parameter or member 'cr_num' not described in 'cxl_h_get_config' drivers/misc/cxl/hcalls.c:320: warning: Function parameter or member 'offset' not described in 'cxl_h_get_config' drivers/misc/cxl/hcalls.c:320: warning: Function parameter or member 'buf_address' not described in 'cxl_h_get_config' drivers/misc/cxl/hcalls.c:320: warning: Function parameter or member 'len' not described in 'cxl_h_get_config' drivers/misc/cxl/hcalls.c:333: warning: Function parameter or member 'unit_address' not described in 'cxl_h_terminate_process' drivers/misc/cxl/hcalls.c:333: warning: Function parameter or member 'process_token' not described in 'cxl_h_terminate_process' drivers/misc/cxl/hcalls.c:351: warning: Function parameter or member 'unit_address' not described in 'cxl_h_collect_vpd' drivers/misc/cxl/hcalls.c:351: warning: Function parameter or member 'record' not described in 'cxl_h_collect_vpd' drivers/misc/cxl/hcalls.c:351: warning: Function parameter or member 'list_address' not described in 'cxl_h_collect_vpd' drivers/misc/cxl/hcalls.c:351: warning: Function parameter or member 'num' not described in 'cxl_h_collect_vpd' drivers/misc/cxl/hcalls.c:351: warning: Function parameter or member 'out' not described in 'cxl_h_collect_vpd' drivers/misc/cxl/hcalls.c:362: warning: Function parameter or member 'unit_address' not described in 'cxl_h_get_fn_error_interrupt' drivers/misc/cxl/hcalls.c:362: warning: Function parameter or member 'reg' not described in 'cxl_h_get_fn_error_interrupt' drivers/misc/cxl/hcalls.c:374: warning: Function parameter or member 'unit_address' not described in 'cxl_h_ack_fn_error_interrupt' drivers/misc/cxl/hcalls.c:374: warning: Function parameter or member 'value' not described in 'cxl_h_ack_fn_error_interrupt' drivers/misc/cxl/hcalls.c:386: warning: Function parameter or member 'unit_address' not described in 'cxl_h_get_error_log' drivers/misc/cxl/hcalls.c:386: warning: Function parameter or member 'value' not described in 'cxl_h_get_error_log' drivers/misc/cxl/hcalls.c:399: warning: Function parameter or member 'unit_address' not described in 'cxl_h_collect_int_info' drivers/misc/cxl/hcalls.c:399: warning: Function parameter or member 'process_token' not described in 'cxl_h_collect_int_info' drivers/misc/cxl/hcalls.c:399: warning: Function parameter or member 'info' not described in 'cxl_h_collect_int_info' drivers/misc/cxl/hcalls.c:440: warning: Function parameter or member 'unit_address' not described in 'cxl_h_control_faults' drivers/misc/cxl/hcalls.c:440: warning: Function parameter or member 'process_token' not described in 'cxl_h_control_faults' drivers/misc/cxl/hcalls.c:440: warning: Function parameter or member 'control_mask' not described in 'cxl_h_control_faults' drivers/misc/cxl/hcalls.c:440: warning: Function parameter or member 'reset_mask' not described in 'cxl_h_control_faults' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'unit_address' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'op' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'p1' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'p2' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'p3' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'p4' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:480: warning: Function parameter or member 'out' not described in 'cxl_h_control_facility' drivers/misc/cxl/hcalls.c:516: warning: Function parameter or member 'unit_address' not described in 'cxl_h_reset_adapter' drivers/misc/cxl/hcalls.c:532: warning: Function parameter or member 'unit_address' not described in 'cxl_h_collect_vpd_adapter' drivers/misc/cxl/hcalls.c:532: warning: Function parameter or member 'list_address' not described in 'cxl_h_collect_vpd_adapter' drivers/misc/cxl/hcalls.c:532: warning: Function parameter or member 'num' not described in 'cxl_h_collect_vpd_adapter' drivers/misc/cxl/hcalls.c:532: warning: Function parameter or member 'out' not described in 'cxl_h_collect_vpd_adapter' drivers/misc/cxl/hcalls.c:561: warning: Function parameter or member 'unit_address' not described in 'cxl_h_download_facility' drivers/misc/cxl/hcalls.c:561: warning: Function parameter or member 'op' not described in 'cxl_h_download_facility' drivers/misc/cxl/hcalls.c:561: warning: Function parameter or member 'list_address' not described in 'cxl_h_download_facility' drivers/misc/cxl/hcalls.c:561: warning: Function parameter or member 'num' not described in 'cxl_h_download_facility' drivers/misc/cxl/hcalls.c:561: warning: Function parameter or member 'out' not described in 'cxl_h_download_facility' drivers/misc/cxl/hcalls.c:626: warning: Function parameter or member 'unit_address' not described in 'cxl_h_download_adapter_image' drivers/misc/cxl/hcalls.c:626: warning: Function parameter or member 'list_address' not described in 'cxl_h_download_adapter_image' drivers/misc/cxl/hcalls.c:626: warning: Function parameter or member 'num' not described in 'cxl_h_download_adapter_image' drivers/misc/cxl/hcalls.c:626: warning: Function parameter or member 'out' not described in 'cxl_h_download_adapter_image' drivers/misc/cxl/hcalls.c:639: warning: Function parameter or member 'unit_address' not described in 'cxl_h_validate_adapter_image' drivers/misc/cxl/hcalls.c:639: warning: Function parameter or member 'list_address' not described in 'cxl_h_validate_adapter_image' drivers/misc/cxl/hcalls.c:639: warning: Function parameter or member 'num' not described in 'cxl_h_validate_adapter_image' Cc: Frederic Barrat Cc: Andrew Donnellan Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/misc/cxl/hcalls.c | 42 +++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/misc/cxl/hcalls.c b/drivers/misc/cxl/hcalls.c index b7c57f67f4f52..aba5e20eeb1f5 100644 --- a/drivers/misc/cxl/hcalls.c +++ b/drivers/misc/cxl/hcalls.c @@ -167,7 +167,7 @@ long cxl_h_attach_process(u64 unit_address, } } -/** +/* * cxl_h_detach_process - Detach a process element from a coherent * platform function. */ @@ -197,7 +197,7 @@ long cxl_h_detach_process(u64 unit_address, u64 process_token) } } -/** +/* * cxl_h_control_function - This H_CONTROL_CA_FUNCTION hypervisor call allows * the partition to manipulate or query * certain coherent platform function behaviors. @@ -238,7 +238,7 @@ static long cxl_h_control_function(u64 unit_address, u64 op, } } -/** +/* * cxl_h_reset_afu - Perform a reset to the coherent platform function. */ long cxl_h_reset_afu(u64 unit_address) @@ -249,7 +249,7 @@ long cxl_h_reset_afu(u64 unit_address) NULL); } -/** +/* * cxl_h_suspend_process - Suspend a process from being executed * Parameter1 = process-token as returned from H_ATTACH_CA_PROCESS when * process was attached. @@ -262,7 +262,7 @@ long cxl_h_suspend_process(u64 unit_address, u64 process_token) NULL); } -/** +/* * cxl_h_resume_process - Resume a process to be executed * Parameter1 = process-token as returned from H_ATTACH_CA_PROCESS when * process was attached. @@ -275,7 +275,7 @@ long cxl_h_resume_process(u64 unit_address, u64 process_token) NULL); } -/** +/* * cxl_h_read_error_state - Checks the error state of the coherent * platform function. * R4 contains the error state @@ -288,7 +288,7 @@ long cxl_h_read_error_state(u64 unit_address, u64 *state) state); } -/** +/* * cxl_h_get_afu_err - collect the AFU error buffer * Parameter1 = byte offset into error buffer to retrieve, valid values * are between 0 and (ibm,error-buffer-size - 1) @@ -304,7 +304,7 @@ long cxl_h_get_afu_err(u64 unit_address, u64 offset, NULL); } -/** +/* * cxl_h_get_config - collect configuration record for the * coherent platform function * Parameter1 = # of configuration record to retrieve, valid values are @@ -324,7 +324,7 @@ long cxl_h_get_config(u64 unit_address, u64 cr_num, u64 offset, NULL); } -/** +/* * cxl_h_terminate_process - Terminate the process before completion * Parameter1 = process-token as returned from H_ATTACH_CA_PROCESS when * process was attached. @@ -337,7 +337,7 @@ long cxl_h_terminate_process(u64 unit_address, u64 process_token) NULL); } -/** +/* * cxl_h_collect_vpd - Collect VPD for the coherent platform function. * Parameter1 = # of VPD record to retrieve, valid values are between 0 * and (ibm,#config-records - 1). @@ -355,7 +355,7 @@ long cxl_h_collect_vpd(u64 unit_address, u64 record, u64 list_address, out); } -/** +/* * cxl_h_get_fn_error_interrupt - Read the function-wide error data based on an interrupt */ long cxl_h_get_fn_error_interrupt(u64 unit_address, u64 *reg) @@ -365,7 +365,7 @@ long cxl_h_get_fn_error_interrupt(u64 unit_address, u64 *reg) 0, 0, 0, 0, reg); } -/** +/* * cxl_h_ack_fn_error_interrupt - Acknowledge function-wide error data * based on an interrupt * Parameter1 = value to write to the function-wide error interrupt register @@ -378,7 +378,7 @@ long cxl_h_ack_fn_error_interrupt(u64 unit_address, u64 value) NULL); } -/** +/* * cxl_h_get_error_log - Retrieve the Platform Log ID (PLID) of * an error log */ @@ -390,7 +390,7 @@ long cxl_h_get_error_log(u64 unit_address, u64 value) NULL); } -/** +/* * cxl_h_collect_int_info - Collect interrupt info about a coherent * platform function after an interrupt occurred. */ @@ -425,7 +425,7 @@ long cxl_h_collect_int_info(u64 unit_address, u64 process_token, } } -/** +/* * cxl_h_control_faults - Control the operation of a coherent platform * function after a fault occurs. * @@ -470,7 +470,7 @@ long cxl_h_control_faults(u64 unit_address, u64 process_token, } } -/** +/* * cxl_h_control_facility - This H_CONTROL_CA_FACILITY hypervisor call * allows the partition to manipulate or query * certain coherent platform facility behaviors. @@ -509,7 +509,7 @@ static long cxl_h_control_facility(u64 unit_address, u64 op, } } -/** +/* * cxl_h_reset_adapter - Perform a reset to the coherent platform facility. */ long cxl_h_reset_adapter(u64 unit_address) @@ -520,7 +520,7 @@ long cxl_h_reset_adapter(u64 unit_address) NULL); } -/** +/* * cxl_h_collect_vpd - Collect VPD for the coherent platform function. * Parameter1 = 4K naturally aligned real buffer containing block * list entries @@ -536,7 +536,7 @@ long cxl_h_collect_vpd_adapter(u64 unit_address, u64 list_address, out); } -/** +/* * cxl_h_download_facility - This H_DOWNLOAD_CA_FACILITY * hypervisor call provide platform support for * downloading a base adapter image to the coherent @@ -616,7 +616,7 @@ static long cxl_h_download_facility(u64 unit_address, u64 op, } } -/** +/* * cxl_h_download_adapter_image - Download the base image to the coherent * platform facility. */ @@ -629,7 +629,7 @@ long cxl_h_download_adapter_image(u64 unit_address, list_address, num, out); } -/** +/* * cxl_h_validate_adapter_image - Validate the base image in the coherent * platform facility. */ From patchwork Tue Jun 30 13:51:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634131 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B2C03138C for ; Tue, 30 Jun 2020 14:02:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3605E206E9 for ; Tue, 30 Jun 2020 14:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mxjPLa6H"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TTWz3kQi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3605E206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XL1+ks7+mapaiJWhLFzRJt9GOVx6upSTLxSbrqaUfh4=; b=mxjPLa6H7Dy6hpp8NVK2mbGQ7 LHR4H/f7Dcn1Ek+4oLDy7U4HdRd+aXnDByZWovUXeCCGOcN7LLFEyzEQIAdgGY0JTbHhhIgcLnfuT wo0secN1/+GmcAtoV22fQ/XbcIwFPljxnMfKTA0117FarUZP6dxR0au9yhuXPbHkoHecHnzWfTF5F a0yhOOZ4pgfl9oeuGbDTzCKLplLYqDnhi4k9nqN9psfNTrpTHG8im1XecfOmSse2yibW1wGlT05AK PX6Ybh/z+sVkfaONf5ZkD5lEw4UakQaUY231QfufspkkiogZGtcaYl6zMh+ElOoW099oEQifYZPop kXIoLVo+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGnN-0005e3-3Q; Tue, 30 Jun 2020 13:59:33 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfo-0001JX-SA for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:46 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so19675584wmf.5 for ; Tue, 30 Jun 2020 06:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wkBklcgolThuSqx2B9FGDRJ2fQUF+10AbLJBzITnPbk=; b=TTWz3kQiTzBuca298CfBMS58ag+bVWHWFEQdNDu9C1/PN/lY6EyJ+tgg5gFUVnhl5Y jlXcfraF1hxROmd3FRyUNLm3DWxMTagFU4Jzmxrjk03uYoJMBVmM50Fk17nCcENFff7l VpuFlVFptef5rsjSkbqRJOg16a9ZddGY/Btdr7e/BdQ435+Gu0zF9saFRJFU/VsYtbjH aKf4HahUOxW6bcYHyRwiuaWGgH2XQvgiqQzDVvnQVmDgZG7nM4/L3LYwLg8waw2y+3xB 1TlptulEwTSHjHG+aEC0qopP/o3e/sb+oK7NvFdiJXhd6uEI6ECNffztfSwHOK5IumFc orCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wkBklcgolThuSqx2B9FGDRJ2fQUF+10AbLJBzITnPbk=; b=rL3/HL1+X4/fs+pNdz9jKBWHw3W9vV8jW2wsLhZZDqXNm6PTRs+JzfkaBJgmfYDfwR ufKcuFGviqoxMjagqp/KogNVHhhyiCIBzGox5suoTQg4pUBjbhB+5AzTyYW2Hdet1r0L T/F7YL/MFF8SyM8cBC/Y3+LVhWCAxT3Bxvld8P0euyQnUH1e6swqMOeADytDr4aU/Wkk BbxxIvQaAoQD94oyrJKTJX+59+YPlTaEakySOGwQxEW32/fFWdJEhDobeLutI1DtzBB4 DiAjKZ5BBTrKC6JaYriU7ZH3jmERso+yfUF0/xoJpDHNEmu9q2qINBMB3EJLv4dYla3c y2/Q== X-Gm-Message-State: AOAM5304W6aXUti1vuPNjHSM6o5hB+1B9yKdC/eZs3ZsXLMLtUc5SMQv voDi/d0gIGrlPvU5dpe89LsqVA== X-Google-Smtp-Source: ABdhPJxrpKuIXyZ4jZXgdzGC5pflyyO+oF9AqHsNWY4gxzEb6UyNUUElbKvxkAnL54GMA/mXFAjShQ== X-Received: by 2002:a1c:1b90:: with SMTP id b138mr21475735wmb.21.1593525103867; Tue, 30 Jun 2020 06:51:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:43 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 28/30] misc: ocxl: config: Provide correct formatting to function headers Date: Tue, 30 Jun 2020 14:51:08 +0100 Message-Id: <20200630135110.2236389-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Donnellan , Lee Jones , linux-kernel@vger.kernel.org, Frederic Barrat , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org A nice attempt was made to provide kerneldoc headers for read_template_version() and read_afu_lpc_memory_info() however, the provided formatting does not match what is expected by kerneldoc. Fixes the following W=1 warnings: drivers/misc/ocxl/config.c:286: warning: Function parameter or member 'dev' not described in 'read_template_version' drivers/misc/ocxl/config.c:286: warning: Function parameter or member 'fn' not described in 'read_template_version' drivers/misc/ocxl/config.c:286: warning: Function parameter or member 'len' not described in 'read_template_version' drivers/misc/ocxl/config.c:286: warning: Function parameter or member 'version' not described in 'read_template_version' drivers/misc/ocxl/config.c:489: warning: Function parameter or member 'dev' not described in 'read_afu_lpc_memory_info' drivers/misc/ocxl/config.c:489: warning: Function parameter or member 'fn' not described in 'read_afu_lpc_memory_info' drivers/misc/ocxl/config.c:489: warning: Function parameter or member 'afu' not described in 'read_afu_lpc_memory_info' Cc: Frederic Barrat Cc: Andrew Donnellan Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/misc/ocxl/config.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index c8e19bfb5ef90..e3b99a39d207e 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -273,11 +273,11 @@ static int read_afu_info(struct pci_dev *dev, struct ocxl_fn_config *fn, } /** - * Read the template version from the AFU - * dev: the device for the AFU - * fn: the AFU offsets - * len: outputs the template length - * version: outputs the major<<8,minor version + * read_template_version - Read the template version from the AFU + * @dev: the device for the AFU + * @fn: the AFU offsets + * @len: outputs the template length + * @version: outputs the major<<8,minor version * * Returns 0 on success, negative on failure */ @@ -476,10 +476,10 @@ static int validate_afu(struct pci_dev *dev, struct ocxl_afu_config *afu) } /** - * Populate AFU metadata regarding LPC memory - * dev: the device for the AFU - * fn: the AFU offsets - * afu: the AFU struct to populate the LPC metadata into + * read_afu_lpc_memory_info - Populate AFU metadata regarding LPC memory + * @dev: the device for the AFU + * @fn: the AFU offsets + * @afu: the AFU struct to populate the LPC metadata into * * Returns 0 on success, negative on failure */ From patchwork Tue Jun 30 13:51:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDB01138C for ; Tue, 30 Jun 2020 14:03:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2FD1206BE for ; Tue, 30 Jun 2020 14:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rxRA6sPX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bzdyYWsf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2FD1206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XIiyOmsC7lUimBl7Z8qs0IfVC+Q6RP0lPM01334fSBw=; b=rxRA6sPXthrBqYOA7/jOj8HKB drWGKXP3fJeeVROjKgXYLbq6GVtxMGapvxJbsHJCLQFLlnShnJid8EuJu5QsBeRXmwa0SvIwdIqr6 TFBqga/wmZqzwUM0kUyh69p80BYpMkGUqpKUxCjZ9edpWpcYWveGgUKMzbq1OJZIezd1dC6bokFzq daoyNjAf0+7oIFHlQZyAvcaSyddSnDCa9+5YHXfPTwqU6UuGWQn0fb7RLO+X2AYKOfN4xL5wPtJQy uK4wC2+arRSH/Kxv8zfjpnJkND6CKwP6x8DeTDVvI11vEdRpABIqcqsb4Bbo8j3uQNAT6NRhx+RZX gvP8u6a0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGoV-00067t-LK; Tue, 30 Jun 2020 14:00:43 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfq-0001K1-0v for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:47 +0000 Received: by mail-wm1-x343.google.com with SMTP id j18so18900791wmi.3 for ; Tue, 30 Jun 2020 06:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DSh3DJM1KgVnqn7Sv/MtEFwOqhHf99gGKru6VjHaA6Q=; b=bzdyYWsfGs9+EldNffhY0jZ/Xs/sS8GuliDUstrvPp9uYq6bQ/V5+lA5ZwfBeDmWm/ i8m0UsGubprm9i/yZvA4l4TgVUivXrQfprf8t059FkPOjiDcVyjmQj8nOvJOixgrjgpL FgH1DuWJLz1B7oW2UybhBcX1rRi30VWbI7HNOqyD8U3YHbd/OvtJJjaqHU16CPtbGbve G+Ixv8V2cY2+TJvAIDBBSQPtk37vfanmlq7o41evKhr+kwCbKrEhwKj01jrnZTx6sWMx wSWW5htUaAUZrogFsTAnp32Egcjm7dxxxbBN/B1F4FDgSK+guhmaftONIhiv02gc+XuP svnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DSh3DJM1KgVnqn7Sv/MtEFwOqhHf99gGKru6VjHaA6Q=; b=dmrSqArIiYo99mPgCfDvMXDQhX7eQr+WyPzP1D0ew1675+7T9JoPpLUe4Tw7gCATsx RikkMcP34r+ldylVOjMJiqJbC96uMliJgELMRjFQyiQsiDP0mQxxqSFmqVMs0PoQqDyW 61R7BFM2tYox4qg8qjiCl22UzBjzAjL1ZxFNn95+m8Ipgf7uSmWYt5t9JBoaTgiKL9eS yXVT8I14MOHtxuj3rNTqy21y/houtqyyFU63DjMkHFrow6Y1t965bxsJjPNkn2BoEMCr z1x9axp6qXtxoVnQ7T/cp2xcqsNzhjw0j0/TOoWiEeia2+Vn+biGBZQq0NdX7Mm544JM Urrg== X-Gm-Message-State: AOAM531Qf7ApCFZMojVv/cjF3iUXZtLsn6Epgr/x3n7bSq+cGG/7h/WB m/G4hxj5HWqWsBbLB8LO0tCBDQ== X-Google-Smtp-Source: ABdhPJydVK1MOk6qSoAzDSES+irwf5HdKi8xQQKwPP2tVuZl3KYPm79LNmnKWydLfpyDyImm9KJShQ== X-Received: by 2002:a7b:c7c2:: with SMTP id z2mr21460539wmk.39.1593525104998; Tue, 30 Jun 2020 06:51:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:44 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 29/30] misc: ibmvmc: Repair ill-named function argument descriptions Date: Tue, 30 Jun 2020 14:51:09 +0100 Message-Id: <20200630135110.2236389-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steven Royer , Dave Engebretsen , linux-kernel@vger.kernel.org, Adam Reznechek , "Bryant G. Ly" , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Formatting is correct and descriptions are all present, but some of the argument names are not properly represented in the documentation. Fixes the following W=1 build warnings: drivers/misc/ibmvmc.c:780: warning: Function parameter or member 'msg_len' not described in 'ibmvmc_send_msg' drivers/misc/ibmvmc.c:780: warning: Excess function parameter 'msg_length' description in 'ibmvmc_send_msg' drivers/misc/ibmvmc.c:1041: warning: Function parameter or member 'buffer' not described in 'ibmvmc_write' drivers/misc/ibmvmc.c:1041: warning: Excess function parameter 'buf' description in 'ibmvmc_write' drivers/misc/ibmvmc.c:1360: warning: Function parameter or member 'file' not described in 'ibmvmc_ioctl' drivers/misc/ibmvmc.c:1360: warning: Excess function parameter 'session' description in 'ibmvmc_ioctl' Cc: Steven Royer Cc: Adam Reznechek Cc: "Bryant G. Ly" Cc: Dave Engebretsen Signed-off-by: Lee Jones --- drivers/misc/ibmvmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c index 2ed23c99f59fd..c0d139c265055 100644 --- a/drivers/misc/ibmvmc.c +++ b/drivers/misc/ibmvmc.c @@ -760,7 +760,7 @@ static int ibmvmc_send_rem_buffer_resp(struct crq_server_adapter *adapter, * @adapter: crq_server_adapter struct * @buffer: ibmvmc_buffer struct * @hmc: ibmvmc_hmc struct - * @msg_length: message length field + * @msg_len: message length field * * This command is sent between the management partition and the hypervisor * in order to signal the arrival of an HMC protocol message. The command @@ -1028,7 +1028,7 @@ static unsigned int ibmvmc_poll(struct file *file, poll_table *wait) * ibmvmc_write - Write * * @file: file struct - * @buf: Character buffer + * @buffer: Character buffer * @count: Count field * @ppos: Offset * @@ -1347,7 +1347,7 @@ static long ibmvmc_ioctl_requestvmc(struct ibmvmc_file_session *session, /** * ibmvmc_ioctl - IOCTL * - * @session: ibmvmc_file_session struct + * @file: file information * @cmd: cmd field * @arg: Argument field * From patchwork Tue Jun 30 13:51:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11634141 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CCB71912 for ; Tue, 30 Jun 2020 14:03:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72D02206BE for ; Tue, 30 Jun 2020 14:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FRQAgxDY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UCptlGP8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72D02206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HeQCwKLlyP80GH56ioCUDqy6eUuOKffM1WiLoLk5UnU=; b=FRQAgxDY13dx1uJC6dzLOzxpZ CpLSTI4ZtA7jPiniWANkGGzpwx/MYdwUcasBvwTDtUrCIm0apDcoWtZzjLa7+koRVHYM78ukbpIEk x/OyzOGYIh5GhYqDVHvKf4fjruI6k8fekjLDXm9Gb+xOENMaL+nALxwfl8hnE9fQspJo7+rJKn9lR xXcLpzLh997Ajllt04i7xpcw7cuS9i7/yU1b8/yyVpTE13RFj5cEysYaMAC2geph1FgGWFUXKcFS2 Sg4kao3tyyuBADi1GPpaBf64eW8apftDJ9jKdhmTImJ25KtWY4RLuldsXZXiW7l4BjgORsuubS9EE mYjdVHN1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGou-0006QL-GE; Tue, 30 Jun 2020 14:01:08 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqGfr-0001KP-4A for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 13:51:48 +0000 Received: by mail-wm1-x344.google.com with SMTP id j18so18900925wmi.3 for ; Tue, 30 Jun 2020 06:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnszQP2mk8a9Zq/MXSfFAa0Z6TG4Q6FByatEINovmEo=; b=UCptlGP89mz89UrYfXQefNW8+e4ZQEEx97tpWiKPBMfS4wNL0irneBp0jrTF9ByhBp r3sH1OSHEMiwFz/5r7EkY9kOTSEF5j3ZoqwRqWJb8vbVNW1skrkKsOZTP5gEp9oREz8g AbeUF9AZHhUcmH/ZNDNbXyX/tcNDJePdqaFSBzXZh+af/Hh0ljo857xNngaLb/5M6uvM FDyUkltnD8NJFywjYlMdE/rEgEs1gwt7Lotc5q/rX00mU0keywb2yCIfDaovLph8enxA OTfjHeNk1H1rosvo8UqtJ7TZT8tY+d+i9r5YkK3hUsAjwQZILkkV5knsYgiZKcO7geQh 9ulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnszQP2mk8a9Zq/MXSfFAa0Z6TG4Q6FByatEINovmEo=; b=Q78b1668oPtOdVSwsmcljSOqVp3Js/w0KeG1wWLIR88Vp9k24QgM13te2xhXEPB+gG AzdprNz0LcK6nsDcUAw362seTwqmgP4pScqQ3SVOW6JiTM/wcVqRK2t5wlsmj9VLs+yD 5BwN3GutzCLbtJ/p9Dv+YYFW4n3D+RLd6vpl1SZ88oKe/wbpVfETJkc6tZaAwIG+3Tgb Q8Lyhy2z42ORFpTt9kKZsW045o7JWmefiNNXboNCNB3kC7j9JJaO+QobcZmqKZWctX++ 1IxH6Uk/xb72+fvuPRA6MSAZCD9AD4zDoD3JGw402w0H7XXjcOfSFDBfQ+X1+AiSL0Sj yXBg== X-Gm-Message-State: AOAM531BYs80RV6yt4hj0HrQ/qomqJRxX/peSVdZVYvQlsQcQNQdUSfq vWU+BjTpJ7nxw6yOcq9a6tYMtg== X-Google-Smtp-Source: ABdhPJxAVcr7BMBgpDdFrMsgoyDTsXOxDXBRszKa7Wa69xRKWCYbNprLZlHUJCgW8CUodbxVKwRxlA== X-Received: by 2002:a1c:ed17:: with SMTP id l23mr21535111wmh.175.1593525106136; Tue, 30 Jun 2020 06:51:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id t4sm3876746wmf.4.2020.06.30.06.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:51:45 -0700 (PDT) From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Subject: [PATCH 30/30] misc: cxl: flash: Remove unused pointer Date: Tue, 30 Jun 2020 14:51:10 +0100 Message-Id: <20200630135110.2236389-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630135110.2236389-1-lee.jones@linaro.org> References: <20200630135110.2236389-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Donnellan , Lee Jones , linux-kernel@vger.kernel.org, Frederic Barrat , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The DRC index pointer us updated on an OPCODE_ADD, but never actually read. Remove the used pointer and shift up OPCODE_ADD to group with OPCODE_DELETE which also provides a noop. Fixes the following W=1 kernel build warning: drivers/misc/cxl/flash.c: In function ‘update_devicetree’: drivers/misc/cxl/flash.c:178:16: warning: variable ‘drc_index’ set but not used [-Wunused-but-set-variable] 178 | __be32 *data, drc_index, phandle; | ^~~~~~~~~ Cc: Frederic Barrat Cc: Andrew Donnellan Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/misc/cxl/flash.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c index cb9cca35a2263..24e3dfcc91a74 100644 --- a/drivers/misc/cxl/flash.c +++ b/drivers/misc/cxl/flash.c @@ -175,7 +175,7 @@ static int update_devicetree(struct cxl *adapter, s32 scope) struct update_nodes_workarea *unwa; u32 action, node_count; int token, rc, i; - __be32 *data, drc_index, phandle; + __be32 *data, phandle; char *buf; token = rtas_token("ibm,update-nodes"); @@ -206,15 +206,12 @@ static int update_devicetree(struct cxl *adapter, s32 scope) switch (action) { case OPCODE_DELETE: + case OPCODE_ADD: /* nothing to do */ break; case OPCODE_UPDATE: update_node(phandle, scope); break; - case OPCODE_ADD: - /* nothing to do, just move pointer */ - drc_index = *data++; - break; } } }