From patchwork Mon Oct 15 20:44:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10642459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97EB7157A for ; Mon, 15 Oct 2018 20:44:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8148228AFF for ; Mon, 15 Oct 2018 20:44:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D83529053; Mon, 15 Oct 2018 20:44:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0190428AFF for ; Mon, 15 Oct 2018 20:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725917AbeJPEbk (ORCPT ); Tue, 16 Oct 2018 00:31:40 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41743 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbeJPEbj (ORCPT ); Tue, 16 Oct 2018 00:31:39 -0400 Received: by mail-pg1-f195.google.com with SMTP id 23-v6so9709589pgc.8 for ; Mon, 15 Oct 2018 13:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eQMGNDfhm/QbCjUyIYjH4w5gwm9UjkQ3AvQiY8q6jd4=; b=Vgchs/xcn7XdhBYUssm3n/xXwqsMfdkL2IkF0yUYsrrwtlhrK4Vre2yoYBlMmkTN/8 HHx50uCCyJyQ5lAed0UxYHUOzFBnXEG4TsMuYxYTValSsQ5WT72+VMRGOGSEsOB8ifuB rBCJrE8OwDA3hOMkl/uVA+fAFgkJdvHUf/LI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eQMGNDfhm/QbCjUyIYjH4w5gwm9UjkQ3AvQiY8q6jd4=; b=n+A6GR9ARSdb0pztWGLckC4XLaPct1Ka5wRsZdkQktkIc9z5MSgu55rA68CUUYyP6U E4SMKYGeCwAJkfuK/T2VCxYCbAX146PM5xmPYjimxs4tQlaN+Xv0JGpL+O/8QXFyr3tI neRrCHJzgIR5WpMgZLDoMmvmcBLkcbBZRrDjSpeUVadFW4+b6Rxy4R/rKVWCDT66vhNl YHrSOiab3ceytVeybH5xh2ZYdKeIuQSvZgiYTT9P/4r/fXKTBXzCp+JVvWeyJOXmFCWZ gBaEICnyqQnXr2UcZrCZ6YLauP7veyyalBWtd2MreOpeo7tbukl1fkiAb2WSPDNZQtNS 5Ofg== X-Gm-Message-State: ABuFfohyGtcI04uhMhISvJNJze+C+yW/4T2dIMHsF2DVwyISiKMUF+lW oVUcjXOweeLttF5nWbiKnfoBiQ== X-Google-Smtp-Source: ACcGV60KQYfrFj/y0aiFT6U6U4RK9u0DrM3lE3lLn8ZPqX48jLDqUgA+iMgDj5jfHqyz+0sdrM9GWA== X-Received: by 2002:a62:6506:: with SMTP id z6-v6mr19017676pfb.20.1539636285522; Mon, 15 Oct 2018 13:44:45 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id o62-v6sm14639565pfb.0.2018.10.15.13.44.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 13:44:44 -0700 (PDT) From: Douglas Anderson To: gregkh@linuxfoundation.org Cc: msavaliy@codeaurora.org, linux-arm-msm@vger.kernel.org, alokc@codeaurora.org, mka@chromium.org, evgreen@chromium.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby Subject: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Date: Mon, 15 Oct 2018 13:44:24 -0700 Message-Id: <20181015204425.84537-1-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.331.ge82ca0e54c-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL selected. If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver was setting RX_BYTES_PW to 1 for _all_ UART ports. This doesn't seem like such a good idea. Let's only set RX_BYTES_PW to 1 for the console port. Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Mukesh Kumar Savaliya --- drivers/tty/serial/qcom_geni_serial.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index d3b5261ee80a..9ee6ce725e43 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -89,9 +89,9 @@ #define MAX_LOOPBACK_CFG 3 #ifdef CONFIG_CONSOLE_POLL -#define RX_BYTES_PW 1 +#define CONSOLE_RX_BYTES_PW 1 #else -#define RX_BYTES_PW 4 +#define CONSOLE_RX_BYTES_PW 4 #endif struct qcom_geni_serial_port { @@ -853,11 +853,13 @@ static int qcom_geni_serial_port_setup(struct uart_port *uport) unsigned int rxstale = DEFAULT_BITS_PER_CHAR * STALE_TIMEOUT; u32 proto; - if (uart_console(uport)) + if (uart_console(uport)) { port->tx_bytes_pw = 1; - else + port->rx_bytes_pw = CONSOLE_RX_BYTES_PW; + } else { port->tx_bytes_pw = 4; - port->rx_bytes_pw = RX_BYTES_PW; + port->rx_bytes_pw = 4; + } proto = geni_se_read_proto(&port->se); if (proto != GENI_SE_UART) {