From patchwork Wed Jul 1 12:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95D5B13B4 for ; Wed, 1 Jul 2020 12:49:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EA7120702 for ; Wed, 1 Jul 2020 12:49:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wq3L0VmN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yk+r9H6l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EA7120702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OcW1rDVfOumT1Sei/zdAy3iSek16OPPJN+1ihmizw4c=; b=Wq3L0VmNLvOkfG1xJcBT7Mtlq A0mzgb9gmFvEJHhn7nS2iObN+wAsxVzByR6m4JitByvlPHEHXKkODELMaxCUkRSpbS63/+4hybo8U ccUcBiqv02O7trtp0zivWp2uNStfKoEWwWXXkxtrJUfqXhNBK1Vfe+2yv7YjvFjxiYwhoMlXz/FM6 Fvodztil9Ci4jzdpNUfSClNtoXAZMkUEGnSfC8IbciFFfgG+Wb5xm4IW70HMICOWw3iO+bf8ZQOXu sJg8HYbb7AY/tTbxR4iER0aqmBv47CmXYXG14JEoH9l8Djzuvi4i0ExZaWhP/eG3/nSrNRDUoTsYR dZ5fbYTCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8x-0004rc-OU; Wed, 01 Jul 2020 12:47:15 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8t-0004pA-0v for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:12 +0000 Received: by mail-wm1-x343.google.com with SMTP id w3so10634606wmi.4 for ; Wed, 01 Jul 2020 05:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=yk+r9H6lX2Cc5i0dlDYZHeHh6IaafXhdA3+cx+ukukxwN0QSjnW3v7AJbxYJahc1rJ It9z0lJpzuNfcP/Ch9oXRsRIl0RTjxEwgK1d4Xrlul48VRVT2oRTZEMpcxQchBYCm4Hf 0hSQ5kknJI7Gvwga0UCeFY1HqgqXDCC3WO9BLFuinxIrTAniduRmJTwp79YNdRxttxsp lbNiJkrLQOfUSvm+Ogb6yMaDLjrp8D6Ycy+5+Va5hhDZ7wVSQS8LKtRXxnBYkXXx5Q62 zR8Wan38GVVfXHBnLw8enlCYUQGkcw2kVwfFXLl8d7WTBo9JwwfLavhTIdmUIsfz6ql3 DZYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x8xCKIw9Ld5Xa//V32cpz9QyqhlFaWmoKz6kDT+w1CQ=; b=a2xtZARseodrdpPCbd3c5vr1G4URVQzESnldZAlPNY/C4ObpepfgEdBJOo3Egoep66 dW3/d6yCfRIlVc/BgNJMwcKiMubbb/Jzxi2BvL/rn20jIwz8CmIDs9rOQmi+epjdi1ZA 7dUF4hP3EBSUr141deSzLvecF+y+SH8OZz10B8FnMkX0P9eoJCZFqChb5NYa76KQhHD4 0dIu/q9eQvW2b8BUqMzHtHndYQ632gfVSqLvqMhfygSG9hG+Gbb+NhEVIjcU0xTK0ZR4 +tzmDajhvFCJDv0CzAq3Jddx6FwG9pMNJcrKf/u0kbRZPpYISP5GwD6AxC7XSmKE4mLj aPOA== X-Gm-Message-State: AOAM530iDIZMDEAT4zSgA8Zo78vAI9tlc8OFTF+o6rYzQb/BKzxR3QyV RUSTPQHFreiNC7Im0xjbiHWIkA== X-Google-Smtp-Source: ABdhPJxQ+Yg6i9TIajip46TH3pID9Y8RjLR+RANFA+2ocxzD+PQpg4Nb+WF2voDLYQGI8AIzZdylRg== X-Received: by 2002:a1c:7209:: with SMTP id n9mr26663783wmc.150.1593607628056; Wed, 01 Jul 2020 05:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:07 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 01/15] mmc: core: quirks: Mark fixups as __maybe_unused Date: Wed, 1 Jul 2020 13:46:48 +0100 Message-Id: <20200701124702.908713-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084711_181023_3B3098DC X-CRM114-Status: GOOD ( 15.84 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrei Warkentin , Martin Mares , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Not all source files which include quirks.h make use of the all of the available fixup information. When this happens the compiler complains that some constant variables are defined by never used. We can fix this by telling the compiler that this intentional by simply marking them as __maybe_unused. Fixes the following W=1 kernel build warnings: In file included from drivers/mmc/core/sdio.c:22: drivers/mmc/core/quirks.h:105:31: warning: ‘mmc_ext_csd_fixups’ defined but not used [-Wunused-const-variable=] 105 | static const struct mmc_fixup mmc_ext_csd_fixups[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ In file included from drivers/mmc/core/mmc.c:25: drivers/mmc/core/quirks.h:123:31: warning: ‘sdio_fixup_methods’ defined but not used [-Wunused-const-variable=] 123 | static const struct mmc_fixup sdio_fixup_methods[] = { | ^~~~~~~~~~~~~~~~~~ drivers/mmc/core/quirks.h:17:31: warning: ‘mmc_blk_fixups’ defined but not used [-Wunused-const-variable=] 17 | static const struct mmc_fixup mmc_blk_fixups[] = { | ^~~~~~~~~~~~~~ Cc: Andrei Warkentin Cc: Martin Mares Signed-off-by: Lee Jones --- drivers/mmc/core/quirks.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 472fa2fdcf139..d68e6e513a4f4 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -14,7 +14,7 @@ #include "card.h" -static const struct mmc_fixup mmc_blk_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { #define INAND_CMD38_ARG_EXT_CSD 113 #define INAND_CMD38_ARG_ERASE 0x00 #define INAND_CMD38_ARG_TRIM 0x01 @@ -102,7 +102,7 @@ static const struct mmc_fixup mmc_blk_fixups[] = { END_FIXUP }; -static const struct mmc_fixup mmc_ext_csd_fixups[] = { +static const struct mmc_fixup __maybe_unused mmc_ext_csd_fixups[] = { /* * Certain Hynix eMMC 4.41 cards might get broken when HPI feature * is used so disable the HPI feature for such buggy cards. @@ -120,7 +120,7 @@ static const struct mmc_fixup mmc_ext_csd_fixups[] = { }; -static const struct mmc_fixup sdio_fixup_methods[] = { +static const struct mmc_fixup __maybe_unused sdio_fixup_methods[] = { SDIO_FIXUP(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251, add_quirk, MMC_QUIRK_NONSTD_FUNC_IF), From patchwork Wed Jul 1 12:46:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636237 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F10EC913 for ; Wed, 1 Jul 2020 12:48:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C623B20702 for ; Wed, 1 Jul 2020 12:48:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DqcrM5pw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e2u2YFLp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C623B20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HmWiu/HAchR1ggDKjHPidIyHv8mGCp7c0GzWcv0nr74=; b=DqcrM5pws6rzOW/TJ8TWU/hK6 tVKqJA49ZWmZ+s6wqMhMg+Z9s6a/LB7h8J36ER/zOoxeX0a/Pf6MAAlfKZnw6m2P2au1ygWID1sTo 0fq1cZxWItLg6ab5HjgnU+qfrUI6mB5r6S1/mFFy9fJlsZSFEOEe73ombQnPiVR3Kmlwot1CGbEGg gFdTIZ20TBYkU8AqVp/bGVV6GeA96kcRotYDZYdxrpb0P29a2wDtvWGEQ0wKCETa/7ihE9KlwumBV AixRY6wRNbdn88MOt2X10ON6P3mA7GH7I3QHLhtEaMruRdDhcnAqtWEe3kMO1aZCVtM+EAptK/71C tINIsNpNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8v-0004qo-FY; Wed, 01 Jul 2020 12:47:13 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8s-0004pB-25 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:10 +0000 Received: by mail-wr1-x441.google.com with SMTP id b6so23636662wrs.11 for ; Wed, 01 Jul 2020 05:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jvkMg3srHyqJh6fgDfE889EmXjO6nBv1Rtq+H+tpC1c=; b=e2u2YFLpA8LpvDLvaHlAIRYF4TjmLrKeAmTHVJZcWeakRJrp85FcAGANacHaeC43IE GwT0zARyiqQqJkx2Z0jikJGsiPsqyVH6E6KLJN3pF7P+VJ6Boi9Bw2GF7/CYiIeZb1gm yAuuqSK20elxyeP0Nlf612iMeF7pF+IeCeAo8RRLLm05q9EF5rHY8bH+hhUcOr/LOOoE ChoJFEuj9WxUbgNvpCUXTY3AxUIt43te77sTOfpALDyw8aU4ycLu8q/k6yLPD/1A5i4H G1YxImumTxqHp8cEv/qHa1thvJ7T1IcJQ9dCxQwSWR8BABPukm8QzuVXPU4l/W766fZS 7pyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jvkMg3srHyqJh6fgDfE889EmXjO6nBv1Rtq+H+tpC1c=; b=uUwydWNb9b/CmyaL4KKZAvd82Mu75Svb/+MeNyoMuNeSTjKFoGCj9JowZ0/qN19Iwv pcgOiAiU07W5vVbm5FnFU2tFibPHlA9bZA1fF4Qystt89bmQdkRUZvY/PjVYA1SrTivW /hwGKW9Rdt5iVeGLTl0NHcDH9kSoIF8N80dY3VFVxcloZYDw+GEyYUCZ7e4uXUFwSois 0Vam9RDgdlL5Z0a78sj/9ReL/K8u7jkj6FLq85JGMRvkTDKWGmBR5ypLIwcQ5FrD+KY3 Cxu7Sh1/beWfOD5ZbqyKUNU9WjoTlfYVF2HKmGmpbzwXbpLWvOHThUl3LDZAapSFrmVZ +JZg== X-Gm-Message-State: AOAM530NNmh/ZvDwmuDNpfyipWqYryPjcRXTMBfeiOLUTLN0EVQJE6DU 5P43q19RDQHD4mmnv/481nbxSg== X-Google-Smtp-Source: ABdhPJwDlLXVXyGj9D0oFqPhwo60exrY7bLbST3n/Wr+UX1G4tJFRxrcFA/CqPK08eQzMC2jmrnXiA== X-Received: by 2002:a5d:6a90:: with SMTP id s16mr25932837wru.8.1593607628989; Wed, 01 Jul 2020 05:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:08 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 02/15] mmc: core: sdio_io: Provide description for sdio_set_host_pm_flags()'s 'flag' arg Date: Wed, 1 Jul 2020 13:46:49 +0100 Message-Id: <20200701124702.908713-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084710_125512_00AC19A5 X-CRM114-Status: GOOD ( 11.93 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Pierre Ossman Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Add missing kerneldoc entry for sdio_set_host_pm_flags()'s 'flag' function argument. Fixes the following W=1 kernel build warning: kernel/drivers/mmc/core/sdio_io.c:722: warning: Function parameter or member 'flags' not described in 'sdio_set_host_pm_flags' Cc: Pierre Ossman Signed-off-by: Lee Jones --- drivers/mmc/core/sdio_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index 2ba00acf64e64..b5dd893bbcb6f 100644 --- a/drivers/mmc/core/sdio_io.c +++ b/drivers/mmc/core/sdio_io.c @@ -709,6 +709,7 @@ EXPORT_SYMBOL_GPL(sdio_get_host_pm_caps); /** * sdio_set_host_pm_flags - set wanted host power management capabilities * @func: SDIO function attached to host + * @flags: Power Management flags to set * * Set a capability bitmask corresponding to wanted host controller * power management features for the upcoming suspend state. From patchwork Wed Jul 1 12:46:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636235 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DD519913 for ; Wed, 1 Jul 2020 12:48:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D8A20702 for ; Wed, 1 Jul 2020 12:48:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jWcncPyL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vT5SNW2n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3D8A20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k8ZaHoJg4T510CvdO87IiVr2iBUN7lwxEYIScrK+K7s=; b=jWcncPyL6wFvRkS6b/YAHcSC5 8ZZCgZH4N8BBAMKxCzEYcJ1VRI5+f32JheSEbP62wtCRo33qzScMMYtOXc9WXe/BYfZoT2pyT4s6U b38jn1fQs2lEbM4izx8pTjRxxz1LrnIxbT8Ky9uxuV9YW7+2G5PKQ/Q6ZLUMPU2bo3mKYTQw9DgsE tvKsSke3NfYKTs1qZ7YVL/SojEIyoI2pHz0fXh0Vk7fTKQCEczSah4FjkO4NIpJf4UykP8Av1BQJZ GuTnWuVmtfrWEOjjHdDgXkXzL5xSN4HKKw8bU7IW2LhARLRFs49eK8h88RkFtjHmX30HVulh+YDrf qouJzuvcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc90-0004sZ-6J; Wed, 01 Jul 2020 12:47:18 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8t-0004pR-9P for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:12 +0000 Received: by mail-wr1-x442.google.com with SMTP id f7so20652747wrw.1 for ; Wed, 01 Jul 2020 05:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9fX3YQmu/TyZUi/gCUeVKqHWnQBcFQjsTJlFycXl+A4=; b=vT5SNW2nj2xlct7B5oFAEKNrAmdAYt9aa/C2EsvoZj3iCmWBfwGimRErcQG+WPVnXv XzjOj6noAaG6pXKH01vGd/aIyT0vJVDNQdn3UV+QOSyKvOTW4tRTlsf9IOsX7r0p4hLZ lg5e3peRTHdOPdw9roQqCIQ2Lh9lnDDtNIoHGkQKydRIQy8bwrbNcyNH7J8t0iOBOpkk uZfR4cpYEi3tZXnNA4LyYnYNzRHQreXLLFSrepfwCP3BU6CXtF5CBaJPW2XRBTiteXFl X76nU0olPK0OHVw74/pUz7g2eurHSfAQt1GXqbLePth2UiMhlC+mJYBtY6/ztU6Gw2QG MaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9fX3YQmu/TyZUi/gCUeVKqHWnQBcFQjsTJlFycXl+A4=; b=f2RUXCIAtzwC/zNJSNHnkyOF+1z7NjUUZSPhUnsDViT0TYSjp+ak5C3JcAf4AOzV4R ohPfUKkY2ix/IeqEXaLYsuXOpIn/38cEdiEgrBqnIAxM3CcffERwkH5g3RD62eHJ9OXJ TnLwf/74X8WLJou/XPTEz/oECOqGwRdKQBEuXu9F6zmpXuDowVRkeK6iTBlOCgImYo+V T1SZiFAF19cV3Uy25Oa2vZMuGKWf24Dxbannn8/v+Azg9YQq6diij/tI9He2e9D0ZU7t SLT6S0dxiikjpDzW2wNyIk3vQ4ckB4n983+4wZIKJNLTVZp+1RR2DRAoxMkP+o6FKFiM tRkg== X-Gm-Message-State: AOAM532mB4TyZFeriDVu03wHjachb0T5Y2wonMSejudWkZCJTKG/Ly+S TbhoCqrlSWliZvMvwR5reiHPvg== X-Google-Smtp-Source: ABdhPJzZIumZWDrMmq5PludRvlVmmwImG5o9AgYWwJ5Q0weSLLiLqzjnRp1cub8VUmYgSnRRyLb3Og== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr27093821wru.324.1593607630155; Wed, 01 Jul 2020 05:47:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:09 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 03/15] mmc: core: regulator: Add missing documetation for 'mmc' and 'ios' Date: Wed, 1 Jul 2020 13:46:50 +0100 Message-Id: <20200701124702.908713-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084711_414367_87DE3934 X-CRM114-Status: GOOD ( 12.90 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Remainder of the kerneldoc descriptions look present and correct. Fixes the following W=1 kernel build warnings: drivers/mmc/core/regulator.c:178: warning: Function parameter or member 'mmc' not described in 'mmc_regulator_set_vqmmc' drivers/mmc/core/regulator.c:178: warning: Function parameter or member 'ios' not described in 'mmc_regulator_set_vqmmc' Signed-off-by: Lee Jones --- drivers/mmc/core/regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/core/regulator.c b/drivers/mmc/core/regulator.c index 96b1d15045d60..609201a467ef9 100644 --- a/drivers/mmc/core/regulator.c +++ b/drivers/mmc/core/regulator.c @@ -159,6 +159,8 @@ static int mmc_regulator_set_voltage_if_supported(struct regulator *regulator, /** * mmc_regulator_set_vqmmc - Set VQMMC as per the ios + * @mmc: the host to regulate + * @ios: io bus settings * * For 3.3V signaling, we try to match VQMMC to VMMC as closely as possible. * That will match the behavior of old boards where VQMMC and VMMC were supplied From patchwork Wed Jul 1 12:46:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636239 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3003513B4 for ; Wed, 1 Jul 2020 12:49:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 088C420702 for ; Wed, 1 Jul 2020 12:49:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qtwOAgkw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PjiRPFC2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 088C420702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KUo4YrBskbQ6bulLoT03dBC5OBiWsD8tG3uNrJca2VY=; b=qtwOAgkwX5CPt6AL0aA/Hpju5 qEjfS8mKW54yayFoBN16Dae1ojZT53YloGlcemOTqlRvyNexZd7t9mk6CzqFbx3BWJk50qYU4VYCb HET96DVycQqHCohsZNStq1MDlU/KQJALnLxxva09ZkemNSUnxKwKBktVckHPZ2qkB27Rj9f2e54Cl oRjLg85W4k4R5YUJPtY+xq+7msaDHfoJYxL4Y7rDigr2+vdErdGIRzCoe23bUnkqLPiJjOmidlH4F cAFaD8aju+GVCrwbO7E/e7ZE1wfzP87S8uAzuZjn73JMCQuNV9Qmq41M2Ln+4rfeKrJcsXmoImMFh n6+QAFbGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc96-0004uy-9Y; Wed, 01 Jul 2020 12:47:24 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8u-0004qA-HQ for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:13 +0000 Received: by mail-wr1-x442.google.com with SMTP id b6so23636824wrs.11 for ; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=PjiRPFC2+ne1JlGgsc0KpJefm6lvkyRsu+EM+8TXu7yFTsA+q9615YF7ZDoGByGVaA QzIJ0Ny5ocQIQXGLjETMjLTXZkb0S0RYf8k4sh/YGGanFkW1YH7EXKpJ4wCv3GyyvwNp XUZBH+7325vbu6YVK2DFMOYYKnRpozd4ENmvm8mBXAsd/18hWr5L+b/wmMtI/EfBHx0C WK4UMad91alCJ1Eu6G47jzTP96yrOF93Z7YUPcBkS49rzZ4sybvwiHpB8j/7ulafXijB SfEcPSCU1uRCLW8yJj6ouzi6dHUy3dXkwlrEUs3oeOmnnu2UgjKGe6FRs/JWurPC4fNo T4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CbNGlX0G5Ov7FT75iCw50EDu+qwZ/8J7t3LRBNdlSbA=; b=gxbJAe3pv6+ykG42irLXb0B3DtB4/gz1fo89VptwxLsFgL/a+FyLFjhF8E8xHk+MJv HY/cNCqFdeoZYXcmVOVdW70CBKNno3TGfj7kiT9TFPXbD/Bg7UcmkJhzl0QPZtUSHALq vOmfWzZ4+GBPlBsMAOnk56gmEi12njTBelotJzGJ54iO34uI0WQYVbOm/icXNCeVMKYO XSph4wr68u6JFH06a7ZSRgHl/bIHk3uzjH0T9h1j/cBKCNDDD45Yfue6FbIn6Y2Kzhhw Z8juzYuyknw1J4Ki4rowI4BHql+PspdiAFrEDTJLlEbMMvsz+dIAKzTPKyZtZ9MFJAMX oSkg== X-Gm-Message-State: AOAM5315VQA4GGGR1jfLxzNMJ/AzN9pW3bPEyM7qGA+WgEw6tw4FPa80 fAFHB0isx9XyXwdZzad2trbFjw== X-Google-Smtp-Source: ABdhPJyR/yX50DpfFq9R2u3R16L2+L4q61pYf7cMIGM739hqYmJOThTTybjRR20yzg25Z+WZLrDNYA== X-Received: by 2002:a5d:474f:: with SMTP id o15mr23624823wrs.306.1593607631728; Wed, 01 Jul 2020 05:47:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:10 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties Date: Wed, 1 Jul 2020 13:46:51 +0100 Message-Id: <20200701124702.908713-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084712_638932_973E6263 X-CRM114-Status: GOOD ( 12.33 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Jaehoon Chung , Ben Dooks , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Describe properties; ext_cd_irq, clk_rates and no_divider (x2). Squashes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'ext_cd_irq' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'clk_rates' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:126: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c' drivers/mmc/host/sdhci-s3c.c:139: warning: Function parameter or member 'no_divider' not described in 'sdhci_s3c_drv_data' Cc: Adrian Hunter Cc: Ben Dooks Cc: Jaehoon Chung Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung --- drivers/mmc/host/sdhci-s3c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 64200c78e90dc..9194bb73e601b 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -107,8 +107,11 @@ * @ioarea: The resource created when we claimed the IO area. * @pdata: The platform data for this controller. * @cur_clk: The index of the current bus clock. + * @ext_cd_irq: External card detect interrupt. * @clk_io: The clock for the internal bus interface. + * @clk_rates: Clock frequencies. * @clk_bus: The clocks that are available for the SD/MMC bus clock. + * @no_divider: No or non-standard internal clock divider. */ struct sdhci_s3c { struct sdhci_host *host; @@ -128,6 +131,7 @@ struct sdhci_s3c { /** * struct sdhci_s3c_driver_data - S3C SDHCI platform specific driver data * @sdhci_quirks: sdhci host specific quirks. + * @no_divider: no or non-standard internal clock divider. * * Specifies platform specific configuration of sdhci controller. * Note: A structure for driver specific platform data is used for future From patchwork Wed Jul 1 12:46:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636251 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B378D913 for ; Wed, 1 Jul 2020 12:49:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C47A20775 for ; Wed, 1 Jul 2020 12:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oxOjVjiH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkxOWXIN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C47A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wHwDgr5IdYRoFisoX2d5L8kyTdj8riwtABlhFouNNaE=; b=oxOjVjiH/vPUzN051M3ZmYTn2 kVlnSm9YMxbLXmQWrcjzXbJKUDYh++8QoRRncgeTQLi1woosAewirBVWiVpC0mhnCExKDmRp4emTK eaexdKZ4CrN+K2XNcXj4GUF4Df24SawvN+ywhRxERtVTOtz5pfuVyUxWBEKiyLV7m7pWfKMkeDsDA WDzTIJBsb57+HBnPJkzUb5NCY27aP4wHmwSDQh5dWMwvwbqahqEjxUeeZIfVP1bLu+xgsAKXhCsDV Lvmuhzee53GA/Wv9dn+60PvSTYr991FQgRdy+90STbT0UfHZi61nBhqPcrxfvHR/r+BLVKUEsRO3J V5R9GxbqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9A-0004xG-Hm; Wed, 01 Jul 2020 12:47:28 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8v-0004qm-Un for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:15 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so22258185wmj.2 for ; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=NkxOWXINSEGLHqpysGjU6l/aLOB9D1RBUt6a9Cv/cmC44LR032HJ/q+z+4snhCTNaW PdMMvGuAtO6Ujsk4aFY5+ggkapbI0y8vbr63jnUFJyXL86NW5J8CQGij61gyCDHXbUvz q0ZXV3do+vtPoNt8BgF/Jqn4PdF42fkgGAD0WiII26VZNos1Zz4ezvQGo2YuQ6UVBJDV LjbxniUTQMcgraMb0BQXgE7a+gMVTa48nOSq35qfFocyo8c0E6lg3HCVEfXt60C77tY6 reC6aeGYzXZElVG8Ik/hDOwn7VmhUGcSH3jWARgSvgWiATkKl6mXLwuzriMC6WwSkV18 Tz5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sJPW3QXOhHs7zWGK9W13Qhww3wag5wL/K8qzQE+aHP4=; b=ZE+WoRnSFuv22HLs/5pS3f9Zq2OlsKutiVkD6fNbTFAFGjxbRT3evLJEDqmBK94vdR 8S4kvljMILq08QJQ4N83/RoYxP6+PUwSa0adL2Eu7pTYFnkHz3EvqfvYDaFVQuhVJV3H KPOICGLRs2eF5TF0Jrx0WHg8b0MqBobk2Tm+IoADGFq/BDM/X79I7fAj3u340L9tgPrn g/49ZFG0RUDwJW0f22KmKwifklGQ+GhLGozWbWf/dRDTKewHfNzRehmob9hjxnSFZa60 oADgso2xsYJ43X6yoH0hxOhYIA2WO1VJSPsJVG1xm0p9cLHx4ZDMuQ0bzfybguoC+nav 2ejg== X-Gm-Message-State: AOAM530dTRcgD2P1YZolg8ELuzhYk29wfNCPlMREwZAr8fLj8tlJq1KO WoXq/umm0BtQcjwZliyonMj3qw== X-Google-Smtp-Source: ABdhPJxnFAAMJptNueVPmlk8boLIXJmBHNOeNDTpH4SZs6YyRbzwAScqFRsTswPCfpzS6+CQ/Dp17w== X-Received: by 2002:a1c:6006:: with SMTP id u6mr26009722wmb.111.1593607632721; Wed, 01 Jul 2020 05:47:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:12 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Date: Wed, 1 Jul 2020 13:46:52 +0100 Message-Id: <20200701124702.908713-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084714_062699_B8A5EB6B X-CRM114-Status: GOOD ( 15.72 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Lee Jones , Chaotian Jing Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No other function in the file is documented using kerneldoc and no effort to document the function arguments have been made. It's a bit of an oddity to say the least. Let's downgrade it from kerneldoc to a standard comment block instead. Fixes the following W=1 kernel build warning: drivers/mmc/host/mtk-sd.c:1030: warning: Function parameter or member 'host' not described in 'msdc_recheck_sdio_irq' Cc: Chaotian Jing Cc: Matthias Brugger Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Matthias Brugger --- drivers/mmc/host/mtk-sd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 39e7fc54c438f..49ac802ebbfeb 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -1018,13 +1018,12 @@ static int msdc_auto_cmd_done(struct msdc_host *host, int events, return cmd->error; } -/** +/* * msdc_recheck_sdio_irq - recheck whether the SDIO irq is lost * * Host controller may lost interrupt in some special case. * Add SDIO irq recheck mechanism to make sure all interrupts * can be processed immediately - * */ static void msdc_recheck_sdio_irq(struct msdc_host *host) { From patchwork Wed Jul 1 12:46:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636255 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C801913 for ; Wed, 1 Jul 2020 12:49:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13DFB20702 for ; Wed, 1 Jul 2020 12:49:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OzJ6k/Jh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ya78GGdR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DFB20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BAyFDK+uQimM/ZZsQnDTKJJjPaAEeYncIiqSwY0GaBk=; b=OzJ6k/JhoFXFmPRE8+9dmhGEX 7ePijC9uayy5YpJD59bI832yUVYCB6946Cs+j7ZNB6Cz4mMP4SCSAzy4B5v93sMOQ2xic9okRw9Tl 2qZnMIQrxP4NFa4TNgUb9MZiXsvIxkIPcwd+Pyvj6ECLimFSEMgspGkrejKsUYULRlJUBd6kg8G2k H58xLQ4m/7eVm1BtNuB1c8sAKQLECAz1ivyL0UWcectH8eHO3u2sY8q8l5I7CUU+FXEALPve6QPkQ L0rwqSgKv7nOSPU/A1+IfzQ+hs8YlhIKHwIRHRJpkysz/AU17yyYVZ/hJ7bh/aJOqC/NKbXppb3+f FzshVCfJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9J-00051a-RO; Wed, 01 Jul 2020 12:47:37 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8y-0004rU-22 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:17 +0000 Received: by mail-wr1-x443.google.com with SMTP id r12so23600394wrj.13 for ; Wed, 01 Jul 2020 05:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=ya78GGdRIDBQGK8B84BfpjUHk69NCx0tP8mmoMldCAn5FHcrT/VhqMAXQF6V/OVicR FMY6bg9H1UVELQAZDu4fCvqgDKIKWO4S9wzT4m3AteUDzvlZOK4/MtjhiCd+KXmKMb1L F1TtQ/2H7zYbSMx2RxkB8Qz1Gr21YJj+SLdsFpOqYnZSQUbS93IXbdEXgX9sf6HweKB0 TNVjzis0NXV8fJMHzzSeFbiEixlXlbJBV2nY8NiHHWlwBss2KBdZAh0ig6sPaccKPpN9 +cviagir9w82XUTR6EHMNr+NxvILSikRpvq1WwLaBLKCHbd8OhUghVvGmfhwHjUneWS0 WzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4HmkZgMMnNokIcxpC5qsgSTpETcgy+guvTGIOYd3vjA=; b=Bitxnyf56ZcjCgmKlTcp2L8stcloy191W/tycmsCwgP/EpcrEPpF14xPOx0oSw25WC fLWSd75p5znUqp1B0Dr/Mn1qXGIJNHJ//vupsNIfPUAXDEmUvO9nwRXStoYgxPFCR863 pkJBi+g0fk4dy/Gf7YZlD2mR8agwSllFn2gkCnSyK7xFUrDO4loXi4SuuXxWy/eSjLWT aGyMnwu2NvSv5lpXSl4rZzcNn4lnmr3/ElcAhHoi4iXLkQjAzNXbiOW3R2BFMY5y8bgr lF3Y9qYkUtcMzN/SZe1/rRxOslus3UNIx213a/SEiVZFAMu//ZkD65LQs+j+GRLLrZo2 SrUA== X-Gm-Message-State: AOAM532EI2x574AIi7SjAPioGnAhwoX4UCwUK2hi3wyHuOe1dApcownH uxQOgSoxm7jdZCnFg7KSSJekfQ== X-Google-Smtp-Source: ABdhPJx5sdyemoJCIEKPCxf8WbgcrVsCh6V9mQezCi/IiAds/ZoliLC+HT1ZY95I0UsHrI8WiYDixg== X-Received: by 2002:adf:ecce:: with SMTP id s14mr26836949wro.154.1593607633908; Wed, 01 Jul 2020 05:47:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:13 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 06/15] mmc: host: atmel-mci: Provide 2 new and correct 1 existing property description Date: Wed, 1 Jul 2020 13:46:53 +0100 Message-Id: <20200701124702.908713-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084716_348012_C5F74D90 X-CRM114-Status: GOOD ( 15.00 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, Ludovic Desroches , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'sg_len' and 'dma_conf' are missing correct kerneldoc documentation and 'buf_phys_addr' was misspelled. Correcting these issues fixes the following W=1 kernel build issues: mmc/host/atmel-mci.c:352: warning: Function parameter or member 'sg_len' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'buf_phys_addr' not described in 'atmel_mci' mmc/host/atmel-mci.c:352: warning: Function parameter or member 'dma_conf' not described in 'atmel_mci' Cc: Ludovic Desroches Cc: Nicolas Ferre Cc: Alexandre Belloni Signed-off-by: Lee Jones --- drivers/mmc/host/atmel-mci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 5cb6926876981..300901415aa20 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -225,12 +225,13 @@ struct atmel_mci_dma { * @lock: Spinlock protecting the queue and associated data. * @regs: Pointer to MMIO registers. * @sg: Scatterlist entry currently being processed by PIO or PDC code. + * @sg_len: Size of the scatterlist * @pio_offset: Offset into the current scatterlist entry. * @buffer: Buffer used if we don't have the r/w proof capability. We * don't have the time to switch pdc buffers so we have to use only * one buffer for the full transaction. * @buf_size: size of the buffer. - * @phys_buf_addr: buffer address needed for pdc. + * @buf_phys_addr: buffer address needed for pdc. * @cur_slot: The slot which is currently using the controller. * @mrq: The request currently being processed on @cur_slot, * or NULL if the controller is idle. @@ -240,6 +241,7 @@ struct atmel_mci_dma { * @data_size: just data->blocks * data->blksz. * @dma: DMA client state. * @data_chan: DMA channel being used for the current data transfer. + * @dma_conf: Configuration for the DMA slave * @cmd_status: Snapshot of SR taken upon completion of the current * command. Only valid when EVENT_CMD_COMPLETE is pending. * @data_status: Snapshot of SR taken upon completion of the current From patchwork Wed Jul 1 12:46:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636257 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4C2613B4 for ; Wed, 1 Jul 2020 12:49:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE01020702 for ; Wed, 1 Jul 2020 12:49:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="y8grv8ni"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JQJdL1or" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE01020702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5LoaeqXQSlugnay+xbMxfZnnrh47VHsQ8bq4fNa+dLs=; b=y8grv8niS80B9hv+444gc2XFg mxwxBhnZatmyNaoDcRXjWFWtce8Qas5gr8FEYCmXQPfvnx1pVFJFR7PVA6gOl04wlQkKWYx4x4/5C dZA64J53c0ocltdlBKcVfJEUZxZvaq4wrfH/ww7y1qJw9otG8baCCvEkp0kBEDB5a3nllxol3ta9T wxY4bHVGn9UuDeuEO49H/hbxOe26e575XRwBxJ21fru/uuNDiJBG2AnERm8668H6jJ+yLPDtyz7gN Mq7MwIg4LmS1ruUYj2vU2t8lbc8bcX+HflgshOTWugcN9ZkjdxCjTu3h1HG1a5zL8lJ/GQnlUTUw2 RymTVnYqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9G-0004zz-W2; Wed, 01 Jul 2020 12:47:35 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8x-0004rZ-Mn for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:16 +0000 Received: by mail-wr1-x442.google.com with SMTP id z15so12391330wrl.8 for ; Wed, 01 Jul 2020 05:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=phaHepEqEbU60VSdrxFqwpC3YbwLDxmZYay7m2R57bw=; b=JQJdL1orTD6yrnvu+G+Eb/HXTwwA1BYCd5yp8o/2fk74PgM7jUblE5zVqfHqU3Swq7 EnCEMIFQOVslHGPA3VVxtzqf50unu1X/ugYbWoRwdC2gV8eLP194tZwfLF3qdwhMqiFC XuW41gKAyIJu/cpdbgQOOiGHnPuS7UP3a7vc8kC1P/O2/4VyLf1l+mZfUR2zrhp1/n9M UB7CHbqjd0FS0AytCmPJ8qTC0izQZsLz/vA6FYkp5RESKM1pgkjbWCafgr78ZiIIi2BK 4GAoFq2K2JGd0y83LhXd8gmI4GDS7sNs/TacfyBk/2+G9VMK3lvuLTwVgcf6Lrq/13xl qpug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=phaHepEqEbU60VSdrxFqwpC3YbwLDxmZYay7m2R57bw=; b=pp0Y00i/7Snf5vX8+3xbC/nVBC0Vs4wgFciDLbJP+260K1ExmHLL+8xFNceg+bwQle GSteZhc88qRnwE9wiBr874pzO2JEJ5D7vmlmamAeoxrAZqyfH/zUaZUmN8a4+xSgzDWz WRmJESgaqJAYW7g+ZvemGjdScBPuJDQ2Rbi+Sq/JPTRjPNqpy1KInjzulLp/WC1G64Te JWlDeJC7cJPYLLJnf8Yy6oxNrQxaf1jOnsTsts/S7c7NUFy9tDWLddMGbOdWxYmSiuBx msvaxcdV4Ygo7tmXZLmckxMmFK+gQDtqoC3u2haFgPNxDtb/9cUZUG+Y/ScLqMji2mnb UDTA== X-Gm-Message-State: AOAM530CbbeNV+9ZvEaLTCB69UKm3os2jMsdQYyFRVN7YNMN96ANWBYK XJ2WmdicNkwgYgfrvRece2zihg== X-Google-Smtp-Source: ABdhPJwgwINDi8Vx2k78e0LUbFfG5zxBt7MBPPGrr1Hcrg1wwapdPMMvrt5k5hC8U/MQ7E7z0g1dog== X-Received: by 2002:adf:e701:: with SMTP id c1mr27181289wrm.350.1593607634878; Wed, 01 Jul 2020 05:47:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:14 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 07/15] mmc: core: queue: Correct misspelling of 'mq' in mmc_init_request()'s docs Date: Wed, 1 Jul 2020 13:46:54 +0100 Message-Id: <20200701124702.908713-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084715_775598_672A16E8 X-CRM114-Status: GOOD ( 13.33 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Correcting this misspelling squashes the following W=1 build warning(s): mmc/core/queue.c:212: warning: Function parameter or member 'mq' not described in '__mmc_init_request' mmc/core/queue.c:212: warning: Excess function parameter 'q' description in '__mmc_init_request' Signed-off-by: Lee Jones --- drivers/mmc/core/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index 4b1eb89b401d9..6c022ef0f84d7 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -203,7 +203,7 @@ static unsigned int mmc_get_max_segments(struct mmc_host *host) /** * mmc_init_request() - initialize the MMC-specific per-request data - * @q: the request queue + * @mq: the request queue * @req: the request * @gfp: memory allocation policy */ From patchwork Wed Jul 1 12:46:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2670F913 for ; Wed, 1 Jul 2020 12:49:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F230920702 for ; Wed, 1 Jul 2020 12:49:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VPcpRz1g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c9lB95Zl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F230920702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nvfKONDnnDD9VZWq0I6bhZkpVb669ZOMqh3JhwrVzDA=; b=VPcpRz1g5bJvYZL4aHwL63qHA FbWLBzukdnGfQa6/zl4/nVl15f1tggd603If2ZezUCVdXVmEJ21MDBop1zmTZApV/+bW6kEDwrWqd CTJWET91zIiSgi7Am5I1ISQ2PFu3wniT2G7LABqToNFZo5JVTmnHsmRSHOlzoDr0+Urkk8gc7lSXq sT5FOhCSWFSYIb4Zb2flIsTFvGet6Lfqe7pByrmAJ1gtu2OdYYTT6tuvIAeJwI6RJhXWC+yauHTwC n1UaDgpxQi54yAm0jVVjF7SCnHZYbEM4RsfdH1sDIB5HT0sn18NRPRTAe/r7raWlR1v1W094mwGbu aJFS5JdKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9M-00053R-Pp; Wed, 01 Jul 2020 12:47:40 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc8z-0004sN-8T for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:18 +0000 Received: by mail-wr1-x442.google.com with SMTP id q5so23655291wru.6 for ; Wed, 01 Jul 2020 05:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yd63tKAD8TEw//9s1TXw4/kd8gj1ZByx7XV4rk7dLd0=; b=c9lB95ZlSkCDr8FrC6iJ4ySeiJo/PwpxEuvTW8mPxbMi7ihPg/iN9Ag0/siQ+aqpIN lJhnsv+KPo9I9zWCV2sxE1dhJLOJGFRNycvWH0auT6M8XZ7Mm/CEmwTqIi/r6BvFoFbn ZF67z9oamZZJ9uq+qhic/shA3dVgWeBSmdEv+aV9UMhqA1T2lxOnICn52HaGh14Z8zLs JlM+mZTh/a6C65EV3n2CX9SPSXdqj7qDRm8JgZVHxNSzK4s2KBtcxSMAE3tkpiwImxEL DLIl0Ew6S3oRNZnBNegDJAc0B6jWmDJxM/kmE9KyRsqZ+dUn1sLkGLyi21Q94OtsfMI6 T5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yd63tKAD8TEw//9s1TXw4/kd8gj1ZByx7XV4rk7dLd0=; b=J2KYKz6iIV2VvTunqdxNX/sS1kuz9PpPiRhJkD7FsxutFkAACoONe2GZD1px8moEDD ZXwVjfrlMlT+qHjSp6wzxBPGtdZpyAA7Lu2mL4H9nWqtktusj6MGvfIp3vNwGm9LbhAQ uIs++PG2ewGTHxFvni6RB4yVpjM9nbYxEmlwzHhwaJ+vSo7+GtVrwEsTrfkx/az8b4PB w1cn6K2bLZmFS4qyGMkq/Ar5Ef1FaixmEBdh/MD20qANdVkuPZJZSrh1X/vFlqx9HTWZ mKkE8CuTv+0k+JdXmaCFp/PaC7tFOTR/T7Key8t1uXx7homa6wDqBc5Hq9/a0w0bAla1 Qm+Q== X-Gm-Message-State: AOAM5326WvAw0h3ckSawL8c3KlXqsaq5+7BREUidCeUWTG2Yv7rvWpZv 2f5MoQJIqySoBYwmwsjXMe/d7g== X-Google-Smtp-Source: ABdhPJwshEQk22UxiuotqnoaKHFLuGrVwcP2gpb1t5Bt9UatQsrYDEIsRgMqxO9yunUFcwD7M//wEQ== X-Received: by 2002:a5d:420b:: with SMTP id n11mr26559514wrq.91.1593607636400; Wed, 01 Jul 2020 05:47:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:15 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args Date: Wed, 1 Jul 2020 13:46:55 +0100 Message-Id: <20200701124702.908713-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084717_416468_1392EA5D X-CRM114-Status: GOOD ( 15.06 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Jaehoon Chung , Kukjin Kim , Thomas Abraham , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Provide missing documentation for dw_mci_exynos_suspend_noirq() and dw_mci_exynos_resume_noirq() function headers. Fixes the following W=1 kernel build warnings: drivers/mmc/host/dw_mmc-exynos.c:184: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_suspend_noirq' drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_resume_noirq' Cc: Jaehoon Chung Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Thomas Abraham Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 5e3d95b636769..bd59186f59b39 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -176,6 +176,7 @@ static int dw_mci_exynos_runtime_resume(struct device *dev) #ifdef CONFIG_PM_SLEEP /** * dw_mci_exynos_suspend_noirq - Exynos-specific suspend code + * @dev: Device to suspend (this device) * * This ensures that device will be in runtime active state in * dw_mci_exynos_resume_noirq after calling pm_runtime_force_resume() @@ -188,6 +189,7 @@ static int dw_mci_exynos_suspend_noirq(struct device *dev) /** * dw_mci_exynos_resume_noirq - Exynos-specific resume code + * @dev: Device to resume (this device) * * On exynos5420 there is a silicon errata that will sometimes leave the * WAKEUP_INT bit in the CLKSEL register asserted. This bit is 1 to indicate From patchwork Wed Jul 1 12:46:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636243 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC9B413B4 for ; Wed, 1 Jul 2020 12:49:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 512EA20702 for ; Wed, 1 Jul 2020 12:49:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GJnzpvGa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hvlv+tX5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 512EA20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1PJ27RTbQd/q2bYpemf4SGXl9QEiC8HlnS65ejnekrM=; b=GJnzpvGanR2Z7EeWpriPvdDkn dqYpcSBEOTCmcP3A6zQ85YbK9F5gbUPXpPgmmUQw07zUV+EKyiThzRaL8K/hpkXuRzVUeisS2UvyE JkRCDdLlspZ+z+6II0zUxUBoBQ4qZOE6qQKmRjW0HqfGHTTRmP7K6J8VXN46QYLJe8uJpCdcIj24/ QER/1hGuZCd2o3rJlb0E9278DdRRFvayFU+FcPXEa7oUzE25PeVMWUqOHrbPKZzB9MXrWKpusXMn/ b0iZl5zD3+RNKQpTfTHsW7XjlGCLgjV5YuSD6atKfOWplAAXljgnIhP+yxmVtfj/IzxrJxb/WsAMx ybvm53acQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9Q-00055N-Cg; Wed, 01 Jul 2020 12:47:44 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc90-0004st-7H for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:19 +0000 Received: by mail-wr1-x443.google.com with SMTP id j4so21212333wrp.10 for ; Wed, 01 Jul 2020 05:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N515jYO+XViE4rxUKT5HCQLZtJJRT/LcfFcciYDmBeM=; b=hvlv+tX5KbtfpPHuAr/9nPcfbWbt2OM+cAiArO7rBU+Y2+hvUnLaSo0jEyJTSCNtqf /BDU4lYL9oLCcqTop/giUBCPoSMdBObVhCbOzDajIg7Xy6OW+ZanytcIK27fFPUGoSVU 2HU2a9hqOlOZrJOszUR6SdV2AyaDNo6lSEkB+ew6DMnwFNMd/BNLqTiFAHq1aJUyK533 vZApsJFvDH9s4cvNsik/dIsdQTNB9Xgck4l+CjFOQg+hSyhnw/3cQ4TbqOVFFZ9q5zuU Hx3f33mBeGd2YAWoPZsDHGAAQN8Ba5WzdLuFqKRs0IHGKbASYvKxZqTge82v1stAPd6T vuAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N515jYO+XViE4rxUKT5HCQLZtJJRT/LcfFcciYDmBeM=; b=Cfjmlpsaz9xH/X8Px/2cuRH5qvb/k8MPC/LQJdUdJjqV5T+lndVLKelO/OO6eD76xP xtutTkbbYYrqiS7rR/1J9NLZ+RHSQYcfWjMAWt5DTp4MtJk2wLQpAq4tuHAwb0zFD+KH qkPi5ehBDAounnxHsQYruabeGeHMJ87/fKrClEqorK9mjCpnVBSn0NuhF37RBh2Z4Y+J k/o0IbmaOho/bGgINT/czKXjJOX9H8QLssnpnbvq12enBCHgdBjSA0IgtWfosVJkX61V 4MfCuUaMXJhJOjW1x+rAFd2/YS+NIFnPIt5AGn5JCEmePxaBcNo5bgIFMoJ6OO9JIQ6k uT6A== X-Gm-Message-State: AOAM530lCGVVHY1WxTvCLk5a7oxdfHHyxLcS9O0+L/Bi+Plc90tm3vyr KUm96QfVYZXm4V1YH282CqZFLw== X-Google-Smtp-Source: ABdhPJzwL6sUJakVeaCCVt1EjUi0Pfn7s08Z72vAPl3BEm+TB/R6hwjCzAdHY66m8bbVha8qFfoZlg== X-Received: by 2002:adf:8168:: with SMTP id 95mr27049461wrm.104.1593607637328; Wed, 01 Jul 2020 05:47:17 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:16 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 09/15] mmc: host: rtsx_pci_sdmmc: Remove set but unused variable 'err' Date: Wed, 1 Jul 2020 13:46:56 +0100 Message-Id: <20200701124702.908713-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084718_616194_1118910A X-CRM114-Status: GOOD ( 15.66 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei WANG , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Seeing as sd_wait_data_idle() returns void and only a very specific read value is checked, there doesn't seem to be a good reason to check the return value of rtsx_pci_read_register(). So remove the assignment and definition of 'err'. Squashes the following W=1 kernel build warning: drivers/mmc/host/rtsx_pci_sdmmc.c: In function ‘sd_wait_data_idle’: drivers/mmc/host/rtsx_pci_sdmmc.c:678:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] 678 | int err, i; | ^~~ Cc: Wei WANG Signed-off-by: Lee Jones --- drivers/mmc/host/rtsx_pci_sdmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index 5a71f6678fd3a..dc0dbd64a2a78 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c @@ -675,11 +675,11 @@ static u8 sd_search_final_phase(struct realtek_pci_sdmmc *host, u32 phase_map) static void sd_wait_data_idle(struct realtek_pci_sdmmc *host) { - int err, i; + int i; u8 val = 0; for (i = 0; i < 100; i++) { - err = rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val); + rtsx_pci_read_register(host->pcr, SD_DATA_STATE, &val); if (val & SD_DATA_IDLE) return; From patchwork Wed Jul 1 12:46:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636267 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75C65913 for ; Wed, 1 Jul 2020 12:50:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2AA20775 for ; Wed, 1 Jul 2020 12:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OdOvWivA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vmuk3iCY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2AA20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cs/kn2qZZs+xjrIdqy95cbNe+H0lJsjfIHtF4P9rss8=; b=OdOvWivAvzqMj/p8LdPN7wolL W842j+F0qtxrBFBc2+yLtGpYwN1ndZ2zZlCfz9Jot0RmAorT+K20gIAOP6YrdoSkW8VfAC+b6rl0M wntq+sRkQPnp3Za7PUa2K0f8wzELYUy1pBH3DBNDX1OH7Bk+54QcNocCvY+XS6zeMkOxmC5eEOtRR FqcBJtfTB6qvoH9LRf9mnk0Lt66UXOrTom6TRPoRexPMfdUoU8KJob/b6LiiXBrf9LO/rCElyckyY sCx7v5LbPdthdySkQU9rVykcgZNgUcdPtwXcwSrjv/DhtKTz8fUnRL3D05YLvx2SSOjQ+dE/5fmeq ydTwxxR7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9W-000583-Jw; Wed, 01 Jul 2020 12:47:50 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc91-0004tM-FN for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:20 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so21602705wmf.0 for ; Wed, 01 Jul 2020 05:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=Vmuk3iCY78/WlEtcAdEexKWZcshcQ4CAc2QtQlIooAG1Sjzo7f922rZ5uu3Btw42mG pof4skzNtKjDAQ2V7hlvDc8qTUDRiAuUwOspjGY68c8ASAmQJZzYuw1DqpPM8TI+tbYk GA04r/sV9cy1DJ0+stgXKyLbOfzThikzkPVRIvV6m9L9IDgbCUeUCf5TPNOjaSYqNQDt /gJn0pdOlKPAceJRAr9sgb4pG0FQSmGa7l9+UIMmmI63BXVj+eiObd+MyXCYC2uFsXEb eSkxfH1EoY2oa1tfhAac2VmwXB4gICM7NLjLUlvi4MHodiQa5hiCYFQ+KVUpjcjAR7OV YM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dBwifa0ZuoxuR9zanjCi/SQC3HxVrP+0TUYJWPy9rp0=; b=TPE7k/SPwkA41+v+F6SIqnUn9qlbts9i56LlNaZGEEoyM2GCcARnldAoCx/CEhH5lS YiChapInFCcSVYgU5TrnMIhVlTA1Wcbm04gT6Izp3lhjeZhMUisvLj3QCD7aklY8vuwF k6sQyUwm7k6KO4UU55K8QYZeprvUqAhghRqUUxNMK381erwE49IpYv+EllEIoS/JAzCO uOE7MqdZ9lPobqyHpAGSVO/VamJOmNhY2EbctiKUuwLzyFvUZI/9fGbwsC3Pe5Jsi6uX CFCyNXG2lpJlv6HdPIcu/FA3E5rYYvbD6qqOk2wtBfwM2uM7b9Jh1d4HZwGaY0oFU0em u3qA== X-Gm-Message-State: AOAM532oVTHg8EofzGofrjjrEOApyptWWYhTy0Jf2yfD7u2IZVvBw7nB 6xwzLka4hEGchwoqkw+de7rdzg== X-Google-Smtp-Source: ABdhPJyRlpTGWtkkPDEX2Kbq6J1uY8YesgkaBwFXFyeaq+IHUPNxOc1d79VYpEMGSjz+hU5Plde7oA== X-Received: by 2002:a1c:f301:: with SMTP id q1mr26418165wmq.110.1593607638527; Wed, 01 Jul 2020 05:47:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:17 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: Remove set but unused variable 'err' Date: Wed, 1 Jul 2020 13:46:57 +0100 Message-Id: <20200701124702.908713-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084719_672776_59CB5415 X-CRM114-Status: GOOD ( 14.21 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roger Tseng , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Seeing as sd_wait_data_idle() returns void and only a very specific read value is checked, there doesn't seem to be a good reason to check the return value of rtsx_pci_read_register(). So remove the assignment and definition of 'err'. Squashes the following W=1 kernel build warning: drivers/mmc/host/rtsx_usb_sdmmc.c: In function ‘sd_wait_data_idle’: drivers/mmc/host/rtsx_usb_sdmmc.c:657:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] 657 | int err, i; | ^~~ Cc: Roger Tseng Signed-off-by: Lee Jones --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index a7084c50ad65f..7225d9312af8c 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -654,12 +654,11 @@ static u8 sd_search_final_phase(struct rtsx_usb_sdmmc *host, u32 phase_map) static void sd_wait_data_idle(struct rtsx_usb_sdmmc *host) { - int err, i; + int i; u8 val = 0; for (i = 0; i < 100; i++) { - err = rtsx_usb_ep0_read_register(host->ucr, - SD_DATA_STATE, &val); + rtsx_usb_ep0_read_register(host->ucr, SD_DATA_STATE, &val); if (val & SD_DATA_IDLE) return; From patchwork Wed Jul 1 12:46:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636249 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E488C13B4 for ; Wed, 1 Jul 2020 12:49:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD68420702 for ; Wed, 1 Jul 2020 12:49:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mOnzNiCe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HWrA80RX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD68420702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ku6vvR51sCF1hw6xxHMZTVThWH/iNM2vr/UKy6JDOv0=; b=mOnzNiCekMJF1apTokARnvpsl ZTe+JDH4d0hzZVoE/J6d/ADk47Ok59RimiwY3fn0V1XO6iyRtm6iEreCyuGVTu7WoJbxjSVdp3DQr 4Ycf9sRP+SNck3amB0rL6EKvE5AmrTflwiq3PfZx3E9GSQwubPh1y03l6HK+8AJD2xjIMTR2RMZJe Q2O7kFLCYk/c7TxpR+VcL+LQWRUL3dx8tdRX94H3pUnDECpt0D3C2bfzEUcdzDpMih6Ew2M6kOv9v x8N6zflXSibYNsbTE5odXoAlHq8CMGFmXZ9e11LrWYhERLLna/3aLsW7HUbT8Wc0GjhTYSM2O7bMb 94OjwnVIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9f-0005Fd-0o; Wed, 01 Jul 2020 12:47:59 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc92-0004tv-Kr for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:22 +0000 Received: by mail-wm1-x341.google.com with SMTP id 22so22269034wmg.1 for ; Wed, 01 Jul 2020 05:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wrIyNI5ZF/KUj1ZtT7jKpZfKmT6HM/rM07zicowUN5s=; b=HWrA80RXIAqmo5CKdWTISZJHmseFSX+3Dyz3Ow1WhDW5QxMOYcgIY6wdeztm6ESucb Bm/J9GT1TDSzZ8gPQVE/FDr23Dp5jiDD1gHJD7RDTKJMdDq6hV0aLQfzYnkwZXaJXYCx lLt9OjNCVFiEVXjv0OyqtuQSXOF7Y70KV0ReaL9HJXcX0PXwm0S3VPJ/qUke3nn+sn/v P3m69z3xKwOK9IuXhP/xxiNZ6+vk0Maggv/Ze/Hlwl8I6LL5mP6el3w1fNIXesCUrFye 1xghHvJgE8hIUQxPXccn0sFsIIKe9pKGOn/+6rzOAf4VIeyH4aoH0TZXq1f0/5uLccsl 36yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wrIyNI5ZF/KUj1ZtT7jKpZfKmT6HM/rM07zicowUN5s=; b=n7U3Wv9jYhIyb+y6RsPc0u1B2eTKAdFI3HjwFrXwipiluuhZAx3ZSDtE2RG1yS+tLi ihci/uamgDafciAedyjbV2l4K91AAxlzDHZxQfXMdoR5HcUhHrDFzzM1+i+C+obHPOzs PsMTIMv6feXRiz8rpScbkaVK/SmKBFCdHGmxhhVbHSji9v+0tEmr/ksybhpdzwsDprwz dZ7QDYoasw7dFZpIYwtBiGxZTlQIRBicCsg1Ujh0tr7WXgZOLxi9fuU6gqlb3zbR0LuK wtF0KEjBSjqGS3GKANFKL2PJQCTnZrjeqJDxBiLgt1RkTw+MU9gAp6OJTxWycspOeFfr WoBA== X-Gm-Message-State: AOAM5300hWfUkjBAZdz6WDbSefTUJBNnmO0ayAWDjPNE6LUGdht52aRk A8W6mm1b5dg/rhOhqssKzULo6Q== X-Google-Smtp-Source: ABdhPJxrkgYBUNiXUPxL6R2LO6yk68bXOYLtPWMdEp987Bhj7XPp0ZSAKkOf3hcOpVV/xo1vAf6y1w== X-Received: by 2002:a1c:3bc2:: with SMTP id i185mr26946217wma.33.1593607639564; Wed, 01 Jul 2020 05:47:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:18 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and provide missing function arg(s) Date: Wed, 1 Jul 2020 13:46:58 +0100 Message-Id: <20200701124702.908713-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084721_704251_ADDBA281 X-CRM114-Status: GOOD ( 13.88 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Soeren Brinkmann , Anton Vorontsov , Michal Simek , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adrian Hunter , Lee Jones , Xiaobo Xie Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects arg descriptions to be in the format '@.*: '. If either the '@' or the ':' is omitted then kerneldoc complains that the description is missing. Add the missing ':' here and provide a new description for 'value'. Fixes the following kernel build W=1 warnings: drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'host' not described in 'sdhci_arasan_update_support64b' drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'value' not described in 'sdhci_arasan_update_support64b' drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes] Cc: Adrian Hunter Cc: Michal Simek Cc: Xiaobo Xie Cc: Anton Vorontsov Cc: Soeren Brinkmann Signed-off-by: Lee Jones Acked-by: Michal Simek --- drivers/mmc/host/sdhci-of-arasan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index db9b544465cda..260e06e238f7e 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1388,7 +1388,8 @@ static void sdhci_arasan_unregister_sdclk(struct device *dev) * - For Keem Bay, it is required to clear this bit. Its default value is 1'b1. * Keem Bay does not support 64-bit access. * - * @host The sdhci_host + * @host: The sdhci_host + * @value: The value to write */ static void sdhci_arasan_update_support64b(struct sdhci_host *host, u32 value) { From patchwork Wed Jul 1 12:46:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636265 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B5564739 for ; Wed, 1 Jul 2020 12:50:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D21720578 for ; Wed, 1 Jul 2020 12:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VBIt9TU7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HJ/om3la" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D21720578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I3wqsBj2E2uI/FtGV5ovjQJDgWxrltoTUYl01dVTGlI=; b=VBIt9TU7E28YT9FzxcOBsztd3 5grqlJC6Oi194IuUHRglxFuhVHZaL9HXyCF5+bDM0p7IQelF6XSePvhHWJb/nxfU0tduLwPXEjDhE NsZVbLjjQGL+LFyd1B3QuaBhekwzt9evLO4JRb/JmktgcM3me3JjBkRD6gg68kwth2TN7ec6nKrWj 5JJSRB64FmxBGjUeO8SS3IqUlqIrlMsCkXMwRttrocjFiwymh4dvpC2LnfJsZhuQrjTcvsED3CiV8 O5y+9ctri3ubEeDTZT6foi/lnY8d1yz/5HVBpP6nRdMRcAYNc+QzCABTjr9BYcNJ8jepgtrbtyPVs nFMPL7x0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9i-0005IO-Bt; Wed, 01 Jul 2020 12:48:02 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc94-0004u2-5Y for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:23 +0000 Received: by mail-wr1-x444.google.com with SMTP id s10so23624496wrw.12 for ; Wed, 01 Jul 2020 05:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=HJ/om3laTlqrN4tbJ+hATe0qObMhqatwVBMmZnGQmvTJIYTLVQz8MxOl73Hvp4WjqF xqUHLf7YHf1hvrtoxKkTPx5vx4baewW61qxzhFuZVeIya9axCarl7l2dViHxrkwleodH dqRvX57EYA4mWlnOc3UXl84JE1fw1eqzsYGqhZglttgGNgeyeTENotbaLBbM3ZJAO6RO W6wL7H1TlNKqrdzCh8F+/x99y+cE9x8koVt002NOvQeOPt78Usfk5Y/7tdSB2HeTaHRe 5DHEEFclRVMMEY0UmZNQW+FvRnf4tsOiigh1L7ZLqnBfpOrsVbnL6LlOLwWrq5rZCYS4 IJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8hbNAtKSwUso7F6/Zo5X4haYX63XDsD/59rYslLWqBM=; b=tN1IMiPN/dwOo/ZBLvUBhFfGkpH2gJEHwyZdQStSW5RlYugJ74jOGk71FvH46s93PK yKCNgR4VzJyecKBp3LjNeUOisIXf0IEeb0HUihVMnJw56JwXE9xYJirsqLtvlkwsEM+5 WoPhFXRJNv045HBoOkybyWNSxnar6oBHcqOCP8XWVOVU/zPi7bnITsNtJ4ziYbulqiSV TxvpVi+MSXojo3IvNbpPSDlqr3p5ZsHw2KmczoePmWUo/9OpHegnPfl2AgAgoDJ9eJUF zjrUhfL8NnN/Ux5BagUZ4ZRn6g3NGyXBh75I0TP36ml4WT83tOADeK2gF9gLLxeX3XhG vc7A== X-Gm-Message-State: AOAM5326iAXonnXPK87KyyXKG7fot5nMFXpmlD8LI9elFYRRXpUk4lYp uhbwDk7NlQX3Z0DxyJ9IclwwLQ== X-Google-Smtp-Source: ABdhPJxaxL/KUxiM37mz4pmYxkZ8JcArmoV2r74oObuQZwBjWSDWoMwdJUFYimiGE/2fmaa9tY0rNA== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr27094488wru.324.1593607640839; Wed, 01 Jul 2020 05:47:20 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:20 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 12/15] mmc: host: sdhci-msm: Staticify local function sdhci_msm_dump_vendor_regs() Date: Wed, 1 Jul 2020 13:46:59 +0100 Message-Id: <20200701124702.908713-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084722_277075_B4CF7BF8 X-CRM114-Status: GOOD ( 14.09 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Adrian Hunter , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org sdhci_msm_dump_vendor_regs() is only used via the .dump_vendor_regs() call-back. It is never exported nor used externally, so it can be static. Squashes the following W=1 kernel build warning: drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes] 1887 | void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index b277dd7fbdb5d..0c02f8a2d11ab 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1884,7 +1884,7 @@ static void sdhci_msm_reset(struct sdhci_host *host, u8 mask) #define SDHCI_MSM_DUMP(f, x...) \ pr_err("%s: " DRIVER_NAME ": " f, mmc_hostname(host->mmc), ## x) -void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) +static void sdhci_msm_dump_vendor_regs(struct sdhci_host *host) { struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); From patchwork Wed Jul 1 12:47:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636253 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D2DF213B4 for ; Wed, 1 Jul 2020 12:49:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA52D20702 for ; Wed, 1 Jul 2020 12:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="keXnaW6T"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xIDiEYkl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA52D20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P7/gsY6WeV2KevUdah9aeEDbCrCzfqUgtZ8AyabHr38=; b=keXnaW6TFHmuAeOfhtJiR5L9i yy/mHmmD0cTBiT8J2Xf1Fmy3jHjp3HAaKbSOw9iLHYwCPIsfGcXwAB+ysLf++HtLtYSM7EkSRy+pG RmZO0KoWMBAWuDgVfLvZAnmVkh44JGTRzIRe2u9JRG7nlth7LXDft6jyfTe4GcjJMkXPEYGCM4CCZ vMUQX7Uxkim26XflLO2UPHoxEnBP1umGTQAMYG1Cdhe6k4NgD22aknBnqSuiqPPM+knNn2oKwGGPE Hqadi0zBcpbXjGj5iU9ASrc3/Lxe3Ns1iqQAVx6hqjPwqe6ePAKWoTEysmJ4hmr6j8Jkkh/5dXSz4 NZGvGqlsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9r-0005PR-0O; Wed, 01 Jul 2020 12:48:11 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc94-0004uj-Ty for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:24 +0000 Received: by mail-wr1-x441.google.com with SMTP id s10so23624545wrw.12 for ; Wed, 01 Jul 2020 05:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=xIDiEYklS6lSZpP6D9pgP0igi/DuLWfHQtgqSxQrazIxDKzatFbofzd5A2lxZECBRp xgjtQ9qigjPm2I9PvVxfMtgVOIO3zEMvCEvi853x8QO6KLsAr0R7mmgVIfL4RruJlql+ xtvfOzVAj5ODP/aWq4ks/9xr7+uRNHZiDwRvvbfKMAlEFVGgBJ4MP7BztMTQk9lB1cy6 pO6NX2PcayLNiR9Ei7AhrqSWZWqG5xjsk2bCLWAueBI1qbYBzRjjcpWOaGChQi+lfluF 84QFziwLTyWWS1h3rphJzHL8TLCaYECg1Le1+RLbeX02xJMNoPAV4Pdm4iq52qPR7Z5X eakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RppFHH3LPgV9Fbxkc7EFxUD1a+LbYIuGU1AKsrw/uFk=; b=ll2hqeMgMcyy+BhywsVUYaFwO51TXeXKc+CarHjeDW80hfQ0R+LhhJeQqm+WLwRkiq i2X1mES5Ehv6euvzbS/0kf6Bh9StdHZIPAze9eI6fN+0urgTDtBTYp6GF+stmOhdE+pg LQsmWANHa50MtKV9lP8wZVy1uVYzgCj1DpfGDz8i7NzyCZdMdy+0Zh0ws61unlh8lMo8 dZjnS4y+fmNzt4ttepMW/HY34qCTwHITnDLh0h3Lw2CRuPQXRJkjhuobvwC7eWGCyZIN FqwKbqeJcLVJUKpWwKc8Db0/ALD9ZlxrVZMDTwoE+dZP8V5r+dOUSRzgubF3cr5S1e0E LFHQ== X-Gm-Message-State: AOAM531+B/XboM06JCrn8bj3bH7aGHR6t4rNGKm8iy03Gndtyizjeyi5 dnt0w2meAVvw4qFF9v6Cc6ypmz2IfKY= X-Google-Smtp-Source: ABdhPJyC8rXxEDpXbOyCSZxcsN81UfnduDOhMYWpILYzv9Y/zpJP7ApdbBjcGjp+fUgrrteEcjr51Q== X-Received: by 2002:a5d:6907:: with SMTP id t7mr26577073wru.329.1593607641927; Wed, 01 Jul 2020 05:47:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:21 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 13/15] mmc: host: sdhci-msm: Demote faux kerneldoc header down to basic comment block Date: Wed, 1 Jul 2020 13:47:00 +0100 Message-Id: <20200701124702.908713-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084723_113522_A9D23A09 X-CRM114-Status: GOOD ( 14.84 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Andy Gross , Adrian Hunter , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org __sdhci_msm_set_clock()'s function header is the only one in kerneldoc format. Which seems odd as it's not part of an external API and isn't referenced anywhere else. Seeing as there has also been no attempt to describe the expected function arguments either, we're going to assume that this is not actually a bona fide kerneldoc use-case. Fixes the following W=1 kernel build warnings: drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'host' not described in '__sdhci_msm_set_clock' drivers/mmc/host/sdhci-msm.c:1595: warning: Function parameter or member 'clock' not described in '__sdhci_msm_set_clock' Cc: Adrian Hunter Cc: Andy Gross Cc: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 0c02f8a2d11ab..7a574fc7635c4 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1583,7 +1583,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host) return SDHCI_MSM_MIN_CLOCK; } -/** +/* * __sdhci_msm_set_clock - sdhci_msm clock control. * * Description: From patchwork Wed Jul 1 12:47:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636261 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A6422913 for ; Wed, 1 Jul 2020 12:49:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E32D20702 for ; Wed, 1 Jul 2020 12:49:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="corA6iB/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Igf8FH8P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E32D20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cf7slLzDBILqCjkWppwQ80veHCKcPmBaFjzq04zMEJ4=; b=corA6iB/i2xKYMFzekpUN80jY ZJzxTOd9QmuIyWCVZOabYSR8h4oHX4hA8me3sBBmpbdLNT2pvnTjuwn6D4envkvKldRUsHDSW+bWK 4eNHuC5OcT/p5BugNVjOO7jaVbFLylgwBRAA9CSQkPiC4jbPpVyzV4TFN5WZIu9r3P3PdlTQ0V0LH BDtEQX6cxrlHepl10sBntSbaPWDq/OJJWzlXProvqD6Gb6f7NcTsWfvCEkIU3yuHwz3DUodrTt7f6 UQg9PwdlwwgZFlRbmrqG/YA5doxHzplxeUVk5hxVO/j5OyjHltRQ51llQI9GfDriMAWsCeyHoc6ku 4btrYr98A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc9y-0005UK-5k; Wed, 01 Jul 2020 12:48:18 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc96-0004vJ-0c for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:25 +0000 Received: by mail-wr1-x441.google.com with SMTP id z2so1403227wrp.2 for ; Wed, 01 Jul 2020 05:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/gJoWFYQiS/u+V7Ey4cmwChdFCLsRE9Rx9263Z1oots=; b=Igf8FH8P6hdkKsVgk8CXs7RoyZeMUEAvTEJYQNZTp+t1LZgNAkLAKn1BdcIPG5ZX+l rscNT7GY/DyCGgRlpTTWOdkLo4LYCl5AlyBQlbjLGBfXsj67ylvJikQahonpLj2+TQha uGBfi+wjKp90MOfhsiMWYRykE3LoUQTwgn6t/1qoYt3cyVOAexgadrj38SqB/FGtO1gQ QoQcTgXLOTl8lEbQsPCii0mmEt4TA4/XesunG6isjLxX+Zwy2Y4t4fkNu8Nky1qAxPK7 BJZG7JB8EMZX6mj1Wi0VDor+x6Cg/whhx+TytTWoqbboaEQAa91Ca+0mUl4Dapdbwzu0 Tj7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/gJoWFYQiS/u+V7Ey4cmwChdFCLsRE9Rx9263Z1oots=; b=TsyaQy8axHhOa5j5gsXLBGEzDWJZoVMYkOfsLWqakYZZCfxLESnfJ9gx1hD8vkzRsT th4cDP6rYqYDrWdEvF4w8k/yifri6Mx5xscXFFZcp5+sihftAX+m2Vy1YZDvGsjIw8Vh Vt8z6AGJ3hOE+71wSCmXaUwv8Vjjbs0NpYhkXbSpec6QnqVPJz2EX6t/lnLkZgKdVKHd cMe7Eqq4XN+I40kyDmooptEbY/rqt+xo5zvwODHwOAyzhxUsz21ZDbDS35GDgCCjFZH5 5vXc1y1nTt97ISDA3/IBRXBwyQn7DCaQvM4AT3Mat8A+bVr9PwK4im9ZLd9/yWBojUIX iKzA== X-Gm-Message-State: AOAM5318CdvW5TQNWzEP210tVlaWvUF/mlfR7ky7sMJ6mp33xfDGH2pq wNi/fTLgL3ZY7SXn82xqiOpWGw== X-Google-Smtp-Source: ABdhPJxRDPkGlJlU4XJGQ/sleeyke1ZZuspWu101J6VUjlcK6F+a1bbhWf8+qWg+jb+I/TlCTyJOJA== X-Received: by 2002:a5d:6846:: with SMTP id o6mr26809049wrw.370.1593607643127; Wed, 01 Jul 2020 05:47:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:22 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 14/15] mmc: host: cqhci: Demote faux kerneldoc header down to basic comment block Date: Wed, 1 Jul 2020 13:47:01 +0100 Message-Id: <20200701124702.908713-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084724_218775_48D77FEF X-CRM114-Status: GOOD ( 14.79 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ritesh Harjani , Venkat Gopalakrishnan , linux-kernel@vger.kernel.org, Adrian Hunter , Lee Jones , linux-arm-kernel@lists.infradead.org, Asutosh Das Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org cqhci_host_alloc_tdl()'s function header is the only one in kerneldoc format. Which seems odd as it's not part of an external API and isn't referenced anywhere else. Seeing as there has also been no attempt to describe the expected function arguments either, we're going to assume that this is not actually a bona fide kerneldoc use-case. Fixes the following W=1 kernel build warning: drivers/mmc/host/cqhci.c:163: warning: Function parameter or member 'cq_host' not described in 'cqhci_host_alloc_tdl' Cc: Adrian Hunter Cc: Ritesh Harjani Cc: Asutosh Das Cc: Venkat Gopalakrishnan Signed-off-by: Lee Jones Acked-by: Adrian Hunter --- drivers/mmc/host/cqhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c index 75934f3c117eb..8cc277b4ffe9e 100644 --- a/drivers/mmc/host/cqhci.c +++ b/drivers/mmc/host/cqhci.c @@ -144,7 +144,7 @@ static void cqhci_dumpregs(struct cqhci_host *cq_host) CQHCI_DUMP(": ===========================================\n"); } -/** +/* * The allocated descriptor table for task, link & transfer descritors * looks like: * |----------| From patchwork Wed Jul 1 12:47:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11636259 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2BE0C14E3 for ; Wed, 1 Jul 2020 12:49:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0575B20702 for ; Wed, 1 Jul 2020 12:49:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LMAJ9jw8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eQGVEx2G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0575B20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U4zeFk2FZ5RZWRtHT5ntRRj37Eb06Bh72SymRoV4jJ0=; b=LMAJ9jw8xBY8A4eBmz7rxFAbf 9SJ+7mnuGYNLE43iQ1nsVf+CFx6hzP3U78lYJmEzaM+nWCslSdsEaOjzXwaKkUZd7yPXM9RXJIVXN OgjEie04lIeRbSC/HSTujBh4Jc0+iHHbOqORXcNXbjdHzt+Jbf3XAsZ2kse0JKIMFXXwpksdNMtG3 PGX0PrHcdR0bZK/M6ece/ZKQsRvvrHAuR2b+Qc1iVUQqsPVbhiwB3IpELGADdRTUJcScNU07KPINQ XX7HKIye7UHVndMpniNtDO2qPFe+zQTzKCjphAeUrqfbmZr0zWqKEB9VmgKaRVIXbbQtINolpsMNU tr7inDmsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqcA7-0005aB-Aw; Wed, 01 Jul 2020 12:48:27 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqc97-0004vr-9W for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 12:47:26 +0000 Received: by mail-wr1-x442.google.com with SMTP id z15so12391850wrl.8 for ; Wed, 01 Jul 2020 05:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QnLoeRbMIPawtLY45ADcQqoBmyPKvpQnROp2LZuEcEU=; b=eQGVEx2G9CgwJoaRiyytD3bAeayvmzMigNnaekh5vAFlUA245DSA0g6cw2hlGXXkTW TyXV6XLQMx3AoT3HoWGV2eQt8JGbxSJYRGy6qwhA2IgBrXDA/cdo4z/50HewPsSMFm+t JNWVg4jGv5mg5JOQlU238F13Xkb08XZScJTD9CM0tJUIW02s5q2Pa9EyJBJCNoOzGJiq loqHBKaYCEOPdf0wmPEJH9cCl3zy09Dj/BryXCfKdY6ysjjer/LebryJb+oYNAb90VPR 6BCSlv5KNWiLYdSwH7TWohviN3hVdnIN4oyA3MgHfAW1epC7QosHmfSpUQCYffrkdL7P 10LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QnLoeRbMIPawtLY45ADcQqoBmyPKvpQnROp2LZuEcEU=; b=pNKAlNe1lJIsx9zncwmsO9lC/aIPPG7YDQRumjGPGaqNRk8wVZi+JBgf4TrHBg4FYR C2A3bhvLnexQnWmPujJThlwksw4rlJJL9SY/dCNCWK0zzrmMShOGWFD4/9VzMsC6Js9r 0psp1MZP+pVAKcVPyrnETz6DMynRVfXxyTnD/KYDzVymlgxpbLQcXkt37UrCFbQGWH54 NeFtj/Il7WN6huWWtzj3qNnJQKAn2tkav+kOknDBPPkr7t09MCLdiMIq7Ef2dqWq9R5e kqqWxTe02R/mTZwdLquxpjhZu5CaJ0XP4LkXoYRLbbyWjPnBzi4CqFfSQzEukCZdU1uS vvyg== X-Gm-Message-State: AOAM533oCkgxZblRWNyzP9DVLR8kK0fXlbJvFJS/d/g3Nen9kqw2EGnZ 2zZn6huweQX3R7+zvq1kcoGp+w== X-Google-Smtp-Source: ABdhPJx5ZJux5WyOu9icq74PEEkDq20mynj0osGwxVYFvb5SgcZMFB2L8zQjL3GioB4vEN4RkmzRwA== X-Received: by 2002:adf:ecce:: with SMTP id s14mr26837602wro.154.1593607644283; Wed, 01 Jul 2020 05:47:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id o29sm7817862wra.5.2020.07.01.05.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 05:47:23 -0700 (PDT) From: Lee Jones To: ulf.hansson@linaro.org Subject: [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used Date: Wed, 1 Jul 2020 13:47:02 +0100 Message-Id: <20200701124702.908713-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org> References: <20200701124702.908713-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_084725_411365_9151C09E X-CRM114-Status: GOOD ( 14.91 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Adrian Hunter , bcm-kernel-feedback-list@broadcom.com, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=] Cc: Adrian Hunter Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com Signed-off-by: Lee Jones --- drivers/mmc/host/sdhci-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c index 225603148d7de..9c7d130205edd 100644 --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -294,7 +294,7 @@ static const struct of_device_id sdhci_iproc_of_match[] = { }; MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match); -static const struct acpi_device_id sdhci_iproc_acpi_ids[] = { +static const struct acpi_device_id __maybe_unused sdhci_iproc_acpi_ids[] = { { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data }, { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data }, { /* sentinel */ }