From patchwork Thu Jul 2 14:45:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639089 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4DD306C1 for ; Thu, 2 Jul 2020 14:46:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 315552067D for ; Thu, 2 Jul 2020 14:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yjw82WJu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729924AbgGBOqe (ORCPT ); Thu, 2 Jul 2020 10:46:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbgGBOqb (ORCPT ); Thu, 2 Jul 2020 10:46:31 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58CD1C08C5C1 for ; Thu, 2 Jul 2020 07:46:31 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id s10so28743645wrw.12 for ; Thu, 02 Jul 2020 07:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RiTsEZKmlrzourRVHCJd/NwIY5VqtrX1m5y/ulB1wRo=; b=yjw82WJumj6TMXLOmN6bgq7tVJe2v9ktMtN5LLLzLsyFajiTkccyVGCqhIIoIgn9nk W4z1Pdizwukxe0IgqzppErqYZo4B4OtFCVjVHQAhZxhhobGjo/AIsXha180UVL5qRthe EjEV4rXnDAVI5ybO4mgNTPAlJJAUuBxtsddJJ3jOReOByTqhha7Q3uXXRZcIkGUrSeKp KZENFOfSgKjU1I+6zmtgpRt7qZzFAhJhvm1WToZq3yEP9zul/OZHLtD5kEAp0c9UxejV oYtECedB2DTkEotpndOoPU6k+9mkozdv/NYbyn6yjk5Od3IehJWQ3BSbfIpuVa6YKMRV 66NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RiTsEZKmlrzourRVHCJd/NwIY5VqtrX1m5y/ulB1wRo=; b=bC2ucKx1SL2j6QcRVArxF9RmKI3A0v2mK0crKaeyeWkORUCPyyuEpeWnie65Q/Bpnv XAHnqNbaunfq4/I4qE5PDXEvavbHTvAgZVg6tvWEwDYbeW68WwE2eONbm4vWZb3m0k/X 7xQOZJUOXDOftAymuoIDxqNGbK1bMzINyFqXkrqBEf0e/6hbbhblenCZ3fAHk3xiDYsZ ULR9a86LU09PV+l7xKOSVTqULeUsKIH0CBGwu282V9nPKp2iYUx+iq/Tj4bU48lmdM2Y SK63WZQQAWmIdsQmY9TTgcUPmIihfa/i58CUJ/RPDhxSfC81TLE6obAqXLBYP/gLQ1Hh 1KNA== X-Gm-Message-State: AOAM532PtCzOZXeOBfmaiibcSvNGVPdvq/5VmeD3jYeEcIJqDp40/swU nMGb4JyOGiC4gEcEIrN6NcYijQ== X-Google-Smtp-Source: ABdhPJyu1qYT+zYhfBDupaUqz6hH9CufCcR9P1VbeJq9vW8PPkJ7AzfYwDapsXNKbDEY85XbGnvUZw== X-Received: by 2002:adf:f445:: with SMTP id f5mr32586837wrp.339.1593701189928; Thu, 02 Jul 2020 07:46:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:29 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 01/30] usb: phy: phy: Fix-up a whole bunch of formatting issues Date: Thu, 2 Jul 2020 15:45:56 +0100 Message-Id: <20200702144625.2533530-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Kerneldoc expects arg descriptions to be in the format '@.*: '. If either the '@' or the ':' is omitted then kerneldoc complains that the description is missing. Add the missing ':'s here. Also provide a new description for 'event'. Fixes the following kernel build W=1 warnings: drivers/usb/phy/phy.c:106: warning: Function parameter or member 'work' not described in 'usb_phy_notify_charger_work' drivers/usb/phy/phy.c:172: warning: Function parameter or member 'nb' not described in 'usb_phy_get_charger_type' drivers/usb/phy/phy.c:172: warning: Function parameter or member 'state' not described in 'usb_phy_get_charger_type' drivers/usb/phy/phy.c:172: warning: Function parameter or member 'data' not described in 'usb_phy_get_charger_type' drivers/usb/phy/phy.c:194: warning: Function parameter or member 'usb_phy' not described in 'usb_phy_set_charger_current' drivers/usb/phy/phy.c:194: warning: Function parameter or member 'mA' not described in 'usb_phy_set_charger_current' drivers/usb/phy/phy.c:244: warning: Function parameter or member 'usb_phy' not described in 'usb_phy_get_charger_current' drivers/usb/phy/phy.c:244: warning: Function parameter or member 'min' not described in 'usb_phy_get_charger_current' drivers/usb/phy/phy.c:244: warning: Function parameter or member 'max' not described in 'usb_phy_get_charger_current' drivers/usb/phy/phy.c:281: warning: Function parameter or member 'usb_phy' not described in 'usb_phy_set_charger_state' drivers/usb/phy/phy.c:281: warning: Function parameter or member 'state' not described in 'usb_phy_set_charger_state' drivers/usb/phy/phy.c:427: warning: Function parameter or member 'dev' not described in 'devm_usb_get_phy' drivers/usb/phy/phy.c:427: warning: Function parameter or member 'type' not described in 'devm_usb_get_phy' drivers/usb/phy/phy.c:456: warning: Function parameter or member 'type' not described in 'usb_get_phy' drivers/usb/phy/phy.c:500: warning: Function parameter or member 'dev' not described in 'devm_usb_get_phy_by_node' drivers/usb/phy/phy.c:500: warning: Function parameter or member 'node' not described in 'devm_usb_get_phy_by_node' drivers/usb/phy/phy.c:500: warning: Function parameter or member 'nb' not described in 'devm_usb_get_phy_by_node' drivers/usb/phy/phy.c:558: warning: Function parameter or member 'dev' not described in 'devm_usb_get_phy_by_phandle' drivers/usb/phy/phy.c:558: warning: Function parameter or member 'phandle' not described in 'devm_usb_get_phy_by_phandle' drivers/usb/phy/phy.c:558: warning: Function parameter or member 'index' not described in 'devm_usb_get_phy_by_phandle' drivers/usb/phy/phy.c:590: warning: Function parameter or member 'dev' not described in 'devm_usb_put_phy' drivers/usb/phy/phy.c:590: warning: Function parameter or member 'phy' not described in 'devm_usb_put_phy' drivers/usb/phy/phy.c:627: warning: Function parameter or member 'type' not described in 'usb_add_phy' drivers/usb/phy/phy.c:721: warning: Function parameter or member 'event' not described in 'usb_phy_set_event' Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/phy/phy.c | 49 ++++++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index ad25546308897..b47285f023cf7 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -88,7 +88,7 @@ static void usb_phy_set_default_current(struct usb_phy *usb_phy) /** * usb_phy_notify_charger_work - notify the USB charger state - * @work - the charger work to notify the USB charger state + * @work: the charger work to notify the USB charger state * * This work can be issued when USB charger state has been changed or * USB charger current has been changed, then we can notify the current @@ -160,9 +160,9 @@ static void __usb_phy_get_charger_type(struct usb_phy *usb_phy) /** * usb_phy_get_charger_type - get charger type from extcon subsystem - * @nb -the notifier block to determine charger type - * @state - the cable state - * @data - private data + * @nb: the notifier block to determine charger type + * @state: the cable state + * @data: private data * * Determin the charger type from extcon subsystem which also means the * charger state has been chaned, then we should notify this event. @@ -178,8 +178,8 @@ static int usb_phy_get_charger_type(struct notifier_block *nb, /** * usb_phy_set_charger_current - set the USB charger current - * @usb_phy - the USB phy to be used - * @mA - the current need to be set + * @usb_phy: the USB phy to be used + * @mA: the current need to be set * * Usually we only change the charger default current when USB finished the * enumeration as one SDP charger. As one SDP charger, usb_phy_set_power() @@ -231,9 +231,9 @@ EXPORT_SYMBOL_GPL(usb_phy_set_charger_current); /** * usb_phy_get_charger_current - get the USB charger current - * @usb_phy - the USB phy to be used - * @min - the minimum current - * @max - the maximum current + * @usb_phy: the USB phy to be used + * @min: the minimum current + * @max: the maximum current * * Usually we will notify the maximum current to power user, but for some * special case, power user also need the minimum current value. Then the @@ -269,8 +269,8 @@ EXPORT_SYMBOL_GPL(usb_phy_get_charger_current); /** * usb_phy_set_charger_state - set the USB charger state - * @usb_phy - the USB phy to be used - * @state - the new state need to be set for charger + * @usb_phy: the USB phy to be used + * @state: the new state need to be set for charger * * The usb phy driver can issue this function when the usb phy driver * detected the charger state has been changed, in this case the charger @@ -414,8 +414,8 @@ static int usb_add_extcon(struct usb_phy *x) /** * devm_usb_get_phy - find the USB PHY - * @dev - device that requests this phy - * @type - the type of the phy the controller requires + * @dev: device that requests this phy + * @type: the type of the phy the controller requires * * Gets the phy using usb_get_phy(), and associates a device with it using * devres. On driver detach, release function is invoked on the devres data, @@ -444,7 +444,7 @@ EXPORT_SYMBOL_GPL(devm_usb_get_phy); /** * usb_get_phy - find the USB PHY - * @type - the type of the phy the controller requires + * @type: the type of the phy the controller requires * * Returns the phy driver, after getting a refcount to it; or * -ENODEV if there is no such phy. The caller is responsible for @@ -480,9 +480,9 @@ EXPORT_SYMBOL_GPL(usb_get_phy); /** * devm_usb_get_phy_by_node - find the USB PHY by device_node - * @dev - device that requests this phy - * @node - the device_node for the phy device. - * @nb - a notifier_block to register with the phy. + * @dev: device that requests this phy + * @node: the device_node for the phy device. + * @nb: a notifier_block to register with the phy. * * Returns the phy driver associated with the given device_node, * after getting a refcount to it, -ENODEV if there is no such phy or @@ -540,9 +540,9 @@ EXPORT_SYMBOL_GPL(devm_usb_get_phy_by_node); /** * devm_usb_get_phy_by_phandle - find the USB PHY by phandle - * @dev - device that requests this phy - * @phandle - name of the property holding the phy phandle value - * @index - the index of the phy + * @dev: device that requests this phy + * @phandle: name of the property holding the phy phandle value + * @index: the index of the phy * * Returns the phy driver associated with the given phandle value, * after getting a refcount to it, -ENODEV if there is no such phy or @@ -578,8 +578,8 @@ EXPORT_SYMBOL_GPL(devm_usb_get_phy_by_phandle); /** * devm_usb_put_phy - release the USB PHY - * @dev - device that wants to release this phy - * @phy - the phy returned by devm_usb_get_phy() + * @dev: device that wants to release this phy + * @phy: the phy returned by devm_usb_get_phy() * * destroys the devres associated with this phy and invokes usb_put_phy * to release the phy. @@ -615,9 +615,9 @@ void usb_put_phy(struct usb_phy *x) EXPORT_SYMBOL_GPL(usb_put_phy); /** - * usb_add_phy - declare the USB PHY + * usb_add_phy: declare the USB PHY * @x: the USB phy to be used; or NULL - * @type - the type of this PHY + * @type: the type of this PHY * * This call is exclusively for use by phy drivers, which * coordinate the activities of drivers for host and peripheral @@ -714,6 +714,7 @@ EXPORT_SYMBOL_GPL(usb_remove_phy); /** * usb_phy_set_event - set event to phy event * @x: the phy returned by usb_get_phy(); + * @event: event to set * * This sets event to phy event */ From patchwork Thu Jul 2 14:45:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639161 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3F4F6C1 for ; Thu, 2 Jul 2020 14:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB19D208B6 for ; Thu, 2 Jul 2020 14:49:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hYKVXrVg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729943AbgGBOtj (ORCPT ); Thu, 2 Jul 2020 10:49:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729920AbgGBOqd (ORCPT ); Thu, 2 Jul 2020 10:46:33 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5C2BC08C5DD for ; Thu, 2 Jul 2020 07:46:32 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s10so28743780wrw.12 for ; Thu, 02 Jul 2020 07:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e63YwYltHzireeUJAWeq6I/Q+T+q+YjnJiKdRakYXIQ=; b=hYKVXrVgkHraKOfZu3k2KQgkRHrWpQyoiVNITKkt1laLeRsQphMY2/cCQQJu6Yxeq3 THAbytYMpx+LL+OHe5i6N7aqfDGUYS1nwUVkXo86nqmsL/g1r1+o4D2Wwlw7xa1TDcb9 W0FNCE+rSz6eQGz46KlgSPYSL4YHs4RZlLpdVVMup84vGo0tmQSvHfVCcsPjRekNJ5wW vdrw4fSR2Y/feAsgx9WotHu0jT2Hbr9cs6ccIIjdBkeW/AtD7DchmnTKJHB6qWLyY16k twS52qFRMzmBCJOAOfwieDFpf/GDvlmB11h6Ajzx0RAxYR6IyNt/wbeNQ17pzw3BSd8F 407g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e63YwYltHzireeUJAWeq6I/Q+T+q+YjnJiKdRakYXIQ=; b=lW7CpM9Pf3ujuGu8HvkffcUOF8GhS7YL1SzhS61MjksPYaXsLb46H4jjBByRN853zD dTcL/cTmYTO1HQBABYzsuLOGkP+IFbi6szPvMUC/32Q0s8go+AjgWk3onQr6prcq1kDl Xe60P/cGNx/AQPdvgLi65EwC5vhDWJqhDYBimZcxgpiRN5g+qangk4RH6loUmFFpdVd0 3YLLrpZ5J84c5AF6OBuc4COGz3DwjlN+jikwyDyg++u+JGaL3U5ahS4gd8uI98cgYa2d 0U/kw1nisVsqQpJbo+0G3arelWmOPx4VjxEoMOSYhLGqFLkJqVEMYgsTGdZ3kKgT8i9j 5ktg== X-Gm-Message-State: AOAM5327H2yA8M8Xaqbg5b4NEiayqiHe9tBbnS9rGAz6EGsVSLjPFB5x +I1a05StvtCZyP9mZyZvTDNLYQ== X-Google-Smtp-Source: ABdhPJwVhXexGFtE5J767EHYTZ5ksk2T2JcVdBbrTkdpijHJTFgDlRPbD9D3pIbKZH4I57pFWKs9HA== X-Received: by 2002:adf:aa90:: with SMTP id h16mr32393226wrc.356.1593701191570; Thu, 02 Jul 2020 07:46:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:30 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Mathias Nyman , Martin Mares , aleksey_gorelov@phoenix.com Subject: [PATCH 02/30] usb: host: pci-quirks: Demote function header from kerneldoc to comment block Date: Thu, 2 Jul 2020 15:45:57 +0100 Message-Id: <20200702144625.2533530-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org quirk_usb_handoff_xhci()'s function header is the only one across the sourcefile which is denoted as a kerneldoc header. Despite no attempt to document its arguments. Drop it down in status from kerneldoc to a standard comment block to match the other headers in the file. Fixes the following W=1 kernel build warning: drivers/usb/host/pci-quirks.c:1145: warning: Function parameter or member 'pdev' not described in 'quirk_usb_handoff_xhci' Cc: Mathias Nyman Cc: Martin Mares Cc: aleksey_gorelov@phoenix.com Signed-off-by: Lee Jones Acked-by: Mathias Nyman --- drivers/usb/host/pci-quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c index 0b949acfa2589..b8961c0381cfd 100644 --- a/drivers/usb/host/pci-quirks.c +++ b/drivers/usb/host/pci-quirks.c @@ -1133,7 +1133,7 @@ void usb_disable_xhci_ports(struct pci_dev *xhci_pdev) } EXPORT_SYMBOL_GPL(usb_disable_xhci_ports); -/** +/* * PCI Quirks for xHCI. * * Takes care of the handoff between the Pre-OS (i.e. BIOS) and the OS. From patchwork Thu Jul 2 14:45:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639157 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6DF416C1 for ; Thu, 2 Jul 2020 14:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DA552089D for ; Thu, 2 Jul 2020 14:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XZH2/Rew" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729938AbgGBOqi (ORCPT ); Thu, 2 Jul 2020 10:46:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729934AbgGBOqg (ORCPT ); Thu, 2 Jul 2020 10:46:36 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E60C08C5DD for ; Thu, 2 Jul 2020 07:46:36 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z13so28793184wrw.5 for ; Thu, 02 Jul 2020 07:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4sdX15PGQylOAZk6Sz4sNwGaJDX52Zxt56l3sZ9x1NU=; b=XZH2/RewojhBFAi5cKK2xZmeR3hWYf8Hb36/KsjUtAhLmQnFfTaP8Wuv9p5IH61VoV efJNPySFXVONCLPCM2T/ePyhmxItYP3DYGvzz56Zu+P7/aLhxohVyUz0Z92qbUD8YAcP gW1RAsBSibUcihwFOp5v9MRBxdxnZlGRnYCxvIYAygFHFHNwsHGzxhwlQKvU68cWjNID rpgAmudz5Jsxiq7nkwTC+fTuNVDcAZFoi949pT6WmfE6dk/I1ukGBVUuPhfxQCnNIBmJ TzfYksu+oqhcRipLU3ELFM2PoikYmCtcBcVAXafRSkgr2ryeMdAE2WNPAdWvHEJhnRQT jd1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4sdX15PGQylOAZk6Sz4sNwGaJDX52Zxt56l3sZ9x1NU=; b=roWzunH/VoqZkj8kJGnuE/vXjKCmi+7g4tPSXb2ts1kqPS+gn9s9izL/23Y0pb/833 72pm5rHl3kaMMFd/PO3auH0yP7kQZ1RCewW6Zo6njKSSVj677WlBkBs+WjD7glpWfX8V +5cFWGdJ2CG/Ff3I7FATW3vzL3HKo7YfL51zNPjkCqqQ9hSLDjDRbZqZpOJIfHXLkavF L8xm5p3YihMZmVgRhPnch1hcSBTQwjoSulvP8CjA79kBKP7vOW7az32GW9ssW/XyMrlA VIQtOo1y43+kQVpupF0NtEb1W4MAp9BpTDsNCqDM3oTZ3ehZx1ZAaXJx6OxA+mDQsEYT vQcg== X-Gm-Message-State: AOAM532//M8ah5bSa6EjJQ8qVmfrXjEcZA07dWRONx5yvQfTboE3GXxO zsyRX46Zrlcg8CAGpCr0+2o0tw== X-Google-Smtp-Source: ABdhPJxFyuUUxdUJtEHuZrAVsfrI1ui/9Xt+xD6a5gkFDyf/gPZpnDWYSne4ItkG8mpc4zEYwpC1gw== X-Received: by 2002:a5d:6a06:: with SMTP id m6mr31648506wru.321.1593701195017; Thu, 02 Jul 2020 07:46:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:34 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Pawel Laszczak , Felipe Balbi , Andrzej Siewior Subject: [PATCH 03/30] usb: common: debug: Demote comment blocks which are obviously not kerneldoc Date: Thu, 2 Jul 2020 15:45:58 +0100 Message-Id: <20200702144625.2533530-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org File headers and simple comments are not kerneldoc worthy. Fixes the following W=1 warnings: drivers/usb/common/debug.c:15: warning: Function parameter or member 'bRequestType' not described in 'usb_decode_get_status' drivers/usb/common/debug.c:15: warning: Function parameter or member 'wIndex' not described in 'usb_decode_get_status' drivers/usb/common/debug.c:15: warning: Function parameter or member 'wLength' not described in 'usb_decode_get_status' drivers/usb/common/debug.c:15: warning: Function parameter or member 'str' not described in 'usb_decode_get_status' drivers/usb/common/debug.c:15: warning: Function parameter or member 'size' not described in 'usb_decode_get_status' drivers/usb/common/debug.c:216: warning: Function parameter or member 'str' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'size' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'bRequestType' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'bRequest' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'wValue' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'wIndex' not described in 'usb_decode_ctrl' drivers/usb/common/debug.c:216: warning: Function parameter or member 'wLength' not described in 'usb_decode_ctrl' Cc: Pawel Laszczak Cc: Felipe Balbi Cc: Andrzej Siewior Signed-off-by: Lee Jones --- drivers/usb/common/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c index 92a986aeaa5d6..092e179d5d5aa 100644 --- a/drivers/usb/common/debug.c +++ b/drivers/usb/common/debug.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * Common USB debugging functions * * Copyright (C) 2010-2011 Texas Instruments Incorporated - http://www.ti.com @@ -207,7 +207,7 @@ static void usb_decode_set_isoch_delay(__u8 wValue, char *str, size_t size) snprintf(str, size, "Set Isochronous Delay(Delay = %d ns)", wValue); } -/** +/* * usb_decode_ctrl - returns a string representation of ctrl request */ const char *usb_decode_ctrl(char *str, size_t size, __u8 bRequestType, From patchwork Thu Jul 2 14:45:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639159 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E8295739 for ; Thu, 2 Jul 2020 14:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9768208B8 for ; Thu, 2 Jul 2020 14:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BjS0+cjb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729944AbgGBOth (ORCPT ); Thu, 2 Jul 2020 10:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729943AbgGBOqj (ORCPT ); Thu, 2 Jul 2020 10:46:39 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC79C08C5DD for ; Thu, 2 Jul 2020 07:46:39 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id q5so28768016wru.6 for ; Thu, 02 Jul 2020 07:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V6gF5OZoL4RS0/p0R84cBC4PkOOgqqKbUR7gNdMwCYM=; b=BjS0+cjbl/ylf9WIsjuuM5KRIKa1tflpMXbUUUReB1WQml9HUW6E7bANNjfQ5fTX/A ePKj5W/F4jTQ5DLni9yk4rEL0mT0PZ8dx/ky2IeK4j26F+tluYD+xaCITBCrSwhHDkG0 UjYtzRYY1AZ1XJ9FbJStn9EZ2dOaSQVOz0ZTjAy3qfUFL/OnG1ALFNX/lOhWfCrk0PAA E9iW5PKN2w1rivJs2V0GOJnXF7m6RAcY+Rhv3sFBPzim9PY9lAbUX+LDiXQaJWjLIobh 7BZt8ywcNGAKtdq5SRkR8fB6Ov7RYsv3mwiu7mpnDcFkBnkV5Ha2N/0X48uQF+Svx/43 Gn0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V6gF5OZoL4RS0/p0R84cBC4PkOOgqqKbUR7gNdMwCYM=; b=A3t/OQaay5T+z5Tt8z5nbK0lTbKluEN9YetKKPbk15Qcl2n//NOsKSDeuYJCyjzk0h 2zaFbQCIZ5n/turl2plOhcaI9V95hzarRGAXy11yIbbfyzuxxNLJSbY3iYKumdwCIcUE PuXtGapNz43YC1nVdf/RpnAas22ef942T0+naglPtQpoQhXLjMvjQIg014Rc7fAGBpm7 ZrXH4mMxF7fjIqA5f1QuzW2IlJFE+1d6S3KtERnREmkfkLVOCrMQocr7k2j5pQTZCVab 5lvYmVGPs2lfRPJVQPeNmXPAQmqVj2pLntl+YPa9RB2ivN2NZprZPt02JjEu1K2zvSmy pyXA== X-Gm-Message-State: AOAM532K63AqM29AzuIq4m56EV8H2fLBD4wNEqze5tdktrkHuQezVse+ xUY5rtzlKy5JOJxLcFtWXpERsg== X-Google-Smtp-Source: ABdhPJxPgeQecG8Qw9IvYuzEGJ3H19n5YN5vEt0bIlABEWuytzwfCAbC88GDg3TzdKAG9CqcWTyTQA== X-Received: by 2002:a5d:4984:: with SMTP id r4mr31220077wrq.215.1593701197660; Thu, 02 Jul 2020 07:46:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:37 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Chunfeng Yun Subject: [PATCH 04/30] usb: common: usb-conn-gpio: Demote comment block which is clearly not kerneldoc Date: Thu, 2 Jul 2020 15:45:59 +0100 Message-Id: <20200702144625.2533530-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This block lacks a title and argument descriptions. Fixes the following W=1 kernel build warning: drivers/usb/common/usb-conn-gpio.c:44: warning: Cannot understand * "DEVICE" = VBUS and "HOST" = !ID, so we have: on line 44 - I thought it was a doc line Cc: Chunfeng Yun Signed-off-by: Lee Jones --- drivers/usb/common/usb-conn-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c index ed204cbb63ea1..b4051f042c79c 100644 --- a/drivers/usb/common/usb-conn-gpio.c +++ b/drivers/usb/common/usb-conn-gpio.c @@ -40,7 +40,7 @@ struct usb_conn_info { int vbus_irq; }; -/** +/* * "DEVICE" = VBUS and "HOST" = !ID, so we have: * Both "DEVICE" and "HOST" can't be set as active at the same time * so if "HOST" is active (i.e. ID is 0) we keep "DEVICE" inactive From patchwork Thu Jul 2 14:46:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639155 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 772D66C1 for ; Thu, 2 Jul 2020 14:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D8CB20CC7 for ; Thu, 2 Jul 2020 14:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="afE8GxK7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730029AbgGBOtb (ORCPT ); Thu, 2 Jul 2020 10:49:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729948AbgGBOqk (ORCPT ); Thu, 2 Jul 2020 10:46:40 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CBCCC08C5DD for ; Thu, 2 Jul 2020 07:46:40 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z2so6524774wrp.2 for ; Thu, 02 Jul 2020 07:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tRsQR13PSt+71+KJ9+2KUCB1us21DRhNxaWRJTFi8XY=; b=afE8GxK7+FqqdTQOg0Q4RfL/jq4qaEfxl3bVjnUTU58Byyndjn0zvnx4zWGWaxbd1G 8HcC2pPTZrDJOXvWZJw2Srm1mc4TKdMYEgzz5rQHZ/vchbzx961n0WWfiYAMcz4bWORc 6yqMFh1JFW3V7a0Jrpihl/434CUzB0yF5qUebR3lgQteVSq+x/MocXFzl8BNYpBbOrNt z7TPIjgB6jtFDr7zIqNK/P9sVMBQ7yuvqAwb7P/Yk2s9AkcxcSmVL5tCjAYNdZyliqQD mvnCt9FkG+r2v32fVSVVcIyAYl4V0Xl60xjM97Dr1WtJxD+AwmzeW240Cm1xUIS5uefk XVrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tRsQR13PSt+71+KJ9+2KUCB1us21DRhNxaWRJTFi8XY=; b=ETaTqzLzDj7AFCHV532AlU444XxE6dWVBN+iqP+mtbF1S1LIYBM6H/m//5I4jvmae6 IlSVC17pxEreq5LMwyTnrmLhCPeU4Ope4T0FpYEUe6hPiTwXzjGjkjhrNDkFYogw85KD ERDxaf9gaAn2DqDRVDpIHGkQLDrgFh1QfpibHLV+dkHTv+vo/3pQgyuN+C1KoYwgf2hG Sp/9LlzKzl4OQNZA9W2XzwQhChiBOI5669lFVYfOpN8xh1pIIRiiRNDUfA+hRMykduTa 8/6ZkTnJ2Hv+1R8jEzIq2RiwPaVKI+rXB/iTNYwdXe/5LTe6qEDTxeqts8qEdTdkha6B USZg== X-Gm-Message-State: AOAM530ZFsqvGG3jB1bS7O5fJU1CYuHkRj8y5sQENagt8z4CX+Xgig+j qKGh2rVjiB9mJaR6T//OS1gunw== X-Google-Smtp-Source: ABdhPJyqONzkjZI9qaxDAqErGMqBbVCt3H11ePJ7rYrmZUiaxTZ0JWbKWEk8+2bN0aTs5d9nufxEOg== X-Received: by 2002:a5d:6045:: with SMTP id j5mr31334712wrt.209.1593701198911; Thu, 02 Jul 2020 07:46:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:38 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Roger Quadros Subject: [PATCH 05/30] usb: dwc3: drd: File headers are not doc headers Date: Thu, 2 Jul 2020 15:46:00 +0100 Message-Id: <20200702144625.2533530-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote drd.c's file header to a standard comment block. Fixes the following W=1 build warnings: drivers/usb/dwc3/drd.c:20: warning: Function parameter or member 'dwc' not described in 'dwc3_otg_disable_events' drivers/usb/dwc3/drd.c:20: warning: Function parameter or member 'disable_mask' not described in 'dwc3_otg_disable_events' Cc: Felipe Balbi Cc: Roger Quadros Signed-off-by: Lee Jones --- drivers/usb/dwc3/drd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 2e483448d6959..fd7f9a9f67dc7 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * drd.c - DesignWare USB3 DRD Controller Dual-role support * * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com From patchwork Thu Jul 2 14:46:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639091 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 940F26C1 for ; Thu, 2 Jul 2020 14:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B8E0208C7 for ; Thu, 2 Jul 2020 14:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oYqkVV24" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbgGBOqn (ORCPT ); Thu, 2 Jul 2020 10:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729952AbgGBOql (ORCPT ); Thu, 2 Jul 2020 10:46:41 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FDADC08C5DF for ; Thu, 2 Jul 2020 07:46:41 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so27093242wmi.3 for ; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J+kkMZUiAX6to3IhikTDOCe6yGlOLBFelQGfEcxa7J0=; b=oYqkVV24P/d5VFn+vZ+xu7zEz2T3MyeSa9GQ7xEp2PIkR7HOZmXSWQOfkdMwfoCcHF ML71NeDp1hvfAL0OmhVnekBhkJTyf/UBwHCpBramw4Q753VTpYPN/yq6UN4vGUP6nUPA gy215GDrhK3vUkq/z0z6i8XYbjgER+KlYeuFAQld6Dfh8HOex73FM2icUOHaoXcYjQkO yinUBmWL3w38DB7AiNpJyvnFg01Nxe0ByKys8XaXwumSrB14MyGneKgiaWXOnTYSwx0+ EyyRZhoCTLrVExgy08RIiE5WQ12iMr43K1LrkrW8+qvyFiOIcGcxrRQ+n6MJ3wo430/Y 5zeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J+kkMZUiAX6to3IhikTDOCe6yGlOLBFelQGfEcxa7J0=; b=IsenJDt4VAU0fG8YHl78WqcquWjd7kxYD2cRThSk9/05HleE9zv+gL6sS72da1EvT2 qGL7ERQ47E+V/rq11tNbw6XVQH6FldlcCHNKTX4JVmhNZwRyECJdbR2ESbASsRW8HeKA YB3OC8grv/BvFNKmx9dOPUPSvtqBgBF43+R53kLF/0p6ELeNpCunZrYuGMlZotHxGJbU i/gpML19mXTikEdH4KiMSWN40Md/tx8vo03cispkCf4LkqKKlMz8u+6F5JBuY/Bcw1QZ q5Rb1+l8gd5C2A2aFZF0qoiCQKBQHhtQUmsT1uJmzddWHl0X2DB8QwUiuiK44Cchif2v l09Q== X-Gm-Message-State: AOAM532SCtVBbEgOYkT+Jf59bkZ+6meptpbd4InxGFB2gXQsmYQeyaO4 abcHPl/E7awfbb7Z25tN4LP8tA== X-Google-Smtp-Source: ABdhPJy7iRwFbgv6eglAJpDWU4n/odEIBwNiUgvkoNtAwDcc/kbXS66Nd69xNj3S9P4CnYRcEag4EA== X-Received: by 2002:a1c:7306:: with SMTP id d6mr23108453wmb.113.1593701199996; Thu, 02 Jul 2020 07:46:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:39 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Heikki Krogerus Subject: [PATCH 06/30] usb: dwc3: ulpi: File headers are not doc headers Date: Thu, 2 Jul 2020 15:46:01 +0100 Message-Id: <20200702144625.2533530-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote ulpi.c's file header to a standard comment block. Fixes the following W=1 build warning: drivers/usb/dwc3/ulpi.c:18: warning: Function parameter or member 'a' not described in 'DWC3_ULPI_ADDR' Cc: Felipe Balbi Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/dwc3/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/ulpi.c b/drivers/usb/dwc3/ulpi.c index f62b5f3c2d67d..e6e6176386a4b 100644 --- a/drivers/usb/dwc3/ulpi.c +++ b/drivers/usb/dwc3/ulpi.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * ulpi.c - DesignWare USB3 Controller's ULPI PHY interface * * Copyright (C) 2015 Intel Corporation From patchwork Thu Jul 2 14:46:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639149 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FFEB739 for ; Thu, 2 Jul 2020 14:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67C8E208B8 for ; Thu, 2 Jul 2020 14:49:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yIWlMjN0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730308AbgGBOtV (ORCPT ); Thu, 2 Jul 2020 10:49:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729959AbgGBOqm (ORCPT ); Thu, 2 Jul 2020 10:46:42 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F85BC08C5DD for ; Thu, 2 Jul 2020 07:46:42 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f18so20722318wrs.0 for ; Thu, 02 Jul 2020 07:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=yIWlMjN0w19WzloUJb27YHxd5Lv2apKTHNCXpZAD+f82IlZ3PHXnJHPuKhqY0rS81s QhZs+X6iPjFvByqqq7pbk0L53rMGDtKW5FxzOziYz6xeaR8f5G/QXdzGL/5bqnDtJiPL sNH3X1dLCSubDr7yM/FA9k24CATuCeAh/iLiL1cX5ux7S1E0GMK8QS8Bt+apIPUWr5vd SZ57qUbVbp6Y3pFbnr8TEYhdSOdESv+8q7JOp726Q0hQtCOeKBHPSPTEt5Msd4ErPqsN BjNbMI2tqHASmGNzXbMyPz2SSAoKQWZklBkBhEeDGBIYuaaXABebQIPiWIan83aqDdb/ Ufrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RqM0ErMZXJazCr0lwXFE+4OfLlFHvj7Gkhb7UJelW6s=; b=CqOeiuNnwCkg6/eTFW57kCNbI6TWTukN3bZFVkcJx8gmq1YAoODs+dH1sxJ+3n3mHd I9WKI1dIZgSPsMk29Nn3BOmc2be7hpXnw11BSJs8DH924BkXCH15lg0iKMyW1cztpIxv ZHWwuF+rOjXINlTW2mjbHJ2F3ccXPdFIzIwelrCmYh29LPKjCOWpF8dd39TptCtdTspV BlJc8YZXy2CSeG2O1DSqVQzqUYXNTJqZQncpcEiXEYRqYJkNXrjTonm+RNRQiezSObTy 91RFJvDU1dIEUKQcjv4H1wo32jutE52EYuBNO8KX5/iaMg6NDvEpZQrB8nDSGps0WQOj 9BZQ== X-Gm-Message-State: AOAM531/urwPWHpBZA56EzzQOZuradY9dIAwBRoEujzq2I7r5qXuQa0R CTC8AKlCA4QHUaVzumKLtCRvZA== X-Google-Smtp-Source: ABdhPJyIZmpTdu7PTQVZc5pYnov4rLotdR3wYot7zbkIhZfmSkLmkMIl/bLtH204G49vYqtuSIyZ/A== X-Received: by 2002:a5d:44c7:: with SMTP id z7mr34212570wrr.226.1593701201196; Thu, 02 Jul 2020 07:46:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:40 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Heikki Krogerus Subject: [PATCH 07/30] usb: common: ulpi: Fix a few kerneldoc related issues Date: Thu, 2 Jul 2020 15:46:02 +0100 Message-Id: <20200702144625.2533530-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Firstly, demote function header to standard comment block as they are not suitable for kerneldoc. Then provide description for ulpi_register_driver()'s argument 'module'. Finally rename description for ulpi_unregister_interface()'s 'ulpi' arg. Fixes the following W=1 warnings: drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'ulpi' not described in 'ulpi_read' drivers/usb/common/ulpi.c:23: warning: Function parameter or member 'addr' not described in 'ulpi_read' drivers/usb/common/ulpi.c:150: warning: Function parameter or member 'module' not described in '__ulpi_register_driver' drivers/usb/common/ulpi.c:299: warning: Function parameter or member 'ulpi' not described in 'ulpi_unregister_interface' drivers/usb/common/ulpi.c:299: warning: Excess function parameter 'intrf' description in 'ulpi_unregister_interface' Cc: Felipe Balbi Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/common/ulpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 9a2ab6751a23c..a18d7c4222ddf 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * ulpi.c - USB ULPI PHY bus * * Copyright (C) 2015 Intel Corporation @@ -143,6 +143,7 @@ static const struct device_type ulpi_dev_type = { /** * ulpi_register_driver - register a driver with the ULPI bus * @drv: driver being registered + * @module: ends up being THIS_MODULE * * Registers a driver with the ULPI bus. */ @@ -290,7 +291,7 @@ EXPORT_SYMBOL_GPL(ulpi_register_interface); /** * ulpi_unregister_interface - unregister ULPI interface - * @intrf: struct ulpi_interface + * @ulpi: struct ulpi_interface * * Unregisters a ULPI device and it's interface that was created with * ulpi_create_interface(). From patchwork Thu Jul 2 14:46:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E4CB16C1 for ; Thu, 2 Jul 2020 14:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8FC02089D for ; Thu, 2 Jul 2020 14:49:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rnd7ZVz1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729968AbgGBOtU (ORCPT ); Thu, 2 Jul 2020 10:49:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729952AbgGBOqo (ORCPT ); Thu, 2 Jul 2020 10:46:44 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DCB5C08C5DF for ; Thu, 2 Jul 2020 07:46:43 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f18so28294692wml.3 for ; Thu, 02 Jul 2020 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zCvEYr43bmvAI4c/u02EnPe5wklhcOBr52WpV3Wdhnc=; b=rnd7ZVz1ZhbElscG9Bkyx7lA4/DyNELrmIlS9pFIxHeR0jZ64UUgjYI7/xmq7V/nBQ ZjeYBcOXpxnMVFhStvkm3qSrrk39Vbmp5EY9GY7i2drA52md+rN3AH5t9d8r0TgeFZNz tw/ORXRpXc9E6zjDPBTC35hNIHMr+7X2+Bt/wd9jC/lvPleiDxFGAMeKNMn6tZwOKAMw +Fr6OtBOW8Ck2cXOQadIEhvAe9qMjojndUc9IB+nRn8EfKDQNJv3QpZ+jbkkt3DrMn/x Qq4i23HE176PnzXDn8TVDQOGIPyiW8rEvw2ymMaPpVPUI/C+iiH4DcU3ekAl1SEKJ2/j EL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zCvEYr43bmvAI4c/u02EnPe5wklhcOBr52WpV3Wdhnc=; b=THjZRN7mQEo+HhLfz1514i1QU9YfZ65MaMafb+iJKjUrDkT7MF9pryChsxZQItV03O 6yFIjGBxSAh4/DNDx/6sb71e+WlLBDLU5p08hH+7UVZcHhO/37Aen98CI1tDNWlVL4nI MYkvAUdqXk14vyOtCrtb66DzJ6snx5nc9ox+VAQTsDnJv1FpSHt3kxUl912W0ZfDfBVN iKHFXbq0DAmOJtmFp/Q+4L1q3kVFjY0ENrHQZ1GnjFMa5lSQysXTrPqD/0KmYAms1ud4 o+gP5yMtm1I8HpMHIDevOgr7HVnigKDOJ4WIl0BpoxayY8UORYYVsP2urhbbP7SizAEf Hikw== X-Gm-Message-State: AOAM531I4O/eVH88BMP8ADawWLczuXhIhLSgLzrppVDUseJU+AFpHUrh 5xEj69nQTMGPlMlF23bPzC3G7g== X-Google-Smtp-Source: ABdhPJxTZlxUGKYXKggwnjvqFMcBCaf45y5q+liL9GM89JskjMNjlM3bEhXyNhYs3yNR7dMSBMPRZA== X-Received: by 2002:a1c:cc12:: with SMTP id h18mr30459205wmb.3.1593701202335; Thu, 02 Jul 2020 07:46:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:41 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Andrzej Siewior , linux-omap@vger.kernel.org Subject: [PATCH 08/30] usb: dwc3: dwc3-omap: Do not read DMA status Date: Thu, 2 Jul 2020 15:46:03 +0100 Message-Id: <20200702144625.2533530-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Commit af566a0be6e49 ("usb: dwc3: omap: get rid of dma_status") rendered reading DMA status from the H/W even more redundant. The variable hasn't been read/used since 2016. Remove the set but unused variable and the call which populates it. Fixes the following W=1 warning: drivers/usb/dwc3/dwc3-omap.c: In function ‘dwc3_omap_probe’: drivers/usb/dwc3/dwc3-omap.c:460:8: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable] 460 | u32 reg; | ^~~ Cc: Felipe Balbi Cc: Andrzej Siewior Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-omap.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index 8c3de2d258bf7..11288a370828c 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * dwc3-omap.c - OMAP Specific Glue layer * * Copyright (C) 2010-2011 Texas Instruments Incorporated - http://www.ti.com @@ -457,8 +457,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) int ret; int irq; - u32 reg; - void __iomem *base; if (!node) { @@ -503,9 +501,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) dwc3_omap_map_offset(omap); dwc3_omap_set_utmi_mode(omap); - /* check the DMA Status */ - reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG); - ret = dwc3_omap_extcon_register(omap); if (ret < 0) goto err1; From patchwork Thu Jul 2 14:46:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639137 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B91F739 for ; Thu, 2 Jul 2020 14:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4256E2089D for ; Thu, 2 Jul 2020 14:48:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bxMpXkgM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbgGBOqu (ORCPT ); Thu, 2 Jul 2020 10:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbgGBOqs (ORCPT ); Thu, 2 Jul 2020 10:46:48 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F1C1C08C5E2 for ; Thu, 2 Jul 2020 07:46:44 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id q5so28768603wru.6 for ; Thu, 02 Jul 2020 07:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K724gNBq1+8gJuUosuyXSMvH+REcJBS2sGMOEUVIfWc=; b=bxMpXkgMVaIQhUosfclwMUUcexKCyxfNvmHDbmWxGE6fnfTamN5u0EjbZj6xscXTJO KIqwSDdDoUdpSQjaH5gfR2j3bPAjelzx07KQNxL5h1MuR11ckg4jcR5+LCNbnF7m0LyX uc+hTJBCiFR8J/aHBmIrhWw+iCM8BO8LXIO9UZm+GQk+ettGaEC+svC5PHWO9knyxcxq Eyx45/1OtfW7w8v3xhWVQYzHpRGQvw0Iu6TXfXbdmUcCnnO7yuLErpt3TcRveMRqx4t5 9j6tlz681kwT2hbuts1GpJis58KKUpqBVck9dSa7i7jQ4OzcB3v+7hlHUu2FUQP7ik3B tWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K724gNBq1+8gJuUosuyXSMvH+REcJBS2sGMOEUVIfWc=; b=kMIU/cnvzYN8pGKD0LdJxrrsSwRv+jbME6VUVWmwf0cEfvTrG9KhwfndjEe9eszVAg sN83HYAZ2xta/2jbaf57TEgPl2/G3t7Cs1RS/P+L1hN51Qw4EnV0n3QwCzrpVQMzgOMd KS/VJBOBbEv7QiDtV1wEi83O/GkF+9u4KhAK/YGLbrE35RenIgQvcfgeT3d0V4AEHA8c p5jWlPAbZYC3lIIvkEpxN6FsJ/Px9y3/9R7nwr4FQvHYiAESz9/HUO5uIVDyZIRGpXUc 3ONTriR0cSo8e201S2i4qqUkj0ETHAjPAoQyH82Ri8Wak14wMltR4rRCp+hcYZYuhxUF /SAQ== X-Gm-Message-State: AOAM532Sg4bz86pO7y2GMvGNT1ElxR2FeHp44V5eQtDbn/l7UAHF0JK4 T8nsgEziwAZgJgBE2WNXlRQsxw== X-Google-Smtp-Source: ABdhPJy4S926IqfqG9+GjXBGJlktkqEcFIY2+P6+GBBzSak8NQL0ghDJYlnEAQjhrd4dBc3MisUR1Q== X-Received: by 2002:a5d:4051:: with SMTP id w17mr30549831wrp.183.1593701203410; Thu, 02 Jul 2020 07:46:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:42 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Minas Harutyunyan , Ben Dooks Subject: [PATCH 09/30] usb: dwc2: gadget: Do not read GINTMSK2 Date: Thu, 2 Jul 2020 15:46:04 +0100 Message-Id: <20200702144625.2533530-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The value of GINTMSK2 hasn't been checked since the inception of dwc2_gadget_wkup_alert_handler() in 2018. Fixes the following W=1 warning: drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’: drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable] 259 | u32 gintmsk2; | ^~~~~~~~ Cc: Minas Harutyunyan Cc: Ben Dooks Signed-off-by: Lee Jones --- drivers/usb/dwc2/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 12b98b4662872..14c422ee6a069 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -256,10 +256,8 @@ int dwc2_hsotg_tx_fifo_total_depth(struct dwc2_hsotg *hsotg) static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) { u32 gintsts2; - u32 gintmsk2; gintsts2 = dwc2_readl(hsotg, GINTSTS2); - gintmsk2 = dwc2_readl(hsotg, GINTMSK2); if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) { dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__); From patchwork Thu Jul 2 14:46:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639145 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6B9A1739 for ; Thu, 2 Jul 2020 14:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FD59208C7 for ; Thu, 2 Jul 2020 14:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A7SXqjqr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729990AbgGBOs7 (ORCPT ); Thu, 2 Jul 2020 10:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729987AbgGBOqs (ORCPT ); Thu, 2 Jul 2020 10:46:48 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10538C08C5E3 for ; Thu, 2 Jul 2020 07:46:47 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id f18so28295037wml.3 for ; Thu, 02 Jul 2020 07:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sONund+v6m72UXA2k3mTvsnzOlUrvp8LHJR6S/5dS2c=; b=A7SXqjqrCM16AVWVbtxBs+8Q7KGVv5itBId7jsXn1AHLh3Veja6uzD8SFiMxl2t4vW rRF59UeX210MC4awzP8qxatLAoLaTqe+g6NZB5Y9eStTCYo9NLjEoQKDNzzXMjoXbeok CiVBADgITsgHMUKr55N6uCwjVEVtVYDES7xmS/ui20fUJ1IbAEhYec63OQgoF1LafLc0 5SV9rFD21yf03RMLcybreux5P78eLRfpg6B+F6tQv7FYQOagpviBnjHwu0Pw0RRSZyfX jlsCnKv9/Ig3pejOEJF3CzbQdz/Ab06ku9zTCfDTG3urmvKVx1uSkSnq22manAl0mLN8 eTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sONund+v6m72UXA2k3mTvsnzOlUrvp8LHJR6S/5dS2c=; b=FFWeFwO87AnhRWnH5oygUCyEG92nEMj8/PWunQs/niiWJCMOQ0+Um3stb9+++06eIk bU3SxLQibG1JXkwmbuLcTpgJTf3KeHR+r4djTYResxnO8kkItAiY7sgwW+Fg9/dMqL6E v6quFBoX3vJFFnQbV9g7+pzmy8NZdNqcYWS8MEE1/9SYSjorIw9JHbJ6xIrtLNK62j0V gdkRE3gBXBc1MP1p9RmT7gYHpsPPUFv5rqMC7VBD+8Yo01kZV0p40vQ9axwsWVGL8f6X hO/m/kY22YkeVdDEoKK42OiYCUmuPB1Ytw1KqyQ7gjthF+f6m2ApAeHFdc/9eNiJiIut SDug== X-Gm-Message-State: AOAM531r8KGQNEQzw7LDmnEF3pIlmrpDqLI/mLuXIK82bkDIi8QhmuHC 0NfjMyPPaDZO0UAT/WfchETfDA== X-Google-Smtp-Source: ABdhPJzRi4BPfjzXaW8qFukfmFtIxWbM/JfxYDBuDyf0+vYOnyYhbkx/MYyV1XQriU0Sd2wBnDG/MA== X-Received: by 2002:a1c:b4c2:: with SMTP id d185mr30552073wmf.57.1593701204872; Thu, 02 Jul 2020 07:46:44 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:43 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Minas Harutyunyan , Ben Dooks Subject: [PATCH 10/30] usb: dwc2: gadget: Remove assigned but never used 'maxsize' Date: Thu, 2 Jul 2020 15:46:05 +0100 Message-Id: <20200702144625.2533530-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The value of 'maxsize' has not been checked since commit 729cac693eecf ("usb: dwc2: Change ISOC DDMA flow") back in 2018, so remove the set but unused variable, which fixes the following W=1 kernel build warning: drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_fill_isoc_desc’: drivers/usb/dwc2/gadget.c:885:6: warning: variable ‘maxsize’ set but not used [-Wunused-but-set-variable] 885 | u32 maxsize = 0; | ^~~~~~~ Cc: Minas Harutyunyan Cc: Ben Dooks Signed-off-by: Lee Jones --- drivers/usb/dwc2/gadget.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 14c422ee6a069..116e6175c7a48 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -880,11 +880,10 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep, struct dwc2_dma_desc *desc; struct dwc2_hsotg *hsotg = hs_ep->parent; u32 index; - u32 maxsize = 0; u32 mask = 0; u8 pid = 0; - maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask); + dwc2_gadget_get_desc_params(hs_ep, &mask); index = hs_ep->next_desc; desc = &hs_ep->desc_list[index]; From patchwork Thu Jul 2 14:46:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639133 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31DF16C1 for ; Thu, 2 Jul 2020 14:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1933E214F1 for ; Thu, 2 Jul 2020 14:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y+Hz7s1H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730004AbgGBOqv (ORCPT ); Thu, 2 Jul 2020 10:46:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729989AbgGBOqt (ORCPT ); Thu, 2 Jul 2020 10:46:49 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 392F2C08C5F3 for ; Thu, 2 Jul 2020 07:46:47 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g10so9234394wmc.1 for ; Thu, 02 Jul 2020 07:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ekU/9fToolV+bnxY6uX+/NgRtkggBCTFheSpOeaBTsQ=; b=y+Hz7s1H9c6E1muboBIQnKa1duyLm9Puyw0SItMBVefMB9XgGsxNMgUvs1xGrvIgYE RobvU+GQKeiKScPwvyKiIuVUYUcLaE1/nvfdKccNfyv5+MvA5wCwfQcKVx7zK139D7Jq ZJUwxai3KootCSJFle1ffk2k5vJ0aiBsqqJkOf4gPxUh/FsKJownzbYSvOU8wUkV2kBu WAfo0c9r1FtOS3RpnmvBUg+i4NU0VPGXBUIm7ORvIkZowhL8kNJlVkVdsGFOiWxADhCF PK3W1qdTIqxSrOrWTRaurHqtBvnHIyZ+Wty4zVcZOHLl2ktHh3fjxQS5H1I+pgpOIXQz 1kjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ekU/9fToolV+bnxY6uX+/NgRtkggBCTFheSpOeaBTsQ=; b=X1UZZSWvNQP+MtYd646QTP/6cUURa0MnysRcfP65eIVOLB1Ufp4OZWJvh1M1624xUj ZWviyjHz6gxcaNL31TGVyU9c7Hsd/M29KpW1FbncyrhQjUx2HgdFKnOD21mUf10gnoEz FWR4/xW65Nhltn+N2U2HPc5Of67SWIoscevpHeiS8fALJ8oeIk3IZJoHuqH0DnVHY79z vAK3efL79++8Ab6I/oLs2zJ8qVccTto3npMYeoW8dORN1l8vDzQ/vNbAtL0w7YKnVG3J jilXRH5IIsJ8YK8Eseu04K16h/ztTGzDw4QJJE+MwQRIxnpW/Yjr0SewCJkXZ602HIFj rJqg== X-Gm-Message-State: AOAM530hPg3o7Lgu/HtJa7gO0VxsON8bMz/NHAOAEkknEba3r3L5k61C yMZuv6KUST7jaLdhCZX57vQLOQ== X-Google-Smtp-Source: ABdhPJyOOLDdd4ToMUJ/Ps2rddIfsLpgMyUtYk7cO7KTC+3Mst0iapsfhCWCGek0yCKObOQbs9rkww== X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr34759591wmj.117.1593701205836; Thu, 02 Jul 2020 07:46:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Minas Harutyunyan , Ben Dooks Subject: [PATCH 11/30] usb: dwc2: gadget: Avoid pointless read of EP control register Date: Thu, 2 Jul 2020 15:46:06 +0100 Message-Id: <20200702144625.2533530-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Commit ec1f9d9f01384 ("usb: dwc2: gadget: parity fix in isochronous mode") moved these checks to dwc2_hsotg_change_ep_iso_parity() back in 2015. The assigned value hasn't been read back since. Let's remove the unnecessary H/W read. Fixes the following W=1 warning: drivers/usb/dwc2/gadget.c: In function ‘dwc2_hsotg_epint’: drivers/usb/dwc2/gadget.c:2981:6: warning: variable ‘ctrl’ set but not used [-Wunused-but-set-variable] 2981 | u32 ctrl; | ^~~~ Cc: Minas Harutyunyan Cc: Ben Dooks Signed-off-by: Lee Jones Acked-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 116e6175c7a48..fa07e3fcb8841 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2975,10 +2975,8 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx, u32 epctl_reg = dir_in ? DIEPCTL(idx) : DOEPCTL(idx); u32 epsiz_reg = dir_in ? DIEPTSIZ(idx) : DOEPTSIZ(idx); u32 ints; - u32 ctrl; ints = dwc2_gadget_read_ep_interrupts(hsotg, idx, dir_in); - ctrl = dwc2_readl(hsotg, epctl_reg); /* Clear endpoint interrupts */ dwc2_writel(hsotg, ints, epint_reg); From patchwork Thu Jul 2 14:46:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDF966C1 for ; Thu, 2 Jul 2020 14:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C615E2089D for ; Thu, 2 Jul 2020 14:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D272CbLl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730279AbgGBOsp (ORCPT ); Thu, 2 Jul 2020 10:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729993AbgGBOqt (ORCPT ); Thu, 2 Jul 2020 10:46:49 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6159FC08C5F4 for ; Thu, 2 Jul 2020 07:46:48 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f139so28291653wmf.5 for ; Thu, 02 Jul 2020 07:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PqDEsV0Ck+FNcXivlLFCVSGlGxhukzNkii5C/yRAQ+E=; b=D272CbLlqYE9XwhTGGNkOy3kKTQob4ZwxsVME5EGX5gMkHXxZcrMA1pMr8s9YEl6MV PGGJD1O6CzfIreM5GJPlte1v7+CCoZ6DW5if1ZQjQbLpw0NMcNcxUqFggpHYGovppt05 Cwx8Zkwsbkpf35qf8zMBgrMa4evocB4C6NwHMM/guVMeL+4hjxo+Xg+EXB3bMjlt3l6j QE14ppYiN/fYozy+KORlSqwt2sa3qJRfhpq5gSM91UDZ0cP+tWUmsa/CuiQ3k/uaGsd+ FLaClHPAo2mrk9SSnnR1xL8UXMJp+fTT5P2nNXpna2sBIAUz6nMX8ImmgM8fZBOW6cyG BYfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PqDEsV0Ck+FNcXivlLFCVSGlGxhukzNkii5C/yRAQ+E=; b=ALrHI5iqv6h3nkiVlh10kvrG8GyPfNrC0eZU3ZnZRITn0O5GGn2WKz9VcWmwQ8yZEW SX52OaS3x5M9lB5pSbadcI6GcvtyPE5RDue4qZZUl08boljxjkDR11Vj2HRMYll9GbNM SaqujdzTEh5fBQ31k5VBdRGig6fhRH+VYKYQFRD/iN0SNElHd2qyxYS7yfX2s2sUpfy1 zBXfv+3xIzK7XmTlIBvbGCVYd+IBGpMrj07k133PniPprJ8PGSMufbcoXm2xfE4jTWNA mlxJPssCuRknKwAuRmSlnXyRLLf9ii8zOZUz+w0pWCF5ZTi64JKEwYYgJFyhoV8mwt9Z U6SA== X-Gm-Message-State: AOAM530d5tEdaJVqcf4dXanYXWn8tzTCw6HW6D3qYwpuTyKXBlQDwXlP MPppky8iVPsNh5AyU+zcy+641w== X-Google-Smtp-Source: ABdhPJzVNf36Ya/k9DJuBz/EJ9+MpHowcfEHl6qa1yClZCcdX++IxMz5yyGSGjVqzQDKr0VxrpsqQA== X-Received: by 2002:a1c:81c1:: with SMTP id c184mr6925584wmd.120.1593701207158; Thu, 02 Jul 2020 07:46:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:46 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Vikram Pandita , Anand Gadiyar , Keshava Munegowda , Roger Quadros , Felipe Balbi , linux-omap@vger.kernel.org Subject: [PATCH 12/30] usb: host: ehci-omap: Provide documentation for ehci_hcd_omap_probe()'s arg 'pdev' Date: Thu, 2 Jul 2020 15:46:07 +0100 Message-Id: <20200702144625.2533530-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Description for 'pdev' argument was missing from the function header. Fixes the following W=1 warning: drivers/usb/host/ehci-omap.c:87: warning: Function parameter or member 'pdev' not described in 'ehci_hcd_omap_probe' Cc: Alan Stern Cc: Vikram Pandita Cc: Anand Gadiyar Cc: Keshava Munegowda Cc: Roger Quadros Cc: Felipe Balbi Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/host/ehci-omap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index fc125b3d06e7d..2ec686e28582a 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -78,6 +78,7 @@ static const struct ehci_driver_overrides ehci_omap_overrides __initconst = { /** * ehci_hcd_omap_probe - initialize TI-based HCDs + * @pdev: Pointer to this platform device's information * * Allocates basic resources for this USB host controller, and * then invokes the start() method for the HCD associated with it From patchwork Thu Jul 2 14:46:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639141 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CAC0739 for ; Thu, 2 Jul 2020 14:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22D922067D for ; Thu, 2 Jul 2020 14:48:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MnIF3NKM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730275AbgGBOso (ORCPT ); Thu, 2 Jul 2020 10:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729996AbgGBOqu (ORCPT ); Thu, 2 Jul 2020 10:46:50 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830C4C08C5DF for ; Thu, 2 Jul 2020 07:46:49 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o8so27099009wmh.4 for ; Thu, 02 Jul 2020 07:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A68m/4vXtRoEt+tCUl/deoA+S6NQ0dzD0za0e2IsKFc=; b=MnIF3NKMeHllD9bTiFG/UBWre8WcWJwn5Gs+iOqWaPWWVSs3Fmue2tnex/eI8nRqPE XQauSD7JfNVMRzo5iKgnr8oq0f8dcrGaXVQgT+wgmvxBBPLfRQpEcxBSpsifs7sxW9TI y7LrKuy/z5fGS7KaetA8KIHoBZ1xNWSKfbioR04TI5jOLFjaaMAUV6foseYp2OYdkRM4 1Z0jBQW5Nt733Tztd5Mv871YZPC7G+E2gk7GlaK964bTvoaRTTMT0v5Op/LxtOUhhyPI eeWnTopVRGYVBugAlMM1Yaopc5tKTEPkusEWAxPsCNUFafsAbuPDdUnPwlEpVSXqMaMZ sQYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A68m/4vXtRoEt+tCUl/deoA+S6NQ0dzD0za0e2IsKFc=; b=UUZZWhB1LM++Jg95d0MYKfy+EnJfNy9tgFKW/alTEp5cfRgnZf9n89r5qff1AHKdy3 2HTvtcxzszJiXOxfygT5aFGabbN6h8y5rmzSjh6xKAuFbmWKOUxM2X1SQ5mVCF90p0Rh lrfwWkgKnsvbwAuxpIIBDB34o8teKKuO8RMTqKn1Vh6kAJbfEdq1eAcsx5BkSs7e+25j SxFrtQMu/qIYbK0VuaX+oAq4xd+fiGmxuNVwWP/jDSIdaSQaTeQTLyn3kLQf4QfOx2aj Cmq1aBT8N30DH5KTrHV18n0QAayGTD4EwYOo4WP46C2VmC7SV2xFHCaWUvoDn12Xr/7e e9Og== X-Gm-Message-State: AOAM533yf1X0NqbCtJZJHB++b0ZdUoeHMnuZEt0Qurb4iWn2Qkvpu9jr n1rNaxa8GEgT/crMiWsTnw3YeA== X-Google-Smtp-Source: ABdhPJw/XS4Q1S0GGevj+ph6k6w1go7mzC+xGwxs/OouigSO7U4rDiQ8fCZ+aBU/5fV4s1OKUk6Idg== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr32283737wmk.77.1593701208260; Thu, 02 Jul 2020 07:46:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:47 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Pawel Laszczak , Peter Chen , Roger Quadros Subject: [PATCH 13/30] usb: cdns3: core: Fix incorrect formatting and misspelled function arg docs Date: Thu, 2 Jul 2020 15:46:08 +0100 Message-Id: <20200702144625.2533530-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org There are 3 misspellings and 1 incorrect format used in this file's kerneldoc function headers. Fixing them squashes the following W=1 kernel build warnings: drivers/usb/cdns3/gadget.c:653: warning: Function parameter or member 'priv_ep' not described in 'cdns3_wa2_descmissing_packet' drivers/usb/cdns3/gadget.c:653: warning: Excess function parameter 'priv_dev' description in 'cdns3_wa2_descmissing_packet' drivers/usb/cdns3/gadget.c:1088: warning: Function parameter or member 'request' not described in 'cdns3_ep_run_transfer' drivers/usb/cdns3/gadget.c:2574: warning: Function parameter or member 'priv_ep' not described in '__cdns3_gadget_ep_set_halt' drivers/usb/cdns3/gadget.c:2574: warning: Excess function parameter 'ep' description in '__cdns3_gadget_ep_set_halt' drivers/usb/cdns3/gadget.c:2595: warning: Function parameter or member 'priv_ep' not described in '__cdns3_gadget_ep_clear_halt' drivers/usb/cdns3/gadget.c:2595: warning: Excess function parameter 'ep' description in '__cdns3_gadget_ep_clear_halt' drivers/usb/cdns3/gadget.c:2898: warning: Function parameter or member 'priv_dev' not described in 'cdns3_init_eps' drivers/usb/cdns3/gadget.c:2898: warning: Excess function parameter 'cdns3' description in 'cdns3_init_eps' drivers/usb/cdns3/gadget.c:3210: warning: Function parameter or member 'cdns' not described in 'cdns3_gadget_init' Cc: Pawel Laszczak Cc: Peter Chen Cc: Roger Quadros Signed-off-by: Lee Jones --- drivers/usb/cdns3/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 19bbb5b7e6b6c..59e5e213a99bb 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -282,7 +282,7 @@ static int cdns3_idle_init(struct cdns3 *cdns) /** * cdns3_hw_role_switch - switch roles based on HW state - * @cdns3: controller + * @cdns: controller */ int cdns3_hw_role_switch(struct cdns3 *cdns) { @@ -320,7 +320,7 @@ int cdns3_hw_role_switch(struct cdns3 *cdns) /** * cdsn3_role_get - get current role of controller. * - * @dev: Pointer to device structure + * @sw: pointer to USB role switch structure * * Returns role */ @@ -334,8 +334,8 @@ static enum usb_role cdns3_role_get(struct usb_role_switch *sw) /** * cdns3_role_set - set current role of controller. * - * @dev: pointer to device object - * @role - the previous role + * @sw: pointer to USB role switch structure + * @role: the previous role * Handles below events: * - Role switch for dual-role devices * - USB_ROLE_GADGET <--> USB_ROLE_NONE for peripheral-only devices From patchwork Thu Jul 2 14:46:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639135 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 584BE739 for ; Thu, 2 Jul 2020 14:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 368252089D for ; Thu, 2 Jul 2020 14:48:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C4y+Myvz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730269AbgGBOsj (ORCPT ); Thu, 2 Jul 2020 10:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730003AbgGBOqv (ORCPT ); Thu, 2 Jul 2020 10:46:51 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EE43C08C5DD for ; Thu, 2 Jul 2020 07:46:50 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l17so27118414wmj.0 for ; Thu, 02 Jul 2020 07:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kl7sz8QA1tp3BsjE/r0OSQuznzm9IU6toz3QDXE6srY=; b=C4y+MyvzGjWT5mo+mg50PzeIgmLfB6enO3CDM4ud6BHtsMBDG6WYTz5E/zlNT5bdVN uqOGQzeXk+cQ9C88ep5Os/SO4JLiJpIMBtkWnibMng/BdShwRCdWzGivNel5W0u3loQo kA9lKtjOxrgy/hdPR3YBZZdVmRYNRZQY5zkRqOB5KvC2jAoY0BasgzIweMUopiIXCw6h nSFj2pB8cwQoI/PgQzlyWAUKi0Zhb7CX58t3cqgORy4DcYy93PevYKZRsF7oDt5MeJUA mwb9uf/Cl44mu/3TC9lpgE4PNlm+bJknnnITiHC5ced76dYl7/QC6pirP7P+PJ8GC3NT LfIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kl7sz8QA1tp3BsjE/r0OSQuznzm9IU6toz3QDXE6srY=; b=CenxT8MybAfi6GSuMztvrLQKhRrIQFV+rOVvKaqPkYzcPAYz1bKmH/uMJHJFWAbkKh XyW1/JCwo0sE3WKdz5P+eKAe5Z58G8LfXIWm1lrrFoPBGQto9OHVlDzhzru+UokR18vV fMmjrrf9IiN8oOdsBLPUiD276oHjDabM0+2DNlaQZEKuvjjzMHN9WB97hp+ykmtb2U3G Z86m/xdNsQJ4ZXR8i0bCUHEsyGG9s7NEe3h2vmydk4As7o5opxGGaMtcibRs8jjxHnnY netnupEgQEBIxQqcFK+ApQ9iPWWhTEqu0pOl2/1f90AQckjC5Ys+Bm73M1TgvvfEgLDX ubIg== X-Gm-Message-State: AOAM533jMQHHr2xHQZjFKqF0XSMSHtGkUymBC+wNDU4lf9vplZy5GwwS t+z0Up/YzIBfbKpbqwfo+/nuAA== X-Google-Smtp-Source: ABdhPJx7VJnF3IZsz1knssd5zApJ5vUeYhNVJHgmwD44/LNnJPIxKZZCahG6RssJD9o76EkSSK6XMA== X-Received: by 2002:a1c:e914:: with SMTP id q20mr30734859wmc.145.1593701209352; Thu, 02 Jul 2020 07:46:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:48 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Pawel Laszczak , Pawel Jez , Peter Chen Subject: [PATCH 14/30] usb: cdns3: ep0: Fix a bunch of kerneldoc issues Date: Thu, 2 Jul 2020 15:46:09 +0100 Message-Id: <20200702144625.2533530-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Add some missing function argument descriptions for 'ep', 'desc' and 'zlp', and correct spelling/bitrot issues surrounding the correct spelling of present args. Fixes the following W=1 warnings: drivers/usb/cdns3/ep0.c:36: warning: Function parameter or member 'zlp' not described in 'cdns3_ep0_run_transfer' drivers/usb/cdns3/ep0.c:236: warning: Function parameter or member 'ctrl' not described in 'cdns3_req_ep0_get_status' drivers/usb/cdns3/ep0.c:236: warning: Excess function parameter 'ctrl_req' description in 'cdns3_req_ep0_get_status' drivers/usb/cdns3/ep0.c:411: warning: Function parameter or member 'ctrl' not described in 'cdns3_req_ep0_handle_feature' drivers/usb/cdns3/ep0.c:411: warning: Excess function parameter 'ctrl_req' description in 'cdns3_req_ep0_handle_feature' drivers/usb/cdns3/ep0.c:661: warning: Function parameter or member 'ep' not described in 'cdns3_gadget_ep0_enable' drivers/usb/cdns3/ep0.c:661: warning: Function parameter or member 'desc' not described in 'cdns3_gadget_ep0_enable' drivers/usb/cdns3/ep0.c:671: warning: Function parameter or member 'ep' not described in 'cdns3_gadget_ep0_disable' drivers/usb/cdns3/ep0.c:867: warning: Function parameter or member 'priv_ep' not described in 'cdns3_init_ep0' drivers/usb/cdns3/ep0.c:867: warning: Excess function parameter 'ep_priv' description in 'cdns3_init_ep0' Cc: Pawel Laszczak Cc: Pawel Jez Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/cdns3/ep0.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 82645a2a0f529..5b3f682338e50 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -227,7 +227,7 @@ static int cdns3_req_ep0_set_address(struct cdns3_device *priv_dev, /** * cdns3_req_ep0_get_status - Handling of GET_STATUS standard USB request * @priv_dev: extended gadget object - * @ctrl_req: pointer to received setup packet + * @ctrl: pointer to received setup packet * * Returns 0 if success, error code on error */ @@ -400,7 +400,7 @@ static int cdns3_ep0_feature_handle_endpoint(struct cdns3_device *priv_dev, * Handling of GET/SET_FEATURE standard USB request * * @priv_dev: extended gadget object - * @ctrl_req: pointer to received setup packet + * @ctrl: pointer to received setup packet * @set: must be set to 1 for SET_FEATURE request * * Returns 0 if success, error code on error @@ -653,6 +653,9 @@ void cdns3_check_ep0_interrupt_proceed(struct cdns3_device *priv_dev, int dir) /** * cdns3_gadget_ep0_enable + * @ep: pointer to endpoint zero object + * @desc: pointer to usb endpoint descriptor + * * Function shouldn't be called by gadget driver, * endpoint 0 is allways active */ @@ -664,6 +667,8 @@ static int cdns3_gadget_ep0_enable(struct usb_ep *ep, /** * cdns3_gadget_ep0_disable + * @ep: pointer to endpoint zero object + * * Function shouldn't be called by gadget driver, * endpoint 0 is allways active */ @@ -690,6 +695,7 @@ static int cdns3_gadget_ep0_set_halt(struct usb_ep *ep, int value) * @ep: pointer to endpoint zero object * @request: pointer to request object * @gfp_flags: gfp flags + * @zlp: add zero length packet * * Returns 0 on success, error code elsewhere */ @@ -858,7 +864,7 @@ void cdns3_ep0_config(struct cdns3_device *priv_dev) /** * cdns3_init_ep0 Initializes software endpoint 0 of gadget * @priv_dev: extended gadget object - * @ep_priv: extended endpoint object + * @priv_ep: extended endpoint object * * Returns 0 on success else error code. */ From patchwork Thu Jul 2 14:46:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7F7996C1 for ; Thu, 2 Jul 2020 14:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 621FC2089D for ; Thu, 2 Jul 2020 14:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mq1Q5i/A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730018AbgGBOqy (ORCPT ); Thu, 2 Jul 2020 10:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730007AbgGBOqw (ORCPT ); Thu, 2 Jul 2020 10:46:52 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3CADC08C5DE for ; Thu, 2 Jul 2020 07:46:51 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so28805305wrv.9 for ; Thu, 02 Jul 2020 07:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N2ZbcYjJZjZ17aCzzB/muazXcgiT4k+gU+MxkZwfWa8=; b=Mq1Q5i/AEO457zmTrv+POuxnGzOAe+6/nY9A5cmZtvfowIplFqpV1Eke6o1PXZdyi6 VJNNLYPpwyhWZlYftQRTK49825KmLFsYZ5p8sohqPXDFA1DByoIbH7eMh2WdHrbZHk4a tUrM5lieL0qZWrljuF0MFtiyYIIgD0lEYfkh90NWOfpwpubQITmjvwsPJTyovuFg6ZLi geCvUfUGEhMmASDmyzzSvlUfJO//nZLj45kN6iVv6QAtcOo9cBt3Kp5viFUQj8cXEb+Z mw00++JZLQ1CQr9sHz5dLhc3zIELZJdfkdmgGOGRamyf0zqOn5oU+GPnyIQfEx9uddeM JIPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N2ZbcYjJZjZ17aCzzB/muazXcgiT4k+gU+MxkZwfWa8=; b=GuqwP1jSMHjImrFjojvZyxSAlnZpkeOrCbRk+16NGCrPyNAXxPaFLwVlvoFwo8FiAb 78FYVOTKw83zs91t7S9mj2sbDuNzrarSjcXSDtz8HVMjZjEZL6ziEmKwzVXD0cqojGrh yjsgiLo5KTeiJtoLjwQqL25yhdOEgHuu09XTKfbUZyT9otivOQ0o+v7Ht2HoRPeOgred zUq77sVu6DDSaSl8Y3+vQeUFMTGVVb9xetu63eB5xItBgHXJrq4Jah38u4qby1zjN38B QnujcwNERo8g8LG5oLCLgKIngIarvf8FGXYtY4oQq+QRHw4IeHu7RrM8cPGJ+NngV8cX SJMQ== X-Gm-Message-State: AOAM530MKLkl3PVvkEO0YvJEi+XjzPq8ROdBaGXQQZFU0GlmA8MbNOrU Piwgj26rNE/8ctxTA9Zfv/eT9Q== X-Google-Smtp-Source: ABdhPJzL8QUTzwy3oMlhA58n2PXE6vG/UgMbPHNq/o/+zK/18O97nXXvR9OcedR0UNxfobMNkjoqDw== X-Received: by 2002:adf:f445:: with SMTP id f5mr32588597wrp.339.1593701210450; Thu, 02 Jul 2020 07:46:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:49 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Thinh Nguyen , John Youn Subject: [PATCH 15/30] usb: dwc3: dwc3-haps: Function headers are not suitable for kerneldoc Date: Thu, 2 Jul 2020 15:46:10 +0100 Message-Id: <20200702144625.2533530-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warnings: drivers/usb/dwc3/dwc3-haps.c:19: warning: Incorrect use of kernel-doc format: * struct dwc3_haps - Driver private structure drivers/usb/dwc3/dwc3-haps.c:23: warning: cannot understand function prototype: 'struct dwc3_haps ' Cc: Felipe Balbi Cc: Thinh Nguyen Cc: John Youn Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-haps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c index 3cecbf1694526..55b4a901168e8 100644 --- a/drivers/usb/dwc3/dwc3-haps.c +++ b/drivers/usb/dwc3/dwc3-haps.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * dwc3-haps.c - Synopsys HAPS PCI Specific glue layer * * Copyright (C) 2018 Synopsys, Inc. From patchwork Thu Jul 2 14:46:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639097 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6A346C1 for ; Thu, 2 Jul 2020 14:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B4AD20899 for ; Thu, 2 Jul 2020 14:46:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dq/N0zwq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730022AbgGBOqz (ORCPT ); Thu, 2 Jul 2020 10:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730013AbgGBOqx (ORCPT ); Thu, 2 Jul 2020 10:46:53 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E45AC08C5C1 for ; Thu, 2 Jul 2020 07:46:53 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so28805488wrv.9 for ; Thu, 02 Jul 2020 07:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dQs4Q7oGTt/0sNcw0ENBRB2w5tCtiZwCiQW85p5XR3U=; b=Dq/N0zwqmdZ1Pky1vybgdJTfU1rvLmD2pQ9c00vr1KrgVzDXKqSrslDmwfYFr/6KCK ehJ/rv2Lr/z18jHuh8s+yqWsmnxzC6ux4zNbBCd6V9T0xBnvLugJ8tNemxxFlkFG/ZDt gwns4rWqq4K2acfTHJlEXcXKdnnasOk6YrTxhliNI+Zmss3EBmCsTymInZ8JBEy99dy3 OUeLJUBDz6Ah0vntaRPup5QDqARM7ZgsXL3KoVIqbpYMZtOdoURkAyVlIP2tS7Grl7Lx YSp64q8Cy5E+a/vdeUBjmCiAy25XXDU+QUVIPcSdPgfjqjBdqE4tTxX3nybtVufRKnsb eBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dQs4Q7oGTt/0sNcw0ENBRB2w5tCtiZwCiQW85p5XR3U=; b=oh1pub/E66mnlLVMur62e3d9MMzBCsOHPggyXNz+PP47ttZgxMiiA+q81+xxEhdGfn BM6lo0QKcfEgS5F+FtQpfBEuChW3gi+IdRgJ2c3UTlYgISuTCNFeYqtOP88tWO8zop/N 6UnVG8VvB4jxLBEnIOFqxUBbk2vMxnoY3nbvTPbfl8YCAZhb1P1pu8JuONLlykHp5Wyp iMpz+RzOCWNsr0HernJ/Ob6gixWRXvJIQWMwHEQlJ2wvtotuUVgHfCRS1TwjeOqvtION hDG9zWdSs7nssDlaSkrJOdbmrNhk9No9PjPNkEFQxpdlMG3cSxdzCf0+n+Qxkcalznf+ bWvw== X-Gm-Message-State: AOAM530Bvn8t+EgfToD+j4SldM9S6Q14WGOM4wA0yQtgImew31qATT2/ MBMzs9u8mO7PkxNdAkwreinKt2fUMfg= X-Google-Smtp-Source: ABdhPJyvjgDLGI4NJ9Sbqgluo1gBEWKCmbDfXNg8SW/WfotLzOFpxXr/k7akiCP8oG+foxClcw6o+Q== X-Received: by 2002:a5d:42c8:: with SMTP id t8mr30432630wrr.23.1593701211993; Thu, 02 Jul 2020 07:46:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:51 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Chunfeng Yun , linux-mediatek@lists.infradead.org Subject: [PATCH 16/30] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc Date: Thu, 2 Jul 2020 15:46:11 +0100 Message-Id: <20200702144625.2533530-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warnings: drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes] 13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...) | ^~~~~~~~~~~~~~ Cc: Chunfeng Yun Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/usb/mtu3/mtu3_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c index 4f5e7857ec312..155eae126e5e2 100644 --- a/drivers/usb/mtu3/mtu3_trace.c +++ b/drivers/usb/mtu3/mtu3_trace.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * mtu3_trace.c - trace support * * Copyright (C) 2019 MediaTek Inc. From patchwork Thu Jul 2 14:46:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639131 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA01F92A for ; Thu, 2 Jul 2020 14:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7C392089D for ; Thu, 2 Jul 2020 14:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cIkTP97L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730261AbgGBOsd (ORCPT ); Thu, 2 Jul 2020 10:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730021AbgGBOqy (ORCPT ); Thu, 2 Jul 2020 10:46:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D31C08C5C1 for ; Thu, 2 Jul 2020 07:46:54 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f139so28292247wmf.5 for ; Thu, 02 Jul 2020 07:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LuydmHRHncRiKpEKLiFPz7smS3ISdpVCQYiyoW4VCQc=; b=cIkTP97Ltc4F26LRPd0k0vH8rCSPhi/svFlkgm7iKd4rUBiebH/6UsCDSQMTEs+DqV DP49K7VEoXDEQN+3y9DARzbaESZ5W1uuHqmbciLtfPHolTD+ucYN8BVDgQfyKWGbO6HD 756KA9mM2iutxpw1ZJI7PuolhFV1232juQjtiTlEXKWJP33njo4EmHVOVLegPykn9Pat y/0yk4CPL7Cso65VaaRKexs5m2cpIXhiY2futiEY2jISvBCohLLdgn/Euz4eV2lRNfKB qHTdgXFbJnl4A+V4gHCMnLhhvAb2xZkinyaYH5F3rAEh7Tim5eHnqwp8tci0JCnaHOvh saCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LuydmHRHncRiKpEKLiFPz7smS3ISdpVCQYiyoW4VCQc=; b=mUGh4wOQ0EkDRbE4kRXrkrDUSeI9aGsasAGkIA4JrTxm+HF4qb62TKLvtMHbfjnD0C xHAwoIY8CqeUr+pvRB76B6GnRVDzeKpZ6XmNgBLqQXy1MtQs187PbZKTtg98oIKp8FFr YrWDSA/GZHlvSXypfNOay9QBnSzhKiCOONMXZrUiSZNA28h21mWMhwOxyeNoxmj0KKaN bR5jKDDaFwQPuMc0Q0X7icqbxgW4bfGpOV6AZA6mAU/Og9TD7SGoihFMQOFdwLHtJke4 WD/wO3bGW1Mv3gMkfKKReYOzRM/YOdBq8UqeOCLmkRAiv4Q+RYGA9aZAa3z5pt8eiGtN KLaA== X-Gm-Message-State: AOAM533+NfDMt98QoPQVwDsk1FC0UQMBlF/5IyKdB42UrexnJ2dHyXS9 cPJGxLCpVM7grlW7e8VNIqi8Vg== X-Google-Smtp-Source: ABdhPJwt4BB5QN+0+VYuAyZoPm9sDJXGV16TynQZBiUxLCJhmyDebIEU0rFkq/UKkGjxIQm03YHAJA== X-Received: by 2002:a1c:7402:: with SMTP id p2mr20867799wmc.117.1593701213215; Thu, 02 Jul 2020 07:46:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:52 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Pawel Laszczak , Pawel Jez , Peter Chen Subject: [PATCH 17/30] usb: cdns3: gadget: Fix a bunch of kernel doc issues Date: Thu, 2 Jul 2020 15:46:12 +0100 Message-Id: <20200702144625.2533530-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Mainline misspelled function argument descriptions. Also one formatting issue with a missing '@' identifier. Fixes the following W=1 build warnings: drivers/usb/cdns3/gadget.c:653: warning: Function parameter or member 'priv_ep' not described in 'cdns3_wa2_descmissing_packet' drivers/usb/cdns3/gadget.c:653: warning: Excess function parameter 'priv_dev' description in 'cdns3_wa2_descmissing_packet' drivers/usb/cdns3/gadget.c:1088: warning: Function parameter or member 'request' not described in 'cdns3_ep_run_transfer' drivers/usb/cdns3/gadget.c:2574: warning: Function parameter or member 'priv_ep' not described in '__cdns3_gadget_ep_set_halt' drivers/usb/cdns3/gadget.c:2574: warning: Excess function parameter 'ep' description in '__cdns3_gadget_ep_set_halt' drivers/usb/cdns3/gadget.c:2595: warning: Function parameter or member 'priv_ep' not described in '__cdns3_gadget_ep_clear_halt' drivers/usb/cdns3/gadget.c:2595: warning: Excess function parameter 'ep' description in '__cdns3_gadget_ep_clear_halt' drivers/usb/cdns3/gadget.c:2898: warning: Function parameter or member 'priv_dev' not described in 'cdns3_init_eps' drivers/usb/cdns3/gadget.c:2898: warning: Excess function parameter 'cdns3' description in 'cdns3_init_eps' drivers/usb/cdns3/gadget.c:3210: warning: Function parameter or member 'cdns' not described in 'cdns3_gadget_init' Cc: Pawel Laszczak Cc: Pawel Jez Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/cdns3/gadget.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 5e24c2e57c0d8..bfb1cbd492892 100644 --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -644,7 +644,7 @@ static void cdns3_wa2_remove_old_request(struct cdns3_endpoint *priv_ep) /** * cdns3_wa2_descmissing_packet - handles descriptor missing event. - * @priv_dev: extended gadget object + * @priv_ep: extended gadget object * * This function is used only for WA2. For more information see Work around 2 * description. @@ -1080,6 +1080,7 @@ static int cdns3_ep_run_stream_transfer(struct cdns3_endpoint *priv_ep, /** * cdns3_ep_run_transfer - start transfer on no-default endpoint hardware * @priv_ep: endpoint object + * @request: request object * * Returns zero on success or negative value on failure */ @@ -2568,7 +2569,7 @@ int cdns3_gadget_ep_dequeue(struct usb_ep *ep, /** * __cdns3_gadget_ep_set_halt Sets stall on selected endpoint * Should be called after acquiring spin_lock and selecting ep - * @ep: endpoint object to set stall on. + * @priv_ep: endpoint object to set stall on. */ void __cdns3_gadget_ep_set_halt(struct cdns3_endpoint *priv_ep) { @@ -2589,7 +2590,7 @@ void __cdns3_gadget_ep_set_halt(struct cdns3_endpoint *priv_ep) /** * __cdns3_gadget_ep_clear_halt Clears stall on selected endpoint * Should be called after acquiring spin_lock and selecting ep - * @ep: endpoint object to clear stall on + * @priv_ep: endpoint object to clear stall on */ int __cdns3_gadget_ep_clear_halt(struct cdns3_endpoint *priv_ep) { @@ -2890,7 +2891,7 @@ static void cdns3_free_all_eps(struct cdns3_device *priv_dev) /** * cdns3_init_eps Initializes software endpoints of gadget - * @cdns3: extended gadget object + * @priv_dev: extended gadget object * * Returns 0 on success, error code elsewhere */ @@ -3202,7 +3203,7 @@ static int cdns3_gadget_resume(struct cdns3 *cdns, bool hibernated) /** * cdns3_gadget_init - initialize device structure * - * cdns: cdns3 instance + * @cdns: cdns3 instance * * This function initializes the gadget. */ From patchwork Thu Jul 2 14:46:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639127 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1E046C1 for ; Thu, 2 Jul 2020 14:48:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B88AB20899 for ; Thu, 2 Jul 2020 14:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jf+GDNuw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbgGBOsa (ORCPT ); Thu, 2 Jul 2020 10:48:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730026AbgGBOqz (ORCPT ); Thu, 2 Jul 2020 10:46:55 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CFCCC08C5C1 for ; Thu, 2 Jul 2020 07:46:55 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id j18so27094515wmi.3 for ; Thu, 02 Jul 2020 07:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q4kYzyJe5IJIPm+2pVeTWhp4LWY4nTSN2jwPRXyKK/c=; b=jf+GDNuw24S8MDfhaAVNwZXkrg1WDtofP+3iJe5sA0+vgI0gkrFHVhSYk/6HllOiVO Ogiu/OEUPY4wl21b+73cOVa9pgC+B1jruUS0HZbLT0d695vLi59oMMCrP9ZC8yy4KPD8 J+mi1tiET8cgM8mB12akEX7WtmQZL2JgfPidAkvTPgFsvOE4+DGK94VcU01avDwQAKSD NjGjUX60Oc0iXDGfu6dWs+W3xS7gnMDe0r7uErqsQZ7wkNRBP+HjjdcSgkiqR6HZSPBR 3CqWyn34qo2Ds5IquhTp1av8xwAhVkJH0PCQMV4+vSshOPHnlIZPZxYbIvU7/L9KEXGB Dh7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q4kYzyJe5IJIPm+2pVeTWhp4LWY4nTSN2jwPRXyKK/c=; b=msMI7x5Y5+AiyVm4uW/P64MCWUGVrZr+emcAG1wMYlbYDLeTy7jctOOBbLeKRY/7F4 iZCNgI33cG1AQVaM377Eo67P41b+6Rbe3FlhAkc3EmdzdFATIdOVNxcqeoLyCRf6wnUd E/su+tBkNzcrWoYa2KBBMUS/Kmqc54IJyOQxC5JoYN9ia3B07LvsgnTQDfIBoE7Iz3mJ zvDsm3KtZWbN9FP28aQP/v5lemdJyjoBYwESwv8LXSOgnWktYAtUVGea+7uXrpMfRaft f5JOc7ML8vMIDnjsHcAXRiEp4a9LnKWCJgNXfUbCAJ3dLfvAOshMlOC0osKw4etZh1Q4 whLg== X-Gm-Message-State: AOAM530RRa4vCysatd44Gzj6MfR6Td3mLyj17ROp9/p9Sr78JctNyWok SeOZXvUniwotFWP39ImMxgXV4w== X-Google-Smtp-Source: ABdhPJzKWcwz3CXZ7XAFguZ3yiChvSKr4c3GX8lltWc46Aa1c+pUtV0QNX3B9BnRdrqRx/NiRlbyMw== X-Received: by 2002:a1c:2ec7:: with SMTP id u190mr31447520wmu.48.1593701214352; Thu, 02 Jul 2020 07:46:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:53 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , iivanov@mm-sol.com, Sundeep Bhatta Subject: [PATCH 18/30] usb: dwc3: dwc3-of-simple: Function headers are not good candidates for kerneldoc Date: Thu, 2 Jul 2020 15:46:13 +0100 Message-Id: <20200702144625.2533530-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following kernel build warning(s): drivers/usb/dwc3/dwc3-of-simple.c:25: warning: cannot understand function prototype: 'struct dwc3_of_simple ' Cc: Felipe Balbi Cc: iivanov@mm-sol.com Cc: Sundeep Bhatta Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-of-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 8852fbfdead4e..34c828c221977 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * dwc3-of-simple.c - OF glue layer for simple integrations * * Copyright (c) 2015 Texas Instruments Incorporated - http://www.ti.com From patchwork Thu Jul 2 14:46:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639099 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B5A8739 for ; Thu, 2 Jul 2020 14:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BDFC208B8 for ; Thu, 2 Jul 2020 14:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EmGnkDPA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730042AbgGBOq6 (ORCPT ); Thu, 2 Jul 2020 10:46:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730034AbgGBOq5 (ORCPT ); Thu, 2 Jul 2020 10:46:57 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB03AC08C5DD for ; Thu, 2 Jul 2020 07:46:56 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so27099819wmh.4 for ; Thu, 02 Jul 2020 07:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kZQeJUz+ErJ6yE5aR4TJ6dhksayixlSTB2k3nGSWLOM=; b=EmGnkDPALpzLOYQpEWxWIHKjJi1QPdROlga7PolW9eoc2fctcHjv9A3rBSoQzpnGVp 8PfqKc2hmGPJ7C4BmFS0/+f1wti/7JErmkD2W8yyRMjypPlwK6A36wVpTDLwyDQg87sw c0uu9+dF+Ug0g9aw3Q4mYqsHAtgNH8/XLOM5hiwW0CRDrWgad5eFiCp87XpG+pFKWWqx LuX983vQCmCEepm8sMhjowkgnJS7kOwY1pekRce9IZQL8MQQ4dn+hkHQkftKnTTGaDR5 900F+B1dg7IZ5BbGwkWizO0a35THYtH7qGGs4CJRdyIVW0UbbSb2o9jXD5Xq0qGGeOk+ KnRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kZQeJUz+ErJ6yE5aR4TJ6dhksayixlSTB2k3nGSWLOM=; b=Y8NPUTtmsM0XWTLnjdxQO2B9u9p0GeCT++7X/mTUcInACR9ZBgmXg99+Sc5eHN0zbF A2NUUG+5AymoaiR2GQmVLSOCrJ4LTyKy/tyi2zgWpn+j4OuU5Wapqjd7QWZagJms/RjD LXbD8p+YAu6IFCV/+TK8Jl0Ez7bTpIir/TN0IyEQSwLwhAsVs/OQA+sXxCPKHppWLcyr 94F/GFUvTEdX3m++yNf1b/5ZZwg3D8wMfd5acAiAMKQ0fS6V2JfEkr8yKvtD/yLOdO5S jVqX26ow9XtwL0R8Cg/97W6aXI+91EXXRfDLIdB/qMA2juttq4xo+IYisTGo+cYXP8tC VUng== X-Gm-Message-State: AOAM530ktZ4pc9PHLoGTyVZ5cwV4P9hiwnO6CuvciumYolnM0n6o4Ujv Ujk6Tzt3hQwkIr+iQUILdI15Sw== X-Google-Smtp-Source: ABdhPJyxMg7EbHaZ/31OlfupBkIBsGFOwrld5FUmxjo0/JeKjE8jPmiIcgJijoZ9w17/iOlzpi1ktw== X-Received: by 2002:a1c:b4c2:: with SMTP id d185mr30552951wmf.57.1593701215544; Thu, 02 Jul 2020 07:46:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:55 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , "by L. Wassmann" Subject: [PATCH 19/30] usb: host: isp1362: Mark the many unused ISP1362_REG entries as __maybe_unused Date: Thu, 2 Jul 2020 15:46:14 +0100 Message-Id: <20200702144625.2533530-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org It would seem a shame to strip out all of the unused register entries, since they can act as a fair source of documentation. Instead, mark them all as __maybe_unused to show the build system that this behaviour is known and intentional. Fixes the following kernel build warning(s): In file included from drivers/usb/host/isp1362-hcd.c:96: drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGALTTMR’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:199:1: note: in expansion of macro ‘ISP1362_REG’ 199 | ISP1362_REG(OTGALTTMR, 0x6C, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGTIMER’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:198:1: note: in expansion of macro ‘ISP1362_REG’ 198 | ISP1362_REG(OTGTIMER, 0x6A, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGINTENB’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:197:1: note: in expansion of macro ‘ISP1362_REG’ 197 | ISP1362_REG(OTGINTENB, 0x69, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGINT’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:196:1: note: in expansion of macro ‘ISP1362_REG’ 196 | ISP1362_REG(OTGINT, 0x68, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGSTATUS’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:195:1: note: in expansion of macro ‘ISP1362_REG’ 195 | ISP1362_REG(OTGSTATUS, 0x67, REG_WIDTH_16, REG_ACCESS_R); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_OTGCONTROL’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:194:1: note: in expansion of macro ‘ISP1362_REG’ 194 | ISP1362_REG(OTGCONTROL, 0x62, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_HCATLPORT’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:183:1: note: in expansion of macro ‘ISP1362_REG’ 183 | ISP1362_REG(HCATLPORT, 0x44, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_HCINTLPORT’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:175:1: note: in expansion of macro ‘ISP1362_REG’ 175 | ISP1362_REG(HCINTLPORT, 0x43, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_HCISTL1PORT’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:171:1: note: in expansion of macro ‘ISP1362_REG’ 171 | ISP1362_REG(HCISTL1PORT, 0x42, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_HCISTL0PORT’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:170:1: note: in expansion of macro ‘ISP1362_REG’ 170 | ISP1362_REG(HCISTL0PORT, 0x40, REG_WIDTH_16, REG_ACCESS_RW); | ^~~~~~~~~~~ drivers/usb/host/isp1362.h:59:22: warning: ‘ISP1362_REG_HCINTDIS’ defined but not used [-Wunused-const-variable=] 59 | static isp1362_reg_t ISP1362_REG_##name = addr | ^~~~~~~~~~~~ drivers/usb/host/isp1362.h:77:1: note: in expansion of macro ‘ISP1362_REG’ 77 | ISP1362_REG(HCINTDIS, 0x05, REG_WIDTH_32, REG_ACCESS_RW); | ^~~~~~~~~~~ Cc: "by L. Wassmann" Signed-off-by: Lee Jones --- drivers/usb/host/isp1362.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp1362.h b/drivers/usb/host/isp1362.h index 4c49688a069d1..9bbfcc3fdd3cc 100644 --- a/drivers/usb/host/isp1362.h +++ b/drivers/usb/host/isp1362.h @@ -56,7 +56,7 @@ typedef const unsigned char isp1362_reg_t; #define ISP1362_REG_NO(r) (r) #define ISP1362_REG(name, addr, width, rw) \ -static isp1362_reg_t ISP1362_REG_##name = addr +static isp1362_reg_t __maybe_unused ISP1362_REG_##name = addr #define REG_ACCESS_TEST(r) do {} while (0) #define REG_WIDTH_TEST(r, w) do {} while (0) From patchwork Thu Jul 2 14:46:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639121 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F0F4E739 for ; Thu, 2 Jul 2020 14:48:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D223D208C7 for ; Thu, 2 Jul 2020 14:48:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DoVlnDUG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730046AbgGBOq7 (ORCPT ); Thu, 2 Jul 2020 10:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730038AbgGBOq6 (ORCPT ); Thu, 2 Jul 2020 10:46:58 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5178C08C5C1 for ; Thu, 2 Jul 2020 07:46:57 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l17so27119287wmj.0 for ; Thu, 02 Jul 2020 07:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=28X3U4dJc3uramg6kDHLLVs+7HIKsy1aJX4qqakHpps=; b=DoVlnDUG55Z4Fzv9+d1V8Ieq224Bfdh8KlYCNDYO1eP2cAbL9Nih/BvbtIkArPTCgY 9VJgpbG9xQ71lm4ghblIel7Ajs+qU1OqUnTyaCshoagZiUE2MzvozTLZotuvn5FmGeP+ YOdVX4MTT9x5O+qveBt4kpo/oJKwWt+EU5xKr0VvewkyHWF9badOtmf1EYeDEQ4jvDpf nXl4J32zR7BlkJVzhTaX8z1hR7v+7RgJuKlrcj9CO/hdrTRAw0GKFQCyJ0gIVKfjAL0A RI8wMjBewSNCZsWaWT3urJ4JA12qcvR3+GSQ+TyQyAid8K8Az19vtresRc7nwlXYT8ZC 1QKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=28X3U4dJc3uramg6kDHLLVs+7HIKsy1aJX4qqakHpps=; b=OKRpdwzJd5OuBi6vu0xZJF4nkGb2STDSbqp/TQDWjEUZ1d8Zs/b52Nh635NhtSDb9v YzFyA0FczIZftJI7Prpxp7nYe0QJgQbPwLu3+cnyYtkWXkGFF6XCiPzkMnIICS9Z/GI4 cglJc3T8MdfjXYNxh/EgscdFoh8IdNIHZnBFcUboYDxPHRbIYGo7uAzxQIBJTQBcAjSc e3ccvg6JKeU6fmjzGBCIprc+xQfOPS6vomtup4jrEvQrgsdSpDYczFjvfAqhVS65IMMp woRTwOv0A8616/OFDUyXHiK2nyRBrQiPCfdarE/OKIz474jE0C8j+3cDZyaczAjnUjYF gDhw== X-Gm-Message-State: AOAM530+5vYnxoAf2y/+guzfjFp/N6pIs9g09OvUayMGd6QTaTg+gn4/ sS6JXkkAzw7mZgKAQp9TylBvIA== X-Google-Smtp-Source: ABdhPJyhJBjWN4in2TNPlqyGbZpG7D4RdUGXcarVJruUemj20CkpM1cwqnzu9QOonoxh49cCQh2bmA== X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr34760561wmj.117.1593701216646; Thu, 02 Jul 2020 07:46:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:56 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Thibaut VARENE Subject: [PATCH 20/30] usb: host: ohci-at91: Demote kerneldoc headers down to basic comment blocks Date: Thu, 2 Jul 2020 15:46:15 +0100 Message-Id: <20200702144625.2533530-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Neither usb_hcd_at91_probe() nor usb_hcd_at91_remove()'s function headers reach the standards required of a kerneldoc entry. Only one attempt at describing an argument was made, as it is not correct (we're removing that too to save confusion). Fixes the following kernel build warning(s): drivers/usb/host/ohci-at91.c:166: warning: Function parameter or member 'driver' not described in 'usb_hcd_at91_probe' drivers/usb/host/ohci-at91.c:166: warning: Function parameter or member 'pdev' not described in 'usb_hcd_at91_probe' drivers/usb/host/ohci-at91.c:259: warning: Function parameter or member 'hcd' not described in 'usb_hcd_at91_remove' drivers/usb/host/ohci-at91.c:259: warning: Function parameter or member 'pdev' not described in 'usb_hcd_at91_remove' drivers/usb/host/ohci-at91.c:259: warning: Excess function parameter 'dev' description in 'usb_hcd_at91_remove' Cc: Alan Stern Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Thibaut VARENE Signed-off-by: Lee Jones --- drivers/usb/host/ohci-at91.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index b635c6a1b1a91..0487a4b0501ec 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -153,7 +153,7 @@ static struct regmap *at91_dt_syscon_sfr(void) /* always called with process context; sleeping is OK */ -/** +/* * usb_hcd_at91_probe - initialize AT91-based HCDs * Context: !in_interrupt() * @@ -244,9 +244,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, /* may be called with controller, bus, and devices active */ -/** +/* * usb_hcd_at91_remove - shutdown processing for AT91-based HCDs - * @dev: USB Host Controller being removed * Context: !in_interrupt() * * Reverses the effect of usb_hcd_at91_probe(), first invoking From patchwork Thu Jul 2 14:46:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639101 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4ADC7739 for ; Thu, 2 Jul 2020 14:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3306E208C7 for ; Thu, 2 Jul 2020 14:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GiK2yuMf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730055AbgGBOrA (ORCPT ); Thu, 2 Jul 2020 10:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730038AbgGBOq7 (ORCPT ); Thu, 2 Jul 2020 10:46:59 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258CCC08C5C1 for ; Thu, 2 Jul 2020 07:46:59 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id q15so27103988wmj.2 for ; Thu, 02 Jul 2020 07:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tk9qHYg/pg0juZNf3DyUaHaFVykgS42nSPkB38BS4VI=; b=GiK2yuMf9VW7Z19uG5zEvbRFhcxtXMkMeY4rPH9Zx9s8uYWAYCMypKVT6Y+yt/6rpf WAMPgaN9U6Wb1hOUUyF6qS2KpVrIESS0jlVC/cZiI8MECown7OC4GobHQPZTQbGyz8ZB 7fvGBsjm6+LwOPTbQneEItoMZe1tX4XEGxdu0PNP4t+fYFBmNOEZ3xFE1sZrfX6U57so CsjeTWoXQxLX8Q7saQaBB7p8LTSLNTov4O5gqDMpRaYJstZKlvKa/a3L7R7Xz1KrFIR7 8h0MKN445JU+sOn0Cy2a2snY9PgjV8i9RE4MkV55pirdqCbmMjSFkawux/M2RHJ4vmHm diuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tk9qHYg/pg0juZNf3DyUaHaFVykgS42nSPkB38BS4VI=; b=mRzrg24N49nhnbB4uge31SohfrkwI00FtstneMNYfJ/AoTbaix+Z4cDmvmlNFWFnSA 0/WDXh30tS7KkbNUU7KVKiGEKpfxIaUTdblF3Yp0asy0w59x1ahRxARPFt/6m95wUxwL yVweD3R9G4FGim5w/WRP9HI58QvT/0pv9M3Cx7i4/3//nJNyJxfhy4DNu74LcnWIBMtq k4RYX6EA3WrSDYaxidGd9V2tX29mFWrzdBnSZorjWcqE4itkyUQyYpASHuhtgQ1f3TSo oBlay57JAHnBD2w6il8SOL5VDdeuzTgJnuq7DrHIswLLDL65xCc1hpLG5rGe4DJgZxVT XsvQ== X-Gm-Message-State: AOAM531ay7YlV552CRwYaQoYPzUpvTPMhn6v/YYLIuGqJRaqqDArT3u8 6QHVAvdDzw8wlRE0ozMW0MZo8Q== X-Google-Smtp-Source: ABdhPJwr5kCUGPxhCkk8QXKgz4YnAOyGhc74VvsL45wpZKCwBUEyj4mXBP6XM5Epl9ziHR3pE3GVuw== X-Received: by 2002:a05:600c:2187:: with SMTP id e7mr31551586wme.171.1593701217878; Thu, 02 Jul 2020 07:46:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:57 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Roman Weissgaerber , David Brownell Subject: [PATCH 21/30] usb: host: ohci: Mark cc_to_error as __maybe_unused Date: Thu, 2 Jul 2020 15:46:16 +0100 Message-Id: <20200702144625.2533530-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org drivers/usb/host/ohci.h in included by a whole much of different sourcefiles. Not all of them make use of cc_to_error. So mark it as __maybe_used to convey that this behaviour is not only acceptable it's expected. Fixes the following kernel build warning(s): In file included from drivers/usb/host/ohci-pci.c:25: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-platform.c:32: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-exynos.c:20: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-spear.c:22: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-st.c:26: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-at91.c:31: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ In file included from drivers/usb/host/ohci-s3c2410.c:32: drivers/usb/host/ohci.h:165:18: warning: ‘cc_to_error’ defined but not used [-Wunused-const-variable=] 165 | static const int cc_to_error 1 = { | ^~~~~~~~~~~ Cc: Alan Stern Cc: Roman Weissgaerber Cc: David Brownell Signed-off-by: Lee Jones --- drivers/usb/host/ohci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h index b85a39588f9d9..aac6285b37f80 100644 --- a/drivers/usb/host/ohci.h +++ b/drivers/usb/host/ohci.h @@ -162,7 +162,7 @@ struct td { /* map OHCI TD status codes (CC) to errno values */ -static const int cc_to_error [16] = { +static const int __maybe_unused cc_to_error [16] = { /* No Error */ 0, /* CRC Error */ -EILSEQ, /* Bit Stuff */ -EPROTO, From patchwork Thu Jul 2 14:46:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639119 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB95F6C1 for ; Thu, 2 Jul 2020 14:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C31F220899 for ; Thu, 2 Jul 2020 14:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c53RgvRD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730070AbgGBOrB (ORCPT ); Thu, 2 Jul 2020 10:47:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730058AbgGBOrA (ORCPT ); Thu, 2 Jul 2020 10:47:00 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E68BC08C5DD for ; Thu, 2 Jul 2020 07:47:00 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 22so27110439wmg.1 for ; Thu, 02 Jul 2020 07:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H2cePmcpx5tsP4U3KYd+LqwzZEatzdvDVRzwm5J/30A=; b=c53RgvRD10yT154GgQgeIyna2QYPrbkI+WTnp2UMoFo9CT36rTCyqrDngBqvuckw3S +oNa3YdgsimKjvPoCH/30TsKQMdDJPLwl5KHWSs/fy5BFSSaYO5/F8t+s9fUmd1kfbTt joQnwQce5qZ1EBcSIkEdbgflYXu4hOxUS6yHZw1bkvsDOdZNN1Lvp9vhf7mjC2cttpwR UMLjHgsZgsLUt6CM3mwFLJczW2/G2TFbYlK31eHuAJ0WUZDimWF74sk72FwUIAoR9soG 5nDZgi3NL2ZhkzfWwoPAK4IyiU44YXnPmkhwRZ/mQsAqgQkNxutA+aNeEwTG27koO4xd N+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H2cePmcpx5tsP4U3KYd+LqwzZEatzdvDVRzwm5J/30A=; b=rJp43+v2vEb5txrCqIRbC8bhj8KqgqF5+UlmTS/V4IAjpa4GWDryoTeHJlChu1AxVG nrZXInsSQhTcnyWQc3vGFIZuSilZzx/y+VXk9V9lM4f1mK55nYgCFR/iAi+sstvYpKlo aB2Ge/d8GbakPAmS6pYz0z8BAnjLpdwbimc6LKLi/Y73gzjx3Zot08TCye83IQmZoVkU VDsXRVEqhnKLlp68jSvwaTBkHKbgVwbP/AmQk7D5NJy44CRP71UKyBFlV2/zlklwgfUG JhUqfMUdTWHaJfdI4wK6hYDRcHLShf8SgV4WB/ufIqYQSv3skhOn3PqHCn6pVz1PN4tp Y1lQ== X-Gm-Message-State: AOAM531SPRE72BrKwEGu6pxPj3OPbbIKg+2EXZ1n0vBesw39FeGIKL8E 9SM8lmYiGo865+2l5m19CfVuoQ== X-Google-Smtp-Source: ABdhPJw0wDnk30+GzymRe6m8MX4bgQkP+1HG/vAC/QIiYL0ssvI94FAnR4CJhMTZpP/sPRSbJk6tYA== X-Received: by 2002:a7b:c775:: with SMTP id x21mr17240384wmk.34.1593701218885; Thu, 02 Jul 2020 07:46:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:58 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Pawel Laszczak , Pawel Jez , Peter Chen Subject: [PATCH 22/30] usb: cdns3: ep0: Move 'zlp' description to appropriate function header Date: Thu, 2 Jul 2020 15:46:17 +0100 Message-Id: <20200702144625.2533530-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org 'zlp' was documented, but in the wrong place. Fixes the following W=1 kernel build warning(s): drivers/usb/cdns3/ep0.c:36: warning: Function parameter or member 'zlp' not described in 'cdns3_ep0_run_transfer' drivers/usb/cdns3/ep0.c:705: warning: Excess function parameter 'zlp' description in 'cdns3_gadget_ep0_queue' Cc: Pawel Laszczak Cc: Pawel Jez Cc: Peter Chen Signed-off-by: Lee Jones --- drivers/usb/cdns3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 5b3f682338e50..5b1aec80b2d7f 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -29,6 +29,7 @@ static struct usb_endpoint_descriptor cdns3_gadget_ep0_desc = { * @length: data length * @erdy: set it to 1 when ERDY packet should be sent - * exit from flow control state + * @zlp: add zero length packet */ static void cdns3_ep0_run_transfer(struct cdns3_device *priv_dev, dma_addr_t dma_addr, @@ -695,7 +696,6 @@ static int cdns3_gadget_ep0_set_halt(struct usb_ep *ep, int value) * @ep: pointer to endpoint zero object * @request: pointer to request object * @gfp_flags: gfp flags - * @zlp: add zero length packet * * Returns 0 on success, error code elsewhere */ From patchwork Thu Jul 2 14:46:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639117 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82377739 for ; Thu, 2 Jul 2020 14:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68A13206E2 for ; Thu, 2 Jul 2020 14:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MRCLlu77" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730181AbgGBOrq (ORCPT ); Thu, 2 Jul 2020 10:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730064AbgGBOrB (ORCPT ); Thu, 2 Jul 2020 10:47:01 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53FE4C08C5DD for ; Thu, 2 Jul 2020 07:47:01 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g75so27085778wme.5 for ; Thu, 02 Jul 2020 07:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pP5tNguPzonDyxhQNucE0D3MbWP90cYYUbxgRDFDsUc=; b=MRCLlu77vm2lwEuKfpgTjOHIiNbOSRTeYtgs5c+tcVQF2EOP3Y+PnwvY8yMjo/cJJ9 TpF2T6O2DEjSh+q/g7J04eisB3ct2rVdiBCpsqSLJeVCjttHOc7mvJkWgxLpgTX1G7ih 9zoqFAsZWRUg+4yjqPZtnjfXqRtNRxiUz9bgYGRiZMsU3zRp/oW2DAsNBN8kUjudGQt9 2V6vEeJAtKSdSkRaouvKT1GaOXxATqsbk9o2Agt560AZqfMKPCHBpvFsq9QjR3OwQ2b/ 2wOOxYVGGAVrNGw3vGhZgQmcSwGG/WaDTMsIgDN0ckGLgqnUhN6oSdWcJu49hXBTt01a 6Kqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pP5tNguPzonDyxhQNucE0D3MbWP90cYYUbxgRDFDsUc=; b=CvUK77mYC7wykGpQFtUFCi8suhb+XXJRs7UCrVnQ5K/xjLQPKuMbfxv3EVAozrX3HJ PYQCbQfMIcB2/zSUtT1BGm91GVuDNXl43Sq6eorU3Ajuey/JvzcMLgo7/IqYpdDG9bVr jR90DxCz1i0+mr5j4JBjpPz429Zx3dmV7ja2K9IBSjD8O5XdRNYDzOto9kSCaxioIkbD 5U9ZkaXYA/k7SHiB8GYbPy2eEL2QAXq2gzkZprJQM3AFRk4TV3rMJLGabcDS+egw0qGC mE1CzZqMvCviwR31iFuw4nZ9cULAv8ZAZu0vUiNEnUGpwsCF2ohwT6JOm8YKTPtL3PIV 33Bg== X-Gm-Message-State: AOAM533GA88AZUYKs5t9qvfVHqLQTx5ek51hXg2McQziSDbNW2m4XIRw GcuN94O3v4HtF6kRj2bCAqmzhQ== X-Google-Smtp-Source: ABdhPJyyBq6LXHLryVvWu+HFwT4JhZivbWn1QGWohZ3dXSZK0sYsC9OCCnVcIDtulXLnqPhVrsy2hQ== X-Received: by 2002:a1c:49d7:: with SMTP id w206mr30883650wma.181.1593701220039; Thu, 02 Jul 2020 07:47:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Masahiro Yamada , Rodolfo Giometti , "Eurotech S.p.A" Subject: [PATCH 23/30] usb: host: oxu210hp-hcd: Move declaration of 'qtd' into 'ifdef OXU_URB_TRACE' Date: Thu, 2 Jul 2020 15:46:18 +0100 Message-Id: <20200702144625.2533530-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If we assign 'epnum' during the declaration we can also avoid "ISO C90 forbids mixed declarations" issues. So it does looks like we can have our cake and eat it in this scenario. Fixes the following W=1 kernel build warning(s): drivers/usb/host/oxu210hp-hcd.c: In function ‘submit_async’: drivers/usb/host/oxu210hp-hcd.c:2040:19: warning: variable ‘qtd’ set but not used [-Wunused-but-set-variable] 2040 | struct ehci_qtd *qtd; | ^~~ Cc: Masahiro Yamada Cc: Rodolfo Giometti Cc: "Eurotech S.p.A" Signed-off-by: Lee Jones --- drivers/usb/host/oxu210hp-hcd.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c index 120666a0d5901..b00673295c9fe 100644 --- a/drivers/usb/host/oxu210hp-hcd.c +++ b/drivers/usb/host/oxu210hp-hcd.c @@ -2037,16 +2037,15 @@ static struct ehci_qh *qh_append_tds(struct oxu_hcd *oxu, static int submit_async(struct oxu_hcd *oxu, struct urb *urb, struct list_head *qtd_list, gfp_t mem_flags) { - struct ehci_qtd *qtd; - int epnum; + int epnum = urb->ep->desc.bEndpointAddress; unsigned long flags; struct ehci_qh *qh = NULL; int rc = 0; +#ifdef OXU_URB_TRACE + struct ehci_qtd *qtd; qtd = list_entry(qtd_list->next, struct ehci_qtd, qtd_list); - epnum = urb->ep->desc.bEndpointAddress; -#ifdef OXU_URB_TRACE oxu_dbg(oxu, "%s %s urb %p ep%d%s len %d, qtd %p [qh %p]\n", __func__, urb->dev->devpath, urb, epnum & 0x0f, (epnum & USB_DIR_IN) ? "in" : "out", From patchwork Thu Jul 2 14:46:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639113 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFDD492A for ; Thu, 2 Jul 2020 14:47:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC63B2067D for ; Thu, 2 Jul 2020 14:47:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wAQqKXwN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730082AbgGBOrE (ORCPT ); Thu, 2 Jul 2020 10:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730075AbgGBOrC (ORCPT ); Thu, 2 Jul 2020 10:47:02 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43518C08C5C1 for ; Thu, 2 Jul 2020 07:47:02 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so28288136wmh.2 for ; Thu, 02 Jul 2020 07:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cen7jwZ+l5/fZQV9+f4eKCsdCtb++xjGqhYwjDReG4s=; b=wAQqKXwNUvkayHtIMBV6LS0l4vt72aFTjRZSPiSvZJ5C/hqTBy3STN6t0PpK9LZ9Sl Lb2UEfzaiMVbpQgMEOWrkp/dkAtB7fHH/UdXXaH4Bf/pD65LBDmzIoAElaEn6uRbkhsr Sq6KZ9fmigZNrcfwKtfJpaz/LqAUX/icEFbG3MXXNaTW9OxviX1QsPqnDatS1kMepeKS ppuFUZVk6RIA9kGXBgwQV83qvsCFqp560ZzvnuFh2RPn028KWAA/WSY3RrZ3P7YNx2HP rVxY/LyhKyYUKA1wHnrnUWETqAHP/uHelYufgGMcwMsaC+Gn9/8D884fgDtbffl5wEIf Db4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cen7jwZ+l5/fZQV9+f4eKCsdCtb++xjGqhYwjDReG4s=; b=TKpRkFSl8iyiX9sBu2zqp1GcZR8M7JIKHMb8Qc56lIfSkPG5jCouS0VH3ZpOLp4mtS HH32XyTzaXZ8BBpg/aNtRApyEHGh7nqUrr9Q1jVpTc4G5aBISh9AriT+SqHAPGC88GZZ 2AjMXavUFod2vlWeJFWSevCDDMnGjttJLVg9oJIDO+/sVAeQv1+aKGOSJXTLuQDV5mA0 6TBzEN6LfD2NkPQ7zUK7dY8tz7ZRUyyOjhJfPrQg9dtOJHzpwVm6vBnEY9Bl9AAd7RDN 9+DUPbDoLYnLXXPqPxECN2kr0WftYnD31LSUMl5A7u5cECP3VLvuv9f71onPlkKkoRym rXTA== X-Gm-Message-State: AOAM5317qjD9qCPpkTDrIbVVGNZi7LraBrdSI3lmXIae8YDuiwhFcvJj UNi/QjSjJvvnKu8JZbvXYI5ASQ== X-Google-Smtp-Source: ABdhPJyKXHl2Fi+reKwJfYF/na/idnzE4RoZeL56RxRf05pfTe+1N4F2X4OdO6C8BsdOK8Y+xUFvgg== X-Received: by 2002:a1c:4b09:: with SMTP id y9mr18364006wma.46.1593701221058; Thu, 02 Jul 2020 07:47:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:00 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Chunfeng Yun , linux-mediatek@lists.infradead.org Subject: [PATCH 24/30] usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file Date: Thu, 2 Jul 2020 15:46:19 +0100 Message-Id: <20200702144625.2533530-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes] 13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...) | ^~~~~~~~~~~~~~ Cc: Chunfeng Yun Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones Reported-by: kernel test robot --- drivers/usb/mtu3/mtu3_trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c index 155eae126e5e2..d17ddb87cdcf2 100644 --- a/drivers/usb/mtu3/mtu3_trace.c +++ b/drivers/usb/mtu3/mtu3_trace.c @@ -8,6 +8,7 @@ */ #define CREATE_TRACE_POINTS +#include "mtu3_debug.h" #include "mtu3_trace.h" void mtu3_dbg_trace(struct device *dev, const char *fmt, ...) From patchwork Thu Jul 2 14:46:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639115 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 36B7A6C1 for ; Thu, 2 Jul 2020 14:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE71206E2 for ; Thu, 2 Jul 2020 14:47:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UH/FEPUu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730180AbgGBOro (ORCPT ); Thu, 2 Jul 2020 10:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730081AbgGBOrE (ORCPT ); Thu, 2 Jul 2020 10:47:04 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B754EC08C5C1 for ; Thu, 2 Jul 2020 07:47:03 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o2so28288295wmh.2 for ; Thu, 02 Jul 2020 07:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j3qxTGweigJBwA2Dcfmp6Oj8j3v23FLWhOhHeBcgW7I=; b=UH/FEPUuaJiocBixPJWaxF19GJofrsYjNd0ZwLFDYiM8v2DNvddLqbfFEcoEIAgua9 bP2+NQ5D2EnmEmmOkQbHI1JvyYJ/o4zFDERtjZF/Uu9t+zeH9dUNXTfGa/pdIk4yUPVT vvgPEaa1aFKNK273L+hRW9C1Ev04KveXHYXLiyNdzpToBUXws7X15l+6DSLce7p6jeiD K1WSC+eCuZhhTPH1+Xzr3/PN1YghnkO1pOilzPFlhWeP9jW6k+/D1ZIAemdOPEOqmxJa Sfo4YYjZUP2FR65boUwbWOUyS/gbbcgDSJusheHBjW1mniiBCNgNVkiP4pZ6pixHLMGz YoDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j3qxTGweigJBwA2Dcfmp6Oj8j3v23FLWhOhHeBcgW7I=; b=U1i4X4mmPEVDUh5Uqczx1o3KrKmozM7/ozPpRp/Kvz8IIb4yDoiKiNWeCNZ5HFA53x G45x2+xTWeitlQCnFlqolos9EymU0zzlx7qF7sONponp9lnOdxo7mCkTUXA9AUCNxnhs 6ki4Anoye9aSiHR+TQlnIHhQrVXB/8fqfYgM+716jaowPaWjMYsGzDwsd/0rr0f9Z44I zlBrYvx/FbeGd6RdOEsE14l3g3uQ01aIEK9D1V4wceHk4YNUd7Akg3o0SWfCLzPCPUSp dcmkeIoWDVlnIKfYNyRRngrPPR28bOjtn+1WTJNOMrZQW6QWLGvL5DyZ68WmOMz+qcwK +l8A== X-Gm-Message-State: AOAM530pAGtIadiCT6DaensDwfyCKFoEWyz2QHbx56ovpkU3MqN7Kdzk b2Qxt/aQHsBBKc308CYWvXU3LQ== X-Google-Smtp-Source: ABdhPJwSKu/tDOvAvRT809W5s5eyOxbUaM/7UBHj3f8+fnH4iRC5julZ8NEXw3uo/stZQZBYv3h22Q== X-Received: by 2002:a1c:7402:: with SMTP id p2mr20868613wmc.117.1593701222460; Thu, 02 Jul 2020 07:47:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:01 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Chunfeng Yun , linux-mediatek@lists.infradead.org Subject: [PATCH 25/30] usb: mtu3: mtu3_core: Demote obvious misuse of kerneldoc to standard comment block Date: Thu, 2 Jul 2020 15:46:20 +0100 Message-Id: <20200702144625.2533530-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the function. Fixes the following W=1 kernel build warning(s): drivers/usb/mtu3/mtu3_core.c:805: warning: Function parameter or member 'mtu' not described in 'mtu3_set_dma_mask' Cc: Chunfeng Yun Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/usb/mtu3/mtu3_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c index 9dd02160cca97..6d515eb67ea79 100644 --- a/drivers/usb/mtu3/mtu3_core.c +++ b/drivers/usb/mtu3/mtu3_core.c @@ -797,7 +797,7 @@ static void mtu3_hw_exit(struct mtu3 *mtu) mtu3_mem_free(mtu); } -/** +/* * we set 32-bit DMA mask by default, here check whether the controller * supports 36-bit DMA or not, if it does, set 36-bit DMA mask. */ From patchwork Thu Jul 2 14:46:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639103 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B83C6C1 for ; Thu, 2 Jul 2020 14:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 442F1208B6 for ; Thu, 2 Jul 2020 14:47:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zmksYIBa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbgGBOrH (ORCPT ); Thu, 2 Jul 2020 10:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730088AbgGBOrF (ORCPT ); Thu, 2 Jul 2020 10:47:05 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CCFC08C5DD for ; Thu, 2 Jul 2020 07:47:05 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id j18so27095532wmi.3 for ; Thu, 02 Jul 2020 07:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3ksR11Jmvb7SL0E2lHCNJ8PR7e/D9ZxRofBGhwA7ldY=; b=zmksYIBaxrCz5zyc7rriRGYaT0Dcm87ZjU1pdpSJu/hULGsdNsjYb6FUiXXBfIhkak bpo7SVVHW5OF5iVWGKwXmW+Trqf5MfMEdS7OTZHjDlp5LV2Rh74zx5NoFQsV5EjpswdF J8a5P0Eee+MW/Ki2PC56ZGCds6qtVFuWuvgEp2BbisXPWlfPlpCKJRaFEXgmvJoCs/RG IY2zGwduN8XSqswG+he9Rbtj1V2NqNzniFGoIU8N4R9AxWWk2q38GxfZTHzjUk35Fuxs CGW0402bmXhkN253lJNUGipofaJfzUZSGFnUwKYsQQ269MeS0IEzGDIUZTx5OQxqFjrk xBkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3ksR11Jmvb7SL0E2lHCNJ8PR7e/D9ZxRofBGhwA7ldY=; b=iVvFJfS+h/UCCz6hFxT7DV0/6wBfgvOHi274O3qlupcvCGDM3oQROouySLt2oI/yod o6jVXhBV/c7icUV6yApAnEtvvd79EMjg96SeqvwjmGgcz9UWW7oETVoAYI5tMLSM7gt4 DwbpNtVM6cQI97OpEkiOwKckNRDs2kPoX8Wu+g+1OPNs8doEH5KGq+2NKpFpC4JEvF6z lUS6MjL38p2IsmE9+m4i7WLQLV6mMkjqPo4tPoEHXeTqxopKwBUgXRmK5/nrFIj3Aly+ ZnRbO/gbQKk6RIu34aUTmo+2vQW8Q9vgLRZI5hiBJ8J+c4STprXijxlRgrnzjcG/vYrt nB7A== X-Gm-Message-State: AOAM5313rhU0xC1zM3onx5a7H2dJLHotZVxIADe1YZJpTY/vrF8UxpQe 9YyazggimvJgmjQG8892ZqRmHA== X-Google-Smtp-Source: ABdhPJwmdFlL7RkkYFdFbYW5E+P0S/O3Mbkj0vldn7UPZvUiB5nbMpzJlLHg5XaYehkEIQxF9v3LEg== X-Received: by 2002:a7b:c348:: with SMTP id l8mr34582906wmj.54.1593701223995; Thu, 02 Jul 2020 07:47:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:03 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Peter Korsgaard Subject: [PATCH 26/30] usb: c67x00: c67x00-ll-hpi: Demote obvious misuse of kerneldoc to standard comment blocks Date: Thu, 2 Jul 2020 15:46:21 +0100 Message-Id: <20200702144625.2533530-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/c67x00/c67x00-ll-hpi.c:269: warning: Function parameter or member 'sie' not described in 'c67x00_ll_usb_clear_status' drivers/usb/c67x00/c67x00-ll-hpi.c:269: warning: Function parameter or member 'bits' not described in 'c67x00_ll_usb_clear_status' drivers/usb/c67x00/c67x00-ll-hpi.c:404: warning: Function parameter or member 'dev' not described in 'c67x00_ll_write_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:404: warning: Function parameter or member 'addr' not described in 'c67x00_ll_write_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:404: warning: Function parameter or member 'data' not described in 'c67x00_ll_write_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:404: warning: Function parameter or member 'len' not described in 'c67x00_ll_write_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:443: warning: Function parameter or member 'dev' not described in 'c67x00_ll_read_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:443: warning: Function parameter or member 'addr' not described in 'c67x00_ll_read_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:443: warning: Function parameter or member 'data' not described in 'c67x00_ll_read_mem_le16' drivers/usb/c67x00/c67x00-ll-hpi.c:443: warning: Function parameter or member 'len' not described in 'c67x00_ll_read_mem_le16' Cc: Peter Korsgaard Signed-off-by: Lee Jones --- drivers/usb/c67x00/c67x00-ll-hpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/c67x00/c67x00-ll-hpi.c b/drivers/usb/c67x00/c67x00-ll-hpi.c index e1fe3603140a8..7a214a3a6cc70 100644 --- a/drivers/usb/c67x00/c67x00-ll-hpi.c +++ b/drivers/usb/c67x00/c67x00-ll-hpi.c @@ -262,7 +262,7 @@ u16 c67x00_ll_get_usb_ctl(struct c67x00_sie *sie) return hpi_read_word(sie->dev, USB_CTL_REG(sie->sie_num)); } -/** +/* * c67x00_ll_usb_clear_status - clear the USB status bits */ void c67x00_ll_usb_clear_status(struct c67x00_sie *sie, u16 bits) @@ -395,7 +395,7 @@ int c67x00_ll_reset(struct c67x00_device *dev) /* -------------------------------------------------------------------------- */ -/** +/* * c67x00_ll_write_mem_le16 - write into c67x00 memory * Only data is little endian, addr has cpu endianess. */ @@ -434,7 +434,7 @@ void c67x00_ll_write_mem_le16(struct c67x00_device *dev, u16 addr, } } -/** +/* * c67x00_ll_read_mem_le16 - read from c67x00 memory * Only data is little endian, addr has cpu endianess. */ From patchwork Thu Jul 2 14:46:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639109 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA3D96C1 for ; Thu, 2 Jul 2020 14:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF35420899 for ; Thu, 2 Jul 2020 14:47:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ec9+I5ho" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730165AbgGBOrg (ORCPT ); Thu, 2 Jul 2020 10:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730092AbgGBOrG (ORCPT ); Thu, 2 Jul 2020 10:47:06 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22013C08C5DE for ; Thu, 2 Jul 2020 07:47:06 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k6so28804787wrn.3 for ; Thu, 02 Jul 2020 07:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tMwEsthS2XYuYqGurNM6AKehw8G1mrvga4W0hde7UB4=; b=Ec9+I5hoL4c/OhbpQoBFb0y/CZVujjYmRsG/1zskUnSQq8YXfTxz90ThqQYnal+8DG q9ZnLOIeC0Y/oOcogCkBJL2g4xr6q75hsSFPpXIRVaWXOdizoz2be1Z5wgaXaTcZiTK9 YZRONflM9w29AwuNQ/AcRDs5Lv6oRcj6CI8ycLh1AeT/5ElyI6syYd2uy+U+X+pfBqxZ shRBecxJWCSOZLUfRifV1q3PVl+kl9TW7VEbPnqwP2BQEd8p+t35ZDnT1SBdK25xWKvh 5OI0Mfcv1M37zgWEDFdhWdMpVFiuIlRDKUGFF891sC232jg1ZlgkdUIgF5MAqOhVBMzW T4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tMwEsthS2XYuYqGurNM6AKehw8G1mrvga4W0hde7UB4=; b=CqmbKEcZflol4OGlbwBgW7VjnwXkxY5tEr7TnKMI9rKc+mpJ1AS3u1/+WwlobUJOP6 CSzES061Edt2quQU5Ta6tOD1rxRP1TrfvSfFp8g+7jicXU5ud6y4Rr0HMgYIQujbrsPK ZrHJsDoADaaG63vgQtX0hw4suy15pYYec4zaO6ULRQrsNxwYpmZJiKFix0kuO2OBqNNS rsda/fnICX19+lk3sEBZFqdawZTRHb71k6MAEIciEIjw6QwCxJD39jwxUceV7CiqEJ/1 Nw5v2ztqp953VgQLqaihPFsciMzz1ZqS1hvxNZtFIZZT5B+zqnvNfaPwvlsOjEMjUQch OtYQ== X-Gm-Message-State: AOAM530m+M6cIuzMRsciBW99gMBc7BwQ8t6mcQijzFGzRiPydACXDUix NTuhsk+nyysE5Nud0ESdpNEiXA== X-Google-Smtp-Source: ABdhPJw7EjXi0Slg9JA5tb8YCf/T1dmVYfymH7vJT4eCDqjnytPxyDPB10JCVTRNqKL+qKYBCha9jw== X-Received: by 2002:adf:a507:: with SMTP id i7mr34858253wrb.0.1593701224905; Thu, 02 Jul 2020 07:47:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:04 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Oliver Neukum Subject: [PATCH 27/30] usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s manage_power arg Date: Thu, 2 Jul 2020 15:46:22 +0100 Message-Id: <20200702144625.2533530-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org A good attempt was made to document everything else. Fixes the following W=1 kernel build warning(s): drivers/usb/class/cdc-wdm.c:961: warning: Function parameter or member 'manage_power' not described in 'usb_cdc_wdm_register' Cc: Oliver Neukum Signed-off-by: Lee Jones --- drivers/usb/class/cdc-wdm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index e3db6fbeadef8..4dceaeca46e73 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -940,7 +940,8 @@ static int wdm_probe(struct usb_interface *intf, const struct usb_device_id *id) * @intf: usb interface the subdriver will associate with * @ep: interrupt endpoint to monitor for notifications * @bufsize: maximum message size to support for read/write - * + * @manage_power: call-back invoked during open and release to + * manage the device's power * Create WDM usb class character device and associate it with intf * without binding, allowing another driver to manage the interface. * From patchwork Thu Jul 2 14:46:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639111 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 73ABF92A for ; Thu, 2 Jul 2020 14:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 566BF20899 for ; Thu, 2 Jul 2020 14:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fmzINiOY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730161AbgGBOrf (ORCPT ); Thu, 2 Jul 2020 10:47:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730096AbgGBOrH (ORCPT ); Thu, 2 Jul 2020 10:47:07 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 249E1C08C5DD for ; Thu, 2 Jul 2020 07:47:07 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so26347520wrp.10 for ; Thu, 02 Jul 2020 07:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iWzVZz/7UdELZYlP3FhiTP4gcXKvtcBfoc9CQcE8FIc=; b=fmzINiOYDHpN5/coulur/6WfMZq1rarCvkcLJwqIc1Y/vuMXSWLwF+MLPBxRgaKlQK 4Ji78wYEgQDaVwbW+4aRXxTfZHJm77A0AyZrWNa8iwJEB939IQCZ3ynS6uLTOiB1a9I2 4IxSgs+zF3yxBmJD+DssJh5yua5pBPdkwPunbhnQf1J3GyvfXFXkW96zLVRS7zZMabR8 ez3irtf10ueuJ+NkEVZeYLDkvDyEzRDUV9dqwNeV0UJKx0GjdO/0nuaBTDtHbguY/KLw w9sj5TX+PniKeuvfQirEYAfhKEOWP1kIfpkYj8uGLXc46IX1tnBfuHJbgybJsR6P9RS+ yfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iWzVZz/7UdELZYlP3FhiTP4gcXKvtcBfoc9CQcE8FIc=; b=N5K7pnYJfIZWG/Q0R1QS0AFehiDCjGsoRkysjAyi/eP+OddHSFG4QbkFI78z6t4HGd zy0jF3864juM8vWcPEUXQO3oD6/hmh69nTWGAv2cDcVMAqETw0fX/hNN0thl3BDomBmi UOgQ9QYab1Yh9ZOrcMXeMiryaCpUJSD0wYTvVF61a4PIsRkJAZIUbBQUGcDHxaQI67rx E9IO08t29Wli3Ft9TqpXltu+m60u1uHVxb7cTkbgaYzDiugFlU0s9o1tW10jujkFLRWC Kfe3cv8djZHs7e3t2ips+RCfKlDDUcNWUwp8aQrIDW2ENavVsSgq9F4IGpNKvH3CXQDx jpyw== X-Gm-Message-State: AOAM532uzeyTO//dGsD4fwQeZmeH8kyvlmzKyxaWY5J/LWY1J8eZpD/r fv2lDicYOl9OWZeJmwNTJ4ZyTg== X-Google-Smtp-Source: ABdhPJyebZwL479ANazYAPU87dJ7Xv2lt4Tl/LxXMiJfnCK83vmeGTFhFdEYRoQEiRdz8686JpwKIw== X-Received: by 2002:a5d:4984:: with SMTP id r4mr31222396wrq.215.1593701225820; Thu, 02 Jul 2020 07:47:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:05 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Peter Korsgaard , Oliver Neukum Subject: [PATCH 28/30] usb: c67x00: c67x00-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Date: Thu, 2 Jul 2020 15:46:23 +0100 Message-Id: <20200702144625.2533530-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'sie' not described in 'c67x00_hcd_irq' drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'int_status' not described in 'c67x00_hcd_irq' drivers/usb/c67x00/c67x00-hcd.c:237: warning: Function parameter or member 'msg' not described in 'c67x00_hcd_irq' drivers/usb/c67x00/c67x00-hcd.c:267: warning: Function parameter or member 'hcd' not described in 'c67x00_hcd_start' drivers/usb/c67x00/c67x00-hcd.c:279: warning: Function parameter or member 'hcd' not described in 'c67x00_hcd_stop' Cc: Peter Korsgaard Cc: Oliver Neukum Signed-off-by: Lee Jones --- drivers/usb/c67x00/c67x00-hcd.c | 6 +++--- drivers/usb/class/cdc-wdm.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/c67x00/c67x00-hcd.c b/drivers/usb/c67x00/c67x00-hcd.c index c39eee17c0e46..39f2376663314 100644 --- a/drivers/usb/c67x00/c67x00-hcd.c +++ b/drivers/usb/c67x00/c67x00-hcd.c @@ -228,7 +228,7 @@ static int c67x00_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, * Main part of host controller driver */ -/** +/* * c67x00_hcd_irq * * This function is called from the interrupt handler in c67x00-drv.c @@ -260,7 +260,7 @@ static void c67x00_hcd_irq(struct c67x00_sie *sie, u16 int_status, u16 msg) } } -/** +/* * c67x00_hcd_start: Host controller start hook */ static int c67x00_hcd_start(struct usb_hcd *hcd) @@ -272,7 +272,7 @@ static int c67x00_hcd_start(struct usb_hcd *hcd) return 0; } -/** +/* * c67x00_hcd_stop: Host controller stop hook */ static void c67x00_hcd_stop(struct usb_hcd *hcd) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 4dceaeca46e73..7f5de956a2fc8 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -941,7 +941,7 @@ static int wdm_probe(struct usb_interface *intf, const struct usb_device_id *id) * @ep: interrupt endpoint to monitor for notifications * @bufsize: maximum message size to support for read/write * @manage_power: call-back invoked during open and release to - * manage the device's power + * manage the device's power * Create WDM usb class character device and associate it with intf * without binding, allowing another driver to manage the interface. * From patchwork Thu Jul 2 14:46:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639105 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 384116C1 for ; Thu, 2 Jul 2020 14:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20BEE212CC for ; Thu, 2 Jul 2020 14:47:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DPNUrNZD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730110AbgGBOrL (ORCPT ); Thu, 2 Jul 2020 10:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730104AbgGBOrJ (ORCPT ); Thu, 2 Jul 2020 10:47:09 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0E8C08C5E1 for ; Thu, 2 Jul 2020 07:47:08 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so28288802wmh.2 for ; Thu, 02 Jul 2020 07:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=juN4hSvL5XQNXRrfZcj7AlUDUYFoERtc/+nkEi7x4Ng=; b=DPNUrNZDKr8bIOqrg9aAd2AwHmX5d8s358yRYd2Z9zSwoUay0njHdD3Z9FyOJYfXnq yuXJR5zm+WMALudvtSdSf7QrU+aX32ihed4eNdWS3+J6iP4PSp0ApUSc13R6lbaytViu 2nEXlLP1OTu1qHSAY5bLLe/AzWbxhs2PXgYldAEI3RW1XRKzFipV79YLuUQiSTLjSP8g /v0zUB/rvMW2lVRRVbnVMjr3LCCeiKd0qPq+6o6Y03pAOpmHuNjRYSmtp8eFBBlpTz6c NANPF2k9ZT//OiBoJTGMU6zxAubsmu61/54CaN7OGPIFUzM4MueSjt15ktnQ4bWU6wPP Nuig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=juN4hSvL5XQNXRrfZcj7AlUDUYFoERtc/+nkEi7x4Ng=; b=Wlf+GNZEHtDW/+9AG32VtfbbkLie9VT+zyfoBZBQYXgV8txFnteEXgzZaGSW5By5SL FLaL6ZUvxgdUI+xsbPVsR2xe431ceeay4KhKkYjdEEfxKPgWIz6SbGHmraL5wRXiBBX9 Li3d6YWq3Xudb6QXNbguJNUF7NsJKGscjYJGpxBeUjQDd9aL86aXyw6r1OMQq7RUrWbq 6etoiWVHk+hQZzyeki0Yc/AH6L1nRr+dVy/riKZ1oHno8nrxbtsGGJ7va1cb1MMyBRKn PJM87tCa1EhLiZLl6LjhcJ5L75iDyeccepYJP2Uj7G97fckfUxwMd9z0lgQo00++ypw1 2M7A== X-Gm-Message-State: AOAM533ge9h4y6XWdiSU9zEATrB64xovy6cRtZgSSVu3QHGxbHqGFg1h 8FT2F2QURDm0VJrLSfYYhKSPiA== X-Google-Smtp-Source: ABdhPJwZjQU/P4mU/ND53GM/MjXCWI6l4mYnK8RuPiwY1UjcwaxyYVsB/ikr+y30GGMSdRhl2uBtAA== X-Received: by 2002:a1c:e914:: with SMTP id q20mr30736308wmc.145.1593701227467; Thu, 02 Jul 2020 07:47:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones Subject: [PATCH 29/30] usb: class: usbtmc: File headers are not good candidates for kerneldoc Date: Thu, 2 Jul 2020 15:46:24 +0100 Message-Id: <20200702144625.2533530-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote usbtmc's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/class/usbtmc.c:11: warning: Function parameter or member 'fmt' not described in 'pr_fmt' Signed-off-by: Lee Jones --- drivers/usb/class/usbtmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index ffc9c6fdd7e1d..4b52758d3a38f 100644 --- a/drivers/usb/class/usbtmc.c +++ b/drivers/usb/class/usbtmc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0+ -/** +/* * drivers/usb/class/usbtmc.c - USB Test & Measurement class driver * * Copyright (C) 2007 Stefan Kopp, Gechingen, Germany From patchwork Thu Jul 2 14:46:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11639107 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 007EE6C1 for ; Thu, 2 Jul 2020 14:47:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D251820899 for ; Thu, 2 Jul 2020 14:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NF9g3FmC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730142AbgGBOr0 (ORCPT ); Thu, 2 Jul 2020 10:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730106AbgGBOrK (ORCPT ); Thu, 2 Jul 2020 10:47:10 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AEF6C08C5C1 for ; Thu, 2 Jul 2020 07:47:10 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so28733177wrj.13 for ; Thu, 02 Jul 2020 07:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GGmNfPC5yyfRr4hRGf2JBNE4nTAK9gpUa3GW7C/jBWg=; b=NF9g3FmC0XN5JQHD6tLzZePjEQQeNjaNgi80LtNDZOe509ZXtnM99as/gig4tZM43V /LTUc4rwnO7YAurW0YGpnQulS7Cp9bzVFb5MH3rCEi5wm6YwY6TLAfRDomNexC4rnEu6 c5xrPVbs4ksyzWPLp2M9t0vP3nKHETS7MysXVUaWfe3bOIrGk4unP+NjuXwN8k0LwJtw Ej7T4rjanV9O5oHL7oi80Dk6yFHa/VboIKRhhXnb9oa15jjYMbwKtD7RHz5ThbQ0ym31 CgYkfpCAvvclfI7u+tam5EKcoXhYGh1IWCaIoiClWayNYdv71V9J7NDWE+zvdknuUtiE K2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GGmNfPC5yyfRr4hRGf2JBNE4nTAK9gpUa3GW7C/jBWg=; b=GtRGz3Uasuuh//fD4Lb4quegP2+qe+RvjiEfi0TCnNrbkMstJMZCBUhleQA26TViSj 1wivsJtdM+QCicQ3uXpLVrG30Z0jjITBni7crbqA1vMWs6oVtyNucY1JIegIDPQDz+Aa LarOJTqI3ap8HS5Kx2YTEDJGmS8ZuLy6MzUHfp1WmLhSzYI7JtMbg95nXwlKTtUUO3h5 DT2u/8owMTCx+g3qy+754/uQ+1BuKSXrkGIxZ2CL2XwtNpCP2rD22C8GnqUBvpBMJvx6 U5aRSq937MFBXwkge//GPIFfMqEFN11xDU/sCz9F+k2w571PEVjfd1iLG7+d2I0IwcB+ /kkA== X-Gm-Message-State: AOAM532nndPmeXelKTJIQMAfqgsO5X007hbkDGLJTe/ZlNel/uIM5ZZd JRONFTcfSnK8tphuymMQNLxcHw== X-Google-Smtp-Source: ABdhPJxOsbwXE/Dv8fyPSOwYjCV8DD+BU5x3NhIySmUznQc+FEh85NIDpK8tN/yFxlLe35byCsnobw== X-Received: by 2002:adf:f60a:: with SMTP id t10mr23432964wrp.64.1593701228692; Thu, 02 Jul 2020 07:47:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:47:08 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Peter Korsgaard Subject: [PATCH 30/30] usb: c67x00: c67x00-sched: Demote obvious misuse of kerneldoc to standard comment blocks Date: Thu, 2 Jul 2020 15:46:25 +0100 Message-Id: <20200702144625.2533530-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/c67x00/c67x00-sched.c:35: warning: Function parameter or member 'queue' not described in 'c67x00_ep_data' drivers/usb/c67x00/c67x00-sched.c:35: warning: Function parameter or member 'node' not described in 'c67x00_ep_data' drivers/usb/c67x00/c67x00-sched.c:35: warning: Function parameter or member 'hep' not described in 'c67x00_ep_data' drivers/usb/c67x00/c67x00-sched.c:35: warning: Function parameter or member 'dev' not described in 'c67x00_ep_data' drivers/usb/c67x00/c67x00-sched.c:35: warning: Function parameter or member 'next_frame' not described in 'c67x00_ep_data' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'ly_base_addr' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'port_length' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'pid_ep' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'dev_addr' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'ctrl_reg' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'status' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'retry_cnt' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'residue' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'next_td_addr' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'td_list' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'td_addr' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'data' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'urb' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'privdata' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'ep_data' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:71: warning: Function parameter or member 'pipe' not described in 'c67x00_td' drivers/usb/c67x00/c67x00-sched.c:137: warning: Function parameter or member 'c67x00' not described in 'dbg_td' drivers/usb/c67x00/c67x00-sched.c:137: warning: Function parameter or member 'td' not described in 'dbg_td' drivers/usb/c67x00/c67x00-sched.c:137: warning: Function parameter or member 'msg' not described in 'dbg_td' drivers/usb/c67x00/c67x00-sched.c:169: warning: Function parameter or member 'a' not described in 'frame_add' drivers/usb/c67x00/c67x00-sched.c:169: warning: Function parameter or member 'b' not described in 'frame_add' drivers/usb/c67x00/c67x00-sched.c:177: warning: Function parameter or member 'a' not described in 'frame_after' drivers/usb/c67x00/c67x00-sched.c:177: warning: Function parameter or member 'b' not described in 'frame_after' drivers/usb/c67x00/c67x00-sched.c:186: warning: Function parameter or member 'a' not described in 'frame_after_eq' drivers/usb/c67x00/c67x00-sched.c:186: warning: Function parameter or member 'b' not described in 'frame_after_eq' drivers/usb/c67x00/c67x00-sched.c:199: warning: Function parameter or member 'c67x00' not described in 'c67x00_release_urb' drivers/usb/c67x00/c67x00-sched.c:199: warning: Function parameter or member 'urb' not described in 'c67x00_release_urb' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'c67x00' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'urb' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'data' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'len' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'pid' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'toggle' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:566: warning: Function parameter or member 'privdata' not described in 'c67x00_create_td' drivers/usb/c67x00/c67x00-sched.c:692: warning: Function parameter or member 'c67x00' not described in 'c67x00_add_ctrl_urb' drivers/usb/c67x00/c67x00-sched.c:692: warning: Function parameter or member 'urb' not described in 'c67x00_add_ctrl_urb' drivers/usb/c67x00/c67x00-sched.c:830: warning: Function parameter or member 'c67x00' not described in 'c67x00_parse_td' drivers/usb/c67x00/c67x00-sched.c:830: warning: Function parameter or member 'td' not described in 'c67x00_parse_td' drivers/usb/c67x00/c67x00-sched.c:978: warning: Function parameter or member 'c67x00' not described in 'c67x00_check_td_list' drivers/usb/c67x00/c67x00-sched.c:1052: warning: Function parameter or member 'c67x00' not described in 'c67x00_send_td' drivers/usb/c67x00/c67x00-sched.c:1052: warning: Function parameter or member 'td' not described in 'c67x00_send_td' drivers/usb/c67x00/c67x00-sched.c:1088: warning: Function parameter or member 'c67x00' not described in 'c67x00_do_work' Cc: Peter Korsgaard Signed-off-by: Lee Jones --- drivers/usb/c67x00/c67x00-sched.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/usb/c67x00/c67x00-sched.c b/drivers/usb/c67x00/c67x00-sched.c index 633c52de3bb36..ef1e4ecaee996 100644 --- a/drivers/usb/c67x00/c67x00-sched.c +++ b/drivers/usb/c67x00/c67x00-sched.c @@ -23,7 +23,7 @@ /* -------------------------------------------------------------------------- */ -/** +/* * struct c67x00_ep_data: Host endpoint data structure */ struct c67x00_ep_data { @@ -34,7 +34,7 @@ struct c67x00_ep_data { u16 next_frame; /* For int/isoc transactions */ }; -/** +/* * struct c67x00_td * * Hardware parts are little endiannes, SW in CPU endianess. @@ -130,7 +130,7 @@ struct c67x00_urb_priv { /* -------------------------------------------------------------------------- */ -/** +/* * dbg_td - Dump the contents of the TD */ static void dbg_td(struct c67x00_hcd *c67x00, struct c67x00_td *td, char *msg) @@ -161,7 +161,7 @@ static inline u16 c67x00_get_current_frame_number(struct c67x00_hcd *c67x00) return c67x00_ll_husb_get_frame(c67x00->sie) & HOST_FRAME_MASK; } -/** +/* * frame_add * Software wraparound for framenumbers. */ @@ -170,7 +170,7 @@ static inline u16 frame_add(u16 a, u16 b) return (a + b) & HOST_FRAME_MASK; } -/** +/* * frame_after - is frame a after frame b */ static inline int frame_after(u16 a, u16 b) @@ -179,7 +179,7 @@ static inline int frame_after(u16 a, u16 b) (HOST_FRAME_MASK / 2); } -/** +/* * frame_after_eq - is frame a after or equal to frame b */ static inline int frame_after_eq(u16 a, u16 b) @@ -190,7 +190,7 @@ static inline int frame_after_eq(u16 a, u16 b) /* -------------------------------------------------------------------------- */ -/** +/* * c67x00_release_urb - remove link from all tds to this urb * Disconnects the urb from it's tds, so that it can be given back. * pre: urb->hcpriv != NULL @@ -557,7 +557,7 @@ static int c67x00_claim_frame_bw(struct c67x00_hcd *c67x00, struct urb *urb, /* -------------------------------------------------------------------------- */ -/** +/* * td_addr and buf_addr must be word aligned */ static int c67x00_create_td(struct c67x00_hcd *c67x00, struct urb *urb, @@ -685,7 +685,7 @@ static int c67x00_add_data_urb(struct c67x00_hcd *c67x00, struct urb *urb) return 0; } -/** +/* * return 0 in case more bandwidth is available, else errorcode */ static int c67x00_add_ctrl_urb(struct c67x00_hcd *c67x00, struct urb *urb) @@ -822,7 +822,7 @@ static void c67x00_fill_frame(struct c67x00_hcd *c67x00) /* -------------------------------------------------------------------------- */ -/** +/* * Get TD from C67X00 */ static inline void @@ -970,7 +970,7 @@ static void c67x00_handle_isoc(struct c67x00_hcd *c67x00, struct c67x00_td *td) /* -------------------------------------------------------------------------- */ -/** +/* * c67x00_check_td_list - handle tds which have been processed by the c67x00 * pre: current_td == 0 */ @@ -1045,7 +1045,7 @@ static inline int c67x00_all_tds_processed(struct c67x00_hcd *c67x00) return !c67x00_ll_husb_get_current_td(c67x00->sie); } -/** +/* * Send td to C67X00 */ static void c67x00_send_td(struct c67x00_hcd *c67x00, struct c67x00_td *td) @@ -1081,7 +1081,7 @@ static void c67x00_send_frame(struct c67x00_hcd *c67x00) /* -------------------------------------------------------------------------- */ -/** +/* * c67x00_do_work - Schedulers state machine */ static void c67x00_do_work(struct c67x00_hcd *c67x00)