From patchwork Mon Jul 6 13:33:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645853 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6EBDE92A for ; Mon, 6 Jul 2020 13:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B25820715 for ; Mon, 6 Jul 2020 13:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tb+/K0K1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729215AbgGFNds (ORCPT ); Mon, 6 Jul 2020 09:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729209AbgGFNdr (ORCPT ); Mon, 6 Jul 2020 09:33:47 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5ED1C061794 for ; Mon, 6 Jul 2020 06:33:46 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so42117292wmh.2 for ; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=tb+/K0K1eA704mpMyghl55v/zWI4mSEucjEWMkto05EJAwtt81Tuc5Ialuiq8LeS2R x7eNhrR5yGpofVpGMlUc+dGvW6hOfzZAKfuPvTYOL9cr6csy+Q7aT4rJAe+QBVgDpCWB JmX38nI6hJKRDaLdaCbKahq0CK0atprPWa2Wn5hZzUEnnjAXQrcx+95LGiam9CAdWbmM QFxzd5VOEiDqMgyMUKWN0JEn5Yco8m9QTRctmmUjIDZ2rJKKvS/HJF17k9YJnzu5eULF XF3nsJOJPonHF1SaySMBGld80Ol8vOnadKhByaY0CkSeG7cHOObHZPhTkBpFLNt2aOaX OXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=C1URJ3soQ1gquaTJ38uKPOt2qcuNwkBHiWCoNex791vP8ZlCi9kILAkg6VruIhfrt4 UFv3ekpsw70qeJNGMwRy79twsZoIE0BlPCgQzqYueHU/cHnOdkyE+KZowOCGRjfQYglR +2XYq0mfNh4rzWWhp7eaC5ibQBZJEHanKgU2h9iRw5E6NnluQWjbsqeZlo6p0PwhBmo6 rdtYwE6XUBBNFDVftz5uequPksl9C5xasvvImPZRYh7yhUWI6TOOPTohzzNTNNjjxCAj JzjiWzsb59wlZis6S4gtNjfKJw2ZRmbW/vwJv/UmbjfzlfwtWwzxxYBf6Mg8TAwbijzm ekmA== X-Gm-Message-State: AOAM531ibqmx9BIwTsKEwwsYTjZ2ayUdlANgXPwJkXkJvWLI5DPzCpKP r1MK5xYGC4DY0lQW75RBQy1kQl3MB54= X-Google-Smtp-Source: ABdhPJxVTByOnTI298yDjNpJQ+8K3fWLg5oZdMazHD2udtCJrLX53D0eLnbVRozcdO4IHjwxa9apZQ== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51110615wma.4.1594042425621; Mon, 06 Jul 2020 06:33:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Juergen Stuber , David Glance , david , legousb-devel@lists.sourceforge.net Subject: [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:10 +0100 Message-Id: <20200706133341.476881-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release' drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write' drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback' drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index ab4b98b041158..8aca55c4c95f1 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -283,7 +283,7 @@ static inline void lego_usb_tower_debug_data(struct device *dev, } -/** +/* * tower_delete */ static inline void tower_delete(struct lego_usb_tower *dev) @@ -299,7 +299,7 @@ static inline void tower_delete(struct lego_usb_tower *dev) } -/** +/* * tower_open */ static int tower_open(struct inode *inode, struct file *file) @@ -398,7 +398,7 @@ static int tower_open(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_release */ static int tower_release(struct inode *inode, struct file *file) @@ -440,7 +440,7 @@ static int tower_release(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_check_for_read_packet * * To get correct semantics for signals and non-blocking I/O @@ -461,7 +461,7 @@ static void tower_check_for_read_packet(struct lego_usb_tower *dev) } -/** +/* * tower_poll */ static __poll_t tower_poll(struct file *file, poll_table *wait) @@ -487,7 +487,7 @@ static __poll_t tower_poll(struct file *file, poll_table *wait) } -/** +/* * tower_llseek */ static loff_t tower_llseek(struct file *file, loff_t off, int whence) @@ -496,7 +496,7 @@ static loff_t tower_llseek(struct file *file, loff_t off, int whence) } -/** +/* * tower_read */ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) @@ -580,7 +580,7 @@ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, } -/** +/* * tower_write */ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t count, loff_t *ppos) @@ -662,7 +662,7 @@ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t } -/** +/* * tower_interrupt_in_callback */ static void tower_interrupt_in_callback(struct urb *urb) @@ -717,7 +717,7 @@ static void tower_interrupt_in_callback(struct urb *urb) } -/** +/* * tower_interrupt_out_callback */ static void tower_interrupt_out_callback(struct urb *urb) @@ -742,7 +742,7 @@ static void tower_interrupt_out_callback(struct urb *urb) } -/** +/* * tower_probe * * Called by the usb core when a new device is connected that it thinks @@ -854,7 +854,7 @@ static int tower_probe(struct usb_interface *interface, const struct usb_device_ } -/** +/* * tower_disconnect * * Called by the usb core when the device is removed from the system. From patchwork Mon Jul 6 13:33:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645849 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3462F1709 for ; Mon, 6 Jul 2020 13:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1766120715 for ; Mon, 6 Jul 2020 13:36:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NkRY2E/H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbgGFNdv (ORCPT ); Mon, 6 Jul 2020 09:33:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729209AbgGFNds (ORCPT ); Mon, 6 Jul 2020 09:33:48 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF3A3C061755 for ; Mon, 6 Jul 2020 06:33:47 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id q15so39369864wmj.2 for ; Mon, 06 Jul 2020 06:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WNaU7ol+N7ICBJATYVP9nw4MVbukWo2xxwQRmnXSWuw=; b=NkRY2E/HSC6TCiGYYeAp7Ij0MVWlfjDJVXmJchaUI3rMunKmwloMDjVwIp6WkePzX/ zebB66G53xUr0ZsJFMrQhXE1gWX/AxLXp0tbYzYz+lCr6MH6Z9gTFrD1OfaR+kij4/1e 2NzT2rvVJrW4SvM//cDtdM/tfm4y/E8QoRFFxL2ksnPMJ1Kp2LcVIiLEjXgEkiSAokKK hFp2tTqg+WJ9LgX/G1frCemjOnFGdmZY3t5IEYxNaXbrue949/A0rRh6O9KbRzWpzsYL dWP09kh1fL33PDeBGoUY6awH4Adfw8S3qvhYakuSG2YCXfUEfR/XdT+fSm0Rukc4Wopr vteg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WNaU7ol+N7ICBJATYVP9nw4MVbukWo2xxwQRmnXSWuw=; b=LrY+JN2bs3xLWGZrnqlXkCXL25+JrZC2F8sHUTm+5JVqCnTrJEeogcQtYiE72QW0j8 uDc+tktAcpoC+KPF9eOdNm71Kv8MJf9cidpCRrwsbCMBigWG4yK75GjdCfRfzrBYykah lsGnvrJXnXRSWZ5ComtjPYwWCOZMt5DdP+yxbi977iZAsl+lMuMnJcNZMlatuo56GTvn bkDw9uCaquGreMOSqaVLmGMlJ8whYG/Mhy4nhv/LZRDlnekocvJnrqWF2T/RSGWsQ02i EV/lUy7kLmGgaoRAP+C9PIogw9v1QLElLiOpvR6LEcCmLyNCW3Vo6Wxq/gFj+aiZPsDe 3UBg== X-Gm-Message-State: AOAM533gudR9VZlQL707Jeq2JkBS1/KRb2H+FWktnWHXKuSrgtCcD5tL rNt3XR9MBRFS4YnGcJjbd8DrZA== X-Google-Smtp-Source: ABdhPJzV6Ohv7aXVOIIpA3ZhF5c1WJsv9HI1KNboAwezr33m6B8+3YAS3pk85zXnZUZoeM+YxtgKZg== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr52514926wmb.105.1594042426613; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:46 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Peter Chen , David Lopo Subject: [PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format Date: Mon, 6 Jul 2020 14:33:11 +0100 Message-Id: <20200706133341.476881-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the structure's properties here. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/ci_hdrc_pci.c:132: warning: cannot understand function prototype: 'const struct pci_device_id ci_hdrc_pci_id_table[] = ' Cc: Peter Chen Cc: David Lopo Signed-off-by: Lee Jones --- drivers/usb/chipidea/ci_hdrc_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c index 49a61549cee67..d63479e1ad104 100644 --- a/drivers/usb/chipidea/ci_hdrc_pci.c +++ b/drivers/usb/chipidea/ci_hdrc_pci.c @@ -120,7 +120,7 @@ static void ci_hdrc_pci_remove(struct pci_dev *pdev) usb_phy_generic_unregister(ci->phy); } -/** +/* * PCI device table * PCI device structure * From patchwork Mon Jul 6 13:33:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645847 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9F92392A for ; Mon, 6 Jul 2020 13:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 861FF20720 for ; Mon, 6 Jul 2020 13:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RLGORxri" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729245AbgGFNdw (ORCPT ); Mon, 6 Jul 2020 09:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729230AbgGFNdu (ORCPT ); Mon, 6 Jul 2020 09:33:50 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B68ADC061755 for ; Mon, 6 Jul 2020 06:33:49 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f7so37934256wrw.1 for ; Mon, 06 Jul 2020 06:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Da1l6YoL6n3bU+jKdqHFRQjokYKz+vBJsiPCL0gGolc=; b=RLGORxri111/tc0Sf0mSoMmtk2VwtRaHx86WcvDwSf1/2SpW+CMz1rr253sGKsrvUK uK22hb403LtPowLnwcDgpTXUfLiAzl7Ehka5hCIWxZK6tjJrXH/wyoVJgONMo5Vu0Nlj JOVU+F2Tj3eJNLPuV+P6fh0BlaNOe3kQimvqE0cUCtSdVVV++6OkgHXYK9XMdK6fCCjd iZNN4s0Qp4aWOgSDwztx886A+qDLbMjw6kR7XG7HJvjUgbm3GyBPHn2A4CX1p7G+5fJG RBZDMLNZSD0KaU+9REz4lAenuUrsvBhPyngaO9nQBPnshwM8sSoFKRwQJe7F/lZ+K4W/ mSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Da1l6YoL6n3bU+jKdqHFRQjokYKz+vBJsiPCL0gGolc=; b=P4ljdu7oKxKYRVvYgERapwb1EtbQUpZDAAjF48mQZuVvsdtpCD7nsRlPQh+4+3Yxb9 sbha6Q/HjKbhxH+6grSICnSTCmFhB3+RAVKAQMnqv9+b0ym27tnQfTxWqgLikVoCggdm mco2O2mGbZTgif3ZZbeWrGd4loPVcuoSuC9L6kJc7keD5HQE1WDN4HfAQzbnAQeg6xMx 1hvxrZPF5WX+pu1wN0XoNVdFf8XiXI1+1Omdi0N+eSmNK6H9RRaUusZCZsENsPZ06VTX e1tXgIdPFxEMS0DEIEfsU2pEa6RRtL44kuv0ctEj/S3uiY9TjmVqfLy/NgPo65xrbM+7 a20w== X-Gm-Message-State: AOAM532nFDVOOdwbJjokG0XDrCQjrjiRhQC8u6bGz8QK36/jUaXDfjQM 9Qq77ikBjZNLnYGp+6qdpG+NVQ== X-Google-Smtp-Source: ABdhPJxATiVCCEdpbl6fe+AbCMEAVhovrhkPLT0ovW8Huxs2dGyxJI6Eppza+UQYGaCLyWLadV5R2g== X-Received: by 2002:a5d:504b:: with SMTP id h11mr47735862wrt.160.1594042428510; Mon, 06 Jul 2020 06:33:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:47 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc' Date: Mon, 6 Jul 2020 14:33:12 +0100 Message-Id: <20200706133341.476881-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/printer.c:24:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/legacy/printer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/printer.c b/drivers/usb/gadget/legacy/printer.c index 57858f0c2b6c9..2cd389575084b 100644 --- a/drivers/usb/gadget/legacy/printer.c +++ b/drivers/usb/gadget/legacy/printer.c @@ -21,7 +21,6 @@ USB_GADGET_COMPOSITE_OPTIONS(); #define DRIVER_VERSION "2015 FEB 17" static const char shortname [] = "printer"; -static const char driver_desc [] = DRIVER_DESC; #include "u_printer.h" From patchwork Mon Jul 6 13:33:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645851 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B004192A for ; Mon, 6 Jul 2020 13:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9692420715 for ; Mon, 6 Jul 2020 13:36:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G1JoL1Da" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729303AbgGFNg3 (ORCPT ); Mon, 6 Jul 2020 09:36:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729232AbgGFNdv (ORCPT ); Mon, 6 Jul 2020 09:33:51 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD228C08C5E0 for ; Mon, 6 Jul 2020 06:33:50 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so38523794wrp.10 for ; Mon, 06 Jul 2020 06:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2vBJeRBU9C8xa/2tDAV3EYv6FtdJQoWad8hFtUeL0Ic=; b=G1JoL1Daorj+JI1ZRbOm0BsITxlYPCPhqAXR8booNKNusooKx24v80Dl9rC+dERNjZ 1wDaFAseXrhBUGr/nbWDDAg/16r5MFQ9cICHpdVqoKiFiyiwWy/N6B6OmFsQ5NXGyjc9 YYrEKmJpZh64Xww7sSEG5VmFi3dtB3DobR83PDYZV5cTCGpwS6PSwpL/XGycHcTpzTWc KSpxBlGnI3+pIfmjl4b1LGJvFxbn3iOWQV/oCNEbTR+EPdh+h7R8qux7lxvt8n7chmMt 6dbFgzTJ0owILMLo/els7olUo+4e0lOaKULvAdId+iS9nhTGGBE4kGFBKvyANowDHPnf XWng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2vBJeRBU9C8xa/2tDAV3EYv6FtdJQoWad8hFtUeL0Ic=; b=HR2GeQlidjQqhtHIa8OBuagaO5VJAtYvQdBwtWtXsU3WnUpO1iS42jtija5Q2Diift POWoJ0Gt+tQN4gfl81GAZNk/k7yTDuDHo9gOH9WxyKDm5hS3j9Ls6dYh0BreKjrCaYV4 67G71ECGiLwADtAYrCzVZ98+Rm0Gh6BetPlUiLEQGTA//L8Clejalf9Ct6S6umHNlu6o uz94ydT+eeumVXoCsaEJj50SggLb+c1dO+eCjOgC8CiSPLN0cR/CAyiPvjKIh0zRgvD0 xwrSrVI00gz3fGY9E5EkvjVxe2tai5+GzB/hC1tlgbkV2T/HUGazU6+wszQBcJDYDi5s w+WQ== X-Gm-Message-State: AOAM532fgdnX8hrdMDfBDouxxvO8lTBWbmUjWdWWUj4hLh+GqW46nLqn IPLKQriOSNgHueq7GOYrxn3MAw2Y4ZY= X-Google-Smtp-Source: ABdhPJxwyl8nugjLp5ZVCs5jjXRLq7y1skE4cNELfOaMcl4PfNxE/98yrBxip9g69YujC40tpLTZeg== X-Received: by 2002:a5d:5706:: with SMTP id a6mr13465102wrv.328.1594042429481; Mon, 06 Jul 2020 06:33:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:48 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' Date: Mon, 6 Jul 2020 14:33:13 +0100 Message-Id: <20200706133341.476881-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/amd5536udc_pci.c:52:19: warning: ‘mod_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/amd5536udc_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c index 80685e4306f31..56258d076abc4 100644 --- a/drivers/usb/gadget/udc/amd5536udc_pci.c +++ b/drivers/usb/gadget/udc/amd5536udc_pci.c @@ -49,7 +49,6 @@ static struct udc *udc; /* description */ -static const char mod_desc[] = UDC_MOD_DESCRIPTION; static const char name[] = "amd5536udc-pci"; /* Reset all pci context */ From patchwork Mon Jul 6 13:33:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645777 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2D85739 for ; Mon, 6 Jul 2020 13:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D983020702 for ; Mon, 6 Jul 2020 13:33:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bWfrC2CT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729257AbgGFNdx (ORCPT ); Mon, 6 Jul 2020 09:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729249AbgGFNdw (ORCPT ); Mon, 6 Jul 2020 09:33:52 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA21BC061794 for ; Mon, 6 Jul 2020 06:33:51 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so40973637wrv.9 for ; Mon, 06 Jul 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+1uVBpjaOD4IpY3ZVlXbRV81yiri13+tuf6A/llAK/Q=; b=bWfrC2CT864d48e8sCwLNN6S649Z7RUI6pO1r+dF7OQw0XBZ0w+YwQQRCgFTULa6lO pUTSNHqHo5MEMTKVVgMIK7+bkfHfqxXFMNgjUdN4S6S7nnMVygMuDMWlbsNhPfyl68jD avi2zqxlw+3PRHuC+6tM753fGejds5lVDT+akNypUQ2JCcQvMzLNJF+A2Xe6mKVZPj7x ZLRC8d3qGcXfT5kgnn66HLzFcO6h8g/DsDcpAsMjN5bQHWZPSbai4i1du/j4Cmeb9Ml5 5lJ4DfLAuw09P70HDlLAaeKYQp/cHK5Eh+xJMsB+5p8ptypyUIV1/p+NtWybWXuYyrVB AiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+1uVBpjaOD4IpY3ZVlXbRV81yiri13+tuf6A/llAK/Q=; b=j7c8bWIZpdoPkyuSy77HdhAuIcJpze5Yke4L59fE6sryRDEJAUnjc+zkdhqN6qZh50 fD1+EL2SnbxAxktDyJ0idBnu8HwWyHFzP4ZaluOebzH7IcD1Wq14t4tpuyGQAF5yQduw RwbzVfD6rw7H5fmD2HOpxJE0L+WbAttTk18K3iGBD1H7NoplWrDktrXRtwX45PZsfEak t/e5d75q1V3HeNRLBlIYKpfRBmpwWmMesrW+zyjK40ORtEJM/M28sO6njUqUh77gUd+O 4HJopF0rbOwv/jFifpcyO3GobQsDyL7so5+pSWI17U3pJ4jwgXTaHRRkpstaBFIruBI1 MQpg== X-Gm-Message-State: AOAM530WM6IZqAo16gYdwZSAo99GmJm+VMvop/vAdsCWBNaLPB9T4V9M VAKb/ExRUS3XuvKGkNFMApKrFQ== X-Google-Smtp-Source: ABdhPJwkx0wriCmaCekhauRjWoIcIVTFPWenfRaZ3yayXF3PWVnJO9SnWMwPmaPvsVmH1dWjO20j+Q== X-Received: by 2002:a5d:470b:: with SMTP id y11mr50991135wrq.101.1594042430666; Mon, 06 Jul 2020 06:33:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:50 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi Subject: [PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark Date: Mon, 6 Jul 2020 14:33:14 +0100 Message-Id: <20200706133341.476881-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Kerneldoc expects all function arguments to be documented. If any are missed it will complain. Downgrade one header with 3 missing argument descriptions and one which makes no attempt. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'dev_addr' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'host_addr' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:750: warning: Function parameter or member 'qmult' not described in 'gether_setup_name' drivers/usb/gadget/function/u_ether.c:1022: warning: Function parameter or member 'dev' not described in 'gether_cleanup' Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_ether.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index fbe96ef1ac7a4..f01e3e21ecf21 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -730,7 +730,7 @@ static struct device_type gadget_type = { .name = "gadget", }; -/** +/* * gether_setup_name - initialize one ethernet-over-usb link * @g: gadget to associated with these links * @ethaddr: NULL, or a buffer in which the ethernet address of the @@ -1012,7 +1012,7 @@ int gether_get_ifname(struct net_device *net, char *name, int len) } EXPORT_SYMBOL_GPL(gether_get_ifname); -/** +/* * gether_cleanup - remove Ethernet-over-USB device * Context: may sleep * From patchwork Mon Jul 6 13:33:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A35113B6 for ; Mon, 6 Jul 2020 13:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED4EB20720 for ; Mon, 6 Jul 2020 13:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EQlHDXEO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729573AbgGFNgM (ORCPT ); Mon, 6 Jul 2020 09:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729264AbgGFNdx (ORCPT ); Mon, 6 Jul 2020 09:33:53 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A93C061794 for ; Mon, 6 Jul 2020 06:33:53 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q15so39370192wmj.2 for ; Mon, 06 Jul 2020 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+2CvC0dcY8mKf0yUeXARfEMP6PiuGQCwRdvUKfmvdsM=; b=EQlHDXEOu5c3/xdYpeddQYBFy4VeGzctriOoYrhCEIoajtAlPrNE3FLI4QCGC5nYfM 7ZiHnbWq+YynONBW3qBawaRo36Ul1xVRH5XE+6GrHGxZpgH++Oh7NYaLgGeCsmYbSpwP 3tLYXhtCdK1wHAoNxnOXADLy8CMSkwXWQzkN7wW8SQo5YOCf6fp0RzSk5OGqctOCLZQg GL8Eg2Y3+FtPHIX6Tpv5cIHjwTba4ZLTCzpqUq8COYY3u/kKfbWo0BR2b9t04dS8/eyk O6chMiqAeUlB1WPYKpr1wK9FhkOq2ULHnyFhs1yRG0AzM4NIL04PlaplMvLyE4hRCsAl Qcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+2CvC0dcY8mKf0yUeXARfEMP6PiuGQCwRdvUKfmvdsM=; b=KrB/m9nITIteVXYE9TNx3zMGeWyvK8+LxCoPf/aK9kRhnvVB2uMh2DpKvF1/3clKob kFdi5ccRFj9lZfQhr971eI3f/ad9e2G6puHwKUHp/dcvt1q4IIQSwmLF1PdOPUh8p2n0 UyjZCN3EHd0hz4ecO81dwuqHB4WlVTwtwAtkUFPCuFgpchCTSzurYKvwjJtoizJJOTP6 D8pxnspqVoZkX6AJkW+Moyk/8yfxdNE5oWlbO14iKx25OzlqqfRpj6MB+vvbHKFpmu7a cKMbmQxaS6zFxLyngB4SJs37pX5Gs/GngODBBGgYIbEIhv9hHmCUKE/07+51ZWH9Z/4I fcJw== X-Gm-Message-State: AOAM532lzrvHIyw3oIDXD5GcByJGOswJRNPrgFtGmnHdis2gxJDteJba 9GQLbUN/mYJj/7aSi4prRBg4VQ== X-Google-Smtp-Source: ABdhPJyadCCkqtZcRNQihNkuxmJXSitEdNZGZi4AKQmzoDsvlBAO2i+Ti9nTcPFs+SJ97X4I3lcvfQ== X-Received: by 2002:a1c:a589:: with SMTP id o131mr46569094wme.12.1594042431959; Mon, 06 Jul 2020 06:33:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:51 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Felipe Balbi Subject: [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues Date: Mon, 6 Jul 2020 14:33:15 +0100 Message-Id: <20200706133341.476881-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Mostly bitrotted argument descriptions/names. Also the removal of a blank line in the middle of a kerneldoc header, which is not allowed. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Function parameter or member 'ep' not described in 'ep_write_UDCCSR' drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Excess function parameter 'udc' description in 'ep_write_UDCCSR' drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Function parameter or member 'udc' not described in 'set_ep0state' drivers/usb/gadget/udc/pxa27x_udc.c:479: warning: Excess function parameter 'dev' description in 'set_ep0state' drivers/usb/gadget/udc/pxa27x_udc.c:506: warning: Excess function parameter 'req' description in 'inc_ep_stats_reqs' drivers/usb/gadget/udc/pxa27x_udc.c:1476: warning: bad line: drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Function parameter or member 'udc' not described in 'udc_enable' drivers/usb/gadget/udc/pxa27x_udc.c:1697: warning: Excess function parameter 'dev' description in 'udc_enable' drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Function parameter or member 'g' not described in 'pxa27x_udc_start' drivers/usb/gadget/udc/pxa27x_udc.c:1750: warning: Excess function parameter 'bind' description in 'pxa27x_udc_start' drivers/usb/gadget/udc/pxa27x_udc.c:1784: warning: Excess function parameter 'driver' description in 'stop_activity' drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Function parameter or member 'g' not described in 'pxa27x_udc_stop' drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Excess function parameter 'driver' description in 'pxa27x_udc_stop' drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Function parameter or member 'pdev' not described in 'pxa_udc_probe' drivers/usb/gadget/udc/pxa27x_udc.c:2358: warning: Excess function parameter '_dev' description in 'pxa_udc_probe' Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc: Felipe Balbi Signed-off-by: Lee Jones Acked-by: Robert Jarzmik --- drivers/usb/gadget/udc/pxa27x_udc.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 78902d13fc275..cfaeca457fa72 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -386,7 +386,7 @@ static inline void udc_clear_mask_UDCCR(struct pxa_udc *udc, int mask) /** * ep_write_UDCCSR - set bits in UDCCSR - * @udc: udc device + * @ep: udc endpoint * @mask: bits to set in UDCCR * * Sets bits in UDCCSR (UDCCSR0 and UDCCSR*). @@ -472,7 +472,7 @@ static int epout_has_pkt(struct pxa_ep *ep) /** * set_ep0state - Set ep0 automata state - * @dev: udc device + * @udc: udc device * @state: state */ static void set_ep0state(struct pxa_udc *udc, int state) @@ -498,7 +498,6 @@ static void ep0_idle(struct pxa_udc *dev) /** * inc_ep_stats_reqs - Update ep stats counts * @ep: physical endpoint - * @req: usb request * @is_in: ep direction (USB_DIR_IN or 0) * */ @@ -1473,7 +1472,6 @@ static void udc_disable(struct pxa_udc *udc); * Context: any * * The UDC should be enabled if : - * - the pullup resistor is connected * - and a gadget driver is bound * - and vbus is sensed (or no vbus sense is available) @@ -1688,7 +1686,7 @@ static void udc_init_data(struct pxa_udc *dev) /** * udc_enable - Enables the udc device - * @dev: udc device + * @udc: udc device * * Enables the udc device : enables clocks, udc interrupts, control endpoint * interrupts, sets usb as UDC client and setups endpoints. @@ -1732,8 +1730,8 @@ static void udc_enable(struct pxa_udc *udc) /** * pxa27x_start - Register gadget driver + * @g: gadget * @driver: gadget driver - * @bind: bind function * * When a driver is successfully registered, it will receive control requests * including set_configuration(), which enables non-control requests. Then @@ -1775,7 +1773,6 @@ static int pxa27x_udc_start(struct usb_gadget *g, /** * stop_activity - Stops udc endpoints * @udc: udc device - * @driver: gadget driver * * Disables all udc endpoints (even control endpoint), report disconnect to * the gadget user. @@ -1792,7 +1789,7 @@ static void stop_activity(struct pxa_udc *udc) /** * pxa27x_udc_stop - Unregister the gadget driver - * @driver: gadget driver + * @g: gadget * * Returns 0 if no error, -ENODEV, -EINVAL otherwise */ @@ -2349,7 +2346,7 @@ MODULE_DEVICE_TABLE(of, udc_pxa_dt_ids); /** * pxa_udc_probe - probes the udc device - * @_dev: platform device + * @pdev: platform device * * Perform basic init : allocates udc clock, creates sysfs files, requests * irq. From patchwork Mon Jul 6 13:33:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645843 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3C9992A for ; Mon, 6 Jul 2020 13:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA9D120720 for ; Mon, 6 Jul 2020 13:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xT+yupj9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729570AbgGFNgL (ORCPT ); Mon, 6 Jul 2020 09:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729268AbgGFNdy (ORCPT ); Mon, 6 Jul 2020 09:33:54 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6177EC08C5E1 for ; Mon, 6 Jul 2020 06:33:54 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w3so29666612wmi.4 for ; Mon, 06 Jul 2020 06:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WegnVZ9DGyLW+kA2xpWSNAlVRAFvD3JLviW2wF/jZ6s=; b=xT+yupj9MavimR1wa5EZqEYTVTre9t7Il8BFvnEd4FOqKCV1obJEBkXayBjU4VTUpX EjG552aZP/iWzX7n5uCIBks2UnXw89KPGuPpFaGTfGBxeYUsPeDHCRpN2j7upHhRcoYp LKHDSdNN49TKwN3vrQQ3LH7oPAr3gSKkrpECRhZdCSuAfuNJxBkCyB4HSP+vs2T3balU /FH7pNPZ2YwlCJegT6qTrUN/oM2ejngS3tbIbVpgI0Y4EN1R+c5gIurEWJ+OMaofmHf4 Xrrez6/t4LlVxxsjlS3b8/S+W4A2pXlnJB+OuOGyM5adoBRjPyRVSYVu37lfQ1r3xGMk vtNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WegnVZ9DGyLW+kA2xpWSNAlVRAFvD3JLviW2wF/jZ6s=; b=Jfy7i5/iG6yfXVKzbRt2K07ci68WpVHy/ADPR4x6bzzLAG/la0AUETkkIys6/1fgcO 3yTQ8rMwMHeM8KBZI7ux6MzxcAuhOiD2jtg0tyuuXCVY2Zg/gg3VuwyuYXZ55BgIAqCa lXcErOKrZUwDoXzhU/UWtSmpZQfpVrpFLKox3G6OVaW17epi3FVu7l/7g4vzGUSDIVR9 ByGmOViy49bRB38FT+7UotdNwh7sPRxCIMf2z2990PhVlPdj6j/6tutK691IbL1lCHqi hUCs/CWMR9Iul80gSHfKCJXIRzajNUbODy64nuJ3dmjR2blrmtFSdU6Gt/CvYJ0y+RET DB7g== X-Gm-Message-State: AOAM530+6DChqUw3DEcgJW3LKwxxD4RL5Q8Jx8oBd6vp94L3LkwCvFvs eZxD0J4sQbaSDi/TtsQSaQrAYg== X-Google-Smtp-Source: ABdhPJyatwtDUIcCOL7ndILXzFNTrMtzJVDI0NWp8JnniRlD+OLzf4loG/6E3grgYnwIqqMACnTmYg== X-Received: by 2002:a1c:48:: with SMTP id 69mr51473365wma.32.1594042433108; Mon, 06 Jul 2020 06:33:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:52 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Juergen Stuber , David Glance , david , legousb-devel@lists.sourceforge.net Subject: [PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:16 +0100 Message-Id: <20200706133341.476881-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 8aca55c4c95f1..f922544056de4 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -271,7 +271,7 @@ static struct usb_driver tower_driver = { }; -/** +/* * lego_usb_tower_debug_data */ static inline void lego_usb_tower_debug_data(struct device *dev, From patchwork Mon Jul 6 13:33:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645779 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1DC4A13B6 for ; Mon, 6 Jul 2020 13:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0226F20771 for ; Mon, 6 Jul 2020 13:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vTKBeOy8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729287AbgGFNd6 (ORCPT ); Mon, 6 Jul 2020 09:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729276AbgGFNdz (ORCPT ); Mon, 6 Jul 2020 09:33:55 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8592EC061755 for ; Mon, 6 Jul 2020 06:33:55 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g75so39362997wme.5 for ; Mon, 06 Jul 2020 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P8CBq5D9tY/rIxd8Q9bScU/Lf3c39zfJPjGb95MJ1ho=; b=vTKBeOy8iUfSZmKMM4EVVOzgbmiCgEA6KMhIW9ctG3K+ahehKKx7a1sXbFvVZtjfS6 innuNalMpnrsqCB+v/QEOP7FDE8Ix5qjbmsU7xSdjpWQDRLoEvBKLlFRGs5HkWKupr5o F/sjXi24nPO0VtY4D2xhTt/xEQPYTXmWfpNum1ncVbzONuISe7B5N2oXZLn+/JAMhw5Z QO2Fo4cOg3XCdfDsBNaMPBVmVx+jBtFeW/lsaUdDr7JemyEnLj8QFk1YWkHg6Xu3O4lQ eq2usXfgODMDCtLx9nv9djz2KGH7YngG/1Y5dAF0iGn6+u6x99vRJjfYVKZCkXX4Zsir JK8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P8CBq5D9tY/rIxd8Q9bScU/Lf3c39zfJPjGb95MJ1ho=; b=cbY6o7sx2TVSv2fmmeoalqhC2GXvJlR4r3maLstSV1PzAwaeRcIPHY6S0FRUu/ujip qEJe4VZQ0OFqRLn5lcndhUVBLcO7UtnQxfJVt4VKIQ9r8uKNF8Ht53TmAYLXAnA3Q2Yt fWW7poZj0zjPNDpyrlKlUvDWZXp0hLUC/BDbjDgEK6cToOfR/tXN9Ui505qeM/5HDPcK qUcwiNQs4qI92DFct8CtsA5NZPe8v6tm40cMhU+6Ow0ry3sLfq6a97pb7P4zl5iQIbON liuvSF/CcR2cNb7R6VdTqR/TXu1swWICttWOZ86rLQRWa9Lp+LQY22Om7uYx1Oudwmzp ykpQ== X-Gm-Message-State: AOAM532bcDU7MmO9WFN+MDI9x3neW9VZKYWzlBNm/PMk45Hw69CVAgyg sr6ZrWgjpmKKRXcUntgwiuzgAlQNZUo= X-Google-Smtp-Source: ABdhPJwGkG53Re/6SkdDHQA3k1u5KCj1bTpxlVndoEvZves+WsU//tEO5Ud0kwzSsc+dh7IMKvG2EQ== X-Received: by 2002:a1c:2157:: with SMTP id h84mr48334366wmh.35.1594042434299; Mon, 06 Jul 2020 06:33:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:53 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Guenter Roeck , Heikki Krogerus , Hans de Goede Subject: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Date: Mon, 6 Jul 2020 14:33:17 +0100 Message-Id: <20200706133341.476881-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' last year. No need to keep it around. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = { | ^~~~~~~~~~~~~~~~ Cc: Guenter Roeck Cc: Heikki Krogerus Cc: Hans de Goede Signed-off-by: Lee Jones --- drivers/usb/typec/tcpm/tcpm.c | 51 ----------------------------------- 1 file changed, 51 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 82b19ebd7838e..d6913eb0ea54d 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -1503,57 +1503,6 @@ static int tcpm_validate_caps(struct tcpm_port *port, const u32 *pdo, return 0; } -static int tcpm_altmode_enter(struct typec_altmode *altmode, u32 *vdo) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - u32 header; - - mutex_lock(&port->lock); - header = VDO(altmode->svid, vdo ? 2 : 1, CMD_ENTER_MODE); - header |= VDO_OPOS(altmode->mode); - - tcpm_queue_vdm(port, header, vdo, vdo ? 1 : 0); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static int tcpm_altmode_exit(struct typec_altmode *altmode) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - u32 header; - - mutex_lock(&port->lock); - header = VDO(altmode->svid, 1, CMD_EXIT_MODE); - header |= VDO_OPOS(altmode->mode); - - tcpm_queue_vdm(port, header, NULL, 0); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static int tcpm_altmode_vdm(struct typec_altmode *altmode, - u32 header, const u32 *data, int count) -{ - struct tcpm_port *port = typec_altmode_get_drvdata(altmode); - - mutex_lock(&port->lock); - tcpm_queue_vdm(port, header, data, count - 1); - mod_delayed_work(port->wq, &port->vdm_state_machine, 0); - mutex_unlock(&port->lock); - - return 0; -} - -static const struct typec_altmode_ops tcpm_altmode_ops = { - .enter = tcpm_altmode_enter, - .exit = tcpm_altmode_exit, - .vdm = tcpm_altmode_vdm, -}; - /* * PD (data, control) command handling functions */ From patchwork Mon Jul 6 13:33:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645837 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1287C1709 for ; Mon, 6 Jul 2020 13:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96C02082E for ; Mon, 6 Jul 2020 13:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I8l3xiex" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbgGFNd6 (ORCPT ); Mon, 6 Jul 2020 09:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729280AbgGFNd5 (ORCPT ); Mon, 6 Jul 2020 09:33:57 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0FB1C061794 for ; Mon, 6 Jul 2020 06:33:56 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id l17so39372868wmj.0 for ; Mon, 06 Jul 2020 06:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ji1N62aOzIlUoLXMMPXkjOjy05RAsl1PzqHcrZ4EBKA=; b=I8l3xiexa/B1JIJEy1ir1PTxhlP/Lj9nM5zUnk6opUF/S6bgIchyQgbqNywo7zJNiU CoQXFx15q77CxSXe0ZRx0B6u3hwF7yxGPD7hJYpfn2bPzbIVajT32LzABpWqvW/U963W rUfVYKYz0ltiAGwB2k/N9DNXTj1wqtMBeV3wSCHJspqZ6qVlC/PJj7n8N2Tb7Ciy5Hs1 YD5+rf7z0Dd+Kbwx1fUXzNmr9b19aJ2JgHb6AopyQqJZZVptVhkZMnlql+lUz0ue0xbF 8kR979vuUk/grhSLXPoSlAHDyv5f75q8fcqNYTPokp9FBt6qc7wkfcTDvRW9v3MCYpNU OHKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ji1N62aOzIlUoLXMMPXkjOjy05RAsl1PzqHcrZ4EBKA=; b=OoAoaCstiaLKagXRNOMCorkaBTlPZdHs3rwBTMopCyoLw+NPziSrrybdv9xgeOpwMX f/m0aTZR2IaRdPuuVD3bZ7Km3FMeeEAjPr+MKagu2GTASxwyfqYl88x7SQBnTZJmbA54 nSrCF0UjQZiPDp0advBdMheDWbZwSGyw0hTWOTft6AkxsEeGILcGvLVnL209GtpcnIBi jiiMTLv3AyU8jceM7d0hI/BkOihoPMklXh80QaY3Pc6SVSRdwSb4gj0cfbLqyr8nVugr gN8KsyaR86R6Lfw8yOObfc/byOhtASV78ZSJlgQuBh/GOZ8no3znzDOY3gGhwNwuj80T d8fA== X-Gm-Message-State: AOAM530tljfWy4DpZbEGP3bj5JwEoMoTkypBEh2yE9sxPZyJ9dzvZcnm V5p6pWLdUADFXNA7dX5EYWUIrA== X-Google-Smtp-Source: ABdhPJzhwy+WhKHOCtml4H28kvQrBHwIYwg1EY7OKr3wVvJUBRZghnh3fq3dov0lUX5F0Rb16y1JmA== X-Received: by 2002:a1c:7306:: with SMTP id d6mr39593585wmb.113.1594042435462; Mon, 06 Jul 2020 06:33:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:54 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Cristian Birsan , Felipe Balbi , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches Subject: [PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' Date: Mon, 6 Jul 2020 14:33:18 +0100 Message-Id: <20200706133341.476881-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Commit e78355b577c4b ("usb: gadget: udc: atmel: Don't use DT to configure end point") pulled out all functionality dealing with 'pp'. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘atmel_udc_of_init’: drivers/usb/gadget/udc/atmel_usba_udc.c:2106:22: warning: variable ‘pp’ set but not used [-Wunused-but-set-variable] 2106 | struct device_node *pp; | ^~ Cc: Cristian Birsan Cc: Felipe Balbi Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index d69f61ff01819..a10b8d406e62b 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -2103,7 +2103,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, { struct device_node *np = pdev->dev.of_node; const struct of_device_id *match; - struct device_node *pp; int i, ret; struct usba_ep *eps, *ep; const struct usba_udc_config *udc_config; @@ -2128,7 +2127,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, GPIOD_IN); if (fifo_mode == 0) { - pp = NULL; udc->num_ep = udc_config->num_ep; udc->configured_ep = 1; } else { @@ -2144,7 +2142,6 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, INIT_LIST_HEAD(&eps[0].ep.ep_list); - pp = NULL; i = 0; while (i < udc->num_ep) { const struct usba_ep_config *ep_cfg = &udc_config->config[i]; From patchwork Mon Jul 6 13:33:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645833 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D3A5F1709 for ; Mon, 6 Jul 2020 13:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB1CC2082E for ; Mon, 6 Jul 2020 13:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="os0d0dx8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729569AbgGFNgH (ORCPT ); Mon, 6 Jul 2020 09:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729284AbgGFNd6 (ORCPT ); Mon, 6 Jul 2020 09:33:58 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 328F5C061794 for ; Mon, 6 Jul 2020 06:33:58 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f18so32880708wrs.0 for ; Mon, 06 Jul 2020 06:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n7/LG8QKfAsUZ5xCCuI2vnf7Sj+c5EJvPq+Icl9Ejy0=; b=os0d0dx8lY4PrV0VCx4VZCbRVDM3s7vVVnY/vA+18e1qU3P3/R/bJTVXFEoxZBax3b H1evzJuHhO3Vf9lGtD/CevHBEjo0+SNdxVktW9IoKWmB/6rtywuxMeCHzwvvtwgP0gZv iDOnInpllmtroWuWZ0seJrk6D1D3YOVkjFObAGw+RXxVOq6bTk9TABngguksuBbbeMSb E+fx0zxFxP07AGEaRcKKn+ANTY3M6cY1izjCqRv23X6tLJUCdKZ3+bll9J/WTLpLQIvX SNlAaXxAnaPkVju6B1V7ZJ03U6SKfOX+L1LAEHgGxR58QOar2re6Pj23qdjIRBLb/rre aXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n7/LG8QKfAsUZ5xCCuI2vnf7Sj+c5EJvPq+Icl9Ejy0=; b=kGV7R9cOf1UlCpK3I3ld7jBGzcQdgEpO7vtDFOKgkuEGlRzWX4Fmb4W6rW2uJXF7ey drRtM/fTCx9lqins2BjSGA/fGF+R5gnrJ9hPeZd1JuqknDCKa737kfKncHnrJxsaMzaz 2VY0m5mhpDbfi9YiAcfRKtww7/jD1bFumuRHUp54X7cqceK99VjIj0kSdsk394Yq9dAj 0tL6BO9iKrlJX3UkzpMaozYBOjJPfHETPHYbb4HcT1o7ciudNokMvozc+IDMKH5MaEIG cM5+LWRSeOPE+TskaY65LFete2Jj94s5KDdqNbNBWKVYZs+MA6Fr+MZV2dsQPdv6DPrX ZPLQ== X-Gm-Message-State: AOAM531/lOOZtL5p9ILeJJIPhYcUA7++qPkkdhMN2EGAYwvFI4XcGrkL lCQ3jCcbPY+4oH1KOb0smtv0+Q== X-Google-Smtp-Source: ABdhPJxDvbV0BLobErzaVbEqiNwKzRAQTJlQ4Ma/Du+Zq1WMwRCa/vj3m927hR86GBAms5PrHXR14w== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr45407084wrs.33.1594042436907; Mon, 06 Jul 2020 06:33:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:56 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Al Borchers Subject: [PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' Date: Mon, 6 Jul 2020 14:33:19 +0100 Message-Id: <20200706133341.476881-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks as though it's never been used. Driver was introduced in 2010. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/nokia.c:65:19: warning: ‘product_nokia’ defined but not used [-Wunused-const-variable=] 65 | static const char product_nokia[] = NOKIA_LONG_NAME; | ^~~~~~~~~~~~~ Cc: Felipe Balbi Cc: Al Borchers Signed-off-by: Lee Jones --- drivers/usb/gadget/legacy/nokia.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/nokia.c b/drivers/usb/gadget/legacy/nokia.c index 978c1a34a9320..2e15f9a32ce9f 100644 --- a/drivers/usb/gadget/legacy/nokia.c +++ b/drivers/usb/gadget/legacy/nokia.c @@ -62,7 +62,6 @@ FSG_MODULE_PARAMETERS(/* no prefix */, fsg_mod_data); #define STRING_DESCRIPTION_IDX USB_GADGET_FIRST_AVAIL_IDX static char manufacturer_nokia[] = "Nokia"; -static const char product_nokia[] = NOKIA_LONG_NAME; static const char description_nokia[] = "PC-Suite Configuration"; static struct usb_string strings_dev[] = { From patchwork Mon Jul 6 13:33:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645831 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B34992A for ; Mon, 6 Jul 2020 13:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 321132084C for ; Mon, 6 Jul 2020 13:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BpLIhIM9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729566AbgGFNgH (ORCPT ); Mon, 6 Jul 2020 09:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729289AbgGFNd7 (ORCPT ); Mon, 6 Jul 2020 09:33:59 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57B60C061755 for ; Mon, 6 Jul 2020 06:33:59 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id l17so39373034wmj.0 for ; Mon, 06 Jul 2020 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F3N+fzezv1MWYIkYTGHlx08nxeXYi/20m77vgS5T6os=; b=BpLIhIM9HO9QX/91QqPb0axOZ+f3MusDB+2c/VFHx/69xTyIJRCZQeP3ZiC1KHq3cQ MPMyfOETWx+kDYSAp2ES8FPPerVyUzUHVoDK4ZE3kx0lHJumW3So3ckLNKz1ZjU/aRgM 9UPBYbokmdIFpUzxdVL/M8Xe6mMwTbF2QrISRvdMpcpb/a4z6XCoUGhvmgYxiOia5lXw fF0G+NETlZp53qRczU0psHvtC9Do08Z+EKc5a0LRflRb6uiSioO1p6Oi7nnKQIyPsFsS iyd7IeCm1h4s1m2dHMRE4UnfHf2FurtJS8GyFbNTXVkCDhdfO9Xv5XIEDIGWp6x38Uyb stNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F3N+fzezv1MWYIkYTGHlx08nxeXYi/20m77vgS5T6os=; b=JHbuNJDIQRm/W1C4n+V7MakFVYfSBUxn72pQgrKun1O7rGVn2eLVaKoMdnVr1kageO MDQCcm/UjdqtQ5q4cROPhNVkxvt9hIHHey36b6ux0DwT2MR4SNA+Efp1hIoYImcYQnTu VWUe6gXmBmD9mX9fKM7UsP4X6Zgrh/5ZHvl7zKiA0i5vPBl7RG09z9vDfazuYb7UFFgn kJyr0W6/dgczYNRqy7jPwkDxcR1XmFKs84nERH1EiLrPlmQJ6dFg68mJVBeL4LgxGFs6 lptWVOOJa6XvS4PR/Fq2CYN1/rfs14sbtfFD96+OoY4l8zgWlvWg80MFBDWUTNe8Jgqe 6CBQ== X-Gm-Message-State: AOAM533JrDSRMbMATOp46iFW5TNzRGvXcTkjDdGptJw1nzMIIVzmaTtX sWNHQND/Ii66xo+bdPHzEVCWXg== X-Google-Smtp-Source: ABdhPJw84chABX+3T3NQgrsvaRU3aLogEgRaFQd3ljAQ8Bw2zi12v8ZyS4JXvweac2ZKGE4NngEQgA== X-Received: by 2002:a7b:c013:: with SMTP id c19mr48981840wmb.158.1594042438048; Mon, 06 Jul 2020 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:57 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , David Howells , Michal Nazarewicz Subject: [PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:20 +0100 Message-Id: <20200706133341.476881-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'type' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'h' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'data' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'len' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'priv' not described in '__ffs_data_do_os_desc' Cc: Felipe Balbi Cc: David Howells Cc: Michal Nazarewicz Signed-off-by: Lee Jones --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 490d353d5fdec..2d00ba0726453 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -2352,7 +2352,7 @@ static int __must_check ffs_do_os_descs(unsigned count, return _len - len; } -/** +/* * Validate contents of the buffer from userspace related to OS descriptors. */ static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, From patchwork Mon Jul 6 13:33:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645827 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 207C192A for ; Mon, 6 Jul 2020 13:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0587C2082E for ; Mon, 6 Jul 2020 13:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bn951av1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729561AbgGFNgB (ORCPT ); Mon, 6 Jul 2020 09:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729297AbgGFNeA (ORCPT ); Mon, 6 Jul 2020 09:34:00 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69239C061755 for ; Mon, 6 Jul 2020 06:34:00 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so42118614wmh.2 for ; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FTimBbBqnMIcQ4eF+VH5m9hye6WMpkC2MlXIy//Z9tM=; b=bn951av1tIBYht5lk9qvY08u0Jgt22BUCKc6vohyqII3OtrGaVeusFgOTPFhqV+i2k p06vfQqGi7JFF4w8LRU6xPFLkIdxuI9J0W8p4lHaQpIytn8kmIblmkWpEIO17UKu+gPf FXeWg/QFad9y2n/5Q8UzWgI3E11IBWoAiWlUX7yiymCFcvPQex79oxP8yohjP6Wsdjol SVkyuBtzjZ/SHYPWMfIDXcXPdKkuaWT6aAmYFvyBne/hm6iaMSsqC427PTvk+2Dq8+ki W7eZeeuLkAhkX4IudL6VGhPcZ6DO+hSxad4t9YaHQaSXU7OGASjpxkSL2XDydREO5DXp giBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FTimBbBqnMIcQ4eF+VH5m9hye6WMpkC2MlXIy//Z9tM=; b=KZ20z7Ug58gyTfqJDvbYXxQ6mQ+oMRDLvG5cVuYdIcCImktLRQICVie4GQHOZYdz9g j5Lwc0m8Opg0bAs0X829N33ZYGdRHpZa24OpY6fdmuBOVGbQX4+8BN7SnvfZhrHNaflV H8j/wJ6gRSRhze3FCzGWljWZc9Ji1YIdKmodh+IcfaSqLFNoZC/3pfodPj6DQnQfbY91 y3FSD74CMxshCZcNDbs3d7Q1C+jQfvI9B10y9m9F15B7wDk8fMbN1G6Aan4D9X0e/ooG vKvIZj5QP9w7bwaNLKjJ0r/2FA4SxCCs7Kxn89bl34cwGuIicHlYFz/mQAz3Y7EH53LY 3eIw== X-Gm-Message-State: AOAM53062RyxNkcKxkHjw+nBQ5S3IKcuEqmWDXVqDpO0d7rL1rmCwCJt xuhmi4rDmzXEc3CAc0Rf6jXUwg== X-Google-Smtp-Source: ABdhPJy2ORInauH49b7tohotkeMYtKjc4Phc6yZfNYXtKYgAdNWMLI138LZhx0E2XlgFikEOm95mpA== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr52128827wmg.118.1594042439124; Mon, 06 Jul 2020 06:33:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:58 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Vladimir Zapolskiy , Sylvain Lemieux , Kevin Wells , Roland Stigge Subject: [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions Date: Mon, 6 Jul 2020 14:33:21 +0100 Message-Id: <20200706133341.476881-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org These are not used outside of this sourcefile, so make them static. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/lpc32xx_udc.c:1929:6: warning: no previous prototype for ‘udc_send_in_zlp’ [-Wmissing-prototypes] 1929 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) | ^~~~~~~~~~~~~~~ drivers/usb/gadget/udc/lpc32xx_udc.c:1943:6: warning: no previous prototype for ‘udc_handle_eps’ [-Wmissing-prototypes] 1943 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) | ^~~~~~~~~~~~~~ Cc: Felipe Balbi Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Kevin Wells Cc: Roland Stigge Signed-off-by: Lee Jones Acked-by: Vladimir Zapolskiy --- drivers/usb/gadget/udc/lpc32xx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 465d0b7c6522a..4a112670cc6c4 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -1926,7 +1926,7 @@ static const struct usb_ep_ops lpc32xx_ep_ops = { }; /* Send a ZLP on a non-0 IN EP */ -void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { /* Clear EP status */ udc_clearep_getsts(udc, ep->hwep_num); @@ -1940,7 +1940,7 @@ void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) * This function will only be called when a delayed ZLP needs to be sent out * after a DMA transfer has filled both buffers. */ -void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { u32 epstatus; struct lpc32xx_request *req; From patchwork Mon Jul 6 13:33:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645823 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7616D13B6 for ; Mon, 6 Jul 2020 13:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59D5320775 for ; Mon, 6 Jul 2020 13:35:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OmZFfKsZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729538AbgGFNfs (ORCPT ); Mon, 6 Jul 2020 09:35:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729302AbgGFNeB (ORCPT ); Mon, 6 Jul 2020 09:34:01 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60021C061755 for ; Mon, 6 Jul 2020 06:34:01 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o2so42118722wmh.2 for ; Mon, 06 Jul 2020 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=OmZFfKsZE3nw2Rx7QazBJNlNeA+U8z1Z2PcNhcqjoK68z1sVetkUL2vJdCbMgfCx+z GQ5OdTbXa+xGGweQRAIjQY+yIMbO16Ik2oUI+cRDjkln/G96vTY+Sv3Hmg9wjeMj9Moe wjup2WRBceFy+RvHDn6sGC88K+miXgtBtFdiQiKW7ax7JwncaSGkDlPgFdll46+6/YiB c2Hvox1thv7IHBF2cFtkUXRSO0tVbQdaKgKzefw5AxbQcMOI86AnSy5xCXNu/8SdAEfj tMQN++j0iRkOEy/9hGk3KCKGViLlrFbGp+lhcUlgAE3JBu5bqpBfe9atSyQizMIJsTA+ txEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFhBoF9F+cplYOt0drBYrKvo/NCkeTyoUMk2XPNxJS4=; b=mTiS31Z0d69Bt5WZvVKcHcE5hi1ITgtO2GVSwv1y2TBNQOCNlIS4uD+Mkimy2U7Qck 8cbbSuEUrwlqbwQLvX0GNGu+AymWOPHeEZJYyZ0MKIyh7c0EuUMwv2cYa+E1hLHGPL2D H9dpRPkDxfmYIB6naOKqwDoITkfpkI/AZoppSp5ALOjQheassrlG7XmFl/A0M6TjwRuA ASN0kd6j/nOuSulc6v7b4aI7O7FXh4PyGsxNTbyyjdvClgkLbPbxBUCMFXqJTtgoKvLZ mKJDX+A0RGLQ3oqrOFroyEs+zHjcJMMAlrsJVjhBJDda2+QYPDJBg2O5ZKBYaCwkR1c+ uQZw== X-Gm-Message-State: AOAM533C/O/yAD24fpcMjZes6aL0gNZ71BG9qHJy0GJM3R+FUOCkWHpB S4oh5AJjPT4Mmx05tB9yFkKKZw== X-Google-Smtp-Source: ABdhPJzHeQs23/qyFcnX4TERiDrg/KCZCBqe16Wspkyc46J1cIxb5+c8wXVxLRMwjJxdzWxMdM1HWA== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416268wmh.121.1594042440115; Mon, 06 Jul 2020 06:34:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:59 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Yoshihiro Shimoda Subject: [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Date: Mon, 6 Jul 2020 14:33:22 +0100 Message-Id: <20200706133341.476881-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks like it's been this way since the driver's inception in 2007. Fixes the following W=1 kernel build warning(s): drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’: drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 478 | u16 tmp; | ^~~ Cc: Yoshihiro Shimoda Signed-off-by: Lee Jones --- drivers/usb/host/r8a66597-hcd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index 0c03ac6b02137..63719cdf6a4e6 100644 --- a/drivers/usb/host/r8a66597-hcd.c +++ b/drivers/usb/host/r8a66597-hcd.c @@ -475,16 +475,14 @@ static void pipe_stop(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) static void clear_all_buffer(struct r8a66597 *r8a66597, struct r8a66597_pipe *pipe) { - u16 tmp; - if (!pipe || pipe->info.pipenum == 0) return; pipe_stop(r8a66597, pipe); r8a66597_bset(r8a66597, ACLRM, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); - tmp = r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); + r8a66597_read(r8a66597, pipe->pipectr); r8a66597_bclr(r8a66597, ACLRM, pipe->pipectr); } From patchwork Mon Jul 6 13:33:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645819 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 212A31709 for ; Mon, 6 Jul 2020 13:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 081B820702 for ; Mon, 6 Jul 2020 13:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="d1ILBA/2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729314AbgGFNeF (ORCPT ); Mon, 6 Jul 2020 09:34:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729305AbgGFNeC (ORCPT ); Mon, 6 Jul 2020 09:34:02 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91BA7C061755 for ; Mon, 6 Jul 2020 06:34:02 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f18so32881053wrs.0 for ; Mon, 06 Jul 2020 06:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KCHAGi+yis7rT4RcJ1xkGNsqK+uVMhPXLaq/wOq2nXg=; b=d1ILBA/20Tq+wf0tqPOsJ+Q7ruJ9GVdOks6k+ffLS4tTGE0XaURNCIQ3lPi3D8MqNy 6bfpQGGIvvkd7dqLML2B/x3dDVz1X2KSrKeKImRiplCftwatlzk4iTY1bSQWuRoNS6CN n+d6tzIzTcqwW84lCy7LOKRcFOHHbSATtvadCsaCKyNI8wsUmOMuAtEzSoIoYXzf4TsO Pa25MqF0q1O3Onbn/OmoYNR44areZTUJ7E38CrsTHRAwH9fameB3YKH/n/EwJedUzvzp PiJOKFvVHKVlf5cdnE+5q7vJa6crbxjM7PG0iwmBGNtpdFRf+AbWmusFYIrj9TqmKxao h3pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KCHAGi+yis7rT4RcJ1xkGNsqK+uVMhPXLaq/wOq2nXg=; b=cpblXl8Pu1Htvqp1rsBfKrsw2b5PnrbWV0WTcru4D9Kh7B9uMl1L3LqPAu3+jnH+nd bdgH7FOZdyTSWT9FPYyuAyzmcqPHY5cl5HzwqwLKw7WKWRBOeo4rnbFQUSUu9hfu7VbV DGtzxZIzXMvQY5xR5OchDR80Wr18OA6gj/UyfYfNeJ2ag2ytCPO3QdjBm37vTA2Fk+ni F9iEW67v735eIVbGXJa7VvQAUlAA3exl51jAm5gQOd5Ti0tBW6+jYuMO2mycbqdU6m9c gyCY9fAIUyINmeatRzxO+rFv9BSIHBS2qxO6RyYAImah+27GX6p7iOvHrnBs+CUlgxbt 5Q9w== X-Gm-Message-State: AOAM532G0qOP7DvnLYMIaLOb0PKU4rHKfx0a9jmCh4EE2o4V3G5ghwID JRoX+kkwbUDYukDeSEFZS8c1Sw== X-Google-Smtp-Source: ABdhPJy2Eg3D1zjnU2FxioIxSHD9bWpgEVorUJ2S4pILADo+vEbjB7rEn1A92h/ru5KDKIiVhqYg/w== X-Received: by 2002:a5d:5706:: with SMTP id a6mr13466028wrv.328.1594042441319; Mon, 06 Jul 2020 06:34:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:00 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Chao Xie , Neil Zhang Subject: [PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' Date: Mon, 6 Jul 2020 14:33:23 +0100 Message-Id: <20200706133341.476881-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks as though it's never been used. Driver was introduced in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_udc_core.c:56:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 56 | static const char driver_desc[] = DRIVER_DESC; | ^~~~~~~~~~~ Cc: Felipe Balbi Cc: Chao Xie Cc: Neil Zhang Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/mv_udc_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 2384b55f9d3e8..0fb4ef464321d 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -53,7 +53,6 @@ static DECLARE_COMPLETION(release_done); static const char driver_name[] = "mv_udc"; -static const char driver_desc[] = DRIVER_DESC; static void nuke(struct mv_ep *ep, int status); static void stop_activity(struct mv_udc *udc, struct usb_gadget_driver *driver); From patchwork Mon Jul 6 13:33:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645825 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0FB4C1709 for ; Mon, 6 Jul 2020 13:36:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E718C20786 for ; Mon, 6 Jul 2020 13:35:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LmBVebwT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729532AbgGFNfs (ORCPT ); Mon, 6 Jul 2020 09:35:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbgGFNeE (ORCPT ); Mon, 6 Jul 2020 09:34:04 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD2E7C08C5E0 for ; Mon, 6 Jul 2020 06:34:03 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l17so39373340wmj.0 for ; Mon, 06 Jul 2020 06:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sSBmUEMtRAkmV+CU8DDs33V6Fj7L3lkyKFBYAuPbnWo=; b=LmBVebwTpb3hcf8Ha93SPa2Exe83aigE3ZaCUunazh7JTvq3EWJEWpqGePjMgFSTjb 48vX7pAPemaRg1gLv34mqX7sXrAi3nrEJ9sw6OthtRsStvw4ItfWxnkvnggDsy34E5w9 WqaT5ePM1xzwUTGIf+o6kze7UQ0iHA8TpdfyoA1ZsJFnmAtVIBK+7EYZrAfk4G5wpN3X DAZteStJ5xgL7d1H4sT7JSE2FDseqOLiRfTspauoOJoTD/bnthzve1DhYXa8UH4/DtPU ZUosrpWbfoqcwxEE3GUSHibRfFB/Wq9aZfcqyMgKtusOkeJUIQXfa9x+iX+fjUXlR0QD mQiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sSBmUEMtRAkmV+CU8DDs33V6Fj7L3lkyKFBYAuPbnWo=; b=rB4CXPBlcZrfQLsrqeX/ut6WXtch7L+JO/km2EngBUZdAHj1du8VjaJ6uVNjww+fgx F3frtFCsyvV0o9E0y2m5fS16F0YEud58AxKvLNqZV4NC+zDsshmRGZh0Up/k8s11bJtI lrJOgzzBME4NcRnAx5tubkHcJXPSzBLc9fum7OmOIYaQ0Sy73s7iECAryuisq4XfBI+p 39BWNZishE1Wy7XQ/c6qF1eSEa8SugZGmeDoOOGfDWTaxzirbEIVnWxcbm0H5xYVAaHD TxHbkaKy0dtdA/qQPGvUmzH4KE8xfViOzoh4NMpBgQUv+PAvR/QSAHRTpsI+i+db/VHs Ap/A== X-Gm-Message-State: AOAM532nqqG9+Stoc6nGrjUFPKciP0T/dcPNxyGQJ2JySSdIeQ0CxmXw By9st+rU/27X9GDYGFYli4fXng== X-Google-Smtp-Source: ABdhPJwZleEIJJnG0EATdvDaGTM4S+5gihL8GAeq5hVd5bhEGIlxo/v6c7sPofOnyiwJwZX1XOuX0g== X-Received: by 2002:a1c:e914:: with SMTP id q20mr47371295wmc.145.1594042442456; Mon, 06 Jul 2020 06:34:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:01 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Chuhong Yuan , LAPIS Semiconductor Subject: [PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues Date: Mon, 6 Jul 2020 14:33:24 +0100 Message-Id: <20200706133341.476881-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Ranging from missing descriptions and formatting mishaps to over-documenting of missing arguments, likely due to bitrot. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pch_udc.c:239: warning: Function parameter or member 'request' not described in 'pch_udc_stp_dma_desc' drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_fall' not described in 'pch_vbus_gpio_data' drivers/usb/gadget/udc/pch_udc.c:315: warning: Function parameter or member 'irq_work_rise' not described in 'pch_vbus_gpio_data' drivers/usb/gadget/udc/pch_udc.c:482: warning: Function parameter or member 'ep' not described in 'pch_udc_write_csr' drivers/usb/gadget/udc/pch_udc.c:482: warning: Excess function parameter 'addr' description in 'pch_udc_write_csr' drivers/usb/gadget/udc/pch_udc.c:498: warning: Function parameter or member 'ep' not described in 'pch_udc_read_csr' drivers/usb/gadget/udc/pch_udc.c:498: warning: Excess function parameter 'addr' description in 'pch_udc_read_csr' drivers/usb/gadget/udc/pch_udc.c:662: warning: Function parameter or member 'ep_in' not described in 'pch_udc_ep_set_bufsz' drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:977: warning: Function parameter or member 'cfg' not described in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:977: warning: Excess function parameter 'regs' description in 'pch_udc_ep_enable' drivers/usb/gadget/udc/pch_udc.c:1010: warning: Function parameter or member 'ep' not described in 'pch_udc_ep_disable' drivers/usb/gadget/udc/pch_udc.c:1010: warning: Excess function parameter 'regs' description in 'pch_udc_ep_disable' drivers/usb/gadget/udc/pch_udc.c:1030: warning: Function parameter or member 'ep' not described in 'pch_udc_wait_ep_stall' drivers/usb/gadget/udc/pch_udc.c:1030: warning: Excess function parameter 'dev' description in 'pch_udc_wait_ep_stall' drivers/usb/gadget/udc/pch_udc.c:1341: warning: Function parameter or member 'data' not described in 'pch_vbus_gpio_irq' drivers/usb/gadget/udc/pch_udc.c:1341: warning: Excess function parameter 'dev' description in 'pch_vbus_gpio_irq' drivers/usb/gadget/udc/pch_udc.c:1365: warning: Function parameter or member 'vbus_gpio_port' not described in 'pch_vbus_gpio_init' drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'dev' not described in 'pch_udc_free_dma_chain' drivers/usb/gadget/udc/pch_udc.c:1510: warning: Function parameter or member 'req' not described in 'pch_udc_free_dma_chain' drivers/usb/gadget/udc/pch_udc.c:1717: warning: Function parameter or member 'usbep' not described in 'pch_udc_pcd_ep_disable' drivers/usb/gadget/udc/pch_udc.c:2006: warning: Excess function parameter 'halt' description in 'pch_udc_pcd_set_wedge' drivers/usb/gadget/udc/pch_udc.c:2756: warning: Function parameter or member 'pdev' not described in 'pch_udc_isr' drivers/usb/gadget/udc/pch_udc.c:2756: warning: Excess function parameter 'dev' description in 'pch_udc_isr' drivers/usb/gadget/udc/pch_udc.c:2906: warning: Function parameter or member 'dev' not described in 'init_dma_pools' drivers/usb/gadget/udc/pch_udc.c:2906: warning: Excess function parameter 'pdev' description in 'init_dma_pools' Cc: Felipe Balbi Cc: Chuhong Yuan Cc: LAPIS Semiconductor Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/pch_udc.c | 36 ++++++++++++++++---------------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index 3344fb8c41811..8afc31d94b0e4 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -229,8 +229,7 @@ struct pch_udc_data_dma_desc { * for control data * @status: Status * @reserved: Reserved - * @data12: First setup word - * @data34: Second setup word + * @request: Control Request */ struct pch_udc_stp_dma_desc { u32 status; @@ -304,8 +303,8 @@ struct pch_udc_ep { * for detecting VBUS * @port: gpio port number * @intr: gpio interrupt number - * @irq_work_fall Structure for WorkQueue - * @irq_work_rise Structure for WorkQueue + * @irq_work_fall: Structure for WorkQueue + * @irq_work_rise: Structure for WorkQueue */ struct pch_vbus_gpio_data { int port; @@ -475,7 +474,7 @@ static void pch_udc_csr_busy(struct pch_udc_dev *dev) * pch_udc_write_csr() - Write the command and status registers. * @dev: Reference to pch_udc_dev structure * @val: value to be written to CSR register - * @addr: address of CSR register + * @ep: end-point number */ static void pch_udc_write_csr(struct pch_udc_dev *dev, unsigned long val, unsigned int ep) @@ -490,7 +489,7 @@ static void pch_udc_write_csr(struct pch_udc_dev *dev, unsigned long val, /** * pch_udc_read_csr() - Read the command and status registers. * @dev: Reference to pch_udc_dev structure - * @addr: address of CSR register + * @ep: end-point number * * Return codes: content of CSR register */ @@ -656,6 +655,7 @@ static inline void pch_udc_ep_set_trfr_type(struct pch_udc_ep *ep, * pch_udc_ep_set_bufsz() - Set the maximum packet size for the endpoint * @ep: Reference to structure of type pch_udc_ep_regs * @buf_size: The buffer word size + * @ep_in: EP is IN */ static void pch_udc_ep_set_bufsz(struct pch_udc_ep *ep, u32 buf_size, u32 ep_in) @@ -968,7 +968,8 @@ static void pch_udc_ep_fifo_flush(struct pch_udc_ep *ep, int dir) /** * pch_udc_ep_enable() - This api enables endpoint - * @regs: Reference to structure pch_udc_ep_regs + * @ep: reference to structure of type pch_udc_ep_regs + * @cfg: current configuration information * @desc: endpoint descriptor */ static void pch_udc_ep_enable(struct pch_udc_ep *ep, @@ -1004,7 +1005,7 @@ static void pch_udc_ep_enable(struct pch_udc_ep *ep, /** * pch_udc_ep_disable() - This api disables endpoint - * @regs: Reference to structure pch_udc_ep_regs + * @ep: reference to structure of type pch_udc_ep_regs */ static void pch_udc_ep_disable(struct pch_udc_ep *ep) { @@ -1024,7 +1025,7 @@ static void pch_udc_ep_disable(struct pch_udc_ep *ep) /** * pch_udc_wait_ep_stall() - Wait EP stall. - * @dev: Reference to pch_udc_dev structure + * @ep: reference to structure of type pch_udc_ep_regs */ static void pch_udc_wait_ep_stall(struct pch_udc_ep *ep) { @@ -1331,7 +1332,7 @@ static void pch_vbus_gpio_work_rise(struct work_struct *irq_work) /** * pch_vbus_gpio_irq() - IRQ handler for GPIO interrupt for changing VBUS * @irq: Interrupt request number - * @dev: Reference to the device structure + * @data: Reference to the device structure * * Return codes: * 0: Success @@ -1354,8 +1355,8 @@ static irqreturn_t pch_vbus_gpio_irq(int irq, void *data) /** * pch_vbus_gpio_init() - This API initializes GPIO port detecting VBUS. - * @dev: Reference to the driver structure - * @vbus_gpio Number of GPIO port to detect gpio + * @dev: Reference to the driver structure + * @vbus_gpio_port: Number of GPIO port to detect gpio * * Return codes: * 0: Success @@ -1499,8 +1500,8 @@ static void empty_req_queue(struct pch_udc_ep *ep) /** * pch_udc_free_dma_chain() - This function frees the DMA chain created * for the request - * @dev Reference to the driver structure - * @req Reference to the request to be freed + * @dev: Reference to the driver structure + * @req: Reference to the request to be freed * * Return codes: * 0: Success @@ -1707,7 +1708,7 @@ static int pch_udc_pcd_ep_enable(struct usb_ep *usbep, /** * pch_udc_pcd_ep_disable() - This API disables endpoint and is called * from gadget driver - * @usbep Reference to the USB endpoint structure + * @usbep: Reference to the USB endpoint structure * * Return codes: * 0: Success @@ -1996,7 +1997,6 @@ static int pch_udc_pcd_set_halt(struct usb_ep *usbep, int halt) * pch_udc_pcd_set_wedge() - This function Sets or clear the endpoint * halt feature * @usbep: Reference to the USB endpoint structure - * @halt: Specifies whether to set or clear the feature * * Return codes: * 0: Success @@ -2750,7 +2750,7 @@ static void pch_udc_dev_isr(struct pch_udc_dev *dev, u32 dev_intr) /** * pch_udc_isr() - This function handles interrupts from the PCH USB Device * @irq: Interrupt request number - * @dev: Reference to the device structure + * @pdev: Reference to the device structure */ static irqreturn_t pch_udc_isr(int irq, void *pdev) { @@ -2900,7 +2900,7 @@ static int pch_udc_pcd_init(struct pch_udc_dev *dev) /** * init_dma_pools() - create dma pools during initialization - * @pdev: reference to struct pci_dev + * @dev: reference to struct pci_dev */ static int init_dma_pools(struct pch_udc_dev *dev) { From patchwork Mon Jul 6 13:33:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645815 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4CD5392A for ; Mon, 6 Jul 2020 13:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34C8320702 for ; Mon, 6 Jul 2020 13:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n9EIrN7G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729321AbgGFNeG (ORCPT ); Mon, 6 Jul 2020 09:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729274AbgGFNeF (ORCPT ); Mon, 6 Jul 2020 09:34:05 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE7E2C061755 for ; Mon, 6 Jul 2020 06:34:04 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s10so40899447wrw.12 for ; Mon, 06 Jul 2020 06:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GNre9OCmAxyss+/an4xQhs3AGuEV6paz8+9ZDHvC1J4=; b=n9EIrN7G3akIgWOBqzyERxZhfzrR9fJGgAr0I5uOS7PMKd2/If2vceE3yjXA1b/eZZ qN3X40tIDqUzGlEgMn0NMHgN6bPz+FRCzIjbeU5YntfppHpfycT/2OcjyBD9MbXMHH02 OAP80qDZ/zvXp0E2Jnb7TOliZnTx2ngHJYqDWJHlo/tMh8+1qQfVZkuz2a58o08kRx4M zF3huI5CGRipEwA6l9h/nCGNATepgZn8qDH7q91rmF3uOAt3E5xdsJAmRFnaRysZtFNy ShO/sIOYPlLSWlNUwKcP5X+GpzdLohe7Jl5tgxA/WU0feCd8kmHyPcohnDu2G/JQnpLS 2TVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GNre9OCmAxyss+/an4xQhs3AGuEV6paz8+9ZDHvC1J4=; b=A0k2wp6WZgSE4fhTjhbJop/fdETcQKrH2AUDmydcRImYygoKZ24ZvAh4Cxuq4TVG+H vL0hRl3WtRQEa1xOzElTfO9m4ULByiLb7iuk0G5S+aIBnX+EH+Z9/mlw9eFqNAHW3gKu 6eBU2+I11rPd2GzHXjS23CZQWDCgskCzwoH7k/hqaZD2xs/keEtbnukY5UoEat702Xes aaj5i6n3ecruwCLgaDXweNUFpPsVag3OzLTGZ7y18X1g3bpLAN3wTuDT2EjhI+ahhjyh zPktw51IVEUpTKQbAX595hrk9njLXGak9mwwjXkS8Qp8k5laK9wM+tsZUNirC5b47RsX zvYA== X-Gm-Message-State: AOAM531MkxY6JB3BdBXPhezC2f2sqIewsYR3G3hDGHX1OWKbA+n1yBk7 t+yWx3kJm3DanxxAT8ijLIw45g== X-Google-Smtp-Source: ABdhPJx5Dq5C1EhkZdMxsgfApXgr0cOIhDoivpkexRKYjAKcjnC2QN2Yq3ue3sIKyjTLwO40wsMNQg== X-Received: by 2002:adf:e74e:: with SMTP id c14mr51614270wrn.143.1594042443610; Mon, 06 Jul 2020 06:34:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:03 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Stephen Boyd , Jay Monkman Subject: [PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc Date: Mon, 6 Jul 2020 14:33:25 +0100 Message-Id: <20200706133341.476881-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'imx21' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'dmem_offset' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'src' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'count' not described in 'copy_to_dmem' Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Stephen Boyd Cc: Jay Monkman Signed-off-by: Lee Jones --- drivers/usb/host/imx21-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/imx21-hcd.c b/drivers/usb/host/imx21-hcd.c index 5835f99662046..b2716cb724719 100644 --- a/drivers/usb/host/imx21-hcd.c +++ b/drivers/usb/host/imx21-hcd.c @@ -224,7 +224,7 @@ static void setup_etd_dword0(struct imx21 *imx21, ((u32) maxpacket << DW0_MAXPKTSIZ)); } -/** +/* * Copy buffer to data controller data memory. * We cannot use memcpy_toio() because the hardware requires 32bit writes */ From patchwork Mon Jul 6 13:33:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645811 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F01514B7 for ; Mon, 6 Jul 2020 13:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 158E4206F5 for ; Mon, 6 Jul 2020 13:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fczPaGVo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729199AbgGFNeI (ORCPT ); Mon, 6 Jul 2020 09:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729318AbgGFNeG (ORCPT ); Mon, 6 Jul 2020 09:34:06 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59347C061755 for ; Mon, 6 Jul 2020 06:34:06 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id w3so29667701wmi.4 for ; Mon, 06 Jul 2020 06:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2XV6WS/bjGR5kvGNxTMlo6KlRGNUtCcJKS3bvPtDJNg=; b=fczPaGVofLQoIlvYv0yf39Kkx0ejpT8IQpmzlyEiDrJUrZ/MVqPYhOAJMwVAKoB1ZU 6J89HvSTdqwH4sVQ9ehrAlrY3rUMG4ReE6aDw3yaZbWeVDRbwD2ZN/LGf5R7IYcwl16l pUjsgPJLFd9N9yyj+ewLUNlIVcCseEtDtuxb+wQFF8GdHXhG4QBEmkxfd/G1ipCvMoRm jh5DxCSHMunlB+DcdKO4cvt+K41fR+0zlKIzEj8el/peWXv+2bbw3u3V69lc+c9I2loI xLGaaq388tf6iFV/oZSWojK8abf0KikizWybxZt7Q1cMFodxZXt0vZUlLJkj3kNY/f/5 TaaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2XV6WS/bjGR5kvGNxTMlo6KlRGNUtCcJKS3bvPtDJNg=; b=Id4WmpVA+GfeWAom+lzyApygMBfMFNuFyNGL7JhuI4fu64AOpi80l0aWXeSUMloB3j rbl5kjYFjvxPjjx550kx0XQRJjkulmbFyOxOMXT64ZOFG09N3+pbStiFVoH1WZShdkLQ e1VXUtuxLOH5XuKEQwPvVntcSsTgbNxpSgDBmL+urIQQzmvRhFL+HZQzxMM1FGLbHVun bNjAL3FzrxPh+RYSEapxS26ZIy3AnRVAsExyunuvZQ/Fcg7onqzTXGDQ6O92yK0tt/NU aX1Y3k01ZT6W2I4wntPobNN8hVw+7FDgVJWPMhYCWl+x3c4i/8r09O8wmzWUrT1SNUOD apmQ== X-Gm-Message-State: AOAM533GKD1Q+nlLuBEbuXspsQing8QuBs7DQdpg0GB4vz/KHKPEZ69L d9bPRq3cr1M2StDZVo2NVtoCKg== X-Google-Smtp-Source: ABdhPJzh1m0Q8D26lQhCsRUAqNMwqePsc1dSEF5Rz1dklZVY+dBtULcNL8uqxOmLNNODWphQLHWsxg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112164wma.4.1594042445108; Mon, 06 Jul 2020 06:34:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:04 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Randy Vinson , Dave Liu , Jerry Huang , Anton Vorontsov Subject: [PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument Date: Mon, 6 Jul 2020 14:33:26 +0100 Message-Id: <20200706133341.476881-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-fsl.c:694: warning: Function parameter or member 'pdev' not described in 'fsl_ehci_drv_remove' drivers/usb/host/ehci-fsl.c:694: warning: Excess function parameter 'dev' description in 'fsl_ehci_drv_remove' Cc: Alan Stern Cc: Randy Vinson Cc: Dave Liu Cc: Jerry Huang Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/ehci-fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 9e9c232e896fa..1ebe4d425277d 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -683,7 +683,7 @@ static const struct ehci_driver_overrides ehci_fsl_overrides __initconst = { /** * fsl_ehci_drv_remove - shutdown processing for FSL-based HCDs - * @dev: USB Host Controller being removed + * @pdev: USB Host Controller being removed * Context: !in_interrupt() * * Reverses the effect of usb_hcd_fsl_probe(). From patchwork Mon Jul 6 13:33:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645813 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 792231709 for ; Mon, 6 Jul 2020 13:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6143720702 for ; Mon, 6 Jul 2020 13:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X6m4FfX9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbgGFNfb (ORCPT ); Mon, 6 Jul 2020 09:35:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729326AbgGFNeH (ORCPT ); Mon, 6 Jul 2020 09:34:07 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 769F9C061794 for ; Mon, 6 Jul 2020 06:34:07 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f139so42144418wmf.5 for ; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9AX8kUBEDyEZkkrAQRSTc56qB4suyJ5w028cqL1Y9nI=; b=X6m4FfX9HVkIRr8hUC5SaedwmejM6tHKMtWNuYYdOU9/56+ZZC56eTIFTX8DjtS4ei zSEhErkoaN6DfMdi+KsFgHeCmraKSYyUDTDBvwE/NCDhuOL2MzmazL5R1kxb0lRkL57E 0VCH1foQu1eLxq00OzM0aq/zolR4GeCqxx9kPmH0iG1YSvxUN+IFUnR+g7vO2/B1H963 +qy2O46U+JBmheOcj0HsXB/yrv+qOhS2qFnevyOLLYNtUuzADE+5fNDvPnKj35lP87aG DkkfR99J7Nsi0YY/wEHEgayT1PyA0037NW+/sIVocVBF9dVaHhoNijkk9NzyIV3eTstA gKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9AX8kUBEDyEZkkrAQRSTc56qB4suyJ5w028cqL1Y9nI=; b=ssk/rfi3ZdqjI05RaA6rvsfoS0MI9QgJbterBP5UoAD+zMdnPVksavRwu1WhFkSE7T MWXjhGwA/AHraUaV9gqePbRGJJ16yTL1XKpxFBadHjcCr6MX+kx0lnJfLmhjH7Rr/maZ PPlTJ1yotRzHjOhcoPqCuuGygxb7zV57DhjiTi00S5b6jCdLqLE7cUywNw4UGBmrOovZ Xss5FeVjY3F9nn4mhLm3cDzi64IsT/G4+i9DzQhCns9xlk/wD/lxeNoIcTVKzvHdoy0w oqvQfy3KFA8SLLJBGaFtIsNLGF8r6OOFx4TIFfH4jYt5EotNYn+Z/o/jzfrht3MM8o/4 fnMA== X-Gm-Message-State: AOAM532xGTlUJfZVh2QVqbufXfyxux4HMq2CMEAHrCQqnOpABoUVq4Pf OPZwaH5oxJcNVdZb7KJ0+J3rMA== X-Google-Smtp-Source: ABdhPJy/vW4eBdtZFwh7RKJcvlKpAd8CeAoqiMJQAacobWRvOb+MQ1KwteySTGzaqMrxvN2XhuOPgg== X-Received: by 2002:a1c:7306:: with SMTP id d6mr39594381wmb.113.1594042446244; Mon, 06 Jul 2020 06:34:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:05 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Yuan-Hsin Chen , Feng-Hsin Chiang , Po-Yu Chuang Subject: [PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params' Date: Mon, 6 Jul 2020 14:33:27 +0100 Message-Id: <20200706133341.476881-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The result is actually read into fotg210->caps->hcc_params. No need to popuate an unused varible with the unchecked return value from fotg210_readl(). Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’: drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable] 5013 | u32 hcc_params; | ^~~~~~~~~~ Cc: Yuan-Hsin Chen Cc: Feng-Hsin Chiang Cc: Po-Yu Chuang Signed-off-by: Lee Jones --- drivers/usb/host/fotg210-hcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index f967adf2d8dfc..51dbbb0e768bc 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -5010,7 +5010,6 @@ static int fotg210_run(struct usb_hcd *hcd) { struct fotg210_hcd *fotg210 = hcd_to_fotg210(hcd); u32 temp; - u32 hcc_params; hcd->uses_new_polling = 1; @@ -5033,7 +5032,7 @@ static int fotg210_run(struct usb_hcd *hcd) * Scsi_Host.highmem_io, and so forth. It's readonly to all * host side drivers though. */ - hcc_params = fotg210_readl(fotg210, &fotg210->caps->hcc_params); + fotg210_readl(fotg210, &fotg210->caps->hcc_params); /* * Philips, Intel, and maybe others need CMD_RUN before the From patchwork Mon Jul 6 13:33:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645781 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7623C13B6 for ; Mon, 6 Jul 2020 13:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BCEF20773 for ; Mon, 6 Jul 2020 13:34:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWvdvBnN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729338AbgGFNeK (ORCPT ); Mon, 6 Jul 2020 09:34:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729329AbgGFNeJ (ORCPT ); Mon, 6 Jul 2020 09:34:09 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABFD0C08C5E0 for ; Mon, 6 Jul 2020 06:34:08 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so39377323wmg.1 for ; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=zWvdvBnN7uGI3YJYG8xAKLYiRJh1mm0+0r6YAQ/ht+c+2n5/aaoZ24CrC6+hTOq75q UZgksZ/ftaNvfFjflqPGT6LMkwCqQ9dhF/YRFHAvqu+DdxqoYp7Ex3s1nB1x0kw/i8Wy 2EWBhwE38eGBFN2TO5wcJ4Q22ru3uU3QZ8WgSOUDl0W5yggF2tD93sA22eOBatapWahz hIdy7n8K4yNPhE7VlJWZ1XdjDn1HYu1O7Ot1DZPO9MIdEvoyXtF65q5zuvF5LY1rfRHI zO4HmtSixQQmvk/yfC0Oeo3PAQMsM6lPTWYiYiuQvARvCD45XF9IVh8ATkXIOd6W0kfn nG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d5p91PYLOlGL5eAhTI+TgOkI4utTlM6UStiViuCSA4I=; b=V5PXigHN7QhIb+gTJ+FkiolrChckXSCG2fHzDjnNOTvj0dMyiufp9CmJl7CovghoXE d1jTME/qEC4fTZAor/OZrE6/tf5Fl/Xj7VI6l7vE0A8HCi+TiLT93SdaN+0C8Y2Zw9Lz S/VUFYGqvWwjnBt1QxNTBW++vMNgRIIP3GQvdfE43q6y7lIjYTtgDSMOfsjZajttvxF9 LUNrKZoTcncz0WuGsyjUHT3L9u/5R3IhsKzVsNn7oI4Su9YemzotEKNhjays5pT3yt/r Sz485yMjRbjHLCBnOcEughJt9pyw1koVb81pTvssKwfi/LsfOJLi1cTSSJJdWhJJsfuw /d7g== X-Gm-Message-State: AOAM532C3/15DEAVhL/Xv+keMZPEo3DDq5O0mJ5lWim7z228AeqgdySf pdiJiUn8u0exsUFatUU8TPdSdQ== X-Google-Smtp-Source: ABdhPJweO4LHH0YuesEFBL8qRBzNi8brrKp2TuduBLyEDI7/Vj9+MgTEjdpThiWYval39YIjbESx5Q== X-Received: by 2002:a1c:8117:: with SMTP id c23mr47262716wmd.157.1594042447424; Mon, 06 Jul 2020 06:34:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:06 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Bryan Wu Subject: [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:28 +0100 Message-Id: <20200706133341.476881-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set' drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback' drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev' drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup' drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup' Cc: Felipe Balbi Cc: Bryan Wu Signed-off-by: Lee Jones --- drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c index 5393e5c37a4ba..60ae8b2d3f6a2 100644 --- a/drivers/usb/gadget/function/u_uac1_legacy.c +++ b/drivers/usb/gadget/function/u_uac1_legacy.c @@ -23,7 +23,7 @@ /*-------------------------------------------------------------------------*/ -/** +/* * Some ALSA internal helper functions */ static int snd_interval_refine_set(struct snd_interval *i, unsigned int val) @@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params, } /*-------------------------------------------------------------------------*/ -/** +/* * Set default hardware params */ static int playback_default_hw_params(struct gaudio_snd_dev *snd) @@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd) return 0; } -/** +/* * Playback audio buffer data by ALSA PCM device */ size_t u_audio_playback(struct gaudio *card, void *buf, size_t count) @@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card) return card->playback.rate; } -/** +/* * Open ALSA PCM and control device files * Initial the PCM or control device */ @@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card) return 0; } -/** +/* * Close ALSA PCM and control device files */ static int gaudio_close_snd_dev(struct gaudio *gau) @@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau) return 0; } -/** +/* * gaudio_setup - setup ALSA interface and preparing for USB transfer * * This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using. @@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card) } -/** +/* * gaudio_cleanup - remove ALSA device interface * * This is called to free all resources allocated by @gaudio_setup(). From patchwork Mon Jul 6 13:33:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645807 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3035714B7 for ; Mon, 6 Jul 2020 13:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17248206F5 for ; Mon, 6 Jul 2020 13:35:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w6hRYUO7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729341AbgGFNeL (ORCPT ); Mon, 6 Jul 2020 09:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729336AbgGFNeK (ORCPT ); Mon, 6 Jul 2020 09:34:10 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D10BBC061794 for ; Mon, 6 Jul 2020 06:34:09 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 17so42074031wmo.1 for ; Mon, 06 Jul 2020 06:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=atQQd6B48grrwp+3FZv95LUICx56wwJRa1SpQXxMQxY=; b=w6hRYUO7YyVcZnrxkVQcL9i+DIcegwSxOpJpusHM7ek+/DIU5QwFI/PAYc6YFHkaCT k8FRF534bpubL0B0OmFF5oq6wY03Rw6yEomh35Tmx6FPDE/waGSczpU5Cgzrn5Uju7Cc bCaXLGQifZRD/R4nbrn64owZsuCBcCb1EC0ImDhAGAXd/cc+WlULEQCijrABf+IpaKDT 3EKntJe03seySO6FPX3ZDocV61TFxZ1D1a4x8qhefwdg2zdjfgFY86PiagDVLamwPJy8 Cryz85XcxwCCMuv2nwLw+AXH9YXajlbSNY8nVxl/zMp1+gxb+292tL9mvtsS+CABRwnw YPYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=atQQd6B48grrwp+3FZv95LUICx56wwJRa1SpQXxMQxY=; b=XeDxVn4Jxf40Yo2IaX/7zmE9EBPTT1GY4vXIrwYXHptikC6GB4bx6bNgxAUzEU6Vje +Uq7pwyjAn+xTTW+EIFVSVcz0QHllixRE0sFGrksU/EgDia+0uOHJLgw2DYnK5CpLNps 803XM4TiH8jXt57/GJGCcgXY1dEHrPIW4S+KmAjVb1r07RPwt3wRIRqdOVzvvj/Zu/dR Y5M9xKh9kKcgXzsxFVPFI6ZoaOTz+PtGkUqK0+Vm0zBgorfG/LxJA5Vh2qHakxV6BlyY EoYQZkFaW9Q6b1uKSWgeYtX6x6IotE29wBLT5oKbahV9L+65QzLwsm5XmInNkXy7skDB QtWg== X-Gm-Message-State: AOAM533bzH6alN79gsfaQBb7GRa34RA28KIdKwbOmzdps4CvVvif6rno DHPHn9A8zNsTFPCGGcyELjRnjA== X-Google-Smtp-Source: ABdhPJwn3KSyjv54N4scU2QXm9bSuHZxzD4jVab9Us5MgbW3y2o+Nt2CodWPVpAjqv1powTZgDaF9Q== X-Received: by 2002:a1c:ed0b:: with SMTP id l11mr2416931wmh.121.1594042448527; Mon, 06 Jul 2020 06:34:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:07 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Chuhong Yuan , Hauke Mehrtens , Felix Fietkau , Michael Buesch Subject: [PATCH 20/32] usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:29 +0100 Message-Id: <20200706133341.476881-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/bcma-hcd.c:180: warning: Function parameter or member 'usb_dev' not described in 'bcma_hcd_usb20_old_arm_init' drivers/usb/host/bcma-hcd.c:268: warning: Function parameter or member 'bcma_hcd' not described in 'bcma_hcd_usb20_ns_init' Cc: Chuhong Yuan Cc: Hauke Mehrtens Cc: Felix Fietkau Cc: Michael Buesch Signed-off-by: Lee Jones --- drivers/usb/host/bcma-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/bcma-hcd.c b/drivers/usb/host/bcma-hcd.c index 652fa29beb273..b1b777f33521e 100644 --- a/drivers/usb/host/bcma-hcd.c +++ b/drivers/usb/host/bcma-hcd.c @@ -168,7 +168,7 @@ static void bcma_hcd_init_chip_mips(struct bcma_device *dev) } } -/** +/* * bcma_hcd_usb20_old_arm_init - Initialize old USB 2.0 controller on ARM * * Old USB 2.0 core is identified as BCMA_CORE_USB20_HOST and was introduced @@ -261,7 +261,7 @@ static void bcma_hcd_usb20_ns_init_hc(struct bcma_device *dev) usleep_range(1000, 2000); } -/** +/* * bcma_hcd_usb20_ns_init - Initialize Northstar USB 2.0 controller */ static int bcma_hcd_usb20_ns_init(struct bcma_hcd_device *bcma_hcd) From patchwork Mon Jul 6 13:33:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645809 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D181913B6 for ; Mon, 6 Jul 2020 13:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B722220874 for ; Mon, 6 Jul 2020 13:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nrBdfUXO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729489AbgGFNfT (ORCPT ); Mon, 6 Jul 2020 09:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729343AbgGFNeL (ORCPT ); Mon, 6 Jul 2020 09:34:11 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084EBC061794 for ; Mon, 6 Jul 2020 06:34:11 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g10so15697626wmc.1 for ; Mon, 06 Jul 2020 06:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oDXPXE1ejSNiTZPmJzCEijdYryKHjxn03JTJMf6IP7Q=; b=nrBdfUXO6LY8W3UqebH3OTR13trp34J0vuEI51RUElQ285ST0V0W0G2+PO4jsv+hxc iLQUwUgSA6VUbu9JTOnHYL/gAiz0ajtk6cAXF8AMBAsmzGLH6OCX7lVStmeEtWmNOokn aqQKVBO/ffzZ9ykuNxvhdS86TyGMm4i/2UFi+wW2xNk4ccagDL0o1j90UxuPFljjkjfI ZvywJxRPhH6jSNIidaJ1ghg7Mi8s1U56J14BPT8gLE+P9e0dXdBExlvcO33c1B9NM2Ht tquR7H/k+Mz3WARXMH1/ra6tRevWfrzSNRlIwGgwDOvIVGWMlhLrf5xgRhr+0xutyrWT fg2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oDXPXE1ejSNiTZPmJzCEijdYryKHjxn03JTJMf6IP7Q=; b=Lf3x4TApkytSXXm1H1uMhw8CQzYg0OUML7fW7pc0YdSTKFwLz3g0xWXVoFJUSZG2yn Gaqb1NstJUO0BqAc0mcmU0xC0G+a92THul/qqXyeErV99EVRiChyXpIkbXh1shXqvOLX 4yjiTWU6dX5Hc7bXl6i6m0R6Fpc6CT7y61B1hhaA9XPTS2NyPYtosQU68iFfuk92Ojji PApcBBgir2mCVuOrhto3Bc2RpfuRHqOt1iJofexl69tZMKXuiMw8jPOb8UhzoHEqq12A 8L/Xe4/ovOZ2uVjTmAedaMFFf7tirwz1tzd7YnG/gE/E9bzdHsemat4s8KPWw1a59As3 NJgA== X-Gm-Message-State: AOAM531OprLuS0dGDQ4YFwC6cVCKP348IBED38PiPrfnKt2pjQ624ib7 OKhEDgxVbJKKqWR0YxI6O3U4Dw== X-Google-Smtp-Source: ABdhPJwIxV2zfyTQ46CXR54rzVA+3y6gCIKQuS9jzSbWYCHADjbdXTgdAvhaPHfM7G6AYqJMnSZhEw== X-Received: by 2002:a7b:cb98:: with SMTP id m24mr49126433wmi.98.1594042449766; Mon, 06 Jul 2020 06:34:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:09 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Yuan-Hsin Chen , Feng-Hsin Chiang , Po-Yu Chuang Subject: [PATCH 21/32] usb: host: fotg210-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:30 +0100 Message-Id: <20200706133341.476881-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Only 2 functions attempted to use kerneldoc in this massive file. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’: drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable] drivers/usb/host/fotg210-hcd.c:5569: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_probe' drivers/usb/host/fotg210-hcd.c:5666: warning: Function parameter or member 'pdev' not described in 'fotg210_hcd_remove' drivers/usb/host/fotg210-hcd.c:5666: warning: Excess function parameter 'dev' description in 'fotg210_hcd_remove' Cc: Yuan-Hsin Chen Cc: Feng-Hsin Chiang Cc: Po-Yu Chuang Signed-off-by: Lee Jones --- drivers/usb/host/fotg210-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 51dbbb0e768bc..633df2e927bb3 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -5557,7 +5557,7 @@ static void fotg210_init(struct fotg210_hcd *fotg210) iowrite32(value, &fotg210->regs->otgcsr); } -/** +/* * fotg210_hcd_probe - initialize faraday FOTG210 HCDs * * Allocates basic resources for this USB host controller, and @@ -5656,7 +5656,7 @@ static int fotg210_hcd_probe(struct platform_device *pdev) return retval; } -/** +/* * fotg210_hcd_remove - shutdown processing for EHCI HCDs * @dev: USB Host Controller being removed * From patchwork Mon Jul 6 13:33:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645805 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBE4014B7 for ; Mon, 6 Jul 2020 13:35:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1C4320715 for ; Mon, 6 Jul 2020 13:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VcXzc+ei" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729485AbgGFNfP (ORCPT ); Mon, 6 Jul 2020 09:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729346AbgGFNeM (ORCPT ); Mon, 6 Jul 2020 09:34:12 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 318C5C08C5DF for ; Mon, 6 Jul 2020 06:34:12 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id o11so40974975wrv.9 for ; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OciwYyOFlkXAJUScx7SVNAsT2ixoj+EcNyfWn6Xsafg=; b=VcXzc+ei6oAKh0w9DGfsZ7yETc5sXN+3CKC6KObuvLUoH3M6ejWS+WNh038+jerj1h KI4cAa0tpwKF8qImVnIfbBVmuIpuZXmutsi83s3amfRemr24wtyYXdFrVYFykResp+mG qSAP9l84fi+Dt0Fnu3Cb2A14nb4o0z0JBuqtUyrjUfF6KCeBfoBEAO5gWLv/tqgaBMBI YLCG0Yb6MCy94d4x5KSxVAJ+aVCnKF9vdxqfslNV7uGTtNVTyuugED/g2wBXF3lcN4ep 1swxoIWib4nm7mySMmzgcmGIskZ388OV4ojyM0vWXISGi3/m8ZetblrkAo0WynFU/xn3 tkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OciwYyOFlkXAJUScx7SVNAsT2ixoj+EcNyfWn6Xsafg=; b=fMSUgTEM8GljCjDL1N9NrxNPa6RLly/dcJV+15FSHHLsRymLI2WYRqJ2E69FD5EKYs 91AqSNjtqwB4xeYy9M9VuIAUWhFIDxS998TLdxeiYmHvhrZ5o7G4yRziCuWGQgzidhzg QTxORo63CVFKbaL4xRbmYZHEcSP3V8iPkUaY46C3RDRWVcDjYaS1yc1l/+PtSo4cbf2Y AVyHkoeTeGE9qaf5O+duw0iAN3GIXjMiVVYJlmQA6CtjECVHU5NgdOTxp1Yyn+tI79YS TkndHw1Ewc0v3BPK/BE6KPwsDQkYCtYm2NtzC4Mk7Nz/OU52fvGrdYAjiZrUXi0EGs3M UjWQ== X-Gm-Message-State: AOAM5339Lz7D45GP0ZZKniyrBXzJUQJarDCHHdw10OTINxNcxC3B/WXp KWIKYp2bc8D9Q2sTtD2MgqXFtg== X-Google-Smtp-Source: ABdhPJwafQcWQ5lx2OMY4PDcOm8GgrMZIhHBn7VBMVREZs6ut8V4qlC9AB2XOFs67IvmSh8lOCpxuQ== X-Received: by 2002:adf:e44c:: with SMTP id t12mr21898286wrm.103.1594042450943; Mon, 06 Jul 2020 06:34:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:10 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Jason Yan , Yu Xu Subject: [PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' Date: Mon, 6 Jul 2020 14:33:31 +0100 Message-Id: <20200706133341.476881-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Looks like it's never been used. Driver was mainlined in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_u3d_core.c:35:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 35 | static const char driver_desc[] = DRIVER_DESC; | ^~~~~~~~~~~ Cc: Felipe Balbi Cc: Jason Yan Cc: Yu Xu Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/mv_u3d_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index 5bb0568b934e1..5486f5a708681 100644 --- a/drivers/usb/gadget/udc/mv_u3d_core.c +++ b/drivers/usb/gadget/udc/mv_u3d_core.c @@ -32,7 +32,6 @@ #define DRIVER_DESC "Marvell PXA USB3.0 Device Controller driver" static const char driver_name[] = "mv_u3d"; -static const char driver_desc[] = DRIVER_DESC; static void mv_u3d_nuke(struct mv_u3d_ep *ep, int status); static void mv_u3d_stop_activity(struct mv_u3d *u3d, From patchwork Mon Jul 6 13:33:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645803 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4697B13B6 for ; Mon, 6 Jul 2020 13:35:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2ACA2206F5 for ; Mon, 6 Jul 2020 13:35:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xDhKb4d1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729482AbgGFNfN (ORCPT ); Mon, 6 Jul 2020 09:35:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729197AbgGFNeO (ORCPT ); Mon, 6 Jul 2020 09:34:14 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E590C061794 for ; Mon, 6 Jul 2020 06:34:13 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so39377634wmg.1 for ; Mon, 06 Jul 2020 06:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=xDhKb4d1kq4g63PE6Kw+d0pJTKLnw/IIJQRWCvGGBRKLAySHr3nXCYdnP0FF+KYdgl vilMW0c0k6s1Ego/Dne9r8otV3SFOpks3w1DdJX6EPTI97pwdrKlIb2UKkbKdM3aDVlj oSrJ9yzAacAEyGyCdl7WGdOS1ZgDlhAHAlm1LeHkd9CpJeixRsVwXY0hZ/8oKIB1aA7R tQf8xNsPpdj7GOKICfWv8NpWcwtVpUjJFXZFlcmBUynkOisE2Sqp7YJSGA42CjzUdB7j d48tqL2Z+IA4acMLvxU18EamPKiWgdTtUL2LpLPFNEyrurJ1mT7m8OpdBkl5rzIdpn3b 0snA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3O86wjxqNkOu1v6Uq0UsZIVMC/nMKC8xbmSovx4mwRU=; b=spwTB8Z3vtqPRSIo1u99v9fuInSBKTXt3LCGxPltWRHG8fwiHQgcHgwGsG6AbMjkFm k6GMPh8XBEL6us0kslX15d+lmq+h8SCieGTaRAzUH6iBPfGz65lwtdXITMf5c7Ralx2A jWCl1Gm0D/aT06CoWS8Hl3lfkQI97c2UNe2KTBWFV4k1DWtHqhZLxp5A9NgKypHRJXtb OJmKJ7VBJlD13Xowok/WjizqaY9R4DHQiMrSX3oyOFDJbPzIcJiXMpVhYv/UqgbOvoYZ l2kASdDqlNNNVYYF3Swk9PJ5JnbytXxZJvqBCl2Xj7FBM4uA/oTpQd5j2UmUDAT4zaYk 1ltA== X-Gm-Message-State: AOAM532lq1rF0/ueTjoBAJbCoROhZjKhPfmNAWKixTEa8huzb0BO3PW7 mypji6FfeCb9MN5050SOYBDaCg== X-Google-Smtp-Source: ABdhPJz+ya1juxEYdu8hRa5da9rRY9b7wU9z75P/hBna1EEO/zxK6KolWddZ+pI9eP30hH8G324USg== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51112738wma.4.1594042452163; Mon, 06 Jul 2020 06:34:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:11 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Felipe Balbi , Jassi Brar , Christophe JAILLET Subject: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Date: Mon, 6 Jul 2020 14:33:32 +0100 Message-Id: <20200706133341.476881-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’: drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable] 626 | u8 addr; | ^~~~ Cc: Felipe Balbi Cc: Jassi Brar Cc: Christophe JAILLET Signed-off-by: Lee Jones Acked-by: Jassi Brar --- drivers/usb/gadget/udc/max3420_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c index 23f33946d80c4..52884bae4af11 100644 --- a/drivers/usb/gadget/udc/max3420_udc.c +++ b/drivers/usb/gadget/udc/max3420_udc.c @@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc) static void max3420_handle_setup(struct max3420_udc *udc) { struct usb_ctrlrequest setup; - u8 addr; spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8); @@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc) USB_TYPE_STANDARD | USB_RECIP_DEVICE)) { break; } - addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); return; case USB_REQ_CLEAR_FEATURE: From patchwork Mon Jul 6 13:33:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645801 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A238214B7 for ; Mon, 6 Jul 2020 13:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89BE020715 for ; Mon, 6 Jul 2020 13:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fw8KkupQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729479AbgGFNfM (ORCPT ); Mon, 6 Jul 2020 09:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729162AbgGFNeO (ORCPT ); Mon, 6 Jul 2020 09:34:14 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79B12C08C5E1 for ; Mon, 6 Jul 2020 06:34:14 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g75so39364227wme.5 for ; Mon, 06 Jul 2020 06:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wF0TEpLE3+8aSfCpSueulEs3qt7dUTbs4ZXmnn02trY=; b=Fw8KkupQWP1sjuNARANgDth/I4E8Dw60dO13hOJ8P5eNzx1H61J9+oaoJEz4UW+eLB x1QdMZF9StP7c7hyy5JUC2MkPAqAt8qlfDb0usPVJ896zJWoOIBxIxiB9t3WJWOp41wc QWQfUyGB9r0pZlKQ/l7gJrP8c9Azan7WlFLNpgl++8vrM1xNTg4t8bQ7iLn1cUPL5RBW AG42p5PbmHJ8Frm71710QTtIrNhkU5qAvSTsYC97K1PrCm5ql9h7VGbzShVHn/cTrI73 fL7PPdPg+3dvqO2vSDnwUP0ahpRMP1oWeMlfwjY87k/1h79BGuI02uv9lh8MDmd3wbOb XMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wF0TEpLE3+8aSfCpSueulEs3qt7dUTbs4ZXmnn02trY=; b=h9SPXPCJLZuHBDA02/zVYab4h9nD6+nrnskiGpOtTASFfFXUS9Y/bq1tFBtFA8bv6S 9atk3EYulhKgMrKN86Ztd19DyJ0MmRcTWi/g6wXqUXEEBMEcPMu3uvPCqioFkSZPk2HC Uj0WhD5HfvCafC63fAI2sxOckGAitNdSgdHMHxKSqfFzsfKyZXcE+MgATo5Pj5X2lN3t YlwtbHXs3VRnesffxicSpt4aw3c61720xtHtjWjRQhaWvk2Esokg+0DW/9un+bS6U2sD nQfVASSAJ3yx+d3CY0rTCW1DXW3uGnB9vNdGNYM1/babupFzNueEHRIC3sDS/vNFGF/s UcYw== X-Gm-Message-State: AOAM530VS9ur3BhqYOVZylzotsc7kPivfdp3rXFJ+bYDM1oRVOfrilAb JQrEEd06ruFRrAx7rV7OYcY2mQ== X-Google-Smtp-Source: ABdhPJxHHFnEPojgYRMIoE3DnTDn2rSpOXSQ2WwvPUtq97j/0sE7IvNfbZmEFXNMp63VwfwkukEpMg== X-Received: by 2002:a1c:c3c5:: with SMTP id t188mr51930563wmf.53.1594042453242; Mon, 06 Jul 2020 06:34:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:12 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Heikki Krogerus Subject: [PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() Date: Mon, 6 Jul 2020 14:33:33 +0100 Message-Id: <20200706133341.476881-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org It isn't called from anywhere outside of ucsi.c. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/ucsi/ucsi.c:1005:5: warning: no previous prototype for ‘ucsi_init’ [-Wmissing-prototypes] 1005 | int ucsi_init(struct ucsi *ucsi) | ^~~~~~~~~ Cc: Heikki Krogerus Signed-off-by: Lee Jones --- drivers/usb/typec/ucsi/ucsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index d0c63afaf345d..affd024190c91 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1002,7 +1002,7 @@ static int ucsi_register_port(struct ucsi *ucsi, int index) * * Registers all ports @ucsi has and enables all notification events. */ -int ucsi_init(struct ucsi *ucsi) +static int ucsi_init(struct ucsi *ucsi) { struct ucsi_connector *con; u64 command; @@ -1078,7 +1078,6 @@ int ucsi_init(struct ucsi *ucsi) return ret; } -EXPORT_SYMBOL_GPL(ucsi_init); static void ucsi_init_work(struct work_struct *work) { From patchwork Mon Jul 6 13:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645783 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 781BF13B6 for ; Mon, 6 Jul 2020 13:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DB7E2088E for ; Mon, 6 Jul 2020 13:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tDxm68x6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729204AbgGFNeR (ORCPT ); Mon, 6 Jul 2020 09:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729354AbgGFNeQ (ORCPT ); Mon, 6 Jul 2020 09:34:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB7EC061794 for ; Mon, 6 Jul 2020 06:34:15 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l2so40630820wmf.0 for ; Mon, 06 Jul 2020 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=tDxm68x6EEuzSyF8zb1P7MNnLA1RLSLV7ALNXgP2jbhLbdEirodV/LE4bXzaJbsPRg SUs25JhonwmI4Zqrwaw4zG1N8CYo4lAXlnF26lpK/OFRkQCBCsW93WEi1lCMj5UWQUmj QMnuck2Ci0chN7EEaR5qWLPh9Nag2b7j1MCcb9/mrCXgV+WBZ7ijQZzXPdT8Hjg0PTNS goxdYPMOU0X2sc2aE1VXEpQk/0hLVxQjbMvmUCXhN28efa29/LuSc8kkdAhJT0CG2LUK rVz1fvRtUKDbzGwTdNfqJrgIE5j/IDqenQl2BErSZqG2pPSnQFEsUwi3TsrnXUWaGjxc gQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tuuvgBdpWU3P+bBrTu/2KsiGO4ss74gkTJhNI/l0mkY=; b=jdRt0SXtbxxxi5a+nWNt5eKHNNlYBfsq0aGX4F9cnWZ60K1C4gBKnmLeU43tKVywaC EjZvUQ5XhSZNvUp8mfOKLEBNCMT1yctHhjpd2Vpd2gj6wQC7T5lPLwueK1xOUydPdHYT 222B/MwAAqbcytllClnu8FYiJxtnt3SsTS1dBhkov6mQr5h/5UVFJIrdh81I/mMP4KZr nDW7nBNXlVajsDRAFOcTDkbc5/glnUIacJqlwkR3DkjYAuFE3OmVPgj0QO8f+TjdirRr /GRqN/UmSy+neEDnzQ7IBzR4Ii4ruAlOm9P5TI+9q1omPbqUQEdzbOBVvJgYJ4ys65WQ AD2A== X-Gm-Message-State: AOAM530ebmRGEAJ4l4Siagl0DZ7OhTHJ5gADPxMyn0sWrCZtfAQKZsIW yJ8MZX0y04wTfNovnO7RX1UH0Q== X-Google-Smtp-Source: ABdhPJzuzYNNW71b23BvSLPHgO5D0LojminjFAQt3G/egnKeifhMWhpTDqlAyYc41PSyJlYXg/HnVQ== X-Received: by 2002:a1c:49d4:: with SMTP id w203mr50012638wma.13.1594042454380; Mon, 06 Jul 2020 06:34:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:13 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Sumit Garg , Daniel Thompson , Douglas Anderson , Petr Mladek , "Eric W. Biederman" , Yinghai Lu , Jason Wessel Subject: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Date: Mon, 6 Jul 2020 14:33:34 +0100 Message-Id: <20200706133341.476881-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org 'ret' hasn't been checked since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 | int chunk, ret; | ^~~ Cc: Sumit Garg Cc: Daniel Thompson Cc: Douglas Anderson Cc: Petr Mladek Cc: "Eric W. Biederman" Cc: Yinghai Lu Cc: Jason Wessel Signed-off-by: Lee Jones Acked-by: "Eric W. Biederman" --- drivers/usb/early/ehci-dbgp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index 775cf70cfb3ed..b075dbfad730f 100644 --- a/drivers/usb/early/ehci-dbgp.c +++ b/drivers/usb/early/ehci-dbgp.c @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s) static void early_dbgp_write(struct console *con, const char *str, u32 n) { - int chunk, ret; + int chunk; char buf[DBGP_MAX_PACKET]; int use_cr = 0; u32 cmd, ctrl; @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n) buf[chunk] = *str; } if (chunk > 0) { - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM, - dbgp_endpoint_out, buf, chunk); + dbgp_bulk_write(USB_DEBUG_DEVNUM, + dbgp_endpoint_out, buf, chunk); } } if (unlikely(reset_run)) { From patchwork Mon Jul 6 13:33:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645799 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C42FE13B6 for ; Mon, 6 Jul 2020 13:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD90620720 for ; Mon, 6 Jul 2020 13:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w5P2aU6D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729365AbgGFNfA (ORCPT ); Mon, 6 Jul 2020 09:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729358AbgGFNeR (ORCPT ); Mon, 6 Jul 2020 09:34:17 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C649CC061794 for ; Mon, 6 Jul 2020 06:34:16 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so29659570wrl.8 for ; Mon, 06 Jul 2020 06:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hOxuOAzmvEV55alflVuCU5810VX9tcA35muYC7R0MbA=; b=w5P2aU6Doeac9XeMuviG7stwJdgM6WsIR+NBZVf+lZt+//ND6hJ0DXWizpA/m6bvwD B2u0ApOKmiuQOBKM1YTtRRJXFMhrqsqF5Ykg3yCIhM78pF2i9vIJFL96Ve0I6gQrZww+ hipLqHTD9shzTQ0ixY1kUN5YsF9v2aMQynbFnVU+Qu+aWu0Ikiy2sbwjO0WWC78XIlyu Jukm9EtNycZtWgB8LT/DwQWNu306tPsdPdKJ6yBLniVQ1uduG5/SYh+Cis1o7XDA4U9y bpXkmFKaaIGenZXim6OybyyfkysmnYGI7GTOso3LNOgCj400PgZI42jXMSjLkXY+Bfio 7O8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hOxuOAzmvEV55alflVuCU5810VX9tcA35muYC7R0MbA=; b=ECbqtyOw05Q0FM87VwP6x71SG7B7mQPaL7Njjknm3nydP8GZu9cWfGb5a/my5omfqM +PkRaZLxim4CcUIy6BhGkaCnNKJMoMWREkoapc1NFEQvVZra5nROr29P5fyPI/IUCyNl X8/VBsGHrzpjgL2b8jKnzRK0e/9biZdWIgCUzb0GuPKtJ9OxE+e86u/2Ns9KWw1O8558 D/P/gJ2pvohKea8ydEHvWVK3cBr73xAIqU47SYV9Oocu0kYe1iDuA8A3s2qKDfQabR3S NzniR0zWYFr3OsHiKRVeencxEowSJTmCJfgttHcIronr+QI2HIT6w4+2J/ExGZr0+xv/ ou1g== X-Gm-Message-State: AOAM5300Tgk37QMHDlPfy9Ssn8MimDp0DVNjwMGy3q2Lwv2EgIt+zReQ R8tB//kKMYCUqNIQrxeSYkmTKg== X-Google-Smtp-Source: ABdhPJwQLKXTvfX4Y1+2PDutR0rJsq3ap9TgpalSECU387DommfB6/zibSUcLtGWIgZ9/g+LfFUx5A== X-Received: by 2002:adf:8024:: with SMTP id 33mr52421656wrk.117.1594042455545; Mon, 06 Jul 2020 06:34:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:14 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Jann Horn , Lu Baolu Subject: [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile Date: Mon, 6 Jul 2020 14:33:35 +0100 Message-Id: <20200706133341.476881-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 | int chunk, ret; | ^~~ drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes] 600 | int __init early_xdbc_parse_parameter(char *s) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes] 653 | int __init early_xdbc_setup_hardware(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes] 910 | void __init early_xdbc_register_console(void) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Jann Horn Cc: Lu Baolu Signed-off-by: Lee Jones Reviewed-by: Jann Horn --- drivers/usb/early/xhci-dbc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index 04ba11fff0edc..a9932c1ff20f7 100644 --- a/drivers/usb/early/xhci-dbc.c +++ b/drivers/usb/early/xhci-dbc.c @@ -21,6 +21,7 @@ #include #include #include +#include #include "../host/xhci.h" #include "xhci-dbc.h" From patchwork Mon Jul 6 13:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645797 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 305EC739 for ; Mon, 6 Jul 2020 13:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16EBD20773 for ; Mon, 6 Jul 2020 13:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e7KtGYdj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729458AbgGFNe7 (ORCPT ); Mon, 6 Jul 2020 09:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729365AbgGFNeS (ORCPT ); Mon, 6 Jul 2020 09:34:18 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F7ABC061755 for ; Mon, 6 Jul 2020 06:34:18 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 17so42074750wmo.1 for ; Mon, 06 Jul 2020 06:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nPVZRZLDqwpPhO4RC/GUsbLkf95aQVfMZw3d44goLsA=; b=e7KtGYdjynUM1W1lVC4D+RIRR4fBD8poghJ6q+calXuw04pQafBm+5FCXwnEGJDTjX BDzvFqtTHsd9hwMREut6OdZzkcQHEC0l2dZjb9VdPRyWH2aZ5LABMONQ2vCB9wK9tp1E zEM6m4tqjYBKq8REuplcACGfj3pwaKAES50KYRAyjwak7AC03Z7nKSoYgGR4tClPuoiM +CxlNKfmQVhp8aKa3Hs4YubZpnJHKn5GFtivVZFBW6CY5w0GlhBeXoh2rigyRtBmRuKn ZF7+SX/Ys14HAbuDA36aa4fev+VbZ5zLdYDDq0g5UecpKwPDPbJBaNBfdLa8wx3hwrnU bMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nPVZRZLDqwpPhO4RC/GUsbLkf95aQVfMZw3d44goLsA=; b=pG4m/jxmCdGY4tHk6qZQ5qN1/kH5/4RmItWikNyPHHXL85KsCm4yUXa1SZQCR0ZJNp Qvr7FkJ6++zqrPFb6N9eYiNizOjuDRVfMlfxftdoxjPvVKlu15wcVg0do276/T0FuHbm ePwuiPXxNOAu7pdiV1YkNnQFBc4tp8oHl7HVAwfyxXKwduGpyZXb23O2Vr3/QLWQx9UN S70zVW6fIyLiy22uvlp5eUy53DDM8063wDZxNPbexPCU3yOunsrztd6WAJvLqdrBlzl8 BwrRg7EpFf6HM56P57c74ckhRc3p1DpYYsafTEzr/ZQkI5LWnxLUMRWOWiGViLQKNsoy 585g== X-Gm-Message-State: AOAM533vUVEMTYOXiyPINlrHgh0X+/dNJJDZwPKLQfSmVdYzp7wEYz7a p0CWr+xqkdLYFhqyM0rtr0wpLQ== X-Google-Smtp-Source: ABdhPJyAcv25bdv6OoMfwgsx5XUgRwu6m6klXGx12+TUQBLMsDvexy8Kv11aX3pyM5ps2Xh49QyLrw== X-Received: by 2002:a7b:c013:: with SMTP id c19mr48983261wmb.158.1594042456784; Mon, 06 Jul 2020 06:34:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:16 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Lu Baolu Subject: [PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc Date: Mon, 6 Jul 2020 14:33:36 +0100 Message-Id: <20200706133341.476881-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Demote xhci-dbc's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/early/xhci-dbc.c:10: warning: Function parameter or member 'fmt' not described in 'pr_fmt' Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/early/xhci-dbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c index a9932c1ff20f7..c0507767a8e34 100644 --- a/drivers/usb/early/xhci-dbc.c +++ b/drivers/usb/early/xhci-dbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * xhci-dbc.c - xHCI debug capability early driver * * Copyright (C) 2016 Intel Corporation From patchwork Mon Jul 6 13:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645795 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5818613B6 for ; Mon, 6 Jul 2020 13:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E7E320771 for ; Mon, 6 Jul 2020 13:34:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FiUwhiwO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729227AbgGFNey (ORCPT ); Mon, 6 Jul 2020 09:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729368AbgGFNeT (ORCPT ); Mon, 6 Jul 2020 09:34:19 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C958C061755 for ; Mon, 6 Jul 2020 06:34:19 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s10so40900548wrw.12 for ; Mon, 06 Jul 2020 06:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mWltuWttrG3KiDQZY2idnG8bvke04NKb60bkJdZCmM8=; b=FiUwhiwORfJUq6xcQw08ePbp4jFq9zkCsBOJbY5wttUElOMB2DgHr2Ko3zvst7bvYB Ui9P6o+mRZcelsc5C9tXcPKLLoFC/iS6qar8Ip5fBxVFMZRZJVsSsyS5ef/QT9kTop8z UGOpptvK9HXjs+3AGo+o6Ivd4xWy7PRMnw7Zkoe+bSm8NQQJFGxdnxnaHaktnGlOtkIN yfyBY5qfjjE8G+G03wwUI6G05iBnT19J8s7Ok43KhKvri0eGH7E8GHp4zy+syeBHiNS0 n72Yictau5/AGSpOoyLakFPr6cSNAGIFJ5miYw5mNg249KRRQV1WtpJcuWU6y6G34G+9 pVRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mWltuWttrG3KiDQZY2idnG8bvke04NKb60bkJdZCmM8=; b=pmxkYqv7+4pqkCCH9ediv0pobxMMC050NVCqbW04Zpf9B3R4pQKA4Id4ddMd6/dEPf 6g4h5/0i3shiHWv17vi1P9nz/ViBnyErLTZ+kM3uvTNx3eRRkgxhDiAvutwWWHy8TpUr lQBHTTCf6WBzrOPdqmCnSQYiRCTt/FmpWEguLgkrGCsx4EZPI6Ojw4uj+Ie8lyF/IXKO swNksBjjuGUMXlF/gkV+TrhvNBbqoU62P0dW2WjIdeAYwwZf9Xd3KFlHyIc1Pif7keyj iB23fH5kgMg8EP+HKEvt6x0S6m32Val2zFENmcKAv8GxIgGUHFGZ4lIv3sf/Ajsv9wPD 7T+A== X-Gm-Message-State: AOAM53294MRV6WdcQSxmta3JxIOLkckATe4OOGjG7pDkjkMB9TDcWY7h 3JIFeQ+oiRU4XDPUaLg+rXLqJA== X-Google-Smtp-Source: ABdhPJz2SSPMu/jcrYODKBmxh4uV8oCWzAS1ZBr1rHvKRDtTIyhN/9NwzeNIP28/M6BupUGAaPu+pg== X-Received: by 2002:a05:6000:1290:: with SMTP id f16mr21627350wrx.66.1594042458073; Mon, 06 Jul 2020 06:34:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:17 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Tony Prisk , Alan Stern , Philipp Zabel , Steven Brown , Hauke Mehrtens , de Goede , Michael Buesch Subject: [PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:37 +0100 Message-Id: <20200706133341.476881-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct ehci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-platform.c:478:36: warning: ‘ehci_acpi_match’ defined but not used [-Wunused-const-variable=] 478 | static const struct acpi_device_id ehci_acpi_match[] = { | ^~~~~~~~~~~~~~~ Cc: Tony Prisk Cc: Alan Stern Cc: Philipp Zabel Cc: Steven Brown Cc: Hauke Mehrtens Cc: de Goede Cc: Michael Buesch Signed-off-by: Lee Jones --- drivers/usb/host/ehci-platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index e9a49007cce4a..006c4f6188a52 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -475,11 +475,13 @@ static const struct of_device_id vt8500_ehci_ids[] = { }; MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); +#ifdef CONFIG_ACPI static const struct acpi_device_id ehci_acpi_match[] = { { "PNP0D20", 0 }, /* EHCI controller without debug */ { } }; MODULE_DEVICE_TABLE(acpi, ehci_acpi_match); +#endif static const struct platform_device_id ehci_platform_table[] = { { "ehci-platform", 0 }, From patchwork Mon Jul 6 13:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645787 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0768514B7 for ; Mon, 6 Jul 2020 13:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E080120715 for ; Mon, 6 Jul 2020 13:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NVlmUCpq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729385AbgGFNeX (ORCPT ); Mon, 6 Jul 2020 09:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729347AbgGFNeV (ORCPT ); Mon, 6 Jul 2020 09:34:21 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F470C08C5E0 for ; Mon, 6 Jul 2020 06:34:21 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l17so39374582wmj.0 for ; Mon, 06 Jul 2020 06:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JwlPz1VQoWtw/PPAMkJDslP79wmZUbGedUK151UzPVM=; b=NVlmUCpq/lKEqVs2LNex5jpihdjoioJToXMlmV7xJlur5bBqqxQQ0ZA/CPEMp/YFYN zo06ci+Iy0l18umuNeYhgFhN14h8r6U7kxH24seP3QCInrax1OBWeKQ1SE9H70pcJnMY Y+3zvLqxSlGJHUh9Rzg3ntB0br++CashYLBwH4dCl6PYtf69SG4bkCjzXWpVyre6jT7Z bs9jKtCs/nALiRvYyYsz/k1abSGU0I7VVN+9TLc1NZl+ZuCNQZNWPap0lcFqJXgO9nJp JQTT4IqiZ5ED2DtL16qAF0f01uKhcxkAIoUDFBjNrhu/dSUyHaMzolCNKJUKIkCUvEqy +HuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JwlPz1VQoWtw/PPAMkJDslP79wmZUbGedUK151UzPVM=; b=gqp+ihc9gfYX7QigcN1YT3w2lAt8BfZOjILeEUB0gi39u6ynp8iKGtW4uKwnKRxDYJ /OYaS+fjlcEmdSHchU+irAzCvY/OnVwGykL6xdFFcykWxoEwnRx4OzY3tfKULUMe68ar IvCRcuCAsLrgBmA/x0lS6F/qofw+nV9Bgos6xwZPzNq0EstcyxHa6Ko39xYBZk0zdXN3 +FT1gHGGh+z7RWNMNw0A5IIj7WyiPH+RfHgz0mwiY7nLhUqehy2K7C6ziRelOXIkMU1B /BPTTcjmHFvWhWD9tULOZtrpAOwehe98MV0UAAA3MZEAc4JY72WR70LIRG/3uhpq9WdF uazg== X-Gm-Message-State: AOAM533841mC6vcIR1ZPH0MDTXaoqwa8R7qSul6v+cf9KakioBoQo/UM YZf9BwBo0l8ljQdflpI29RoLYQ== X-Google-Smtp-Source: ABdhPJwWAM9YUcyOeIqwvk9EC4yw+4vx9TJztDtgcS6azkPjILD4VT5pv7bUKjKcnm3I1NN1jBI33A== X-Received: by 2002:a1c:e914:: with SMTP id q20mr47372571wmc.145.1594042459982; Mon, 06 Jul 2020 06:34:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:19 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Andy Gross , Bjorn Andersson , Felipe Balbi , Philipp Zabel , linux-arm-msm@vger.kernel.org Subject: [PATCH 29/32] usb: dwc3: dwc3-qcom: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:38 +0100 Message-Id: <20200706133341.476881-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct dwc3_qcom_acpi_match becomes defined by unused. Also need to place the platform data obtained via the matching process inside the #ifdef, else that becomes unused too. Fixes the following W=1 kernel build warning(s): drivers/usb/dwc3/dwc3-qcom.c:761:36: warning: ‘dwc3_qcom_acpi_match’ defined but not used [-Wunused-const-variable=] 761 | static const struct acpi_device_id dwc3_qcom_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Andy Gross Cc: Bjorn Andersson Cc: Felipe Balbi Cc: Philipp Zabel Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/usb/dwc3/dwc3-qcom.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 1dfd024cd06b1..e1e78e9824b16 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -540,16 +540,6 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) return 0; } -static const struct dwc3_acpi_pdata sdm845_acpi_pdata = { - .qscratch_base_offset = SDM845_QSCRATCH_BASE_OFFSET, - .qscratch_base_size = SDM845_QSCRATCH_SIZE, - .dwc3_core_base_size = SDM845_DWC3_CORE_SIZE, - .hs_phy_irq_index = 1, - .dp_hs_phy_irq_index = 4, - .dm_hs_phy_irq_index = 3, - .ss_phy_irq_index = 2 -}; - static int dwc3_qcom_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -758,11 +748,23 @@ static const struct of_device_id dwc3_qcom_of_match[] = { }; MODULE_DEVICE_TABLE(of, dwc3_qcom_of_match); +#ifdef CONFIG_ACPI +static const struct dwc3_acpi_pdata sdm845_acpi_pdata = { + .qscratch_base_offset = SDM845_QSCRATCH_BASE_OFFSET, + .qscratch_base_size = SDM845_QSCRATCH_SIZE, + .dwc3_core_base_size = SDM845_DWC3_CORE_SIZE, + .hs_phy_irq_index = 1, + .dp_hs_phy_irq_index = 4, + .dm_hs_phy_irq_index = 3, + .ss_phy_irq_index = 2 +}; + static const struct acpi_device_id dwc3_qcom_acpi_match[] = { { "QCOM2430", (unsigned long)&sdm845_acpi_pdata }, { }, }; MODULE_DEVICE_TABLE(acpi, dwc3_qcom_acpi_match); +#endif static struct platform_driver dwc3_qcom_driver = { .probe = dwc3_qcom_probe, From patchwork Mon Jul 6 13:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645793 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4E2513B6 for ; Mon, 6 Jul 2020 13:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAD2F2070C for ; Mon, 6 Jul 2020 13:34:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uusCAAiM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729425AbgGFNej (ORCPT ); Mon, 6 Jul 2020 09:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729383AbgGFNeW (ORCPT ); Mon, 6 Jul 2020 09:34:22 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82153C061794 for ; Mon, 6 Jul 2020 06:34:22 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f7so37936610wrw.1 for ; Mon, 06 Jul 2020 06:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wUFrKyBE/rqHQUVcokgEiKeaeYpvOr+KJ0Q9vYwpje8=; b=uusCAAiMYRyZu2CfIvDS4HCRjCXdZtQhAdbkpOMuxK8zvkQgvAiWP7osHCg5j0Lxi5 16z2up3T4hzLGYGUj30PuZuH/B1ZOaCs7UsgLTYfLAopJ+wzvauVq5wsuRkhS9mODBVO xu3HpYfIRTGCABdG6OuYwyuSubTIL9fv8KfITH2PVNH6p+KU2u/VSZ88VFCHVaBSnUEE qCSCG4xa+6MOhyRfi5aRon2mI3zyyZNLPzHx0yYiSZHLP1iZQY77tCT0GZB2yW+6Np0Z oepj3m1na2bZFY8S7xZRfDmdzIbt82vIVRQ30dBiAEz2EguVEQm+DlN2OGXrSjBKXDOb Soig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wUFrKyBE/rqHQUVcokgEiKeaeYpvOr+KJ0Q9vYwpje8=; b=D3HSVrawI3Xsgd4N49Jm++FeCmxco74wRM9lQSiOcNWHAyihmYdxaYyLi/wNMpO+br vdRt8DaCd3Gvc90hvu6q2y1900UfArQBC8+5bs7P1wrjpHSghaq/0Wfv7yNXrJW1yBfb H9+edcWNi2YgYPnEOTK4EzodvuqGqjaETZEClfPPS7yuQhOzC78m5W8UrawT0iVpeohc a0hHPwCG3nrjsz3P+CvyKsvgJnIkG770lRod4y00UNEU0Z9gsfdNpmWbgOAfrUFBAMiX KagbbwMUl/vtRrHLnaucDWQU39BhTKAUZ6CNmuv9AYvQRL3N0QArP/XDIT7fxg7kn8jE JvzA== X-Gm-Message-State: AOAM531XDjmWcnjI0vmW9Dr+xdC9ymMDSjgAKw5JUUTB8+h2JLeoz8r+ OnZkLyIes7YMJT71CNxUYVUZVA== X-Google-Smtp-Source: ABdhPJyyqkr63bgakviOF8q+Q3TQCXiWUrHVNA65wDA49vqE6L9e5OtXIB/BD5KAE97IICp4FfjQqQ== X-Received: by 2002:a5d:470b:: with SMTP id y11mr50993618wrq.101.1594042461212; Mon, 06 Jul 2020 06:34:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:20 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Shlomi Gridish , Jerry Huang , Peter Barada , Anton Vorontsov Subject: [PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data' Date: Mon, 6 Jul 2020 14:33:39 +0100 Message-Id: <20200706133341.476881-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Neither have been used since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_bds’: drivers/usb/host/fhci-tds.c:472:6: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable] 472 | u32 buf; | ^~~ drivers/usb/host/fhci-tds.c:470:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable] 470 | u16 extra_data; | ^~~~~~~~~~ drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_actual_frame’: drivers/usb/host/fhci-tds.c:527:6: warning: variable ‘extra_data’ set but not used [-Wunused-but-set-variable] 527 | u16 extra_data; | ^~~~~~~~~~ Cc: Shlomi Gridish Cc: Jerry Huang Cc: Peter Barada Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/fhci-tds.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/fhci-tds.c b/drivers/usb/host/fhci-tds.c index f3308ce250438..d98fd9e1af0bc 100644 --- a/drivers/usb/host/fhci-tds.c +++ b/drivers/usb/host/fhci-tds.c @@ -467,17 +467,15 @@ u32 fhci_host_transaction(struct fhci_usb *usb, /* Reset the Tx BD ring */ void fhci_flush_bds(struct fhci_usb *usb) { - u16 extra_data; u16 td_status; - u32 buf; struct usb_td __iomem *td; struct endpoint *ep = usb->ep0; td = ep->td_base; while (1) { td_status = in_be16(&td->status); - buf = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be32(&td->buf_ptr); + in_be16(&td->extra); /* if the TD is not empty - we'll confirm it as Timeout */ if (td_status & TD_R) @@ -524,7 +522,6 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) { u8 mode; u16 tb_ptr; - u16 extra_data; u16 td_status; u32 buf_ptr; struct usb_td __iomem *td; @@ -538,7 +535,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) td = cpm_muram_addr(tb_ptr); td_status = in_be16(&td->status); buf_ptr = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be16(&td->extra); do { if (td_status & TD_R) { out_be16(&td->status, (td_status & ~TD_R) | TD_TO); @@ -552,7 +549,7 @@ void fhci_flush_actual_frame(struct fhci_usb *usb) td = next_bd(ep->td_base, td, td_status); td_status = in_be16(&td->status); buf_ptr = in_be32(&td->buf_ptr); - extra_data = in_be16(&td->extra); + in_be16(&td->extra); } while ((td_status & TD_R) || buf_ptr); fhci_td_transaction_confirm(usb); From patchwork Mon Jul 6 13:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645791 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33CC8739 for ; Mon, 6 Jul 2020 13:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F9F20702 for ; Mon, 6 Jul 2020 13:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pIQ9uuVn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729413AbgGFNed (ORCPT ); Mon, 6 Jul 2020 09:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729391AbgGFNeY (ORCPT ); Mon, 6 Jul 2020 09:34:24 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996A6C061755 for ; Mon, 6 Jul 2020 06:34:23 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so39378299wmg.1 for ; Mon, 06 Jul 2020 06:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYphPHtOnqXpEOjqEtrG2eQ5inMeigGW8H35HCVLb4A=; b=pIQ9uuVnn+fW6hJfQP519yESrX2DO/yRDUtbTlObfQ7JiXoQk1gUB8izw+sRf4uiP8 0qRPMoy8V3fOjyBkwCzS9AG6yUdgQccA81mMdgPqR8VCUf9uNV6P4+i3drgluWiyuTmT MQEXMjrNdksYTFKqr2MlVEY2y1S2VnIj7ZkoLfXk5UAfT4JD5GUm5dHUV+1okA6gW4No 9O2oZmH1/5mtvpALvC7xYtm7gHR72y8RzKnIJ29P1F/sxS16DaKnI1wHAtggBbdw+i3T am7aikxGnPnMayMpGLeH64fpGjUAHyfWf/ZsNROTefX8AI4c+3cIjlt2iV9Amf5+79BV DbAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYphPHtOnqXpEOjqEtrG2eQ5inMeigGW8H35HCVLb4A=; b=JaQx5lIdPK4bHTXecc15umCCL2b2bEuiET5GNQYhmxlbzB21zejOE07aeAGFXQdCFk +q83PfLvH1URpC6qB7gWiQz6Fu5OA01YcEM8YMcnaJTdaGMELoUrRRl4r0jJ8l9IiM2z SqqmQ8zlwJ52oXj9VrQKN662lkFmp8KnVGa3gWAX15e7n37zJfXUikwARIPCCBlgx5SN Jzw7dgWyiI75PWYwK71qboy3Wv+nTPtvWcKaEDhQ8QivvYN0h/G35F/Iui13H2a2TZSk HL6Q/nJ334grqi208PlsjEgAWQiPcF5L4ubb2U8pjkI0s9qCtRyTigFj/qnoVfkth3xn kpHQ== X-Gm-Message-State: AOAM531yhmHYRKF0ME39TzsWqqMRFluYZDddlfTalJ2Lcdb+KXXGS+GA Kr180J1+xCA+08TwkcJiSPOolw== X-Google-Smtp-Source: ABdhPJxX/0H3QT2+4IGeuZMzXZfirJMCquWrp7wTX/H7qNjAS315WxUrQkgO2PIZ78d0/7Tv01PEFA== X-Received: by 2002:a05:600c:2219:: with SMTP id z25mr6860737wml.154.1594042462367; Mon, 06 Jul 2020 06:34:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:21 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Shlomi Gridish , Jerry Huang , Peter Barada , Anton Vorontsov Subject: [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Date: Mon, 6 Jul 2020 14:33:40 +0100 Message-Id: <20200706133341.476881-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org 'td' has been completely unused since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-sched.c: In function ‘fhci_queue_urb’: drivers/usb/host/fhci-sched.c:704:13: warning: variable ‘td’ set but not used [-Wunused-but-set-variable] 704 | struct td *td; | ^~ Cc: Shlomi Gridish Cc: Jerry Huang Cc: Peter Barada Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/usb/host/fhci-sched.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c index 3235d53074038..63c646c8f7d62 100644 --- a/drivers/usb/host/fhci-sched.c +++ b/drivers/usb/host/fhci-sched.c @@ -701,7 +701,6 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) u32 data_len = urb->transfer_buffer_length; int urb_state = 0; int toggle = 0; - struct td *td; u8 *data; u16 cnt = 0; @@ -770,7 +769,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) usb_endpoint_maxp(&urb->ep->desc)) == 0)) urb_state = US_BULK0; while (data_len > 4096) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : @@ -781,7 +780,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) cnt++; } - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : toggle, data, data_len, 0, 0, true); @@ -789,7 +788,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) if (urb->transfer_flags & URB_ZERO_PACKET && cnt < urb_priv->num_of_tds) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_CARRY, NULL, 0, 0, 0, true); @@ -798,7 +797,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) break; case FHCI_TF_INTR: urb->start_frame = get_frame_num(fhci) + 1; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, data, data_len, urb->interval, urb->start_frame, true); @@ -808,12 +807,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) ed->max_pkt_size = usb_endpoint_maxp(&urb->ep->desc); /* setup stage */ - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, USB_TD_TOGGLE_DATA0, urb->setup_packet, 8, 0, 0, true); /* data stage */ if (data_len > 0) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, data_len, 0, 0, @@ -822,12 +821,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) /* status stage */ if (data_len > 0) - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, (usb_pipeout(urb->pipe) ? FHCI_TA_IN : FHCI_TA_OUT), USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); else - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); @@ -844,7 +843,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) */ frame += cnt * urb->interval; frame &= 0x07ff; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, From patchwork Mon Jul 6 13:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645789 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 701EA13B6 for ; Mon, 6 Jul 2020 13:34:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 555632070C for ; Mon, 6 Jul 2020 13:34:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gbx/6YjT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729377AbgGFNe0 (ORCPT ); Mon, 6 Jul 2020 09:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729395AbgGFNeZ (ORCPT ); Mon, 6 Jul 2020 09:34:25 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C44CC061755 for ; Mon, 6 Jul 2020 06:34:24 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so40881770wrj.13 for ; Mon, 06 Jul 2020 06:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+aWkOnJjbe/7IK7NRoDvxRwORV+t2eCxVhOYLY5eRmU=; b=gbx/6YjTbDOXIW4LuH0gXQ/axZ6vtr5Q+IM30lN6HSd2IbKna7uTyK10teMAt6y0Lk 0xliIWmuFyYSKC28K8Txu3/u3lIpSijGtDQGknnxxqv2omOKry0M4wAsRTesMW1jTCkw /Ba0dcFpT+psH9sKfyWZCtE7LsLorCxeXUV4QsTez0/QuWDq2MrS6syfLhb7J2VnpAbZ q2Q119ypezf9Whp4PGxmTQ+bdWH+i0HCBUEBAsa0C1SfsMKNGakHeNCRHHdN1ynTWw5y 33tnFoqLPdDQh4A3ja91qaZ+9hK40F/VuKoKaVKroSwGPK31KwufTLIdetqfGKmilXP3 l4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+aWkOnJjbe/7IK7NRoDvxRwORV+t2eCxVhOYLY5eRmU=; b=ts9vygYj6MnzG50a7GhXMoUePW+UR08oWsh9cuozkTtxAY/Nn811GBs1RvDTqTJmDX FJOxAB/90DFRCW2AmxeQoawByqqw70qbMHiDIhWo/YwE2ukF6w118Q0MDjzUQHhBdka/ /ul1yfcYsHU+ZvPB9RbfbtD1bl6BVW7KkEH5UKD+nP+6alU+O1KHyA8l7Q4WTrkFhjry KCBDd8QhvQZRilGc+8ywJWGgmCKzHu9SDCPSjfeY2SyLOEbCQnWc1jw5ZLw+vYVI82qq f4mTObGzmlZe92tyQgHfBrUmdAz7ZRxw4FN4en1DKmGhEYimgqxKhwdMDBB8teoMRFnQ 9WCA== X-Gm-Message-State: AOAM5331u7Rg3jhFrYxwd4oj9EQza5ODfLicLFDdpUpi9lrqP9h10EiY fXFacIHwcH/CZ3uRh4Gn/Oh2uw== X-Google-Smtp-Source: ABdhPJxzVzY9SwrV/olyY4sGtNbsNmUZ7ypHADkmoDe0zZ4QHpbHLQ5OWEWVzQ/lT81AhxcLun8qWw== X-Received: by 2002:adf:8024:: with SMTP id 33mr52422302wrk.117.1594042463436; Mon, 06 Jul 2020 06:34:23 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:34:22 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Mathias Nyman , Andrzej Siewior Subject: [PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Mon, 6 Jul 2020 14:33:41 +0100 Message-Id: <20200706133341.476881-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct usb_xhci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-plat.c:457:36: warning: ‘usb_xhci_acpi_match’ defined but not used [-Wunused-const-variable=] 457 | static const struct acpi_device_id usb_xhci_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~ Cc: Mathias Nyman Cc: Andrzej Siewior Signed-off-by: Lee Jones --- drivers/usb/host/xhci-plat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index f6b4089bfc4a5..3e15b70a6fc99 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -454,12 +454,14 @@ static const struct dev_pm_ops xhci_plat_pm_ops = { NULL) }; +#ifdef CONFIG_ACPI static const struct acpi_device_id usb_xhci_acpi_match[] = { /* XHCI-compliant USB Controller */ { "PNP0D10", }, { } }; MODULE_DEVICE_TABLE(acpi, usb_xhci_acpi_match); +#endif static struct platform_driver usb_xhci_driver = { .probe = xhci_plat_probe,