From patchwork Tue Jul 7 04:52:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colton Lewis X-Patchwork-Id: 11647583 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C7D68912 for ; Tue, 7 Jul 2020 04:52:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF17620708 for ; Tue, 7 Jul 2020 04:52:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="gQ1PMMAe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbgGGEwf (ORCPT ); Tue, 7 Jul 2020 00:52:35 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:15659 "EHLO mail1.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgGGEwf (ORCPT ); Tue, 7 Jul 2020 00:52:35 -0400 Date: Tue, 07 Jul 2020 04:52:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1594097554; bh=5q/H+8yMap6cF7suS0jVAeF0hIctFaxQAHzKYezya8s=; h=Date:To:From:Cc:Reply-To:Subject:From; b=gQ1PMMAejZmgITH489XmQYaurUZIRU55gU+CluReM/vrn9WpYxkt+zrvqwamIaXpQ xokCfT7krd3abRP1m5cGMq9JJl4cLN5MGUKKBEq3+tLkm0bEmA5B4q0zBzUUDeHYQp VfL6r7KciTXTUcSw58+BvOL3qMPmjwvqlOOrstQs= To: gregkh@linuxfoundation.og From: Colton Lewis Cc: balbi@kernel.org, linux-usb@vger.kernel.org, Colton Lewis Reply-To: Colton Lewis Subject: [PATCH 1/2] usb: correct kernel-doc inconsistency Message-ID: <20200707045207.235540-1-colton.w.lewis@protonmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Silence documentation build warning by correcting kernel-doc comment for sub_validate_langid function. ./drivers/usb/gadget/usbstring.c:77: warning: Function parameter or member 'langid' not described in 'usb_validate_langid' ./drivers/usb/gadget/usbstring.c:77: warning: Excess function parameter 'lang' description in 'usb_validate_langid' Signed-off-by: Colton Lewis --- drivers/usb/gadget/usbstring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/usbstring.c b/drivers/usb/gadget/usbstring.c index 58a4d3325090..119505fac777 100644 --- a/drivers/usb/gadget/usbstring.c +++ b/drivers/usb/gadget/usbstring.c @@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string); /** * usb_validate_langid - validate usb language identifiers - * @lang: usb language identifier + * @langid: usb language identifier * * Returns true for valid language identifier, otherwise false. */ From patchwork Tue Jul 7 04:52:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colton Lewis X-Patchwork-Id: 11647585 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 56C4E60D for ; Tue, 7 Jul 2020 04:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F46320771 for ; Tue, 7 Jul 2020 04:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="QK8XmgXl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbgGGEwy (ORCPT ); Tue, 7 Jul 2020 00:52:54 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:55613 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbgGGEwu (ORCPT ); Tue, 7 Jul 2020 00:52:50 -0400 Date: Tue, 07 Jul 2020 04:52:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1594097568; bh=AOCJo4KszPc6cDSEFbOggU0+XbOioihHgRo2YDXQqE4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=QK8XmgXl4qX7h4MqtEOJ1gd8O32hdN+3cYyF6nbH17pP6zRWr+z+NnynbwWfEVUMR 1pbn1ugkWh9CJNDUIPh0Y3pxOY+e6vDDSUk7bWH0AP7X5G+k2CQZa6t/q36wvuYQTo F8nNWIbHcnD7MapFIcrMyK6MzKPtTJOtkIPyp+H4= To: gregkh@linuxfoundation.og From: Colton Lewis Cc: balbi@kernel.org, linux-usb@vger.kernel.org, Colton Lewis Reply-To: Colton Lewis Subject: [PATCH 2/2] usb: correct kernel-doc inconsistency Message-ID: <20200707045207.235540-2-colton.w.lewis@protonmail.com> In-Reply-To: <20200707045207.235540-1-colton.w.lewis@protonmail.com> References: <20200707045207.235540-1-colton.w.lewis@protonmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Silence documentation build warning by correcting kernel-doc comments for usb_device and usb_device_driver structs. ./include/linux/usb.h:713: warning: Function parameter or member 'use_generic_driver' not described in 'usb_device' ./include/linux/usb.h:1253: warning: Function parameter or member 'match' not described in 'usb_device_driver' ./include/linux/usb.h:1253: warning: Function parameter or member 'id_table' not described in 'usb_device_driver' Signed-off-by: Colton Lewis --- include/linux/usb.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/usb.h b/include/linux/usb.h index 9f3c721c70dc..88c80289e51f 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -621,6 +621,7 @@ struct usb3_lpm_parameters { * be manipulated by those functions, with the bandwidth_mutex is held. * @hub_delay: cached value consisting of: * parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns) + * @use_generic_driver: bit is set to use generic usb driver * * Will be used as wValue for SetIsochDelay requests. * @@ -1215,6 +1216,7 @@ struct usb_driver { * struct usb_device_driver - identifies USB device driver to usbcore * @name: The driver name should be unique among USB drivers, * and should normally be the same as the module name. + * @match: Called to see if driver matches a device. * @probe: Called to see if the driver is willing to manage a particular * device. If it is, probe returns zero and uses dev_set_drvdata() * to associate driver-specific data with the device. If unwilling @@ -1227,6 +1229,7 @@ struct usb_driver { * @dev_groups: Attributes attached to the device that will be created once it * is bound to the driver. * @drvwrap: Driver-model core structure wrapper. + * @id_table: Array of device ids supported by this driver. * @supports_autosuspend: if set to 0, the USB core will not allow autosuspend * for devices bound to this driver. * @generic_subclass: if set to 1, the generic USB driver's probe, disconnect,