From patchwork Tue Jul 7 10:16:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648145 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A474912 for ; Tue, 7 Jul 2020 10:18:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 224A5206DF for ; Tue, 7 Jul 2020 10:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pSlp4Zq8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JPaF/Cic" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 224A5206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IGyHunaS0vtOlyLbZiC18mhJL3R690JcOug4ZKse+9M=; b=pSlp4Zq80DJG+bw2orlzvBGet b0aJrzwUM/NCEAfEEs9zjbBxaR9wPn+Q3Wu7fovHaqACOT52eJ6ohdbsY3r3fYDTPc/laSokOq5XS 6+iFdk1+JOJkchPdk4aT83tn2Wn0yMPTKDyZu8l8H/+8bmUfeLYE7Gl5bqP0elY2LP8mHUBLFgS45 Ju1zI19kfWM/jNDbNN3uc0qdQIVqFTKIyWhu6BPW2E3QNYTkJN3UViXExEHSxFMoZXY13R/v8ABwY S9XFhM8hknqAUp4ytQi3aEG7UzU/r6HZ4IHX+TY+HdkhTT77Xq7/4dQzQLeDpcM6Ys5csWLRO49hv yhx4YDK5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskei-00045a-UJ; Tue, 07 Jul 2020 10:16:52 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskef-00044N-7A for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:49 +0000 Received: by mail-wr1-x442.google.com with SMTP id k6so44563098wrn.3 for ; Tue, 07 Jul 2020 03:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X8lNwwZEdxo/c3swk/aA3YOExp2MKHA0sqq87q0a3wI=; b=JPaF/CicEUbbEvjATlnxD7O2L+C/bGJ44q6+XFBdFLiooQUTKPkM6b0DF3WaHnu4JS ljQ5WTYJ0xaTu2U4mv3oOx94WuvUQoFuRkIBSLp8S2hyPW4ZQLvUaGeRMmQZt7cpJj4x m01vqsFt+pXzQBT5G2aTJ3/BjNOhPTnV8UlrL+8wty5YciPoKJ4ARWpjMjBBFNiU1Uhx 9RLT5cN5m8UAT70LX2t+cMicwmn7u5LoXarjAg0/SCZWkFYApjO4j0N51QUXv+ZkdZxI q7sxYY1T4eOP1cuu4pEh2T0MQzepg3MsQdNjmC/63Xv8pzwyBzI699063chxHcX2/rES m0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X8lNwwZEdxo/c3swk/aA3YOExp2MKHA0sqq87q0a3wI=; b=S4V2VgNJy368joTwq0hTYIbFbBBm/B06VQ77eCf/OgbB5RfwQInpqsBUTHhWQxpLjc E73LWPtGst+0xfw7D0JttG8B8FbuBVYqJBCpseWAjdeglLFB2IxSCVg28e/DXLPCmBSn H7M++qW/v3c1ElS9V7OpNH0TRQnilZ/+mTVh189uWq8PFw+mvS8GHdKIuTrIgajSUaRD ELJN/2r0dldJs2m1cDU9PmUac9u7B5U8CrMSeLlKtQ20NQ+6kY5oh11qZs+taTgbmJct EtgZ8anIcytDBliD+S+pPWagDw/ufybEIxUT+iK1VnO1Qgtwa2NOCSc+6q5q2WtSBBij yBsA== X-Gm-Message-State: AOAM533SX0WRy/nuYP12dl3tfAcDNDKyeZsV8tpZAOp8qVQxqZVHfxc0 DNgo0vfk7b4QMn55e8rG5pV/vw== X-Google-Smtp-Source: ABdhPJzoaszx/FMxs1EP+dndZHd/3eQX6gVh8XKr9z6/arTSDiQU05AAnvgjIGjxpvs4zR3pPcZ5+Q== X-Received: by 2002:adf:f888:: with SMTP id u8mr11364000wrp.18.1594117008361; Tue, 07 Jul 2020 03:16:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:47 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 01/28] ASoC: atmel: atmel-pcm-dma: Demote function header which is clearly not kerneldoc Date: Tue, 7 Jul 2020 11:16:15 +0100 Message-Id: <20200707101642.1747944-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061649_275954_CD11A5B4 X-CRM114-Status: GOOD ( 12.93 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Sedji Gaouaou , Ludovic Desroches , Bo Shen , Codrin Ciubotariu , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): sound/soc/atmel/atmel-pcm-dma.c:55: warning: Function parameter or member 'ssc_sr' not described in 'atmel_pcm_dma_irq' sound/soc/atmel/atmel-pcm-dma.c:55: warning: Function parameter or member 'substream' not described in 'atmel_pcm_dma_irq' Cc: Codrin Ciubotariu Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Bo Shen Cc: Sedji Gaouaou Signed-off-by: Lee Jones --- sound/soc/atmel/atmel-pcm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c index cb03c4f7324c9..0a2e956232afe 100644 --- a/sound/soc/atmel/atmel-pcm-dma.c +++ b/sound/soc/atmel/atmel-pcm-dma.c @@ -44,7 +44,7 @@ static const struct snd_pcm_hardware atmel_pcm_dma_hardware = { .buffer_bytes_max = 512 * 1024, }; -/** +/* * atmel_pcm_dma_irq: SSC interrupt handler for DMAENGINE enabled SSC * * We use DMAENGINE to send/receive data to/from SSC so this ISR is only to From patchwork Tue Jul 7 10:16:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E5BB14B7 for ; Tue, 7 Jul 2020 10:18:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4DD520708 for ; Tue, 7 Jul 2020 10:18:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SMw5pWMN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eKf7OQbj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4DD520708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rsnnZVRPrcR/llHwHTnh2ti7U0FgflDsXNdm446Va2A=; b=SMw5pWMNRXHBUgwTJDzt6kIYV EvyiDqCXYy1L6Q1jgUvYsXR01yyqPwRRs4/SUIovYzrpvAfDj/eWj+ZEPwvtURU3dQkr9fT7YQivj m5iwqCNMd7cJ70YcHKtsqK4tCaoJ/64qRW6iPFX446HPjrULnNXt55Vlh7ra66aCfnA+gonFyKQux Fn5vWIpQMgI7MeL0mchjTkk1EyCze6iABcMMF0uUvZOXxh8yUvn9uysEFTHbEPw5LqJtdOGac3jMp UpFJ6j99EcSZ3nQMWD0G1BIR4TzpwYcu/2Z5BZeRFWxvVzGYkU1BG+YznuVutpoUQ3r5A6so+GXua Idey4Cbkg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskep-000481-RX; Tue, 07 Jul 2020 10:16:59 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskeh-00044v-AI for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:52 +0000 Received: by mail-wr1-x443.google.com with SMTP id j4so42131660wrp.10 for ; Tue, 07 Jul 2020 03:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0Ojcexqfn/ZS3noXIMdqlD9+JbA+cGF+iBmDVVcfGM0=; b=eKf7OQbj/SAKIuqAfQubX24p12bDVbV98ZLiLwXpicE8+hlGHR2Lwqg2oTYcLwu/qD Bn5Gn1gBc/1gGzBGsmqTb+Q+gUH+21qv7MFJY6nOjy++f7nMMe8Uoj5EWJRz+g+D/XLb lTtDXG7caO9jtnbnh02SmWHCT20SHTj18dUEk2p19o/ko5C6t0jv1EgkhiXWypF+9X83 Yg2bkKaO/kwFRZb6VQD/FOiRIyeNO8bncKjdrWxHfp/Q3nQSOfaHxzzXXVE8YKEnUc15 o/LFftlJi1GnXMqcbZ9j6KBshO9S1Arc8MHEO5MopHLhfQ3irAsVv5y6Ee972eCGsmtq 8Nyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Ojcexqfn/ZS3noXIMdqlD9+JbA+cGF+iBmDVVcfGM0=; b=ZsGg12TGPxjT6F7lqRtg33etSSQ12eHqh0oqIvd6CRatGpAA/7hskvYqXQW2wBnqev 7/fo578gA0Vk76pSZ0ukwVaagr5zKkunfEDTBsiSsHNLogGDruy53z8vFQy2Ed+gHnXR 0HJgS25i/7RbrbFPd36zhQOivCzzaXe1U4V3D31eha4a+QrGt3zdqiNd9SRUarC6Wv3k ZS844RsU6FpDHBdvcGb/hCOhcKSQy/fzg1gZF/r50WxEdVRUpw8qiLam5X4I5nxKCv5n X7OAs/glkhZSps1SKkfq3JNEaNVgeDYKwlMI70YKhz8TgeLU6ygF3etWvMwpPimPODtv LYdg== X-Gm-Message-State: AOAM533xwdO3en2hVilnLN2Q11kMaNvEGgUNcgVoaZ/H+dUZaeJ4b1DH SbhzaPxShp8X+dQE/864FHugLQ== X-Google-Smtp-Source: ABdhPJxXHqSXuvC/N6FMDoHvlD9BJG1LNiYAOWrAD6I4lg3PAZdm04pKuSFnfS9ZIM3N4PgczWCONg== X-Received: by 2002:a5d:474f:: with SMTP id o15mr50415169wrs.306.1594117009607; Tue, 07 Jul 2020 03:16:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:48 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 02/28] ASoC: atmel: atmel_ssc_dai: Demote function header which is clearly not kerneldoc Date: Tue, 7 Jul 2020 11:16:16 +0100 Message-Id: <20200707101642.1747944-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061651_430178_C03D73D0 X-CRM114-Status: GOOD ( 13.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Sedji Gaouaou , Ludovic Desroches , Frank Mandarino , Codrin Ciubotariu , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): sound/soc/atmel/atmel_ssc_dai.c:892: warning: Function parameter or member 'ssc_id' not described in 'atmel_ssc_set_audio' Cc: Codrin Ciubotariu Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Sedji Gaouaou Cc: Frank Mandarino Signed-off-by: Lee Jones --- sound/soc/atmel/atmel_ssc_dai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 0f18dfb85bfed..3a0335864034a 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -885,7 +885,7 @@ static int asoc_ssc_init(struct device *dev) return 0; } -/** +/* * atmel_ssc_set_audio - Allocate the specified SSC for audio use. */ int atmel_ssc_set_audio(int ssc_id) From patchwork Tue Jul 7 10:16:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648153 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A11AE912 for ; Tue, 7 Jul 2020 10:19:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59A63206F6 for ; Tue, 7 Jul 2020 10:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FhbWbrSZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KWAySNzy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59A63206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uWQkFi5fC2w1MbFmCsOjccm/mMHgeosNptgSc5nInr8=; b=FhbWbrSZrq9Gziw2Inows2yI4 uGiZtaOBmx90GZhy7x4Wd+AKKAdeWtkCB3Of2stdBdvFJHFpE6B5qC2U1QzNJ8WgHIusaFisUQ96W 6CqYl4Y2YebTN5XScVIn+GeS2uwlyacEgaz/Wje6ZO2kZXD732hKhTpXtxjm0kTT8fdnV9c011tU5 9/68eEkR1fwHFJj5L64uMIS/v+N1lBHvlmtnfJgOv2Id9N60iNwDTbMTgnWWjF+ffiO8ZJGOSxCZr Hb4R+Ddi+oJ6s7FePK1eGww1V/WufoVtoe3ABeJ1poUWhWRyiQz4PgKXnoQGYSYnoahaisSDlGmXk 7tqExw4pw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf0-0004Bv-Q9; Tue, 07 Jul 2020 10:17:10 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskei-00045N-Ep for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:53 +0000 Received: by mail-wr1-x443.google.com with SMTP id s10so44500519wrw.12 for ; Tue, 07 Jul 2020 03:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KDb2cHewYsZWIM9X5BweTMn+o+Wme2rV/mNBj7f6Kc0=; b=KWAySNzyfzgA6L35OqDEdMfxyRW6P5mNQ/VoKFi3SPOGxlROBgL/6G+0MYrllTvY+U CwdWcR0JaSnDwr0jP1J9a/WGbXKdNpkAw4F9cqrIhLwhxLXc/QuvLC/+rCJ95WSCocwi 5u8Ofosz9530ws8xxT5Le5pgKaBsFBSqXZ4KnG9+ar+gJv8obmLu8DxsTKzFLZhfNu6X xSbgp8e/buyq7tf5WVYb6aqlEwHk3L1kA1BS0Ar0tAd3bhnm1DgmIL/fQUYbIL0Kz56v HRbSh3uo5DzQiBe0Cs6+GdH1OK9V/sDl1+PEBHLNW8xOmIZjYUq36JRRw1Zo5Z5+Q1ld P1Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KDb2cHewYsZWIM9X5BweTMn+o+Wme2rV/mNBj7f6Kc0=; b=E0lIF0i2RBzLcVmyC8fdD+p/q5Rk+OUDnLbc8oqsEghn0wSJ+Qg/0RIrQOYhGetEMT XEVIz45VXBVtjAaR26gMJWp5tft2PD0Osx1dx6ZRiAzgvNRKOISXMZAzu5fhwKSISxAY cxn1Ca3/H8HuTo09vvbMqKm8CC9kM5HFkYWHKMqN/nVBW0c4EkrpJCWw9CckUc9sFkKo 5dbjC9afj8eOASGCtYtX+IUtx5eCfdWwmwhoPP8N/tgge6+WsEQQ1BBtzQ1etW+G+7RD ClUiyKhHLqhx5rthUsMtiQH2hM0Ia99aMwPhEQ/uuNCucjeGM0wJHUrootYSBwZIlM07 H2cg== X-Gm-Message-State: AOAM5324bDGvN2UXxGGI5zJHEHJrzPIaZnfo3qdsoDTNYQmaY920ZtvE 1JDErl6BnpiN2ifvInxRgflrRw== X-Google-Smtp-Source: ABdhPJyuLSFDg+DgyQWYS0Sp/uZ2Uz32rktUaElyVytRNJtrr6b4EIZCqaiZhAvG7a8BZrItq4OaWA== X-Received: by 2002:a5d:69c5:: with SMTP id s5mr53007426wrw.197.1594117011646; Tue, 07 Jul 2020 03:16:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:51 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 03/28] ASoC: fsl: fsl-asoc-card: Use correct format when providing struct documentation Date: Tue, 7 Jul 2020 11:16:17 +0100 Message-Id: <20200707101642.1747944-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061652_580357_88FD1B9A X-CRM114-Status: GOOD ( 11.85 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Struct kerneldoc headers need to be prefixed with 'struct $NAME', else the checker gets confused. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl-asoc-card.c:43: warning: cannot understand function prototype: 'struct codec_priv ' sound/soc/fsl/fsl-asoc-card.c:60: warning: cannot understand function prototype: 'struct cpu_priv ' sound/soc/fsl/fsl-asoc-card.c:83: warning: cannot understand function prototype: 'struct fsl_asoc_card_priv ' sound/soc/fsl/fsl-asoc-card.c:104: warning: cannot understand function prototype: 'const struct snd_soc_dapm_route audio_map[] = ' Also the size of the struct does not belong in the description: sound/soc/fsl/fsl-asoc-card.c:65: warning: Function parameter or member 'sysclk_freq' not described in 'cpu_priv' sound/soc/fsl/fsl-asoc-card.c:65: warning: Function parameter or member 'sysclk_dir' not described in 'cpu_priv' sound/soc/fsl/fsl-asoc-card.c:65: warning: Function parameter or member 'sysclk_id' not described in 'cpu_priv' sound/soc/fsl/fsl-asoc-card.c:95: warning: Function parameter or member 'dai_link' not described in 'fsl_asoc_card_priv' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl-asoc-card.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 57ea1b072326b..3b1fd8c9316d8 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -33,7 +33,7 @@ #define DAI_FMT_BASE (SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF) /** - * CODEC private data + * struct codec_priv - CODEC private data * * @mclk_freq: Clock rate of MCLK * @mclk_id: MCLK (or main clock) id for set_sysclk() @@ -48,11 +48,11 @@ struct codec_priv { }; /** - * CPU private data + * struct cpu_priv - CPU private data * - * @sysclk_freq[2]: SYSCLK rates for set_sysclk() - * @sysclk_dir[2]: SYSCLK directions for set_sysclk() - * @sysclk_id[2]: SYSCLK ids for set_sysclk() + * @sysclk_freq: SYSCLK rates for set_sysclk() + * @sysclk_dir: SYSCLK directions for set_sysclk() + * @sysclk_id: SYSCLK ids for set_sysclk() * @slot_width: Slot width of each frame * * Note: [1] for tx and [0] for rx @@ -65,9 +65,9 @@ struct cpu_priv { }; /** - * Freescale Generic ASOC card private data + * struct fsl_asoc_card_priv - Freescale Generic ASOC card private data * - * @dai_link[3]: DAI link structure including normal one and DPCM link + * @dai_link: DAI link structure including normal one and DPCM link * @pdev: platform device pointer * @codec_priv: CODEC private data * @cpu_priv: CPU private data @@ -94,7 +94,7 @@ struct fsl_asoc_card_priv { char name[32]; }; -/** +/* * This dapm route map exsits for DPCM link only. * The other routes shall go through Device Tree. * From patchwork Tue Jul 7 10:16:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648155 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1793912 for ; Tue, 7 Jul 2020 10:19:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79DE7206DF for ; Tue, 7 Jul 2020 10:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a/r8WfD4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZKwj3HHw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79DE7206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G23BlIeRAJNfTJ5bWbYtw9gLLhcF1NzQ8EJO48haxQc=; b=a/r8WfD4TjncZyUOImnPy5t1H yNiOTaC/wdfXQDvt/NBRV6fo9OS3mId9gxS1ZAfkAytv9SBQdR0LS+e/0sMOdI6giFd24nVimnlZk Li8TkxAVxzPXNTCN06QjqH5O+yermqJiojHdZxgcmplx5HRBShD97kIcKt8x5uhrWcZi/c+hl/Oc5 ZzE3tTPPQ7254vkwsVOClze2yX74RznoksrZPCOXwxcFmoHIjs8HX35TanjtN7ROD4r3S9NlfHB26 Rgsw2sd9C+OxeNKBDyEdRVXdpkjKSHyfBM0tsFwcRLQ0WEO8zXLZSPEm/i76xKbtc5V1I29C2+c2A UeC3Npl8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfI-0004MX-Cr; Tue, 07 Jul 2020 10:17:28 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskej-00045v-QT for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:55 +0000 Received: by mail-wm1-x341.google.com with SMTP id a6so1413650wmm.0 for ; Tue, 07 Jul 2020 03:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WA9dG36UknQVCp/Rfsks+W3xsfkt4WlYU9zyAfbsCgQ=; b=ZKwj3HHwQOk7yXe4WVIDlXiwgYKi35YtfQOQBLtduNJaim5iOiInCvN13A/ysgBTFA gid3Y1lntBVYfmTMVDpyzc5Dpl8m16t8Jmkd33+lgwA+zsTrLp9Z616D7dJuQEiEaqwO xhLycdc4APcvWyNwd2DH6fBd6ToPPhQ4SLe5Q8uYSdU8kTWwRVjT0JLT2uqIRYnuU0yZ //VZ8EBQVJv7gy0gQdMd9vdEqaX5MCkItW3oM2WVNZXGH7o0W+6cGt3kbz+cAiWIleC6 zj2SRmISQNV9o+ZRxaou75jIdRInodNYBtvGpqOlkAfZlEF9nqmJCeYzQc7IUAgDIhs6 NH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WA9dG36UknQVCp/Rfsks+W3xsfkt4WlYU9zyAfbsCgQ=; b=P1FplM435qmpcYq72LFEB6BeLEx6RJ1mMGOUFQmruX/qwUd2RbyNTFqDxstgCpU+Sb s1lDDTYIMFPdznEkFYlaXWO8SvR9GK6RoQoN4nqFYOywcZJYc118z6CQ2LI3PZNy3aKf fDsAPcfp6y0qoQFUDkU5DwY9Dp0I5+mq3Le4Ye/GNaPf2lT1krIb97F9sMHSO7Okjhak MQSXcdKL7SZNfQILZXsq52vTXS8DXuzHdIPxzdqBn6ob59L1hARY6uESI8cR4aaPpxnC BRP+p4doqQYNNNVbs3IicXb4h4eT/wvf/F+cryX2GDRd05tVixh7vOU+m14xxT2f8E08 VLig== X-Gm-Message-State: AOAM530A8Lpep6g4KZvjzyEPay8jFS/Wfbe19seyw9txKoH1pMwJyF8G xALluCCw+lTvEfwEZKHk82t6q4KH0/o= X-Google-Smtp-Source: ABdhPJwfe7mJl2Nlvy7MUCw7TJuJtcEgvNqi1W6VVbo7nbbTXXlCa6Y7P3z77mktRj4O6UVPNWCFTA== X-Received: by 2002:a1c:3245:: with SMTP id y66mr3228476wmy.64.1594117012898; Tue, 07 Jul 2020 03:16:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:52 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 04/28] ASoC: fsl: fsl_asrc: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 7 Jul 2020 11:16:18 +0100 Message-Id: <20200707101642.1747944-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061653_991841_CC51C00E X-CRM114-Status: GOOD ( 13.73 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_asrc.c:44: warning: cannot understand function prototype: 'unsigned char input_clk_map_imx35[ASRC_CLK_MAP_LEN] = ' sound/soc/fsl/fsl_asrc.c:78: warning: cannot understand function prototype: 'unsigned char clk_map_imx8qm[2][ASRC_CLK_MAP_LEN] = ' sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'inrate' not described in 'fsl_asrc_sel_proc' sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'outrate' not described in 'fsl_asrc_sel_proc' sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'pre_proc' not described in 'fsl_asrc_sel_proc' sound/soc/fsl/fsl_asrc.c:118: warning: Function parameter or member 'post_proc' not described in 'fsl_asrc_sel_proc' sound/soc/fsl/fsl_asrc.c:158: warning: Function parameter or member 'channels' not described in 'fsl_asrc_request_pair' sound/soc/fsl/fsl_asrc.c:158: warning: Function parameter or member 'pair' not described in 'fsl_asrc_request_pair' sound/soc/fsl/fsl_asrc.c:201: warning: Function parameter or member 'pair' not described in 'fsl_asrc_release_pair' sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'pair' not described in 'fsl_asrc_set_watermarks' sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'in' not described in 'fsl_asrc_set_watermarks' sound/soc/fsl/fsl_asrc.c:223: warning: Function parameter or member 'out' not described in 'fsl_asrc_set_watermarks' sound/soc/fsl/fsl_asrc.c:242: warning: Function parameter or member 'pair' not described in 'fsl_asrc_cal_asrck_divisor' sound/soc/fsl/fsl_asrc.c:242: warning: Function parameter or member 'div' not described in 'fsl_asrc_cal_asrck_divisor' sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'pair' not described in 'fsl_asrc_set_ideal_ratio' sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'inrate' not described in 'fsl_asrc_set_ideal_ratio' sound/soc/fsl/fsl_asrc.c:259: warning: Function parameter or member 'outrate' not described in 'fsl_asrc_set_ideal_ratio' sound/soc/fsl/fsl_asrc.c:310: warning: Function parameter or member 'pair' not described in 'fsl_asrc_config_pair' sound/soc/fsl/fsl_asrc.c:310: warning: Function parameter or member 'use_ideal_rate' not described in 'fsl_asrc_config_pair' sound/soc/fsl/fsl_asrc.c:516: warning: Function parameter or member 'pair' not described in 'fsl_asrc_start_pair' sound/soc/fsl/fsl_asrc.c:545: warning: Function parameter or member 'pair' not described in 'fsl_asrc_stop_pair' sound/soc/fsl/fsl_asrc.c:559: warning: Function parameter or member 'pair' not described in 'fsl_asrc_get_dma_channel' sound/soc/fsl/fsl_asrc.c:559: warning: Function parameter or member 'dir' not described in 'fsl_asrc_get_dma_channel' sound/soc/fsl/fsl_asrc.c:902: warning: Function parameter or member 'asrc' not described in 'fsl_asrc_init' sound/soc/fsl/fsl_asrc.c:936: warning: Function parameter or member 'irq' not described in 'fsl_asrc_isr' sound/soc/fsl/fsl_asrc.c:936: warning: Function parameter or member 'dev_id' not described in 'fsl_asrc_isr' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_asrc.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 462ce9f9ab488..209bf80dc3670 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -37,7 +37,7 @@ static struct snd_pcm_hw_constraint_list fsl_asrc_rate_constraints = { .list = supported_asrc_rate, }; -/** +/* * The following tables map the relationship between asrc_inclk/asrc_outclk in * fsl_asrc.h and the registers of ASRCSR */ @@ -68,7 +68,7 @@ static unsigned char output_clk_map_imx53[ASRC_CLK_MAP_LEN] = { 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, 0x7, }; -/** +/* * i.MX8QM/i.MX8QXP uses the same map for input and output. * clk_map_imx8qm[0] is for i.MX8QM asrc0 * clk_map_imx8qm[1] is for i.MX8QM asrc1 @@ -101,7 +101,7 @@ static unsigned char clk_map_imx8qxp[2][ASRC_CLK_MAP_LEN] = { }, }; -/** +/* * Select the pre-processing and post-processing options * Make sure to exclude following unsupported cases before * calling this function: @@ -147,7 +147,7 @@ static void fsl_asrc_sel_proc(int inrate, int outrate, *post_proc = 1; } -/** +/* * Request ASRC pair * * It assigns pair by the order of A->C->B because allocation of pair B, @@ -192,7 +192,7 @@ static int fsl_asrc_request_pair(int channels, struct fsl_asrc_pair *pair) return ret; } -/** +/* * Release ASRC pair * * It clears the resource from asrc and releases the occupied channels. @@ -216,7 +216,7 @@ static void fsl_asrc_release_pair(struct fsl_asrc_pair *pair) spin_unlock_irqrestore(&asrc->lock, lock_flags); } -/** +/* * Configure input and output thresholds */ static void fsl_asrc_set_watermarks(struct fsl_asrc_pair *pair, u32 in, u32 out) @@ -233,7 +233,7 @@ static void fsl_asrc_set_watermarks(struct fsl_asrc_pair *pair, u32 in, u32 out) ASRMCRi_OUTFIFO_THRESHOLD(out)); } -/** +/* * Calculate the total divisor between asrck clock rate and sample rate * * It follows the formula clk_rate = samplerate * (2 ^ prescaler) * divider @@ -249,7 +249,7 @@ static u32 fsl_asrc_cal_asrck_divisor(struct fsl_asrc_pair *pair, u32 div) return ((div - 1) << ASRCDRi_AxCPi_WIDTH) | ps; } -/** +/* * Calculate and set the ratio for Ideal Ratio mode only * * The ratio is a 32-bit fixed point value with 26 fractional bits. @@ -292,7 +292,7 @@ static int fsl_asrc_set_ideal_ratio(struct fsl_asrc_pair *pair, return 0; } -/** +/* * Configure the assigned ASRC pair * * It configures those ASRC registers according to a configuration instance @@ -507,7 +507,7 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair *pair, bool use_ideal_rate) return fsl_asrc_set_ideal_ratio(pair, inrate, outrate); } -/** +/* * Start the assigned ASRC pair * * It enables the assigned pair and makes it stopped at the stall level. @@ -538,7 +538,7 @@ static void fsl_asrc_start_pair(struct fsl_asrc_pair *pair) regmap_write(asrc->regmap, REG_ASRIER, ASRIER_AOLIE); } -/** +/* * Stop the assigned ASRC pair */ static void fsl_asrc_stop_pair(struct fsl_asrc_pair *pair) @@ -551,7 +551,7 @@ static void fsl_asrc_stop_pair(struct fsl_asrc_pair *pair) ASRCTR_ASRCEi_MASK(index), 0); } -/** +/* * Get DMA channel according to the pair and direction. */ static struct dma_chan *fsl_asrc_get_dma_channel(struct fsl_asrc_pair *pair, @@ -895,7 +895,7 @@ static const struct regmap_config fsl_asrc_regmap_config = { .cache_type = REGCACHE_FLAT, }; -/** +/* * Initialize ASRC registers with a default configurations */ static int fsl_asrc_init(struct fsl_asrc *asrc) @@ -929,7 +929,7 @@ static int fsl_asrc_init(struct fsl_asrc *asrc) return regmap_write(asrc->regmap, REG_ASR56K, ipg_rate / 56000); } -/** +/* * Interrupt handler for ASRC */ static irqreturn_t fsl_asrc_isr(int irq, void *dev_id) From patchwork Tue Jul 7 10:16:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648159 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 559EA14B7 for ; Tue, 7 Jul 2020 10:19:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B413D20702 for ; Tue, 7 Jul 2020 10:19:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H+woBh6o"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y0gY2Sy9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B413D20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hKxOZuSeGPAvPRdcgjkLFy0qWiuvWlYtuZnMVSI96Ws=; b=H+woBh6oDKx/THAKeFaRFvEWK Tv2LYr+N5GGAqUS+Mxy7CHxtk+6Ws4jpPyDgs1Ss1HBZULfxLYGzwAJQaT0CsA5DHWZASItmRFE1R bZ23GaKK6W6+JZvD13I10SL2ZV8/GPP8yRurLCOeKFeBDjnAftXsSuSFB9hv3czSWSC4Ic6KWMlXb B9S4Lxzbvb5gq6PuGw2KAKU8tN3q7hiLuz89gWmThwq+86GzF/ow5KSuEnuMluXxLq5UsxhKKPhvd z7ooVC72qJRwIFnkbCvGGIV1Z0diUYYRh425Avo3Ek/1H86kK0g7bLXFp0myeFYe444H17oDQ7GLt eU6nonAhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfY-0004QL-8B; Tue, 07 Jul 2020 10:17:44 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskel-00046Q-3N for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:56 +0000 Received: by mail-wr1-x442.google.com with SMTP id f18so36485019wrs.0 for ; Tue, 07 Jul 2020 03:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8ZEmbLq4aOW35ukJy4E78RGy/Qq2YYTCi7Pk4jUv8mI=; b=Y0gY2Sy9AnIXxGPBMPafdM/OU+9ALGKd8+XAf10BdrSVdmVXMQ3Drjdux2AMMLpIff I9bHd7e1F6GPWDyeNwpRf5NJl51RBzzacMIqXloYMMCBSl8luOL9X9Vlh2wVEddLyVzH X/EglPfk6GL5tncqxuYjwHRyb9k89v9BbmrAsS/STklgO/FkJI/85N9CuLpAYoYifrY8 m9rysfNJHAiL9ccDW9o8UiDwstNbizR9NdPn2J2Sl1EeTmUz+hEEOxWPUxRA1Ze5DYoF uvYdXCkL+aLfmYJDTbvIyEzfu1DeN08knBxZdKrkCHIPtTnNlqsFQH5mepXeDajhBjxs UYvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8ZEmbLq4aOW35ukJy4E78RGy/Qq2YYTCi7Pk4jUv8mI=; b=qwm4fkOQyiOBaaJNma17FTxgpNsmoV0e04AHxyaYZgGpmTSbyjorjSq3sAMawBvZLf bAxeJtk7HjnuLPMsZc0UZt3XN554i6WFjAp5ZAM8svVbQBcszU/2qdtQVhWvInWAbrkv R5sQHHb9Ptkj5vXBy4GRVJtdi8I9ZfrUCIGQmZekH6W/N0FFroZm/lcV7YtrzhxU7PN8 6jSO9nwkYLd+ubIaDEa9vX9Yvqp+19Kcz3z6StHIZeam0GHXNhIwxW1V35EDxN9k39T+ sN5rsZFqHnQWhbL9+UPTpE9kwmc7nBMtSOnNPfx/h7zRHSUNcNQ7g0tnIgxow0vfDOiy nwPw== X-Gm-Message-State: AOAM533XiiXmAfYqlT90+9Gjn4gWNi/dv/Y/uWeA3Gqa1HhF0H5bcZD2 NqMO6pomJom2Mb4wiVfw8cjECg== X-Google-Smtp-Source: ABdhPJxbWYN/EZ506zCfhQGem0UtKR9JftLPkvuSL9odppwn/+9aRct/FXJzmr1kyNsbYQyI9tSEhw== X-Received: by 2002:adf:edc8:: with SMTP id v8mr52127368wro.125.1594117014212; Tue, 07 Jul 2020 03:16:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:53 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 05/28] ASoC: fsl: fsl_ssi: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 7 Jul 2020 11:16:19 +0100 Message-Id: <20200707101642.1747944-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061655_345320_0611C984 X-CRM114-Status: GOOD ( 14.14 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_ssi.c:380: warning: Function parameter or member 'irq' not described in 'fsl_ssi_isr' sound/soc/fsl/fsl_ssi.c:380: warning: Function parameter or member 'dev_id' not described in 'fsl_ssi_isr' sound/soc/fsl/fsl_ssi.c:406: warning: Function parameter or member 'ssi' not described in 'fsl_ssi_config_enable' sound/soc/fsl/fsl_ssi.c:406: warning: Function parameter or member 'tx' not described in 'fsl_ssi_config_enable' sound/soc/fsl/fsl_ssi.c:506: warning: Function parameter or member 'ssi' not described in 'fsl_ssi_config_disable' sound/soc/fsl/fsl_ssi.c:506: warning: Function parameter or member 'tx' not described in 'fsl_ssi_config_disable' sound/soc/fsl/fsl_ssi.c:583: warning: Function parameter or member 'ssi' not described in 'fsl_ssi_setup_regvals' sound/soc/fsl/fsl_ssi.c:675: warning: Function parameter or member 'substream' not described in 'fsl_ssi_set_bclk' sound/soc/fsl/fsl_ssi.c:675: warning: Function parameter or member 'dai' not described in 'fsl_ssi_set_bclk' sound/soc/fsl/fsl_ssi.c:675: warning: Function parameter or member 'hw_params' not described in 'fsl_ssi_set_bclk' sound/soc/fsl/fsl_ssi.c:798: warning: Function parameter or member 'substream' not described in 'fsl_ssi_hw_params' sound/soc/fsl/fsl_ssi.c:798: warning: Function parameter or member 'hw_params' not described in 'fsl_ssi_hw_params' sound/soc/fsl/fsl_ssi.c:798: warning: Function parameter or member 'dai' not described in 'fsl_ssi_hw_params' sound/soc/fsl/fsl_ssi.c:1003: warning: Function parameter or member 'dai' not described in 'fsl_ssi_set_dai_fmt' sound/soc/fsl/fsl_ssi.c:1003: warning: Function parameter or member 'fmt' not described in 'fsl_ssi_set_dai_fmt' sound/soc/fsl/fsl_ssi.c:1018: warning: Function parameter or member 'dai' not described in 'fsl_ssi_set_dai_tdm_slot' sound/soc/fsl/fsl_ssi.c:1018: warning: Function parameter or member 'tx_mask' not described in 'fsl_ssi_set_dai_tdm_slot' sound/soc/fsl/fsl_ssi.c:1018: warning: Function parameter or member 'rx_mask' not described in 'fsl_ssi_set_dai_tdm_slot' sound/soc/fsl/fsl_ssi.c:1018: warning: Function parameter or member 'slots' not described in 'fsl_ssi_set_dai_tdm_slot' sound/soc/fsl/fsl_ssi.c:1018: warning: Function parameter or member 'slot_width' not described in 'fsl_ssi_set_dai_tdm_slot' sound/soc/fsl/fsl_ssi.c:1065: warning: Function parameter or member 'substream' not described in 'fsl_ssi_trigger' sound/soc/fsl/fsl_ssi.c:1065: warning: Function parameter or member 'cmd' not described in 'fsl_ssi_trigger' sound/soc/fsl/fsl_ssi.c:1065: warning: Function parameter or member 'dai' not described in 'fsl_ssi_trigger' sound/soc/fsl/fsl_ssi.c:1245: warning: Function parameter or member 'ssi' not described in 'fsl_ssi_hw_init' sound/soc/fsl/fsl_ssi.c:1274: warning: Function parameter or member 'ssi' not described in 'fsl_ssi_hw_clean' sound/soc/fsl/fsl_ssi.c:1292: warning: Function parameter or member 's' not described in 'make_lowercase' Also use correct formatting when documenting structs: sound/soc/fsl/fsl_ssi.c:258: warning: cannot understand function prototype: 'struct fsl_ssi ' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_ssi.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 1a2fa7f181423..5717d664cde1e 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -203,7 +203,7 @@ struct fsl_ssi_soc_data { }; /** - * fsl_ssi: per-SSI private data + * struct fsl_ssi - per-SSI private data * * @regs: Pointer to the regmap registers * @irq: IRQ of this SSI @@ -373,7 +373,7 @@ static bool fsl_ssi_is_i2s_cbm_cfs(struct fsl_ssi *ssi) SND_SOC_DAIFMT_CBM_CFS; } -/** +/* * Interrupt handler to gather states */ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id) @@ -394,7 +394,7 @@ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * Set SCR, SIER, STCR and SRCR registers with cached values in regvals * * Notes: @@ -474,7 +474,7 @@ static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx) ssi->streams |= BIT(dir); } -/** +/* * Exclude bits that are used by the opposite stream * * When both streams are active, disabling some bits for the current stream @@ -494,7 +494,7 @@ static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx) #define ssi_excl_shared_bits(vals, avals, aactive) \ ((vals) & _ssi_xor_shared_bits(vals, avals, aactive)) -/** +/* * Unset SCR, SIER, STCR and SRCR registers with cached values in regvals * * Notes: @@ -576,7 +576,7 @@ static void fsl_ssi_tx_ac97_saccst_setup(struct fsl_ssi *ssi) } } -/** +/* * Cache critical bits of SIER, SRCR, STCR and SCR to later set them safely */ static void fsl_ssi_setup_regvals(struct fsl_ssi *ssi) @@ -660,7 +660,7 @@ static void fsl_ssi_shutdown(struct snd_pcm_substream *substream, clk_disable_unprepare(ssi->clk); } -/** +/* * Configure Digital Audio Interface bit clock * * Note: This function can be only called when using SSI as DAI master @@ -781,7 +781,7 @@ static int fsl_ssi_set_bclk(struct snd_pcm_substream *substream, return 0; } -/** +/* * Configure SSI based on PCM hardware parameters * * Notes: @@ -996,7 +996,7 @@ static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt) return 0; } -/** +/* * Configure Digital Audio Interface (DAI) Format */ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) @@ -1010,7 +1010,7 @@ static int fsl_ssi_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) return _fsl_ssi_set_dai_fmt(ssi, fmt); } -/** +/* * Set TDM slot number and slot width */ static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask, @@ -1054,7 +1054,7 @@ static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *dai, u32 tx_mask, return 0; } -/** +/* * Start or stop SSI and corresponding DMA transaction. * * The DMA channel is in external master start and pause mode, which @@ -1238,7 +1238,7 @@ static struct snd_ac97_bus_ops fsl_ssi_ac97_ops = { .write = fsl_ssi_ac97_write, }; -/** +/* * Initialize SSI registers */ static int fsl_ssi_hw_init(struct fsl_ssi *ssi) @@ -1267,7 +1267,7 @@ static int fsl_ssi_hw_init(struct fsl_ssi *ssi) return 0; } -/** +/* * Clear SSI registers */ static void fsl_ssi_hw_clean(struct fsl_ssi *ssi) @@ -1285,7 +1285,7 @@ static void fsl_ssi_hw_clean(struct fsl_ssi *ssi) regmap_update_bits(ssi->regs, REG_SSI_SCR, SSI_SCR_SSIEN, 0); } } -/** +/* * Make every character in a string lower-case */ static void make_lowercase(char *s) From patchwork Tue Jul 7 10:16:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648161 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5C155912 for ; Tue, 7 Jul 2020 10:19:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3D5D20702 for ; Tue, 7 Jul 2020 10:19:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sqxyA6WT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WAOUaxcv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3D5D20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0+TeMhIoTIJ8Oa9O8N+CCSjSKpW1SZrukvHSiqN1JsQ=; b=sqxyA6WTWCtw0IHF4ZaF5jZtu 6Zpy/kOaRGqodYcXAr069VRUghQBsvHwK7SwIcoFgOirWH+GhsUoNDXLdegLlMB8jVJtc2m3CU3PB mAEzL3TCPoZkSvcFAAQLA59rRUxaELNrVz0GKd9MYgBTm6UnYyS0u9FPSUAD0fsjC0yb8MYhhE5zG U/a/TgRmu+JtFDlp5ogV498zpl+MUtwyJwHw/5cle8njYXmX7xQfBjFPZVbBSdeDMJY8ZW+ImCTuf APAjEfONLTObkmEqK7OPoYc9cg90BsX3MT8Fe2+H/hs3RE3vnmT2UkVv2IMq9rKlisMB70Z3v6qCv Sia8ppZ+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfk-0004W3-NA; Tue, 07 Jul 2020 10:17:56 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskem-000474-SG for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:57 +0000 Received: by mail-wr1-x442.google.com with SMTP id z13so44550829wrw.5 for ; Tue, 07 Jul 2020 03:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3bZAeFSvmpf6EGc1Rrn0+wIXui3QoI3bJ6wz54zb8+8=; b=WAOUaxcvTIM+kgWqOPLkQO4t70ks1L8rcPeDMg8pQrArTyQIPJe3qJ2b6X9yfmIOtN FoVH/1sxUaBU+lLS1q0NXqVn5rMbuOrXCOjCTVQCkvErCympXu/1zVBbW/R6A5BJVKZo ByWRWPmFEchS4xkyIHSzSz9G9RHBo8c+Q+WD5keTRSHptVe9L/hfTEHJnKm14KCr+WfK 7ld7Tl3ZD7VAdo7qF1vXsXViNmFFwcCzjktzAES9B/Keda+pdD/MBrNHF8hm9AnHEIBF p8DUsIDCLdkfuJnhk/kQKKIwxnmabi7l1DNAVoRo6wPW3rjq/h4AOh8/swp1letY5w+p v9Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3bZAeFSvmpf6EGc1Rrn0+wIXui3QoI3bJ6wz54zb8+8=; b=XQb6ogM6xtI5GtI37Z9dSAAZi8xifhXk7F9eQovo5vtZKr9YB8bM6U80vzxqiI1pQ6 R0zrQYjZJnJI1+8brHdZ7jPJ3Kza2g88SBDuY+2TFcrPB/P/apOLwmqUCxiOC9/pqO1y JpIwpx2YgcbToxsRoI26i621ZXwYv5OTN2gtDlC5hX+24vbnJYxGtJ7oa72sm23PkdBB 75RhDpi6kD7vSDFq1DtpPMYFRUUvxu48S8mkX4I1pc0iKyIn1KEwTtw2OcI0KWOCAYJ+ I2Rj1UHjDxWR0xmVpfVpumNWrFX2SwV1nJUEZgLT1l6tDRI6WgcE7F+iFnJ2H73OlbF3 z57Q== X-Gm-Message-State: AOAM532CRWvq7oXNCtIqaABAI5eyHDtVWGYUdabJx9a5oNpXgqb0SuBn 4q8GsAe9ndB63m1ah+GUDfYDew== X-Google-Smtp-Source: ABdhPJxe7ZibCsreBnej5nYrQVJiRA2C6Ue1mU4csLgJ2IUwGSMta3Aa6li7Bu4sjMAwkzjp/Id2dQ== X-Received: by 2002:adf:fe0e:: with SMTP id n14mr52181174wrr.325.1594117015828; Tue, 07 Jul 2020 03:16:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:54 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 06/28] ASoC: fsl: fsl_ssi_dbg: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 7 Jul 2020 11:16:20 +0100 Message-Id: <20200707101642.1747944-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061656_961271_E64E38EF X-CRM114-Status: GOOD ( 13.15 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Markus Pargmann , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_ssi_dbg.c:90: warning: Function parameter or member 'flag' not described in 'SIER_SHOW' sound/soc/fsl/fsl_ssi_dbg.c:90: warning: Function parameter or member 'name' not described in 'SIER_SHOW' sound/soc/fsl/fsl_ssi_dbg.c:99: warning: Function parameter or member 's' not described in 'fsl_ssi_stats_show' sound/soc/fsl/fsl_ssi_dbg.c:99: warning: Function parameter or member 'unused' not described in 'fsl_ssi_stats_show' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: Markus Pargmann Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_ssi_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c index 2a20ee23dc52d..2c46c55f0a882 100644 --- a/sound/soc/fsl/fsl_ssi_dbg.c +++ b/sound/soc/fsl/fsl_ssi_dbg.c @@ -78,7 +78,7 @@ void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *dbg, u32 sisr) dbg->stats.tfe0++; } -/** +/* * Show the statistics of a flag only if its interrupt is enabled * * Compilers will optimize it to a no-op if the interrupt is disabled @@ -90,7 +90,7 @@ void fsl_ssi_dbg_isr(struct fsl_ssi_dbg *dbg, u32 sisr) } while (0) -/** +/* * Display the statistics for the current SSI device * * To avoid confusion, only show those counts that are enabled From patchwork Tue Jul 7 10:16:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648163 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EC3FA912 for ; Tue, 7 Jul 2020 10:19:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1F0F206DF for ; Tue, 7 Jul 2020 10:19:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yAUnC/Px"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yjtJryfp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1F0F206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bArgnekgG3jBAoK4bG+hSbP+l21WZflRA859SYPYAIs=; b=yAUnC/Pxs5MFU2lcYhNNdKvw7 S+ycn0GrmspHonecB9lKGn3Z2RUo4CDzuCYrxL9Gd4wqa3aG5CFveazH3gr3A7z1wKUpRobe169OG BEcgpbqBQpDqp/bbmw2x182SP0bpxCPtqtgNB5BEKhEhXVIflzkP9DE5PqdCvRhH5YqNZ81oF/u32 6I62ZXT2GfQElqIiS9AQE6UmpnDypfvIWQY1xxj9JKzg6T176rwJlZ7Jegxylvm2vjmBiRTvR6e+q HH/Dj7ekUl9BWtL7c4om8AJT/C+Qb8aqshAeiWBz1dxFJQYAwTEGpo5DB+kY2ryY0MVj+kwtAmE8Y U5otDBoew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfr-0004Zd-Tp; Tue, 07 Jul 2020 10:18:04 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskeo-00047l-DI for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:16:59 +0000 Received: by mail-wr1-x443.google.com with SMTP id q5so44517455wru.6 for ; Tue, 07 Jul 2020 03:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pNlZaQWHbaIHYTs0iyc+dtmoOXHEctaupDIvIqecIP4=; b=yjtJryfpQL6B6O+GfgFViYidP0Zfm2TNnBAeSexpzgadJ0xpgfrAVW4b+dn87kGz6C EZ20LZ2Ach4spz+6mWWhfonGFfs2/rcy9nw1nAUr6v3gjXQ3E0cGVWpLruB6V7BWcVKA NCL298eJZDj7ZhP4xvIuCDI1BvtD35Mo5E9bGkX6iUv4iYAAQPpZP38IaOr9k6wvCT0n Jauv59h1FuWhqhRbx4pA4BUC4us6dOrcZW5shkE7d6GTM45WW2uOaKGiuBEwVYlhIvDm Ht9quBZq0GIUYGteKk4rPBi59T6GO0mAXIXQ0Kg0IC8E0hgNv6gc97KOTf9D6n8+RNH2 QigA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pNlZaQWHbaIHYTs0iyc+dtmoOXHEctaupDIvIqecIP4=; b=j3pUUS6ralBvob67YKjrbmA7SaE7AYOdKcqKR8xGxJC4oideuyBxd+KzCySvJCaOw4 gW+gcEMKUs4cPEOc+f2Fw30yG3n8gsUhMKvttSc1bsA96ST55XUXagsXsTAOIDnvpCcL GkaP9rTJPZEeoULs0Bm1vKc/+P8CGXoKgDxO08E0wji5D+rzP315DJz7ILTd7Bc2ALYH PPLd+AqPky1nninDegeU4zpBjXVoyL01orv7oxJQxQwTxbIwJL/CQc4xQODYAotVzpzs bIr8avOvZ1gIRt/uUrdhIaCLHZri9Ek5miRObje3xO+kTMhmZMPhVKqgXBEl7xmOGCB4 SC2Q== X-Gm-Message-State: AOAM530woXy+AiNNsgNPntSjNdLCH8XD8CFcxjs79JF8WtN0Hlb5POCI yS9x0o9tYM7uXytXINf/9GwlOg== X-Google-Smtp-Source: ABdhPJwPGZGh7haWMlGt/1TcC8QGkDnJP2knf1a1NGX34zsnQYiFoWMcsNgAkfwT9eECzK95dCDJuA== X-Received: by 2002:a5d:484b:: with SMTP id n11mr50993417wrs.320.1594117017437; Tue, 07 Jul 2020 03:16:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:56 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 07/28] ASoC: fsl: fsl_spdif: Use correct formatting when denoting struct documentation Date: Tue, 7 Jul 2020 11:16:21 +0100 Message-Id: <20200707101642.1747944-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061658_510887_A7B6CECF X-CRM114-Status: GOOD ( 12.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Barinov , alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects struct documentation to start with "struct $NAME". Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_spdif.c:104: warning: cannot understand function prototype: 'struct fsl_spdif_priv ' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: Vladimir Barinov Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 5b2689ae63d4d..7aa3bdec5b6b5 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -81,7 +81,7 @@ struct spdif_mixer_control { }; /** - * fsl_spdif_priv: Freescale SPDIF private data + * struct fsl_spdif_priv - Freescale SPDIF private data * * @fsl_spdif_control: SPDIF control data * @cpu_dai_drv: cpu dai driver From patchwork Tue Jul 7 10:16:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648165 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1ABB96C1 for ; Tue, 7 Jul 2020 10:20:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E70942065F for ; Tue, 7 Jul 2020 10:20:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bJeCWX6K"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qrsas+PZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E70942065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Gcrn2HDfudnCPxdYrWrFg9irOGHWF9D8+Ka3gRmLIw=; b=bJeCWX6KfhQWhmath3TB5mAmr zviQG4jSLbsyJyWUaGMTOR7nn+YJRyZYoSANKzD7iKLdAoYQdUrIZ42dM3llboR8yjMtBVFIlZK5h NcnsaaJF6m9a1uHS9Ng2+Huuf4aTn8UpKIC0bT2JVQVHKaMz6Yi8h1z+GTWg3YiI2GV9I0tQH/c+/ 6LkbtYElrj0b2qt3B/R/40fjuobecwHts0+4fy5H93h8hYBQXegrAG6eIpLFW/nMO9//dJUsjyxNX 9A6eQPeUaXxszvkc6IH7OuuTKR9kRX/buHLyPxsg7USTgZnz6cUGmjfpt5SxY460sdw8LINdySY4X HghqjviVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskg2-0004eN-1M; Tue, 07 Jul 2020 10:18:14 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskep-00048M-GS for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:00 +0000 Received: by mail-wr1-x443.google.com with SMTP id z13so44550965wrw.5 for ; Tue, 07 Jul 2020 03:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HXwAK5e9O3NfsiXPR7kk8AeqU5Nw2ls4PmOWf/vu7lg=; b=qrsas+PZEhVKEED/gwuG+M3fvZFc9iTyVZ9kC/kfAQJtySYFhAXFVpKKKmyVPzJsef fCJFw/7CBzrR/D0H4Ibl8ook5vPEI7nkN6UMPeetQWBt4M+Kx0Tquh3FeHQKe+00wO+m GqDseXgUs910Lbr6v6S1qDkgnl8n1Y7UIIuytj30iKNt1AOZABZ9LymxXsaWj6zDFYGe XI8qHYoQ/wOSdxtGcESFe8ZYMktICg66e53gTSweXye36XFgFl6kw5awQcpN8EpYSN23 8sMm+Tp30g9gUcdoX30JFTNJlS2oJp3wB6d8NA/Z4UGG+OpYufSxlq2WEns0mrZb6qvR vMcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HXwAK5e9O3NfsiXPR7kk8AeqU5Nw2ls4PmOWf/vu7lg=; b=pfDfFOf80MgjmHDvDE943vVt2RKXeM/kCRHjS2yLu/W6XtCzURRF1FQ66hBsRCpiv6 ZHfxjxy6hHpEP2NwxRsEUv8ROLn1Hcfq6oUutm3LJeH3uMTHcyDpZSf15/jtjqR7sH7M gDFwAbacdvELUT3RgwqANmVRYmx3NXiQeuyNOht6pr8qGtBHEizINYwoScWM9S6J9Zv3 WbjaDZ3olFGKEh04BwlZ2FYnU0wi1CHtMk1s7iXVxqZJrNbt/NdL9E2/kCWTevO3aUqq NbMxEQB0UryC52rS/aprFx3qz9YiFbAG2bqC8SZ5hbI/njSPDZC8SjESy5I10Qlq8XgJ jQ/A== X-Gm-Message-State: AOAM531cwFM8T0xvGQJgJH+joLuA4/1LO/tRq95yTfauzv6GCXsFaFgZ CE9z1pKH9S9GxsNjd6byWqG1hg== X-Google-Smtp-Source: ABdhPJw+rbiTfjvaZjvfOEvXP2PwVD2bXCDT7mTpQWEQuNXSkRYtQLVPb8Dx6k7fktqcFGcvxY+9RA== X-Received: by 2002:a5d:6802:: with SMTP id w2mr51092373wru.88.1594117018607; Tue, 07 Jul 2020 03:16:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:58 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 08/28] ASoC: fsl: fsl_spdif: Update 'struct fsl_spdif_priv's descriptions Date: Tue, 7 Jul 2020 11:16:22 +0100 Message-Id: <20200707101642.1747944-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061659_611026_87560ECD X-CRM114-Status: GOOD ( 12.10 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Barinov , alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Two descriptions for 'soc' and 'regcache_srpc' were missing. Add them. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_spdif.c:125: warning: Function parameter or member 'soc' not described in 'fsl_spdif_priv' sound/soc/fsl/fsl_spdif.c:125: warning: Function parameter or member 'regcache_srpc' not described in 'fsl_spdif_priv' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: Vladimir Barinov Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_spdif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 7aa3bdec5b6b5..f0b2375a9246f 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -83,6 +83,7 @@ struct spdif_mixer_control { /** * struct fsl_spdif_priv - Freescale SPDIF private data * + * @soc: SoC specific data * @fsl_spdif_control: SPDIF control data * @cpu_dai_drv: cpu dai driver * @pdev: platform device pointer @@ -100,6 +101,7 @@ struct spdif_mixer_control { * @spbaclk: SPBA clock (optional, depending on SoC design) * @dma_params_tx: DMA parameters for transmit channel * @dma_params_rx: DMA parameters for receive channel + * @regcache_srpc: regcache for SRPC */ struct fsl_spdif_priv { const struct fsl_spdif_soc_data *soc; @@ -120,7 +122,6 @@ struct fsl_spdif_priv { struct clk *spbaclk; struct snd_dmaengine_dai_dma_data dma_params_tx; struct snd_dmaengine_dai_dma_data dma_params_rx; - /* regcache for SRPC */ u32 regcache_srpc; }; From patchwork Tue Jul 7 10:16:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648173 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6815B14B7 for ; Tue, 7 Jul 2020 10:20:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4126A2065F for ; Tue, 7 Jul 2020 10:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wukwA0XJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="akr9Zsp1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4126A2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OmPb60PFLPJZ4TBBTUPfcl33aHUProsuLdmqoesXMOc=; b=wukwA0XJXYc0z2/z5F0sbYd60 2XZ8aL5bxa30cC6X4JzcJBNe1ezX6ouJKKoL2EB4AkmcwnpntQIIRYisRFHDmvXwqNBdTv3QRbuIR Sf61TBrYzNxqRsLK3EaKvCyGqYHz+TkU8JFH52YHViAzyQ5z2KVSVT3gFnhNMeOsl4n1g+OnRcYEq wwc+Z9oAxQP4/2bTr7bKn9xq4cOns1OAvcTK1bmCrH/rRUu4FOEwJYqBYHbwaKc1TX02XjioZbf+W gFmOoXoum/CbUWvGcA2m5bFEUxldoDGnT0vwjnhsbAOvjJHhkcfzXljrRbFSkb9jpYCRqnypDlnHB M5agj5vIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskg6-0004hh-Bu; Tue, 07 Jul 2020 10:18:19 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskeq-00048y-Oj for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:02 +0000 Received: by mail-wr1-x441.google.com with SMTP id s10so44500917wrw.12 for ; Tue, 07 Jul 2020 03:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YsokizqvcQrYmRK4XFUw9AfpZPmtx9CnTkzjsD5Kh2w=; b=akr9Zsp1R9zCusMjYHj20g4bdfxR2yvSbDS3HgPMMiM7U4jS+e7z+EtZ2c1Ikm6qSJ j50t7qj6FEzIYazt1dQ/z2GMn07rEoyth5ncNZ/VBMThxjPl38ULcQKS+uBtxBd5UUbN 2fYZzTWY2o1yX4Xhk//N/CTDnmLeaX8+cCylsZtWLK3/gQLvTJFa0lwDJgeuQCumUB+m Pg2eQBVR27X5w1MuozculYRrSsmF0Iw/Vd7LE93nW7MdOJGe4VWoDyqRQyyWGfpn/LK6 LqMF5Thu9gPLoKx5rUeWRdJkOngDQOols03IREwRd6KxBITISTpO+Bmta9r6mlF8pD7W OmmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YsokizqvcQrYmRK4XFUw9AfpZPmtx9CnTkzjsD5Kh2w=; b=igqFtiR8oXTP21vAazLOXz+zlgp+L53Z2yep6jlMFH/exIWNhUG3aVJ7Oo2P0rHW6H MuAU0YWNarwVNljusRhJby4XS1Z+Lw4n49ze3OXShQQXvkRO0q7r4d5ybcVESDeeRh5l AKyjysDH4d+ZXhy7TY+qIG48Fvu5xtYjh5vCTajRZTc3oCEzsni/CVXuNjbKtWOmtxKg cOQl57Y94Ay8wmIaQ/jIHFcVRDf6ZC9OTpvna/22Yb3ifFszMx8fhUW1MDJvtFoG2qUZ BT/MD6ENCatq/cF3R5zsc1iXnHY4lD//nOrzDLjaxYxeZTu32njixj0hJ5jH3ndDXTBF HuXQ== X-Gm-Message-State: AOAM530ku984ZzToBnQIII7m2ashDUhfiGe6GsCD2Of05t9VbduLJbfe 3d03Bz0G+/1woa1Y5rb2FliHsALRdN4= X-Google-Smtp-Source: ABdhPJyokynAsMCJ9KP59ioOQmggRgChTfyTqf7FPi5nBCxf7ckHFkFUgqw78HQEefo5rpFgheVoXQ== X-Received: by 2002:adf:f20a:: with SMTP id p10mr56349271wro.41.1594117019816; Tue, 07 Jul 2020 03:16:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:16:59 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 09/28] ASoC: fsl: fsl_esai: Fix a bunch of kerneldoc issues Date: Tue, 7 Jul 2020 11:16:23 +0100 Message-Id: <20200707101642.1747944-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061700_892170_3DEFE221 X-CRM114-Status: GOOD ( 13.84 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Struct headers require a 'struct $NAME' title, all function parameters require a description and need to be in the format '@.*:', else the checker gets confused. Also demote one kerneldoc header where no effort was made to document any of the function's params. Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_esai.c:30: warning: cannot understand function prototype: 'struct fsl_esai_soc_data ' sound/soc/fsl/fsl_esai.c:61: warning: cannot understand function prototype: 'struct fsl_esai ' sound/soc/fsl/fsl_esai.c:170: warning: Function parameter or member 'dai' not described in 'fsl_esai_divisor_cal' sound/soc/fsl/fsl_esai.c:265: warning: Function parameter or member 'dai' not described in 'fsl_esai_set_dai_sysclk' sound/soc/fsl/fsl_esai.c:265: warning: Function parameter or member 'clk_id' not described in 'fsl_esai_set_dai_sysclk' sound/soc/fsl/fsl_esai.c:265: warning: Function parameter or member 'freq' not described in 'fsl_esai_set_dai_sysclk' sound/soc/fsl/fsl_esai.c:265: warning: Function parameter or member 'dir' not described in 'fsl_esai_set_dai_sysclk' sound/soc/fsl/fsl_esai.c:265: warning: Excess function parameter 'Parameters' description in 'fsl_esai_set_dai_sysclk' sound/soc/fsl/fsl_esai.c:364: warning: Function parameter or member 'dai' not described in 'fsl_esai_set_bclk' sound/soc/fsl/fsl_esai.c:364: warning: Function parameter or member 'tx' not described in 'fsl_esai_set_bclk' sound/soc/fsl/fsl_esai.c:364: warning: Function parameter or member 'freq' not described in 'fsl_esai_set_bclk' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_esai.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index cbcb70d6f8c83..bb3c405df623c 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -22,7 +22,7 @@ SNDRV_PCM_FMTBIT_S24_LE) /** - * fsl_esai_soc_data: soc specific data + * struct fsl_esai_soc_data - soc specific data * * @imx: for imx platform * @reset_at_xrun: flags for enable reset operaton @@ -33,7 +33,7 @@ struct fsl_esai_soc_data { }; /** - * fsl_esai: ESAI private data + * struct fsl_esai - ESAI private data * * @dma_params_rx: DMA parameters for receive channel * @dma_params_tx: DMA parameters for transmit channel @@ -160,10 +160,11 @@ static irqreturn_t esai_isr(int irq, void *devid) * This function is used to calculate the divisors of psr, pm, fp and it is * supposed to be called in set_dai_sysclk() and set_bclk(). * + * @dai: SoC DAI + * @tx: current setting is for playback or capture * @ratio: desired overall ratio for the paticipating dividers * @usefp: for HCK setting, there is no need to set fp divider * @fp: bypass other dividers by setting fp directly if fp != 0 - * @tx: current setting is for playback or capture */ static int fsl_esai_divisor_cal(struct snd_soc_dai *dai, bool tx, u32 ratio, bool usefp, u32 fp) @@ -252,11 +253,11 @@ static int fsl_esai_divisor_cal(struct snd_soc_dai *dai, bool tx, u32 ratio, /** * This function mainly configures the clock frequency of MCLK (HCKT/HCKR) * - * @Parameters: - * clk_id: The clock source of HCKT/HCKR + * @dai: SoC DAI + * @clk_id: The clock source of HCKT/HCKR * (Input from outside; output from inside, FSYS or EXTAL) - * freq: The required clock rate of HCKT/HCKR - * dir: The clock direction of HCKT/HCKR + * @freq: The required clock rate of HCKT/HCKR + * @dir: The clock direction of HCKT/HCKR * * Note: If the direction is input, we do not care about clk_id. */ @@ -357,7 +358,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id, return 0; } -/** +/* * This function configures the related dividers according to the bclk rate */ static int fsl_esai_set_bclk(struct snd_soc_dai *dai, bool tx, u32 freq) From patchwork Tue Jul 7 10:16:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648171 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1069C6C1 for ; Tue, 7 Jul 2020 10:20:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C31752065F for ; Tue, 7 Jul 2020 10:20:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YfHjFDAW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VNmHdT5a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31752065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JgWCYPjR1tZZQJmavIPDjuQZ1bXrrNkxxuT+4eAO3DE=; b=YfHjFDAWmpECBFRmgncZ7RyDF Ghpc+UX7oNQbRE4rLzBM0OtQh9gjoKqiz1WGpx9BnV3UAhDXsSDQRE++RKCBjylNffJB0BnvWRqhS DPQcGJBGBYYH8Ngv+8BBPd4EOPpsB0W5ABT/plLEDMHVelki2OFuR1IKqGh2HzcCBG8z3rXB4fFwW Ch6Y1QNBFFowPidQV36GdXc/V8tdi7zrBjGpizEfwsAGGc/WBZmNDrND9qjQK2wGTyBfgiwTL9SBH 1aztJl5mly8u0f+GKbWgVTsMfldvED7fRNyMZgb55S64DLGLmDP7pfJzjtUgNC1GGZjFtebkATxJU 52V6UdZWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskgI-0004oQ-KC; Tue, 07 Jul 2020 10:18:30 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsker-00049W-RX for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:03 +0000 Received: by mail-wr1-x441.google.com with SMTP id b6so44527377wrs.11 for ; Tue, 07 Jul 2020 03:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ceIee8YBFX9kzqJWoK/1iqOS7aaLJ7GoK8i5sFpusg4=; b=VNmHdT5aOvG5QcaUjgLr53ubScedW6+ksFA4XxzupsIrEYDcgzzUzddsvpTVB9+XBd Ry1c1rkjcL2OrFOHVSR5WsUH1Zte6YIqm83zgl4a8K4ORxMhKnyNnv+a+uocR+ceVe7d xSvPRKPxzLXNAG8kwS1XjuRA68zvHf8U6dL/SIXIee0ZAa7JMk85f5nO7LCsI2Nw0k0P Yrd5NXh0wSnDfPpx4/l6Q9a4OlDOxl6oJ1wrFcS002d6H5/bblBAdZvP2iJbJ1PiCx3s 5HiwZQ/XzuOK93xWUiz73N1/WL6mKyRf1RVnJD+SfQcACuO9YfuphgOAaSE3clIFgaah BH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ceIee8YBFX9kzqJWoK/1iqOS7aaLJ7GoK8i5sFpusg4=; b=a4eXWnioY1hHLUC+LmjM+LGlRozV9as2dOfbrU5Q9Jd6elKQOenEsz9kJMEUHZBOKm qVMf16tSlmhq4toPaOj6+H2LD5/yxOSxN1DxygF1qka8hnBpffkAQkAl1R9Vs+dV1J5d 2uXXkMk3fkzcp76JGwoJwpwW4xQDk68GYfueRkNY26tU3M5fvwRkRyeJ2g7AXxLUWCDM Nvjv51zkblZC8Qv4bDy0+PKsbS3BCGPWeP+VEATpN5UXUFf3nE2jRGFLRPUzjIy1aWAi EMMj45DOnr85NpWEtOmSrtUDAUPBQnIBOg64qQ+JzOS3GSTxNZjUcAlvg3B52FgDygpD 5tPg== X-Gm-Message-State: AOAM532B6qyq+MTm0ot+9e4Xr/r0J/8uzXYxauwL/7IMjP94BaenWX82 dfd71aKfARwwIK0IFGIKyWReCA== X-Google-Smtp-Source: ABdhPJwX2C88MDS9oCo6CUBN9iE8kRApkiJqgBaHVMS9ZR3zrmhkp/rOi+eiD5PYlCH7fNBq+FuNpQ== X-Received: by 2002:adf:c441:: with SMTP id a1mr52516736wrg.130.1594117020948; Tue, 07 Jul 2020 03:17:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:00 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 10/28] ASoC: fsl: fsl_esai: Add descriptions for 'tx_mask' and 'rx_mask' to 'fsl_esai' Date: Tue, 7 Jul 2020 11:16:24 +0100 Message-Id: <20200707101642.1747944-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061701_997743_B055F9CC X-CRM114-Status: GOOD ( 11.97 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Fabio Estevam , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicolin Chen , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): sound/soc/fsl/fsl_esai.c:86: warning: Function parameter or member 'tx_mask' not described in 'fsl_esai' sound/soc/fsl/fsl_esai.c:86: warning: Function parameter or member 'rx_mask' not described in 'fsl_esai' Cc: Timur Tabi Cc: Nicolin Chen Cc: Xiubo Li Cc: Fabio Estevam Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- sound/soc/fsl/fsl_esai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index bb3c405df623c..3f67f4a465780 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -49,6 +49,8 @@ struct fsl_esai_soc_data { * @fifo_depth: depth of tx/rx FIFO * @slot_width: width of each DAI slot * @slots: number of slots + * @tx_mask: tx register mask + * @rx_mask: rx register mask * @channels: channel num for tx or rx * @hck_rate: clock rate of desired HCKx clock * @sck_rate: clock rate of desired SCKx clock From patchwork Tue Jul 7 10:16:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648175 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 12A7914B7 for ; Tue, 7 Jul 2020 10:20:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBCCA206F6 for ; Tue, 7 Jul 2020 10:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="woZKx5hG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TiDsFIcm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBCCA206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G05SNU0ztKF7uMFTZBqExQaktcJIPVvZaTLLYdGXfdA=; b=woZKx5hG4X64jORs//eqEL/ad 0+YCbnXDSUf00pf1HB5+IQWmqHDP57TbYfGrietTyKn7o1AQ6srd0e1WIprexSPhtGmgZztMPk9WY m14MVavt9hoJrCx1QSxHmyAASgiBpo9cagtsL6SiydQjYepm0jZvszXYRczF3s/4yDFuzEQr3o1jV JCEMIsHweWlAZqSIEvCCfgIxTUM4UMVe4RpVQlpUfXjQoa6mDzIY2qh5tFGCP1V8GBLELrAHRj8ce HFMEKpt+n1wmT3SSKII52FwY9IDoUUW3H4e8MRVFIyugqvXy+kWPz6AQQkDzHZ3OWYnUlnp1j4KtM tSb+Wrijw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskgQ-0004u0-Dy; Tue, 07 Jul 2020 10:18:38 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsket-0004A4-10 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:05 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so42682865wmj.2 for ; Tue, 07 Jul 2020 03:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j306gyjagAnal9NO9hxv+ks7W0GYhjttqc5twDw7Zos=; b=TiDsFIcm82IMvKsBQX6/HNIU30n+rKxa8eOMBrBbtxHEawE+hUYaWGDqNZoQzgpzb4 wpE/sDK5PJm5+ErIRCpPTGSUTLT2mQ4GwVCK9zcD8joRnlHa/IE4X6h8QBtW5pgd3UOg 2JBLfOVGlUI+hRpujRyLnkTE2sf9blsqOfFszV7jUptZQ9MVIcjeN+ARhm+N6nVTdjrv 5xPaYCX979M0/5uJ3eAAy0fUcI3h2hXJxoeADLr1m0Ju4iJ9a//jAnT8D9VglIw9PoGn 5ti+fmywLzKuP10a61cwSFPawXqydZJ/TEqUsZT3Ruw+bpOLVIRvfRrdqIg5PO9hU9hN hwHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j306gyjagAnal9NO9hxv+ks7W0GYhjttqc5twDw7Zos=; b=hRhov15mtMjT3jiuT8nqCIrptLkZgpNSPJjfqFuU1vf6qJC9dxyhE2b6JcitzHswVq y3uaYl3V0V/SFBQSz4x/ZbZvQawkBF3xu+HzX/y/IbShQ0iCFXS3erjw8D2jjJw2l//6 eS5l/houVQemNhpEDKFwOM0+FldMAvfeLNxLhGWFGQtcgmNvBQk+Mt6ESy0Z2L0p+hnc JXJwwdPu9U5ycmGeUwOrkRWzqSeRTAYrdCDzj6yr1eVbxw+o2ob5UolxDhHFBOGqMmag F8oHcNqFRGSm8SSSpgQ50ltwKB6ndYSDYOTwL1FV4zqyS0vXjkaW0N/zReTWX7jUPwQZ g9iQ== X-Gm-Message-State: AOAM53307SveiKmM/RoER3jfmzrF99dHthRG9lv/g7YWdJ4RERHRp/Vp SrlabJ/sCrGza1pQC7U8WeTHpw== X-Google-Smtp-Source: ABdhPJw5fQ+cD4J6acJX9hjTuDH1yBuLxCoSudpJcORTNYjASKSRDv3BMPijf/xqeQ+Ze5JdnB5tow== X-Received: by 2002:a7b:c4d7:: with SMTP id g23mr3603144wmk.17.1594117022067; Tue, 07 Jul 2020 03:17:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:01 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 11/28] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Date: Tue, 7 Jul 2020 11:16:25 +0100 Message-Id: <20200707101642.1747944-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061704_103038_F29F50B1 X-CRM114-Status: GOOD ( 12.94 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Robert Jarzmik , linux-kernel@vger.kernel.org, Haojian Zhuang , linux-arm-kernel@lists.infradead.org, Lee Jones , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This is the only use of kerneldoc in the sourcefile and full descriptions are not provided. Fixes the following W=1 kernel build warning(s): sound/soc/pxa/pxa-ssp.c:186: warning: Function parameter or member 'ssp' not described in 'pxa_ssp_set_scr' Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- sound/soc/pxa/pxa-ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c index 6a72cc1665b7c..d1e09ade0190d 100644 --- a/sound/soc/pxa/pxa-ssp.c +++ b/sound/soc/pxa/pxa-ssp.c @@ -178,7 +178,7 @@ static int pxa_ssp_resume(struct snd_soc_component *component) #define pxa_ssp_resume NULL #endif -/** +/* * ssp_set_clkdiv - set SSP clock divider * @div: serial clock rate divider */ From patchwork Tue Jul 7 10:16:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648177 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0D4314B7 for ; Tue, 7 Jul 2020 10:21:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CC0120702 for ; Tue, 7 Jul 2020 10:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HB00UO4i"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QsQNaqhx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CC0120702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M29alqmAnyfbEk3lH11ZJ/9CXz86BbW3Jd5Yj97pLpk=; b=HB00UO4idmnE3DIJNIGo5znUR uCKvj9Yt6U9YspCU2HRui+yAsrR/Ncu7KPuwibsnbjgIMuOmjYMWTzrZYc2UDm8e4SsJJA1xXZrJO nLXElogd+sIoD8jYN50HHQgfJdip0mrGxYZp+1mmd7Z0U3q2TFjLsrLE0jNcPIukayI4Jc3InzUd1 abGtM+9BUPPVoG+hwAnPqqV5R9uHGldWj5irLx4xJwImY0Y5WcfQqT3XTeGRHMnGzCp9MGvYdoLXE dBN8JJUJ0CcQ6gdoYRVyqKoLUudF3zovCQrzNbIidKJKFcWyM7Mpr0kJ75d3eVU3XgNbOk9oESibE PjaHEsDJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskgj-00054r-FR; Tue, 07 Jul 2020 10:18:57 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskeu-0004AH-CO for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:05 +0000 Received: by mail-wm1-x343.google.com with SMTP id f139so45916047wmf.5 for ; Tue, 07 Jul 2020 03:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qKCC8gwbOOqZ6yEPkGSkmGeka7mYOZ7iXEWMftP650=; b=QsQNaqhxkVtL41tk1/qoGhyCm7rVJ4vpnlgVliFcwROlzr/daTSEoku3cq8UN82fQX IFbaFWVeeLZZcbS0019ujgPja2Nu5gkt/1krAFAUnVatnIx3B91JzL5kGlJDfics0Pav uL9Yr8HgEPEpP24WORMxYPT+RLeq0riRndWjJeO/uU4y0oO+r4jt9Ig0R0Pk8DMQcv7z rp4u8MT93nqSXy9KYnhrdA+GBJiH2sAaOi/Dy/QKPlv0PunseCYqkvxjRt83mLjFcW6Z alULEaJtZv8pRcmMemxrm7hMHD0NKnLzelBD/xb4HTuKiZ/wncZ/jnlVrwAmV3VlLCjX FiKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qKCC8gwbOOqZ6yEPkGSkmGeka7mYOZ7iXEWMftP650=; b=ZU+VM7uw36RHIj51OcwJUdSKGTs8HpDydn5qHGlHihQgHQ2AK/CGQwCGPCyRkkxOxM 0RTfwqa0WQ7I1leSYa0tuh6HbGL1oOs4GPXUS4JiLuab1Tq3e/vKM5LfShlxQCMNwqqu SFmPHjesX5KcF5TNwcltYRPm/1IIEDCNvJHSk7D3xDB98vUK2/wzHYFpRRssHbjHhgNw WcMTq9zEqeeERjon5unNCoSjtZSyrIZyB2Nxhl0ERji2jKnAW7Xl3RWdIFBHa7SmPQig JqmPqW2CpsnqqNkKop7OyxuREO7yo8hcOlgb5oMc1fh6Jq3hUf8MWmoe8CGjmTJJ8MxW 2Xwg== X-Gm-Message-State: AOAM532TLOlRkRG8xUSPU1nJksaREmXbNuhWMddkOaKLFgZxn4Q4E0KX wDrP2k08BSJhUUOlxGT96qN1hg== X-Google-Smtp-Source: ABdhPJx1ZbuUA9wWKqxxF1IHrewdkfGEfSuRE8l+gQGgDf17uueoN0ReeFhO3RmeiPsig4/tbI5/XQ== X-Received: by 2002:a1c:e143:: with SMTP id y64mr3375157wmg.90.1594117023297; Tue, 07 Jul 2020 03:17:03 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:02 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 12/28] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Date: Tue, 7 Jul 2020 11:16:26 +0100 Message-Id: <20200707101642.1747944-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061704_489935_6FA77CF6 X-CRM114-Status: GOOD ( 12.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, Junichi Wakasugi , Mihai Serban , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though the result of snd_soc_update_bits() has never been checked. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/ak4458.c: In function ‘ak4458_set_dai_mute’: sound/soc/codecs/ak4458.c:408:16: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Kuninori Morimoto Cc: Junichi Wakasugi Cc: Mihai Serban Signed-off-by: Lee Jones --- sound/soc/codecs/ak4458.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index f180cb5dfe4f1..39ae089dcd1d8 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -405,7 +405,7 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute) { struct snd_soc_component *component = dai->component; struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component); - int nfs, ndt, ret, reg; + int nfs, ndt, reg; int ats; nfs = ak4458->fs; @@ -416,14 +416,14 @@ static int ak4458_set_dai_mute(struct snd_soc_dai *dai, int mute) ndt = att_speed[ats] / (nfs / 1000); if (mute) { - ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 1); + snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 1); mdelay(ndt); if (ak4458->mute_gpiod) gpiod_set_value_cansleep(ak4458->mute_gpiod, 1); } else { if (ak4458->mute_gpiod) gpiod_set_value_cansleep(ak4458->mute_gpiod, 0); - ret = snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0); + snd_soc_component_update_bits(component, AK4458_01_CONTROL2, 0x01, 0); mdelay(ndt); } From patchwork Tue Jul 7 10:16:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648181 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4EEC614B7 for ; Tue, 7 Jul 2020 10:21:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2655420720 for ; Tue, 7 Jul 2020 10:21:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjRQLaIy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J1XcyxDn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2655420720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5F9Q8gRbE38xc+tjaPR4y9e9JZ++GI+Ct+KeYtolnYU=; b=MjRQLaIyOHUyeiPYE9vF7p05f 0SGoJWYU6vhrvpyRhWAjlynaXHoitgsQrZU0Qj835B8SRapuGSAZRcEiYG6LOjbhukFQRGh+yHldt X/XRhg44KOXQVWc8ozzUGSCzRYkwezxWR3lOCPPtadBVav0FIlFiKby0Aa9ZsKgO8UAMtvguu4T0b es2B9vIe9ENyPQ2fR/3fbtYiHgXUQ+BmH/qy6Oq5EZUBmAzinVgV2ffCWDndREGIgJT2qaxMpwEFf 9VmYT2YC6B0iJHXhP3dy/22+y5P3KpFXpfChKcLxT+tjMOThXElIA04LnSH+mjuJhx2A1JJWUiJKq 4UCz6Xfng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskgs-0005D2-8o; Tue, 07 Jul 2020 10:19:06 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskev-0004BB-Eq for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:06 +0000 Received: by mail-wm1-x343.google.com with SMTP id 22so42691819wmg.1 for ; Tue, 07 Jul 2020 03:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tfKAHOC4Bqa/g3TTN2zyTgayqsyKLptRGMeCLeLAzGA=; b=J1XcyxDnRmpZz0W4IPrMVJKymtJ07od5/Ui2uKeAXQgpc0qotceonG0/oloTEdbH7s h9+dfh0LSbVUcJW+pc/XyHocqcTsyqzJb8LmBvxq6MpxjTnaT9VZNdirDOfgB5bWoWDq niIIONlBk6sA9+rBm5/Zf0rtNPutp2de6yaHctV6VNL88YoptrE7bzN9P2c95z9yX8TU WwB1XVGi9t17KxFLcrnyiAgHFMMynYQSuE2RBzJTnvTVRfnVq3tEgvIXuDERBUvrzOkJ JpljX451HY8DEy3VySwa2mAmhxKDg2TS61UqmnWH5Dn1LD8i/9kIhADrwvWC7PFYhZae S8bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tfKAHOC4Bqa/g3TTN2zyTgayqsyKLptRGMeCLeLAzGA=; b=TNNl9ty3UgqMhEc13Fp4zEBTKFhV9tkQQe6T82t+ynUwuLAFBdAAvd66cC8/JEwn+r chiq8CCPaxzwBFHKyGU70nVcuvBXfpHQZX390r+FzlptaFhrXGX5dPcy8ItDZ099hWYz z0nkwaBoS/T6q16cX8yRBlKITUEm1lEEYB4W0gCDHclisJDXnCNSQ+DJVCebChPKYoOM mQ/cEcLURYezQvhb5jdxtngmBiTCl6u83lj9XbBLXSPSqq12d+2qPxmmYI0AVnSz1wm0 rj7iIaMgq9SJjHgS9rPUJZrqMZ/wG289U89/jydbZBcwgyBN7sZMl5rLCIpr4rs0rSeb TBbg== X-Gm-Message-State: AOAM532ms/kYlka0YrcWtAw9aif2HIcF8k9VTNGPs1WZMCZ0nysTb6s4 N2Vtvnptu9YVAItmY2dercn88w== X-Google-Smtp-Source: ABdhPJzZOEjZmejJdYRsgb4UUUE3sZTs8G1LEoJTOp7Viz61ZnkIYUsK9D/hnCyJv8g4p3iI/k5fcQ== X-Received: by 2002:a05:600c:2249:: with SMTP id a9mr3274840wmm.163.1594117024429; Tue, 07 Jul 2020 03:17:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:03 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 13/28] ASoC: qcom: qdsp6: q6asm: Provide documentation for WMA 'codec_profile' Date: Tue, 7 Jul 2020 11:16:27 +0100 Message-Id: <20200707101642.1747944-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061705_606101_CF5D30A9 X-CRM114-Status: GOOD ( 11.53 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Banajit Goswami , Patrick Lai , linux-kernel@vger.kernel.org, Vinod Koul , Srinivas Kandagatla , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): sound/soc/qcom/qdsp6/q6asm.c:924: warning: Function parameter or member 'codec_profile' not described in 'q6asm_open_write' Cc: Patrick Lai Cc: Banajit Goswami Cc: Srinivas Kandagatla Cc: Vinod Koul Signed-off-by: Lee Jones --- sound/soc/qcom/qdsp6/q6asm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index ae4b2cabdf2d6..58720b18fc8c8 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -915,6 +915,7 @@ static int q6asm_ac_send_cmd_sync(struct audio_client *ac, struct apr_pkt *pkt) * * @ac: audio client pointer * @format: audio sample format + * @codec_profile: profile to use when WMA * @bits_per_sample: bits per sample * * Return: Will be an negative value on error or zero on success From patchwork Tue Jul 7 10:16:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648183 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7BD5D14B7 for ; Tue, 7 Jul 2020 10:21:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53E462065F for ; Tue, 7 Jul 2020 10:21:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a1z2URfj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yhs6mPQq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53E462065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BabDmv7YHe330hG8gK88yWysUNTCKdN2XQ5a3ukGhpM=; b=a1z2URfjN35OKsQFWdWp0Oo/9 iOtXioFRvYXZ2ulVHznLqmyzgvDONl5leDqW8MaRtQNNNbOMhEKGHyF7gGcLy+8ChD2PhiEM6bSbj ExwgUcMf0xBjx9RXPwb1MzFjufR9/25XKsIUJpy9Yt3rlGxbIH2hzF/fC06k3sG8xz1RUlq2VitJ3 lx02sUglr71K3pROHLthrzfyeet9F4HE9K431Ccejc1rBnEWMiWcHgDur3lrilAXt/uiWu3GbxabY NmMc8XvGV/4X3OUIY8fZlSQSJpsyDLMUg031h512n+9iU6frJ/crIKfv7MCiN4I8JQeNoi20DX1LX K0y6puJ9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskh8-0005LI-Dl; Tue, 07 Jul 2020 10:19:22 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskew-0004Bf-GK for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:07 +0000 Received: by mail-wr1-x442.google.com with SMTP id f18so36485621wrs.0 for ; Tue, 07 Jul 2020 03:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=joYuVrqjbvze3xQNhXb1qygj1A0MIp/q6w6MCrvUZ8U=; b=yhs6mPQq4PZeAt1M2EZMuLygavzZyEDV/c7Afv2xVs9/TugaazgwktDEldd7ZHl6jo 5TSLozA1cPtC0mMfjSR+eEDDFqNoqdaIRYlcRwQyis654xVVugVaJ5/09fjtvF53qr3G AM71mfQpQPhABe8ZE/CSuJ/7yjxUd4EfLvizTrmuoLtXflMfxnEsww5Abej9dATeKPzk DCcxKFJ2krNUxMnnknHCRIUQMbynguHM9yiVaGT4YbXmFZxoaTGinJsTS2pn6w9dxE35 wWajVTMatx/MEmzV/VNOHjxcWEmbTRuoAH82DfsBaLUVz/gI1cNQy4aav0LgjVDi2bPO +umA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=joYuVrqjbvze3xQNhXb1qygj1A0MIp/q6w6MCrvUZ8U=; b=SEdvzE4hRlMq3bypei5CxkETj6K2cBN2aXqkTJqDlkyhulX1J0bc1PAsII8i0XU+ZV 9PTNyDF534omxMkT3mtWIS2HRZoLoxbtPKNbk5L0EIRLWjJyAJM1HwljSI/HXlN6lxsG mnX9H87DqXUxXWFmsLr6ACmNPSKqVygPkkVIZm+TuzdnQto1SpAHchNcCltg4Gzdvnf7 wzXpvDQ64ERAuvPU8WXkQACRZGKwwMMOeG1Pm4m/q7X6QeopeoyX8Iz7XoLP7dNtDP1O gBg1o94kkOUNpdKn2tqF62m7vDia9pCFu28Ub/7JdEnpFCsBQnNCZ1J1VS99x0/SVRgR wQ2w== X-Gm-Message-State: AOAM531oifMt/pr0WTImWm0YK+BHjHCDcaAsV3cKUOE4r9HMuEVciiyJ VyCC8ztVjy+dngfZBFNMD0PYbw== X-Google-Smtp-Source: ABdhPJxG99p5QaqaNYLPvj7Abir3MWTHXEmvxOPLyB5aXcDmjbSSvCDpahka5msO5NNg5NwWh6HBEg== X-Received: by 2002:a5d:484b:: with SMTP id n11mr50993892wrs.320.1594117025590; Tue, 07 Jul 2020 03:17:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:05 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 14/28] ASoC: samsung: pcm: Demote half-documented kerneldoc header Date: Tue, 7 Jul 2020 11:16:28 +0100 Message-Id: <20200707101642.1747944-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061706_687882_7D15B3B1 X-CRM114-Status: GOOD ( 13.38 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Sangbeom Kim , Jaswinder Singh , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Ideally the author or someone 'in the know' should come back and provide the remainder of the documentation. Until the kerneldoc checkers have been satisfied, let's just demote the header to a standard comment block. Fixes the following W=1 kernel build warning(s): sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'lock' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'sclk_per_fs' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'idleclk' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'pclk' not described in 's3c_pcm_info' sound/soc/samsung/pcm.c:127: warning: Function parameter or member 'cclk' not described in 's3c_pcm_info' Cc: Krzysztof Kozlowski Cc: Sangbeom Kim Cc: Sylwester Nawrocki Cc: Jaswinder Singh Signed-off-by: Lee Jones --- sound/soc/samsung/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index a5b1a12b34966..3116be4239f59 100644 --- a/sound/soc/samsung/pcm.c +++ b/sound/soc/samsung/pcm.c @@ -102,7 +102,7 @@ #define S3C_PCM_FIFOSTAT_RXFIFOFULL (0x1 << 1) #define S3C_PCM_FIFOSTAT_RXFIFOALMSTFULL (0x1 << 0) -/** +/* * struct s3c_pcm_info - S3C PCM Controller information * @dev: The parent device passed to use from the probe. * @regs: The pointer to the device register block. From patchwork Tue Jul 7 10:16:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648187 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D9C7D14B7 for ; Tue, 7 Jul 2020 10:21:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 690292065F for ; Tue, 7 Jul 2020 10:21:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EjQOhWWV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SG9DVu7f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 690292065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+uY1dOpy2gA4QfcphRLpmcIwfpXk55LMCwasHhjgwDE=; b=EjQOhWWVKimgPYc2eDkeSNl5N wBYh0AyaxDx7DIUOfi+zKD7g42Dk1N3LLl4wg9aEFid4ZuTe+rqJK17H/l9LGsowC68iBvbslxHfG cT1TWtA0q/Emsa827ERqr1OPhtGvWPkxSKvXoy0JVAHH8KSnzgbBueo37S8sQPrxc2xbykxWXIjgu A9BMKCXVFD0wiINz/URrm5nCU+eS2PWmCCB8zURqAx2XMo5bcpw2XWNxIGMMjTxnZh3R6bbJs+ADh GXg8wvxxBtBB/iPNkrTlUvBAkUXo04oLYkbsnh5ocfp2w6sqpJwJMaIt7QgBA+AdVEebLflWffAlZ ppcOuHv4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskhT-0005WV-9v; Tue, 07 Jul 2020 10:19:43 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskex-0004CO-Tl for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:09 +0000 Received: by mail-wr1-x442.google.com with SMTP id f7so41531405wrw.1 for ; Tue, 07 Jul 2020 03:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MeJNmc8Tyj+Q0twt9zY+vng7Jbsk0DhIYimyC4Uuyj0=; b=SG9DVu7fXCmkADEx1FB+YT3/QUV77NTc0vAi8Aq/OU5JY/5r0nXXfnJqgkyWhfpyGx D/UhIe9t7HU7t8lZcbEWpiDr++OlOpU+kL/tqL3Eh1wNadJzD0au75fv1TBcsNZSNkKA nOjCXy180Pi8mtF0+NoAX54Kixg2UaD63ENJKA1+YP8Ld65pqMeva44ZXpor7DWQd1ju LqVE4zWDY7HKent37Y3VvP8l/uIBW/84nidbsrUq+OOIyYGQIAWbpqZUxcM+8jPgDwz+ kb+JOM5fpsZC42M0+bwu5CJuC0R7MS7KlmUfHMsPCjS5HD8CfYN6wAditT74bUOm4bkf t3hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MeJNmc8Tyj+Q0twt9zY+vng7Jbsk0DhIYimyC4Uuyj0=; b=Iq16jNAzamg2GVyzc/vFyWXqp5u74FtYPVqfgFnLP+Vgbf/kScx1W803Wvxb948n28 KF4IJtUpnLxSN+ckNjAanPfOqXVxDYlIkbyIXtr1GIlKqIlQKJdHpPSIK1vOOLNrYUZ9 uqtyiZEzvwe3TLyR5YToeCXJEew3RKkSHYWkXgCKDZjPf+PyPSkIzqvXTxDU9u5WmafC ALRmWgkk8o7xeed+tI2FtYRHiToOH/vTkSiHsA54PLN2k+ycLPJkG4f8MJ1t9wETR/85 eTAfvufxPmWmQ2dDYvpUrD/SjtxvGnrrMdkCsiaQw3zfAurv1dvGaMK0T4m1AcHfvgg8 TgcQ== X-Gm-Message-State: AOAM533IN5d5g7EaDjhCMHf0IhW2WYFnNd/OrFEme7ri6WPpu0sENUI5 jRUxdWQ97KDjGA/Icd1ggg/AQw== X-Google-Smtp-Source: ABdhPJxy1qhKfpuwCxgH8O9/dsEgy203Bk85YKuQEh58briez0Nc3pkRWpshwrxQBdavC6rVpap1eg== X-Received: by 2002:adf:ec42:: with SMTP id w2mr53690649wrn.269.1594117026710; Tue, 07 Jul 2020 03:17:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:06 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 15/28] ASoC: samsung: spdif: Fix 3 misspelled struct properties Date: Tue, 7 Jul 2020 11:16:29 +0100 Message-Id: <20200707101642.1747944-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061708_262925_C0F05A36 X-CRM114-Status: GOOD ( 11.26 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Sangbeom Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org, Seungwhan Youn Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When documenting structure properties, they must match the names exactly. Fixes the following W=1 kernel build warning(s): sound/soc/samsung/spdif.c:89: warning: Function parameter or member 'saved_clkcon' not described in 'samsung_spdif_info' sound/soc/samsung/spdif.c:89: warning: Function parameter or member 'saved_con' not described in 'samsung_spdif_info' sound/soc/samsung/spdif.c:89: warning: Function parameter or member 'saved_cstas' not described in 'samsung_spdif_info' Cc: Krzysztof Kozlowski Cc: Sangbeom Kim Cc: Sylwester Nawrocki Cc: Seungwhan Youn Signed-off-by: Lee Jones --- sound/soc/samsung/spdif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c index 759fc66443298..4ae7ff623b826 100644 --- a/sound/soc/samsung/spdif.c +++ b/sound/soc/samsung/spdif.c @@ -70,9 +70,9 @@ * @clk_rate: Current clock rate for calcurate ratio. * @pclk: The peri-clock pointer for spdif master operation. * @sclk: The source clock pointer for making sync signals. - * @save_clkcon: Backup clkcon reg. in suspend. - * @save_con: Backup con reg. in suspend. - * @save_cstas: Backup cstas reg. in suspend. + * @saved_clkcon: Backup clkcon reg. in suspend. + * @saved_con: Backup con reg. in suspend. + * @saved_cstas: Backup cstas reg. in suspend. * @dma_playback: DMA information for playback channel. */ struct samsung_spdif_info { From patchwork Tue Jul 7 10:16:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648191 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70E8614B7 for ; Tue, 7 Jul 2020 10:22:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A03D2065F for ; Tue, 7 Jul 2020 10:22:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EAJVEnm0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="odgYUcrj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A03D2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5KG9UL3slb86sJRHSCDXuwLuWMeL0+st7M+ilY6RqyM=; b=EAJVEnm0WifOJBqlPG/pjK4FY HTroOhrkNqGtf90YmtcROM7+63VbermIXDlIWtAAbCEhD6JQ78Terbod9CPzA3SvcGqWZQ3Zc/eHH 9BJKxAo+4drkUcrTgCQS8X7uMwTQ72uiKNXrbV/F6fF8DU67Fd+NmDEJGbP+3xQN4kEb0SdUiAoYd qeIX297grwMtt0KLs70lMBhqFjgyfGSr8xSSJcFE6T2NiCV9RSncaO55s6vyBgJ7Z3ktKfInWZM5w 9u8eQRk/DNjMAwgU+sg8AlFOZB/AE54Al6oHtMXQLbWKszUmZhgN6iaeqTrSmO2C7mASSACLE3Zax h9yq4zk8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskha-0005cq-TH; Tue, 07 Jul 2020 10:19:50 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskez-0004Cz-26 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:12 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so45916283wmf.5 for ; Tue, 07 Jul 2020 03:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GCffUQZ+pBFslq04fueNayccH0ricdllCgVoeeuKMEc=; b=odgYUcrjBkWubGoKGvf/V/V80vy17B/RnX7fHgsFMRUIpPOJcrJt9dv+tXTEr3zxIH 4VsYldSNIBGB1DSkbFXTHBa0geEKra9/qralT48dvdSWtNZ7chRn9zar3CUhzrZOp7Hw zr8dgtoNbIXHH9at4ApTG7Uu7k0aeDOo2fUnOoFyAotLj2PlDySDbWPhpKQPJFvKG4lz gxmvNUMXPop7hY3KcqWMubpQ/jwBvQEy/Rxb55ZVJnbhlrqw/63qx6GNenP/HQK0xkXf 9RKzqvQVpNRpV1pdZFlvCD7F+DoL0i/coqsXs47ThIYQhKcOL4zpWvIXNMbG3+/omqZj tVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GCffUQZ+pBFslq04fueNayccH0ricdllCgVoeeuKMEc=; b=tWknfsrtrvM6DMwAg7qOVIi7Rvz2ToD2N2A+uV0w7MchbGKFyRT7cMcaqRG2Z0iKmV t9V6RBngadGh5b7oZPbK/90NH7FujRi8udivWaeaBeVvcP8Z7lG9qG1hfzO69bG8F+Pe bs5ObwLLA5RR2OURv2u+AZFMDEZ0pP/4J7+no41kDGseC8B8J88rdyEMKTOeO1lDIfrP FrZX8FDEQtiVOKDHFl1WTU47MauFmrSJXkhnv3664gSE1NAj13TnpqLDrkZKKtomR4y/ 98/Y0Mdt/vzpXakceOLdY4romB7DeKJG3Mo/bNoFBF1cPMTfO5FRmWTYSUe7v8W/OCKg 0zqg== X-Gm-Message-State: AOAM533Kc/DOFOVELjTvI/qkBSAI1P7j9aySMxdgHxM/ADEiLK66Fv8y MBWQOGj+d/G33va6zc/JVGDlKkdBnqo= X-Google-Smtp-Source: ABdhPJwTGPinkE3kiIv2EohNfkljh6vRj8hjjmX611oqnzrxQA4XinO205+FsY+R+JHSOtM4FcmiIQ== X-Received: by 2002:a1c:2109:: with SMTP id h9mr3331083wmh.174.1594117027926; Tue, 07 Jul 2020 03:17:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:07 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 16/28] ASoC: sunxi: sun4i-i2s: Demote half-documented kerneldoc header Date: Tue, 7 Jul 2020 11:16:30 +0100 Message-Id: <20200707101642.1747944-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061709_193377_8F84EF8E X-CRM114-Status: GOOD ( 12.76 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Maxime Ripard , Andrea Venturi , Chen-Yu Tsai , Philipp Zabel , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Ideally the author or someone 'in the know' should come back and provide the remainder of the documentation. Until the kerneldoc checkers have been satisfied, let's just demote the header to a standard comment block. Fixes the following W=1 kernel build warning(s): sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'bclk_dividers' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'num_bclk_dividers' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'mclk_dividers' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'num_mclk_dividers' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'get_bclk_parent_rate' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'get_sr' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'get_wss' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'set_chan_cfg' not described in 'sun4i_i2s_quirks' sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member 'set_fmt' not described in 'sun4i_i2s_quirks' Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Philipp Zabel Cc: Andrea Venturi Signed-off-by: Lee Jones --- sound/soc/sunxi/sun4i-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index d0a8d5810c0a5..34c24e3cedc78 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -126,7 +126,7 @@ struct sun4i_i2s; -/** +/* * struct sun4i_i2s_quirks - Differences between SoC variants. * * @has_reset: SoC needs reset deasserted. From patchwork Tue Jul 7 10:16:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648195 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C56716C1 for ; Tue, 7 Jul 2020 10:22:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EF7D20708 for ; Tue, 7 Jul 2020 10:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TYYoJfet"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uCg08VN2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EF7D20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nVEFZT54XSyrAcmmj8B4NZXGP75CKaTVL510y9B7AK8=; b=TYYoJfet4UxjlrJWjrNcjH4C7 Hcd+vuarZAdw1cNAATluu0AeevUnRYBe9MDT8PHfAlPjE046EW3DA9F2b/hs9CcfXfu5C9u6wr7Mx /Q95sX57zVSmYFcU3t1ZaCRIzxqrNWkSmzEynxaUwIsvsmJJC6uqI/1Z8fStnyvRL8OrVUt6+/6RZ i4HnCV9jryTWFdVU3QF8Ii7tEuJ7CfXOXvEGMffER/GigD4fcp0KMbp5ah/WDS/PrMvMw+AdiRztI PhlPH003tFMiTnZTMspBL3/oX/1HOUBpsLpKUKBgLqp9se8c4MxandI43wgz8xTj23rw+kchHxa63 47fkV2ZhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskhv-0005mC-PW; Tue, 07 Jul 2020 10:20:11 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf2-0004Dk-3V for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:15 +0000 Received: by mail-wm1-x342.google.com with SMTP id o2so45890879wmh.2 for ; Tue, 07 Jul 2020 03:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qvkfvflL72kN7LZNfXrEA+gETlAfB400MfXaywOwHac=; b=uCg08VN2KG7tt0Tx0AckaREPBcmh1YeIiZN5oAjKUDygIZCzkIvg51lyzxafwIyAf4 pXk2PHOrb083JCm4EbyHGCsuyFFpJg2QOKk11tqTTDZSB7wzNDHdngRCxLwvhh5fvUw1 LQt1EQ32PAvvFjqfsjatkVitUxHKb+Oltn50+vBxConSiEzzt6Yw0QV1abss/+635/J+ mUotE25yq7r4tQiY0YspR/OoLPVaZW8wnMxGqUpkPBBhnfzlJPQdxUwG3qPsHNqgqYOf g4cXGoim7zhet6+9Fpo3F8/F3GvNynrAUwV60Z2GADKjANPHfrqYPsz+1S/wTZWiJkAE DtZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qvkfvflL72kN7LZNfXrEA+gETlAfB400MfXaywOwHac=; b=mHwX4ptVVBVPAffmZgzlJO32o4MwlsmXylTNRzg7oT/oi8hbK5MOJCNs9NooV4+PNo wveKd/5aeRgum271hpaJ9M2iFTl5ZVwa5I1kGEqaTCKkukxMJ3K7YRnlSBHuGeD5nYKc 9LNDbvVLt0ZHZGvRIS66cdEqfeM4flCK+AVjRx1wy4OCF3oCaWF3bRazfCSrfuHkJIsa 9Z+EY/UzO9CgC28+qkyKZt0oD0Y5ty0MdYAl7KNJknZqL8u71qsD8T9FHvMj4cO/dXzi HQV9BrwghVT8TY7+blRIYk97VXlaM/CrbJCvBApBfNM+In2pCyK6ihwdpcHoGMP6u32b dkBA== X-Gm-Message-State: AOAM531bGq5dYDP++PtNBy+Ab5hp3twASnzxDvkjzJkI9/2YS7+0Y2du 15g/31z48VUsjviJ+GtEuj10gg== X-Google-Smtp-Source: ABdhPJwGVhbK5W+Z5vcbZBvlNHt5B5X22zSccrN72IuuGIypiyRyY/iE9EBTD1QWpJfGc7dtm4tawA== X-Received: by 2002:a1c:3954:: with SMTP id g81mr3382942wma.73.1594117029172; Tue, 07 Jul 2020 03:17:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:08 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 17/28] ASoC: uniphier: aio-core: Fix incorrectly named struct property and remove another Date: Tue, 7 Jul 2020 11:16:31 +0100 Message-Id: <20200707101642.1747944-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061712_266933_507859D2 X-CRM114-Status: GOOD ( 12.59 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , alsa-devel@alsa-project.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Both issues are likely due to bitrot. Let's bring them up-to-date. Fixes the following W=1 kernel build warning(s): sound/soc/uniphier/aio-core.c:107: warning: Function parameter or member 'pll_id' not described in 'aio_chip_set_pll' sound/soc/uniphier/aio-core.c:107: warning: Excess function parameter 'source' description in 'aio_chip_set_pll' sound/soc/uniphier/aio-core.c:279: warning: Excess function parameter 'ch' description in 'aio_port_set_ch' Cc: Masahiro Yamada Signed-off-by: Lee Jones Reviewed-by: Masahiro Yamada --- sound/soc/uniphier/aio-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c index 9bcba06ba52ea..86eb0915d80ad 100644 --- a/sound/soc/uniphier/aio-core.c +++ b/sound/soc/uniphier/aio-core.c @@ -93,9 +93,9 @@ void aio_iecout_set_enable(struct uniphier_aio_chip *chip, bool enable) /** * aio_chip_set_pll - set frequency to audio PLL - * @chip : the AIO chip pointer - * @source: PLL - * @freq : frequency in Hz, 0 is ignored + * @chip: the AIO chip pointer + * @pll_id: PLL + * @freq: frequency in Hz, 0 is ignored * * Sets frequency of audio PLL. This function can be called anytime, * but it takes time till PLL is locked. @@ -267,7 +267,6 @@ void aio_port_reset(struct uniphier_aio_sub *sub) /** * aio_port_set_ch - set channels of LPCM * @sub: the AIO substream pointer, PCM substream only - * @ch : count of channels * * Set suitable slot selecting to input/output port block of AIO. * From patchwork Tue Jul 7 10:16:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648199 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5AFF26C1 for ; Tue, 7 Jul 2020 10:22:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320762065F for ; Tue, 7 Jul 2020 10:22:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K/7uhALc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fEqHjWMc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320762065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C0o/sepfSt5Hve9NmccyWY/ECBokauVKkaozQd3NmXA=; b=K/7uhALcqHzGQkW1YVr8is28Q wJHJO5F7k3rGyA3iBKricwwT+GO6qXULTP+jfFfYwtbbcgEHdJ3bv8XPnjU3ikylK4BiS4Q/1bkZA TActvxLOMvp3/WM0YI8JlVCAuD5Kl1NFPL1ChrgVBjJfadr1WASR9CCahFjTsKpLcpzclss/2QQxq SRSW4568ld+gKcxewyT/anEkPj5a2OEmaxFnSEs43trCAa7y0Oo14NisO8UrEPS2CN5EYzAavt/Yk e7cwieScDbHjYuHHCTq1vWEAqqPA6ebCK95TDFJbT8ZgadiITKnAazNVbMEyqwOkvvTqLkXvYPCOz KXli+/wUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jski5-0005vr-SS; Tue, 07 Jul 2020 10:20:23 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf2-0004ED-2D for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:16 +0000 Received: by mail-wm1-x343.google.com with SMTP id a6so1414101wmm.0 for ; Tue, 07 Jul 2020 03:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i3kHcmoqkZhWZ4oxxNqqC7HGSrDg94q7cDYwU1R7wZ0=; b=fEqHjWMcV3QH7QNn2Owlf7RTYFuOqYPb28IOEN+o8frgMg6wAk8EIXNIqfXOBqZq/J eeNF4yNNT3ZzEc5lsIJ/W04R1U22wzOJwlIgEaSxbcmxd8TAEG0DB9MI6zZ2RgNDZckd 17shoR7zE9yCtAQjpGYYM0SiDGaB5u/gxtfv3XELzdDRrwTwbclyndNJxB4BZeFnqY1I OyjOspkNXEZtkGE0QSucKXF5JuLvxRciMy6CiAGnjOdgV9USRqYyNr2lNLA3NgF7RVh1 6vqRw2pZ7C5/IkR610hR7hIDqT6R4cHYaecuXnKDtPOQ+LZUCIFg/+NHbIdNw+HgVsiF BGsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i3kHcmoqkZhWZ4oxxNqqC7HGSrDg94q7cDYwU1R7wZ0=; b=eyv0X4P+pHdvS70uSNkvE2EGVUKH0Y5NhmRjBSdSiIcyVI6MtUIj0arfwnk2alH+Rn 5m/Ib0gNQq0p+2xVl9PnMRA3lEra/CPPW/I76jcSmW56ccwlDmx9HHBN3FFWVaEjKPCf RuPl7S4R4I7WX8hcf9J3XTU0Z28U5+U+24x0NYQn86s0eVZcRiReEN1kK0aUG3g82XUD TROkvf0tFA/gznPHpuJ4GzSOSxFWIpaM/mAFejkRYJGsHiEDhd5L1vLU1TqUnM5OweA5 eG5s61Lqc+spu+0HacglXvdtMAlyxf4otETW2HKyM6TW9hkzLZ0ohtW5Go5P80FRvlh6 0j8A== X-Gm-Message-State: AOAM532PC4zfhxOxI2Dx/BWW7A0Mkm1tB38VkpEne9NQqIVWaBdSU2Zi WfIUOmcStUFq3JnKIX8bBbOBCA== X-Google-Smtp-Source: ABdhPJxvtg3nk0eX5HE4sSuL+1NhcMKYEL2lfzfo5OK/+r0EuBSISL2ieYbjgHLSGSKA8gV8c787RA== X-Received: by 2002:a7b:c0c9:: with SMTP id s9mr3231907wmh.166.1594117030396; Tue, 07 Jul 2020 03:17:10 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:09 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 18/28] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' Date: Tue, 7 Jul 2020 11:16:32 +0100 Message-Id: <20200707101642.1747944-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061712_226062_9B2C75A6 X-CRM114-Status: GOOD ( 12.10 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Marcus Cooper , linux-kernel@vger.kernel.org, Maxime Ripard , Andrea Venturi , Chen-Yu Tsai , Philipp Zabel , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Property name descriptions need to match exactly. Fixes the following W=1 kernel build warning(s): sound/soc/sunxi/sun4i-spdif.c:178: warning: Function parameter or member 'reg_dac_txdata' not described in 'sun4i_spdif_quirks' Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Philipp Zabel Cc: Andrea Venturi Cc: Marcus Cooper Signed-off-by: Lee Jones --- sound/soc/sunxi/sun4i-spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index 86779a99df751..326dd45e39dab 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -167,7 +167,7 @@ /** * struct sun4i_spdif_quirks - Differences between SoC variants. * - * @reg_dac_tx_data: TX FIFO offset for DMA config. + * @reg_dac_txdata: TX FIFO offset for DMA config. * @has_reset: SoC needs reset deasserted. * @val_fctl_ftx: TX FIFO flush bitmask. */ From patchwork Tue Jul 7 10:16:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648217 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB2DA14B7 for ; Tue, 7 Jul 2020 10:23:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94359206F6 for ; Tue, 7 Jul 2020 10:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0ofc4a3A"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tCYSjXuU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94359206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mYLNhxKg1fYXeF0eapFr/wWbun58wCDJwXJhYrH10Iw=; b=0ofc4a3AuzdDM41hwKZe37D4g 1WyNj+M+UNyjGk8FoYDUKOMdWoPvcelDNPIJqhTl2dJcd0y+IAZO4GMGvcOr3P+SdrEvnue16GP4q jiZHPay+HVpWWWpwSay6Uw6FFDqIbrnqzrj7VcbyBSJtnyLqFRE8VruLUNxQGRfrgil4ElZ5JObow DXVb4hMImgQkcmTaGGZ79OP2ZFeyhFTdolkQAMFF4zN8dU+lzt+WPzS/NemSyliZWB9dTWFhlnN0M wiS/yAUCqwCGQiR7uSnFEenj95slX3ebHAFaHJx1bx4MrMDd/o1fGFS44NqfBeLuU3vnxA3qWlXmx TLR1dzGTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskiO-00067x-QR; Tue, 07 Jul 2020 10:20:40 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf2-0004EZ-Rm for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:16 +0000 Received: by mail-wm1-x344.google.com with SMTP id g75so42669148wme.5 for ; Tue, 07 Jul 2020 03:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d7oRUP6HHmbAXMILeJrpZWaXkV9JssFtTdyZGy/6dhk=; b=tCYSjXuURlwgjreX0Ebq0a2Q23GCLXJ9ADPRqI9ys1VeUMctC69cJNaP8QTx38oG4/ G/CvUacR2s5NWT9H85WTs8wjAHTeI5sYNvDO2tOx2a9ohVWrbgNr/YRR7NbYflcn8iJB 1nDzhvSjUAeyDQ8WX00jokbXUyChwf4iVxhdJ+fX5iKVekqBwr1tUYhe99XCtpLHkWNt j/7sOrH2fBcl0o//lBbkhztFByYhe1pPAp1fvuolQFS3bbFLWD6OQWrOFV3qoOn8EmIJ eOenFNQIFMj2OchrK0q//ZaAftRPDArUIUH/zS8ZIdH5x5KzGeqSV0ezQmk0uAnHMHv9 4Uiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d7oRUP6HHmbAXMILeJrpZWaXkV9JssFtTdyZGy/6dhk=; b=EOimY247mckxXGYflAI40jmUmQpgnvD8WLI3Mk3ecFFRsSmPielxR7JEfAgebTfY4F NYx5CMaB1NClhxpmqKGsBKtAc5Rv7wiSH0fl7a0ce2w6a3Qx8ish13Im5ySrC2py/IJ/ E7dVWujtU92cT/tysQSWtQu2KD7R+JVj361N5olLtA5JGto52zGd6ql3ZqNPpeC8Hmw3 SuC+HAxzUXKE/dK7TRFvPbvjaqMEtts1KjWb25/mq+KrjGkFCNYyOdt61mf//lXSQrNJ iifXkUFQBA55j6QoU3v4AbLfCgoGtPNzr0jzNRiaFEVRpDJFnPm+FUdaIbYSVWwPQmbt 23YQ== X-Gm-Message-State: AOAM531cLD/t/x7q4vM4rtcDUWbB5rTbo0mWMBJI8BZXCZtBLb+h/ykA T/CSW/mlPmVQXwkMX78F0Qb7aw== X-Google-Smtp-Source: ABdhPJx2P1TjQfKulF9kQvC3Rl1oKv0T6tweHznyPHPtYx+jkOMqb0z4kGRg8v3Or+e4ue4AewQEsA== X-Received: by 2002:a7b:c38c:: with SMTP id s12mr3391563wmj.136.1594117031692; Tue, 07 Jul 2020 03:17:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:10 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 19/28] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Date: Tue, 7 Jul 2020 11:16:33 +0100 Message-Id: <20200707101642.1747944-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061713_135140_5EC7722C X-CRM114-Status: GOOD ( 11.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ola Lilja , alsa-devel@alsa-project.org, Roger Nilsson , Lee Jones , linux-kernel@vger.kernel.org, Sandeep Kaushik , zhong jiang , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like these have been unchecked since the driver's inception in 2012. Fixes the following W=1 kernel build warning(s): sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’: sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’ set but not used [-Wunused-but-set-variable] sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’: sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable] Cc: zhong jiang Cc: Ola Lilja Cc: Roger Nilsson Cc: Sandeep Kaushik Signed-off-by: Lee Jones --- sound/soc/ux500/ux500_msp_i2s.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c index 394d8b2a4a161..fd0b88bb79212 100644 --- a/sound/soc/ux500/ux500_msp_i2s.c +++ b/sound/soc/ux500/ux500_msp_i2s.c @@ -395,7 +395,7 @@ static int enable_msp(struct ux500_msp *msp, struct ux500_msp_config *config) static void flush_fifo_rx(struct ux500_msp *msp) { - u32 reg_val_DR, reg_val_GCR, reg_val_FLR; + u32 reg_val_GCR, reg_val_FLR; u32 limit = 32; reg_val_GCR = readl(msp->registers + MSP_GCR); @@ -403,7 +403,7 @@ static void flush_fifo_rx(struct ux500_msp *msp) reg_val_FLR = readl(msp->registers + MSP_FLR); while (!(reg_val_FLR & RX_FIFO_EMPTY) && limit--) { - reg_val_DR = readl(msp->registers + MSP_DR); + readl(msp->registers + MSP_DR); reg_val_FLR = readl(msp->registers + MSP_FLR); } @@ -412,7 +412,7 @@ static void flush_fifo_rx(struct ux500_msp *msp) static void flush_fifo_tx(struct ux500_msp *msp) { - u32 reg_val_TSTDR, reg_val_GCR, reg_val_FLR; + u32 reg_val_GCR, reg_val_FLR; u32 limit = 32; reg_val_GCR = readl(msp->registers + MSP_GCR); @@ -421,7 +421,7 @@ static void flush_fifo_tx(struct ux500_msp *msp) reg_val_FLR = readl(msp->registers + MSP_FLR); while (!(reg_val_FLR & TX_FIFO_EMPTY) && limit--) { - reg_val_TSTDR = readl(msp->registers + MSP_TSTDR); + readl(msp->registers + MSP_TSTDR); reg_val_FLR = readl(msp->registers + MSP_FLR); } writel(0x0, msp->registers + MSP_ITCR); From patchwork Tue Jul 7 10:16:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648223 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 370386C1 for ; Tue, 7 Jul 2020 10:23:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD876206F6 for ; Tue, 7 Jul 2020 10:23:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FD4j2TYI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LCQfc/e5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD876206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=knqm1j9n4welb1yJP0jQ/yy1d/OEEt3KtApFe0vsDtg=; b=FD4j2TYIkLOYlsv8FxDfR15Qw 9Ko6225DzH9PRFjJq3n5Hes3ZERRNVMMSWieZ0JU5dXYZOYLWFkCUfQeCPntrZSOkGu/wnOoF2JvF Al5vLAL1HANFRRKWxrJjOADNFbg2ZCFAGSoiWWRZ1YM/VDG9sOwfQVB0YOWSJtXyNd6PyA0rrSxqW 7MISTlKIAaLUF5lwMPq8PVVkRlUwetsd4qUneQwqYiFdqo3sw8rAGKHbTW5D0rBep3QDa1k3r83W0 ooGaCTSFbcJ/WH6GRes+UlyNGtD8N/F95yFVyPpvoNrT3PixCEVerjif/QHNSJMPZZMeG1t0KJ0T2 K1kqvsjyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskih-0006M2-BV; Tue, 07 Jul 2020 10:20:59 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf4-0004FV-27 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:19 +0000 Received: by mail-wm1-x342.google.com with SMTP id f18so45915500wml.3 for ; Tue, 07 Jul 2020 03:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GMUYidfrIwBoQwr04cGElMGH9ZhgIrwlDOw4is85pEg=; b=LCQfc/e5ty78KnRBAWkN5lY+b68RFMYCz8nZm/KdhRS9l+QtjMn+DGKkzXQpAfRwuD n8dndQB0ha994npwPP+9EdI4y10eYHeLl7rqUAivaYJyPvaYJ5ovzn9eJrfwLoqCqK4D X1AiU35rKsZhW8y7U7JVvYJ3Hdc6bOWnrjH3pdc0D7QzdCRmlTGMuowrhG6zEB0mjcko uRbhznr83cxoJYNTTqCOsMg7hp/Eqo6YLYBOePqhVcVBAlo/BOJld4J9auQWVMDG2fff aH0a3GrNPvm2pIMPUemmoUKXAZVmeTlnqbZWMT93sJR7zuapWpadYGEV9ssJwOGmt31Q jRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GMUYidfrIwBoQwr04cGElMGH9ZhgIrwlDOw4is85pEg=; b=iwmiLB7wlcN5nhItUoD6BDrdRKF5EjGn2b+YPESQQucboHS32dfWwgzpqKXCVoKESo yXEheWfK+IA6Zbc7MaYnLk2tiJYY+Ugz3YWskZakodkqsOeKvDFs0J0S1bf68CCNEaoj 3iUn5aOmzA9wznkEsOozbyB5Q4LE+RiKAWeknBd+2gfIl6Q4erP/hxQe2pAhor2uXHWE zlSeK4waShLAPXi5N1t9a8r5Co69xtSwWua4aH4rMvfevRwy0V/kTKNu6P+SV0zsQF+K lybVHVEnUIBwgC9la8hlQsEJO2wz8V+Sa3iNM9iFXNB8r8abTE6lHqqttkLpCCMHA8/N PjMg== X-Gm-Message-State: AOAM530bhJ/bw448ZI6xfs8JniaGiMDl0mNtvHarvQaGVPMhZB+0uZMG hQ1/7Y2FHxSXfTJxtaYW4biAZQ== X-Google-Smtp-Source: ABdhPJy3UpRnh1pbIW5TM69XcTo8ALmp1/bv7rxoyf8ZQ1E28518TJ8Xw2HwfBX5mnOEi/HYkpRqNA== X-Received: by 2002:a7b:cbcb:: with SMTP id n11mr3217967wmi.99.1594117032905; Tue, 07 Jul 2020 03:17:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:12 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 20/28] ASoC: sti: uniperif: Mark 'uni_tdm_hw' as __maybe_unused Date: Tue, 7 Jul 2020 11:16:34 +0100 Message-Id: <20200707101642.1747944-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061714_310990_DB556CD4 X-CRM114-Status: GOOD ( 13.17 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnaud Pouliquen , alsa-devel@alsa-project.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Only 2 of the 3 source files which include this headerfile actually reference 'uni_tdm_hw'. The other source file 'sti_uniperif.c' sees as it as being unused. Mark it as __maybe_unused to show that this behaviour is not only known, it's intentional. Fixes the following W=1 kernel build warning(s): sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=] 1351 | static const struct snd_pcm_hardware uni_tdm_hw = { | ^~~~~~~~~~ Cc: Arnaud Pouliquen Signed-off-by: Lee Jones --- sound/soc/sti/uniperif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index 2dc2da5d458bd..e22d045d5cd99 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data { struct sti_uniperiph_dai dai_data; }; -static const struct snd_pcm_hardware uni_tdm_hw = { +static const struct snd_pcm_hardware __maybe_unused uni_tdm_hw = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID, From patchwork Tue Jul 7 10:16:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648225 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A3006C1 for ; Tue, 7 Jul 2020 10:23:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7615206F6 for ; Tue, 7 Jul 2020 10:23:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PRwgZ9wS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hYVZlimb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7615206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k44CXqpOpHpaiMF1vzhIogAjM0YT/cpgF7wXHt8ULmA=; b=PRwgZ9wSWtbGPdRx1WaQoYTLU utyz9DcLso/e1BHGfPBVD6vgqilPO0dtLXG3ZPUopCj3cQa/8pRCkcXqNL3P/zpwo2fIHaxXX9zjq 2WiZWy9N4Fp4YfAradPrk4UkH6ufAKWVVa6896AJ2rcHEYeFwKP2hhbQerko9anwEc9us2cDK7WFm 12CkIlggQ9n+XnVcIsGDu2vd5Jz1sd7AwcRcxyJ0NyqBw5bqS1BSJdZ+ES70mWDZ8XLesZvauQ+5V qz2D0zgqzF3cF2IdigQ5ccAmAStwkEELzy/3pt7gKwJDCyv45m3n/Yk9OTOp/A0g8y/7zxY7DjWdh 5PxR7pZyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskj3-0006cM-Vt; Tue, 07 Jul 2020 10:21:22 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf5-0004GL-3F for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:19 +0000 Received: by mail-wm1-x343.google.com with SMTP id 17so45840980wmo.1 for ; Tue, 07 Jul 2020 03:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Eb/RPEg+kMf5EbfmZ+xzaRqlinKf/Ie6foYLp+7RL7o=; b=hYVZlimbR1Y4vTKWrzDgy1aOXAjhRbuXLpjometenz6KMcYiaNc5FhS2U/BgwBCWXy LzGWQeSIPg9sR21qe7fjeRqIc3SEMoZrxAkopagoIob1IVlOGbwvFoVywKOqplqP8Umt XvO5Yn4OK6ezPzEVhTp5NEyj+HxHd9PFoQ1Fsavx+M+BoqizA5C06Jn5KeLfpr+OIWrh +5N+5by4tWgAD/1iQ/PsHy93hhlGY9XnJaOnJKnMMbeQ2LmKUuDnMHIW9lPfudD4XTye qSnp/RyyG0guNjiIyiyWHMN+FOLPl53mrX7b5uT0jtu3YXZc4Fa80g30Up4hUTbEk/B9 MpYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Eb/RPEg+kMf5EbfmZ+xzaRqlinKf/Ie6foYLp+7RL7o=; b=W0dhu/WIKTtARbqjzxGFMRI9zchLeG8NV7NWJXcNJ7JCho6lBKk81YDy+sl7F6/Dke aROUY/oHc0loSDaQ+kYFd5n0JR4pbSVwZmZPNjhhy6g+fc0ZgFLROYk+PBYYI+9YexKN Kuou/FLCysCT5SK+fF3f6mGJqf0eoTFYGM6DhWC1+of+jEZzit8SnTOVzvfMG92Y9Ff+ 9FdTZ/4b/IHLjtK92BE6HYvbTrNPa80L5cZ31zFfu4zL0na1YceW8bzM+FcRQxS6LY4G pEDsTPR/cbQmb3Xz5TDlFo6czk/f0hOUo9DgPoG6r0nCWDXosd01TwsnqhIfqVdIvvjm dqCA== X-Gm-Message-State: AOAM530du+ARrx0eFv3Tr3YmxOR18Sj9y6cGRRZfANTrHyMUUdwuD6ju fgMnPiQXv+hFSQ4oByZg0dP61w== X-Google-Smtp-Source: ABdhPJwiukos6NDimwam5UH9qNhkPMjAs8ALC3WtOoAlktRpKr9H6nmMroUuFl9TDomf2uyT3u8ExA== X-Received: by 2002:a7b:c259:: with SMTP id b25mr3421129wmj.107.1594117034103; Tue, 07 Jul 2020 03:17:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:13 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 21/28] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w' Date: Tue, 7 Jul 2020 11:16:35 +0100 Message-Id: <20200707101642.1747944-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061715_372180_FD859647 X-CRM114-Status: GOOD ( 12.60 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Samuel Ortiz , linux-kernel@vger.kernel.org, Peter Ujfalusi , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Lee Jones , Jarkko Nikula Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like 'w' has remained unchecked since the driver's inception. Fixes the following W=1 kernel build warning(s): sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’: sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable] Cc: Peter Ujfalusi Cc: Jarkko Nikula Cc: Samuel Ortiz Cc: linux-omap@vger.kernel.org Signed-off-by: Lee Jones --- sound/soc/ti/omap-mcbsp-st.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c index 5a32b54bbf3bb..643ef7eb68fc8 100644 --- a/sound/soc/ti/omap-mcbsp-st.c +++ b/sound/soc/ti/omap-mcbsp-st.c @@ -142,10 +142,9 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir) static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp) { - u16 w; struct omap_mcbsp_st_data *st_data = mcbsp->st_data; - w = MCBSP_ST_READ(mcbsp, SSELCR); + MCBSP_ST_READ(mcbsp, SSELCR); MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) | ST_CH1GAIN(st_data->ch1gain)); From patchwork Tue Jul 7 10:16:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648235 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C515914B7 for ; Tue, 7 Jul 2020 10:24:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E5C42065F for ; Tue, 7 Jul 2020 10:24:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrxpXt33"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kJo1+ouw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E5C42065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1VanXKrZcr7gb80xjjy4yDE4MTErQXlRBSXTeLmkuhE=; b=KrxpXt33Ok2RXVFPQPlKlOw1W wKO0V0MpagLiSkN4U5WgV1qGZMqMV4sXeSH7FnoZ8uHjYk61+skCZ8K2fETeOk5P5O83GdbGYYu7s kWNM7bkzhS6PK6h7bOlXxaRf1SbomKkfcUcXVnx1Zn8MG6I4eD9TyrJfYOKfoGgRXR1Mm7bW3EvTF cmlG71OjBlop+iqBRWXvqkt1kFJxOKcdPdx3ndyC2vCNjTTqFLWOAeo/qo5P1BBeKt5aEp5Yw++pm Ip/Hwn3Sk7UD5r18QRsCc5vzLNkH+nwUfiEi81VY/qFp6/Coll3+bKvHfrShVSi8zdfaxwy2+S8lP xBOqzbFaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskjZ-0006qL-VK; Tue, 07 Jul 2020 10:21:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf6-0004Gn-6W for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:22 +0000 Received: by mail-wr1-x444.google.com with SMTP id o11so44581745wrv.9 for ; Tue, 07 Jul 2020 03:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U3fyU5lC2kiQoR/Tx6i2htjANdo4PmUgTNG8kh6JAhc=; b=kJo1+ouwbe5ipI7BlC5Ic4kTj8wrYnx05NhCanfvRd3nkj5ATUjqLzGEfPRFCp2ulE KlBv/4imh5BYzeZCn2F/hHtgC47bvGB4fduIIt+wknpl41OgBzDF+cPpVYzYmTyVMfmn fyL0juesSL2d0Mvlsdth1UFm/UcrSurKgPRTyvbJvnMdRe1jh7ljFlsf6qXnrhkrWm4S w/kvER9sdviBe2wO7C5yDsga3UBqektYMCTs5TnCXRD398XXHiALQmZCob/PqQRJQo2W S9xILBqXWTrhiJbJvgqPcatbuL4E5Gzn5H/TkKAlV4+/nMN2pxueG5HoYl4kOqGmLPMe mlww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U3fyU5lC2kiQoR/Tx6i2htjANdo4PmUgTNG8kh6JAhc=; b=LxtXG5jGUQt3dl5hYRKEn7GyVnyrqO2G1e9/+V7SR0jk+UctZuZQh0gTcsuQ3JQDaf Ho99C2B4Suk3SCklYcQMrngToH6DAgfU3teaoC/3JAmVhU6iWFGHbpyY06GUStV8Ngff BZqViVVGSDdZfU727/8dhnc+u34im80RRnxY6hHZUqlwHpH63gw6K9N+t0cnjp3bAhIa EpzKK0qiYFHFcY/MFZxcmANOvI917A61hBvFgRxGtWvkSfkSM9WPnkoh/EmJYplS0aiR Tac6eC+Wuppf+FvdPaSKW/2kgEZlN1FWT5p7fXlx6E+qbImMs+PMl0RuxIMTjObgv0Lo 5jhQ== X-Gm-Message-State: AOAM532DsEv0MHVTStl/1MsEJx6McwMhd8Ks+U5mOX6GSPoFyGNSgP1f i6FHeRWx3QDLnfk0Jp2UlnMMcQ== X-Google-Smtp-Source: ABdhPJw3IxiVYR6WmuTK9z+sTSUJZ6MQnqXOW88rUyFa86F5H3CyEoVayXplHB7xTuQyEIOgTW+qOg== X-Received: by 2002:adf:e48f:: with SMTP id i15mr17550261wrm.327.1594117035204; Tue, 07 Jul 2020 03:17:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:14 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 22/28] ASoC: codecs: da7210: Fix formatting issues in da7210_set_dai_pll() header Date: Tue, 7 Jul 2020 11:16:36 +0100 Message-Id: <20200707101642.1747944-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061716_351532_0F61102A X-CRM114-Status: GOOD ( 13.14 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Support Opensource , linux-kernel@vger.kernel.org, David Chen , Kuninori Morimoto , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc expects parameter documentation to be in the format '@.*: '. If that convention is not followed, the kerneldoc checker gets confused. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/da7210.c:985: warning: Function parameter or member 'codec_dai' not described in 'da7210_set_dai_pll' sound/soc/codecs/da7210.c:985: warning: Function parameter or member 'pll_id' not described in 'da7210_set_dai_pll' sound/soc/codecs/da7210.c:985: warning: Function parameter or member 'source' not described in 'da7210_set_dai_pll' sound/soc/codecs/da7210.c:985: warning: Function parameter or member 'fref' not described in 'da7210_set_dai_pll' sound/soc/codecs/da7210.c:985: warning: Function parameter or member 'fout' not described in 'da7210_set_dai_pll' Cc: Support Opensource Cc: David Chen Cc: Kuninori Morimoto Signed-off-by: Lee Jones --- sound/soc/codecs/da7210.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c index 0c99dcf242e42..159b5f0eb7100 100644 --- a/sound/soc/codecs/da7210.c +++ b/sound/soc/codecs/da7210.c @@ -971,11 +971,13 @@ static int da7210_set_dai_sysclk(struct snd_soc_dai *codec_dai, /** * da7210_set_dai_pll :Configure the codec PLL - * @param codec_dai : pointer to codec DAI - * @param pll_id : da7210 has only one pll, so pll_id is always zero - * @param fref : MCLK frequency, should be < 20MHz - * @param fout : FsDM value, Refer page 44 & 45 of datasheet - * @return int : Zero for success, negative error code for error + * @codec_dai: pointer to codec DAI + * @pll_id: da7210 has only one pll, so pll_id is always zero + * @source: unused + * @fref: MCLK frequency, should be < 20MHz + * @fout: FsDM value, Refer page 44 & 45 of datasheet + * + * Returns: Zero for success, negative error code for error * * Note: Supported PLL input frequencies are 12MHz, 13MHz, 13.5MHz, 14.4MHz, * 19.2MHz, 19.6MHz and 19.8MHz From patchwork Tue Jul 7 10:16:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648237 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DE5B6C1 for ; Tue, 7 Jul 2020 10:24:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF36C2065F for ; Tue, 7 Jul 2020 10:24:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="THJ/BtnR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QGMjHJlQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF36C2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bzpJYQ0bZxK6wXa77vBudtVuusslalw3hlQbkKQdaZc=; b=THJ/BtnRWqmWPzmWi/dRW7vp8 ZcOW8kEPt1KyLNULM31OJSTDKh0VM09WFHrUldrnJoNGen3TXSZpTbF+vnj0d3xTkLP2mcwt5wDnT M5gQpPZpCK8ukV0lggA/FODWYHV23e4X1YteB+U0G6dtGe/A0ejmO2NJpNz2090APaXElZ536Woc8 /lUTzLcJB1RNjarm/Xx9DLjmnzBR65H6VQWRM9q5xXaPVsN+V+cWuQdTNWekTfW+8VnhXDXp1Wnoe VwwFBi4nGrPTdq0wGCHjki7wAmuk4owUTZLFMdHyl4DQh5dhw5ifAwYAMCbwwwDNtXXkmAy1wJ8eW 6XQrlrbFA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskjh-00071a-1z; Tue, 07 Jul 2020 10:22:01 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf7-0004HY-Go for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:22 +0000 Received: by mail-wr1-x443.google.com with SMTP id q5so44518508wru.6 for ; Tue, 07 Jul 2020 03:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EXLqTyUKMLj4M51ntYR1QA4V9xA1YrzmuNUETaX0PBA=; b=QGMjHJlQ9LWikvX6Na5JwK9UPUmF/DNUlzfwClDFWUzxLNI3vHyW3hm6xlfswr2AV8 wkFMnZoIWoQ8W/vbLtLairtyr3oUjXlaXBn79y60eIPJCInMUGmqhIwj5oH14AoPyTuW PpuseWJtIwwqJ+wYUvHy5dH0KlMSlu3UwlLaMIwhi5Ru3QdAjHI0pt0KyOvCYdK+XJuB g5A8bJoPOmMZSw0D/+fiy6siWxtEreitU2khKnrX6y7K+Wbf/i7VhqyVGk1Vfn7qfBdZ zdC4l9jK22GpHnEbOHuseblQoFf5gMl+OxkiwHcQ/RKvu1QoDmvGzarx+CMpe8vRPBXe tr2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EXLqTyUKMLj4M51ntYR1QA4V9xA1YrzmuNUETaX0PBA=; b=eonkBSFdnRJZEaFzTh1dy3yykJZNUnp88kQHELKlNVEFs0pcPlI+EidrBY3VM/0z+a TGxeJCdhqA2222Pw5t7r5mohoRRwCWA2kKbLDWhOBLmu/7wvgQT6QY16Uuj0LLk7HclQ WcjL3s6AibzWSrKmupO56yY9GaopFEFGwgLvXOdox9/50ciXgBkJ+nfA2LFVqQDwbpzh 0AnZ1FPXof0yr+4Je02Ki0ZgCNOtDND9sbBdaB1ukPljnX4wkyXi9bSspIAGk23w1/bf faw7V6FXFekeR5dyLTOOGvdYuGyBds4dnCSTFaDYYhy563pyJhgtr4y9Be5CVHsaeF4H DqEw== X-Gm-Message-State: AOAM530QVmOSSFCYrtROYjaAOqjyaNhEaYOHuesotDeM6OEDkfcK55ZO 9SjM1t9cU6uTFoQte5YFPAAKiQ== X-Google-Smtp-Source: ABdhPJxqAC3BtmcDgPQdVNfB2mynSSt1Kjfhgyv7zPY1kPqaosnB4BBwP2w2zFQNZfEfX5SODLsnZw== X-Received: by 2002:adf:dfd1:: with SMTP id q17mr50235597wrn.94.1594117036243; Tue, 07 Jul 2020 03:17:16 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:15 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 23/28] ASoC: soc-ac97: Demote seemingly unintentional kerneldoc header Date: Tue, 7 Jul 2020 11:16:37 +0100 Message-Id: <20200707101642.1747944-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061717_747379_2286B0D7 X-CRM114-Status: GOOD ( 12.01 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Purdie , alsa-devel@alsa-project.org, Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): sound/soc/soc-ac97.c:402: warning: Function parameter or member 'ops' not described in 'snd_soc_set_ac97_ops_of_reset' sound/soc/soc-ac97.c:402: warning: Function parameter or member 'pdev' not described in 'snd_soc_set_ac97_ops_of_reset' Cc: Richard Purdie Signed-off-by: Lee Jones --- sound/soc/soc-ac97.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index 906106ed8ca14..af789552a9d4c 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -391,7 +391,7 @@ int snd_soc_set_ac97_ops(struct snd_ac97_bus_ops *ops) } EXPORT_SYMBOL_GPL(snd_soc_set_ac97_ops); -/** +/* * snd_soc_set_ac97_ops_of_reset - Set ac97 ops with generic ac97 reset functions * * This function sets the reset and warm_reset properties of ops and parses From patchwork Tue Jul 7 10:16:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648241 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 344E66C1 for ; Tue, 7 Jul 2020 10:25:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB82F2065F for ; Tue, 7 Jul 2020 10:24:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ml64rVuS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QoVnhhkn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB82F2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BoarGsUQ/1VCnC0r6jq4qfnxOM78jb5nA5/pFFqdW3o=; b=Ml64rVuSXYu2DmhUvTwm2jiBH ITGpdKGyeTP9UTIMxQ6SXZGktYWWt23Er9izgoxNluvjbN1mo7BkTKAmyIgeuW2UXAMepmg303Mjf fhjAtacfcRjrzUA/NnNiqixPOcaSYYl8/T7zKH/LLmwfcojeK91DbbW9VFm2aMdc43LvB/F4NqmT5 BP87MhKm6nA7sVWwcCsr8RA6Y2R9Rx9HaV7li2yqKD2yF9rJNIIQVECUoj7V3zEM6h/3bMHDdK9ET pWjxyTIgrrPQfgikf/I/PTIJJZ/Kb16psn0y+quug/Yw7YUVXdjW+fles6zfgKN/3VA1b4jsv99X1 HScJ8jhyA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskjz-0007BM-I9; Tue, 07 Jul 2020 10:22:19 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf8-0004IE-DW for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:24 +0000 Received: by mail-wr1-x442.google.com with SMTP id s10so44501950wrw.12 for ; Tue, 07 Jul 2020 03:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c4/atXJGhj1n0uTQI5cYV/gQNs+sjaOZMgJsAAMgfWA=; b=QoVnhhknZYVxWfl9mcL1Hgta3/3Af8FucpK51zcYOzuI1LPngqjVM8rBVmQqjLgh7E 1Uw5NQ/B6U3SUgvxl1hiVmj1hwCKO9EaY5U/DRBIuNUsVN/pN8KwuthGGhnUKBnKlSQB a4d7SMY6AFyJbq8ZR4ADQrnNHzUMD5ziAGLPIcECCntkWmbzjXnZofBCZFbWuKIPcqcC wAZxm9Rtksb3/dunSciAduuH/UVb0HHOL8I3Rsr26SmQn3plTAqH/gh7J1xC4qLizdp6 nnU60q8xCFLFZxL4M3qkB9cNqUBR/rnNppyXEvYp/IwKxkobwyQx6HJWu9+ptWGyT82Y JKlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c4/atXJGhj1n0uTQI5cYV/gQNs+sjaOZMgJsAAMgfWA=; b=SlpqNppPeb+qnaJFJPR4vFr1n3mLxF+aPBUtVgvY0/DdRek2ojg31mxaENSM0SIV59 /bkU+AUpJBT0fAPlMWC/vLo1vsKcH87dvmSXq4IY4VZoiQ1e0lqYZTAkcRWBbCGcVz+J g8Vds8RG/3jHX2FG5HZpeEX5JwFuOP3D7RDWcO3yD9lu/1GbSQmZwOMVRAB/56vPjawF 0w+Vb9n8ezQPbA1ANdfX474IyYHqcLGTYtiJIt27mYglbSyyFsbt05f9rpPutqcgOOJ0 PuaXT+Mb+nel56TTpmdnnweaQXXwQLlC+C0X3FBgRI/t7S4iH3i53705ghoWLZMECy0M 4JJQ== X-Gm-Message-State: AOAM5300Pg3kAmM/BsGWhdnlnqhuXijsaf6T+C6ez7XX7Lmsm3MtYXCD eZqJKkiZPeSwYFa5DGSMPxcu0g== X-Google-Smtp-Source: ABdhPJw9oo8pfsuehCGY22+GnK13HnMCljfQRckQGf4lIiSb36XKwJQOyruMnCDQuGqbsropcrAgFw== X-Received: by 2002:adf:e60e:: with SMTP id p14mr51698572wrm.31.1594117037406; Tue, 07 Jul 2020 03:17:17 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:16 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 24/28] ASoC: codecs: jz4770: Remove defined but never used variable 'mic_boost_tlv' Date: Tue, 7 Jul 2020 11:16:38 +0100 Message-Id: <20200707101642.1747944-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061718_628942_E8D9B5E8 X-CRM114-Status: GOOD ( 12.43 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Paul Cercueil , ter Huurne , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): In file included from include/sound/tlv.h:10, from sound/soc/codecs/jz4770.c:19: sound/soc/codecs/jz4770.c:306:35: warning: ‘mic_boost_tlv’ defined but not used [-Wunused-const-variable=] 306 | static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0); | ^~~~~~~~~~~~~ include/uapi/sound/tlv.h:64:15: note: in definition of macro ‘SNDRV_CTL_TLVD_DECLARE_DB_SCALE’ 64 | unsigned int name[] = { | ^~~~ sound/soc/codecs/jz4770.c:306:14: note: in expansion of macro ‘DECLARE_TLV_DB_SCALE’ 306 | static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0); | ^~~~~~~~~~~~~~~~~~~~ Cc: Paul Cercueil Cc: ter Huurne Signed-off-by: Lee Jones Reviewed-by: Paul Cercueil --- sound/soc/codecs/jz4770.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 34775aa624024..4dee585761c24 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -303,7 +303,6 @@ static int jz4770_codec_digital_mute(struct snd_soc_dai *dai, int mute) static const DECLARE_TLV_DB_MINMAX_MUTE(dac_tlv, -3100, 0); static const DECLARE_TLV_DB_SCALE(adc_tlv, 0, 100, 0); static const DECLARE_TLV_DB_MINMAX(out_tlv, -2500, 600); -static const DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0); static const DECLARE_TLV_DB_SCALE(linein_tlv, -2500, 100, 0); /* Unconditional controls. */ From patchwork Tue Jul 7 10:16:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648245 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7DDEF14E3 for ; Tue, 7 Jul 2020 10:25:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54D962065F for ; Tue, 7 Jul 2020 10:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qhUHaPSt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SJcEfdTt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54D962065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VtaxbKhqmaNTKbEoWPf1GEGQbxOBD2uCb9JjoaoRaj0=; b=qhUHaPSt1dLRuWETciTdo9ylc 5aepl1dNstGdi2P5zkQEocuLOLT9lvRnsjQ0rnTCE8E3xdVsx6pORb1eErsWD8ODSTOm5aBn44Lxs HiFbVYJF64JbbWj68WgSdGCWcFwDXS5owqqcwpQw+XKtqR6AUnU4oqCkzrt2L5ldKUvMCkqC8MtPZ xjxd56yxyLvKy0mAPCELHYkN1qsnFsKdx3G8AFMHilztIEHbGBC9HMSLaTsbs/LImu+Fc7HPaTQUw 5C7EfQpsDutkTIaO4UyBw5dOvPxFTUVCCiROJ6nDU61xZWUMgWAIdAeL6l7kyIxscQECi1Kqp+RCi x0eefZD8A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskkE-0007MS-AH; Tue, 07 Jul 2020 10:22:34 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskf9-0004Iu-Me for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:25 +0000 Received: by mail-wr1-x443.google.com with SMTP id q5so44518647wru.6 for ; Tue, 07 Jul 2020 03:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ud7YS/nxWFCEKdfNWplmyakfpWkMMmFHvetIuQwMK9A=; b=SJcEfdTtluJRJ9drVxAEM084sLA2jjg2omREK8yyLHD5QF4fquunCIC3osGjdY+i8M BrPPOXhxhQSpxRhiU4+fbkmi+4dMKtSbB8gYesK+Z9X3T1NqQeLhdRgH2vWDU1cvpE+R PYS0ZwS8h1ihPLT3G3c16hhCJ1KBoJG1ZbsPwrXQ1QNq/BicFRrDnZJzAccXitAGMYne lPh0gdOFjd2w94WzTScj+7JLsDxkoGXcOyAshHQgtAv+5pB6mE+oZp6R+1uD5ZsUTis8 eWLozHqgIHEAodALeznoyshSfIRd8qod9GXI8pQkFLJVOp8LwD5JpC5Mc4zMr2ad2Dzl HLtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ud7YS/nxWFCEKdfNWplmyakfpWkMMmFHvetIuQwMK9A=; b=IYmDissBnZ/oMqS69UQaW+qGYGcLdWbe5oDAx0nK1bNHII6ijFOsmMSFUISlaJyXSQ AOpuHmBQteausOdzxvOwogpy/4JQLaV+f8FdE/qtfWEAW8NKGIvvkATNPpwrsd5zDec4 nmTK39oRd+FUxwFcWDAjs4sgx8TW7nlj9JNfhYJ7UEb1ckBr2zfihzZw6JNkfXXNMVzt ll1JbOKbRF6xFjKD9o/QL8rQ7QQB0ruWRMNaJ9L5bKFc2pGFXrFr2kFHirh2DfVzPoX0 PuX84cF7gWcHRwW2fVE0HLwcYAGN1TyOIQU+IT9XcB4rkOIzOJId+BBZOUM4vGRzJOug ziuA== X-Gm-Message-State: AOAM5310y8D/+Iy9roo4pClYu1Y5JkZKnn4Juh2LJLtY82zr0g8C0Wt5 T8Zy+hVaP2IMtWhpjXfctTyOAA== X-Google-Smtp-Source: ABdhPJzRh/ancHeMqyP+Io8AG6Q6pzx7xBhbdTVJ+PS2MJdQ9kFHphykVYJVX0M5fqWOZIm7rVI35g== X-Received: by 2002:adf:f711:: with SMTP id r17mr54294795wrp.409.1594117038542; Tue, 07 Jul 2020 03:17:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:17 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 25/28] ASoC: codecs: rt5631: Demote misuse of kerneldoc to standard comment blocks Date: Tue, 7 Jul 2020 11:16:39 +0100 Message-Id: <20200707101642.1747944-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061719_908874_D9383753 X-CRM114-Status: GOOD ( 12.07 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, flove , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Little or no attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/rt5631.c:72: warning: Function parameter or member 'component' not described in 'rt5631_write_index' sound/soc/codecs/rt5631.c:72: warning: Function parameter or member 'reg' not described in 'rt5631_write_index' sound/soc/codecs/rt5631.c:72: warning: Function parameter or member 'value' not described in 'rt5631_write_index' sound/soc/codecs/rt5631.c:82: warning: Function parameter or member 'component' not described in 'rt5631_read_index' sound/soc/codecs/rt5631.c:82: warning: Function parameter or member 'reg' not described in 'rt5631_read_index' sound/soc/codecs/rt5631.c:367: warning: Function parameter or member 'component' not described in 'onebit_depop_power_stage' sound/soc/codecs/rt5631.c:405: warning: Function parameter or member 'component' not described in 'onebit_depop_mute_stage' sound/soc/codecs/rt5631.c:443: warning: Function parameter or member 'component' not described in 'depop_seq_power_stage' sound/soc/codecs/rt5631.c:515: warning: Function parameter or member 'component' not described in 'depop_seq_mute_stage' Cc: Oder Chiou Cc: flove Signed-off-by: Lee Jones --- sound/soc/codecs/rt5631.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index b5184f0e10e34..f1ace236c401e 100644 --- a/sound/soc/codecs/rt5631.c +++ b/sound/soc/codecs/rt5631.c @@ -64,7 +64,7 @@ static const struct reg_default rt5631_reg[] = { { RT5631_PSEUDO_SPATL_CTRL, 0x0553 }, }; -/** +/* * rt5631_write_index - write index register of 2nd layer */ static void rt5631_write_index(struct snd_soc_component *component, @@ -74,7 +74,7 @@ static void rt5631_write_index(struct snd_soc_component *component, snd_soc_component_write(component, RT5631_INDEX_DATA, value); } -/** +/* * rt5631_read_index - read index register of 2nd layer */ static unsigned int rt5631_read_index(struct snd_soc_component *component, @@ -357,7 +357,7 @@ static int check_adcr_select(struct snd_soc_dapm_widget *source, return !(reg & RT5631_M_MIC2_TO_RECMIXER_R); } -/** +/* * onebit_depop_power_stage - auto depop in power stage. * @enable: power on/off * @@ -395,7 +395,7 @@ static void onebit_depop_power_stage(struct snd_soc_component *component, int en snd_soc_component_write(component, RT5631_INT_ST_IRQ_CTRL_2, hp_zc); } -/** +/* * onebit_depop_mute_stage - auto depop in mute stage. * @enable: mute/unmute * @@ -433,7 +433,7 @@ static void onebit_depop_mute_stage(struct snd_soc_component *component, int ena snd_soc_component_write(component, RT5631_INT_ST_IRQ_CTRL_2, hp_zc); } -/** +/* * onebit_depop_power_stage - step by step depop sequence in power stage. * @enable: power on/off * @@ -505,7 +505,7 @@ static void depop_seq_power_stage(struct snd_soc_component *component, int enabl snd_soc_component_write(component, RT5631_INT_ST_IRQ_CTRL_2, hp_zc); } -/** +/* * depop_seq_mute_stage - step by step depop sequence in mute stage. * @enable: mute/unmute * From patchwork Tue Jul 7 10:16:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648255 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2AE796C1 for ; Tue, 7 Jul 2020 10:26:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE64720702 for ; Tue, 7 Jul 2020 10:26:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uBwp6Xh+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RJJDMHb5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE64720702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ziq5weAetvNFX9uGIpnqJgfLVi0koNfTCJGzwYynQ+0=; b=uBwp6Xh+bQ78piDhehykx3H+y 2++3IB+bW2Ioe+DOprn+0GMH/6d+3Ho1iuIVuE0F0E2IeTAQFpbQZ2y39c4Ltz1+Lp38N7bqH6Twt vV51r1Wqg4fYo5U1wDFZpuiFUU/8Bta4p6+F2ncJxpRlkI7pJjkYs66zBTHt8g1myDlvPIzjXPLSQ /FgsIhdxliSy4i6eaAkhMjste4iIB6p3doRF6r2a14rRAZMSuq27KpR3GNRt78PJk9U9Tx3aWXHZn he1e8peV8BMQpiw/CUcBPf7myvavW1uKfbNKkyJnCOlDiDIgIRCZIh4U1ZZwl+W2nClYE2hCxyJNQ 74Ayo2XiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskli-00084Q-1N; Tue, 07 Jul 2020 10:24:06 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfA-0004JP-WB for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:28 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so42683739wmj.2 for ; Tue, 07 Jul 2020 03:17:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uo5lua4EqbM6dOWxZ2PX5/59WiGZNeMIYC5zygYLP+w=; b=RJJDMHb5PseEHV13fK3dntfY0SifRUv3KOer7kIUTRvgXuZ4xlS45hcCxG5BKlewVC 3hP+gmb2xP8RQZ4rXrBu7OAMcj1IjYnk/Hq8f5w+JQIvyEKO1gCKJqlBEWxmNCyou+gh RVSC+T3bqxktFOZj/7Cj+oOt0FWUcOpX2WZL3ggGMoRNb3BBwPGNOjBsphEau4CyJlWx HRhZzBsx+Zeb3zzu6VHY6FFwmBLm0Xf3cA5G6VqXRm+bw6pVJKQSqdh+a+CDvFyxFPZm tt7mqjlndBOcwoFBaY1YXUAZ/dYDPaXolLxY/JRUFFiXiX+li4ymLYlyNAFDfkDvl0fJ 28eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uo5lua4EqbM6dOWxZ2PX5/59WiGZNeMIYC5zygYLP+w=; b=PaHQJR853eQJO8bILAYBiMSJRJrvVX+lgUTEQCUesEwFf3Hfrz3q5r1tI9HrGMHjai FOvtymU1d8YiShlnSxnyrBOLrPgdRBcvbfy87W/wLrKT3b+nl/8qGoJ9J+EuroVLtNvR Kh9gtP8DdxMsuhrEYVhp6B41sIN1Tyo4ppoNTGF9W35X8SYGOsvcoJsA6dBNwmX9TLnh I68deDibZU7dCP1zY7Qdac6/IHd9Urmo0Y1sT0iotkonFqbxG86/Qx5/T3fam3dfOGGq KJHyArCQ6XK6sMjqmdC6uTooID/hF0JXE9XoHey7q9XMIRAKO8R9RtJfL0o5nsSN6KjF 2k0w== X-Gm-Message-State: AOAM530Ev8QTx1PPc82c+NSycUWOAPHpN8VrOdgpr6uuwZRdXFNvdWiB yI9B6s7gC4c6ZohSXUtPduyR0g== X-Google-Smtp-Source: ABdhPJwBZScVrLRaoB2qbt1B7gPdAiGWJE3GpDYVPkVBQkQeuhCY3G1NK1G3mX96r9YIsd6G8GLX1g== X-Received: by 2002:a7b:c38c:: with SMTP id s12mr3392098wmj.136.1594117039808; Tue, 07 Jul 2020 03:17:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:19 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 26/28] ASoC: codecs: rt5659: Remove many unused const variables Date: Tue, 7 Jul 2020 11:16:40 +0100 Message-Id: <20200707101642.1747944-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061721_213865_08DFA017 X-CRM114-Status: GOOD ( 12.06 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Oder Chiou , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Bard Liao , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks as though they've never been used. Fixes the following W=1 kernel build warning(s): In file included from sound/soc/codecs/rt5659.c:25: In file included from sound/soc/codecs/rt5659.c:25: sound/soc/codecs/rt5659.c:1232:2: warning: ‘rt5659_ad_monor_asrc_enum’ defined but not used [-Wunused-const-variable=] 1232 | rt5659_ad_monor_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_R_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1231:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1231 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1228:2: warning: ‘rt5659_ad_monol_asrc_enum’ defined but not used [-Wunused-const-variable=] 1228 | rt5659_ad_monol_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_L_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1227:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1227 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1224:2: warning: ‘rt5659_ad_sto2_asrc_enum’ defined but not used [-Wunused-const-variable=] 1224 | rt5659_ad_sto2_asrc_enum, RT5659_ASRC_3, RT5659_AD_STO2_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1223:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1223 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1220:2: warning: ‘rt5659_ad_sto1_asrc_enum’ defined but not used [-Wunused-const-variable=] 1220 | rt5659_ad_sto1_asrc_enum, RT5659_ASRC_2, RT5659_AD_STO1_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1219:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1219 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1216:2: warning: ‘rt5659_da_monor_asrc_enum’ defined but not used [-Wunused-const-variable=] 1216 | rt5659_da_monor_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_R_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1215:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1215 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1212:2: warning: ‘rt5659_da_monol_asrc_enum’ defined but not used [-Wunused-const-variable=] 1212 | rt5659_da_monol_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_L_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1211:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1211 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/rt5659.c:1208:2: warning: ‘rt5659_da_sto_asrc_enum’ defined but not used [-Wunused-const-variable=] 1208 | rt5659_da_sto_asrc_enum, RT5659_ASRC_2, RT5659_DA_STO_T_SFT, 0x7, | ^~~~~~~~~~~~~~~~~~~~~~~ include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’ 359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~ sound/soc/codecs/rt5659.c:1207:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’ 1207 | static SOC_VALUE_ENUM_SINGLE_DECL( | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Oder Chiou Cc: Bard Liao Signed-off-by: Lee Jones --- sound/soc/codecs/rt5659.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/sound/soc/codecs/rt5659.c b/sound/soc/codecs/rt5659.c index 541fc6f1089bb..41e5917b16a5e 100644 --- a/sound/soc/codecs/rt5659.c +++ b/sound/soc/codecs/rt5659.c @@ -1195,43 +1195,6 @@ static const struct snd_kcontrol_new rt5659_if3_dac_swap_mux = static const struct snd_kcontrol_new rt5659_if3_adc_swap_mux = SOC_DAPM_ENUM("IF3 ADC Swap Source", rt5659_if3_adc_enum); -static const char * const rt5659_asrc_clk_src[] = { - "clk_sysy_div_out", "clk_i2s1_track", "clk_i2s2_track", - "clk_i2s3_track", "clk_sys2", "clk_sys3" -}; - -static unsigned int rt5659_asrc_clk_map_values[] = { - 0, 1, 2, 3, 5, 6, -}; - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_da_sto_asrc_enum, RT5659_ASRC_2, RT5659_DA_STO_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_da_monol_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_L_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_da_monor_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_R_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_ad_sto1_asrc_enum, RT5659_ASRC_2, RT5659_AD_STO1_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_ad_sto2_asrc_enum, RT5659_ASRC_3, RT5659_AD_STO2_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_ad_monol_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_L_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - -static SOC_VALUE_ENUM_SINGLE_DECL( - rt5659_ad_monor_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_R_T_SFT, 0x7, - rt5659_asrc_clk_src, rt5659_asrc_clk_map_values); - static int rt5659_hp_vol_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { From patchwork Tue Jul 7 10:16:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648247 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4189214B7 for ; Tue, 7 Jul 2020 10:25:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19108206B6 for ; Tue, 7 Jul 2020 10:25:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EIVj228t"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y6F9hlhl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19108206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jThaIjFTxDzIQ5fZXZ6kidLeHEChDUKsYQwpKJZrCqk=; b=EIVj228t7n2A/RtYISD0bViR9 XhEmLmotPbJDPT6ICrKoCoEE7RcrXcRzK5N2QHMDJ0DYYlxh09sfAfZycM/Y3WmUZMPdlWN3vOuWd bUn9DKcuuwD6OR91QOEV0QOgg3fs86EGAWZD2HbWeDGjr7jDLH37Jz6APtc1Y3kDcT2a+1KIPpwUY H3t4RZ/X6Yd2gKy0/FMHH4FHbopADVdDPbN2FpIwRlCtDMJY+tl2yzJvbysNUOpL5c/WXxh25Q+kR LyoVVQ+UpMxnCKDAzxC9wdVj1ZA+Pe05aBkdetKMF9uWxV37yiV4g4eqrjZH9ZoZ38GJYcT6Usrmi Vcu/NXFiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskkg-0007b0-VZ; Tue, 07 Jul 2020 10:23:03 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfC-0004K8-Hm for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:29 +0000 Received: by mail-wm1-x341.google.com with SMTP id l17so42691908wmj.0 for ; Tue, 07 Jul 2020 03:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GL1MoJKxnZtWyOmgkHZ5ZdLcj+7xXQIgEe9rUvPd4fk=; b=Y6F9hlhltdfKqf7rUHge+Z/I8Om08eU1SVFzRpv3TDOhmPvM9NURwqhOyyLVfI1Vb4 BqUBp0JbKvL5b8IjHEUFXRsWnP36t2lkN2REOpkuVSjdiuAe56EMv2KCjf7uDPtI0Lpi jOTz+FHuWVueoCq7I7YD4Uv+TqF/FEaBTg8jla19QgpBMo1Pio0tYDrtAFkgsdqCz9N6 fpFI3yKqDfH1I/os94fMLiK9ei7oND1VEkkMLIUYq13l9KmD6P8SyzeiTXRJkr5e9v1H JgC+/inW/oO6efg0baiUOq+sZeQQGGrv2ZIbVih4nL+lFEk2d1gDBg+PELv6YK8Oevnl HEjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GL1MoJKxnZtWyOmgkHZ5ZdLcj+7xXQIgEe9rUvPd4fk=; b=cEIxy6bcxM3mHmrgPiufe6AVrrvVEv5MVi8QaOxnUww4RpvNPS5C7qVXW1ENoW/0fS P6qjoOs83ty45M2N7DfshmXMLV7MIFHm01mNPMY1gtX7mjWFgB8e6gLNAdMRnZlz+jcX 246rKxK9hdPMlm8PJ18AleFGsDBf8IwmVe9Cg71+pnxwHpIprDgD1ZxAAIaUKlQPjyCc kRbjytIRtHmHzAj8xlyrbOeYmPWpf7PBQAFV+C/wJHTw/V2H3r4k6S1e/0TBGAZ6tUzS 5hRwRkEonoeuJW36cQLnvtIFNhil9Ivd39iQsaLWmUp5sOJ1tTbmDNvy9kays7VA8URR OuQg== X-Gm-Message-State: AOAM531K9Wjyd34arsuoRSiFueHFznxNp8i6S2hBchdlo2Ecge17VD40 gppNGO0iWaapePTO6ScVPMovkQ== X-Google-Smtp-Source: ABdhPJys3a86OxKV+EWBwNFIyLWi784LN6fGl3f7t0+dy9DQHj3SWrOybRjJElejQDlEqlUS/0V1dA== X-Received: by 2002:a7b:c208:: with SMTP id x8mr3446081wmi.49.1594117041183; Tue, 07 Jul 2020 03:17:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:20 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 27/28] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header Date: Tue, 7 Jul 2020 11:16:41 +0100 Message-Id: <20200707101642.1747944-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061722_706913_E6A71ABC X-CRM114-Status: GOOD ( 13.08 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, Grant Likely , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): sound/soc/codecs/tlv320aic26.c:138: warning: Function parameter or member 'dai' not described in 'aic26_mute' sound/soc/codecs/tlv320aic26.c:138: warning: Function parameter or member 'mute' not described in 'aic26_mute' Cc: Kuninori Morimoto Cc: Grant Likely Signed-off-by: Lee Jones --- sound/soc/codecs/tlv320aic26.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c index 032b397356438..4569bbc08acb3 100644 --- a/sound/soc/codecs/tlv320aic26.c +++ b/sound/soc/codecs/tlv320aic26.c @@ -131,7 +131,7 @@ static int aic26_hw_params(struct snd_pcm_substream *substream, return 0; } -/** +/* * aic26_mute - Mute control to reduce noise when changing audio format */ static int aic26_mute(struct snd_soc_dai *dai, int mute) From patchwork Tue Jul 7 10:16:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11648259 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 64C5914B7 for ; Tue, 7 Jul 2020 10:27:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C6BE2065F for ; Tue, 7 Jul 2020 10:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KMm18vvW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C0uhEvrw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C6BE2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XjyIREVzL6RGQufVIGO2HjMT0b640fQGo54V510GJcw=; b=KMm18vvWEMIT9bIz5NgEJwM4G IYYooKvr9c4/bdGODRuY5kpk5nhRHok55uGHsXZAEKaBgB2Yo1YWVXxHZXMclIRfPrfLDy7KWtpAh Wp0ECo53zNxBrHBJn8lQPgzSibzDt59hBU/2+Za/iCjB0R+JWHjV2+deK+4m4QwdzVKq8d4yQmD7l lg4b/1k3q2JeW2Y/xoyv/cnicQUUO2JcJPODMvB9sghoTWkTltYzdv6V0E/f8p9BkpY14+yk72Yqs FckunqYgHhldX84hv/utu7xst5EZ99HCsH7sgEtzww67ApKdRGEMPWOQ7127F3Cj2W/5FQ1b82N81 BENw76Ptw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskmu-0000P8-IQ; Tue, 07 Jul 2020 10:25:20 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jskfD-0004L7-Oc for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 10:17:33 +0000 Received: by mail-wm1-x342.google.com with SMTP id g75so42669685wme.5 for ; Tue, 07 Jul 2020 03:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mkgQ5GKpYIPow7Og+7iz9PKlHm4fJKjWVXLF1XFMGh8=; b=C0uhEvrw6Cb6IHyeUQxsYIXDlt3MpDWf+csmiOXGn8Tz+dxr65xSfiRAXDv0HcY7VA NvpMy1QsPzCkYFLQA/o8gvCmNN5LUa6IzlRX+YurOnzL/MvvpNS1KRUxqYpOgpLfdjE1 S2OtbToPGQBg8bUH8J1mfVOMyo4577J/aIDCuTAdvoPMQOHr7bqo4ZA6P7mvSbmnTivp QG0NtI5BiM4i5cVDFeBAKf5Ou9B19WCz8jkZYmqAkbgdhl5KYNI6mtDzea4vd0V4DJLI uLs+F14Mfcp16TcdvjfEn3NvNcwnkFxvfenN1oYO0taaEW1PJM+hY9kvVQ5vBZcyvZ0W JOJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mkgQ5GKpYIPow7Og+7iz9PKlHm4fJKjWVXLF1XFMGh8=; b=PxTT60PBBTXpzixIcqLl8XoAT4v1tnA6llxgZKL0MtyYWt+1lvfh/D7XkX5CU8p+Lu Cz/e5WJ/SCPzigBQPoon2OJAQxeCwBF6KJJL8DxTIjuyRbm75e7XGRDmbHW50mbzIFBN f4vnLTlUN3teLCk8SUdYRz+Of7dCbSTipcbckM1aSJChvzkEG3Nhy1y6Hsw/SdMzwaaE aVoLVF6vfWKAkX96a/dunz90dm3WnJr8/H1FPvAFnNPLjS5nku/PYTvbYbZSZv5eFeoh +gn+nTlWXG+5Hw9nMaSQB+jbh1wKGsxwtROSA1ZK9veahniK4JyyHdhgVfq15PgXAr8k KFHA== X-Gm-Message-State: AOAM533xJt1NmVxT+wVEfmTeZ9tK++NL/6x85cjdagrJcd4VrDQ2W1P5 6tvwCaIf/iKzhSchHrMNiGb381qlxzw= X-Google-Smtp-Source: ABdhPJyfry+2eTSCxNFY+4n4PKf/X6rv1JuST/nCviW5AF3KdytzTgNqbLpj9UGcP7OiMG0Dy8C7Tg== X-Received: by 2002:a7b:cc08:: with SMTP id f8mr3624996wmh.106.1594117042719; Tue, 07 Jul 2020 03:17:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id z8sm469409wmg.39.2020.07.07.03.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:17:22 -0700 (PDT) From: Lee Jones To: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com Subject: [PATCH 28/28] ASoC: codecs: wm8400: Remove a bunch of unused variables Date: Tue, 7 Jul 2020 11:16:42 +0100 Message-Id: <20200707101642.1747944-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707101642.1747944-1-lee.jones@linaro.org> References: <20200707101642.1747944-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_061723_933825_38E53C38 X-CRM114-Status: GOOD ( 11.86 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): sound/soc/codecs/wm8400.c:443:38: warning: ‘wm8400_dapm_rxvoice_controls’ defined but not used [-Wunused-const-variable=] 443 | static const struct snd_kcontrol_new wm8400_dapm_rxvoice_controls[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/sound/tlv.h:10, from sound/soc/codecs/wm8400.c:26: sound/soc/codecs/wm8400.c:78:35: warning: ‘out_omix_tlv’ defined but not used [-Wunused-const-variable=] 78 | static const DECLARE_TLV_DB_SCALE(out_omix_tlv, -600, 0, 0); | ^~~~~~~~~~~~ include/uapi/sound/tlv.h:64:15: note: in definition of macro ‘SNDRV_CTL_TLVD_DECLARE_DB_SCALE’ 64 | unsigned int name[] = { | ^~~~ sound/soc/codecs/wm8400.c:78:14: note: in expansion of macro ‘DECLARE_TLV_DB_SCALE’ 78 | static const DECLARE_TLV_DB_SCALE(out_omix_tlv, -600, 0, 0); | ^~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/wm8400.c:70:35: warning: ‘rec_mix_tlv’ defined but not used [-Wunused-const-variable=] 70 | static const DECLARE_TLV_DB_SCALE(rec_mix_tlv, -1500, 600, 0); | ^~~~~~~~~~~ include/uapi/sound/tlv.h:64:15: note: in definition of macro ‘SNDRV_CTL_TLVD_DECLARE_DB_SCALE’ 64 | unsigned int name[] = { | ^~~~ sound/soc/codecs/wm8400.c:70:14: note: in expansion of macro ‘DECLARE_TLV_DB_SCALE’ 70 | static const DECLARE_TLV_DB_SCALE(rec_mix_tlv, -1500, 600, 0); | ^~~~~~~~~~~~~~~~~~~~ Cc: Kuninori Morimoto Cc: patches@opensource.cirrus.com Signed-off-by: Lee Jones --- sound/soc/codecs/wm8400.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c index 2551eb0f1868c..35ffa7765c85c 100644 --- a/sound/soc/codecs/wm8400.c +++ b/sound/soc/codecs/wm8400.c @@ -67,16 +67,12 @@ static void wm8400_component_reset(struct snd_soc_component *component) wm8400_reset_codec_reg_cache(wm8400->wm8400); } -static const DECLARE_TLV_DB_SCALE(rec_mix_tlv, -1500, 600, 0); - static const DECLARE_TLV_DB_SCALE(in_pga_tlv, -1650, 3000, 0); static const DECLARE_TLV_DB_SCALE(out_mix_tlv, -2100, 0, 0); static const DECLARE_TLV_DB_SCALE(out_pga_tlv, -7300, 600, 0); -static const DECLARE_TLV_DB_SCALE(out_omix_tlv, -600, 0, 0); - static const DECLARE_TLV_DB_SCALE(out_dac_tlv, -7163, 0, 0); static const DECLARE_TLV_DB_SCALE(in_adc_tlv, -7163, 1763, 0); @@ -439,14 +435,6 @@ static SOC_ENUM_SINGLE_DECL(wm8400_ainrmux_enum, static const struct snd_kcontrol_new wm8400_dapm_ainrmux_controls = SOC_DAPM_ENUM("Route", wm8400_ainrmux_enum); -/* RXVOICE */ -static const struct snd_kcontrol_new wm8400_dapm_rxvoice_controls[] = { -SOC_DAPM_SINGLE_TLV("LIN4/RXN", WM8400_INPUT_MIXER5, WM8400_LR4BVOL_SHIFT, - WM8400_LR4BVOL_MASK, 0, in_mix_tlv), -SOC_DAPM_SINGLE_TLV("RIN4/RXP", WM8400_INPUT_MIXER6, WM8400_RL4BVOL_SHIFT, - WM8400_RL4BVOL_MASK, 0, in_mix_tlv), -}; - /* LOMIX */ static const struct snd_kcontrol_new wm8400_dapm_lomix_controls[] = { SOC_DAPM_SINGLE("LOMIX Right ADC Bypass Switch", WM8400_OUTPUT_MIXER1,