From patchwork Tue Oct 16 14:00:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 10643581 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45BA514E2 for ; Tue, 16 Oct 2018 14:02:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 339C42A010 for ; Tue, 16 Oct 2018 14:02:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 247D32A017; Tue, 16 Oct 2018 14:02:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 909A12A010 for ; Tue, 16 Oct 2018 14:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=r1y8lKZKrHhWd+nk3sh3uczzN8tUTptgCHjDwC/4q88=; b=Izo ZzWmnTJlrCU6NeUHqHfX1JZ2+TRwNGHXZnKVxlDD8rFyQ15TWFvjBBdIKwW6Dg2PsiE7rnGjr4UAw wDHrzFNQCFq4p4sX8lkU4pq0KcDJqynni2ayNr7NtixUdpn4QL0J3L5kjhZab/Gg8n/8NbxnRCA/V aZV+WWKvPHpkvCCZuDetBRh1twx/g48rFfjp5OCJX1LiyM7YRKJsYqK5qurc0hb2jXyKoI1xLqShw SPtRlt+hbyQteefS3RmU/uHccTNvjDreCvU9LACw3Ba2Ul0WR9K1ddKuWQYeLVmOf7dCnhUcOyZmn A+JbpoyC55GfCfyvXAy0k+54ZZCRV4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCPv4-0004BX-OR; Tue, 16 Oct 2018 14:01:58 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCPui-0003u0-FS for linux-arm-kernel@lists.infradead.org; Tue, 16 Oct 2018 14:01:53 +0000 Received: by mail-wr1-x441.google.com with SMTP id e4-v6so25691769wrs.0 for ; Tue, 16 Oct 2018 07:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=AyjUgKMFmAFThaK4GvWsdrdl4JZ3kTa6zVPrOmGMjOA=; b=OwrJnI6D/huHRM5jiagiGiKBxUHFUlMvwe1t2GexoIKOTqtFGY3vwPCkrAUWdnT5+f n+wvqEq+enR14QpmLTY3VNYAsxMcDtJOZ2R2Cw0rRdiHypMeUGRanfszUimV9omTlSGH ApMgMERT+Pim+X1tp/uH775sDaVLHsJDyJb2Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AyjUgKMFmAFThaK4GvWsdrdl4JZ3kTa6zVPrOmGMjOA=; b=ZaNqaLBqSe8WGKRluBU0z6b437gvQlscAkDBmeXhQqHPIEsGvsTzFfwfYq8aYQVsK6 jLNXb7F/j2HY3ij6GJpPSphLpA9bjj3jRQF/d3LGk2HVeF5hTm7P2sbfINOXIc/qJLyg 3Nv09OLuREKiGFLSk9usCVKkm35xYzoJI+57Qx+8DHENyOLzvlBsEcXGCpVLXIrQkwkG CLwHFkqSRjQkXPTrCTjh/jy4xzEAin34gpNuYjSzVGxriwf8DFCAahR2wLYH+5kOJQYu zk1wuw4fZRHBVFkS2yvlx26YxFH+84GXH8aRmhNYzKQWnj0ICPZKBBgiXnTsleVcclGD kNtw== X-Gm-Message-State: ABuFfojyGKMqGYgRWOVmkEgkBlc3FRoFSnypIoQxnZU9n/WyaVLVzP9B vFIKvNIxoU68QGfcLpKRtbKG+Q== X-Google-Smtp-Source: ACcGV614RNSZy+OjIvsEaE9ONlZaDAeI1a8EpD+wP5Gt58g75Bh8DJgL6KJJ2ZjTenoZPwHLydiQBg== X-Received: by 2002:adf:cd0c:: with SMTP id w12-v6mr19534363wrm.67.1539698480294; Tue, 16 Oct 2018 07:01:20 -0700 (PDT) Received: from localhost.localdomain (221.56.88.92.rev.sfr.net. [92.88.56.221]) by smtp.gmail.com with ESMTPSA id b81-v6sm10195012wmh.47.2018.10.16.07.01.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Oct 2018 07:01:19 -0700 (PDT) From: Daniel Lezcano To: heiko@sntech.de Subject: [PATCH] DT: rockchip: Fix stability issues with the 'performance' governor on rock960 Date: Tue, 16 Oct 2018 16:00:20 +0200 Message-Id: <1539698431-12616-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181016_070136_587631_AE67D800 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Shawn Lin , linux-kernel@vger.kernel.org, Vicente Bergas , "open list:ARM/Rockchip SoC support" , Rob Herring , Manivannan Sadhasivam , Enric Balletbo i Serra , Ezequiel Garcia , "moderated list:ARM/Rockchip SoC support" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When the performance governor is set as default, the rock960 hangs around one minute after booting, whatever the activity is (idle, key pressed, loaded, ...). Based on the commit log found at https://patchwork.kernel.org/patch/10092377/ "vdd_log has no consumer and therefore will not be set to a specific voltage. Still the PWM output pin gets configured and thence the vdd_log output voltage will changed from it's default. Depending on the idle state of the PWM this will slightly over or undervoltage the logic supply of the RK3399 and cause instability with GbE (undervoltage) and PCIe (overvoltage). Since the default value set by a voltage divider is the correct supply voltage and we don't need to change it during runtime we remove the rail from the devicetree completely so the PWM pin will not be configured." After removing the vdd-log from the rock960's specific DT, the board does no longer hang and shows a stable behavior. Apply the same change for the rock960 by removing the vdd-log from the DT. Signed-off-by: Daniel Lezcano Tested-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index 6c8c4ab..56abbb0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi @@ -57,18 +57,6 @@ regulator-always-on; vin-supply = <&vcc_sys>; }; - - vdd_log: vdd-log { - compatible = "pwm-regulator"; - pwms = <&pwm2 0 25000 0>; - regulator-name = "vdd_log"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1400000>; - regulator-always-on; - regulator-boot-on; - vin-supply = <&vcc_sys>; - }; - }; &cpu_l0 {