From patchwork Tue Jul 7 17:34:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 11649443 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 712B1618 for ; Tue, 7 Jul 2020 17:34:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AD8120773 for ; Tue, 7 Jul 2020 17:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vC1opu1I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AD8120773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=K/LYCtfZtLF5bnMTt360IUroJYrFPpX34YFjO3IUieo=; b=vC1opu1It/FOUZ0K0+sQnNufZj 1G8ajZ7JP2bqMU2qOEC9p6bpI4K5XUT2e6b/RCbDebV4iGGrNAaHkAJZuevr8qoJZ/CfiJ6ZCKr4+ 5+tg7vR0XFN7kqvu4yGI92+G8E5NVDoFjuGueZA3dTmi/hTBzQGLFAA22WIBuFx0+fFrE3l+55J5e nsgIKCyBTpCcec0hNJjaJpGapbe3llwxIm4Ls2EJXv1XzvfHxEj/BTwVyOvqXjFC9TkHV8cESL6ry cNFjWBT3B6IH7JOzaekT/1pCJrpQIufQ+p12bat8WRXoO9jNElnamN5gk+TizYbi0hYBJNHSdMamj rI8+s7Zw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsrUH-0000pc-L6; Tue, 07 Jul 2020 17:34:33 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsrUF-0000oJ-Ec for linux-rockchip@lists.infradead.org; Tue, 07 Jul 2020 17:34:32 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id D83D52A077A From: Dafna Hirschfeld To: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com Subject: [PATCH] media: staging: rkisp1: comment each define (RKISP1_CIF_ISP_MODULE_*), explaining what the abbreviation means Date: Tue, 7 Jul 2020 19:34:13 +0200 Message-Id: <20200707173413.13977-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_133431_610705_AE69DB42 X-CRM114-Status: UNSURE ( 5.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com, dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org Add one line comment before each module define 'RKISP1_CIF_ISP_MODULE_*' explaining what the abbreviation means. Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike --- .../staging/media/rkisp1/uapi/rkisp1-config.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/staging/media/rkisp1/uapi/rkisp1-config.h b/drivers/staging/media/rkisp1/uapi/rkisp1-config.h index 57f5035d62a4..b2923b2833d3 100644 --- a/drivers/staging/media/rkisp1/uapi/rkisp1-config.h +++ b/drivers/staging/media/rkisp1/uapi/rkisp1-config.h @@ -18,23 +18,41 @@ #define V4L2_META_FMT_RK_ISP1_PARAMS v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 params */ #define V4L2_META_FMT_RK_ISP1_STAT_3A v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A statistics */ +/* Defect Pixel Cluster Detection */ #define RKISP1_CIF_ISP_MODULE_DPCC BIT(0) +/* Black Level Subtraction */ #define RKISP1_CIF_ISP_MODULE_BLS BIT(1) +/* Sensor De-gamma */ #define RKISP1_CIF_ISP_MODULE_SDG BIT(2) +/* Histogram */ #define RKISP1_CIF_ISP_MODULE_HST BIT(3) +/* Lens Shade Control */ #define RKISP1_CIF_ISP_MODULE_LSC BIT(4) +/* Auto White Balance Gain */ #define RKISP1_CIF_ISP_MODULE_AWB_GAIN BIT(5) +/* Filter */ #define RKISP1_CIF_ISP_MODULE_FLT BIT(6) +/* Bayer Demosaic */ #define RKISP1_CIF_ISP_MODULE_BDM BIT(7) +/* Cross Talk */ #define RKISP1_CIF_ISP_MODULE_CTK BIT(8) +/* Gamma Out Curve */ #define RKISP1_CIF_ISP_MODULE_GOC BIT(9) +/* Color Processing */ #define RKISP1_CIF_ISP_MODULE_CPROC BIT(10) +/* Auto Focus Control */ #define RKISP1_CIF_ISP_MODULE_AFC BIT(11) +/* Auto White Balancing */ #define RKISP1_CIF_ISP_MODULE_AWB BIT(12) +/* Image Effect */ #define RKISP1_CIF_ISP_MODULE_IE BIT(13) +/* Auto Exposure Control */ #define RKISP1_CIF_ISP_MODULE_AEC BIT(14) +/* Wide Dynamic Range */ #define RKISP1_CIF_ISP_MODULE_WDR BIT(15) +/* Denoise Pre-Filter */ #define RKISP1_CIF_ISP_MODULE_DPF BIT(16) +/* Denoise Pre-Filter Strength */ #define RKISP1_CIF_ISP_MODULE_DPF_STRENGTH BIT(17) #define RKISP1_CIF_ISP_CTK_COEFF_MAX 0x100