From patchwork Tue Jul 7 19:23:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 11649897 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5957513B4 for ; Tue, 7 Jul 2020 19:24:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D578D2065D for ; Tue, 7 Jul 2020 19:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="nMpUKwqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D578D2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 528C2167F; Tue, 7 Jul 2020 21:23:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 528C2167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594149866; bh=xBUASslxjSyhTFK6h+nWFMq+LULqrshfcg1w85dLBf4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nMpUKwqXUMum63QJnGgfbPvE/Ic4qDMr9+9Hkg07UL/4DIXCvg+r/AfuVJilKZz3S FRGuQWVh39dhusFKpAqUa86SCw5Mtz/xiB1NdzSNiV9yWmMoRjWH51qzpiBSEeERfo 1Ccb6NY9+KRwIWjfVDbvWHeOgc9P0+6FYuw7TQUw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DA844F80216; Tue, 7 Jul 2020 21:23:38 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8783AF80274; Tue, 7 Jul 2020 21:23:37 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B624FF8011F for ; Tue, 7 Jul 2020 21:23:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B624FF8011F IronPort-SDR: Sd4oKXIo8jmdF2/GbZCcBeRrZd3a6B1Vn9dkLprpZwJ7I1JLDnW+9/Bx3oU6fCKh5tyAMgfee9 7L0y85ZPxrsg== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="145187058" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="145187058" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:26 -0700 IronPort-SDR: nZd1XNfBgSexdEI+Op9MoJXOk1LmIOxOGcG1+OVzQaZ0IqMS97VDSWk6TLGuC8zKrF4+G5dR8+ mVMUiSDNd3cg== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="266915972" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.254.77.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:25 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 1/3] ASoC: Intel: Skylake: remove comparison always false warning Date: Tue, 7 Jul 2020 14:23:08 -0500 Message-Id: <20200707192310.98663-2-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> References: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , tiwai@suse.de, open list , Takashi Iwai , Jie Yang , Pierre-Louis Bossart , Liam Girdwood , broonie@kernel.org, Piotr Maziarz , Lee Jones X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fix W=1 warnings: skl-sst-dsp.c: In function ‘skl_dsp_get_enabled_cores’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] cast the core number to a long to avoid checking if an unsigned value is lower than zero. Signed-off-by: Pierre-Louis Bossart --- sound/soc/intel/skylake/skl-sst-dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-sst-dsp.c b/sound/soc/intel/skylake/skl-sst-dsp.c index 225706d148d8..cb83b395f210 100644 --- a/sound/soc/intel/skylake/skl-sst-dsp.c +++ b/sound/soc/intel/skylake/skl-sst-dsp.c @@ -52,7 +52,7 @@ unsigned int skl_dsp_get_enabled_cores(struct sst_dsp *ctx) unsigned int core_mask, en_cores_mask; u32 val; - core_mask = SKL_DSP_CORES_MASK(skl->cores.count); + core_mask = SKL_DSP_CORES_MASK((long)skl->cores.count); val = sst_dsp_shim_read_unlocked(ctx, SKL_ADSP_REG_ADSPCS); From patchwork Tue Jul 7 19:23:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 11649907 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C69213B4 for ; Tue, 7 Jul 2020 19:26:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96E79206BE for ; Tue, 7 Jul 2020 19:26:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="CbDRTAS9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96E79206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2992D16B4; Tue, 7 Jul 2020 21:25:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2992D16B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594149964; bh=MnmFIyfz8opQA73+gocp84GeFftVL/WCyQjynZzRmhY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CbDRTAS9l5liB+MXhdgdXIKYBb6/83UED1Q5JsSjkmW0QqlfTxoPTt9K2qmi+2JTi pX9sj5jrFpVl6G9yStp9cEyDpczJoBWGvtt1+AZ3oVhkRTaJmGF5PfunI7sE+wSIrS mITPw1w61IYGN+Xso5f07Gjg97wYSVLY6bNMOdAs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 43A65F80264; Tue, 7 Jul 2020 21:23:44 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 94B0CF802C2; Tue, 7 Jul 2020 21:23:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 79575F80257 for ; Tue, 7 Jul 2020 21:23:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 79575F80257 IronPort-SDR: aq+QswkhpIbxrlB2CN5UJVT6vwl5Don3rWA2+G4YOtK5GSkD55Amk70RNwnDhHpEYQ7UZZDl2G yK9UmZR/rmUQ== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="145187060" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="145187060" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:28 -0700 IronPort-SDR: SXk1Q10/dEw/B/Ix8SBzmmQ/EaXgCGiyRZzY/KFVwafU5RV1QwarZfIx8N5njtxEpEbarCmYED AVEqznV6nxUQ== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="266915974" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.254.77.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:26 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 2/3] ASoC: meson: axg-pdm: remove comparison always false warning Date: Tue, 7 Jul 2020 14:23:09 -0500 Message-Id: <20200707192310.98663-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> References: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: open list , tiwai@suse.de, Kevin Hilman , Takashi Iwai , Liam Girdwood , Pierre-Louis Bossart , broonie@kernel.org, "open list:ARM/Amlogic Meson SoC support" , Lee Jones , "moderated list:ARM/Amlogic Meson SoC support" , Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fix W=1 warning. sound/soc/meson/axg-pdm.c: In function ‘axg_pdm_set_channel_mask’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] cast the channel number to an int to avoid checking if an unsigned value is lower than zero. Signed-off-by: Pierre-Louis Bossart --- sound/soc/meson/axg-pdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/axg-pdm.c b/sound/soc/meson/axg-pdm.c index bfd37d49a73e..8fe5b2563619 100644 --- a/sound/soc/meson/axg-pdm.c +++ b/sound/soc/meson/axg-pdm.c @@ -206,7 +206,7 @@ static int axg_pdm_set_sample_pointer(struct axg_pdm *priv) static void axg_pdm_set_channel_mask(struct axg_pdm *priv, unsigned int channels) { - unsigned int mask = GENMASK(channels - 1, 0); + unsigned int mask = GENMASK((int)channels - 1, 0); /* Put all channel in reset */ regmap_update_bits(priv->map, PDM_CTRL, From patchwork Tue Jul 7 19:23:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 11649905 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E8A613B4 for ; Tue, 7 Jul 2020 19:25:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E975020720 for ; Tue, 7 Jul 2020 19:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pgTl9btG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E975020720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D8E116C9; Tue, 7 Jul 2020 21:24:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D8E116C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594149921; bh=ftiznkGhVf0jDKPK0eeSfPVmWxF7EPcySZcMur+bFTs=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pgTl9btG6tqL4ecybVLtsbDB6vaLa/2oWjXo3hfuXGaacA3onvGYZT/pR98eSfNVU Zfw11n+4pA1/sRX76U2o0PGOEgTLAVeWz2AYu5VVg7NICPKAMWkeSWv9FkQz2tuW15 bt1wi/1z8naXqGlsvCev/a0jrEHQJMT9JtrAj2yI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3A8A5F800DF; Tue, 7 Jul 2020 21:23:41 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 08F88F80264; Tue, 7 Jul 2020 21:23:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 951E1F801F9 for ; Tue, 7 Jul 2020 21:23:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 951E1F801F9 IronPort-SDR: MtCZoju1H1yxTH1EtxmM/UcpQkq6Z54JNltjFMPsVOIiEUChTytoQMblH15UasqRfAseAY4SoJ scU6XT3Nd08Q== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="145187062" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="145187062" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:29 -0700 IronPort-SDR: K33tZHbvjJJz+antiIUzSPM8PCsbQXC/0det2ssOH3Ql+QVJxbrxSEX7yRQ07VjmGga7TrT+CC VjVS0Z0i/9qg== X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="266915978" Received: from mrtorger-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.254.77.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 12:23:28 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 3/3] ASoC: meson: axg-spdifin: remove comparison always false warning Date: Tue, 7 Jul 2020 14:23:10 -0500 Message-Id: <20200707192310.98663-4-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> References: <20200707192310.98663-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: open list , tiwai@suse.de, Kevin Hilman , Takashi Iwai , Liam Girdwood , Pierre-Louis Bossart , broonie@kernel.org, "open list:ARM/Amlogic Meson SoC support" , Lee Jones , "moderated list:ARM/Amlogic Meson SoC support" , Jerome Brunet X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fix W=1 warning: sound/soc/meson/axg-spdifin.c: In function ‘axg_spdifin_write_mode_param’: include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cast width to an int to avoid checking if an unsigned value is lower than zero. Signed-off-by: Pierre-Louis Bossart --- sound/soc/meson/axg-spdifin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c index d0d09f945b48..5fa411d4e985 100644 --- a/sound/soc/meson/axg-spdifin.c +++ b/sound/soc/meson/axg-spdifin.c @@ -154,7 +154,7 @@ static void axg_spdifin_write_mode_param(struct regmap *map, int mode, reg = offset * regmap_get_reg_stride(map) + base_reg; shift = width * (num_per_reg - 1 - rem); - regmap_update_bits(map, reg, GENMASK(width - 1, 0) << shift, + regmap_update_bits(map, reg, GENMASK((int)width - 1, 0) << shift, val << shift); }