From patchwork Wed Jul 8 04:47:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 11650619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A057313B4 for ; Wed, 8 Jul 2020 04:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F3D42078A for ; Wed, 8 Jul 2020 04:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ak1epF1V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbgGHErS (ORCPT ); Wed, 8 Jul 2020 00:47:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgGHErR (ORCPT ); Wed, 8 Jul 2020 00:47:17 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF6BC061755 for ; Tue, 7 Jul 2020 21:47:17 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id g6so1716414ybo.11 for ; Tue, 07 Jul 2020 21:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=t1zm4rFoTNNHC3eGsKGD6Fgub/4GaFQ3Ds768gV+HuM=; b=ak1epF1VAW1EBVYLvTEpSPZ5Yjonre4LZpvDGD5Bs6k9n7giPywAO3QnlkuTz89zsj T+qPQe4gXsjCmSRGlP1TfJmw4xFaCK4jwBd1PRh1BavDZY24XvQehmQ18sDaVHmc7KKf azGwWS/zy8Z9AokRA/Y3P2wvQkRN0V1JznLYvlDpshPZFGoYilfVfHX3dbdQqV4BoKfV rIT4gUjAqHPTSBRM8tRkq7zbwzcNRbPXEqUZPD0/DmRl2XQgfcKWrG8aSzw3lbSPxq3T CsdmFq2Ln2kWj277dbl3Nwu2+TVpY8wk/i31jBs0CijbQv/Tf5H9IOSV1ugK1m5FwFhL 4wUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=t1zm4rFoTNNHC3eGsKGD6Fgub/4GaFQ3Ds768gV+HuM=; b=p05Ure2xVQ3wNf2+W33zacIsWM2WSHN3qKAxq1FWjMZPcAL1eJY0t7pbpGaXPuHsZp ONcTwovqOMXFVJ1DGFruptfCotyrXbUhhT6LNkKgFl0ISSrErWu1ZrSRjsINIfLo0Jvo qaKpIdyMdZU6J2tZfBZza6Lvca6VyTzfUcASkAgm2DXTYAbUZCE+MZslUQlAAO1lLtBu uPNXVl6u8UmQL1O0Irg+860T8bmPlJ1RELxbrrdFVrlFtj3DqO5y8tQsO056MGzuD9eK K6mnt4AbPymp0U9AX/KsYwJkjQhzv7Tz11FfH4hRuoJmIEouNNNmCJzFY6baiEo5UzIq E8mA== X-Gm-Message-State: AOAM532vP9eWYWp1hhyFif/1qI/bdYtEG90TJ1khq+yyyKluRRkwlru7 tPk/v0EBLC1DXhHC2EJn6+2ke+nZM5pMPxEamZ28BZqB X-Google-Smtp-Source: ABdhPJzdu4Zcx3BRFbrUHXrwKaD4csW7LhbBKC9TiwQdSUBhuUt90+mw26Rs+Yb80kAvz5UHCo8MIi0ztIy1mU2+VDE= X-Received: by 2002:a25:bc81:: with SMTP id e1mr88466871ybk.375.1594183636670; Tue, 07 Jul 2020 21:47:16 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Tue, 7 Jul 2020 23:47:05 -0500 Message-ID: Subject: [SMB3][PATCH] fix unneeded error message on change notify To: CIFS Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Fix the length check on SMB3 change notify Reviewed-by: Ronnie Sahlberg From 51783092719842b4443929098af1f848df5dbeb2 Mon Sep 17 00:00:00 2001 From: Steve French Date: Tue, 7 Jul 2020 23:43:39 -0500 Subject: [PATCH] smb3: fix unneeded error message on change notify We should not be logging a warning repeatedly on change notify. CC: Stable # v5.6+ Signed-off-by: Steve French --- fs/cifs/smb2misc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 6a39451973f8..157992864ce7 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs/smb2misc.c @@ -354,9 +354,13 @@ smb2_get_data_area_len(int *off, int *len, struct smb2_sync_hdr *shdr) ((struct smb2_ioctl_rsp *)shdr)->OutputCount); break; case SMB2_CHANGE_NOTIFY: + *off = le16_to_cpu( + ((struct smb2_change_notify_rsp *)shdr)->OutputBufferOffset); + *len = le32_to_cpu( + ((struct smb2_change_notify_rsp *)shdr)->OutputBufferLength); + break; default: - /* BB FIXME for unimplemented cases above */ - cifs_dbg(VFS, "no length check for command\n"); + cifs_dbg(VFS, "no length check for command %d\n", le16_to_cpu(shdr->Command)); break; } -- 2.25.1