From patchwork Wed Jul 8 12:01:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651501 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB23560D for ; Wed, 8 Jul 2020 12:04:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A30AB2080D for ; Wed, 8 Jul 2020 12:04:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KpCSdog7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728969AbgGHMC2 (ORCPT ); Wed, 8 Jul 2020 08:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728962AbgGHMC2 (ORCPT ); Wed, 8 Jul 2020 08:02:28 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B354C08E6DC for ; Wed, 8 Jul 2020 05:02:27 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so2706550wmh.4 for ; Wed, 08 Jul 2020 05:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OYcU6QrkQ8vEFK16KZ0JwglvYSsa1RsL+nSDllm7Llo=; b=KpCSdog7huLlJl0j5Tz551x3UOHlNMY59WJnYF7IOjTNQ7wGfCYJwMCkY7q/tQQvFB tPxTBmOK4P2phupcTbCAGmgW4bl05vYVFXnkPACYCRmO5PurZJ5BotQL4IfIkwBK0vRx 9AEOsxpeG4po7sQEpY9l227WkEHE3rKVKVmlrH1c3xkFMfY8xEXRsJY0W9lQ1rINQecT e8EmCwPRoEPigbSphNAFdzgSsGLRbOtOumrBqaXFbPKvjqEKmzp/E8inOLjAld3mGX0p rqYQH6JHXH01TBdNtxnNOBkHOP5k2WyPD6yo7rRy/U875/5DH47Rut8yY7Nx1xj2qTW5 QrQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OYcU6QrkQ8vEFK16KZ0JwglvYSsa1RsL+nSDllm7Llo=; b=LHdp98gzCHb66LfP0XpC6HsCQR60mCg8CKkfWi85y+wWBoUyI1tL9wOR31xssVQnIP NhcXYNUbMo8I7Nz44DGv2xZGf7a41elpnMTZCFnDf9BIooCgATSd/ramNDHAYFMMcw7E Gv0VWeMc7nvbtYFVNtItAIfM1KjCm/N2qMqbK1tYdPDCEjFzpatbms8UbeLqZHqJg43I XQ5IxEBFzfaMxKPruoFjHCeWtBxyfJ0BKLNiizppDADsaKslHqRY6JgzLCacjsukVhw3 F/BOfgUeyToSdALAxPqc1O2MTDhp3wgb9L0nYWFBiLwlD5CgVt9a8JEibC1znpvCtURg a3tg== X-Gm-Message-State: AOAM532tlQQV2ETpmKr68z6h9I5Yusnbzt4xqTmMqnujMHiRU+d7iG1T FReLxw/jaPeXADMp5TjIw8li9Q== X-Google-Smtp-Source: ABdhPJycC9Sqys7Gmp7jg5AAPUD6iK1Pq5Uk5vSy/gv3EyAVuisDIiJYjEPx39WpB5AD7BroV+e4sA== X-Received: by 2002:a1c:2485:: with SMTP id k127mr8789530wmk.138.1594209746128; Wed, 08 Jul 2020 05:02:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:25 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 01/30] scsi: libfc: fc_exch: Supply some missing kerneldoc struct/function attributes/params Date: Wed, 8 Jul 2020 13:01:52 +0100 Message-Id: <20200708120221.3386672-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'left' not described in 'fc_exch_pool' drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'right' not described in 'fc_exch_pool' drivers/scsi/libfc/fc_exch.c:100: warning: Function parameter or member 'lport' not described in 'fc_exch_mgr' drivers/scsi/libfc/fc_exch.c:727: warning: Function parameter or member 'ep' not described in 'fc_invoke_resp' drivers/scsi/libfc/fc_exch.c:727: warning: Function parameter or member 'sp' not described in 'fc_invoke_resp' drivers/scsi/libfc/fc_exch.c:727: warning: Function parameter or member 'fp' not described in 'fc_invoke_resp' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_exch.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index 52e8666598531..16eb3b60ed582 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c @@ -49,6 +49,8 @@ static struct workqueue_struct *fc_exch_workqueue; * @total_exches: Total allocated exchanges * @lock: Exch pool lock * @ex_list: List of exchanges + * @left: Cache of free slot in exch array + * @right: Cache of free slot in exch array * * This structure manages per cpu exchanges in array of exchange pointers. * This array is allocated followed by struct fc_exch_pool memory for @@ -60,7 +62,6 @@ struct fc_exch_pool { u16 next_index; u16 total_exches; - /* two cache of free slot in exch array */ u16 left; u16 right; } ____cacheline_aligned_in_smp; @@ -74,6 +75,7 @@ struct fc_exch_pool { * @ep_pool: Reserved exchange pointers * @pool_max_index: Max exch array index in exch pool * @pool: Per cpu exch pool + * @lport: Local exchange port * @stats: Statistics structure * * This structure is the center for creating exchanges and sequences. @@ -702,6 +704,9 @@ int fc_seq_exch_abort(const struct fc_seq *req_sp, unsigned int timer_msec) /** * fc_invoke_resp() - invoke ep->resp() + * @ep: The exchange to be operated on + * @fp: The frame pointer to pass through to ->resp() + * @sp: The sequence pointer to pass through to ->resp() * * Notes: * It is assumed that after initialization finished (this means the From patchwork Wed Jul 8 12:01:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E415D60D for ; Wed, 8 Jul 2020 12:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAEF92082E for ; Wed, 8 Jul 2020 12:04:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jqFRszdp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729312AbgGHMEo (ORCPT ); Wed, 8 Jul 2020 08:04:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728977AbgGHMC2 (ORCPT ); Wed, 8 Jul 2020 08:02:28 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 941E2C08C5DC for ; Wed, 8 Jul 2020 05:02:28 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g10so3825930wmc.1 for ; Wed, 08 Jul 2020 05:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Oudq2oeculi6K4POMA0xfQMiSgZLhEbNGoOFwG0ADmE=; b=jqFRszdpAMk/WEosA8vCIRplw1s1iZVrYBQi444fVIoA249wMXPC1qA438UH/pbuQP Y10ZiE8f7eoJFYP7Cg3TfSow5vMIIKrfp4BoWdH+JPlXnbdl81a5gGetvj1SYKBgNf4F D35LtipJgz5JBrVEq+XnPNNiOHGzFPmjAwzdsQDMSptzo/0L1uaqMjWCMQSk2NEpk//M dZDsHlJINjfzhUqIRcSIdEAIWl/KwTxs3zuFSFQIS6xfqMoPsiLbmJS8520VaOUnJdPl 7iYbyatQKg/SdPNXYUQKn0Efp4F0tDOkI3pFXy8P79jDnb/eHuubmfN6cdgpM2dB5H3d FF7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oudq2oeculi6K4POMA0xfQMiSgZLhEbNGoOFwG0ADmE=; b=b9SrUewiqYe6zEM6NDyHrmGPAlgWqWg/nsjJJrjHQW2jsdyFIy/LMaEYy1J42VSIUO Xi5gy5KjDxXjdvJbG2Xt0CXnT9+N6knc0QkXs9+8XSgfLh8Ud26up8x9FX4vJsXuROky UIV8BvsiPvSdoaEs2WmZU4v1IGKACb9rc67vbUNGjrSsBnRKg4DIgSSlUrgdZ+r7G4/O lvUC2BPBJKBaa23chfNfscn/sh36tOXVbiBFAqFMrChzdXqYP7kkeQOEcF2JLl7m96Hs zkHdXpPvUfaZvvg9W7ms8Lg0TWpd3+YTb9vVHlyp4yslUXA424R3Yy9STfAiGE+wj7Rn GRTA== X-Gm-Message-State: AOAM532Xdc9LdEJ7GyqHKA0Y4fDZF/NAJvTJGcFp26d9gm9oi0Blgvz8 LlePpwfrv1bZyQRgiLNBVcb3Xg== X-Google-Smtp-Source: ABdhPJzYNIcclovtnQ3AJIvggPGf90KHk3jlI7m3GaG1Us2M/TmmiUx/g/jjRI1O0K985J5D3nwqIQ== X-Received: by 2002:a1c:2842:: with SMTP id o63mr8902604wmo.169.1594209747310; Wed, 08 Jul 2020 05:02:27 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:26 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones Subject: [PATCH 02/30] include: scsi: scsi_transport_fc: Match HBA Attribute Length with HBAAPI V2.0 definitions Date: Wed, 8 Jul 2020 13:01:53 +0100 Message-Id: <20200708120221.3386672-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org According to 'include/scsi/scsi_transport_fc.h': "Attributes are based on HBAAPI V2.0 definitions" ... so it seems sane to match the 'HBA Attribute Length' to them. If we don't, the compiler complains that the copied data will be truncated. Fixes the following W=1 kernel build warning(s): In file included from include/linux/bitmap.h:9, from include/linux/cpumask.h:12, from include/linux/smp.h:13, from include/linux/percpu.h:7, from include/scsi/libfc.h:13, from drivers/scsi/libfc/fc_elsct.c:17: In function ‘strncpy’, inlined from ‘fc_ct_ms_fill.constprop’ at include/scsi/fc_encode.h:263:3: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 79 [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ In function ‘strncpy’, inlined from ‘fc_ct_ms_fill.constprop’ at include/scsi/fc_encode.h:275:3: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 79 [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ Signed-off-by: Lee Jones --- include/scsi/fc/fc_ms.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/scsi/fc/fc_ms.h b/include/scsi/fc/fc_ms.h index 800d53dc94705..9e273fed0a85f 100644 --- a/include/scsi/fc/fc_ms.h +++ b/include/scsi/fc/fc_ms.h @@ -63,8 +63,8 @@ enum fc_fdmi_hba_attr_type { * HBA Attribute Length */ #define FC_FDMI_HBA_ATTR_NODENAME_LEN 8 -#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 64 -#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 64 +#define FC_FDMI_HBA_ATTR_MANUFACTURER_LEN 80 +#define FC_FDMI_HBA_ATTR_SERIALNUMBER_LEN 80 #define FC_FDMI_HBA_ATTR_MODEL_LEN 256 #define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 256 #define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 256 From patchwork Wed Jul 8 12:01:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651445 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93A96913 for ; Wed, 8 Jul 2020 12:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 775E120775 for ; Wed, 8 Jul 2020 12:02:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bV9bLouL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728995AbgGHMCb (ORCPT ); Wed, 8 Jul 2020 08:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728987AbgGHMCa (ORCPT ); Wed, 8 Jul 2020 08:02:30 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0989C08E6DC for ; Wed, 8 Jul 2020 05:02:29 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j4so46263571wrp.10 for ; Wed, 08 Jul 2020 05:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/GI6WmzBD/tXdjRqMOCJ6wEDBpBeiEpQ/v95OUrVAL8=; b=bV9bLouLqxa4IS/T3dEi6X062He0tvGD4Qu/lii+sBTB4lF0PJlrBT8iLObnuSUf/d htNbTUHwkzbxbY17Ti9OZOI298t98K0MS6hNsoWwMwcsCPUo3nWfTqmkMHnMbxdFDwIi 7cLhWhiWk7Jt+bIL+nYY7mPML81GkdliiPEbEJqIfUNk1igpLbKw/cz5TYWHDyLRjtgk S//PUlCBhoQn2NoheTUiYMruF8YG+aV7399r8pLTeHV4kq8MmiDx5BTyNiAuDzBcVPId n1PpGPt9MNZ2uNMMYT+7vRTd6tgVu8bpnr1hH9IbIyuKzf+P6pXBu4mNP+SiwWU1eBPv C1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/GI6WmzBD/tXdjRqMOCJ6wEDBpBeiEpQ/v95OUrVAL8=; b=Hjd4Ryi7TEohjER5QChbC8ayQWQq0Xi+gtp9DPIOqMZ6PpgO5Q/v3DV4GUdLyEXxds 5SAMV9v0j2aOG8cT4+sbDTfTpqH8PpZvKdG49yJkZRlqy4VRp8D/j26X05VilnpqcdXd tYM88YZDFROneGaSgSpmEvpzIIsDVxCbObkxZpTfeM+RkP0QoKMPZNSKWKJzSYa27MXk 0BOEV1gnweUBiiHiskmlOvQNFgF78ikWWkIVUvOwfzNjytnIP3JN8YiunC5Al4kzA7t9 8ifOi81a/jgcwZKBYx41vHS9yO3p84HuMSwIJpq0FHSMzpa+Bn42SUN2rHEVkwR9HaOG R/Rg== X-Gm-Message-State: AOAM533+/vXEbvxULYzzKKJ3fajU+IyZv4ChiFip3ZxKaQKlIqSQJyA6 bjWWTqb6rfEgrsTWwFkvXAdjPQ== X-Google-Smtp-Source: ABdhPJwVGA5JxCPrvpb0mkdsBMsuK375rqhOSlXQczWVSfrzvBV+h/UTJTX6pj2n5TmhwEwR5NyToQ== X-Received: by 2002:a05:6000:ca:: with SMTP id q10mr59989471wrx.135.1594209748519; Wed, 08 Jul 2020 05:02:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:27 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke , Johannes Thumshirn Subject: [PATCH 03/30] scsi: libfc: fc_disc: trivial: Fix spelling mistake of 'discovery' Date: Wed, 8 Jul 2020 13:01:54 +0100 Message-Id: <20200708120221.3386672-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is my fault (can't even blame copy/paste). Cc: Hannes Reinecke Reported-by: Johannes Thumshirn Signed-off-by: Lee Jones Reviewed-by: Johannes Thumshirn --- drivers/scsi/libfc/fc_disc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index 428f40cfd1c36..19721db232839 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -370,7 +370,7 @@ static void fc_disc_gpn_ft_req(struct fc_disc *disc) /** * fc_disc_gpn_ft_parse() - Parse the body of the dNS GPN_FT response. - * @disc: The descovery context + * @disc: The discovery context * @buf: The GPN_FT response buffer * @len: The size of response buffer * From patchwork Wed Jul 8 12:01:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651499 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B886C913 for ; Wed, 8 Jul 2020 12:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FEDE2080D for ; Wed, 8 Jul 2020 12:04:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J5+Dp0He" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729196AbgGHMEn (ORCPT ); Wed, 8 Jul 2020 08:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728637AbgGHMCd (ORCPT ); Wed, 8 Jul 2020 08:02:33 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97DCBC08C5DC for ; Wed, 8 Jul 2020 05:02:31 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z2so26408658wrp.2 for ; Wed, 08 Jul 2020 05:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zj88WzcC8Hp115aJ2vlTY+pxEWRybRaihV1rme1nf/Q=; b=J5+Dp0HeyJVdvuXj8D7pcksR0L060RA13hVnHzmEuUSfmb+fExnpI95v2doAH5bgpM AerHZM65Y5A43lh6M1KxDXUEp7uKPcGChM5mNKuVi3J2s/d1jP9qF2+s6bEzGns8Gpbd Jmgw64cyc8ozeKeyLOd/7/FBN6QkujrHYgO05n3G7zRfFHGttwVLyAcKDQ529LKnV+3x BhFTJvTjrVfGMyRGZIzRGNg3ZHzByWbBxAmtupuVxhxMyhn+R5C6bbj7VYoBDPNzAJ9P TxkzDB4rciwtDU4q+WjZF/2KbEI/vScIQhTbz7KWw5oVcW1vCF4ORMZ6LQZA1UHiwD23 atzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zj88WzcC8Hp115aJ2vlTY+pxEWRybRaihV1rme1nf/Q=; b=X4y+/6TPiPc4LjKujM0JVucolykGJ+pM7b/IS44T1y1Ce7xWC1dfDvcqkO5Fysgb2f +NGNYAX6HwO+VqBo/JGE1ZRk8bohYDhAPib4u6XYQHwW/RwBQMgqTDXTqMYiWWk8Mq/X eX6eKt3LNEYHOLzKI6daLni8FDOGhThVoIcqQ5i2TyDcPdC7Cu3iVCHlEG07ugsSCTjo GBkJ7GA2Bm3xV9FHbT1QSmGozZ9vfZP6p8bo2VNXtAEslpKa6vNO7Jg8J66jARIMo8Xf /mehlACNcCcxRnsNKYNeCyqsW7IFrO6TTfZbvEpiAj3lTPPrhnQsAbMG6H+2w9akKkuA rnZA== X-Gm-Message-State: AOAM531u9Sr+b5QlL8czBf4Wlp01itlz9tW9mIo3fNbaHM+q7dVkzPKx l+KCmpSq6OJLy/q2tCGANCaQCA== X-Google-Smtp-Source: ABdhPJzFvogyw5VWz9I19SIiKvctbL6YjQ+TmzjgqYE/dMgQrN6HrKQRPWUWFjUPI3aluSHxpvZBkA== X-Received: by 2002:adf:82e1:: with SMTP id 88mr37661923wrc.376.1594209750242; Wed, 08 Jul 2020 05:02:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:29 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 04/30] scsi: fcoe: fcoe: Fix various kernel-doc infringements Date: Wed, 8 Jul 2020 13:01:55 +0100 Message-Id: <20200708120221.3386672-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org A couple of headers make no attempt to document their associated function parameters. Others looks as if they are suffering with a little bitrot. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe.c:654: warning: Function parameter or member 'lport' not described in 'fcoe_netdev_features_change' drivers/scsi/fcoe/fcoe.c:654: warning: Function parameter or member 'netdev' not described in 'fcoe_netdev_features_change' drivers/scsi/fcoe/fcoe.c:2039: warning: Function parameter or member 'ctlr_dev' not described in 'fcoe_ctlr_mode' drivers/scsi/fcoe/fcoe.c:2039: warning: Excess function parameter 'cdev' description in 'fcoe_ctlr_mode' drivers/scsi/fcoe/fcoe.c:2144: warning: Function parameter or member 'fcoe' not described in 'fcoe_dcb_create' drivers/scsi/fcoe/fcoe.c:2144: warning: Excess function parameter 'netdev' description in 'fcoe_dcb_create' drivers/scsi/fcoe/fcoe.c:2144: warning: Excess function parameter 'port' description in 'fcoe_dcb_create' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'lport' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'did' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'fp' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'op' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'resp' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'arg' not described in 'fcoe_elsct_send' drivers/scsi/fcoe/fcoe.c:2627: warning: Function parameter or member 'timeout' not described in 'fcoe_elsct_send' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/fcoe/fcoe.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index cb41d166e0c0f..0f9274960dc6b 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -645,7 +645,7 @@ static int fcoe_lport_config(struct fc_lport *lport) return 0; } -/** +/* * fcoe_netdev_features_change - Updates the lport's offload flags based * on the LLD netdev's FCoE feature flags */ @@ -2029,7 +2029,7 @@ static int fcoe_ctlr_enabled(struct fcoe_ctlr_device *cdev) /** * fcoe_ctlr_mode() - Switch FIP mode - * @cdev: The FCoE Controller that is being modified + * @ctlr_dev: The FCoE Controller that is being modified * * When the FIP mode has been changed we need to update * the multicast addresses to ensure we get the correct @@ -2136,9 +2136,7 @@ static bool fcoe_match(struct net_device *netdev) /** * fcoe_dcb_create() - Initialize DCB attributes and hooks - * @netdev: The net_device object of the L2 link that should be queried - * @port: The fcoe_port to bind FCoE APP priority with - * @ + * @fcoe: The new FCoE interface */ static void fcoe_dcb_create(struct fcoe_interface *fcoe) { @@ -2609,7 +2607,7 @@ static void fcoe_logo_resp(struct fc_seq *seq, struct fc_frame *fp, void *arg) fc_lport_logo_resp(seq, fp, lport); } -/** +/* * fcoe_elsct_send - FCoE specific ELS handler * * This does special case handling of FIP encapsualted ELS exchanges for FCoE, From patchwork Wed Jul 8 12:01:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651447 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD3D160D for ; Wed, 8 Jul 2020 12:02:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87BE920772 for ; Wed, 8 Jul 2020 12:02:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JixprpI/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729016AbgGHMCf (ORCPT ); Wed, 8 Jul 2020 08:02:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729003AbgGHMCe (ORCPT ); Wed, 8 Jul 2020 08:02:34 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204B3C08E6DC for ; Wed, 8 Jul 2020 05:02:34 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so2707113wmh.4 for ; Wed, 08 Jul 2020 05:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NOdYD3KnvBuwlGzK8Lnx8We5QJ0C1TZDV+3j7uFLFto=; b=JixprpI/iyFPxF6ee+dH2JdsbcuHPTPnnoX1F3rcXIQ4k3OYRsZSRYQmJGb6ALqgfc YEw8xDtYre4v+Jtsor6pVeB4rp3+PJ412r9kRfQX9g053Niz7miQEjjRff+30qkVSD8m 5gs+DfbtIn/adakkKNCa/qX8uqksIl0NdHkScYEGmfq03Sl56/oR2bRVhMyWOBEbjJW1 T+zRkYZYPQx0ToqmK/+cQbnzkn7v/ZuBdpS49qgSU/baax0kqsnVlyVw6WgG8GB66QU6 tmCvRM3Vkexf6Pq5QiowYcoPdp7OV2B6TmQcqHXVdOoQ/Kxh7QCr56MLQgXxV/TJuva0 yF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NOdYD3KnvBuwlGzK8Lnx8We5QJ0C1TZDV+3j7uFLFto=; b=PKC7gEZDlKrknOaDBsOJL2Z76L/Ob42MSNh+L9jASDA1BiyR4+9De0Hw98mvDahFUU 7AwNkmIdPtRwK6+Z0YW0Ux523pUBIORYgvM2e1iSmeWb7N6n4H/yOr1jgAW5RaKXhuV2 FGfe3NnXcFedBdPgw73q49qzmJYblUKGH+2hxZBzHI13BlDXykOB1vN1jNvgHD+nb7ly +TTifa0dAk3wUp8drrRD8bcnByeAVfrj1x2qlnmeQyw0ltYZCms4QN2n4eZqBuKwQDOe Gb73tOrTdUQ2q4KpKLij7pzyNkXNkrYRq5lsi29skgvmhY8QHPP31zI64crvOoKCb5CT TuYg== X-Gm-Message-State: AOAM530g4Nm1liJQ1lQnkeLW5dI/lq53E/GpriooNz6ykA/upide8T/r oG4t5h11IXlBWeOwu5+BsB/2OQ== X-Google-Smtp-Source: ABdhPJxQSvaPZcN4iL+6b6o0K9wsu6WyyFSvKUXVm1rXKpLkVJi4QJtnoYJZbRK7RXLPmGLNPHTXjA== X-Received: by 2002:a1c:7c16:: with SMTP id x22mr8681183wmc.76.1594209752400; Wed, 08 Jul 2020 05:02:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:31 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 05/30] scsi: fcoe: fcoe_ctlr: Fix a myriad of documentation issues Date: Wed, 8 Jul 2020 13:01:56 +0100 Message-Id: <20200708120221.3386672-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Mostly missing or incorrect (bitrotted) function parameters. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member 'mode' not described in 'fcoe_ctlr_init' drivers/scsi/fcoe/fcoe_ctlr.c:604: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_encaps' drivers/scsi/fcoe/fcoe_ctlr.c:1312: warning: Function parameter or member 'skb' not described in 'fcoe_ctlr_recv_clr_vlink' drivers/scsi/fcoe/fcoe_ctlr.c:1312: warning: Excess function parameter 'fh' description in 'fcoe_ctlr_recv_clr_vlink' drivers/scsi/fcoe/fcoe_ctlr.c:1781: warning: Function parameter or member 't' not described in 'fcoe_ctlr_timeout' drivers/scsi/fcoe/fcoe_ctlr.c:1781: warning: Excess function parameter 'arg' description in 'fcoe_ctlr_timeout' drivers/scsi/fcoe/fcoe_ctlr.c:1904: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_recv_flogi' drivers/scsi/fcoe/fcoe_ctlr.c:2166: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_disc_stop_locked' drivers/scsi/fcoe/fcoe_ctlr.c:2166: warning: Excess function parameter 'fip' description in 'fcoe_ctlr_disc_stop_locked' drivers/scsi/fcoe/fcoe_ctlr.c:2188: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_disc_stop' drivers/scsi/fcoe/fcoe_ctlr.c:2188: warning: Excess function parameter 'fip' description in 'fcoe_ctlr_disc_stop' drivers/scsi/fcoe/fcoe_ctlr.c:2204: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_disc_stop_final' drivers/scsi/fcoe/fcoe_ctlr.c:2204: warning: Excess function parameter 'fip' description in 'fcoe_ctlr_disc_stop_final' drivers/scsi/fcoe/fcoe_ctlr.c:2273: warning: Function parameter or member 'frport' not described in 'fcoe_ctlr_vn_parse' drivers/scsi/fcoe/fcoe_ctlr.c:2273: warning: Excess function parameter 'rdata' description in 'fcoe_ctlr_vn_parse' drivers/scsi/fcoe/fcoe_ctlr.c:2804: warning: Function parameter or member 'frport' not described in 'fcoe_ctlr_vlan_parse' drivers/scsi/fcoe/fcoe_ctlr.c:2804: warning: Excess function parameter 'rdata' description in 'fcoe_ctlr_vlan_parse' drivers/scsi/fcoe/fcoe_ctlr.c:2900: warning: Excess function parameter 'min_len' description in 'fcoe_ctlr_vlan_send' drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Function parameter or member 'fip' not described in 'fcoe_ctlr_vlan_recv' drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Function parameter or member 'skb' not described in 'fcoe_ctlr_vlan_recv' drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter 'lport' description in 'fcoe_ctlr_vlan_recv' drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter 'fp' description in 'fcoe_ctlr_vlan_recv' drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Function parameter or member 'callback' not described in 'fcoe_ctlr_disc_start' drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Function parameter or member 'lport' not described in 'fcoe_ctlr_disc_start' drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Excess function parameter 'fip' description in 'fcoe_ctlr_disc_start' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/fcoe/fcoe_ctlr.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index 1791a393795da..99242f9856708 100644 --- a/drivers/scsi/fcoe/fcoe_ctlr.c +++ b/drivers/scsi/fcoe/fcoe_ctlr.c @@ -134,6 +134,7 @@ static void fcoe_ctlr_map_dest(struct fcoe_ctlr *fip) /** * fcoe_ctlr_init() - Initialize the FCoE Controller instance * @fip: The FCoE controller to initialize + * @mode: FIP mode to set */ void fcoe_ctlr_init(struct fcoe_ctlr *fip, enum fip_mode mode) { @@ -587,6 +588,7 @@ static void fcoe_ctlr_send_keep_alive(struct fcoe_ctlr *fip, /** * fcoe_ctlr_encaps() - Encapsulate an ELS frame for FIP, without sending it * @fip: The FCoE controller for the ELS frame + * @lport: The local port * @dtype: The FIP descriptor type for the frame * @skb: The FCoE ELS frame including FC header but no FCoE headers * @d_id: The destination port ID. @@ -1302,7 +1304,7 @@ static void fcoe_ctlr_recv_els(struct fcoe_ctlr *fip, struct sk_buff *skb) /** * fcoe_ctlr_recv_els() - Handle an incoming link reset frame * @fip: The FCoE controller that received the frame - * @fh: The received FIP header + * @skb: The received FIP packet * * There may be multiple VN_Port descriptors. * The overall length has already been checked. @@ -1775,7 +1777,7 @@ static void fcoe_ctlr_flogi_send(struct fcoe_ctlr *fip) /** * fcoe_ctlr_timeout() - FIP timeout handler - * @arg: The FCoE controller that timed out + * @t: Timer context use to obtain the controller reference */ static void fcoe_ctlr_timeout(struct timer_list *t) { @@ -1887,6 +1889,7 @@ static void fcoe_ctlr_recv_work(struct work_struct *recv_work) /** * fcoe_ctlr_recv_flogi() - Snoop pre-FIP receipt of FLOGI response * @fip: The FCoE controller + * @lport: The local port * @fp: The FC frame to snoop * * Snoop potential response to FLOGI or even incoming FLOGI. @@ -2158,7 +2161,7 @@ static struct fc_rport_operations fcoe_ctlr_vn_rport_ops = { /** * fcoe_ctlr_disc_stop_locked() - stop discovery in VN2VN mode - * @fip: The FCoE controller + * @lport: The local port * * Called with ctlr_mutex held. */ @@ -2179,7 +2182,7 @@ static void fcoe_ctlr_disc_stop_locked(struct fc_lport *lport) /** * fcoe_ctlr_disc_stop() - stop discovery in VN2VN mode - * @fip: The FCoE controller + * @lport: The local port * * Called through the local port template for discovery. * Called without the ctlr_mutex held. @@ -2195,7 +2198,7 @@ static void fcoe_ctlr_disc_stop(struct fc_lport *lport) /** * fcoe_ctlr_disc_stop_final() - stop discovery for shutdown in VN2VN mode - * @fip: The FCoE controller + * @lport: The local port * * Called through the local port template for discovery. * Called without the ctlr_mutex held. @@ -2262,7 +2265,7 @@ static void fcoe_ctlr_vn_start(struct fcoe_ctlr *fip) * fcoe_ctlr_vn_parse - parse probe request or response * @fip: The FCoE controller * @skb: incoming packet - * @rdata: buffer for resulting parsed VN entry plus fcoe_rport + * @frport: parsed FCoE rport from the probe request * * Returns non-zero error number on error. * Does not consume the packet. @@ -2793,7 +2796,7 @@ static int fcoe_ctlr_vn_recv(struct fcoe_ctlr *fip, struct sk_buff *skb) * fcoe_ctlr_vlan_parse - parse vlan discovery request or response * @fip: The FCoE controller * @skb: incoming packet - * @rdata: buffer for resulting parsed VLAN entry plus fcoe_rport + * @frport: parsed FCoE rport from the probe request * * Returns non-zero error number on error. * Does not consume the packet. @@ -2892,7 +2895,6 @@ static int fcoe_ctlr_vlan_parse(struct fcoe_ctlr *fip, * @fip: The FCoE controller * @sub: sub-opcode for vlan notification or vn2vn vlan notification * @dest: The destination Ethernet MAC address - * @min_len: minimum size of the Ethernet payload to be sent */ static void fcoe_ctlr_vlan_send(struct fcoe_ctlr *fip, enum fip_vlan_subcode sub, @@ -2969,9 +2971,8 @@ static void fcoe_ctlr_vlan_disc_reply(struct fcoe_ctlr *fip, /** * fcoe_ctlr_vlan_recv - vlan request receive handler for VN2VN mode. - * @lport: The local port - * @fp: The received frame - * + * @fip: The FCoE controller + * @skb: The received FIP packet */ static int fcoe_ctlr_vlan_recv(struct fcoe_ctlr *fip, struct sk_buff *skb) { @@ -3015,9 +3016,8 @@ static void fcoe_ctlr_disc_recv(struct fc_lport *lport, struct fc_frame *fp) fc_frame_free(fp); } -/** +/* * fcoe_ctlr_disc_recv - start discovery for VN2VN mode. - * @fip: The FCoE controller * * This sets a flag indicating that remote ports should be created * and started for the peers we discover. We use the disc_callback From patchwork Wed Jul 8 12:01:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651497 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5EAF913 for ; Wed, 8 Jul 2020 12:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB7BB207DF for ; Wed, 8 Jul 2020 12:04:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZX89HUHj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgGHMEg (ORCPT ); Wed, 8 Jul 2020 08:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729015AbgGHMCf (ORCPT ); Wed, 8 Jul 2020 08:02:35 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5549CC08E6DC for ; Wed, 8 Jul 2020 05:02:35 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o2so2739867wmh.2 for ; Wed, 08 Jul 2020 05:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DmqYn8cL7eqDFwNGfmdwoQHTEQPwopRMh0yPN6WNGOc=; b=ZX89HUHjMyHzb2heKm0iH8q120RxpXZ4NY/Lixv0Rryknk//WXNKNL878jlcUlwD49 lChMvRvyp2d4ylLHijtfBzHUSke+nLv3JvqjaILPjmI2/osr42fXXhHvW1otnkJ//5RA PsmBBT+QTvIFVvrk6MZ/OMKKCDmePDjOMzzRIEM2w2nSM5MDwDhq587PwePzFNlLq90y pr72HLxGR9a4GcvhyFNTSlEoiEbzmLNGJiR8kUBognvguyqVNiUwe1IGf5sIePxRdAmb zLsoOx2hSbEay1tc3FINUEu1HVft+fIYuN3V3iskbFPP4x79ZLD63clZdzhZP0IR3wMt MPLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DmqYn8cL7eqDFwNGfmdwoQHTEQPwopRMh0yPN6WNGOc=; b=NUSpuJep/c9nGoZiSJb8IKuwmVc7BshbUi+ES/KmCx46zcyR+9wulXRMTXcpav/AkM Jp3WZOWu7yeM5AxQHztGgZeN/rop0C5W+Dyy3K+niWnG1hIP3vm3uP6Sv1ffySAGkPsU JYI5/eWwEI5iDP6EtdoQ3cm5iaQr/oArq25xPOvKS2smpYVhwdygKdSu6KLJ2vX1/glN ZQ6nk5pEUEo2J2hV7foNGDyaHENmddZW+p3w6igwGbvRbgvWajhU4tUYtMdi35c3Xqmw YwLtl6wAgZnj/dqz58sxZFOgMjHIIt2RqOd6qhiHQWXuaUGZN5ZkHqmuYJaMqPXko52d /sCQ== X-Gm-Message-State: AOAM531NIiILzETVlro5uSYiIrh4LdF3zaMpory1s5U+4guS2D6dSOhP W862RdiQnZh4yzmcXgd434ESAQ== X-Google-Smtp-Source: ABdhPJyyzSZPiPJuG3p9zylereXCy8YSx2u92+RYTlb+uZ2h3JczIOOmqkwgrRMO7xGWj6DDJaWMXg== X-Received: by 2002:a1c:6788:: with SMTP id b130mr9412333wmc.100.1594209753955; Wed, 08 Jul 2020 05:02:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:33 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 06/30] scsi: fcoe: fcoe_transport: Correct some kernel-doc issues Date: Wed, 8 Jul 2020 13:01:57 +0100 Message-Id: <20200708120221.3386672-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Mainly due to misdocumentation or bitrotted descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/fcoe/fcoe_transport.c:396: warning: Function parameter or member 'skb' not described in 'fcoe_check_wait_queue' drivers/scsi/fcoe/fcoe_transport.c:447: warning: Function parameter or member 't' not described in 'fcoe_queue_timer' drivers/scsi/fcoe/fcoe_transport.c:447: warning: Excess function parameter 'lport' description in 'fcoe_queue_timer' drivers/scsi/fcoe/fcoe_transport.c:682: warning: Function parameter or member 'netdev' not described in 'fcoe_netdev_map_lookup' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/fcoe/fcoe_transport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index a20ddc301c89e..6e187d0e71fd2 100644 --- a/drivers/scsi/fcoe/fcoe_transport.c +++ b/drivers/scsi/fcoe/fcoe_transport.c @@ -382,6 +382,7 @@ EXPORT_SYMBOL_GPL(fcoe_clean_pending_queue); /** * fcoe_check_wait_queue() - Attempt to clear the transmit backlog * @lport: The local port whose backlog is to be cleared + * @skb: The received FIP packet * * This empties the wait_queue, dequeues the head of the wait_queue queue * and calls fcoe_start_io() for each packet. If all skb have been @@ -439,7 +440,7 @@ EXPORT_SYMBOL_GPL(fcoe_check_wait_queue); /** * fcoe_queue_timer() - The fcoe queue timer - * @lport: The local port + * @t: Timer context use to obtain the FCoE port * * Calls fcoe_check_wait_queue on timeout */ @@ -672,6 +673,7 @@ static void fcoe_del_netdev_mapping(struct net_device *netdev) /** * fcoe_netdev_map_lookup - find the fcoe transport that matches the netdev on which * it was created + * @netdev: The net device that the FCoE interface is on * * Returns : ptr to the fcoe transport that supports this netdev or NULL * if not found. From patchwork Wed Jul 8 12:01:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651495 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D357960D for ; Wed, 8 Jul 2020 12:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B000020739 for ; Wed, 8 Jul 2020 12:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l3TBC6Ja" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgGHMEa (ORCPT ); Wed, 8 Jul 2020 08:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729022AbgGHMCh (ORCPT ); Wed, 8 Jul 2020 08:02:37 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78776C08C5DC for ; Wed, 8 Jul 2020 05:02:36 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id b6so48659899wrs.11 for ; Wed, 08 Jul 2020 05:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=46IKHC7Ib+3RpYilksHo0J0tVnpqASiueOx9DpvscBA=; b=l3TBC6JaAs3Oj5T2ANAgmLhjgaFoSm80oROvJAm6eo+aJXW4c5H1FV+nwjp8n5QqOd dqM919EV90o7+ViXKxLMIJ8sIANeJnkGz3rSX2oVxho73Bdi3kpXbtgyuJn6TZHYl6OU ELwLqKf9lDeo3NMCDMwB8y6oUKob9loOnZGFcO8NNNvw/GA4SCDot7K84wmf7Rs3ZSj1 OnQa+edYrzHvpoXDfrchTC6A5neZP4SFlhSdYPMLN/inQ5RsiVFDxS467VFD5gc9Zyec w5FHNoMNTJtToJA73nkBxmRy2EQcegrcyCGt2ZnSzB6Hj4F/K1hIimrXAz5EKsoPseaI zxLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=46IKHC7Ib+3RpYilksHo0J0tVnpqASiueOx9DpvscBA=; b=Mxs2X2xxweuoaridWCt/lKqkbiSPTzSxOB2vhjsVNFYleux+6cileIt9Nkipi5BRf7 apWREz2uTr5yKgU+aYGGAUMzeq8fl19rFSqkLYpWwWa6z4ca0mhLyXUh7HjC0ceHbUYw XAk34q1rvAnKnAT4iQEJuzNb+ByTyCaXeATqKhDSe84TD9hhPkf5dQ9aM6kicgJMxDMz jY+cT68hB0XnOp2D0s/PLmIFIZ9VmYqkZscjpbv3SReaSRlrteZWTjw2Eb++HqDZEMXI AETuVu5W/CESCTixNyQ3wnwwvsPRQclyL9xDe1+uVJCvmYSt2UyXTKNIkzM5Qai13qEF 7zkw== X-Gm-Message-State: AOAM532sU7BLcqWdje+UsRUngghxV27mOoRuLQF0xu2r1jJLT1PzAQw1 WonMlGLUeT5hWhWcoBnQ10kOX3/1qn4= X-Google-Smtp-Source: ABdhPJx7400FkBTJjZF37J5652hYPclvA4b+wU9dUR9dX0IU/91BKTSabo6ymiYYSVoXlFRmC05wxw== X-Received: by 2002:adf:e948:: with SMTP id m8mr59727341wrn.398.1594209755159; Wed, 08 Jul 2020 05:02:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:34 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Prakash Gollapudi Subject: [PATCH 07/30] scsi: bnx2fc: bnx2fc_fcoe: Repair a range of kerneldoc issues Date: Wed, 8 Jul 2020 13:01:58 +0100 Message-Id: <20200708120221.3386672-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From bitrotted and missing function parameters to misuse of kerneldoc format. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Function parameter or member 'lport' not described in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Function parameter or member 'addr' not described in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Excess function parameter 'fip' description in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Excess function parameter 'old' description in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Excess function parameter 'new' description in 'bnx2fc_update_src_mac' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1670: warning: Function parameter or member 'netdev' not described in 'bnx2fc_destroy' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1670: warning: Excess function parameter 'buffer' description in 'bnx2fc_destroy' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1670: warning: Excess function parameter 'kp' description in 'bnx2fc_destroy' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2108: warning: Function parameter or member 'netdev' not described in 'bnx2fc_disable' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2236: warning: Function parameter or member 'netdev' not described in 'bnx2fc_enable' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2529: warning: Function parameter or member 'dev' not described in 'bnx2fc_ulp_exit' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2962: warning: cannot understand function prototype: 'struct scsi_host_template bnx2fc_shost_template = ' drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2996: warning: cannot understand function prototype: 'struct cnic_ulp_ops bnx2fc_cnic_cb = ' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Prakash Gollapudi Signed-off-by: Lee Jones --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 0e33324e16f51..5cdeeb3539fdc 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -1071,9 +1071,8 @@ static int bnx2fc_fip_recv(struct sk_buff *skb, struct net_device *dev, /** * bnx2fc_update_src_mac - Update Ethernet MAC filters. * - * @fip: FCoE controller. - * @old: Unicast MAC address to delete if the MAC is non-zero. - * @new: Unicast MAC address to add. + * @lport: The local port + * @addr: Location of data to copy * * Remove any previously-set unicast MAC filter. * Add secondary FCoE MAC address filter for our OUI. @@ -1659,8 +1658,7 @@ static void __bnx2fc_destroy(struct bnx2fc_interface *interface) /** * bnx2fc_destroy - Destroy a bnx2fc FCoE interface * - * @buffer: The name of the Ethernet interface to be destroyed - * @kp: The associated kernel parameter + * @netdev: The net device that the FCoE interface is on * * Called from sysfs. * @@ -2101,7 +2099,7 @@ static int __bnx2fc_disable(struct fcoe_ctlr *ctlr) return 0; } -/** +/* * Deperecated: Use bnx2fc_enabled() */ static int bnx2fc_disable(struct net_device *netdev) @@ -2229,7 +2227,7 @@ static int __bnx2fc_enable(struct fcoe_ctlr *ctlr) return 0; } -/** +/* * Deprecated: Use bnx2fc_enabled() */ static int bnx2fc_enable(struct net_device *netdev) @@ -2523,7 +2521,7 @@ static struct bnx2fc_hba *bnx2fc_hba_lookup(struct net_device /** * bnx2fc_ulp_exit - shuts down adapter instance and frees all resources * - * @dev cnic device handle + * @dev: cnic device handle */ static void bnx2fc_ulp_exit(struct cnic_dev *dev) { @@ -2956,7 +2954,7 @@ static struct device_attribute *bnx2fc_host_attrs[] = { NULL, }; -/** +/* * scsi_host_template structure used while registering with SCSI-ml */ static struct scsi_host_template bnx2fc_shost_template = { @@ -2989,7 +2987,7 @@ static struct libfc_function_template bnx2fc_libfc_fcn_templ = { .rport_event_callback = bnx2fc_rport_event_handler, }; -/** +/* * bnx2fc_cnic_cb - global template of bnx2fc - cnic driver interface * structure carrying callback function pointers */ From patchwork Wed Jul 8 12:01:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 63AC4913 for ; Wed, 8 Jul 2020 12:04:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A37F2065C for ; Wed, 8 Jul 2020 12:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XHAfQtf1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729188AbgGHME2 (ORCPT ); Wed, 8 Jul 2020 08:04:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729030AbgGHMCi (ORCPT ); Wed, 8 Jul 2020 08:02:38 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019E9C08E6DC for ; Wed, 8 Jul 2020 05:02:38 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id q15so2725702wmj.2 for ; Wed, 08 Jul 2020 05:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CbDIhrckRx3GTebLwLuoUtbus6UaS40hQs+7mAaRUqY=; b=XHAfQtf1JAQ5VA4lD8a5M0K9xIEd3wjQPYeGkZpVYIRFvwsEfXYnoQAXMbZeDaNi/O UBvXSfjuqJ9gC8B812sv6P0z4WSeIudvXNXDXCkvejh6R152xb26L8EP9bpqk96d3aS5 cZvqL0wKjmJA8/HKXKXROPFgujX96fI5EFnhYgDtgPfdPd+2CUCGhZPbkpbxbCxfhajA 3w77tgKuLqsqzrz1zQQwWO4PKL50RqAf82qafFw1mDlPd4PYX/A9sygzDpIOpFTSsiSs Kj+5LNN0qfQODixhXraXYrqsM9HMVEm8TZPNr9Q3QtxcO3cq5TBB6x5u2fqy38JhPgUd CEiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CbDIhrckRx3GTebLwLuoUtbus6UaS40hQs+7mAaRUqY=; b=moLE3iTyoNoMsDPtjulzTHtIBn6Aa6YP1XpDARG6ia/fRvgrmBsIH5FI8GAO/VHM/5 nCEjWkoFTe0vpFv47O0E7TJwYjMSCYWDwPjqHmGoMoWTea2GoYXe8H65Piqo8Ur8da/c 4BwWX3iP512CxDhI9qbm1AS6HmaoGCFcqfNIrwhiwdUCJJFLNKaEO3s3if96y/tiMJND TIjq6VU7FSNQHNra4/z8tdpTIejFm6HNzi1HgzvoGYJWbDiMHQg/KRcGjFeOEzPeV8bV PXAR53Wl6PLzl9TFdmbsSRx2pJEwXAON3B06OUxj2Ai/JZ9ImqFAwPdSJnd9J3gSVx9d GXUQ== X-Gm-Message-State: AOAM530aUj2mIpCZWt7utyRKXk4EOWE78Qg9W8CDN7EY/MxYapR3f3oh 6OFe99czv+G7k26LitoMcipGpg== X-Google-Smtp-Source: ABdhPJy+HB17Q9P1mrRKVGT2FF3j0WmBBb+fLX/6I25X987iIeI1ppamW0cma4BCMtp1nwaoLxHKaA== X-Received: by 2002:a1c:1fc2:: with SMTP id f185mr8954863wmf.0.1594209756344; Wed, 08 Jul 2020 05:02:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:35 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 08/30] scsi: qedf: qedf_main: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 8 Jul 2020 13:01:59 +0100 Message-Id: <20200708120221.3386672-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_main.c:1027: warning: Function parameter or member 'lport' not described in 'qedf_xmit' drivers/scsi/qedf/qedf_main.c:1027: warning: Function parameter or member 'fp' not described in 'qedf_xmit' drivers/scsi/qedf/qedf_main.c:1426: warning: Function parameter or member 'lport' not described in 'qedf_rport_event_handler' drivers/scsi/qedf/qedf_main.c:1426: warning: Function parameter or member 'rdata' not described in 'qedf_rport_event_handler' drivers/scsi/qedf/qedf_main.c:1426: warning: Function parameter or member 'event' not described in 'qedf_rport_event_handler' Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedf/qedf_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 36b1ca2dadbb5..a77a74fad6a7e 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -1019,9 +1019,8 @@ static int qedf_xmit_l2_frame(struct qedf_rport *fcport, struct fc_frame *fp) return rc; } -/** +/* * qedf_xmit - qedf FCoE frame transmit function - * */ static int qedf_xmit(struct fc_lport *lport, struct fc_frame *fp) { @@ -1415,7 +1414,7 @@ static void qedf_cleanup_fcport(struct qedf_ctx *qedf, kref_put(&rdata->kref, fc_rport_destroy); } -/** +/* * This event_callback is called after successful completion of libfc * initiated target login. qedf can proceed with initiating the session * establishment. From patchwork Wed Jul 8 12:02:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E35A060D for ; Wed, 8 Jul 2020 12:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAF3920739 for ; Wed, 8 Jul 2020 12:04:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WTS0XP84" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbgGHME0 (ORCPT ); Wed, 8 Jul 2020 08:04:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729043AbgGHMCj (ORCPT ); Wed, 8 Jul 2020 08:02:39 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 786B6C08E763 for ; Wed, 8 Jul 2020 05:02:39 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 17so2743113wmo.1 for ; Wed, 08 Jul 2020 05:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8R5JqiLjYcza4fbV6goyYqcdxR7v8Q2JkVSQFyfGqhI=; b=WTS0XP84AmmKQrGU8ziMJ3EGhNUnOurEbGXIkTmbQAGMR/dlruCblCEvvVvGWA3O0k MimUKfmmpbWohYE7vF5UIRsPJBDLsf4+VRtZNZOBzkN0vafEWFgpVT0bzbGM2ARDQP9j k2gYk3QaC3Vwm4/QfiIwQMXscCbndCduFjGyN2Xfv/a8nLlvohHaafqRerLHrCPZqKwY TaLJVAjOlqGYB6OE9H9T9FebrRMhImG9jr4fRCwSF510Yl7lr8+2AElxYOOBELn5CuTQ PCnhte0ZuTJh4en1CTY0nf6YBtHNI4mvLnzvWtbQiF6czj5H3Ov8gsqKLxnwI3J+iYKy LMDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8R5JqiLjYcza4fbV6goyYqcdxR7v8Q2JkVSQFyfGqhI=; b=BCEqacpLNav0G34euivF9O/JYrCN5+s13oE9KDGucdaicvNeIz1DB6dmtUFnZHBLSW i3AsJsMObefQ2cy5PcZSepOulY4NlOLPQ0b7qymXh4iT1pV31+MjQDwcrgaPr1yK/nDJ kyxvwmgHLU2jjG/0olQHIrxUzhFwBO06vwYbUII/CzjggXoot8LvIQmmmFfzaG9AgGRJ fJm7ChxkdDlMcKNNEEt6GKCzNuzE4X4mUd7m41E0hi4YurLP+WxSVcbOcZomojd2dCIz ce26yKkm+tdCZ1t5CF9TvI5HARoPBs4H3sDmnvqSLARLjUc21SwNfW4nBbWJcnklXvpv vTHw== X-Gm-Message-State: AOAM530+RUsi85QXlE6PL1fxu1S2k//DKlY/dgy7R4ld8haOtC6Gg832 7laV8Qq0qdA3UF+RnqnOHIli6UtVnAY= X-Google-Smtp-Source: ABdhPJzNHZRM3aKgz5exfCRDRHqYWEiH/AAdFnW93fxIFV5+7uoZn9heFMe5b+YngdabAe4i2GsUbQ== X-Received: by 2002:a1c:28a:: with SMTP id 132mr8926950wmc.109.1594209758143; Wed, 08 Jul 2020 05:02:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:37 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 09/30] scsi: qedf: qedf_main: Remove set but not checked variable 'tmp' Date: Wed, 8 Jul 2020 13:02:00 +0100 Message-Id: <20200708120221.3386672-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks like the return value of readw() has never been checked. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_main.c: In function ‘__qedf_probe’: drivers/scsi/qedf/qedf_main.c:3203:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedf/qedf_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index a77a74fad6a7e..47fc14f5ed9d7 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3199,7 +3199,6 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) void *task_start, *task_end; struct qed_slowpath_params slowpath_params; struct qed_probe_params qed_params; - u16 tmp; /* * When doing error recovery we didn't reap the lport so don't try @@ -3393,9 +3392,9 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) "Writing %d to primary and secondary BDQ doorbell registers.\n", qedf->bdq_prod_idx); writew(qedf->bdq_prod_idx, qedf->bdq_primary_prod); - tmp = readw(qedf->bdq_primary_prod); + readw(qedf->bdq_primary_prod); writew(qedf->bdq_prod_idx, qedf->bdq_secondary_prod); - tmp = readw(qedf->bdq_secondary_prod); + readw(qedf->bdq_secondary_prod); qed_ops->common->set_power_state(qedf->cdev, PCI_D0); From patchwork Wed Jul 8 12:02:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651487 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0891913 for ; Wed, 8 Jul 2020 12:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9428720772 for ; Wed, 8 Jul 2020 12:04:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z3S73qsa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729086AbgGHMCp (ORCPT ); Wed, 8 Jul 2020 08:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729064AbgGHMCm (ORCPT ); Wed, 8 Jul 2020 08:02:42 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1AE3C08E6DC for ; Wed, 8 Jul 2020 05:02:40 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id w3so2727773wmi.4 for ; Wed, 08 Jul 2020 05:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Uxo2DH0sWgHFikhlDzsPIQecz45jNH2LIUT7ZFPJRdc=; b=Z3S73qsah5B8+M25GHxcQW+vj3SVCTqzm1ZlGRZ0+H8kgseFbUABdfEfgOjC57ppOK Q97RVVqZ637x9jvt5B2zLnHqSjfhVMYGCu1bls1xTQ3YttGwRZGOZfAa7PBYMTI2ClVg SmMBa+L1gVMEbt8QpDFbITW3gGVAhE4favEtUYlxg5OuzdFwhtOwoYqhXRkLSdDi/DDe fao1vr/hLdJ69C2pQdevkwSQz4cST/FiGxoBI9rzcw72I4tfvpnVIa4HcJ5oWMTDRLEi geLBR44wwsUeYQbwIi+/mky8bLBcjUfK1HtyoqvSLiBmpEeGxzTLGSg7/8+OApchBLhj PaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uxo2DH0sWgHFikhlDzsPIQecz45jNH2LIUT7ZFPJRdc=; b=B/FIWxrNH5xN4c34ntazqIxF1wy95OQFT5PXBU7rv+VSZqeipJLkisiII1jCZ723j6 tz+QfSbBkmfZqTRh9bnlPTBkPt2hbYp1wtUmr4wBS05LFaQhdMWzieh0ehZTxLx2kt/V tvNsZSz0ab22E7OsqYTqFGqYNh5VN1VI4+9Nt9mz2QwwrwXndoOCQO3LBjs0PQikJeh5 IxupC/4G4q0rLXq9IWR8ya8Nsf8rc/qiqzYyGVfPhU0Kur3yifyB8K4qGSRIy6QshezC MrviUbmmmg2eG07LgihC978bZPIlIlhzBjIzUwtpuOQv8q/kZ427Y+Z1728BoAoApWkH ZqSQ== X-Gm-Message-State: AOAM533YJ8y9ij9dpMeDjl8R7d/yfnu0DJa3INdJoNS+ZoInW/9lYJLD GxHwSj1rAYqUZAjd+8ig62i7EVccMGE= X-Google-Smtp-Source: ABdhPJxFIlIFPqh41Y8DKlp3BF/310Wa9qNRIhGkrdPXnp1+GeFiGn2wK8WWSc2XAV6/+rhh3J8i6g== X-Received: by 2002:a1c:2485:: with SMTP id k127mr8790621wmk.138.1594209759339; Wed, 08 Jul 2020 05:02:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:38 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 10/30] scsi: libfc: fc_lport: Repair function parameter documentation Date: Wed, 8 Jul 2020 13:02:01 +0100 Message-Id: <20200708120221.3386672-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Either misdocumentation and/or bitrot. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_lport.c:412: warning: Function parameter or member 'in_fp' not described in 'fc_lport_recv_echo_req' drivers/scsi/libfc/fc_lport.c:412: warning: Excess function parameter 'fp' description in 'fc_lport_recv_echo_req' drivers/scsi/libfc/fc_lport.c:447: warning: Function parameter or member 'in_fp' not described in 'fc_lport_recv_rnid_req' drivers/scsi/libfc/fc_lport.c:447: warning: Excess function parameter 'fp' description in 'fc_lport_recv_rnid_req' drivers/scsi/libfc/fc_lport.c:1330: warning: Function parameter or member 'state' not described in 'fc_lport_enter_ns' drivers/scsi/libfc/fc_lport.c:1428: warning: Function parameter or member 'state' not described in 'fc_lport_enter_ms' drivers/scsi/libfc/fc_lport.c:1939: warning: Function parameter or member 'tov' not described in 'fc_lport_els_request' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_lport.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c index 684c5e361a286..b84dbc316df15 100644 --- a/drivers/scsi/libfc/fc_lport.c +++ b/drivers/scsi/libfc/fc_lport.c @@ -405,7 +405,7 @@ static void fc_lport_recv_rlir_req(struct fc_lport *lport, struct fc_frame *fp) /** * fc_lport_recv_echo_req() - Handle received ECHO request * @lport: The local port receiving the ECHO - * @fp: ECHO request frame + * @in_fp: ECHO request frame */ static void fc_lport_recv_echo_req(struct fc_lport *lport, struct fc_frame *in_fp) @@ -440,7 +440,7 @@ static void fc_lport_recv_echo_req(struct fc_lport *lport, /** * fc_lport_recv_rnid_req() - Handle received Request Node ID data request * @lport: The local port receiving the RNID - * @fp: The RNID request frame + * @in_fp: The RNID request frame */ static void fc_lport_recv_rnid_req(struct fc_lport *lport, struct fc_frame *in_fp) @@ -1325,6 +1325,7 @@ static void fc_lport_enter_scr(struct fc_lport *lport) /** * fc_lport_enter_ns() - register some object with the name server * @lport: Fibre Channel local port to register + * @state: Local port state */ static void fc_lport_enter_ns(struct fc_lport *lport, enum fc_lport_state state) { @@ -1423,6 +1424,7 @@ static void fc_lport_enter_dns(struct fc_lport *lport) /** * fc_lport_enter_ms() - management server commands * @lport: Fibre Channel local port to register + * @state: Local port state */ static void fc_lport_enter_ms(struct fc_lport *lport, enum fc_lport_state state) { @@ -1932,6 +1934,7 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, * @job: The BSG Passthrough job * @lport: The local port sending the request * @did: The destination port id + * @tov: The timeout period (in ms) */ static int fc_lport_els_request(struct bsg_job *job, struct fc_lport *lport, From patchwork Wed Jul 8 12:02:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AFC5913 for ; Wed, 8 Jul 2020 12:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7337E2080D for ; Wed, 8 Jul 2020 12:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pxXV0EYb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729081AbgGHMCo (ORCPT ); Wed, 8 Jul 2020 08:02:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729056AbgGHMCl (ORCPT ); Wed, 8 Jul 2020 08:02:41 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E9A8C08E763 for ; Wed, 8 Jul 2020 05:02:41 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so2740289wmh.2 for ; Wed, 08 Jul 2020 05:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PUEEoaUyF+s08hE4dARneQxf1Covum7aHqB9FrCQqkg=; b=pxXV0EYbO/Efhe2l4FrwNUHf3aw91pdWOupfVC6/0ixxbUMs5OuGizocqMJNMZzYDb p99Kk593i/aTNpYlRIHL4qJnB+nMqMw5jpLA3QI34FM1tvDcip5cse0QZ0ymPnhQvGMR M8yLIIYKhbXqe242v/hCKN4SQHrpvSyAO/8cRKhfaUYiksC872hREKWmbbgcoaE2vNws LwiK4DKh2h8n34GK46+eoruCag26JNpB5IbScXXbhULDPH9Ukye4/J++DodbIP+z4iG7 AbnL2aAKpoqL44rwUWi29SoDwp/az05LGAWp7NPAznlDkT14oMqei6dkKRqkf/CvCQ2K lUTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PUEEoaUyF+s08hE4dARneQxf1Covum7aHqB9FrCQqkg=; b=nnKWa/eF5bz2mtNd86AbeRsHO535zd/gEYWNzhwq7U4tQ9oS098lpUdJrsvkr62hJ4 fw1qxsjzo2eAGZembyOtSWDtuG9PmRSlOdxQK7DWhY3GEtZrVY636mXFolZvmDgOR1BM oERtIQTMLdRqL8y/30MLdlHAZq6ERGYPLmfB8rzFEVH2ZsrYNGECfkYTSdORKaE920SH 9oyrvdWLtLf9C/Hj4BhdeISHWmrSEVALUlLBMOmONRpdHyJC1blorqhiOskrEpdX/yUf YWrZLQtzjAmr6kCcq0Ak64Qe2k4u5k134LccoGWLbYG+F7YPyqd02cXP8csniPUufxtu 7hVA== X-Gm-Message-State: AOAM5339LxmYFcsxIVgbtoFbYkDh4tbimiRBnszgxsJqfyLQTXgNPztg Gbi3vSQIqO0YDXaXLDcgGeqn4Q== X-Google-Smtp-Source: ABdhPJzxdA+vdJ9AscwTb1wWQzpErI8U1G4NExOlK6INLjHkDA9iMum4ZAxybvC6e7lyHjZyUYKJlg== X-Received: by 2002:a1c:6354:: with SMTP id x81mr8672065wmb.98.1594209760335; Wed, 08 Jul 2020 05:02:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:39 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 11/30] scsi: libfc: fc_rport: Fix a couple of misdocumented function parameters Date: Wed, 8 Jul 2020 13:02:02 +0100 Message-Id: <20200708120221.3386672-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:129: warning: Function parameter or member 'port_id' not described in 'fc_rport_create' drivers/scsi/libfc/fc_rport.c:129: warning: Excess function parameter 'ids' description in 'fc_rport_create' drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'lport_arg' description in 'fc_rport_logo_resp' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_rport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 278d15ff1c5ae..ea99e69d4d89c 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -121,7 +121,7 @@ EXPORT_SYMBOL(fc_rport_lookup); /** * fc_rport_create() - Create a new remote port * @lport: The local port this remote port will be associated with - * @ids: The identifiers for the new remote port + * @port_id: The identifiers for the new remote port * * The remote port will start in the INIT state. */ @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, * fc_rport_logo_resp() - Handler for logout (LOGO) responses * @sp: The sequence the LOGO was on * @fp: The LOGO response frame - * @lport_arg: The local port + * @rport_arg: The local port */ static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, void *rdata_arg) From patchwork Wed Jul 8 12:02:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651449 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 60F1F913 for ; Wed, 8 Jul 2020 12:02:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4451F2078D for ; Wed, 8 Jul 2020 12:02:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P7pECm1G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729089AbgGHMCp (ORCPT ); Wed, 8 Jul 2020 08:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729069AbgGHMCo (ORCPT ); Wed, 8 Jul 2020 08:02:44 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B455AC08E876 for ; Wed, 8 Jul 2020 05:02:43 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q15so2726218wmj.2 for ; Wed, 08 Jul 2020 05:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DSQYT4u05u5XHMfy8CsexKzDa1uvZ/5gisr4AmMPcPk=; b=P7pECm1Gy1aRGbb++bMKhwPg0A2Y4d68UaMYFhuCKyV7BMX6/bLCcJJU1aOmkTCNnR ESXvFF0ZIUpyGUBlYp41i+v78s2zHN9JN7jTrQO8KRQt9mga3jI+XfLhqnrLMqCQ0Ql9 xM+/0JCu3uYPvksvh9FzSn57QgfB9VHwcitInoNrmizP17t+sRXsyi7hr0pIaiz+CKRJ LdOaxKfUR9WU9i4gXuE2ygO0DsQsZxTXF1SoBYUkR3cBmKoi16XVhdpP5LgzttcngxtY sxcZlUl0YpiKu3mokih0XocFqx5/DZ9iKJTByM1jXxN6M+DiyYpuvQLDF4odHGcRnGNy 7CEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DSQYT4u05u5XHMfy8CsexKzDa1uvZ/5gisr4AmMPcPk=; b=U4xWUE5Z/WuZt+q0RKyNgcqPFvuDeIRRbEba+YSWJaMV6tq/ICaJlkEhHZ4ugICP/y D4vVcbShcmz2Zlq5NxPfcb2yT4+63Qzq5RLr2+ppQEWLMAq7kJuDS6Io3AfBMz6i+FE2 xQJTmtRef8i7pYzN3B5oJ09LLO3aCZzqWgZFJfhtY/oqFotKp+6nlMnMigEYKQ5+altU nKLeO02TeniRn+Q3ro0L9PH56F+PkDA5+xCTctM4duMyfTlwGcvuDb5jfyu+JZyo0heB nvDTz40Lx4EGbL11S7QbR3o7Zjod+sMZO8No7H04DgiDmtRO8Cc4WVQrdHwjor8cEQSP 3OiQ== X-Gm-Message-State: AOAM532xQQA1taamGZ/fvpjYlWxCbmIh35q113s6evgSCfsqjZmq4Q+e ByruaR8mbcIy728KxSinY6Eb5Q== X-Google-Smtp-Source: ABdhPJz0/5Wm5G+Wa29qTxr1KGWCC4Ogqt6V8P6SjFAPiPZP9bxs2AwnCef6loyajt0KgPGKePrthg== X-Received: by 2002:a05:600c:2c0d:: with SMTP id q13mr8769318wmg.81.1594209762080; Wed, 08 Jul 2020 05:02:42 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:41 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 12/30] scsi: libfc: fc_fcp: Provide missing and repair existing function documentation Date: Wed, 8 Jul 2020 13:02:03 +0100 Message-Id: <20200708120221.3386672-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Mostly due to descriptions not keeping up with API changes. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_fcp.c:299: warning: Function parameter or member 'status_code' not described in 'fc_fcp_retry_cmd' drivers/scsi/libfc/fc_fcp.c:595: warning: Function parameter or member 'seq' not described in 'fc_fcp_send_data' drivers/scsi/libfc/fc_fcp.c:595: warning: Excess function parameter 'sp' description in 'fc_fcp_send_data' drivers/scsi/libfc/fc_fcp.c:1289: warning: Function parameter or member 't' not described in 'fc_lun_reset_send' drivers/scsi/libfc/fc_fcp.c:1289: warning: Excess function parameter 'data' description in 'fc_lun_reset_send' drivers/scsi/libfc/fc_fcp.c:1422: warning: Function parameter or member 't' not described in 'fc_fcp_timeout' drivers/scsi/libfc/fc_fcp.c:1422: warning: Excess function parameter 'data' description in 'fc_fcp_timeout' drivers/scsi/libfc/fc_fcp.c:1696: warning: Function parameter or member 'code' not described in 'fc_fcp_recovery' drivers/scsi/libfc/fc_fcp.c:1716: warning: Function parameter or member 'offset' not described in 'fc_fcp_srr' drivers/scsi/libfc/fc_fcp.c:1859: warning: Function parameter or member 'sc_cmd' not described in 'fc_queuecommand' drivers/scsi/libfc/fc_fcp.c:1859: warning: Excess function parameter 'cmd' description in 'fc_queuecommand' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_fcp.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index bf2cc9656e191..d1ff2335f552b 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -289,6 +289,7 @@ static int fc_fcp_send_abort(struct fc_fcp_pkt *fsp) /** * fc_fcp_retry_cmd() - Retry a fcp_pkt * @fsp: The FCP packet to be retried + * @status_code: The FCP status code to set * * Sets the status code to be FC_ERROR and then calls * fc_fcp_complete_locked() which in turn calls fc_io_compl(). @@ -580,7 +581,7 @@ static void fc_fcp_recv_data(struct fc_fcp_pkt *fsp, struct fc_frame *fp) /** * fc_fcp_send_data() - Send SCSI data to a target * @fsp: The FCP packet the data is on - * @sp: The sequence the data is to be sent on + * @seq: The sequence the data is to be sent on * @offset: The starting offset for this data request * @seq_blen: The burst length for this data request * @@ -1283,7 +1284,7 @@ static int fc_fcp_pkt_abort(struct fc_fcp_pkt *fsp) /** * fc_lun_reset_send() - Send LUN reset command - * @data: The FCP packet that identifies the LUN to be reset + * @t: Timer context used to fectch the FSP packet */ static void fc_lun_reset_send(struct timer_list *t) { @@ -1409,7 +1410,7 @@ static void fc_fcp_cleanup(struct fc_lport *lport) /** * fc_fcp_timeout() - Handler for fcp_pkt timeouts - * @data: The FCP packet that has timed out + * @t: Timer context used to fectch the FSP packet * * If REC is supported then just issue it and return. The REC exchange will * complete or time out and recovery can continue at that point. Otherwise, @@ -1691,6 +1692,7 @@ static void fc_fcp_rec_error(struct fc_fcp_pkt *fsp, struct fc_frame *fp) /** * fc_fcp_recovery() - Handler for fcp_pkt recovery * @fsp: The FCP pkt that needs to be aborted + * @code: The FCP status code to set */ static void fc_fcp_recovery(struct fc_fcp_pkt *fsp, u8 code) { @@ -1709,6 +1711,7 @@ static void fc_fcp_recovery(struct fc_fcp_pkt *fsp, u8 code) * fc_fcp_srr() - Send a SRR request (Sequence Retransmission Request) * @fsp: The FCP packet the SRR is to be sent on * @r_ctl: The R_CTL field for the SRR request + * @offset: The SRR relative offset * This is called after receiving status but insufficient data, or * when expecting status but the request has timed out. */ @@ -1851,7 +1854,7 @@ static inline int fc_fcp_lport_queue_ready(struct fc_lport *lport) /** * fc_queuecommand() - The queuecommand function of the SCSI template * @shost: The Scsi_Host that the command was issued to - * @cmd: The scsi_cmnd to be executed + * @sc_cmd: The scsi_cmnd to be executed * * This is the i/o strategy routine, called by the SCSI layer. */ From patchwork Wed Jul 8 12:02:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7BE3860D for ; Wed, 8 Jul 2020 12:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 633B22078A for ; Wed, 8 Jul 2020 12:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ePpcXke5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729101AbgGHMCr (ORCPT ); Wed, 8 Jul 2020 08:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729091AbgGHMCp (ORCPT ); Wed, 8 Jul 2020 08:02:45 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31FA1C08C5DC for ; Wed, 8 Jul 2020 05:02:45 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z2so26409632wrp.2 for ; Wed, 08 Jul 2020 05:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RqlEHKoTUXwkwwzl23khP5gj2PQF0+ph23LGhTCUMbw=; b=ePpcXke5tXclT2fBQPujnmP2l9hoUTUx+VX/MZTSmyivctPiQwNyHOIJQlMnwrCBq4 qWa4BcdVq8Or6fdbX0k/F0sMw7F1z2FPsLCG6vfeo/Ms9fJiAiI+kr9alWl7+HrhZ1Aj Oc/Zwx5s4NaFdZYy5PTIXbExIKG5C9bSb3+XM4igB+fncFS/rjaHORj/Y30mC4C7tZjw KEvyZbNlV1OzL8BHUCIPhlWAQCVgLNWFWn45Hs2oS5LVejnDrzhid9+8IiugOJUIhMn5 ySriXNtKzfvJ1mSZxGj+5zuwVDSYli87Cz3vLmSGTjG7DwPM3xyVCaUDtx5zTBFeLgjr X1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RqlEHKoTUXwkwwzl23khP5gj2PQF0+ph23LGhTCUMbw=; b=md+15FC46IwDpkW8DecYlM9IbFF1HJ62aeOnGZQ3eEy1qRDLiXyoybdhTEVNK/ZL5+ 9yviglX0kgQvNg9Tmr2sW7T1pOYQk408qJGBylu4pgCkrC8uVUEQaiYbGmof5E/2ihMu CqZbd2HS0uCxW5saO5CoEqgNuNwlp04GdjiaUadL0MdZZYD1Cv+mPTDamJIIbSUxY7Yn FBUW2OmgGxPtY3GmrKXY6QhqMTmX+k1VRTejS30tII/HnrI+XJ2P4OE+syT7g0YBzU43 gGhSTQ1nlt2/nsTJ1pA+tcU3uIgcP8yI8igKNz8anE/Wo0jnPXOoFnPpA/stWQFaKRMz wqng== X-Gm-Message-State: AOAM533ZHow8eBq+gHcwOv3cLQ/fgZRKw/gW8mdQWYZ2q+wLLKyH0azf 9IPJsyWk9lonx8Ggdg9pItqq0w== X-Google-Smtp-Source: ABdhPJybgCUfC2v2G2nkcbaN94RRipdwi48CXMSX3irN5Cb2W43ouvBk5Pn7IZE/DcQiUbAbUj4GhA== X-Received: by 2002:adf:efc9:: with SMTP id i9mr61721571wrp.77.1594209763930; Wed, 08 Jul 2020 05:02:43 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:42 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke Subject: [PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function parameter and copy/paste error Date: Wed, 8 Jul 2020 13:02:04 +0100 Message-Id: <20200708120221.3386672-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Description should state 'remote' port, not 'local'. Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp' drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp' Cc: Hannes Reinecke Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_rport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index ea99e69d4d89c..18663a82865f9 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata, * fc_rport_logo_resp() - Handler for logout (LOGO) responses * @sp: The sequence the LOGO was on * @fp: The LOGO response frame - * @rport_arg: The local port + * @rdata_arg: The remote port */ static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp, void *rdata_arg) From patchwork Wed Jul 8 12:02:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651485 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7DA2A60D for ; Wed, 8 Jul 2020 12:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6504E2078A for ; Wed, 8 Jul 2020 12:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oE7zSyqN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729297AbgGHMEO (ORCPT ); Wed, 8 Jul 2020 08:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729100AbgGHMCr (ORCPT ); Wed, 8 Jul 2020 08:02:47 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF717C08E6DC for ; Wed, 8 Jul 2020 05:02:46 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id a6so48692948wrm.4 for ; Wed, 08 Jul 2020 05:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u+pt3rF/aF9MXBxaxOWkhoV3OTeQnwTFN7tbYNZX5zs=; b=oE7zSyqND80DYg6poQGupsJ8X6JD6kP5o9tqMqKexmIZ5T1XZjMpjTu+uc7XV6qG7C kgRV15okIHcFVrQO3kFLU1I/IukiFmYdYwspufNCTRM1gYnW9u4QQmEd4wNPjU9bXeY1 4F54e1h99u1e3nHDUhuna8VpdSI0KEA8ciSGQSTWgQcJPnBXfHbNoj0+Myq6rxp/eRmo ykuFjG2I1w+jLuHT3F04K3g0Nc5DtiGlrm1JnI/1KFlsdjpK91/142ie+NT+ae16cS8T Ubys/GUaWZV1JQrnzxbGaWGDvtMlqqZ63FShQOSNGLNQQeM8svaxthO8fb8w6nQJAEyV APvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u+pt3rF/aF9MXBxaxOWkhoV3OTeQnwTFN7tbYNZX5zs=; b=son0F+ELD5UmivHAZjc0Igtp5J3zS/RgqHsPrwkNSyLPtJjsUUl5Mz3+1ALZ2xZ6ek M5AxwwSlzDUXHUiDg07ryw0f/v7/iCYkt07llJhlfaut6O8yZHS/LeWHKhQTetVoDRbo 4+MO5i7GHTjZSrtMjpvzrK+Dl90rIyLdklELBvetjwW0hCdWuUnR+zvTO5sWARbtxIeE GOR0qzrdHsoU57aJBlq7FBPZkFKazsxHhgg73gYrOOe0DMIE0q/hDutOxBRjLwOEdQi+ TieopSFdxfXi8pf7iTDsLyPjol+3KYw9vJhp+TYW4qaaokd0iuRlB1QaTi7weMmTx3H5 BhSQ== X-Gm-Message-State: AOAM532T0w8RIlTgZBV1I+GWmeRExY4PBN+RsmbNwbLRcxOMrSlpIu1j 7PDS+idm9KVOsL4dWvkJzb/s4A== X-Google-Smtp-Source: ABdhPJxURppvfG7DEhP9spdQjCHFBwUzs5wOqtlXraGeSTbxLP6VMc4VjMRGbCLjqZhSHFVRG8rCJA== X-Received: by 2002:a5d:5084:: with SMTP id a4mr60185807wrt.191.1594209765523; Wed, 08 Jul 2020 05:02:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:44 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Prakash Gollapudi Subject: [PATCH 14/30] scsi: bnx2fc: bnx2fc_hwi: Fix a couple of bitrotted function documentation headers Date: Wed, 8 Jul 2020 13:02:05 +0100 Message-Id: <20200708120221.3386672-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Likely a result of documentation not keeping up with API updates (a.k.a. bitrot). Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_hwi.c:493: warning: Function parameter or member 'hba' not described in 'bnx2fc_send_session_destroy_req' drivers/scsi/bnx2fc/bnx2fc_hwi.c:493: warning: Excess function parameter 'port' description in 'bnx2fc_send_session_destroy_req' drivers/scsi/bnx2fc/bnx2fc_hwi.c:1345: warning: Function parameter or member 'context' not described in 'bnx2fc_indicate_kcqe' drivers/scsi/bnx2fc/bnx2fc_hwi.c:1345: warning: Function parameter or member 'kcq' not described in 'bnx2fc_indicate_kcqe' drivers/scsi/bnx2fc/bnx2fc_hwi.c:1345: warning: Excess function parameter 'hba' description in 'bnx2fc_indicate_kcqe' drivers/scsi/bnx2fc/bnx2fc_hwi.c:1345: warning: Excess function parameter 'kcqe' description in 'bnx2fc_indicate_kcqe' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Prakash Gollapudi Signed-off-by: Lee Jones --- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c index 8c0d6866cf3b8..e72d7bb7f4f42 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c @@ -485,7 +485,7 @@ int bnx2fc_send_session_disable_req(struct fcoe_port *port, /** * bnx2fc_send_session_destroy_req - initiates FCoE Session destroy * - * @port: port structure pointer + * @hba: adapter structure pointer * @tgt: bnx2fc_rport structure pointer */ int bnx2fc_send_session_destroy_req(struct bnx2fc_hba *hba, @@ -1334,8 +1334,8 @@ static void bnx2fc_init_failure(struct bnx2fc_hba *hba, u32 err_code) /** * bnx2fc_indicae_kcqe - process KCQE * - * @hba: adapter structure pointer - * @kcqe: kcqe pointer + * @context: adapter structure pointer + * @kcq: kcqe pointer * @num_cqe: Number of completion queue elements * * Generic KCQ event handler From patchwork Wed Jul 8 12:02:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651481 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 415B313B6 for ; Wed, 8 Jul 2020 12:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2831420775 for ; Wed, 8 Jul 2020 12:04:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LlEuIaQu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729120AbgGHMCt (ORCPT ); Wed, 8 Jul 2020 08:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729107AbgGHMCs (ORCPT ); Wed, 8 Jul 2020 08:02:48 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00875C08E81A for ; Wed, 8 Jul 2020 05:02:48 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z13so48673021wrw.5 for ; Wed, 08 Jul 2020 05:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gWJPxbY7PTu5jz1j2WvOZoYFlTAfYyf+i8sx4XKlA9Q=; b=LlEuIaQuyQtrD8o+C30o/JtGeWeUsbO/txVU+A6LYz63IfG9R93qINSLBUmVyZvT2U 98bMPE8qF6hGv0pP16N3AKpuQrg/IZLSD2KwCZt18PPYtVp3G4iUBLsgI1dM3oWRe5ZR KyqTPJen03y7ssLSdaSFBg4O45HqvmY1X2qVlbfGTr7RMdhoKAc4fJ1Bz2Pik4kXtO0R VAEBah5CGh4GXJSueVHxYQRPFd2G5wCWL/Nv95H5us/2U1NYiSxKFKJvBW2L6G5FoEz1 5yxFmy5tgLsjt+3sT0HOZ7GjvNGB0EdZfeSc3nlDxFwopJ6+W2Coc0aT9utnaV2rzyGH oL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gWJPxbY7PTu5jz1j2WvOZoYFlTAfYyf+i8sx4XKlA9Q=; b=oOT8WN0VQTqjrQmZy5dYphNgmnpwROYuJCMR0zd0NrwETVlPtz+eY8xlvPdsKeWgjE 9FyQuaENfto7mlj0VYqbzKBx+xqfGsgVu8qVg0x2IoPZP9CbhtmGcaCXWjd+JTwXYLbH 12g/QXdk/3b0MQ0l5kLMYgaVaRMXTsYlaKkmksAUot7UcDcTVlwiHvXKBxIgXiyBoNE7 QKENoqe/kNOQMT9JdXcDfP0GnGDd8wSVZubG903+nIrRR+90z7ElAkLWMw6JmSY/8V1/ 1xNrjGclBpxdV9ifSMWwULgHnjqEklIsmW/smo5cc6gk+duh1PRYyTybT/q/Z95BHgz4 QErw== X-Gm-Message-State: AOAM533177GMgnszPUswbMNyiqVvhaeFuyQiWaiLQoTqXSE2V8yZ6xeh CwGR5OjeeLBZwt/5rgW12eZF5RPOSEQ= X-Google-Smtp-Source: ABdhPJyoBWDur01GN3OGpWdPl+zjI7B005D70HmJyRtXG+8lIHhWFF5UJGc9jIyLm/qIhJzG+PFwkw== X-Received: by 2002:adf:c404:: with SMTP id v4mr55879971wrf.85.1594209766662; Wed, 08 Jul 2020 05:02:46 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:45 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , support@areca.com.tw Subject: [PATCH 15/30] scsi: arcmsr: arcmsr_hba: Remove some set but unused variables Date: Wed, 8 Jul 2020 13:02:06 +0100 Message-Id: <20200708120221.3386672-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_remap_pciregion’: drivers/scsi/arcmsr/arcmsr_hba.c:286:30: warning: variable ‘flags’ set but not used [-Wunused-but-set-variable] 286 | unsigned long addr, range, flags; | ^~~~~ drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_suspend’: drivers/scsi/arcmsr/arcmsr_hba.c:1070:11: warning: variable ‘intmask_org’ set but not used [-Wunused-but-set-variable] 1070 | uint32_t intmask_org; | ^~~~~~~~~~~ drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_done4abort_postqueue’: drivers/scsi/arcmsr/arcmsr_hba.c:1410:29: warning: variable ‘cdb_phy_hipart’ set but not used [-Wunused-but-set-variable] 1410 | unsigned long ccb_cdb_phy, cdb_phy_hipart; | ^~~~~~~~~~~~~~ drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_hbaD_postqueue_isr’: drivers/scsi/arcmsr/arcmsr_hba.c:2448:36: warning: variable ‘cdb_phy_hipart’ set but not used [-Wunused-but-set-variable] 2448 | unsigned long flags, ccb_cdb_phy, cdb_phy_hipart; | ^~~~~~~~~~~~~~ drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_hbaD_polling_ccbdone’: drivers/scsi/arcmsr/arcmsr_hba.c:3498:36: warning: variable ‘cdb_phy_hipart’ set but not used [-Wunused-but-set-variable] 3498 | unsigned long flags, ccb_cdb_phy, cdb_phy_hipart; | ^~~~~~~~~~~~~~ Cc: support@areca.com.tw Signed-off-by: Lee Jones --- drivers/scsi/arcmsr/arcmsr_hba.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 30914c8f29cc2..1c252934409c7 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -283,11 +283,10 @@ static bool arcmsr_remap_pciregion(struct AdapterControlBlock *acb) } case ACB_ADAPTER_TYPE_D: { void __iomem *mem_base0; - unsigned long addr, range, flags; + unsigned long addr, range; addr = (unsigned long)pci_resource_start(pdev, 0); range = pci_resource_len(pdev, 0); - flags = pci_resource_flags(pdev, 0); mem_base0 = ioremap(addr, range); if (!mem_base0) { pr_notice("arcmsr%d: memory mapping region fail\n", @@ -1067,12 +1066,11 @@ static void arcmsr_free_irq(struct pci_dev *pdev, static int arcmsr_suspend(struct pci_dev *pdev, pm_message_t state) { - uint32_t intmask_org; struct Scsi_Host *host = pci_get_drvdata(pdev); struct AdapterControlBlock *acb = (struct AdapterControlBlock *)host->hostdata; - intmask_org = arcmsr_disable_outbound_ints(acb); + arcmsr_disable_outbound_ints(acb); arcmsr_free_irq(pdev, acb); del_timer_sync(&acb->eternal_timer); if (set_date_time) @@ -1407,7 +1405,7 @@ static void arcmsr_done4abort_postqueue(struct AdapterControlBlock *acb) struct ARCMSR_CDB *pARCMSR_CDB; bool error; struct CommandControlBlock *pCCB; - unsigned long ccb_cdb_phy, cdb_phy_hipart; + unsigned long ccb_cdb_phy; switch (acb->adapter_type) { @@ -1489,8 +1487,7 @@ static void arcmsr_done4abort_postqueue(struct AdapterControlBlock *acb) ((toggle ^ 0x4000) + 1); doneq_index = pmu->doneq_index; spin_unlock_irqrestore(&acb->doneq_lock, flags); - cdb_phy_hipart = pmu->done_qbuffer[doneq_index & - 0xFFF].addressHigh; + pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh; addressLow = pmu->done_qbuffer[doneq_index & 0xFFF].addressLow; ccb_cdb_phy = (addressLow & 0xFFFFFFF0); @@ -2445,7 +2442,7 @@ static void arcmsr_hbaD_postqueue_isr(struct AdapterControlBlock *acb) struct MessageUnit_D *pmu; struct ARCMSR_CDB *arcmsr_cdb; struct CommandControlBlock *ccb; - unsigned long flags, ccb_cdb_phy, cdb_phy_hipart; + unsigned long flags, ccb_cdb_phy; spin_lock_irqsave(&acb->doneq_lock, flags); pmu = acb->pmuD; @@ -2459,8 +2456,7 @@ static void arcmsr_hbaD_postqueue_isr(struct AdapterControlBlock *acb) pmu->doneq_index = index_stripped ? (index_stripped | toggle) : ((toggle ^ 0x4000) + 1); doneq_index = pmu->doneq_index; - cdb_phy_hipart = pmu->done_qbuffer[doneq_index & - 0xFFF].addressHigh; + pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh; addressLow = pmu->done_qbuffer[doneq_index & 0xFFF].addressLow; ccb_cdb_phy = (addressLow & 0xFFFFFFF0); @@ -3495,7 +3491,7 @@ static int arcmsr_hbaD_polling_ccbdone(struct AdapterControlBlock *acb, bool error; uint32_t poll_ccb_done = 0, poll_count = 0, flag_ccb; int rtn, doneq_index, index_stripped, outbound_write_pointer, toggle; - unsigned long flags, ccb_cdb_phy, cdb_phy_hipart; + unsigned long flags, ccb_cdb_phy; struct ARCMSR_CDB *arcmsr_cdb; struct CommandControlBlock *pCCB; struct MessageUnit_D *pmu = acb->pmuD; @@ -3527,8 +3523,7 @@ static int arcmsr_hbaD_polling_ccbdone(struct AdapterControlBlock *acb, ((toggle ^ 0x4000) + 1); doneq_index = pmu->doneq_index; spin_unlock_irqrestore(&acb->doneq_lock, flags); - cdb_phy_hipart = pmu->done_qbuffer[doneq_index & - 0xFFF].addressHigh; + pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh; flag_ccb = pmu->done_qbuffer[doneq_index & 0xFFF].addressLow; ccb_cdb_phy = (flag_ccb & 0xFFFFFFF0); if (acb->cdb_phyadd_hipart) From patchwork Wed Jul 8 12:02:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651479 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 20EC460D for ; Wed, 8 Jul 2020 12:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08AD620772 for ; Wed, 8 Jul 2020 12:04:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wYVP4yTr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbgGHMEB (ORCPT ); Wed, 8 Jul 2020 08:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729122AbgGHMCu (ORCPT ); Wed, 8 Jul 2020 08:02:50 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A227AC08E6DC for ; Wed, 8 Jul 2020 05:02:49 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s10so48633707wrw.12 for ; Wed, 08 Jul 2020 05:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sZwSMA5UIb7oM9+D5j+l12KsCqeP4op1hhjOFtyL2ps=; b=wYVP4yTrdIb3gPXKLBwSIe8aCHTr6bqSOLL6eZHfT2SvX4q7eX66ukJezKlb3lJqzz CMDoawaoFMDHzHmDGUCKQ6z7g/1iBWboIw+C6XhatxXuamWkI+POzEoQS8TVmKkIoHjn lDqKVIY9a1/orsCpupEsEuTM39RugV8ru6SmhANSET57A7VpxrvkQJ+SE2M2lcl2jD0b n2EXTHaIJfjG7vIhxcWdJTpZqeBDEtlI96662m8C4+2T7wWh/+pZOhrRQB1snq6rGvuy ldFuM1a634U11GCgiL8GLL8ONxQ1GezKf3CdyRcJet9PeWu1yxrI1x04pzhr6hv//mrS SmrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sZwSMA5UIb7oM9+D5j+l12KsCqeP4op1hhjOFtyL2ps=; b=i56wROMmpppp9KqXicCHXXSHR0DyMEVvFSreLC8QnQCjEHTWdTa2uAsH4WVjAgLsGg CA//nCS/S1aQr/3KDRf2gEBYioz4pSCy+Cdk5MAJGcHPzP7HAUc77BJkTl9Nb09JhMdw vqa537BLAeIPSCmgpr0ME2NSXZRC2PNlFugM+N7suaB41BJtsmtLO/iE0QODAJMiwa4x XBC8DMH5F/dcmwhOyJALajtCX7ddzubJWAjkzBkM2J/ba+Thov0VNSC3UzyKdG92turT nydf54i/D45fBX3nnSzXXGAo4dkU/5oC9Ov21JCIrAYBIfTAU05zZjpadrwK6Ihbvool lp/w== X-Gm-Message-State: AOAM5331ENgS9eybv+hYwxwccJ0dhHA8apsoPHup8i/d5bNI2vwuMhBb sx1sncPzfwo91woErbQO17pkow== X-Google-Smtp-Source: ABdhPJzUhN5+/7ZGY9cHq+7oMDlNaKPxbiI8XirtTADjCEmOj88jT3VDHFhh0FBXmjOTu9U+a4GNVg== X-Received: by 2002:a5d:6412:: with SMTP id z18mr56966206wru.310.1594209767822; Wed, 08 Jul 2020 05:02:47 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:47 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , support@areca.com.tw Subject: [PATCH 16/30] scsi: arcmsr: arcmsr_hba: Make room for the trailing NULL, even if it is over-written Date: Wed, 8 Jul 2020 13:02:07 +0100 Message-Id: <20200708120221.3386672-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Ensure we do not copy the final one (which is not overwitten). Fixes the following W=1 kernel build warning(s): In file included from include/linux/bitmap.h:9, from include/linux/nodemask.h:95, from include/linux/mmzone.h:17, from include/linux/gfp.h:6, from include/linux/umh.h:4, from include/linux/kmod.h:9, from include/linux/module.h:16, from drivers/scsi/arcmsr/arcmsr_hba.c:47: In function ‘strncpy’, inlined from ‘arcmsr_handle_virtual_command’ at drivers/scsi/arcmsr/arcmsr_hba.c:3055:3: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ In function ‘strncpy’, inlined from ‘arcmsr_handle_virtual_command’ at drivers/scsi/arcmsr/arcmsr_hba.c:3053:3: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output truncated before terminating nul copying 16 bytes from a string of the same length [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ In function ‘strncpy’, inlined from ‘arcmsr_handle_virtual_command’ at drivers/scsi/arcmsr/arcmsr_hba.c:3051:3: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output truncated before terminating nul copying 8 bytes from a string of the same length [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ Cc: support@areca.com.tw Signed-off-by: Lee Jones --- drivers/scsi/arcmsr/arcmsr_hba.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 1c252934409c7..5feed135eb26c 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -3031,7 +3031,7 @@ static void arcmsr_handle_virtual_command(struct AdapterControlBlock *acb, { switch (cmd->cmnd[0]) { case INQUIRY: { - unsigned char inqdata[36]; + unsigned char inqdata[37]; char *buffer; struct scatterlist *sg; @@ -3048,16 +3048,16 @@ static void arcmsr_handle_virtual_command(struct AdapterControlBlock *acb, /* ISO, ECMA, & ANSI versions */ inqdata[4] = 31; /* length of additional data */ - strncpy(&inqdata[8], "Areca ", 8); + strncpy(&inqdata[8], "Areca ", 9); /* Vendor Identification */ - strncpy(&inqdata[16], "RAID controller ", 16); + strncpy(&inqdata[16], "RAID controller ", 17); /* Product Identification */ - strncpy(&inqdata[32], "R001", 4); /* Product Revision */ + strncpy(&inqdata[32], "R001", 5); /* Product Revision */ sg = scsi_sglist(cmd); buffer = kmap_atomic(sg_page(sg)) + sg->offset; - memcpy(buffer, inqdata, sizeof(inqdata)); + memcpy(buffer, inqdata, sizeof(inqdata) - 1); sg = scsi_sglist(cmd); kunmap_atomic(buffer - sg->offset); From patchwork Wed Jul 8 12:02:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651477 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA358913 for ; Wed, 8 Jul 2020 12:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD7F920739 for ; Wed, 8 Jul 2020 12:03:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LCrk/nSz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729138AbgGHMCw (ORCPT ); Wed, 8 Jul 2020 08:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729132AbgGHMCv (ORCPT ); Wed, 8 Jul 2020 08:02:51 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 181DAC08E6DC for ; Wed, 8 Jul 2020 05:02:51 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f7so45653932wrw.1 for ; Wed, 08 Jul 2020 05:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mg1YIIvkYpJ6DUGLzmprsP3AfdbwaW1FuT6nykJ+1c8=; b=LCrk/nSzhh3HJrkDfqz+itjwOmKDQt+wE4yNjJsNxAsaUwpZcAd8GvEsdgkSOYZo5z 7o+qf/aO49+PXFe2utcWGOXXG8AVO5/NNCMCP9khiGMcEvIdvCgN3bn19Tj7KerBvYqB r8czN1UsnVANue88UlwzxhWlnb/tl79HP7K46oFbedCPQVyiDSQ7Ml+gHIoFz4Zu8tMD nDx1nIB3izsFsriHXCbA1/rl/bkcdxpe4yoy4vxcCx5AJ2Xx/l+0FPcY+hXIDI9I6xo9 rYbgqyizh1DJ2wjdPwAQ1mdF+/V1JaToAJffXoaoqixqo9MN86cCENjku61wPbtojt4S Ivjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mg1YIIvkYpJ6DUGLzmprsP3AfdbwaW1FuT6nykJ+1c8=; b=TRiiy7iJil+7Pn6w4JeIRyPPw9/QMDHe9s3T46LdRz1GV+wrNsDtu8VRu0gE8YZb0t zX3PIdlEhROWaM3QQwJp3LZudi8n1Ba7FFltuTUE4PLk+AJ/5nwZ2LCUpUxC5jyl218j w7vTb+hOfijIv2cvvLZeqDFDO4igTUtJYCJ8apjEE0Fdl5CVZSpfYVTSnGCs+wF8yc8a SPLd9tPbqLhaK1wgZ2jfWPEjtXhbXtubDNHpl4nqIHHpzhNdMQRfpUmAag9/erNAq1jU fMtYmbX+8/sQ8Wq05LMWwJH8l3Q5keQ7+RdY+tGwQDXCyCG9b/A3GUEvQ6GGqG4c6dvi KWDw== X-Gm-Message-State: AOAM533F9ZxaQrdxHL8uLM96UY72YdPca959nqfQbTlSKSC6jvBrPMr6 /a6YbiAmkU0noQqIK5LAbcoNfQ== X-Google-Smtp-Source: ABdhPJwhhxqJF147mUsqw6o/BenIIvNwA62KuHnCS4OdSXjaxmLCDXQYWSiRFnAiEKbwmJWrlgErmQ== X-Received: by 2002:a5d:4b4f:: with SMTP id w15mr56943748wrs.84.1594209769710; Wed, 08 Jul 2020 05:02:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:48 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 17/30] scsi: qedf: qedf_io: Remove a whole host of unused variables Date: Wed, 8 Jul 2020 13:02:08 +0100 Message-Id: <20200708120221.3386672-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_io.c: In function ‘qedf_cmd_timeout’: drivers/scsi/qedf/qedf_io.c:25:5: warning: variable ‘op’ set but not used [-Wunused-but-set-variable] 25 | u8 op = 0; | ^~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_map_sg’: drivers/scsi/qedf/qedf_io.c:490:12: warning: variable ‘end_addr’ set but not used [-Wunused-but-set-variable] 490 | u64 addr, end_addr; | ^~~~~~~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_post_io_req’: drivers/scsi/qedf/qedf_io.c:863:22: warning: variable ‘req_type’ set but not used [-Wunused-but-set-variable] 863 | enum fcoe_task_type req_type = 0; | ^~~~~~~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_scsi_completion’: drivers/scsi/qedf/qedf_io.c:1134:31: warning: variable ‘task_ctx’ set but not used [-Wunused-but-set-variable] 1134 | struct e4_fcoe_task_context *task_ctx; | ^~~~~~~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_scsi_done’: drivers/scsi/qedf/qedf_io.c:1345:6: warning: variable ‘xid’ set but not used [-Wunused-but-set-variable] 1345 | u16 xid; | ^~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_initiate_abts’: drivers/scsi/qedf/qedf_io.c:1866:6: warning: variable ‘r_a_tov’ set but not used [-Wunused-but-set-variable] 1866 | u32 r_a_tov = 0; | ^~~~~~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_process_abts_compl’: drivers/scsi/qedf/qedf_io.c:1967:11: warning: variable ‘xid’ set but not used [-Wunused-but-set-variable] 1967 | uint16_t xid; | ^~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_initiate_cleanup’: drivers/scsi/qedf/qedf_io.c:2163:31: warning: variable ‘task’ set but not used [-Wunused-but-set-variable] 2163 | struct e4_fcoe_task_context *task; | ^~~~ drivers/scsi/qedf/qedf_io.c: In function ‘qedf_process_unsol_compl’: drivers/scsi/qedf/qedf_io.c:2534:11: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 2534 | uint16_t tmp; | ^~~ Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedf/qedf_io.c | 30 ++++-------------------------- 1 file changed, 4 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 0f6a15c1a04b3..acd9774a9387c 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -22,7 +22,6 @@ static void qedf_cmd_timeout(struct work_struct *work) container_of(work, struct qedf_ioreq, timeout_work.work); struct qedf_ctx *qedf; struct qedf_rport *fcport; - u8 op = 0; if (io_req == NULL) { QEDF_INFO(NULL, QEDF_LOG_IO, "io_req is NULL.\n"); @@ -89,7 +88,6 @@ static void qedf_cmd_timeout(struct work_struct *work) io_req->event = QEDF_IOREQ_EV_ELS_TMO; /* Call callback function to complete command */ if (io_req->cb_func && io_req->cb_arg) { - op = io_req->cb_arg->op; io_req->cb_func(io_req->cb_arg); io_req->cb_arg = NULL; } @@ -487,7 +485,7 @@ static int qedf_map_sg(struct qedf_ioreq *io_req) int sg_count = 0; int bd_count = 0; u32 sg_len; - u64 addr, end_addr; + u64 addr; int i = 0; sg_count = dma_map_sg(&qedf->pdev->dev, scsi_sglist(sc), @@ -502,10 +500,9 @@ static int qedf_map_sg(struct qedf_ioreq *io_req) scsi_for_each_sg(sc, sg, sg_count, i) { sg_len = (u32)sg_dma_len(sg); addr = (u64)sg_dma_address(sg); - end_addr = (u64)(addr + sg_len); /* - * Intermediate s/g element so check if start and end address + * Intermediate s/g element so check if start address * is page aligned. Only required for writes and only if the * number of scatter/gather elements is 8 or more. */ @@ -860,7 +857,6 @@ int qedf_post_io_req(struct qedf_rport *fcport, struct qedf_ioreq *io_req) struct qedf_ctx *qedf = lport_priv(lport); struct e4_fcoe_task_context *task_ctx; u16 xid; - enum fcoe_task_type req_type = 0; struct fcoe_wqe *sqe; u16 sqe_idx; @@ -873,11 +869,9 @@ int qedf_post_io_req(struct qedf_rport *fcport, struct qedf_ioreq *io_req) io_req->cpu = smp_processor_id(); if (sc_cmd->sc_data_direction == DMA_FROM_DEVICE) { - req_type = FCOE_TASK_TYPE_READ_INITIATOR; io_req->io_req_flags = QEDF_READ; qedf->input_requests++; } else if (sc_cmd->sc_data_direction == DMA_TO_DEVICE) { - req_type = FCOE_TASK_TYPE_WRITE_INITIATOR; io_req->io_req_flags = QEDF_WRITE; qedf->output_requests++; } else { @@ -1130,8 +1124,6 @@ static void qedf_unmap_sg_list(struct qedf_ctx *qedf, struct qedf_ioreq *io_req) void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, struct qedf_ioreq *io_req) { - u16 xid; - struct e4_fcoe_task_context *task_ctx; struct scsi_cmnd *sc_cmd; struct fcoe_cqe_rsp_info *fcp_rsp; struct qedf_rport *fcport; @@ -1155,8 +1147,6 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, return; } - xid = io_req->xid; - task_ctx = qedf_get_task_mem(&qedf->tasks, xid); sc_cmd = io_req->sc_cmd; fcp_rsp = &cqe->cqe_info.rsp_info; @@ -1342,7 +1332,6 @@ void qedf_scsi_completion(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, void qedf_scsi_done(struct qedf_ctx *qedf, struct qedf_ioreq *io_req, int result) { - u16 xid; struct scsi_cmnd *sc_cmd; int refcount; @@ -1364,7 +1353,6 @@ void qedf_scsi_done(struct qedf_ctx *qedf, struct qedf_ioreq *io_req, */ clear_bit(QEDF_CMD_OUTSTANDING, &io_req->flags); - xid = io_req->xid; sc_cmd = io_req->sc_cmd; if (!sc_cmd) { @@ -1863,7 +1851,6 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) struct fc_rport_priv *rdata; struct qedf_ctx *qedf; u16 xid; - u32 r_a_tov = 0; int rc = 0; unsigned long flags; struct fcoe_wqe *sqe; @@ -1886,7 +1873,6 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) goto out; } - r_a_tov = rdata->r_a_tov; lport = qedf->lport; if (lport->state != LPORT_ST_READY || !(lport->link_up)) { @@ -1964,14 +1950,12 @@ void qedf_process_abts_compl(struct qedf_ctx *qedf, struct fcoe_cqe *cqe, struct qedf_ioreq *io_req) { uint32_t r_ctl; - uint16_t xid; int rc; struct qedf_rport *fcport = io_req->fcport; QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_SCSI_TM, "Entered with xid = " "0x%x cmd_type = %d\n", io_req->xid, io_req->cmd_type); - xid = io_req->xid; r_ctl = cqe->cqe_info.abts_info.r_ctl; /* This was added at a point when we were scheduling abts_compl & @@ -2159,8 +2143,6 @@ int qedf_initiate_cleanup(struct qedf_ioreq *io_req, { struct qedf_rport *fcport; struct qedf_ctx *qedf; - uint16_t xid; - struct e4_fcoe_task_context *task; int tmo = 0; int rc = SUCCESS; unsigned long flags; @@ -2220,12 +2202,9 @@ int qedf_initiate_cleanup(struct qedf_ioreq *io_req, refcount, fcport, fcport->rdata->ids.port_id); /* Cleanup cmds re-use the same TID as the original I/O */ - xid = io_req->xid; io_req->cmd_type = QEDF_CLEANUP; io_req->return_scsi_cmd_on_abts = return_scsi_cmd_on_abts; - task = qedf_get_task_mem(&qedf->tasks, xid); - init_completion(&io_req->cleanup_done); spin_lock_irqsave(&fcport->rport_lock, flags); @@ -2531,7 +2510,6 @@ void qedf_process_unsol_compl(struct qedf_ctx *qedf, uint16_t que_idx, struct fcoe_cqe *cqe) { unsigned long flags; - uint16_t tmp; uint16_t pktlen = cqe->cqe_info.unsolic_info.pkt_len; u32 payload_len, crc; struct fc_frame_header *fh; @@ -2629,9 +2607,9 @@ void qedf_process_unsol_compl(struct qedf_ctx *qedf, uint16_t que_idx, qedf->bdq_prod_idx = 0; writew(qedf->bdq_prod_idx, qedf->bdq_primary_prod); - tmp = readw(qedf->bdq_primary_prod); + readw(qedf->bdq_primary_prod); writew(qedf->bdq_prod_idx, qedf->bdq_secondary_prod); - tmp = readw(qedf->bdq_secondary_prod); + readw(qedf->bdq_secondary_prod); spin_unlock_irqrestore(&qedf->hba_lock, flags); } From patchwork Wed Jul 8 12:02:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651475 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD45160D for ; Wed, 8 Jul 2020 12:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 940962065C for ; Wed, 8 Jul 2020 12:03:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vRrcLJ4v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbgGHMDt (ORCPT ); Wed, 8 Jul 2020 08:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729141AbgGHMCx (ORCPT ); Wed, 8 Jul 2020 08:02:53 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D50C08C5DC for ; Wed, 8 Jul 2020 05:02:52 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so46265135wrp.10 for ; Wed, 08 Jul 2020 05:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=vRrcLJ4vDQL45XkegDFjkvZZg7i76UXflllyN2qZnOq226OkdOjiHe3dbctK+ciSBn gWt/7Pwpd0ep+S4IlbWVMRNd/jxynHNsYOvFF4YJzUTxJ4WRNxA+9Xx+Hga8fCD8h3Kq NjUMJjub0ouBPz11A0fIgcXp8KkYeU0hakOhnTw2D9YgxvZx9AjdDri3FolrNPkWD89E WQUqQpZ1EfyUTEBnP5Xc43TgLsqRxFxs6LmMtoHTj4gDY7oCFlPP7UeQ1vB/MgbnZwnA 62ZNMumMK3DF40ZarEwdRS0gFNj3ETrfBbl55wKEp2PSrEmF76zgNslRZPhokRoIaQps hGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rsv1890EAaVy29cSOpHY+htSuPNyhdWUNl+08rJAqiI=; b=QObieNg0Nfr68IcCGZ8PgrPgojOhOS7DoNNg4/TwTk2ca6PNr+E9VkTPqFp8Lqtvg6 ViOYNCoDzYl90RrtNi9i9n/YFL9whcx0vxP3YT58MXalPu0MdkyChO3mO5eBaz2i7wFR DnCd/T5YAuaTxf3rYOM9nyRKbRz5tJQUXVMxp76ghs5N61qLJ20UIlHGoEv3iVGe6zJI GZAb/667dnN8OFLiaVc2DITWu4826Z+h4OFUZhFxPWYn8cVPZRIq/2i8yqgaAQNOC9v8 BZ0ANz84sUuaGGZNaTiNy7vSmBYQe+CGgskpigGsb6w0n1kO7iL8Cu1WSGut7ra+C72j a8Mw== X-Gm-Message-State: AOAM531Gdvzyh31xNwVORBye1K1SbaLwdWKf4+9aOBN3XkS1+le7hOqb B1cJ///nr/5y2BqLkAp98GGJKg== X-Google-Smtp-Source: ABdhPJz3PHEM50t/r5XjgX+XVA3j0TbMoFQW182h5eqiEs0GZFDqnC7RQSOEvrxuPzYypjDcuJLp6Q== X-Received: by 2002:adf:e948:: with SMTP id m8mr59728702wrn.398.1594209771378; Wed, 08 Jul 2020 05:02:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:50 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Prakash Gollapudi Subject: [PATCH 18/30] scsi: bnx2fc: bnx2fc_tgt: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 8 Jul 2020 13:02:09 +0100 Message-Id: <20200708120221.3386672-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'lport' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'rdata' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member 'event' not described in 'bnx2fc_rport_event_handler' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'hba' not described in 'bnx2fc_alloc_session_resc' drivers/scsi/bnx2fc/bnx2fc_tgt.c:665: warning: Function parameter or member 'tgt' not described in 'bnx2fc_alloc_session_resc' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Prakash Gollapudi Signed-off-by: Lee Jones --- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c index 50384b4a817c8..a3e2a38aabf2f 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c +++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c @@ -431,7 +431,7 @@ static int bnx2fc_init_tgt(struct bnx2fc_rport *tgt, return 0; } -/** +/* * This event_callback is called after successful completion of libfc * initiated target login. bnx2fc can proceed with initiating the session * establishment. @@ -656,9 +656,8 @@ static void bnx2fc_free_conn_id(struct bnx2fc_hba *hba, u32 conn_id) spin_unlock_bh(&hba->hba_lock); } -/** - *bnx2fc_alloc_session_resc - Allocate qp resources for the session - * +/* + * bnx2fc_alloc_session_resc - Allocate qp resources for the session */ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba *hba, struct bnx2fc_rport *tgt) From patchwork Wed Jul 8 12:02:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651451 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13BF2913 for ; Wed, 8 Jul 2020 12:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E93222078C for ; Wed, 8 Jul 2020 12:02:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G220Ai4w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729159AbgGHMCz (ORCPT ); Wed, 8 Jul 2020 08:02:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729147AbgGHMCy (ORCPT ); Wed, 8 Jul 2020 08:02:54 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB421C08C5DC for ; Wed, 8 Jul 2020 05:02:53 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z13so48673469wrw.5 for ; Wed, 08 Jul 2020 05:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gv6x0VpkNH1KBubo4tbm9ETrzBqqoMdr5YdMKsMLhQk=; b=G220Ai4wYV+H9LPdaGJhcn08dRDAI9AZc/Sag2LiLOJpLSclfGTa1nEe8XtWtJQKQv Uzl3wfDFpi1fa9rWO/jY2L/m80DRo3XcKjxexcx/3WPL/NuvUbyiMWNIFBffi9ghjKTq JdOqkEjXw7xEJ3VkVQJGR1fwzHuXGIMfRDm8Bp/LG6Z55flahyb50r/hi/tT1Kh5Qr8F k6Z+Tnjc6b03u4VyL3sHc7jaaWOOM83IIPLihSYksQvwhhrYidTyn2eDM1xfyiATcsCz w8i2IMbw+BkePHEPgumwuveLujmIrM6NIQF4F2jOhVJbwGMaVuVwh4Wfq+tPeyEhNjRi Us4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gv6x0VpkNH1KBubo4tbm9ETrzBqqoMdr5YdMKsMLhQk=; b=le8JjniZoto/rN0G/QiU+4wxpegRKy8w7yVoXaNEaIFbgqKM6vuNvpJPgNi88a53Gr 2FDmc21J22ovro7iRj9c+5rx5q/ght0ELs8pDS5PmeUphgSZ0vGwsdT4xhCpgSxFmCgQ ZvvecFGKMb9PiLoupslA96I2M5BOeaLrBsMU2r9fWT0dCyTAHRAuDgodPyVaRYW2/noQ UkHj5xhCylBIFccCqhO0SQXB/YwM0mwjgxUsgY9pTJaiWb1IHLbtCq04T/BhdV7jAWf9 L+2FY+o32OqBjCkt+oW/wXx+/pU4vPkNE+qFrQggaL1oY8FvQwiv2CowmTNVSDxSaO1n Zvpg== X-Gm-Message-State: AOAM53247/dAvp1w07Jg80Mt7qcDNhbsUMI/NOr9IOw/oMKRn+cVH9VD dgFVKWmVl33iKoxpbVJgabp/qA== X-Google-Smtp-Source: ABdhPJxBZ5+wTaIVpUTRzBASxtW3kmeSXLXBjvGGO/osSrQr7g/mocW02GIZju2wbYKAuDeAP8ePCA== X-Received: by 2002:adf:f711:: with SMTP id r17mr59508450wrp.409.1594209772642; Wed, 08 Jul 2020 05:02:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:52 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke , "Daniel M. Eischen" , Doug Ledford Subject: [PATCH 19/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'tinfo' Date: Wed, 8 Jul 2020 13:02:10 +0100 Message-Id: <20200708120221.3386672-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks like none of the artifact from ahc_fetch_transinfo() are used anymore. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_target_alloc’: drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ set but not used [-Wunused-but-set-variable] 567 | struct ahc_initiator_tinfo *tinfo; | ^~~~~ Cc: Hannes Reinecke Cc: "Daniel M. Eischen" Cc: Doug Ledford Signed-off-by: Lee Jones --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 2edfa0594f183..32bfe20d79cc1 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -564,8 +564,6 @@ ahc_linux_target_alloc(struct scsi_target *starget) struct scsi_target **ahc_targp = ahc_linux_target_in_softc(starget); unsigned short scsirate; struct ahc_devinfo devinfo; - struct ahc_initiator_tinfo *tinfo; - struct ahc_tmode_tstate *tstate; char channel = starget->channel + 'A'; unsigned int our_id = ahc->our_id; unsigned int target_offset; @@ -612,9 +610,6 @@ ahc_linux_target_alloc(struct scsi_target *starget) spi_max_offset(starget) = 0; spi_min_period(starget) = ahc_find_period(ahc, scsirate, maxsync); - - tinfo = ahc_fetch_transinfo(ahc, channel, ahc->our_id, - starget->id, &tstate); } ahc_compile_devinfo(&devinfo, our_id, starget->id, CAM_LUN_WILDCARD, channel, From patchwork Wed Jul 8 12:02:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651453 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C592E60D for ; Wed, 8 Jul 2020 12:02:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC30620739 for ; Wed, 8 Jul 2020 12:02:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UVVJVhkk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729164AbgGHMC6 (ORCPT ); Wed, 8 Jul 2020 08:02:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729088AbgGHMC4 (ORCPT ); Wed, 8 Jul 2020 08:02:56 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5FF5C08E6DC for ; Wed, 8 Jul 2020 05:02:55 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id q5so48642101wru.6 for ; Wed, 08 Jul 2020 05:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Sy/K8f8HsXXHV/Uh8PtUz+jEUwEZnfQCudyYCgnVPrY=; b=UVVJVhkkvXU5mQaYO7/e6LDc6Bn+WyCrxwonvgA5bXcIDKlvL9UZyftgtkF/mFygO9 Y92+vMSrt60fiM8wodrySHgosdmXqwjvaG1WzE9xIhuct+M/8L+96nZZbbCOnULeiPeN ZTVXO+EZChxwre/ooWZwMBRtGz/N4IHmc4b4dzDo4XBqs5IZVDEKI/RWuz/xu4Y/nxll oEOYdjvrgnEqGvYKb2wvkiCLmtuI4POA5MgvjqNTPNlGUFedPELjVCNPRZUakEPFg46j idt6O3eIE1ZjoTHSb6RgXUs5GAOkd/qW1jc7JHesY4MaWWwu08UKU8pn5Lj+Y/aThEDi CgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sy/K8f8HsXXHV/Uh8PtUz+jEUwEZnfQCudyYCgnVPrY=; b=gTPpeeYTsuj8lRjp6D2akJmcjGPNhaJfCq7sAW/jE7Xwm9JEAwK6/o8Xf8ZHPVUzPG lhP55OXPiMt4Nzl+NqfE01tHujj3txC4JFnH8Og6AklqLSNzRm3Wp8Ql8gG53d+qhwTa nOcpBqxPSymnc9jBWf+/7EEGTpT1O9kDjy8XhYhOw+oYTz1B0nl/vyXpQ1qH1WXUo2w+ ZvJL1sAPxcWr+RJ53cgAldNmslBALK0f8olIlP76CMfwObqgpbF+blc7pOgeR/AjAmAP 3naCqVzGtnoAj9gEDAZ6WZ03E8xlfI96oprjEM88y5Snd0jU2oPsmyM1fHLu0LvjokmG 1CgQ== X-Gm-Message-State: AOAM530+e0BZZruNV078cwjpyat/6Ebyz60lWO6RUQMYy3qyY8flXA7z 6ckdQuTS/uSIItKaG61u5ebHwQ== X-Google-Smtp-Source: ABdhPJwhGEqPkcJyX2dv/WqMG7iM0VhAhQCXAAfNOLSl+0U4picjbr+HsPGcLq6WylxaF+kkxtJ1Ow== X-Received: by 2002:adf:efc9:: with SMTP id i9mr61722445wrp.77.1594209774488; Wed, 08 Jul 2020 05:02:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:53 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke , "Daniel M. Eischen" , Doug Ledford Subject: [PATCH 20/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'ahc' Date: Wed, 8 Jul 2020 13:02:11 +0100 Message-Id: <20200708120221.3386672-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks as though 'ahc' hasn't been used since 2005. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’: drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not used [-Wunused-but-set-variable] 674 | struct ahc_softc *ahc; | ^~~ Cc: Hannes Reinecke Cc: "Daniel M. Eischen" Cc: Doug Ledford Signed-off-by: Lee Jones --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 32bfe20d79cc1..cc4c7b1781466 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -666,10 +666,6 @@ ahc_linux_slave_alloc(struct scsi_device *sdev) static int ahc_linux_slave_configure(struct scsi_device *sdev) { - struct ahc_softc *ahc; - - ahc = *((struct ahc_softc **)sdev->host->hostdata); - if (bootverbose) sdev_printk(KERN_INFO, sdev, "Slave Configure\n"); From patchwork Wed Jul 8 12:02:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651471 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A117F60D for ; Wed, 8 Jul 2020 12:03:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8575120772 for ; Wed, 8 Jul 2020 12:03:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zoWewV9d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729171AbgGHMC7 (ORCPT ); Wed, 8 Jul 2020 08:02:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728853AbgGHMC5 (ORCPT ); Wed, 8 Jul 2020 08:02:57 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C54DDC08E81E for ; Wed, 8 Jul 2020 05:02:56 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f7so45654319wrw.1 for ; Wed, 08 Jul 2020 05:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cqbTOjU/FsSc/cHhe4oGvv9xN2ZDzn7IWu0NGLngM90=; b=zoWewV9d1ulJ/bH/jICQjHixsau47YCzAklx8ceOU84BPftiPxpMZF0f24A3uJifAy WR6EoM/eQTRGCgdtSKVlKcIRuPnEzVw0mCdXnbLrzEZM7aGAuFdowHp17GGw08nGupWS t+lpRdoDrh2caOBuiY3mb6YnMTarGIipSjHtUFInU29vKG58Cw/RLCWaZztfylzbEDOV wM37/e7+vMtJflYnxCy3AySMUfiPOXz5k8hYR0N4OBk4i1KQbXPv8K11gvvMY1D7mYhv lqHE5EJVJzm+zpA6G+2F0xspXaakloejilN2rTdeJ8DuwPcOUFqzbfLKfzMTVPdte2SB rTlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cqbTOjU/FsSc/cHhe4oGvv9xN2ZDzn7IWu0NGLngM90=; b=hpk7Du/oGM/6BqDYSEcom4/5BHaLkkh/PbgHuXq9F9R6wcskM2TC02pn7Gqalhn8J/ keKHRi1Fe50lMtW4KbvuXpsrndv2LFO7jbBmft+kVuM0ieNeay5JcP7fMP+9AXGXeXRs N5wFPJUMvgPFJXvcI91cnJJhei2pPTxhTGOQZ7RK6zg4M5AtRRGOWGbPMaC7crHZu1Tl 56abpxg2glBltvlEjtNDOsY5jssSN8pmNwg1KgdkuOHK3BohX4ou4NzKXyPHUYm0Yi0K 2/DHH8bwjGhtXbnRpo56aArTXTmtqIZldLOXjYWUCnujweo2zl35u72YUdU3YQS8XoHJ hm9w== X-Gm-Message-State: AOAM533h4W+DMDAdOyhQyMC7hNJpnye8791stIbAh20FXKQIOi3uO81x RXQbnh+rpCf9ZwkniCsYzLuHzA== X-Google-Smtp-Source: ABdhPJxkrFhbMOxpEFlvwlI61CdCcGTb2RM1bzUiLziBTpCekYswKA7OwjDozO25mAUrHiZmJNolVA== X-Received: by 2002:a5d:5651:: with SMTP id j17mr55771132wrw.145.1594209775563; Wed, 08 Jul 2020 05:02:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:54 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke , "Daniel M. Eischen" , Doug Ledford Subject: [PATCH 21/30] scsi: aic7xxx: aic7xxx_osm: Remove unused variable 'targ' Date: Wed, 8 Jul 2020 13:02:12 +0100 Message-Id: <20200708120221.3386672-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Looks like checking the 'targ' was removed in 2005. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’: drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but not used [-Wunused-but-set-variable] 1604 | struct ahc_linux_target *targ; | ^~~~ Cc: Hannes Reinecke Cc: "Daniel M. Eischen" Cc: Doug Ledford Signed-off-by: Lee Jones --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index cc4c7b1781466..ed437c16de881 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -1592,7 +1592,6 @@ ahc_send_async(struct ahc_softc *ahc, char channel, case AC_TRANSFER_NEG: { struct scsi_target *starget; - struct ahc_linux_target *targ; struct ahc_initiator_tinfo *tinfo; struct ahc_tmode_tstate *tstate; int target_offset; @@ -1626,7 +1625,6 @@ ahc_send_async(struct ahc_softc *ahc, char channel, starget = ahc->platform_data->starget[target_offset]; if (starget == NULL) break; - targ = scsi_transport_target_data(starget); target_ppr_options = (spi_dt(starget) ? MSG_EXT_PPR_DT_REQ : 0) From patchwork Wed Jul 8 12:02:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651473 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D809260D for ; Wed, 8 Jul 2020 12:03:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD32120775 for ; Wed, 8 Jul 2020 12:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q6uRu82j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbgGHMDr (ORCPT ); Wed, 8 Jul 2020 08:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729166AbgGHMC7 (ORCPT ); Wed, 8 Jul 2020 08:02:59 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405CCC08C5DC for ; Wed, 8 Jul 2020 05:02:58 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z15so37394720wrl.8 for ; Wed, 08 Jul 2020 05:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KFOnaZnxegDwLsJeWEMPqv4RGP3pzEUK9a4hgTT6mu8=; b=Q6uRu82jwSDeZ78JavUIgd2woRyBNcxJuhMq+FRLmC3XTYtoWv+51cU6IeO/mNUdBu oKgCZ+rrLCMxezQIxG4UkdQhPcRLfn549EONuRgoAqwxU2Lr2a3vvV3TwUJHWUimlYtQ Fo5TCNuXA+/fUYM1MYkQP7cbji9F6ZST/COLXUwJVI9oju8J31nfBlVBJVPFZlYaNSMw A0LRs9ID71Nuel55W0lc00rmDTKP7lQ7ohQVnrAOTlegM+uNCUKGrO+mWYXiSxuSWKCf 5WeM7YG4vhzx7sfpYTrjL9cO9SNUxp5e4Yxzm44x6dYu5+HdWRTL0NztnI9axDpXk4HM ibvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KFOnaZnxegDwLsJeWEMPqv4RGP3pzEUK9a4hgTT6mu8=; b=grDOxt5eLrx+dIfCMqNa/YmTPd5fX6bCUUN9Fv8ty5CPhD4aKlA0ogT4wax4vTTAwq 25YEvz/VhNkipDmJh9sWGhw55hA0U4ev41I5ONy2pFBBH0sws14iyeKkPz1ACUwDKxyw hLStt08Z1oEVyqUMhHm+KTIz7JB/UD9IdJ7xB4PcujI5KwHW9YKJpXB+Aj6bjjcpbESP P+aAz0gkecvRjgMS3i7LY0epq6jGFUWsAlg2JbARHs1a1+jxiOqJjZQ+BYPL9zHC2jjl dxyiOF6UfOyYXDOi+e+UErUqxlbA7oJYiX8iFPMMgPTjNxpeWXV9cIZ+owoSClLTUhss XtdA== X-Gm-Message-State: AOAM533g9H6ER1erKBRyBh3+vR20gnmO+DTzO2li8egwLWfs6mKPtVaW cLuPDw9ryrcxUkQ0T418c4lU1w== X-Google-Smtp-Source: ABdhPJw1vOTmcjZYF+x8I6snBJawVy908WIGOwoyXCv+bit3rfF8pDZRl4HJ6NWGVrs1Yb9JL2hEoQ== X-Received: by 2002:a05:6000:111:: with SMTP id o17mr61713548wrx.178.1594209776960; Wed, 08 Jul 2020 05:02:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:56 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Hannes Reinecke , "Daniel M. Eischen" , Doug Ledford Subject: [PATCH 22/30] scsi: aic7xxx: aic7xxx_osm: Fix 'amount_xferred' set but not used issue Date: Wed, 8 Jul 2020 13:02:13 +0100 Message-Id: <20200708120221.3386672-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org 'amount_xferred' is used, but only in certain circumstances. Place the same stipulations on the defining/allocating of 'amount_xferred' as is placed when using it. We've been careful not to change any of the ordering semantics here. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_done’: drivers/scsi/aic7xxx/aic7xxx_osm.c:1725:12: warning: variable ‘amount_xferred’ set but not used [-Wunused-but-set-variable] 1725 | uint32_t amount_xferred; | ^~~~~~~~~~~~~~ Cc: Hannes Reinecke Cc: "Daniel M. Eischen" Cc: Doug Ledford Signed-off-by: Lee Jones --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index ed437c16de881..e7ccb8b80fc19 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -1711,10 +1711,12 @@ ahc_done(struct ahc_softc *ahc, struct scb *scb) */ cmd->sense_buffer[0] = 0; if (ahc_get_transaction_status(scb) == CAM_REQ_INPROG) { +#ifdef AHC_REPORT_UNDERFLOWS uint32_t amount_xferred; amount_xferred = ahc_get_transfer_length(scb) - ahc_get_residual(scb); +#endif if ((scb->flags & SCB_TRANSMISSION_ERROR) != 0) { #ifdef AHC_DEBUG if ((ahc_debug & AHC_SHOW_MISC) != 0) { From patchwork Wed Jul 8 12:02:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651469 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D6B660D for ; Wed, 8 Jul 2020 12:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7259920772 for ; Wed, 8 Jul 2020 12:03:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fMHkSCgx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729180AbgGHMDB (ORCPT ); Wed, 8 Jul 2020 08:03:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729175AbgGHMC7 (ORCPT ); Wed, 8 Jul 2020 08:02:59 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F7BDC08E81E for ; Wed, 8 Jul 2020 05:02:59 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k6so48695772wrn.3 for ; Wed, 08 Jul 2020 05:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hh5XWPq04WZIcyTw2TRmdhHW7NgKe3Z7t0gHGNMmsgU=; b=fMHkSCgxQ7hkuTaPlS/0D/KZJXqyBjHse5sLtImExlRx9Oy4hwhjNM+Ddp/0FTKdIc x6vWyX9nuSVFdk61OuqRqpUT5TQplqlJBM4lD/BJUXURVh6Sv9HGEI8DCLo1rPS/nigH pfU08yofXgOMQdbqj5htuW7eO3ZZt4PCiBQZlpp6lLEpFsuoOPIQcdy88/eSCUBMO0Lc ZbwtJ5VOukEyfhnz/4sULiAJJnoqbLo1pk/RiL7xG3OwrycGEaxmxsB5lQn+gVy8kWW9 RLap/i3pUfK5jYxp7RjQtMDgV9wLzL3ny13wl1ObZUE6u7VWF36yNSnX+o/wi3dDvoM0 Rszg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hh5XWPq04WZIcyTw2TRmdhHW7NgKe3Z7t0gHGNMmsgU=; b=E/H4hPS7WeScpiR+MD06nS4RS0t+L/+AyRENXo1ncDs1IGjg0FyRAu9QE2o9M34Tfr cIYVN0yXAkBgFzYE39vyGn2dCDJ/QaevJn/z20OBiDAfPTpeg2O0A0T1oeIDqIB81YRj ke4PfoN4N32AWuIN5ppAoXtwBZcEC84ZBLixXC8wrm+wvpOdS7Iv8c1jfIQCBFGy+oMc MnnfJQQ1uYXiefTRYXTKiRxmMmaupip2ataCPndQew3HzCd1jji+ZmOCf3WdUo+Eh5Bj Q1/b1oRlnSsZLK/n9zbzHpp6QrNXQEj9CMXMWsd2oQY96P8xhRxhVLtZvCszdq5HJyLm vBvA== X-Gm-Message-State: AOAM530hYGT1OL6yhe4RA5bOCSPjnAYd4SaJeVQj4tJdmcirNI8YZMk4 F8o7RU/yBYHMo79WmIudekZznA== X-Google-Smtp-Source: ABdhPJxJEBS1dYfw5wGdrR6htHKpeIzczomGy3iuyGyh+g0AUlw04I6l/CsnT5O7u4aEH6AxSwnX7Q== X-Received: by 2002:a5d:540d:: with SMTP id g13mr54127802wrv.380.1594209778177; Wed, 08 Jul 2020 05:02:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:57 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 23/30] scsi: qedf: qedf_debugfs: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 8 Jul 2020 13:02:14 +0100 Message-Id: <20200708120221.3386672-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedf/qedf_debugfs.c:25: warning: Function parameter or member 'qedf' not described in 'qedf_dbg_host_init' drivers/scsi/qedf/qedf_debugfs.c:25: warning: Function parameter or member 'dops' not described in 'qedf_dbg_host_init' drivers/scsi/qedf/qedf_debugfs.c:25: warning: Function parameter or member 'fops' not described in 'qedf_dbg_host_init' drivers/scsi/qedf/qedf_debugfs.c:25: warning: Excess function parameter 'pf' description in 'qedf_dbg_host_init' drivers/scsi/qedf/qedf_debugfs.c:51: warning: Function parameter or member 'qedf_dbg' not described in 'qedf_dbg_host_exit' drivers/scsi/qedf/qedf_debugfs.c:51: warning: Excess function parameter 'pf' description in 'qedf_dbg_host_exit' drivers/scsi/qedf/qedf_debugfs.c:64: warning: Function parameter or member 'drv_name' not described in 'qedf_dbg_init' Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedf/qedf_debugfs.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/qedf/qedf_debugfs.c b/drivers/scsi/qedf/qedf_debugfs.c index b88bed9bb1338..a3ed681c8ce3f 100644 --- a/drivers/scsi/qedf/qedf_debugfs.c +++ b/drivers/scsi/qedf/qedf_debugfs.c @@ -14,10 +14,9 @@ static struct dentry *qedf_dbg_root; -/** +/* * qedf_dbg_host_init - setup the debugfs file for the pf - * @pf: the pf that is starting up - **/ + */ void qedf_dbg_host_init(struct qedf_dbg_ctx *qedf, const struct qedf_debugfs_ops *dops, @@ -42,10 +41,9 @@ qedf_dbg_host_init(struct qedf_dbg_ctx *qedf, } } -/** +/* * qedf_dbg_host_exit - clear out the pf's debugfs entries - * @pf: the pf that is stopping - **/ + */ void qedf_dbg_host_exit(struct qedf_dbg_ctx *qedf_dbg) { @@ -56,9 +54,9 @@ qedf_dbg_host_exit(struct qedf_dbg_ctx *qedf_dbg) qedf_dbg->bdf_dentry = NULL; } -/** +/* * qedf_dbg_init - start up debugfs for the driver - **/ + */ void qedf_dbg_init(char *drv_name) { @@ -68,9 +66,9 @@ qedf_dbg_init(char *drv_name) qedf_dbg_root = debugfs_create_dir(drv_name, NULL); } -/** +/* * qedf_dbg_exit - clean out the driver's debugfs entries - **/ + */ void qedf_dbg_exit(void) { From patchwork Wed Jul 8 12:02:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651455 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 846E160D for ; Wed, 8 Jul 2020 12:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A6A22089D for ; Wed, 8 Jul 2020 12:03:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V7YTg/Nu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728765AbgGHMDD (ORCPT ); Wed, 8 Jul 2020 08:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729186AbgGHMDC (ORCPT ); Wed, 8 Jul 2020 08:03:02 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE32BC08C5DC for ; Wed, 8 Jul 2020 05:03:01 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so48661608wrs.11 for ; Wed, 08 Jul 2020 05:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=V7YTg/NuT1ipSiphL7EvNRuTDaXv8eq0KaXXKKSKjl/mC+jCiU36KNbNpr6xipISRd qWZWOid3XF/HdL7CtyOkvOVNsRM4xkEX+fjQAovODTP/W0CIuJkkHlFIFykYxRI9Qvo2 qE8RJ0nwah9EwAlJFf+GPBkJRk63xtzmgOt4P6iT0iahUYwp1gIlsl3MCWmaGO79N5bN y1DSQnGFHBZLQ2sIPBPi+E2ieP2vvs1eA/maPioucGFRuBDhYQtQrlppYxc8xu68qIFj L6IHtoeUfefWuAax+TghGhwH9LCZf0l5eps2R/cZBZljKcjvX9KvozXCeIy4iILmYgId Awwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EfL+TnTwzrxBs3OWsbVJ1u2HNp81yr5D58y8jJwfHCg=; b=ttdWFeYFyowELllEhCsPZPhIc59onOzglgcrRsmt2mfV2UTdsXCmJO/N5GKUT2RNcG odaNWsjId2YaGkiloN511ZfIJpPeCzV5iacgx/cezH7ej0Iaf5TJ6a8BBcPt9ENFbcjm dzrxgRcQYuTx/WI+Th9BXVq1EozetwUJSRj2QNn+hsulfG88ROQYJUw1ydaZSmDwPg3h QX5xXGH4KS62pCUvRrLqZXNVbUjgoNbn9DKUftZwwoGywFyvStSFy3fbDzwo3SNl9tj2 udhIHSrrORjF/J7a0Q0EFQ8UOf3L77XqR5ciE5tj6LTVhImyOcC5wHlJ5z7XYg4HuGN5 rdDA== X-Gm-Message-State: AOAM5339/Ew6yc/W322ama1sLbCdR2ZC1lHIGHBFZrHDg2aTJzt3zJdn phywiXUyzAKaOuEtf5PkOO9Jdg== X-Google-Smtp-Source: ABdhPJwDfd21b5LkVyddx+3HtwmIG7Pf/brq+tML6qftxXPRLFkk5Zh6X+F0E5Q2tUlt/E8YIAo/KQ== X-Received: by 2002:a5d:5549:: with SMTP id g9mr61834625wrw.419.1594209780204; Wed, 08 Jul 2020 05:03:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:02:59 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH 24/30] scsi: aacraid: linit: Provide suggested curly braces around empty body of if() Date: Wed, 8 Jul 2020 13:02:15 +0100 Message-Id: <20200708120221.3386672-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 368 | param->heads, param->sectors, num)); | ^ Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/linit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index a308e86a97f19..734dd6e67246d 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -363,9 +363,10 @@ static int aac_biosparm(struct scsi_device *sdev, struct block_device *bdev, param->cylinders = cap_to_cyls(capacity, param->heads * param->sectors); if (num < 4 && end_sec == param->sectors) { - if (param->cylinders != saved_cylinders) + if (param->cylinders != saved_cylinders) { dprintk((KERN_DEBUG "Adopting geometry: heads=%d, sectors=%d from partition table %d.\n", param->heads, param->sectors, num)); + } } else if (end_head > 0 || end_sec > 0) { dprintk((KERN_DEBUG "Strange geometry: heads=%d, sectors=%d in partition table %d.\n", end_head + 1, end_sec, num)); From patchwork Wed Jul 8 12:02:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74C2D913 for ; Wed, 8 Jul 2020 12:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CE212078A for ; Wed, 8 Jul 2020 12:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HcEJA8WD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbgGHMDG (ORCPT ); Wed, 8 Jul 2020 08:03:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729199AbgGHMDF (ORCPT ); Wed, 8 Jul 2020 08:03:05 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32024C08E6DC for ; Wed, 8 Jul 2020 05:03:04 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s10so48634748wrw.12 for ; Wed, 08 Jul 2020 05:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oQ4WvRwPDFUcNrh06O2K9jOUxxfeZulaKjQ0ybDc5os=; b=HcEJA8WDl4WeJ2vXIx9y7tBCth1cotVU/SGVBEDKeoxBy/vHIVkUEVxUdRO0FHSzuR ibKIsFFbEhwKcXgsnSy5GbgBrKsb3JMgHrxW2eiAPh28qoXxbmBoNF6JAP3Qe3fZLW2c XSEoh/x0mVS5KNb/8Lu7uVYR8fx3X1830tDuS+dj0Tn7BXba7wJhtiX2qIyLLFZR3dwd /BBfXElqsVR1A/f5KJTzaJJE3SvCKvuYKRf/p58LaYkTV6MrdtawQiS6bgqW30VLM2Gt unrA4NE6cx7pEQkdDtUkkOSQVeJNjKUhnp20MnowWCLVVKURPzHppVzG1gQfciGp+VhC +l5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oQ4WvRwPDFUcNrh06O2K9jOUxxfeZulaKjQ0ybDc5os=; b=Q9saBBN+v/4GGtezrF1hjSy2sbgybyIHm8STdoNomIctSRpnAhUehFnONM+D4UQA1/ 15AB8dRLvmelqrCCkBHCqTVdAqvn4o1QlOfabKJPMdxW7Ozdq4TJjLfJKYeg2IUNrg0y DiYa73C6HXzVX9StR/nNjXBUYFw1P2ZDV5iiqWGdAiY4SegYUGCBu5jXOtVsXk8akOrz zDBiudGRjAunkzdc7BRKEy2OlYlLlk0IkIBNxV/I8JBVaVxPRe1uqfmnpN+667dPPrNU NJSbgARC9EjXU0ujGSi5FABjqb0unllZ3/PX4p7rqckTn6P0pfk5S+28oEedrP29Dndq eaNA== X-Gm-Message-State: AOAM531uxFt7oBb4DkwbQ45p1+Nh/C0oIbUAQcgPgf8SsrZoTVx2cb9X 4b/9YnP3PIbN/VkzJ2PzznmksQ== X-Google-Smtp-Source: ABdhPJwVLbtlb7LCz9yj2ORin0ecR6yZcKzsnIjqiqxEm/K74D5PXILyHP5nAyq2AdzFCvfsEY1XSA== X-Received: by 2002:adf:82e1:: with SMTP id 88mr37664379wrc.376.1594209782309; Wed, 08 Jul 2020 05:03:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:00 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH 25/30] scsi: aacraid: linit: Fix a couple of small kerneldoc issues Date: Wed, 8 Jul 2020 13:02:16 +0100 Message-Id: <20200708120221.3386672-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Most likely caused by bitrot (docs not keeping in sync with API). Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’: drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] drivers/scsi/aacraid/linit.c:243: warning: Function parameter or member 'shost' not described in 'aac_queuecommand' drivers/scsi/aacraid/linit.c:243: warning: Excess function parameter 'done' description in 'aac_queuecommand' drivers/scsi/aacraid/linit.c:1176: warning: Excess function parameter 'inode' description in 'aac_cfg_ioctl' Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/linit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 734dd6e67246d..f043e378652c1 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -230,8 +230,8 @@ static struct aac_driver_ident aac_drivers[] = { /** * aac_queuecommand - queue a SCSI command + * @shost: Scsi host to queue command on * @cmd: SCSI command to queue - * @done: Function to call on command completion * * Queues a command for execution by the associated Host Adapter. * @@ -1160,7 +1160,6 @@ static int aac_cfg_open(struct inode *inode, struct file *file) /** * aac_cfg_ioctl - AAC configuration request - * @inode: inode of device * @file: file handle * @cmd: ioctl command code * @arg: argument From patchwork Wed Jul 8 12:02:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0173313B6 for ; Wed, 8 Jul 2020 12:03:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD20E20775 for ; Wed, 8 Jul 2020 12:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BQfkrIML" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728876AbgGHMD0 (ORCPT ); Wed, 8 Jul 2020 08:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729205AbgGHMDG (ORCPT ); Wed, 8 Jul 2020 08:03:06 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB89EC08C5DC for ; Wed, 8 Jul 2020 05:03:05 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g75so2705505wme.5 for ; Wed, 08 Jul 2020 05:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ERoz3fkdfBzQNDlM4+cYEX1ahP8otbMKTg0c52YoDQM=; b=BQfkrIMLhcq2bpyg8GI9z9uvky9LxtnORcYZhT+HkKw3ytxk/0Ay4nbGD7kwBmp1o6 N3fxA9DiSNExlEt2oSAxsnQiJkkxThmoA6m7fFYCEu4hI3GrEo8XPwyw/a1Se1oHPz7B eHmAxZnQvSXjYkWZ8xLqfBCeE0BYZTDzM/wnaRamU/If4Or6GkR+V+kR2lznDPNqvYPW 91Tyg4okajt6CHPVTLyJ5mjmPV0YNdivt77C2OUVYNqZy6H0sBNFZCVbOOfzq0uwO3o/ JTK4tmuz2+WFCkAg3US1BBmXBHYNTM59CcMm+uKePPWUBkA1L9RL0UbMTvL0AHRda0FL qhpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ERoz3fkdfBzQNDlM4+cYEX1ahP8otbMKTg0c52YoDQM=; b=FOWH0ARK1IYNOeYIkAUNN6XJ/FA5o09ZNB7zYmsT8eFCxJ80sBXxvwrCebyBmRGoic tfpmswzhHeKb4VnivjzclaAoIZa/+19/qc3LBC0zNm86XrEorVarr6vifpUQDuvKvMB9 8SFC6I659vgMGJOIl+KFHGFOS3l16pHP8uQVapiBAj1bLhpjELlEA2sgLK0xiNHMukaI dVp12CQ+Bci6frC6dY8rFMnIeZpVyn2pmbmkuL9u6CVIYuyWpC9tHPNQqiDUMmhIPWU6 7h1oBWH9Gs7ChpNH/5qNhB+yD2FS5wqAsF7RkU9tIJyR+oFCWOFFltJxmoziP/PsqOcV egdA== X-Gm-Message-State: AOAM531D3dHws8I7CGQ5ULptn2Pa2WAmqGRGWW7rTUoyboLF01ehJqAR g4stWG5DsB+2WnPukUZrcuM4bg== X-Google-Smtp-Source: ABdhPJzT8YdDaUodEHbCCXJeTOYOV4BqAXnxN0Y2LVKcQ+xGvSsmtq2rXCJSexfhZNek8Wi4fPWdBg== X-Received: by 2002:a1c:4d04:: with SMTP id o4mr8741190wmh.132.1594209784342; Wed, 08 Jul 2020 05:03:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:03 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , YueHaibing , Luben Tuikov Subject: [PATCH 26/30] scsi: aic94xx: aic94xx_init: Demote seemingly unintentional kerneldoc header Date: Wed, 8 Jul 2020 13:02:17 +0100 Message-Id: <20200708120221.3386672-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_init.c:538: warning: Function parameter or member 'asd_ha' not described in 'asd_free_edbs' Cc: YueHaibing Cc: Luben Tuikov Signed-off-by: Lee Jones --- drivers/scsi/aic94xx/aic94xx_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index bef47f38dd0db..a195bfe9eccc0 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -530,7 +530,7 @@ static int asd_create_ha_caches(struct asd_ha_struct *asd_ha) return 0; } -/** +/* * asd_free_edbs -- free empty data buffers * asd_ha: pointer to host adapter structure */ From patchwork Wed Jul 8 12:02:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651463 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD59460D for ; Wed, 8 Jul 2020 12:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABFC52084C for ; Wed, 8 Jul 2020 12:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LdN2LCty" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgGHMDJ (ORCPT ); Wed, 8 Jul 2020 08:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbgGHMDH (ORCPT ); Wed, 8 Jul 2020 08:03:07 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C52C08E763 for ; Wed, 8 Jul 2020 05:03:06 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f18so40612825wrs.0 for ; Wed, 08 Jul 2020 05:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3n7m55npDtDZS6ysg5UOur5QEJUSKE4xUdCSnXfF9I=; b=LdN2LCtyGTzzQ+qlGdQvFqe+2zPotqSI9Imp8iDHZFNi/oyIhiVCezyF+yih5fiXay A/klLsVhEKRZbPDNWDywrbfBE8CDLi8fS9P6dR0aWlzRH/cNKr7H+KHD1kUGKWCAddpL EUNPqMf0EjIpSibosimkcdqLLGZKRN43OMT3YASWzcZ6aXGL5MG8yxS+fcn5TjBTgvf/ VLs7o/Nc9WIz8moWJMc9F2QkEp5/JrWr2Tt48FvzDgduRMy3rSQZoqr5rlYAbqVGKLb9 YcOEnf0YWXK1q8a3jhwdBcGl8/3ghj0+j90TDSbUxnuzoj1VZlfOsxeXfn1RuJKIL4in 8QRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g3n7m55npDtDZS6ysg5UOur5QEJUSKE4xUdCSnXfF9I=; b=Rht9qbiXE3xWGyOY3zBK5VPqUeNZOr6uCwmEGpDzzEBk/UG6bUKdRD08n+ALy8XRcN amvyiHacpWatO4tbTEHYivgAoYJu1X7juFXYDVvYmjT71lq+JVM7ojlzkoHjt7e3AqQ2 hm6+hhnNM/K0jpoGlqeL2FmJehu34DikNlFbwNCKnGF1hdD/0SrVgZBx/WoIgt8fp92K PEvYZOtHXCqEk+Xp5gKYzZkCinigembJ15M+mBn+Oe9ZdoT/o+/ttWDmFtDfNxXLnk80 7V97ziaA1q/X3Pme6q6PW7WUSoesbXWuHaxiuNpemIDtOED1qtPfSJAjoVm4eEdSvmzb ahiw== X-Gm-Message-State: AOAM53157mSJczctADwOzNcHiAbSJJE/in4oQBcly536oup/ya2EeSi8 2AW5WMfvIZEE9ODmLMEbVsz5xA== X-Google-Smtp-Source: ABdhPJyJeKaM/57Fr+Eq5QRy28Y3Git8JNtamFxzD6xH0ADsZksp3OmxVWOkjxgbV0mq32FaBVDgKA== X-Received: by 2002:adf:e948:: with SMTP id m8mr59729897wrn.398.1594209785629; Wed, 08 Jul 2020 05:03:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:04 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Jack Wang , Kumar Santhanam , Sangeetha Gnanasekaran , Nikith Ganigarakoppal Subject: [PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others Date: Wed, 8 Jul 2020 13:02:18 +0100 Message-Id: <20200708120221.3386672-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org More bitrot issues with function documentation not keeping up with API changes. Fixes the following W=1 kernel build warning(s): drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function prototype: 'const struct pm8001_chip_info pm8001_chips[] = ' drivers/scsi/pm8001/pm8001_init.c:86: warning: cannot understand function prototype: 'struct scsi_host_template pm8001_sht = ' drivers/scsi/pm8001/pm8001_init.c:115: warning: cannot understand function prototype: 'struct sas_domain_function_template pm8001_transport_ops = ' drivers/scsi/pm8001/pm8001_init.c:212: warning: Function parameter or member 'irq' not described in 'pm8001_interrupt_handler_msix' drivers/scsi/pm8001/pm8001_init.c:237: warning: Function parameter or member 'irq' not described in 'pm8001_interrupt_handler_intx' drivers/scsi/pm8001/pm8001_init.c:265: warning: Function parameter or member 'ent' not described in 'pm8001_alloc' drivers/scsi/pm8001/pm8001_init.c:624: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_init_sas_add' drivers/scsi/pm8001/pm8001_init.c:624: warning: Excess function parameter 'chip_info' description in 'pm8001_init_sas_add' drivers/scsi/pm8001/pm8001_init.c:900: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_setup_msix' drivers/scsi/pm8001/pm8001_init.c:900: warning: Excess function parameter 'chip_info' description in 'pm8001_setup_msix' drivers/scsi/pm8001/pm8001_init.c:900: warning: Excess function parameter 'irq_handler' description in 'pm8001_setup_msix' drivers/scsi/pm8001/pm8001_init.c:981: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_request_irq' drivers/scsi/pm8001/pm8001_init.c:981: warning: Excess function parameter 'chip_info' description in 'pm8001_request_irq' Cc: Jack Wang Cc: Kumar Santhanam Cc: Sangeetha Gnanasekaran Cc: Nikith Ganigarakoppal Signed-off-by: Lee Jones Acked-by: Jack Wang --- drivers/scsi/pm8001/pm8001_init.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 9e99262a2b9dd..20fa96cbc9d3d 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -57,7 +57,7 @@ MODULE_PARM_DESC(link_rate, "Enable link rate.\n" static struct scsi_transport_template *pm8001_stt; -/** +/* * chip info structure to identify chip key functionality as * encryption available/not, no of ports, hw specific function ref */ @@ -80,7 +80,7 @@ LIST_HEAD(hba_list); struct workqueue_struct *pm8001_wq; -/** +/* * The main structure which LLDD must register for scsi core. */ static struct scsi_host_template pm8001_sht = { @@ -109,7 +109,7 @@ static struct scsi_host_template pm8001_sht = { .track_queue_depth = 1, }; -/** +/* * Sas layer call this function to execute specific task. */ static struct sas_domain_function_template pm8001_transport_ops = { @@ -129,9 +129,9 @@ static struct sas_domain_function_template pm8001_transport_ops = { }; /** - *pm8001_phy_init - initiate our adapter phys - *@pm8001_ha: our hba structure. - *@phy_id: phy id. + * pm8001_phy_init - initiate our adapter phys + * @pm8001_ha: our hba structure. + * @phy_id: phy id. */ static void pm8001_phy_init(struct pm8001_hba_info *pm8001_ha, int phy_id) { @@ -155,9 +155,8 @@ static void pm8001_phy_init(struct pm8001_hba_info *pm8001_ha, int phy_id) } /** - *pm8001_free - free hba - *@pm8001_ha: our hba structure. - * + * pm8001_free - free hba + * @pm8001_ha: our hba structure. */ static void pm8001_free(struct pm8001_hba_info *pm8001_ha) { @@ -205,6 +204,7 @@ static void pm8001_tasklet(unsigned long opaque) * pm8001_interrupt_handler_msix - main MSIX interrupt handler. * It obtains the vector number and calls the equivalent bottom * half or services directly. + * @irq: interrupt number * @opaque: the passed outbound queue/vector. Host structure is * retrieved from the same. */ @@ -230,6 +230,7 @@ static irqreturn_t pm8001_interrupt_handler_msix(int irq, void *opaque) /** * pm8001_interrupt_handler_intx - main INTx interrupt handler. + * @irq: interrupt number * @dev_id: sas_ha structure. The HBA is retrieved from sas_has structure. */ @@ -257,8 +258,8 @@ static u32 pm8001_request_irq(struct pm8001_hba_info *pm8001_ha); /** * pm8001_alloc - initiate our hba structure and 6 DMAs area. - * @pm8001_ha:our hba structure. - * + * @pm8001_ha: our hba structure. + * @ent: PCI device ID structure to match on */ static int pm8001_alloc(struct pm8001_hba_info *pm8001_ha, const struct pci_device_id *ent) @@ -615,7 +616,7 @@ static void pm8001_post_sas_ha_init(struct Scsi_Host *shost, /** * pm8001_init_sas_add - initialize sas address - * @chip_info: our ha struct. + * @pm8001_ha: our ha struct. * * Currently we just set the fixed SAS address to our HBA,for manufacture, * it should read from the EEPROM @@ -893,8 +894,7 @@ static int pm8001_configure_phy_settings(struct pm8001_hba_info *pm8001_ha) #ifdef PM8001_USE_MSIX /** * pm8001_setup_msix - enable MSI-X interrupt - * @chip_info: our ha struct. - * @irq_handler: irq_handler + * @pm8001_ha: our ha struct. */ static u32 pm8001_setup_msix(struct pm8001_hba_info *pm8001_ha) { @@ -975,7 +975,7 @@ static u32 pm8001_setup_irq(struct pm8001_hba_info *pm8001_ha) /** * pm8001_request_irq - register interrupt - * @chip_info: our ha struct. + * @pm8001_ha: our ha struct. */ static u32 pm8001_request_irq(struct pm8001_hba_info *pm8001_ha) { From patchwork Wed Jul 8 12:02:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651459 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8269660D for ; Wed, 8 Jul 2020 12:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AD972083B for ; Wed, 8 Jul 2020 12:03:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DnDSJDuY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729237AbgGHMDM (ORCPT ); Wed, 8 Jul 2020 08:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbgGHMDJ (ORCPT ); Wed, 8 Jul 2020 08:03:09 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74A03C08E6DC for ; Wed, 8 Jul 2020 05:03:08 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id a6so3832839wmm.0 for ; Wed, 08 Jul 2020 05:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3sXxKpQgrnotRyFJvyRPk0Xs+GRdftij+k/kTivXzV0=; b=DnDSJDuY3iQMxIY3ZoXbR8gf2IDWmP9iuqtYX0Ro69doTFbs451srECIXBPTjM4vRz jfzGby1S7dLMvMBAV1tEfIcXHUto6nk5UArtEQldbva/5wZ/W7Qg/XEAFwNRK3hOpAoZ 3bNNuFcPStvvmPlkIAp7LDc736Q2vFJGwqmL+1McUykrXjme+1OR1unCiC5E4bexWf6U CJN9j47LLuj1u2A/xcgmsifxrce1xQ6FOAXwsDtAYqT8gcPkG2RCYLBwt+8SRs9vpJcy wz1sP2yu+ba9bZkAjpDXwqyub4JAWZHdphP3daDLoor9sd1y2dhB3caU9iuP4FkHZxv1 LHWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3sXxKpQgrnotRyFJvyRPk0Xs+GRdftij+k/kTivXzV0=; b=uDY1QYiGExlqmLN0+rDIVao4Gt24zgxzfYw0KBfuCauna7krtRZRINp527ONUBlBOK /9WKsbbFxA0FWn9FVTAvswgxL+xsX0liiXlysHLG2HvzOQnzXFFxxwUQXZ4pglvH2XoN JuMMmi6XOo3794o0yU57arCD5rjJrv62jWzcSZigWDfBqxSZOYK6RZhF6kO7Y0k37yep /CT727ovxQAqQ0FCJ/sRjbxt+7rRZF9Xb4HML6sLS5tdMO0OGrEglcrcePvp3MZdDOS8 AXZBJ0OyFIbtu17yqvCs3o1XcdCplPklBbZfQfhUsQ64qETw+/bfSd7+ZgOj+MIgIfpk BSCw== X-Gm-Message-State: AOAM530hjSbNPSuMZ8jiJ/Tqld3R+NzeOIF/sDipMSCGzPm6Aow7M1K8 89ubk5CtSBoCMRmwQBqWxwDdyxkPBGw= X-Google-Smtp-Source: ABdhPJx/fai7U19D/GJCZpEsSrd9/JyRH2FHRiM3naVNNV8cPY0UhsCV5vBEpN4APbY6ozLX4DIqdA== X-Received: by 2002:a1c:2402:: with SMTP id k2mr9021990wmk.138.1594209786967; Wed, 08 Jul 2020 05:03:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:06 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Luben Tuikov Subject: [PATCH 28/30] scsi: aic94xx: aic94xx_hwi: Repair kerneldoc formatting error and remove extra param Date: Wed, 8 Jul 2020 13:02:19 +0100 Message-Id: <20200708120221.3386672-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Function parameters need to be documented with format '@.*: '. 'to' is not longer asd_start_timers()'s function parameter. Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_hwi.c:589: warning: Function parameter or member 'asd_ha' not described in 'asd_init_ctxmem' drivers/scsi/aic94xx/aic94xx_hwi.c:1157: warning: Excess function parameter 'to' description in 'asd_start_scb_timers' Cc: Luben Tuikov Signed-off-by: Lee Jones --- drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_hwi.c b/drivers/scsi/aic94xx/aic94xx_hwi.c index c5a46c59d4f80..9256ab7b25227 100644 --- a/drivers/scsi/aic94xx/aic94xx_hwi.c +++ b/drivers/scsi/aic94xx/aic94xx_hwi.c @@ -575,7 +575,7 @@ static int asd_extend_cmdctx(struct asd_ha_struct *asd_ha) /** * asd_init_ctxmem -- initialize context memory - * asd_ha: pointer to host adapter structure + * @asd_ha: pointer to host adapter structure * * This function sets the maximum number of SCBs and * DDBs which can be used by the sequencer. This is normally @@ -1146,7 +1146,6 @@ static void asd_swap_head_scb(struct asd_ha_struct *asd_ha, /** * asd_start_timers -- (add and) start timers of SCBs * @list: pointer to struct list_head of the scbs - * @to: timeout in jiffies * * If an SCB in the @list has no timer function, assign the default * one, then start the timer of the SCB. This function is From patchwork Wed Jul 8 12:02:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A6A7A60D for ; Wed, 8 Jul 2020 12:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 881A320772 for ; Wed, 8 Jul 2020 12:03:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yzdKPR8L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbgGHMDL (ORCPT ); Wed, 8 Jul 2020 08:03:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729230AbgGHMDK (ORCPT ); Wed, 8 Jul 2020 08:03:10 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B81F8C08C5DC for ; Wed, 8 Jul 2020 05:03:09 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g75so2705851wme.5 for ; Wed, 08 Jul 2020 05:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d7D7AfDQQG73fSw4f21gOz4vhVntWScnapCoKvjgVSM=; b=yzdKPR8LmjXafIM30grkb0E+LW79z46rqDXm9mEWI86cQMpo85admAyJckDe32ioy3 Y+/tQzNQW+VY1amhzFzVpMR7XyOYzzrKFTG/xS8UjMQ8crFfdCVlaTGUxw9Fbx9khpTW Cu6D4FUjxcj0ovqqy9n8v+274LaGFqN8iWjbMBXYsUgBAZ4otDdZ0gCGJFsFiItATOvW bvoCE4xtS+DO82Pzz15fBgxnG+wqQE3nlWVnhvSGdHLafONqrnn4pxfqv1LZHT84O/lp So9qQYGVA5Xf8pRvRF/gUz3BJxNWSi9GQFPbyzIhhC/X5X8AWUIuwGC7Vz+sWOcK0y4o qy1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d7D7AfDQQG73fSw4f21gOz4vhVntWScnapCoKvjgVSM=; b=K8Q46ASOuVpE76GjJ9y/4xiTICWIBbFOkGOoeK8sRaKTDvkXOZQVjT/PW21+w1+ScM nRvejsVGo3ZMsEuynXWuRHheD1J7w1k2r/lqirXsEhiK0YLOKZ7P3nOy8aLeAvj7eTAa n50hH9W0wk6qL6qkP9l9WdHLlh2lEM3KXa7Wltd0lJ88j9y57DbMVHhEY5tXolUImc0x gpb6oVWCdLlzp4nE7vuw2JGHe/sCXav1fmHmr5bn0GEQRfZSBESPrUTRbQcKPqty8x8n itA4pBVzqcnd6XfpHhoOybOvRvt/GkrRhFnJHKZ8Q8Xygc5DzQrGSlAZaYULKbyPvZTB D4DA== X-Gm-Message-State: AOAM532RhBLRtQdW+cno2+fQzotfLZSyubfJisDf574fCViqDh4BUV7F Lpnk7ZU8Yph3AMQFCBk3ngU9XA== X-Google-Smtp-Source: ABdhPJzdvUY503n425HeR/FqzogV0LWtQyotNCGukbYwNiIlFSv32ZgKGIiJMG2t9LP/0bHWyzltXg== X-Received: by 2002:a1c:7d56:: with SMTP id y83mr9527216wmc.154.1594209788425; Wed, 08 Jul 2020 05:03:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:07 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , "PMC-Sierra, Inc" Subject: [PATCH 29/30] scsi: aacraid: aachba: Fix a bunch of function doc formatting errors Date: Wed, 8 Jul 2020 13:02:20 +0100 Message-Id: <20200708120221.3386672-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org And a few missing/excessive parameter descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev' not described in 'aac_get_config_status' drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'commit_flag' not described in 'aac_get_config_status' drivers/scsi/aacraid/aachba.c:358: warning: Excess function parameter 'common' description in 'aac_get_config_status' drivers/scsi/aacraid/aachba.c:450: warning: Function parameter or member 'dev' not described in 'aac_get_containers' drivers/scsi/aacraid/aachba.c:450: warning: Excess function parameter 'common' description in 'aac_get_containers' drivers/scsi/aacraid/aachba.c:568: warning: Function parameter or member 'scsicmd' not described in 'aac_get_container_name' drivers/scsi/aacraid/aachba.c:796: warning: Function parameter or member 'scsicmd' not described in 'aac_probe_container_callback1' drivers/scsi/aacraid/aachba.c:796: warning: Excess function parameter 'dev' description in 'aac_probe_container_callback1' drivers/scsi/aacraid/aachba.c:796: warning: Excess function parameter 'cid' description in 'aac_probe_container_callback1' drivers/scsi/aacraid/aachba.c:1105: warning: Function parameter or member 'scsicmd' not described in 'aac_get_container_serial' drivers/scsi/aacraid/aachba.c:1961: warning: Excess function parameter 'phys_luns' description in 'aac_set_safw_attr_all_targets' drivers/scsi/aacraid/aachba.c:1961: warning: Excess function parameter 'rescan' description in 'aac_set_safw_attr_all_targets' drivers/scsi/aacraid/aachba.c:3394: warning: Cannot understand * on line 3394 - I thought it was a doc line drivers/scsi/aacraid/aachba.c:3687: warning: Cannot understand * on line 3687 - I thought it was a doc line drivers/scsi/aacraid/aachba.c:3752: warning: Cannot understand * on line 3752 - I thought it was a doc line drivers/scsi/aacraid/aachba.c:3795: warning: Cannot understand * on line 3795 - I thought it was a doc line Cc: Adaptec OEM Raid Solutions Cc: "PMC-Sierra, Inc" Signed-off-by: Lee Jones --- drivers/scsi/aacraid/aachba.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 2b868f8db8ffe..7ae1e545a255c 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -561,7 +561,7 @@ static void get_container_name_callback(void *context, struct fib * fibptr) scsicmd->scsi_done(scsicmd); } -/** +/* * aac_get_container_name - get container name, none blocking. */ static int aac_get_container_name(struct scsi_cmnd * scsicmd) @@ -786,8 +786,7 @@ static int _aac_probe_container(struct scsi_cmnd * scsicmd, int (*callback)(stru /** * aac_probe_container - query a logical volume - * @dev: device to query - * @cid: container identifier + * @scsicmd: the scsi command block * * Queries the controller about the given volume. The volume information * is updated in the struct fsa_dev_info structure rather than returned. @@ -1098,7 +1097,7 @@ static void get_container_serial_callback(void *context, struct fib * fibptr) scsicmd->scsi_done(scsicmd); } -/** +/* * aac_get_container_serial - get container serial, none blocking. */ static int aac_get_container_serial(struct scsi_cmnd * scsicmd) @@ -1952,8 +1951,6 @@ static int aac_get_safw_attr_all_targets(struct aac_dev *dev) /** * aac_set_safw_attr_all_targets- update current hba map with data from FW * @dev: aac_dev structure - * @phys_luns: FW information from report phys luns - * @rescan: Indicates scan type * * Update our hba map with the information gathered from the FW */ @@ -3391,15 +3388,12 @@ int aac_dev_ioctl(struct aac_dev *dev, unsigned int cmd, void __user *arg) } /** - * * aac_srb_callback * @context: the context set in the fib - here it is scsi cmd * @fibptr: pointer to the fib * * Handles the completion of a scsi command to a non dasd device - * */ - static void aac_srb_callback(void *context, struct fib * fibptr) { struct aac_srb_reply *srbreply; @@ -3684,13 +3678,11 @@ static void hba_resp_task_failure(struct aac_dev *dev, } /** - * * aac_hba_callback * @context: the context set in the fib - here it is scsi cmd * @fibptr: pointer to the fib * * Handles the completion of a native HBA scsi command - * */ void aac_hba_callback(void *context, struct fib *fibptr) { @@ -3749,14 +3741,12 @@ void aac_hba_callback(void *context, struct fib *fibptr) } /** - * * aac_send_srb_fib * @scsicmd: the scsi command block * * This routine will form a FIB and fill in the aac_srb from the * scsicmd passed in. */ - static int aac_send_srb_fib(struct scsi_cmnd* scsicmd) { struct fib* cmd_fibcontext; @@ -3792,7 +3782,6 @@ static int aac_send_srb_fib(struct scsi_cmnd* scsicmd) } /** - * * aac_send_hba_fib * @scsicmd: the scsi command block * From patchwork Wed Jul 8 12:02:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11651461 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9967C913 for ; Wed, 8 Jul 2020 12:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82A7F2083B for ; Wed, 8 Jul 2020 12:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n292cOlk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728848AbgGHMDU (ORCPT ); Wed, 8 Jul 2020 08:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729232AbgGHMDL (ORCPT ); Wed, 8 Jul 2020 08:03:11 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B505C08C5DC for ; Wed, 8 Jul 2020 05:03:11 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o8so2710386wmh.4 for ; Wed, 08 Jul 2020 05:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XQHRlmYiMy5z0WnxtNKRalmwQyJTVSmo3hN7/2Qvzas=; b=n292cOlkFOyUyQ8ZkW6XuDxtzEgcsyhqPXRt7/EPXsfkxxrObnUpsWEbLWdfZ8Eq6s P/lp8mGBvS46SbnST3odFaAF/4nxTUozIlvQvRrCISKPcSbf3EHcfXo3R0XZPFzKWE/M /RrB07MQODt05nVNPEhKIQRcU0rvw4VBjKaAiUpdwmUcpfHNL/LQP4J/VFqBS8UcbWoN g7QKzYhENoql15R1iKSDZIGmsP/8U05P5VOFN8YtkJTIByodKGe1GMjnqEfFCJb8khIC c2jBNUY588S31VNGlrlv95/LdNM8UZFuWKauPiMhIy84/UTVA0T055uCUGikYhYvvilL 4cOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XQHRlmYiMy5z0WnxtNKRalmwQyJTVSmo3hN7/2Qvzas=; b=auv6yTK8Dc0fGiEpKXdqjcNw5Uy/xq5pgPq9/Dmn3L9dsvkNYHb4MnVoavbGwDovAp aofVi4JzggCstDWIry724GvuToBztRRT84Dx+0+wISmrxaxJAMPxC5QAYougsPRfO+aO sRMeYZue+ilrnlpYWtr4GvZjOlfx0Vqoe0WiJJTJCtloOll8LUVPIjscJJeeOULBErn0 mZ9WW/qqUIh4R7RsKWszmvh/Tdb/ItJAtRTJ2vObodL0Z9mvUOExmt6n5HfTcKDRLDhK rSAHp+B5beo1Lu9cQlkuf3r+c2L2R9cKB2OgQewhD4Ry+R+u7RzKlZzxFxmY3Ycwg8Qy oFmw== X-Gm-Message-State: AOAM53129X2TqMJNWxltzbpz1dIEvDBZ4N9/3UfvdCeIW+VZlZkGQDRP NRQcXK7wkxb1KqDHPE2AXuPKUg== X-Google-Smtp-Source: ABdhPJywj779mVY5kkp6U1/q3t+6iH+w1ef8s3SruZgBMfwL4j+sJHFUFND72bQd7nKC092vdnHnHA== X-Received: by 2002:a1c:f219:: with SMTP id s25mr8709643wmc.2.1594209789802; Wed, 08 Jul 2020 05:03:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id m62sm3964997wmm.42.2020.07.08.05.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 05:03:08 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com Subject: [PATCH 30/30] scsi: qla4xxx: ql4_init: Provide a missing function param description and fix formatting Date: Wed, 8 Jul 2020 13:02:21 +0100 Message-Id: <20200708120221.3386672-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200708120221.3386672-1-lee.jones@linaro.org> References: <20200708120221.3386672-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Kerneldoc function parameter references need to be in the format '@.*: ', else the kerneldoc checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/scsi/qla4xxx/ql4_init.c: In function ‘ql4xxx_set_mac_number’: drivers/scsi/qla4xxx/ql4_init.c:17:10: warning: variable ‘func_number’ set but not used [-Wunused-but-set-variable] drivers/scsi/qla4xxx/ql4_init.c: In function ‘qla4xxx_pci_config’: drivers/scsi/qla4xxx/ql4_init.c:664:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] from drivers/scsi/qla4xxx/ql4_init.c:9: from drivers/scsi/qla4xxx/ql4_init.c:9: drivers/scsi/qla4xxx/ql4_init.c:953: warning: Function parameter or member 'is_reset' not described in 'qla4xxx_initialize_adapter' drivers/scsi/qla4xxx/ql4_init.c:1168: warning: Function parameter or member 'ha' not described in 'qla4xxx_process_ddb_changed' drivers/scsi/qla4xxx/ql4_init.c:1168: warning: Function parameter or member 'fw_ddb_index' not described in 'qla4xxx_process_ddb_changed' drivers/scsi/qla4xxx/ql4_init.c:1168: warning: Function parameter or member 'state' not described in 'qla4xxx_process_ddb_changed' drivers/scsi/qla4xxx/ql4_init.c:1168: warning: Function parameter or member 'conn_err' not described in 'qla4xxx_process_ddb_changed' Cc: QLogic-Storage-Upstream@qlogic.com Signed-off-by: Lee Jones --- drivers/scsi/qla4xxx/ql4_init.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index 2bf5e3e639e1a..5963127f7d2ef 100644 --- a/drivers/scsi/qla4xxx/ql4_init.c +++ b/drivers/scsi/qla4xxx/ql4_init.c @@ -945,6 +945,7 @@ void qla4xxx_free_ddb_index(struct scsi_qla_host *ha) /** * qla4xxx_initialize_adapter - initiailizes hba * @ha: Pointer to host adapter structure. + * @is_reset: Is this init path or reset path * * This routine parforms all of the steps necessary to initialize the adapter. * @@ -1156,9 +1157,9 @@ int qla4xxx_flash_ddb_change(struct scsi_qla_host *ha, uint32_t fw_ddb_index, /** * qla4xxx_process_ddb_changed - process ddb state change - * @ha - Pointer to host adapter structure. - * @fw_ddb_index - Firmware's device database index - * @state - Device state + * @ha: Pointer to host adapter structure. + * @fw_ddb_index: Firmware's device database index + * @state: Device state * * This routine processes a Decive Database Changed AEN Event. **/