From patchwork Tue Jul 14 11:15:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662331 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 234B613B4 for ; Tue, 14 Jul 2020 11:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BCDB22208 for ; Tue, 14 Jul 2020 11:16:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RfZ/Kz3I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727891AbgGNLQm (ORCPT ); Tue, 14 Jul 2020 07:16:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbgGNLPw (ORCPT ); Tue, 14 Jul 2020 07:15:52 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27844C08C5DB for ; Tue, 14 Jul 2020 04:15:52 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id k6so20883208wrn.3 for ; Tue, 14 Jul 2020 04:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J5xJlzZ+5aNa1GB1o6zmShj2PdHMF5lWE0KYZLpqibo=; b=RfZ/Kz3I91qMv/2m0Zf4ivjprRznfDKxRo5ZqPfQhhX9PSZaThHJo6P+kCgKU3rr8P ch5dX9+quX9ibe+sKu0v+Q+oiCV4mvt9tXT+dOpTZlx3dlk3pFSFYEBV9GrqzAU5e/qZ 2wuJ02QboJI8XWG+i9e/liAXGaPAVnPv3+356DXkW9YOG6Yu1G48GvrBl69d/svmIOHf M7goBeDf5RKNAnR9LAsrJsJn/VUl7itgVGaOdoTZU7JX7at3D701oJQUMpkJOWv5dSvN Vqzrln1AVz6HaXiepPBW+suT8kz9j6tWg2CRXWblQOSODD48YjXUIjfkxnM1sVlC2Ha0 P9zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J5xJlzZ+5aNa1GB1o6zmShj2PdHMF5lWE0KYZLpqibo=; b=j5P6iC8Tb1iW5Q5k5aX5HKzzkWHTR0JvXO+e/fgZbUrjBs29b5P/tAnWnUzTt5Zn9h ZvXX0OyAVx4dNL8GKKyrrviKNc6RJnCBEJSZPKhAyYDxM8RejJ94lZwIsHJmrDJN+twR FTSm4k8woB64NaKhNRA7IEg6U/VC5886EuLODn8OVdWBU1tM93mgBLn8N842AutJnf9P qI3ECOO+OYyJj8sxqo8U4KwV942TtfRBAGdD278IKcwdqVzS/U96t/urpFycdu8cWxF8 Zt9HU7NDoOdKlq3aUytffNWCtrRDKI0TLl/0w4kxBySlDb6+933L90now1TpiUL1V+Nr GU3g== X-Gm-Message-State: AOAM5330ZxQcCM6BWE7ygLc3MikkQgQrV2RDz3bH/ppD4m2rBF2IHxRK CjpkPXcP61vqUuSZur9XpLP4ToCdPuk= X-Google-Smtp-Source: ABdhPJy+IpSkDvt0gKhCLe7N/pHcRPdSZRSy6u7pwrYXAu5aBo0g8In969/7Eo5zqi8LjXxj6Yj/1w== X-Received: by 2002:adf:f388:: with SMTP id m8mr4799959wro.338.1594725350794; Tue, 14 Jul 2020 04:15:50 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:50 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Sean Wang , Matthias Brugger , linux-mediatek@lists.infradead.org Subject: [PATCH 01/17] dma: mediatek: mtk-hsdma: Fix formatting in 'struct mtk_hsdma_pdesc' doc block Date: Tue, 14 Jul 2020 12:15:30 +0100 Message-Id: <20200714111546.1755231-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Struct attribute names must be an exact match or the kerneldoc checker gets confused. Fixes the following W=1 kernel build warning(s): drivers/dma/mediatek/mtk-hsdma.c:120: warning: Function parameter or member 'desc1' not described in 'mtk_hsdma_pdesc' drivers/dma/mediatek/mtk-hsdma.c:120: warning: Function parameter or member 'desc2' not described in 'mtk_hsdma_pdesc' drivers/dma/mediatek/mtk-hsdma.c:120: warning: Function parameter or member 'desc3' not described in 'mtk_hsdma_pdesc' drivers/dma/mediatek/mtk-hsdma.c:120: warning: Function parameter or member 'desc4' not described in 'mtk_hsdma_pdesc' Cc: Sean Wang Cc: Matthias Brugger Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/dma/mediatek/mtk-hsdma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c index 4c58da7421432..f133ae8dece16 100644 --- a/drivers/dma/mediatek/mtk-hsdma.c +++ b/drivers/dma/mediatek/mtk-hsdma.c @@ -107,10 +107,10 @@ enum mtk_hsdma_vdesc_flag { * struct mtk_hsdma_pdesc - This is the struct holding info describing physical * descriptor (PD) and its placement must be kept at * 4-bytes alignment in little endian order. - * @desc[1-4]: The control pad used to indicate hardware how to - * deal with the descriptor such as source and - * destination address and data length. The maximum - * data length each pdesc can handle is 0x3f80 bytes + * @desc1: | The control pad used to indicate hardware how to + * @desc2: | deal with the descriptor such as source and + * @desc3: | destination address and data length. The maximum + * @desc4: | data length each pdesc can handle is 0x3f80 bytes */ struct mtk_hsdma_pdesc { __le32 desc1; From patchwork Tue Jul 14 11:15:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662339 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0339013A4 for ; Tue, 14 Jul 2020 11:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3EA62220F for ; Tue, 14 Jul 2020 11:17:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sx/RKyQ9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgGNLRA (ORCPT ); Tue, 14 Jul 2020 07:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgGNLQk (ORCPT ); Tue, 14 Jul 2020 07:16:40 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08825C08C5DE for ; Tue, 14 Jul 2020 04:15:53 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b6so20886296wrs.11 for ; Tue, 14 Jul 2020 04:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8AHNAOGxoWBX3bXCs6Dh5/0gSXTq0LMXanlZCN8dNwA=; b=sx/RKyQ9jzgAwx3JUl7dyzFreyfVZjEL/DUHRuGpwSBUKhEE64OoYSqxjGFVirc7Gk sryFAxXibssYup3dVrT2uC4aq0mcmalkbq93JYSCp+BwRLD89Pv+5kz4oOojBTVD6WrI ahvJMu6FY2XT9T7OraeUW0dHR9cOdvO/2/IlNgYTkZD69LmCXDobV3qC8Noc5zlOMwgv c8k9E73fAGNjkpPwVPp4//NZ/4D4LjQ+03Bry7q7c7JxzRjVhem6LUJ20JsV5NOal6eh /ghvlJF4oOsqxuRZCbzwXiSGso3UnKH7O7X45+VT50Cn4Ete91et4bDQ6N+ZMBcH0aiX q0lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8AHNAOGxoWBX3bXCs6Dh5/0gSXTq0LMXanlZCN8dNwA=; b=NW3iyBEs9ES2oxQck7VDLX2y16qlVSVi/LCrhRY1t6JIw8m1tUSvzrDSoJBoPKgYlL VfLdC7/7aT+otPqqIQaXJZlYPPD3xRAdrQyRLnfjDdVQC7943RYZXD3XoWKlwyI2gpWe ALm/tWaZThZLQJNTWi2JRyb5vsbSxUW8/y73AsS5cEmiujSVS88v5yBs79nlvr1Q567C 5S2VM5FGS1IsjeL5ta/Yra16CgOUnUSRdi1iPIWFPhOdM0Br3JRI6GSMVizpi4AE1vXM 3lqs/oXnC4vpz2hgx3989dyDQmG72uqAx1ezIdnA3vAH/LKGHdKm9NWHTdK6hygO1eAL SFeA== X-Gm-Message-State: AOAM5319g8UMcOKQdpmgZNyJGeE4TdpiHh62gHtSx4WkZk5KBUOs7Fm1 IVsRtSA+B3LAyFPrkbDI9rOpDg== X-Google-Smtp-Source: ABdhPJz+RcOyEJB9HyBPqs6LMXrDgN6dj+1DlUqwXuNalPd8xjE66KHEGwQS5Q1S0C8zFN0qvlHVrg== X-Received: by 2002:a05:6000:cf:: with SMTP id q15mr4734329wrx.203.1594725351797; Tue, 14 Jul 2020 04:15:51 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:51 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones Subject: [PATCH 02/17] dma: of-dma: Fix misspellings/formatting issues in some function headers Date: Tue, 14 Jul 2020 12:15:31 +0100 Message-Id: <20200714111546.1755231-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/of-dma.c:57: warning: Function parameter or member 'ofdma' not described in 'of_dma_router_xlate' drivers/dma/of-dma.c:57: warning: Excess function parameter 'of_dma' description in 'of_dma_router_xlate' drivers/dma/of-dma.c:107: warning: Function parameter or member 'data' not described in 'of_dma_controller_register' drivers/dma/of-dma.c:308: warning: Function parameter or member 'ofdma' not described in 'of_dma_simple_xlate' drivers/dma/of-dma.c:308: warning: Excess function parameter 'of_dma' description in 'of_dma_simple_xlate' drivers/dma/of-dma.c:338: warning: Function parameter or member 'ofdma' not described in 'of_dma_xlate_by_chan_id' drivers/dma/of-dma.c:338: warning: Excess function parameter 'of_dma' description in 'of_dma_xlate_by_chan_id' Signed-off-by: Lee Jones --- drivers/dma/of-dma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index b2c2b5e8093cf..863f2aaf5c8f7 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-dma.c @@ -46,7 +46,7 @@ static struct of_dma *of_dma_find_controller(struct of_phandle_args *dma_spec) /** * of_dma_router_xlate - translation function for router devices * @dma_spec: pointer to DMA specifier as found in the device tree - * @of_dma: pointer to DMA controller data (router information) + * @ofdma: pointer to DMA controller data (router information) * * The function creates new dma_spec to be passed to the router driver's * of_dma_route_allocate() function to prepare a dma_spec which will be used @@ -92,7 +92,7 @@ static struct dma_chan *of_dma_router_xlate(struct of_phandle_args *dma_spec, * @np: device node of DMA controller * @of_dma_xlate: translation function which converts a phandle * arguments list into a dma_chan structure - * @data pointer to controller specific data to be used by + * @data: pointer to controller specific data to be used by * translation function * * Returns 0 on success or appropriate errno value on error. @@ -295,7 +295,7 @@ EXPORT_SYMBOL_GPL(of_dma_request_slave_channel); /** * of_dma_simple_xlate - Simple DMA engine translation function * @dma_spec: pointer to DMA specifier as found in the device tree - * @of_dma: pointer to DMA controller data + * @ofdma: pointer to DMA controller data * * A simple translation function for devices that use a 32-bit value for the * filter_param when calling the DMA engine dma_request_channel() function. @@ -323,7 +323,7 @@ EXPORT_SYMBOL_GPL(of_dma_simple_xlate); /** * of_dma_xlate_by_chan_id - Translate dt property to DMA channel by channel id * @dma_spec: pointer to DMA specifier as found in the device tree - * @of_dma: pointer to DMA controller data + * @ofdma: pointer to DMA controller data * * This function can be used as the of xlate callback for DMA driver which wants * to match the channel based on the channel id. When using this xlate function From patchwork Tue Jul 14 11:15:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662335 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C23F13B4 for ; Tue, 14 Jul 2020 11:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F8172220C for ; Tue, 14 Jul 2020 11:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SdnZRHxr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbgGNLQz (ORCPT ); Tue, 14 Jul 2020 07:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727850AbgGNLQk (ORCPT ); Tue, 14 Jul 2020 07:16:40 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 334EBC08C5E0 for ; Tue, 14 Jul 2020 04:15:54 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w3so5008032wmi.4 for ; Tue, 14 Jul 2020 04:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1JX6Y3K2cqUwU/GGZOaVZUng81gC2+PNbg79UPVm7pA=; b=SdnZRHxrdki/679eF7FPi+/jeTt1n4vu5QCRmxeDf6qNUzYvM7bS2wL2e0ozSfTlDM tARtuX6tX/rbJL0nOjGxOz1EtxEWgSJNBrFZwRThgWXp5Kl5a6eD/wFnCjhIw+jzzB7/ pa4ZdykY/E568sV/yKFbCQxdcbcvMthgP72Nu27IdlPvdnWn5ftPWOFl2iZSTN1CLks5 jCbJHl6gQERwh+F3BClZBDXiW2ATsNlEyVQiw6QRQl3Zs4s0/giQC73/rqp6wSLML6mF zYRMnkFtGmDat2lWvacTNArmkiOZWN/S+hRGD0VkR7xu8KkSelzdOD+GdqTV8/pI3av1 6uAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1JX6Y3K2cqUwU/GGZOaVZUng81gC2+PNbg79UPVm7pA=; b=N9P2V3XpF8iyXmfEyY6zQKrosOUasKV6w4SYKOFhEDe0+3B3PkuT72rXbJPQa5poBC QvMlSvtL/+m/9T7cu8cHoon6G9q8wZCBLuME9pqI1o29uKJkj0cvzeF309wzqCxz5WEM RUzWXRX1n1rJ0e7kABNpOhMQvKOC/xNKfsKKdNVocdC6i5jJkdBsh8jnEEaCV33Qj4yf eHISnDF5FpVBOtz07l1FyUtSeyuFWeXmBKxOdmcjE15LybDJ8g4+X5tCaNsHN/mFA3lf fE+XN0BO794/+zcSjCZeEgAn0/3hNdBufUeqV+h+3rS9sMhJ42lhyHLqfL6nOTA5s3Sz a92w== X-Gm-Message-State: AOAM531ZYLjvNINTsTS3Vm/Sjgot2QrZg98GJ7EZm7koZCKg3eQh1X1n 9kDqiZJ0fZg7LgXT+OPCFIzt4A== X-Google-Smtp-Source: ABdhPJzIAm8WUFOAz5PhBWJ+LR0cHqt9Te+7GSve6DdRDT8JFwjK99lQq5ArJTTuSWYWI8WtVeWu0w== X-Received: by 2002:a1c:a4c6:: with SMTP id n189mr3714749wme.173.1594725352930; Tue, 14 Jul 2020 04:15:52 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:52 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Lennert Buytenhek , Ryan Mallon , Mika Westerberg Subject: [PATCH 03/17] dma: ep93xx_dma: Provide some missing struct attribute documentation Date: Tue, 14 Jul 2020 12:15:32 +0100 Message-Id: <20200714111546.1755231-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org A couple of entries were missed, causing kerneldoc to complain. Fixes the following W=1 kernel build warning(s): drivers/dma/ep93xx_dma.c:183: warning: Function parameter or member 'slave_config' not described in 'ep93xx_dma_chan' drivers/dma/ep93xx_dma.c:215: warning: Function parameter or member 'hw_synchronize' not described in 'ep93xx_dma_engine' Cc: Lennert Buytenhek Cc: Ryan Mallon Cc: Mika Westerberg Signed-off-by: Lee Jones --- drivers/dma/ep93xx_dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index 9c8b4d35cf03d..87a246012629f 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -147,6 +147,7 @@ struct ep93xx_dma_desc { * is set via .device_config before slave operation is * prepared * @runtime_ctrl: M2M runtime values for the control register. + * @slave_config: slave configuration * * As EP93xx DMA controller doesn't support real chained DMA descriptors we * will have slightly different scheme here: @active points to a head of @@ -187,6 +188,7 @@ struct ep93xx_dma_chan { * @dma_dev: holds the dmaengine device * @m2m: is this an M2M or M2P device * @hw_setup: method which sets the channel up for operation + * @hw_synchronize: synchronizes DMA channel termination to current context * @hw_shutdown: shuts the channel down and flushes whatever is left * @hw_submit: pushes active descriptor(s) to the hardware * @hw_interrupt: handle the interrupt From patchwork Tue Jul 14 11:15:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662333 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1FB113B6 for ; Tue, 14 Jul 2020 11:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98FC42220E for ; Tue, 14 Jul 2020 11:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sySJajNw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727935AbgGNLQt (ORCPT ); Tue, 14 Jul 2020 07:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727869AbgGNLQl (ORCPT ); Tue, 14 Jul 2020 07:16:41 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49972C08C5E2 for ; Tue, 14 Jul 2020 04:15:55 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f18so20906178wrs.0 for ; Tue, 14 Jul 2020 04:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MLpJm3mzK+V3kK3HZ3SJH1x+Limv7E45WQQkbSJWTls=; b=sySJajNwSAkugA5Z9nBjxFfu7QwyjdADzjqsQa+cpQZcqSV/GK1YAGZtjBZdEpOIRE qhCguOnqhDMtdxsnHovaMlrvZzXMWD5TcFatVeJdFeyTVUOWefKhY7XbB145tlHGi1Sa i5sJsZbefS0ktjmmcgPcl/LDtOjjQMtojC6g+wfYnjIa/R4ugyx5mgQ4wibAdDdYhjYu e86uZNax1MWGcDvMTk23+uZ2idMAUq1LtyDlpomNfpBpKwFqZvW3Pga1yvWiu0YsXzJv 1ZLwatEwBAdHWtyhwagGUyovYUxFBUaO0W2WqFy1660sqs0wHOmpOMorBt26JdBjkFXd P0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MLpJm3mzK+V3kK3HZ3SJH1x+Limv7E45WQQkbSJWTls=; b=eNJguCI84JqXb3y/xWy5LgnXLhVbTY7eCHnqgsF/ENwTNKPddgVfGBWWR7ydZ0Jq3z 1kJNeUJjGrWQm8VJMPTFraXOpVvvTRm3VLyG+Jaauqw+HAr925ey/pE2dMobPstgWcKN ojF5FkpQ2ICjuvMFj1xEey/8MLkdJynuzEKABt3TZOp5BRGJdT2Qqc6PntFX2MgagYmi 8E12MnEJSWNQpwHVnhmSNnYG8RoI2afnQzzDOO3Kbj+27ikdX9NpCpuDKh+Z+WvRydXC XXNJpUbFlgsPWYlCCxVQBbAlAMPv8iokeh40OoPQle1ZCPP3Tc+DPTRnVUhSJ+dF/bUj 8TBQ== X-Gm-Message-State: AOAM5300JT1l89mWSHbg4GwxI3M9B5bBVtzmwcHC39vNz1fxlg9opRok nCrn6BDN74lhWxPPzGdDkJsbog== X-Google-Smtp-Source: ABdhPJyDRC1BL2tn7X/XOxKF+nUyGiv0k9S/8IxjJcKJE2YoRqCxMojY/XU+Yg+IRUHzvp+gWFIq6w== X-Received: by 2002:adf:fe85:: with SMTP id l5mr4392632wrr.333.1594725354068; Tue, 14 Jul 2020 04:15:54 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:53 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones Subject: [PATCH 04/17] dma: mmp_pdma: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 12:15:33 +0100 Message-Id: <20200714111546.1755231-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/dma/mmp_pdma.c:298: warning: Function parameter or member 'chan' not described in 'start_pending_queue' drivers/dma/mmp_pdma.c:393: warning: Function parameter or member 'dchan' not described in 'mmp_pdma_alloc_chan_resources' drivers/dma/mmp_pdma.c:862: warning: Function parameter or member 'dchan' not described in 'mmp_pdma_issue_pending' Signed-off-by: Lee Jones --- drivers/dma/mmp_pdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 41c542eaa23a5..f42f792db277e 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -290,7 +290,7 @@ static void mmp_pdma_free_phy(struct mmp_pdma_chan *pchan) spin_unlock_irqrestore(&pdev->phy_lock, flags); } -/** +/* * start_pending_queue - transfer any pending transactions * pending list ==> running list */ @@ -381,7 +381,7 @@ mmp_pdma_alloc_descriptor(struct mmp_pdma_chan *chan) return desc; } -/** +/* * mmp_pdma_alloc_chan_resources - Allocate resources for DMA channel. * * This function will create a dma pool for descriptor allocation. @@ -854,7 +854,7 @@ static enum dma_status mmp_pdma_tx_status(struct dma_chan *dchan, return ret; } -/** +/* * mmp_pdma_issue_pending - Issue the DMA start command * pending list ==> running list */ From patchwork Tue Jul 14 11:15:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662337 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A0AFD13A4 for ; Tue, 14 Jul 2020 11:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 845D72220D for ; Tue, 14 Jul 2020 11:16:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="raat87E0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgGNLQ4 (ORCPT ); Tue, 14 Jul 2020 07:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727871AbgGNLQm (ORCPT ); Tue, 14 Jul 2020 07:16:42 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56267C08C5E3 for ; Tue, 14 Jul 2020 04:15:56 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z13so20886675wrw.5 for ; Tue, 14 Jul 2020 04:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=271JiKK80FLwolRF6spciLtpgZEz0e7WX3q5gXVxSzM=; b=raat87E0F+i5FkKKSfcO3L2BJ5q4wOj/rW3ptZDMlqpAJZ9MaUq1eZax/zYLu3u1ge +ZyWI3fFRpkmoWUgc+bymQ9frEC7/F/B8Q1NHD3kAgIQ/7Z1kiTsvp4eMiHBIuvmPQ/d FEknbe7lLIOAsbdIS5yrDLkZrtppZzfTEMJFXUnasPMvnauSITv7zvkVKwj2/0xVFxMh SXs6P9KeDUBqrH8rP7LfVq+F0db6vfdk3Z/uJilq1e5+7TGTLUh8dK55PbTqHpBb3gjg 1gwM6YZOar952H6zAlL5fSktswLL5YpeaAWDTx727Q9tMQRM0EP1u+hCI2Gfs35Ni1K8 6PRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=271JiKK80FLwolRF6spciLtpgZEz0e7WX3q5gXVxSzM=; b=jwPmX0L8BaQb0nGjGoJkOgvzlmnrpQBCEKRSoq5zSvchMYi+HRE1Cw7vZgmCNJX1SV FQzaebKV6TTlpcY7ckvM0z/ZTRTCl9pRUI8AAYt3uS9fOn0afQL1iGRuUsPXDwuYwdV8 nNl3D/MJIxU41U6sjvR4plmvBWINjwcKp+TF3g/kxNohVbkw06py7mkeER6e16R00YGT aKvehBb0kKRJhKALKugjcGZOAugc8vfC/Z1FmZoFAIK/82Hv8iYUdloXlkZ8pO/2lMz6 DqyXdzpfkmz/5VVza0pMOwDuELz/rA1uIwvn2pn9aYwbjeRbhmNkiUumgHqj69yUNltN MnKg== X-Gm-Message-State: AOAM5303zNY3nReGwHylCB5H3cKvcIl4M36AKFtenS3QUrPibY9mC3/c 4LaBiB9G+Olt9z5sYcRSYmP5DQ== X-Google-Smtp-Source: ABdhPJxHSXSpUZXfp2uA6lo+uRLlOTalaig2KsNnaQ+tQtCBvn+WX9e2f1GMQPSpjVH56EMB/KpxqA== X-Received: by 2002:a5d:4710:: with SMTP id y16mr4774395wrq.189.1594725355155; Tue, 14 Jul 2020 04:15:55 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:54 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Philipp Zabel , Jaswinder Singh Subject: [PATCH 05/17] dma: pl330: Demote obvious misuse of kerneldoc to standard comment block Date: Tue, 14 Jul 2020 12:15:34 +0100 Message-Id: <20200714111546.1755231-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org No 'struct' title is provided. Nor are any attribute descriptions. Fixes the following W=1 kernel build warning(s): drivers/dma/pl330.c:295: warning: cannot understand function prototype: 'struct pl330_reqcfg ' Cc: Philipp Zabel Cc: Jaswinder Singh Signed-off-by: Lee Jones --- drivers/dma/pl330.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 6a158eef6b8ad..4fc7aeec70a81 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -284,7 +284,7 @@ struct pl330_config { u32 irq_ns; }; -/** +/* * Request Configuration. * The PL330 core does not modify this and uses the last * working configuration if the request doesn't provide any. From patchwork Tue Jul 14 11:15:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662377 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2790913A4 for ; Tue, 14 Jul 2020 11:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 101AE2220D for ; Tue, 14 Jul 2020 11:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bt0GCA6s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbgGNLQm (ORCPT ); Tue, 14 Jul 2020 07:16:42 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7217C08C5F3 for ; Tue, 14 Jul 2020 04:15:57 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k6so20883653wrn.3 for ; Tue, 14 Jul 2020 04:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QiZP1EJ4HMANCxwy0emf1RpubxHNKPeVfuS0vb5jwJ0=; b=Bt0GCA6sAZ1Dhav8uxfVkLsp+I/g50wOtMFqyePzqFC2JGKGQxf3cofzFqQLhNbxix MYHy7BJqu7ePGOEXENWyzEDOqRnf7hx4HmX+xp/YqM9BmOTD2QM8AHwRHx8+rdCKXCic Pyjf/Qqn5u/+f+t2ojun7ZEgZQ26jHK8sFVi7bFwAMD2KWCNJeaUK/snV2iHB/lrurng h2WH838TmE6UU8l1dStBAttQpIHjjbZDEUOqOTzlzpn/lcbltMLgIlmu3iJyR3SW1lMm wl7f4eeoVNZIyCvMf8vK2JiVtvZbc0GHpPNzkvbArAVJhlqNI1knGxYIRsaYRGwWSPZy Ip0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QiZP1EJ4HMANCxwy0emf1RpubxHNKPeVfuS0vb5jwJ0=; b=S6fDDsqjBtSAUXBf69SCrwtqDVybF3POkgAdszNtgV68Y/KfMjvH8ts0Igexcl6k1G KQGcQKhQyoAc7VCMitFHbYdDnk6Ukniopylag1LSpeDX4m+Yswr+zexhfBZdSUyLTK1Y 7L3LbNpBPAOXqP3xAkPQfUziH47Udvj9GmjFpoVofHEto4hPC1XdYZY76+6NiqP/DJq8 hzfMZxrmDLxifGWjkm3QXsVtrd2vSvOQJbp/dYPIafGM1cFvVbFjUjpfSJHySXgZ6SF7 tGg2J+bDvGhCxirplPeu6YTKbf9cRQknJi660YHoMbcMYUyF0FUVPU+fUiFntUA6DY82 OGFQ== X-Gm-Message-State: AOAM530cBi/XHu5yv6xsWXEOlHr5Isyfnf0eqONgsowDH0JUZv8/PbaY ZPZCSEau2fnGaf6TnGEKBAs0LA== X-Google-Smtp-Source: ABdhPJwkiwpi8l/2xIcMFabgGHg0sSEJz0lNu3Gqu0LiD5h2i/XCtSzTUFZ2AhtZQDnFonigsMSt8A== X-Received: by 2002:a5d:6749:: with SMTP id l9mr4524901wrw.63.1594725356234; Tue, 14 Jul 2020 04:15:56 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:55 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Per Forlin , Jonas Aaberg Subject: [PATCH 06/17] dma: ste_dma40: Supply 2 missing struct attribute descriptions Date: Tue, 14 Jul 2020 12:15:35 +0100 Message-Id: <20200714111546.1755231-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/ste_dma40.c:398: warning: Function parameter or member 'dma_addr' not described in 'd40_lcla_pool' drivers/dma/ste_dma40.c:601: warning: Function parameter or member 'dma_parms' not described in 'd40_base' Cc: Per Forlin Cc: Jonas Aaberg Signed-off-by: Lee Jones --- drivers/dma/ste_dma40.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index de8bfd9a76e9e..21e2f1d0c2109 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -381,6 +381,7 @@ struct d40_desc { * struct d40_lcla_pool - LCLA pool settings and data. * * @base: The virtual address of LCLA. 18 bit aligned. + * @dma_addr: DMA address, if mapped * @base_unaligned: The orignal kmalloc pointer, if kmalloc is used. * This pointer is only there for clean-up on error. * @pages: The number of pages needed for all physical channels. @@ -534,6 +535,7 @@ struct d40_gen_dmac { * mode" allocated physical channels. * @num_log_chans: The number of logical channels. Calculated from * num_phy_chans. + * @dma_parms: DMA parameters for the channel * @dma_both: dma_device channels that can do both memcpy and slave transfers. * @dma_slave: dma_device channels that can do only do slave transfers. * @dma_memcpy: dma_device channels that can do only do memcpy transfers. From patchwork Tue Jul 14 11:15:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662375 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D78C713B4 for ; Tue, 14 Jul 2020 11:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCA4922208 for ; Tue, 14 Jul 2020 11:18:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lRnHD6+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727899AbgGNLQm (ORCPT ); Tue, 14 Jul 2020 07:16:42 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7ECC08C5F4 for ; Tue, 14 Jul 2020 04:15:58 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id b6so20886752wrs.11 for ; Tue, 14 Jul 2020 04:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xDspo//ZGGv62/k8vhH8b8dLXko1WA1DYqLJUY7Z0pU=; b=lRnHD6+n0Kjyezcw88EVB0+8py6DiaAYhCbxlABYw2m8o9Zqwb0e0UYsTQn6UzdoyM Ai/Lwf+avt/HMmYhCR2/TG+yz4ONmkQc2lUl56ky4FIDgvtg1bdsR8ab93IYufj3BDun i0WFD7NuGJNJDoZQohH34gqSOOdzQKa+D1J8sCzkxCvJV+Jwbn1/J2Scn0vFBzHdFMU4 yHlh6N9RzslpQaPG35aqpOqxYCtYF2Q9jqYGfdLmmosobj45f6BOMGXsaHWrN8m60dsA vBG+Cnm/FE0W+t1lyKdF9znSpMDeukw6cl5PVzqvlV6+4bcIri+v2g7Y5SvFnTWu1qFI jtFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xDspo//ZGGv62/k8vhH8b8dLXko1WA1DYqLJUY7Z0pU=; b=Ci0U6ykrymbip/82IL9upFixHN2UcVIz6acm4QWQ0KrP+On0JFBUv9Uew6PB6i2EKt c0UiOmPU5iJBxh5jTDthup/PKKkhp1Mt4p75YhIsSpnfZzAXmuFx2oTRNoc5KqHiJPlW TWLJ8ZaoxGu68f4iZOxdnspn2HYt6A6y3jNqtrPN60POZHA9Qc5dPCMuHiIgkiTYNqQp 1UuDYmU6FHKmIfthDjmopDXHJXxG6IaLwsBU89Q6OXEWL0hO8ZaF0zAH0KZ+sRiB7tLF lF+n1o5ld6xdVoOAnGwcFZFP5VlsPO0UCF4klgnF0S5Anihi0WMBxfIjrC2IQLTPwp73 SJuQ== X-Gm-Message-State: AOAM5328QT8c0SlAmRZr++U2tqyMk40NmPQ60YlUbP68amF68AmrsYFM P68X7x6BPUPP0ctbQRPegdHFiw== X-Google-Smtp-Source: ABdhPJzIzSvAOB3xgad3Sen6dlJzxBYaenPpru9T4eTefZSfzMtOdkfpSmMn9BuJRx6p9P4nOKO/4A== X-Received: by 2002:a5d:6a90:: with SMTP id s16mr4580377wru.8.1594725357328; Tue, 14 Jul 2020 04:15:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:56 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Stefan Roese Subject: [PATCH 07/17] dma: altera-msgdma: Fix struct documentation blocks Date: Tue, 14 Jul 2020 12:15:36 +0100 Message-Id: <20200714111546.1755231-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fix some misspelling/description issues, demote non-kerneldoc header to standard comment block and provide a new description for msgdma_desc_config()'s 'stride' parameter. Fixes the following W=1 kernel build warning(s): drivers/dma/altera-msgdma.c:163: warning: Function parameter or member 'node' not described in 'msgdma_sw_desc' drivers/dma/altera-msgdma.c:163: warning: Function parameter or member 'tx_list' not described in 'msgdma_sw_desc' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'lock' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dev' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'irq_tasklet' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'pending_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'free_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'active_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'done_list' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'desc_free_cnt' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'idle' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dmadev' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'dmachan' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'hw_desq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'sw_desq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'npendings' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'slave_cfg' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'irq' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'csr' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'desc' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:197: warning: Function parameter or member 'resp' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:265: warning: Function parameter or member 'stride' not described in 'msgdma_desc_config' Cc: Stefan Roese Signed-off-by: Lee Jones Reviewed-by: Stefan Roese --- drivers/dma/altera-msgdma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c index 539e785039cac..321ac3a7aa418 100644 --- a/drivers/dma/altera-msgdma.c +++ b/drivers/dma/altera-msgdma.c @@ -153,7 +153,8 @@ struct msgdma_extended_desc { * struct msgdma_sw_desc - implements a sw descriptor * @async_tx: support for the async_tx api * @hw_desc: assosiated HW descriptor - * @free_list: node of the free SW descriprots list + * @node: node to move from the free list to the tx list + * @tx_list: transmit list node */ struct msgdma_sw_desc { struct dma_async_tx_descriptor async_tx; @@ -162,7 +163,7 @@ struct msgdma_sw_desc { struct list_head tx_list; }; -/** +/* * struct msgdma_device - DMA device structure */ struct msgdma_device { @@ -258,6 +259,7 @@ static void msgdma_free_desc_list(struct msgdma_device *mdev, * @dst: Destination buffer address * @src: Source buffer address * @len: Transfer length + * @stride: Read/write stride value to set */ static void msgdma_desc_config(struct msgdma_extended_desc *desc, dma_addr_t dst, dma_addr_t src, size_t len, From patchwork Tue Jul 14 11:15:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662389 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA9FD13B4 for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A06AD22211 for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lnvYu/8j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgGNLTQ (ORCPT ); Tue, 14 Jul 2020 07:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbgGNLQq (ORCPT ); Tue, 14 Jul 2020 07:16:46 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA5F0C08C5F6 for ; Tue, 14 Jul 2020 04:15:59 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so20899529wru.6 for ; Tue, 14 Jul 2020 04:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HLIjy5aQCoym5Mm/hCfDKR0dFhPfvd31LPr0bmAaNkI=; b=lnvYu/8jdk95UwX9IoDefntQmNZ+TclIUQ6X2+ECk2EmyNfMBSnJ+i5mPNOqb7kmeM fLy4ysPmpsGjO8sriBthSrL7udGqmt9/nuZ5l7zKTopOVTfaks9NXyO0gV74aG5K40sk x5bxKd00883pryu8HmCJch6RB7XfgGh5Ne39TcCPPFPZ84VnYZOnl3F9aFfqj45OnhBl zh+xG9CZrFaicAU4SyVU3j3xTIGosE7bPvvrO4l7S71upbFK2rurlyQHcVSY14RqCI4Q E+qz9npM2rYERwSBflKs0s8CrvBk5r0P8pPmgAnq/cKLuvv/eO8TGROqdG4/raMbpw5k hYgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HLIjy5aQCoym5Mm/hCfDKR0dFhPfvd31LPr0bmAaNkI=; b=XGZmLUSiTLccFH4hw4NxkWOCwAxHsZnca5nsiQt2kfyclm5ZXCgRqQslNQYfm/QZ+n MdDWmgoazhxw46sLgsliRuEatQHtS6ZH7BwQCG/wfajn/HMP1luvwCbwjiAbN+WiVsu8 QIixcny3nfpDUcO7nppz8OZtlsoMyBhcKrciVZ8bo9Y/oc+5luCJliRM1S0iVJt5TxPn VLAlHeA1uxQWwgwCj2GUGO4uPBbezcRrcUHVk5C46cfpdr1T8FdtVoi0dTi5tPUdyXAy 97QRqFdKS3+tBb9TjrqQOrITa23i+rcV67+1w9f/97hhpjxsrzv1iUN/g3V99FJgjjgP U2cg== X-Gm-Message-State: AOAM533KoFP38Py6Q8In4X86HDHCtQZGF02Qa9JKMiur3keVDFKIMJpM vQ9a0YqbAWShCaDNXxgK2jKQkA== X-Google-Smtp-Source: ABdhPJyPj59yNtEMPOQ/nf0KvMrMzW5MAG6d1mHgCW2Smzjhseeu55XTnni31ER4NoiwLyYXa+7vOw== X-Received: by 2002:adf:b190:: with SMTP id q16mr4666971wra.356.1594725358605; Tue, 14 Jul 2020 04:15:58 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:57 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Ludovic Desroches , Nicolas Ferre Subject: [PATCH 08/17] dma: at_hdmac: Repair parameter misspelling and demote non-kerneldoc headers Date: Tue, 14 Jul 2020 12:15:37 +0100 Message-Id: <20200714111546.1755231-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/at_hdmac.c:666: warning: Function parameter or member 'tx' not described in 'atc_tx_submit' drivers/dma/at_hdmac.c:666: warning: Excess function parameter 'desc' description in 'atc_tx_submit' drivers/dma/at_hdmac.c:1206: warning: Function parameter or member 'reg_width' not described in 'atc_dma_cyclic_check_values' drivers/dma/at_hdmac.c:1206: warning: Function parameter or member 'buf_addr' not described in 'atc_dma_cyclic_check_values' drivers/dma/at_hdmac.c:1206: warning: Function parameter or member 'period_len' not described in 'atc_dma_cyclic_check_values' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'chan' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'desc' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'period_index' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'buf_addr' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'reg_width' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'period_len' not described in 'atc_dma_cyclic_fill_desc' drivers/dma/at_hdmac.c:1228: warning: Function parameter or member 'direction' not described in 'atc_dma_cyclic_fill_desc' Cc: Ludovic Desroches Cc: Nicolas Ferre Signed-off-by: Lee Jones --- drivers/dma/at_hdmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 73a20780744bf..45bbcd6146fd2 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -656,7 +656,7 @@ static irqreturn_t at_dma_interrupt(int irq, void *dev_id) /** * atc_tx_submit - set the prepared descriptor(s) to be executed by the engine - * @desc: descriptor at the head of the transaction chain + * @tx: descriptor at the head of the transaction chain * * Queue chain if DMA engine is working already * @@ -1196,7 +1196,7 @@ atc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, return NULL; } -/** +/* * atc_dma_cyclic_check_values * Check for too big/unaligned periods and unaligned DMA buffer */ @@ -1217,7 +1217,7 @@ atc_dma_cyclic_check_values(unsigned int reg_width, dma_addr_t buf_addr, return -EINVAL; } -/** +/* * atc_dma_cyclic_fill_desc - Fill one period descriptor */ static int From patchwork Tue Jul 14 11:15:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662387 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CC2A13A4 for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E5A62220D for ; Tue, 14 Jul 2020 11:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pHR0K+KI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbgGNLTP (ORCPT ); Tue, 14 Jul 2020 07:19:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbgGNLQr (ORCPT ); Tue, 14 Jul 2020 07:16:47 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C8ACC08C5F8 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so20829525wrj.13 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=pHR0K+KIKxD5EhQKwXJRi/S4mxtDdDxisRS89L6rsYWjar6xsf8yjwNVsm+/g1upct IjWqNYsequpP4EokGC40Vu6cXEx/yZuCdZaq0N3/OFVgliYwoxdDkSpoT0u76/HuKY6U MUbzo7YLYjjS7/pll5iVgV7Q58ymHgPYlsRuP2liz2R5WxN22Oi1Kk4KwrQO9/oZusKt OQkwybdZ3gHPd3FOQszTItGnFNRuTo22n7TnlJGNSowr7quZ7wNDgooiGSqS4dtCo1t5 8Tcq5cilV0VQoGtWhZTw8JfUhrmhODcrz7h4EDAXTRcu12wQcylbZ4ozZzb2AmspBtFl XHAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=sxXqBfjcoq6u0/Hb5rBuTLG7D0N+6zUKLAE/ArLzret52Sio6ZAxQsD7WLSEUIz1sp BYYCEBc0nlADbZRRabtTItsSzzjXr7yEw5qg4wl1H70VoZfzuddvDWETsS0k3sGTHexZ F7s5wF7oux2OByIiKx8baVxk27//2QCh083BTFI3CyEeePBPTBJlQlXqN5HXGHMe8/78 2i7spFlfi2ZyWxwItD4G1obAx77zP71nzlqtaLyChEzt5lc0iMLzvnkUAib2sqy/KYXv Pms1GWhtNCHDqI4N+LyB23/FFPAGJWUn5vRz+qq91fxGRRS7O+nn086ykNAQ1wJRHvJb 6IeA== X-Gm-Message-State: AOAM532zmM48aFjxb8VODNmU0GAStq1jEmefEZGOlZQmkkkPyqcuLnRE dd2eJlIH6Nsr9KjJ23mEDrE+sg== X-Google-Smtp-Source: ABdhPJyAH8JGNWD20qUSqWUGbGK+bbNu7uHkKBBKvWNRnQi1cZAEQOcb1acarwwp6TN9Ch6DTWsG9A== X-Received: by 2002:a5d:420b:: with SMTP id n11mr4591674wrq.91.1594725359812; Tue, 14 Jul 2020 04:15:59 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:59 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Maxime Ripard , Chen-Yu Tsai , =?utf-8?q?Emilio_L=C3=B3pez?= Subject: [PATCH 09/17] dma: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 12:15:38 +0100 Message-Id: <20200714111546.1755231-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'priv' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'vchan' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'chan' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'src' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'dest' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'len' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'sconfig' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'direction' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'chan' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'src' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'dest' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'len' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'sconfig' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:577: warning: Function parameter or member 'contract' not described in 'get_next_cyclic_promise' drivers/dma/sun4i-dma.c:596: warning: Function parameter or member 'vd' not described in 'sun4i_dma_free_contract' Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: "Emilio López" Signed-off-by: Lee Jones Acked-by: Chen-Yu Tsai --- drivers/dma/sun4i-dma.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index e7ff09a5031db..e8b6633ae6612 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -307,7 +307,7 @@ static void set_pchan_interrupt(struct sun4i_dma_dev *priv, spin_unlock_irqrestore(&priv->lock, flags); } -/** +/* * Execute pending operations on a vchan * * When given a vchan, this function will try to acquire a suitable @@ -419,7 +419,7 @@ static int sanitize_config(struct dma_slave_config *sconfig, return 0; } -/** +/* * Generate a promise, to be used in a normal DMA contract. * * A NDMA promise contains all the information required to program the @@ -486,7 +486,7 @@ generate_ndma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a promise, to be used in a dedicated DMA contract. * * A DDMA promise contains all the information required to program the @@ -543,7 +543,7 @@ generate_ddma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a contract * * Contracts function as DMA descriptors. As our hardware does not support @@ -565,7 +565,7 @@ static struct sun4i_dma_contract *generate_dma_contract(void) return contract; } -/** +/* * Get next promise on a cyclic transfer * * Cyclic contracts contain a series of promises which are executed on a @@ -589,7 +589,7 @@ get_next_cyclic_promise(struct sun4i_dma_contract *contract) return promise; } -/** +/* * Free a contract and all its associated promises */ static void sun4i_dma_free_contract(struct virt_dma_desc *vd) From patchwork Tue Jul 14 11:15:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662383 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2271213B6 for ; Tue, 14 Jul 2020 11:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09B0E22208 for ; Tue, 14 Jul 2020 11:18:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jL/qnxUg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgGNLSx (ORCPT ); Tue, 14 Jul 2020 07:18:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727926AbgGNLQs (ORCPT ); Tue, 14 Jul 2020 07:16:48 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41276C08C5FB for ; Tue, 14 Jul 2020 04:16:02 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 17so5003266wmo.1 for ; Tue, 14 Jul 2020 04:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D5s+rt+e2q3V0egWj1kNYGUguad7SryOLaiZ+itebdM=; b=jL/qnxUg7kHcZtAr6n9CGwUkJP9YJWkIhRzSWv4qL92aeS/U9U9g4zmNTJgB3Xz5vk EhtOmx3utz7MY7fGlpBM8ymeZz/Z1LEcmgct51u77TV6v8ybZlzM05eoBQZHgZEju/TN P1NVX5MKM9FKkX/foE9t2S2+zssTOe5hxn6ZIdXU/zcsNGXWLkpHk5+z0yRwIm+K60IF 5AfyIwSiPgWmJxPCZuO4J2098g00yGjDb6/m5ubDBW1OjdYQwtSxGucUafpEVM4+wmsE npu8ws+PErzvWJ4Bg8Ue0dHmiwGP1cvG6cC/5tOHg5SglktOksJAj+zL7FxBMMYhDlw5 2isw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D5s+rt+e2q3V0egWj1kNYGUguad7SryOLaiZ+itebdM=; b=sP4lrXVY06Zy1K7SLlihQlTNYvmbzt1SqR+akhTE9mIE5ZjZdKAjJhOvAQbHALqdgJ gAVCtjw6jo0/FhuFPeNdt0CYWGkORp53ud/7kAVK+1pBbR05XgV2MaNj5/a/1TVvOcKM Bl59u8dk6bI7CU6AkxQ51tWW0udblK7sMXJFledY40G5aoo/Ueeiw2zXZft1aa77VRdp +ppc5oefDBC+MFMzaWNPkzRvtHGdL8lfEkfYLrznHijmALHPqJeO5NTvge99eDnluB1p VjVKVjs44I23W6BHpeREvTa4x2GchkukjTtSHNASDDoswIDmHdtmuCy/BkvrU3/wV8Wa B57Q== X-Gm-Message-State: AOAM530YKlT9c2X8fq1gjphwXGPDznsk98ov2cH86vqbNYLmKaTy+Sop qp7YUzzXH+x7SJjBaXxUV9hI6g== X-Google-Smtp-Source: ABdhPJzlT0nwkncrA8tygh2vgm+oBugX1DRxO+s57LIOaZAoV6vTcoZohz7bp+W9pItWsl0fDL6/YQ== X-Received: by 2002:a1c:e910:: with SMTP id q16mr3821369wmc.188.1594725360960; Tue, 14 Jul 2020 04:16:00 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:00 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Wen He , Jiaheng Fan Subject: [PATCH 10/17] dma: fsl-qdma: Fix 'struct fsl_qdma_format' formatting issue Date: Tue, 14 Jul 2020 12:15:39 +0100 Message-Id: <20200714111546.1755231-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Kerneldoc formatting for attributes should be '@.*: '. Fixes the following W=1 kernel build warning(s): drivers/dma/fsl-qdma.c:154: warning: Function parameter or member 'data' not described in 'fsl_qdma_format' Cc: Wen He Cc: Jiaheng Fan Signed-off-by: Lee Jones --- drivers/dma/fsl-qdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index 95cc0256b3878..c33f491fae3e5 100644 --- a/drivers/dma/fsl-qdma.c +++ b/drivers/dma/fsl-qdma.c @@ -136,7 +136,7 @@ * @__reserved1: Reserved field. * @cfg8b_w1: Compound descriptor command queue origin produced * by qDMA and dynamic debug field. - * @data Pointer to the memory 40-bit address, describes DMA + * @data: Pointer to the memory 40-bit address, describes DMA * source information and DMA destination information. */ struct fsl_qdma_format { From patchwork Tue Jul 14 11:15:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662381 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE6B313B4 for ; Tue, 14 Jul 2020 11:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C588A22208 for ; Tue, 14 Jul 2020 11:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NQ/hVm91" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbgGNLSw (ORCPT ); Tue, 14 Jul 2020 07:18:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727930AbgGNLQs (ORCPT ); Tue, 14 Jul 2020 07:16:48 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73E1BC08C5FD for ; Tue, 14 Jul 2020 04:16:03 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so20829689wrj.13 for ; Tue, 14 Jul 2020 04:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnI1Hr8cN1xgbEvUxkhLUJ4OsaPQfVlLvMmqI8pCO3s=; b=NQ/hVm91tDxmABEPbH0rNFSS8NGb/3PLnnApSOyHhscglrmoLOMyFWz5wtrlv5WEAc w7NAY2gdTBxkp94u7rS0Tgl3QOcWWldpWa1sZatsmBy4bkojuQ84zuqlGEmm43TZlNhe 7e3tzwADI4qKPfm21AmneVuYTXCGvYdl6nXLIBiAbNSxYm48Go5/XJhJbknaO85600l/ TzbhOUwbnb14+TgiQxeYmoqM4xnXjKW+V62qGrdsT14LaW6eknTWW9U8wx+FLbneGpIQ tr/AyMKX9X+pZ6WHkzUes84iQtVh7eyenP5X+cqfAeZa6IUYaorMUth/P/mYblGq+9S0 DidQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnI1Hr8cN1xgbEvUxkhLUJ4OsaPQfVlLvMmqI8pCO3s=; b=fpr91/BuibXWeX9ZnX15ver0wsgTvQ0BGCoxshuo/OSUrDKnCOXX0GapKawOxWjkmQ dQ80piTlENRhM2Mz7NADQsXiY2QCe//PKM50EzNYEi2kkZI2XiLkoWjPIwWevNiMwEpj 4XWmbBjncqphHHb1FPzoCxRAtxf3rgPhk+6CIfJdTDAh/2IsHwH9Qy0IHjKD1xI4ZfE9 +gpw1gH2ZBIWKXXDxSzYMd1OrCppNMnBicWBIeGjH44lxF29ZQ8zwLFOJr+Ppw5iEEz3 Nce0xOiQWCBRELbQDkHeXLKpJyJQD1KTtrTmGW9onoGSYNXgPypMMU0fNdalhR3zEUrb i2Nw== X-Gm-Message-State: AOAM531cON0JrWIKz0h/Eoha1gKbeHuxcAH3zLphG5cDmS2Wl6m4SNyk 5lF6MgPPAGHu7vtzZzEP9dc5+w== X-Google-Smtp-Source: ABdhPJzYlJ+XLLzRSmvIFCs1WJ2WYX+Cwdno9y3SVmnqqB4jRMVHTnl+GSY47lUzMwCDxwwOni3Ziw== X-Received: by 2002:adf:db86:: with SMTP id u6mr4773505wri.27.1594725362227; Tue, 14 Jul 2020 04:16:02 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:01 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH 11/17] dma: imx-sdma: Correct formatting issue and provide 2 new descriptions Date: Tue, 14 Jul 2020 12:15:40 +0100 Message-Id: <20200714111546.1755231-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/imx-sdma.c:383: warning: Function parameter or member 'slave_config' not described in 'sdma_channel' drivers/dma/imx-sdma.c:383: warning: Function parameter or member 'context_loaded' not described in 'sdma_channel' drivers/dma/imx-sdma.c:383: warning: Function parameter or member 'terminate_worker' not described in 'sdma_channel' Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Signed-off-by: Lee Jones --- drivers/dma/imx-sdma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 270992c4fe475..4f8d8f5e11329 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -335,7 +335,7 @@ struct sdma_desc { * @sdma: pointer to the SDMA engine for this channel * @channel: the channel number, matches dmaengine chan_id + 1 * @direction: transfer type. Needed for setting SDMA script - * @slave_config Slave configuration + * @slave_config: Slave configuration * @peripheral_type: Peripheral type. Needed for setting SDMA script * @event_id0: aka dma request line * @event_id1: for channels that use 2 events @@ -354,8 +354,10 @@ struct sdma_desc { * @shp_addr: value for gReg[6] * @per_addr: value for gReg[2] * @status: status of dma channel + * @context_loaded: ensure context is only loaded once * @data: specific sdma interface structure * @bd_pool: dma_pool for bd + * @terminate_worker: used to call back into terminate work function */ struct sdma_channel { struct virt_dma_chan vc; From patchwork Tue Jul 14 11:15:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662379 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3D30B13A4 for ; Tue, 14 Jul 2020 11:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23A1E22208 for ; Tue, 14 Jul 2020 11:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QMwhtxDa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbgGNLSw (ORCPT ); Tue, 14 Jul 2020 07:18:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727931AbgGNLQs (ORCPT ); Tue, 14 Jul 2020 07:16:48 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 852EBC08C5FF for ; Tue, 14 Jul 2020 04:16:04 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so20874385wrl.8 for ; Tue, 14 Jul 2020 04:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NG9Wo5yoqPGjiyqodzKSv+oNiGoDZQc2LrtiOZLw/AM=; b=QMwhtxDa+JsIYLGkUIZnWg3AJTpgFH0ficDCJzPtKLoaZCg8YduENGKsRoTzfb0QTz Gyu3Cqsat4DTRiNwff9MhhGJxWAsooiZxVz2Yp/6x0RpBecs9ejTuRPUEpJUZG75fi3X +P6gjwJGwpRpgD6jnp7+9mxe0EtP29RHfFxLUFtSXHH/C+je3VQ7E40NHqdEoGoiuWAD bIbdmUhQEcsv+lomE5TNhgItLBYNn65TwW9BP3v2Bw4Ie4p4y+BC0M4QzjX5NB01jxyG VlD9mWRFwKCxJVSb/6HyXNPrS6UmSuXj9Ya3O8ddMBXpU5Ree0hlB8zVke5Id4lo3q6n u0Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NG9Wo5yoqPGjiyqodzKSv+oNiGoDZQc2LrtiOZLw/AM=; b=OhUM7z5JX31qh7JxCy3iOPaoTqFkUFH7iiBPoMqG191fSUwn25AONSjTRZ9vrAemtp St6u40jb9m9Uy1fpRsg5sfPX+czPYkdIFf8rv/P7mAXSdXA5gfds2rR/alFZ+E6JXEwy Z03806IpmcHXh2OT1mnoRWtdM9tL1HSnaigeq1CRhlRAcYdZ3qUL93g3HyuiYl27W8dM TQE0m4NXPwOCPAWg634S1X8VtF2nwXRDyKQ/B0lbaBF+IY8A9AyE5KWgh9eJyIJz1rtk /XiHmyte0NmvCSmIdUSQi9PEk5Eq6kYF/XGXLGC83f+AQv7XTrGrl67KBYkjDIofVKSx QTNw== X-Gm-Message-State: AOAM531U95/DwT8ze+FK+Z6DbfdQcdTMp1YqSWuW/Z663GugxKBtRLYz k/77B9Nnw57oO1R3HrtBNlvbcw== X-Google-Smtp-Source: ABdhPJzQhzUPxkgJqMX4nrpyi4zj2gxa+lDyykGrb8nrWKpjpsCsNGmOs+AiZhWEbBSh2KpnpmRSug== X-Received: by 2002:adf:f388:: with SMTP id m8mr4801297wro.338.1594725363325; Tue, 14 Jul 2020 04:16:03 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:02 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones Subject: [PATCH 12/17] dma: iop-adma: Function parameter documentation must adhere to correct formatting Date: Tue, 14 Jul 2020 12:15:41 +0100 Message-Id: <20200714111546.1755231-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Also remove superfluous entry. Fixes the following W=1 kernel build warning(s): drivers/dma/iop-adma.c:418: warning: Function parameter or member 'chan' not described in 'iop_adma_alloc_chan_resources' Signed-off-by: Lee Jones --- drivers/dma/iop-adma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c index db0e274126fb7..3350bffb2e937 100644 --- a/drivers/dma/iop-adma.c +++ b/drivers/dma/iop-adma.c @@ -406,8 +406,7 @@ static void iop_chan_start_null_xor(struct iop_adma_chan *iop_chan); /** * iop_adma_alloc_chan_resources - returns the number of allocated descriptors - * @chan - allocate descriptor resources for this channel - * @client - current client requesting the channel be ready for requests + * @chan: allocate descriptor resources for this channel * * Note: We keep the slots for 1 operation on iop_chan->chain at all times. To * avoid deadlock, via async_xor, num_descs_in_pool must at a minimum be From patchwork Tue Jul 14 11:15:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662413 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D0CE13B6 for ; Tue, 14 Jul 2020 11:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3407222208 for ; Tue, 14 Jul 2020 11:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b1sAb44W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727971AbgGNLUU (ORCPT ); Tue, 14 Jul 2020 07:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727858AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28DEC08E81E for ; Tue, 14 Jul 2020 04:16:05 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z13so20887461wrw.5 for ; Tue, 14 Jul 2020 04:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z/zoKcrmx2IW2qZYN8v07zqfWyovJdKlsFhRtVJoj8Y=; b=b1sAb44WGmZFCdVAFpOnOB6gjm1ZuIfnH5qfH6jEl7r1V5Ot0bj2a/haai/zLlbGwZ jyft/gXpKRKwhcAmBF6N1E3tVUv3FpyxaQDJbEMA+kzxFOdi5i/iC+SuVdGwUK3S7lkC JCMyVtDbRUfFVhAZkbBSmtUupdpqKKxXkUPJTaoOYPu5dPFvyg6Blg9WrDMzB/cseVM+ rhmyyRlfWyztEMer+eWo6n3Do/AXv5WhKdZaS+4tgq6H2R8pELz1fQ3yZJcDDG53AKI8 o6mlh08h6jJhiGMzg1aEP83hrtSL2JwTrrM/lGjoC5Bpn1y65cxU+TAsW9GNOLI5/kNh tUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z/zoKcrmx2IW2qZYN8v07zqfWyovJdKlsFhRtVJoj8Y=; b=C/qmRVplk8FX5cMggCBQU0MrqgUBYo1suMjoCKJwVpASeO6eivHSeAHIjpNUc6chsC CxkBF5P7mScdbc5KIEfu2jOO4bN/wKSyNqL+3FTjdiG8XWOZAp10mBOX69USHwiUrwrO za+/pod+oNmK2SpdpAmaipg3Qe0IwXi/Ys/E5SPJm4n8eneRwWHUYH1fMKp25TZuHyKr KxVg10k+1zJGjQ9XSvjLvEImyY8wn1oOsRDbZwX6LKap0JPEHGIPSkIgMKVEMzRGyrFf Sfk9Nto0PzbKUCiEmuD6+L24sD4Cc4pFDXl64sTimSKHsA5SfYz3uK7Y4wrBS16XnOyZ qCTg== X-Gm-Message-State: AOAM5313L2qLWKtuvqU37+RtgCSB0iCCptIyO9r4pigLk2IKHDElCfS+ c8U9LpH15aBG6VZMSs37svL/8Q== X-Google-Smtp-Source: ABdhPJyAUbTKcS5Sll5KxkNhZWdfScOwNs01z+UT0g/DeH+FLBo8B9AbZI4twgzB3lN+ZB/l5mfLmQ== X-Received: by 2002:a5d:698e:: with SMTP id g14mr4923996wru.301.1594725364528; Tue, 14 Jul 2020 04:16:04 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:03 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Guennadi Liakhovetski , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 13/17] dma: nbpfaxi: Provide some missing attribute docs and split out slave info Date: Tue, 14 Jul 2020 12:15:42 +0100 Message-Id: <20200714111546.1755231-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/nbpfaxi.c:157: warning: Function parameter or member 'chan' not described in 'nbpf_desc' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'tasklet' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_addr' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_width' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_src_burst' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_addr' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_width' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'slave_dst_burst' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'running' not described in 'nbpf_channel' drivers/dma/nbpfaxi.c:220: warning: Function parameter or member 'paused' not described in 'nbpf_channel' Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Martin KaFai Lau Cc: Song Liu Cc: Yonghong Song Cc: Andrii Nakryiko Cc: John Fastabend Cc: KP Singh Cc: Guennadi Liakhovetski Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones --- drivers/dma/nbpfaxi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c index 594409a6e9752..74df621402e10 100644 --- a/drivers/dma/nbpfaxi.c +++ b/drivers/dma/nbpfaxi.c @@ -144,6 +144,7 @@ struct nbpf_link_desc { * @async_tx: dmaengine object * @user_wait: waiting for a user ack * @length: total transfer length + * @chan: associated DMAC channel * @sg: list of hardware descriptors, represented by struct nbpf_link_desc * @node: member in channel descriptor lists */ @@ -174,13 +175,17 @@ struct nbpf_desc_page { /** * struct nbpf_channel - one DMAC channel * @dma_chan: standard dmaengine channel object + * @tasklet: channel specific tasklet used for callbacks * @base: register address base * @nbpf: DMAC * @name: IRQ name * @irq: IRQ number - * @slave_addr: address for slave DMA - * @slave_width:slave data size in bytes - * @slave_burst:maximum slave burst size in bytes + * @slave_src_addr: source address for slave DMA + * @slave_src_width: source slave data size in bytes + * @slave_src_burst: maximum source slave burst size in bytes + * @slave_dst_addr: destination address for slave DMA + * @slave_dst_width: destination slave data size in bytes + * @slave_dst_burst: maximum destination slave burst size in bytes * @terminal: DMA terminal, assigned to this channel * @dmarq_cfg: DMA request line configuration - high / low, edge / level for NBPF_CHAN_CFG * @flags: configuration flags from DT @@ -191,6 +196,8 @@ struct nbpf_desc_page { * @active: list of descriptors, scheduled for processing * @done: list of completed descriptors, waiting post-processing * @desc_page: list of additionally allocated descriptor pages - if any + * @running: linked descriptor of running transaction + * @paused: are translations on this channel paused? */ struct nbpf_channel { struct dma_chan dma_chan; From patchwork Tue Jul 14 11:15:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 54EB513B6 for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C47212CC for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fqu+JGaF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728010AbgGNLUT (ORCPT ); Tue, 14 Jul 2020 07:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D82C08E886 for ; Tue, 14 Jul 2020 04:16:06 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 17so5003771wmo.1 for ; Tue, 14 Jul 2020 04:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tHvsPtXMawqhgTlXf8i2jhQs/B2cBsj2Ks/fZJOcmHY=; b=Fqu+JGaFSRh7vRRPgR/HabR8IBZaeLvvr2EcwSrSv7QCI/6fOnODRUdqwt90J3g5C8 0s7/ZkCY/MC07cLGz5P6eZPk8H0sOh7MIQCT3wT/fmUP0dZZvRlB6+ROihSuNTcRcnrn 3f/KQJT0rXlJvq27p2T59AjfgIz20tp6gxCQwiRj2g3DFceT0HNj5P5tLxs2F3WUfGUr BCztbiua/SQvCo0rqC98vsPQJ6hLsJvnB5rS2qxatc4pm34FHMoA/X6H2H78RvRzapwC 7c22y4tqYny0qVqhSNYiSLAngITlsOr2bNM3rVNtPcNOiSxaFmQjsg/AEf1VCrEiPz2W p5Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tHvsPtXMawqhgTlXf8i2jhQs/B2cBsj2Ks/fZJOcmHY=; b=HPJryujxIm0l8lVQG2WqWsfKeRaLAKj3mj1TzKBeqUTbk5JJgBnFucjXUycMa829Qo pl0A6iEPt/u6CW9q8v73/S9fJrwj7Zhq93fnoikCzq/WLo+EG35+YyRjBdRiFRfyq91G XDtLO3QRsHUHgoCsId8Q1UNXgDbJKIKIhUxcHJMaZmMmEuayyC75Reqg67Utp2VQbBMK wNS5LXrAX3JPVqPI3HGCfZyPr5LQyoVKeNe5Wcg6+HLbRmofXySftLrwFaIRzYJ7juNn bhYDHaBZls4b20BeADXXvzaJa/GdoKkOYh1qHeoSr/UnmKUSjAMKO5O/SUOHj/FW2bdH 7YPg== X-Gm-Message-State: AOAM531SJR9bDT5MZNhozF6FRCaxEL3m0lhrkLrA5ZK14Zjgua15XP7s JwBky/6S8euPlftS4kw66I5Zhw== X-Google-Smtp-Source: ABdhPJxVoSxX2N3tawtWC/yLdMqtT4pktyn2twbJ8qTyWyZpqmkc6sC5zihRJLY5WtskmmQJi5EWrw== X-Received: by 2002:a05:600c:2116:: with SMTP id u22mr3778571wml.82.1594725365560; Tue, 14 Jul 2020 04:16:05 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:05 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Prasad Sahu , Loc Ho Subject: [PATCH 14/17] dma: xgene-dma: Provide descriptions for 'dev' and 'clk' in device's ddata Date: Tue, 14 Jul 2020 12:15:43 +0100 Message-Id: <20200714111546.1755231-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/xgene-dma.c:310: warning: Function parameter or member 'dev' not described in 'xgene_dma' drivers/dma/xgene-dma.c:310: warning: Function parameter or member 'clk' not described in 'xgene_dma' Cc: Prasad Sahu Cc: Loc Ho Signed-off-by: Lee Jones --- drivers/dma/xgene-dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c index cd60fa6d67501..4f733d37a22e2 100644 --- a/drivers/dma/xgene-dma.c +++ b/drivers/dma/xgene-dma.c @@ -287,6 +287,8 @@ struct xgene_dma_chan { /** * struct xgene_dma - internal representation of an X-Gene DMA device + * @dev: reference to this device's struct device + * @clk: reference to this device's clock * @err_irq: DMA error irq number * @ring_num: start id number for DMA ring * @csr_dma: base for DMA register access From patchwork Tue Jul 14 11:15:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662407 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C87313B4 for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02BA92082F for ; Tue, 14 Jul 2020 11:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r07S7f0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727989AbgGNLUT (ORCPT ); Tue, 14 Jul 2020 07:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbgGNLSm (ORCPT ); Tue, 14 Jul 2020 07:18:42 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531D2C08E8A0 for ; Tue, 14 Jul 2020 04:16:08 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j4so20884339wrp.10 for ; Tue, 14 Jul 2020 04:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ewSSWUW/45nS/yx3Bple4Rafu63cuthV60wjjsFm31o=; b=r07S7f0JSGNo1Nt9IZFRGGvi9Lp2WCC0rUzVkAvOq5O5uuetYvLH26mbxDtnyAveOz frcZe2zibwjQUBdEtszl73MgfdEyhSWZPApwvfZbtovOiVCL+WQ62RhmhxnQcZamm8Xu 3/+y9QgaGUFjp0zbF74w49tY4gMxtfrYEhyvpwi1E5zAnvOXnxeahcfETAjZ8zxWDFQR y8d4IbJ64kqiAxtEplpKCvRtSMPMDLwDzaSZYdo7ZjIcV83l6ES2n2CSsfPa7S0tsFm2 WaARQ9l+CbHGQ1v3IShviPOp0RquLwYS1UYGGtDANowawECxzEayp2QTi3YOTEl+9InD KT1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ewSSWUW/45nS/yx3Bple4Rafu63cuthV60wjjsFm31o=; b=s2QVfiZAZwghiNqiH1t4UCpFZN/UAuRmr0vLqDmv12mqlSAzyvRoLiRph1AYWDThq+ fUJYzpkKxd4KN2CvTX1ZhKNVsOPqg6Tq9kzp4RJMA8mqCbVjeExbDHP4ausgVI6qHABT wMBFcYoOYG3ZhLahyyIBVUH1TSWtGTi7Wetos0nYwHtA4lBISmmN3NGP0+53z9z4BXyv j6+ceZbqEILkwMdkdoqs3864EpFJvdVuZ94tnpi22H82sT5lJt9ep4oighTaOcCrfFU5 ZnXsj6+7iYVDknNitk9L6bEDaqr0smy8EY4+NTKd9eF0tKb/UKwqj0j8Fj7nyC7ArspE Uu0g== X-Gm-Message-State: AOAM532n6xJIrHpoc46cxyLZq2Ixmy07zlEsp6ZCP78NBvIPphg1kSZK tIkCVIAu7uvxukjQ/fenfADh8A== X-Google-Smtp-Source: ABdhPJwOpZLkCp6n4syZLc9H9p9CNZPkWXr22M9kvz71NJK/JQzp8BLfmFRHWp3bAZgklkl2RAAp0Q== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr4330551wrs.33.1594725367098; Tue, 14 Jul 2020 04:16:07 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:06 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones Subject: [PATCH 15/17] dma: mv_xor_v2: Supply some missing 'struct mv_xor_v2_device' attribute docs Date: Tue, 14 Jul 2020 12:15:44 +0100 Message-Id: <20200714111546.1755231-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'clk' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'reg_clk' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'irq_tasklet' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'hw_queue_idx' not described in 'mv_xor_v2_device' drivers/dma/mv_xor_v2.c:168: warning: Function parameter or member 'msi_desc' not described in 'mv_xor_v2_device' Signed-off-by: Lee Jones --- drivers/dma/mv_xor_v2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index 157c959311eaf..9225f08dfee92 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -135,9 +135,11 @@ struct mv_xor_v2_descriptor { /** * struct mv_xor_v2_device - implements a xor device * @lock: lock for the engine + * @clk: reference to the 'core' clock + * @reg_clk: reference to the 'reg' clock * @dma_base: memory mapped DMA register base * @glob_base: memory mapped global register base - * @irq_tasklet: + * @irq_tasklet: tasklet used for IRQ handling call-backs * @free_sw_desc: linked list of free SW descriptors * @dmadev: dma device * @dmachan: dma channel @@ -146,6 +148,8 @@ struct mv_xor_v2_descriptor { * @sw_desq: SW descriptors queue * @desc_size: HW descriptor size * @npendings: number of pending descriptors (for which tx_submit has + * @hw_queue_idx: HW queue index + * @msi_desc: local interrupt descriptor information * been called, but not yet issue_pending) */ struct mv_xor_v2_device { From patchwork Tue Jul 14 11:15:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E5ED138C for ; Tue, 14 Jul 2020 11:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12CE222208 for ; Tue, 14 Jul 2020 11:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pbKjjlMz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbgGNLUU (ORCPT ); Tue, 14 Jul 2020 07:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728157AbgGNLSr (ORCPT ); Tue, 14 Jul 2020 07:18:47 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E7F6C08E8AA for ; Tue, 14 Jul 2020 04:16:09 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f2so20826588wrp.7 for ; Tue, 14 Jul 2020 04:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NWVbeI3JQ64+Db8G4vi0TII3jbdljajswVKqeX2AaNk=; b=pbKjjlMz+yuId3GnPdr+6e7242L15C8zpZ8cI32mV6xd6AgENPK00kT71vMS4zOEUQ BZiKrF66/XjLDH28yMZs8xHjFIparf2OgetsOT625Mif3xJ1q8QNLhyQtuK7TGfZUNIr CCj18IDVn978g2dBSbIwr5b38Pq9EwmlS120Y77bC8ePRFzM8Q56ZfUktL7RchA2vkT5 u5WCyG9mExt5AiqtFF84SoZFQZZshdlOkMoEgh6kK8rhIdvqnnVvWrj3OTAyPe9rWQLc ErVVxOlolsFySUFnE8kq65UQFNT1RnKfPw0BhzkytqrRJQZNY7Rt5ThFUPrGUW6rf9Ea d7wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NWVbeI3JQ64+Db8G4vi0TII3jbdljajswVKqeX2AaNk=; b=ME7dMnCwAv06RtcTydQuE/XXgvLwI5NftnNzENfXh9HPtkQ0W5so4u2wV9CU5XSzVT 7g2yhxrZ6FHSGmeKWLDJjauOu6z6hCo/nhdg9gwW7V0A8vmE/TQRSiaCkhVqbmDbWNpY T7th0HvbN2xlWvRpmUXKviiLgW+VmDDyuo8KUHV+EWi0NK+mLu3LFeb8eYd0nJa+sirM /+hJkY5Uk+Be3cDACuX7xCNcZqoDFep9Iaxaibjrlub1BUXq5LVhrITfvlqb1cguiAkp 8sjE66MqebxRqelAvf5x2S30BmwjmnKh9czNoSqC4PZY9GZCyEL7aiPRPeNmGGf47A77 4gvA== X-Gm-Message-State: AOAM532R5AOWr02t4HvrLlnIp4YCZjyjSL78EjW5NwXTxE8ZkwvkFOPy 6THbeKnZoAGhUhgxtkg5JZgKdQ== X-Google-Smtp-Source: ABdhPJy/Z9vM5I8MKYqwiF/ImZ+zlunr0KhgAAKurSmz0v7+QqjmsliobL9ygI2dqTBBUF+btm1W9g== X-Received: by 2002:a5d:4a84:: with SMTP id o4mr4756252wrq.104.1594725368354; Tue, 14 Jul 2020 04:16:08 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:07 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Logan Gunthorpe Subject: [PATCH 16/17] dma: ioat: init: Correct misspelling of function parameter 'c' for channel Date: Tue, 14 Jul 2020 12:15:45 +0100 Message-Id: <20200714111546.1755231-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/ioat/init.c:608: warning: Function parameter or member 'c' not described in 'ioat_free_chan_resources' drivers/dma/ioat/init.c:608: warning: Excess function parameter 'chan' description in 'ioat_free_chan_resources' Cc: Logan Gunthorpe Signed-off-by: Lee Jones --- drivers/dma/ioat/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c index 20a4f36a2f6ea..8a53f5c96b168 100644 --- a/drivers/dma/ioat/init.c +++ b/drivers/dma/ioat/init.c @@ -602,7 +602,7 @@ static void ioat_enumerate_channels(struct ioatdma_device *ioat_dma) /** * ioat_free_chan_resources - release all the descriptors - * @chan: the channel to be cleaned + * @c: the channel to be cleaned */ static void ioat_free_chan_resources(struct dma_chan *c) { From patchwork Tue Jul 14 11:15:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11662415 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1EEB138C for ; Tue, 14 Jul 2020 11:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3BCE22203 for ; Tue, 14 Jul 2020 11:20:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="olMroX2n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727045AbgGNLUg (ORCPT ); Tue, 14 Jul 2020 07:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728158AbgGNLSr (ORCPT ); Tue, 14 Jul 2020 07:18:47 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74D8C08E8AB for ; Tue, 14 Jul 2020 04:16:11 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so4768253wmh.4 for ; Tue, 14 Jul 2020 04:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=olMroX2nvIY5Lf+mJdh7YdFYN9DJVM3DML7ddb9rOUmNTds3C+m2JdC3mqOc4y2yki oCjN/ROWc7AHqc9tDEJzhS48Ft6N8WDIfr4nT2lTE5jdLWQGIWrolpNjO+lPcicdCRRM 2fCsqXPM7bJUnvwrgFNVo7ICmUoZdIFs0+zJzOFi3XIgI9grTk89B6Pv4TQQAvkhtRye 9sjSmijV4C2Z3rQ8tSb74WzoWGcSTqF9z7JoxwTfy5DhX28xoARq2ihF4ykZe7GW8r58 nDxZdTjaN05xW+eeHH3pFOqwpav7WW2J+QyIHz+GahF3UcEzGl7obV8i3hDK+YXlBs7R Pf0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=OyYs/dYx8sdl4nkqv++QdHfFkv5yZ7FHzkjKRmCFrD5XLhdwKucQoFajHNe8NwmArt TdjDUfrXvzLXWPdfV7K5b5mVR/2ukpQ13vMLjIofirL3mfm/QW62dHY9GrdH16fI4oOo nRN22u+L85HRi6Zkm5YKWqpBnByS5ceXp5CxmeQR2rOEo7jRu3Cw1fxmHYoHqOf31Lyl A6hO3MB6Y6iSmzVaXtt4AOn8qRwwGiu7oQH5aFpssCnUEmyU8GeQGoC8hK03bWLb+F9p 9Qo9B43lnQA2r74HpHebxVUmDAQIuFKGj++Z+KoTT2ARgAwPl/PcMxf3uNt6vyQ0KklP yS4w== X-Gm-Message-State: AOAM531FYehaHnYpU8o5jibfI3HVYfiv4J6lbZ5h2xfEcowgzvyznNlo y+0VAucn41WsmAsMaUmHsIyUwg== X-Google-Smtp-Source: ABdhPJzfCBA237+MDiPPiC6gnBUiuuivn5CvYJKDoBxN2PB52EY3xNb72wTKP7tCyZ9qJUnt4SpQXw== X-Received: by 2002:a1c:7209:: with SMTP id n9mr3892120wmc.150.1594725369516; Tue, 14 Jul 2020 04:16:09 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:08 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Dave Jiang , Leonid Ravich Subject: [PATCH 17/17] dma: ioat: dma: Fix some parameter misspelling and provide description for phys_complete Date: Tue, 14 Jul 2020 12:15:46 +0100 Message-Id: <20200714111546.1755231-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/ioat/dma.c:202: warning: Function parameter or member 'ioat_chan' not described in 'ioat_update_pending' drivers/dma/ioat/dma.c:202: warning: Excess function parameter 'ioat' description in 'ioat_update_pending' drivers/dma/ioat/dma.c:465: warning: Function parameter or member 'ioat_chan' not described in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:465: warning: Excess function parameter 'ioat' description in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'ioat_chan' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'phys_complete' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Excess function parameter 'ioat' description in '__cleanup' Cc: Dave Jiang Cc: Leonid Ravich Signed-off-by: Lee Jones --- drivers/dma/ioat/dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index fd782aee02d92..a814b200299bf 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -193,7 +193,7 @@ void ioat_issue_pending(struct dma_chan *c) /** * ioat_update_pending - log pending descriptors - * @ioat: ioat+ channel + * @ioat_chan: ioat+ channel * * Check if the number of unsubmitted descriptors has exceeded the * watermark. Called with prep_lock held @@ -457,7 +457,7 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags) /** * ioat_check_space_lock - verify space and grab ring producer lock - * @ioat: ioat,3 channel (ring) to operate on + * @ioat_chan: ioat,3 channel (ring) to operate on * @num_descs: allocation length */ int ioat_check_space_lock(struct ioatdma_chan *ioat_chan, int num_descs) @@ -585,7 +585,8 @@ desc_get_errstat(struct ioatdma_chan *ioat_chan, struct ioat_ring_ent *desc) /** * __cleanup - reclaim used descriptors - * @ioat: channel (ring) to clean + * @ioat_chan: channel (ring) to clean + * @phys_complete: zeroed (or not) completion address (from status) */ static void __cleanup(struct ioatdma_chan *ioat_chan, dma_addr_t phys_complete) {