From patchwork Tue Jul 14 14:50:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663005 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F07B4722 for ; Tue, 14 Jul 2020 14:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF48122473 for ; Tue, 14 Jul 2020 14:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mPwQpN+Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728418AbgGNOu4 (ORCPT ); Tue, 14 Jul 2020 10:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbgGNOuy (ORCPT ); Tue, 14 Jul 2020 10:50:54 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947BFC061794 for ; Tue, 14 Jul 2020 07:50:54 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id q5so22194932wru.6 for ; Tue, 14 Jul 2020 07:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PyDCzRLu9Rp5ffLvCZoaXuGAE+qn3bcIj12X3rgDaY8=; b=mPwQpN+Qu91QZ2MKryhuGiiJzJqon/gMYBCzo8EhqXVyHMQU0f+SMVudmHG3byrsFK JJYM1icU5EgZZbY6UYqyJwH565d2EsGYC3ePxJSqwzt3Sa2srbEpSqLjlpkYKxWjp1tw ujqOlhVyy3Yhl2YAiVxMF+wEXe1nzyw7RUCYva3xlELef2BJOfsvWrUonzTeAAs2K2cl +OI1ZY/+TGOGmYtPt09UgSnQS0g97Lw8dAr+PkDKclYLsAo6vPt4dQpPqsTDRb+XCLLN +QPntCH68/N596jApxTdK3oGeuqqT+RPWpopbMCXmfq3KHiUYiEjhSsk2tsn5jF4REAr 5jDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PyDCzRLu9Rp5ffLvCZoaXuGAE+qn3bcIj12X3rgDaY8=; b=QsyEyZr2vkEJeMJvcAKkOkm5xzSxopDZJY5n44Cdi8ng+r9YeGX6mpKxNeR4Ib2k/t t1/jKjUMCtH2LADfypDUyZRkWTU1AlVXZLV3AZxrZKxg9wbtx7jPCLrBHp046UWlDHJf Tjyc2OLEHESUmC8BpL2wt0hLBKP4pRPepWDJPHOg8XnVLDukHwoGyufUmJfB3ABMqECt 99X2RxBzdAPh8OzEnp9CapZeWra88oLGKK8OAM7AFE10Mp2YUrBccmdvOD5jy1Fl4lyp FnFRu80g/bpAvNXm1kXBzF86IbivfwWqmHO3jtUrqA25Xfgd3oJJIEB/WCZmVXVpL8hq 3Plg== X-Gm-Message-State: AOAM533cU6R9ZeZ694YNLh62pLa1PPFjc+5pL09CIHycO5eYNnG7u16s YZRt67hwG5YNPxS6+PlPEVaJ+Vo0sA8= X-Google-Smtp-Source: ABdhPJyfB1Tf3EHgK0lx0lDBNPNcHN0//kJ4X5HF1TFk9KcRccYA9FoOD6xF1iEC2VIyddc1Jc7SAA== X-Received: by 2002:a5d:4c82:: with SMTP id z2mr5923643wrs.287.1594738253227; Tue, 14 Jul 2020 07:50:53 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:52 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Dominik Brodowski Subject: [PATCH 01/13] cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 15:50:37 +0100 Message-Id: <20200714145049.2496163-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'policy' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'buf' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:229: warning: Function parameter or member 'show_boost' not described in 'show_available_freqs' drivers/cpufreq/freq_table.c:269: warning: Function parameter or member 'policy' not described in 'scaling_available_frequencies_show' drivers/cpufreq/freq_table.c:269: warning: Function parameter or member 'buf' not described in 'scaling_available_frequencies_show' drivers/cpufreq/freq_table.c:281: warning: Function parameter or member 'policy' not described in 'scaling_boost_frequencies_show' drivers/cpufreq/freq_table.c:281: warning: Function parameter or member 'buf' not described in 'scaling_boost_frequencies_show' Cc: Dominik Brodowski Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/freq_table.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c index e117b0059123e..f839dc9852c08 100644 --- a/drivers/cpufreq/freq_table.c +++ b/drivers/cpufreq/freq_table.c @@ -221,7 +221,7 @@ int cpufreq_frequency_table_get_index(struct cpufreq_policy *policy, } EXPORT_SYMBOL_GPL(cpufreq_frequency_table_get_index); -/** +/* * show_available_freqs - show available frequencies for the specified CPU */ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, @@ -260,7 +260,7 @@ static ssize_t show_available_freqs(struct cpufreq_policy *policy, char *buf, struct freq_attr cpufreq_freq_attr_##_name##_freqs = \ __ATTR_RO(_name##_frequencies) -/** +/* * show_scaling_available_frequencies - show available normal frequencies for * the specified CPU */ @@ -272,7 +272,7 @@ static ssize_t scaling_available_frequencies_show(struct cpufreq_policy *policy, cpufreq_attr_available_freq(scaling_available); EXPORT_SYMBOL_GPL(cpufreq_freq_attr_scaling_available_freqs); -/** +/* * show_available_boost_freqs - show available boost frequencies for * the specified CPU */ From patchwork Tue Jul 14 14:50:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663029 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E348722 for ; Tue, 14 Jul 2020 14:51:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E7C221973 for ; Tue, 14 Jul 2020 14:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YEcBJ/q7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgGNOvm (ORCPT ); Tue, 14 Jul 2020 10:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728326AbgGNOu4 (ORCPT ); Tue, 14 Jul 2020 10:50:56 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEEDFC061755 for ; Tue, 14 Jul 2020 07:50:55 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z13so22178210wrw.5 for ; Tue, 14 Jul 2020 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ihjHslCIw8qoMVK4GXrRB+3Lj/xZDniOVXUYfLOZNm8=; b=YEcBJ/q7/mLdEyofaH1QpMzFdOfql2c06Deu4Gj8zwMCMhKcM5c8YQYC+jEM7HJq2u liLKBjUuGd8RudZiUYzZrrWTRL/RaYpcFJ1xzgCLo9lbT2hEK4trRnz+BCDJx2QAz3M0 nIw/VRbG5eFVnIz7UzRsPMth8wn9XdhvZsGxmaOgGGldEVpyDiIZSKn/Gy1//wNd5tcF gelOWreE6XE15uo39TT7C5n8hnFfJCn8mhhn99cu5DUJMAYAL4RB1/HndMjU7qi3rhye brmqOvYtDeXs6fO08TuvEMIW3EMKQzskdg4lh+AhfPJMUzslv3vPIwI7fNtv9NhKbGcH adIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ihjHslCIw8qoMVK4GXrRB+3Lj/xZDniOVXUYfLOZNm8=; b=VEdstT+iiD+TeAYQtO7LGxL+uvgGjUKxAWTDdngR40x/2wER7+CwDUgrcszQL+cqcn yzpcVLrEvY2H0hMCrUJlLwvYULp3Pt472d4Rj3g/LZVwZ8eG53SmnUkAnINrV6Y9MSXt 45+d6wfiSrzv+WkZd5X41H31Yizihx4f0wAls0d0QQgOTTOUj+5Gz+viC+S/QWhvf+r8 zex6rkmflo0VUM5NmqgDbFDS9D6K80kv2jfD/RYlnw8oZoX0C6CoTvsoLkprAnTxrxTa yC0djKjajgm5e8xKctnAqvrQ0acxP+zPeFlvwDxRNVxdYQaRs4d7jWoPICOU8XfcmYR8 fZaw== X-Gm-Message-State: AOAM533C2pUUAYxShOVypSBTjFl7WFawvwUJPLnfoiT5B2oyQp7yeK2o 1dRSJ9DaoH17xK1hYuJzqS2tpg== X-Google-Smtp-Source: ABdhPJwzq69EoF6A0ryhfZcTCDHp9k1EFZj2+M3oKKC0bVvjPj1f1QUC3IU6l7A16+RPYZFneZO5UA== X-Received: by 2002:adf:f18c:: with SMTP id h12mr5882500wro.375.1594738254389; Tue, 14 Jul 2020 07:50:54 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:53 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Dominik Brodowski , Ashok Raj , Jacob Shin Subject: [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Date: Tue, 14 Jul 2020 15:50:38 +0100 Message-Id: <20200714145049.2496163-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Also provide missing function parameter description for 'cpu' and 'policy'. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/cpufreq.c:60: warning: cannot understand function prototype: 'struct cpufreq_driver *cpufreq_driver; ' drivers/cpufreq/cpufreq.c:90: warning: Function parameter or member 'cpufreq_policy_notifier_list' not described in 'BLOCKING_NOTIFIER_HEAD' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'val' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:312: warning: Function parameter or member 'ci' not described in 'adjust_jiffies' drivers/cpufreq/cpufreq.c:538: warning: Function parameter or member 'policy' not described in 'cpufreq_driver_resolve_freq' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'file_name' not described in 'show_one' drivers/cpufreq/cpufreq.c:686: warning: Function parameter or member 'object' not described in 'show_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'file_name' not described in 'store_one' drivers/cpufreq/cpufreq.c:731: warning: Function parameter or member 'object' not described in 'store_one' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'policy' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:741: warning: Function parameter or member 'buf' not described in 'show_cpuinfo_cur_freq' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'policy' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:754: warning: Function parameter or member 'buf' not described in 'show_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'policy' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'buf' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:770: warning: Function parameter or member 'count' not described in 'store_scaling_governor' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'policy' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:806: warning: Function parameter or member 'buf' not described in 'show_scaling_driver' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'policy' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:815: warning: Function parameter or member 'buf' not described in 'show_scaling_available_governors' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'policy' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:859: warning: Function parameter or member 'buf' not described in 'show_related_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'policy' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:867: warning: Function parameter or member 'buf' not described in 'show_affected_cpus' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'policy' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:901: warning: Function parameter or member 'buf' not described in 'show_bios_limit' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'dev' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:1625: warning: Function parameter or member 'sif' not described in 'cpufreq_remove_dev' drivers/cpufreq/cpufreq.c:2380: warning: Function parameter or member 'cpu' not described in 'cpufreq_get_policy' drivers/cpufreq/cpufreq.c:2771: warning: Function parameter or member 'driver' not described in 'cpufreq_unregister_driver' Cc: Dominik Brodowski Cc: Ashok Raj Cc: Jacob Shin Signed-off-by: Lee Jones --- drivers/cpufreq/cpufreq.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 036f4cc42ede2..17c1c3becd925 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -52,7 +52,7 @@ static LIST_HEAD(cpufreq_governor_list); static char default_governor[CPUFREQ_NAME_LEN]; -/** +/* * The "cpufreq driver" - the arch- or hardware-dependent low * level driver of CPUFreq support, and its spinlock. This lock * also protects the cpufreq_cpu_data array. @@ -80,7 +80,7 @@ static int cpufreq_set_policy(struct cpufreq_policy *policy, struct cpufreq_governor *new_gov, unsigned int new_pol); -/** +/* * Two notifier lists: the "policy" list is involved in the * validation process for a new CPU frequency policy; the * "transition" list for kernel code that needs to handle @@ -300,7 +300,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu) * EXTERNALLY AFFECTING FREQUENCY CHANGES * *********************************************************************/ -/** +/* * adjust_jiffies - adjust the system "loops_per_jiffy" * * This function alters the system "loops_per_jiffy" for the clock @@ -526,6 +526,7 @@ EXPORT_SYMBOL_GPL(cpufreq_disable_fast_switch); /** * cpufreq_driver_resolve_freq - Map a target frequency to a driver-supported * one. + * @policy: associated policy to interrogate * @target_freq: target frequency to resolve. * * The target to driver frequency mapping is cached in the policy. @@ -670,7 +671,7 @@ static struct cpufreq_governor *cpufreq_parse_governor(char *str_governor) return get_governor(str_governor); } -/** +/* * cpufreq_per_cpu_attr_read() / show_##file_name() - * print out cpufreq information * @@ -712,7 +713,7 @@ static ssize_t show_scaling_cur_freq(struct cpufreq_policy *policy, char *buf) return ret; } -/** +/* * cpufreq_per_cpu_attr_write() / store_##file_name() - sysfs write access */ #define store_one(file_name, object) \ @@ -733,7 +734,7 @@ static ssize_t store_##file_name \ store_one(scaling_min_freq, min); store_one(scaling_max_freq, max); -/** +/* * show_cpuinfo_cur_freq - current CPU frequency as detected by hardware */ static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy, @@ -747,7 +748,7 @@ static ssize_t show_cpuinfo_cur_freq(struct cpufreq_policy *policy, return sprintf(buf, "\n"); } -/** +/* * show_scaling_governor - show the current policy for the specified CPU */ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf) @@ -762,7 +763,7 @@ static ssize_t show_scaling_governor(struct cpufreq_policy *policy, char *buf) return -EINVAL; } -/** +/* * store_scaling_governor - store policy for the specified CPU */ static ssize_t store_scaling_governor(struct cpufreq_policy *policy, @@ -799,7 +800,7 @@ static ssize_t store_scaling_governor(struct cpufreq_policy *policy, return ret ? ret : count; } -/** +/* * show_scaling_driver - show the cpufreq driver currently loaded */ static ssize_t show_scaling_driver(struct cpufreq_policy *policy, char *buf) @@ -807,7 +808,7 @@ static ssize_t show_scaling_driver(struct cpufreq_policy *policy, char *buf) return scnprintf(buf, CPUFREQ_NAME_PLEN, "%s\n", cpufreq_driver->name); } -/** +/* * show_scaling_available_governors - show the available CPUfreq governors */ static ssize_t show_scaling_available_governors(struct cpufreq_policy *policy, @@ -851,7 +852,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf) } EXPORT_SYMBOL_GPL(cpufreq_show_cpus); -/** +/* * show_related_cpus - show the CPUs affected by each transition even if * hw coordination is in use */ @@ -860,7 +861,7 @@ static ssize_t show_related_cpus(struct cpufreq_policy *policy, char *buf) return cpufreq_show_cpus(policy->related_cpus, buf); } -/** +/* * show_affected_cpus - show the CPUs affected by each transition */ static ssize_t show_affected_cpus(struct cpufreq_policy *policy, char *buf) @@ -894,7 +895,7 @@ static ssize_t show_scaling_setspeed(struct cpufreq_policy *policy, char *buf) return policy->governor->show_setspeed(policy, buf); } -/** +/* * show_bios_limit - show the current cpufreq HW/BIOS limitation */ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf) @@ -1616,7 +1617,7 @@ static int cpufreq_offline(unsigned int cpu) return 0; } -/** +/* * cpufreq_remove_dev - remove a CPU device * * Removes the cpufreq interface for a CPU device. @@ -2373,6 +2374,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor); * cpufreq_get_policy - get the current cpufreq_policy * @policy: struct cpufreq_policy into which the current cpufreq_policy * is written + * @cpu: CPU to find the policy for * * Reads the current cpufreq policy. */ @@ -2759,7 +2761,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) } EXPORT_SYMBOL_GPL(cpufreq_register_driver); -/** +/* * cpufreq_unregister_driver - unregister the current CPUFreq driver * * Unregister the current CPUFreq driver. Only call this if you have From patchwork Tue Jul 14 14:50:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663007 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E9E57722 for ; Tue, 14 Jul 2020 14:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0436222C8 for ; Tue, 14 Jul 2020 14:51:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QHrJMslm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728559AbgGNOvA (ORCPT ); Tue, 14 Jul 2020 10:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728439AbgGNOu5 (ORCPT ); Tue, 14 Jul 2020 10:50:57 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7D4C08C5C1 for ; Tue, 14 Jul 2020 07:50:56 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a6so22167820wrm.4 for ; Tue, 14 Jul 2020 07:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JqiGjo2A+JuWYmJhOxUeBH7YynB0Z20iJW99N6uR5uY=; b=QHrJMslmP0Kh8UfmYvSOG0q4hByvfx/EPXrsCJO7U06cWI5RsbB6FO/K0J4OQ20T3j RBSFiYd9YHmUsFIbhn61Ge90cJT0vVd9vMRFr2EWRb1rkIHD8mMz/JY2ZZYwATz7auHu 18qgce0k8NfkRreMk/6e8YOBYMNHETPxUAHrQe2cFWQJRL/XweHeVtQEfMjN4YFvAnWL iIGlreeiHb8EF/eZQZCNRcHzlxKZv4+L5IkxmQFPUubbWI4G7B4xk0u1kk6T2CxnXRGo Jhw6lNuhbQ/AQS6p3QF5pvEy8QaJWxBEzyv1VQLjejUm4KkJTim9bBrnVEfdT59BlKQV Liyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JqiGjo2A+JuWYmJhOxUeBH7YynB0Z20iJW99N6uR5uY=; b=cHS5L7t7FgtHY+lJCzcLUpoVqdnaZLRVr6xFkyzs5RoD4DQD3PSSsLUn42DvRmVdSM IAMNjdLLdBlpikM0G8j9oL/aInRbnW2pnEx13TKPBWz0TtTfl5KfJPpLQd38AOjMUIQS vn/lOckVfcofLFUnSVVYrSdpJdrfCwPmMf/QEVw7raassAOWa9j1vQdkI4phew5YFudx lbMfneHS+hP/h4cUthWhxYFLFQS816Crl/ojYwro/sn6VxPQWE6HgqbVbNIa/u0YoFK2 2uAcEvTH9/ZCvTOddTBURAccIkyyCF2F8SqgVGaGOM7oAMboo1YmdcXJeFq9z+GQ0Wue 3Zug== X-Gm-Message-State: AOAM530wE6OGPyTBRF+pffiy9EZV/xxdRH47qH7s70rpSzlBEkfXpn8/ b54/ibbQ+l5imA6uXa9ZPzf/fA== X-Google-Smtp-Source: ABdhPJz0D8DB83PkawksqyN2zvcSXy61SCN97inRz7exzjOwhX1N4sU7xjVlExKi+/mgYquJYu+oog== X-Received: by 2002:adf:fa8f:: with SMTP id h15mr6113893wrr.211.1594738255423; Tue, 14 Jul 2020 07:50:55 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:54 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Venkatesh Pallipadi , Jun Nakajima , Alexander Clouter Subject: [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block Date: Tue, 14 Jul 2020 15:50:39 +0100 Message-Id: <20200714145049.2496163-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org There is no need for this to be denoted as kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'attr_set' not described in 'store_sampling_rate' drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'buf' not described in 'store_sampling_rate' drivers/cpufreq/cpufreq_governor.c:46: warning: Function parameter or member 'count' not described in 'store_sampling_rate' Cc: Venkatesh Pallipadi Cc: Jun Nakajima Cc: Alexander Clouter Signed-off-by: Lee Jones --- drivers/cpufreq/cpufreq_governor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index f99ae45efaea7..63f7c219062b9 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -26,7 +26,7 @@ static DEFINE_PER_CPU(struct cpu_dbs_info, cpu_dbs); static DEFINE_MUTEX(gov_dbs_data_mutex); /* Common sysfs tunables */ -/** +/* * store_sampling_rate - update sampling rate effective immediately if needed. * * If new rate is smaller than the old, simply updating From patchwork Tue Jul 14 14:50:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663025 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5FA421392 for ; Tue, 14 Jul 2020 14:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48167224D1 for ; Tue, 14 Jul 2020 14:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vBZqRin9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728656AbgGNOvA (ORCPT ); Tue, 14 Jul 2020 10:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728559AbgGNOu6 (ORCPT ); Tue, 14 Jul 2020 10:50:58 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B57B9C08C5DD for ; Tue, 14 Jul 2020 07:50:57 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id o11so22218893wrv.9 for ; Tue, 14 Jul 2020 07:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CMXxo9aOlmaJXA2Fa0TTzO8LQVMEninajvd8D9uCCWE=; b=vBZqRin9ErymR0h6YWFtX6OzZP7QsHPxUOwJ1TB67Z1qz2iAYJvnsWx2gcLuhJy4lb hDDc4aeOkm27SRzf8X1k2WIAObsAJND5revrzkP/m7ZCMP80546Bxq3T3UndYTS8OzUC JRsd6UB7YHbFJbx8g2t1uiz5Y+e8rX83mYC50waDpkpo5tPFH0kwV8nCXZvv/pkzP297 KtwmqwGgdm6Um5BEKSCxhXmSf67vT0WeoxDQQEouLXVk2MTiwej9lYE4yeXcO2AgZFPY 1n2hO29e3beuwFoHJWMa6cOWi5ut2YKBxpnhv1OpHJLS9ZZ8+unvn3Q7bOKY5dKnNGed ooaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CMXxo9aOlmaJXA2Fa0TTzO8LQVMEninajvd8D9uCCWE=; b=pLg73u8ja566ow76J7NuI0MUZyOlwhOINFmBvMzOENEEGGNf+WiYmmicoTn4pi6wSz dgXkmpKXzITF+QybhJGNZYNOqj1upv5xbN8RaSwhpfSIf4VBc/L03gwL6GymBNlXfdtN ATEf+JLW1c1fugMdJ1tQkZW7QaNbRXQn9MIApkN+Hrke3WurToRTI5hQIQnXWqCFBEBC GdU/1fnX6ipMEPAu4/FcZGA4w6XEiEdAFVYH1qTsH844g0Te4jnWIYXA20KonPnvVw7X PYtVW6lbrQDgXh3fmNJ0g2/vF/PWJ6UZpby263NbacbX8qULCBbmhcBcLrIKM/Flxg3N DHAQ== X-Gm-Message-State: AOAM532WERj1LbTuPrdOJ+iXjr24vrpnZ+S/y9RO7t4LP+J/l/seHtBA zhcJt6NZ1Qh/PJ9QotjhrrWZ8mh1sXk= X-Google-Smtp-Source: ABdhPJwYqf/NbTXIZQ6P2+Ae9aB7yAhOCiew0QjfGjYt6pXaaft/XHPCaQXykUjtuNfRA79JvHAIRA== X-Received: by 2002:adf:81c8:: with SMTP id 66mr6172511wra.348.1594738256436; Tue, 14 Jul 2020 07:50:56 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:55 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Patrice Chotard , Pal Singh Subject: [PATCH 04/13] cpufreq: sti-cpufreq: Fix some formatting and misspelling issues Date: Tue, 14 Jul 2020 15:50:40 +0100 Message-Id: <20200714145049.2496163-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Kerneldoc format for attribute descriptions should be '@.*: '. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/sti-cpufreq.c:49: warning: cannot understand function prototype: 'struct sti_cpufreq_ddata ' Cc: Patrice Chotard Cc: Pal Singh Signed-off-by: Lee Jones --- drivers/cpufreq/sti-cpufreq.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c index 8f16bbb164b84..a5ad96d29adca 100644 --- a/drivers/cpufreq/sti-cpufreq.c +++ b/drivers/cpufreq/sti-cpufreq.c @@ -40,11 +40,11 @@ enum { }; /** - * ST CPUFreq Driver Data + * struct sti_cpufreq_ddata - ST CPUFreq Driver Data * - * @cpu_node CPU's OF node - * @syscfg_eng Engineering Syscon register map - * @regmap Syscon register map + * @cpu: CPU's OF node + * @syscfg_eng: Engineering Syscon register map + * @syscfg: Syscon register map */ static struct sti_cpufreq_ddata { struct device *cpu; From patchwork Tue Jul 14 14:50:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663027 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4FBA722 for ; Tue, 14 Jul 2020 14:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B3F922205 for ; Tue, 14 Jul 2020 14:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yr1SJcM2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729004AbgGNOvi (ORCPT ); Tue, 14 Jul 2020 10:51:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbgGNOu7 (ORCPT ); Tue, 14 Jul 2020 10:50:59 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C93FEC061794 for ; Tue, 14 Jul 2020 07:50:58 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f2so22124238wrp.7 for ; Tue, 14 Jul 2020 07:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sa7IFFvEjkUEYkKGNfZ4AaOfAhDNPotc0mtcZbr7pMU=; b=Yr1SJcM2AwK2hW8wKdiFtlaK6rKbZ3NlkGx8d1Od6cqVH4nDmmoGCDQVhLHIDws+3d 2OVvC3aJXzU/ZjRq+haMRmCsqS9W94aOftUL13uUTXk4ZnJIiwTbqrjSFcSQ6+MBToTA Wlf9HuAi0Aza+9dtw/LHZF7rOTCDvLKrgawrfm5e6w/OV2eflKYPT6fW2ypIM7ewVmNc 6sZcE8UtKJDkeu8wqVxcoXJajhBkeReoa/7FhnEB2BS2H5Z5vYRvhfarz4C2XXTsWwBv aBmWOuw/i4Vdi3oCKJV1Zdhv/857tPWI3NzjMDJuHyaPTGpybciaeB3NKBD0sTczkWGs so9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sa7IFFvEjkUEYkKGNfZ4AaOfAhDNPotc0mtcZbr7pMU=; b=GJsFrWmZ6PbblctWCTxBPQMrsLtb8KmwguZpEor+M3Bo8/54r1s8v+8MG+/H0WJ9VJ 2kXtM9EL5SF9dQIty4XcnZ/Hs9B/e0hXnZQAzja4fwP3AQSrf4BbT6UhPVlzYDZjh+Y6 ObcHToipJKFzg9NHusUv9qOvfoC7a0WH8rdP/rEfUkZVtP9mxLo5Lh8kJ6Qmqa1Z83xj lPgZicsZ7eSFV0Mn6yDHT8hsl0eUsVzKYNp+vmWSqvOkegk0gYa7gu1ppBQ4f8BwruoN aJCZwh0nDRLx0VRLG19r0tKX1SN3Efr+oxQRtXOZPpieFP/rw8jgf04UK9qwq/VAVbr0 s0zw== X-Gm-Message-State: AOAM530xILnVTjvUitBzJ3WOXJNwxkYRyv1ouZA6D9AsfBP0dpCPu8sJ I7eAsQ96P089SzLv69BoMGe16w== X-Google-Smtp-Source: ABdhPJzNf9Z+WHkT0D9c7/YKzZVAjpjagqUFxoxaf/blhTxuH25LgfvUKpph8N2tIaWR9WV7qZZ8hg== X-Received: by 2002:adf:82f5:: with SMTP id 108mr6084464wrc.218.1594738257584; Tue, 14 Jul 2020 07:50:57 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:57 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Olof Johansson , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Date: Tue, 14 Jul 2020 15:50:41 +0100 Message-Id: <20200714145049.2496163-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org If function callers and providers do not share the same prototypes the compiler complains of missing prototypes. Fix this by moving the already existing prototypes out to a mutually convenient location. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] 109 | int check_astate(void) | ^~~~~~~~~~~~ drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] 114 | void restore_astate(int cpu) | ^~~~~~~~~~~~~~ Cc: Olof Johansson Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ arch/powerpc/platforms/pasemi/powersave.S | 2 ++ drivers/cpufreq/pasemi-cpufreq.c | 1 + include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++++ 4 files changed, 31 insertions(+), 15 deletions(-) create mode 100644 include/linux/platform_data/pasemi.h diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h index 70b56048ed1be..528d81ef748ad 100644 --- a/arch/powerpc/platforms/pasemi/pasemi.h +++ b/arch/powerpc/platforms/pasemi/pasemi.h @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); extern void idle_spin(void); extern void idle_doze(void); -/* Restore astate to last set */ -#ifdef CONFIG_PPC_PASEMI_CPUFREQ -extern int check_astate(void); -extern void restore_astate(int cpu); -#else -static inline int check_astate(void) -{ - /* Always return >0 so we never power save */ - return 1; -} -static inline void restore_astate(int cpu) -{ -} -#endif - extern struct pci_controller_ops pasemi_pci_controller_ops; #endif /* _PASEMI_PASEMI_H */ diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc/platforms/pasemi/powersave.S index d0215d5329ca7..7747b48963286 100644 --- a/arch/powerpc/platforms/pasemi/powersave.S +++ b/arch/powerpc/platforms/pasemi/powersave.S @@ -5,6 +5,8 @@ * Maintained by: Olof Johansson */ +#include + #include #include #include diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index c66f566a854cb..c6bb3ecc90ef3 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include diff --git a/include/linux/platform_data/pasemi.h b/include/linux/platform_data/pasemi.h new file mode 100644 index 0000000000000..3fed0687fcc9a --- /dev/null +++ b/include/linux/platform_data/pasemi.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2020 Linaro Ltd. + * + * Author: Lee Jones + */ + +#ifndef _LINUX_PLATFORM_DATA_PASEMI_H +#define _LINUX_PLATFORM_DATA_PASEMI_H + +/* Restore astate to last set */ +#ifdef CONFIG_PPC_PASEMI_CPUFREQ +int check_astate(void); +void restore_astate(int cpu); +#else +static inline int check_astate(void) +{ + /* Always return >0 so we never power save */ + return 1; +} +static inline void restore_astate(int cpu) +{ +} +#endif + +#endif /* _LINUX_PLATFORM_DATA_PASEMI_H */ + + From patchwork Tue Jul 14 14:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663023 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41D8914DD for ; Tue, 14 Jul 2020 14:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29EF322461 for ; Tue, 14 Jul 2020 14:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YaPkEvwk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728652AbgGNOvh (ORCPT ); Tue, 14 Jul 2020 10:51:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728633AbgGNOvA (ORCPT ); Tue, 14 Jul 2020 10:51:00 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2617C08C5C1 for ; Tue, 14 Jul 2020 07:50:59 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id o11so22219174wrv.9 for ; Tue, 14 Jul 2020 07:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6pwz2ffWzBJ40s4OQQcEx95BGb6IW3I0JlI9ImusOaw=; b=YaPkEvwkRMrXCrAr3GD3Lq5esr1zvrFowgkVtFLyXE9aeQ+n6qHPlhaUhK4AYO4xUs hm5M2HAtd3m5JHJjY2xKUYjnMD1tdtfs5OPz2xXGUBp2zizzY0ZWTKvQ9U0A5cXFSIRJ j3yMdMtUprKvhoEl35KqZAv8e37m9RfHJ9JDTy287GDX+MDLsV7UmkJ7LDgRcd0qsysv Ia93V3kAPH4VDyioq5fO47gOCGnLqoR2QLu1mPSgJAUAUCITRKMczfB1Ec4oXyA2jWHx PQLY4by7vk9xQhpkcw3oZfR/uB2heai2vAqu8clRrz2QEmp5oM3aCK3aViE9BDI4b5mz 3u7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6pwz2ffWzBJ40s4OQQcEx95BGb6IW3I0JlI9ImusOaw=; b=D2cYdilliLHs+11YcX/UfcZDhktikgVH8cjaFWw5YunoWXg2aDB4lro5I/1edRiXMx P8Cd5VqztCwyAaideFvvFiYDUVTLVphYPKwEVZM0eb4sK7VCgGcCbZ9TIGHY/0iC0jzW ecCXdeuCcTu5T8wG01QthbiG1oHk1uYXNz2uRnjcjYsY+344sZEQUh9vOPYo0TeL1dMF Y3EQr7RJB/2+1ER2jKcf90M1COcBCdv2chU7yVkOyfHmHCxaZCxPeKrXlTMZWSWdF/iU ZFrj3xrVAhs0oyDG3IJJWDbQwkC4zs6Z9Kc+xSfcRN9yWJHFQCnAZsx4q9YLpX5ceLGD VBbg== X-Gm-Message-State: AOAM532fxIZDrE8QUoQ28b65I9BNZ6KGRHG6EJL7JIZMw8k24VhGxfFV By/9Pj9covh8HDZnV1CIq5JF5Q== X-Google-Smtp-Source: ABdhPJxR1XkWPEdO/OToyZfeyPk6VSF/2G2O+HfpfRXS3rTqGgoQ4md522X2INCeZPPwNAHNuFWGZw== X-Received: by 2002:a5d:650e:: with SMTP id x14mr6401946wru.187.1594738258660; Tue, 14 Jul 2020 07:50:58 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:58 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static Date: Tue, 14 Jul 2020 15:50:42 +0100 Message-Id: <20200714145049.2496163-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes] drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes] Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 8646eb197cd96..068cc53abe320 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) * according quadratic equation. Queues a new timer if it is still not equal * to local pstate */ -void gpstate_timer_handler(struct timer_list *t) +static void gpstate_timer_handler(struct timer_list *t) { struct global_pstate_info *gpstates = from_timer(gpstates, t, timer); struct cpufreq_policy *policy = gpstates->policy; @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { .notifier_call = powernv_cpufreq_reboot_notifier, }; -void powernv_cpufreq_work_fn(struct work_struct *work) +static void powernv_cpufreq_work_fn(struct work_struct *work) { struct chip *chip = container_of(work, struct chip, throttle); struct cpufreq_policy *policy; From patchwork Tue Jul 14 14:50:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663009 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53A62722 for ; Tue, 14 Jul 2020 14:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34259222C8 for ; Tue, 14 Jul 2020 14:51:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oan2KmRn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbgGNOvG (ORCPT ); Tue, 14 Jul 2020 10:51:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728699AbgGNOvB (ORCPT ); Tue, 14 Jul 2020 10:51:01 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 451EBC061755 for ; Tue, 14 Jul 2020 07:51:01 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f18so22197871wrs.0 for ; Tue, 14 Jul 2020 07:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=87fYCk78HvnEcHEWI8252kKdAErne/JGHZaNtIMV4DM=; b=oan2KmRnlmziHA33dlWeKxYSz99uymPx4Upt4DdPZqzkE7Pn6aNbVFcS4EqijPPT1b epm+Z0+gabomO1htq+2nGq7mfGaa4AQjVGvinv2W7rG4Yf4zrX1lLQEsQqp/IxzwJsZK KsU3lyQE4BSuu7m+y0e17j3xQipWcaeFlmiHFAjUhm+t5oiOf17IImiudspjVz2Gr4Np +3ggtvvQ+Y0p36Roz5hpma2QxOSlmCwdpxC50LPbuzXaY/z9L0dMBVjNrKdi9Dd18Pfz bjl9EDQ3qx3ytSsCNXEZ3bn0ERkPJPoJyn67O07VbJKTig+xN3S9JouZaVPvYAKfp92V EHyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=87fYCk78HvnEcHEWI8252kKdAErne/JGHZaNtIMV4DM=; b=uobfP77obTiAzQel5NnDjZXHrtMBOSirUmxCCnDfIleK4x1fOvsvA/titnHBcYy/ND 5+cJdXzYjnpECTyIrttS/PlrcYkQkW2ycAJbqSu/y5f0x21cMeHpn1GG+QezBKh7LYN7 goHpfRT9nq1eHSvypwAcquYEe7V8y27RRlqtmGUX3xFCj+pzlVWYGZpukQM0ZhsvMQjF /PtviW+wTgZ5Fms6oEjTh9wf5RHiOZ4QVwpr1+kK5BUJuMoShSSpnG1myBwRdp30xEyi 9YNZ8j9Q4P2soVKTAd0SMVlsZo4rGLVEAYt4kzdvpNOgAGalnXls8VdV25/kQ16CMEf8 WofQ== X-Gm-Message-State: AOAM530aia33S48nheiia5uzvFytgL//qJUgWD3Xsxvm8dhpimx68s/T bVpvHZzwhfFfPZqoqXuRyAxIIg== X-Google-Smtp-Source: ABdhPJyholUMWz/5/8DrxA2fX1xTdZCmREnCcugfLGT0R3+RARPOD0BiRca7mzrYbDfRATUmPfhpCg== X-Received: by 2002:a5d:6990:: with SMTP id g16mr6060756wru.131.1594738259994; Tue, 14 Jul 2020 07:50:59 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:50:59 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Date: Tue, 14 Jul 2020 15:50:43 +0100 Message-Id: <20200714145049.2496163-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Repair problems with formatting and missing attributes/parameters, and demote header comments which do not meet the required standards applicable to kerneldoc. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_lpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'last_gpstate_idx' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:84: warning: Function parameter or member 'policy' not described in 'global_pstate_info' drivers/cpufreq/powernv-cpufreq.c:182: warning: Function parameter or member 'i' not described in 'idx_to_pstate' drivers/cpufreq/powernv-cpufreq.c:201: warning: Function parameter or member 'pstate' not described in 'pstate_to_idx' drivers/cpufreq/powernv-cpufreq.c:670: warning: Function parameter or member 't' not described in 'gpstate_timer_handler' drivers/cpufreq/powernv-cpufreq.c:670: warning: Excess function parameter 'data' description in 'gpstate_timer_handler' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Viresh Kumar --- drivers/cpufreq/powernv-cpufreq.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 068cc53abe320..2e5a8b8a4abaa 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -64,13 +64,14 @@ * highest_lpstate_idx * @last_sampled_time: Time from boot in ms when global pstates were * last set - * @last_lpstate_idx, Last set value of local pstate and global - * last_gpstate_idx pstate in terms of cpufreq table index + * @last_lpstate_idx: Last set value of local pstate and global + * @last_gpstate_idx: pstate in terms of cpufreq table index * @timer: Is used for ramping down if cpu goes idle for * a long time with global pstate held high * @gpstate_lock: A spinlock to maintain synchronization between * routines called by the timer handler and * governer's target_index calls + * @policy: Associated CPUFreq policy */ struct global_pstate_info { int highest_lpstate_idx; @@ -170,7 +171,7 @@ static inline u8 extract_pstate(u64 pmsr_val, unsigned int shift) /* Use following functions for conversions between pstate_id and index */ -/** +/* * idx_to_pstate : Returns the pstate id corresponding to the * frequency in the cpufreq frequency table * powernv_freqs indexed by @i. @@ -188,7 +189,7 @@ static inline u8 idx_to_pstate(unsigned int i) return powernv_freqs[i].driver_data; } -/** +/* * pstate_to_idx : Returns the index in the cpufreq frequencytable * powernv_freqs for the frequency whose corresponding * pstate id is @pstate. @@ -660,7 +661,7 @@ static inline void queue_gpstate_timer(struct global_pstate_info *gpstates) /** * gpstate_timer_handler * - * @data: pointer to cpufreq_policy on which timer was queued + * @t: Timer context used to fetch global pstate info struct * * This handler brings down the global pstate closer to the local pstate * according quadratic equation. Queues a new timer if it is still not equal From patchwork Tue Jul 14 14:50:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663021 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9098A722 for ; Tue, 14 Jul 2020 14:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7776122205 for ; Tue, 14 Jul 2020 14:51:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kw0j6YyJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728940AbgGNOvZ (ORCPT ); Tue, 14 Jul 2020 10:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728742AbgGNOvC (ORCPT ); Tue, 14 Jul 2020 10:51:02 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 716C0C061755 for ; Tue, 14 Jul 2020 07:51:02 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id r12so22118484wrj.13 for ; Tue, 14 Jul 2020 07:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oYBUe5BwYsr/R2phlHidQsm6+vzt4cxxnkc0JimKqEE=; b=kw0j6YyJsiIk2n3yX5+GkWGHEPOb5rpZONh1AHETutb3Im0RIS6q17btR7I5qt+Y3G Cr1hhv/Kwb4+WIS0DNHRjmc1aw52YDL0xbevlEKg7TJLPfD4wiKMTStgnlv9QSESRuy2 ud15ingoco58gPEiG8JkpQosiAAkovGqjbIlBoloUt9rOcx2anemoSqTP2ATqz6NrUQt tulqxTx3pqJ1mnmLEsWngWkqghXlkZjKVXZb6FZTVVe+ZC2J0MR1r2jQ+V86qR4QnhyQ LWrTAK+0ruiFBAkkrUIWJlkdAkSpEDrtau+/OBkjXFh5ifl7sURfmnAjGYLKjcVCRWk7 J80Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oYBUe5BwYsr/R2phlHidQsm6+vzt4cxxnkc0JimKqEE=; b=bW2eNspwr32wNn0CjRYysAzC4135Fymh8C9Um6/d2Is6uhM1igcHXbcNvMM+xijXnx zhAV2j9Ynd36WTi7CDvJGKoJ7A+FZeaG9YdWm/PwOWRRLg+vlgdHy5oJf2BMgWLkIKxq q0jZ4dFsQNlrA9JUAF9LoskLC97bHZONlBsxKNHZpHCU1tKps7cB42BHiE4rP7En0u0R WRjIUkry2UI3I/BhfCwL9issL5VyeisH2BLGxnx4+zYfeL5R/Yx3i1PpI6+cmuQy0B5b TaMjeqr+nrt8vHwFe0cQkoV+N4XHL2pyFCktc1geLdsaK7jq62PMj/Vt0XwJfwUdy2y2 7gjw== X-Gm-Message-State: AOAM5306j9yYvMN902aAkQeHXDmZV0eOVc6XfMbVm9/cgnXHG83D8xeE ufB6SxmqmcBLGaDzuE24gLqJYA== X-Google-Smtp-Source: ABdhPJz8xLGj6PyHHnWxNk1fB9l9swenCZNjFdqaoHR4cK01bpPaXCLBFCFf4j5xacHn27d9sC7Xrw== X-Received: by 2002:a5d:5151:: with SMTP id u17mr6280720wrt.154.1594738261236; Tue, 14 Jul 2020 07:51:01 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:00 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Andy Grover , Paul Diefenbaugh , Dominik Brodowski , Denis Sadykov Subject: [PATCH 08/13] cpufreq: acpi-cpufreq: Take 'dummy' principle one stage further Date: Tue, 14 Jul 2020 15:50:44 +0100 Message-Id: <20200714145049.2496163-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org If we fail to use a variable, even a 'dummy' one, then the compiler complains that it is set but not used. We know this is fine, so we set it to its own value here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/acpi-cpufreq.c: In function ‘cpu_freq_read_intel’: drivers/cpufreq/acpi-cpufreq.c:247:11: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] drivers/cpufreq/acpi-cpufreq.c: In function ‘cpu_freq_read_amd’: drivers/cpufreq/acpi-cpufreq.c:265:11: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Andy Grover Cc: Paul Diefenbaugh Cc: Dominik Brodowski Cc: Denis Sadykov Signed-off-by: Lee Jones --- drivers/cpufreq/acpi-cpufreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index 429e5a36c08a9..d38a693b48e03 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -247,6 +247,7 @@ static u32 cpu_freq_read_intel(struct acpi_pct_register *not_used) u32 val, dummy; rdmsr(MSR_IA32_PERF_CTL, val, dummy); + dummy &= dummy; /* Silence set but not used warning */ return val; } @@ -264,6 +265,7 @@ static u32 cpu_freq_read_amd(struct acpi_pct_register *not_used) u32 val, dummy; rdmsr(MSR_AMD_PERF_CTL, val, dummy); + dummy &= dummy; /* Silence set but not used warning */ return val; } From patchwork Tue Jul 14 14:50:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FAD11392 for ; Tue, 14 Jul 2020 14:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62FD2224D1 for ; Tue, 14 Jul 2020 14:51:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t6daXhKQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728947AbgGNOvZ (ORCPT ); Tue, 14 Jul 2020 10:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbgGNOvE (ORCPT ); Tue, 14 Jul 2020 10:51:04 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3AC1C08C5DB for ; Tue, 14 Jul 2020 07:51:03 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s10so22129103wrw.12 for ; Tue, 14 Jul 2020 07:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ov8mkUGBo3MkEAlxc2kYHhcoEYaszqjEJyXig/T1tiI=; b=t6daXhKQWGdOTczm6qL35xc0fppGdojfryPU3Yy+9b2M42Lz9lDVXu8Z+oQPer8/wn 66lWCuWHscF79MDsDWoRINbL+J3DI3JwRywYtB3y/yDN2fYApJvODwK9fVhtnK1i5TrR 6PwVmrMyZL9diMFGKxmlNMcb/U/bTKAABaKdcywqnPyqnVG8Qf3AUAoJpdZ/2pUkQHF/ JNbL4G/kUrCSGBLIjO7xXY9Eqm4CKdYlM/6mJNq99ZnUxi1hI/38z3KoHgnowKzwqcF5 DuKh916+E7/PuxfrO02rdsDIELOoLKt8hH+gN8cgun3vPBAXSTxr4R8r6rhWs+4/y9qb Zpdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ov8mkUGBo3MkEAlxc2kYHhcoEYaszqjEJyXig/T1tiI=; b=JJ3XLFrtXPn9XOUCxN0dsmsQlu73bygS9czVB6y7wSEDTxSGrRqrajvwjk35VG0u1m LHicJvSxf8aAC15n9V9ZvaWwocYw5lYzvs/P9DDxSyoXdSXIyCpYgZ/soU1pmljzf2i8 v43RWf5DmmSjSFIMA0SgVpbguqBwy+09htQ3BH0KnX3ha8cQfPb88besCYyjpNLvKPKE 7vE2Gj34jh//KvfAvsm11CHgy7DOyIXc8ZztthaNQ7fGKSy3FAXQGEiSHrkf9DHZc2ER +p7UtcaGCEwRf1on2tbMuz6kg8+MeydFUmgRtUdeBv24TaNwXZVR8Y7YxIaJhARL0wlw YkSw== X-Gm-Message-State: AOAM530NliIE9LXrV6FTKzwb8sboyvV6OS14gheWLHE0apfRNXYriboe sDsvvONiVttBRV656grThDXjCBww8WY= X-Google-Smtp-Source: ABdhPJwXO/T/LF1NI7ZgnyJQbsl2c1EL4iDXIFBRbgGKB7Pv7E0G1E9GvN5Ys7i50Jv2Wiu8MXJf4g== X-Received: by 2002:adf:f18c:: with SMTP id h12mr5883468wro.375.1594738262394; Tue, 14 Jul 2020 07:51:02 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:01 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Andy Grover , Paul Diefenbaugh , Dominik Brodowski , Denis Sadykov Subject: [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:45 +0100 Message-Id: <20200714145049.2496163-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/acpi-cpufreq.c:1004:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=] 997 | static const struct x86_cpu_id acpi_cpufreq_ids[] = { | ^~~~~~~~~~~~~~~~ drivers/cpufreq/acpi-cpufreq.c:997:32: warning: ‘acpi_cpufreq_ids’ defined but not used [-Wunused-const-variable=] 619 | static const struct acpi_device_id processor_device_ids[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Andy Grover Cc: Paul Diefenbaugh Cc: Dominik Brodowski Cc: Denis Sadykov Signed-off-by: Lee Jones --- drivers/cpufreq/acpi-cpufreq.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index d38a693b48e03..fc68f13352695 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -995,18 +995,4 @@ MODULE_PARM_DESC(acpi_pstate_strict, late_initcall(acpi_cpufreq_init); module_exit(acpi_cpufreq_exit); -static const struct x86_cpu_id acpi_cpufreq_ids[] = { - X86_MATCH_FEATURE(X86_FEATURE_ACPI, NULL), - X86_MATCH_FEATURE(X86_FEATURE_HW_PSTATE, NULL), - {} -}; -MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids); - -static const struct acpi_device_id processor_device_ids[] = { - {ACPI_PROCESSOR_OBJECT_HID, }, - {ACPI_PROCESSOR_DEVICE_HID, }, - {}, -}; -MODULE_DEVICE_TABLE(acpi, processor_device_ids); - MODULE_ALIAS("acpi"); From patchwork Tue Jul 14 14:50:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663017 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 32659722 for ; Tue, 14 Jul 2020 14:51:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19D1A222C8 for ; Tue, 14 Jul 2020 14:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MHULfHb/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbgGNOvY (ORCPT ); Tue, 14 Jul 2020 10:51:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728768AbgGNOvF (ORCPT ); Tue, 14 Jul 2020 10:51:05 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC09EC08C5DD for ; Tue, 14 Jul 2020 07:51:04 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so22181509wrl.8 for ; Tue, 14 Jul 2020 07:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xAmlwZf9FF5B+fNw3FLwoudWl6EScDCCxEL7TtadPBI=; b=MHULfHb/qq2DdPxVtZdND+73JTuMCaIpc5HvzUeGk6dbIqMsJzHFttAq159KGZhl+E uc32b1iIIALtw+ydZp8fFCVf22oX/ZdWCauKax3caYhdVkySmLHWnfqsCdIC72Zkwchc 0HSG5fFKVugqRl0OpEK9Pw86gfD9D3MreYxK7XhNMk+0Inko/tj6sj1308edItjH6uo6 E5+EcxAVfNcEsuIU/t2HPJ2VjGAKGSOfJyddVycUripolPiZXCNSEbtHOJSdnPoQdyBC z5kKNMEq5B9YxP3pmvcBN6urA6s4KBar6ixz9U4qx3EMF/Ca6qnZHRoNaYFvLzVkUo89 chLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xAmlwZf9FF5B+fNw3FLwoudWl6EScDCCxEL7TtadPBI=; b=eGwPhW/+LbJshXva3266r2xW3rmDf8cYZAwSRbhynQoufgm4fKpj8rOtep4cmy+GQf Zst4cKJQ2U/+EbdWingwDLvgirDhkaNlGFQ3GkTtTHqmQxkMcKscSrAtZ+4uH2y1o7Oj dOQfPpJ8+mGrMoU+nEIpNpg8M3Mr2F4DMICeorPwnvo9P+vsgObBo/keWThISGixSpbM yFrKJmUDgIMF34dc5LbxLRJK2Vz1T0mgJ53AA+xziEY7MtqZ2paQ0X9FdYXCf9L1iqV7 VDMEli4Izwue3Nh58NvCne+mChZHiVrTPZAo0nT59eHgx507/sa2qktvjru3HF4iWkG7 g3TA== X-Gm-Message-State: AOAM530zbU024p8bXphA0HFtfy+fLugDD0CaATHpSsSiPepI92h+pIdm DK8PyVlur9A8ggXPbzr+xCRo7Q== X-Google-Smtp-Source: ABdhPJyoziaq49v5CTUiEUg6/TO+E0QrGY8bGLFPGBYZLqb4ZcvlqiI8gGMCMznhtGm8VhY3kHmpDA== X-Received: by 2002:adf:82f5:: with SMTP id 108mr6085256wrc.218.1594738263620; Tue, 14 Jul 2020 07:51:03 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:03 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Andreas Herrmann , Dominik Brodowski , Pavel Machek , Paul Devriendt , Mark Langsdorf Subject: [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables Date: Tue, 14 Jul 2020 15:50:46 +0100 Message-Id: <20200714145049.2496163-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org If we fail to use a variable, even a 'dummy' one, then the compiler complains that it is set but not used. We know this is fine, so we set it to its own value here. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/powernow-k8.c: In function ‘pending_bit_stuck’: drivers/cpufreq/powernow-k8.c:89:10: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable] 89 | u32 lo, hi; | ^~ drivers/cpufreq/powernow-k8.c: In function ‘core_voltage_pre_transition’: drivers/cpufreq/powernow-k8.c:285:14: warning: variable ‘lo’ set but not used [-Wunused-but-set-variable] 285 | u32 maxvid, lo, rvomult = 1; | ^~ Cc: Andreas Herrmann Cc: Dominik Brodowski Cc: Pavel Machek Cc: Paul Devriendt Cc: Mark Langsdorf Signed-off-by: Lee Jones --- drivers/cpufreq/powernow-k8.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index 3984959eed1d5..b76df81044c4f 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -89,6 +89,7 @@ static int pending_bit_stuck(void) u32 lo, hi; rdmsr(MSR_FIDVID_STATUS, lo, hi); + hi &= hi; /* Silence set but not used warning */ return lo & MSR_S_LO_CHANGE_PENDING ? 1 : 0; } @@ -292,6 +293,7 @@ static int core_voltage_pre_transition(struct powernow_k8_data *data, rvomult = 2; rvosteps *= rvomult; rdmsr(MSR_FIDVID_STATUS, lo, maxvid); + lo &= lo; /* Silence set but not used warning */ maxvid = 0x1f & (maxvid >> 16); pr_debug("ph1 maxvid=0x%x\n", maxvid); if (reqvid < maxvid) /* lower numbers are higher voltages */ From patchwork Tue Jul 14 14:50:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663013 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE5A314DD for ; Tue, 14 Jul 2020 14:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4D0C22205 for ; Tue, 14 Jul 2020 14:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qjP2GZD7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbgGNOvJ (ORCPT ); Tue, 14 Jul 2020 10:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbgGNOvH (ORCPT ); Tue, 14 Jul 2020 10:51:07 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10B41C08C5DF for ; Tue, 14 Jul 2020 07:51:06 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id s10so22129406wrw.12 for ; Tue, 14 Jul 2020 07:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c4FLx3muVHP2pCB5GbFp6A725ffqNGbokYtDZodR17k=; b=qjP2GZD7DEKVihUDEr8DOQw2jWLp1ateuBsMjM0zK6Bb2UqoHJmPYlUHozDy416wNM WrAuxkpdR4itLlHHdt6zK11R6J+YF3H2X9qJZ66q2VApdxJKRjggHHHabWQwZw7hB96T QWs5bcfcqHQm4RaN+IvzHqT8YkR/SDeIgCjE/O23h5GB6yX7uF3f+mu5tH4VFffzfF2E fIKqvH4tnupS9kNadhZE35Og9MwXuvniL9jmbgbMP0p9qLqc/WadErfR6kfmfJxcmI4T vuRdQt4/I+wCmwLpf95BYtk6T5qUhTEM2vcn+XQP1s8jt4AyNsu7U5RSJOLSG0O1B47Q SZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c4FLx3muVHP2pCB5GbFp6A725ffqNGbokYtDZodR17k=; b=QhUj9aFnCnNUPvgPXTJxMVN3GKl7fzcrP5lUOi+ie9QG9hzyWSoj8lMt5YC96+IlG0 G5MPv6nQj40hvO+gHbnm//HLLs/LFiIG+f9630itIGOyUuqyVlkUV9qNqBPN+vIIxCK9 /TCwEhUu8RmCQODssU3c6lv6EmkoKW/+kApFTh1t9hOhlbl6BfgLeYrBPbPqzflmT4It C7iw0vJ7jeR7f/S4Vm2yGHUHpaFpV4WLMX8nvqHpOtVlUGKnBBncvecxN5zBBhEHZiiy b2NCoEDnDkmEug8GG7K/Kt5SxLtjoIUrYoEzLixR050J2WfGWbBmbuzKuMR0fcA1wiCU 8NFw== X-Gm-Message-State: AOAM532LjLv6T/97vFEDOhDXhwAtJFR/cQ74ARyeyA9tifDzcQFKIf3c KBiAQBhViDjDBfaktVDWjtDvmg== X-Google-Smtp-Source: ABdhPJyQdxIA4lIDbDulsvOs0NZhV4S0UZCnh86sCShA7ZRuRfPhL4qVQmpdKI2T4VJMz3HcRktgOA== X-Received: by 2002:adf:8442:: with SMTP id 60mr6633538wrf.276.1594738264728; Tue, 14 Jul 2020 07:51:04 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:04 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Matthew Garrett , Nagananda Chumbalkar Subject: [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:47 +0100 Message-Id: <20200714145049.2496163-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=] 619 | static const struct acpi_device_id processor_device_ids[] = { | ^~~~~~~~~~~~~~~~~~~~ Cc: Matthew Garrett Cc: Nagananda Chumbalkar Signed-off-by: Lee Jones --- drivers/cpufreq/pcc-cpufreq.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c index 5789fe7a94bd3..99cf8b78c032a 100644 --- a/drivers/cpufreq/pcc-cpufreq.c +++ b/drivers/cpufreq/pcc-cpufreq.c @@ -616,13 +616,6 @@ static void __exit pcc_cpufreq_exit(void) free_percpu(pcc_cpu_info); } -static const struct acpi_device_id processor_device_ids[] = { - {ACPI_PROCESSOR_OBJECT_HID, }, - {ACPI_PROCESSOR_DEVICE_HID, }, - {}, -}; -MODULE_DEVICE_TABLE(acpi, processor_device_ids); - MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar"); MODULE_VERSION(PCC_VERSION); MODULE_DESCRIPTION("Processor Clocking Control interface driver"); From patchwork Tue Jul 14 14:50:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663015 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 03687722 for ; Tue, 14 Jul 2020 14:51:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEAD022205 for ; Tue, 14 Jul 2020 14:51:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zNeMYDIH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728913AbgGNOvU (ORCPT ); Tue, 14 Jul 2020 10:51:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728833AbgGNOvI (ORCPT ); Tue, 14 Jul 2020 10:51:08 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F775C08C5E2 for ; Tue, 14 Jul 2020 07:51:07 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so22119050wrj.13 for ; Tue, 14 Jul 2020 07:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AqdFH5K7w1Gi1dVNyBHBLmEyEPDpMkPLQqFOgpWKb8k=; b=zNeMYDIHJED7se7OqmcmpxTYUyzehCUyRtWunJvcBfdAuICVelAnfmYtw7GuBPUBlc d/pXNoafB+fgqXtmn64mKrwZUYXTYjtMFTGUq0m9bhqCqfyPWpUaGr3WxPKCpSVkmTSY I+J/jDnePhbC2x0dIJzFW1sMHCnzz6NUnsO3VS0J9KbDeaWvpubida+OLoO33PkJ2MXo fmSqLnpptDjn4oQRgS69BQWwUpgKj7EGqA+PEo2vsGs3tVdEl5/gZkixdlC5Ebd2Ss9E izf49OWpwU7LNnFdDt3iddBnPoOU9ThybroR8ocRIEK/NwuMVN9KLWb3ziUx09mL/sOu q0fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AqdFH5K7w1Gi1dVNyBHBLmEyEPDpMkPLQqFOgpWKb8k=; b=iAAzWJ7zuv06YZ5hRyIP0jAD3ZPWnJMq4ProvRY7QIz68ugXCdR2N6L8ulFbCL9LtE v0cqMXKblKuzErKvyP5O4dS5I//EF1fW6KAdz3boT5hIeglQHXrwNPcPReLERKPLqBqB iE4gI+X6RWushNJyJ1Y+7RGFHyE5+W6JszEJshgYMsJupEgnnWEIPp34UWncNCMn/+pz fWRwTbrZz2yQmvbdnw9q7Sq0hlfwAugUq2I6z+OaAQDFyEedL987ksqxs3LezT0mWqOE B6laKAl6U/R4eVVEW+/EW1JncDMCPIBH6ZCWU0K6Nroz02WP5XtVXYt9TyEze5YkEd4F F68A== X-Gm-Message-State: AOAM531xj9tnVM2ISz36Z6GWAnDD7jIYgKiwRqn19aI7/IvEtz0OL58v qSplwF2tp8rBxxaoCztAKbk4YtpOsTQ= X-Google-Smtp-Source: ABdhPJz408nOqlOdcCH2rmaB0MOSljVm9QafGiYYQORYvAR+a4nRgn2T/Gr31RWc8hp64O0RPEjK1g== X-Received: by 2002:a05:6000:1107:: with SMTP id z7mr6077015wrw.355.1594738265886; Tue, 14 Jul 2020 07:51:05 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:05 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Srinivas Pandruvada , Len Brown , Dirk Brandewie Subject: [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() Date: Tue, 14 Jul 2020 15:50:48 +0100 Message-Id: <20200714145049.2496163-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/cpufreq/intel_pstate.c:293: warning: Function parameter or member 'get_aperf_mperf_shift' not described in 'pstate_funcs' Cc: Srinivas Pandruvada Cc: Len Brown Cc: Dirk Brandewie Signed-off-by: Lee Jones --- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 44c7b4677675d..f92fc69c87269 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -275,6 +275,8 @@ static struct cpudata **all_cpu_data; * @get_min: Callback to get minimum P state * @get_turbo: Callback to get turbo P state * @get_scaling: Callback to get frequency scaling factor + * @get_aperf_mperf_shift: Callback to get the number of clock cycles after + * aperf, merf is incremented * @get_val: Callback to convert P state to actual MSR write value * @get_vid: Callback to get VID data for Atom platforms * From patchwork Tue Jul 14 14:50:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11663011 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CE7E1392 for ; Tue, 14 Jul 2020 14:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53EC5222C8 for ; Tue, 14 Jul 2020 14:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wn2diMwB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbgGNOvK (ORCPT ); Tue, 14 Jul 2020 10:51:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728841AbgGNOvJ (ORCPT ); Tue, 14 Jul 2020 10:51:09 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CC90C08C5E3 for ; Tue, 14 Jul 2020 07:51:08 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z15so22181925wrl.8 for ; Tue, 14 Jul 2020 07:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1l4G4IRouZ0WTRSlZcy5MrRuoV79BSQEwt+8MDC1zos=; b=wn2diMwBztTukWV3a+OQNb47W076q9O5m4hlY8WUNk2ANeNPaT/CQqfi3zwQR1nGOg VSSBNKiAlDKVFIJkOH+19zNKugRcw4cpro7kI2dybo1tFgi8XfZSUt3XWqaoBeR3z+Av +BpmcNzyT53w8bXQHF125EFE/q99zFhEemyIkgKezuFYO+m6Wrr3L3utp3V8ZyiYB1a+ o30rqYQ6cOqjoSrfZS3gdzIETNcvOBwh9eiVRnEkHsqSZKnsldi6j2CGj6wyxxwcW7sN 6DdTvdz7/e/Gkt4GbQ+f9viLiUUW0EP2OA+J4uLKVRwzUHrW9D8fZA2LFwU5mGcjfEJU A74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1l4G4IRouZ0WTRSlZcy5MrRuoV79BSQEwt+8MDC1zos=; b=SCdznfrEDOIaluZ0zAHBmlX9O3rUkjvK25DTCdViQUno1az8S5Ce25hCnUmGFIi3p3 VWJy9LGS9qotv6pgOtczTotRL8/gx2V6lgwlXGl09F6ETjpaKBmdZc1eDEch3bZJ8hdZ T40ED9B5BUZ7vf0HMNEW3syfU2c/2ybFrhK47pHtNZhrOoW7v5sikbr7UnX0SBWaSKA2 e8Y9ZV2brrzC27ZDCu9WIir4N3NE7iNKvBGOpEXwDJs1IWnfX+YUAKbrwVBajdDy30Dd u2ro6BGaqXr8D3yl2Q/r7/mSIrtI4NfzCeLXrBEDWeBKNg4Srns46CKPbt97/tffl3P8 r5lw== X-Gm-Message-State: AOAM531jcyiHyPXXwpiE4j1ZeDYHtjI60Ynv1xg8vP2+PI8nC8tKjjKZ soi/dxKZnRpdYznt8pSJuLjcTg== X-Google-Smtp-Source: ABdhPJxU9G/etho4iPMM3oDyoMPF/f2Brrlm1RMB2kEg+iD0TtRcr3nqndDSPblNhCAw+mZZ27YJig== X-Received: by 2002:a5d:4845:: with SMTP id n5mr6034582wrs.353.1594738266949; Tue, 14 Jul 2020 07:51:06 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id a84sm4653305wmh.47.2020.07.14.07.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:51:06 -0700 (PDT) From: Lee Jones To: rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lee Jones , Jacob Shin Subject: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Date: Tue, 14 Jul 2020 15:50:49 +0100 Message-Id: <20200714145049.2496163-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714145049.2496163-1-lee.jones@linaro.org> References: <20200714145049.2496163-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Can't see them being used anywhere and the compiler doesn't complain that they're missing, so ... Fixes the following W=1 kernel build warning(s): drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=] 147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~~~~ Cc: Jacob Shin Signed-off-by: Lee Jones --- drivers/cpufreq/amd_freq_sensitivity.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/amd_freq_sensitivity.c b/drivers/cpufreq/amd_freq_sensitivity.c index f7c4206d4c90b..a17093729511b 100644 --- a/drivers/cpufreq/amd_freq_sensitivity.c +++ b/drivers/cpufreq/amd_freq_sensitivity.c @@ -144,12 +144,6 @@ static void __exit amd_freq_sensitivity_exit(void) } module_exit(amd_freq_sensitivity_exit); -static const struct x86_cpu_id amd_freq_sensitivity_ids[] = { - X86_MATCH_FEATURE(X86_FEATURE_PROC_FEEDBACK, NULL), - {} -}; -MODULE_DEVICE_TABLE(x86cpu, amd_freq_sensitivity_ids); - MODULE_AUTHOR("Jacob Shin "); MODULE_DESCRIPTION("AMD frequency sensitivity feedback powersave bias for " "the ondemand governor.");