From patchwork Wed Jul 15 15:06:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665665 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F40113B6 for ; Wed, 15 Jul 2020 15:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25F672075B for ; Wed, 15 Jul 2020 15:06:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GJNtHxOO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgGOPGk (ORCPT ); Wed, 15 Jul 2020 11:06:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbgGOPGi (ORCPT ); Wed, 15 Jul 2020 11:06:38 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E54C061755 for ; Wed, 15 Jul 2020 08:06:37 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id c80so5943197wme.0 for ; Wed, 15 Jul 2020 08:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=GJNtHxOOPRZtWeTHohDWQFHqjfvGxwnNJdz6voIjChor1Ex7zIh4RYKL7WWFAzR67l f7K6Mns+x6QufGhR0YGwcwSB6Ksx1+20gB3D0ECOxU5kJQGoqjY8exCJTAt8dQkkp3es KBfkVws4SnYAGHAmAiNEENKUgAG1i+aKYJjtbRNcMGdddULPquE6SyXgXnJMWKLw3ESF qAiZll4KqluNRYd8wNJwHDavMEF6i/6Yw2Ywx+6HqNXeMzoIymgEW3MHNV0mpfIhR9qG qCXTeImq1wgSxS2sBsd/telggQixF4aMfmSfSnxUZK5dN1xRAf/sqplOCqD1E6kuaGjW hUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=drTfjdtvxp2OL0TS1prvAHXiSlBnCwdBUPHgHErSoCU7ZIeAPkoT3d3M+RvfWwA0kt H7bIm0EnR12rqIBvRWU3D0h8DQv3SireHhxHCjM1O00/UBoRVxYycWh9U516yluPqz8b uB/ZFxYzaLGZEhmJUo+HFR6i5EMEyOiIRlp4OzDnDr00bETk0Pav7pAbKLzCkIUZbXJI U77P6/o9/bqXAsxFItWDPVph9MpCQhdK69HhaXt0MY7i2RIQ7w0Z+Opq3b8/DRX6PEtM T1admMe/VPSpwJQdm4Rb6i8kxY8j35s8yDTZsyBZvEg+aPDLdC6+n2MP4gxW/vBybbVh NNtw== X-Gm-Message-State: AOAM532PprERUYEXUWYIqZHEpJ8MXxvNtSrgGvcaMjrtS2+xM6E00ouv alnmL6OKC8u/GFYpsJhBlmWsJQ== X-Google-Smtp-Source: ABdhPJxcPdfqVlAgwpuDa0tcwDk1FMUSmp8ir4ZG/rOkWM0vMSIRi4JhoDhnJtEr1vPL8BvGTLjNhw== X-Received: by 2002:a1c:e285:: with SMTP id z127mr9115336wmg.162.1594825596325; Wed, 15 Jul 2020 08:06:36 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:35 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Martin Sperl Subject: [PATCH 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Date: Wed, 15 Jul 2020 16:06:19 +0100 Message-Id: <20200715150632.409077-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Kerneldoc function parameter descriptions must be in '@.*: ' format. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'test' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'tx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'rx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'spi' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'test' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'tx' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'rx' not described in 'spi_test_run_test' Cc: Mark Brown Cc: Martin Sperl Cc: linux-spi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-loopback-test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index b6d79cd156fb5..9522d1b5786d5 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -885,10 +885,10 @@ static int spi_test_run_iter(struct spi_device *spi, /** * spi_test_execute_msg - default implementation to run a test * - * spi: @spi_device on which to run the @spi_message - * test: the test to execute, which already contains @msg - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: @spi_device on which to run the @spi_message + * @test: the test to execute, which already contains @msg + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: error code of spi_sync as well as basic error checking */ @@ -957,10 +957,10 @@ EXPORT_SYMBOL_GPL(spi_test_execute_msg); * including all the relevant iterations on: * length and buffer alignment * - * spi: the spi_device to send the messages to - * test: the test which we need to execute - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: the spi_device to send the messages to + * @test: the test which we need to execute + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: status code of spi_sync or other failures */ From patchwork Wed Jul 15 15:06:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665695 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC20913B1 for ; Wed, 15 Jul 2020 15:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3665206E9 for ; Wed, 15 Jul 2020 15:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o9rdZT8H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728212AbgGOPHe (ORCPT ); Wed, 15 Jul 2020 11:07:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbgGOPGj (ORCPT ); Wed, 15 Jul 2020 11:06:39 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EF1C061755 for ; Wed, 15 Jul 2020 08:06:38 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a6so3660546wmm.0 for ; Wed, 15 Jul 2020 08:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=o9rdZT8Hx4ZSY0QyT7IkQ4ORw3I2KhdkBi8D9WD0aKlkOqwzLlsY+8wGm3MgZELZEZ eoxZGyF0WYg3vLxEQtGzR1mPRhYBeowAwZG5Q1ohDhRTF6B7aI/kDZ5zE1rHynHqdjwD Y54oXUrHFNGOjkRgk4fKPU/YwFrCG6KHOLta5pTY2GQOAgYV/hWW7p7fvAIj9huteoSQ oR5UJ1GnrJrbbh6QbH915oTx/e/2TW3Tlgbng7XupxpuplJjwr3xz7gWkoAfFDYwk3yU T/n29AgXpPcokXXb+lnNSy//o0npV250DhZ5HWTzVSajBjsCeZ+1+gxceNq9A5EviKhl XrIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=nyH/xzSqdNNyYVD/7zh1JXXlGlyW/+GN/gGXt3uLnUCjWdXa/a/ghMMRjkdCUfCE7L qKoMpR+bHwp32p1XBy2lsiu0nHPn3e6huENg/lhy8Bf6aOxcAF7I2/8/p4evoB2EP4WP vrGgs4Ewc1HH0LOEawBc2MWq7KO+H+zFVAQ5C1hsLNy+rBpbGnutzG2zaI2QcoSDfNUp XY7kp3btkLZiihXDpg6lBPkuB17BU4OrgviBheSuxgjcqFD+ZIre8QhXtIvlzfLxPsid OQsCcL4o003zsDFQmqd0qLs//q8vrk9iQMXr5e8gJMlzHwk39tvlpbtdpTTf++i+LvER 3oZw== X-Gm-Message-State: AOAM530hvSAk3uNpp54tk2rAIQ4SSqE785u+JcEnBSMz6YjoXbM35g7j 9AT98jnJPQMSbuVidjyctApI7Q== X-Google-Smtp-Source: ABdhPJx9OHW5pgfjAQYGs6oy+4+393KILVPwhdW2gMjyprB70ILbgU/eATaVe2aWskjv61M55Cm5OA== X-Received: by 2002:a1c:7916:: with SMTP id l22mr9762032wme.91.1594825597387; Wed, 15 Jul 2020 08:06:37 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:36 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 15 Jul 2020 16:06:20 +0100 Message-Id: <20200715150632.409077-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-bitbang.c:181: warning: Function parameter or member 'spi' not described in 'spi_bitbang_setup' drivers/spi/spi-bitbang.c:215: warning: Function parameter or member 'spi' not described in 'spi_bitbang_cleanup' drivers/spi/spi-bitbang.c:434: warning: Function parameter or member 'bitbang' not described in 'spi_bitbang_stop' Signed-off-by: Lee Jones --- drivers/spi/spi-bitbang.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c index 68491a8bf7b5b..1a7352abd8786 100644 --- a/drivers/spi/spi-bitbang.c +++ b/drivers/spi/spi-bitbang.c @@ -174,7 +174,7 @@ int spi_bitbang_setup_transfer(struct spi_device *spi, struct spi_transfer *t) } EXPORT_SYMBOL_GPL(spi_bitbang_setup_transfer); -/** +/* * spi_bitbang_setup - default setup for per-word I/O loops */ int spi_bitbang_setup(struct spi_device *spi) @@ -208,7 +208,7 @@ int spi_bitbang_setup(struct spi_device *spi) } EXPORT_SYMBOL_GPL(spi_bitbang_setup); -/** +/* * spi_bitbang_cleanup - default cleanup for per-word I/O loops */ void spi_bitbang_cleanup(struct spi_device *spi) @@ -427,7 +427,7 @@ int spi_bitbang_start(struct spi_bitbang *bitbang) } EXPORT_SYMBOL_GPL(spi_bitbang_start); -/** +/* * spi_bitbang_stop - stops the task providing spi communication */ void spi_bitbang_stop(struct spi_bitbang *bitbang) From patchwork Wed Jul 15 15:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665693 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9155913B1 for ; Wed, 15 Jul 2020 15:07:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A505206E9 for ; Wed, 15 Jul 2020 15:07:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MuVa6YUi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbgGOPGl (ORCPT ); Wed, 15 Jul 2020 11:06:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727848AbgGOPGk (ORCPT ); Wed, 15 Jul 2020 11:06:40 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4AC2C08C5DE for ; Wed, 15 Jul 2020 08:06:39 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 22so5935308wmg.1 for ; Wed, 15 Jul 2020 08:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=MuVa6YUilZbMg938X6+LEiTeMKwmIyt0RScRI3mHKMSuc868HMtye15e+tdjz7hn5l pm6AT7nOyryMAZpDFrCikxebECb2ckO+QnyNGZ5PNQYIudu90DgxNcpa4DuPtVhVjIUa SN8IPX+xnfZAB8oFwQjswqvmWXCNl5KOCfrc+RCbt7EJY9QOTaIuoG+4Ay8r/xYX+oJh iZGI4AKMukXc74MYDDnc2SxtzANeEqihLcQ94ZD+XxjhGJHuZ3b07myurXNAUcCQLAD/ g50CYKeZ/F5UaVtwBdnc/n2IPvzfF6dQV/1Bf5xrb2Hm5uRn+r/OYpDGHLKgLuhHWo1R IO7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=YyVI9Tc30gmZfCd1hyxfVE1RCO9IOS/txR8JwxQh22Ic+qUCix0c/kM7jmVadm3ucP bDdBSNZL7msgTlu625ZDXkk7YhrvZ+kcFmtldBTzRTvQ+IvUOOg3JAAV71GQatifAYdk 5t4KpHhGHtnMIlA8CrB36qOQ0gGRAB6uqt885yyQqAw0wC6CcCZDgVjkqQRceeKdqz3S h3Ej7qGJJh4s5xja8lmaOsx0RTHl5e4NYK2+tWQgUTr+FkPgXEEeq4P/86fWkOtIEByt YO1qyPxNH/avzL38HJqcTyjkMsKKVTnoenI8FFpsqWU2J4ZBU1Nr7/7tAzxILkjkP2cX UXoQ== X-Gm-Message-State: AOAM5314ln5U3ZFDD+faQPOFDu6/ZjCMLNEoOvjZNuCBTptLG2P1OE9y 2v8u7DNKho0K5P2QfGetd3rvqA== X-Google-Smtp-Source: ABdhPJyX7pdGpzS47hcVgtTiOYRgvA0VEgqvOXAjH60JAODiKRtGtZA78dSsUpVRg8hrCzcXmu+7PA== X-Received: by 2002:a7b:c403:: with SMTP id k3mr9037305wmi.35.1594825598535; Wed, 15 Jul 2020 08:06:38 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:37 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Date: Wed, 15 Jul 2020 16:06:21 +0100 Message-Id: <20200715150632.409077-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'dspi' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'max_speed_hz' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Excess function parameter 'maxspeed_hz' description in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:719: warning: Function parameter or member 'data' not described in 'dummy_thread_fn' drivers/spi/spi-davinci.c:719: warning: Excess function parameter 'context_data' description in 'dummy_thread_fn' drivers/spi/spi-davinci.c:735: warning: Function parameter or member 'data' not described in 'davinci_spi_irq' drivers/spi/spi-davinci.c:735: warning: Excess function parameter 'context_data' description in 'davinci_spi_irq' Signed-off-by: Lee Jones --- drivers/spi/spi-davinci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index f50c0c79cbdfa..818f2b22875d2 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -236,7 +236,8 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) /** * davinci_spi_get_prescale - Calculates the correct prescale value - * @maxspeed_hz: the maximum rate the SPI clock can run at + * @dspi: the controller data + * @max_speed_hz: the maximum rate the SPI clock can run at * * This function calculates the prescale value that generates a clock rate * less than or equal to the specified maximum. @@ -710,7 +711,7 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t) /** * dummy_thread_fn - dummy thread function * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * This is to satisfy the request_threaded_irq() API so that the irq * handler is called in interrupt context. @@ -723,7 +724,7 @@ static irqreturn_t dummy_thread_fn(s32 irq, void *data) /** * davinci_spi_irq - Interrupt handler for SPI Master Controller * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * ISR will determine that interrupt arrives either for READ or WRITE command. * According to command it will do the appropriate action. It will check From patchwork Wed Jul 15 15:06:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DF5F138C for ; Wed, 15 Jul 2020 15:07:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15FCF206E9 for ; Wed, 15 Jul 2020 15:07:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oiEqOrmX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbgGOPGm (ORCPT ); Wed, 15 Jul 2020 11:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726941AbgGOPGl (ORCPT ); Wed, 15 Jul 2020 11:06:41 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E06DEC061755 for ; Wed, 15 Jul 2020 08:06:40 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g75so5921081wme.5 for ; Wed, 15 Jul 2020 08:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=oiEqOrmX2BCeuQ06E7MkwpKIP4Kzg4tSFdZCvp67JPPy3zuGG0hk8ZwYm+YrTRxez3 S9iEWCUA4c2hahIplVrfA69MF6/SQ7MGCu8MTU6oORMVoTfX2qt9tENX5pAEPb8hOZkU wj1Sj899IJnMTKboN+ELSEphoncvVC/TXnLx/5IQ2kO8/5kezYniQGyN11ps1lBIbxrr BLYu+c4DRt4uLJAX55f/u/3j2cQ9oI0CFD9/99mXFEMRYQIMXVmKdYhG8xCLiWqH1Ow8 a+ZTDoMSBYXrgIEpzWnr3w8dC3epdyq67iz9Tn+SpBspYuSNkyDDy8a/fdyP4HOLQd2j o5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=aM+6yNVRGFVeXC0oxVIXiUZnPRXH9v0MB1pih5AMauLFtWDKmiEgYVVJQf3ObWwESM y72I0rlUrebSn3dhvSAPPeDbiA+oTF30f1hIoeVQMLnGoUVzEXl5YoUwaBvgLaKNa2Z7 CdwPe0Vu/kcUVpXT2W/Hv5wKbvMKgocGzttR91f0F2flWWwnY3S0ED3eCut3JPvlpeR7 iov0DvDWP/iQ6W0JNnh/ruWBjzGmUsdD3glDektrEboQe4nU/KQIXPTHFlZJzgXLcNX2 ZtRch/KIktvQnkCnvwnM/4vwHLGuuLuOTidppdxu4SnDV6fIHD+QzkIeE+HzFLmuFetD dpRA== X-Gm-Message-State: AOAM530o9P9Aeg/Oypq4q9v5P5UCSeqQvQVxU/fsoVh97jOFadxuVQHY oh5BYWealr8XPZXkC+/C4dlwXg== X-Google-Smtp-Source: ABdhPJzEuvQZZCCGKOKNb4JQQwMdZwBlgkjQDqt0GAJkyBKy+DD1uRuFH0A3VbTwcFKQG0BKip3Drw== X-Received: by 2002:a1c:e383:: with SMTP id a125mr9253712wmh.11.1594825599646; Wed, 15 Jul 2020 08:06:39 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:38 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Mika Westerberg Subject: [PATCH 04/14] spi: spi-ep93xx: Fix API slippage Date: Wed, 15 Jul 2020 16:06:22 +0100 Message-Id: <20200715150632.409077-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org ep93xx_spi_read_write() changed is parameters, but the function documentation was left unchanged. Let's realign. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-ep93xx.c:227: warning: Function parameter or member 'master' not described in 'ep93xx_spi_read_write' drivers/spi/spi-ep93xx.c:227: warning: Excess function parameter 'espi' description in 'ep93xx_spi_read_write' Cc: Mika Westerberg Signed-off-by: Lee Jones --- drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index ae7c79a062084..aa676559d2738 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -214,7 +214,7 @@ static void ep93xx_do_read(struct spi_master *master) /** * ep93xx_spi_read_write() - perform next RX/TX transfer - * @espi: ep93xx SPI controller struct + * @master: SPI master * * This function transfers next bytes (or half-words) to/from RX/TX FIFOs. If * called several times, the whole transfer will be completed. Returns From patchwork Wed Jul 15 15:06:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665689 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C657138C for ; Wed, 15 Jul 2020 15:07:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14C2E206E9 for ; Wed, 15 Jul 2020 15:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zSvp1cyp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgGOPGn (ORCPT ); Wed, 15 Jul 2020 11:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbgGOPGm (ORCPT ); Wed, 15 Jul 2020 11:06:42 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22E28C061755 for ; Wed, 15 Jul 2020 08:06:42 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 17so6165801wmo.1 for ; Wed, 15 Jul 2020 08:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=zSvp1cyp9NwMoDYQ099HhmCQeArDGEPwCWKkWWzxkXBbj5HghEulOTG6delZXfRB4V 7pZwKEOvp46RKySf8Yzgtk9eN3B4BrBHD+xBCvj58iH13cRfFWtS2B5C2Nhix1PIZUxg JREpBcxLC3C7l0qnK44ImxJ1a2yrz/6U6//NpLOhRGhvW5Ui21FgwTqGG8Jn0swFlid/ 7fez9lVPIMrbEJ9VMehmmZlRi4gHVJBZjIzmMBGGfGCL5Rt4m8lN9MaPazxs8psW/9VH iV600X2ZSWoU8ZSzhXfgAfPccHmAflze7iWKZwsSmgjjO7Pft90i2o6F6TpklayyKXza Cw/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=WSuXqIjjxZuMhjSNR4pY6c/3PYC2GnNf3m+Pp8s4QW9ByiucTU5wqK4bZIn4CL/dDW aeXp++u4VbSJwxtsRqPOg5uvQpm9rNJK3lr8r34k+ZZaG9gi9CKQdb5TzFPLTNi7voMK N91ekhHfO62jCcwwhipCfO7rEGAZpGytdnb1Fpi0jpW+ckQ25zX+AO1KP6rDQbdu6XWh vrenb7taBrTffDHXtwoLzycKGY+hjfBr55H74rHP0OsjjJCZq4jI/DlSy0WLJTBmyDn8 nMg9RMd+dersHwpt2e0gVJTx2tTcQT3ZTFzwmEqVKP7cUcTqwjLhrCAV5iQDr5Bdn9+B xZig== X-Gm-Message-State: AOAM532MyVdPUYyfT4NNP6hkkpui9yz8+DKs2toU1/XCHKG6YKDKPEDO e1Uz1HDGhUJOaGlMyvbHFFlefw== X-Google-Smtp-Source: ABdhPJyhdfGUmrtF4d7P3vciFQvDcpZfiGbqTTuoOSU/tp9T2pBra1bNvwYIGOrWZFGbTtCfW3Nx+Q== X-Received: by 2002:a1c:5986:: with SMTP id n128mr8694473wmb.112.1594825600839; Wed, 15 Jul 2020 08:06:40 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:40 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Kevin Hilman , Beniamino Galvani , linux-amlogic@lists.infradead.org Subject: [PATCH 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Date: Wed, 15 Jul 2020 16:06:23 +0100 Message-Id: <20200715150632.409077-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman Cc: Beniamino Galvani Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index c7b0399802913..8eca6f24cb799 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -70,7 +70,7 @@ * @master: the SPI master * @regmap: regmap for device registers * @clk: input clock of the built-in baud rate generator - * @device: the device structure + * @dev: the device structure */ struct meson_spifc { struct spi_master *master; From patchwork Wed Jul 15 15:06:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665685 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2271C13B1 for ; Wed, 15 Jul 2020 15:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B258206E9 for ; Wed, 15 Jul 2020 15:07:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ic4mFINw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgGOPHa (ORCPT ); Wed, 15 Jul 2020 11:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727913AbgGOPGn (ORCPT ); Wed, 15 Jul 2020 11:06:43 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77242C061755 for ; Wed, 15 Jul 2020 08:06:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so6164889wml.3 for ; Wed, 15 Jul 2020 08:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=ic4mFINwL49QSVPf3k9/rgWYim5/9jEoZkN3gqetr4K9fAHlJVyJ3XypL6SuWfRqDz +S7WszcHEof6BWrZKfFj9g/YLF71Qcm1yt4zHcQPPYgdqTAQxCrOZh51+TZvW0YQ8Ck0 aLn5KjCQKZ3Gd/aFzV5L2DQfyiqU8ujb9Iv4xSapyMw6tqW4tt5JwZPpcrPnOA8PiwaE 0yOlSql13qvWzpkdNz/tyd6HeetzNbv+eay/5/xjytCtAkIYMyDbb9Uefd2mAG3NGm2+ EaVE9UW+LkFfgx1Zg5Rp6RueZCf8/5881/TkICwUazyXDTk14I4cs6dLDvr0xHFNjtcl EisA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=IHcMfRLZxX220lK7y9zLD+RHzkGSYdVNcaPPZbecFHYDOek74z66ticUpnsPSAFGOV JhNndawedBqA5JBB1ULfM8KmC7yXVOX3G+SV+K5fssHIv2BrrfPzDqyNnpfHuufF4ELE aY9d0jT8b0Wl6yx2LlhCt/M8kqfQLXG+tkHHsO1P+xYllyl5uDN4baHl31Ld9IM7F7zq 2w8UF73ha30cj7AgKur5FbdkBJUASPJrJAPC7TcMtUYEdNGqPstpBh3GC+Q4YkuHyymS C6cSp093CrZnRzMk7drx/DxVA6ykLXuzOVCJNS8MvZ8J5EtcWwok3WROSBUGD7z15pBz /x3w== X-Gm-Message-State: AOAM530/0cFtuCaSXjraNutWjmWJsxVq+jTwoUgm5jz18WoOEClwQAQe AQPnPVJliJUsjEdiV2QdjIiTpQ== X-Google-Smtp-Source: ABdhPJyhQwehdC5E5vWdp2tq0inGEyTI0AsEuhIDReVDRKACyOC/THNq1DETNswb/m5QQ3kSVY3afQ== X-Received: by 2002:a1c:7315:: with SMTP id d21mr8770056wmb.108.1594825602210; Wed, 15 Jul 2020 08:06:42 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:41 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Kevin Hilman , Neil Armstrong , linux-amlogic@lists.infradead.org Subject: [PATCH 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Date: Wed, 15 Jul 2020 16:06:24 +0100 Message-Id: <20200715150632.409077-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc: Kevin Hilman Cc: Neil Armstrong Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spicc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 77f7d0e0e46ad..ecba6b4a5d85d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) { - u32 data; - if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, SPICC_ENH_MAIN_CLK_AO, @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) spicc->base + SPICC_TESTREG); while (meson_spicc_rxready(spicc)) - data = readl_relaxed(spicc->base + SPICC_RXDATA); + readl_relaxed(spicc->base + SPICC_RXDATA); if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, From patchwork Wed Jul 15 15:06:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665683 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 05E8413B6 for ; Wed, 15 Jul 2020 15:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2081206E9 for ; Wed, 15 Jul 2020 15:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mm5H0gkt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgGOPHa (ORCPT ); Wed, 15 Jul 2020 11:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727926AbgGOPGp (ORCPT ); Wed, 15 Jul 2020 11:06:45 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBF42C08C5DD for ; Wed, 15 Jul 2020 08:06:44 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 22so5935593wmg.1 for ; Wed, 15 Jul 2020 08:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=mm5H0gktuRl27KwOE3Op7rhTrBCOq3IjXtDklC9duhaS3OTT2AIBTmiUK7enabkTxf phcZ+mlV/fhB5510gdwnlVT3Nu8bq+sziuBIoKP6hjoayECw6hdssq4P9CHFYDMgDvIQ ErWfZyh4qn06Cfihd8RkCok4YpfxkvExmV1F49S4++6DMkMoaoPjSjicaXvmiKHPAhAs zamOm620KAFOcYr63wq8QipRJwm8ft++56w68XfTbJiF0Y/z8iqjB7oqiRiK4B4uUWpS X6Lp1A3i1p5aH4zsuxlrzFMGCAXnMp1cnAVb07VjMsCZTEORkYIDT50YyijZRN7wzI4Y PcOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=cZSBmAhANt9nfZPUAfnfH9XjJ1OnEY/qm4HYH1sowzzbnfKtsiiU9OJKGL8SIp9/tH PQCnsXkn9Rke+GGL160VZJ7g6zoY6Y6nqg+V9cR/OeXWBnuIiFJZa83YyxsowHs7uJwX FnVGmhJbk1/G2aMf+MIR7bZxyAUGO8i+RJ0PRvwF+4oA2ptkaahaWXy4SwXew7FEEGmi 7yb36QyIc0stLxFaXeWyb5QmQj/ZZDriXummaOCeVIeQVHP+fTx3HC2wiR2+CWuicqxO XMVi6NxnFQqBcdbdcm0nVYYtHC9WB/s/Scv3gxdgeeJS57t8H6ykfHwSEiGtNdO+pYyb Xiaw== X-Gm-Message-State: AOAM5315Y3OWpkIR9AG5Fo3npteXEuN4qunaCmH4LURUZRG34b0tchJn QqMNywHw8ZUh9uz+IrRDEMViyunID98= X-Google-Smtp-Source: ABdhPJwPI7700rZiGUg8UA2/gAzTCD4H6EyDR617KU4GnsAL6bxdbGHlfr3Qjde6X1ytzLoqJxXbAg== X-Received: by 2002:a05:600c:21cb:: with SMTP id x11mr8697229wmj.141.1594825603705; Wed, 15 Jul 2020 08:06:43 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:42 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Kukjin Kim , Krzysztof Kozlowski , Andi Shyti , Jaswinder Singh , linux-samsung-soc@vger.kernel.org Subject: [PATCH 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data' Date: Wed, 15 Jul 2020 16:06:25 +0100 Message-Id: <20200715150632.409077-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'pdev' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'rx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'tx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_conf' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_id' not described in 's3c64xx_spi_driver_data' Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Andi Shyti Cc: Jaswinder Singh Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-s3c64xx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index cf67ea60dc0ed..924b24441789a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -130,9 +130,11 @@ struct s3c64xx_spi_dma_data { * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register. * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter. * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter. + * @quirks: Bitmask of known quirks * @high_speed: True, if the controller supports HIGH_SPEED_EN bit. * @clk_from_cmu: True, if the controller does not include a clock mux and * prescaler unit. + * @clk_ioclk: True if clock is present on this device * * The Samsung s3c64xx SPI controller are used on various Samsung SoC's but * differ in some aspects such as the size of the fifo and spi bus clock @@ -154,6 +156,7 @@ struct s3c64xx_spi_port_config { * @clk: Pointer to the spi clock. * @src_clk: Pointer to the clock used to generate SPI signals. * @ioclk: Pointer to the i/o clock between master and slave + * @pdev: Pointer to device's platform device data * @master: Pointer to the SPI Protocol master. * @cntrlr_info: Platform specific data for the controller this driver manages. * @lock: Controller specific lock. @@ -166,7 +169,11 @@ struct s3c64xx_spi_port_config { * @xfer_completion: To indicate completion of xfer task. * @cur_mode: Stores the active configuration of the controller. * @cur_bpw: Stores the active bits per word settings. - * @cur_speed: Stores the active xfer clock speed. + * @cur_speed: Current clock speed + * @rx_dma: Local receive DMA data (e.g. chan and direction) + * @tx_dma: Local transmit DMA data (e.g. chan and direction) + * @port_conf: Local SPI port configuartion data + * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { void __iomem *regs; From patchwork Wed Jul 15 15:06:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665667 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18EC313B6 for ; Wed, 15 Jul 2020 15:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDCE72075F for ; Wed, 15 Jul 2020 15:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rtO/R+gF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727981AbgGOPGu (ORCPT ); Wed, 15 Jul 2020 11:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbgGOPGq (ORCPT ); Wed, 15 Jul 2020 11:06:46 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FAECC08C5DF for ; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id o11so3069197wrv.9 for ; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bjh7OhojJcRmD5KkKwacJpyMf8L6Fg+f9kXKvvMc3JQ=; b=rtO/R+gF9zsxdsObRHLZjii928eu9P6U4fV47qT04PDZqfN1Aq+9wmYpIrjcPldh7T yP1DLy0eimKSKjz+BYeWPwFsrz3w33TZgBqvD+zngaL580tLU7cwgnteXFXEa2cVb63a C3hCJVfmWgf8lgOF6706sYiBVu2V51RlGIqpapFdC5++3X0ambcY9JvZQCYe85kYOmw7 bSpz8d0j/QI47062tJVsowpUDTU7eNVnWs3lPdNm2HUsKNOkvlscGCVf3IgWF57B7ma/ SicBianzkJtzdwiwzI2qiNr5ecy2Jif9S6uDJm1um/jUNYgDmdZ52yFNt5ixduLTT+cK f0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bjh7OhojJcRmD5KkKwacJpyMf8L6Fg+f9kXKvvMc3JQ=; b=OhmZB/aBsisf3goLGcA7959VMKkQKPfZ6p8MllvEYUUHG1qwo6190A7qnadgOtvYqS DnNh6CxPOZx2i0QWgqlmwBE6G6ZPw4dlTpqI+ERgHW7E6e1jYxhki6fxsc53tZKP1fva fFGfuoDdIjv0AjxcfXpxugihuJ6KG3p2MGrt+9fS9NAtyJxD42bdpYZOE4SnvoS+pmdr C2M65Tex/YBu2a6aVA7VJTkyWSAg3z3TZcwgipwQ+g7Mfs06iIzzjqa8wMTPkLxUZMde jZc+/6O803hivBEz7ctH6ti72e+jX4e4+gQnb9vemQ9E4CGjrku3Kupx9f8LlReK0ZPb zigA== X-Gm-Message-State: AOAM531Rwq4T6JmC2+NwEBHOCmNMi9u3fB37nxMWg5OJ/uLcmjst/PQF Hj69oiWp1UcRnytTK5R/k62Tzg== X-Google-Smtp-Source: ABdhPJz/qORqv4SB3JCQPZLx2YoBeuFRtlxnr/5oEScOZOZu+WtAdMW0hpudATx8mM94Ld2/ZEFr8w== X-Received: by 2002:adf:fa10:: with SMTP id m16mr7456479wrr.134.1594825605304; Wed, 15 Jul 2020 08:06:45 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:44 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Linus Walleij , Sachin Verma Subject: [PATCH 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Date: Wed, 15 Jul 2020 16:06:26 +0100 Message-Id: <20200715150632.409077-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Also demote non-worthy kerneldoc headers to standard comment blocks. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing ' drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' not described in 'vendor_data' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'rx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'tx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'dma_running' not described in 'pl022' drivers/spi/spi-pl022.c:670: warning: Function parameter or member 'pl022' not described in 'readwriter' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'irq' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'dev_id' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'pl022' not described in 'set_up_next_transfer' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'transfer' not described in 'set_up_next_transfer' Cc: Linus Walleij Cc: Sachin Verma Signed-off-by: Lee Jones Acked-by: Linus Walleij --- drivers/spi/spi-pl022.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 66028ebbc336d..d1776fea287e5 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -298,7 +298,7 @@ enum ssp_reading { READING_U32 }; -/** +/* * The type of writing going on on this chip */ enum ssp_writing { @@ -317,6 +317,7 @@ enum ssp_writing { * @extended_cr: 32 bit wide control register 0 with extra * features and extra features in CR1 as found in the ST variants * @pl023: supports a subset of the ST extensions called "PL023" + * @loopback: supports loopback mode * @internal_cs_ctrl: supports chip select control register */ struct vendor_data { @@ -353,11 +354,14 @@ struct vendor_data { * @read: the type of read currently going on * @write: the type of write currently going on * @exp_fifo_level: expected FIFO level + * @rx_lev_trig: receive FIFO watermark level which triggers IRQ + * @tx_lev_trig: transmit FIFO watermark level which triggers IRQ * @dma_rx_channel: optional channel for RX DMA * @dma_tx_channel: optional channel for TX DMA * @sgt_rx: scattertable for the RX transfer * @sgt_tx: scattertable for the TX transfer * @dummypage: a dummy page used for driving data on the bus with DMA + * @dma_running: indicates whether DMA is in operation * @cur_cs: current chip select (gpio) * @chipselects: list of chipselects (gpios) */ @@ -662,7 +666,7 @@ static void load_ssp_default_config(struct pl022 *pl022) writew(CLEAR_ALL_INTERRUPTS, SSP_ICR(pl022->virtbase)); } -/** +/* * This will write to TX and read from RX according to the parameters * set in pl022. */ @@ -1237,6 +1241,8 @@ static inline void pl022_dma_remove(struct pl022 *pl022) /** * pl022_interrupt_handler - Interrupt handler for SSP controller + * @irq: IRQ number + * @dev_id: Local device data * * This function handles interrupts generated for an interrupt based transfer. * If a receive overrun (ROR) interrupt is there then we disable SSP, flag the @@ -1334,7 +1340,7 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * This sets up the pointers to memory for the next message to * send out on the SPI bus. */ From patchwork Wed Jul 15 15:06:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665677 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 27CDF13B1 for ; Wed, 15 Jul 2020 15:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0698A2065D for ; Wed, 15 Jul 2020 15:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UyEhMAjQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbgGOPGt (ORCPT ); Wed, 15 Jul 2020 11:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727965AbgGOPGs (ORCPT ); Wed, 15 Jul 2020 11:06:48 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D19B8C08C5E1 for ; Wed, 15 Jul 2020 08:06:47 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so6184900wmh.2 for ; Wed, 15 Jul 2020 08:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=UyEhMAjQjWz7s63ZoKbqZd0he72PbgcQoERVqZzfPDdeHfi76qTF2aqAKxzkw+vs8v 1ccaVDSAO4pCzQ94UQJrxVt/sheMgiPUXVzxym6vO5O3kTo9gbcNiNZVaVD1plMF0J3k z3yGisz15rp6uRZwbOTBwSS7WRG2WW4RYhT3UooUQ1/ByKSkNAp8xkJVJkMzDKEaz/uV dY1tnRfjmei2kZiknTPr5tnLNurtxkTSnbU4QVjMd/PG1AQFoIo5f4IX91KQdnkdhecL G0V3E7kPOXw89FXa9PIId9kyqYzc/kbEl6QHQn+6MHKgA350J1Dw6gHOjtOneOkfuyyM 4CgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=VHSq4Viiv27nQECVu6PWGZwsggUQZYsVJfawFOaExm0f/rM3cveFAPEPtjJ3dsHj0V Vl6V4spv+IVG7/vI861Cp2D/gWxlnuqeOVir1w9oXHO6dzRmXZMuhFrBOKELaH3pFD+L H24ev9KpzVoz2UJP2WuLMf4tOjrfS6ry/6v9UVVEtkibnDX7pMu9xGn6GwdGslov2eha o1WdNi0dwZpRGF7MMam2LQI9yppmYGL//NPCsz69r+syze5HUkqvVZ64DkpZxSdrSYXx JBvnFw6QO98LP0FRwl5mcgzzAu7DCxoZtakoUnvREds5r7Hp+DU6uejhGOrbu8FXJiSP iftw== X-Gm-Message-State: AOAM533X3N8h2PVv1X2DptnK8xrpJmbwEtWasBm3ZgJ6/c0LjR4btj+C xQmz16196hN6LIuYmG7+le0ZgA== X-Google-Smtp-Source: ABdhPJx39xtrPHkcaKWFcDV25x4ysJFEnVveAGzGMS6sEEHSQ9JC+ALsZmBUt/eVdulx8vVh0d6eMQ== X-Received: by 2002:a1c:f609:: with SMTP id w9mr9114757wmc.150.1594825606599; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:45 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Michal Simek , Sureshkumar Relli Subject: [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Wed, 15 Jul 2020 16:06:27 +0100 Message-Id: <20200715150632.409077-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Michal Simek Cc: Sureshkumar Relli Signed-off-by: Lee Jones Acked-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency. From patchwork Wed Jul 15 15:06:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665679 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48BF813B6 for ; Wed, 15 Jul 2020 15:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 318E02065D for ; Wed, 15 Jul 2020 15:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KZ/TT1t8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgGOPH3 (ORCPT ); Wed, 15 Jul 2020 11:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727965AbgGOPGt (ORCPT ); Wed, 15 Jul 2020 11:06:49 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE03C061755 for ; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id j4so3047894wrp.10 for ; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IfYptBKxQvrYFn67V4A+QmgFkUNV62He06/dIZhBEjs=; b=KZ/TT1t8CLQwqRlkcCPqM5ZK4eIUzF122chFSiLAFw9aUgHkXoJwedsjFUWNkqBK8w xoB4tfqJRd7SZyxqiKTR0kyAIdXPlACO3EGTzoXFXhuypYOk/pAabYnC9cCRagJh7ra6 ys8mn2pnkIg3p3UpxtX1bwTvZquhEm5FSmtxNhh0OL5NHOsLK1CSoHoAZKQZe3U63AC6 kWdU4mIEZiRg7ZLXpgfvBAeuZbFLsSu/s8OANq5iu9F/gUzRFCpo8TyvZzhRXipVMsh/ W/JWNHB7R1SpSzw5769jWnV7f2oaRtgeMcQNpgQUwUsncIOaqTP5xM4uwZc4qtUaYnV4 /oKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IfYptBKxQvrYFn67V4A+QmgFkUNV62He06/dIZhBEjs=; b=OXKJVXBYMVxUXy/peRhZXgvAZBbgPWaps/NfgGR3QU6wQKPFqi1GaO9ZMbVy9xdVcU yM7IkCxuGpo4Y+HDcAuueGBeWx5O7gxGrDl0nw9CG3ZimpNaN4nDi6O38uon2RtHZUuA YcuLV7Jlq9E588sY6Qruq8aWzXkk5wAQ0jDDU2XETvOcogEDW8tPhVxWeyd5eHzLkicL HevDn4AuoGHKHmHqm+OhN+6WoTA0y1fBRg7WcZUAJZInDtHW2JXbRpZi0yscR9+rUcDI D5k4s5Rm9Eh1HCuk2dnzXGfwz/YM3ao+O1szdbAkAqBUV0wGg2VTEf0Ygk28AcJz+VAE H6/A== X-Gm-Message-State: AOAM531MoKXmMlee5zSzr+Tj1qqjyWUAioa0xRy962imrp2SXFJXxsNb AFzvQSlME0i8+CiANJjXQSlypA== X-Google-Smtp-Source: ABdhPJxrrdTj/aQFIMBJUj58shw/EWz9k6o034iUJPO0GSeP71Qz7tMabUEkuVxpSHB3KuZgJnnDiQ== X-Received: by 2002:a5d:4992:: with SMTP id r18mr11145302wrq.323.1594825608304; Wed, 15 Jul 2020 08:06:48 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:47 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Michal Simek Subject: [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Date: Wed, 15 Jul 2020 16:06:28 +0100 Message-Id: <20200715150632.409077-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend' Cc: Michal Simek Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynqmp-gqspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index 811c97a7c8589..e17a201252557 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset, /** * zynqmp_gqspi_selectslave: For selection of slave device * @instanceptr: Pointer to the zynqmp_qspi structure - * @flashcs: For chip select - * @flashbus: To check which bus is selected- upper or lower + * @slavecs: For chip select + * @slavebus: To check which bus is selected- upper or lower */ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, u8 slavecs, u8 slavebus) @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master, /** * zynqmp_qspi_suspend: Suspend method for the QSPI driver - * @_dev: Address of the platform_device structure + * @dev: Address of the platform_device structure * * This function stops the QSPI driver queue and disables the QSPI controller * From patchwork Wed Jul 15 15:06:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665673 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 56013138C for ; Wed, 15 Jul 2020 15:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F6A62065D for ; Wed, 15 Jul 2020 15:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EzXgoWXV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgGOPGv (ORCPT ); Wed, 15 Jul 2020 11:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727991AbgGOPGv (ORCPT ); Wed, 15 Jul 2020 11:06:51 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5AC9C061755 for ; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f18so3132237wrs.0 for ; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=EzXgoWXVHcblT299CWnFjUwu/qW4z3MCPe2EO1ynFgOADXo0wZ1hvqbPWrfz+tOefw VGGaZd5/muef9MzYyk6NIpaostukgfsY74ELsVkuN6ZdvEB4Q+J3btO58zC484dxcoC7 jdl2m8vMVMOlhrc0xvsq55kzBXJ5aF9Ckq4TuG+MIDJ1ZJj6LFV9hfXvWgNz1PXIwh49 MUqAgaDi/6eYeqRV8KEZqdndWwgVFN1ZaurPwYdAdUUE+bXE3Muc8Q15gmfSdAC/ponK qbDU08/zyrkSq5o8cqOTCtjTrlhrRS3BvWbyXMb9T00Bv3omHZ4gOBBlEwEJwx5mkh5h kQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=aaXbYKD2wd92wFt2TWJAAV18aWBKDpuYeSuMvOooa3klGP0wV5XhEFuUBdCqZar9V4 qNhyoDl0+mxBUfYtSQRdAHECyZ+u1FD+bNbyt2s/AVTHJmVIUqq02PipNZlyzP00vwjb YAimxOU0Gz/RfqulsZbQGBnOKDgXwCkDBoBk1KX6LAnZyr34BtYpLmU4uFgO9CQLleKw PB8hEItMYZO8+rNj39YWIQP34It9L1LZGrx+1FzUp5qgWTwXCSOPcmvKCa46Z5ReCNPB 7X+qWsOiQxrviwCeCJTgRoy67aUQmF2B+a6Ke+1uz/+GiTW07se1/8e8EzLJciyliqhO lJqw== X-Gm-Message-State: AOAM533noU5rznT3FFyAhFkq/jZKNQFQpyS6SL1jSy18WKBithC5Ku9g pc5tr+rebqJozXQDQlBc6/IZLvBrOyQ= X-Google-Smtp-Source: ABdhPJxCpSAQqlbFgoqFALYbH3qfi5+G5rnYppQXXaOhBDyF/njkKYqkmrszZU89byQS4aLL9AvwtA== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr11024451wrs.33.1594825609431; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:48 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones Subject: [PATCH 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Wed, 15 Jul 2020 16:06:29 +0100 Message-Id: <20200715150632.409077-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr; From patchwork Wed Jul 15 15:06:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665671 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9449513B1 for ; Wed, 15 Jul 2020 15:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D1F120672 for ; Wed, 15 Jul 2020 15:07:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RH7cBJ2W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbgGOPGx (ORCPT ); Wed, 15 Jul 2020 11:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728006AbgGOPGw (ORCPT ); Wed, 15 Jul 2020 11:06:52 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2340C08C5DB for ; Wed, 15 Jul 2020 08:06:51 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id a6so3096791wrm.4 for ; Wed, 15 Jul 2020 08:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=42oj6jbSoGTF/ydaYibmpIO6VIJqDyq5aw5c0LpPRTc=; b=RH7cBJ2WlhKQHMXBNizOzo0T2ahy8XU3B6sEARR+uPl/o4nKI3IuEZJ8uLvbbZC5t4 l+AQ8s+3lqDbOapGH58ozWtwg6v2+RT2FZ/JrwPNhkDFeWKYhdds3OJIy2j/3nVpUHrf vghBDZGIJosR4XixZz0e228Ju4WbUGTyTYT3ukz5dmafd9HXsLrkhYug7ZwpZ93bHTAP 2QenT/NInodOgQnlQXZhCDNVS3NG0xHeAslNgHrC3Z4fXIrCBuLGhlx+eqnWpBg6zyd6 SI4SMBZdEt6nG3WgD8giZCqQmEn/lEzYF4u8dFu5sOWMyxqNUNeH2E/mOMwRTNvnggql BEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=42oj6jbSoGTF/ydaYibmpIO6VIJqDyq5aw5c0LpPRTc=; b=bGWsd/rwE+DPdNTcIkZzu4KRrd94ZRGLF41Ooq+w1I6+L9tl5hpuSpGIABPHEVCKJZ L2UjnhuZKYJWSKHlT4acD6q8GTof1O3sy3kBVCX32p79JJlOMLSudG+rheCWUUq7YZCG BVjf+DHVBT75G2rd6eH2RTnLvsGu5SwqpdUIiKA4KxYl0CUTVfaWpwTrrV83kDn839rU cD4f9iOIdOm+pqHOp8D4CECndO1M6PBPpYU7NNhIfKQjokpvb56qcTDGyZIHggOJigtP +Ao6tETLmXusT5PG5awn1fI7VrlRs0/tSswp0b1zdlaacvd5o8JCaK0mopa4QFty+ywH XdVA== X-Gm-Message-State: AOAM533lyrDAu5+38EtE3P9cwxuV0WRFWDC3UsidpF7GprZlt5Qgo/hl FXuTZTH288uypysrX+7RiAWZaA== X-Google-Smtp-Source: ABdhPJxc3qUeyfFWGzOmf9reFa92XgdB27XAAzFJpjdbVd7jj+ddsAHBcS7KpBUlsilZ+jYr/eF36A== X-Received: by 2002:a5d:4a45:: with SMTP id v5mr11986837wrs.228.1594825610727; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:49 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches Subject: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Date: Wed, 15 Jul 2020 16:06:30 +0100 Message-Id: <20200715150632.409077-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org It's there so why not use it. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Radu Pirea Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Lee Jones --- drivers/spi/spi-at91-usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index 88033422a42ae..d47a20be43ccd 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -692,6 +692,7 @@ static struct platform_driver at91_usart_spi_driver = { .driver = { .name = "at91_usart_spi", .pm = &at91_usart_spi_pm_ops, + .of_match_table = at91_usart_spi_dt_ids, }, .probe = at91_usart_spi_probe, .remove = at91_usart_spi_remove, From patchwork Wed Jul 15 15:06:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665675 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 71E6013B1 for ; Wed, 15 Jul 2020 15:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B4732065D for ; Wed, 15 Jul 2020 15:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OeStQ676" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728140AbgGOPHO (ORCPT ); Wed, 15 Jul 2020 11:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728006AbgGOPGx (ORCPT ); Wed, 15 Jul 2020 11:06:53 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 564CCC08C5DB for ; Wed, 15 Jul 2020 08:06:53 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id g75so5921805wme.5 for ; Wed, 15 Jul 2020 08:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=OeStQ676gkLJC9flvx8uGog1ZO5sbiMnJMlr05Al3vZvFQRZHCm9sU16b+mHbGjiu/ zQLROHGqy978gbiKFEpIyBMkOKofeVQ/0xUFfYH39mKo7Q/YCUXT4fDwvOGve9NdyaIX 9oBji0BeVTVDE0SHHoemYV6TVo+WjAKxrdNhNHqSd/H/p+j3DHSbgYtsByjsXwlwg6yh B90amTbQ+xuUjsIMEaeQTQ5v1qC2Q60Kfs8TTa513agQ2PQASIWFW+QdgHaZlhk4wKge XgSqUFE8pvon3wcWLfW14C76/b7c1rRSMvGnEnSCton+69Vj+u/y5VG7MA4JQqEPS5Xd Ycwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=JBesWAtC1FiyInXitv+oQDht8Z9RX2KVfqI4BhFM6mGD3/+dAfXBaoN9z1t6q99iRz TWC5o0IaNIf2KDSjpughDiXvpObUFInCakya5g56jDzfErd6/Zv/mSX2U3IFKAOlwmDD nWJ+gtl77BL1VyGe9VaMQ1j056uci72HLZ2Onu8X1TTvO/1qn8TyFkpog/yboMKm1ccV 2rz2YIxYC+VubOCO53b1axt1qus2Lp3iwZSX9hKvftF1mWTdo1daAbboWKYXKiKseKTN OrrISJwxfr6iHj5zFiKYbhZHN1Uco5k2jrQqtu8yX6gs+6cL08D3NM0XXXt5iFMAPYdN C/dA== X-Gm-Message-State: AOAM533naY34KSYDxMq7FnlgYvFys6EhFSlJcysS4619BmR7PoqokE9I sCzPUnFjJsLD1ekuWlGTE3VOUQ== X-Google-Smtp-Source: ABdhPJyBnfjeYbjMACkhjMYXKR10NpPlrtS5qROBcZV5AlpsItZlXQak8hpIg97VCabsero4VDwi7w== X-Received: by 2002:a1c:a557:: with SMTP id o84mr9230410wme.42.1594825612087; Wed, 15 Jul 2020 08:06:52 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:51 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Daniel Mack , Haojian Zhuang , Robert Jarzmik Subject: [PATCH 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when Date: Wed, 15 Jul 2020 16:06:31 +0100 Message-Id: <20200715150632.409077-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 | static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- drivers/spi/spi-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 0040362b71622..814268405ab0b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1432,6 +1432,7 @@ static void cleanup(struct spi_device *spi) kfree(chip); } +#ifdef CONFIG_ACPI static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, @@ -1442,6 +1443,7 @@ static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { }, }; MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif /* * PCI IDs of compound devices that integrate both host controller and private From patchwork Wed Jul 15 15:06:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665669 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A172138C for ; Wed, 15 Jul 2020 15:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31F1A20787 for ; Wed, 15 Jul 2020 15:07:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BYmhvu/P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728127AbgGOPHM (ORCPT ); Wed, 15 Jul 2020 11:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728043AbgGOPGz (ORCPT ); Wed, 15 Jul 2020 11:06:55 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B81C8C08C5DB for ; Wed, 15 Jul 2020 08:06:54 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f2so3064118wrp.7 for ; Wed, 15 Jul 2020 08:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=BYmhvu/PhXomekAXRVNla/c/6EiDYkDyIEEP+MnOTHWaO96GdMvSUBbWJS2c9+d7Jk VRcp05/uXtkltdnBCD3P4U/6uWXmTugA1wexZ81oTwI5iXU7B5eDg18v1fmgG2gpnKrY it07272+neTo2ZgSdaMpbMxWIRl/CJYkeFY2bH2Qc3ma0Q8+h02ZtLTMWgAnGuztvZYn ugk+ds7CLMSz5QoMkAHIgg+y7QLjfsXOlV07N2pPDjgbpagdKNJ8+SYYTPvMc5djiWwH 5awGcZaMqjxnB/PtmoiA5Wx4+EdazDc9VX+/311LH/1OaZcHs/cKfKmw2aCAutzqfQJB lAvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=PZbkgJntwgcT5VC3nAZVsk3WVGfT90ERwjMbSJfnqfAJw/9QvC2ArF4YJ6rfK/pLqn VwBRniJNnpA1qPY8Ij+BmO41/dXvCThvgP/EympLyiPmZnPfdxJeSc3su/uXML8uqshg uQKP75nKS7b1HxweVATKLRv67X0N4wUYDowuR/0d9rZfiYYtWOL8HkS6mOD02uiFRTZx GjDz/hb1a+HVEkqKCx6Gf/LJQ+SEl/6swrjWWIO5FpM/BlrZkCmX0oAruCRSerWZoCf/ v7whRZaezPj7Bg5lha5NVZrUwdBTLzZ+gZaVZXptFc+RR+ZFxpPVp4Ena+e0+0DwFHIG LLzA== X-Gm-Message-State: AOAM531mJ75Pf5S0rVK2jjS7GE23FiaqcQOfbkwOlE0mXIH2lk6TlN6I wQWmXDmuEhVQqEntZqj3g0HnIQ== X-Google-Smtp-Source: ABdhPJzKOkWoJ5Xd1No49tmC7h+p+Lj1YSarlHghqR0fzO+t7pGvO0lAkoOgf54GCL5hcHwEPQMssg== X-Received: by 2002:adf:f6cb:: with SMTP id y11mr11810561wrp.100.1594825613486; Wed, 15 Jul 2020 08:06:53 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:52 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Lee Jones , Sanjay R Mehta Subject: [PATCH 14/14] spi: spi-amd: Do not define 'struct acpi_device_id' when Date: Wed, 15 Jul 2020 16:06:32 +0100 Message-Id: <20200715150632.409077-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct acpi_device_id spi_acpi_match[] = { | ^~~~~~~~~~~~~~ Cc: Sanjay R Mehta Signed-off-by: Lee Jones --- drivers/spi/spi-amd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c index d0aacd4de1b9e..7f629544060db 100644 --- a/drivers/spi/spi-amd.c +++ b/drivers/spi/spi-amd.c @@ -294,11 +294,13 @@ static int amd_spi_probe(struct platform_device *pdev) return err; } +#ifdef CONFIG_ACPI static const struct acpi_device_id spi_acpi_match[] = { { "AMDI0061", 0 }, {}, }; MODULE_DEVICE_TABLE(acpi, spi_acpi_match); +#endif static struct platform_driver amd_spi_driver = { .driver = {