From patchwork Wed Jul 15 15:06:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665703 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33BD313B1 for ; Wed, 15 Jul 2020 15:08:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3A9B20658 for ; Wed, 15 Jul 2020 15:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eNUwfX6p"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GJNtHxOO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3A9B20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LF/xDE5947mtveu/ix9LY4sZMEMK3gPHIbbOyzsIOdE=; b=eNUwfX6pGMAouvWmr4aUZNi2/ NuYEAEQNRyxtmsizbkkkcXoPwSFtzIcSzeLlbWVzBp6cRUXIoYlH+qBXAahZnWY4OoqqAa//p+e6Q EVnzNen/h85mbPJBPS6Xeh+E5UKZEbNc3H+vgPGuIAhbpG8ldpXWTdUOyILkJ6GVuQRdM7UqpuyBT X3+8NMwx1sq+bEhziOlEFJI3UFC+4sV/Wc1q+ALjq1xs+urTMBnZv9xYVUMvm44qatu82oa0ruzjy 0xXcQ+9rhZIUfa9EdUii2FI8/QR7//zgXjDoCBiaOM3+AmeP9fbp0dO+cRDxLgUhCTu3dMzNFggv0 S7po+gQvg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizd-0006Uk-Hf; Wed, 15 Jul 2020 15:06:45 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizV-0006RC-7x for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id f18so6164592wml.3 for ; Wed, 15 Jul 2020 08:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=GJNtHxOOPRZtWeTHohDWQFHqjfvGxwnNJdz6voIjChor1Ex7zIh4RYKL7WWFAzR67l f7K6Mns+x6QufGhR0YGwcwSB6Ksx1+20gB3D0ECOxU5kJQGoqjY8exCJTAt8dQkkp3es KBfkVws4SnYAGHAmAiNEENKUgAG1i+aKYJjtbRNcMGdddULPquE6SyXgXnJMWKLw3ESF qAiZll4KqluNRYd8wNJwHDavMEF6i/6Yw2Ywx+6HqNXeMzoIymgEW3MHNV0mpfIhR9qG qCXTeImq1wgSxS2sBsd/telggQixF4aMfmSfSnxUZK5dN1xRAf/sqplOCqD1E6kuaGjW hUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=JW+3GsyzBnxKhgjz8e6crlun092eT42GY7HotA/EIiQSCia9QTDSVQUo0JAEaGr7WQ ztKLZj/Q7503YE9cl+gQqDduqnhnIZTftu9CvwtlOGtaWGQCJHvA+F9dcLOYvZrdh6ht z1B4kwVt+QaMFwZsXPGPO2PTXc5ghOCM8bwgPXq8Iv4/uraD+reDgPBYtN1yVy7l1WuZ 1k3VCH27NRNVHA30iLwN2HHM8pLYN8i5Jc2ZJ94P34N17YuMh3W5aEf7dFJDoirTg0yA J5naPnDTCTNIaNto7PhgwoN4O8Sa2cbybPcDVG0SowuD7P4vqKQNBtjOeumQcCjJjnzQ 8lrw== X-Gm-Message-State: AOAM530tZ3zIyGrYBjEhK/9B9a81eFJ5d3nDToiSwpHK5dzsZFcDNLaX V1YoOy72ht5cl5XdJAdXw+GqFg== X-Google-Smtp-Source: ABdhPJxcPdfqVlAgwpuDa0tcwDk1FMUSmp8ir4ZG/rOkWM0vMSIRi4JhoDhnJtEr1vPL8BvGTLjNhw== X-Received: by 2002:a1c:e285:: with SMTP id z127mr9115336wmg.162.1594825596325; Wed, 15 Jul 2020 08:06:36 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:35 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Date: Wed, 15 Jul 2020 16:06:19 +0100 Message-Id: <20200715150632.409077-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110637_337656_B18867BA X-CRM114-Status: GOOD ( 12.62 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Sperl , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc function parameter descriptions must be in '@.*: ' format. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'test' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'tx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'rx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'spi' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'test' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'tx' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'rx' not described in 'spi_test_run_test' Cc: Mark Brown Cc: Martin Sperl Cc: linux-spi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-loopback-test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index b6d79cd156fb5..9522d1b5786d5 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -885,10 +885,10 @@ static int spi_test_run_iter(struct spi_device *spi, /** * spi_test_execute_msg - default implementation to run a test * - * spi: @spi_device on which to run the @spi_message - * test: the test to execute, which already contains @msg - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: @spi_device on which to run the @spi_message + * @test: the test to execute, which already contains @msg + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: error code of spi_sync as well as basic error checking */ @@ -957,10 +957,10 @@ EXPORT_SYMBOL_GPL(spi_test_execute_msg); * including all the relevant iterations on: * length and buffer alignment * - * spi: the spi_device to send the messages to - * test: the test which we need to execute - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: the spi_device to send the messages to + * @test: the test which we need to execute + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: status code of spi_sync or other failures */ From patchwork Wed Jul 15 15:06:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665709 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 064E513B1 for ; Wed, 15 Jul 2020 15:09:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D40AF2065D for ; Wed, 15 Jul 2020 15:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F5wpXuqx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o9rdZT8H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D40AF2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=95s9GyOf7k3iioROZrQEk0BLADfHyFdhYvxWADSnOyE=; b=F5wpXuqxVUT71TyxscWTRmGxu FH+2UO5hsx8wcd16kUpzZ/LlCuMsRCNi4Ygq7asUT+tnsNjpTw6QxvsZDYv9+h2AYRGbp8xHgzok5 OvkBum7c5iv5700SCh6d2TdMRYEn2IK7bkq9xqVFD2ZKVJknRKT1AwN6y+0lJVnxGTobxI/t9fRhr pT026qeH3wEfiU+aPMGH+pyoLZLltZtCawuyC57duJPeL+tReukifSz16AyQ0LvM3MNk9X9faB2Us mq2FTLZEpzDeK2LGPQuCmhLiDPaUs1NkEuVssQaeGSYuWuaKtjC67T5/pkMNMdVmokGEkj4aN9YCM ynM2LGtYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizq-0006Zq-Jl; Wed, 15 Jul 2020 15:06:59 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizW-0006Ra-Ds for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:39 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so5946666wmj.2 for ; Wed, 15 Jul 2020 08:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=o9rdZT8Hx4ZSY0QyT7IkQ4ORw3I2KhdkBi8D9WD0aKlkOqwzLlsY+8wGm3MgZELZEZ eoxZGyF0WYg3vLxEQtGzR1mPRhYBeowAwZG5Q1ohDhRTF6B7aI/kDZ5zE1rHynHqdjwD Y54oXUrHFNGOjkRgk4fKPU/YwFrCG6KHOLta5pTY2GQOAgYV/hWW7p7fvAIj9huteoSQ oR5UJ1GnrJrbbh6QbH915oTx/e/2TW3Tlgbng7XupxpuplJjwr3xz7gWkoAfFDYwk3yU T/n29AgXpPcokXXb+lnNSy//o0npV250DhZ5HWTzVSajBjsCeZ+1+gxceNq9A5EviKhl XrIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=CbgK/JGB+QDtLFXbW/Q11av0YmxGBfqaZI3NIz40bvBh0jSV6AQZGrzASNXiPHYj0S T2fd2Mj6cDIlVNebVDwSdYyiFgJje/9/G1LBWJIfgY6dM8N1PMJsVaDy7ZBoE7hHRK7+ A3Q7VplKg5twIEXLC1wDeLxL1CxzcLpHWL2vwM3auNLZpgT9C/yLUhXeLQquAgJc0xor dBlBf42o7XmN0NwLxyA3lbgtXsm7P191uLV37lQK502On4qIBIT4nUzaHRoiu9ha7Tic WDF5+wT8x3KpufOOJE6zrLJWniluIAv5ERFN0u43B25JcX2NWmZ/svDgcLwDFX/HKBnC MG9g== X-Gm-Message-State: AOAM5300QrqptwPgy3i4IcUb8jAFIs6pJMwBab6+5cIhS+SH0io6siV0 O/xPez61Fg6shvaqrvw9/zmy4w== X-Google-Smtp-Source: ABdhPJx9OHW5pgfjAQYGs6oy+4+393KILVPwhdW2gMjyprB70ILbgU/eATaVe2aWskjv61M55Cm5OA== X-Received: by 2002:a1c:7916:: with SMTP id l22mr9762032wme.91.1594825597387; Wed, 15 Jul 2020 08:06:37 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:36 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Date: Wed, 15 Jul 2020 16:06:20 +0100 Message-Id: <20200715150632.409077-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110638_490426_2E3B12B9 X-CRM114-Status: GOOD ( 10.12 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-bitbang.c:181: warning: Function parameter or member 'spi' not described in 'spi_bitbang_setup' drivers/spi/spi-bitbang.c:215: warning: Function parameter or member 'spi' not described in 'spi_bitbang_cleanup' drivers/spi/spi-bitbang.c:434: warning: Function parameter or member 'bitbang' not described in 'spi_bitbang_stop' Signed-off-by: Lee Jones --- drivers/spi/spi-bitbang.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c index 68491a8bf7b5b..1a7352abd8786 100644 --- a/drivers/spi/spi-bitbang.c +++ b/drivers/spi/spi-bitbang.c @@ -174,7 +174,7 @@ int spi_bitbang_setup_transfer(struct spi_device *spi, struct spi_transfer *t) } EXPORT_SYMBOL_GPL(spi_bitbang_setup_transfer); -/** +/* * spi_bitbang_setup - default setup for per-word I/O loops */ int spi_bitbang_setup(struct spi_device *spi) @@ -208,7 +208,7 @@ int spi_bitbang_setup(struct spi_device *spi) } EXPORT_SYMBOL_GPL(spi_bitbang_setup); -/** +/* * spi_bitbang_cleanup - default cleanup for per-word I/O loops */ void spi_bitbang_cleanup(struct spi_device *spi) @@ -427,7 +427,7 @@ int spi_bitbang_start(struct spi_bitbang *bitbang) } EXPORT_SYMBOL_GPL(spi_bitbang_start); -/** +/* * spi_bitbang_stop - stops the task providing spi communication */ void spi_bitbang_stop(struct spi_bitbang *bitbang) From patchwork Wed Jul 15 15:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665705 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C76A013B6 for ; Wed, 15 Jul 2020 15:08:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E3F42065D for ; Wed, 15 Jul 2020 15:08:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fu/hXd+o"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MuVa6YUi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E3F42065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7RxlMuun9DUKSLYkPsN7hqw3mCGiSLNV/fKakrWvYWA=; b=Fu/hXd+o8YyMkHfdLf06Lgrw7 0dtzoj1QxYydvCLjqdSzbkmBSrM7tM0eGkj8YR4yxdHByAuuI8XiWfAE41bpvPid5uRb4+0L3Cg4J 3nYi7nLuQt9pHKo0bdy0TFJsE+g1E+bo6zhdkmAccP+FV0x/J+L08JgZsnASWmny08g99xT/TSVfd vsMiwVWvaXu7kOqxX5YF0b4ngvmMXUyKvZiF7iw1/L+MAemOp2aq5NsUFDMqY286CfhjZuJC2ANho 1PdqqpAAYFq1ToJUiRZX4kdve6JMFIdmGRb34OBtlcwVHtbmTkTAl76Y/EIQaQdDurcZQoxMauJ0L hQz1ocn4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizw-0006bd-H4; Wed, 15 Jul 2020 15:07:04 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizX-0006S0-Cv for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:40 +0000 Received: by mail-wm1-x343.google.com with SMTP id c80so5943336wme.0 for ; Wed, 15 Jul 2020 08:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=MuVa6YUilZbMg938X6+LEiTeMKwmIyt0RScRI3mHKMSuc868HMtye15e+tdjz7hn5l pm6AT7nOyryMAZpDFrCikxebECb2ckO+QnyNGZ5PNQYIudu90DgxNcpa4DuPtVhVjIUa SN8IPX+xnfZAB8oFwQjswqvmWXCNl5KOCfrc+RCbt7EJY9QOTaIuoG+4Ay8r/xYX+oJh iZGI4AKMukXc74MYDDnc2SxtzANeEqihLcQ94ZD+XxjhGJHuZ3b07myurXNAUcCQLAD/ g50CYKeZ/F5UaVtwBdnc/n2IPvzfF6dQV/1Bf5xrb2Hm5uRn+r/OYpDGHLKgLuhHWo1R IO7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=QVXOJ5Bh8UGTTHm1ZyklVG4ZWgFhgC1xCxQ8/ERWQsZSvNkdfq4zmG2tLyv0B4Ijwo dIxPTpQ6AldDc8TduqPXVR0pVs3IvL2gpjku3Duoz4OKlh4by/hGyynzkulKuZm93piL RNY+dhPqiRJFZZltpvbBjbX6gorESP6hGQdNScm0okeaisMajZnNvsl25BsFnS4YfnoT zZad76B61RVwTqGeA76Zc9bhO99Gl3EYixF4ILl6Mmhf+cgR1T68qj11RLEO3p7i2u5g PSUa81gjQFiysfsdzS7xYvEUHmF19QRwFEDmLLCGUqmrODX3dqcKYXxjisdCtdhISdUB AjcA== X-Gm-Message-State: AOAM530EVdKkVDP8IAiEZU/F6yvZ8ep3rigOugg4aI/5ENWHU0k37/zm vv/2UaLy+6WF4Xlt/1GeVTGqSA== X-Google-Smtp-Source: ABdhPJyX7pdGpzS47hcVgtTiOYRgvA0VEgqvOXAjH60JAODiKRtGtZA78dSsUpVRg8hrCzcXmu+7PA== X-Received: by 2002:a7b:c403:: with SMTP id k3mr9037305wmi.35.1594825598535; Wed, 15 Jul 2020 08:06:38 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:37 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Date: Wed, 15 Jul 2020 16:06:21 +0100 Message-Id: <20200715150632.409077-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110639_520003_B934D2F2 X-CRM114-Status: GOOD ( 12.21 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'dspi' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'max_speed_hz' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Excess function parameter 'maxspeed_hz' description in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:719: warning: Function parameter or member 'data' not described in 'dummy_thread_fn' drivers/spi/spi-davinci.c:719: warning: Excess function parameter 'context_data' description in 'dummy_thread_fn' drivers/spi/spi-davinci.c:735: warning: Function parameter or member 'data' not described in 'davinci_spi_irq' drivers/spi/spi-davinci.c:735: warning: Excess function parameter 'context_data' description in 'davinci_spi_irq' Signed-off-by: Lee Jones --- drivers/spi/spi-davinci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index f50c0c79cbdfa..818f2b22875d2 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -236,7 +236,8 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) /** * davinci_spi_get_prescale - Calculates the correct prescale value - * @maxspeed_hz: the maximum rate the SPI clock can run at + * @dspi: the controller data + * @max_speed_hz: the maximum rate the SPI clock can run at * * This function calculates the prescale value that generates a clock rate * less than or equal to the specified maximum. @@ -710,7 +711,7 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t) /** * dummy_thread_fn - dummy thread function * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * This is to satisfy the request_threaded_irq() API so that the irq * handler is called in interrupt context. @@ -723,7 +724,7 @@ static irqreturn_t dummy_thread_fn(s32 irq, void *data) /** * davinci_spi_irq - Interrupt handler for SPI Master Controller * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * ISR will determine that interrupt arrives either for READ or WRITE command. * According to command it will do the appropriate action. It will check From patchwork Wed Jul 15 15:06:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665711 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C0AF138C for ; Wed, 15 Jul 2020 15:09:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6352A2065D for ; Wed, 15 Jul 2020 15:09:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MWNZLSm8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oiEqOrmX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6352A2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XD8LLudLHueNxs/FrXCVOrYvXOU66rl3QbxjkzukUDk=; b=MWNZLSm81VPl/p5EHK4KWRONl xko4sOCrrWliv0AZgnEfwjDQmXacf9m7BgfgdYo45loxxtkJGuDoFhwO58IFgwfHhbCUE5CGmGGHp DUzVX8KDdWVeeR0oiW+2XaWdedTnlum+Psc7LWYfiXrbgA4a8zljkmd7vR+TwqKEqFMmYcSEn1yN2 tbP14QK4+o1SdYOQ4CqujVOGAxxVAgCVrmOTfZDED+bsrKsG3Ua2pe4NjGjvT/zbLkoKn3F7oVL9X z9aAxlvBEMZnUa1/KJA1kcm++pnd4cF8Q6wt5O4oaCWLZB7GvcoOznhZa+QRHRYrcNMdVUHpOKIrz 60S6KcImw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj08-0006hT-TA; Wed, 15 Jul 2020 15:07:17 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizY-0006ST-Ja for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:43 +0000 Received: by mail-wm1-x341.google.com with SMTP id l2so6190754wmf.0 for ; Wed, 15 Jul 2020 08:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=oiEqOrmX2BCeuQ06E7MkwpKIP4Kzg4tSFdZCvp67JPPy3zuGG0hk8ZwYm+YrTRxez3 S9iEWCUA4c2hahIplVrfA69MF6/SQ7MGCu8MTU6oORMVoTfX2qt9tENX5pAEPb8hOZkU wj1Sj899IJnMTKboN+ELSEphoncvVC/TXnLx/5IQ2kO8/5kezYniQGyN11ps1lBIbxrr BLYu+c4DRt4uLJAX55f/u/3j2cQ9oI0CFD9/99mXFEMRYQIMXVmKdYhG8xCLiWqH1Ow8 a+ZTDoMSBYXrgIEpzWnr3w8dC3epdyq67iz9Tn+SpBspYuSNkyDDy8a/fdyP4HOLQd2j o5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=udLBMx2g+PDXkBLj7aoneq3adnU3nx6/AyVr5g0re3U9V+IvAIJWdknggydIHaHiFw lkc8uiYWvHN1xwd5qTefrv7fwxU7xSFAavGyjmrWIK5zwo3AqQMis4H8IAW11zVueCAD mrGUKeWHdYv48KB23eDE0GnzLnjPuefvLhAwEFZSDaJURbIl08MUQXevJe9QEE52n7ww Ofz2I0R1EiP0xjinp+1QPxNPik6ZVwO/A/i1PQd3U/VZ3BlSlh8rkLo2801xd1vxntfa ovLGEcVCDmqELQKh3zK1HdB3TJh6XQbt+qbVP3png46YM8V/KeUM1+yTd+ECn7sCx/Rw 9YBQ== X-Gm-Message-State: AOAM530Z8g6K1rXcLBCA2DuV3r4k60AP+9DsPYIfrpszj328EE/e15hB Pv87AmTb//StZlVlksOrmErfBNx+wdM= X-Google-Smtp-Source: ABdhPJzEuvQZZCCGKOKNb4JQQwMdZwBlgkjQDqt0GAJkyBKy+DD1uRuFH0A3VbTwcFKQG0BKip3Drw== X-Received: by 2002:a1c:e383:: with SMTP id a125mr9253712wmh.11.1594825599646; Wed, 15 Jul 2020 08:06:39 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:38 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 04/14] spi: spi-ep93xx: Fix API slippage Date: Wed, 15 Jul 2020 16:06:22 +0100 Message-Id: <20200715150632.409077-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110640_725306_CA2983F2 X-CRM114-Status: GOOD ( 11.95 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mika Westerberg , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ep93xx_spi_read_write() changed is parameters, but the function documentation was left unchanged. Let's realign. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-ep93xx.c:227: warning: Function parameter or member 'master' not described in 'ep93xx_spi_read_write' drivers/spi/spi-ep93xx.c:227: warning: Excess function parameter 'espi' description in 'ep93xx_spi_read_write' Cc: Mika Westerberg Signed-off-by: Lee Jones --- drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index ae7c79a062084..aa676559d2738 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -214,7 +214,7 @@ static void ep93xx_do_read(struct spi_master *master) /** * ep93xx_spi_read_write() - perform next RX/TX transfer - * @espi: ep93xx SPI controller struct + * @master: SPI master * * This function transfers next bytes (or half-words) to/from RX/TX FIFOs. If * called several times, the whole transfer will be completed. Returns From patchwork Wed Jul 15 15:06:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665713 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFD5E13B1 for ; Wed, 15 Jul 2020 15:09:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C965120658 for ; Wed, 15 Jul 2020 15:09:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0j6HthON"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zSvp1cyp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C965120658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pED7XFveHCYBLoS4nA6D9NqQcOYRTVjxom453MKgCP4=; b=0j6HthON6isFdlTkDdOhTgXcS eS8jsUUQH5kuio3Ooe+b7SdJ0o3Xcc/Mu6zNFCA6acVmyqoTp5BPIeTFk58oHuyF5/acFwmpIY7DH pU3KuEi2ErFKi4vj7exPoM3OOQ7IqTWLmkKUB1pA5hhzthVinuLYx2GRM7GoNoACnAmV8JudNYrSe 4yLv+bdrMcEKACLFJyT1b0VgPOlDSKiO7CBG2Mw8INZwn4oxn4WuD3c6NI7bPf7wDsyO+R6e30bwI J45yLYyjDtkCU5joQfu8U6apCu1eZslWhM0zzNx6ZfP0tCXvzd9e+bf2zkozoUQT4MZenK4jmFN9Q T+Jo5xjlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj0L-0006mJ-TN; Wed, 15 Jul 2020 15:07:30 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizZ-0006TK-QD for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:43 +0000 Received: by mail-wm1-x342.google.com with SMTP id f18so6164803wml.3 for ; Wed, 15 Jul 2020 08:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=zSvp1cyp9NwMoDYQ099HhmCQeArDGEPwCWKkWWzxkXBbj5HghEulOTG6delZXfRB4V 7pZwKEOvp46RKySf8Yzgtk9eN3B4BrBHD+xBCvj58iH13cRfFWtS2B5C2Nhix1PIZUxg JREpBcxLC3C7l0qnK44ImxJ1a2yrz/6U6//NpLOhRGhvW5Ui21FgwTqGG8Jn0swFlid/ 7fez9lVPIMrbEJ9VMehmmZlRi4gHVJBZjIzmMBGGfGCL5Rt4m8lN9MaPazxs8psW/9VH iV600X2ZSWoU8ZSzhXfgAfPccHmAflze7iWKZwsSmgjjO7Pft90i2o6F6TpklayyKXza Cw/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=ERIYY95DGOQymLFjGAtaF+Lhdy9sNCgtyFRIS3+2cUX/Bc8HX9f+h5EBQ72MtCax96 EVWrIZsrUPT77P2wUhrUFIGVpagbDim2BEhBQxvB6IXeaJggb7Z1BYrwd3iOY4ayKaMP aZWtKtxkCVje98MqyJcE8rFoBMpG4n2Odlr1B1lp0pw047ElxL1cX81WXxEFTOL2XoNj u/3Ru5/c+N1vef+JKveapIm60LWJGedD5FqHLmmQjRYRfM784moqo00esiswC/TuNkZz XRrkd/XbewY2yEjdZH4braTeMD2UlK2j05I9nMkUGWL4E/jwcxwK9SB22h/ZDMyX1ctJ S5mA== X-Gm-Message-State: AOAM533yKgKqAdzrCjaxHJLzZ/Bn9S5gVpAk5d5w0cDqbxg0qwxrjOw+ YD2dqI795+YbpO6F0ALuCJdvHw== X-Google-Smtp-Source: ABdhPJyhdfGUmrtF4d7P3vciFQvDcpZfiGbqTTuoOSU/tp9T2pBra1bNvwYIGOrWZFGbTtCfW3Nx+Q== X-Received: by 2002:a1c:5986:: with SMTP id n128mr8694473wmb.112.1594825600839; Wed, 15 Jul 2020 08:06:40 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:40 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Date: Wed, 15 Jul 2020 16:06:23 +0100 Message-Id: <20200715150632.409077-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110641_973154_6EA3B693 X-CRM114-Status: GOOD ( 12.75 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Beniamino Galvani , linux-amlogic@lists.infradead.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman Cc: Beniamino Galvani Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index c7b0399802913..8eca6f24cb799 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -70,7 +70,7 @@ * @master: the SPI master * @regmap: regmap for device registers * @clk: input clock of the built-in baud rate generator - * @device: the device structure + * @dev: the device structure */ struct meson_spifc { struct spi_master *master; From patchwork Wed Jul 15 15:06:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665715 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 807FE138C for ; Wed, 15 Jul 2020 15:09:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34A7F20658 for ; Wed, 15 Jul 2020 15:09:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c2os0s65"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ic4mFINw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A7F20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N88oh4Ui9KCYw774r+jCwX+Tj5IDQUK9bFhcrtsqTrU=; b=c2os0s65Pa4JPGdacyqjZipid VB5VVZ81HUal8nTUaSjAbRSNmYAhkpvK1eWEE/b+bwSdNWb3jyvQrLLHRd2V33Y5KDP0smjol4VPA 4mBGpGLoA5N5aawKscu94h/dTx319EsK17dDxzEN5taFZYolM2CIfT7Gv/cBCe5tZ/khJnOUXyRXa dBRrJEVFITp134KqzRUw0j9I6QqGYrbBxMHnl8FyUg1G4ItOdx4YkL6tNF3QBNnIPZ2vuwBgR67CA AIxwVejUK+0xExU7R7OKS2ZDOODCd2GdguCpKqUTxeoR/vGv1BPitGfGZVJPGune0ZRmswvFxyh+6 dcLXj4/ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj0b-0006s7-6v; Wed, 15 Jul 2020 15:07:45 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizb-0006U8-3h for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:47 +0000 Received: by mail-wm1-x344.google.com with SMTP id g75so5921268wme.5 for ; Wed, 15 Jul 2020 08:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=ic4mFINwL49QSVPf3k9/rgWYim5/9jEoZkN3gqetr4K9fAHlJVyJ3XypL6SuWfRqDz +S7WszcHEof6BWrZKfFj9g/YLF71Qcm1yt4zHcQPPYgdqTAQxCrOZh51+TZvW0YQ8Ck0 aLn5KjCQKZ3Gd/aFzV5L2DQfyiqU8ujb9Iv4xSapyMw6tqW4tt5JwZPpcrPnOA8PiwaE 0yOlSql13qvWzpkdNz/tyd6HeetzNbv+eay/5/xjytCtAkIYMyDbb9Uefd2mAG3NGm2+ EaVE9UW+LkFfgx1Zg5Rp6RueZCf8/5881/TkICwUazyXDTk14I4cs6dLDvr0xHFNjtcl EisA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=qjKRz0mX+0mm1uKPLktp1RNhE2ALavYYRECa/e/bV+5WEyoaPR42DWkNjP8YqscNIq IEyDKBd9fHH1qG5zV8tc8/ACg+9UucjHts1qa24FRxiBkqvo4nFOWebgXVhW2gHujNQr lFJs0Q5IZjZmSN2CAQFSKN7BasqvzUtF7tDVdpk/TCUk4sc3LcnzpHvW5AgT66Gu/n5r cmobNj7XAMhPZ8a0dE7gEXo5QS8CBBMi/zjsgXczSTXTLEB/F/ffXgT1KrI3/kEOsQt7 il+dGuCJFJyQz1LkUZWIfhwfFKGoyVMWtST08U1uS0Ze3pWr29btBo2KmYJhwDf2Pd0K s8kA== X-Gm-Message-State: AOAM533vdNLYvlQ3uSgko5KhWtyzn1xQ5b/04qbwP4gydyohqvEulIiE PpVg+LnhTIPmuybcKNk4Ako+dg== X-Google-Smtp-Source: ABdhPJyhQwehdC5E5vWdp2tq0inGEyTI0AsEuhIDReVDRKACyOC/THNq1DETNswb/m5QQ3kSVY3afQ== X-Received: by 2002:a1c:7315:: with SMTP id d21mr8770056wmb.108.1594825602210; Wed, 15 Jul 2020 08:06:42 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:41 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Date: Wed, 15 Jul 2020 16:06:24 +0100 Message-Id: <20200715150632.409077-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110643_265749_3E0B994E X-CRM114-Status: GOOD ( 12.36 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Kevin Hilman , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc: Kevin Hilman Cc: Neil Armstrong Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones --- drivers/spi/spi-meson-spicc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 77f7d0e0e46ad..ecba6b4a5d85d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) { - u32 data; - if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, SPICC_ENH_MAIN_CLK_AO, @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) spicc->base + SPICC_TESTREG); while (meson_spicc_rxready(spicc)) - data = readl_relaxed(spicc->base + SPICC_RXDATA); + readl_relaxed(spicc->base + SPICC_RXDATA); if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, From patchwork Wed Jul 15 15:06:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665719 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A7F1138C for ; Wed, 15 Jul 2020 15:10:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4627320658 for ; Wed, 15 Jul 2020 15:10:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EHkh3R8J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mm5H0gkt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4627320658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7lIS8DsHC08ZwZmDwW1d+zZ/12KYeeSqcEUcnjBrJGM=; b=EHkh3R8Jbh93AnqGU4BYgzjFL bpDo2z69TGV9AzBt8BGdmjTlFIuMyoQ6LOo3Z2VpXnHL4aXsTIAl4QfjPxqPRwcYcjA+2iPHVLaNv vgIxv5I/vmfGM67gsUGX8EuooiNWI7E0Zvct2LnZBJGFYNNcE1YWlKbwAMae0cA4oXmInTNMtBPtt pa8vZvx5WBvj4OoU8IxVEIizXVkCmkPFEehSuxAfVeCK6NcE9wME4zmq3iEdMx2q8r5ioYPxdF2ye ISVx/AZkpw1oygSvFEXN+mjRAoJmxhGk87d2maDak/nFZNmFljI12ChNvxHkmlwInp1fbuUEAqg4U GkMSPs6rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj0q-0006z7-N3; Wed, 15 Jul 2020 15:08:00 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizc-0006V5-Nr for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:48 +0000 Received: by mail-wm1-x342.google.com with SMTP id g75so5921363wme.5 for ; Wed, 15 Jul 2020 08:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=mm5H0gktuRl27KwOE3Op7rhTrBCOq3IjXtDklC9duhaS3OTT2AIBTmiUK7enabkTxf phcZ+mlV/fhB5510gdwnlVT3Nu8bq+sziuBIoKP6hjoayECw6hdssq4P9CHFYDMgDvIQ ErWfZyh4qn06Cfihd8RkCok4YpfxkvExmV1F49S4++6DMkMoaoPjSjicaXvmiKHPAhAs zamOm620KAFOcYr63wq8QipRJwm8ft++56w68XfTbJiF0Y/z8iqjB7oqiRiK4B4uUWpS X6Lp1A3i1p5aH4zsuxlrzFMGCAXnMp1cnAVb07VjMsCZTEORkYIDT50YyijZRN7wzI4Y PcOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=G8zE0yH2N/KMAe6b4hXwnHmDwRKASJmpEcp1WzH+euKgHNf48887xYQG7UBkfrRpWI 0KkQTXDEsnZbJE8VhA4hexki+1QJP8vtTbwp2Ql5B3uX4F1ifThnxBBAUaIDxfbEP322 Be2fEwoZXaSYYtFQ18hK/kBv4GH/Yvj7QDSzWy9Cmb/fV2QTIkBfXUaqSGxueBApB/dJ SG3s6cgzcYPmzvr7bzLkc5DrrA5Sf75lYAvNMr8rwwfAs9QCUViJvleOH5Bx3QrhPL0j PXsYLtS0MdvXce1i23kCjUSnIM2Hj3TTeRRv8XDTm8UnwVGbXOrWwe+vUf/jqm+vW19/ 0BRw== X-Gm-Message-State: AOAM533Xle7JTv1vTDbjjnlUI2H+508RaP07tHAYxWctpS3R4dAFAVjh y1KcOqAJC5jhGCOWMMginK88jA== X-Google-Smtp-Source: ABdhPJwPI7700rZiGUg8UA2/gAzTCD4H6EyDR617KU4GnsAL6bxdbGHlfr3Qjde6X1ytzLoqJxXbAg== X-Received: by 2002:a05:600c:21cb:: with SMTP id x11mr8697229wmj.141.1594825603705; Wed, 15 Jul 2020 08:06:43 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:42 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data' Date: Wed, 15 Jul 2020 16:06:25 +0100 Message-Id: <20200715150632.409077-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110644_868497_CDD316E8 X-CRM114-Status: GOOD ( 14.79 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Jaswinder Singh , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-spi@vger.kernel.org, Kukjin Kim , Andi Shyti , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'pdev' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'rx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'tx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_conf' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_id' not described in 's3c64xx_spi_driver_data' Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Andi Shyti Cc: Jaswinder Singh Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-s3c64xx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index cf67ea60dc0ed..924b24441789a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -130,9 +130,11 @@ struct s3c64xx_spi_dma_data { * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register. * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter. * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter. + * @quirks: Bitmask of known quirks * @high_speed: True, if the controller supports HIGH_SPEED_EN bit. * @clk_from_cmu: True, if the controller does not include a clock mux and * prescaler unit. + * @clk_ioclk: True if clock is present on this device * * The Samsung s3c64xx SPI controller are used on various Samsung SoC's but * differ in some aspects such as the size of the fifo and spi bus clock @@ -154,6 +156,7 @@ struct s3c64xx_spi_port_config { * @clk: Pointer to the spi clock. * @src_clk: Pointer to the clock used to generate SPI signals. * @ioclk: Pointer to the i/o clock between master and slave + * @pdev: Pointer to device's platform device data * @master: Pointer to the SPI Protocol master. * @cntrlr_info: Platform specific data for the controller this driver manages. * @lock: Controller specific lock. @@ -166,7 +169,11 @@ struct s3c64xx_spi_port_config { * @xfer_completion: To indicate completion of xfer task. * @cur_mode: Stores the active configuration of the controller. * @cur_bpw: Stores the active bits per word settings. - * @cur_speed: Stores the active xfer clock speed. + * @cur_speed: Current clock speed + * @rx_dma: Local receive DMA data (e.g. chan and direction) + * @tx_dma: Local transmit DMA data (e.g. chan and direction) + * @port_conf: Local SPI port configuartion data + * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { void __iomem *regs; From patchwork Wed Jul 15 15:06:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665723 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA80F138C for ; Wed, 15 Jul 2020 15:10:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 824D920658 for ; Wed, 15 Jul 2020 15:10:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hSLpwt8Z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rtO/R+gF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 824D920658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rGE/Cw6cw5X/vlG8eqBR8aY7eqb0UlKXqauNa0Y7zh0=; b=hSLpwt8Zu2uj8ffq8t3SAQXwF dHv8BsxvvKfhrnwFd76N5vNpwV+XqirJnZxv9aoSFkkjNr3pHscZnR6r33JWwnHePZpEbJ/n/i+IF VYZ+OA7oT8uZT4ncwx/YqN29Jka6ysyv85yhSxkF9LOZLqjfLV64L6NZkb9BwJraVrdX1j7W4vw06 LurSIQdklgRpghwqkdUhQZxWzyNq61wsm0NPfozQCc2L8UIhLrIyFs/+WGhHMNbZFegUIgQDwmvIa YQGJaPr+6Bsu7eJ0wTWF645kpNLcaxCCtI0tfVjJABNby3Y0s5X9FXOCvaUzxsbvxv7vDBzfqn1wa GZhIAF02w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj14-00073P-Ot; Wed, 15 Jul 2020 15:08:14 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvize-0006Vh-BY for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:49 +0000 Received: by mail-wr1-x443.google.com with SMTP id q5so3075977wru.6 for ; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bjh7OhojJcRmD5KkKwacJpyMf8L6Fg+f9kXKvvMc3JQ=; b=rtO/R+gF9zsxdsObRHLZjii928eu9P6U4fV47qT04PDZqfN1Aq+9wmYpIrjcPldh7T yP1DLy0eimKSKjz+BYeWPwFsrz3w33TZgBqvD+zngaL580tLU7cwgnteXFXEa2cVb63a C3hCJVfmWgf8lgOF6706sYiBVu2V51RlGIqpapFdC5++3X0ambcY9JvZQCYe85kYOmw7 bSpz8d0j/QI47062tJVsowpUDTU7eNVnWs3lPdNm2HUsKNOkvlscGCVf3IgWF57B7ma/ SicBianzkJtzdwiwzI2qiNr5ecy2Jif9S6uDJm1um/jUNYgDmdZ52yFNt5ixduLTT+cK f0qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bjh7OhojJcRmD5KkKwacJpyMf8L6Fg+f9kXKvvMc3JQ=; b=YjqsponH6AWeluljbWEgEeJ5p2M7ZtX3btWZLHQqeoSJzbZiQTHgsYQ1vFLT8QCgIj nWVYtJ0akge1cN/a3HyvkHW4J/SCo4mzNVU5BL6sfjyb1La2H3nt4R8/2jg3Xuos5iO+ HZJ/BoHv+4i1mQwZIDfW4vusNstTwNLOTiGsg/vu7rZwX9oaO1lqLIyMi4z1IzJ1WwBl XmLF+Ot+yQIKETP0xKIg+5L473VZM8r+V795KOl4FfbkXi1+VzCshampNilW06Gt9b19 PTzHWfy6GaCvzauD+f+6BTUMReXO4P6AzwBnujLOkR6GhRT0SHNG/9EDX/f4i/nvN9bJ Au/w== X-Gm-Message-State: AOAM532u9sOnjYypKpUpwL5M4fTvws/z5dqYmM/slo8uLYvPWBJ7jt4e C2YD5xpPGM5zjyI/Ni6sP42NPg== X-Google-Smtp-Source: ABdhPJz/qORqv4SB3JCQPZLx2YoBeuFRtlxnr/5oEScOZOZu+WtAdMW0hpudATx8mM94Ld2/ZEFr8w== X-Received: by 2002:adf:fa10:: with SMTP id m16mr7456479wrr.134.1594825605304; Wed, 15 Jul 2020 08:06:45 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:44 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Date: Wed, 15 Jul 2020 16:06:26 +0100 Message-Id: <20200715150632.409077-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110646_495684_593DCA2D X-CRM114-Status: GOOD ( 14.49 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sachin Verma , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Also demote non-worthy kerneldoc headers to standard comment blocks. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing ' drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' not described in 'vendor_data' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'rx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'tx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'dma_running' not described in 'pl022' drivers/spi/spi-pl022.c:670: warning: Function parameter or member 'pl022' not described in 'readwriter' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'irq' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'dev_id' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'pl022' not described in 'set_up_next_transfer' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'transfer' not described in 'set_up_next_transfer' Cc: Linus Walleij Cc: Sachin Verma Signed-off-by: Lee Jones Acked-by: Linus Walleij --- drivers/spi/spi-pl022.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 66028ebbc336d..d1776fea287e5 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -298,7 +298,7 @@ enum ssp_reading { READING_U32 }; -/** +/* * The type of writing going on on this chip */ enum ssp_writing { @@ -317,6 +317,7 @@ enum ssp_writing { * @extended_cr: 32 bit wide control register 0 with extra * features and extra features in CR1 as found in the ST variants * @pl023: supports a subset of the ST extensions called "PL023" + * @loopback: supports loopback mode * @internal_cs_ctrl: supports chip select control register */ struct vendor_data { @@ -353,11 +354,14 @@ struct vendor_data { * @read: the type of read currently going on * @write: the type of write currently going on * @exp_fifo_level: expected FIFO level + * @rx_lev_trig: receive FIFO watermark level which triggers IRQ + * @tx_lev_trig: transmit FIFO watermark level which triggers IRQ * @dma_rx_channel: optional channel for RX DMA * @dma_tx_channel: optional channel for TX DMA * @sgt_rx: scattertable for the RX transfer * @sgt_tx: scattertable for the TX transfer * @dummypage: a dummy page used for driving data on the bus with DMA + * @dma_running: indicates whether DMA is in operation * @cur_cs: current chip select (gpio) * @chipselects: list of chipselects (gpios) */ @@ -662,7 +666,7 @@ static void load_ssp_default_config(struct pl022 *pl022) writew(CLEAR_ALL_INTERRUPTS, SSP_ICR(pl022->virtbase)); } -/** +/* * This will write to TX and read from RX according to the parameters * set in pl022. */ @@ -1237,6 +1241,8 @@ static inline void pl022_dma_remove(struct pl022 *pl022) /** * pl022_interrupt_handler - Interrupt handler for SSP controller + * @irq: IRQ number + * @dev_id: Local device data * * This function handles interrupts generated for an interrupt based transfer. * If a receive overrun (ROR) interrupt is there then we disable SSP, flag the @@ -1334,7 +1340,7 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * This sets up the pointers to memory for the next message to * send out on the SPI bus. */ From patchwork Wed Jul 15 15:06:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665717 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C66313B1 for ; Wed, 15 Jul 2020 15:10:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD38A20658 for ; Wed, 15 Jul 2020 15:10:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="htgKyABK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UyEhMAjQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD38A20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=igBL3TFzHerrDgkKYlzoZs9RLe4gVkM/4ywK+7HVsdw=; b=htgKyABKnjmC9zpgpW+JSnejw hcGiPavFrlhiCNlJZDXhcTYP2X9Dux6rIuKcOmLFfHIrJmP0VTftP0NiN5X07t+cy8lYx2MFsiBy4 8JQfAAFfpV4SmENEbLe46MkX+PKiHAy9qlfpAaN8pyB8kOJw0reBzGIZI0o8dQJjDATCYKOvW4XPr 9d5zjyh3rtcZX9J19tqlvpinIV6nfi8yUEQBGbaKOx8xBkOAqW0hRxu4orWu6r1Lno/PnVa7D88q1 NaCv3P2MVuUhiBYv5dCN3TiG4ZIeXaQ/fcpbs35WbMOwtKJ2a8GwM/V0jJXLCv47Te4Z0c28A5AC8 AIvbbVcSw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj0w-00071W-I4; Wed, 15 Jul 2020 15:08:06 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizf-0006WB-J2 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:49 +0000 Received: by mail-wm1-x342.google.com with SMTP id l2so6191108wmf.0 for ; Wed, 15 Jul 2020 08:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=UyEhMAjQjWz7s63ZoKbqZd0he72PbgcQoERVqZzfPDdeHfi76qTF2aqAKxzkw+vs8v 1ccaVDSAO4pCzQ94UQJrxVt/sheMgiPUXVzxym6vO5O3kTo9gbcNiNZVaVD1plMF0J3k z3yGisz15rp6uRZwbOTBwSS7WRG2WW4RYhT3UooUQ1/ByKSkNAp8xkJVJkMzDKEaz/uV dY1tnRfjmei2kZiknTPr5tnLNurtxkTSnbU4QVjMd/PG1AQFoIo5f4IX91KQdnkdhecL G0V3E7kPOXw89FXa9PIId9kyqYzc/kbEl6QHQn+6MHKgA350J1Dw6gHOjtOneOkfuyyM 4CgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P2yOByTJ584zq87efhS3Vkyk+agE9qVyWq/sL4PYeIk=; b=dF8Xhtzjzl2WcE2oJW/pN/5HqWEBL3vx7azr9lv0tLjmM7devOFlF3S/KFPUkVgNv5 jPjQbwHgj0U2LPA2KOYpGNSLkVP7X65248Lp5EtNyWk4D71yFjm3JcHFeXsaK9VfIlk7 YliQp039swFYjJeOV5rVIa7lq0pyuDnScXYekoSAXtUO2lB4/JHpKa3AYmY9VwuHykQd bm9v+kVP0VbXfWPzh6qsJDSr8bTIXMG5UgDJ3Hw8O6hasyDffvnhpDOH6YPvTcWRAlZq QcHeG0wdC3nykGf863Rfhk9uT8gCzALhRWwx8DvRttGQyLh7f0oHDzCZRujhMpVZZr/t xXzQ== X-Gm-Message-State: AOAM533r7HNVezHj5gCSAnlGFmFruLSYmBzzB0EvuJUstol/WW4uT5D0 dw5XX3hGcpi3f1v1dholkjrY3Q== X-Google-Smtp-Source: ABdhPJx39xtrPHkcaKWFcDV25x4ysJFEnVveAGzGMS6sEEHSQ9JC+ALsZmBUt/eVdulx8vVh0d6eMQ== X-Received: by 2002:a1c:f609:: with SMTP id w9mr9114757wmc.150.1594825606599; Wed, 15 Jul 2020 08:06:46 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:45 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Wed, 15 Jul 2020 16:06:27 +0100 Message-Id: <20200715150632.409077-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110647_725061_342BBC63 X-CRM114-Status: GOOD ( 12.15 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , linux-kernel@vger.kernel.org, Sureshkumar Relli , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Michal Simek Cc: Sureshkumar Relli Signed-off-by: Lee Jones Acked-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency. From patchwork Wed Jul 15 15:06:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C17F13B1 for ; Wed, 15 Jul 2020 15:10:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5F5320658 for ; Wed, 15 Jul 2020 15:10:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="unPomTA+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KZ/TT1t8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5F5320658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N5OxSDH3zq/juAZrB2cniAc7rxgyhd4iB730PK8+viQ=; b=unPomTA+eEZK5bhE7GTesusq8 CADMnxskpChjmCQvoeB58daNIeKLEzJGSUDoFryYjLyCKEUPJ0Va2SZVONMsSa9xOhkvinBjEO5AU k+GlemJ1NMPJQQV8P9L7yctZIJCkaMyYcYTc1RwVxzdo7wQd0Shhd3QdVnuA0UmHWgnw6ZCwqjGs3 oCQPTww0ehpH58OVRhkm8rj7d2jzvBA0osovYRwBhVvyaTuj7K3iVDFVBGKRM8/0FOKHJtY2yoCp3 n07GFSFe2006L0CiXHdjas4azXr1V2og7qCmbO6YTMK2RA/WeCrl9sMTi+e+R6HQQxbcz2Z/Ze4x8 qfhitAQOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj1J-0007El-A4; Wed, 15 Jul 2020 15:08:29 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizh-0006Wy-Cq for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:50 +0000 Received: by mail-wr1-x442.google.com with SMTP id o11so3069375wrv.9 for ; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IfYptBKxQvrYFn67V4A+QmgFkUNV62He06/dIZhBEjs=; b=KZ/TT1t8CLQwqRlkcCPqM5ZK4eIUzF122chFSiLAFw9aUgHkXoJwedsjFUWNkqBK8w xoB4tfqJRd7SZyxqiKTR0kyAIdXPlACO3EGTzoXFXhuypYOk/pAabYnC9cCRagJh7ra6 ys8mn2pnkIg3p3UpxtX1bwTvZquhEm5FSmtxNhh0OL5NHOsLK1CSoHoAZKQZe3U63AC6 kWdU4mIEZiRg7ZLXpgfvBAeuZbFLsSu/s8OANq5iu9F/gUzRFCpo8TyvZzhRXipVMsh/ W/JWNHB7R1SpSzw5769jWnV7f2oaRtgeMcQNpgQUwUsncIOaqTP5xM4uwZc4qtUaYnV4 /oKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IfYptBKxQvrYFn67V4A+QmgFkUNV62He06/dIZhBEjs=; b=VciSklx4YqxGW88UD1TbouIE5+9skqNWtID+RWFFvITk+LPWAsAkEmZ8KdtSQNTzwH LQ0NqzvmMd84dNeEaO7tSU2Rny8FueMpq5qFfGEJNt435k1L6PE3JkhsI+5jRhIOlyRq F3PXaFTyPWwtzvceaVNYeMfrzBwSTSPDj7HIBooGIUVxuCn0hz0UF1Ce2ogx5cd3OY3/ 3EDNjfkf/cNC/ThsVyq8MMK2QA3/wVN0c9VswwHM4UNtuR4g87PvUWt48M1fnFkGRN50 X8m4SOCvdkbuus4/NPM3D4so2YfKQ6LhZ7gAzR6+OfLZjQq8r5rYAqxJBaevUvVQVGdv MkAQ== X-Gm-Message-State: AOAM531GpUQKP5vjVvySbBu4t6Ohkp15uaQrDnit5Ma//a7EaQM0B7xs O+BytIb9vrPsgs/7A4ICfzqQz5y50rg= X-Google-Smtp-Source: ABdhPJxrrdTj/aQFIMBJUj58shw/EWz9k6o034iUJPO0GSeP71Qz7tMabUEkuVxpSHB3KuZgJnnDiQ== X-Received: by 2002:a5d:4992:: with SMTP id r18mr11145302wrq.323.1594825608304; Wed, 15 Jul 2020 08:06:48 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:47 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Date: Wed, 15 Jul 2020 16:06:28 +0100 Message-Id: <20200715150632.409077-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110649_528108_B3AB52B6 X-CRM114-Status: GOOD ( 12.58 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend' Cc: Michal Simek Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynqmp-gqspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index 811c97a7c8589..e17a201252557 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset, /** * zynqmp_gqspi_selectslave: For selection of slave device * @instanceptr: Pointer to the zynqmp_qspi structure - * @flashcs: For chip select - * @flashbus: To check which bus is selected- upper or lower + * @slavecs: For chip select + * @slavebus: To check which bus is selected- upper or lower */ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, u8 slavecs, u8 slavebus) @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master, /** * zynqmp_qspi_suspend: Suspend method for the QSPI driver - * @_dev: Address of the platform_device structure + * @dev: Address of the platform_device structure * * This function stops the QSPI driver queue and disables the QSPI controller * From patchwork Wed Jul 15 15:06:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665725 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DDC7138C for ; Wed, 15 Jul 2020 15:10:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 705A320658 for ; Wed, 15 Jul 2020 15:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gTWO1Mdt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EzXgoWXV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 705A320658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9FfHxkMs+ZsC+4fqRbsz213O0o7WMv+4BV6ieknnas=; b=gTWO1MdtUzXoy83EJ6qAyUn88 Ss6Zz2uTXa0a8CpXSLGMxdKp/Dv7S0dxRxZZ2D/QtMEc/fsWLZSl+G0rLCGqMqgX9PJTwBwlSvdqj IloKhok2zySlS+b9k1YEPJwDEGAiKOOZ3sQTF5YKJISoYe8+ib/hTjI4VqFkLG7i73fsRx6pbc9fQ nFyjSffe/pjqNJkEkl9vciyq902a/EkLOl+9uZa3aqedB7KNIA3zAHxnP2KLMKA+gzcsMfj2GGEzk R9ceD3Of5xHnCtUpKWGFASyNSNwezWgmoueO6JX46RsfQbiO2SQHu2/PbpW9as/tFw/kLzLF98ee1 kiY9JZpdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj1Q-0007Ij-HN; Wed, 15 Jul 2020 15:08:36 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizi-0006XT-Ma for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:52 +0000 Received: by mail-wr1-x444.google.com with SMTP id a6so3096723wrm.4 for ; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=EzXgoWXVHcblT299CWnFjUwu/qW4z3MCPe2EO1ynFgOADXo0wZ1hvqbPWrfz+tOefw VGGaZd5/muef9MzYyk6NIpaostukgfsY74ELsVkuN6ZdvEB4Q+J3btO58zC484dxcoC7 jdl2m8vMVMOlhrc0xvsq55kzBXJ5aF9Ckq4TuG+MIDJ1ZJj6LFV9hfXvWgNz1PXIwh49 MUqAgaDi/6eYeqRV8KEZqdndWwgVFN1ZaurPwYdAdUUE+bXE3Muc8Q15gmfSdAC/ponK qbDU08/zyrkSq5o8cqOTCtjTrlhrRS3BvWbyXMb9T00Bv3omHZ4gOBBlEwEJwx5mkh5h kQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=Gw3BuQGiXm8+Mjs6g3EcfRfnFHC2gItJEvN4AhappaDpoAUKQtpg3nFk4ffqBx2Oqs C0v7Qq/i2KtDQpzW8Y9hcCKO+b1gofwn3Bsk+iWFrYrENxZ+BxCRk242/C9O96IfcRgT sylWvvG7vvFU95iESCIdV1nyb8hjdI850le4dmjLgoDB1x4jtpBt8IFf3RZjqCRxAqBU +DvVWN/2LNntXj9bxObb1wq1iz5IxDmQ2F51hmuqLjrHYsIXt/sp5ERyUTMTn8rnYc98 biFWKcNj/tFor2ISGEFjCDWQMVVQt5G9HgUL34vwLz/YH1jupLA72PYhfQ6MafkCL07o YCBQ== X-Gm-Message-State: AOAM532Hqfr4kARDMOtTL9Wylc4Lu1DM6dGlXgAY7zkvBU5HpNwr2oHZ yMTaz6lGs4VjWNylVttgMswVwQ== X-Google-Smtp-Source: ABdhPJxCpSAQqlbFgoqFALYbH3qfi5+G5rnYppQXXaOhBDyF/njkKYqkmrszZU89byQS4aLL9AvwtA== X-Received: by 2002:a5d:4a42:: with SMTP id v2mr11024451wrs.33.1594825609431; Wed, 15 Jul 2020 08:06:49 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:48 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Wed, 15 Jul 2020 16:06:29 +0100 Message-Id: <20200715150632.409077-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110650_851034_ADE6EC80 X-CRM114-Status: GOOD ( 13.29 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr; From patchwork Wed Jul 15 15:06:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665727 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 87757138C for ; Wed, 15 Jul 2020 15:10:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DCEB20658 for ; Wed, 15 Jul 2020 15:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OAfC5Pvl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RH7cBJ2W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DCEB20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XVvbTVAH3epHkv4CSbrMFmYjXvlaQrFi7cecXV1JtoY=; b=OAfC5PvlGCLzBsKbnYgFeFi4f r+mQISxODj6UJCBW+TLyuMxGlcwCQNJLzChDN82sXAwY82g7vT3trIQAeJEHsUZEIBgV7OwSQxczX CpBtgUJEjEt5bEFDiudZN/ihr1XJzsvhLnpLB7NCG4/WavlIDn58ZUTVJll0EbIGztu/Ia38/W4fa V+kNq1Reqr5wWU8Mn/g3IHGZIB3v9Ay1Zya1WW3mzTH7cwSHJ560IxXMsqQO1ahT/fMmmnM1lpEk7 xQH/7+C3N5B4vs7wEM/QGsoVc1G1xgM8flGcMAWjoKKbLmmAkR3ibw9gHCnCHbwpRINXfAw1XNNb+ edd9PKNJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj1l-0007R8-7U; Wed, 15 Jul 2020 15:08:58 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizj-0006Y0-N8 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:53 +0000 Received: by mail-wr1-x442.google.com with SMTP id q5so3076291wru.6 for ; Wed, 15 Jul 2020 08:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=42oj6jbSoGTF/ydaYibmpIO6VIJqDyq5aw5c0LpPRTc=; b=RH7cBJ2WlhKQHMXBNizOzo0T2ahy8XU3B6sEARR+uPl/o4nKI3IuEZJ8uLvbbZC5t4 l+AQ8s+3lqDbOapGH58ozWtwg6v2+RT2FZ/JrwPNhkDFeWKYhdds3OJIy2j/3nVpUHrf vghBDZGIJosR4XixZz0e228Ju4WbUGTyTYT3ukz5dmafd9HXsLrkhYug7ZwpZ93bHTAP 2QenT/NInodOgQnlQXZhCDNVS3NG0xHeAslNgHrC3Z4fXIrCBuLGhlx+eqnWpBg6zyd6 SI4SMBZdEt6nG3WgD8giZCqQmEn/lEzYF4u8dFu5sOWMyxqNUNeH2E/mOMwRTNvnggql BEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=42oj6jbSoGTF/ydaYibmpIO6VIJqDyq5aw5c0LpPRTc=; b=be7117/++MsfOkTKDh3bQUWkxDcReweF5ZddSVvWNiBX9QXVXA6PlFUxJQWRO0mvi1 5/dKpPDVp2AJtfxjNMHqqC7MSBdupRngx9nYyw1JYn+9muxe3pgfmcrnihQqwvhjGpHN gcncUlZ6BIlFwvfhU3mTqybZ2QSx0yTkeqkvmXxEf7luZmxg9rf6/jVWw9ZpQJkGRUP4 lCI/VoPBVPzAy/tpI+t2aUK29B/wvHxA5YOUVP+fmYMNiDua8GfdOPnqEttt92we94lp hwhtnC7oZtu1fwyN6ZmwXlIebtj9MfoeXCCJAwde7TsQT0zY717tUE103s71pdOjJnu5 fvpw== X-Gm-Message-State: AOAM531kZhMARn4PSWfD7Hl3DzmaccIourKen3O3sbYOypXHYNWfCHRj SVO8z0a+0BIk2jCX2VztRdOhFg== X-Google-Smtp-Source: ABdhPJxc3qUeyfFWGzOmf9reFa92XgdB27XAAzFJpjdbVd7jj+ddsAHBcS7KpBUlsilZ+jYr/eF36A== X-Received: by 2002:a5d:4a45:: with SMTP id v5mr11986837wrs.228.1594825610727; Wed, 15 Jul 2020 08:06:50 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:49 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id' Date: Wed, 15 Jul 2020 16:06:30 +0100 Message-Id: <20200715150632.409077-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110651_837221_344CCB32 X-CRM114-Status: GOOD ( 13.10 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Radu Pirea , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It's there so why not use it. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Radu Pirea Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Lee Jones --- drivers/spi/spi-at91-usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index 88033422a42ae..d47a20be43ccd 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -692,6 +692,7 @@ static struct platform_driver at91_usart_spi_driver = { .driver = { .name = "at91_usart_spi", .pm = &at91_usart_spi_pm_ops, + .of_match_table = at91_usart_spi_dt_ids, }, .probe = at91_usart_spi_probe, .remove = at91_usart_spi_remove, From patchwork Wed Jul 15 15:06:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665729 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C50D913B1 for ; Wed, 15 Jul 2020 15:10:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CFCF20658 for ; Wed, 15 Jul 2020 15:10:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aqP7bfGK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OeStQ676" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFCF20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rK9jXS8VMe5whwJShosUusivPUtIdeDEn/NwAl2che8=; b=aqP7bfGK4QmfU93VVfm8Q611u gZLJmKIObiSb7tQUjx5MOEKsMTQmSNyRt2qOsuZse8u1yLTm4pBPWh+ENl6SzIooUVX+KR537cUPx y+kq4vPRLjtbU8Wb2RXfeZIeBgZ8QCSwzrCSJYBUjw3eG9577+J2eTzXQtxQacjVQsRbrWHDMwVO2 QBW90mdcG0DPDotMIBcXMeYAOq5QHSoxf+lUQQWD7Ecxe21FbQs7jADw2StTWE/aAKVDyT8xdklSH LpT06yb9Gq17BXpdNFd+N8EzfsmRNqO3yuNjRwiaGjSLLZxkINfrhx0MXTuUbPrAqSqPr/nkR6V+p zxRkHdlcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj1u-0007Zt-DX; Wed, 15 Jul 2020 15:09:06 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizl-0006YW-2h for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:54 +0000 Received: by mail-wm1-x343.google.com with SMTP id o8so5915948wmh.4 for ; Wed, 15 Jul 2020 08:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=OeStQ676gkLJC9flvx8uGog1ZO5sbiMnJMlr05Al3vZvFQRZHCm9sU16b+mHbGjiu/ zQLROHGqy978gbiKFEpIyBMkOKofeVQ/0xUFfYH39mKo7Q/YCUXT4fDwvOGve9NdyaIX 9oBji0BeVTVDE0SHHoemYV6TVo+WjAKxrdNhNHqSd/H/p+j3DHSbgYtsByjsXwlwg6yh B90amTbQ+xuUjsIMEaeQTQ5v1qC2Q60Kfs8TTa513agQ2PQASIWFW+QdgHaZlhk4wKge XgSqUFE8pvon3wcWLfW14C76/b7c1rRSMvGnEnSCton+69Vj+u/y5VG7MA4JQqEPS5Xd Ycwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=Yv5cUvuF7ri/Pa6hYxo/u2rPuM051eC0SiLf/1+MJQfoy0SB1xcrqh+UgmdOaKxpzo +y5Qf8fySkehcHYFJM9YwEEY02bkF/WrNZoZYmW+yCUA56i6HTj97dZOtL9pegZsej3F at5KQJ9q6rZP/AhugVCgP21m694cje2N3Qc2ho2lJ+C6octVdp+JVe3tLNo7zFEilgkM aKGrnCI0Hfbm9/uQ6r9bqiCFnxAQJel/5xsM+l5XS9zdTEZ5AFpaVTvQH/k6YqyoosCE KBnuXSQHyEK0OwXsY2tLrSWsPl29DP2MZi6slKCmgX+8Ax8GzQaZTkKXm1JcbuEjM3Dd XX4A== X-Gm-Message-State: AOAM531A/dHVt2303GuJk6PmJdjrQwwQDsG5HqtNU1h6QpB6wyN4BeqR A/SIeHNoRiM2xH+h1sMc7fLcBw== X-Google-Smtp-Source: ABdhPJyBnfjeYbjMACkhjMYXKR10NpPlrtS5qROBcZV5AlpsItZlXQak8hpIg97VCabsero4VDwi7w== X-Received: by 2002:a1c:a557:: with SMTP id o84mr9230410wme.42.1594825612087; Wed, 15 Jul 2020 08:06:52 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:51 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when Date: Wed, 15 Jul 2020 16:06:31 +0100 Message-Id: <20200715150632.409077-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110653_255156_81E056C5 X-CRM114-Status: GOOD ( 13.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Robert Jarzmik , linux-kernel@vger.kernel.org, Haojian Zhuang , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 | static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- drivers/spi/spi-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 0040362b71622..814268405ab0b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1432,6 +1432,7 @@ static void cleanup(struct spi_device *spi) kfree(chip); } +#ifdef CONFIG_ACPI static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, @@ -1442,6 +1443,7 @@ static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { }, }; MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif /* * PCI IDs of compound devices that integrate both host controller and private From patchwork Wed Jul 15 15:06:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11665731 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D7EE5138C for ; Wed, 15 Jul 2020 15:11:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF22720658 for ; Wed, 15 Jul 2020 15:11:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1FyI/frO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BYmhvu/P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF22720658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jzQHqSW9OqwjS8TZHUY6/PUJhDQs4yREEhYqGrIXgBY=; b=1FyI/frOY5BkC0wEtUTmqaDK2 /mVgo3v04+h9klYNfosbYWJoPXtdkXAUQYLeNeudqXTyGQoxtmyBjeiQ84Ck7jyxz0I6RDSKsf900 LymEbIcacO30KV9tYY/Hj6Nbzv+jDrPGLgtaW8038Ibq1FG1r65mD9arlflKhJ67Z0o/iQXalpNSZ eTe4BMLE/foNwVrW3q1YAS677tcAxHCxqZUOfRye1njfkp57L/PqBw93+xMhDExyzNDgILHzkbajk 0rC3i3wlArqoPNXuwQ5CJI5wrHGoXuN+70bbG1IibmcICrgfm0L4gjySJTHkj2AWL/Kbdiyz/Pw+z 2Mdc5YM1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvj29-0007es-8z; Wed, 15 Jul 2020 15:09:22 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvizm-0006Z9-Ep for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 15:06:56 +0000 Received: by mail-wr1-x441.google.com with SMTP id z2so3120283wrp.2 for ; Wed, 15 Jul 2020 08:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=BYmhvu/PhXomekAXRVNla/c/6EiDYkDyIEEP+MnOTHWaO96GdMvSUBbWJS2c9+d7Jk VRcp05/uXtkltdnBCD3P4U/6uWXmTugA1wexZ81oTwI5iXU7B5eDg18v1fmgG2gpnKrY it07272+neTo2ZgSdaMpbMxWIRl/CJYkeFY2bH2Qc3ma0Q8+h02ZtLTMWgAnGuztvZYn ugk+ds7CLMSz5QoMkAHIgg+y7QLjfsXOlV07N2pPDjgbpagdKNJ8+SYYTPvMc5djiWwH 5awGcZaMqjxnB/PtmoiA5Wx4+EdazDc9VX+/311LH/1OaZcHs/cKfKmw2aCAutzqfQJB lAvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=fZTc6uqB4nNK+x+gL8EflEkav5Gv8UO0OTBfXkN7eFzzKNymeK8WTYqx/lFE9pPg3u jSNc93rkzG8B1tSjKR3BPJ9fbAQ4lIzI3R1C7dtPEfblBLxlbAZuPmf4gLVMJaJPtOot yl1S8jUe4BUdxUxZt6DpwCGm0MpO74UbIcQlTgkR6+fkN8lM04IJZqy4ANUKkcEKgwmh nzGpMOevSrYq1xmL127rR/GVO82mD3JCc9Dffyg+OCkSajIyzx+YCpsJfMfVB2lluqK6 XSHEHCHgO90b7Pg9EVH95kezFaTL4bmwVRpyWqbWils6CS3iuSAcya1xIY/VlgWQRsk+ 9rTA== X-Gm-Message-State: AOAM532JihK8BengJoFwfPDvsenSmoKIjWqwDtUR9NZ4OH3cGIYyJOcC C5ZJA0wl/m5iIOEe9m3Gxw9Xhg== X-Google-Smtp-Source: ABdhPJzKOkWoJ5Xd1No49tmC7h+p+Lj1YSarlHghqR0fzO+t7pGvO0lAkoOgf54GCL5hcHwEPQMssg== X-Received: by 2002:adf:f6cb:: with SMTP id y11mr11810561wrp.100.1594825613486; Wed, 15 Jul 2020 08:06:53 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id w2sm3906140wrs.77.2020.07.15.08.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:06:52 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH 14/14] spi: spi-amd: Do not define 'struct acpi_device_id' when Date: Wed, 15 Jul 2020 16:06:32 +0100 Message-Id: <20200715150632.409077-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200715150632.409077-1-lee.jones@linaro.org> References: <20200715150632.409077-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_110654_580041_E8DD2B3B X-CRM114-Status: GOOD ( 13.02 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sanjay R Mehta , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct acpi_device_id spi_acpi_match[] = { | ^~~~~~~~~~~~~~ Cc: Sanjay R Mehta Signed-off-by: Lee Jones --- drivers/spi/spi-amd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c index d0aacd4de1b9e..7f629544060db 100644 --- a/drivers/spi/spi-amd.c +++ b/drivers/spi/spi-amd.c @@ -294,11 +294,13 @@ static int amd_spi_probe(struct platform_device *pdev) return err; } +#ifdef CONFIG_ACPI static const struct acpi_device_id spi_acpi_match[] = { { "AMDI0061", 0 }, {}, }; MODULE_DEVICE_TABLE(acpi, spi_acpi_match); +#endif static struct platform_driver amd_spi_driver = { .driver = {