From patchwork Fri Jul 17 13:54:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09C0760D for ; Fri, 17 Jul 2020 13:56:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D58F320734 for ; Fri, 17 Jul 2020 13:56:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="exNrvKjf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LNz53P4v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D58F320734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LF/xDE5947mtveu/ix9LY4sZMEMK3gPHIbbOyzsIOdE=; b=exNrvKjfNxBmawzydRB92TDfs hc+hImCXZyJs6Aule3bJtInksIfKW3P90UWi/wbLgAjqpQmoTNd8n4YNQajEK7/L9AuDlWSVtn/kx uwgjJwGwHeu8wKOJxqb0hUoCy2Q03bz2rmN7P1u6Aoof7xwmbU1HYtwZfGoeU3Jy7jlBzzYHiSp4E 5JYEoClsngymTgZEozpyZoQ+q/gRosWMucBfTMhn8X1L6xIOmpmEif9oT1skYKkO7j5o2H6CrDDZL QPL3sRwYyBqFvjT9Reenap5fWw6OLnOGzmrIdtGCCrVaxCUQFx7BjBqTNFVi+4/Dy5rI/KicS6mUV EmSTQFPoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQow-0002tY-Ah; Fri, 17 Jul 2020 13:54:38 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoo-0002pP-A5 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:31 +0000 Received: by mail-wr1-x441.google.com with SMTP id o11so11214609wrv.9 for ; Fri, 17 Jul 2020 06:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=LNz53P4vPM8KOT6MgDZZt6XHv/VQQGMQknAGIrbSBeKWG/DqcokivbaP+KPiPKngn7 wyZfusiKq6wHj1H3NRXBVRRgwn92OZuXpoHoB4COPu/LYEEaBWueviYAs+8vaToPfiIX +5mKXjsrA8Qsw9IgpOUyw9iRWhM+Pqy3/ulzSZ+J/rN5QrKtA3MWoVTDBIrTzip58nzf 78MvBYGi9ddoCLEP8NDJ/ry3KnnDNBWD0fJPc1A6756DJjCdCAN9/A1eh/zaUnKZmG3t JvKl6C0QsjM25XYiStS/XegGKvdBvzcCc4VK+mXGcUrzHGlergl5K2K3pcv73mIL85xQ Grzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KGFwubHFzcLZa75OH2QfePfgNHp1yNFJ+5dMrYJqOBc=; b=j9L/qooySrYVKq7XrXj9EqT5T3gBJC6M0X8mEoIQunP+sdEO4SbMewiahlR5ZCYGBx kKrTUp28+eha/FIS1UJ1QbJpg5c9U683ZKuNM17E4cEDPGyCkdtk+CGggkDUfd/1pGO1 9oXT+z6Fn4gvqa08WUKjbHtJzA2+gk6ZxDHZv5DTpX5XepqNwY+5JO2CwP/G+fcMtJDz 9QiBuGUGvNMuJm8Klv7ejUAB9ly13DGjwphT2eqo7lPYi0+e+mYW8FXZrTaF4saoSrXi L3P844SCZRINStulHg2rEFTdW8Ga5VLBsIqnEvj8AYxAR9KWa7DqMo9gz0LcXBpbewRz vwqA== X-Gm-Message-State: AOAM532rQd0Gg+wbxU72iZVBTybe3mzmEjHep//V7IrrruB20f1Avxo/ ctn1He4NpNXxVpgguPBod8IF+w== X-Google-Smtp-Source: ABdhPJyRBdalYFJ2SqW1AzaxyMFU8anZRL1EGLZqqUNS1odMSvESXDDxeCbz5xSprj+I0pStJ0HyWQ== X-Received: by 2002:adf:ee4d:: with SMTP id w13mr10311012wro.245.1594994068030; Fri, 17 Jul 2020 06:54:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:27 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 01/14] spi: spi-loopback-test: Fix formatting issues in function header blocks Date: Fri, 17 Jul 2020 14:54:11 +0100 Message-Id: <20200717135424.2442271-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095430_394586_DEE3F56F X-CRM114-Status: GOOD ( 12.14 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Sperl , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Kerneldoc function parameter descriptions must be in '@.*: ' format. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'spi' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'test' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'tx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:897: warning: Function parameter or member 'rx' not described in 'spi_test_execute_msg' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'spi' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'test' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'tx' not described in 'spi_test_run_test' drivers/spi/spi-loopback-test.c:970: warning: Function parameter or member 'rx' not described in 'spi_test_run_test' Cc: Mark Brown Cc: Martin Sperl Cc: linux-spi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-loopback-test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c index b6d79cd156fb5..9522d1b5786d5 100644 --- a/drivers/spi/spi-loopback-test.c +++ b/drivers/spi/spi-loopback-test.c @@ -885,10 +885,10 @@ static int spi_test_run_iter(struct spi_device *spi, /** * spi_test_execute_msg - default implementation to run a test * - * spi: @spi_device on which to run the @spi_message - * test: the test to execute, which already contains @msg - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: @spi_device on which to run the @spi_message + * @test: the test to execute, which already contains @msg + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: error code of spi_sync as well as basic error checking */ @@ -957,10 +957,10 @@ EXPORT_SYMBOL_GPL(spi_test_execute_msg); * including all the relevant iterations on: * length and buffer alignment * - * spi: the spi_device to send the messages to - * test: the test which we need to execute - * tx: the tx buffer allocated for the test sequence - * rx: the rx buffer allocated for the test sequence + * @spi: the spi_device to send the messages to + * @test: the test which we need to execute + * @tx: the tx buffer allocated for the test sequence + * @rx: the rx buffer allocated for the test sequence * * Returns: status code of spi_sync or other failures */ From patchwork Fri Jul 17 13:54:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670401 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06C4813B1 for ; Fri, 17 Jul 2020 13:56:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D22DB20734 for ; Fri, 17 Jul 2020 13:56:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pbYjr0nu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sxuSTfoC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D22DB20734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=95s9GyOf7k3iioROZrQEk0BLADfHyFdhYvxWADSnOyE=; b=pbYjr0nuO8N2lbEDERa6gwMhF GXRau6xxM3K6PLxP3dsokrHRsuTUoV1PaGvN+tx6jagLAfWi6ujWD0nFN9wxuEhL9Ktpr8AqlgYsx N64lhFSEFIhp2aiYXWu0oNLjUeZLx++LVlUMdUwOIRuHJHxDUjkwTtWICVpCheKu85j/vSA+P68Ey Rma1YZzbva8krqXU+JHiUyHstUb+OMhWIRm4Xfdn5vs/J1zVHzubhNj4/mn1uA9Zm9/NDn/uA7c5N btgmIYiDkF7iLpclnk/QpLJwKJGu1a5y5WNtETxF70EKCZ+jHfJlMQmLAM6gIsWB/oBAa7rD0fc3V UDIk+rgKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQot-0002sb-Mb; Fri, 17 Jul 2020 13:54:35 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoo-0002pT-5K for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:31 +0000 Received: by mail-wr1-x442.google.com with SMTP id o11so11214661wrv.9 for ; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=sxuSTfoC2hrZKKISGmaJt1ryNoM+Mb53vx2VqywQ2dm6pt4TZ3WpIxoolFr/96l5HI zgp/5o581dmdBiSgQH3SacRs4hO0s2WCDSNAoa/pJXkzvrtSt48cyV/mcy5I48v5N6uj xmXqic/H5aJT4crWkPnWZ3OyiIOkd6vfhc8jU3EPrcggEqC2+I1bjp0fuQRPhgEGivWK ha15AuG72HyS/oCVqOEXoBdq9Osq05Ti56BmkcMaSYnI4b8Yl6qBjBfxGW/MIAqK9BRQ 48m14QnuLysn9zQoC8jLbQP5u+0EN6xO+0yHGeuvFjNT3LPCFTTjHa67pDCtydIvFQ9Q GIiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+k3VcTxp8QDyMoYM0yDw+EEU9DorBAQ7cdSI3O9/bb8=; b=BMSGEt5Ne+dqyRo6aDvbHpqx0VHzx0CfgZ+UClm4HS+kRIyVXjnWj/UdKA2sC4hdxi TM15l3qFGr2dTZR2F/nKQNnT0UTVtPjc3T4zciXfUDtKa2nGInqXT/elRbo8b2PYD8YL aAHXngZyDgRlCRx7zLhc4Mkpo5NPB9bFfDUunOf+GZYOZwHEVGjzmQ0GbqnjTkFeOnVJ azzPbdAv91nYk7Otdh3HRlr5JW7Pv+FOSVsuyS34oGYpq8xDwntXmfGCRok/lwUfP+MP ZbJz/EhNcdiJCjbmlQrRjp38gxdJWiTwRsje+yr1ZsUTMZ9pHwvMkfGLXhPlogw7fhIN boNw== X-Gm-Message-State: AOAM5337e6FfuJyORu40FgDsI2C5LKx3PSIBaA/JLsPiAoOnJCakJwne +h4qDNGUpV2yMBxkQpsvhy05Xg== X-Google-Smtp-Source: ABdhPJxWtRjEu5h/VTCvkKtCbMutdB3KhIeOKshDePoFQqyehuXzpt7xnH4k4MXi+QlSEZd2V53Rcw== X-Received: by 2002:a5d:5450:: with SMTP id w16mr3244734wrv.155.1594994069010; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:28 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 02/14] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 17 Jul 2020 14:54:12 +0100 Message-Id: <20200717135424.2442271-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095430_226704_3DAEB62D X-CRM114-Status: UNSURE ( 9.63 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-bitbang.c:181: warning: Function parameter or member 'spi' not described in 'spi_bitbang_setup' drivers/spi/spi-bitbang.c:215: warning: Function parameter or member 'spi' not described in 'spi_bitbang_cleanup' drivers/spi/spi-bitbang.c:434: warning: Function parameter or member 'bitbang' not described in 'spi_bitbang_stop' Signed-off-by: Lee Jones --- drivers/spi/spi-bitbang.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c index 68491a8bf7b5b..1a7352abd8786 100644 --- a/drivers/spi/spi-bitbang.c +++ b/drivers/spi/spi-bitbang.c @@ -174,7 +174,7 @@ int spi_bitbang_setup_transfer(struct spi_device *spi, struct spi_transfer *t) } EXPORT_SYMBOL_GPL(spi_bitbang_setup_transfer); -/** +/* * spi_bitbang_setup - default setup for per-word I/O loops */ int spi_bitbang_setup(struct spi_device *spi) @@ -208,7 +208,7 @@ int spi_bitbang_setup(struct spi_device *spi) } EXPORT_SYMBOL_GPL(spi_bitbang_setup); -/** +/* * spi_bitbang_cleanup - default cleanup for per-word I/O loops */ void spi_bitbang_cleanup(struct spi_device *spi) @@ -427,7 +427,7 @@ int spi_bitbang_start(struct spi_bitbang *bitbang) } EXPORT_SYMBOL_GPL(spi_bitbang_start); -/** +/* * spi_bitbang_stop - stops the task providing spi communication */ void spi_bitbang_stop(struct spi_bitbang *bitbang) From patchwork Fri Jul 17 13:54:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670407 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FAF313B1 for ; Fri, 17 Jul 2020 13:56:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ADA720734 for ; Fri, 17 Jul 2020 13:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KO78vfxy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KkJ58wTN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4ADA720734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7RxlMuun9DUKSLYkPsN7hqw3mCGiSLNV/fKakrWvYWA=; b=KO78vfxyW2KUuBZMCVtpFtNL7 SNWgKuaoHNUNPTWJ2cTH4kH82FkDsPOf8A5qaV/vjqOk4m3KNiFkR4/lQWJg3IQjuxGn51Pb0k2/O 4wk7pWdPXDA5ZvrCiKk04DE38YmkbPlzBKwnMAc2PV7/kqcj6nCweMYTbiIZlvo9VvnfvI/HfwVkE kDLk98pI95i8ivenz0pVzZM6oKU0oULmAu2AQY0AeEaZ1DhVsXBTwaY5z4UnyhdrHysnfUf2Iv/Mn 89r9NsSCYUj9FrgCuif3w+4A/UwC/rCBYCSmf0FHDFazFbwq/eMcRh3iq/El/1skGzeJQInlKdpv+ eUWt+/AZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQp3-0002we-7e; Fri, 17 Jul 2020 13:54:45 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQop-0002ps-23 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:32 +0000 Received: by mail-wr1-x443.google.com with SMTP id f7so11235547wrw.1 for ; Fri, 17 Jul 2020 06:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=KkJ58wTNLjFEfso6eafu7XHSWYDgIT2QpWO7ZoFkscH8T9bz8ZmXHL/FjjlmZ89szi SaFxtVC+zwUMaS9y7ToZr9FGXrgGE9lajWTHriEwPcmteH93rS1qRDvL4YRUgyiwqVjY j2XI/cb69GWiMEVGLVZJpYOnN7mJxmtOVxzdc5xq7P1QqsKa5UyRwAwgxwGNN4SMhZ9c TqcG0zsLXsFS6Z54kAMk4BtYeysJM7Og48NOlrTAwXyP4f1nYDQ2Co2a33Si6aDn5C8r t84r0SBiYXp9Hn5nQINc7//3xnye6zTLmDHLpUWGwXf2nG1a/uQpGh81nFfjKIfX3oCe TMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vKemoWjqR6g96Xgsgirmftjm/E0sdVIsOFgpktr/D0I=; b=L6pbVjQy3xJ5arrYjG5NK1MHzbxesOfJZ5OvW/sCovncmAyTYv0yQg8keo/G1Ba3FE NOYEOIKBOACfFgpzAU2HdN/U0Z5FDU0SwvQePA2PNFDJLbNRh24JyY2bBytxr4SMG0zC vYAlB8uzHDXWNhaGqaWy8KyXdE7bU3oiAWONYOXSjvl+67rGuJeBs+Bprso7Lbhza2rx F7SBdqDbpBYqH6rfMnYtWRfw1qWXNEaF1yFuj1euGsPzHLx+MxUrfaJ0ud8DEb7nTqFA S2OEwS8ywGyal3uRbZFjxdlnJ9ZhsEaxdODLNVraG4RgrFuORtTgfwOB321PMW0q0j4p zqJA== X-Gm-Message-State: AOAM53235Ym76BrdKiT5yfzkY5lV7MVLBT3Zf9SLlHpncT7xfrYKzFsF b8RkDMfW48Te29bMc9y+7lq6sw== X-Google-Smtp-Source: ABdhPJyScPf7JwQtEZvA5sD1ShLQoa/+KNAe8xTjYnMg0F86HrLTvwwPzQtxX+Mk4a1wGK3SMbuJaQ== X-Received: by 2002:adf:e44c:: with SMTP id t12mr11315545wrm.103.1594994069964; Fri, 17 Jul 2020 06:54:29 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:29 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 03/14] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages Date: Fri, 17 Jul 2020 14:54:13 +0100 Message-Id: <20200717135424.2442271-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095431_660603_C82F7F3D X-CRM114-Status: GOOD ( 11.72 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'dspi' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Function parameter or member 'max_speed_hz' not described in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:249: warning: Excess function parameter 'maxspeed_hz' description in 'davinci_spi_get_prescale' drivers/spi/spi-davinci.c:719: warning: Function parameter or member 'data' not described in 'dummy_thread_fn' drivers/spi/spi-davinci.c:719: warning: Excess function parameter 'context_data' description in 'dummy_thread_fn' drivers/spi/spi-davinci.c:735: warning: Function parameter or member 'data' not described in 'davinci_spi_irq' drivers/spi/spi-davinci.c:735: warning: Excess function parameter 'context_data' description in 'davinci_spi_irq' Signed-off-by: Lee Jones --- drivers/spi/spi-davinci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index f50c0c79cbdfa..818f2b22875d2 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -236,7 +236,8 @@ static void davinci_spi_chipselect(struct spi_device *spi, int value) /** * davinci_spi_get_prescale - Calculates the correct prescale value - * @maxspeed_hz: the maximum rate the SPI clock can run at + * @dspi: the controller data + * @max_speed_hz: the maximum rate the SPI clock can run at * * This function calculates the prescale value that generates a clock rate * less than or equal to the specified maximum. @@ -710,7 +711,7 @@ static int davinci_spi_bufs(struct spi_device *spi, struct spi_transfer *t) /** * dummy_thread_fn - dummy thread function * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * This is to satisfy the request_threaded_irq() API so that the irq * handler is called in interrupt context. @@ -723,7 +724,7 @@ static irqreturn_t dummy_thread_fn(s32 irq, void *data) /** * davinci_spi_irq - Interrupt handler for SPI Master Controller * @irq: IRQ number for this SPI Master - * @context_data: structure for SPI Master controller davinci_spi + * @data: structure for SPI Master controller davinci_spi * * ISR will determine that interrupt arrives either for READ or WRITE command. * According to command it will do the appropriate action. It will check From patchwork Fri Jul 17 13:54:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 24A1660D for ; Fri, 17 Jul 2020 13:56:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F061C20717 for ; Fri, 17 Jul 2020 13:56:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YycmV5s5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lnb0CtVb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F061C20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XD8LLudLHueNxs/FrXCVOrYvXOU66rl3QbxjkzukUDk=; b=YycmV5s5BAlt6sJ7SNQWIgypv r4Lnc/SzIkGK1RcLZuIO7qYOm42wDz2xTAokRUqTGBbWSKI3pFbV1D6WvGnR2opZKwhtYd6yEHZu7 4bIQjqlBIiD4CDkx49aHRd7Ka40ty28hTlrAHem1Qx4l2avYIOM2CAyRFJHRZ5BY3j0urqvPLXW9e aP/P0+fudg3dkm20vYf5YGWdvIQ+29DtuO0y58JrQzuQYvTklWOhu6SmZzje/xPFilX3GgJx7m1Vy 7Y8A0A/irNrvyi/EY51y7h+iYVBbJCUfDlywSRwcql3H+X9QA3JEBKDBRuvbDyp6U1OVI8H5flw/A D7VoOZ01Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQp7-0002xa-Qy; Fri, 17 Jul 2020 13:54:49 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQop-0002qE-O8 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:32 +0000 Received: by mail-wr1-x441.google.com with SMTP id j4so11179948wrp.10 for ; Fri, 17 Jul 2020 06:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=Lnb0CtVbWRFsYcq4I5p0F1kPtzqlpb6+B4HmHr3H+ScjOsj6hVQKmo+YIsjT/9/1Wb Yy2UgzVEDRWavrWMKex3LUCcFe52iG62z/WvSEZ3zI6juSVZPj/pEqEXhfaMh3gIozlj t7HNZjapNynHgojy1h7+YTFwv7Qum3LB6AZh/SMfJecVuhCDb/bMSGw8ZfBrXf59OnzV lZiGC+oV1HLtzifxh7cQfiIOF4+ng7vsehMXUj6Q9InmFvkFup9vjes56JwEP1rkc5bM WAUuYaXko7tWKb7ZE114QTBu1M2OSz72GYWTnkhCU/cozXoZHojS11ZFxsEZ3fmtGekd nM6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0v3MpsT0EiR8b5Jx0N89c4SZ6k9ifhqdf8ekF4nSQ4=; b=NYLtyreNBTp6DOfwvPYRAsBVPJbyqAWVcCt9nEEN90uMfoYfi12H2/fdLCk9mDDBrn joX0b7QfZ87Q1ZtF8jclxJrrmVftd34lF9IAJ0fxDlhekOeEDBRc+4RVht1W5MOu3yIB nq8gFIynOY59lMLYLmHjPrTocyTCNudJy/MRn9bu15jicn/xL2HiBwQyI7nkRN/nQI4B eN8MdsPeZXHIXCHTjToZG2Ai0sOxAIjZIvpz2La9YZHPTSyMPdxeleLjXxr7ItXABrB2 Ha9AmJ/qcXeC/84rtlUlehSgaJNSWsunB8cUSyhjSq6DIHuRtd3+1r1LHfR75QlVdjuZ LFlQ== X-Gm-Message-State: AOAM532j2MGvPd7KX2+L15hCLDVPfig+VIDSqdJ/yj7e43QVh15ZY2dz VnjlyeB+9vBSnEVMPEpBB36oYA== X-Google-Smtp-Source: ABdhPJyWncy34Npy4rilSJUIpPISij8gKpvR0Ke699A8H9i1pMrCUYIxVOaCspw8BGlBJb6OzBknuw== X-Received: by 2002:a5d:4f8b:: with SMTP id d11mr9770503wru.147.1594994070888; Fri, 17 Jul 2020 06:54:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:30 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 04/14] spi: spi-ep93xx: Fix API slippage Date: Fri, 17 Jul 2020 14:54:14 +0100 Message-Id: <20200717135424.2442271-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095431_827129_DC9EC4D1 X-CRM114-Status: GOOD ( 11.46 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mika Westerberg , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org ep93xx_spi_read_write() changed is parameters, but the function documentation was left unchanged. Let's realign. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-ep93xx.c:227: warning: Function parameter or member 'master' not described in 'ep93xx_spi_read_write' drivers/spi/spi-ep93xx.c:227: warning: Excess function parameter 'espi' description in 'ep93xx_spi_read_write' Cc: Mika Westerberg Signed-off-by: Lee Jones --- drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index ae7c79a062084..aa676559d2738 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -214,7 +214,7 @@ static void ep93xx_do_read(struct spi_master *master) /** * ep93xx_spi_read_write() - perform next RX/TX transfer - * @espi: ep93xx SPI controller struct + * @master: SPI master * * This function transfers next bytes (or half-words) to/from RX/TX FIFOs. If * called several times, the whole transfer will be completed. Returns From patchwork Fri Jul 17 13:54:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670405 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FB4D13B4 for ; Fri, 17 Jul 2020 13:56:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B4F520759 for ; Fri, 17 Jul 2020 13:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ujMeN1fA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZAC5kkae" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B4F520759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pED7XFveHCYBLoS4nA6D9NqQcOYRTVjxom453MKgCP4=; b=ujMeN1fAghOsqlFLN0qiMev8T agh0zwVoMdxSJgpR5bnWnPZFuTjuZ2iykhlyV03Xz4Yv/x9kxoSuflfu9+UlSaSttEZnP0nU2/V9V R4oaS85Nh+FODI42RaSEdkCRMUGoTbOsnGBh2L7plwInmPXvylq8KdPfxKW1n0+QavW8LcX+Zt5J2 dxU5jifw8CH7FlQMEyTVNq0RLNg1obTSQtO91mryQKIgQHYROfPshSEIXx7zaP0YXKAbPLkKW7z49 RMbmY/Hs1tZSnhrkZ8ttcui5dLC2WLUohYfkchGmJgefn0v6jnbtnjWyEg4C+Cc1eu30b1k2WVtgu zfv4mVnoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQpD-00030N-O5; Fri, 17 Jul 2020 13:54:55 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoq-0002qy-Om for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:33 +0000 Received: by mail-wr1-x442.google.com with SMTP id q5so11219038wru.6 for ; Fri, 17 Jul 2020 06:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=ZAC5kkaeD48hDzasHcMFBgI5ok3om/Ag5jSHoowWVEUw02KGIjIWhow3DY2EWpzj1k xGIQfKuwkO6ETxRSTvlinnPUEMJh5/qXsllh3rX9yQQ5qtv6gB5OoR9meWBkVvG+GZFV aJWhSVmI/c5AX1aCSjblRbbyZkqfNY8nX0kmHTI4kACCAYFjKYyHj9YMFXsOA0U2gl7k JPPPn5HFtj+Aq3tDCoBEZqm00dLcmf8Me76bz9eW43D6ng60idi56pggV1F3MsRrKQe0 aYxadZEomTMoFaJKKr+DcDh6tNOFHztWuOeSlU+oyVZKjITYbEoH53/73ocvYz5aFLxK WtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R5bZU73kxT5M1JMsvuGC6Lo9dJE8hXmdkV8EdjzvhWs=; b=tX/kBv3SrXI3xM7QAcP8ByRsai5cIpkYayhXFE+I5KWwsYy8PgyUOYGsYmXXYEFHlo nCiKIMgiootxfMmYK/2gy5KDbwwNP2MXhf/Et8cDCHgjLasCPCS5gLLYKvDM5rslp44k jq6zn3cKjW7RQBGB08oMVsRECNvL5V6gpqpoZ7Ltp3SLsVVyuZ0cewmxHJLlxCcboU+p fOn78h6P747N+OU9vlY+8ai71FhRmPoYm4wI5MqrhRxBCJRUGkiaRcaUzIImn0Jh/jpD 9FiWllN8TxwOmIQvil35WyyjeXyL/x5LqhA71c3SB2YYK00q2qic+BhOGmNnHcM36ipJ 7dyA== X-Gm-Message-State: AOAM5333gYrlx4T4UL6cCPmjIa5gfT9TRjz+4o4VLFs3r6v52ZzJm9dx mUKxKCDf5cpjh0C3EslKeUphNg== X-Google-Smtp-Source: ABdhPJxG9WExdH+no7RsXepaf01G8y07Rip1YGVf8Z/0A+HGPnfCWJrwdTxKjFDyUGuQE69jroFN6Q== X-Received: by 2002:a5d:4607:: with SMTP id t7mr11203477wrq.251.1594994071957; Fri, 17 Jul 2020 06:54:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:31 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Date: Fri, 17 Jul 2020 14:54:15 +0100 Message-Id: <20200717135424.2442271-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095432_877165_0567F92C X-CRM114-Status: GOOD ( 12.26 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Beniamino Galvani , linux-amlogic@lists.infradead.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman Cc: Beniamino Galvani Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones Acked-by: Neil Armstrong --- drivers/spi/spi-meson-spifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index c7b0399802913..8eca6f24cb799 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -70,7 +70,7 @@ * @master: the SPI master * @regmap: regmap for device registers * @clk: input clock of the built-in baud rate generator - * @device: the device structure + * @dev: the device structure */ struct meson_spifc { struct spi_master *master; From patchwork Fri Jul 17 13:54:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670425 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D732E13B4 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1B0620734 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R7JXe0SG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JqcHwGwY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B0620734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N88oh4Ui9KCYw774r+jCwX+Tj5IDQUK9bFhcrtsqTrU=; b=R7JXe0SGN/N/+/FvNt8yPQ7cz n6jzSNsYrl9t9zjWSaqf0bEhgk3Gd51F6FiWfRJL+90XQZsaxvSQ+BdEa0Ej0ykPLYP1576hJriyV icUuZeqVDyNDbttCHEjjJoPPIje4gW/0Yh/kCjL15ohq5WnQ3JSiAhYkv81SOxCJwj/W4tbarCCuS Y9iKu8uzI8bqD/oJkDRjU5uwp7R/bJjNjWDsCfDwd5au6HtZJWBzmGPghyJ1F9WOeZFqZS3czvDpe BhC4iN1+k0WO0mUx1mpz5kx6UwUyWceMtG+LSdvrDQXCvGn47+HS2XKugb+0xT+W8psj60Sw4gHaV bh04Xp62w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqF-0003QU-1U; Fri, 17 Jul 2020 13:55:59 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQos-0002rq-7D for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:35 +0000 Received: by mail-wr1-x444.google.com with SMTP id a6so11236777wrm.4 for ; Fri, 17 Jul 2020 06:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=JqcHwGwYT8ZTvOUrpYD9UCG8OknPKe8KLct5xkbhm9XKF4P4uYR3ON03DVJiunjCn9 QalPNLZvjQnz3T1ZZ9giCZ7GjjqGSi2w13uo8hMx3L+J4wM+SCKHoJ7knI9Kd9M/nlGt o2wI1kB21f9JI/xRneRKdJMNoMlJAyRmqfVA58DfnQrFib3EINkomufdHtBctOOj2LIW QTMr9rlzAWo6+J4efQMbIqi8bDow/ngNWRzB8LMci5NiRtYIKlNTofQTrypuLrgTkW7c HVDsTyXjFUajMUuSHCJRL7I3fU2YEwA78dG7meEnNEPs3ruKpDUG/HVmR6gs+ydyy2Hu f9mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Neuk7hlxyMHOEJZl+c3Ce+fuWuJ+zLYxzzvecm8U2ZQ=; b=geZ0Dv2Wzz/hFUOTp2vBxIeS29ruFEwf6v/ASvr1Yq5cgzi6RgriiyJMnHeFUZvlGo rFY+tgNyms+gkBoXSkjWLXshUwDzEj8ChvvnW0L9AAmLIzZvNKpuL6yvXz0xMlKGeCxu COWJzNp4YWUjXPPs/yUxm34YRG4g/KsxVMQVUak2Wuy7NnN/IySD40G5g1T+XkusEh3m o+Ntw98oUviovoqmKE3aP9U0xrqCjtbYplfDepPLKFL0jeZrlyJPFyRM4rHe7bE/Jcoe +NOY84PFpkWK/ztPbqErmIvgNOfOPWUvmUAo/ynBsHIgZ0qhsGFoaT3jM4qhdw6bdPx2 Ii4w== X-Gm-Message-State: AOAM532KcL/X/P45naLcLhk2eSZKiXWdWlOUp6XPDSOmnCmSI1bYlADE WMplfHKL9Qv7ViDnj/MCIgM/rA== X-Google-Smtp-Source: ABdhPJz3szDLxEUogVXdh3Zg2yz5Kc9c/NDxZApAW0Y6M9e5ChL8WhgjNGUtkoELCEPuIq+gwAJAiA== X-Received: by 2002:adf:ebd0:: with SMTP id v16mr10685903wrn.241.1594994073095; Fri, 17 Jul 2020 06:54:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:32 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Date: Fri, 17 Jul 2020 14:54:16 +0100 Message-Id: <20200717135424.2442271-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095434_352017_7A9B2BA4 X-CRM114-Status: GOOD ( 11.78 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Kevin Hilman , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc: Kevin Hilman Cc: Neil Armstrong Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones Acked-by: Neil Armstrong --- drivers/spi/spi-meson-spicc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 77f7d0e0e46ad..ecba6b4a5d85d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) { - u32 data; - if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, SPICC_ENH_MAIN_CLK_AO, @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) spicc->base + SPICC_TESTREG); while (meson_spicc_rxready(spicc)) - data = readl_relaxed(spicc->base + SPICC_RXDATA); + readl_relaxed(spicc->base + SPICC_RXDATA); if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, From patchwork Fri Jul 17 13:54:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670415 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81D1860D for ; Fri, 17 Jul 2020 13:57:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EF9120717 for ; Fri, 17 Jul 2020 13:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FH0KA6XC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LTF03lW7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EF9120717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7lIS8DsHC08ZwZmDwW1d+zZ/12KYeeSqcEUcnjBrJGM=; b=FH0KA6XCcrKi9zyYiaqNAkyo8 2zuOwt4rECTOaF+A/caXoJJlJcM3jWta5OFKMqpX8bNVGsoycxpish9krlTcDYj0Qba420UsVLCaH UrEdpWJUwhjZ4Dy3OH5Jbg/fbLNJ3BCMPaUHsAtPxl/TYFt7RgD9wqURqCgXSvt3BYjunaFXkJsa3 kFOaa5L6WAVlQkrSqWvylwyAUNxFbrLrNHGw7hWOGQK/LH5rM+tpvTnbJOV8k9iezUkoQE+i9Sq9w mmQq5vTdIhpW+e8scsVxH3kKjrka337W5CD7qCst96AHaqHYXwsamrr5jzT85ZxujsK5PofYBljPO 6hdjK8JOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQpQ-00035r-OS; Fri, 17 Jul 2020 13:55:08 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQos-0002sV-VP for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:36 +0000 Received: by mail-wr1-x443.google.com with SMTP id z2so11258285wrp.2 for ; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=LTF03lW7kEJAH5aMocIcsUzVWKAAABsB7rRAQmExZ4VoAYuhMbb4bcfHA0awvwbIDn fSkxCfo/z71K8EDTbTRd1sVt8VejJPdF8NuHRjTZxmZonr2ag+LnYAaMzozlvyj/Cb5E PWgYZBTaStJPspQcjcGfuT8bJBxeDTvRJ0sGTQqibirjPdbO9pmPQ7kUKwHMotEFdyKo MCB7tcYRiYbE8rd+eUj1eVl/BPcWVE6wBcLZhlVqdWLaOOma3YFofkP6BA3dPq9kNNRI 8PItgM9yXEDb1k7nXRz+os22F5zYnJ0UhBHCQb8OoWOH804RCJZrIwdQb5vBvWHvE7ZZ xA7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HtRzZ5KmeCiCWZA3g8vq3ZlMKJB7i9QBYHFK4C8GH0s=; b=ObkjYLsOMOmjDj+PkSMrpVqTzI/fuLoA4VACWxI1havUNP5tkxyYbftwLztXgMz0FS wFlt4yS7Jblei19gGZs7dRYeGqNkZfsZQ0rJyreGTTDvrWMt2BPQAA2vtUSWkxE+jbBL WJsyc5/fXXJ2DbjJMI0HhnM5WBXZGo+rO35SQR/OYv7PytMxIZGFMtUyykFw3puJL9Lb qclwPhW+VL8Y4RQCJzASBfB0CFTkp7C5isfb/OjJzMC9sF7/lmVlneR6Gyd2UyRAf3HE BEov/9efCjVlhGDFOCh0RF5Vg2ADzaBc26mTfTttbDbHgTkq3zHZ45lmglCPOwO1yA0r sMQA== X-Gm-Message-State: AOAM533CCkXyzjwjkt2y9oQLAW1GFI0p0yoJT30hRYHaewGJgNju7CRA C0kyCLIip0gZQltKcM6GI4MNug== X-Google-Smtp-Source: ABdhPJyHX3PoYRsGFUxGkeeCqGttR+NzV972E7ncV9J1A49qk+XgxXs6FMRDtU1LSi15aefSC1/YWA== X-Received: by 2002:adf:8486:: with SMTP id 6mr1234507wrg.109.1594994074147; Fri, 17 Jul 2020 06:54:34 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:33 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 07/14] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data' Date: Fri, 17 Jul 2020 14:54:17 +0100 Message-Id: <20200717135424.2442271-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095435_094114_B001AA63 X-CRM114-Status: GOOD ( 14.38 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:443 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Jaswinder Singh , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-spi@vger.kernel.org, Kukjin Kim , Andi Shyti , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'quirks' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:150: warning: Function parameter or member 'clk_ioclk' not described in 's3c64xx_spi_port_config' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'pdev' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'rx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'tx_dma' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_conf' not described in 's3c64xx_spi_driver_data' drivers/spi/spi-s3c64xx.c:189: warning: Function parameter or member 'port_id' not described in 's3c64xx_spi_driver_data' Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Andi Shyti Cc: Jaswinder Singh Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/spi/spi-s3c64xx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index cf67ea60dc0ed..924b24441789a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -130,9 +130,11 @@ struct s3c64xx_spi_dma_data { * @fifo_lvl_mask: Bit-mask for {TX|RX}_FIFO_LVL bits in SPI_STATUS register. * @rx_lvl_offset: Bit offset of RX_FIFO_LVL bits in SPI_STATUS regiter. * @tx_st_done: Bit offset of TX_DONE bit in SPI_STATUS regiter. + * @quirks: Bitmask of known quirks * @high_speed: True, if the controller supports HIGH_SPEED_EN bit. * @clk_from_cmu: True, if the controller does not include a clock mux and * prescaler unit. + * @clk_ioclk: True if clock is present on this device * * The Samsung s3c64xx SPI controller are used on various Samsung SoC's but * differ in some aspects such as the size of the fifo and spi bus clock @@ -154,6 +156,7 @@ struct s3c64xx_spi_port_config { * @clk: Pointer to the spi clock. * @src_clk: Pointer to the clock used to generate SPI signals. * @ioclk: Pointer to the i/o clock between master and slave + * @pdev: Pointer to device's platform device data * @master: Pointer to the SPI Protocol master. * @cntrlr_info: Platform specific data for the controller this driver manages. * @lock: Controller specific lock. @@ -166,7 +169,11 @@ struct s3c64xx_spi_port_config { * @xfer_completion: To indicate completion of xfer task. * @cur_mode: Stores the active configuration of the controller. * @cur_bpw: Stores the active bits per word settings. - * @cur_speed: Stores the active xfer clock speed. + * @cur_speed: Current clock speed + * @rx_dma: Local receive DMA data (e.g. chan and direction) + * @tx_dma: Local transmit DMA data (e.g. chan and direction) + * @port_conf: Local SPI port configuartion data + * @port_id: Port identification number */ struct s3c64xx_spi_driver_data { void __iomem *regs; From patchwork Fri Jul 17 13:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670413 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C902113B1 for ; Fri, 17 Jul 2020 13:57:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FC2420717 for ; Fri, 17 Jul 2020 13:57:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HMkfzexk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z6e2Az59" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FC2420717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2ilr6AZFwtDAMwA6WxdwXriTSx1DqMVr5WRszJEFyZc=; b=HMkfzexkNErJLkEB4Dpig+QG0 C9zrF9RgjbLsmJ7XvwbvXdtm5Xrc/WNuvWHMAwrXSwwhN4wj9M8ekYHfligcpVvPhuHs+dilUi3Us etkPKVaTaGcUyRTEzoiiCA6p6XEiVpk8VaNv1mUWOxfzR0Azbj7ZmKL9J2jbQvG/pafNN5tBfpJcD wl+tVcvNGRpOiswXn0g8tWLL2v8e0+ol8ExOrjhT+CDv8I4zw+C298pxa+YpO/pbTxnp5eSf87D9m FWXqMTzsz2vLU80wSPHHT+kiHlFVtIFqFaB3h7VYOF7oWNJDWVls3ywctXt3gIn5goc59GSIqt+aX /t+G6i37g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQpa-00038W-2s; Fri, 17 Jul 2020 13:55:18 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQou-0002t4-BJ for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:37 +0000 Received: by mail-wm1-x344.google.com with SMTP id 17so17180235wmo.1 for ; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BdU11UOQFuXyCSynzxRXM0IT1vARtgrxd2bUOuqypjo=; b=Z6e2Az599CouQ+hjKJ3fh171GrmBXuuQYoyxs21YgHQXcnooWtd0d4qYE1hp7Fwp5Z SM8M9boXYBJvn8lwPVCVxW6+FNHJUOfLDJ52Mrw0pvO9wEGLC8olytK/rYr01bgfpIRX NfOd0UXXmOtLeEZgF7joBx8fm4hIDMZDinwqPn3IXqLfsoAW+pE3JeoJdYkxDJ+rSeGm zl3LNaO8Iip6w5A2lPOWUgmwjQqpCN61R357z3ZYuT4myLa+74zeRFOI1eyXwWOm8FDM ISnduGtoskDm+LkUDeOMHuTItePm8NNoAdICqcjQFMk/XhvtEoz3VYA6B7hUX6aUJ1V1 XjxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BdU11UOQFuXyCSynzxRXM0IT1vARtgrxd2bUOuqypjo=; b=A/ntQt+JqQNyRDUj+X+lxK2UecIKHwopx4tUkfplwqmSPd6GS5o/8HQbDEpIYr+CAv YLQS+ubF6TyDuCkkez7JhlE4BktTw0Jwo7npnoj6hb3SBzlAfYLdBGvURMU9XA1DkAdw ONQPJGXAWRIISM+sYRje+Dmdgqe5aX74ogQZI3LjsIZjoZZY9c+uYvOhrjm4XYirsV94 b7t+40JiJr8pl2X+dAX8DB4NMYIGww60shPbaocQu2gFqEQYnx4giVXl0YEIOnT3lNWX h6BVbF0uA2ZXZyJlyj04aXwtwBtYTLL9wRr/Z2TCdYFjpjJpyNIbqkmrxO4R3bLofdyR d5Zg== X-Gm-Message-State: AOAM532r5i8is/ZVqpiAZtFsGeuUxHEHR30mwSuY+btpOB1fPQVgvXpE twuivgeMyXgo+OZkYJh+QqzcyQ== X-Google-Smtp-Source: ABdhPJw7B9TDI0XMbwrUhXUY/EXKQH5gIkMZxaFo6XtGIcaYGVLxDNa64CokR+smlhl5Hzf6a9aXJQ== X-Received: by 2002:a7b:cd83:: with SMTP id y3mr9305717wmj.105.1594994075163; Fri, 17 Jul 2020 06:54:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:34 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs Date: Fri, 17 Jul 2020 14:54:18 +0100 Message-Id: <20200717135424.2442271-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095436_435806_C4375BA2 X-CRM114-Status: GOOD ( 13.63 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sachin Verma , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Also demote non-worthy kerneldoc headers to standard comment blocks. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing ' drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' not described in 'vendor_data' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'rx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'tx_lev_trig' not described in 'pl022' drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'dma_running' not described in 'pl022' drivers/spi/spi-pl022.c:670: warning: Function parameter or member 'pl022' not described in 'readwriter' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'irq' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'dev_id' not described in 'pl022_interrupt_handler' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'pl022' not described in 'set_up_next_transfer' drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'transfer' not described in 'set_up_next_transfer' Cc: Sachin Verma Signed-off-by: Lee Jones Acked-by: Linus Walleij --- drivers/spi/spi-pl022.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 66028ebbc336d..d1776fea287e5 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -298,7 +298,7 @@ enum ssp_reading { READING_U32 }; -/** +/* * The type of writing going on on this chip */ enum ssp_writing { @@ -317,6 +317,7 @@ enum ssp_writing { * @extended_cr: 32 bit wide control register 0 with extra * features and extra features in CR1 as found in the ST variants * @pl023: supports a subset of the ST extensions called "PL023" + * @loopback: supports loopback mode * @internal_cs_ctrl: supports chip select control register */ struct vendor_data { @@ -353,11 +354,14 @@ struct vendor_data { * @read: the type of read currently going on * @write: the type of write currently going on * @exp_fifo_level: expected FIFO level + * @rx_lev_trig: receive FIFO watermark level which triggers IRQ + * @tx_lev_trig: transmit FIFO watermark level which triggers IRQ * @dma_rx_channel: optional channel for RX DMA * @dma_tx_channel: optional channel for TX DMA * @sgt_rx: scattertable for the RX transfer * @sgt_tx: scattertable for the TX transfer * @dummypage: a dummy page used for driving data on the bus with DMA + * @dma_running: indicates whether DMA is in operation * @cur_cs: current chip select (gpio) * @chipselects: list of chipselects (gpios) */ @@ -662,7 +666,7 @@ static void load_ssp_default_config(struct pl022 *pl022) writew(CLEAR_ALL_INTERRUPTS, SSP_ICR(pl022->virtbase)); } -/** +/* * This will write to TX and read from RX according to the parameters * set in pl022. */ @@ -1237,6 +1241,8 @@ static inline void pl022_dma_remove(struct pl022 *pl022) /** * pl022_interrupt_handler - Interrupt handler for SSP controller + * @irq: IRQ number + * @dev_id: Local device data * * This function handles interrupts generated for an interrupt based transfer. * If a receive overrun (ROR) interrupt is there then we disable SSP, flag the @@ -1334,7 +1340,7 @@ static irqreturn_t pl022_interrupt_handler(int irq, void *dev_id) return IRQ_HANDLED; } -/** +/* * This sets up the pointers to memory for the next message to * send out on the SPI bus. */ From patchwork Fri Jul 17 13:54:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670417 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 26C7A13B1 for ; Fri, 17 Jul 2020 13:57:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2ECD20717 for ; Fri, 17 Jul 2020 13:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aXQiypch"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cCC6wwWl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2ECD20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GVuP6AXbVt/SZoDgqaMe06wiv0/4v/0XOEqVhuoSHm8=; b=aXQiypchWi0KVQSj0VrLBBalI wm3bsKigl01mV5T5sJbNGmreQ4o5YdugZjg6OfsJW3W5th6qWE4kq7ynjxABpsAcJw6B8dscEpF6X eT3P6ns7t4YrCHPzvegJbXAdKoygkKMQBdwp/PZeUrxzIqTq/Ef+15LAN8CBOznA0iZ25fHi8Kt/6 Lxhh+pVT3bnrYHznCq7kpdCQkLW60FDAPUPawgfOx3ULf2ZpMa5NmKB+u14JvtfMWgpJRphrlJjYp 4OOOcq944L+QSzD4pnVmd7c2qHUcLMwvU9O1Af28Wii6zE5pf9LbIn7Y6PSlkoGCif3C+q7i+ww4/ ToW10zRHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQpo-0003DP-6j; Fri, 17 Jul 2020 13:55:32 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQov-0002tQ-Ew for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id f139so17178367wmf.5 for ; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=cCC6wwWlQpTMveu1qLqD9irne79EY5ETXeh1rAvAAmH+LbiFyUjRk1ScIyrfmwefTv mFH+Dn3v/+xPUHoIWVWnpdkrm8IZAwwrC0nGV6nJHAUPKTjea9YuyLEZQwc1IJAswX6+ tCXEHvtE1nHhDMPzh2+JAiQX+k+oxlOF0rSb1BHirgI+fTnJa1Wag/CmnsEhB2k4FQei IuVXnlndn2vb2xncG+l0JMF/aakBraFwN6jUo0NHQUI1LLX0qof6/3e3YtpgKX0gUI4o sBKrEHsK4I3F+qIti6r6RGX+i+V2MWy7R7rwXBmQH2TfDvHmoPTS3FPp8isAlmk2K3fI VMLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/mBj9pAMuVLonO6aKhrgrEYwyEsNFutXpDwnyRxo/to=; b=OA+0cHhk8wVIFmnM9WbWHB+qJt6KVXVoerdsdPVPvQUhz0KkW5MltkRHz4Qn7Ap/Jl KPWxhhz0FfPQll0akO/aSEd7nMVe95imfPz8bO8kJg5AxMexannAY8qEV3qVlNPbC4hK 9knNqWKufVKpkzLuLtio5VXgKLRPPgwpCbbx06hnQ4CLGXMt+RKLaLiVIehx65fdDJRj FSzhWTdz96/xrbrFpE10NiZUEpaWUDtwTEp6Saf5jcIlpeHPj+jypsOcAt8lFtQp1qax h77kd80I6f74jxOcu5O5TkvO7Wkwj3KdINOxg+etW1OOdfKmpdmcnxZQHmR+PSIvrnZY Ec5w== X-Gm-Message-State: AOAM531I4GQmacG4YzL0iaBxPv6mQz1ZbhSnpAc69r2TJbgg2HCMXPQT Ayp84sCxL+yhoNmylVir6EKqpw== X-Google-Smtp-Source: ABdhPJwcTbAJHeWet+0yZMRNf1B5uWVO3GrnOII6C92tRowqv4TTCeJPT7QC54S41JczZLvDokTPCg== X-Received: by 2002:a1c:2d0c:: with SMTP id t12mr9259723wmt.43.1594994076272; Fri, 17 Jul 2020 06:54:36 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:35 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 09/14] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters Date: Fri, 17 Jul 2020 14:54:19 +0100 Message-Id: <20200717135424.2442271-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095437_549800_A386B70E X-CRM114-Status: GOOD ( 11.24 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , linux-kernel@vger.kernel.org, Sureshkumar Relli , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynq-qspi.c:143: warning: Function parameter or member 'dev' not described in 'zynq_qspi' drivers/spi/spi-zynq-qspi.c:334: warning: Function parameter or member 'spi' not described in 'zynq_qspi_config_op' drivers/spi/spi-zynq-qspi.c:334: warning: Excess function parameter 'qspi' description in 'zynq_qspi_config_op' Cc: Sureshkumar Relli Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynq-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-zynq-qspi.c b/drivers/spi/spi-zynq-qspi.c index bbf3d90561f54..5d8a5ee62fa23 100644 --- a/drivers/spi/spi-zynq-qspi.c +++ b/drivers/spi/spi-zynq-qspi.c @@ -119,6 +119,7 @@ /** * struct zynq_qspi - Defines qspi driver instance + * @dev: Pointer to the this device's information * @regs: Virtual address of the QSPI controller registers * @refclk: Pointer to the peripheral clock * @pclk: Pointer to the APB clock @@ -316,7 +317,7 @@ static void zynq_qspi_chipselect(struct spi_device *spi, bool assert) /** * zynq_qspi_config_op - Configure QSPI controller for specified transfer * @xqspi: Pointer to the zynq_qspi structure - * @qspi: Pointer to the spi_device structure + * @spi: Pointer to the spi_device structure * * Sets the operational mode of QSPI controller for the next QSPI transfer and * sets the requested clock frequency. From patchwork Fri Jul 17 13:54:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670421 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0E1D60D for ; Fri, 17 Jul 2020 13:57:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A86F320717 for ; Fri, 17 Jul 2020 13:57:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UjoqRirc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vGeuCgIu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86F320717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UUpNM7xoZAezQYuLdX/9Fev01SyL5dS4emwmWndD04o=; b=UjoqRircJaoMlQjDl3fIHguhP qdruidwW1AjdVjW60BwvQyTWcLTyuPhWfEMDNKsA5QGtgspmdsyF2WKayYRgvobMxhQkrlJNdiBCh vP8R0detvLKsNrAGAQamkRd8XJ8W6B3U4XDN07S+T/XXaJ6MRnugAtni6oIyWSU+S8ZO4ZGffwLfh k5sXwJ1VpLofyd9YeWuvVw91QZ4VYzE91pXPZeuuJybZvQQQ7i6Vk/IdsYwBvW1bqMzZ7cMlHAIyT 6c7k4/lSUAmSEODp1P8myBx/BucKw2E/TEUhHzdo2SGjJLcYkhoFkjX9Kmsdaq61rQRivs130OWAE N7CNvF1oQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQq3-0003Lo-7W; Fri, 17 Jul 2020 13:55:47 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQow-0002to-6k for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:39 +0000 Received: by mail-wm1-x342.google.com with SMTP id q15so14960134wmj.2 for ; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptPnW5Wq5Xlmw660UEVJ/FMLrebEARvPD+hr3BMDl5Y=; b=vGeuCgIuXoltl82e88QMAD4qKZTTplcAZ8PaNDib7nkd+uoYiTXZeVJpFP9WyGWZ6I PfM3Ca8M089A3y7Gbs8ILX0PuKbmPBeDvzF6ZG9V3ukEAc/yw0+f71JUSMyM5Ffokyx7 IdXYIamPS9sSWW3ciq7IBJGGjzRIMC8rDnqUysc+Ej2OPnL/1OMIB5dxfe/+A6fARcQK auUqYqUQhiAleVyWBH7QyFrx3GSYVVrxi6lr2CkcDRTPu0ZBZ+RQRF8oG/t+LG7RvNwm iVL5K/MEY+S9e2wv2tSgOE+UWEyObkfBCvxhkCv/36sDGFg6YatUyXNMRuzC8OaDQxDT 93+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptPnW5Wq5Xlmw660UEVJ/FMLrebEARvPD+hr3BMDl5Y=; b=Q+yks1jPQQ4LSyilpwDifF2xTQZmnjt6zlGZTrjxiaZMN0qpAevt1+uD2s/5A53XZX YjjybTnhFF2pqWKY8+lJ+5GpqDf3EZWMS2NdRWU8xpR14UlWYEYINW/NCgHzE2QilnFD fUcQrJLTlOLotcMxfDViWIALh9bfEAbvH2UjzPvKtuz+wEGg8Cl+2PLfd5RYhKuasfpH AgZaibK/7lIYiwUGI4chpt68K1uVSXyaIeIL/UmjYzqf74ICAgYCeSH+w5rBOLA29jj9 1Q2GeOOexFUB2eLyohmnqb5a0g9pt69wM5tY44QzKTTTkFgmGb9f4vqJDD5S08ppR22h 2chg== X-Gm-Message-State: AOAM531t1W4vdcEV43nC7a2G53H90GYOhhjSNFZ8haooOKMr0eONwkFH aizVYWN3D8Flcd+B42JZbt8I/g== X-Google-Smtp-Source: ABdhPJyZRQNbnf+BDafZphHh3/FOeuAD/mogS711QlQ7nFrzO3XXgtccwF7VUm3xUyVC5f35oFt8Lw== X-Received: by 2002:a05:600c:2949:: with SMTP id n9mr8765745wmd.69.1594994077227; Fri, 17 Jul 2020 06:54:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:36 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 10/14] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc Date: Fri, 17 Jul 2020 14:54:20 +0100 Message-Id: <20200717135424.2442271-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095438_334878_EC1B114B X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavecs' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Function parameter or member 'slavebus' not described in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashcs' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:205: warning: Excess function parameter 'flashbus' description in 'zynqmp_gqspi_selectslave' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Function parameter or member 'dev' not described in 'zynqmp_qspi_suspend' drivers/spi/spi-zynqmp-gqspi.c:902: warning: Excess function parameter '_dev' description in 'zynqmp_qspi_suspend' Signed-off-by: Lee Jones Reviewed-by: Michal Simek --- drivers/spi/spi-zynqmp-gqspi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index 811c97a7c8589..e17a201252557 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -197,8 +197,8 @@ static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 offset, /** * zynqmp_gqspi_selectslave: For selection of slave device * @instanceptr: Pointer to the zynqmp_qspi structure - * @flashcs: For chip select - * @flashbus: To check which bus is selected- upper or lower + * @slavecs: For chip select + * @slavebus: To check which bus is selected- upper or lower */ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, u8 slavecs, u8 slavebus) @@ -892,7 +892,7 @@ static int zynqmp_qspi_start_transfer(struct spi_master *master, /** * zynqmp_qspi_suspend: Suspend method for the QSPI driver - * @_dev: Address of the platform_device structure + * @dev: Address of the platform_device structure * * This function stops the QSPI driver queue and disables the QSPI controller * From patchwork Fri Jul 17 13:54:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670427 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D730B13B1 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF58E20717 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2twAuKVN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CLcRog2e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF58E20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9FfHxkMs+ZsC+4fqRbsz213O0o7WMv+4BV6ieknnas=; b=2twAuKVN6LftpbMKiA+RmZS5U KMJTF69tYElxMJ995+yWx1HTGnmsES0SRwSPVtOtR5QTUJ5i8O1Lm4hs5LgcrqEsv1ocOycqC9ih5 oekGHz5FUjI3ni58SS61N+Ve6+X5nOAQbmzDOAuIhTep4fvzk2+UVf4+ngsLNnh4ueFsH8QNYy24l IOSds08q98K08FexMsdaIMg0Gdf32oSj1jlDETEQLpvEmjNJyah24op9W0agCP8Zek4CL9sNnRWLT DupsRn23/NEz5wNBpW/1YQwIZdfIygApel2n6EFiDdTgDc6IxnCUl6HSBxNTwKisFNtt0LAdG693w kQAEs3LCw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqL-0003WV-R3; Fri, 17 Jul 2020 13:56:05 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQox-0002uH-2v for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:40 +0000 Received: by mail-wm1-x344.google.com with SMTP id f139so17178482wmf.5 for ; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=CLcRog2efhriOmziPd49uvqHp4X3kgn1MMhEVojt9mJGnBLfyFuKfUqJx5yUzpj2Zj 5Ym61ZRmqQ3DPrfbITu3j1YnCKySperMNZP3cU9/bdO1TgPDWdDmjQ7d0qmWsdesIvOB bpIYUeLDljadMWctNzF83RAoClWIdr6ZSV9f6nz8BgpWTi2y0Wbqedj2QUGb4eXYyhXl YxdqabjHzf9qfpd/LXuXtREuBS0/PiNBbOp/snlxaqVb4l4MNvOyJybjndDRwjdnl8LP v+6owkZu7AR/Jbyz9Uap9KGe77zwO5b6d8Qz+tNE0W5rLJK5uCHXMlkkdJN/ItaZQ7br qxOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZd/W0TpHswu0SuYSG0OcLxLAj8b5WuGZfRv6Lvmmao=; b=dv9TSD+/zxgm/yZVTdNRQIspGlxRYBMrFGrvVlcEuDjuCJGfjbkcl4fB7m+K0+QpRc xRLFl6s1yyzA1Z1gC+3E/ew1oLXbLdhG7F6llbOc0idow1ssZYNqIDpCxmW6OSUS2ep3 9O6O5ahQD2mdrsEifB6xZYfcdHhbozCMY3jZly03/gnEy0nfiHFYUNKxAMfH+EJu8jnt cLaAhLXOcd4sgdcNg6on5ob8sFHns02n63ZdpLMR6i+GiYiT2M80QVfvg59xsSk66ICW tFV1Xch1nqI+c1YPzUQHZOlDaRspf7QkOqNLWV1H461dWRxONK/zt10gOl5pF2nH7HpT IgOw== X-Gm-Message-State: AOAM530ak0C9o3eNm8kr12FwJrjk+Iud38rj/I9skiFPJv0gGYwQmYIR m7/mRpfIqEYHbWPrkcOm3YSNmA== X-Google-Smtp-Source: ABdhPJzmXBAH1xHG/f+/U5CPsM7W8OR1I8fHDdWt1wtsnnCdoWIGjeRov6Uqg+/snJgO/SsCP9UkMg== X-Received: by 2002:a1c:7e90:: with SMTP id z138mr9010367wmc.7.1594994078207; Fri, 17 Jul 2020 06:54:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:37 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 11/14] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data' Date: Fri, 17 Jul 2020 14:54:21 +0100 Message-Id: <20200717135424.2442271-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095439_191251_A97DCB3C X-CRM114-Status: GOOD ( 12.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones --- drivers/spi/spi-topcliff-pch.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af74743e..baadd380cb297 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl { /** * struct pch_spi_data - Holds the SPI channel specific details * @io_remap_addr: The remapped PCI base address + * @io_base_addr: Base address * @master: Pointer to the SPI master structure * @work: Reference to work queue handler * @wait: Wait queue for waking up upon receiving an @@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl { * transfer * @rx_index: Receive data count; for bookkeeping during * transfer - * @tx_buff: Buffer for data to be transmitted - * @rx_index: Buffer for Received data + * @pkt_tx_buff: Buffer for data to be transmitted + * @pkt_rx_buff: Buffer for received data * @n_curnt_chip: The chip number that this SPI driver currently * operates on * @current_chip: Reference to the current chip that this SPI @@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl { * @board_dat: Reference to the SPI device data structure * @plat_dev: platform_device structure * @ch: SPI channel number + * @dma: Local DMA information + * @use_dma: True if DMA is to be used * @irq_reg_sts: Status of IRQ registration + * @save_total_len: Save length while data is being transferred */ struct pch_spi_data { void __iomem *io_remap_addr; From patchwork Fri Jul 17 13:54:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670429 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 134BF60D for ; Fri, 17 Jul 2020 13:57:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0A8320717 for ; Fri, 17 Jul 2020 13:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rIlAqWsz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VjzgIcU3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0A8320717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a8sV0wCbJqGtUlNlao2MdsJAo12ncKxAkXZyC7iRFJA=; b=rIlAqWszyL3sG12CdenCzY75W i+zaedrK6oEhORnSNakab5wD6LHEG3okzkorTMsBlCiRI59QjFZElYTzm4FUMfAWiqQfXYjHoLLQ0 SbyXXUaYXhMpaem9q/ix8k27FaLO1hhPFlmy7XMsp3ClTa5X3YYqeSjUYLwA4iJ9v9HbrsJnqGi2Z jBXKxGmUfe15uqHXW8qHOLdhraakesABFZ08wWCRtbPfR4y2gJMVO0EWLZGGD2PNLfxOIG7Pldu6I QccSNkJYalSkBk65B16Roytwz+qhg+kwq/Sy4iceaY5onQTR37MjKVKbPn43u46sQ6mcSAN8AVpSM GZXxXS6pg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqQ-0003ZV-3q; Fri, 17 Jul 2020 13:56:10 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoy-0002uh-93 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:41 +0000 Received: by mail-wm1-x342.google.com with SMTP id c80so14957809wme.0 for ; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CPH+QD7EGY89rpfM+jPOD+8I8Jq38VLlFewJk4yzuOM=; b=VjzgIcU3+ooip1M3AXK8TOgT0tdwcKF6NfoM8oDGAwDytuhYS3FzrGb+gD0Sjj04RP 6tyujb+FQaCiDYHM2ixzWByHiOOkfBd0lBsy9VaxV+PtktCvhVOceqQZ+cKcGruuUrA0 O7Gv5SFLmuApMRfZ4hdAu4HGPK1lB5nEBEfUyYFoDANRIzWirPpShVehPf4xCLYivPps iB2xoC8Y6/AfyoniZHOquXz01a98gHtBPW5io+sA1mafGTG8zdNDuQHU+/7aGle0kbSz m/3XeCqXw41/d+ARjP+Ax1G3nDZ5ChIQ52kQUK5FqdILlK3EDB/vZfoYqY0F57+cPyl0 1E9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CPH+QD7EGY89rpfM+jPOD+8I8Jq38VLlFewJk4yzuOM=; b=nLj3odMWvlNrt+pJInAuZg7RwvgZecjadLFIwxkYpVQOFmUt090yC2+Z5z9oD3TW5Z PmWnceFN/PLkD5mJylF4lxCN3aub3vWJq8w8BOJqjZJxUeKO1p7QhAUwo3RA9IvXsYoI k2nSL56WWLZlvozywW8R6vxST6jODveiB+nA48sfkmeSb03BkTR3+ryzKDGy1n+0RLpU VN3Nt/vS9obzHx8D1Xa9wvh3agdXDxfRDRDhsmxY5WKxbKA8Q6oViSc3aLUmTT0xCq6R KrwBBCPdvdh0x+4rW1TPbwNipYCsHd6C0+ViRyPf1BBEU5n+Syz+sC93+Liw3dFSnYqS lS9g== X-Gm-Message-State: AOAM533mDlTleGAPIuWMjI1k1Evvdqq6D7+CD8rQO+S1u/c7NPoKYb8S uyS6rx0TeGbVrK5ek6CbbAB+5g== X-Google-Smtp-Source: ABdhPJw8rtOM08fs2Dc82BjfBnHOOT1pIb5vMuLLZE4XFUuoUcXbreINH3AZhhkT4VVddL8v21h2jw== X-Received: by 2002:a1c:48d7:: with SMTP id v206mr9115687wma.145.1594994079322; Fri, 17 Jul 2020 06:54:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:38 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 12/14] spi: spi-at91-usart: Remove unused OF table 'struct of_device_id' Date: Fri, 17 Jul 2020 14:54:22 +0100 Message-Id: <20200717135424.2442271-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095440_431539_8A48E790 X-CRM114-Status: GOOD ( 11.43 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:342 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Radu Pirea , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-spi@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The only way this driver can be probed by MFD via its parent device. No other reference to 'microchip,at91sam9g45-usart-spi' exists in the kernel. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=] 684 | static const struct of_device_id at91_usart_spi_dt_ids[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Radu Pirea Cc: Nicolas Ferre Cc: Ludovic Desroches Suggested-by: Alexandre Belloni Signed-off-by: Lee Jones Acked-by: Alexandre Belloni --- drivers/spi/spi-at91-usart.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c index 88033422a42ae..8c8352625d232 100644 --- a/drivers/spi/spi-at91-usart.c +++ b/drivers/spi/spi-at91-usart.c @@ -681,13 +681,6 @@ static const struct dev_pm_ops at91_usart_spi_pm_ops = { at91_usart_spi_runtime_resume, NULL) }; -static const struct of_device_id at91_usart_spi_dt_ids[] = { - { .compatible = "microchip,at91sam9g45-usart-spi"}, - { /* sentinel */} -}; - -MODULE_DEVICE_TABLE(of, at91_usart_spi_dt_ids); - static struct platform_driver at91_usart_spi_driver = { .driver = { .name = "at91_usart_spi", From patchwork Fri Jul 17 13:54:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0022660D for ; Fri, 17 Jul 2020 13:57:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC9AB20717 for ; Fri, 17 Jul 2020 13:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L0RS17uJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BJWYGXYq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC9AB20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rK9jXS8VMe5whwJShosUusivPUtIdeDEn/NwAl2che8=; b=L0RS17uJK+ASlzyqfVAyDibGK NuFw/u0+dlGYsmEV5iEr7FKOYkFGAbRubQ5xPNDdHj+g6ZT8ZXE9vYO0CMzYx/edua/JaVfLr/C0V 4F+Sf9AhQmUtvJvCjVGepDQ54nSUR4xb73MRQTQga3uBNrlbB0pzmEWOJC/gcF878k0oLspypMEI0 AzhaObLHFslzf12X47MHJbYQC3UOeQKI7npONjTmn/nbq/VetCA5tE5ohAHfWI7GvvHAdzGGjuZH6 zEsKGqTq2wMWrufBo2+nnQ+d2hmL7SBAWd2MA5i80g4qPHkV63zanLSlwwK/dZRBb8eivbDCN2lIL kKAkUkwDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqW-0003dA-6k; Fri, 17 Jul 2020 13:56:17 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQoz-0002vP-P5 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:42 +0000 Received: by mail-wr1-x442.google.com with SMTP id j4so11180695wrp.10 for ; Fri, 17 Jul 2020 06:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=BJWYGXYq1pgsO4ivqCiR82eR35O7gSNMT6QzlxPG0J5WFo7f9l9ct2/Tj5hbius4wJ Z3Nj9oYaqBKMg1Xoi6M4UZkmmfrLIkOblh0TJcSGnmWoWrAo6+546QwFRUIZFYt0uk9F P4n6sI1WeB+yEJLGruWOY5oFh5vAAwBE0sSKpokIUpMVYM0U5mlq0hoKOTFrP6pj1ogt qBVxuMuEOaLVOwxwyszj1rDIl05cV1teNU20ANvSq5UID796wEmfuWiVh9kq+r3ORgD1 CKk+4gQ6lc1SCsduPRjx9fMiZ8f6nvrTSL7uHPXLrhtjK2mTSQcMBXQMTJfGqOP5i/M3 qjLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AI7c50J2x+3VkfEYyAsOrnfGhBXfcF4lm0Ws/hDguDo=; b=tOAXubG/DpEWqXE539ByICMlJHksEahI7ThSrU6Yzrp6X2odVXeafqV/YTGmoWMBxD aJzapKbKCim9mOq5rVvRX1iOy4geHET8qKxX9hzGW9m5LSnes2PKhguJ7rqWFezKfyw9 FI24538X6QM4sWOUTkdQ7zbhOGQVSQDozakzPOGaBSNXWtzUDU5EgdvASGqVKEzO5nPO XwZA/m9olk2yDwjCzj18irN/ctAYVF75fv9rTY1naOxCm4Ls2VswxF6+dOur7UG0h5lK B3VHozIv+wmOGd0JFZoKYdjdUhVp+vA6sbM6YxBtBmRFnqombbuS/7RTEEUkhbEzBt2D CNvQ== X-Gm-Message-State: AOAM533vBTvAEQdKtfNaqn9ck/XbT0lsFw0WHxegCSd0TjZ8YUpVU88Q ZWsP5MWk1zjQ9c44hv2uVCrgcw== X-Google-Smtp-Source: ABdhPJzcxiqCEsLDkUJ5mleRr1Wv9TnyI904k47F56Gh6ETTAgfzBGp386wph9T+fLWOu0SbjVA3ng== X-Received: by 2002:adf:f104:: with SMTP id r4mr10951860wro.90.1594994080427; Fri, 17 Jul 2020 06:54:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:39 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 13/14] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 17 Jul 2020 14:54:23 +0100 Message-Id: <20200717135424.2442271-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095441_858258_0FDEBB19 X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Robert Jarzmik , linux-kernel@vger.kernel.org, Haojian Zhuang , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'pxa2xx_spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-pxa2xx.c:1435:36: warning: ‘pxa2xx_spi_acpi_match’ defined but not used [-Wunused-const-variable=] 1435 | static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Signed-off-by: Lee Jones --- drivers/spi/spi-pxa2xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 0040362b71622..814268405ab0b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1432,6 +1432,7 @@ static void cleanup(struct spi_device *spi) kfree(chip); } +#ifdef CONFIG_ACPI static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, @@ -1442,6 +1443,7 @@ static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { }, }; MODULE_DEVICE_TABLE(acpi, pxa2xx_spi_acpi_match); +#endif /* * PCI IDs of compound devices that integrate both host controller and private From patchwork Fri Jul 17 13:54:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11670431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 16FF860D for ; Fri, 17 Jul 2020 13:57:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3B8B20717 for ; Fri, 17 Jul 2020 13:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="maVgfzUV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bpNzeGQ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3B8B20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jzQHqSW9OqwjS8TZHUY6/PUJhDQs4yREEhYqGrIXgBY=; b=maVgfzUVv05rwo53x2MhfIprF 09Uf7ipUunMrrrIEBJUwpjbCofYxTLsBk0G0FLgHIUB3uNHE5cPKjyBtFxeS6Ld26VLdvenHt7+xO wRzrdzstGhINyc7dduaXhfblqn7kKWfMqOYKxdTDlsTaezNFl4lI5pEPL2GC9uwF+m32JYGcmAkzl /yd9vTuf91xyNfL/m0szPTMo9UenEF7rMmq5gxdNkWSipQHAgbSkcvRavF7qDZT4pCWDUR1r8DQw0 ev6sc2A/WeWujOvFq9+zGQr4hBspO3nbT1CT/7pyh78IMIChUpshk1ymJ75ISowWjrVJv9acI93pV jnaEQyDgg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQqb-0003gI-N4; Fri, 17 Jul 2020 13:56:21 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwQp0-0002va-ME for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 13:54:43 +0000 Received: by mail-wm1-x343.google.com with SMTP id q15so14960511wmj.2 for ; Fri, 17 Jul 2020 06:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=bpNzeGQ2MR4hr80NvQhU98nD3GgSa4EDbYmGyWnchS5R3CJAZ9DaK36qm+qmXP2F+E V8YBOYQySCSk1JLCHed2FvU7RP1NEE94M+Kde0STUOJGfkONWj4s0Uc+QjarvN2q4NtN AsmqgLlDKAu8qLK16LPIIt5kXHR1qcZnoUFm4pHV/kl5ScEHKkKwzKmyOBCfwPguiP/z GSwuDGCDy1Ku3Ybl9ASlfk+YTrI0hfqVKnazspGNqYP19fvdKf5StJnn1HUViiHCURQ2 0VEZEE2oky80AyF2bpL0dAxjuoS1yacbs+7svgQv8gFOU0JezgrR8a7YMHfLdNtQBFns rT6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=St/xAyCtrmRBWfYYcSn7juPr5Poh/NZ3n2rNrUrY394=; b=F2upXMUsSpODkLp+h1rg/aukaS/gxZH/wB8e9sGFdB6DG97Ms5i82+A5y90fQLiZnm RZwOUZInYr9ZVphHQaPXInB3FqU2LulO29A9SQpjJCbTqJj+OH9OUDtY3pJuZNCXVrFg C8+6CywGQMjoCuk0yxhoTye7T31zPQzvl9cAYaCuatCVBe35zxA9W+V+4IvGsiy+IrZu 1dplrUyJcqwP3Rbk2V5hqNb5SRKQbOHO3FxFbWW24npn8DoR1S/V85YI5EcDg+FM3R6r W/3VOljTIdt6O6ZdV0bnmXf51E+jUsQNsy3QOQlDT49eth9SPPNs+3lbwYLSgYy54Uv3 biVA== X-Gm-Message-State: AOAM532ZnUjvQGzJFJe49Ae9/1e+ogYKiNWOifIOkzcjng6crCZ3h6Du vwToainonphsoMSPPnjwrwyHGfqmkWTXAA== X-Google-Smtp-Source: ABdhPJwGwZMyZOKEAjKXmjbfGVU0S7+YF4JdD8KyDcLgCtRvve1JosJQWI81wjFZ79tXlavUy9Wvog== X-Received: by 2002:a1c:31c6:: with SMTP id x189mr8995770wmx.182.1594994081433; Fri, 17 Jul 2020 06:54:41 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id w128sm16118356wmb.19.2020.07.17.06.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 06:54:40 -0700 (PDT) From: Lee Jones To: broonie@kernel.org Subject: [PATCH v2 14/14] spi: spi-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 17 Jul 2020 14:54:24 +0100 Message-Id: <20200717135424.2442271-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200717135424.2442271-1-lee.jones@linaro.org> References: <20200717135424.2442271-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_095442_776694_D1AC7D49 X-CRM114-Status: GOOD ( 12.54 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sanjay R Mehta , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct acpi_device_id spi_acpi_match[] = { | ^~~~~~~~~~~~~~ Cc: Sanjay R Mehta Signed-off-by: Lee Jones --- drivers/spi/spi-amd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c index d0aacd4de1b9e..7f629544060db 100644 --- a/drivers/spi/spi-amd.c +++ b/drivers/spi/spi-amd.c @@ -294,11 +294,13 @@ static int amd_spi_probe(struct platform_device *pdev) return err; } +#ifdef CONFIG_ACPI static const struct acpi_device_id spi_acpi_match[] = { { "AMDI0061", 0 }, {}, }; MODULE_DEVICE_TABLE(acpi, spi_acpi_match); +#endif static struct platform_driver amd_spi_driver = { .driver = {