From patchwork Sat Jul 18 13:51:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11671939 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8AE013B6 for ; Sat, 18 Jul 2020 13:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8590F207EA for ; Sat, 18 Jul 2020 13:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080338; bh=AomjsvQpNNm5nuJPYBEOB2xsI+7XPf7vGxKGBp5ZrY0=; h=From:To:Cc:Subject:Date:List-ID:From; b=wFAzY1GgBobt9BdvMSiw1GIblhVVPd3q92/CxiuxltslR4ibULBaas+7oh43Tg6XI V48bNAPhe51Cz3xRyNgcB3tzW6JD3UZmy/7NPawU8tAhQqHZNunaMrsCkDHm2KP9LC Tfvf5pS74nc94V/b9zDzf/Gd7HJQGi20cLXZ6wGM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgGRNwS (ORCPT ); Sat, 18 Jul 2020 09:52:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:52978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgGRNwR (ORCPT ); Sat, 18 Jul 2020 09:52:17 -0400 Received: from localhost.localdomain (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A64D420684; Sat, 18 Jul 2020 13:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080337; bh=AomjsvQpNNm5nuJPYBEOB2xsI+7XPf7vGxKGBp5ZrY0=; h=From:To:Cc:Subject:Date:From; b=O/nqqNG/0AprEL+iesKmVGQItFlMpjJNySemo6Y/pMtXp2eeSB8HTiG2A2GmdAJLx uKS7xwPDR0BNl0sR9cPI6Kgy5shuVuF85hGkGKz71F/xVUt9CBVyBaeJx9T3f6xebB /4RdQPgWSjMUUfTKozFJr1MJ2ZLUYECy6Fx2Z29Q= From: Vinod Koul To: dmaengine@vger.kernel.org Cc: Vinod Koul , Hyun Kwon , Laurent Pinchart , Michal Simek Subject: [PATCH 1/3] dmaengine: xilinx: dpdma: remove comparison of unsigned expression Date: Sat, 18 Jul 2020 19:21:59 +0530 Message-Id: <20200718135201.191881-1-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org xilinx_dpdma_config() channel id is unsigned int and compares with ZYNQMP_DPDMA_VIDEO0 which is zero, so remove this comparison drivers/dma/xilinx/xilinx_dpdma.c:1073:15: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2) Signed-off-by: Vinod Koul Reviewed-by: Laurent Pinchart --- drivers/dma/xilinx/xilinx_dpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c index af88a6762ef4..8e602378f2dc 100644 --- a/drivers/dma/xilinx/xilinx_dpdma.c +++ b/drivers/dma/xilinx/xilinx_dpdma.c @@ -1070,7 +1070,7 @@ static int xilinx_dpdma_config(struct dma_chan *dchan, * Abuse the slave_id to indicate that the channel is part of a video * group. */ - if (chan->id >= ZYNQMP_DPDMA_VIDEO0 && chan->id <= ZYNQMP_DPDMA_VIDEO2) + if (chan->id <= ZYNQMP_DPDMA_VIDEO2) chan->video_group = config->slave_id != 0; spin_unlock_irqrestore(&chan->lock, flags); From patchwork Sat Jul 18 13:52:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11671941 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A563213B6 for ; Sat, 18 Jul 2020 13:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D755207EA for ; Sat, 18 Jul 2020 13:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080341; bh=v14RUrLpqw5e23XhDMif2sgNKz4wLFS80KSOAwmN2hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NGWlGEA47qys+m6/8U+qZewdLPhluzEbDGe2jphDj8sJAiyd4crDKd4bB9whFLuiO HQv+Ru+cQWbVtNa1JdiKjEHAFmSzBus4pNUxb0Eudcqjs4V+Q/CoAyU7g81yKLCkqW lxJIwrAZEROeV5ZR9YZ59qJ597XN324OaVssGfYU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbgGRNwV (ORCPT ); Sat, 18 Jul 2020 09:52:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:53018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726569AbgGRNwU (ORCPT ); Sat, 18 Jul 2020 09:52:20 -0400 Received: from localhost.localdomain (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33487207DD; Sat, 18 Jul 2020 13:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080340; bh=v14RUrLpqw5e23XhDMif2sgNKz4wLFS80KSOAwmN2hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aHaSVuhVw6b+gI5ZYpbKz4sNTaqxz2Or+eiiBOT+s8vVrO4sCCWfz1DGI4bHRkK6i SkKIkPHvlrEFABfTuStC/oaswNpgE5/hBApzT/cJRZlh5165bcq3Xz7WmXTDT7hbmw +0YYww2Ife6NBiNfEj78D8hUMQ2ZxAv9EAOwTtwQ= From: Vinod Koul To: dmaengine@vger.kernel.org Cc: Vinod Koul , Hyun Kwon , Laurent Pinchart , Michal Simek Subject: [PATCH 2/3] dmaengine: xilinx: dpdma: add missing kernel doc Date: Sat, 18 Jul 2020 19:22:00 +0530 Message-Id: <20200718135201.191881-2-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200718135201.191881-1-vkoul@kernel.org> References: <20200718135201.191881-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org xilinx_dpdma_sw_desc_set_dma_addrs() documentation is missing describing 'xdev', so add it drivers/dma/xilinx/xilinx_dpdma.c:313: warning: Function parameter or member 'xdev' not described in 'xilinx_dpdma_sw_desc_set_dma_addrs' Signed-off-by: Vinod Koul Reviewed-by: Laurent Pinchart --- drivers/dma/xilinx/xilinx_dpdma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c index 8e602378f2dc..430f3714f6a3 100644 --- a/drivers/dma/xilinx/xilinx_dpdma.c +++ b/drivers/dma/xilinx/xilinx_dpdma.c @@ -295,6 +295,7 @@ static inline void dpdma_set(void __iomem *base, u32 offset, u32 set) /** * xilinx_dpdma_sw_desc_set_dma_addrs - Set DMA addresses in the descriptor + * @xdev: DPDMA device * @sw_desc: The software descriptor in which to set DMA addresses * @prev: The previous descriptor * @dma_addr: array of dma addresses From patchwork Sat Jul 18 13:52:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11671943 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AF5A6C1 for ; Sat, 18 Jul 2020 13:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B534207EA for ; Sat, 18 Jul 2020 13:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080343; bh=u9Upr7Cditq41YfgIAZXfUwHFBvS8KDwmmsKJQE8Zxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hTZth4dd4HsXWGMi6Y5lZ882fEUPrny/sgxtINY8ibNq36bQ1b4IZWaJp47zeY7Y6 LOH9BwAkUHvEs199Od7wTLPA/1/rcoNC6/gkeMqroxnho0cbcmE0sAl+95UjK5qNaU n3416YyUKmQe8OPfCsaazBkBLt4JcjiAdn0Smcto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbgGRNwX (ORCPT ); Sat, 18 Jul 2020 09:52:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:53042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726569AbgGRNwW (ORCPT ); Sat, 18 Jul 2020 09:52:22 -0400 Received: from localhost.localdomain (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0B6E20684; Sat, 18 Jul 2020 13:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595080342; bh=u9Upr7Cditq41YfgIAZXfUwHFBvS8KDwmmsKJQE8Zxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DjgOIGQJmvrIK7utA7B+DXNyou5ywpPsze+kPPorEkc/sm9Em+6Z/uDH4CbxbeL1K +LGwdoKb2PqUYMBJny7xrUkUoYd7Xoy9wuBgzJDnfIyeGuca61jNVdEzpTzT7WSu7O S6QcPeBBZRpJKN4TkzBtn3f8+OpMGAz5g5wG4DoE= From: Vinod Koul To: dmaengine@vger.kernel.org Cc: Vinod Koul , Hyun Kwon , Laurent Pinchart , Michal Simek Subject: [PATCH 3/3] dmaengine: xilinx: dpdma: fix kernel doc format Date: Sat, 18 Jul 2020 19:22:01 +0530 Message-Id: <20200718135201.191881-3-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200718135201.191881-1-vkoul@kernel.org> References: <20200718135201.191881-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org xilinx_dpdma_chan structure documents 'desc' members, but that leads to warnings, so split that up and describe members drivers/dma/xilinx/xilinx_dpdma.c:241: warning: Function parameter or member 'desc' not described in 'xilinx_dpdma_chan' Signed-off-by: Vinod Koul --- drivers/dma/xilinx/xilinx_dpdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c index 430f3714f6a3..d94c75a842f8 100644 --- a/drivers/dma/xilinx/xilinx_dpdma.c +++ b/drivers/dma/xilinx/xilinx_dpdma.c @@ -214,8 +214,8 @@ struct xilinx_dpdma_tx_desc { * @lock: lock to access struct xilinx_dpdma_chan * @desc_pool: descriptor allocation pool * @err_task: error IRQ bottom half handler - * @desc.pending: Descriptor schedule to the hardware, pending execution - * @desc.active: Descriptor being executed by the hardware + * @desc: pending: Descriptor schedule to the hardware, pending execution + * active: Descriptor being executed by the hardware * @xdev: DPDMA device */ struct xilinx_dpdma_chan {