From patchwork Tue Jul 21 04:25:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru M Stan X-Patchwork-Id: 11674941 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52F2B138C for ; Tue, 21 Jul 2020 04:27:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B0972080D for ; Tue, 21 Jul 2020 04:27:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BcuAvzJR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="N/dp9Ioq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B0972080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=icgQisSx9tNg36iJ8nkg365tlFl1mFsLaYUtd0fBjYA=; b=BcuAvzJRS2AywV4E+QOjDvqPw rfNP6GpluyIkz+PwdhXqsUHexeRhP9M99P3NsqSfh41dd765QzM+sw/iI7pcGI+EUr+EOZXrGG6o6 6cjHJMq+XIDrXUuwRCe/yrBMA4GXu3RV4tzMm1XQrdldqqJN6WPu6EA8u9DslGUHOcewf/zhhpB7m jz90LBmUEB24pslEz+KeUrV2n7dy5/SU4l2zKDchTdfCc1nCPJaFtQKtR8Hb5VHkcwbAKS1MXbAmN h/1/6OjWGG/wneMaK8bOXn6JfgS2ag3mHA4eedNrL0lCP1h+qD21gtsB2t3qUx29owL4a8oS+kbwl +kGOQ9SQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxjsI-0007Rf-QC; Tue, 21 Jul 2020 04:27:30 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxjsE-0007PW-81 for linux-rockchip@lists.infradead.org; Tue, 21 Jul 2020 04:27:27 +0000 Received: by mail-pg1-x543.google.com with SMTP id z5so11356221pgb.6 for ; Mon, 20 Jul 2020 21:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v5DIRukwkI98RYm4Qg9DISHCAkP2l2iEddWUuvGqnjI=; b=N/dp9Ioq7OLVcCOwash9KSFssj8jIbJUFR6b8tP8e+vEJwiLmWFgkAsVB9nOd0if4D P3ZLOqJgVpdVgZ347tBVo6nFNCBHouz4wA3H96fDyiMLb1tysqPqlqkrdGyFLbVqJtj2 NKTnsjColGrhQmU4O9/Vhs4VscuviZPH175ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v5DIRukwkI98RYm4Qg9DISHCAkP2l2iEddWUuvGqnjI=; b=RmS7S25slX07B2XHNSwXaI8ECCCcNIxTgC1MbY3ZUB+6EsAIQ2DQnZv1ci7ORjeocP UKTWDSqOoT4P2DCbS5Ugo5i3EQEBlCdtXlvFZw6MBgcgxDOFOlWBryOrdOBRF7KdTdJF Zm9pFh+eAG6PVca3m/pSuLbzl98eRUuzv3EoUYf4w1WwhwsAP8bo88gNAV52M02Tj/j9 MJcP9DhKdYIXj4KRibjjwtAL9/9zMivv4GyCaKSNxS9Fa7Z491VIiG1TOuNrn8x1R2Aj 1qHUMKUbzS9g/XUejOExsHahF4xwIqo4eClk5ryBSSpJTO1HYULUcF+qawzdojsDpEY3 m1tw== X-Gm-Message-State: AOAM532yQJQQ9FyENttGVwjgwHYUxDTNKpTGw4G0mNJt+3kqJGJys/3P eOouqNnywt64E8EGQA9Tk/M/oA== X-Google-Smtp-Source: ABdhPJysPuat1sQO+DzVyz8AlUl5gUkPbkn8rHbNtm3EfbnoGtqhvO3PEyZiKFezujfJ6TOP2pe3oA== X-Received: by 2002:a63:b956:: with SMTP id v22mr21098040pgo.242.1595305644265; Mon, 20 Jul 2020 21:27:24 -0700 (PDT) Received: from alex-desktop.lan (c-73-63-253-164.hsd1.ca.comcast.net. [73.63.253.164]) by smtp.gmail.com with ESMTPSA id o8sm1207075pjf.37.2020.07.20.21.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 21:27:23 -0700 (PDT) From: Alexandru Stan To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Heiko Stuebner , Rob Herring Subject: [PATCH 3/3] ARM: dts: rockchip: Remove 0 point in backlight Date: Mon, 20 Jul 2020 21:25:22 -0700 Message-Id: <20200720212502.3.I96b8d872ec51171f19274e43e96cadc092881271@changeid> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200721042522.2403410-1-amstan@chromium.org> References: <20200721042522.2403410-1-amstan@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_002726_320856_B98E2B21 X-CRM114-Status: GOOD ( 11.43 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:543 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandru Stan , Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Matthias Kaehlcke , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org After the "PWM backlight interpolation adjustments" patches, the backlight interpolation works a little differently. The way these dts files were working before was relying on a bug (IMHO). Remove the 0-3 range since otherwise we would have a 252 long interpolation that would slowly go between 0 and 3, looking really bad in userspace. We'll still have the 0% point available to userspace, "backlight: pwm_bl: Artificially add 0% during interpolation" takes care of that. Signed-off-by: Alexandru Stan --- arch/arm/boot/dts/rk3288-veyron-jaq.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-minnie.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-tiger.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts index 171ba6185b6d..af4b21636c08 100644 --- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts +++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts @@ -20,7 +20,7 @@ / { &backlight { /* Jaq panel PWM must be >= 3%, so start non-zero brightness at 8 */ - brightness-levels = <0 8 255>; + brightness-levels = <8 255>; num-interpolated-steps = <247>; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index 383fad1a88a1..b25aa2f3cbee 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -39,7 +39,7 @@ volum_up { &backlight { /* Minnie panel PWM must be >= 1%, so start non-zero brightness at 3 */ - brightness-levels = <0 3 255>; + brightness-levels = <3 255>; num-interpolated-steps = <252>; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-tiger.dts b/arch/arm/boot/dts/rk3288-veyron-tiger.dts index 069f0c2c1fdf..52a84cbe7a90 100644 --- a/arch/arm/boot/dts/rk3288-veyron-tiger.dts +++ b/arch/arm/boot/dts/rk3288-veyron-tiger.dts @@ -23,7 +23,7 @@ / { &backlight { /* Tiger panel PWM must be >= 1%, so start non-zero brightness at 3 */ - brightness-levels = <0 3 255>; + brightness-levels = <3 255>; num-interpolated-steps = <252>; };