From patchwork Wed Jul 22 04:57:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 11677253 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18DD31510 for ; Wed, 22 Jul 2020 04:59:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E491D207BB for ; Wed, 22 Jul 2020 04:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fwiwgzAf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E491D207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cTO7arAYdvmS88d3qTpQVY1vVXLNBd1DNtqBv3+pY2M=; b=fwiwgzAfJ27qKXcv8Ga2pBICf lD/Z2e+UKhJSX4mFqbqTW+AlBPDQiXIb8/Nfo0ccq47t/7oS38ZzbTBF7PQeHSgsKjU+YmS2XlHwn P8hFZQhwuiTLPB7XwCN2PhO7qp8MtpkstNhtYMTcboQnaepn8rXz4S+Kug86Ct9u0r8f041AWCHXl Raky7QEimhhdpsP5kptDZPtEM4tLfrhZtTILJc4rQz1WQ8s+1xTqeH5Y+SCo3PdTb1Nv/MV99ctVj gNufbLFk4aM3rhzH9ok7S0K3F3yikvCVSDBa9cvmFWXQJjRI9kE60KXYywpRJ+iqILmhrbzkO9LjC QurtNS3zg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy6pD-0003F4-0e; Wed, 22 Jul 2020 04:57:51 +0000 Received: from smtprelay0237.hostedemail.com ([216.40.44.237] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy6p9-0003EH-RT for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 04:57:48 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 47E931829508C; Wed, 22 Jul 2020 04:57:46 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, , RULES_HIT:41:355:379:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3872:4321:5007:8660:10004:10400:10848:11232:11658:11914:12296:12297:12555:12740:12760:12895:13069:13138:13148:13230:13231:13311:13357:13439:14093:14096:14097:14181:14394:14659:14721:21080:21220:21433:21451:21627:21939:30054:30091, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0, DNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none X-HE-Tag: milk10_2f0383b26f33 X-Filterd-Recvd-Size: 2811 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Wed, 22 Jul 2020 04:57:44 +0000 (UTC) Message-ID: Subject: [PATCH] Makefile.extrawarn: Move sign-compare from W=2 to W=3 From: Joe Perches To: Masahiro Yamada , Michal Marek Date: Tue, 21 Jul 2020 21:57:43 -0700 In-Reply-To: <11ac49bc33546ef9ebc4120878206bd882667d8a.camel@perches.com> References: <1595358391-34525-1-git-send-email-clabbe@baylibre.com> <1595358391-34525-17-git-send-email-clabbe@baylibre.com> <11ac49bc33546ef9ebc4120878206bd882667d8a.camel@perches.com> User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_005747_938223_EE549EA6 X-CRM114-Status: GOOD ( 13.01 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [216.40.44.237 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [216.40.44.237 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: herbert@gondor.apana.org.au, linux-kbuild , linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, Corentin Labbe , davem@davemloft.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This -Wsign-compare compiler warning can be very noisy and most of the suggested conversions are unnecessary. Make the warning W=3 so it's described under the "can most likely be ignored" block. Signed-off-by: Joe Perches --- On Tue, 2020-07-21 at 14:32 -0700, Joe Perches wrote: > On Tue, 2020-07-21 at 19:06 +0000, Corentin Labbe wrote: > > This patch fixes the warning: > > warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare] > > I think these do not really need conversion. > Are these useful compiler warnings ? Perhaps move the warning from W=2 to W=3 so it's described as "can most likely be ignored" scripts/Makefile.extrawarn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 62c275685b75..95e4cdb94fe9 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -66,7 +66,6 @@ KBUILD_CFLAGS += -Wnested-externs KBUILD_CFLAGS += -Wshadow KBUILD_CFLAGS += $(call cc-option, -Wlogical-op) KBUILD_CFLAGS += -Wmissing-field-initializers -KBUILD_CFLAGS += -Wsign-compare KBUILD_CFLAGS += -Wtype-limits KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized) KBUILD_CFLAGS += $(call cc-option, -Wunused-macros) @@ -87,6 +86,7 @@ KBUILD_CFLAGS += -Wpacked KBUILD_CFLAGS += -Wpadded KBUILD_CFLAGS += -Wpointer-arith KBUILD_CFLAGS += -Wredundant-decls +KBUILD_CFLAGS += -Wsign-compare KBUILD_CFLAGS += -Wswitch-default KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat)