From patchwork Sun Jul 26 12:28:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 11685699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2DF4A13A4 for ; Sun, 26 Jul 2020 12:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BC5B206D8 for ; Sun, 26 Jul 2020 12:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595766489; bh=3pUBaBWGrfcLKWmWWsUPaRO4kpEpnbREmgmSfMgtfSM=; h=From:To:Subject:Date:List-ID:From; b=tQ49lu7RXNx4OQrh/PUoijScS8U6LxZCXx8m4d8u4bSlmbJlG1fXt6rDy0ki+epee ZnoAarT9lHXP6kxurNwyCsMoykoVwEfuKV4I8vNNbDWqvDuhiaX3V+UTKnIxzLrtN8 HMztRjJ2d/lewZEI8+fBWpGClMC3vM9cybT5/9Jo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbgGZM2G (ORCPT ); Sun, 26 Jul 2020 08:28:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:56656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726042AbgGZM2G (ORCPT ); Sun, 26 Jul 2020 08:28:06 -0400 Received: from tleilax.com (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA54F206D8 for ; Sun, 26 Jul 2020 12:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595766486; bh=3pUBaBWGrfcLKWmWWsUPaRO4kpEpnbREmgmSfMgtfSM=; h=From:To:Subject:Date:From; b=mBF1ryh10UnO+QvrSSWIQanO7x5nafxMTg9PcSF/ueNo5I1pTZgli+1Lezgnrzvee NSIOh3sqfir6Buttc28ivZhyrFUzJDX6ulaVVkHKnfyfz1oPqwup+pPynMxGxP/gR4 q1L7ITC6l18DKkOf6AJEc0nPZF0yXZUDcP8QyAXI= From: Jeff Layton To: ceph-devel@vger.kernel.org Subject: [PATCH] ceph: fix memory leak when reallocating pages array for writepages Date: Sun, 26 Jul 2020 08:28:04 -0400 Message-Id: <20200726122804.16008-1-jlayton@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org Once we've replaced it, we don't want to keep the old one around anymore. Signed-off-by: Jeff Layton --- fs/ceph/addr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 01ad09733ac7..01e167efa104 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1212,6 +1212,7 @@ static int ceph_writepages_start(struct address_space *mapping, locked_pages * sizeof(*pages)); memset(data_pages + i, 0, locked_pages * sizeof(*pages)); + kfree(data_pages); } else { BUG_ON(num_ops != req->r_num_ops); index = pages[i - 1]->index + 1;