From patchwork Sun Jul 26 14:25:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11685717 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9AF95913 for ; Sun, 26 Jul 2020 14:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8275D206D8 for ; Sun, 26 Jul 2020 14:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NABGNQ4j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726065AbgGZO0P (ORCPT ); Sun, 26 Jul 2020 10:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgGZO0O (ORCPT ); Sun, 26 Jul 2020 10:26:14 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90DE5C0619D2 for ; Sun, 26 Jul 2020 07:26:14 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id t6so7996738pgq.1 for ; Sun, 26 Jul 2020 07:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I2x4nvf5u7YHLs/rvuQ2DKG/frGYuFxUPbbH8Ur2AHA=; b=NABGNQ4jISqfIf4KjeMNSJ4qb2+5n5awMayQraRWHQOLGp8Qph63X9tPrWRZikdKCX aK3lLJ+sXhEoxgHJqf6iMldB1Iqj4cvJ4KwwgligXHmcaRw5Z4uleGrKkYsii0rvM5aw H2j4IlXpQ0vtDpQ6wQfe7YUVW1XUwt1wKvkjPGbaAs4UvHFjVS1ohzu2AhghufQaGNi+ jJqbK1R3EPu5umXbwXWZcubHRR+L4syFDSs0T1fV/sKK2ajrYM3VRapwk/nqiOujGOsS FJvk5hXuboIOwPBjxbkKPw4pqR2gZXYbMN7FX/6u6TdbGBwOlo2usRA1ixoy7TQBR3N3 tW0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I2x4nvf5u7YHLs/rvuQ2DKG/frGYuFxUPbbH8Ur2AHA=; b=i9MViKbhhyJcza0uzAlt7dV6vtRfv2kBICBYD8yEcTMH/WIVbq83A38K1WZnT0zmyU w7Weygq7g0tQsVzH7NR2qN7qr+Efe19nH05xb0CbgdWHUeOVJBCXjzR/ZWwEPKHYn7gs wbcxFuERO6k3+zPf+dLipPTtD1KHAUr0NmPe9icuc0GOfwXoZD9AdlI/KsKD7xuiVkee 53RZXJ775M1NfA8Z07mrui28frQA4xExLtngHrOKsATq2+2MtDNt1o+94BWjCHtDvNzU PSHoYGskb0sdyINai+hezDPdG6Tb/LqeDG8oOdp4nsXH6mANKzoVShkVZJjRBjuVHwV5 ixtA== X-Gm-Message-State: AOAM530+6cygr4pNN9x5dEpx0Vc9uCW8il+3Lsso8s2g/JrpZG7xc/A9 a7EerZQF6b62AhnqureM/e+tsZzNIaU= X-Google-Smtp-Source: ABdhPJxVqgXRXEmB+ysTbd1UBADhgrL9BLA2jGHX7jcvzqfkFdbJ9ZFvlk1UyyjaGzhLavO8iu6zOw== X-Received: by 2002:a63:7e55:: with SMTP id o21mr16433946pgn.263.1595773573417; Sun, 26 Jul 2020 07:26:13 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.48]) by smtp.gmail.com with ESMTPSA id p11sm11278908pjb.3.2020.07.26.07.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 07:26:12 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, peff@peff.net, Shourya Shukla , Christian Couder , Kaartic Sivaraam Subject: [PATCH 1/4] t7401: modernize style Date: Sun, 26 Jul 2020 19:55:50 +0530 Message-Id: <20200726142553.42545-2-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200726142553.42545-1-shouryashukla.oo@gmail.com> References: <20200726142553.42545-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The tests in 't7401-submodule-summary.sh' were written a long time ago and have some violations with respect to our CodingGuidelines such as incorrect spacing in usages of the redirection operator and absence of line feed between statements in case of the '|' (pipe) operator. Update it to match the CodingGuidelines. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 9bc841d085..4439fb7c17 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -16,12 +16,13 @@ add_file () { owd=$(pwd) cd "$sm" for name; do - echo "$name" > "$name" && + echo "$name" >"$name" && git add "$name" && test_tick && git commit -m "Add $name" done >/dev/null - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD | + cut -c1-7 cd "$owd" } commit_file () { @@ -125,7 +126,8 @@ commit_file sm1 && head3=$( cd sm1 && git reset --hard HEAD~2 >/dev/null && - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD | + cut -c1-7 ) test_expect_success 'modified submodule(backward)' " From patchwork Sun Jul 26 14:25:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11685719 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3ADE913 for ; Sun, 26 Jul 2020 14:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89CFC20714 for ; Sun, 26 Jul 2020 14:26:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIFegmTY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbgGZO0S (ORCPT ); Sun, 26 Jul 2020 10:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgGZO0S (ORCPT ); Sun, 26 Jul 2020 10:26:18 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B338C0619D2 for ; Sun, 26 Jul 2020 07:26:18 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id k27so7987580pgm.2 for ; Sun, 26 Jul 2020 07:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1JuxiEFbBgSuA8iGZ0RpKI2x/jJRiy3MfqRBbgyn/Q=; b=GIFegmTYeetu9JLXr72v5JJxU0YmZiXbZCEJ6I7acDD8fH4Dqw993tVk0YNqJQAlUO Gt4xmJk19vrpRSJd52hr+CefExG4SuOtbkjgiEOQtfAb/GXiW0yqRHC3+o51EXYuHl7c 09S2Xa/sN5OSVA8xaxftPAu1Isc7UlSq+vGg6q+DyVq+gMiYQQ6ebY7ygv2ycKj9cui3 hRm+dV2bSFKoYBzFG7wwNt+Fi8Ooc4+liDGF7W4O9aaid5olFallR9axZK3I1umtpmEU Mp6gtDhZLeD0Kyw0ToY2OATY0VD0NNqeRXpPW62NSDSfnv4niVw3p5JYqSaxjr4keVA7 g54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1JuxiEFbBgSuA8iGZ0RpKI2x/jJRiy3MfqRBbgyn/Q=; b=hhVI8qdsjErIm5RBLRcvNLaW8YyFLMo8bXDHh8hvax5j5OgH8AmobxFBGlXSHbGLhn Wc6CAFc5GxbFcX2mP2yzSXoy4apDPm7FyI5nQLWg7o7WXqHcQWHpfX7Fo687nkoeTDoB aekLgznZnIrOIfFsmggIuRuJkNhVh5A5GOiH29BJKs4jhe8zGp/r+dFzL/hPhIlee2gi 0QkqyY+gb4F2AOh7Ep6fQ/Q6JJNzaSpxdUSywnoJ8tJLDUyx7OpzD+5BE1l0/AKcsn8P eXnzrqFFdMWPqAX55YUD9GAUlgAfDZwgzlZey+nX0AcJGu8TH/H8HdO0/e84KDWzATer q2Tw== X-Gm-Message-State: AOAM5314oAucoos572Nma00JghMEv1SD8bwWnRH13oN7oeELRmxVVnRI ILBy560GlJA1cTCW6QSDlT7wXV4J/NI= X-Google-Smtp-Source: ABdhPJzhScOGIutRvWtiiP6crX31s1e4tiWA5V/AOxm6IpbTJExj97t9VDRDfjGu1tU/ZIuI3zhEiQ== X-Received: by 2002:a63:7c42:: with SMTP id l2mr16522679pgn.35.1595773577204; Sun, 26 Jul 2020 07:26:17 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.48]) by smtp.gmail.com with ESMTPSA id p11sm11278908pjb.3.2020.07.26.07.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 07:26:16 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, peff@peff.net, Shourya Shukla , Christian Couder , Kaartic Sivaraam Subject: [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Date: Sun, 26 Jul 2020 19:55:51 +0530 Message-Id: <20200726142553.42545-3-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200726142553.42545-1-shouryashukla.oo@gmail.com> References: <20200726142553.42545-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to 'test_i18ncmp expected actual' to align it with the convention followed by other tests in the test script. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 4439fb7c17..18fefdb0ba 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -183,7 +183,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --cached' " < Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " test_expect_success 'typechanged submodule(submodule->blob), --files' " @@ -193,7 +193,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --files' " > Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -rf sm1 && @@ -204,7 +204,7 @@ test_expect_success 'typechanged submodule(submodule->blob)' " * sm1 $head4(submodule)->$head5(blob): EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -f sm1 && @@ -217,7 +217,7 @@ test_expect_success 'nonexistent commit' " Warn: sm1 doesn't contain commit $head4_full EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " commit_file From patchwork Sun Jul 26 14:25:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11685721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E9428913 for ; Sun, 26 Jul 2020 14:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCB6C206D8 for ; Sun, 26 Jul 2020 14:26:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GhOsL4Wd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgGZO0W (ORCPT ); Sun, 26 Jul 2020 10:26:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgGZO0V (ORCPT ); Sun, 26 Jul 2020 10:26:21 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED11C0619D2 for ; Sun, 26 Jul 2020 07:26:21 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id p3so7976707pgh.3 for ; Sun, 26 Jul 2020 07:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=whHTi2PgYuIlHWf9MWsZT104mUeL4Ulx6vg3RpDG9VI=; b=GhOsL4Wd92qb1d5q3m9LGo40VnDfdKPbY9+cqVZ6i6KWaj8PJbzvbOWeo5YjXlDBNs jHC99nx3SQHJ/E6xuoxk8xNr1puEysProGNWR1kJHLzBu52DJZUKIbGFG7CavmMHtT0u TcwsOLYeGphoowQt62i+Ks1SR06BvGmmdNY2/zKl9PJeLSD0a6OZ/O7T2zAVkX33x0zP D0YH+DfliKlQ58ATwFSVPkI6lVroNZtWnAr/PM5xADEiAbhVynAhU7PaC+9rZpW1zB1+ t8cCpJaXf2FKEo07Jv4oeBJhJL9nKVXXY6A4tspn6h8xyTTEa4SiUXtq/nUJqgeTPcVY OZNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=whHTi2PgYuIlHWf9MWsZT104mUeL4Ulx6vg3RpDG9VI=; b=KZokROkpnNpByqsVSeFrmVhimDJW06D98UEykhTE3H6msItyCJ6M6reZJSmhwyiV7G JkSfCStyqbW4vyAJsbBGKf/rg02yZq32o0A/J6TxyNHH+8GIbKpR+h3HZkVSf8WARKqY xVjPTfuHwiDnUbFUY7N0iVl3D8b9YerLP0hEJO9xnkMdNr2kabu9KPqr5OhjqXSGcL0i zhfh+vWmZ4Vs0ssxGOYcMw1dqaMxE1jvUmcu0xM0RFIZKNHUln4q4vDmyLntI1OZh7Wj wUjGxYjCtzBcpcYEFTFz5nnFB5Xv8wLYsa3R9+vXdA89X9PF84NLLeqZu/I+2wdCwLdm no2w== X-Gm-Message-State: AOAM532lO80ujKEhpY8rDhh3XoSc44i5a0xXoed5wEB+UFlMK18kAz3a g6D4qKr2+tVTsG1O+ACiU6wiQZNGfCY= X-Google-Smtp-Source: ABdhPJyY1Jbfb+vFl1PncWI1WP4+yewLprKNDx0EKe8WK/o/D/1oQCv/u3vK658c/+l0ooUi/V9U6A== X-Received: by 2002:aa7:93c3:: with SMTP id y3mr16488523pff.206.1595773580714; Sun, 26 Jul 2020 07:26:20 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.48]) by smtp.gmail.com with ESMTPSA id p11sm11278908pjb.3.2020.07.26.07.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 07:26:19 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, peff@peff.net, Shourya Shukla , Christian Couder , Kaartic Sivaraam Subject: [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Date: Sun, 26 Jul 2020 19:55:52 +0530 Message-Id: <20200726142553.42545-4-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200726142553.42545-1-shouryashukla.oo@gmail.com> References: <20200726142553.42545-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The '--for-status' test got its expected output from stdin. This is inconsistent with the other tests in the test script which get their expected output from a file named 'expected'. So, change the syntax of the '--for-status' test for uniformity. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 18fefdb0ba..145914cd5a 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -285,13 +285,14 @@ EOF test_expect_success '--for-status' " git submodule summary --for-status HEAD^ >actual && - test_i18ncmp actual - <expected <<-EOF && * sm1 $head6...0000000: * sm2 0000000...$head7 (2): > Add foo9 EOF + test_i18ncmp expected actual " test_expect_success 'fail when using --files together with --cached' " From patchwork Sun Jul 26 14:25:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11685723 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40660913 for ; Sun, 26 Jul 2020 14:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25FCF20714 for ; Sun, 26 Jul 2020 14:26:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hDEWeUqe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgGZO0Z (ORCPT ); Sun, 26 Jul 2020 10:26:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgGZO0Y (ORCPT ); Sun, 26 Jul 2020 10:26:24 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEAA0C0619D2 for ; Sun, 26 Jul 2020 07:26:24 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id n5so7975903pgf.7 for ; Sun, 26 Jul 2020 07:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CzQP0fpTEenofZBakSUNThJaAXN5CPnFNEIP1yxLOdU=; b=hDEWeUqenThsKdGayjAIPv1tbxkGPIj0XxSNVBSV1U1t5dumPXE/i41p6AFexEPuz1 lAKmtuvi3Mzkf0Gov9nCTlz2cWX0ExQFzUY/SNTlTVQzQ9neAHfWQq9/G54AKlOwRaDQ UhzRpdeb5Cg5uAJ+EolB+PHkAwuJs4O357drWhO/2UVxTTkmzFwvTPc0gp7ZVDoWBSQd NSZq8ijHskgZ78hyFmGuW/Zkdf7tQ6gknsv+QTOOSwTq/kZtIYwa3qMEWQHIyAcdZH5J Oy+YdbXpW/ON0GaE1q7cRWk7aloiIGQE4Pz76GKWKigmmh5RLSzzjwzlTj9s2Wr6/JUE MBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CzQP0fpTEenofZBakSUNThJaAXN5CPnFNEIP1yxLOdU=; b=tXVSEMl40hs+/CADRlR/MuOA1XuNyAuSDBAZgdSkUcsyGCTdFoUOKWqIszb8rIOFBS yhwRElf+gjY0T7fZA8bEnrOZaiXXGx5/nvdsFMpkaEuQokCSgjVLzl8UUozmhV+G/Ts5 IL9nFVs8W/tjzMlTYVez5RGsTDs/S0s3rX9HKb/aWNPqTt7YFXRlR7RfVeWIiZt4C27u 20gommQVMhLPEmqCyhfTYfB22JTPEhGyqS8Ewai63APvqvRB2oZPAesNBytC5InENJNL 9yheQqACra4Jjcub1IS5m/TxfXlpElswE+Fd14kXHvi/LGlItLrjwT5hgxE/T/7zU3Lz bKbQ== X-Gm-Message-State: AOAM530Ar+mWOX48agGfVOQGICEk2HDKOCaRVcdr3uA4W6kGQ+V/1C50 r3XxEDk5Yp/FYcRP6kj0tMyk72kpbEY= X-Google-Smtp-Source: ABdhPJxW+dCVCLg3dSX2oVZlLiyR0p8YfpLr1iTMg9S/BwK1/G6Q45E6Gwz7p/aM7hn7lZnX1uxZSQ== X-Received: by 2002:a62:7bc9:: with SMTP id w192mr16861862pfc.255.1595773584008; Sun, 26 Jul 2020 07:26:24 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.48]) by smtp.gmail.com with ESMTPSA id p11sm11278908pjb.3.2020.07.26.07.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 07:26:23 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, Johannes.Schindelin@gmx.de, peff@peff.net, Shourya Shukla , Christian Couder , Kaartic Sivaraam Subject: [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Date: Sun, 26 Jul 2020 19:55:53 +0530 Message-Id: <20200726142553.42545-5-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200726142553.42545-1-shouryashukla.oo@gmail.com> References: <20200726142553.42545-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Add a WARNING regarding the usage of 'git add' instead of 'git submodule add' to add submodules to the superproject. Also add a NEEDSWORK regarding the outdated syntax and working of the test, which may need to be improved to obtain better and desired results. While at it, change the word 'test' to 'test script' in the test description to avoid ambiguity. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 145914cd5a..2db4cf5cbf 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -5,8 +5,13 @@ test_description='Summary support for submodules -This test tries to verify the sanity of summary subcommand of git submodule. +This test script tries to verify the sanity of summary subcommand of git submodule. ' +# WARNING: This test script uses 'git add' instead of 'git submodule add' to add +# submodules to the superproject. Some submodule subcommands such as init and +# deinit might not work as expected in this script. + +# NEEDSWORK: This test script is old fashioned and may need a big cleanup. . ./test-lib.sh