From patchwork Thu Oct 18 12:51:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Manszewski X-Patchwork-Id: 10647101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB09617D4 for ; Thu, 18 Oct 2018 12:53:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBA1F28653 for ; Thu, 18 Oct 2018 12:53:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BBD8E2873D; Thu, 18 Oct 2018 12:53:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 159FE28653 for ; Thu, 18 Oct 2018 12:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: Message-Id:In-Reply-To:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1mBZnSl/GUjPATcwgXVlzmEQeaOFYQz/MEqZN9gDWWw=; b=n+kDZSoNI49ClbFNui4v7XTukw ZAWNDdkUcixsM4Y2ffARZeBKbwMm9CkTLcRG5C3LOAtL6ET8thtYH6sN4ERIp6uMChwlBTJvHXmHC 2Ntym/0tgfFiXQfdGUPnaUvLyd6FFnYYHLV56QtNS046pNNMSnZcn4ZeVXjdTyEybsImfUfAOz526 l+EY7dR2Xq63XilNK6zhqjBM5HMPSLruNLV5vmjfMAzPmNQXkKnX5rYVFy6MAeLIi95vvgHMXshTp ib2yUZdI0n1C9It6oqnAgvVL8rn+IXA5SvT5wwGn0wjXhZ5l9Duy4a2tvpDEl9Ikk8AImZr5qwtBd bOfUVMvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gD7o7-0001GZ-9q; Thu, 18 Oct 2018 12:53:43 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gD7ml-0000eK-NU for linux-arm-kernel@lists.infradead.org; Thu, 18 Oct 2018 12:52:23 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181018125210euoutp02cba8c600df370ffdf05637d28db6bea2~etP8s8SYN2864328643euoutp02U for ; Thu, 18 Oct 2018 12:52:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181018125210euoutp02cba8c600df370ffdf05637d28db6bea2~etP8s8SYN2864328643euoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1539867130; bh=9E02YJ4gWL+PlXXstPIqUYWhzDbY8POwv7pBCqjPVIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SV8IQMt96sL+mSmanOQB2YzLVgF2X2dUvx5IFrrDqUQzf/TDInXDnxGbBgyyC4tbo zNqc3zB6pdbbZUcYfVMBNbULKCDwr3mx53VDT464AgvXlZewlf8Pz/AkkCiFMyzx1c uSz3dN5cQebVVftPiS8AQJHC4Bz+U/PbnI+VWEzA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181018125209eucas1p27fa2dc771969ba7beff7048d6e73143c~etP72vwS_3028930289eucas1p2B; Thu, 18 Oct 2018 12:52:09 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 70.BC.04441.9F188CB5; Thu, 18 Oct 2018 13:52:09 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181018125208eucas1p1e78fba86800edc4ceae4bbda95871ea1~etP6-rVKA0658506585eucas1p1y; Thu, 18 Oct 2018 12:52:08 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181018125208eusmtrp244e9552c7eb8443e3b3ac010982631e6~etP6pNYN61293212932eusmtrp2B; Thu, 18 Oct 2018 12:52:08 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-c7-5bc881f999a9 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 94.CA.04128.8F188CB5; Thu, 18 Oct 2018 13:52:08 +0100 (BST) Received: from AMDC2034.DIGITAL.local (unknown [106.120.51.41]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181018125207eusmtip1366519199472d40711b8a5b6ca56ec80~etP5mSVBa2139821398eusmtip1f; Thu, 18 Oct 2018 12:52:07 +0000 (GMT) From: Christoph Manszewski To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 1/2] drm/exynos: decon: Make plane alpha configurable Date: Thu, 18 Oct 2018 14:51:46 +0200 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1539867107-3383-1-git-send-email-c.manszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0iTYRTHefbuvWw0e5sDH1ZZrJJu3ro+UZRCH94vQYlFNShXvUxJl2xq 2YeaM0pNUxeRlLcuatrSNufKRcnmcorkUkNLU2eDUivEa5qkbW7Wt/95zu9//pzDQ2FCBy6m 4hRJrFIhi5cQfK6padYRPJvWLA0z/oKop7oNRzltLRykL6jBkf1VGUAfpkYJVO80k0g7kMdF Q/3tXJTr+o4hh+M5id5pfpDI4OrCUae5kEAFjjcclPvSgqNntj4SPRir46K+2zaACm4PExH+ jK5YBxhDVSbBvJh24kxxyxFm4Kadw9Q+vsrUa19zGLu5h2RuGasAM2EIPMw/yd93jo2PS2GV oftj+LHOL5+xxKL1lzTzIWqQH5gFeBSkd0DHQhOeBfiUkH4CoKnJ5CsmASwyNZPeYgLAxhIX d8nSsPDBR1UAmN39GvyzGLvTFimC3gl7+8YJjxbR6+Cf/KpFCKM7ceh4+GAR8qcZ+K15Gng0 l94AB9V3gTciEH5qy8Q8mudm+t9WLsZBepiEX+v0pKchoFPgTN8PN0S5Gwdhpnmn1+sPR+xG 0qtXwYX6Eo7Xmw5gz2SXb1AegJanWb6F9kLDxxGOZxBGb4I15lDvcyTsmKsmvfP94MefKzzP mFtqTXd9sQKYcV3opYPgd6ORWIodmpjyrcLAOUu570D33QeuGAR5YM29/2GlAFSBADZZlSBn VeEK9mKISpagSlbIQ85eSDAA9zdrnbePvwRTHWesgKaAZJnAydqlQlyWokpNsAJIYRKRYFbd LBUKzslSL7PKC6eVyfGsygpWUlxJgKC8WC8V0nJZEnueZRNZ5VKXQ/HEalAbVhkjHtBFr74m bj3KCT4xvnwsudHKk0sjd+iOuZh5W0GEYEgvb58pfLybKUv0O3R1o62Xn5OW3pTRiVoiotJO bduirz2+Pa7uzh55bjVfWzoaTc2F/WYpzfsOjU4YpanUNlhEuwIPOCliQPQp+8qwYmuQMzrI GHPjkXWtVMJVxcrCN2NKlewvlNw7DGIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t/xu7o/Gk9EG0x7wmxxa905VovecyeZ LDbOWM9qcXz3UkaLK1/fs1nsfLCL3WLS/QksFi/uXWSx6H/8mtni/PkN7BZnm96wW2x6fI3V 4vKuOWwWM87vY7Lo33GQ1WLtkbvsFgs/bmWxuDv5CKPFjMkv2RyEPdbMW8PosWlVJ5vH9m8P WD3mnQz0uN99nMlj85J6j52T9jJ5HN91i92jb8sqRo/Pm+QCuKL0bIryS0tSFTLyi0tslaIN LYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0Mh48usNcMFeloumfXgPjRLkuRk4O CQETif3/r7B2MXJxCAksZZRYf/shO0RCRmLe2T42CFtY4s+1LjaIok+MEi/eLGQFSbAJmErc vvsJrEhEQFni78RVjCBFzAIPWSXeL+wESwgLeEg8P/GNEcRmEVCVeNgwHczmFXCXOHt7CdQ2 OYmb5zqZQWxOoPp7R1eCLRACqnmxYQvrBEa+BYwMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3 MQJja9uxn1t2MHa9Cz7EKMDBqMTD+yD1eLQQa2JZcWXuIUYJDmYlEV7nhhPRQrwpiZVVqUX5 8UWlOanFhxhNgY6ayCwlmpwPjPu8knhDU0NzC0tDc2NzYzMLJXHe8waVUUIC6YklqdmpqQWp RTB9TBycUg2MgnV3J/81nc0+d8K8+1HL2Rq8Jk59lRxnyLRnikVrTyq77SFVzfm/r7G/Lxdp yL/LKvAosi9NzaX+TEDMj/qDL74rr7QKuDM/hOmqYfYlUfblm+RXb9YxqBEJMei4x9fFpbHy mYx0TJxaqsv5IzUlv1KOdV2K/30nxWCpzGL2G7PXMJ8U3LRKiaU4I9FQi7moOBEA7RV+t8MC AAA= Message-Id: <20181018125208eucas1p1e78fba86800edc4ceae4bbda95871ea1~etP6-rVKA0658506585eucas1p1y@eucas1p1.samsung.com> X-CMS-MailID: 20181018125208eucas1p1e78fba86800edc4ceae4bbda95871ea1 X-Msg-Generator: CA X-RootMTR: 20181018125208eucas1p1e78fba86800edc4ceae4bbda95871ea1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181018125208eucas1p1e78fba86800edc4ceae4bbda95871ea1 References: <1539867107-3383-1-git-send-email-c.manszewski@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181018_055219_923383_368F4287 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maarten Lankhorst , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Bartlomiej Zolnierkiewicz , Christoph Manszewski , Gustavo Padovan , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , David Airlie , Kyungmin Park , Kukjin Kim , Andrzej Hajda , Lowry Li , Sean Paul , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The decon hardware supports variable plane alpha. Currently planes are opaque, make this configurable. Tested on TM2 with Exynos 5433 CPU, on top of exynos-drm-next, commit: c530174b90fa Signed-off-by: Christoph Manszewski --- v2 changes: - remove window blend property for the first (0) layer (currently zpos is immutable), - remove unused parameter in decon_win_set_bldmod, - move local variables to decon_win_set_pixfmt, - add alpha parameter in decon_win_set_bldmod, - don't call decon_win_set_bldmod for the first (0) layer, - move decon_win_set_bldmod call to bottom of decon_win_set_pixfmt, drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 33 +++++++++++++++++++++++++++ drivers/gpu/drm/exynos/regs-decon5433.h | 7 ++++++ 2 files changed, 40 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 94529aa82339..2578db16750d 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -84,6 +84,14 @@ static const enum drm_plane_type decon_win_types[WINDOWS_NR] = { [CURSON_WIN] = DRM_PLANE_TYPE_CURSOR, }; +static const unsigned int capabilities[WINDOWS_NR] = { + 0, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND, +}; + static inline void decon_set_bits(struct decon_context *ctx, u32 reg, u32 mask, u32 val) { @@ -259,9 +267,30 @@ static void decon_commit(struct exynos_drm_crtc *crtc) decon_set_bits(ctx, DECON_UPDATE, STANDALONE_UPDATE_F, ~0); } + +static void decon_win_set_bldmod(struct decon_context *ctx, unsigned int win, + unsigned int alpha) +{ + u32 win_alpha = alpha >> 8; + u32 val = 0; + + if (alpha != DRM_BLEND_ALPHA_OPAQUE) { + val = VIDOSD_Wx_ALPHA_R_F(win_alpha) | + VIDOSD_Wx_ALPHA_G_F(win_alpha) | + VIDOSD_Wx_ALPHA_B_F(win_alpha); + decon_set_bits(ctx, DECON_VIDOSDxC(win), + VIDOSDxC_ALPHA0_RGB_MASK, val); + decon_set_bits(ctx, DECON_BLENDCON, BLEND_NEW, BLEND_NEW); + } +} + static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, struct drm_framebuffer *fb) { + struct exynos_drm_plane plane = ctx->planes[win]; + struct exynos_drm_plane_state *state = + to_exynos_plane_state(plane.base.state); + unsigned int alpha = state->base.alpha; unsigned long val; val = readl(ctx->addr + DECON_WINCONx(win)); @@ -288,6 +317,7 @@ static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, val |= WINCONx_BPPMODE_32BPP_A8888; val |= WINCONx_WSWP_F | WINCONx_BLD_PIX_F | WINCONx_ALPHA_SEL_F; val |= WINCONx_BURSTLEN_16WORD; + val |= WINCONx_ALPHA_MUL_F; break; } @@ -307,6 +337,8 @@ static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, } writel(val, ctx->addr + DECON_WINCONx(win)); + if (win > 0) + decon_win_set_bldmod(ctx, win, alpha); } static void decon_shadow_protect(struct decon_context *ctx, bool protect) @@ -561,6 +593,7 @@ static int decon_bind(struct device *dev, struct device *master, void *data) ctx->configs[win].num_pixel_formats = ARRAY_SIZE(decon_formats); ctx->configs[win].zpos = win - ctx->first_win; ctx->configs[win].type = decon_win_types[win]; + ctx->configs[win].capabilities = capabilities[win]; ret = exynos_plane_init(drm_dev, &ctx->planes[win], win, &ctx->configs[win]); diff --git a/drivers/gpu/drm/exynos/regs-decon5433.h b/drivers/gpu/drm/exynos/regs-decon5433.h index 19ad9e47945e..72648bda3142 100644 --- a/drivers/gpu/drm/exynos/regs-decon5433.h +++ b/drivers/gpu/drm/exynos/regs-decon5433.h @@ -104,6 +104,7 @@ #define WINCONx_BURSTLEN_16WORD (0x0 << 10) #define WINCONx_BURSTLEN_8WORD (0x1 << 10) #define WINCONx_BURSTLEN_4WORD (0x2 << 10) +#define WINCONx_ALPHA_MUL_F (1 << 7) #define WINCONx_BLD_PIX_F (1 << 6) #define WINCONx_BPPMODE_MASK (0xf << 2) #define WINCONx_BPPMODE_16BPP_565 (0x5 << 2) @@ -121,6 +122,9 @@ #define SHADOWCON_PROTECT_MASK GENMASK(14, 10) #define SHADOWCON_Wx_PROTECT(n) (1 << (10 + (n))) +/* VIDOSDxC */ +#define VIDOSDxC_ALPHA0_RGB_MASK (0xffffff) + /* VIDOSDxD */ #define VIDOSD_Wx_ALPHA_R_F(n) (((n) & 0xff) << 16) #define VIDOSD_Wx_ALPHA_G_F(n) (((n) & 0xff) << 8) @@ -206,4 +210,7 @@ #define CRCCTRL_CRCEN (0x1 << 0) #define CRCCTRL_MASK (0x7) +/* BLENDCON */ +#define BLEND_NEW (1 << 0) + #endif /* EXYNOS_REGS_DECON5433_H */ From patchwork Thu Oct 18 12:51:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Manszewski X-Patchwork-Id: 10647099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5756117D4 for ; Thu, 18 Oct 2018 12:53:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 479792872A for ; Thu, 18 Oct 2018 12:53:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B06E28791; Thu, 18 Oct 2018 12:53:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE0C82872A for ; Thu, 18 Oct 2018 12:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: Message-Id:In-Reply-To:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=kqOGTf63JZcL87M9Z05RZuQNSj6PAmcuRMk8bY/6Sg8=; b=C+fLiCzU2u+huoFHGxV/digDtw 12XYl3ZD1zJwgjiCD3OUDOtEi8FcE69cO5Wbn1yzNo4AHzSpejLYLsvfiDpU3SMpupnt+6TS2OPkn IwYRPqmOQMmo9/K98IOea3erfzz5iwPi+7R8r/0jxMKgzDaDelmbT0RKdUDuwAoAbY4AP7TDB/9mD tu6SmxDMeztEOvg1mh/JpFf50W90ZJMH1hsGo//DJk7sDvHCEKXADhPZDoJETYoso0eOjNJF2rDuB qSBqAf0hR6F7+cLBTzX66I+35DNUtoWjUhTh2tb5jc4pj6ZXUuxWr+tIPDFSWuf+bsfz5IR2bHg/K G247lUAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gD7nN-0000u6-N7; Thu, 18 Oct 2018 12:52:57 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gD7ml-0000eL-NV for linux-arm-kernel@lists.infradead.org; Thu, 18 Oct 2018 12:52:22 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181018125211euoutp0283d1194aab9920be3a759fb3536b6b3a~etP9CWker2999229992euoutp02G for ; Thu, 18 Oct 2018 12:52:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181018125211euoutp0283d1194aab9920be3a759fb3536b6b3a~etP9CWker2999229992euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1539867131; bh=jSuiCXcApiuEnFxS3MssmQrYHGlUkcGAKWcj/scsU+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FNvtW6+xm5cUfnQVmxvune28iCGC4FmYc47dh3GJMjnC8ixz9lN5D2WpoHPxRnmgW iqAjwSGIp7QVchEqK1YTpB4wEZ8onyff5wqjjwqRi63xy8draRoHgwuXFxP9baTlV7 pnossScGqCcsjoJAtBZbLc9tD7bUx1YLHO+uU6nE= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181018125210eucas1p1994790d83dcfb57e3f28bbbbdb500349~etP8Z-eTa0071600716eucas1p1N; Thu, 18 Oct 2018 12:52:10 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 69.DA.04294.AF188CB5; Thu, 18 Oct 2018 13:52:10 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181018125209eucas1p199f2790a05546e2bbb306e97ee102b51~etP7nkA4R0072400724eucas1p1J; Thu, 18 Oct 2018 12:52:09 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181018125209eusmtrp2cfba1c5c09f3ac75cd302b1b17d528f3~etP7lcvnX1293212932eusmtrp2F; Thu, 18 Oct 2018 12:52:09 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-d8-5bc881fa2edd Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 37.CA.04128.9F188CB5; Thu, 18 Oct 2018 13:52:09 +0100 (BST) Received: from AMDC2034.DIGITAL.local (unknown [106.120.51.41]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181018125208eusmtip18cdebe893952cabf49e8bcc9d6cfb4a0~etP6zKvte2139821398eusmtip1g; Thu, 18 Oct 2018 12:52:08 +0000 (GMT) From: Christoph Manszewski To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 2/2] drm/exynos: decon: Make pixel blend mode configurable Date: Thu, 18 Oct 2018 14:51:47 +0200 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1539867107-3383-1-git-send-email-c.manszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUzMcRzH973fYzfH16+2PsNi1zRCYtjXotiwn9nCZkb9ocNPmR7vuiNs zjN5OmWraHmYp05U51CHVMrV6I6kuHYVrZaSULGap65f8d/r8/6839/PZ599eUpwMhP47fHJ kjZeE6tmlfT9ZwPOWYP7qyKDzX8o4rrjYMgpR7WCFGbmM8T+8Boidf09LClusXEkrdlEk46m VzQ509pFEaezgCM1Bz5xxNJaz5DXtmyWZDpLFORMURlDble4OXL56z2auNMrEMlM/8gu8Rbz cvKQaDEfZ8UH31sYMad6rdh8wq4Q717dJxanPVaIdpuLE09bzUjstfitUUYoF22VYrcbJO3s 0ChlzGnreyaxbNaunp8vOSM6FpCKvHjA86CstZ5NRUpewDcRPK+pRXLRh+BzfzUlF70IHAds aDTiqmtWeFjANxBUZm3+l8gudNGeBovnQ6P7G+thH+wPv86ah5+l8GsGnFcuD5u88Wr40WGl PEzjqXCqXGbAfvDOcXyYvbAITZW5jCcMuJuD7P1XhtdQYQMUNrwYCSyDyi/nGJm9odNu5WSe BH+KLyrk8EEErr76kZdMCMpupdKyKwQsbzuHXPzQftMh3zZblpdCxmET7ZEBj4W33eM9MjWE afczKFlWwbEjguwOgC6rlR0d29HbP3ItEdrevKfla11A8OWzaEKTz/+fdQkhM/KV9Lq4aEk3 N17aGaTTxOn08dFBWxLiLGjomz3/be8rQrafm8sR5pF6jKpFskcKjMagS4krR8BTah/VgLEq UlBt1aTslrQJm7T6WElXjibytNpXdT2nMFLA0ZpkaYckJUra0a6C95pgRDuCT4ZnTDO8PMuZ rUklq55sdK8o8PcNe5HprEtfnBwCUWlihmPd0ymlRnxUWHi3NqzhomnbTPejcEPbk4blM8YZ NxxqrP+wYUHSoNDuIusrSxZ2Yb1XtD7IvXKvb/Oehgh/EsyG5vZ4m1DNzNCQ9l1ZgVWWgNI3 +VZM2vorsJrWxWjmBFJaneYvTRFEBWIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t/xu7o/G09EG/w8LGpxa905VovecyeZ LDbOWM9qcXz3UkaLK1/fs1nsfLCL3WLS/QksFi/uXWSx6H/8mtni/PkN7BZnm96wW2x6fI3V 4vKuOWwWM87vY7Lo33GQ1WLtkbvsFgs/bmWxuDv5CKPFjMkv2RyEPdbMW8PosWlVJ5vH9m8P WD3mnQz0uN99nMlj85J6j52T9jJ5HN91i92jb8sqRo/Pm+QCuKL0bIryS0tSFTLyi0tslaIN LYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0Mvq2PGQtOKhb8f7PBfYGxg61LkZO DgkBE4lbV+4zdTFycQgJLGWUWLPqBTNEQkZi3tk+NghbWOLPtS42iKJPjBLbvk8FK2ITMJW4 ffcTWJGIgLLE34mrGEGKmAUeskq8X9gJlhAW8JVY1DEDzGYRUJXoPbQFrJlXwF2iedUpRogN chI3z3WCxTkFPCTuHV3JCmILAdW82LCFdQIj3wJGhlWMIqmlxbnpucVGesWJucWleel6yfm5 mxiB0bXt2M8tOxi73gUfYhTgYFTi4X2QejxaiDWxrLgy9xCjBAezkgivc8OJaCHelMTKqtSi /Pii0pzU4kOMpkBHTWSWEk3OB0Z+Xkm8oamhuYWlobmxubGZhZI473mDyighgfTEktTs1NSC 1CKYPiYOTqkGRuHLn9eqrz9by6F7PNPtgSLr/vfTL+wJyWK6NvX/w2OFzxIEar0+Na6MX9R0 u3JSzZmUgqq8fcxuAk2ufTIOmTfKTv26NeGvrO/aCSo9x1o/v2G+sb/i8rQXE3mPn+0TmHj4 m8/RbyzeMVtlj5x9Gi01ecZ9szftCyMZhQrN565Z08VunSv/LFiJpTgj0VCLuag4EQD1FojZ xAIAAA== Message-Id: <20181018125209eucas1p199f2790a05546e2bbb306e97ee102b51~etP7nkA4R0072400724eucas1p1J@eucas1p1.samsung.com> X-CMS-MailID: 20181018125209eucas1p199f2790a05546e2bbb306e97ee102b51 X-Msg-Generator: CA X-RootMTR: 20181018125209eucas1p199f2790a05546e2bbb306e97ee102b51 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181018125209eucas1p199f2790a05546e2bbb306e97ee102b51 References: <1539867107-3383-1-git-send-email-c.manszewski@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181018_055219_927839_10FD2A2C X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maarten Lankhorst , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Bartlomiej Zolnierkiewicz , Christoph Manszewski , Gustavo Padovan , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , David Airlie , Kyungmin Park , Kukjin Kim , Andrzej Hajda , Lowry Li , Sean Paul , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Currently blend mode is set accordingly to pixel format. Add pixel blend mode property and make it configurable, by modifying the blend equation. Tested on TM2 with Exynos 5433 CPU, on top of exynos-drm-next, commit: c530174b90fa Signed-off-by: Christoph Manszewski --- v3 changes: - fix compilation errors (previouslsy wrong patch was sent); v2 changes: - add premultiplied mode by setting blending equation accordingly, - remove no longer used blend mode settings from decon_win_set_pixfmt, drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 67 +++++++++++++++++++++++---- drivers/gpu/drm/exynos/regs-decon5433.h | 15 ++++++ 2 files changed, 72 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 2578db16750d..bc080064b6b4 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -86,10 +86,10 @@ static const enum drm_plane_type decon_win_types[WINDOWS_NR] = { static const unsigned int capabilities[WINDOWS_NR] = { 0, - EXYNOS_DRM_PLANE_CAP_WIN_BLEND, - EXYNOS_DRM_PLANE_CAP_WIN_BLEND, - EXYNOS_DRM_PLANE_CAP_WIN_BLEND, - EXYNOS_DRM_PLANE_CAP_WIN_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND | EXYNOS_DRM_PLANE_CAP_PIX_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND | EXYNOS_DRM_PLANE_CAP_PIX_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND | EXYNOS_DRM_PLANE_CAP_PIX_BLEND, + EXYNOS_DRM_PLANE_CAP_WIN_BLEND | EXYNOS_DRM_PLANE_CAP_PIX_BLEND, }; static inline void decon_set_bits(struct decon_context *ctx, u32 reg, u32 mask, @@ -267,13 +267,53 @@ static void decon_commit(struct exynos_drm_crtc *crtc) decon_set_bits(ctx, DECON_UPDATE, STANDALONE_UPDATE_F, ~0); } +static void decon_win_set_bldeq(struct decon_context *ctx, unsigned int win, + unsigned int alpha, unsigned int pixel_alpha) +{ + u32 mask = BLENDERQ_A_FUNC_F(0xf) | BLENDERQ_B_FUNC_F(0xf); + u32 val = 0; + + switch (pixel_alpha) { + case DRM_MODE_BLEND_PIXEL_NONE: + break; + case DRM_MODE_BLEND_COVERAGE: + val |= BLENDERQ_A_FUNC_F(BLENDERQ_ALPHA_A); + val |= BLENDERQ_B_FUNC_F(BLENDERQ_ONE_MINUS_ALPHA_A); + decon_set_bits(ctx, DECON_BLENDERQx(win), mask, val); + break; + case DRM_MODE_BLEND_PREMULTI: + default: + if (alpha != DRM_BLEND_ALPHA_OPAQUE) { + val |= BLENDERQ_A_FUNC_F(BLENDERQ_ALPHA0); + val |= BLENDERQ_B_FUNC_F(BLENDERQ_ONE_MINUS_ALPHA_A); + } else { + val |= BLENDERQ_A_FUNC_F(BLENDERQ_ONE); + val |= BLENDERQ_B_FUNC_F(BLENDERQ_ONE_MINUS_ALPHA_A); + } + decon_set_bits(ctx, DECON_BLENDERQx(win), mask, val); + break; + } +} static void decon_win_set_bldmod(struct decon_context *ctx, unsigned int win, - unsigned int alpha) + unsigned int alpha, unsigned int pixel_alpha) { u32 win_alpha = alpha >> 8; u32 val = 0; + switch (pixel_alpha) { + case DRM_MODE_BLEND_PIXEL_NONE: + break; + case DRM_MODE_BLEND_COVERAGE: + case DRM_MODE_BLEND_PREMULTI: + default: + val |= WINCONx_ALPHA_SEL_F; + val |= WINCONx_BLD_PIX_F; + val |= WINCONx_ALPHA_MUL_F; + break; + } + decon_set_bits(ctx, DECON_WINCONx(win), WINCONx_BLEND_MODE_MASK, val); + if (alpha != DRM_BLEND_ALPHA_OPAQUE) { val = VIDOSD_Wx_ALPHA_R_F(win_alpha) | VIDOSD_Wx_ALPHA_G_F(win_alpha) | @@ -291,8 +331,14 @@ static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, struct exynos_drm_plane_state *state = to_exynos_plane_state(plane.base.state); unsigned int alpha = state->base.alpha; + unsigned int pixel_alpha; unsigned long val; + if (fb->format->has_alpha) + pixel_alpha = state->base.pixel_blend_mode; + else + pixel_alpha = DRM_MODE_BLEND_PIXEL_NONE; + val = readl(ctx->addr + DECON_WINCONx(win)); val &= WINCONx_ENWIN_F; @@ -315,9 +361,8 @@ static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, case DRM_FORMAT_ARGB8888: default: val |= WINCONx_BPPMODE_32BPP_A8888; - val |= WINCONx_WSWP_F | WINCONx_BLD_PIX_F | WINCONx_ALPHA_SEL_F; + val |= WINCONx_WSWP_F; val |= WINCONx_BURSTLEN_16WORD; - val |= WINCONx_ALPHA_MUL_F; break; } @@ -335,10 +380,12 @@ static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win, val &= ~WINCONx_BURSTLEN_MASK; val |= WINCONx_BURSTLEN_8WORD; } + decon_set_bits(ctx, DECON_WINCONx(win), ~WINCONx_BLEND_MODE_MASK, val); - writel(val, ctx->addr + DECON_WINCONx(win)); - if (win > 0) - decon_win_set_bldmod(ctx, win, alpha); + if (win > 0) { + decon_win_set_bldmod(ctx, win, alpha, pixel_alpha); + decon_win_set_bldeq(ctx, win, alpha, pixel_alpha); + } } static void decon_shadow_protect(struct decon_context *ctx, bool protect) diff --git a/drivers/gpu/drm/exynos/regs-decon5433.h b/drivers/gpu/drm/exynos/regs-decon5433.h index 72648bda3142..63db6974bf14 100644 --- a/drivers/gpu/drm/exynos/regs-decon5433.h +++ b/drivers/gpu/drm/exynos/regs-decon5433.h @@ -117,6 +117,7 @@ #define WINCONx_BPPMODE_16BPP_A4444 (0xe << 2) #define WINCONx_ALPHA_SEL_F (1 << 1) #define WINCONx_ENWIN_F (1 << 0) +#define WINCONx_BLEND_MODE_MASK (0xc2) /* SHADOWCON */ #define SHADOWCON_PROTECT_MASK GENMASK(14, 10) @@ -213,4 +214,18 @@ /* BLENDCON */ #define BLEND_NEW (1 << 0) +/* BLENDERQx */ +#define BLENDERQ_ZERO 0x0 +#define BLENDERQ_ONE 0x1 +#define BLENDERQ_ALPHA_A 0x2 +#define BLENDERQ_ONE_MINUS_ALPHA_A 0x3 +#define BLENDERQ_ALPHA0 0x6 +#define BLENDERQ_Q_FUNC_F(n) (n << 18) +#define BLENDERQ_P_FUNC_F(n) (n << 12) +#define BLENDERQ_B_FUNC_F(n) (n << 6) +#define BLENDERQ_A_FUNC_F(n) (n << 0) + +/* BLENDCON */ +#define BLEND_NEW (1 << 0) + #endif /* EXYNOS_REGS_DECON5433_H */