From patchwork Tue Jul 28 17:08:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11689585 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7FE46138C for ; Tue, 28 Jul 2020 17:09:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D55020809 for ; Tue, 28 Jul 2020 17:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956149; bh=VAI8WP8+wW4qJ9tQCB41NOf7v1n5wUijWbIgNFmDwXo=; h=From:To:Cc:Subject:Date:List-ID:From; b=dItPWqrse9uRkrj8cjM1XUNXnMxkCWOPN0QPvJQQnLxY1A7oak3zp0eFxThDVsVXh PD8K2yrW93DMMrlVz9VkdysWRCgw87y8wWNJW2OPdFofQmWbhlpup90tAPL/4iR1af V9vzujM38Ziz5A2cLzzYzZjB6JEGcCmXPDP4bffo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731580AbgG1RJJ (ORCPT ); Tue, 28 Jul 2020 13:09:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:35008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731510AbgG1RJH (ORCPT ); Tue, 28 Jul 2020 13:09:07 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D79B220792; Tue, 28 Jul 2020 17:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956147; bh=VAI8WP8+wW4qJ9tQCB41NOf7v1n5wUijWbIgNFmDwXo=; h=From:To:Cc:Subject:Date:From; b=BVVHKM1hkuYqzDbdJY7kVXUv0ivAY/LK1Dv96e+cQ+PqTB7JE8fjQP0QgWeTqV8Ye yfUgaaDqu/cJ5WTGUXX9j4p3Ux++RApP4b3XtVy93aOP5Sr6phKNzmJwr1lIhyz1Xw LflB5f5oj03w3YvssSPJ5y1jV1y4FETmM78HYmPA= From: Krzysztof Kozlowski To: Joerg Roedel , David Woodhouse , Lu Baolu , Rob Clark , Andy Gross , Bjorn Andersson , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/3] iommu: amd: Fix kerneldoc Date: Tue, 28 Jul 2020 19:08:57 +0200 Message-Id: <20200728170859.28143-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Fix W=1 compile warnings (invalid kerneldoc): drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type' drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- drivers/iommu/amd/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 958050c213f9..4a37169b1b1b 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h) /** * get_highest_supported_ivhd_type - Look up the appropriate IVHD type - * @ivrs Pointer to the IVRS header + * @ivrs: Pointer to the IVRS header * * This function search through all IVDB of the maximum supported IVHD */ @@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu) #define XT_INT_VEC(x) (((x) & 0xFFULL) << 32) #define XT_INT_DEST_HI(x) ((((x) >> 24) & 0xFFULL) << 56) -/** +/* * Setup the IntCapXT registers with interrupt routing information * based on the PCI MSI capability block registers, accessed via * MMIO MSI address low/hi and MSI data registers. From patchwork Tue Jul 28 17:08:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11689587 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F21F138C for ; Tue, 28 Jul 2020 17:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 470B020825 for ; Tue, 28 Jul 2020 17:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956152; bh=UqJi1Cd1ki/EcIWIXcChXTjP/XpNmsjxdc58Fdu+XQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q51dKxqiOfGshVaxsXPSaPUhP3vNOznybBepb1OGEn5GuRTFYGHpHBuhcKChxgQkG PxQ4BXs9xryqeawrpRqO0yVFYWNirI9kS7RV4C0ftHeoDCbGfVo7U1KZ3l4+Y9/WgK +q6NWD0zGNqWBfXJgVQuJm//fDh5ATcVz9uCI/u0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731879AbgG1RJL (ORCPT ); Tue, 28 Jul 2020 13:09:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:35040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731510AbgG1RJK (ORCPT ); Tue, 28 Jul 2020 13:09:10 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDD73207F5; Tue, 28 Jul 2020 17:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956149; bh=UqJi1Cd1ki/EcIWIXcChXTjP/XpNmsjxdc58Fdu+XQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fs/MEgnTSxxCi5jA3YzqQTDPVc1zsYyTyPewoVynXtXG436QcvHVNBES/dt+LX63h nRyXeUxTKE1IKYMh0KuPqyHnRkagxVZsSKrMRdVTm4q4wZJSXhaxpldwOKBOERXu1c 1Qmu0h6gsj3CVgNTM/6t8h91s00U9MemBEDjf1Nk= From: Krzysztof Kozlowski To: Joerg Roedel , David Woodhouse , Lu Baolu , Rob Clark , Andy Gross , Bjorn Andersson , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment Date: Tue, 28 Jul 2020 19:08:58 +0200 Message-Id: <20200728170859.28143-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200728170859.28143-1-krzk@kernel.org> References: <20200728170859.28143-1-krzk@kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Fix W=1 compile warnings (invalid kerneldoc): drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c index 93e6345f3414..ba47edf03941 100644 --- a/drivers/iommu/intel/dmar.c +++ b/drivers/iommu/intel/dmar.c @@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd) return NULL; } -/** +/* * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition * structure which uniquely represent one DMA remapping hardware unit * present in the platform From patchwork Tue Jul 28 17:08:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11689589 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B3C40138C for ; Tue, 28 Jul 2020 17:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A4F120825 for ; Tue, 28 Jul 2020 17:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956157; bh=drzFY1Bjn9Jmo6o8Q37vv3qLVrJCJ/FYL0oLYPswpPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lkVTnLOGiUYLyVkZ0QppqSDfDwr6uDnRS8yJLOM4W50Z23J24WG8pJhQn+RbFfX4b kJDY/wW1v8U432HG9nrYl3x14OEEiiZhwHMA8JdvL3zU5FrOKWQ5Fsyk6kqR5z139H 5Lz1Sa2A5DRn7K00Kcz9VNcp9scbtlISAOJYwu6I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731796AbgG1RJO (ORCPT ); Tue, 28 Jul 2020 13:09:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:35120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731510AbgG1RJN (ORCPT ); Tue, 28 Jul 2020 13:09:13 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 896DF20829; Tue, 28 Jul 2020 17:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595956152; bh=drzFY1Bjn9Jmo6o8Q37vv3qLVrJCJ/FYL0oLYPswpPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HDQX7NDfUea8PQ/0hXDSjnCKNpNdv8wrQq+4T/lFsUziwoz4UaPmIA+VPrlZJ+uRD oPaoWk55haQlQ70UawEEt4SHDgUvEsbDKPxHbB9woQyUDDiZBcRyrWPeP0jY/yiHAC Fu8BWv99FyqS14VZ6X+3cgeHrSrVeFftNfidcy/Q= From: Krzysztof Kozlowski To: Joerg Roedel , David Woodhouse , Lu Baolu , Rob Clark , Andy Gross , Bjorn Andersson , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Date: Tue, 28 Jul 2020 19:08:59 +0200 Message-Id: <20200728170859.28143-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200728170859.28143-1-krzk@kernel.org> References: <20200728170859.28143-1-krzk@kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The of_device_id is included unconditionally by of.h header and used in the driver as well. Remove of_match_ptr to fix W=1 compile test warning with !CONFIG_OF: drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=] 910 | static const struct of_device_id qcom_iommu_of_match[] = { Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson --- drivers/iommu/qcom_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c index af6bec3ace00..9535a6af7553 100644 --- a/drivers/iommu/qcom_iommu.c +++ b/drivers/iommu/qcom_iommu.c @@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = { static struct platform_driver qcom_iommu_ctx_driver = { .driver = { .name = "qcom-iommu-ctx", - .of_match_table = of_match_ptr(ctx_of_match), + .of_match_table = ctx_of_match, }, .probe = qcom_iommu_ctx_probe, .remove = qcom_iommu_ctx_remove, @@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = { static struct platform_driver qcom_iommu_driver = { .driver = { .name = "qcom-iommu", - .of_match_table = of_match_ptr(qcom_iommu_of_match), + .of_match_table = qcom_iommu_of_match, .pm = &qcom_iommu_pm_ops, }, .probe = qcom_iommu_device_probe,