From patchwork Thu Oct 18 22:45:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 17EBD1508 for ; Thu, 18 Oct 2018 22:46:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09BF028C5A for ; Thu, 18 Oct 2018 22:46:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F234928C62; Thu, 18 Oct 2018 22:46:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DBAD28C5A for ; Thu, 18 Oct 2018 22:46:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbeJSGt0 (ORCPT ); Fri, 19 Oct 2018 02:49:26 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:58841 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbeJSGt0 (ORCPT ); Fri, 19 Oct 2018 02:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=+HTUPK3VyITRhe/XxdkOD6mNf8Id95Qr/TGohyalDlE=; b=p2rTliNf1Cun +QmKnBpOmpUtpxzl45X2Bs4KkpWcYCxNhVnSA+Y4JcK00YVtvkXrrsD0m6mFUQ1vrN55npjT6FzIe eM3BeWLdK4IRuICtbE010gNNzq5ko20TcGLKkA7VQlOZvwyLyTnnkpe7qcSk4Qo5clih8i7ZC0piV Nf+lSWCztHtOrIpgCmGS4UH2sfQV80C/V0aMy9UdTpF1YoINPThoHowqVNjVqsbqSLy/3ZfGjjORh zTgbJTRX616Mh0+X4o2n9jPUj1F5b0jxrfpV/VlbtZXdYAYmNCFYIFrZvY+Z7JUmy1iT9PIG5imvG /1maT9IF/cslX+0zxhgyhg==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3T-0009iq-La; Fri, 19 Oct 2018 00:46:12 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 6A2B2C0906; Fri, 19 Oct 2018 00:45:56 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 1/7] qla2xxx: Modify fall-through annotations Date: Thu, 18 Oct 2018 15:45:40 -0700 Message-Id: <20181018224546.189268-2-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.14) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5jyEUE4YhlAkQ22ZlbVdDiN602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkXK7hkc l6fFT7uw+/s/67N7+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+gShc8n9XPxGt9u39SToPuN89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJPaY+bzZyDlQytCgKDw2Ue1fKOeutt3E0t3O1NFV5940ZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that the compiler complains about missing fall-through annotations when building with W=1. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index c72d8012fe2a..2ccf9f190c68 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -680,7 +680,7 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, fcport); break; } - /* drop through */ + /* fall through */ default: if (fcport_is_smaller(fcport)) { /* local adapter is bigger */ diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 3015f1bbcf1a..902f9c25da2e 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -4540,7 +4540,7 @@ static int qlt_issue_task_mgmt(struct fc_port *sess, u64 lun, case QLA_TGT_CLEAR_TS: case QLA_TGT_ABORT_TS: abort_cmds_for_lun(vha, lun, a->u.isp24.fcp_hdr.s_id); - /* drop through */ + /* fall through */ case QLA_TGT_CLEAR_ACA: h = qlt_find_qphint(vha, mcmd->unpacked_lun); mcmd->qpair = h->qpair; From patchwork Thu Oct 18 22:45:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6593513B0 for ; Thu, 18 Oct 2018 22:46:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5765928C5A for ; Thu, 18 Oct 2018 22:46:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B44B28C62; Thu, 18 Oct 2018 22:46:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABF8228C5A for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbeJSGt0 (ORCPT ); Fri, 19 Oct 2018 02:49:26 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:40159 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbeJSGt0 (ORCPT ); Fri, 19 Oct 2018 02:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=3Y2NKKuku3DkmFcr9n+Hr2/82zwT8EtuFWo4CNIr0lY=; b=SKNP3SJ0LBe1 IQ4xanIYhK+8rZyOFy707MaPX+tEUQqric1l+o53L2EHCOY0W4u5ce8tRb4Mt5mnVZQLMMvmEQSgT /oD3TtZOTZhQ/CxLHG2TT/T3M9RJ/Mkodwbff8R2O65cljtxXbO+J0qN0VCTM6h0ukdORsPGOH4nP rWMRxtyrqefw4Fy9Al8xBRuigE78+H+5KcfAc04bd7+fGOQXOy30MG3Bm7suPiarlKh97iYyfonIi l4ZtS7QFa1I4t/hObZ4C23smmg9Pc8dUvN4bfFJlnb20WD0iNkWeaF1M+fOQ6+reoe+uevjWEMQCk FfjP2u5orXjquk93w3Zm9Q==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3T-0009j1-KL; Fri, 19 Oct 2018 00:46:12 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id D75CEC0926; Fri, 19 Oct 2018 00:45:57 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 2/7] qla2xxx: Improve several kernel-doc headers Date: Thu, 18 Oct 2018 15:45:41 -0700 Message-Id: <20181018224546.189268-3-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.02) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5hscO9Y3Zh53+h6z08eaqxJ602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkWiBYfn X20lgm+OA0Q05Esr+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+3bQ7qx5ugAzGRUauicufmt89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJPaY+bzZyDlQytCgKDw2Ue1vDBY+kWE5C2rBkBTXCXSFZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that complaints about kernel-doc headers are reported when building with W=1. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- drivers/scsi/qla2xxx/qla_isr.c | 6 +++--- drivers/scsi/qla2xxx/qla_mbx.c | 6 +++--- drivers/scsi/qla2xxx/qla_mr.c | 6 +++--- drivers/scsi/qla2xxx/qla_nx.c | 2 +- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- drivers/scsi/qla2xxx/qla_sup.c | 2 +- drivers/scsi/qla2xxx/qla_target.c | 6 +++--- 8 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 86fb8b21aa71..032635321ad6 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -1195,8 +1195,8 @@ qla24xx_walk_and_build_prot_sglist(struct qla_hw_data *ha, srb_t *sp, * @sp: SRB command to process * @cmd_pkt: Command type 3 IOCB * @tot_dsds: Total number of segments to transfer - * @tot_prot_dsds: - * @fw_prot_opts: + * @tot_prot_dsds: Total number of segments with protection information + * @fw_prot_opts: Protection options to be passed to firmware */ inline int qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct cmd_type_crc_2 *cmd_pkt, diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index d73b04e40590..30d3090842f8 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -25,7 +25,7 @@ static int qla2x00_error_entry(scsi_qla_host_t *, struct rsp_que *, /** * qla2100_intr_handler() - Process interrupts for the ISP2100 and ISP2200. - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. @@ -144,7 +144,7 @@ qla2x00_check_reg16_for_disconnect(scsi_qla_host_t *vha, uint16_t reg) /** * qla2300_intr_handler() - Process interrupts for the ISP23xx and ISP63xx. - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. @@ -3109,7 +3109,7 @@ qla2xxx_check_risc_status(scsi_qla_host_t *vha) /** * qla24xx_intr_handler() - Process interrupts for the ISP23xx and ISP24xx. - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index bd8c86aeccc2..38ef06d613ba 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -3479,9 +3479,9 @@ qla8044_read_serdes_word(scsi_qla_host_t *vha, uint32_t addr, uint32_t *data) /** * qla2x00_set_serdes_params() - * @vha: HA context - * @sw_em_1g: - * @sw_em_2g: - * @sw_em_4g: + * @sw_em_1g: serial link options + * @sw_em_2g: serial link options + * @sw_em_4g: serial link options * * Returns */ diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 521a51370554..2d96f3b7e3e3 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2624,7 +2624,7 @@ qlafx00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) * qlafx00_multistatus_entry() - Process Multi response queue entries. * @vha: SCSI driver HA context * @rsp: response queue - * @pkt: + * @pkt: received packet */ static void qlafx00_multistatus_entry(struct scsi_qla_host *vha, @@ -2867,7 +2867,7 @@ qlafx00_async_event(scsi_qla_host_t *vha) /** * qlafx00x_mbx_completion() - Process mailbox command completions. * @vha: SCSI driver HA context - * @mb0: + * @mb0: value to be written into mailbox register 0 */ static void qlafx00_mbx_completion(scsi_qla_host_t *vha, uint32_t mb0) @@ -2893,7 +2893,7 @@ qlafx00_mbx_completion(scsi_qla_host_t *vha, uint32_t mb0) /** * qlafx00_intr_handler() - Process interrupts for the ISPFX00. - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index de2bc78449e7..8dbe94c52f65 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c @@ -2010,7 +2010,7 @@ qla82xx_mbx_completion(scsi_qla_host_t *vha, uint16_t mb0) /** * qla82xx_intr_handler() - Process interrupts for the ISP23xx and ISP63xx. - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index 3a2b0282df14..fe856b602e03 100644 --- a/drivers/scsi/qla2xxx/qla_nx2.c +++ b/drivers/scsi/qla2xxx/qla_nx2.c @@ -3878,7 +3878,7 @@ qla8044_write_optrom_data(struct scsi_qla_host *vha, uint8_t *buf, #define PF_BITS_MASK (0xF << 16) /** * qla8044_intr_handler() - Process interrupts for the ISP8044 - * @irq: + * @irq: interrupt number * @dev_id: SCSI driver HA context * * Called by system whenever the host adapter generates an interrupt. diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index 4499c787165f..2a3055c799fb 100644 --- a/drivers/scsi/qla2xxx/qla_sup.c +++ b/drivers/scsi/qla2xxx/qla_sup.c @@ -2229,7 +2229,7 @@ qla2x00_erase_flash_sector(struct qla_hw_data *ha, uint32_t addr, /** * qla2x00_get_flash_manufacturer() - Read manufacturer ID from flash chip. - * @ha: + * @ha: host adapter * @man_id: Flash manufacturer ID * @flash_id: Flash ID */ diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 902f9c25da2e..ad7612b80d91 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6598,9 +6598,9 @@ static void qlt_lport_dump(struct scsi_qla_host *vha, u64 wwpn, * qla_tgt_lport_register - register lport with external module * * @target_lport_ptr: pointer for tcm_qla2xxx specific lport data - * @phys_wwpn: - * @npiv_wwpn: - * @npiv_wwnn: + * @phys_wwpn: physical port WWPN + * @npiv_wwpn: NPIV WWPN + * @npiv_wwnn: NPIV WWNN * @callback: lport initialization callback for tcm_qla2xxx code */ int qlt_lport_register(void *target_lport_ptr, u64 phys_wwpn, From patchwork Thu Oct 18 22:45:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B857B13B0 for ; Thu, 18 Oct 2018 22:46:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7EE928C5A for ; Thu, 18 Oct 2018 22:46:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9946428C62; Thu, 18 Oct 2018 22:46:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EF1628C5A for ; Thu, 18 Oct 2018 22:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbeJSGtT (ORCPT ); Fri, 19 Oct 2018 02:49:19 -0400 Received: from out002.mailprotect.be ([83.217.72.86]:53247 "EHLO out002.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbeJSGtT (ORCPT ); Fri, 19 Oct 2018 02:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=ztgvedYg7cU1QREViOuSvAZQ3JJTGaiPYbEgkVxemnw=; b=kDehyJEXNeyx imYnF+BsJ1hcPCo9A9auKOCXREuzmGRWx8kyywr3HhJVSbMrivcqtHGTRiyeXCKPkIGo8wfkiqpVd aSycOLff1Knb4yC34zX9TBSu5py9h3RpXP5mtuzs5DU/LB+waLGQl4uhwvM4MVh0WUnm1gokIz6QA +esfQr9CqJq3oDSYfp4Y/7OWBwRGWDKkZ2BwtHO3TJeDEtm75qeM6S2GFUKPF7QGOKns6hSu0ARJR pLDBShgV2UIVtMsqiNXQexSj9ZUCC1I0e7wJBCaQ9declnzDHiiLVAFx0CMR2RXrDgPRHEvCTwQYr VQSN/zuzRZrPXrB5MiOU+g==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out002.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3L-0008fk-3e; Fri, 19 Oct 2018 00:46:03 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 60BF8C0948; Fri, 19 Oct 2018 00:45:59 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 3/7] qla2xxx: Declare local functions 'static' Date: Thu, 18 Oct 2018 15:45:42 -0700 Message-Id: <20181018224546.189268-4-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.02) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5hq7u5XZzfTHWGRUhdxbRtd602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVN0CAq 1/XTFB452Wkf2lRT+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwNFyFWesvfWEQ3buhdR df3sTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfKfP/aig7ylqqMl +wLuapTnPj0Fx64kQdp6PxbKaWC95N89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJPdFiZXDPPOvxmoG814Q1b/tXc922MPsys4rW2NdjLUaZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that the compiler complains about missing declarations when building with W=1. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 2ccf9f190c68..6fe20c27acc1 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -425,7 +425,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) __qla24xx_handle_gpdb_event(vha, ea); } -int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) +static int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) { struct qla_work_evt *e; @@ -1551,7 +1551,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, } -void qla_handle_els_plogi_done(scsi_qla_host_t *vha, struct event_arg *ea) +static void qla_handle_els_plogi_done(scsi_qla_host_t *vha, + struct event_arg *ea) { ql_dbg(ql_dbg_disc, vha, 0x2118, "%s %d %8phC post PRLI\n", From patchwork Thu Oct 18 22:45:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 875161508 for ; Thu, 18 Oct 2018 22:46:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75E8D28C5A for ; Thu, 18 Oct 2018 22:46:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A13428C66; Thu, 18 Oct 2018 22:46:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C69F28C5A for ; Thu, 18 Oct 2018 22:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbeJSGte (ORCPT ); Fri, 19 Oct 2018 02:49:34 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:53991 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727173AbeJSGtd (ORCPT ); Fri, 19 Oct 2018 02:49:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=HSDQF8Po28Tb5jpSPKXTe0LRTUObFD7BMQ1dbax4uH0=; b=e83QTl9uqy27 ep8g+P+NUKXuF0KYT4Wh4x/LS304J8BP/jsYu9PJlJ83b/Dl+DaksBaLHiBFUDODeBJ4PF1baAvg+ vdRksep/kWYGcq7oMI0icxKMeEBrqoyOiHByp7DENLdDMHvSq2eS0PyWFifbAVY4QqfjfvKXWl9MK A1sdQp+fx1EkgDgJHfp01t0xtD44lOxNCmC0CQYVe5cT93D33FXtoGquAvLYRnFp0+fTtGJx9Lom7 bHAP03qEappirCwyCZcjCK1j0kfFqMZ3lvXXR0dteVyBWNYsIPlIJBc/eL6lpWL/oXfjtM+4DYoiX SCmCNiZKZQQXq4XPmLpTOg==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3X-0009jL-Bu; Fri, 19 Oct 2018 00:46:15 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id C8483C0979; Fri, 19 Oct 2018 00:46:00 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 4/7] qla2xxx: Make qla2x00_sysfs_write_nvram() easier to analyze Date: Thu, 18 Oct 2018 15:45:43 -0700 Message-Id: <20181018224546.189268-5-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.21) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5pBF+DCcHhjQm3TIH1IkH0h602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVQCytY OoZVxl+F53A8HuQL+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+g/bU1kD8gbEZjO3jD3rU5N89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJJw6ErNMl63LYQLOtoyJp6XzpYaOzLTDpQ7teUJWfJbRZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Modify the unlock statement such that it becomes easier for static analyzers to analyze it. This patch does not change any functionality. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index b28f159fdaee..0bb9ac6ece92 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -218,7 +218,7 @@ qla2x00_sysfs_write_nvram(struct file *filp, struct kobject *kobj, mutex_lock(&ha->optrom_mutex); if (qla2x00_chip_is_down(vha)) { - mutex_unlock(&vha->hw->optrom_mutex); + mutex_unlock(&ha->optrom_mutex); return -EAGAIN; } From patchwork Thu Oct 18 22:45:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C75C1508 for ; Thu, 18 Oct 2018 22:46:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C92428C5A for ; Thu, 18 Oct 2018 22:46:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF5D828C66; Thu, 18 Oct 2018 22:46:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96B0128C5A for ; Thu, 18 Oct 2018 22:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbeJSGta (ORCPT ); Fri, 19 Oct 2018 02:49:30 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:37679 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbeJSGta (ORCPT ); Fri, 19 Oct 2018 02:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=vgbhXTq96HlVN9zWQCkWg2PwwVQZrTn5zGhPcCEpfBE=; b=KZZp9zew0WBR OrMJUSa0jmIGfXNjeq2X6WQ5I9CUknWRr+6V2y4rP9Lmr2wA1L+xN5yNscsy+FP9QWrD49RRKCKvQ UZYvD7bNcgbDAn5KoxbheEAAVjjkleqvZ1dbjGiZs6xGq6Ig1kbXNzcVdvoFtkEA39Tx2WdpdNnIq nH5MzpDZevywobZvLdldlsIIB4wHPKFaEzhSgbrqvT2rHZb7xMAl5y+CjwppRWA6AeDrQC0ddy1Oh x8AGl42VgB6DAuBQKTH6w+foksuV2h8/Zx3q9BgMf70g7Wf3vyKRkx2gM4Uliko0be1lXq+nd5avW GZlI1uDCva2wZ4umPnio/w==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3X-0009jM-Ak; Fri, 19 Oct 2018 00:46:15 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 5E092C0993; Fri, 19 Oct 2018 00:46:02 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 5/7] qla2xxx: Remove a set-but-not-used variable Date: Thu, 18 Oct 2018 15:45:44 -0700 Message-Id: <20181018224546.189268-6-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5qrTT/1HV4pNzy6z2+7YnBh602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkWaQAH9 W102tjm0gaHhlCQ8+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+U+RR6uCQH291q2Ik6Ndmp989OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJJw6ErNMl63LYQLOtoyJp6UYvz3GigAx0DI6Pv7crwp7ZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch does not change any functionality. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index dba672f87cb2..01607d2f2c34 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1749,7 +1749,7 @@ qla2x00_loop_reset(scsi_qla_host_t *vha) static void __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res) { - int cnt, status; + int cnt; unsigned long flags; srb_t *sp; scsi_qla_host_t *vha = qp->vha; @@ -1799,8 +1799,8 @@ __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res) if (!sp_get(sp)) { spin_unlock_irqrestore (qp->qp_lock_ptr, flags); - status = qla2xxx_eh_abort( - GET_CMD_SP(sp)); + qla2xxx_eh_abort( + GET_CMD_SP(sp)); spin_lock_irqsave (qp->qp_lock_ptr, flags); } From patchwork Thu Oct 18 22:45:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A8E6A13B0 for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96D0D28C5A for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8771028C66; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F0B128C5A for ; Thu, 18 Oct 2018 22:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbeJSGtc (ORCPT ); Fri, 19 Oct 2018 02:49:32 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:39223 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbeJSGtc (ORCPT ); Fri, 19 Oct 2018 02:49:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=iVeCb+B4S4OcYuyQhTo+ebxPJWOgp4P+D6TXxE0JHC8=; b=lSGQn1nWoPid NrS9Jz8z8GXQWHdoNg94wJHsJfNZP5RwWtmNQU0ZmLpKe+q5TSM1E8gWd4qS6HK67rTK8jjBS52Z+ zCCVbSLzwZ9ku+dIgfMqlLjJTjr0gAOdeYLinR9FKXcw9zvQqy9LUREEh032CYPoWe/qM6ck4rFo6 cLqEPKK2Wd0dfqj1uVgH2ucDK88lcBzjOrxbQbo++lGPzJHDI2cT4OIQhVajnO1D23SDvXq28dj5w zRko2DrA1lKPJrBWbcy9C5hsRcJ+f3krG1DgcAjZJtWGgi+hhGaNWuOf7Bl1jG6Y+l4IWW+x3nhH/ pxmfNhyeSMqVoewysTWDyg==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3Z-0009jX-UZ; Fri, 19 Oct 2018 00:46:18 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id C5C1DC0948; Fri, 19 Oct 2018 00:46:03 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 6/7] qla2xxx: Make sure that qlafx00_ioctl_iosb_entry() initializes 'res' Date: Thu, 18 Oct 2018 15:45:45 -0700 Message-Id: <20181018224546.189268-7-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.29) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5tU5qcUyt3FD+g3KoBeoNxh602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVIB/By MNbUX7EZfs40fNTJ+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+wccV1Pe/GGVvsrigw1B7Vd89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJOadjlR3ghD00hMB10wfWyGCr6CrA4gNGHQiTbQ5a4CNZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Only one of the two code paths in qlafx00_ioctl_iosb_entry() initializes the variable 'res'. Make sure that 'res' is initialized before sp->done(sp, res) is called. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index 2d96f3b7e3e3..b8f967e61891 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2212,7 +2212,7 @@ qlafx00_ioctl_iosb_entry(scsi_qla_host_t *vha, struct req_que *req, struct bsg_job *bsg_job; struct fc_bsg_reply *bsg_reply; struct srb_iocb *iocb_job; - int res; + int res = 0; struct qla_mt_iocb_rsp_fx00 fstatus; uint8_t *fw_sts_ptr; From patchwork Thu Oct 18 22:45:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10648349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A0761508 for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A90F28C5A for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D6EE28C62; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 134EA28C5A for ; Thu, 18 Oct 2018 22:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbeJSGtZ (ORCPT ); Fri, 19 Oct 2018 02:49:25 -0400 Received: from com-out001.mailprotect.be ([83.217.72.83]:56919 "EHLO com-out001.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbeJSGtZ (ORCPT ); Fri, 19 Oct 2018 02:49:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=tdRh4NEUros+Wwc0hjntWnSJNSQiwlVAyDhDfvP+sxU=; b=LosyWZBxuA4T L3gombY7YpBfXB3b54penHTrwVchpcuuzmHAtMCJz0f0pG08boABY86kEnRpeBsk0DUjX1hht0ZH5 GXCxp91Tlc6OuZJaCjxJbAJJacM0quR4YKzNnDPXU+7/9mI3GX5Swnis1vF6jJ7S4LvC9R6Oy4U71 jziqmJQuPW40evsVBkZT8KWpW1c5DI6NLan2cq8B7XxPSiE1OnizmZLip0aoIeYS7JmOfpqXDK6bc WdULZ+9OanPIv7B47OiRDQZS1NTeIxJcci5eW+yOuB+j/CwmEMj2vnLwNRghvNu1M77ZWFgZ76Vz4 4ppCyMbyqHLluOu4BTj3VA==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gDH3S-0009jv-E9; Fri, 19 Oct 2018 00:46:11 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 3930BC09A6; Fri, 19 Oct 2018 00:46:05 +0200 (CEST) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Himanshu Madhani Subject: [PATCH 7/7] qla2xxx: Remove two arguments from qlafx00_error_entry() Date: Thu, 18 Oct 2018 15:45:46 -0700 Message-Id: <20181018224546.189268-8-bvanassche@acm.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181018224546.189268-1-bvanassche@acm.org> References: <20181018224546.189268-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.11) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5nRcTsuFHExsE2I/na15xqF602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTarjontMPw7f3NqDIrNV7pphXnBH4p08Ft9j1x3N/nLO18D Od3nQsC62ajtEOV/fohsGOPFT2pee2Xw2nnaC+uuZzUV2SSE877X6ek5VphlU4lE4xwlSMNZQReC h1BkhSvwYJg8Zt8D44lX+/mPOqzZYqVFg3z5lbRdfQAf/u3PyUGlz8CJSOMrvzx9TVg3RkVgf1NI Xmo6OyQUiwsS5y8c+yiBn1++U1P6gFCnKfjMMqxWoq/FM2XXTzjR7Qr2fwMMkuAhrQsaE4EFItc3 F3UBTqn1gyiGMs00+yjdEjhJY611qc5TTtnihBuF8qtjLQ8qKjBgnhkDdZyt5hDIfQWKNv5BuPUK FL0zB1N5cuImBZB4RMjNrYhKfl0SAFHN1M5EDBffVZVjmVaNbG4ZJG7Ff0+2U06FHKGGFNW71s0u W88WrhLmFL/jnsAXfPxLyzjzxdxlFfinQQaq5wl/I9BovCrJPmnnTHzVkpybMK7ZTTCS3QnTZ9ql TgOmsfE7BE1z8Ne0ck6P4ivKdWmRJx+gQYzna0TUPxp4FPQssSWHj7R1IoyVcpAXxfUeXJw8PSKZ yxi/aFboTUAaA09dklP/aIfVaCHpEB6cFH6WJxE4ZuXQEFqM1vccOzPcPFsPwfK8UcVk6hjRxQmD Dj6E/uD+G6wLiuvpztxcYbTepspBcN89OVhGIz4XNIPo1k/OgsY0wu7hsg0KKTp14lShhltI/LkL W6eiryQjwVOtGwt2QIsEMysPur9wmiDBurOy6iSG6b/fgtlHDkX18Z9N16MyYEBkrhhCSE3l+hqP hVgOJA00R26L1DocNWUJ9oSlIXFut9mbGHk9HOXus3wbXZI+ZuM7jUXIESohoO51xWmU8czCEOxz /0BeOl9RtvpQQNIAY8GGzvEuQ/UbbinoS2ia9cWG5T+iUuLiPEkCpP4nehmok11u89pTKgJ27pjs IdJdnSA6TSRMmUFdTg/ucnvNo0E7UOWuGn2ne/goKp9SNIalL4LoE8AgSzw+KJWjcRuRcNd9tiaL vbHyK6vNP7FLLRiiuePC9LaWqfSSfvDlMCVzN5/dW7beNptJSTOj3Yk= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move a debug statement from qlafx00_error_entry() into its caller. Remove one unused argument from that function. This patch does not change the behavior of the qla2xxx driver. Cc: Himanshu Madhani Signed-off-by: Bart Van Assche Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mr.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b8f967e61891..60f964c53c01 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2681,12 +2681,10 @@ qlafx00_multistatus_entry(struct scsi_qla_host *vha, * @vha: SCSI driver HA context * @rsp: response queue * @pkt: Entry pointer - * @estatus: - * @etype: */ static void qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, - struct sts_entry_fx00 *pkt, uint8_t estatus, uint8_t etype) + struct sts_entry_fx00 *pkt) { srb_t *sp; struct qla_hw_data *ha = vha->hw; @@ -2695,9 +2693,6 @@ qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, struct req_que *req = NULL; int res = DID_ERROR << 16; - ql_dbg(ql_dbg_async, vha, 0x507f, - "type of error status in response: 0x%x\n", estatus); - req = ha->req_q_map[que]; sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); @@ -2745,9 +2740,11 @@ qlafx00_process_response_queue(struct scsi_qla_host *vha, if (pkt->entry_status != 0 && pkt->entry_type != IOCTL_IOSB_TYPE_FX00) { + ql_dbg(ql_dbg_async, vha, 0x507f, + "type of error status in response: 0x%x\n", + pkt->entry_status); qlafx00_error_entry(vha, rsp, - (struct sts_entry_fx00 *)pkt, pkt->entry_status, - pkt->entry_type); + (struct sts_entry_fx00 *)pkt); continue; }